12010-05-24 Ojan Vafai <ojan@chromium.org> 2 3 Reviewed by Eric Seidel. 4 5 add tests to ensure that --git-commit ranges are exclusive of the start of the range 6 https://bugs.webkit.org/show_bug.cgi?id=39612 7 8 * Scripts/webkitpy/common/checkout/scm_unittest.py: 9 102010-05-24 Eric Seidel <eric@webkit.org> 11 12 Reviewed by Adam Barth. 13 14 Add a temporary script for testing the html5 parser until it can run more layout tests 15 https://bugs.webkit.org/show_bug.cgi?id=39611 16 17 * Scripts/test-html5-parser: Added. 18 192010-05-24 Eric Seidel <eric@webkit.org> 20 21 Reviewed by Chris Jerdonek. 22 23 webkit-patch needs --verbose flag to enable DEBUG logging 24 https://bugs.webkit.org/show_bug.cgi?id=39208 25 26 I also added some code to print out how long commands take to run. 27 28 * Scripts/webkit-patch: 29 - Add hackish -v/--verbose parsing (similar to check-webkit-style) 30 * Scripts/webkitpy/common/system/executive.py: 31 - Log how long commands take to run. 32 * Scripts/webkitpy/tool/main.py: 33 - Add -v/--verbose option to global options. 34 352010-05-23 Eric Seidel <eric@webkit.org> 36 37 Reviewed by Daniel Bates. 38 39 Split PatchReader out into its own file 40 https://bugs.webkit.org/show_bug.cgi?id=39576 41 42 This is in preparation for making check-webkit-style 43 support being passed paths to patch files on the command line. 44 45 * Scripts/check-webkit-style: 46 * Scripts/webkitpy/style/checker.py: 47 * Scripts/webkitpy/style/checker_unittest.py: 48 * Scripts/webkitpy/style/patchreader.py: Added. 49 * Scripts/webkitpy/style/patchreader_unittest.py: Added. 50 * Scripts/webkitpy/style_references.py: 51 522010-05-23 Adam Barth <abarth@webkit.org> 53 54 Reviewed by Daniel Bates. 55 56 webkit-patch should let you add a comment when uploading a patch 57 https://bugs.webkit.org/show_bug.cgi?id=39552 58 59 As requested by Dan "the man" Bates. 60 61 * Scripts/webkitpy/tool/steps/options.py: 62 * Scripts/webkitpy/tool/steps/postdiff.py: 63 642010-05-23 Adam Barth <abarth@webkit.org> 65 66 Reviewed by Eric Seidel. 67 68 webkit-patch should assign newly created bugs to their creator 69 https://bugs.webkit.org/show_bug.cgi?id=39548 70 71 As requested on webkit-dev. 72 73 * Scripts/webkitpy/common/net/bugzilla.py: 74 752010-05-23 Adam Barth <abarth@webkit.org> 76 77 Reviewed by Eric Seidel. 78 79 Hide prepare and post commands for webkit-patch 80 https://bugs.webkit.org/show_bug.cgi?id=39539 81 82 It turns out these commands aren't very popular and they confuse new 83 users. They'll still be there for advanced users, however. 84 85 * Scripts/webkitpy/tool/commands/upload.py: 86 872010-05-23 Jesus Sanchez-Palencia <jesus@webkit.org> 88 89 Reviewed by Laszlo Gombos. 90 91 [Qt] QtTestBrowser has two graphicsview options that aren't enabled correctly 92 https://bugs.webkit.org/show_bug.cgi?id=39491 93 94 Making toggleResizesToContents and toggleTiledBackingStore checkable when 95 QtTestBrowser is started on graphics view mode. 96 97 * QtTestBrowser/main.cpp: 98 (LauncherWindow::createChrome): 99 1002010-05-23 Jesus Sanchez-Palencia <jesus@webkit.org> 101 102 Reviewed by Laszlo Gombos. 103 104 [Qt] QtTestBrowser is still called QtLauncher in the code 105 https://bugs.webkit.org/show_bug.cgi?id=39488 106 107 Finish the name change of QtLauncher to QtTestBrowser. 108 109 * QtTestBrowser/main.cpp: 110 (LauncherApplication::LauncherApplication): 111 (LauncherApplication::handleUserOptions): 112 * QtTestBrowser/mainwindow.cpp: 113 (MainWindow::MainWindow): 114 * QtTestBrowser/useragentlist.txt: 115 1162010-05-23 Marcus Bulach <bulach@chromium.org> 117 118 Reviewed by Kent Tamura. 119 120 [chromium] Adds Geolocation support to DumpRenderTree. 121 https://bugs.webkit.org/show_bug.cgi?id=39440 122 123 Existing LayoutTests/fast/dom/Geolocation/* should pass. 124 125 * DumpRenderTree/chromium/LayoutTestController.cpp: 126 (LayoutTestController::LayoutTestController): 127 (LayoutTestController::setGeolocationPermission): 128 (LayoutTestController::setMockGeolocationPosition): 129 (LayoutTestController::setMockGeolocationError): 130 * DumpRenderTree/chromium/LayoutTestController.h: 131 * DumpRenderTree/chromium/TestShell.cpp: 132 (TestShell::TestShell): 133 * DumpRenderTree/chromium/WebViewHost.cpp: 134 (WebViewHost::geolocationService): 135 * DumpRenderTree/chromium/WebViewHost.h: 136 1372010-05-22 Adam Barth <abarth@webkit.org> 138 139 Unreviewed. 140 141 Re-order Yong's email addresses because his gmail account is the one he 142 uses for bugs.webkit.org. 143 144 * Scripts/webkitpy/common/config/committers.py: 145 1462010-05-22 Daniel Bates <dbates@rim.com> 147 148 Reviewed by Chris Jerdonek. 149 150 Add infrastructure to parse SVN property changes 151 https://bugs.webkit.org/show_bug.cgi?id=38885 152 153 Adds function VCSUtils::parseSvnDiffFooter to parse an SVN footer 154 that consists of one or more properties. 155 156 Note, the first line of an SVN footer begins with "Property changes on". 157 158 * Scripts/VCSUtils.pm: 159 - Added function parseSvnDiffFooter. Will use this function 160 towards resolving Bug #39409 <https://bugs.webkit.org/show_bug.cgi?id=39409>. 161 - Removed FIXME comment above function parseSvnProperty, since 162 it is being used by parseSvnDiffFooter. 163 * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl: Added. 164 - Added unit tests. 165 1662010-05-22 Eric Seidel <eric@webkit.org> 167 168 Unreviewed, fixing test results only. 169 170 Disable compositing tests on the commit-queue as a workaround for bug 38912 171 https://bugs.webkit.org/show_bug.cgi?id=39067 172 173 * Scripts/webkitpy/tool/steps/steps_unittest.py: 174 - Update test results after my previous change. 175 1762010-05-22 Eric Seidel <eric@webkit.org> 177 178 Unreviewed. 179 180 Disable compositing tests on the commit-queue as a workaround for bug 38912 181 https://bugs.webkit.org/show_bug.cgi?id=39067 182 183 * Scripts/webkitpy/tool/steps/runtests.py: 184 - Disable all of compositing, not just compositing/iframes 185 1862010-05-22 Kent Tamura <tkent@chromium.org> 187 188 Reviewed by Dimitri Glazkov. 189 190 [DRT/Chromium] Link resources and load Ahem font for Windows 191 https://bugs.webkit.org/show_bug.cgi?id=39473 192 193 * DumpRenderTree/chromium/DumpRenderTree.cpp: 194 (main): Call platformInit(). 195 * DumpRenderTree/chromium/TestShell.h: 196 Declare platformInit(). It is not related to TestShell class, but the 197 implementation of paltformInit() is placed at TestShell*.{cpp,mm}. 198 * DumpRenderTree/chromium/TestShellGtk.cpp: 199 (platformInit): 200 * DumpRenderTree/chromium/TestShellMac.mm: 201 (platformInit): 202 * DumpRenderTree/chromium/TestShellWin.cpp: 203 (platformInit): 204 - Make stdout/stderr binary mode 205 - Load Ahem font 206 2072010-05-21 Eric Seidel <eric@webkit.org> 208 209 Unreviewed, EWS build fix only. 210 211 QueueStatusServer returns 500 error when EWS bots post empty queues 212 https://bugs.webkit.org/show_bug.cgi?id=39523 213 214 Mac python seems to have some built-in timezone support 215 however other python installs don't. So we need to ignore 216 timezones in our parsing. 217 218 Date parsing is tested by existing unit tests. 219 220 * QueueStatusServer/handlers/updateworkitems.py: 221 - Fix typo causing exception on server. 222 * Scripts/webkitpy/common/net/bugzilla.py: 223 - Fix exception due to python's lack of timezone support. 224 2252010-05-21 Eric Seidel <eric@webkit.org> 226 227 Reviewed by Adam Barth. 228 229 QueueStatusServer returns 500 error when EWS bots post empty queues 230 https://bugs.webkit.org/show_bug.cgi?id=39523 231 232 updateworkitems handler was raising an exception because 233 int() couldn't convert "" to a number. 234 235 I attempted to unit test this but we don't yet have a system by 236 which to load unit tests for appengine classes which depend on 237 google.appengine libraries which are not in the python default install. 238 239 We'll need to write a wrapper script to load those into the python path 240 and then run the unit test files. 241 242 * QueueStatusServer/handlers/statusbubble.py: 243 - Hide cr-win-ews since we're not currently running this bot. 244 * QueueStatusServer/handlers/updateworkitems.py: 245 - Fix the parsing logic to be able to understand "". 246 * Scripts/webkitpy/common/net/statusserver.py: 247 - Only log the work items posted to the server to the debug log channel. 248 2492010-05-21 Eric Seidel <eric@webkit.org> 250 251 Unreviewed, fixing the commit-queue to run again. 252 253 Make the EWSes report queue position in white bubbles 254 https://bugs.webkit.org/show_bug.cgi?id=39519 255 256 * Scripts/webkitpy/common/net/statusserver.py: 257 - Fix exception in _post_work_items_to_server when passed 258 integers. Unfortunately we have no good way to mock 259 the Browser object yet, and after several attempts I was 260 not able to create a good one, so no tests. :( 261 2622010-05-14 Ojan Vafai <ojan@chromium.org> 263 264 Reviewed by Eric Seidel. 265 266 webkit-patch land --squash commits too much if branch is not up to date 267 https://bugs.webkit.org/show_bug.cgi?id=38852 268 269 * Scripts/webkitpy/common/checkout/scm.py: 270 * Scripts/webkitpy/common/checkout/scm_unittest.py: 271 2722010-05-21 Eric Seidel <eric@webkit.org> 273 274 Reviewed by Adam Barth. 275 276 Make the EWSes report queue position in white bubbles 277 https://bugs.webkit.org/show_bug.cgi?id=39519 278 279 This also fixes sorting of commit-queue patches 280 to be in order of patch attachment. 281 https://bugs.webkit.org/show_bug.cgi?id=33395 282 283 This makes the various Queues post what patches they are about to process 284 so that we can display a list of patches on status server pages, as well 285 as report queue position in status bubbles. 286 287 This is the first step towards creating a control-channel for the queues. 288 Next step will be to have them read back the patches in order from the server 289 and finally we will add the ability for the server to control that order. 290 291 * Scripts/webkitpy/common/net/bugzilla.py: 292 - Teach bugzilla how to parse attach_date for attachments. 293 * Scripts/webkitpy/common/net/bugzilla_unittest.py: 294 - Test that we're parsing dates correctly. 295 This may have timezone issues for non-PST contributers, unsure. 296 * Scripts/webkitpy/common/net/statusserver.py: 297 - Post work items to the status server for display. 298 * Scripts/webkitpy/tool/bot/patchcollection.py: 299 - Call StatusServer.update_work_items 300 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 301 - Update unit test results now that we're posting work item list. 302 * Scripts/webkitpy/tool/commands/queues.py: 303 - Call StatusSever.update_work_items 304 - Sort patches so that the server's list understands 305 that the commit-queue gives priority to rollout patches. 306 - I also fixed patch sorting per bug 33395 while I was here. 307 * Scripts/webkitpy/tool/commands/queues_unittest.py: 308 - Update results after update_work_items changes. 309 - Test attachment sorting. 310 * Scripts/webkitpy/tool/mocktool.py: 311 - Add mock for update_work_items 312 3132010-05-21 Robin Cao <robin.cao@torchmobile.com.cn> 314 315 Reviewed by Adam Roben. 316 317 fast/dom/HTMLObjectElement/children-changed.html times out on Windows run-webkit-tests 318 https://bugs.webkit.org/show_bug.cgi?id=31315 319 320 * DumpRenderTree/win/FrameLoadDelegate.cpp: 321 (FrameLoadDelegate::didFailProvisionalLoadWithError): Need to invoke locationChangeDone here as mac port does. 322 3232010-05-20 Mark Rowe <mrowe@apple.com> 324 325 Rubber-stamped by Dan Bernstein. 326 327 <rdar://problem/7848154> Remove the dependency on Foundation's private __COCOA_FORMAL_PROTOCOLS_2__ define. 328 329 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 330 3312010-05-20 Tony Gentilcore <tonyg@chromium.org> 332 333 Reviewed by Daniel Bates. 334 335 Look in /proc/registry64 for the Platform SDK on 64-bit Windows. 336 https://bugs.webkit.org/show_bug.cgi?id=39296 337 338 The build-webkit script failed for me on Vista 64. A web search turned 339 up this blog post with a patch that worked for me: 340 http://www.nicholaswilson.me.uk/2010/04/hacking-webkit-fail/ 341 342 * Scripts/webkitdirs.pm: 343 3442010-05-20 Eric Seidel <eric@webkit.org> 345 346 Reviewed by Adam Barth. 347 348 ThreadedMessageQueue should use with_statement for exception safety 349 https://bugs.webkit.org/show_bug.cgi?id=39233 350 351 * Scripts/webkitpy/common/thread/threadedmessagequeue.py: 352 3532010-05-20 Diego Gonzalez <diegohcg@webkit.org> 354 355 Reviewed by Kenneth Rohde Christiansen. 356 357 [Qt] QtTestBrowser does not support websites which requires HTTP Authentication via dialogs 358 https://bugs.webkit.org/show_bug.cgi?id=38456 359 360 * QtTestBrowser/webpage.cpp: 361 (WebPage::WebPage): 362 (WebPage::authenticationRequired): 363 * QtTestBrowser/webpage.h: 364 3652010-05-20 Martin Robinson <mrobinson@igalia.com> 366 367 Reviewed by Eric Seidel. 368 369 editingBehavior settings needs to be set back to a reasonable default between tests 370 https://bugs.webkit.org/show_bug.cgi?id=39433 371 372 For now, hard code the default setting during reset, so that the serialized 373 version of the setting stays in sync with expectations. 374 375 * DumpRenderTree/mac/DumpRenderTree.mm: 376 (resetDefaultsToConsistentValues): Reset editing behavior to the appropriate platform default. 377 * DumpRenderTree/win/DumpRenderTree.cpp: 378 (resetDefaultsToConsistentValues): Ditto. 379 3802010-05-20 Brent Fulgham <bfulgham@webkit.org> 381 382 Build fix. No review. 383 384 The WebKitAPITest targets do not use the "_debug" suffix needed 385 by the WinCairo port. Added Debug_Cairo target to correct this. 386 387 * WebKitAPITest/WebKitAPITest.vcproj: 388 3892010-05-20 Martin Robinson <mrobinson@igalia.com> 390 391 Reviewed by Ojan Vafai. 392 393 editing/selection/extend-selection-after-double-click.html crashes on the Leopard Intel release bot 394 https://bugs.webkit.org/show_bug.cgi?id=39431 395 396 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 397 (LayoutTestController::setEditingBehavior): 398 Prevent a double-free by not having this variable be in the auto-release pool. 399 4002010-05-20 Martin Robinson <mrobinson@webkit.org> 401 402 Reviewed by Ojan Vafai. 403 404 Expose the editing behavior setting in DRT to test all editing code paths 405 https://bugs.webkit.org/show_bug.cgi?id=38603 406 407 * DumpRenderTree/LayoutTestController.cpp: 408 (setEditingBehaviorCallback): Added. 409 (LayoutTestController::staticFunctions): Expose the setEditingBehaviorCallback function. 410 * DumpRenderTree/LayoutTestController.h: 411 * DumpRenderTree/chromium/LayoutTestController.cpp: Add callback method for setting editing behavior. 412 * DumpRenderTree/chromium/LayoutTestController.h: Declaration for this method. 413 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 414 (LayoutTestController::setEditingBehavior): Implementation of editing behavior control. 415 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 416 (LayoutTestController::setEditingBehavior): Ditto 417 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 418 (LayoutTestController::setEditingBehavior): Added stub implementation of editing behavior control. 419 * DumpRenderTree/qt/LayoutTestControllerQt.h: 420 (LayoutTestController::setEditingBehavior): Add slot for controlling editor behavior. 421 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 422 (LayoutTestController::setEditingBehavior): Implementation of editing behavior control. 423 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 424 (LayoutTestController::setEditingBehavior): Added stub implementation of editing behavior control. 425 4262010-05-20 Kent Tamura <tkent@chromium.org> 427 428 Reviewed by Eric Seidel. 429 430 [DRT/Chromium] Increase the time out value 431 https://bugs.webkit.org/show_bug.cgi?id=39203 432 433 Change the time out value of Chromium DRT to 30 seconds, which is 434 the same as other ports. 435 If a DRT process exits before new-run-webkit-tests detects time 436 out, new-run-webkit-tests assumes the DRT process crashed. 437 438 * DumpRenderTree/chromium/TestShell.cpp: 439 (TestShell::layoutTestTimeout): 440 Change the time out value from 10 seconds to 30 seconds. 441 4422010-05-20 Chris Evans <cevans@google.com> 443 444 Unreviewed. 445 446 Marking myself as a committer. 447 448 * Scripts/webkitpy/common/config/committers.py: Add cevans@google.com. 449 4502010-05-20 Simon Hausmann <simon.hausmann@nokia.com> 451 452 Reviewed by Tor Arne Vestbo. 453 454 [Qt] Weekly binary builds on Mac OS X don't work when launched in the Finder 455 https://bugs.webkit.org/show_bug.cgi?id=37273 456 457 * QtTestBrowser/QtTestBrowser.pro: Build QtLauncher as bundle in package builds 458 4592010-05-20 Fumitoshi Ukai <ukai@chromium.org> 460 461 Unreviewed fix for websocket test failures. 462 463 * Scripts/new-run-webkit-websocketserver: 464 options is named parameter for factory.get(). 465 4662010-05-20 Fumitoshi Ukai <ukai@chromium.org> 467 468 Reviewed by Shinichiro Hamaji. 469 470 Chromium: Add --chromium option to new-run-webkit-websocketserver 471 https://bugs.webkit.org/show_bug.cgi?id=37664 472 473 Missed to pass options to factory.get() in r59595 474 475 * Scripts/new-run-webkit-websocketserver: 476 Pass options to factory.get(). 477 4782010-05-19 Eric Seidel <eric@webkit.org> 479 480 Reviewed by Adam Roben. 481 482 WinEWS should build Debug instead of Release 483 https://bugs.webkit.org/show_bug.cgi?id=39242 484 485 This is a workaround for 486 https://bugs.webkit.org/show_bug.cgi?id=39197 487 Adam Roben and Brian Weinstein believe this may 488 also make building faster since Debug builds 489 take less time to link. 490 491 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 492 4932010-05-19 Dirk Pranke <dpranke@chromium.org> 494 495 Unreviewed, build fix. 496 497 * DumpRenderTree/chromium/NotificationPresenter.cpp: 498 (NotificationPresenter::show): 499 5002010-05-19 Eric Seidel <eric@webkit.org> 501 502 Reviewed by Adam Barth. 503 504 user.py throws exception when readline module is missing 505 https://bugs.webkit.org/show_bug.cgi?id=39239 506 507 * Scripts/webkitpy/common/system/user.py: 508 - The error handling path requires the "sys" module, 509 so added an import sys at the top of the file. 510 5112010-05-18 Kent Tamura <tkent@chromium.org> 512 513 Reviewed by Dimitri Glazkov. 514 515 [DRT/Chromium] Fix a repaint issue and textarea tests 516 https://bugs.webkit.org/show_bug.cgi?id=39054 517 518 * DumpRenderTree/chromium/WebViewHost.cpp: 519 (WebViewHost::canvas): Remove m_paintRect initialization in canvas(). 520 This line updated m_paintRect unexpectedly during paintRect(). 521 We don't need to initialize m_paintRect because show() does it. 522 5232010-05-18 Tony Chang <tony@chromium.org> 524 525 Reviewed by Kent Tamura. 526 527 [chromium] new-run-webkit-tests --use-drt should run on Linux 528 https://bugs.webkit.org/show_bug.cgi?id=37845 529 530 * Scripts/webkitpy/layout_tests/port/chromium.py: 531 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 532 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 533 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 534 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 535 5362010-05-18 Kent Tamura <tkent@chromium.org> 537 538 Reviewed by Dimitri Glazkov. 539 540 [DRT/Chromium] Fix some initialization/reset issues 541 https://bugs.webkit.org/show_bug.cgi?id=39281 542 543 * DumpRenderTree/chromium/LayoutTestController.cpp: 544 (LayoutTestController::reset): Reset m_userStyleSheetLocation. 545 * DumpRenderTree/chromium/LayoutTestController.h: 546 Remove unused variable, m_workQueueFrozen. 547 (LayoutTestController::WorkQueue::WorkQueue): Initialize m_frozen. 548 * DumpRenderTree/chromium/TestShell.cpp: 549 (TestShell::resetTestController): Reset WebSettings too. 550 5512010-05-18 Dirk Pranke <dpranke@chromium.org> 552 553 Reviewed by Ojan Vafai. 554 555 new-run-webkit-tests: implement '--reset-results' flag to complement 556 the '--new-baseline' flag. '--new-baseline' will always write the 557 results into the platform directory; '--reset-results' will update the 558 existing baseline wherever it happens to be. Both sets of behavior 559 are useful in different circumstances. 560 561 https://bugs.webkit.org/show_bug.cgi?id=38879 562 563 * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Added. 564 * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Added. 565 * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Added. 566 * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Added. 567 * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Added. 568 * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Added. 569 * Scripts/webkitpy/layout_tests/data/misc/crash.html: Added. 570 * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Added. 571 * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Added. 572 * Scripts/webkitpy/layout_tests/data/misc/passing.html: Added. 573 * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Added. 574 * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Added. 575 * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Added. 576 * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt: Added. 577 * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Added. 578 * Scripts/webkitpy/layout_tests/data/text/article-element.html: Added. 579 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 580 * Scripts/webkitpy/layout_tests/port/test.py: 581 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 582 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 583 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 584 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 585 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 586 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 587 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 588 * Scripts/webkitpy/layout_tests/port/test.py: 589 * Scripts/webkitpy/layout_tests/port/dryrun.py: 590 5912010-05-18 Eric Seidel <eric@webkit.org> 592 593 Reviewed by Adam Roben. 594 595 Add an --html5-parser option to DumpRenderTree to allow testing the new HTML5Lexer 596 https://bugs.webkit.org/show_bug.cgi?id=39311 597 598 This flag allows us to run the new HTML5Lexer code. 599 Right now all documents parse as empty documents, but 600 now that we're able to run the code we can fix that. 601 602 Once we're able to lex a few basic documents I'll add 603 an --html5-parser flag to run-webkit-tests so that we test 604 running all of the layout tests with the HTML5 parser. 605 606 * DumpRenderTree/mac/DumpRenderTree.mm: 607 (resetDefaultsToConsistentValues): 608 (initializeGlobalsFromCommandLineOptions): 609 6102010-05-08 Robert Hogan <robert@roberthogan.net> 611 612 Reviewed by Simon Hausmann. 613 614 [Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html 615 and http/tests/xmlhttprequest/cross-origin-authorization.html 616 617 QHttpNetworkRequest adds Authorization and Cookie headers to XHRs 618 without knowing if this is valid behaviour or not. In order to allow 619 Qt to decide whether Cookie/Authorization headers should be added 620 to an XHR QtWebKit needs to use an attribute added to QNetworkRequest. 621 These new attributes are: QNetworkRequest::CookieLoadControlAttribute, 622 QNetworkRequest::CookieSaveControlAttribute,and 623 QNetworkRequest::AuthenticationReuseControlAttribute. 624 625 In order to properly support the tests, Qt's DRT needs to use one 626 NetworkAccessManager for all pages. This allows it to use cached 627 credentials where appropriate. 628 629 The tests now pass when run individually but there seems to be a problem with 630 leaking the results of requests across tests when run with the others in 631 http/tests. This will be addressed in a separate patch. 632 633 https://bugs.webkit.org/show_bug.cgi?id=32967 634 635 636 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 637 (WebCore::WebPage::WebPage): 638 (WebCore::DumpRenderTree::DumpRenderTree): 639 * DumpRenderTree/qt/DumpRenderTreeQt.h: 640 641 6422010-05-18 Fumitoshi Ukai <ukai@chromium.org> 643 644 Reviewed by Eric Seidel. 645 646 run_webkit_tests_unittest fails on SnowLeopard 647 https://bugs.webkit.org/show_bug.cgi?id=39279 648 649 * Scripts/webkitpy/layout_tests/port/base.py: 650 Return copy of os.environ. 651 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 652 Check os.environ was not modified. 653 6542010-05-18 Fumitoshi Ukai <ukai@chromium.org> 655 656 Reviewed by Eric Seidel. 657 658 Chromium: new-run-webkit-httpd fails to setup_mount 659 https://bugs.webkit.org/show_bug.cgi?id=39257 660 661 * Scripts/webkitpy/common/system/executive.py: 662 Assert type of args in run_command. 663 * Scripts/webkitpy/common/system/executive_unittest.py: 664 Add test_run_command_args_type 665 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 666 Executive.run_command takes array for command line. 667 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 668 Test if setup_environ_for_server() run setup_mount.bat. 669 6702010-05-17 Kent Tamura <tkent@chromium.org> 671 672 Reviewed by David Levin. 673 674 Chromium Windows build system does not rebuild correctly when 675 enabling/disabling a feature 676 https://bugs.webkit.org/show_bug.cgi?id=38926 677 678 Add a workaround of this issue. 679 680 * Scripts/update-webkit: 681 Chromium-Windows only: If WebKit/chromium/features.gyp has been 682 updated, remove WebKit/chromium/Debug and WebKit/chromium/Release. 683 6842010-05-17 Sheriff Bot <webkit.review.bot@gmail.com> 685 686 Unreviewed, rolling out r59631. 687 http://trac.webkit.org/changeset/59631 688 https://bugs.webkit.org/show_bug.cgi?id=39255 689 690 chromium canaries can no longer run webkit_tests, suspect this 691 change. (Requested by atwilson on #webkit). 692 693 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 694 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 695 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 696 6972010-05-17 Eric Seidel <eric@webkit.org> 698 699 Reviewed by Adam Barth. 700 701 Attempt to make new-run-webkit-tests --help more sane 702 https://bugs.webkit.org/show_bug.cgi?id=37836 703 704 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 705 - Add a FIXME about options.singly and options.batch_size being different. 706 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 707 - Add support for hidden options. 708 - Add option groupings to attempt to simplify --help. 709 - Fix a bunch of option helps to start with a capitalized verb. 710 - Hide a bunch of options which make no sense to users. 711 - Sort options in --help. 712 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 713 - Add tests for option sorting. 714 7152010-05-17 Robert Hogan <robert@webkit.org> 716 717 Reviewed by Kenneth Rohde Christiansen. 718 719 [Qt] Disable Icon Database by default in Qt DRT 720 721 Unskip: 722 http/tests/misc/favicon-loads-with-images-disabled.html 723 http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html 724 http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html 725 http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html 726 727 https://bugs.webkit.org/show_bug.cgi?id=37382 728 729 Add support for layoutTestController.setIconDatabaseEnabled and layoutTestController.disableImageLoading(). 730 The XFrameOptions tests were failing because of an extra resource load callback for favicon.ico requests. 731 These extra callbacks are removed by supporting both of the above layoutTestContoller commands. 732 733 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 734 (WebCore::WebPage::resetSettings): 735 (WebCore::DumpRenderTree::DumpRenderTree): 736 * DumpRenderTree/qt/DumpRenderTreeQt.h: 737 (WebCore::DumpRenderTree::drtStoragePath): 738 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 739 (LayoutTestController::reset): 740 (LayoutTestController::disableImageLoading): 741 (LayoutTestController::setIconDatabaseEnabled): 742 * DumpRenderTree/qt/LayoutTestControllerQt.h: 743 7442010-05-17 Fumitoshi Ukai <ukai@chromium.org> 745 746 Reviewed by Eric Seidel. 747 748 Chromium: Add --chromium option to new-run-webkit-websocketserver 749 https://bugs.webkit.org/show_bug.cgi?id=37664 750 751 os.environ setup and setup_mount for cygwin are moved in ChromiumWinPort.setup_environ_for_server. 752 753 * Scripts/new-run-webkit-httpd: 754 Remove passing register_cygwin. 755 * Scripts/new-run-webkit-websocketserver: 756 Add --chromium flag. 757 Remove passing register_cygwin. 758 Create port object using options. 759 * Scripts/webkitpy/layout_tests/port/base.py: 760 Add setup_environ_for_server(). 761 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 762 Ditto. 763 * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Added. 764 * Scripts/webkitpy/layout_tests/port/http_server.py: 765 Remove register_cygwin_parameter. 766 Call setup_environ_for_server(). 767 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 768 Ditto. 769 7702010-05-16 Daniel Bates <dbates@rim.com> 771 772 Reviewed by Chris Jerdonek. 773 774 https://bugs.webkit.org/show_bug.cgi?id=39184 775 776 Adds function VCSUtils::parseSvnProperty to parse an SVN property with 777 either a single-line or multi-line value change. 778 779 * Scripts/VCSUtils.pm: 780 - Added function parseSvnProperty. We will use this function 781 towards resolving Bug #38885 <https://bugs.webkit.org/show_bug.cgi?id=38885>. 782 - Removed FIXME comment above function parseSvnPropertyValue, since 783 it is being used by parseSvnProperty. 784 - Modified function parseSvnPropertyValue to break out of "while (<$fileHandle>)" 785 loop when it encounters the start of the next property so that it can be 786 processed by its caller, parseSvnPropertyValue. We reference this bullet below 787 by (*). 788 * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Added. 789 - Added unit tests. 790 * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl: 791 - Changed the name of the unit test "simple multi-line '-' change" to 792 "single-line '-' change followed by empty line" since the former was an 793 incorrect description of this test. 794 - Added unit test "single-line '-' change followed by the next property", and 795 "multi-line '-' change followed by the next property" to test (*) above. 796 7972010-05-16 Tony Chang <tony@chromium.org> 798 799 Not reviewed, fixing layout test. 800 801 Don't output Inspect Element since this is not enabled on the bots, 802 but most developers probably have it installed. 803 804 * DumpRenderTree/mac/EventSendingController.mm: 805 (-[EventSendingController contextClick:]): 806 8072010-05-12 Tony Chang <tony@chromium.org> 808 809 Reviewed by Darin Adler. 810 811 Spellcheck disabling does not disable context menu 812 https://bugs.webkit.org/show_bug.cgi?id=25639 813 814 * DumpRenderTree/mac/EventSendingController.mm: 815 (+[EventSendingController isSelectorExcludedFromWebScript:]): 816 (+[EventSendingController webScriptNameForSelector:]): 817 (-[EventSendingController contextClick:]): add a bool parameter that 818 when true, dumps the context menu items to stdout. 819 8202010-05-16 Robert Hogan <robert@webkit.org> 821 822 Reviewed by Kenneth Rohde Christiansen. 823 824 [Qt] Unskip fast/loader/main-document-url-for-non-http-loads.html 825 826 Update Qt DRT to use frame loader, editor client and notification presenter 827 functions in DumpRenderTreeSupportQt. 828 829 https://bugs.webkit.org/show_bug.cgi?id=38867 830 831 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 832 (WebCore::DumpRenderTree::open): 833 (WebCore::DumpRenderTree::dump): 834 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 835 (LayoutTestController::LayoutTestController): 836 (LayoutTestController::reset): 837 (LayoutTestController::dumpEditingCallbacks): 838 (LayoutTestController::dumpFrameLoadCallbacks): 839 (LayoutTestController::dumpResourceLoadCallbacks): 840 (LayoutTestController::setWillSendRequestReturnsNullOnRedirect): 841 (LayoutTestController::setWillSendRequestReturnsNull): 842 (LayoutTestController::setWillSendRequestClearHeader): 843 8442010-05-16 Eric Seidel <eric@webkit.org> 845 846 Unreviewed, rolling out r59571. 847 http://trac.webkit.org/changeset/59571 848 https://bugs.webkit.org/show_bug.cgi?id=39054 849 850 Broke Cr Win, but we didn't notice immediately due to 851 https://bugs.webkit.org/show_bug.cgi?id=38926. It's possible 852 that this didn't actually break Cr Win, but rather that bug 853 38926 necessitates a clean compile after this and sucessive 854 checkins only produced a partial recompile and thus failed to 855 build. 856 857 * DumpRenderTree/chromium/WebViewHost.cpp: 858 (WebViewHost::canvas): 859 8602010-05-16 Robert Hogan <robert@webkit.org> 861 862 Reviewed by Kenneth Rohde Christiansen. 863 864 [Qt]Unskip security/set-form-autocomplete-attribute.html 865 866 Add support for layoutTestController.elementDoesAutoCompleteForElementWithId(). 867 868 https://bugs.webkit.org/show_bug.cgi?id=38859 869 870 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 871 (LayoutTestController::elementDoesAutoCompleteForElementWithId): 872 * DumpRenderTree/qt/LayoutTestControllerQt.h: 873 8742010-05-16 Kent Tamura <tkent@chromium.org> 875 876 Reviewed by Dimitri Glazkov. 877 878 [DRT/Chromium] Fix repaint, WebGL, textarea tests 879 https://bugs.webkit.org/show_bug.cgi?id=39054 880 881 * DumpRenderTree/chromium/WebViewHost.cpp: 882 (WebViewHost::canvas): Remove m_paintRect initialization in canvas(). 883 This line updated m_paintRect unexpectedly during paintRect(). 884 We don't need to initialize m_paintRect because show() does it. 885 8862010-05-16 Sergio Villar Senin <svillar@igalia.com> 887 888 Reviewed by Gustavo Noronha Silva. 889 890 [GTK] Improve reporting of frame loader callbacks in DRT 891 https://bugs.webkit.org/show_bug.cgi?id=36454 892 893 * DumpRenderTree/gtk/DumpRenderTree.cpp: 894 (webViewLoadStatusNotified): 895 (createWebView): added connection to notify::load-status and 896 signal callback 897 8982010-05-15 Daniel Bates <dbates@rim.com> 899 900 Reviewed by Chris Jerdonek. 901 902 https://bugs.webkit.org/show_bug.cgi?id=39170 903 904 Add function parseSvnPropertyValue to parse single-line and multi-line 905 property values of an SVN property change. 906 907 * Scripts/VCSUtils.pm: 908 Added function parseSvnPropertyValue. We will use this as part of 909 Bug #38885 <https://bugs.webkit.org/show_bug.cgi?id=38885>. 910 * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl: Added. 911 9122010-05-15 Jochen Eisinger <jochen@chromium.org> 913 914 Reviewed by Dmitry Titov. 915 916 Add allowDatabase method to TestWebWorker. 917 https://bugs.webkit.org/show_bug.cgi?id=38742 918 919 * DumpRenderTree/chromium/TestWebWorker.h: 920 (TestWebWorker::allowDatabase): 921 9222010-05-15 Simon Hausmann <simon.hausmann@nokia.com> 923 924 Rubber-stamped by Antti Koivisto. 925 926 [Qt] Rename QtLauncher to QtTestBrowser 927 https://bugs.webkit.org/show_bug.cgi?id=37665 928 929 Forgot to remove the original directory after the rename. 930 931 * QtLauncher: Removed. 932 9332010-05-15 Sheriff Bot <webkit.review.bot@gmail.com> 934 935 Unreviewed, rolling out r59544. 936 http://trac.webkit.org/changeset/59544 937 https://bugs.webkit.org/show_bug.cgi?id=39165 938 939 Cased LayoutTest to start crashing (Requested by abarth on 940 #webkit). 941 942 * Scripts/old-run-webkit-tests: 943 9442010-05-15 Mario Sanchez Prada <msanchez@igalia.com> 945 946 Reviewed by Xan Lopez. 947 948 Ensure DRT loads GAIL (Gtk+ module), for a11y tests 949 https://bugs.webkit.org/show_bug.cgi?id=38648 950 951 Add the GTK_MODULES envvar (set to "gail") to the clean 952 environment when running DRT for the Gtk+ port 953 954 * Scripts/old-run-webkit-tests: 955 9562010-05-15 Eric Seidel <eric@webkit.org> 957 958 Reviewed by Maciej Stachowiak. 959 960 Add script to check for minimum python version and install if missing on Tiger 961 https://bugs.webkit.org/show_bug.cgi?id=38886 962 963 Per Maciej's request on webkit-dev: 964 https://lists.webkit.org/pipermail/webkit-dev/2010-May/012785.html 965 provide a script which can automatically install Python on Tiger where 966 the system provided version is too old to be of use. 967 968 Note this uses the official Mac Python installer from python.org. 969 This installs a copy of Python in /Library/Frameworks/Python.framework. 970 It also makes symlinks from /usr/local/bin to the Python.framework/bin. 971 972 I have tested this script on Leopard and it worked fine. I have not 973 tested it on Tiger as I do not have access to a Tiger machine. In 974 either case this should provide a great starting point for someone 975 wishing to upgrade their copy of Python on Tiger. 976 977 Future patches can make our scripts depend on a success return from this 978 script and then they can either skip tests/sections for which python is 979 insufficient, or they can fail themselves. 980 981 * Scripts/ensure-valid-python: Added. 982 9832010-05-15 Eric Seidel <eric@webkit.org> 984 985 Reviewed by Adam Barth. 986 987 Display queue position inside EWS bubbles 988 https://bugs.webkit.org/show_bug.cgi?id=38979 989 990 This ended up being a lot of clean-up to our status server code. 991 992 Added a new WorkItems model, a form with which to fill it, 993 and taught the Attachment class how to calculate the current queue 994 postion for an attachment using the data in WorkItems. 995 996 I also finally made statusbubble.* and dashboard.* not use copy-paste code. 997 998 The Attachment class has this summary() method which is very 999 controller/view-like and does not belong in a model class. 1000 This patch got rid of all direct uses of summary(). 1001 1002 * QueueStatusServer/handlers/dashboard.py: 1003 - Build row objects to hand off to the view instead of handing off a 1004 summary object and expecting the view to process it directly. 1005 * QueueStatusServer/handlers/statusbubble.py: 1006 - Build bubble object and hand them off to the view. 1007 * QueueStatusServer/handlers/updatestatus.py: 1008 - Code cleanup. Just move some code into _queue_status_from_request 1009 to make the main put() handler easier to read. 1010 * QueueStatusServer/handlers/updateworkitems.py: Added. 1011 - Controller to handle storing WorkItems model objects. 1012 * QueueStatusServer/main.py: 1013 - Add route for /update-work-items 1014 * QueueStatusServer/model/attachment.py: 1015 - Add new methods to replace direct summary() access. 1016 - Teach attachment how to calculate queue positions from WorkItems data. 1017 * QueueStatusServer/model/queues.py: 1018 - Move name_with_underscores here for easier re-use. 1019 * QueueStatusServer/model/workitems.py: Added. 1020 - New model for storing what items are currently queue for any bot. 1021 * QueueStatusServer/templates/dashboard.html: 1022 - Kill the copy/paste code! 1023 * QueueStatusServer/templates/statusbubble.html: 1024 - Kill the copy/paste code! 1025 * QueueStatusServer/templates/updateworkitems.html: Added. 1026 - Simple form for updating a queue's current work items. 1027 10282010-05-15 Joanmarie Diggs <joanmarie.diggs@gmail.com> 1029 1030 Reviewed by Xan Lopez. 1031 1032 https://bugs.webkit.org/show_bug.cgi?id=30500 1033 [Gtk] Find a way for WebKit to "announce" itself so that ATs can readily distinguish it from true Gtk/Gail 1034 1035 The "announcement" is now made in the form of an object attribute 1036 associated with the AtkObject. 1037 1038 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 1039 (AccessibilityUIElement::allAttributes): 1040 (attributeSetToString): 1041 10422010-05-15 Mario Sanchez Prada <msanchez@igalia.com> 1043 1044 Reviewed by Xan Lopez. 1045 1046 Accessibility: Implement isSelected in DRT for GTK 1047 https://bugs.webkit.org/show_bug.cgi?id=31018 1048 1049 Implement AccessibilityUIElement::isSelected() for Gtk 1050 1051 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 1052 (AccessibilityUIElement::isSelected): 1053 10542010-05-14 Adam Barth <abarth@webkit.org> 1055 1056 Reviewed by Eric Seidel. 1057 1058 scm.py should use self.run instead of run_command 1059 https://bugs.webkit.org/show_bug.cgi?id=38957 1060 1061 We've wanted to do this for a while, but it's a prerequiste for running 1062 SVN from the cwd instead of the checkout_root. 1063 1064 * Scripts/webkitpy/common/checkout/scm.py: 1065 10662010-05-14 Anton Muhin <antonm@chromium.org> 1067 1068 Reviewed by Darin Fisher. 1069 1070 [Chromium] Consider implementing addOriginAccessWhitelistEntry method 1071 https://bugs.webkit.org/show_bug.cgi?id=37578 1072 1073 Remove deprecated methods. 1074 1075 * DumpRenderTree/chromium/LayoutTestController.cpp 1076 * DumpRenderTree/chromium/LayoutTestController.h 1077 10782010-05-14 Kenneth Russell <kbr@google.com> 1079 1080 Reviewed by Darin Adler. 1081 1082 Rename WebGLArray types to TypedArray types 1083 https://bugs.webkit.org/show_bug.cgi?id=39091 1084 1085 Extended functionality of do-webcore-rename script and used it to 1086 rename the WebGLArray types to the TypedArray naming convention. 1087 The only source files which were touched by hand, and which are 1088 being manually reviewed, are: 1089 WebCore/page/DOMWindow.idl 1090 WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone) 1091 WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp 1092 WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 1093 These only needed to be touched to update the aliases between the 1094 WebGLArray and TypedArray names introduced in bug 39036. (It was 1095 not feasible to have do-webcore-rename handle this as it would 1096 introduce circular renamings.) These aliases will be removed in 1097 roughly a month once existing WebGL content has been updated. 1098 1099 No new tests; covered under existing WebGL tests. Updated 1100 constructed-objects-prototypes and prototype-inheritance-2 tests. 1101 Ran all layout tests in Safari and all WebGL tests in Chromium. 1102 1103 * Scripts/do-webcore-rename: 1104 Handle the case where some renames are substrings of others. 1105 Support renaming files containing custom JS bindings. If 1106 isDOMTypeRename is non-zero, expand the regexp which rewrites 1107 the file's contents in order to support custom JS bindings. 1108 11092010-05-14 Eric Seidel <eric@webkit.org> 1110 1111 Reviewed by Adam Barth. 1112 1113 webkit-patch rollout throws exception if bug is already open 1114 https://bugs.webkit.org/show_bug.cgi?id=38803 1115 1116 This was caused by someone incorrectly wrapping the code. :p 1117 I'm going to have to start demanding unit tests for wrapping changes... 1118 1119 I also fixed the code to be able to reopen bugs which were never confirmed. 1120 Before it regressed, the code would just log in that case. Now it actually 1121 will reopen the bug, but there is a FIXME about how the logic is a bit backwards. 1122 1123 * Scripts/webkitpy/common/net/bugzilla.py: 1124 * Scripts/webkitpy/common/net/bugzilla_unittest.py: 1125 - Yay testing! 1126 11272010-05-14 Simon Hausmann <simon.hausmann@nokia.com> 1128 1129 Rubber-stamped by Antti Koivisto. 1130 1131 [Qt] Rename QtLauncher to QtTestBrowser 1132 1133 * QtTestBrowser: Copied from WebKitTools/QtLauncher. 1134 * QtTestBrowser/QtLauncher.pro: Removed. 1135 * QtTestBrowser/QtLauncher.qrc: Removed. 1136 * QtTestBrowser/QtTestBrowser.pro: Copied from WebKitTools/QtLauncher/QtLauncher.pro. 1137 * QtTestBrowser/QtTestBrowser.qrc: Copied from WebKitTools/QtLauncher/QtLauncher.qrc. 1138 * Scripts/run-launcher: 1139 * Scripts/webkitdirs.pm: 1140 11412010-05-14 Adam Barth <abarth@webkit.org> 1142 1143 Reviewed by Eric Seidel. 1144 1145 Stop CCing webkit-bot-watchers 1146 https://bugs.webkit.org/show_bug.cgi?id=39020 1147 1148 webkit-bot-watchers is somewhat of a failed experiment. No one 1149 subscribed to the list (not even me). Removing it from the code 1150 because wms says it bounces email sometimes. 1151 1152 * Scripts/webkitpy/tool/commands/queues.py: 1153 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 1154 11552010-05-14 Eric Seidel <eric@webkit.org> 1156 1157 Reviewed by Adam Barth. 1158 1159 REGRESSION: webkit-patch commit-message throws exception 1160 https://bugs.webkit.org/show_bug.cgi?id=38997 1161 1162 * Scripts/webkitpy/tool/commands/upload.py: 1163 - Fix to respect and pass the --squash and --git-commit options. 1164 * Scripts/webkitpy/tool/commands/upload_unittest.py: 1165 - Fix the unit test to use the central MockCheckout instead of 1166 its own custom Mock which didn't require enough parameters. 1167 11682010-05-13 Diego Gonzalez <diegohcg@webkit.org> 1169 1170 Reviewed by Kenneth Rohde Christiansen. 1171 1172 [Qt] Improve QtLauncher user agent dialog resize 1173 https://bugs.webkit.org/show_bug.cgi?id=39062 1174 1175 * QtLauncher/main.cpp: 1176 (LauncherWindow::showUserAgentDialog): 1177 11782010-05-13 Eric Seidel <eric@webkit.org> 1179 1180 Reviewed by Ojan Vafai. 1181 1182 Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912 1183 https://bugs.webkit.org/show_bug.cgi?id=39067 1184 1185 Fix yet another typo in my original hack. 1186 I also added another unit test for this fix. 1187 1188 * Scripts/webkitpy/common/config/ports.py: 1189 * Scripts/webkitpy/common/config/ports_unittest.py: 1190 11912010-05-13 Eric Seidel <eric@webkit.org> 1192 1193 Reviewed by Ojan Vafai. 1194 1195 Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912 1196 https://bugs.webkit.org/show_bug.cgi?id=39067 1197 1198 My previous (unreviewed) hack didn't actually work due to checking "mac" instead of "Mac". 1199 This change fixes my hack, and unit tests it. 1200 1201 * Scripts/webkitpy/tool/mocktool.py: 1202 - Make it possible to make run_command log too. 1203 * Scripts/webkitpy/tool/steps/runtests.py: 1204 - Fix my hack to actually work. 1205 * Scripts/webkitpy/tool/steps/steps_unittest.py: 1206 - Test my hack (and basic RunTests behavior as well). 1207 12082010-05-13 Antonio Gomes <tonikitoo@webkit.org>, Yi Shen <yi.4.shen@nokia.com> 1209 1210 Reviewed by Kenneth Christiansen. 1211 1212 [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo 1213 https://bugs.webkit.org/show_bug.cgi?id=37759 1214 1215 WebKitTools: 1216 1217 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 1218 (LayoutTestController::computedStyleIncludingVisitedInfo): 1219 * DumpRenderTree/qt/LayoutTestControllerQt.h: 1220 12212010-05-10 Adam Roben <aroben@apple.com> 1222 1223 Convert status bar text to UTF-8 before logging it on Windows 1224 1225 We were previously logging the text using printf("%S", bstr). This 1226 converts the UTF-16 BSTR to a multibyte string using wctomb, which 1227 uses the codepage for the current locale to perform the conversion. 1228 The conversion was failing, causing printf to bail and truncate the 1229 string. By converting to UTF-8 manually before logging, we avoid this 1230 issue (and also end up with UTF-8 output, which is what the expected 1231 results contain). We may have to do this in other places in DRT, 1232 eventually. 1233 1234 Fixes <http://webkit.org/b/38849> REGRESSION (r59016): 1235 plugins/set-status.html fails on Windows 1236 1237 Reviewed by Alexey Proskuryakov. 1238 1239 * DumpRenderTree/win/DumpRenderTree.cpp: 1240 (toUTF8): Moved this here from FrameLoadDelegate. Renamed from 1241 BSTRtoString. 1242 1243 * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of toUTF8. 1244 1245 * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed BSTRtoString. 1246 (descriptionSuitableForTestResult): Updated for rename. 1247 1248 * DumpRenderTree/win/UIDelegate.cpp: 1249 (UIDelegate::setStatusText): Convert the status bar text to UTF-8 1250 before logging it so that Windows won't try (and fail) to convert it 1251 to the current locale's codepage. 1252 12532010-05-13 Eric Seidel <eric@webkit.org> 1254 1255 Unreviewed hack, attempting to get the commit-queue running again. 1256 1257 Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912 1258 https://bugs.webkit.org/show_bug.cgi?id=39067 1259 1260 I had this hack locally on the commit-queue, but it's fragile 1261 and broke this morning. It will work much better if committed 1262 to the repository. In either case it's temporary while we 1263 work up a real fix for bug 38912. 1264 1265 * Scripts/webkitpy/common/config/ports.py: 1266 - Expose an is_leopard() method. 1267 * Scripts/webkitpy/tool/steps/runtests.py: 1268 - Don't run compositing/iframes tests on the commit-queue under leopard. 1269 12702010-05-13 Fumitoshi Ukai <ukai@chromium.org> 1271 1272 Unreviewed fix. Revert previous change. 1273 1274 Even if with-statments are changed in websocket_server.py, it also claims syntax error for with statement in http_server.py. 1275 Until python 2.5 is installed on tiger bot, skips websocket/tests on tiger. 1276 1277 * Scripts/webkitpy/layout_tests/port/websocket_server.py: use with statement 1278 12792010-05-13 Fumitoshi Ukai <ukai@chromium.org> 1280 1281 Unreviewed fix. 1282 1283 On tiger bot, it claims syntax error for with statement. 1284 1285 * Scripts/webkitpy/layout_tests/port/websocket_server.py: rewrite with statement with try-finally. 1286 12872010-05-13 Fumitoshi Ukai <ukai@chromium.org> 1288 1289 Reviewed by David Levin. 1290 1291 WebSocket: pywebsocket 0.5 1292 https://bugs.webkit.org/show_bug.cgi?id=38034 1293 1294 Remove pywebsocket from webkitpy/thirdparty. 1295 Make pywebsocket autoinstalled. 1296 1297 * Scripts/new-run-webkit-websocketserver: 1298 Add --output-dir option. 1299 * Scripts/old-run-webkit-tests: 1300 Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py 1301 * Scripts/run-webkit-websocketserver: 1302 Ditto. 1303 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 1304 Use autoinstalled pywebsocket. 1305 * Scripts/webkitpy/thirdparty/__init__.py: 1306 Autoinstall pywebsocket 1307 * Scripts/webkitpy/thirdparty/pywebsocket: Removed. 1308 13092010-05-12 Chris Jerdonek <cjerdonek@webkit.org> 1310 1311 Reviewed by Daniel Bates. 1312 1313 Fixed a bug in svn-apply whereby the reviewer would not get set if 1314 the portion of the patch for the ChangeLog contains "NOBODY (**PS!)" 1315 in the leading junk. 1316 1317 https://bugs.webkit.org/show_bug.cgi?id=38998 1318 1319 * Scripts/VCSUtils.pm: 1320 - Added the $changeLogTimeZone variable from svn-apply. 1321 - Added setChangeLogDateAndReviewer() from svn-apply. 1322 - Added a localTimeInProjectTimeZone() subroutine. 1323 - In setChangeLogDateAndReviewer(): 1324 - Added an $epochTime parameter to make the subroutine more testable. 1325 - Made the "NOBODY (**PS!)" regular expression more specific so that 1326 it will not apply to text in the leading junk. 1327 - Updated to call localTimeInProjectTimeZone(). 1328 * Scripts/svn-apply: 1329 - Removed the $changeLogTimeZone file variable. 1330 - Added an $epochTime file variable to represent the current time. 1331 - Removed the setChangeLogDateAndReviewer() subroutine. 1332 - Updated patch() to use the new setChangeLogDateAndReviewer() syntax. 1333 * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl: Added. 1334 - Added unit tests. 1335 13362010-05-12 Eric Seidel <eric@webkit.org> 1337 1338 Reviewed by Adam Barth. 1339 1340 test-webkitpy fails on windows due to lack of readline module 1341 https://bugs.webkit.org/show_bug.cgi?id=38884 1342 1343 Win32 Python does not have a readline module, so we should 1344 not exit(1) if the import fails. 1345 1346 Also the failure message is mac-specific and doesn't need to be. 1347 Only print the mac-specific install instructions on mac. 1348 1349 * Scripts/webkitpy/common/system/user.py: 1350 13512010-05-12 Kent Tamura <tkent@chromium.org> 1352 1353 Reviewed by Nate Chapin. 1354 1355 [DRT/Chromium] Add a missing Sans-serif font setting 1356 https://bugs.webkit.org/show_bug.cgi?id=38981 1357 1358 * DumpRenderTree/chromium/TestShell.cpp: 1359 (TestShell::resetWebSettings): 1360 Set "Helvetica" for Sans-serif. It is the same as the default setting of test_shell. 1361 13622010-05-10 Ojan Vafai <ojan@chromium.org> 1363 1364 Reviewed by Adam Barth. 1365 1366 webkit-patch upload --fancy-review now uses the bugzilla bug ID as the rietveld ID 1367 https://bugs.webkit.org/show_bug.cgi?id=38866 1368 1369 wkrietveld.appspot.com has already been updated to allow you to 1370 pass --issue for the issue creation as well as subsequent uploads. 1371 1372 Also, remove the extra code for trying to read out the issue ID 1373 from the changelog description since we just use the bugzilla ID now. 1374 1375 * Scripts/webkitpy/common/config/__init__.py: 1376 * Scripts/webkitpy/common/net/rietveld.py: 1377 * Scripts/webkitpy/tool/steps/postcodereview.py: 1378 * Scripts/webkitpy/tool/steps/postdiff.py: 1379 13802010-05-12 Ojan Vafai <ojan@chromium.org> 1381 1382 No review needed. 1383 1384 Marking myself as a reviewer. 1385 1386 * Scripts/webkitpy/common/config/committers.py: 1387 13882010-05-12 Dirk Pranke <dpranke@chromium.org> 1389 1390 Reviewed by Eric Seidel. 1391 1392 new-run-webkit-tests: add a --print default option so that you can 1393 easily get the default output plus something (e.g., you can say 1394 '--print default,config' instead of '--print misc,one-line-progress, 1395 one-line-summary,unexpected,unexpected-results,updates,config'. 1396 1397 Also, add more unit tests for --verbose, --print everything, etc. 1398 1399 https://bugs.webkit.org/show_bug.cgi?id=38877 1400 1401 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 1402 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 1403 14042010-05-12 Csaba Osztrogonác <ossy@webkit.org> 1405 1406 Reviewed by Adam Barth. 1407 1408 Qt build failures cause SheriffBot false positives 1409 https://bugs.webkit.org/show_bug.cgi?id=38969 1410 1411 Add Qt bots back to the core builders, because bug fixed by r59261. 1412 1413 * Scripts/webkitpy/common/net/buildbot.py: 1414 * Scripts/webkitpy/common/net/buildbot_unittest.py: 1415 14162010-05-12 Csaba Osztrogonác <ossy@webkit.org> 1417 1418 Reviewed by Kenneth Rohde Christiansen. 1419 1420 [Qt] Slave losts cause build break on bots 1421 https://bugs.webkit.org/show_bug.cgi?id=38980 1422 1423 * Scripts/build-webkit: Remove 0 byte sized files from productDir before build. 1424 14252010-05-12 Csaba Osztrogonác <ossy@webkit.org> 1426 1427 Unreviewed trivial fix after r59254. 1428 1429 * Scripts/old-run-webkit-tests: 1430 14312010-05-12 Csaba Osztrogonác <ossy@webkit.org> 1432 1433 Reviewed by Eric Seidel. 1434 1435 run-webkit-tests --exit-after-N-failures should not count new tests as failures 1436 https://bugs.webkit.org/show_bug.cgi?id=31829 1437 1438 * Scripts/old-run-webkit-tests: 1439 14402010-05-12 James Robinson <jamesr@chromium.org> 1441 1442 Reviewed by Simon Fraser. 1443 1444 Disable smooth scrolling on OS X when running tests 1445 https://bugs.webkit.org/show_bug.cgi?id=38964 1446 1447 Some tests (like fast/repaint/fixed-move-after-keyboard-scroll.html) 1448 depend on smooth scrolling behavior. Since this is off by default 1449 in Leopard and on by default in Snow Leopard, DRT should turn it 1450 off always to ensure a consistent test environment. 1451 1452 * DumpRenderTree/mac/DumpRenderTree.mm: 1453 (resetDefaultsToConsistentValues): 1454 14552010-05-10 Rodrigo Belem <rodrigo.belem@openbossa.org> 1456 1457 Reviewed by Kenneth Christiansen , Simon Hausmann and Gustavo Noronha. 1458 1459 [Qt, Gtk] Allows build-webkit script to receive an install prefix as parameter 1460 https://bugs.webkit.org/show_bug.cgi?id=26224 1461 1462 Added more parameters to build-webkit script, the --prefix for gkt 1463 and --install-libs, --install-headers for qt. Now it is possible 1464 to change the install prefix for gtk and install path for qt. 1465 1466 * Scripts/build-webkit: 1467 * Scripts/webkitdirs.pm: 1468 14692010-05-12 Philippe Normand <pnormand@igalia.com> 1470 1471 Unreviewed, added my IRC nickname. 1472 1473 * Scripts/webkitpy/common/config/committers.py: 1474 14752010-05-11 Chris Jerdonek <cjerdonek@webkit.org> 1476 1477 Reviewed by Eric Seidel. 1478 1479 Fixed two FIXME's in svn-apply: eliminated the unnecessary %copiedFiles 1480 variable and changed gitKnowsOfFile() to use exitStatus(). 1481 1482 https://bugs.webkit.org/show_bug.cgi?id=38862 1483 1484 * Scripts/svn-apply: 1485 14862010-05-11 Eric Seidel <eric@webkit.org> 1487 1488 Unreviewed, just fixing python typo. 1489 1490 EWS bots should poll more often than every 5 minutes 1491 https://bugs.webkit.org/show_bug.cgi?id=38968 1492 1493 Typo in _now(), add a unittest to prove I fixed it. 1494 1495 * Scripts/webkitpy/tool/bot/queueengine.py: 1496 * Scripts/webkitpy/tool/bot/queueengine_unittest.py: 1497 14982010-05-11 Adam Barth <abarth@webkit.org> 1499 1500 Reviewed by Eric Seidel. 1501 1502 Qt build failures cause SheriffBot false positives 1503 https://bugs.webkit.org/show_bug.cgi?id=38969 1504 1505 The Qt buildbot randomly fails to compile occasionally because its 1506 network connection causes SVn to leave zero-byte files around. These 1507 compile failures confuse SheriffBot into thinking someone's patch 1508 caused a build break. 1509 1510 In this patch, I've temporarily removed Qt from the list of core 1511 builders. Ossy is working on a script to clean up the zero byte files. 1512 Once that goes in, we can add Qt back to the core builders. 1513 1514 * Scripts/webkitpy/common/net/buildbot.py: 1515 * Scripts/webkitpy/common/net/buildbot_unittest.py: 1516 15172010-05-11 Adam Barth <abarth@webkit.org> 1518 1519 Reviewed by Eric Seidel. 1520 1521 sheriffbot is spammy. 1522 https://bugs.webkit.org/show_bug.cgi?id=38936 1523 1524 Reduce sheriffbot spam by not warning about new blameworthy revisions 1525 that can be explained by previously blamed revisions. This might cause 1526 us to not warn about some real failures, but we're getting too much 1527 spam from slow builders that have large blamelists (and we've already 1528 poked the responsible folks using data from a fast builder). 1529 1530 * Scripts/webkitpy/tool/bot/sheriff_unittest.py: 1531 - Removed unneeded import 1532 * Scripts/webkitpy/tool/commands/sheriffbot.py: 1533 - The logic change 1534 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 1535 - Tests of the change 1536 * Scripts/webkitpy/tool/mocktool.py: 1537 - Merged two declarations of MockBuilder 1538 15392010-05-11 Tony Chang <tony@chromium.org> 1540 1541 Reviewed by David Levin. 1542 1543 [chromium] detect num processors to pass to make -j on Linux 1544 https://bugs.webkit.org/show_bug.cgi?id=38833 1545 1546 * Scripts/webkitdirs.pm: 1547 15482010-05-11 Eric Seidel <eric@webkit.org> 1549 1550 Reviewed by Adam Barth. 1551 1552 EWS bots should poll more often than every 5 minutes 1553 https://bugs.webkit.org/show_bug.cgi?id=38968 1554 1555 We'll make them poll every 2 minutes to start with. 1556 I'm going to re-write how polling works soon, so this is 1557 a stop-gap to try and make the bots more responsive. 1558 1559 If Bill notices any additional load on bugzilla we'll drop 1560 the polling frequency back to 5 minutes. He's historically said 1561 that the EWS bots appear to be a drop in the bucket and thus 1562 should be able to poll much more frequently w/o causing trouble. 1563 1564 * Scripts/webkitpy/tool/bot/queueengine.py: 1565 * Scripts/webkitpy/tool/bot/queueengine_unittest.py: 1566 - Add a test for sleep_message 1567 15682010-05-11 Eric Seidel <eric@webkit.org> 1569 1570 Reviewed by Adam Barth. 1571 1572 commit-queue should commit rollouts without running tests 1573 https://bugs.webkit.org/show_bug.cgi?id=38940 1574 1575 Most of this change is improving our test coverage for the commit-queue. 1576 The only functional change is removing the --test flag when the commit-queue 1577 is running in rollouts mode. 1578 1579 I added test coverage for status updates, and updated the commit-queue status 1580 messages to distinguish rollout vs. normal landing mode in its empty queue 1581 and land patch messages. 1582 1583 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 1584 - Got rid of a bunch of copy/paste code using _default_expected_stderr 1585 * Scripts/webkitpy/tool/commands/queues.py: 1586 - Moved rollout patch filtering out of _validate_patches_in_commit_queue 1587 so that we only have to check if the builders are green in one place. 1588 - Make the "empty queue" message note which queue it is referring to. 1589 - Don't pass --text to land-attachment when in rollout mode. 1590 * Scripts/webkitpy/tool/commands/queues_unittest.py: 1591 - Update results now that we're testing status updates. 1592 - Test _can_build_and_test since I made a typo in that call while 1593 writing this change and the unit tests failed to catch it! 1594 * Scripts/webkitpy/tool/mocktool.py: 1595 - Log status updates to make them testable in our unit tests. 1596 15972010-05-11 Kent Tamura <tkent@chromium.org> 1598 1599 Reviewed by Dimitri Glazkov. 1600 1601 [DRT/Chromium] Apply recent changes of test_shell to DRT 1602 https://bugs.webkit.org/show_bug.cgi?id=38895 1603 1604 Port the changes to test_shell during (r40492, r46810] of Chromium. 1605 Highlights: 1606 - Introduce NotificationPresenter 1607 - Fix parameter mismatch of WebViewClient::startDragging() 1608 1609 This change fixes dozens of unexpected behaviors. 1610 1611 * DumpRenderTree/DumpRenderTree.gypi: 1612 Add NotificationPresenter.{cpp,h} 1613 * DumpRenderTree/chromium/EventSender.cpp: 1614 (applyKeyModifier): 1615 (EventSender::EventSender): 1616 (EventSender::reset): 1617 (EventSender::webview): 1618 (EventSender::doDragDrop): 1619 (EventSender::keyDown): 1620 (EventSender::addTouchPoint): 1621 (EventSender::clearTouchPoints): 1622 (EventSender::releaseTouchPoint): 1623 (EventSender::setTouchModifier): 1624 (EventSender::updateTouchPoint): 1625 (EventSender::cancelTouchPoint): 1626 (EventSender::sendCurrentTouchEvent): 1627 (EventSender::touchEnd): 1628 (EventSender::touchMove): 1629 (EventSender::touchStart): 1630 (EventSender::touchCancel): 1631 * DumpRenderTree/chromium/EventSender.h: 1632 * DumpRenderTree/chromium/LayoutTestController.cpp: 1633 (LayoutTestController::LayoutTestController): 1634 (LayoutTestController::reset): 1635 (LayoutTestController::showWebInspector): 1636 (LayoutTestController::setAuthorAndUserStylesEnabled): 1637 (LayoutTestController::setScrollbarPolicy): 1638 (LayoutTestController::setWillSendRequestClearHeader): 1639 (LayoutTestController::callShouldCloseOnWebView): 1640 (LayoutTestController::grantDesktopNotificationPermission): 1641 (LayoutTestController::removeOriginAccessWhitelistEntry): 1642 (LayoutTestController::addUserScript): 1643 (LayoutTestController::addUserStyleSheet): 1644 * DumpRenderTree/chromium/LayoutTestController.h: 1645 * DumpRenderTree/chromium/NotificationPresenter.cpp: Added. 1646 * DumpRenderTree/chromium/NotificationPresenter.h: Added. 1647 * DumpRenderTree/chromium/TestShell.cpp: 1648 (TestShell::TestShell): 1649 (TestShell::runFileTest): 1650 (TestShell::resetTestController): 1651 * DumpRenderTree/chromium/TestShell.h: 1652 (TestShell::eventSender): 1653 (TestShell::notificationPresenter): 1654 (TestShell::showDevTools): 1655 * DumpRenderTree/chromium/WebViewHost.cpp: 1656 (WebViewHost::createView): 1657 (WebViewHost::createPopupMenu): 1658 (WebViewHost::startDragging): 1659 (WebViewHost::notificationPresenter): 1660 (WebViewHost::createApplicationCacheHost): 1661 (WebViewHost::willSendRequest): 1662 (WebViewHost::updateAddressBar): 1663 (WebViewHost::updateURL): 1664 * DumpRenderTree/chromium/WebViewHost.h: 1665 (WebViewHost::addClearHeader): 1666 (WebViewHost::clearHeaders): 1667 16682010-05-10 Dirk Pranke <dpranke@chromium.org> 1669 1670 Reviewed by Eric Seidel. 1671 1672 new-run-webkit-tests: fix a path-handling bug that was breaking the 1673 dryrun ports on windows, and add a comment about why we don't run 1674 the chromium dryrun tests by default on every port. 1675 1676 https://bugs.webkit.org/show_bug.cgi?id=38796 1677 1678 * Scripts/webkitpy/layout_tests/port/dryrun.py: 1679 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 1680 16812010-05-11 Mark Rowe <mrowe@apple.com> 1682 1683 Reviewed by Darin Adler. 1684 1685 <http://webkit.org/b/38941> build-webkit shouldn't always override ENABLE_FOO Xcode configuration settings 1686 1687 * Scripts/build-webkit: Don't pass the ENABLE setting to xcodebuild if the value matches the default. 1688 This will lead to xcodebuild picking up the settings from FeatureDefines.xcconfig, and will aid in 1689 revealing problems that are due to inconsistent values for settings across projects. 1690 16912010-05-11 Mark Rowe <mrowe@apple.com> 1692 1693 Build fix. 1694 1695 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 1696 16972010-05-10 Ojan Vafai <ojan@chromium.org> 1698 1699 Reviewed by David Levin. 1700 1701 CheckStyle was eating script errors when there were local-commits and working copy changes 1702 https://bugs.webkit.org/show_bug.cgi?id=38880 1703 1704 * Scripts/webkitpy/tool/steps/checkstyle.py: 1705 * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Added. 1706 17072010-05-11 Jian Li <jianli@chromium.org> 1708 1709 Reviewed by Dmitry Titov. 1710 1711 Expose FileReader interface. 1712 https://bugs.webkit.org/show_bug.cgi?id=38609 1713 1714 * Scripts/build-webkit: turn on building FileReader for Apple's WebKit. 1715 17162010-05-10 Tony Chang <tony@chromium.org> 1717 1718 Reviewed by Kent Tamura. 1719 1720 [chromium] Build DRT when running build-webkit --chromium 1721 https://bugs.webkit.org/show_bug.cgi?id=38730 1722 1723 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed. 1724 * Scripts/build-dumprendertree: This does nothing now. 1725 17262010-05-10 Jon Honeycutt <jhoneycutt@apple.com> 1727 1728 REGRESSION(r59100): Added test is broken on many platforms. 1729 https://bugs.webkit.org/show_bug.cgi?id=38881 1730 1731 Reviewed by Eric Seidel. 1732 1733 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 1734 (NPP_Destroy): 1735 Use pluginLog, rather than printf, to match other platforms. 1736 17372010-05-10 Dirk Pranke <dpranke@chromium.org> 1738 1739 Unreviewed, build fix. 1740 1741 Fix a build failure caused by assuming the default platform in 1742 a unit test for new-run-webkit-tests instead of specifying 1743 --platform test. 1744 1745 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 1746 17472010-05-10 Dirk Pranke <dpranke@chromium.org> 1748 1749 Unreviewed, build-fix 1750 1751 new-run-webkit-tests: fix test failure caused by me failing to update 1752 the expected output. Also, run '--platform test' instead of 1753 'platform dryrun' since the former is guaranteed to work and the 1754 latter isn't. 1755 1756 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 1757 17582010-05-10 Dirk Pranke <dpranke@chromium.org> 1759 1760 Reviewed by David Levin. 1761 1762 new-run-webkit-tests: looks like the unicode conversion broke 1763 --print-last-failures and --retest-last-failures. Fixing. 1764 1765 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 1766 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 1767 17682010-05-10 Dirk Pranke <dpranke@chromium.org> 1769 1770 Reviewed by David Levin. 1771 1772 Re-attempt to fix 38616 - newline handling in new-run-webkit-tests. 1773 I didn't handle some cases correctly before and the solution was 1774 confusing. The new patch assumes all calls to the printing module 1775 don't have newlines, and will append newlines where necessary, just 1776 like logging does. 1777 1778 https://bugs.webkit.org/show_bug.cgi?id=38790 1779 1780 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: 1781 * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: 1782 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 1783 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 1784 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 1785 17862010-05-10 Kent Tamura <tkent@chromium.org> 1787 1788 Reviewed by Adam Barth. 1789 1790 Make tkent a reviewer 1791 https://bugs.webkit.org/show_bug.cgi?id=38875 1792 1793 * Scripts/webkitpy/common/config/committers.py: 1794 17952010-05-07 Jon Honeycutt <jhoneycutt@apple.com> 1796 1797 Crash closing window containing Flash plug-in 1798 https://bugs.webkit.org/show_bug.cgi?id=38797 1799 <rdar://problem/7935266> 1800 1801 Reviewed by Eric Seidel. 1802 1803 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 1804 (pluginAllocate): 1805 Initialize new member to false. 1806 1807 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: 1808 Added a new member. 1809 1810 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 1811 (NPP_New): 1812 Check whether the element has the "testGetURLOnDestroy" attribute, and 1813 record that. 1814 (NPP_Destroy): 1815 If "testGetURLOnDestroy" is set, perform a load while destroying the 1816 plug-in. 1817 18182010-05-10 Eric Seidel <eric@webkit.org> 1819 1820 Reviewed by David Levin. 1821 1822 Executive.kill_* do not work with windows python 1823 https://bugs.webkit.org/show_bug.cgi?id=38872 1824 1825 http://trac.webkit.org/changeset/57444 is where the original 1826 breakage occurred. 1827 http://trac.webkit.org/changeset/58314 is where the regression 1828 started affecting chromium. 1829 1830 I have since learned that sys.platform has no "windows" value. 1831 "win32" is always the value, under 32 or 64 bit windows 1832 1833 The tests for this code are not run anywhere because 1834 test-webkitpy does not yet work on "win32". Mostly due to 1835 depending on unixisms like "cat" and "yes". 1836 1837 * Scripts/webkitpy/common/system/executive.py: 1838 * Scripts/webkitpy/common/system/executive_unittest.py: 1839 18402010-05-10 Dirk Pranke <dpranke@chromium.org> 1841 1842 Reviewed by Eric Seidel. 1843 1844 Fix a bug in rebaseline-chromium-webkit-tests where we would crash 1845 instead of logging an error and exiting if it couldn't find either a 1846 debug or a release build of the image diff binary. 1847 1848 https://bugs.webkit.org/show_bug.cgi?id=38692 1849 1850 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 1851 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Added. 1852 18532010-05-10 Eric Seidel <eric@webkit.org> 1854 1855 Reviewed by Adam Barth. 1856 1857 new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL 1858 https://bugs.webkit.org/show_bug.cgi?id=38861 1859 1860 * Scripts/webkitpy/common/system/executive.py: 1861 * Scripts/webkitpy/common/system/executive_unittest.py: 1862 18632010-05-10 Jer Noble <jer.noble@apple.com> 1864 1865 Unreviewed. 1866 1867 Adding myself as a committer. 1868 1869 * Scripts/webkitpy/common/config/committers.py: 1870 18712010-05-10 Hans Wennborg <hans@chromium.org> 1872 1873 Reviewed by Jeremy Orlow. 1874 1875 [Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace() 1876 https://bugs.webkit.org/show_bug.cgi?id=38750 1877 1878 Put a per-origin quota on session storage since it is using memory in 1879 the browser process, and should not be allowed to grow arbitrarily 1880 large. See also http://trac.webkit.org/changeset/58828. 1881 1882 * DumpRenderTree/chromium/WebViewHost.cpp: 1883 (WebViewHost::createSessionStorageNamespace): 1884 * DumpRenderTree/chromium/WebViewHost.h: 1885 18862010-05-10 Csaba Osztrogonác <ossy@webkit.org> 1887 1888 Rubber-stamped by Simon Hausmann. 1889 1890 [Qt] Roll-out r59020 and r59021, because the Qt part of these changes 1891 haven't been landed in Qt trunk yet. Should be rolled-in again after the merge. 1892 1893 https://bugs.webkit.org/show_bug.cgi?id=32967 1894 1895 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 1896 (WebCore::WebPage::WebPage): 1897 (WebCore::DumpRenderTree::DumpRenderTree): 1898 * DumpRenderTree/qt/DumpRenderTreeQt.h: 1899 19002010-05-09 Daniel Bates <dbates@rim.com> 1901 1902 Reviewed by Chris Jerdonek. 1903 1904 https://bugs.webkit.org/show_bug.cgi?id=38812 1905 1906 Make the regular expressions for parsing the start of an SVN 1907 and Git header global variables since they are used throughout 1908 VCSUtils.pm. 1909 1910 * Scripts/VCSUtils.pm: 1911 19122010-05-09 Chris Jerdonek <cjerdonek@webkit.org> 1913 1914 Reviewed by Daniel Bates. 1915 1916 Finished moving the header-parsing logic from svn-apply and -unapply 1917 to VCSUtils.pm's parsing methods. 1918 1919 https://bugs.webkit.org/show_bug.cgi?id=38802 1920 1921 * Scripts/VCSUtils.pm: 1922 - Added to parseGitDiffHeader() the ability to parse and store 1923 whether a file is new or deleted. 1924 - Also reordered in parseGitDiffHeader() some of the else statements 1925 to a more readable ordering. 1926 - Added to parseSvnDiffHeader() the ability to parse and store 1927 whether a file is new. 1928 * Scripts/svn-apply: 1929 - Changed handleGitBinaryChange() to use the new "isNew" and "isDeletion" 1930 diffHash key-values. 1931 - Changed patch() to use the new "isNew" diffHash key-value. 1932 * Scripts/svn-unapply: 1933 - Changed patch() to use the new "isNew" and "isDeletion" diffHash key-values. 1934 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: 1935 - Added unit tests for new and deleted files. 1936 * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: 1937 - Updated the unit tests as necessary. 1938 - Added a unit test for a deleted file. 1939 * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl: 1940 - Updated the unit tests as necessary. 1941 19422010-05-08 Chris Jerdonek <cjerdonek@webkit.org> 1943 1944 Reviewed by Daniel Bates. 1945 1946 Added to svn-apply support for git renames and copies with similarity 1947 index less than 100%. 1948 1949 https://bugs.webkit.org/show_bug.cgi?id=32834 1950 1951 * Scripts/VCSUtils.pm: 1952 - Added to parseGitDiffHeader() support for renames and similarity 1953 index less than 100%. 1954 - Added to parseDiff() support for processing renames, renames with 1955 changes, and copies with changes. 1956 - Added to parsePatch() the ability to process multiple return 1957 values from parseDiff(). 1958 * Scripts/svn-apply: 1959 - Added to patch() the ability to process diff hashes with the 1960 isDeletion key-value set. 1961 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: 1962 - Updated the unit tests as necessary. 1963 - Added unit tests for rename with similarity index 100%, 1964 rename with similarity index < 100%, and rename with a change 1965 to the executable bit. 1966 * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: 1967 - Added unit tests for rename with similarity index 100%, 1968 rename with similarity index < 100%, and rename with a change 1969 to the executable bit. 1970 * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: 1971 - Updated the unit tests as necessary. 1972 * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl: 1973 - Simplified the carriage-return unit test to more narrowly test 1974 only carriage returns. 1975 19762010-05-08 Chris Jerdonek <cjerdonek@webkit.org> 1977 1978 Reviewed by Daniel Bates. 1979 1980 This revision suppresses the misleading "error: pathspec..." messages 1981 when using svn-apply to add a binary file from a Git diff. 1982 1983 https://bugs.webkit.org/show_bug.cgi?id=38047 1984 1985 When adding a new binary file from a Git diff, svn-apply prints 1986 a misleading error of the form -- "error: pathspec '<filename>' did 1987 not match any file(s) known to git. Did you forget to 'git add'?" 1988 This patch suppresses these messages since they are normal. 1989 1990 * Scripts/VCSUtils.pm: 1991 Added the callSilently() subroutine from runPatchCommand.pl, which 1992 executes a Perl function while suppressing STDERR. 1993 * Scripts/svn-apply: 1994 Refactored the Git portion of scmKnowsOfFile() into a 1995 gitKnowsOfFile(), and called this new subroutine using callSilently(). 1996 * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: 1997 Removed callSilently() since it was moved to VCSUtils.pm in this patch. 1998 19992010-05-08 Victor Wang <victorw@chromium.org> 2000 2001 Reviewed by Adam Barth. 2002 2003 [chromium]: Upload test results json files to app engine server 2004 Add an option to run_webkit_tests.py to upload generated 2005 JSON files to app engine server. These JSON files will be used 2006 by chromium layout test falkiness dashboard. 2007 2008 https://bugs.webkit.org/show_bug.cgi?id=36063 2009 2010 * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Added. 2011 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2012 20132010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com> 2014 2015 Reviewed by Kenneth Rohde Christiansen. 2016 2017 [Qt] Build the ImageDiff tool for all platforms including Windows and Symbian 2018 https://bugs.webkit.org/show_bug.cgi?id=38706 2019 2020 Use qmath.h instead of math.h to make it portable. 2021 2022 * DumpRenderTree/qt/ImageDiff.cpp: 2023 (main): 2024 20252010-05-08 Robert Hogan <robert@roberthogan.net> 2026 2027 Reviewed by Simon Hausmann. 2028 2029 [Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html 2030 and http/tests/xmlhttprequest/cross-origin-authorization.html 2031 2032 QHttpNetworkRequest adds Authorization and Cookie headers to XHRs 2033 without knowing if this is valid behaviour or not. In order to allow 2034 Qt to decide whether Cookie/Authorization headers should be added 2035 to an XHR QtWebKit needs to use an attribute added to QNetworkRequest. 2036 These new attributes are: QNetworkRequest::CookieLoadControlAttribute, 2037 QNetworkRequest::CookieSaveControlAttribute,and 2038 QNetworkRequest::AuthenticationReuseControlAttribute. 2039 2040 In order to properly support the tests, Qt's DRT needs to use one 2041 NetworkAccessManager for all pages. This allows it to use cached 2042 credentials where appropriate. 2043 2044 The tests now pass when run individually but there seems to be a problem with 2045 leaking the results of requests across tests when run with the others in 2046 http/tests. This will be addressed in a separate patch. 2047 2048 https://bugs.webkit.org/show_bug.cgi?id=32967 2049 2050 2051 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 2052 (WebCore::WebPage::WebPage): 2053 (WebCore::DumpRenderTree::DumpRenderTree): 2054 * DumpRenderTree/qt/DumpRenderTreeQt.h: 2055 2056 20572010-05-04 Robert Hogan <robert@webkit.org> 2058 2059 Reviewed by Eric Seidel. 2060 2061 [Qt] unskip http/tests/plugins/npapi-response-headers.html 2062 2063 Turns out this failed because run-webkit-tests was eating the first occurrence 2064 of 'Content-Type: text/plain' in the test output as a header. Strange but true. 2065 So do as Chromium does and preface all text dumps with the 2066 'Content-Type: text/plain' header. 2067 2068 https://bugs.webkit.org/show_bug.cgi?id=38541 2069 2070 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 2071 (WebCore::DumpRenderTree::dump): 2072 20732010-05-08 Eric Seidel <eric@webkit.org> 2074 2075 Reviewed by Daniel Bates. 2076 2077 test-webkitpy fails under cygwin 2078 https://bugs.webkit.org/show_bug.cgi?id=38718 2079 2080 * Scripts/webkitpy/common/system/executive.py: 2081 - Add _KILL_PROCESS_KILLED_PROCESS_EXIT_CODE and 2082 _KILL_ALL_KILLED_PROCESS_EXIT_CODE to store the expected 2083 exit codes of processes killed by kill_process and kill_all. 2084 These two constants are only used by the unit tests but are 2085 stored in executive.py so they can be right next to the platform ifs. 2086 - Remove unnecessary str() conversion, run_command does that for us. 2087 - Make os.kill retry on cygwin on EAGAIN. It's unclear why CYGWIN 2088 throws EAGAIN, but it only does so sometimes. 3 may not be enough 2089 retries, but we'll try it to start with. 2090 - Add _windows_image_name to automatically convert "yes" to "yes.exe" 2091 for use with taskkill.exe /im. Various callers to kill_all could 2092 be updated to remove the .exe, but that can be done in another patch. 2093 - Use taskkill.exe for killall on cygwin. 2094 * Scripts/webkitpy/common/system/executive_unittest.py: 2095 - Use the new *_KILLED_PROCESS_EXIT_CODE constants which are correctly 2096 set to 0 on windows/cygwin systems where taskkill.exe is used. 2097 - Test _windows_image_name 2098 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 2099 - Add FIXME about including mac-snowleopard in baseline_search_path. 2100 * Scripts/webkitpy/layout_tests/port/webkit.py: 2101 - Make default_configuration actually read from the Configuration file. 2102 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added. 2103 - Test default_configuration 2104 * Scripts/webkitpy/layout_tests/port/win.py: 2105 - Need a basic baseline_search_path if --platform dryrun is to work. 2106 21072010-05-08 Eric Seidel <eric@webkit.org> 2108 2109 Unreviewed, just reverting commit. 2110 2111 REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert. 2112 https://bugs.webkit.org/show_bug.cgi?id=38798 2113 2114 * Scripts/webkitpy/common/system/executive.py: 2115 * Scripts/webkitpy/common/system/executive_unittest.py: 2116 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 2117 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 2118 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 2119 * Scripts/webkitpy/layout_tests/port/mac.py: 2120 * Scripts/webkitpy/layout_tests/port/webkit.py: 2121 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed. 2122 * Scripts/webkitpy/layout_tests/port/win.py: 2123 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2124 * Scripts/webkitpy/tool/commands/download.py: 2125 * Scripts/webkitpy/tool/commands/download_unittest.py: 2126 21272010-05-06 Eric Seidel <eric@webkit.org> 2128 2129 Reviewed by Daniel Bates. 2130 2131 test-webkitpy fails under cygwin 2132 https://bugs.webkit.org/show_bug.cgi?id=38718 2133 2134 * Scripts/webkitpy/common/system/executive.py: 2135 - Add _KILL_PROCESS_KILLED_PROCESS_EXIT_CODE and 2136 _KILL_ALL_KILLED_PROCESS_EXIT_CODE to store the expected 2137 exit codes of processes killed by kill_process and kill_all. 2138 These two constants are only used by the unit tests but are 2139 stored in executive.py so they can be right next to the platform ifs. 2140 - Remove unnecessary str() conversion, run_command does that for us. 2141 - Make os.kill retry on cygwin on EAGAIN. It's unclear why CYGWIN 2142 throws EAGAIN, but it only does so sometimes. 3 may not be enough 2143 retries, but we'll try it to start with. 2144 - Add _windows_image_name to automatically convert "yes" to "yes.exe" 2145 for use with taskkill.exe /im. Various callers to kill_all could 2146 be updated to remove the .exe, but that can be done in another patch. 2147 - Use taskkill.exe for killall on cygwin. 2148 * Scripts/webkitpy/common/system/executive_unittest.py: 2149 - Use the new *_KILLED_PROCESS_EXIT_CODE constants which are correctly 2150 set to 0 on windows/cygwin systems where taskkill.exe is used. 2151 - Test _windows_image_name 2152 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 2153 - Add FIXME about including mac-snowleopard in baseline_search_path. 2154 * Scripts/webkitpy/layout_tests/port/webkit.py: 2155 - Make default_configuration actually read from the Configuration file. 2156 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added. 2157 - Test default_configuration 2158 * Scripts/webkitpy/layout_tests/port/win.py: 2159 - Need a basic baseline_search_path if --platform dryrun is to work. 2160 2161 2010-05-07 Eric Seidel <eric@webkit.org> 2162 2163 Reviewed by Nikolas Zimmermann. 2164 2165 DryrunTest fails on every platform other than mac 2166 https://bugs.webkit.org/show_bug.cgi?id=38796 2167 2168 The test uses the port detection logic to find a suitable 2169 port to use results from. However that detection logic assumes 2170 chromium on linux, which requires a chromium checkout which the 2171 bots don't have. The test is broken and we'll need to fix it. 2172 For now I'm just going to disable the test on all platforms besides mac. 2173 2174 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2175 2176 2010-05-07 Eric Seidel <eric@webkit.org> 2177 2178 Reviewed by Daniel Bates. 2179 2180 Clean up baseline_search_path to use map to reduce copy/paste code 2181 https://bugs.webkit.org/show_bug.cgi?id=38792 2182 2183 Reading which portnames a port falls back to is easier if 2184 we convert port names to paths with map instead of using copy/paste code. 2185 2186 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 2187 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 2188 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 2189 * Scripts/webkitpy/layout_tests/port/mac.py: 2190 2191 2010-05-07 Eric Seidel <eric@webkit.org> 2192 2193 Reviewed by Daniel Bates. 2194 2195 rollout commands fail when commit is missing bug number 2196 https://bugs.webkit.org/show_bug.cgi?id=38791 2197 2198 * Scripts/webkitpy/tool/commands/download.py: 2199 - _commit_info failed to actually return the CommitInfo in the no-bug-id case. 2200 * Scripts/webkitpy/tool/commands/download_unittest.py: 2201 - Test that the fix worked. 2202 22032010-05-07 Darin Fisher <darin@chromium.org> 2204 2205 Fix build bustage: toElement<T> should be to<T>. 2206 2207 * DumpRenderTree/chromium/LayoutTestController.cpp: 2208 (LayoutTestController::elementDoesAutoCompleteForElementWithId): 2209 22102010-05-07 Chris Jerdonek <cjerdonek@webkit.org> 2211 2212 Reviewed by Daniel Bates. 2213 2214 Refactored VCSUtils.pm's parse-related methods to leave inapplicable 2215 hash values unset instead of setting them to "undef". 2216 2217 https://bugs.webkit.org/show_bug.cgi?id=38724 2218 2219 Preferring "not set" over "undef" keeps the unit tests smaller and 2220 easier to maintain. Otherwise, we would have to update every unit 2221 test case each time we add support for a new key-value pair -- 2222 instead of just the relevant ones. 2223 2224 * Scripts/VCSUtils.pm: 2225 - In parseGitDiffHeader(), adjusted the handling of these key-values: 2226 executableBitDelta and isBinary. 2227 - In parseSvnDiffHeader(), adjusted the handling of these key-values: 2228 copiedFromPath, isBinary, and sourceRevision. 2229 - In parseDiffHeader(), adjusted the handling of these key-values: 2230 isGit and isSvn. 2231 - In parseDiff(), adjusted the handling of these key-values: 2232 isBinary, isGit, isSvn, and sourceRevision. 2233 2234 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: 2235 - Updated the unit tests as necessary. 2236 2237 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: 2238 - Updated the unit tests as necessary. 2239 2240 * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: 2241 - Updated the unit tests as necessary. 2242 2243 * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl: 2244 - Updated the unit tests as necessary. 2245 22462010-05-06 Mark Rowe <mrowe@apple.com> 2247 2248 Rubber-stamped by Dan Bernstein. 2249 2250 Exclude leaks due to <rdar://problem/7815391> from the output. 2251 2252 * Scripts/old-run-webkit-tests: 2253 22542010-05-06 Sheriff Bot <webkit.review.bot@gmail.com> 2255 2256 Unreviewed, rolling out r58933. 2257 http://trac.webkit.org/changeset/58933 2258 https://bugs.webkit.org/show_bug.cgi?id=38717 2259 2260 "Broke all websocket tests on Tiger" (Requested by eseidel on 2261 #webkit). 2262 2263 * Scripts/new-run-webkit-websocketserver: 2264 * Scripts/old-run-webkit-tests: 2265 * Scripts/run-webkit-websocketserver: 2266 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 2267 * Scripts/webkitpy/thirdparty/__init__.py: 2268 * Scripts/webkitpy/thirdparty/pywebsocket/COPYING: Added. 2269 * Scripts/webkitpy/thirdparty/pywebsocket/MANIFEST.in: Added. 2270 * Scripts/webkitpy/thirdparty/pywebsocket/README: Added. 2271 * Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added. 2272 * Scripts/webkitpy/thirdparty/pywebsocket/example/echo_client.py: Added. 2273 * Scripts/webkitpy/thirdparty/pywebsocket/example/echo_wsh.py: Added. 2274 * Scripts/webkitpy/thirdparty/pywebsocket/example/handler_map.txt: Added. 2275 * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/__init__.py: Added. 2276 * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/dispatch.py: Added. 2277 * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/handshake.py: Added. 2278 * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/headerparserhandler.py: Added. 2279 * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/memorizingfile.py: Added. 2280 * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/msgutil.py: Added. 2281 * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/standalone.py: Added. 2282 * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/util.py: Added. 2283 * Scripts/webkitpy/thirdparty/pywebsocket/setup.py: Added. 2284 * Scripts/webkitpy/thirdparty/pywebsocket/test/config.py: Added. 2285 * Scripts/webkitpy/thirdparty/pywebsocket/test/mock.py: Added. 2286 * Scripts/webkitpy/thirdparty/pywebsocket/test/run_all.py: Added. 2287 * Scripts/webkitpy/thirdparty/pywebsocket/test/test_dispatch.py: Added. 2288 * Scripts/webkitpy/thirdparty/pywebsocket/test/test_handshake.py: Added. 2289 * Scripts/webkitpy/thirdparty/pywebsocket/test/test_memorizingfile.py: Added. 2290 * Scripts/webkitpy/thirdparty/pywebsocket/test/test_mock.py: Added. 2291 * Scripts/webkitpy/thirdparty/pywebsocket/test/test_msgutil.py: Added. 2292 * Scripts/webkitpy/thirdparty/pywebsocket/test/test_util.py: Added. 2293 * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/README: Added. 2294 * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/blank_wsh.py: Added. 2295 * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added. 2296 * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added. 2297 * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added. 2298 * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added. 2299 * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added. 2300 * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added. 2301 * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added. 2302 * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/hello.pl: Added. 2303 23042010-05-06 Fumitoshi Ukai <ukai@chromium.org> 2305 2306 Reviewed by David Levin. 2307 2308 WebSocket: pywebsocket 0.5 2309 https://bugs.webkit.org/show_bug.cgi?id=38034 2310 2311 Remove pywebsocket from webkitpy/thirdparty. 2312 Make pywebsocket autoinstalled. 2313 2314 * Scripts/new-run-webkit-websocketserver: 2315 Add --output-dir option. 2316 * Scripts/old-run-webkit-tests: 2317 Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py 2318 * Scripts/run-webkit-websocketserver: 2319 Ditto. 2320 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 2321 Use autoinstalled pywebsocket. 2322 * Scripts/webkitpy/thirdparty/__init__.py: 2323 Autoinstall pywebsocket 2324 * Scripts/webkitpy/thirdparty/pywebsocket: Removed. 2325 23262010-05-06 Chris Jerdonek <cjerdonek@webkit.org> 2327 2328 Reviewed by Daniel Bates. 2329 2330 svn-apply now understands the Git diff "copy from" syntax when the 2331 similarity index is 100%. 2332 2333 https://bugs.webkit.org/show_bug.cgi?id=38628 2334 2335 * Scripts/VCSUtils.pm: 2336 - Adjusted parseGitDiffHeader() to parse the "copy from" and 2337 "similarity index" lines. 2338 2339 * Scripts/svn-unapply: 2340 - Adjusted the patch() subroutine so that copies are recognized 2341 as file additions. 2342 2343 * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: 2344 - Added unit tests for the cases of a copy with similarity index 2345 100% and less than 100%. 2346 23472010-05-06 Chris Jerdonek <cjerdonek@webkit.org> 2348 2349 Reviewed by Daniel Bates. 2350 2351 Removed the need for svn-apply and -unapply to re-parse whether 2352 a diff is binary or not. 2353 2354 https://bugs.webkit.org/show_bug.cgi?id=38320 2355 2356 * Scripts/VCSUtils.pm: 2357 - Adjusted parseGitDiffHeader() to set the isBinary key. 2358 - Adjusted parseSvnDiffHeader() to set the isBinary key. 2359 - Adjusted parseDiffHeader() to set the isBinary key. 2360 - Changed the scmFormat key set by parseDiffHeader() to 2361 isGit and isSvn keys. 2362 - Adjusted parseDiff() to set the isBinary, isGit, and isSvn keys. 2363 2364 * Scripts/svn-apply: 2365 - Updated the patch() method to use the isBinary, isGit, and 2366 isSvn keys. 2367 2368 * Scripts/svn-unapply: 2369 - Updated the patch() method to use the isBinary and isSvn keys. 2370 2371 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: 2372 - Updated the unit tests as necessary. 2373 - Added a test case to test that the isBinary key is getting set properly. 2374 2375 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: 2376 - Updated the unit tests as necessary. 2377 2378 * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: 2379 - Updated the unit tests as necessary. 2380 2381 * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl: 2382 - Updated the unit tests as necessary. 2383 23842010-05-06 Kent Tamura <tkent@chromium.org> 2385 2386 Reviewed by Dimitri Glazkov. 2387 2388 [DRT/Chromium] Add support for resources on Mac 2389 https://bugs.webkit.org/show_bug.cgi?id=38637 2390 2391 Repack webkit_chromium_resources.pak, webkit_strings_en-US.pak, 2392 and webkit_resources.pak, and put them as Mac bundle resource. 2393 The 'actions' section is almost same as a part of test_shell.gypi. 2394 2395 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 2396 23972010-05-06 Csaba Osztrogonác <ossy@webkit.org> 2398 2399 [Qt] Unreviewed buildfix after r58917. 2400 2401 * DumpRenderTree/qt/LayoutTestControllerQt.h: Missing function declaration added. 2402 24032010-05-06 Anders Carlsson <andersca@apple.com> 2404 2405 Reviewed by Darin Adler and Dan Bernstein.. 2406 2407 REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters 2408 https://bugs.webkit.org/show_bug.cgi?id=38698 2409 <rdar://problem/7942075> 2410 2411 Add a 'setPluginsEnabled' layoutTestController function for disabling plug-ins. This is only implemented on Mac currently 2412 because the bug that needs this functionality is mac specific. 2413 2414 * DumpRenderTree/LayoutTestController.cpp: 2415 (setPluginsEnabledCallback): 2416 (LayoutTestController::staticFunctions): 2417 * DumpRenderTree/LayoutTestController.h: 2418 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 2419 (LayoutTestController::setPluginsEnabled): 2420 * DumpRenderTree/mac/DumpRenderTree.mm: 2421 (resetDefaultsToConsistentValues): 2422 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 2423 (LayoutTestController::setPluginsEnabled): 2424 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 2425 (LayoutTestController::setPluginsEnabled): 2426 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 2427 (LayoutTestController::setPluginsEnabled): 2428 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 2429 (LayoutTestController::setPluginsEnabled): 2430 24312010-05-06 Jochen Eisinger <jochen@chromium.org> 2432 2433 Reviewed by Dimitri Glazkov. 2434 2435 Make ImageDiff depend on WebKit. When compiled from within Chromium, WTF is not a standalone dynamic library but depends on WebKit. 2436 https://bugs.webkit.org/show_bug.cgi?id=38632 2437 2438 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 2439 24402010-05-06 Simon Hausmann <simon.hausmann@nokia.com> 2441 2442 Reviewed by Kenneth Rohde Christiansen. 2443 2444 [Qt] Replace public inspector url with private property for QtLauncher 2445 https://bugs.webkit.org/show_bug.cgi?id=35340 2446 2447 Replace the public API with a private dynamic property until this feature 2448 is ready. 2449 2450 * QtLauncher/main.cpp: 2451 (LauncherWindow::init): 2452 24532010-05-05 Joseph Pecoraro <joepeck@webkit.org> 2454 2455 Reviewed by Pavel Feldman. 2456 2457 Web Inspector: build-webkit --inspector-frontend Should Exclude *.re2js 2458 https://bugs.webkit.org/show_bug.cgi?id=38449 2459 2460 * Scripts/webkitdirs.pm: 2461 24622010-05-05 Charles Wei <charles.wei@torchmobile.com.cn> 2463 2464 Reviewed by George Staikos 2465 2466 This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit 2467 Make the test cases in fast/wcss optionional only when WCSS is enabled. 2468 2469 https://bugs.webkit.org/show_bug.cgi?id=37848 2470 2471 * Scripts/old-run-webkit-tests: 2472 * Scripts/webkitperl/features.pm: 2473 24742010-05-05 Kent Tamura <tkent@chromium.org> 2475 2476 Reviewed by Eric Seidel. 2477 2478 [DRT/Chromium] Remove InitWebCoreSystemInterface() call 2479 https://bugs.webkit.org/show_bug.cgi?id=38624 2480 2481 Chromium r45167 <http://src.chromium.org/viewvc/chrome?view=rev&revision=45167> 2482 added InitWebCoreSystemInterface() to webkit/support/platform_support_mac.mm. 2483 So we don't need to call it from DumpRenderTree.cpp anymore. 2484 2485 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 2486 * DumpRenderTree/chromium/DumpRenderTree.cpp: 2487 (main): Remove InitWebCoreSystemInterface(). 2488 24892010-05-05 Dirk Pranke <dpranke@chromium.org> 2490 2491 Reviewed by Eric Seidel. 2492 2493 new-run-webkit-tests: clean up newline handling in printing 2494 2495 The new printing module seems to handle newlines somewhat 2496 inconsistently, especially in --verbose mode. This change cleans up 2497 the code to make things more consistent and adds a bunch of unit tests. 2498 2499 https://bugs.webkit.org/show_bug.cgi?id=38616 2500 2501 * Scripts/webkitpy/common/array_stream.py: Added. 2502 * Scripts/webkitpy/common/array_stream_unittest.py: Added. 2503 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: 2504 * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: Added. 2505 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 2506 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 2507 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2508 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2509 25102010-05-05 James Robinson <jamesr@chromium.org> 2511 2512 Reviewed by Adam Barth. 2513 2514 Ban the single letter 'l' as an identifier name 2515 http://trac.webkit.org/changeset/58844 2516 2517 Add a lint rule to ban the single letter 'l' as an identifier name 2518 since it is very easy to confuse with the numeral '1', especially 2519 in code like WebCore/css/CSSHelper.cpp. 2520 2521 See http://trac.webkit.org/changeset/58844 as an example of a bug 2522 caused by confusing short variable names. 2523 2524 * Scripts/webkitpy/style/checkers/cpp.py: 2525 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 2526 25272010-05-04 Eric Seidel <eric@webkit.org> 2528 2529 Reviewed by Shinichiro Hamaji. 2530 2531 PrettyPatch.pretty_diff("") should not hang 2532 https://bugs.webkit.org/show_bug.cgi?id=38552 2533 2534 Also found a bug in PrettyPatch.pretty_diff where it would 2535 hang when passed "" as input. 2536 2537 I suspect there may be bugs in prettify.rb (or our use there-of) 2538 where it can hang, which would then cause the testing thread to hang. 2539 2540 * Scripts/webkitpy/common/prettypatch.py: 2541 - Don't hang when passed "" 2542 * Scripts/webkitpy/common/prettypatch_unittest.py: 2543 - Test that we don't hang when passed "" 2544 * Scripts/webkitpy/layout_tests/port/base.py: 2545 - Add a FIXME that we should share code with prettypatch.rb 2546 25472010-05-04 Dirk Pranke <dpranke@chromium.org> 2548 2549 Reviewed by Eric Seidel. 2550 2551 new-run-webkit-tests: turn off threading on the Chromium Mac port until 2552 we can stabilize the port more and figure out why it is hanging so 2553 frequently. 2554 2555 https://bugs.webkit.org/show_bug.cgi?id=38553 2556 2557 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 2558 - override default_child_processes() and log a warning 2559 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2560 - fix a typo that caused us to print a method object instead of the 2561 value the method object returns in the case where there is only 2562 one child process. 2563 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2564 - Add unit tests for the output of run_webkit_tests - in this case, 2565 the handling of --child-processes and --print config 2566 25672010-05-04 Timothy Hatcher <timothy@apple.com> 2568 2569 Fix the find command in extract-localizable-strings so skip 2570 directories are correctly skipped and header files are searched. 2571 2572 https://bugs.webkit.org/show_bug.cgi?id=38545 2573 rdar://problem/7941295 2574 2575 Reviewed by Darin Adler. 2576 2577 * Scripts/extract-localizable-strings: Append -o after each -prune 2578 so -and isn't implied. Surround all the -name arguments so they get 2579 an implied -print action. Removed check for "icu". Skip any header that 2580 ends in LocalizableStrings.h, so SafariLocalizableStrings.h is skipped. 2581 * Scripts/update-webkit-localizable-strings: Add the two icu directories 2582 to the skip list. 2583 25842010-05-04 Jesus Sanchez-Palencia <jesus@webkit.org> 2585 2586 Reviewed by Eric Seidel. 2587 2588 Wrong documentation on 'webkit-patch help land'. 2589 https://bugs.webkit.org/show_bug.cgi?id=37871 2590 2591 Small fix on the help documentation for webkit-patch 2592 land. 2593 2594 * Scripts/webkitpy/tool/commands/download.py: 2595 25962010-05-04 Laszlo Gombos <laszlo.1.gombos@nokia.com> 2597 2598 Reviewed by Kenneth Rohde Christiansen. 2599 2600 [Qt] QWebPage viewMode property 2601 https://bugs.webkit.org/show_bug.cgi?id=38119 2602 2603 Rename the property from wrt_viewMode to _q_viewMode. 2604 2605 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 2606 (LayoutTestController::setViewModeMediaFeature): 2607 26082010-05-04 Jochen Eisinger <jochen@chromium.org> 2609 2610 Reviewed by Jeremy Orlow. 2611 2612 Fix typo in run_webkit_tests.py: s/_print\./_printer./ 2613 https://bugs.webkit.org/show_bug.cgi?id=38515 2614 2615 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2616 26172010-05-04 Chris Jerdonek <cjerdonek@webkit.org> 2618 2619 Reviewed by Eric Seidel. 2620 2621 This revision completes the terminology change from "processor" to 2622 "checker" for the CarriageReturnProcessor, CppProcessor, 2623 PythonProcessor, and TextProcessor classes, etc. 2624 2625 https://bugs.webkit.org/show_bug.cgi?id=38262 2626 2627 The word "processor" currently has two uses in our code. This 2628 revision renames the lower-level use to "checker" and preserves the 2629 word "processor" for higher-level, more general uses. This 2630 revision also makes whatever other name changes that logically 2631 followed from this change. 2632 2633 * Scripts/check-webkit-style: 2634 - Updated references to PatchChecker. 2635 2636 * Scripts/webkitpy/style/checker.py: 2637 - Renamed the StyleCheckerConfiguration class to 2638 StyleProcessorConfiguration. 2639 - Renamed the ProcessorDispatcher class to CheckerDispatcher, and 2640 made similar changes for the class's method names. 2641 - Renamed the PatchChecker class to PatchReader. 2642 - Updated the file as necessary to accommodate the other class 2643 renames in this patch. 2644 2645 * Scripts/webkitpy/style/checker_unittest.py: 2646 - Updated the unit test code as necessary. 2647 2648 * Scripts/webkitpy/style/checkers/common.py: 2649 - Renamed the CarriageReturnProcessor class to CarriageReturnChecker, 2650 and changed its process() method to check(). 2651 2652 * Scripts/webkitpy/style/checkers/common_unittest.py: 2653 - Updated the unit test code as necessary. 2654 2655 * Scripts/webkitpy/style/checkers/cpp.py: 2656 - Renamed the CppProcessor class to CppChecker, and renamed its 2657 process() method to check(). 2658 2659 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 2660 - Updated the unit test code as necessary. 2661 2662 * Scripts/webkitpy/style/checkers/python.py: 2663 - Renamed the PythonProcessor class to PythonChecker, and renamed 2664 its process() method to check(). 2665 2666 * Scripts/webkitpy/style/checkers/python_unittest.py: 2667 - Updated the unit test code as necessary. 2668 2669 * Scripts/webkitpy/style/checkers/text.py: 2670 - Renamed the TextProcessor class to TextChecker, and renamed 2671 its process() method to check(). 2672 2673 * Scripts/webkitpy/style/checkers/text_unittest.py: 2674 - Updated the unit test code as necessary. 2675 2676 * Scripts/webkitpy/style/error_handlers.py: 2677 - Updated the code as necessary. 2678 2679 * Scripts/webkitpy/style/error_handlers_unittest.py: 2680 - Updated the unit test code as necessary. 2681 26822010-05-04 Chris Jerdonek <cjerdonek@webkit.org> 2683 2684 Reviewed by Eric Seidel. 2685 2686 Adjusted svn-apply and -unapply to accept git diffs generated 2687 using the --no-prefix flag. 2688 2689 https://bugs.webkit.org/show_bug.cgi?id=32438 2690 2691 * Scripts/VCSUtils.pm: 2692 - Loosened the regular expression for the "diff --git" line to 2693 match when the --no-prefix flag is used with "git diff". 2694 - Also refactored the code parsing the first line so that the 2695 script exits with an error message if the first line cannot 2696 be parsed. 2697 * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: 2698 - Added a unit test case for the --no-prefix case. 2699 27002010-05-04 Chris Jerdonek <cjerdonek@webkit.org> 2701 2702 Reviewed by Daniel Bates. 2703 2704 Changed VCSUtils.pm's parseDiffHeader() to call the new 2705 parseGitDiffHeader() method. 2706 2707 https://bugs.webkit.org/show_bug.cgi?id=38454 2708 2709 This revision makes more progress towards adding executable-bit 2710 support to svn-apply and svn-unapply. It also makes more progress 2711 towards refactoring the code into a more maintainable form. 2712 2713 * Scripts/VCSUtils.pm: 2714 - Removed gitdiff2svndiff(). 2715 - Removed the Git-specific logic from parseDiffHeader() and 2716 renamed it parseSvnDiffHeader(). 2717 - Added a new parseDiffHeader() subroutine which calls 2718 parseSvnDiffHeader() or parseGitDiffHeader() depending on 2719 the format of the first header line. 2720 2721 * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Removed. 2722 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: 2723 - Removed most of the test cases since these cases are now 2724 covered by the unit tests for parseSvnDiffHeader() and 2725 parseGitDiffHeader(). 2726 2727 * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl: Added. 2728 - Copied the SVN unit tests from parseDiffHeader.pl and updated 2729 them as necessary. 2730 27312010-05-03 Eric Seidel <eric@webkit.org> 2732 2733 Reviewed by Adam Barth. 2734 2735 Builders should run the perl and python unit tests on every commit 2736 https://bugs.webkit.org/show_bug.cgi?id=37976 2737 2738 The unit tests take a few seconds to run, so they should not 2739 have any noticable effect on builder speed. 2740 2741 We're running the tests everywhere but Tiger as Tiger's 2742 Python version is ancient. 2743 I would have rather have detected the python version of the 2744 slave but I couldn't find any API to do that, and I didn't want 2745 to hack version detection into test-webkitpy (at least not yet). 2746 2747 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 2748 27492010-05-03 Chris Jerdonek <cjerdonek@webkit.org> 2750 2751 Reviewed by Adam Barth. 2752 2753 Fixed a recent REGRESSION that caused svn-apply and -unapply to 2754 skip over changes to the first file in a diff if leading junk was 2755 present (like in an e-mail diff) and if the --force option was used. 2756 2757 https://bugs.webkit.org/show_bug.cgi?id=38507 2758 2759 * Scripts/svn-apply: 2760 - Removed the bit of code at the beginning of the patch() 2761 subroutine that checks for the "Index:" line at the beginning 2762 of a file diff (since the parsePatch() subroutine already 2763 checks this). 2764 2765 * Scripts/svn-unapply: 2766 - Removed the bit of code at the beginning of the patch() 2767 subroutine that checks for the "Index:" line at the beginning 2768 of a file diff (since the parsePatch() subroutine already 2769 checks this). 2770 27712010-05-03 Chris Jerdonek <cjerdonek@webkit.org> 2772 2773 Unreviewed. 2774 2775 Adjusted the ChangeLog entry below for r58732 (bug 35804) to reflect 2776 the fact that the change will not become active until the patch 2777 for bug 38454 lands. 2778 27792010-05-03 Chris Jerdonek <cjerdonek@webkit.org> 2780 2781 Reviewed by Eric Seidel. 2782 2783 Added code for svn-apply and -unapply to display an instructive error 2784 message if the --binary flag is left off the "git diff" command 2785 for diffs containing binary file differences. 2786 2787 https://bugs.webkit.org/show_bug.cgi?id=35804 2788 2789 This change will become active when parseDiffHeader() is modified 2790 to call parseGitDiffHeader (see bug 38454). 2791 2792 * Scripts/VCSUtils.pm: 2793 - Adjusted parseDiffHeader() to exit with an appropriate error message 2794 if it encounters a line of the form "Binary files <path1> and 2795 <path2> differ". 2796 27972010-05-03 Dirk Pranke <dpranke@chromium.org> 2798 2799 Unreviewed, build fix. 2800 2801 new-run-webkit-tests: r58728 broke the buildbot logic for parsing the 2802 output of the log; specifying --verbose should basically be equivalent 2803 to --print everything, but instead it was equivalent to not specifying 2804 --print and getting the default set. Now, --verbose acts as if 2805 --print everything was implicitly specified as the default (you can 2806 still override it if you specify both; this is a somewhat debatable 2807 call). 2808 2809 https://bugs.webkit.org/show_bug.cgi?id=38504 2810 2811 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 2812 28132010-05-03 Dirk Pranke <dpranke@chromium.org> 2814 2815 Unreviewed, build fix. 2816 2817 new-run-webkit-tests: Fix minor precedence bug introduced in r58728 where we printed 2818 "-\n" 78 times instead of "-" 78 times followed by a single "\n". 2819 2820 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 2821 28222010-05-03 Dirk Pranke <dpranke@chromium.org> 2823 2824 Reviewed by Eric Seidel. 2825 2826 new-run-webkit-tests: refactor a large chunk of the printing/logging 2827 code out of run-webkit-tests py (almost 300 lines out of 1900). 2828 2829 This change also renames --log to --print (to be slightly more 2830 descriptive). I've also added better help messages for printing. 2831 2832 The new code has unit tests! 2833 2834 There is still more code to be moved, but this patch is big enough as 2835 it is. Namely, still to move are the printing of the actual results 2836 and the timing statistics, which should move another 300-400 lines 2837 out of the file. 2838 2839 Notable changes to run_webkit_tests.py beyond code simply moving: 2840 * MeteredStream is now hidden under the new printing.Printer class. 2841 All the references to self._meter now point to self._printer. 2842 * All logging configuration is done in printing.configure_logging() 2843 * Instead of using write() lambdas to control what is and isn't 2844 printed, we use separate methods on the printer object. This will 2845 make it easier to grep which print statements are printed 2846 under protection of each flag. 2847 * The print_results flag I added a few revs back to suppress printing 2848 in the unit tests has been replaced with --print nothing. 2849 * The ResultSummary class now stores the entire TestResult for each 2850 test, not just the actual result type. 2851 * summarize_unexpected_results() got moved from a method on TestRunner 2852 to a standalone function. This should move into a separate file 2853 along with the ResultSummary class and the TestResult class 2854 * The --trace option added recently has been replaced by 2855 '--print trace-everything' and '--print trace-unexpected' 2856 2857 https://bugs.webkit.org/show_bug.cgi?id=38018 2858 2859 * Scripts/new-run-webkit-tests: 2860 - update to new entry points in run_webkit_tests.py 2861 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: 2862 - fix a minor nit where we were printing an empty string where 2863 we didn't need to 2864 * Scripts/webkitpy/layout_tests/layout_package/printing.py: Added. 2865 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Added 2866 * Scripts/webkitpy/layout_tests/port/test.py: 2867 - implement relative_test_filename() and expected_filename() so 2868 we can test printing unexpected results in a platform-neutral 2869 way 2870 * Scripts/webkitpy/run_webkit_test.py: 2871 - move a lot of the printing code into printing.py 2872 - change the signatures of the exported entry points for easier 2873 unit testing 2874 * Scripts/webkitpy/run_webkit_tests_unittest.py: 2875 - update w/ changes to run_webkit_tests entry points. 2876 28772010-05-03 Kevin Watters <kevinwatters@gmail.com> 2878 2879 Reviewed by Kevin Ollivier. 2880 2881 [wx] Build and use Mac's ComplexTextController to support complex text in wx. 2882 https://bugs.webkit.org/show_bug.cgi?id=38482 2883 2884 * wx/build/settings.py: 2885 28862010-05-03 Abhishek Arya <inferno@chromium.org> 2887 2888 Reviewed by Adam Barth. 2889 2890 Add support for controlling clipboard access from javascript. 2891 Clipboard access from javascript is enabled in test framework. 2892 https://bugs.webkit.org/show_bug.cgi?id=27751 2893 2894 * DumpRenderTree/LayoutTestController.cpp: 2895 (setJavaScriptCanAccessClipboardCallback): 2896 (LayoutTestController::staticFunctions): 2897 * DumpRenderTree/LayoutTestController.h: 2898 * DumpRenderTree/chromium/LayoutTestController.cpp: 2899 (LayoutTestController::LayoutTestController): 2900 (LayoutTestController::setJavaScriptCanAccessClipboard): 2901 (LayoutTestController::overridePreference): 2902 * DumpRenderTree/chromium/LayoutTestController.h: 2903 * DumpRenderTree/chromium/TestShell.cpp: 2904 (TestShell::resetWebSettings): 2905 * DumpRenderTree/gtk/DumpRenderTree.cpp: 2906 (resetDefaultsToConsistentValues): 2907 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 2908 (LayoutTestController::setJavaScriptCanAccessClipboard): 2909 * DumpRenderTree/mac/DumpRenderTree.mm: 2910 (resetDefaultsToConsistentValues): 2911 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 2912 (LayoutTestController::setJavaScriptCanAccessClipboard): 2913 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 2914 (WebCore::WebPage::WebPage): 2915 (WebCore::WebPage::resetSettings): 2916 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 2917 (LayoutTestController::setJavaScriptCanAccessClipboard): 2918 * DumpRenderTree/qt/LayoutTestControllerQt.h: 2919 * DumpRenderTree/win/DumpRenderTree.cpp: 2920 (resetDefaultsToConsistentValues): 2921 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 2922 (LayoutTestController::setJavaScriptCanAccessClipboard): 2923 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 2924 (LayoutTestController::setJavaScriptCanAccessClipboard): 2925 29262010-05-03 Anders Carlsson <andersca@apple.com> 2927 2928 Reviewed by Adam Roben. 2929 2930 Maui MiniBrowser: Add an option to show/hide the web view 2931 https://bugs.webkit.org/show_bug.cgi?id=38486 2932 2933 * MiniBrowser/win/BrowserWindow.cpp: 2934 (BrowserWindow::createWindow): 2935 Set the background brush to something other than null. 2936 2937 (BrowserWindow::onCommand): 2938 Show and hide the web view accordingly. 2939 2940 * MiniBrowser/win/MiniBrowser.rc: 2941 * MiniBrowser/win/resource.h: 2942 Add new menu item. 2943 29442010-05-03 Chris Jerdonek <cjerdonek@webkit.org> 2945 2946 Reviewed by Daniel Bates. 2947 2948 Added a parseGitDiffHeader() subroutine to VCSUtils.pm that 2949 parses any changes to the executable bit in a Git diff. 2950 2951 https://bugs.webkit.org/show_bug.cgi?id=38425 2952 2953 This revision is more preparation towards adding "executable bit" 2954 support to svn-apply and svn-unapply. No code is going "live" in 2955 this change except for the new unit tests in test-webkitperl. 2956 2957 * Scripts/VCSUtils.pm: 2958 - Added isExecutable() to determine whether a file mode has the 2959 executable bit set or not. 2960 - Added parseGitDiffHeader() to parse the header of a Git diff. 2961 2962 * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Added. 2963 - Added unit tests for parseGitDiffHeader(). 2964 29652010-05-03 Daniel Bates <dbates@rim.com> 2966 2967 Reviewed by Chris Jerdonek. 2968 2969 https://bugs.webkit.org/show_bug.cgi?id=38447 2970 2971 Refactor the unit tests in VCSUtils_unittest/parseDiff.pl to use 2972 Test::More::is_deeply like we do in VCSUtils_unittest/parseDiffHeader.pl. 2973 2974 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: 2975 29762010-05-02 Chris Jerdonek <cjerdonek@webkit.org> 2977 2978 Unreviewed. 2979 2980 Corrected a file path in the ChangeLog entry for r58663 (bug 38319) below. 2981 29822010-05-02 Chris Jerdonek <cjerdonek@webkit.org> 2983 2984 Reviewed by Eric Seidel. 2985 2986 https://bugs.webkit.org/show_bug.cgi?id=38319 2987 2988 * Scripts/VCSUtils.pm: 2989 - In parseDiffHeader()-- 2990 - Added an "scmFormat" hash key to the return value to represent 2991 whether the diff is Git or SVN formatted. 2992 - Adjusted the code so the value of "copiedFromPath" will 2993 be undef rather than "does not exist" if the file was not 2994 copied. 2995 2996 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: 2997 - Added a FIXME to refactor these unit tests to use is_deeply(). 2998 2999 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: 3000 - Updated the unit tests to test the "scmFormat" value. 3001 - Simplified the unit tests by refactoring them to use is_deeply(). 3002 30032010-05-01 Daniel Bates <dbates@rim.com> 3004 3005 Reviewed by Chris Jerdonek. 3006 3007 https://bugs.webkit.org/show_bug.cgi?id=38423 3008 3009 Adds infrastructure to change the file mode of a file using 3010 the appropriate SCM-specific routines. 3011 3012 No functionality was changed, so no new tests. 3013 3014 * Scripts/VCSUtils.pm: Added subroutines scmToggleExecutableBit, 3015 scmAddExecutableBit, and scmRemoveExecutableBit. 3016 * Scripts/svn-apply: Check for the hash key executableBitDelta 3017 and toggle the executable bit. 3018 * Scripts/svn-unapply: Ditto. 3019 30202010-04-30 Chris Marrin <cmarrin@apple.com> 3021 3022 Reviewed by Simon Fraser. 3023 3024 Enabled accelerated compositing in DRT for Windows 3025 https://bugs.webkit.org/show_bug.cgi?id=38404 3026 3027 * DumpRenderTree/win/DumpRenderTree.cpp: 3028 (main): 3029 30302010-04-30 Anders Carlsson <andersca@apple.com> 3031 3032 Try to fix GTK+ build. 3033 3034 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 3035 (webkit_test_plugin_new_stream): 3036 30372010-04-30 Anders Carlsson <andersca@apple.com> 3038 3039 Fix build. 3040 3041 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 3042 30432010-04-30 Anders Carlsson <andersca@apple.com> 3044 3045 Reviewed by Timothy Hatcher. 3046 3047 Next step towards fixing 3048 3049 https://bugs.webkit.org/show_bug.cgi?id=20784 3050 move npapi.h to C99 integer types 3051 3052 Use the C99 types everywhere. The "old" types are still around but will be removed 3053 in a subsequent commit. 3054 3055 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 3056 (int32VariantToIdentifier): 3057 (doubleVariantToIdentifier): 3058 (testIdentifierToInt): 3059 (testGetIntIdentifier): 3060 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 3061 (NPP_New): 3062 (NPP_NewStream): 3063 (NPP_WriteReady): 3064 (NPP_Write): 3065 (NPP_HandleEvent): 3066 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 3067 (NPP_New): 3068 (NPP_NewStream): 3069 (NPP_WriteReady): 3070 (NPP_Write): 3071 (NPP_HandleEvent): 3072 30732010-04-30 Steve Block <steveblock@google.com> 3074 3075 Reviewed by Jeremy Orlow. 3076 3077 Changed Steve Block from committer to reviewer. 3078 3079 * Scripts/webkitpy/common/config/committers.py: 3080 30812010-04-28 Ojan Vafai <ojan@chromium.org> 3082 3083 Reviewed by Eric Seidel. 3084 3085 webkit-patch doesn't work if a git repo is tracking multiple svn repos 3086 https://bugs.webkit.org/show_bug.cgi?id=38290 3087 3088 Getting the tests to pass required getting our SVN repo to more closely 3089 match the real svn.webkit.org repo by having a trunk directory. 3090 That involved adding an extra commit at the beginning and thus changing 3091 all the commit numbers in the tests. 3092 3093 * Scripts/webkitpy/common/checkout/scm.py: 3094 30952010-04-29 Eric Seidel <eric@webkit.org> 3096 3097 Reviewed by Adam Barth. 3098 3099 new-run-webkit-tests can deadlock with Chromium's TestShell 3100 https://bugs.webkit.org/show_bug.cgi?id=38298 3101 3102 Fix _write_command_and_read_line to never send unicode() to 3103 test_shell, instead to always encode as utf-8. This was causing 3104 random hangs because if test_shell ever encounters a \0 in the 3105 stream it can deadlock with NRWT. 3106 3107 There is still a deadlock bug to fix in NRWT/test_shell design, however 3108 this fix should make the deadlock occur less often. 3109 3110 * Scripts/webkitpy/layout_tests/port/chromium.py: 3111 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 3112 31132010-04-29 Chris Jerdonek <cjerdonek@webkit.org> 3114 3115 Reviewed by Eric Seidel. 3116 3117 Refactored svn-apply and svn-unapply to use the new 3118 parsePatch() subroutine. 3119 3120 https://bugs.webkit.org/show_bug.cgi?id=34033 3121 3122 * Scripts/VCSUtils.pm: 3123 - Consolidated %diffHash documentation. 3124 - Added prepareParsedPatch(). 3125 3126 * Scripts/svn-apply: 3127 - Replaced main while loop with calls to parsePatch() and 3128 prepareParsedPatch(). 3129 3130 * Scripts/svn-unapply: 3131 - Replaced main while loop with calls to parsePatch() and 3132 prepareParsedPatch(). 3133 3134 * Scripts/test-webkitperl: 3135 - Changed to render relative test paths rather than absolute 3136 test paths. 3137 3138 * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl: Added. 3139 - Added unit tests for prepareParsedPatch(). 3140 31412010-04-28 Chris Jerdonek <cjerdonek@webkit.org> 3142 3143 Reviewed by Eric Seidel. 3144 3145 Added to VCSUtils's parseDiffHeader() support for binary patches. 3146 3147 https://bugs.webkit.org/show_bug.cgi?id=38094 3148 3149 The parseDiffHeader() function is part of new patch-parsing code 3150 for svn-apply and svn-unapply that will go live in a subsequent 3151 revision. 3152 3153 * Scripts/VCSUtils.pm: 3154 - Added logic to parseDiffHeader() to recognize the ending of 3155 the header portion of a binary diff. 3156 3157 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: 3158 - Added unit test cases for SVN and Git binary diffs. 3159 31602010-04-28 Eric Seidel <eric@webkit.org> 3161 3162 Reviewed by David Levin. 3163 3164 Document that subprocess.poll/wait are not threadsafe 3165 https://bugs.webkit.org/show_bug.cgi?id=38289 3166 3167 * Scripts/webkitpy/common/system/executive.py: 3168 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 3169 * Scripts/webkitpy/layout_tests/port/chromium.py: 3170 * Scripts/webkitpy/layout_tests/port/http_server.py: 3171 * Scripts/webkitpy/layout_tests/port/server_process.py: 3172 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 3173 31742010-04-28 Chris Jerdonek <cjerdonek@webkit.org> 3175 3176 Reviewed by Daniel Bates. 3177 3178 Removed the dividing line (i.e. "====...") logic from the code 3179 called by svn-apply and svn-unapply. 3180 3181 https://bugs.webkit.org/show_bug.cgi?id=38093 3182 3183 The dividing line logic is unnecessary. Removing it simplifies the 3184 code and makes some subsequent changes easier. 3185 3186 * Scripts/VCSUtils.pm: 3187 - Removed the logic in gitdiff2svndiff() to convert the git 3188 "index" line to an SVN dividing line. 3189 - Adjusted the logic similarly in parseDiffHeader(). 3190 3191 * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: 3192 - Updated the unit tests as necessary. 3193 3194 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: 3195 - Updated the unit tests as necessary. 3196 - Corrected an error in the unit tests whereby all elements 3197 of an array were referencing the same element rather than 3198 distinct elements -- causing unit test failures to be masked. 3199 3200 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: 3201 - Updated the unit tests as necessary. 3202 - Made the same unit test correction as above for parseDiff.pl. 3203 32042010-04-28 Evan Stade <estade@chromium.org> 3205 3206 Unreviewed. 3207 3208 * Scripts/webkitpy/common/config/committers.py: adding myself as a committer 3209 32102010-04-28 Sam Weinig <sam@webkit.org> 3211 3212 Reviewed by Mark Rowe. 3213 3214 Add MiniBrowser to the lists of modules to build and only build it on 3215 SnowLeopard and later. 3216 3217 * Makefile: 3218 * MiniBrowser/Makefile: 3219 32202010-04-28 Sam Weinig <sam@webkit.org> 3221 3222 Reviewed by Mark Rowe. 3223 3224 Make running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH. 3225 3226 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: 3227 * MiniBrowser/mac/make-launchable.sh: Added. 3228 32292010-04-28 Eric Seidel <eric@webkit.org> 3230 3231 Reviewed by David Levin. 3232 3233 Audit all uses of subprocess in webkitpy 3234 https://bugs.webkit.org/show_bug.cgi?id=38284 3235 3236 After further discussions with Jeffrey Yasskin 3237 about http://bugs.python.org/issue2320 3238 and related issues of using subprocess from 3239 multiple threads, I have learned that subprocess 3240 is known to be non-threadsafe through recent 3241 Python 2.7 builds. 3242 3243 I'm attempting to lessen our exposure to these 3244 subprocess bugs by auditing each use of subprocess 3245 in webkitpy. I did not find any unsafe calls 3246 in my audit, but I did remove numerous unneeded 3247 import subprocess lines. 3248 3249 * Scripts/webkitpy/common/checkout/api.py: 3250 * Scripts/webkitpy/common/net/bugzilla.py: 3251 * Scripts/webkitpy/common/system/deprecated_logging_unittest.py: 3252 * Scripts/webkitpy/common/system/user.py: 3253 * Scripts/webkitpy/layout_tests/port/base.py: 3254 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 3255 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 3256 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Added. 3257 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 3258 * Scripts/webkitpy/layout_tests/port/gtk.py: 3259 * Scripts/webkitpy/layout_tests/port/mac.py: 3260 * Scripts/webkitpy/layout_tests/port/qt.py: 3261 * Scripts/webkitpy/layout_tests/port/webkit.py: 3262 * Scripts/webkitpy/layout_tests/port/win.py: 3263 32642010-04-28 Darin Adler <darin@apple.com> 3265 3266 Ignore a directory the Python tools creates. 3267 3268 * Scripts/webkitpy/style: Modified property svn:ignore. 3269 32702010-04-28 Darin Adler <darin@apple.com> 3271 3272 * Scripts/extract-localizable-strings: Fix minor mistake in 3273 argument checking. 3274 32752010-04-28 Luiz Agostini <luiz.agostini@openbossa.org> 3276 3277 Reviewed by Kenneth Rohde Christiansen. 3278 3279 [Qt] QWebPage viewMode property 3280 https://bugs.webkit.org/show_bug.cgi?id=38119 3281 3282 Replacing method qt_wrt_setViewMode by wrt_viewMode property. 3283 3284 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 3285 (LayoutTestController::setViewModeMediaFeature): 3286 32872010-04-28 Chris Jerdonek <cjerdonek@webkit.org> 3288 3289 Reviewed by Shinichiro Hamaji. 3290 3291 Adjusted check-webkit-style so that files with file type NONE 3292 are automatically skipped without warning. 3293 3294 https://bugs.webkit.org/show_bug.cgi?id=38197 3295 3296 This change simplifies configuring which files to skip. It also 3297 addresses an issue whereby check-webkit-style was unintentionally 3298 checking .vcproj files for carriage returns. 3299 3300 * Scripts/webkitpy/style/checker.py: 3301 - Moved the C++, Python, and text file extensions to new 3302 module-level configuration variables. 3303 - Removed .pyc from the _SKIPPED_FILES_WITHOUT_WARNING configuration 3304 variable. 3305 - Changed the numeric values of the FileType enum so that 3306 FileType.NONE evaluates to False. 3307 - For ProcessorDispatcher.should_skip_without_warning(): 3308 - Changed the method to return True for FileType.NONE files. 3309 - Made ChangeLog files an exception to getting skipped. 3310 - Changed the StyleProcessor.process() method to raise an 3311 exception if given a file path that should not be processed. 3312 3313 * Scripts/webkitpy/style/checker_unittest.py: 3314 - Updated the unit tests and added more test cases as necessary. 3315 33162010-04-28 Eric Seidel <eric@webkit.org> 3317 3318 Reviewed by Jeremy Orlow. 3319 3320 webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128',) 3321 https://bugs.webkit.org/show_bug.cgi?id=38248 3322 3323 The previous code did not check the return code of taskkill. 3324 When I moved that callsite from using subprocess.call to 3325 Executive.run_command having a non-zero return code became an error. 3326 3327 In this change I've centralized our killall handling in executive, 3328 and added tests for it to make sure it works. 3329 3330 Currently kill_process and kill_all swallow exceptions in the cases 3331 where the process(es) to be killed do(es) not exist. 3332 3333 * Scripts/webkitpy/common/system/executive.py: 3334 * Scripts/webkitpy/common/system/executive_unittest.py: 3335 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 3336 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 3337 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 3338 * Scripts/webkitpy/layout_tests/port/gtk.py: 3339 * Scripts/webkitpy/layout_tests/port/mac.py: 3340 * Scripts/webkitpy/layout_tests/port/qt.py: 3341 * Scripts/webkitpy/layout_tests/port/win.py: 3342 33432010-04-28 Eric Seidel <eric@webkit.org> 3344 3345 Reviewed by Shinichiro Hamaji. 3346 3347 wdiff_text throws ScriptError because wdiff returns non-zero when files differ 3348 https://bugs.webkit.org/show_bug.cgi?id=38246 3349 3350 wdiff returns 0 when files are the same, 1 when they differ. 3351 run_command by default raises ScriptError if the return code is non-zero. 3352 Fixed this by adding a custom error handler which only raises if the 3353 return code is not 1. 3354 3355 I broke up the huge wdiff_text() method into little pieces 3356 for easier unit testing. There is only one functional change here 3357 and that is the addition of the custom error handler. 3358 3359 * Scripts/webkitpy/layout_tests/port/base.py: 3360 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 3361 33622010-04-28 Fumitoshi Ukai <ukai@chromium.org> 3363 3364 Unreviewed build fix. 3365 3366 * DumpRenderTree/chromium/TestShell.cpp: 3367 (TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'. 3368 * DumpRenderTree/chromium/WebViewHost.cpp: 3369 (WebViewHost::willSendRequest): too few arguments for format. 3370 33712010-04-27 Shinichiro Hamaji <hamaji@chromium.org> 3372 3373 Reviewed by Darin Adler and Eric Seidel. 3374 3375 Add layoutTestController.setPrinting() 3376 https://bugs.webkit.org/show_bug.cgi?id=37203 3377 3378 * DumpRenderTree/LayoutTestController.cpp: 3379 (LayoutTestController::LayoutTestController): 3380 (setPrintingCallback): 3381 (LayoutTestController::staticFunctions): 3382 * DumpRenderTree/LayoutTestController.h: 3383 (LayoutTestController::isPrinting): 3384 (LayoutTestController::setIsPrinting): 3385 * DumpRenderTree/mac/DumpRenderTree.mm: 3386 (dump): 3387 33882010-04-27 Michael Nordman <michaeln@google.com> 3389 3390 Reviewed by Dmitry Titov. 3391 3392 [Chromium] Add two things to the webkit API to support appcaches in workers. 3393 1) WebURLRequest TargetTypes for worker and shared worker main resources. 3394 2) Factory method on class WebCommonWorkerClient to 3395 createApplicationCacheHost() for the associated worker. 3396 3397 https://bugs.webkit.org/show_bug.cgi?id=38147 3398 3399 * DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method 3400 (TestWebWorker::createApplicationCacheHost): 3401 34022010-04-27 Adam Barth <abarth@webkit.org> 3403 3404 Reviewed by Eric Seidel. 3405 3406 run-bindings-tests doesn't work in an SVN checkout 3407 https://bugs.webkit.org/show_bug.cgi?id=38225 3408 3409 Previously detect_scm_system needed an absolute path for SVN. Now we 3410 accept a relative path. 3411 3412 * Scripts/webkitpy/common/checkout/scm.py: 3413 * Scripts/webkitpy/common/checkout/scm_unittest.py: 3414 34152010-04-27 Sam Weinig <sam@webkit.org> 3416 3417 Reviewed by Stephanie Lewis. 3418 3419 Always build WebKit2 when building on SnowLeopard and later. 3420 3421 * Scripts/build-webkit: 3422 34232010-04-27 Sam Weinig <sam@webkit.org> 3424 3425 Reviewed by Maciej Stachowiak. 3426 3427 Fix for https://bugs.webkit.org/show_bug.cgi?id=38238 3428 Allow both WebKit and WebKit2 to link to the same WebCore.framework 3429 3430 * Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building 3431 WebCore for WebKit2, it is no longer necessary. 3432 34332010-04-27 James Robinson <jamesr@chromium.org> 3434 3435 Reviewed by David Levin. 3436 3437 Fix a typo in chromium.py that causes NRWT to fail in --verbose 3438 mode in a Chromium checkout. 3439 https://bugs.webkit.org/show_bug.cgi?id=38234 3440 3441 * Scripts/webkitpy/layout_tests/port/chromium.py: 3442 34432010-04-27 Darin Fisher <darin@chromium.org> 3444 3445 Reviewed by Dimitri Glazkov. 3446 3447 [Chromium] Remove deprecated form of didChangeLocationWithinPage 3448 https://bugs.webkit.org/show_bug.cgi?id=38178 3449 3450 Switch over to implementing didNavigateWithinPage. 3451 3452 * DumpRenderTree/chromium/WebViewHost.cpp: 3453 (TestWebViewDelegate::didNavigateWithinPage): 3454 (WebViewHost::didChangeLocationWithinPage): 3455 * DumpRenderTree/chromium/WebViewHost.h: 3456 34572010-04-27 Evan Martin <evan@chromium.org> 3458 3459 Unreviewed. 3460 3461 Adding myself to commmitters list. 3462 3463 * Scripts/webkitpy/common/config/committers.py: 3464 34652010-04-27 Adam Barth <abarth@webkit.org> 3466 3467 Reviewed by Darin Adler. 3468 3469 run-bindings-tests should use --reset-results instead of --overwrite 3470 https://bugs.webkit.org/show_bug.cgi?id=38200 3471 3472 As requested by Ojan. 3473 3474 * Scripts/run-bindings-tests: 3475 34762010-04-27 Adam Barth <abarth@webkit.org> 3477 3478 Reviewed by Eric Seidel. 3479 3480 REGRESSION(r58261): webkit-patch edit-changelogs is broken 3481 https://bugs.webkit.org/show_bug.cgi?id=38204 3482 3483 In 58261, we added code to abstract step that interrogates the squash 3484 and git_commit options, but it doesn't declare that it uses those 3485 options. That means any command that doesn't happen to declare those 3486 options might be broken if it uses the cached_lookup mechanism. 3487 3488 * Scripts/webkitpy/tool/steps/abstractstep.py: 3489 * Scripts/webkitpy/tool/steps/applypatch.py: 3490 * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py: 3491 * Scripts/webkitpy/tool/steps/build.py: 3492 * Scripts/webkitpy/tool/steps/checkstyle.py: 3493 * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py: 3494 * Scripts/webkitpy/tool/steps/closebug.py: 3495 * Scripts/webkitpy/tool/steps/closebugforlanddiff.py: 3496 * Scripts/webkitpy/tool/steps/commit.py: 3497 * Scripts/webkitpy/tool/steps/confirmdiff.py: 3498 * Scripts/webkitpy/tool/steps/createbug.py: 3499 * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: 3500 * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py: 3501 * Scripts/webkitpy/tool/steps/obsoletepatches.py: 3502 * Scripts/webkitpy/tool/steps/postcodereview.py: 3503 * Scripts/webkitpy/tool/steps/postdiff.py: 3504 * Scripts/webkitpy/tool/steps/preparechangelog.py: 3505 * Scripts/webkitpy/tool/steps/runtests.py: 3506 * Scripts/webkitpy/tool/steps/update.py: 3507 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: 3508 * Scripts/webkitpy/tool/steps/validatereviewer.py: 3509 35102010-04-27 Eric Seidel <eric@webkit.org> 3511 3512 Reviewed by David Levin. 3513 3514 prepare-ChangeLog --bug fails on some CYGWIN installs due to missing certs 3515 https://bugs.webkit.org/show_bug.cgi?id=38212 3516 3517 * Scripts/prepare-ChangeLog: 3518 - Pass --insecure to curl to work around CYGWIN missing certs. 3519 35202010-04-27 Sam Weinig <sam@webkit.org> 3521 3522 Rubber-stamped by Beth Dakin. 3523 3524 It is no longer necessary to set ENABLE_EXPERIMENTAL_SINGLE_VIEW_MODE 3525 or WTF_USE_WEB_THREAD. Remove them. 3526 3527 * Scripts/build-webkit: 3528 35292010-04-27 Chris Jerdonek <cjerdonek@webkit.org> 3530 3531 Reviewed by David Levin. 3532 3533 Changed Chris Jerdonek from committer to reviewer. 3534 3535 * Scripts/webkitpy/common/config/committers.py: 3536 35372010-04-27 Benjamin Poulain <benjamin.poulain@nokia.com> 3538 3539 Reviewed by Kenneth Rohde Christiansen. 3540 3541 [Qt] QGraphicsWebView: Arrow keys scroll the graphics-view instead of the web-page 3542 https://bugs.webkit.org/show_bug.cgi?id=35834 3543 3544 The scene should always have the size of the web view otherwhise it is 3545 possible to scroll the graphics view. 3546 3547 * QtLauncher/webview.cpp: 3548 (WebViewGraphicsBased::resizeEvent): 3549 35502010-04-27 Diego Gonzalez <diegohcg@webkit.org> 3551 3552 Unreviewed. 3553 3554 Adding myself to committers.py 3555 3556 * Scripts/webkitpy/common/config/committers.py: 3557 35582010-04-27 Eric Seidel <eric@webkit.org> 3559 3560 Reviewed by Adam Barth. 3561 3562 [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux) 3563 https://bugs.webkit.org/show_bug.cgi?id=37987 3564 3565 After further research, I believe the hang is caused by: 3566 http://bugs.python.org/issue2320 3567 Basically Popen() is not reentrant. 3568 The workaround is to pass close_fds=True to Popen() on Mac/Linux. 3569 3570 I fixed our main Popen wrapper "Executive.run_command" to use close_fds=True 3571 when appropriate. 3572 3573 I audited all places we call Popen() and either moved them to run_command 3574 or left a FIXME that they are not thread safe. A few places I added the 3575 close_fds workaround there and left an explanitory note. 3576 3577 * Scripts/webkitpy/common/checkout/scm_unittest.py: 3578 - Added note that this Popen use is not threadsafe. 3579 * Scripts/webkitpy/common/system/executive.py: 3580 - Fixed our Executive.run_* to workaround python bug 2320. 3581 * Scripts/webkitpy/common/system/user.py: 3582 _ Added note that this Popen use is not threadsafe. 3583 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: ditto. 3584 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: ditto. 3585 * Scripts/webkitpy/layout_tests/port/base.py: 3586 - Change wdiff back to using run_command now that we believe it 3587 to be threadsafe. 3588 * Scripts/webkitpy/layout_tests/port/chromium.py: 3589 - Fix to use Executive in places. 3590 - Pass self._executive down to the Driver for easier unit testing. 3591 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 3592 - Re-factor to use a _kill_all method. 3593 - Made the _kill_all method use run_command to be threadsafe. 3594 * Scripts/webkitpy/layout_tests/port/http_server.py: 3595 - Add FIXME about using Executive. 3596 * Scripts/webkitpy/layout_tests/port/server_process.py: 3597 - Use Executive to be threadsafe. 3598 * Scripts/webkitpy/layout_tests/port/webkit.py: 3599 - Pass self._executive down to the Driver. 3600 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 3601 - Add note about Popen not being threadsafe. 3602 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 3603 - Move one caller to run_command add notes about moving others. 3604 36052010-04-27 Adam Barth <abarth@webkit.org> 3606 3607 Reviewed by Maciej Stachowiak. 3608 3609 REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout. 3610 https://bugs.webkit.org/show_bug.cgi?id=38186 3611 3612 Unfortunately, we don't have a good way of testing this change because 3613 our test coverage of the scm.py API is poor... 3614 3615 * Scripts/webkitpy/common/checkout/scm.py: 3616 * Scripts/webkitpy/tool/steps/preparechangelog.py: 3617 36182010-04-26 Eric Seidel <eric@webkit.org> 3619 3620 Reviewed by Adam Barth. 3621 3622 Remove unused code from text_diff.py 3623 https://bugs.webkit.org/show_bug.cgi?id=38170 3624 3625 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 3626 - Remove is_render_tree_dump which appears unused. 3627 36282010-04-26 Adam Barth <abarth@webkit.org> 3629 3630 Reviewed by Eric Seidel. 3631 3632 webkit-patch pretty-diff is broken 3633 https://bugs.webkit.org/show_bug.cgi?id=38172 3634 3635 We need to register for these options because they're used when we look 3636 up the diff. 3637 3638 * Scripts/webkitpy/tool/steps/confirmdiff.py: 3639 36402010-04-26 Adam Barth <abarth@webkit.org> 3641 3642 Reviewed by Eric Seidel. 3643 3644 Add ObjC and GObject to run-bindings-test 3645 https://bugs.webkit.org/show_bug.cgi?id=38168 3646 3647 * Scripts/run-bindings-tests: 3648 36492010-04-26 Adam Barth <abarth@webkit.org> 3650 3651 Reviewed by Eric Seidel. 3652 3653 Add testing infrastructure for JSC bindings generator 3654 https://bugs.webkit.org/show_bug.cgi?id=38167 3655 3656 Add support for testing more than one bindings. Also, converted the 3657 script to PEP8 style. 3658 3659 * Scripts/run-bindings-tests: 3660 36612010-04-26 Eric Seidel <eric@webkit.org> 3662 3663 Reviewed by Adam Barth. 3664 3665 Refactor results.html generation out into a new method and test it 3666 https://bugs.webkit.org/show_bug.cgi?id=38164 3667 3668 Hopefully this results in no change in functionality. 3669 3670 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 3671 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 3672 36732010-04-26 Adam Barth <abarth@webkit.org> 3674 3675 Unreviewed, rolling out r58265. 3676 http://trac.webkit.org/changeset/58265 3677 https://bugs.webkit.org/show_bug.cgi?id=38021 3678 3679 This change prevents me from uploading patches. It also breaks sheriff-bot. 3680 3681 * Scripts/webkitpy/tool/steps/options.py: 3682 36832010-04-26 Eric Seidel <eric@webkit.org> 3684 3685 Reviewed by Adam Barth. 3686 3687 [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux) 3688 https://bugs.webkit.org/show_bug.cgi?id=37987 3689 3690 Rolled out: 3691 http://trac.webkit.org/changeset/58062 3692 http://trac.webkit.org/changeset/58060 3693 http://trac.webkit.org/changeset/58059 3694 http://trac.webkit.org/changeset/58055 3695 http://trac.webkit.org/changeset/58054 3696 and parts of: 3697 http://trac.webkit.org/changeset/58050 3698 3699 I also wrote some new comments and a tiny amount of new 3700 code to help make ChromiumDriver.run_test easier to read. 3701 3702 In order to unit-test my new code, I had to change ChromiumDriver 3703 to not automatically start itself when created. That ended up 3704 being a lot of plumbing, but is hopefully easier to understand now. 3705 3706 There are no tests for the (restored) wdiff code. wdiff does not 3707 exist on all systems, so for now we will assume it worked since 3708 it is just old code being reverted. 3709 3710 * Scripts/webkitpy/layout_tests/driver_test.py: 3711 - Use create_driver instead of start_driver, and be sure to call .stop() 3712 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 3713 - Use create_driver instead of start_driver 3714 * Scripts/webkitpy/layout_tests/port/base.py: 3715 - Added a comment to explain that diffs are binary files. 3716 - Various patch reverts relating to wdiff 3717 - Add Driver._command_wrapper to share code between WebKitDriver and ChromiumDriver. 3718 - Made _command_wrapper use shlex.split to get rid of the FIXME. 3719 * Scripts/webkitpy/layout_tests/port/base_unittest.py: Added. 3720 - test the new _command_wrapper 3721 * Scripts/webkitpy/layout_tests/port/chromium.py: 3722 - Use _command_wrapper to get rid of a bunch of ugly code. 3723 - Make __init__ stop auto-starting. 3724 - Rename create_driver to start_driver. 3725 - Added _write_command_and_read_line to make it possible to 3726 put a FIXME next to read_line() w/o having to put it in two places. 3727 - Moved test_shell command building into _test_shell_command and tested it. 3728 - Fix comments to say test_shell since ChromiumDriver is test_shell only. 3729 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Added. 3730 - Test the new test_shell_command method. 3731 * Scripts/webkitpy/layout_tests/port/dryrun.py: 3732 - Rename create_driver to start_driver. 3733 * Scripts/webkitpy/layout_tests/port/test.py: 3734 - Rename create_driver to start_driver. 3735 * Scripts/webkitpy/layout_tests/port/webkit.py: 3736 - Rename create_driver to start_driver. 3737 - Treat output as binary arrays. 3738 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 3739 - Treat diff files as binary. 3740 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 3741 - Treat diff files as binary. 3742 37432010-04-26 Adam Barth <abarth@webkit.org> 3744 3745 Reviewed by Eric Seidel. 3746 3747 Move bindings test directory into the scripts directory 3748 https://bugs.webkit.org/show_bug.cgi?id=38161 3749 3750 Change script to point to the new location of these data files. 3751 3752 * Scripts/run-bindings-tests: 3753 37542010-04-26 Adam Barth <abarth@webkit.org> 3755 3756 Unreviewed. Mark run-bindings-tests executable so we can execute it. 3757 3758 * Scripts/run-bindings-tests: 3759 37602010-04-26 Tony Chang <tony@chromium.org> 3761 3762 Reviewed by David Levin. 3763 3764 [chromium] build-webkit --chromium should build release by default 3765 https://bugs.webkit.org/show_bug.cgi?id=38028 3766 3767 * Scripts/build-dumprendertree: Also should build release by default 3768 * Scripts/build-webkit: Make sure to pass command line args through 3769 * Scripts/webkitdirs.pm: Build the right configuration 3770 37712010-04-26 Ojan Vafai <ojan@chromium.org> 3772 3773 Reviewed by Eric Seidel. 3774 3775 complete rietveld bugzilla integration 3776 https://bugs.webkit.org/show_bug.cgi?id=38021 3777 3778 Makes --fancy-review the default. All this means is that the patch will 3779 be uploaded to rietveld in addition to bugs.webkit.org. 3780 3781 * Scripts/webkitpy/tool/steps/options.py: 3782 37832010-04-26 Chris Jerdonek <cjerdonek@webkit.org> 3784 3785 Reviewed by Shinichiro Hamaji. 3786 3787 For check-webkit-style, renamed the style/processors/ directory 3788 to style/checkers/. 3789 3790 https://bugs.webkit.org/show_bug.cgi?id=38122 3791 3792 * Scripts/webkitpy/style/checker.py: 3793 - Updated import statements. 3794 3795 * Scripts/webkitpy/style/checker_unittest.py: 3796 - Updated import statements. 3797 3798 * Scripts/webkitpy/style/checkers: Copied from WebKitTools/Scripts/webkitpy/style/processors. 3799 * Scripts/webkitpy/style/processors: Removed. 3800 * Scripts/webkitpy/style/processors/__init__.py: Removed. 3801 * Scripts/webkitpy/style/processors/common.py: Removed. 3802 * Scripts/webkitpy/style/processors/common_unittest.py: Removed. 3803 * Scripts/webkitpy/style/processors/cpp.py: Removed. 3804 * Scripts/webkitpy/style/processors/cpp_unittest.py: Removed. 3805 * Scripts/webkitpy/style/processors/python.py: Removed. 3806 * Scripts/webkitpy/style/processors/python_unittest.py: Removed. 3807 * Scripts/webkitpy/style/processors/python_unittest_input.py: Removed. 3808 * Scripts/webkitpy/style/processors/text.py: Removed. 3809 * Scripts/webkitpy/style/processors/text_unittest.py: Removed. 3810 38112010-04-06 Ojan Vafai <ojan@chromium.org> 3812 3813 Reviewed by Adam Barth. 3814 3815 Include git commits in the diff for webkit-patch upload/land. 3816 https://bugs.webkit.org/show_bug.cgi?id=36394 3817 3818 Adds --squash, --no-squash and --git-commit. 3819 3820 --git-commit will use a specific local commit for land/upload. 3821 If a commit-range is specified, then that range is treated as 3822 a single squashed commit. 3823 3824 --squash will squash all local changes including working copy changes 3825 into a single patch. 3826 3827 --no-squash is the legacy behavior (upload only considers the working copy, 3828 land commits the working copy and then each local commit separately to SVN) 3829 3830 If neither is specified, then an informative error is raised if there is 3831 more than one local commit or when there are local commit(s) and working 3832 copy changes. 3833 3834 If the webkit-patch.squash git config parameter is set, then 3835 that will be respected instead of raising an error. 3836 3837 * Scripts/check-webkit-style: 3838 * Scripts/webkitpy/common/checkout/api.py: 3839 * Scripts/webkitpy/common/checkout/api_unittest.py: 3840 * Scripts/webkitpy/common/checkout/scm.py: 3841 * Scripts/webkitpy/common/checkout/scm_unittest.py: 3842 * Scripts/webkitpy/style/optparser.py: 3843 --git-since is removed and --git-commit no longer implies commit_id.. 3844 Instead, it treats that individual commit, but also supports commit ranges 3845 (e.g. commit_id..) as arguments. 3846 * Scripts/webkitpy/style/optparser_unittest.py: 3847 * Scripts/webkitpy/style_references.py: 3848 * Scripts/webkitpy/tool/commands/download.py: 3849 * Scripts/webkitpy/tool/commands/upload.py: 3850 * Scripts/webkitpy/tool/main.py: 3851 * Scripts/webkitpy/tool/mocktool.py: 3852 * Scripts/webkitpy/tool/steps/abstractstep.py: 3853 * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py: 3854 * Scripts/webkitpy/tool/steps/checkstyle.py: 3855 * Scripts/webkitpy/tool/steps/commit.py: 3856 * Scripts/webkitpy/tool/steps/options.py: 3857 * Scripts/webkitpy/tool/steps/postdiff.py: 3858 * Scripts/webkitpy/tool/steps/preparechangelog.py: 3859 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: 3860 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: 3861 * Scripts/webkitpy/tool/steps/validatereviewer.py: 3862 38632010-04-26 Chris Jerdonek <cjerdonek@webkit.org> 3864 3865 Reviewed by Shinichiro Hamaji. 3866 3867 Deleted the StyleChecker-related classes that are no longer 3868 being used. 3869 3870 https://bugs.webkit.org/show_bug.cgi?id=38118 3871 3872 * Scripts/webkitpy/style/checker.py: 3873 - Deleted the DeprecatedStyleChecker class. 3874 3875 * Scripts/webkitpy/style/checker_unittest.py: 3876 - Deleted the StyleCheckerTest, StyleCheckerCheckFileBase, 3877 StyleCheckerCheckFileTest, and StyleCheckerCheckPathsTest classes. 3878 38792010-04-26 Chris Jerdonek <cjerdonek@webkit.org> 3880 3881 Reviewed by Shinichiro Hamaji. 3882 3883 Changed the StyleChecker class to use the new TextFileReader class. 3884 3885 https://bugs.webkit.org/show_bug.cgi?id=37066 3886 3887 This revision separates the code responsible for reading and iterating 3888 over text files from the rest of check-webkit-style. 3889 3890 * Scripts/check-webkit-style: 3891 - Changed the script to use the new StyleProcessor and 3892 TextFileReader classes instead of the StyleChecker class. 3893 3894 * Scripts/webkitpy/style/checker.py: 3895 - Added a FIXME to rename many of uses of the word "processor" to 3896 "checker". We did this to clarify the difference between 3897 ProcessorBase instances passed to the TextFileReader and 3898 classes that process and check lines for style. 3899 - Added a FIXME to remove FileType.NONE as a possible return value 3900 of ProcessorDispatcher._file_type(). This will better consolidate 3901 the logic of which files should be skipped. 3902 - Added a FIXME to delete the StyleChecker class. 3903 - Added the StyleProcessor class which implements ProcessorBase. 3904 This class is responsible for processing lines to check style 3905 (but not for reading files). For each file, this class creates 3906 creates both a carriage-return checker and a format-specific 3907 style checker (e.g. one of C++, Python, etc). 3908 - Updated the PatchChecker class to use a TextFileReader instance 3909 instead of a StyleChecker. 3910 3911 * Scripts/webkitpy/style/checker_unittest.py: 3912 - Added the StyleProcessor_EndToEndTest class to do "end-to-end" 3913 tests of the StyleProcessor class. 3914 - Added the StyleProcessor_CodeCoverageTest to test the 3915 StyleProcessor class with more complete code coverage. 3916 Unlike the StyleProcessor_EndToEndTest class, this class makes 3917 heavy use of mock parameters. 3918 - Added FIXME's to delete the unit test classes that are no 3919 longer needed. 3920 - Updated the PatchCheckerTest class to use a MockTextFileReader 3921 instead of a MockStyleChecker. 3922 3923 * Scripts/webkitpy/style/filereader.py: 3924 - Updated the TextFileReader class to use the preferred logic 3925 of checking file existence at the beginning of the process_file() 3926 method instead of in the except block, per 3927 https://bugs.webkit.org/show_bug.cgi?id=37122 3928 3929 * Scripts/webkitpy/style/filereader_unittest.py: 3930 - In the TextFileReaderTest class: 3931 - Moved the test_process_file__should_not_process() method. 3932 - Added a test_process_file__file_stdin() method to test 3933 the file path "-". 3934 39352010-04-20 Robert Hogan <robert@webkit.org> 3936 3937 Reviewed by Simon Hausmann. 3938 3939 [Qt] Add more support for textInputController 3940 3941 Add support for selectedRange(), setMarkedText(), insertText(), 3942 and firstRectForCharacterRange(). 3943 3944 Unskip tests: 3945 3946 fast/forms/input-maxlength-ime-preedit.html 3947 fast/forms/input-maxlength-ime-completed.html 3948 fast/text/international/thai-cursor-position.html 3949 fast/events/ime-composition-events-001.html 3950 editing/selection/5825350-1.html 3951 editing/selection/5825350-2.html 3952 editing/selection/mixed-editability-10.html 3953 3954 https://bugs.webkit.org/show_bug.cgi?id=35702 3955 3956 * DumpRenderTree/qt/TextInputControllerQt.cpp: 3957 (TextInputController::setMarkedText): 3958 (TextInputController::insertText): 3959 (TextInputController::selectedRange): 3960 (TextInputController::firstRectForCharacterRange): 3961 * DumpRenderTree/qt/TextInputControllerQt.h: 3962 39632010-04-23 Eric Seidel <eric@webkit.org> 3964 3965 Reviewed by Adam Barth. 3966 3967 check-webkit-style complains about non-utf8 data in layout test result 3968 https://bugs.webkit.org/show_bug.cgi?id=38027 3969 3970 The problem was we were assuming patch files/diff output as utf-8. 3971 Turns out they're not. We have to treat them as binary data because 3972 a single patch may have multiple text files in it with conflicting encodings! 3973 3974 * Scripts/webkitpy/common/checkout/api.py: 3975 - contents_at_revision returns a byte array, so decode it to unicode 3976 before passing it to parse_latest_entry_from_file 3977 * Scripts/webkitpy/common/checkout/api_unittest.py: 3978 - Update our mock mock_contents_at_revision to match the encoding 3979 semantics of the real one. 3980 * Scripts/webkitpy/common/checkout/scm.py: 3981 - Be careful not to decode output which may contain file contents 3982 (like diff, cat or show) as the encoding for that content is unknown. 3983 * Scripts/webkitpy/common/checkout/scm_unittest.py: 3984 - Update our tests to use both latin1 and utf-8 encoded data. 3985 * Scripts/webkitpy/common/net/bugzilla.py: 3986 - _fill_attachment_form should not assume unicode data. Callers 3987 may wish to attach other types of files to bugs. 3988 * Scripts/webkitpy/common/prettypatch.py: 3989 - Diffs are byte arrays, deal with them as such. 3990 * Scripts/webkitpy/common/prettypatch_unittest.py: 3991 - Test to make sure we handle diffs with multiple conflicting encodings. 3992 * Scripts/webkitpy/common/system/executive_unittest.py: 3993 - Make sure that our unicode support does not break our 3994 byte array input support for run_command. 3995 39962010-04-23 Sam Weinig <sam@webkit.org> 3997 3998 Reviewed by David Levin. 3999 4000 Fix for https://bugs.webkit.org/show_bug.cgi?id=38060 4001 Split up Threading.h 4002 4003 Add necessary forwarding headers. 4004 4005 * DumpRenderTree/ForwardingHeaders/wtf/Atomics.h: Added. 4006 * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Added. 4007 * DumpRenderTree/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added. 4008 40092010-04-23 Xiaomei Ji <xji@chromium.org> 4010 4011 No need to review. 4012 4013 Add xji as committer. 4014 4015 * Scripts/webkitpy/common/config/committers.py: 4016 40172010-04-23 Kevin Ollivier <kevino@theolliviers.com> 4018 4019 [wx] Build fix, add platform stub for new LayoutTestController method. 4020 4021 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 4022 (LayoutTestController::markerTextForListItem): 4023 40242010-04-19 Dirk Pranke <dpranke@chromium.org> 4025 4026 Reviewed by Adam Barth. 4027 4028 new-run-webkit-tests: add a "--retry-failures" flag and a 4029 "--no-retry-failures" flag (the former is the default). Also, rename 4030 "--print-unexpected-results" and "--retry-unexpected-results" to 4031 "--print-last-failures" and "--retry-last-failures" because the 4032 retry flag was confusing. The new flag names aren't great, but 4033 hopefully they're less confusing. 4034 4035 https://bugs.webkit.org/show_bug.cgi?id=37838 4036 4037 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 4038 40392010-04-22 Sam Weinig <sam@webkit.org> 4040 4041 Reviewed by Anders Carlsson. 4042 4043 Fix for https://bugs.webkit.org/show_bug.cgi?id=38022 4044 Move isMainThread predicate function to MainThread.h 4045 4046 Added forwarding header for MainThread.h 4047 4048 * DumpRenderTree/ForwardingHeaders/wtf/MainThread.h: Added. 4049 40502010-04-23 Laszlo Gombos <laszlo.1.gombos@nokia.com> 4051 4052 Reviewed by Kenneth Rohde Christiansen. 4053 4054 [Qt] Disable Netscape plugin support for minimal configuration 4055 https://bugs.webkit.org/show_bug.cgi?id=38026 4056 4057 Pass the minimal configuration option to Qt build system 4058 as part of the CONFIG variable. 4059 4060 * Scripts/build-webkit: 4061 40622010-04-22 Fumitoshi Ukai <ukai@chromium.org> 4063 4064 Unreviewed fix. 4065 4066 * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined. 4067 40682010-04-22 James Robinson <jamesr@chromium.org> 4069 4070 Reviewed by Adam Barth. 4071 4072 Revert 58077 and follow-ups. It's broken. 4073 https://bugs.webkit.org/show_bug.cgi?id=37664 4074 4075 * Scripts/new-run-webkit-httpd: 4076 * Scripts/new-run-webkit-websocketserver: 4077 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 4078 * Scripts/webkitpy/layout_tests/port/http_server.py: 4079 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 4080 40812010-04-22 Yaar Schnitman <yaar@chromium.org> 4082 4083 Reviewed by Adam Barth. 4084 4085 Integrate v8 testing utility with webkit tests 4086 https://bugs.webkit.org/show_bug.cgi?id=37731 4087 4088 * Scripts/run-bindings-tests: Added. 4089 40902010-04-22 Eric Seidel <eric@webkit.org> 4091 4092 Reviewed by Dimitri Glazkov. 4093 4094 new-run-webkit-tests --verbose shows ever-increasing #EOF lines 4095 https://bugs.webkit.org/show_bug.cgi?id=37794 4096 4097 * Scripts/webkitpy/layout_tests/port/webkit.py: 4098 - Remove the assert() since our ServerProcess code does not always 4099 seem to be reading the full stderr output (or we're not waiting for it to). 4100 41012010-04-22 Eric Seidel <eric@webkit.org> 4102 4103 Reviewed by Adam Barth. 4104 4105 Add code to help debug new-run-webkit-test hangs on the Chromium bots 4106 https://bugs.webkit.org/show_bug.cgi?id=38011 4107 4108 I can see no reasonable way to test this change. 4109 Stubbing out sys._current_frames() and traceback.extract_stack 4110 seems folly. Dumping real data would have line number 4111 (and possibly other call stack) variance between runs. 4112 4113 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 4114 - Add _dump_thread_states and _dump_thread_states_if_necessary 4115 to have our main thread dump the states of all threads every 4116 60 seconds when running in verbose mode. 4117 - Better document what is going on in our main loop. 4118 41192010-04-22 Sam Weinig <sam@webkit.org> 4120 4121 Reviewed by Anders Carlsson. 4122 4123 Fix for https://bugs.webkit.org/show_bug.cgi?id=38002 4124 Add rudimentary statistics gathering for WebKit2 4125 4126 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: 4127 * MiniBrowser/mac/AppDelegate.h: 4128 * MiniBrowser/mac/AppDelegate.m: 4129 (-[BrowserAppDelegate init]): 4130 (-[BrowserAppDelegate newWindow:]): 4131 (-[BrowserAppDelegate getCurrentPageNamespace]): 4132 (-[BrowserAppDelegate _setProcessModel:]): 4133 (-[BrowserAppDelegate showStatisticsWindow:]): 4134 (-[BrowserAppDelegate applicationWillTerminate:]): 4135 * MiniBrowser/mac/BrowserStatisticsWindow.xib: Added. 4136 * MiniBrowser/mac/BrowserStatisticsWindowController.h: Added. 4137 * MiniBrowser/mac/BrowserStatisticsWindowController.m: Added. 4138 (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]): 4139 (-[BrowserStatisticsWindowController dealloc]): 4140 (-[BrowserStatisticsWindowController windowDidLoad]): 4141 (-[BrowserStatisticsWindowController refreshStatistics:]): 4142 * MiniBrowser/mac/BrowserWindowController.h: 4143 * MiniBrowser/mac/English.lproj/MainMenu.xib: 4144 * MiniBrowser/mac/MiniBrowser_Prefix.pch: 4145 41462010-04-22 Dave Moore <davemoore@chromium.org> 4147 4148 Reviewed by Dimitri Glazkov. 4149 4150 Add test support for icon changes. 4151 4152 https://bugs.webkit.org/show_bug.cgi?id=33812 4153 4154 * DumpRenderTree/LayoutTestController.cpp: 4155 (LayoutTestController::LayoutTestController): 4156 (dumpIconChangesCallback): 4157 (LayoutTestController::staticFunctions): 4158 * DumpRenderTree/LayoutTestController.h: 4159 (LayoutTestController::dumpIconChanges): 4160 (LayoutTestController::setDumpIconChanges): 4161 * DumpRenderTree/win/FrameLoadDelegate.cpp: 4162 (FrameLoadDelegate::didChangeIcons): 4163 * DumpRenderTree/win/FrameLoadDelegate.h: 4164 * WinLauncher/WinLauncher.h: 4165 (WinLauncherWebHost::didChangeIcons): 4166 41672010-04-22 Eric Seidel <eric@webkit.org> 4168 4169 Unreviewed. Script fix. Will ask dpranke to look tomorrow. 4170 4171 new-run-webkit-tests --verbose shows ever-increasing #EOF lines 4172 https://bugs.webkit.org/show_bug.cgi?id=37794 4173 4174 The bots are seeing cases where .error is sometimes empty. 4175 Lets make the code not crash in that case for now. 4176 4177 * Scripts/webkitpy/layout_tests/port/webkit.py: 4178 41792010-04-22 Fumitoshi Ukai <ukai@chromium.org> 4180 4181 Unreviewed fix. 4182 4183 * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined. 4184 41852010-04-22 Fumitoshi Ukai <ukai@chromium.org> 4186 4187 Unreviewed fix. 4188 4189 * Scripts/new-run-webkit-websocketserver: PyWebSocket no longer takes keyword argument 'register_cygwin'. 4190 41912010-04-22 Eric Seidel <eric@webkit.org> 4192 4193 Unreviewed. Restore the Leopard bots to using 4194 old-run-webkit-tests for now. 4195 4196 * Scripts/run-webkit-tests: 4197 41982010-04-22 Fumitoshi Ukai <ukai@chromium.org> 4199 4200 Unreviewed fix. 4201 4202 * Scripts/webkitpy/layout_tests/port/http_server.py: fix NameError: global name 'env' is not defined. 4203 42042010-04-22 Fumitoshi Ukai <ukai@chromium.org> 4205 4206 Unreviewed fix. 4207 4208 * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'env' is not defined. 4209 42102010-04-22 Fumitoshi Ukai <ukai@chromium.org> 4211 4212 Reviewed by Adam Barth. 4213 4214 Chromium: Add --chromium option to new-run-webkit-websocketserver 4215 https://bugs.webkit.org/show_bug.cgi?id=37664 4216 4217 Move cygwin setup logic in chromium_win.py. 4218 4219 * Scripts/new-run-webkit-httpd: remove register_cygwin parameter to pass http_server. 4220 * Scripts/new-run-webkit-websocketserver: add --chromium flag 4221 * Scripts/webkitpy/layout_tests/port/chromium_win.py: setup for cygwin 4222 * Scripts/webkitpy/layout_tests/port/http_server.py: remove cygwin setup logic 4223 * Scripts/webkitpy/layout_tests/port/websocket_server.py: remove cygwin setup logic 4224 42252010-04-22 Eric Seidel <eric@webkit.org> 4226 4227 Reviewed by Adam Barth. 4228 4229 new-run-webkit-tests --verbose shows ever-increasing #EOF lines 4230 https://bugs.webkit.org/show_bug.cgi?id=37794 4231 4232 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 4233 - Fix the log message to explain that this is stderr output, not test output. 4234 * Scripts/webkitpy/layout_tests/port/webkit.py: 4235 - Be sure to reset the server_process.error after reading (seems like the wrong 4236 place to do this, but at least this fixes the bug and dpranke and I can talk 4237 about better designs later). 4238 - Also remove the #EOF from the stderr output before returning it. 4239 42402010-04-22 Eric Seidel <eric@webkit.org> 4241 4242 Unreviewed. Fixing new-run-webkit-tests on the bots. 4243 4244 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 4245 - Fixing _compat_shim_option to take variable keyword args. 4246 - Turns out that nargs + callback is ignored unless type is specified. 4247 So I added the type so that the option was properly consumed. 4248 This was why new-run-webkit-tests couldn't find any tests, it 4249 was looking for them under "20" because that was the argument 4250 which should have been consumed by --exit-after-n-failures. 4251 42522010-04-22 Tony Chang <tony@chromium.org> 4253 4254 Not reviewed, build fix for chromium Windows. 4255 4256 [chromium] fix ImageDiff compile on windows 4257 https://bugs.webkit.org/show_bug.cgi?id=37979 4258 4259 * DumpRenderTree/chromium/ImageDiff.cpp: 4260 42612010-04-22 Adam Barth <abarth@webkit.org> 4262 4263 Unreviewed, rolling out r58069. 4264 http://trac.webkit.org/changeset/58069 4265 https://bugs.webkit.org/show_bug.cgi?id=27751 4266 4267 Broke compile on Windows. 4268 4269 * DumpRenderTree/LayoutTestController.cpp: 4270 (LayoutTestController::staticFunctions): 4271 * DumpRenderTree/LayoutTestController.h: 4272 * DumpRenderTree/chromium/LayoutTestController.cpp: 4273 (LayoutTestController::LayoutTestController): 4274 (LayoutTestController::overridePreference): 4275 * DumpRenderTree/chromium/LayoutTestController.h: 4276 * DumpRenderTree/chromium/TestShell.cpp: 4277 (TestShell::resetWebSettings): 4278 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 4279 * DumpRenderTree/mac/DumpRenderTree.mm: 4280 (resetDefaultsToConsistentValues): 4281 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 4282 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 4283 (WebCore::WebPage::WebPage): 4284 (WebCore::WebPage::resetSettings): 4285 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 4286 * DumpRenderTree/qt/LayoutTestControllerQt.h: 4287 * DumpRenderTree/win/DumpRenderTree.cpp: 4288 (resetDefaultsToConsistentValues): 4289 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 4290 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 4291 42922010-04-22 Eric Seidel <eric@webkit.org> 4293 4294 Unreviewed. Just adding logging. 4295 4296 Adding logging to help debug why the Leopard Bot 4297 can't find any tests to run. 4298 4299 * Scripts/webkitpy/layout_tests/layout_package/test_files.py: 4300 * Scripts/webkitpy/layout_tests/port/base.py: 4301 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 4302 - Make it a fatal error to have no tests to run. 4303 43042010-04-22 Abhishek Arya <inferno@chromium.org> 4305 4306 Reviewed by Adam Barth. 4307 4308 Add support for controlling clipboard access from javascript. 4309 Clipboard access from javascript is enabled in test framework. 4310 https://bugs.webkit.org/show_bug.cgi?id=27751 4311 4312 * DumpRenderTree/LayoutTestController.cpp: 4313 (setJavaScriptCanAccessClipboardCallback): 4314 (LayoutTestController::staticFunctions): 4315 * DumpRenderTree/LayoutTestController.h: 4316 * DumpRenderTree/chromium/LayoutTestController.cpp: 4317 (LayoutTestController::LayoutTestController): 4318 (LayoutTestController::setJavaScriptCanAccessClipboard): 4319 (LayoutTestController::overridePreference): 4320 * DumpRenderTree/chromium/LayoutTestController.h: 4321 * DumpRenderTree/chromium/TestShell.cpp: 4322 (TestShell::resetWebSettings): 4323 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 4324 (LayoutTestController::setJavaScriptCanAccessClipboard): 4325 * DumpRenderTree/mac/DumpRenderTree.mm: 4326 (resetDefaultsToConsistentValues): 4327 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 4328 (LayoutTestController::setJavaScriptCanAccessClipboard): 4329 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 4330 (WebCore::WebPage::WebPage): 4331 (WebCore::WebPage::resetSettings): 4332 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 4333 (LayoutTestController::setJavaScriptCanAccessClipboard): 4334 * DumpRenderTree/qt/LayoutTestControllerQt.h: 4335 * DumpRenderTree/win/DumpRenderTree.cpp: 4336 (resetDefaultsToConsistentValues): 4337 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 4338 (LayoutTestController::setJavaScriptCanAccessClipboard): 4339 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 4340 (LayoutTestController::setJavaScriptCanAccessClipboard): 4341 43422010-04-21 Adam Barth <abarth@webkit.org> 4343 4344 Reviewed by Eric Seidel. 4345 4346 webkit-patch can't fetch attachments on security bugs 4347 https://bugs.webkit.org/show_bug.cgi?id=37975 4348 4349 Instead of calling CURL, we just need to use our Mechanize object, 4350 which understand bugs.webkit.org authentication. 4351 4352 * Scripts/webkitpy/common/checkout/api.py: 4353 * Scripts/webkitpy/common/net/bugzilla.py: 4354 43552010-04-21 Eric Seidel <eric@webkit.org> 4356 4357 Unreviewed. Temporary commit, will roll-out before morning. 4358 4359 Turning on new-run-webkit-tests for the Leopard build bot 4360 for testing of the harness. 4361 Users should not noctice (except for the results.html difference). 4362 4363 * Scripts/run-webkit-tests: 4364 43652010-04-21 Eric Seidel <eric@webkit.org> 4366 4367 Unreviewed. Fix typo in my previous fix attempt. 4368 4369 REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø 4370 https://bugs.webkit.org/show_bug.cgi?id=37765 4371 4372 More on-the-bot debugging, sigh. I wish I had a local build. 4373 4374 * Scripts/webkitpy/layout_tests/port/base.py: 4375 43762010-04-21 Eric Seidel <eric@webkit.org> 4377 4378 Unreviewed. Fix typo in my previous fix attempt. 4379 4380 REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø 4381 https://bugs.webkit.org/show_bug.cgi?id=37765 4382 4383 * Scripts/webkitpy/layout_tests/port/base.py: 4384 - Add self. to class variable access. 4385 43862010-04-21 Eric Seidel <eric@webkit.org> 4387 4388 Unreviewed. Another attempt to fix NRWT for chromium. 4389 4390 REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø 4391 https://bugs.webkit.org/show_bug.cgi?id=37765 4392 4393 * Scripts/webkitpy/layout_tests/port/base.py: 4394 - wdiff_text was returning a byte array instead of a 4395 unicode string. The simple fix was to just decode 4396 the result. However, seeing so much duplicated code 4397 with Executive made me cry, so I re-wrote the function 4398 to be more like pretty_patch_text and use run_command 4399 (which already knows how to handle unicode). 4400 44012010-04-21 Adam Barth <abarth@webkit.org> 4402 4403 Reviewed by Eric Seidel. 4404 4405 Windows tests buildbots are too slow to be core builders 4406 https://bugs.webkit.org/show_bug.cgi?id=37970 4407 4408 It's 10:45. The Windows test bots are still hours behind. They're too 4409 slow to be core builders. When they get fast, we can add them back. 4410 4411 * Scripts/webkitpy/common/net/buildbot.py: 4412 * Scripts/webkitpy/common/net/buildbot_unittest.py: 4413 44142010-04-21 Eric Seidel <eric@webkit.org> 4415 4416 Unreviewed. Attempt one more time to fix NRWT for chromium. 4417 4418 REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø 4419 https://bugs.webkit.org/show_bug.cgi?id=37765 4420 4421 I'm debugging in the blind because I don't have a chromium 4422 build on this laptop. 4423 4424 * Scripts/webkitpy/layout_tests/port/chromium.py: 4425 - Apply the previous fix to a second caller. 4426 44272010-04-21 Eric Seidel <eric@webkit.org> 4428 4429 Unreviewed. Attempt one more time to fix NRWT for chromium. 4430 4431 REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø 4432 https://bugs.webkit.org/show_bug.cgi?id=37765 4433 4434 * Scripts/webkitpy/layout_tests/port/chromium.py: 4435 - Fix handling of test_shell output so that we always 4436 decode it as utf-8. 4437 Unlike DumpRenderTree test_shell does not ever return 4438 pixel data. It spits out the pixel dumps in a separate 4439 file, thus all output over stdout is utf-8 text. 4440 44412010-04-21 Eric Seidel <eric@webkit.org> 4442 4443 Unreviewed. Attempt one more time to fix NRWT for chromium. 4444 4445 REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø 4446 https://bugs.webkit.org/show_bug.cgi?id=37765 4447 4448 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 4449 - Pass encoding to _save_baseline_data and write_output_files 4450 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 4451 - Make _save_baseline_data and write_output_files take an encoding. 4452 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 4453 - Pass encoding to _save_baseline_data and write_output_files 4454 44552010-04-21 No'am Rosenthal <noam.rosenthal@nokia.com> 4456 4457 Reviewed by Kenneth Rohde Christiansen. 4458 4459 [Qt] QtLauncher: make FPS measurement accurate 4460 https://bugs.webkit.org/show_bug.cgi?id=37934 4461 4462 Instead of counting paints, which are not interchangeable with frames that 4463 the user sees, we now set an arbitrary timer for FPS measurements. The idea is 4464 that if the main thread is delayed for any reason, that timer would be delayed 4465 as well. 4466 4467 * QtLauncher/QtLauncher.pro: 4468 * QtLauncher/fpstimer.cpp: Added. 4469 (FpsTimer::FpsTimer): 4470 (FpsTimer::numFrames): 4471 (FpsTimer::start): 4472 (FpsTimer::stop): 4473 (FpsTimer::timerEvent): 4474 * QtLauncher/fpstimer.h: Added. 4475 * QtLauncher/webview.cpp: 4476 (WebViewGraphicsBased::setFrameRateMeasurementEnabled): 4477 (WebViewGraphicsBased::updateFrameRate): 4478 (WebViewGraphicsBased::paintEvent): 4479 * QtLauncher/webview.h: 4480 44812010-04-21 Eric Seidel <eric@webkit.org> 4482 4483 Unreviewed, just adding missing ":" in python file. 4484 4485 REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø 4486 https://bugs.webkit.org/show_bug.cgi?id=37765 4487 4488 new-run-webkit-tests --chromium was borked. 4489 4490 * Scripts/webkitpy/layout_tests/port/chromium.py: 4491 44922010-04-21 Eric Seidel <eric@webkit.org> 4493 4494 Reviewed by Adam Barth. 4495 4496 REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø 4497 https://bugs.webkit.org/show_bug.cgi?id=37765 4498 4499 Third time is the charm. I've fixed all the 4500 new-run-webkit-tests regressions from previous attempts. 4501 4502 I fixed the queue to not ignore Tor as a reviwer in r57531, 4503 but instead it throws an exception every time his name is in a patch. 4504 4505 This fixes our Executive.run_command code to work around a Popen 4506 bug http://bugs.python.org/issue5290 whereby python versions before 2.6 4507 do not correctly handle unicode objects as input or output to 4508 Popen.communicate. 4509 4510 Following the advice of: 4511 http://farmdev.com/talks/unicode/ 4512 I have changed all of webkitpy to use unicode() objects as strings 4513 instead of str objects (which in Python 3 are renamed "bytes"). 4514 4515 String literals were left as "foo" instead of converting to u"foo" 4516 as u"foo" is only required if the string has a non-ascii code point. 4517 Python is smart about comparing str() and unicode() values and will 4518 log an error to the console if the comparison is ever invalid. 4519 4520 Executive.run* now correctly accept and return unicode() objects. 4521 I attempted to fix all the places that we call .write() to make sure we 4522 encode any unicode() objects into utf-8. 4523 4524 I removed several uses of StringIO. StringIO should generally always be 4525 passed a unicode() value. 4526 4527 Likewise I replaced most calls to open() with codecs.open(). 4528 codecs.open() matches Python 3 open semantics in requiring an encoding 4529 parameter. Files opened with codecs.open() with a unicode-compatible 4530 encoding will vend unicode() objects from their read() calls, like how 4531 StringIO created with a unicode() object will do. 4532 4533 I also deployed "with" statements wider (now that the project has 4534 settled on Python 2.5) to close a bunch of file descriptor leaks. 4535 4536 * Scripts/webkitpy/common/checkout/api_unittest.py: 4537 - Read/write utf-8 files instead of ascii. 4538 - Update the tests to use test for proper unicode() handling. 4539 * Scripts/webkitpy/common/checkout/changelog.py: 4540 - Document that parse_latest_entry_from_file expects 4541 file-like objects which return unicode strings. 4542 * Scripts/webkitpy/common/checkout/changelog_unittest.py: 4543 - Use unicode() strings instead of str() byte arrays. 4544 - Deploy "with" to close file descriptor leaks. 4545 * Scripts/webkitpy/common/checkout/commitinfo.py: 4546 - Remove unneeded import. 4547 * Scripts/webkitpy/common/checkout/scm.py: 4548 - Remove use of str(). 4549 * Scripts/webkitpy/common/checkout/scm_unittest.py: 4550 - Read/write utf-8 files and use unicode() strings in testing. 4551 * Scripts/webkitpy/common/config/committers.py: 4552 - Use \u instead of \x to make slightly clearer what we're doing. 4553 * Scripts/webkitpy/common/net/bugzilla.py: 4554 - Add a new _string_contents() method and explain why 4555 we have to call unicode() on the result of soup.string 4556 and why it's safe to do so w/o needing to pass a codec name. 4557 - Remove the (unused) support for passing a file object to add_patch_to_bug(). 4558 * Scripts/webkitpy/common/net/buildbot.py: 4559 - Use unicode() instead of str() when needing to coax a 4560 NavigableString object into a unicode() object. 4561 * Scripts/webkitpy/common/net/buildbot_unittest.py: 4562 - Add a test which contains a unicode builder name. 4563 * Scripts/webkitpy/common/net/statusserver.py: 4564 - Remove use of str() 4565 * Scripts/webkitpy/common/prettypatch.py: 4566 - Write out the patch file as utf-8. 4567 * Scripts/webkitpy/common/system/autoinstall.py: 4568 - Write out files with a explicit encodings. 4569 - Deploy "with" to close file descriptor leaks. 4570 * Scripts/webkitpy/common/system/deprecated_logging.py: 4571 - Write out log files as utf-8. 4572 * Scripts/webkitpy/common/system/executive.py: 4573 - Make run* properly take and return unicode() objects. 4574 - Cleaned up input handling in run_command a little by adding 4575 a _compute_input() method which can return early instead of having 4576 such a long/cluttered if-block. 4577 * Scripts/webkitpy/common/system/executive_unittest.py: 4578 - Added a unit test to make sure we don't break Tor again! 4579 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 4580 - Write out the test list as utf-8. 4581 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 4582 - Write out json files as utf-8. 4583 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 4584 - Deploy "with" to close file descriptor leaks. 4585 * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME. 4586 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto. 4587 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto. 4588 * Scripts/webkitpy/layout_tests/port/gtk.py: ditto. 4589 * Scripts/webkitpy/layout_tests/port/mac.py: ditto. 4590 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 4591 - Make the skipped file parsing test unicode. 4592 * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME. 4593 * Scripts/webkitpy/layout_tests/port/server_process.py: ditto. 4594 * Scripts/webkitpy/layout_tests/port/webkit.py: 4595 - Deploy "with" to close file descriptor leaks. 4596 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 4597 - Make explicit the encodings of log files and pid files. 4598 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 4599 - Make encodings explicit and deploy "with". 4600 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto. 4601 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto. 4602 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto. 4603 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto. 4604 * Scripts/webkitpy/style/filereader_unittest.py: ditto. 4605 * Scripts/webkitpy/thirdparty/__init__.py: ditto. 4606 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 4607 - Removed extra import. 4608 * Scripts/webkitpy/tool/commands/queues.py: 4609 - No need to map args to strings now that run_command does. 4610 - Update test results to match args changes. 4611 - Document our global argument hacks. 4612 * Scripts/webkitpy/tool/commands/upload.py: 4613 - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper. 4614 * Scripts/webkitpy/tool/mocktool.py: 4615 - Rename add_patch_to_bug argument to match bugzilla.py 4616 * Scripts/webkitpy/tool/steps/abstractstep.py: 4617 - Executive.run_* now require lists instead of strings. 4618 The lack of this change was what broke webkit-patch 4619 for svn users the first time this was landed. 4620 * Scripts/webkitpy/tool/steps/postdiff.py: 4621 - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper. 4622 * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto 4623 * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto 4624 * Scripts/webkitpy/tool/steps/steps_unittest.py: 4625 - Fixed spurious logging seen when running test-webkitpy 4626 46272010-04-21 Chris Fleizach <cfleizach@apple.com> 4628 4629 Reviewed by Alexey Proskuryakov. 4630 4631 aria-liveregion-notifications.html fails on leopard release bot 4632 https://bugs.webkit.org/show_bug.cgi?id=37112 4633 4634 Change the way that notifications are listened for by forcing clients 4635 to call a remove listener as well to match the add listener. DRT will 4636 assert if those are not done in the correct order. 4637 4638 * DumpRenderTree/AccessibilityUIElement.cpp: 4639 (removeNotificationListenerCallback): 4640 (AccessibilityUIElement::getJSClass): 4641 * DumpRenderTree/AccessibilityUIElement.h: 4642 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 4643 (AccessibilityUIElement::removeNotificationListener): 4644 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 4645 (-[AccessibilityNotificationHandler initWithPlatformElement:]): 4646 (-[AccessibilityNotificationHandler dealloc]): 4647 (-[AccessibilityNotificationHandler _notificationReceived:]): 4648 (-[AccessibilityNotificationHandler setCallback:]): 4649 (AccessibilityUIElement::AccessibilityUIElement): 4650 (AccessibilityUIElement::~AccessibilityUIElement): 4651 (AccessibilityUIElement::addNotificationListener): 4652 (AccessibilityUIElement::removeNotificationListener): 4653 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 4654 (AccessibilityUIElement::removeNotificationListener): 4655 46562010-04-21 Anders Carlsson <andersca@apple.com> 4657 4658 Reviewed by Sam Weinig. 4659 4660 Add debug menu items to show/hide the Web View. 4661 https://bugs.webkit.org/show_bug.cgi?id=37958 4662 4663 * MiniBrowser/mac/BrowserWindowController.h: 4664 * MiniBrowser/mac/BrowserWindowController.m: 4665 (-[BrowserWindowController showHideWebView:]): 4666 (-[BrowserWindowController removeReinsertWebView:]): 4667 (-[BrowserWindowController validateMenuItem:]): 4668 * MiniBrowser/mac/English.lproj/MainMenu.xib: 4669 46702010-04-21 Eric Seidel <eric@webkit.org> 4671 4672 Unreviewed. Rolling out unicode() changes as they broke NRWT for chromium. 4673 Rolling out: 4674 http://trac.webkit.org/changeset/58014 4675 http://trac.webkit.org/changeset/58016 4676 http://trac.webkit.org/changeset/58020 4677 4678 REGRESSION(57531): the commit-queue still hates Tor Arne Vestbo 4679 https://bugs.webkit.org/show_bug.cgi?id=37765 4680 4681 * Scripts/webkitpy/common/checkout/api_unittest.py: 4682 * Scripts/webkitpy/common/checkout/changelog.py: 4683 * Scripts/webkitpy/common/checkout/changelog_unittest.py: 4684 * Scripts/webkitpy/common/checkout/commitinfo.py: 4685 * Scripts/webkitpy/common/checkout/scm.py: 4686 * Scripts/webkitpy/common/checkout/scm_unittest.py: 4687 * Scripts/webkitpy/common/config/committers.py: 4688 * Scripts/webkitpy/common/net/bugzilla.py: 4689 * Scripts/webkitpy/common/net/buildbot.py: 4690 * Scripts/webkitpy/common/net/buildbot_unittest.py: 4691 * Scripts/webkitpy/common/net/statusserver.py: 4692 * Scripts/webkitpy/common/prettypatch.py: 4693 * Scripts/webkitpy/common/system/autoinstall.py: 4694 * Scripts/webkitpy/common/system/deprecated_logging.py: 4695 * Scripts/webkitpy/common/system/executive.py: 4696 * Scripts/webkitpy/common/system/executive_unittest.py: 4697 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 4698 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 4699 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 4700 * Scripts/webkitpy/layout_tests/port/chromium.py: 4701 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 4702 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 4703 * Scripts/webkitpy/layout_tests/port/gtk.py: 4704 * Scripts/webkitpy/layout_tests/port/mac.py: 4705 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 4706 * Scripts/webkitpy/layout_tests/port/qt.py: 4707 * Scripts/webkitpy/layout_tests/port/server_process.py: 4708 * Scripts/webkitpy/layout_tests/port/webkit.py: 4709 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 4710 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 4711 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 4712 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 4713 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 4714 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 4715 * Scripts/webkitpy/style/filereader_unittest.py: 4716 * Scripts/webkitpy/thirdparty/__init__.py: 4717 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 4718 * Scripts/webkitpy/tool/commands/queues.py: 4719 * Scripts/webkitpy/tool/commands/queues_unittest.py: 4720 * Scripts/webkitpy/tool/commands/upload.py: 4721 * Scripts/webkitpy/tool/mocktool.py: 4722 * Scripts/webkitpy/tool/steps/abstractstep.py: 4723 * Scripts/webkitpy/tool/steps/postdiff.py: 4724 * Scripts/webkitpy/tool/steps/postdiffforcommit.py: 4725 * Scripts/webkitpy/tool/steps/postdiffforrevert.py: 4726 * Scripts/webkitpy/tool/steps/steps_unittest.py: 4727 47282010-04-21 Eric Seidel <eric@webkit.org> 4729 4730 Unreviewed, fixing NRWT for real this time. 4731 4732 REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø 4733 https://bugs.webkit.org/show_bug.cgi?id=37765 4734 4735 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 4736 - Add a hack to fix new-run-webkit-tests 4737 my understanding of codecs.open(encoding=None) 4738 must have been wrong. 4739 47402010-04-21 Eric Seidel <eric@webkit.org> 4741 4742 Unreviewed, just fixing exception seen on builders. 4743 4744 REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø 4745 https://bugs.webkit.org/show_bug.cgi?id=37765 4746 4747 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 4748 - Pass and encoding to _write_into_file_at_path 4749 47502010-04-21 Eric Seidel <eric@webkit.org> 4751 4752 Reviewed by Adam Barth. 4753 4754 REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø 4755 https://bugs.webkit.org/show_bug.cgi?id=37765 4756 4757 I fixed the queue to not ignore Tor as a reviwer in r57531, 4758 but instead it throws an exception every time his name is in a patch. 4759 4760 This fixes our Executive.run_command code to work around a Popen 4761 bug http://bugs.python.org/issue5290 whereby python versions before 2.6 4762 do not correctly handle unicode objects as input or output to 4763 Popen.communicate. 4764 4765 Following the advice of: 4766 http://farmdev.com/talks/unicode/ 4767 I have changed all of webkitpy to use unicode() objects as strings 4768 instead of str objects (which in Python 3 are renamed "bytes"). 4769 4770 String literals were left as "foo" instead of converting to u"foo" 4771 as u"foo" is only required if the string has a non-ascii code point. 4772 Python is smart about comparing str() and unicode() values and will 4773 log an error to the console if the comparison is ever invalid. 4774 4775 Executive.run* now correctly accept and return unicode() objects. 4776 I attempted to fix all the places that we call .write() to make sure we 4777 encode any unicode() objects into utf-8. 4778 4779 I removed several uses of StringIO. StringIO should generally always be 4780 passed a unicode() value. 4781 4782 Likewise I replaced most calls to open() with codecs.open(). 4783 codecs.open() matches Python 3 open semantics in requiring an encoding 4784 parameter. Files opened with codecs.open() with a unicode-compatible 4785 encoding will vend unicode() objects from their read() calls, like how 4786 StringIO created with a unicode() object will do. 4787 4788 I also deployed "with" statements wider (now that the project has 4789 settled on Python 2.5) to close a bunch of file descriptor leaks. 4790 4791 * Scripts/webkitpy/common/checkout/api_unittest.py: 4792 - Read/write utf-8 files instead of ascii. 4793 - Update the tests to use test for proper unicode() handling. 4794 * Scripts/webkitpy/common/checkout/changelog.py: 4795 - Document that parse_latest_entry_from_file expects 4796 file-like objects which return unicode strings. 4797 * Scripts/webkitpy/common/checkout/changelog_unittest.py: 4798 - Use unicode() strings instead of str() byte arrays. 4799 - Deploy "with" to close file descriptor leaks. 4800 * Scripts/webkitpy/common/checkout/commitinfo.py: 4801 - Remove unneeded import. 4802 * Scripts/webkitpy/common/checkout/scm.py: 4803 - Remove use of str(). 4804 * Scripts/webkitpy/common/checkout/scm_unittest.py: 4805 - Read/write utf-8 files and use unicode() strings in testing. 4806 * Scripts/webkitpy/common/config/committers.py: 4807 - Use \u instead of \x to make slightly clearer what we're doing. 4808 * Scripts/webkitpy/common/net/bugzilla.py: 4809 - Add a new _string_contents() method and explain why 4810 we have to call unicode() on the result of soup.string 4811 and why it's safe to do so w/o needing to pass a codec name. 4812 - Remove the (unused) support for passing a file object to add_patch_to_bug(). 4813 * Scripts/webkitpy/common/net/buildbot.py: 4814 - Use unicode() instead of str() when needing to coax a 4815 NavigableString object into a unicode() object. 4816 * Scripts/webkitpy/common/net/buildbot_unittest.py: 4817 - Add a test which contains a unicode builder name. 4818 * Scripts/webkitpy/common/net/statusserver.py: 4819 - Remove use of str() 4820 * Scripts/webkitpy/common/prettypatch.py: 4821 - Write out the patch file as utf-8. 4822 * Scripts/webkitpy/common/system/autoinstall.py: 4823 - Write out files with a explicit encodings. 4824 - Deploy "with" to close file descriptor leaks. 4825 * Scripts/webkitpy/common/system/deprecated_logging.py: 4826 - Write out log files as utf-8. 4827 * Scripts/webkitpy/common/system/executive.py: 4828 - Make run* properly take and return unicode() objects. 4829 - Cleaned up input handling in run_command a little by adding 4830 a _compute_input() method which can return early instead of having 4831 such a long/cluttered if-block. 4832 * Scripts/webkitpy/common/system/executive_unittest.py: 4833 - Added a unit test to make sure we don't break Tor again! 4834 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 4835 - Write out the test list as utf-8. 4836 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 4837 - Write out json files as utf-8. 4838 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 4839 - Deploy "with" to close file descriptor leaks. 4840 * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME. 4841 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto. 4842 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto. 4843 * Scripts/webkitpy/layout_tests/port/gtk.py: ditto. 4844 * Scripts/webkitpy/layout_tests/port/mac.py: ditto. 4845 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 4846 - Make the skipped file parsing test unicode. 4847 * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME. 4848 * Scripts/webkitpy/layout_tests/port/server_process.py: ditto. 4849 * Scripts/webkitpy/layout_tests/port/webkit.py: 4850 - Deploy "with" to close file descriptor leaks. 4851 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 4852 - Make explicit the encodings of log files and pid files. 4853 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 4854 - Make encodings explicit and deploy "with". 4855 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto. 4856 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto. 4857 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto. 4858 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto. 4859 * Scripts/webkitpy/style/filereader_unittest.py: ditto. 4860 * Scripts/webkitpy/thirdparty/__init__.py: ditto. 4861 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 4862 - Removed extra import. 4863 * Scripts/webkitpy/tool/commands/queues.py: 4864 - No need to map args to strings now that run_command does. 4865 - Update test results to match args changes. 4866 - Document our global argument hacks. 4867 * Scripts/webkitpy/tool/commands/upload.py: 4868 - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper. 4869 * Scripts/webkitpy/tool/mocktool.py: 4870 - Rename add_patch_to_bug argument to match bugzilla.py 4871 * Scripts/webkitpy/tool/steps/abstractstep.py: 4872 - Executive.run_* now require lists instead of strings. 4873 The lack of this change was what broke webkit-patch 4874 for svn users the first time this was landed. 4875 * Scripts/webkitpy/tool/steps/postdiff.py: 4876 - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper. 4877 * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto 4878 * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto 4879 * Scripts/webkitpy/tool/steps/steps_unittest.py: 4880 - Fixed spurious logging seen when running test-webkitpy 4881 48822010-04-21 Kinuko Yasuda <kinuko@chromium.org> 4883 4884 Unreviewed. 4885 4886 Add myself in committers.py. 4887 4888 * Scripts/webkitpy/common/config/committers.py: 4889 48902010-04-21 Dirk Pranke <dpranke@chromium.org> 4891 4892 Reviewed by Dimitri Glazkov. 4893 4894 new-run-webkit-tests: fix a bug in the Chromium port where we would 4895 try to talk to a crashed test_shell and raise exceptions that weren't 4896 being caught. 4897 4898 https://bugs.webkit.org/show_bug.cgi?id=37941 4899 4900 * Scripts/webkitpy/layout_tests/port/chromium.py: 4901 49022010-04-21 Laszlo Gombos <laszlo.1.gombos@nokia.com> 4903 4904 Unreviewed. 4905 4906 [Qt] [Symbian] Build fix. 4907 4908 Work around a Qt quirk. Some versions of Symbian port Qt 4909 QFontDatabase::removeAllApplicationFonts symbol is not available. 4910 4911 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 4912 (WebCore::DumpRenderTree::open): 4913 49142010-04-21 Alexey Proskuryakov <ap@apple.com> 4915 4916 Unreviewed. 4917 4918 https://bugs.webkit.org/show_bug.cgi?id=37933 4919 <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced. 4920 4921 Adding stub implementation of authenticateSession(). Depending on platform loader behavior, 4922 a real implementation may or may not be necessary for the one test that currently uses it 4923 to pass. 4924 4925 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 4926 (LayoutTestController::authenticateSession): 4927 * DumpRenderTree/qt/LayoutTestControllerQt.h: 4928 49292010-04-21 Alexey Proskuryakov <ap@apple.com> 4930 4931 Reviewed by Brady Eidson. 4932 4933 https://bugs.webkit.org/show_bug.cgi?id=37933 4934 <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced. 4935 4936 Adding authenticateSession() method that adds credentials to per-process credential storage 4937 (for platforms that even have such). No Windows implementation, because writing another 4938 loader for DRT is painful. 4939 4940 * DumpRenderTree/LayoutTestController.cpp: 4941 (authenticateSessionCallback): 4942 (LayoutTestController::staticFunctions): 4943 * DumpRenderTree/LayoutTestController.h: 4944 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 4945 (-[SynchronousLoader dealloc]): 4946 (-[SynchronousLoader connectionShouldUseCredentialStorage:]): 4947 (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): 4948 (-[SynchronousLoader connection:didFailWithError:]): 4949 (-[SynchronousLoader connectionDidFinishLoading:]): 4950 (+[SynchronousLoader makeRequest:withUsername:password:]): 4951 (LayoutTestController::authenticateSession): 4952 4953 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 4954 (LayoutTestController::authenticateSession): 4955 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 4956 (LayoutTestController::authenticateSession): 4957 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 4958 (LayoutTestController::authenticateSession): 4959 Stub implementations. 4960 49612010-04-21 Kent Tamura <tkent@chromium.org> 4962 4963 Reviewed by Dimitri Glazkov. 4964 4965 [DRT/Chromium] Make DRT compilable in Chromium tree 4966 https://bugs.webkit.org/show_bug.cgi?id=37923 4967 4968 We need to use different GYPs in a case of WebKit-only checkout 4969 and a case of whole Chromium checkout because the relative paths 4970 from webkit/ to WebKit/chromium/features.gypi are different in 4971 these cases and we can't use 'conditions' for 'includes' in GYPs. 4972 4973 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 4974 49752010-04-21 Jakub Wieczorek <jwieczorek@webkit.org> 4976 4977 Reviewed by Darin Adler. 4978 4979 List item markers are not always updated after changes in the DOM. 4980 https://bugs.webkit.org/show_bug.cgi?id=37060 4981 4982 * DumpRenderTree/LayoutTestController.cpp: 4983 (markerTextForListItemCallback): A function that returns the marker text for a given list item. 4984 (LayoutTestController::staticFunctions): 4985 * DumpRenderTree/LayoutTestController.h: 4986 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 4987 (LayoutTestController::markerTextForListItem): Implement it in the GTK port. 4988 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 4989 (LayoutTestController::markerTextForListItem): Add a stub. 4990 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 4991 (LayoutTestController::LayoutTestController): 4992 (LayoutTestController::markerTextForListItem): Implement it in the Qt port. 4993 * DumpRenderTree/qt/LayoutTestControllerQt.h: 4994 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 4995 (LayoutTestController::markerTextForListItem): Add a stub. 4996 49972010-04-21 Adam Roben <aroben@apple.com> 4998 4999 Exclude leaks in CGGradientCreateWithColorComponents from 5000 run-webkit-tests leaks output 5001 5002 The leak in CG is covered by <rdar://problem/7888492>. 5003 5004 Fixes <http://webkit.org/b/37927>. 5005 5006 Reviewed by Eric Carlson. 5007 5008 * Scripts/old-run-webkit-tests: 5009 (sub countAndPrintLeaks): Exclude leaks in 5010 CGGradientCreateWithColorComponents on certain OSs. 5011 50122010-04-21 Kent Tamura <tkent@chromium.org> 5013 5014 Reviewed by Shinichiro Hamaji. 5015 5016 [DRT/Chromium] Import MockSpellCheck from Chromium 5017 https://bugs.webkit.org/show_bug.cgi?id=37910 5018 5019 Import webkit/tools/test_shell/mock_spellcheck.{cc,h} rev.37241 of Chromium. 5020 5021 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 5022 Add ICU explicitly because WTFString.h includes ICU headers. 5023 Add MockSpellCheck.{cpp,h}. 5024 * DumpRenderTree/chromium/MockSpellCheck.cpp: Added. 5025 * DumpRenderTree/chromium/MockSpellCheck.h: Added. 5026 * DumpRenderTree/chromium/WebViewHost.cpp: 5027 (WebViewHost::spellCheck): 5028 * DumpRenderTree/chromium/WebViewHost.h: 5029 * DumpRenderTree/chromium/config.h: Define JS_EXPORTDATA, which is used 5030 by wtf/text/AtomicString.h included by wtf/text/WTFString.h. 5031 50322010-04-21 Adam Barth <abarth@webkit.org> 5033 5034 Reviewed by Eric Seidel. 5035 5036 Add webkit-patch pretty-diff 5037 https://bugs.webkit.org/show_bug.cgi?id=37892 5038 5039 This is slightly lame because it asks you whether the diff is correct, 5040 but it's a starting point. 5041 5042 * Scripts/webkitpy/tool/commands/__init__.py: 5043 * Scripts/webkitpy/tool/commands/prettydiff.py: Added. 5044 * Scripts/webkitpy/tool/main.py: 5045 50462010-04-21 Adam Barth <abarth@webkit.org> 5047 5048 Reviewed by Darin Adler. 5049 5050 Remove mention of non-existant --no-build option 5051 https://bugs.webkit.org/show_bug.cgi?id=37893 5052 5053 The option doesn't exist! 5054 5055 * Scripts/webkitpy/tool/commands/stepsequence.py: 5056 50572010-04-21 Balazs Kelemen <kb@inf.u-szeged.hu> 5058 5059 Reviewed by Kenneth Rohde Christiansen. 5060 5061 [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling. 5062 https://bugs.webkit.org/show_bug.cgi?id=37198 5063 5064 * QtLauncher/main.cpp: 5065 (LauncherWindow::toggleInterruptingJavaScriptEnabled): 5066 (LauncherWindow::newWindow): 5067 (LauncherWindow::cloneWindow): 5068 (LauncherWindow::createChrome): 5069 (main): 5070 * QtLauncher/webpage.cpp: 5071 (WebPage::WebPage): 5072 (WebPage::shouldInterruptJavaScript): 5073 * QtLauncher/webpage.h: 5074 (WebPage::setInterruptingJavaScriptEnabled): 5075 50762010-04-21 Eric Seidel <eric@webkit.org> 5077 5078 Unreviewed, rolling out r57963. 5079 http://trac.webkit.org/changeset/57963 5080 https://bugs.webkit.org/show_bug.cgi?id=37759 5081 5082 Three tests started crashing on the Qt bot. 5083 5084 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 5085 * DumpRenderTree/qt/LayoutTestControllerQt.h: 5086 50872010-04-21 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 5088 5089 Reviewed by Eric Seidel. 5090 5091 Make new-run-webkit-tests work for the Qt port 5092 https://bugs.webkit.org/show_bug.cgi?id=37588 5093 5094 * Scripts/webkitpy/layout_tests/port/qt.py: 5095 50962010-04-21 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 5097 5098 Reviewed by Eric Seidel. 5099 5100 new-run-webkit-tests: try to detect alternate apache path 5101 https://bugs.webkit.org/show_bug.cgi?id=37587 5102 5103 _check_port_build() also needs to return true in the 5104 base implementation to not fail the check_build step. 5105 5106 * Scripts/webkitpy/layout_tests/port/webkit.py: 5107 51082010-04-21 Yi Shen <yi.4.shen@nokia.com> 5109 5110 Reviewed by Simon Hausmann. 5111 5112 [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo 5113 https://bugs.webkit.org/show_bug.cgi?id=37759 5114 5115 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 5116 (LayoutTestController::computedStyleIncludingVisitedInfo): 5117 * DumpRenderTree/qt/LayoutTestControllerQt.h: 5118 51192010-04-21 Eric Seidel <eric@webkit.org> 5120 5121 Unreviewed, test fix only. 5122 5123 new-run-webkit-tests: implement a --log trace message to be able to display detailed output of an individual test run 5124 https://bugs.webkit.org/show_bug.cgi?id=37726 5125 5126 This change seems to have broken a test. 5127 Attempting to handle the case where we don't have any 5128 timing information. Dirk may have to correct this change. 5129 5130 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 5131 51322010-04-19 Eric Seidel <eric@webkit.org> 5133 5134 Reviewed by Adam Barth. 5135 5136 new-run-webkit-tests has much higher startup latency than run-webkit-tests 5137 https://bugs.webkit.org/show_bug.cgi?id=37643 5138 5139 I got rid of the -expected.checksum reads during startup. 5140 This makes startup noticably better on my laptop. 5141 5142 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 5143 - Use image_hash() instead of .image_hash now that expected.checksum 5144 file reads are done lazily. 5145 * Scripts/webkitpy/layout_tests/port/http_server_base.py: 5146 - Add debug logging for this sleep call. 5147 In my testing I never saw this sleep() hit. 5148 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 5149 - Sleep a shorter interval to make websocket server 5150 startup more responsive. On my machine startup was 5151 taking around 1 second. 5152 - Remove the unconditional .5s delay on startup. 5153 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 5154 - Make image_hash file reads done lazily in a new image_hash() function. 5155 - Add a "Starting testing ..." meter update after DRT threads have 5156 been started, but before we get updates from the first one. 5157 - Rename variable "t" to a full english name to match WebKit style. 5158 51592010-04-20 Daniel Bates <dbates@rim.com> 5160 5161 Reviewed by Eric Seidel. 5162 5163 https://bugs.webkit.org/show_bug.cgi?id=37748 5164 5165 Make Sheriffbot more inspirational. 5166 5167 * Scripts/webkitpy/common/net/bugzilla.py: 5168 * Scripts/webkitpy/common/net/bugzilla_unittest.py: 5169 * Scripts/webkitpy/tool/bot/irc_command.py: 5170 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: 5171 * Scripts/webkitpy/tool/mocktool.py: 5172 51732010-04-20 Kent Tamura <tkent@chromium.org> 5174 5175 Reviewed by Dimitri Glazkov. 5176 5177 [DRT/Chromium] Import Chromium image_diff as ImageDiff 5178 https://bugs.webkit.org/show_bug.cgi?id=37790 5179 5180 ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium. 5181 5182 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 5183 * DumpRenderTree/chromium/ImageDiff.cpp: Added. 5184 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 5185 51862010-04-20 Dirk Pranke <dpranke@chromium.org> 5187 5188 This patch to new-run-webkit-tests adds a --log 'trace' option 5189 that prints out detailed info about a given test as it executes 5190 (where the baselines are, what the expectation is, what we got, 5191 how long it took). 5192 5193 https://bugs.webkit.org/show_bug.cgi?id=37726 5194 5195 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 5196 - use the newly exposed TestResult class and implement 5197 --log trace 5198 * Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py: 5199 - rename TestStats to TestResult and make it more public, resulting 5200 in cleaner code 5201 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 5202 - add expectation_to_string() as a separate callable function 5203 52042010-04-20 Eric Seidel <eric@webkit.org> 5205 5206 Unreviewed, rolling out r57907. 5207 http://trac.webkit.org/changeset/57907 5208 https://bugs.webkit.org/show_bug.cgi?id=37765 5209 5210 Appears to have broken MacEWS and possibly webkit-patch upload 5211 for svn users. Needs further investigation. 5212 5213 * Scripts/webkitpy/common/checkout/api.py: 5214 * Scripts/webkitpy/common/checkout/api_unittest.py: 5215 * Scripts/webkitpy/common/checkout/changelog.py: 5216 * Scripts/webkitpy/common/checkout/changelog_unittest.py: 5217 * Scripts/webkitpy/common/checkout/commitinfo.py: 5218 * Scripts/webkitpy/common/checkout/scm.py: 5219 * Scripts/webkitpy/common/checkout/scm_unittest.py: 5220 * Scripts/webkitpy/common/config/committers.py: 5221 * Scripts/webkitpy/common/net/bugzilla.py: 5222 * Scripts/webkitpy/common/net/buildbot.py: 5223 * Scripts/webkitpy/common/net/buildbot_unittest.py: 5224 * Scripts/webkitpy/common/net/statusserver.py: 5225 * Scripts/webkitpy/common/prettypatch.py: 5226 * Scripts/webkitpy/common/system/autoinstall.py: 5227 * Scripts/webkitpy/common/system/deprecated_logging.py: 5228 * Scripts/webkitpy/common/system/executive.py: 5229 * Scripts/webkitpy/common/system/executive_unittest.py: 5230 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 5231 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 5232 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: 5233 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 5234 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 5235 * Scripts/webkitpy/tool/commands/queues.py: 5236 * Scripts/webkitpy/tool/commands/queues_unittest.py: 5237 * Scripts/webkitpy/tool/commands/upload.py: 5238 * Scripts/webkitpy/tool/mocktool.py: 5239 * Scripts/webkitpy/tool/steps/abstractstep.py: 5240 * Scripts/webkitpy/tool/steps/postdiff.py: 5241 * Scripts/webkitpy/tool/steps/postdiffforcommit.py: 5242 * Scripts/webkitpy/tool/steps/postdiffforrevert.py: 5243 * Scripts/webkitpy/tool/steps/steps_unittest.py: 5244 52452010-04-20 Nate Chapin <japhet@chromium.org> 5246 5247 Unreviewed. 5248 5249 Update my irc handle in committers.py (natechapin -> japhet). 5250 5251 * Scripts/webkitpy/common/config/committers.py: 5252 52532010-04-20 Eric Seidel <eric@webkit.org> 5254 5255 Reviewed by Adam Barth. 5256 5257 REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø 5258 https://bugs.webkit.org/show_bug.cgi?id=37765 5259 5260 I fixed the queue to not ignore Tor as a reviwer in r57531, 5261 but instead it throws an exception every time his name is in a patch. 5262 5263 This fixes our Executive.run_command code to work around a Popen 5264 bug http://bugs.python.org/issue5290 whereby python versions before 2.6 5265 do not correctly handle unicode objects as input or output to 5266 Popen.communicate. 5267 5268 Following the advice of: 5269 http://farmdev.com/talks/unicode/ 5270 I'm attempting to take the python unicode plunge and use unicode() 5271 objects as strings instead of str() objects everywhere in webkitpy. 5272 5273 We do not have to use u"" instead of "" because u"a" == "a" as expected 5274 in Python. Python will generate a warning to the console in cases where 5275 a unicode() == str() operation cannot be performed. 5276 5277 I also cleaned up the input handling in run_command a little by adding 5278 a new _compute_input() method which can return early instead of having 5279 such a long/cluttered if-block. 5280 5281 Executive.run* now correctly accept and return unicode() objects. 5282 I attempted to fix all the places that we call .write() to make sure we 5283 encode any unicode() objects into utf-8. 5284 5285 All places which use StringIO need to be sure to pass StringIO a 5286 pre-encoded byte-array (str object) instead of unicode so that 5287 clients which read from the StringIO don't have encoding exceptions. 5288 To make this easier, I removed the patch_file_object support from 5289 add_patch_to_bug, and changed the 4 places which previously used 5290 StringIO to create a fake patch file. 5291 5292 I attempted to document any places where we are not correctly converting 5293 to/from bytes (str() objects) to strings (unicode() objects). 5294 5295 * Scripts/webkitpy/common/checkout/api_unittest.py: 5296 - Read/write utf-8 files instead of ascii. 5297 - Update the tests to use test for proper unicode() handling. 5298 * Scripts/webkitpy/common/checkout/changelog_unittest.py: 5299 - Use unicode() strings instead of str() byte arrays. 5300 * Scripts/webkitpy/common/checkout/scm.py: 5301 - Remove use of str(). 5302 * Scripts/webkitpy/common/checkout/scm_unittest.py: 5303 - Read/write utf-8 files and use unicode() strings in testing. 5304 * Scripts/webkitpy/common/config/committers.py: 5305 - Use \u instead of \x to make slightly clearer what we're doing. 5306 * Scripts/webkitpy/common/net/bugzilla.py: 5307 - Add a new _string_contents() method and explain why 5308 we have to call unicode() on the result of soup.string 5309 and why it's safe to do so w/o needing to pass a codec name. 5310 - Remove the (unused) support for passing a file object to add_patch_to_bug(). 5311 * Scripts/webkitpy/common/net/buildbot.py: 5312 - Use unicode() instead of str() when needing to coax a 5313 NavigableString object into a unicode() object. 5314 * Scripts/webkitpy/common/net/statusserver.py: 5315 - Remove use of str() 5316 * Scripts/webkitpy/common/prettypatch.py: 5317 - Write out the patch file as utf-8. 5318 * Scripts/webkitpy/common/system/autoinstall.py: 5319 - Add a FIXME about encoding. 5320 * Scripts/webkitpy/common/system/deprecated_logging.py: 5321 - Document that tee() works on bytes, not strings. 5322 * Scripts/webkitpy/common/system/executive.py: 5323 - Make run* properly take and return unicode() objects. 5324 * Scripts/webkitpy/common/system/executive_unittest.py: 5325 - Added a unit test to make sure we don't break Tor again! 5326 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 5327 - Write out the test list as utf-8. 5328 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 5329 - Write out json files as utf-8. 5330 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: 5331 - Add FIXME about encoding handling. 5332 * Scripts/webkitpy/tool/commands/upload.py: 5333 - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper. 5334 * Scripts/webkitpy/tool/mocktool.py: 5335 - Rename add_patch_to_bug argument to match bugzilla.py 5336 * Scripts/webkitpy/tool/steps/postdiff.py: 5337 - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper. 5338 * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto. 5339 * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto. 5340 * Scripts/webkitpy/tool/steps/steps_unittest.py: 5341 - Fixed spurious logging seen when running test-webkitpy 5342 53432010-04-20 Chris Jerdonek <cjerdonek@webkit.org> 5344 5345 Reviewed by Shinichiro Hamaji. 5346 5347 For check-webkit-style, implemented __eq__() and __ne__() (the 5348 built-in equality and inequality methods) for the 5349 DefaultStyleErrorHandler class. 5350 5351 https://bugs.webkit.org/show_bug.cgi?id=37850 5352 5353 This will facilitate unit-testing for a subsequent patch, 5354 namely for https://bugs.webkit.org/show_bug.cgi?id=37850 5355 5356 * Scripts/webkitpy/style/error_handlers.py: 5357 - Added __eq__() and __ne__() to the DefaultStyleErrorHandler 5358 class. 5359 5360 * Scripts/webkitpy/style/error_handlers_unittest.py: 5361 - Added unit tests for __eq__() and __ne__(). 5362 - Also included a minor clean-up refactoring of combining the 5363 StyleErrorHandlerTestBase class (which has not needed to 5364 be separate due to previous changes) into the 5365 DefaultStyleErrorHandlerTest class. 5366 53672010-04-20 Jakub Wieczorek <jwieczorek@webkit.org> 5368 5369 Unreviewed. 5370 5371 Add my IRC nick to the committers.py list. 5372 5373 * Scripts/webkitpy/common/config/committers.py: 5374 53752010-04-20 Kim Grönholm <kim.gronholm@nomovok.com> 5376 5377 Reviewed by Simon Hausmann. 5378 5379 [Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView 5380 https://bugs.webkit.org/show_bug.cgi?id=37816 5381 5382 Fix multi-touch mocking in QtLauncher when using QGraphicsView. 5383 Test: https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955 5384 5385 * QtLauncher/main.cpp: 5386 (LauncherWindow::eventFilter): 5387 (LauncherWindow::initializeView): 5388 53892010-04-20 MORITA Hajime <morrita@google.com> 5390 5391 Unreviewed, add myself to the committers list. 5392 5393 * Scripts/webkitpy/common/config/committers.py: 5394 53952010-04-20 Kent Tamura <tkent@chromium.org> 5396 5397 Reviewed by Shinichiro Hamaji. 5398 5399 [DRT/Chromium] Fix some unexpected results of editing 5400 https://bugs.webkit.org/show_bug.cgi?id=37843 5401 5402 This change fixes about 70 unexpected results. 5403 The original test_webview_delegate.cc doesn't have this bug. 5404 The bug was introduced when I ported it to WebKit tree. 5405 5406 * DumpRenderTree/chromium/WebViewHost.cpp: 5407 (printRangeDescription): Replace the latter startContainer() with endContainer(). 5408 54092010-04-19 Dirk Pranke <dpranke@chromium.org> 5410 5411 Unreviewed, build fix. 5412 5413 Turn off some unit tests for now - the new-run-webkit-tests dryrun 5414 tests for chromium won't work if you don't have a chromium checkout. 5415 5416 https://bugs.webkit.org/show_bug.cgi?id=37841 5417 5418 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 5419 54202010-04-19 Dirk Pranke <dpranke@chromium.org> 5421 5422 Unreviewed, build fix. 5423 5424 (Re-)add dryrun.py; this was renamed from passing.py in the previous 5425 CL but apparently somehow didn't get checked in. 5426 5427 https://bugs.webkit.org/show_bug.cgi?id=37841 5428 5429 * Scripts/webkitpy/layout_tests/port/dryrun.py: Added. 5430 54312010-04-19 Shinichiro Hamaji <hamaji@chromium.org> 5432 5433 Reviewed by David Levin. 5434 5435 check-webkit-style: exits when encountering a deleted file 5436 https://bugs.webkit.org/show_bug.cgi?id=37122 5437 5438 This reverts the quick fix done by r57119 and makes check_patch 5439 not call check_file for deleted files. 5440 5441 Also this change fixes the behavior for "-", which should mean 5442 stdin. Before this change, the style checker just ignored "-" 5443 with a warning message. 5444 5445 * Scripts/webkitpy/style/checker.py: 5446 * Scripts/webkitpy/style/checker_unittest.py: 5447 54482010-04-19 Daniel Bates <dbates@rim.com> 5449 5450 No review, rolling out 57868. 5451 http://trac.webkit.org/changeset/57868 5452 https://bugs.webkit.org/show_bug.cgi?id=37748 5453 5454 Sheriffbot wasn't very inspirational after this patch. 5455 Instead, he was silent when you said hi :-(. Rolling 5456 out this patch so that I can debug/test this some more. 5457 5458 * Scripts/webkitpy/common/net/bugzilla.py: 5459 * Scripts/webkitpy/common/net/bugzilla_unittest.py: 5460 * Scripts/webkitpy/tool/bot/irc_command.py: 5461 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: 5462 * Scripts/webkitpy/tool/mocktool.py: 5463 54642010-04-19 Daniel Bates <dbates@rim.com> 5465 5466 Reviewed by Adam Barth. 5467 5468 https://bugs.webkit.org/show_bug.cgi?id=37748 5469 5470 Make Sheriffbot more inspirational. 5471 5472 * Scripts/webkitpy/common/net/bugzilla.py: 5473 * Scripts/webkitpy/common/net/bugzilla_unittest.py: 5474 * Scripts/webkitpy/tool/bot/irc_command.py: 5475 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: 5476 * Scripts/webkitpy/tool/mocktool.py: 5477 54782010-04-19 Kevin Ollivier <kevino@theolliviers.com> 5479 5480 [wx] Build fix, add missing header. 5481 5482 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 5483 54842010-04-19 Dirk Pranke <dpranke@chromium.org> 5485 5486 Reviewed by Adam Barth. 5487 5488 new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port 5489 that can be used to test platforms other than the one you are running 5490 on. This can be useful for checking baselines and testing code 5491 coverage. 5492 5493 Note that running the code on the "wrong" port requires each 5494 port-specific implementation to actually not require any 5495 platform-specific python code (e.g., the chromium-win port must 5496 test for the existence of windows functions before calling them). 5497 5498 https://bugs.webkit.org/show_bug.cgi?id=37782 5499 5500 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 5501 * Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py. 5502 * Scripts/webkitpy/layout_tests/port/factory.py: 5503 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 5504 55052010-04-19 Dirk Pranke <dpranke@chromium.org> 5506 5507 Reviewed by Eric Seidel. 5508 5509 new-run-webkit-tests: add --build (default) and --no-build 5510 options to make that step optional. This flag modifies what happens 5511 in port.check_build(). 5512 5513 https://bugs.webkit.org/show_bug.cgi?id=37786 5514 5515 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 5516 * Scripts/webkitpy/layout_tests/port/chromium.py: 5517 * Scripts/webkitpy/layout_tests/port/webkit.py: 5518 55192010-04-19 Dirk Pranke <dpranke@chromium.org> 5520 5521 Unreviewed, build fix. 5522 5523 new-run-webkit-tests - fix a typo in r57480 that caused us to stop 5524 logging the actual list of unexpected results. 5525 5526 https://bugs.webkit.org/show_bug.cgi?id=37831 5527 5528 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 5529 55302010-04-19 Dirk Pranke <dpranke@chromium.org> 5531 5532 Reviewed by Adam Barth. 5533 5534 From a patch by Tor Arne Vestbo <tor.arne.vestbo@nokia.com> 5535 5536 new-run-webkit-tests: make the retry step more explicit 5537 https://bugs.webkit.org/show_bug.cgi?id=37606 5538 5539 It might be confusing to see the test and percent counters 5540 reset without any notice of what's going on, so we make the 5541 message that a retry-run is started explicit. 5542 5543 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 5544 55452010-04-19 Sam Weinig <weinig@apple.com> 5546 5547 Reviewed by Anders Carlsson. 5548 5549 Add support for opening a new window (File->New Window) to 5550 Windows MiniBrowser. Accelerator doesn't work. 5551 5552 * MiniBrowser/win/BrowserView.cpp: 5553 (createNewPage): Use BrowserView::create. 5554 * MiniBrowser/win/BrowserWindow.cpp: 5555 (BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW 5556 by creating a new window. 5557 * MiniBrowser/win/BrowserWindow.h: 5558 (BrowserWindow::create): Added. Don't allow creating 5559 BrowserWindows on the stack by making constructor 5560 private and exposing the create function. 5561 * MiniBrowser/win/MiniBrowser.cpp: 5562 (MiniBrowser::createNewWindow): Move new window creation 5563 logic here. 5564 * MiniBrowser/win/MiniBrowser.h: 5565 * MiniBrowser/win/MiniBrowser.rc: 5566 * MiniBrowser/win/main.cpp: 5567 (_tWinMain): Use the new MiniBrowser::createNewWindow(). 5568 55692010-04-19 Chris Fleizach <cfleizach@apple.com> 5570 5571 Reviewed by Beth Dakin. 5572 5573 AX: aria-haspopup needs to be exposed 5574 https://bugs.webkit.org/show_bug.cgi?id=37808 5575 5576 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 5577 (AccessibilityUIElement::hasPopup): 5578 55792010-04-19 Dirk Pranke <dpranke@chromium.org> 5580 5581 Reviewed by Eric Seidel. 5582 5583 Submit a better workaround for r57806 than the one in r57831 - log 5584 an error and exit if you try to run new-run-webkit-tests with --use-drt 5585 on Windows. 5586 5587 https://bugs.webkit.org/show_bug.cgi?id=37822 5588 5589 * Scripts/webkitpy/layout_tests/port/chromium.py: 5590 55912010-04-19 Jesus Sanchez-Palencia <jesus@webkit.org> 5592 5593 Unreviewed. 5594 5595 Just adding myself as a committer. 5596 5597 * Scripts/webkitpy/common/config/committers.py: 5598 55992010-04-19 Dirk Pranke <dpranke@chromium.org> 5600 5601 Reviewed by Eric Seidel. 5602 5603 Add slightly better logging to the websocket python wrapper script, 5604 including a --verbose flag for debug output. 5605 5606 https://bugs.webkit.org/show_bug.cgi?id=37233 5607 5608 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 5609 * Scripts/new-run-webkit-websocketserver: 5610 56112010-04-19 Dirk Pranke <dpranke@chromium.org> 5612 5613 Reviewed by Eric Seidel. 5614 5615 new-run-webkit-tests: add a way (--print-unexpected-results) to 5616 (re-)print out the tests that produced unexpected results in the 5617 last run. Also add a way (--retry-unexpected-results) to 5618 automatically re-test them. 5619 5620 https://bugs.webkit.org/show_bug.cgi?id=37783 5621 5622 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 5623 56242010-04-19 Dirk Pranke <dpranke@chromium.org> 5625 5626 Reviewed by Eric Seidel. 5627 5628 Restructure the logging in new-run-webkit-tests so that many of log 5629 messages that were logged to the MeteredStream also get logged in 5630 --verbose mode. 5631 5632 https://bugs.webkit.org/show_bug.cgi?id=37780 5633 5634 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: 5635 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 5636 56372010-04-19 Dirk Pranke <dpranke@chromium.org> 5638 5639 Reviewed by Eric Seidel. 5640 5641 new-run-webkit-tests: add 'summary' and 'unexpected-results' options 5642 to the --log flag. Also add a 'progress' flag to enable the regular 5643 progress bar (as opposed to 'detailed-progress', which enables the 5644 dots). Also add a 'nothing' flag to allow you to be explicit that 5645 you don't want any logging on the command line. 5646 5647 The default is 5648 '--log detailed-progress,summary,unexpected,unexpected-results' 5649 5650 (The default logging is unchanged by this patch, this just makes things 5651 properly configurable). 5652 5653 Note that 'nothing' doesn't work properly yet; I need a couple other 5654 patches to land to avoid rewriting things several different ways. 5655 5656 https://bugs.webkit.org/show_bug.cgi?id=37785 5657 5658 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 5659 56602010-04-19 Kenneth Rohde Christiansen <kenneth@webkit.org> 5661 5662 Reviewed by Simon Hausmann. 5663 5664 Make the URL change on committed load. 5665 5666 * QtLauncher/mainwindow.cpp: 5667 (MainWindow::buildUI): 5668 (MainWindow::setAddressUrl): 5669 * QtLauncher/mainwindow.h: 5670 56712010-04-19 Dirk Pranke <dpranke@chromium.org> 5672 5673 Reviewed by Eric Seidel. 5674 5675 Fix a typo in the rebaselining tool that causes us to use "debug" 5676 instead of "Debug" in a directory path, which fails on platforms with 5677 case-sensitive filesystems. 5678 5679 https://bugs.webkit.org/show_bug.cgi?id=37819 5680 5681 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 5682 56832010-04-19 Dirk Pranke <dpranke@chromium.org> 5684 5685 Unreviewed, build fix. 5686 5687 Fix breakage of chromium-win canary bots caused by r57806. That patch 5688 introduced the option of using Chrome's new port of DumpRenderTree, 5689 but unfortunately that port relies on the webkit.py class 5690 implementation which uses non-blocking I/O that isn't available on 5691 Windows. This patch turns off that option and doesn't import the 5692 class if we're running on Windows. 5693 5694 https://bugs.webkit.org/show_bug.cgi?id=37817 5695 5696 * Scripts/webkitpy/layout_tests/port/chromium.py: 5697 56982010-04-19 James Robinson <jamesr@chromium.org> 5699 5700 Reviewed by abarth. 5701 5702 Fix a typo 5703 5704 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 5705 57062010-04-19 Adam Roben <aroben@apple.com> 5707 5708 Fix run-webkit-tests when there are spaces in the path 5709 5710 Fixes <http://webkit.org/b/37809> 5711 5712 Reviewed by Adam Barth. 5713 5714 * Scripts/run-webkit-tests: Use an "indirect object" to specify the 5715 path to the harness to exec(). According to perldoc, this usage will 5716 prohibit perl from parsing the arguments to exec() via the shell, 5717 which would incorrectly split paths with spaces in them, etc. 5718 57192010-04-19 Dimitri Glazkov <dglazkov@chromium.org> 5720 5721 Reviewed by Adam Roben. 5722 5723 WinLauncher.h should use LF line-endings and use native line-endings style. 5724 https://bugs.webkit.org/show_bug.cgi?id=37807 5725 5726 * WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings. 5727 57282010-04-19 Kent Tamura <tkent@chromium.org> 5729 5730 Reviewed by Shinichiro Hamaji. 5731 5732 [DRT/Chromium] Fix a test initialization problem 5733 https://bugs.webkit.org/show_bug.cgi?id=37791 5734 5735 * DumpRenderTree/chromium/DumpRenderTree.cpp: 5736 (runTest): Call resetTestController() before runFileTest(). Some 5737 controllers initialize their fields in reset() and not in their 5738 constructors. 5739 57402010-04-19 Kent Tamura <tkent@chromium.org> 5741 5742 Reviewed by Eric Seidel. 5743 5744 [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt 5745 https://bugs.webkit.org/show_bug.cgi?id=37793 5746 5747 We need to use WebKitDriver instead of ChromiumDriver for Chromium 5748 DRT because its interface is different from test_shell. 5749 5750 Chromium DRT has no UI. So we can't use it to show test results. 5751 5752 * Scripts/webkitpy/layout_tests/port/chromium.py: 5753 57542010-04-18 Eric Seidel <eric@webkit.org> 5755 5756 Reviewed by Adam Roben. 5757 5758 Make failure-reason more forgiving 5759 https://bugs.webkit.org/show_bug.cgi?id=37525 5760 5761 Removed search_limit, which wasn't very useful anyway. 5762 Added a log about the long load time loading from the builders. 5763 Prompt the user for what revision to start walking from (makes it easy to restart upon failure). 5764 5765 * Scripts/webkitpy/common/net/buildbot.py: 5766 * Scripts/webkitpy/tool/commands/queries.py: 5767 57682010-04-18 Chris Jerdonek <cjerdonek@webkit.org> 5769 5770 Reviewed by Shinichiro Hamaji. 5771 5772 Created a class for check-webkit-style that encapsulates iterating 5773 over text files and reading them. 5774 5775 https://bugs.webkit.org/show_bug.cgi?id=37754 5776 5777 This revision is an intermediate step towards separating our 5778 style-checking code from the logic of iterating over files and 5779 reading them. 5780 5781 * Scripts/webkitpy/common/system/logtesting.py: 5782 - Added a logMessages() method to the LoggingTestCase class. 5783 This method provides unit tests with access to the raw list 5784 of log messages in case the tester needs to do something more 5785 than simply assert the list of existing messages. 5786 5787 * Scripts/webkitpy/style/checker.py: 5788 - Added a ProcessorBase class that processors of lists of lines 5789 should eventually inherit from. 5790 - Also added a FIXME to use the ProcessorBase class and the 5791 TextFileReader class added below. 5792 5793 * Scripts/webkitpy/style/filereader.py: Added. 5794 - Created a TextFileReader class that encapsulates reading 5795 and iterating over text files. 5796 5797 * Scripts/webkitpy/style/filereader_unittest.py: Added. 5798 - Added a TextFileReaderTest class to unit-test the 5799 new TextFileReader class. 5800 58012010-04-15 Tony Chang <tony@chromium.org> 5802 5803 Reviewed by Adam Barth. 5804 5805 [chromium] new-run-webkit-tests should be able to use chromium DRT 5806 https://bugs.webkit.org/show_bug.cgi?id=37645 5807 5808 Make sure that the lack of a chromium checkout doesn't cause the script to 5809 fail. 5810 5811 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 5812 * Scripts/webkitpy/layout_tests/port/chromium.py: 5813 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths 5814 to be relative to an upstream output dir. 5815 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag. 5816 58172010-04-18 Eric Seidel <eric@webkit.org> 5818 5819 Unreviewed, fixing the Qt bot. 5820 5821 Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms 5822 https://bugs.webkit.org/show_bug.cgi?id=37632 5823 5824 * Scripts/run-webkit-tests: 5825 - Exit non-zero of launching the harness fails. 5826 58272010-04-18 Eric Seidel <eric@webkit.org> 5828 5829 Unreviewed, fixing the Qt bot. 5830 5831 Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms 5832 https://bugs.webkit.org/show_bug.cgi?id=37632 5833 5834 * Scripts/run-webkit-tests: 5835 - Fix the wrapper to work for users who do not 5836 have WebKitTools/Scripts in their path. 5837 58382010-04-14 Eric Seidel <eric@webkit.org> 5839 5840 Reviewed by Adam Barth. 5841 5842 Add a layer of indirection when calling run-webkit-tests to 5843 allow testing new-run-webkit-tests on various platforms. 5844 https://bugs.webkit.org/show_bug.cgi?id=37632 5845 5846 This will let us test and fix bugs in new-run-webkit-tests 5847 without needing to restart the buildbot master between tests. 5848 5849 Currently this change leaves run-webkit-tests as-is, but once 5850 its landed we will easily be able to turn on/off 5851 new-run-webkit-tests for various ports/configurations. 5852 5853 I will send a note out to webkit-dev about how we will 5854 be using this launcher script to test on the bots. 5855 5856 * Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests. 5857 * Scripts/run-webkit-tests: 5858 - A new script which decides whether to run new- or old- 5859 run-webkit-tests based on the platform. 5860 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 5861 - Add some dummy argument handling for arguments which 5862 old-run-webkit-tests supports but new-run-webkit-tests 5863 does not yet. 5864 58652010-04-18 Eric Seidel <eric@webkit.org> 5866 5867 Reviewed by Adam Barth. 5868 5869 Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red) 5870 https://bugs.webkit.org/show_bug.cgi?id=33295 5871 5872 The Gtk builders have been green every time I've looked 5873 at them in the last 5 days or so. It would appear webkit 5874 is now keeping them green and we should update the core 5875 builder list to match reality. 5876 5877 * Scripts/webkitpy/common/net/buildbot.py: 5878 * Scripts/webkitpy/common/net/buildbot_unittest.py: 5879 58802010-04-18 Robert Hogan <robert@webkit.org> 5881 5882 Reviewed by Simon Hausmann. 5883 5884 [Qt] Add support for LayoutTestController commands: 5885 setSmartInsertDeleteEnabled 5886 setSelectTrailingWhitespaceEnabled 5887 execCommand 5888 isCommandEnabled 5889 5890 https://bugs.webkit.org/show_bug.cgi?id=35844 5891 5892 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 5893 (WebCore::WebPage::resetSettings): 5894 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 5895 (LayoutTestController::setSmartInsertDeleteEnabled): 5896 (LayoutTestController::setSelectTrailingWhitespaceEnabled): 5897 (LayoutTestController::execCommand): 5898 (LayoutTestController::isCommandEnabled): 5899 * DumpRenderTree/qt/LayoutTestControllerQt.h: 5900 59012010-04-17 Adam Barth <abarth@webkit.org> 5902 5903 Reviewed by Eric Seidel. 5904 5905 Remove steps_references and commands_references 5906 https://bugs.webkit.org/show_bug.cgi?id=37758 5907 5908 We tried using the mumble_references convention to manage our 5909 dependencies, but it doesn't seem to be providing much value for the 5910 steps and commands module because these modules are small pieces of the 5911 larger tool module. In this patch, I've removed the references file 5912 for these modules. 5913 5914 I've left the style_references file for the style module because that 5915 module seems better isolated from the rest of webkitpy and the 5916 style_references file appears to be providing some value. 5917 5918 * Scripts/webkitpy/tool/commands/commandtest.py: 5919 * Scripts/webkitpy/tool/commands/download_unittest.py: 5920 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 5921 * Scripts/webkitpy/tool/commands/queries_unittest.py: 5922 * Scripts/webkitpy/tool/commands/queues_unittest.py: 5923 * Scripts/webkitpy/tool/commands/queuestest.py: 5924 * Scripts/webkitpy/tool/commands/upload.py: 5925 * Scripts/webkitpy/tool/commands/upload_unittest.py: 5926 * Scripts/webkitpy/tool/commands_references.py: Removed. 5927 * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py: 5928 * Scripts/webkitpy/tool/steps/steps_unittest.py: 5929 * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: 5930 * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: 5931 * Scripts/webkitpy/tool/steps_references.py: Removed. 5932 59332010-04-17 Eric Seidel <eric@webkit.org> 5934 5935 Reviewed by Adam Barth. 5936 5937 WebKit needs a Chromium Mac EWS Builder 5938 https://bugs.webkit.org/show_bug.cgi?id=37742 5939 5940 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 5941 59422010-04-17 Adam Barth <abarth@webkit.org> 5943 5944 Fix expected results for unit test broken by 5945 http://trac.webkit.org/changeset/57772 5946 5947 * Scripts/webkitpy/common/net/buildbot_unittest.py: 5948 59492010-04-17 Sam Weinig <weinig@apple.com> 5950 5951 Reviewed by Adam Roben. 5952 5953 Teach windows MiniBrowser how to work with window.open() 5954 and targeted links. 5955 5956 * MiniBrowser/win/BrowserView.cpp: 5957 (createNewPage): Create a new BrowserWindow and return its page. 5958 (showPage): Show the page. 5959 (closePage): Empty implementation. 5960 (runJavaScriptAlert): Empty implementation. 5961 (BrowserView::create): Register a UIClient. 5962 * MiniBrowser/win/BrowserView.h: 5963 (BrowserView::webView): Added. 5964 Change create to take a BrowserWindow instead of an HWND. 5965 5966 * MiniBrowser/win/BrowserWindow.cpp: 5967 (BrowserWindow::wndProc): Respond to WM_NCDESTROY. 5968 (BrowserWindow::goToURL): Added. Forwards to BrowserView. 5969 (BrowserWindow::onCreate): Don't always go to the default 5970 url. Let the caller do this. 5971 (BrowserWindow::onNCDestroy): Delete the window. 5972 * MiniBrowser/win/BrowserWindow.h: 5973 (BrowserWindow::view): Added. 5974 (BrowserWindow::window): Added. 5975 5976 * MiniBrowser/win/main.cpp: 5977 (_tWinMain): 5978 Go to the default URL for the initial page. Allocate the initial 5979 window on the heap for correctness. 5980 59812010-04-16 Adam Roben <aroben@apple.com> 5982 5983 Add the Windows Debug (Test) builder to the list of core builders 5984 5985 It's been green for a few days now, and all the known Windows 5986 flakiness is Release-only. 5987 5988 Rubber-stamped by Mark Rowe. 5989 5990 * Scripts/webkitpy/common/net/buildbot.py: 5991 (BuildBot.core_builder_name_regexps): Added a regular expression to 5992 match the "Windows Debug (Test)" builder. 5993 59942010-04-16 Sam Weinig <sam@webkit.org> 5995 5996 Reviewed by Anders Carlsson. 5997 5998 Fix window.open() and targeted links. 5999 6000 * MiniBrowser/mac/BrowserWindowController.m: 6001 (_createNewPage): Use the correct initializer to and load the window. 6002 60032010-04-16 Adam Roben <aroben@apple.com> 6004 6005 Fix links to layout test results from build status pages 6006 6007 Reviewed by Mark Rowe. 6008 6009 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 6010 (ExtractTestResults.finished): Prepend "/" on the URL of the test 6011 results page so that it is treated as an absolute URL. 6012 60132010-04-16 Tony Chang <tony@chromium.org> 6014 6015 Reviewed by Dimitri Glazkov. 6016 6017 [chromium] build DRT on Linux 6018 https://bugs.webkit.org/show_bug.cgi?id=37690 6019 6020 * Scripts/build-dumprendertree: Add support for win and linux 6021 60222010-04-16 Sam Weinig <weinig@apple.com> 6023 6024 Reviewed by Adam Roben. 6025 6026 Use the threaded process model for MiniBrowser if holding down 6027 the shift key on startup. 6028 6029 * MiniBrowser/win/BrowserView.cpp: 6030 (BrowserView::create): 6031 60322010-04-15 Tony Chang <tony@chromium.org> 6033 6034 Reviewed by Dimitri Glazkov. 6035 6036 [chromium] Add TestShellGtk.cpp so we can link on Linux 6037 https://bugs.webkit.org/show_bug.cgi?id=37561 6038 6039 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add new file and 6040 add platform file exceptions. 6041 * DumpRenderTree/chromium/TestShellGtk.cpp: Added. 6042 (AlarmHandler): 6043 (TestShell::waitTestFinished): 6044 60452010-04-15 Tony Chang <tony@chromium.org> 6046 6047 Reviewed by Dimitri Glazkov. 6048 6049 build DRT on chromium mac 6050 https://bugs.webkit.org/show_bug.cgi?id=37639 6051 6052 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 6053 * Scripts/build-dumprendertree: enable build-dumprendertree --chromium 6054 60552010-04-15 Kent Tamura <tkent@chromium.org> 6056 6057 Reviewed by Dimitri Glazkov. 6058 6059 [DRT/Chromium] Add LayoutTestHelper for Mac 6060 https://bugs.webkit.org/show_bug.cgi?id=37668 6061 6062 LayouTestHelper.mm is based on webkit/tools/test_shell/mac/layout_test_helper.mm 6063 of Chromium. 6064 6065 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 6066 * DumpRenderTree/chromium/LayoutTestHelper.mm: Added. 6067 60682010-04-15 Alexey Proskuryakov <ap@apple.com> 6069 6070 Reviewed by Geoff Garen. 6071 6072 https://bugs.webkit.org/show_bug.cgi?id=37494 6073 <rdar://problem/7857060> REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html 6074 fails on Windows 6075 6076 * DumpRenderTree/win/EventSender.cpp: (makeEventSender): 6077 * DumpRenderTree/win/EventSender.h: 6078 Tell EventSender if it's being created for a top frame. 6079 6080 * DumpRenderTree/win/FrameLoadDelegate.cpp: 6081 (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): We only want to reset 6082 EventSender machinery when a new test is loaded, not when an iframe (or just its global 6083 object) is created. 6084 60852010-04-15 Adam Roben <aroben@apple.com> 6086 6087 Fix Windows WebKit2 build. 6088 6089 * MiniBrowser/win/MiniBrowser.cpp: 6090 60912010-04-15 Ojan Vafai <ojan@chromium.org> 6092 6093 Reviewed by Adam Barth. 6094 6095 Include codereview issue number in patch description 6096 https://bugs.webkit.org/show_bug.cgi?id=37677 6097 6098 This lets us know which rietveld issue this patch is tied to. 6099 6100 Also, make it so that --fancy-review overrides --no-review. 6101 6102 * Scripts/webkitpy/tool/steps/postcodereview.py: 6103 * Scripts/webkitpy/tool/steps/postdiff.py: 6104 61052010-04-15 Adam Roben <aroben@apple.com> 6106 6107 Make --exit-after-n-failures work when all tests are timing out or crashing 6108 6109 Fixes <http://webkit.org/b/37679>. 6110 6111 Reviewed by Jon Honeycutt. 6112 6113 * Scripts/run-webkit-tests: 6114 (top level): When a test crashes or times out, break out of the main loop if 6115 stopRunningTestsEarlyIfNeeded returns true. Moved some code from the bottom of the main loop 6116 from here... 6117 (stopRunningTestsEarlyIfNeeded): ...to here. 6118 61192010-04-15 Sam Weinig <sam@webkit.org> 6120 6121 Reviewed by Anders Carlsson. 6122 6123 Add WebHistoryClient support. 6124 https://bugs.webkit.org/show_bug.cgi?id=37671 6125 6126 Add HistoryClient logging. 6127 6128 * MiniBrowser/mac/BrowserWindowController.m: 6129 (_didNavigateWithNavigationData): 6130 (_didPerformClientRedirect): 6131 (_didPerformServerRedirect): 6132 (_didUpdateHistoryTitle): 6133 (-[BrowserWindowController awakeFromNib]): 6134 61352010-04-15 Anders Carlsson <andersca@apple.com> 6136 6137 Reviewed by Sam Weinig. 6138 6139 Start the mini browser in threaded mode if shift is pressed during startup. 6140 https://bugs.webkit.org/show_bug.cgi?id=37670 6141 6142 * MiniBrowser/mac/AppDelegate.m: 6143 (-[BrowserAppDelegate init]): 6144 61452010-04-15 Chris Fleizach <cfleizach@apple.com> 6146 6147 Reviewed by Beth Dakin. 6148 6149 AXHelp is being appended from ancestors incorrectly 6150 https://bugs.webkit.org/show_bug.cgi?id=37659 6151 6152 * DumpRenderTree/AccessibilityUIElement.cpp: 6153 (getHelpTextCallback): 6154 (AccessibilityUIElement::getJSClass): 6155 * DumpRenderTree/AccessibilityUIElement.h: 6156 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 6157 (AccessibilityUIElement::helpText): 6158 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 6159 (AccessibilityUIElement::helpText): 6160 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 6161 (AccessibilityUIElement::helpText): 6162 61632010-04-15 Dirk Pranke <dpranke@chromium.org> 6164 6165 Reviewed by Adam Barth. 6166 6167 Re-format run-webkit-tests to fit in 80-columns for PEP-8 compliance. 6168 (broken by r57463 and r57381, at least). I've also filed bug 37477 6169 to fix check-webkit-style to catch these things. 6170 6171 https://bugs.webkit.org/show_bug.cgi?id=38586 6172 6173 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6174 61752010-04-15 Dirk Pranke <dpranke@chromium.org> 6176 6177 Reviewed by Dimitri Glazkov. 6178 6179 Add a way to override the user-visible name for the test binary since 6180 some ports don't call it DumpRenderTree (e.g., Chromium Win uses 6181 test_shell, Chromium Mac uses TestShell) by adding a driver_name() 6182 method to the Port interface. 6183 6184 https://bugs.webkit.org/show_bug.cgi?id=37631 6185 6186 * Scripts/webkitpy/layout_tests/port/base.py: 6187 * Scripts/webkitpy/layout_tests/port/chromium.py: 6188 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 6189 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6190 61912010-04-14 Anders Carlsson <andersca@apple.com> 6192 6193 Reviewed by Adam Roben. 6194 6195 Add "Force Repaint" to debug menu. 6196 https://bugs.webkit.org/show_bug.cgi?id=37627 6197 6198 * MiniBrowser/mac/BrowserWindowController.h: 6199 * MiniBrowser/mac/BrowserWindowController.m: 6200 (-[BrowserWindowController forceRepaint:]): 6201 * MiniBrowser/mac/English.lproj/MainMenu.xib: 6202 62032010-04-15 Sam Weinig <sam@webkit.org> 6204 6205 Reviewed by Adam Roben. 6206 6207 Add debug-minibrowser script. 6208 6209 * Scripts/debug-minibrowser: Copied from Scripts/run-minibrowser. 6210 * Scripts/webkitdirs.pm: 6211 62122010-04-15 Roland Steiner <rolandsteiner@chromium.org> 6213 6214 Reviewed by Dimitri Glazkov. 6215 6216 Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows 6217 https://bugs.webkit.org/show_bug.cgi?id=37636 6218 6219 Second patch: add Windows-specific implementation parts 6220 of TestShell. 6221 6222 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 6223 * DumpRenderTree/chromium/TestShell.h: 6224 (TestShell::finishedEvent): 6225 * DumpRenderTree/chromium/TestShellWin.cpp: 6226 (watchDogThread): 6227 (TestShell::waitTestFinished): 6228 62292010-04-15 Roland Steiner <rolandsteiner@chromium.org> 6230 6231 Reviewed by Dimitri Glazkov. 6232 6233 Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows 6234 https://bugs.webkit.org/show_bug.cgi?id=37636 6235 6236 First patch: fix compiler errors. 6237 6238 * DumpRenderTree/chromium/EventSender.cpp: 6239 (EventSender::reset): 6240 (EventSender::dispatchMessage): 6241 * DumpRenderTree/chromium/LayoutTestController.cpp: 6242 (LayoutTestController::pathToLocalResource): 6243 * DumpRenderTree/chromium/TestWebWorker.h: 6244 * DumpRenderTree/chromium/TextInputController.cpp: 6245 * DumpRenderTree/chromium/WebViewHost.h: 6246 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 6247 62482010-04-14 Luiz Agostini <luiz.agostini@openbossa.org> 6249 6250 Reviewed by Simon Hausmann. 6251 6252 [Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp 6253 https://bugs.webkit.org/show_bug.cgi?id=37622 6254 6255 Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433 6256 (bug 35844). Moving it back. 6257 6258 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 6259 (LayoutTestController::setViewModeMediaFeature): 6260 62612010-04-15 Dirk Pranke <dpranke@chromium.org> 6262 6263 Reviewed by Adam Barth. 6264 6265 Add some very minimal unit tests for new-run-webkit-tests. This should 6266 be enough to catch egregious brokenness like syntax errors and import 6267 declaration issues. 6268 6269 https://bugs.webkit.org/show_bug.cgi?id=37432 6270 6271 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6272 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added. 6273 62742010-04-14 Brian Weinstein <bweinstein@apple.com> 6275 6276 Reviewed by Adam Roben. 6277 6278 Add a way for the buildbot to kill any old processes that are running. This 6279 is useful because the Windows bots can get in states where a process remains 6280 running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red 6281 state, and the processes must be killed manually. 6282 6283 * BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill 6284 the old processes that might be running. 6285 * BuildSlaveSupport/win/kill-old-processes: Added. 6286 62872010-04-14 Sam Weinig <sam@webkit.org> 6288 6289 Reviewed by Anders Carlsson. 6290 6291 Tear down WebKit more completely on window closing and application 6292 termination. We still don't block application termination for pending 6293 close, but this is a step in the right direction. 6294 6295 * MiniBrowser/mac/AppDelegate.m: 6296 (-[BrowserAppDelegate applicationWillTerminate:]): 6297 * MiniBrowser/mac/BrowserWindowController.h: 6298 * MiniBrowser/mac/BrowserWindowController.m: 6299 (-[BrowserWindowController dealloc]): 6300 (-[BrowserWindowController windowWillClose:]): 6301 (-[BrowserWindowController applicationTerminating]): 6302 63032010-04-14 Adam Barth <abarth@webkit.org> 6304 6305 Reviewed by Eric Seidel. 6306 6307 Use pretty patch for confirming webkit-patch diffs 6308 https://bugs.webkit.org/show_bug.cgi?id=37489 6309 6310 * Scripts/webkitpy/common/prettypatch.py: Added. 6311 * Scripts/webkitpy/tool/commands/download_unittest.py: 6312 * Scripts/webkitpy/tool/commands/upload_unittest.py: 6313 * Scripts/webkitpy/tool/mocktool.py: 6314 * Scripts/webkitpy/tool/steps/confirmdiff.py: 6315 63162010-04-14 Eric Seidel <eric@webkit.org> 6317 6318 Reviewed by Adam Barth. 6319 6320 Teach webkit-patch how to handle revisions missing ChangeLogs 6321 https://bugs.webkit.org/show_bug.cgi?id=37519 6322 6323 Make commit_info_for_revision return None when revision 6324 is missing a ChangeLog. Previously we would throw an array index 6325 exception. 6326 Teach callers how to handle None. 6327 6328 * Scripts/webkitpy/common/checkout/api.py: 6329 * Scripts/webkitpy/common/checkout/api_unittest.py: 6330 * Scripts/webkitpy/tool/commands/download.py: 6331 * Scripts/webkitpy/tool/commands/queries.py: 6332 * Scripts/webkitpy/tool/commands/sheriffbot.py: 6333 63342010-04-13 Eric Seidel <eric@webkit.org> 6335 6336 Reviewed by Adam Roben. 6337 6338 Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red) 6339 https://bugs.webkit.org/show_bug.cgi?id=33297 6340 6341 This is an experiment. The bots have been green for 6342 a while. We'll see if adding them under sheriff-bot protection 6343 will keep them green. 6344 6345 * Scripts/webkitpy/common/net/buildbot.py: 6346 * Scripts/webkitpy/common/net/buildbot_unittest.py: 6347 63482010-04-13 Eric Seidel <eric@webkit.org> 6349 6350 Unreviewed, just fixing a constant in the Rietveld unit test. 6351 6352 * Scripts/webkitpy/common/net/rietveld_unittest.py 6353 63542010-04-13 Eric Seidel <eric@webkit.org> 6355 6356 Unreviewed, just adding missing Mock to fix python tests. 6357 6358 * Scripts/webkitpy/tool/mocktool.py: 6359 63602010-04-13 Ojan Vafai <ojan@chromium.org> 6361 6362 Reviewed by David Levin. 6363 6364 Add experimental prototype Rietveld integration to webkit-patch upload 6365 https://bugs.webkit.org/show_bug.cgi?id=37418 6366 6367 This patch adds bare-bones integration with Rietveld for code reviews. 6368 The behavior is hidden behind the --fancy-review command line flag. 6369 Currently, there's no support for uploading more than one patch per 6370 issue (which is a nice feature of Rietveld). The plan is to play with 6371 this for a bit and see if it's useful. 6372 6373 Modified from Adam's original patch to autoinstall the rietveld upload script. 6374 6375 * Scripts/webkitpy/common/config/__init__.py: 6376 * Scripts/webkitpy/common/net/rietveld.py: Added. 6377 * Scripts/webkitpy/common/net/rietveld_unitttest.py: Added. 6378 * Scripts/webkitpy/tool/commands/queues_unittest.py: 6379 * Scripts/webkitpy/tool/commands/upload.py: 6380 * Scripts/webkitpy/tool/commands/upload_unittest.py: 6381 * Scripts/webkitpy/tool/main.py: 6382 * Scripts/webkitpy/tool/mocktool.py: 6383 * Scripts/webkitpy/tool/steps/__init__.py: 6384 * Scripts/webkitpy/tool/steps/options.py: 6385 * Scripts/webkitpy/tool/steps/postcodereview.py: Added. 6386 * Scripts/webkitpy/tool/steps/postdiff.py: 6387 63882010-04-13 Sam Weinig <sam@webkit.org> 6389 6390 Rubber-stamped by Mark Rowe. 6391 6392 Add Makefile to MiniBrowser. 6393 6394 * MiniBrowser/Makefile: Added. 6395 63962010-04-13 Eric Seidel <eric@webkit.org> 6397 6398 Unreviewed, just adding a sanity check. 6399 6400 Add check to make sure commit-queue can never commit too short a message 6401 https://bugs.webkit.org/show_bug.cgi?id=37528 6402 6403 The commit-queue made bogus messages here: 6404 http://trac.webkit.org/changeset/57532 6405 http://trac.webkit.org/changeset/57534 6406 6407 This was a regression caused by adding unicode parsing for 6408 our ChangeLog files. Popen does not seem to play nice with 6409 unicode strings. 6410 6411 I'm also adding an "assert" to make sure short ChangeLogs never happen again. 6412 6413 * Scripts/webkitpy/common/system/executive.py: 6414 - Cast input to strings before passing to POpen 6415 * Scripts/webkitpy/tool/steps/commit.py: 6416 - Validate that commit messages are not to short. 6417 64182010-04-13 Adam Roben <aroben@apple.com> 6419 6420 Robustify new-run-webkit-tests against paths with spaces in them 6421 6422 Reviewed by Eric Seidel. 6423 6424 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 6425 (LayoutTestApacheHttpd.__init__): Quote all paths that we pass to 6426 Apache to ensure that paths with spaces in them are interpreted 6427 correctly. 6428 64292010-04-13 Csaba Osztrogonác <ossy@webkit.org> 6430 6431 Unreviewed buildfix after r57537. 6432 6433 * DumpRenderTree/qt/LayoutTestControllerQt.h: Declaration of removeOriginAccessWhitelistEntry() added. 6434 64352010-04-13 Sam Weinig <sam@webkit.org> 6436 6437 Reviewed by Maciej Stachowiak. 6438 6439 Make building new webkit API and MiniBrowser a little easier. 6440 6441 * Scripts/build-webkit: Make building with --webkit2 build the 6442 MiniBrowser as well and tell you how to use it. 6443 * Scripts/run-minibrowser: Copied from Scripts/run-safari. 6444 * Scripts/webkitdirs.pm: Add runMiniBrowser function. 6445 64462010-04-12 Timothy Hatcher <timothy@apple.com> 6447 6448 SecurityOrigin needs a way to remove individual OriginAccessEntries 6449 https://bugs.webkit.org/show_bug.cgi?id=37449 6450 6451 Reviewed by Dave Hyatt. 6452 6453 * DumpRenderTree/LayoutTestController.cpp: 6454 (removeOriginAccessWhitelistEntryCallback): Added. Call LayoutTestController::removeOriginAccessWhitelistEntry. 6455 (LayoutTestController::staticFunctions): Added removeOriginAccessWhitelistEntry. 6456 * DumpRenderTree/LayoutTestController.h: 6457 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 6458 (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement. 6459 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 6460 (LayoutTestController::removeOriginAccessWhitelistEntry): Added. 6461 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 6462 (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement. 6463 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 6464 (LayoutTestController::removeOriginAccessWhitelistEntry): Added. 6465 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 6466 (LayoutTestController::whiteListAccessFromOrigin): FIXME to implement. 6467 (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement. 6468 64692010-04-13 Timothy Hatcher <timothy@apple.com> 6470 6471 Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry. 6472 And LayoutTestController.whiteListAccessFromOrigin to addOriginAccessWhitelistEntry. 6473 And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists. 6474 6475 SecurityOrigin needs a way to remove individual OriginAccessEntries 6476 https://bugs.webkit.org/show_bug.cgi?id=37449 6477 6478 Reviewed by Dave Hyatt. 6479 6480 * DumpRenderTree/LayoutTestController.cpp: 6481 (addOriginAccessWhitelistEntryCallback): 6482 (LayoutTestController::staticFunctions): 6483 * DumpRenderTree/LayoutTestController.h: 6484 * DumpRenderTree/chromium/LayoutTestController.cpp: 6485 (LayoutTestController::LayoutTestController): 6486 (LayoutTestController::addOriginAccessWhitelistEntry): 6487 * DumpRenderTree/chromium/LayoutTestController.h: 6488 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 6489 (LayoutTestController::addOriginAccessWhitelistEntry): 6490 * DumpRenderTree/mac/DumpRenderTree.mm: 6491 (resetWebViewToConsistentStateBeforeTesting): 6492 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 6493 (LayoutTestController::addOriginAccessWhitelistEntry): 6494 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 6495 (LayoutTestController::addOriginAccessWhitelistEntry): 6496 * DumpRenderTree/qt/LayoutTestControllerQt.h: 6497 * DumpRenderTree/win/DumpRenderTree.cpp: 6498 (resetWebViewToConsistentStateBeforeTesting): 6499 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 6500 (LayoutTestController::addOriginAccessWhitelistEntry): 6501 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 6502 (LayoutTestController::addOriginAccessWhitelistEntry): 6503 65042010-04-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 6505 6506 Reviewed by Eric Seidel. 6507 6508 Remove duplicate function for new-run-webkit-tests 6509 https://bugs.webkit.org/show_bug.cgi?id=37517 6510 6511 The version() function was already implemented. 6512 6513 * Scripts/webkitpy/layout_tests/port/webkit.py: 6514 65152010-04-13 Eric Seidel <eric@webkit.org> 6516 6517 Reviewed by David Levin. 6518 6519 the commit-queue hates Tor Arne Vestbø 6520 https://bugs.webkit.org/show_bug.cgi?id=37511 6521 6522 We were failing to read reviewers out of ChangeLogs 6523 when the reviewer has unicode characters in his/her name. 6524 I fixed this by explicitly decoding from utf8 every time we 6525 read in a ChangeLog file (they are always UTF8). 6526 6527 * Scripts/webkitpy/common/checkout/changelog.py: 6528 * Scripts/webkitpy/common/checkout/changelog_unittest.py: 6529 65302010-04-13 Adam Roben <aroben@apple.com> 6531 6532 Fix run-webkit-tests on Windows with spaces in the path 6533 6534 Fixes <http://webkit.org/b/37509>. 6535 6536 Reviewed by Steve Falkenburg. 6537 6538 * Scripts/run-webkit-tests: 6539 (convertPathUsingCygpath): Remove spaces from the path before passing 6540 them to cygpath, then add them back in after conversion, as some 6541 versions of cygpath seem to convert spaces into newlines. 6542 65432010-04-13 Adam Barth <abarth@webkit.org> 6544 6545 Unreviewed, but approved by Dumitru Daniliuc. (This patch is intended 6546 to fix the downstream Chromium build bots. Hopefully it will work!) 6547 6548 Add a driver script for the new websocket server 6549 https://bugs.webkit.org/show_bug.cgi?id=37495 6550 6551 websocket_server.py can't be run directly because its a module and not 6552 a standalone script. This used to work by accident because it didn't 6553 depend on any other modules. 6554 6555 * Scripts/new-run-webkit-websocketserver: Added. 6556 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 6557 65582010-04-12 Eric Seidel <eric@webkit.org> 6559 6560 Reviewed by Adam Barth. 6561 6562 Make new-run-webkit-test PrettyPatch failure reporting more awesome 6563 https://bugs.webkit.org/show_bug.cgi?id=37487 6564 6565 I also fixed an Executive/executive typo. 6566 6567 * Scripts/webkitpy/layout_tests/port/base.py: 6568 65692010-04-12 Eric Seidel <eric@webkit.org> 6570 6571 Reviewed by Adam Barth. 6572 6573 new-run-webkit-tests should only build java support files on Mac 6574 https://bugs.webkit.org/show_bug.cgi?id=37482 6575 6576 Only the mac needs java support files, so I pushed _build_java 6577 down into the Mac port using a new hook "_check_port_build". 6578 In the process I noticed a bunch of code which could be shared 6579 between all ports and thus got rid of _tests_for_disabled_features 6580 and version() copy/paste between all webkit ports. 6581 I also made check_build only bother to check for ImageDiff if we're 6582 using pixel tests. 6583 6584 * Scripts/webkitpy/layout_tests/port/gtk.py: 6585 * Scripts/webkitpy/layout_tests/port/mac.py: 6586 * Scripts/webkitpy/layout_tests/port/qt.py: 6587 * Scripts/webkitpy/layout_tests/port/webkit.py: 6588 * Scripts/webkitpy/layout_tests/port/win.py: 6589 65902010-04-12 Dumitru Daniliuc <dumi@chromium.org> 6591 6592 Unreviewed, trying to make scripts work on machines without 6593 Ruby... 6594 6595 * Scripts/webkitpy/layout_tests/port/base.py: 6596 65972010-04-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 6598 6599 Reviewed by Eric Seidel. 6600 6601 Add stub files for running new-run-webkit-tests for the Qt port 6602 6603 * Scripts/webkitpy/layout_tests/port/factory.py: 6604 * Scripts/webkitpy/layout_tests/port/qt.py: Added. 6605 66062010-04-12 Dirk Pranke <dpranke@chromium.org> 6607 6608 Reviewed by Eric Seidel. 6609 6610 Modify run_webkit_tests.py to not call sys.exit() at the end of test 6611 run; doing so makes it more difficult to embed the routine for, 6612 among other things, unit tests. We push the exit calling up into 6613 new-run-webkit-tests. 6614 6615 https://bugs.webkit.org/show_bug.cgi?id=37464 6616 6617 * Scripts/new-run-webkit-tests: 6618 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6619 66202010-04-12 Eric Seidel <eric@webkit.org> 6621 6622 Unreviewed. 6623 6624 Add stub Gtk implementation for new-run-webkit-tests. 6625 6626 * Scripts/webkitpy/layout_tests/port/factory.py: 6627 * Scripts/webkitpy/layout_tests/port/gtk.py: Added. 6628 66292010-04-12 Eric Seidel <eric@webkit.org> 6630 6631 Reviewed by Adam Barth. 6632 6633 new-run-webkit-tests fails with exception on systems missing ruby 6634 https://bugs.webkit.org/show_bug.cgi?id=37441 6635 6636 * Scripts/webkitpy/layout_tests/port/base.py: 6637 - Catch failures similar to how wdiff code path does. 6638 - After one failure, stop trying. 6639 66402010-04-12 Tony Chang <tony@chromium.org> 6641 6642 Reviewed by Eric Seidel. 6643 6644 Fix how we import simplejson based on how it's used in this file. 6645 This fixes exceptions raised when trying to write the simplejson output. 6646 6647 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6648 66492010-04-11 Chris Jerdonek <cjerdonek@webkit.org> 6650 6651 Reviewed by Shinichiro Hamaji. 6652 6653 Refactored check-webkit-style so that the StyleChecker class 6654 has no dependencies on patch-related concepts. 6655 6656 https://bugs.webkit.org/show_bug.cgi?id=37065 6657 6658 This patch is an intermediate step towards making the StyleChecker 6659 class a generalized file processor that can do arbitary operations 6660 on the files corresponding to a list of paths. This patch 6661 also simplifies the unit-testing of patch-checking code. 6662 6663 * Scripts/check-webkit-style: 6664 - Updated to use the new PatchChecker class. 6665 6666 * Scripts/webkitpy/style/checker.py: 6667 - Refactored the StyleChecker.check_patch() method into the 6668 check() method of a new PatchChecker class. 6669 6670 * Scripts/webkitpy/style/checker_unittest.py: 6671 - Refactored the unit tests as necessary, changing the 6672 StyleCheckerCheckPatchTest class to a PatchCheckerTest class. 6673 66742010-04-11 Adam Barth <abarth@webkit.org> 6675 6676 Unreviewed. 6677 6678 Fix new-run-webkit-tests regressions cased by Eric's option parsing patch 6679 https://bugs.webkit.org/show_bug.cgi?id=37430 6680 6681 We need some basic unit testing of this script, or we're going to keep 6682 breaking it like this. Added missing namespace qualifiers and 6683 propagated renaming of an option. 6684 6685 * Scripts/webkitpy/common/config/ports.py: 6686 * Scripts/webkitpy/layout_tests/driver_test.py: 6687 * Scripts/webkitpy/layout_tests/port/base.py: 6688 * Scripts/webkitpy/layout_tests/port/mac.py: 6689 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6690 66912010-04-11 Eric Seidel <eric@webkit.org> 6692 6693 Reviewed by Adam Barth. 6694 6695 Break new-run-webkit-tests options into groups for easier re-use and possible relocation 6696 https://bugs.webkit.org/show_bug.cgi?id=37408 6697 6698 new-run-webkit-tests currently has one huge function for 6699 dealing with all options-parsing. 6700 This patch is a first attempt at trying to split that large 6701 function down into smaller (hopefully more readable?) chunks 6702 dealing with the different areas of options. 6703 For example, it would make sense to move configuration 6704 options off into some module which deals with the vagries of 6705 WebKit's configuration system. It would also make sense to move 6706 Chromium options off onto the Chromium port object (where they are used). 6707 It may make sense to move results.json options over to the results.json code. 6708 This change is a first iteration, and we will certainly need more 6709 refinement to this code over time. Hopefully I didn't make things 6710 harder to read here. 6711 6712 * Scripts/webkitpy/layout_tests/driver_test.py: 6713 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6714 67152010-04-11 Adam Barth <abarth@webkit.org> 6716 6717 Reviewed by Eric Seidel. 6718 6719 create-rollout copy needs to be updated to reflect removal of --no-build 6720 https://bugs.webkit.org/show_bug.cgi?id=37425 6721 6722 Removed --no-build and --no-test from the instructions because these 6723 don't exist anymore. 6724 6725 * Scripts/webkitpy/tool/commands/download_unittest.py: 6726 - Updated the expected results to reflect the new copy. 6727 * Scripts/webkitpy/tool/steps/postdiffforrevert.py: 6728 67292010-04-11 Sheriff Bot <webkit.review.bot@gmail.com> 6730 6731 Unreviewed, rolling out r57460. 6732 http://trac.webkit.org/changeset/57460 6733 https://bugs.webkit.org/show_bug.cgi?id=37424 6734 6735 broke chromium builders (Requested by tony^work on #webkit). 6736 6737 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 6738 67392010-04-11 Tony Chang <tony@chromium.org> 6740 6741 Reviewed by Darin Fisher. 6742 6743 [chromium] update chromium DEPS for upstream compile 6744 https://bugs.webkit.org/show_bug.cgi?id=36578 6745 6746 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Small fix to avoid a circular dependency between 6747 WebKit.gyp and webkit.gyp. 6748 67492010-04-11 Joseph Pecoraro <joepeck@webkit.org> 6750 6751 Reviewed by Eric Seidel. 6752 6753 svn-apply errors out when removing directories in git 6754 https://bugs.webkit.org/show_bug.cgi?id=34871 6755 6756 * Scripts/svn-apply: 6757 (isDirectoryEmptyForRemoval): early break if the directory doesn't exist 6758 (scmRemove): have git ignore unmatched files 6759 67602010-04-11 Daniel Bates <dbates@rim.com> 6761 6762 No review, rolling out 57440. 6763 http://trac.webkit.org/changeset/57440 6764 https://bugs.webkit.org/show_bug.cgi?id=27204 6765 6766 Did not handle Git patches that included both file and property 6767 changes to the same file. Rolling this change out while I look 6768 into this. 6769 6770 * Scripts/VCSUtils.pm: 6771 * Scripts/svn-apply: 6772 * Scripts/svn-unapply: 6773 * Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Removed. 6774 * Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Removed. 6775 * Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Removed. 6776 67772010-04-11 Adam Barth <abarth@webkit.org> 6778 6779 Reviewed by Eric Seidel. 6780 6781 Fix typo in log path for AbstractQueue 6782 https://bugs.webkit.org/show_bug.cgi?id=37414 6783 6784 * Scripts/webkitpy/tool/commands/queues.py: 6785 * Scripts/webkitpy/tool/commands/queues_unittest.py: 6786 67872010-04-11 Adam Barth <abarth@webkit.org> 6788 6789 Unreviewed. Add missing import statement. 6790 6791 * Scripts/webkitpy/common/system/executive.py: 6792 67932010-04-11 Robert Hogan <robert@webkit.org> 6794 6795 Reviewed by Simon Hausmann. 6796 6797 [Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader 6798 6799 https://bugs.webkit.org/show_bug.cgi?id=37410 6800 6801 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 6802 (LayoutTestController::reset): 6803 (LayoutTestController::setWillSendRequestReturnsNull): 6804 (LayoutTestController::setWillSendRequestClearHeader): 6805 * DumpRenderTree/qt/LayoutTestControllerQt.h: 6806 68072010-04-11 Csaba Osztrogonác <ossy@webkit.org> 6808 6809 [Qt] Unreviewed buildfix for --debug build after r57433. 6810 6811 Refactor Qt DRT support in QtWebKit 6812 https://bugs.webkit.org/show_bug.cgi?id=35844 6813 6814 * QtLauncher/main.cpp: qt_drt_garbageCollector_collect(); renamed to DumpRenderTreeSupportQt::garbageCollectorCollect(); 6815 (launcherMain): 6816 68172010-04-11 Joseph Pecoraro <joepeck@webkit.org> 6818 6819 Reviewed by Mark Rowe. 6820 6821 Make commit-log-editor Rubber-stamp aware. And other minor cleanups. 6822 https://bugs.webkit.org/show_bug.cgi?id=37407 6823 6824 * Scripts/commit-log-editor: 6825 68262010-04-11 Eric Seidel <eric@webkit.org> 6827 6828 Reviewed by Adam Barth. 6829 6830 Add PrettyPatch links to new-run-webkit-tests output 6831 https://bugs.webkit.org/show_bug.cgi?id=37406 6832 6833 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 6834 - We're leaking a file handle here, add a FIXME. 6835 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 6836 - Add pretty diff links. 6837 * Scripts/webkitpy/layout_tests/port/base.py: 6838 - Add support for generating pretty diffs using PrettyPatch. 6839 * Scripts/webkitpy/layout_tests/port/webkit.py: 6840 - We're leaking another file handle here, another FIXME. 6841 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 6842 - Update write_output_files signature. 6843 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 6844 - Remove unused arguments from write_output_files. 6845 - Add support for dumping pretty diffs to write_output_files. 6846 - Fix a bunch of file descriptor leaks in this file. 6847 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 6848 - Update write_output_files signature. 6849 68502010-04-10 Adam Barth <abarth@webkit.org> 6851 6852 Reviewed by Eric Seidel. 6853 6854 kill_process is copy/pasted in five places 6855 https://bugs.webkit.org/show_bug.cgi?id=37405 6856 6857 We shouldn't replicate the kill_process logic in every port. Instead, 6858 we should move the process interaction to Executive. 6859 6860 Dirk mentioned that he wanted this abstraction to make it easier to 6861 mock things out for testing. It turns out this function is only used 6862 in one place where it can't be used as a mock point for testing because 6863 the corresponding create process actually creates a real process. In 6864 the long term, we should indirect both these calls through a non-static 6865 Executive as a mock point. However, we should wait on that until we 6866 actually want to write the test. 6867 6868 * Scripts/webkitpy/layout_tests/port/base.py: 6869 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 6870 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 6871 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 6872 * Scripts/webkitpy/layout_tests/port/mac.py: 6873 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 6874 * Scripts/webkitpy/layout_tests/port/win.py: 6875 68762010-04-10 Adam Barth <abarth@webkit.org> 6877 6878 Reviewed by Eric Seidel. 6879 6880 new-run-webkit-tests shouldn't alter its path to import packages 6881 https://bugs.webkit.org/show_bug.cgi?id=37404 6882 6883 * Scripts/new-run-webkit-tests: 6884 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 6885 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 6886 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 6887 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6888 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: 6889 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 6890 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 6891 * Scripts/webkitpy/thirdparty/simplejson/decoder.py: 6892 68932010-04-10 Eric Seidel <eric@webkit.org> 6894 6895 Reviewed by Adam Barth. 6896 6897 new-run-webkit-tests should store results to a directory under the build tree 6898 https://bugs.webkit.org/show_bug.cgi?id=37380 6899 6900 * Scripts/webkitpy/layout_tests/port/webkit.py: 6901 69022010-04-10 Daniel Bates <dbates@rim.com> 6903 6904 Reviewed by Eric Seidel. 6905 6906 https://bugs.webkit.org/show_bug.cgi?id=27204 6907 6908 Implement support for changing the executable bit of a file. 6909 The executable bit is among the most changed file properties. 6910 Future support can include other property changes. 6911 6912 Currently, if a patch changes the executable bit of a file 6913 it is not respected by svn-apply or svn-unapply. Since the 6914 commit-queue bot uses these tools as part of its workflow, 6915 such patches cannot be committed by it. That is, such patches 6916 need to be committed by hand. Instead, we should add support 6917 for the executable bit so that such patches can be committed 6918 by the commit-queue bot. 6919 6920 * Scripts/VCSUtils.pm: Also change reference to Apple Computer, Inc. 6921 in copyright to Apple, Inc. 6922 * Scripts/svn-apply: 6923 * Scripts/svn-unapply: 6924 * Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Added. 6925 * Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Added. 6926 * Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Added. 6927 69282010-04-10 Eric Seidel <eric@webkit.org> 6929 6930 Reviewed by Adam Barth. 6931 6932 WinEWS bot fails to svn update because scm.clean_working_directory leaves files around 6933 https://bugs.webkit.org/show_bug.cgi?id=37401 6934 6935 The Git-based bots don't have this trouble because 6936 Git.clean_working_directory fully removes files that were 6937 marked as "add". SVN.clean_working_directory previously just 6938 called "svn revert" which would leave added files in the 6939 working directory untracked. This patch makes 6940 SVN.clean_working_directory function more like 6941 Git.clean_working_directory by removing added files after revert. 6942 6943 * Scripts/webkitpy/common/checkout/scm.py: 6944 - Add SCM.absolute_path for easy conversion between 6945 repository-relative paths and absolute paths. 6946 - Add SCM.add and SCM.added_files 6947 - Make SVN.clean_working_directory remove any added_files after svn revert. 6948 - The new unit tests found a bug in Git.status_command, change to use git diff --name-status instead. 6949 * Scripts/webkitpy/common/checkout/scm_unittest.py: 6950 - Add tests for added code. 6951 69522010-04-10 Adam Barth <abarth@webkit.org> 6953 6954 Reviewed by Eric Seidel. 6955 6956 new-run-webkit-tests can't find ImageDiff on Windows 6957 https://bugs.webkit.org/show_bug.cgi?id=37403 6958 6959 It turns out the build directory on Windows is structured differently 6960 than it is on other platforms. Instead of assuming the normal 6961 structure, we should just ask perl to figure it out for us. 6962 6963 * Scripts/webkitpy/layout_tests/port/webkit.py: 6964 69652010-04-10 Adam Barth <abarth@webkit.org> 6966 6967 Rubber-stamped by Eric Seidel. 6968 6969 Change "Gathering files" status line to "Collecting tests". Gathering 6970 the files sounds silly to me. 6971 6972 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6973 69742010-04-10 Adam Barth <abarth@webkit.org> 6975 6976 Reviewed by Eric Seidel. 6977 6978 Fix bugs to make new-run-webkit-tests almost run on windows 6979 https://bugs.webkit.org/show_bug.cgi?id=37400 6980 6981 Fix some minor bugs that prevent new-run-webkit-tests from being run on 6982 Windows. I still haven't run it to completion, but I'm getting 6983 further. 6984 6985 * Scripts/webkitpy/layout_tests/port/factory.py: 6986 * Scripts/webkitpy/layout_tests/port/webkit.py: 6987 69882010-04-10 Robert Hogan <robert@webkit.org> 6989 6990 Reviewed by Kenneth Rohde Christiansen. 6991 6992 Refactor Qt DRT support in QtWebKit 6993 6994 Update Qt DRT to use new DumpRenderTreeSupportQt static class. 6995 6996 https://bugs.webkit.org/show_bug.cgi?id=35844 6997 6998 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 6999 (WebCore::DumpRenderTree::DumpRenderTree): 7000 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 7001 (WebCore::DumpRenderTree::dumpFramesAsText): 7002 * DumpRenderTree/qt/DumpRenderTreeQt.h: 7003 * DumpRenderTree/qt/GCControllerQt.cpp: 7004 (GCController::collect): 7005 (GCController::collectOnAlternateThread): 7006 (GCController::getJSObjectCount): 7007 * DumpRenderTree/qt/GCControllerQt.h: 7008 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 7009 (LayoutTestController::counterValueForElementById): 7010 (LayoutTestController::setViewModeMediaFeature): 7011 (LayoutTestController::setMediaType): 7012 (LayoutTestController::closeWebInspector): 7013 (LayoutTestController::showWebInspector): 7014 (LayoutTestController::evaluateInWebInspector): 7015 (LayoutTestController::setFrameFlatteningEnabled): 7016 (LayoutTestController::setJavaScriptProfilingEnabled): 7017 (LayoutTestController::setTimelineProfilingEnabled): 7018 (LayoutTestController::pauseAnimationAtTimeOnElementWithId): 7019 (LayoutTestController::pauseTransitionAtTimeOnElementWithId): 7020 (LayoutTestController::sampleSVGAnimationForElementAtTime): 7021 (LayoutTestController::numberOfActiveAnimations): 7022 (LayoutTestController::whiteListAccessFromOrigin): 7023 (LayoutTestController::setCaretBrowsingEnabled): 7024 (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): 7025 (LayoutTestController::workerThreadCount): 7026 (LayoutTestController::pageNumberForElementById): 7027 (LayoutTestController::numberOfPages): 7028 * DumpRenderTree/qt/LayoutTestControllerQt.h: 7029 70302010-04-10 Adam Barth <abarth@webkit.org> 7031 7032 Reviewed by Eric Seidel. 7033 7034 Move global queue log to the logs directory so it survives git clean -f 7035 https://bugs.webkit.org/show_bug.cgi?id=37395 7036 7037 * Scripts/webkitpy/tool/commands/queues.py: 7038 70392010-04-10 Adam Barth <abarth@webkit.org> 7040 7041 Reviewed by Eric Seidel. 7042 7043 SheriffBot should spam when it encounters errors 7044 https://bugs.webkit.org/show_bug.cgi?id=37329 7045 7046 We need to always update the status server so we don't get stuck in a 7047 spam loop. I tried writing a test for this change, but it kind of 7048 got out of control. We need a better way to do failure injection. 7049 7050 * Scripts/webkitpy/tool/commands/sheriffbot.py: 7051 70522010-04-10 Adam Barth <abarth@webkit.org> 7053 7054 Unreviewed attempt to fix the Chromium Mac canary. 7055 7056 * Scripts/webkitpy/common/config/ports.py: 7057 * Scripts/webkitpy/common/config/ports_unittest.py: 7058 * Scripts/webkitpy/common/system/executive.py: 7059 70602010-04-10 Adam Barth <abarth@webkit.org> 7061 7062 Unreviewed. 7063 7064 Add the Apache bits to win.py for new-run-webkit-tests 7065 https://bugs.webkit.org/show_bug.cgi?id=37397 7066 7067 I still have run this yet, but I looked around to figure out what the 7068 various paths appear to be. I'll figure out a way to remove the 7069 copy/paste code in a future patch. 7070 7071 * Scripts/webkitpy/layout_tests/port/mac.py: 7072 * Scripts/webkitpy/layout_tests/port/webkit.py: 7073 * Scripts/webkitpy/layout_tests/port/win.py: 7074 70752010-04-10 Adam Barth <abarth@webkit.org> 7076 7077 Reviewed by Eric Seidel. 7078 7079 Sketch out the win port for new-run-webkit-tests 7080 https://bugs.webkit.org/show_bug.cgi?id=37393 7081 7082 I haven't tried running this yet, but we've got to start somewhere. 7083 7084 * Scripts/webkitpy/layout_tests/port/factory.py: 7085 * Scripts/webkitpy/layout_tests/port/mac.py: 7086 * Scripts/webkitpy/layout_tests/port/webkit.py: 7087 * Scripts/webkitpy/layout_tests/port/win.py: Added. 7088 70892010-04-10 Ojan Vafai <ojan@chromium.org> 7090 7091 Reviewed by Adam Barth. 7092 7093 webkit-patch land should not build and test by default 7094 https://bugs.webkit.org/show_bug.cgi?id=33631 7095 7096 Reverse the sense of --no-build and --no-test to be --build and --test. 7097 Also, decoupled the build and test options so you can test without 7098 building. 7099 7100 (Patch manngled by Adam Barth. All bugs are his fault.) 7101 7102 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 7103 * Scripts/webkitpy/tool/commands/queues.py: 7104 * Scripts/webkitpy/tool/commands/queues_unittest.py: 7105 * Scripts/webkitpy/tool/steps/options.py: 7106 * Scripts/webkitpy/tool/steps/runtests.py: 7107 71082010-04-10 Adam Barth <abarth@webkit.org> 7109 7110 Reviewed by Eric Seidel. 7111 7112 Factor WebKitPort out of MacPort to allow for WinPort 7113 https://bugs.webkit.org/show_bug.cgi?id=37388 7114 7115 The split is a bit of a guess. We might have to adjust things once we 7116 actually have a second port to work with. 7117 7118 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 7119 * Scripts/webkitpy/layout_tests/port/mac.py: 7120 * Scripts/webkitpy/layout_tests/port/webkit.py: Added. 7121 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 7122 71232010-04-10 Adam Barth <abarth@webkit.org> 7124 7125 Reviewed by Eric Seidel. 7126 7127 run_webkit_tests.py shouldn't have platform-specific logic 7128 https://bugs.webkit.org/show_bug.cgi?id=37387 7129 7130 Dirk Pranke pointed out that my last patch was wrong because I 7131 introduced platform-specific logic into run_webkit_tests.py, limiting 7132 the parallelism in Chromium to work around a bug in the main Mac port. 7133 7134 * Scripts/webkitpy/common/system/executive.py: 7135 - Fix a typo pointed out by Chris Jerdonek. 7136 * Scripts/webkitpy/layout_tests/port/base.py: 7137 * Scripts/webkitpy/layout_tests/port/mac.py: 7138 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 7139 71402010-04-10 Robert Hogan <robert@webkit.org> 7141 7142 Unreviewed fix to regressions in r57416. 7143 7144 [Qt] Fix regressions in http/tests/navigation from r57416 7145 7146 Reset willSendRequestReturnsNullOnRedirect after each test to 7147 prevent it leaking to subsequent tests. 7148 7149 Error pointed out by Jakub Wieczorek. 7150 7151 https://bugs.webkit.org/show_bug.cgi?id=37237 7152 7153 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 7154 (LayoutTestController::reset): 7155 71562010-04-11 Robert Hogan <robert@webkit.org> 7157 7158 Reviewed by Simon Hausmann. 7159 7160 [Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports. 7161 7162 Add support for layoutTestController.setWillSendRequestReturnsNullOnRedirect to Qt DRT. 7163 Prevent dumping resource load callbacks once layout test has dumped. 7164 7165 https://bugs.webkit.org/show_bug.cgi?id=37237 7166 7167 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 7168 (WebCore::DumpRenderTree::dump): 7169 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 7170 (LayoutTestController::setWillSendRequestReturnsNullOnRedirect): 7171 * DumpRenderTree/qt/LayoutTestControllerQt.h: 7172 71732010-04-10 Laszlo Gombos <laszlo.1.gombos@nokia.com> 7174 7175 Reviewed by Kenneth Rohde Christiansen. 7176 7177 [Qt] Implement Desktop Notifications API for QtWebKit 7178 https://bugs.webkit.org/show_bug.cgi?id=35503 7179 7180 DRT stubs for notification. Enables to run and pass 7181 3 (currently disabled) tests. 7182 7183 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 7184 (LayoutTestController::LayoutTestController): 7185 (LayoutTestController::grantDesktopNotificationPermission): 7186 (LayoutTestController::checkDesktopNotificationPermission): 7187 * DumpRenderTree/qt/LayoutTestControllerQt.h: 7188 71892010-04-09 Dumitru Daniliuc <dumi@chromium.org> 7190 7191 Unreviewed, another change to executive.py to make it run with 7192 python 2.4. 7193 7194 * Scripts/webkitpy/common/system/executive.py: 7195 71962010-04-09 Dumitru Daniliuc <dumi@chromium.org> 7197 7198 Unreviewed, attempting to make executive.py run with python 2.4 7199 (which is still used on Chromium's Windows canary bot). 7200 7201 * Scripts/webkitpy/common/system/executive.py: 7202 72032010-04-09 Kevin Watters <kevinwatters@gmail.com> 7204 7205 Reviewed by Eric Seidel. 7206 7207 [wx] Basic implementation of SVG support for wx port. 7208 7209 * wx/build/settings.py: 7210 72112010-04-09 Adam Barth <abarth@webkit.org> 7212 7213 Reviewed by Eric Seidel. 7214 7215 Don't reinvent Executive.cpu_count for every port 7216 https://bugs.webkit.org/show_bug.cgi?id=37377 7217 7218 mac.py and chromium_mac.py had some copy/paste code. This code doesn't 7219 actually have anything to do with WebKit ports. It's really just 7220 something in the multiprocessing package. The lame bit is that package 7221 isn't available in older versions of Python, so we need to implement a 7222 fallback. However, we already have the fallback in common. We don't 7223 need to reinvent it specificly for layout_tests. 7224 7225 * Scripts/webkitpy/common/system/executive.py: 7226 * Scripts/webkitpy/layout_tests/port/base.py: 7227 * Scripts/webkitpy/layout_tests/port/chromium.py: 7228 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 7229 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 7230 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 7231 * Scripts/webkitpy/layout_tests/port/mac.py: 7232 * Scripts/webkitpy/layout_tests/port/test.py: 7233 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 7234 72352010-04-09 Adam Barth <abarth@webkit.org> 7236 7237 Reviewed by Eric Seidel. 7238 7239 new-run-webkit-tests --release fails to build release DRT when global configuration is Debug 7240 https://bugs.webkit.org/show_bug.cgi?id=37376 7241 7242 We need to explicitly pass the --release flag. I bet there are more 7243 instances of this bug. 7244 7245 * Scripts/webkitpy/layout_tests/port/base.py: 7246 * Scripts/webkitpy/layout_tests/port/mac.py: 7247 72482010-04-09 Tony Chang <tony@chromium.org> 7249 7250 Reviewed by Eric Seidel. 7251 7252 [chromium] DRT compile fix on win/linux 7253 https://bugs.webkit.org/show_bug.cgi?id=37314 7254 7255 Looks like this was missed when upstreaming. 7256 7257 * DumpRenderTree/chromium/EventSender.cpp: 7258 (applyKeyModifier): 7259 72602010-04-09 Adam Barth <abarth@webkit.org> 7261 7262 Unreviewed, but approved by Dirk Pranke. 7263 7264 rename test_expectations_test.py to test_expectations_unittest.py so it actually gets run 7265 https://bugs.webkit.org/show_bug.cgi?id=37372 7266 7267 We need to end unit tests with _unittest.py for them to be autodetected 7268 by the test harness. +6 tests. 7269 7270 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py. 7271 72722010-04-09 Adam Barth <abarth@webkit.org> 7273 7274 Reviewed by Eric Seidel. 7275 7276 new-run-webkit-tests should talk about DumpRenderTree not test_shell 7277 https://bugs.webkit.org/show_bug.cgi?id=37371 7278 7279 test_shell is some strange Chromium thing. 7280 DumpRenderTree (tm) is the real deal. 7281 7282 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Added. 7283 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 7284 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 7285 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Removed. 7286 * Scripts/webkitpy/layout_tests/port/chromium.py: 7287 * Scripts/webkitpy/layout_tests/port/server_process.py: 7288 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 7289 72902010-04-09 Zoltan Horvath <zoltan@webkit.org> 7291 7292 Reviewed by Alexey Proskuryakov. 7293 7294 Fix 2 issues (what were introduced in r56524) in svn-create-patch's generateDiff() 7295 https://bugs.webkit.org/show_bug.cgi?id=32582 7296 7297 Add missing return variable. Initialize $patch variable and remove unnecessary condition. 7298 7299 * Scripts/svn-create-patch: 7300 73012010-04-09 Kevin Ollivier <kevino@theolliviers.com> 7302 7303 [wx] Build fix after addition of LayoutTestController method. 7304 7305 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 7306 (LayoutTestController::computedStyleIncludingVisitedInfo): 7307 73082010-04-09 Sam Weinig <sam@webkit.org> 7309 7310 Reviewed by Anders Carlsson. 7311 7312 Fix for https://bugs.webkit.org/show_bug.cgi?id=37368 7313 Add MiniBrowser. 7314 7315 * MiniBrowser: Added. 7316 * MiniBrowser/MiniBrowser.vcproj: Added. 7317 * MiniBrowser/MiniBrowser.xcodeproj: Added. 7318 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added. 7319 * MiniBrowser/mac: Added. 7320 * MiniBrowser/mac/AppDelegate.h: Added. 7321 * MiniBrowser/mac/AppDelegate.m: Added. 7322 * MiniBrowser/mac/BrowserWindowController.h: Added. 7323 * MiniBrowser/mac/BrowserWindowController.m: Added. 7324 * MiniBrowser/mac/English.lproj: Added. 7325 * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Added. 7326 * MiniBrowser/mac/English.lproj/InfoPlist.strings: Added. 7327 * MiniBrowser/mac/English.lproj/MainMenu.xib: Added. 7328 * MiniBrowser/mac/MiniBrowser-Info.plist: Added. 7329 * MiniBrowser/mac/MiniBrowser_Prefix.pch: Added. 7330 * MiniBrowser/mac/main.m: Added. 7331 * MiniBrowser/win: Added. 7332 * MiniBrowser/win/BrowserView.cpp: Added. 7333 * MiniBrowser/win/BrowserView.h: Added. 7334 * MiniBrowser/win/BrowserWindow.cpp: Added. 7335 * MiniBrowser/win/BrowserWindow.h: Added. 7336 * MiniBrowser/win/MiniBrowser.cpp: Added. 7337 * MiniBrowser/win/MiniBrowser.h: Added. 7338 * MiniBrowser/win/MiniBrowser.rc: Added. 7339 * MiniBrowser/win/Resources: Added. 7340 * MiniBrowser/win/main.cpp: Added. 7341 * MiniBrowser/win/resource.h: Added. 7342 * MiniBrowser/win/stdafx.cpp: Added. 7343 * MiniBrowser/win/stdafx.h: Added. 7344 73452010-04-09 Eric Seidel <eric@webkit.org> 7346 7347 Reviewed by Adam Barth. 7348 7349 webkit-patch attached my patch to the wrong bug 7350 https://bugs.webkit.org/show_bug.cgi?id=37015 7351 7352 The problem here is that SVN was violating SCM's implicit 7353 contract of always returning paths relative to the repository root. 7354 That can easily be fixed by telling SVN that the CWD is the repository root. 7355 7356 When fixing this I realized there are a large number of places in SCM.py where 7357 we want to consider explicitly passing self.checkout_root as the CWD. 7358 That would allow scm methods to be executed even when the CWD is not inside 7359 the scm tree at all, and would also make sure (in the case of SVN) that paths 7360 returned are relative to the root. Git (almost always) returns paths relative 7361 to the repository root. 7362 7363 * Scripts/webkitpy/common/checkout/scm.py: 7364 - Explicitly pass self.checkout_root as cwd in run_status_and_extract_filenames 7365 - Add a ton of FIXMEs about the need to go back and decide which methods require cwd=self.checkout_root 7366 and which do not. We'll probably add a helper function to scm (likely SCM._run) which 7367 always passes cwd=self.checkout_root to Executive.run_command 7368 * Scripts/webkitpy/common/checkout/scm_unittest.py: 7369 - Add a test for this change. 7370 * Scripts/webkitpy/tool/commands/upload.py: 7371 - Removed the explicit os.chdir to the repository root, since scm.py methods 7372 should be robust against the cwd not being equal to the root. 7373 73742010-04-09 Adam Roben <aroben@apple.com> 7375 7376 Don't return 0 as a JSValueRef 7377 7378 That is an illegal use of the JSC API. 7379 7380 Fixes <http://webkit.org/b/37333> REGRESSION (r57292): :visited tests 7381 are asserting on debug Windows and GTK builds 7382 7383 Reviewed by Anders Carlsson. 7384 7385 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 7386 (LayoutTestController::computedStyleIncludingVisitedInfo): 7387 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 7388 (LayoutTestController::computedStyleIncludingVisitedInfo): 7389 Return an "undefined" JSValueRef instead of 0. 7390 73912010-04-09 Csaba Osztrogonác <ossy@webkit.org> 7392 7393 Reviewed by Eric Seidel. 7394 7395 Make DumpRenderTree parallelizable 7396 https://bugs.webkit.org/show_bug.cgi?id=36899 7397 7398 * DumpRenderTree/mac/DumpRenderTree.mm: 7399 (libraryPathForDumpRenderTree): Use DUMPRENDERTREE_TEMP if exist. 7400 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 7401 (WebCore::DumpRenderTree::DumpRenderTree): Use DUMPRENDERTREE_TEMP if exist. 7402 * Scripts/run-webkit-tests: 7403 - Create a unique temporary directory and pass its path to 7404 DumpRenderTree with DUMPRENDERTREE_TEMP environment variable. 7405 74062010-04-09 Mark Rowe <mrowe@apple.com> 7407 7408 Reviewed by Oliver Hunt. 7409 7410 <http://webkit.org/b/37326> IDL files are being copied in to the WebCore framework again 7411 7412 Add a script to detect the presence of inappropriate files in the frameworks. At present 7413 it only looks for .css, .idl and .in files in the top level of WebCore.framework/Resources, 7414 as these are the only cases we've encountered recently. It can be extended to check the 7415 other frameworks or for other inappropriate files in the future. 7416 7417 * Scripts/check-for-inappropriate-files-in-framework: Added. 7418 74192010-04-08 Sam Weinig <sam@webkit.org> 7420 7421 Reviewed by Darin Adler. 7422 7423 Add option to build WebKit2 to build-webkit. 7424 7425 * Scripts/build-webkit: 7426 74272010-04-08 Darin Adler <darin@apple.com> 7428 7429 Reviewed by Alexey Proskuryakov. 7430 7431 run-webkit-tests should respect argument order 7432 https://bugs.webkit.org/show_bug.cgi?id=37257 7433 7434 * Scripts/run-webkit-tests: Changed so that sorting is done only 7435 on the results of iterating directories. Test order is based on 7436 what's passed on the command line. Removed code that aimed to 7437 eliminate duplicates since it can be useful to run the same test 7438 more than once. 7439 74402010-04-07 David Hyatt <hyatt@apple.com> 7441 7442 Reviewed by Oliver Hunt. 7443 7444 https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS. Add a new method for 7445 obtaining computed style with :visited info included. This allows layout tests to actually tell that 7446 :visited is in effect. 7447 7448 * DumpRenderTree/LayoutTestController.cpp: 7449 (computedStyleIncludingVisitedInfoCallback): 7450 (LayoutTestController::staticFunctions): 7451 * DumpRenderTree/LayoutTestController.h: 7452 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 7453 (LayoutTestController::computedStyleIncludingVisitedInfo): 7454 74552010-04-07 Dirk Pranke <dpranke@chromium.org> 7456 7457 Reviewed by Adam Barth. 7458 7459 Enable rebaseline-chromium-webkit-tests to run from a webkit-only 7460 checkout (i.e., you don't need anything from the Chromium tree checked 7461 out). This requires us to introduce the concept of a "target" 7462 port/platform that we use to get configuration information from as well 7463 as the "running" port that we use to make directories and diff images 7464 and the "rebaselining" port we use to actually manage baselines. 7465 7466 https://bugs.webkit.org/show_bug.cgi?id=37238 7467 7468 * Scripts/webkitpy/layout_tests/port/mac.py: 7469 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 7470 74712010-04-05 Antonio Gomes <tonikitoo@webkit.org> 7472 7473 Reviewed by Simon Hausmann. 7474 7475 [Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect. 7476 https://bugs.webkit.org/show_bug.cgi?id=29431 7477 7478 Added stubs for Mac, win, gtk and wx DRTs to implement setScrollbarPolicy method. 7479 7480 * DumpRenderTree/LayoutTestController.cpp: 7481 (setScrollbarPolicyCallback): 7482 (LayoutTestController::staticFunctions): 7483 * DumpRenderTree/LayoutTestController.h: 7484 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 7485 (LayoutTestController::setScrollbarPolicy): 7486 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 7487 (LayoutTestController::setScrollbarPolicy): 7488 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 7489 (LayoutTestController::setScrollbarPolicy): 7490 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 7491 (LayoutTestController::setScrollbarPolicy): 7492 74932010-04-01 Antonio Gomes <tonikitoo@webkit.org> 7494 7495 Reviewed by David Hyatt. 7496 7497 [Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect. 7498 https://bugs.webkit.org/show_bug.cgi?id=29431 7499 7500 Make possible to DRT to set scrollbar policies (on, off or auto). 7501 7502 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 7503 (LayoutTestController::setScrollbarPolicy): 7504 * DumpRenderTree/qt/LayoutTestControllerQt.h: 7505 * QtLauncher/main.cpp: 7506 (LauncherWindow::toggleScrollbars): 7507 (LauncherWindow::createChrome): 7508 75092010-04-08 Adam Barth <abarth@webkit.org> 7510 7511 Reviewed by Eric Seidel. 7512 7513 new-run-webkit-tests should give a percent complete indication 7514 https://bugs.webkit.org/show_bug.cgi?id=37258 7515 7516 Because it's awesome. 7517 7518 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 7519 75202010-04-08 Adam Barth <abarth@webkit.org> 7521 7522 Unreviewed. 7523 7524 Add back the --target option because it's needed by the downstream 7525 Chromium bots. 7526 7527 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 7528 75292010-04-08 Adam Barth <abarth@webkit.org> 7530 7531 Reviewed by Eric Seidel. 7532 7533 new-run-webkit-tests should understand set-webkit-configuration 7534 https://bugs.webkit.org/show_bug.cgi?id=37252 7535 7536 * Scripts/webkitpy/layout_tests/port/base.py: 7537 * Scripts/webkitpy/layout_tests/port/mac.py: 7538 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 7539 75402010-04-08 Adam Barth <abarth@webkit.org> 7541 7542 Reviewed by Eric Seidel. 7543 7544 Rename target to configuration in new-run-webkit-tests to match the rest of WebKit 7545 https://bugs.webkit.org/show_bug.cgi?id=37251 7546 7547 The rest of our tools call --debug or --release the configuration. 7548 It's confusing to call it target in this script. 7549 7550 * Scripts/webkitpy/layout_tests/driver_test.py: 7551 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 7552 * Scripts/webkitpy/layout_tests/port/base.py: 7553 * Scripts/webkitpy/layout_tests/port/chromium.py: 7554 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 7555 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 7556 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 7557 * Scripts/webkitpy/layout_tests/port/mac.py: 7558 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 7559 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 7560 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: 7561 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 7562 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 7563 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 7564 75652010-04-07 Adam Barth <abarth@webkit.org> 7566 7567 Reviewed by Eric Seidel. 7568 7569 Remove depricated op.popen2 call in new-run-webkit-tests 7570 https://bugs.webkit.org/show_bug.cgi?id=37249 7571 7572 Python complains that this API is depricated. We already solved this 7573 problem in executive.py. 7574 7575 * Scripts/webkitpy/layout_tests/port/mac.py: 7576 75772010-04-07 Eric Seidel <eric@webkit.org> 7578 7579 Reviewed by Adam Barth. 7580 7581 new-run-webkit-tests crashes when run on a 64-bit machine 7582 https://bugs.webkit.org/show_bug.cgi?id=37248 7583 7584 * Scripts/webkitpy/layout_tests/port/mac.py: 7585 - The code was trying to always run the 32-bit intel version 7586 of the DumpRenderTree binary. DRT does not build 32-bit on 64-bit 7587 machines so that makes no sense. This may have made sense for test_shell 7588 at some point, but I think we should just remove this for DRT. 7589 75902010-04-07 Eric Seidel <eric@webkit.org> 7591 7592 Reviewed by Adam Barth. 7593 7594 WebKit Apache configs only listen on IPv4 addresses, causing random timeouts 7595 https://bugs.webkit.org/show_bug.cgi?id=37104 7596 7597 Add warnings that the partial support for specifying what port numbers 7598 apache should bind to is even more broken after this fix. 7599 7600 * Scripts/run-webkit-httpd: 7601 * Scripts/run-webkit-tests: 7602 76032010-04-07 Shinichiro Hamaji <hamaji@chromium.org> 7604 7605 Reviewed by Darin Adler. 7606 7607 LayoutTestController::m_handlesAuthenticationChallenges isn't initialized 7608 https://bugs.webkit.org/show_bug.cgi?id=37190 7609 7610 * DumpRenderTree/LayoutTestController.cpp: 7611 (LayoutTestController::LayoutTestController): 7612 76132010-03-31 Eric Seidel <eric@webkit.org> 7614 7615 Reviewed by Adam Barth. 7616 7617 Add webkit-patch command to crawl buildbot history and find when tests 7618 started to fail. 7619 https://bugs.webkit.org/show_bug.cgi?id=36911 7620 7621 This is a very bare-bones implementation, which works, but isn't pretty. 7622 We will need further re-factoring and improvement to this code, but 7623 after long discussions with Adam, I think it's best that we land this 7624 and iterate from there. 7625 7626 * Scripts/webkitpy/common/net/buildbot.py: 7627 - Add revision_build_pairs_with_results for cleaner code and possible 7628 optimization of this command. 7629 - Return None if a build number can't be found for a revision in 7630 build_for_revision 7631 - Separate out suspect_revisions_for_transition for re-use by 7632 FailureReason 7633 - Add LayoutTestResults.failing_tests() and make our parsing code 7634 explict about what tables it accepts. 7635 * Scripts/webkitpy/tool/commands/queries.py: 7636 - Move _print_blame_information_for_commit out of WhatBroke for re-use 7637 by FailureReason. 7638 - Add FailureReason command which can crawl a given builder and explain 7639 why it is currently red on a per-test basis. 7640 76412010-04-06 Kent Tamura <tkent@chromium.org> 7642 7643 Reviewed by Dimitri Glazkov. 7644 7645 [DRT/Chromium] Add DumpRenderTree.gyp, and some small fixes 7646 https://bugs.webkit.org/show_bug.cgi?id=37137 7647 7648 - Add DumpRenderTree.gyp 7649 - Remove some dependencies to base/string_util.h, 7650 base/compiler_specific.h, base/file_path.h, base/file_util.h, 7651 base/message_loop.h, base/sys_string_conversions.h, 7652 7653 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Added. 7654 * DumpRenderTree/chromium/CppVariant.cpp: 7655 (CppVariant::toStringVector): 7656 * DumpRenderTree/chromium/EventSender.cpp: 7657 (EventSender::EventSender): 7658 (EventSender::keyDown): 7659 (EventSender::scheduleAsynchronousClick): 7660 (EventSender::beginDragWithFiles): 7661 * DumpRenderTree/chromium/LayoutTestController.cpp: 7662 (LayoutTestController::setUserStyleSheetLocation): 7663 (LayoutTestController::pathToLocalResource): 7664 * DumpRenderTree/chromium/TextInputController.cpp: 7665 (TextInputController::markedRange): 7666 (TextInputController::selectedRange): 7667 76682010-04-06 Dirk Pranke <dpranke@chromium.org> 7669 7670 Reviewed by Eric Seidel. 7671 7672 Write stack traces into the results directory for new-run-webkit-tests, 7673 instead of writing them alongside the test file. 7674 7675 https://bugs.webkit.org/show_bug.cgi?id=36504 7676 7677 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 7678 76792010-04-06 Dirk Pranke <dpranke@chromium.org> 7680 7681 Unreviewed build fix. 7682 7683 Enable pixel tests by default in new-run-webkit-tests unless 7684 explicitly set by the port or by the command line. This was broken in 7685 the fix for bug 36801 (rev. 57173). 7686 7687 https://bugs.webkit.org/show_bug.cgi?id=37184 7688 7689 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 7690 76912010-04-06 Dirk Pranke <dpranke@chromium.org> 7692 7693 Reviewed by Eric Seidel. 7694 7695 Disable pixel tests on the mac port by default. 7696 7697 Also, revamp the way we check for pixel tests being enabled or 7698 disabled. We now look for options.pixel_tests instead of 7699 options.no_pixel_tests, and we have the "--pixel-tests" (force enable) 7700 and "--no-pixel-tests" (force disable) flags. 7701 7702 https://bugs.webkit.org/show_bug.cgi?id=36801 7703 7704 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 7705 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: 7706 * Scripts/webkitpy/layout_tests/port/chromium.py: 7707 * Scripts/webkitpy/layout_tests/port/mac.py: 7708 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 7709 77102010-04-06 Diego Gonzalez <diego.gonzalez@openbossa.org> 7711 7712 Reviewed by Laszlo Gombos. 7713 7714 [Qt] Added the iPhone and iPad latest user agent in QtLauncher UA switcher 7715 https://bugs.webkit.org/show_bug.cgi?id=37159 7716 7717 * QtLauncher/useragentlist.txt: 7718 77192010-04-06 Laszlo Gombos <laszlo.1.gombos@nokia.com> 7720 7721 Reviewed by Kenneth Rohde Christiansen. 7722 7723 [Qt] Add current user-agent string for Symbian for QtLauncher 7724 https://bugs.webkit.org/show_bug.cgi?id=37131 7725 7726 * QtLauncher/useragentlist.txt: 7727 77282010-04-06 Adam Barth <abarth@webkit.org> 7729 7730 Reviewed by Eric Seidel. 7731 7732 Explain how to handle rollout patches 7733 https://bugs.webkit.org/show_bug.cgi?id=37139 7734 7735 We need to set expectations for how long landing rollout patches with 7736 the commit-queue takes. The commit-queue is optimized for safety, not 7737 performance. Also, give folks an alternative way to land patches 7738 quickly. 7739 7740 In addition, improve our testing of add_patch_to_bug by having 7741 MockBugzilla log. This caused me to tighten a bunch of tests and 7742 notice that one of our tests wasn't being run. 7743 7744 * Scripts/webkitpy/tool/commands/download_unittest.py: 7745 * Scripts/webkitpy/tool/commands/upload_unittest.py: 7746 * Scripts/webkitpy/tool/mocktool.py: 7747 * Scripts/webkitpy/tool/steps/postdiffforrevert.py: 7748 77492010-04-06 Adam Barth <abarth@webkit.org> 7750 7751 Reviewed by Eric Seidel. 7752 7753 Turns out commit_info.committer() can be None 7754 https://bugs.webkit.org/show_bug.cgi?id=37106 7755 7756 When the committer isn't in committers.py, the committer() property on 7757 commit_info can be None. We need to handle that case gracefully. 7758 7759 * Scripts/webkitpy/common/checkout/commitinfo.py: 7760 * Scripts/webkitpy/tool/bot/sheriff.py: 7761 * Scripts/webkitpy/tool/bot/sheriff_unittest.py: 7762 * Scripts/webkitpy/tool/commands/queries.py: 7763 77642010-04-06 Laszlo Gombos <laszlo.1.gombos@nokia.com> 7765 7766 Reviewed by Kenneth Rohde Christiansen. 7767 7768 [Qt] [Symbian] Build fix for Dumprendertree if Qt printing is not supported 7769 https://bugs.webkit.org/show_bug.cgi?id=37082 7770 7771 Use the QT_NO_PRINTER guard to flag QPrinter dependent code. 7772 7773 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 7774 (WebCore::DumpRenderTree::dryRunPrint): 7775 77762010-04-05 Adam Barth <abarth@webkit.org> 7777 7778 Reviewed by Eric Seidel. 7779 7780 SheriffBot should force_build builders that are idle and have failed exactly once 7781 https://bugs.webkit.org/show_bug.cgi?id=37059 7782 7783 We can get into a deadlocked state where the commit-queue is stopped 7784 because the builders are red but the SheriffBot hasn't taken action 7785 because the builder has failed only once. The SheriffBot should force 7786 build idle builders that have failed exactly once to either turn the 7787 tree green again (if the test was flaky) or trigger the "failed twice" 7788 remedies (IRC and bug posts). 7789 7790 * Scripts/webkitpy/common/net/buildbot.py: 7791 * Scripts/webkitpy/tool/bot/sheriff.py: 7792 * Scripts/webkitpy/tool/bot/sheriff_unittest.py: 7793 * Scripts/webkitpy/tool/commands/sheriffbot.py: 7794 * Scripts/webkitpy/tool/mocktool.py: 7795 77962010-04-05 Chris Jerdonek <cjerdonek@webkit.org> 7797 7798 Reviewed by Shinichiro Hamaji. 7799 7800 Fixed check-webkit-style issue where the script was prematurely 7801 exiting when encountering deleted files in patches. 7802 7803 https://bugs.webkit.org/show_bug.cgi?id=37122 7804 7805 * Scripts/webkitpy/style/checker.py: 7806 - Changed non-existent file message from ERROR to WARN. 7807 - StyleChecker.check_file() no longer raises an exception when 7808 a file is not found. 7809 7810 * Scripts/webkitpy/style/checker_unittest.py: 7811 - Updated unit tests as necessary. 7812 78132010-04-05 Adam Barth <abarth@webkit.org> 7814 7815 Reviewed by Eric Seidel. 7816 7817 SheriffBot should include blamelist when posting to bugs 7818 https://bugs.webkit.org/show_bug.cgi?id=37113 7819 7820 When posting on bugs, we should include the full list of SVN revisions 7821 that caused the regression to folks have a better sense of whether they 7822 are to blame. 7823 7824 * Scripts/webkitpy/tool/bot/sheriff.py: 7825 * Scripts/webkitpy/tool/bot/sheriff_unittest.py: 7826 * Scripts/webkitpy/tool/commands/sheriffbot.py: 7827 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 7828 * Scripts/webkitpy/tool/commands/upload_unittest.py: 7829 * Scripts/webkitpy/tool/mocktool.py: 7830 78312010-04-05 Chris Jerdonek <cjerdonek@webkit.org> 7832 7833 Unreviewed after discussion with Adam, Darin, and Eric. 7834 7835 Deleted the auto-install directory since it is no longer needed in 7836 source control (it is auto-generated). 7837 7838 Also added webkitpy/thirdparty/autoinstalled to webkitpy/thirdparty's 7839 svn:ignore property. 7840 7841 * Scripts/webkitpy/thirdparty/autoinstalled: Removed. 7842 78432010-04-05 Mark Rowe <mrowe@apple.com> 7844 7845 Reviewed by Adele Peterson. 7846 7847 Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>. 7848 REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI 7849 7850 Add a JavaScript hook in DRT to call through to WebView's -setEditable:. This is required in order to reproduce 7851 the crash. 7852 7853 * DumpRenderTree/LayoutTestController.cpp: 7854 (setWebViewEditableCallback): 7855 (LayoutTestController::staticFunctions): 7856 * DumpRenderTree/LayoutTestController.h: 7857 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 7858 (LayoutTestController::setWebViewEditable): 7859 * DumpRenderTree/mac/DumpRenderTree.mm: 7860 (resetWebViewToConsistentStateBeforeTesting): 7861 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 7862 (LayoutTestController::setWebViewEditable): 7863 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 7864 (LayoutTestController::setWebViewEditable): 7865 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 7866 (LayoutTestController::setWebViewEditable): 7867 (LayoutTestController::layerTreeAsText): 7868 78692010-04-05 Darin Adler <darin@apple.com> 7870 7871 Ignore more files the Python tools strew about the working directory. 7872 7873 * Scripts/webkitpy: Added property svn:ignore. 7874 * Scripts/webkitpy/common: Added property svn:ignore. 7875 * Scripts/webkitpy/common/checkout: Added property svn:ignore. 7876 * Scripts/webkitpy/common/config: Added property svn:ignore. 7877 * Scripts/webkitpy/common/net: Added property svn:ignore. 7878 * Scripts/webkitpy/common/thread: Added property svn:ignore. 7879 * Scripts/webkitpy/python24: Added property svn:ignore. 7880 * Scripts/webkitpy/thirdparty/autoinstalled: Modified property svn:ignore. 7881 * Scripts/webkitpy/tool/bot: Added property svn:ignore. 7882 78832010-04-05 Adam Barth <abarth@webkit.org> 7884 7885 Unreviewed. Add Vitaly Repeshko as a committer. 7886 7887 * Scripts/webkitpy/common/config/committers.py: 7888 78892010-04-05 Adam Barth <abarth@webkit.org> 7890 7891 Unreviewed. Update kenne's IRC nick to his registered nick. 7892 7893 * Scripts/webkitpy/common/config/committers.py: 7894 78952010-04-05 Ojan Vafai <ojan@chromium.org> 7896 7897 Reviewed by Eric Seidel. 7898 7899 assorted helper functions and cleanup of git utilities 7900 https://bugs.webkit.org/show_bug.cgi?id=37103 7901 7902 * Scripts/webkitpy/common/checkout/scm.py: 7903 No code currently uses the optional dry_run argument. So removing it. 7904 Change all uses of "trunk" to read the correct value out of the git config. 7905 Made the dcommit call actually get called when dry_run==true. 7906 * Scripts/webkitpy/common/checkout/scm_unittest.py: 7907 * Scripts/webkitpy/common/net/credentials.py: 7908 Move the git config call into scm. 7909 * Scripts/webkitpy/common/net/credentials_unittest.py: 7910 * Scripts/webkitpy/common/system/executive.py: 7911 If return_exit_code==true, don't error out, just return the exit_code. 7912 79132010-04-05 Ojan Vafai <ojan@chromium.org> 7914 7915 Reviewed by Eric Seidel. 7916 7917 prepare-ChangeLog should take a merge-base for which git branch to diff against. 7918 https://bugs.webkit.org/show_bug.cgi?id=36394 7919 7920 * Scripts/prepare-ChangeLog: 7921 79222010-04-05 Chris Jerdonek <cjerdonek@webkit.org> 7923 7924 Reviewed by Shinichiro Hamaji. 7925 7926 Removed the PatchStyleErrorHandler class and incorporated its 7927 functionality into the DefaultStyleErrorHandler class. 7928 7929 https://bugs.webkit.org/show_bug.cgi?id=37067 7930 7931 * Scripts/webkitpy/style/checker.py: 7932 - In the StyleChecker class: 7933 - Added a line_number parameter to the check_file() method. 7934 - Renamed the handle_style_error parameter to 7935 mock_handle_style_error to be consistent with the other mock_* 7936 parameter names. 7937 - Added a mock_check_file parameter to the check_patch() method 7938 to facilitate unit testing the changes in this patch. 7939 - Rewrote the check_patch() method with the patch-parsing logic 7940 taken from the PatchStyleErrorHandler class. 7941 7942 * Scripts/webkitpy/style/checker_unittest.py: 7943 - Added a StyleCheckerCheckFileBase class and sub-classed the 7944 existing StyleCheckerCheckFileTest class from it. 7945 - Added a StyleCheckerCheckPatchTest class to unit-test the 7946 rewritten check_patch() method. 7947 - Removed the vestigial __main__ code at the bottom of the file. 7948 This is left over from when check-webkit-style was implemented 7949 as a module and a wrapper module. 7950 7951 * Scripts/webkitpy/style/error_handlers.py: 7952 - Added an optional line_numbers parameter to the 7953 DefaultStyleErrorHandler class constructor and adjusted the 7954 __call__() method as necessary. 7955 - Removed the PatchStyleErrorHandler class. 7956 7957 * Scripts/webkitpy/style/error_handlers_unittest.py: 7958 - Removed the PatchStyleErrorHandlerTest class which unit-tested 7959 the PatchStyleErrorHandler class which is being removed in this 7960 patch. 7961 - Added a test_line_numbers() test method to the 7962 DefaultStyleErrorHandlerTest class to test use of the 7963 DefaultStyleErrorHandler's new line_numbers attribute. 7964 79652010-04-05 Adam Barth <abarth@webkit.org> 7966 7967 Unreviewed. 7968 7969 Tighten SheriffBot's flaky test detector 7970 https://bugs.webkit.org/show_bug.cgi?id=37063 7971 7972 Instead of just looking for two sequential red builds, look for two 7973 sequential failures of the same test. This should reduce sheriffbot 7974 false positive substantially. 7975 7976 I'm landing this change unreviewed because I've noticed SheriffBot 7977 triggering a lot more false positives now that we've expanded the set 7978 of core builders. I've tried to take Eric's comments on Bug 37063 into 7979 account. I'm happy to iterate on this patch tomorrow once Eric wakes 7980 up. 7981 7982 * Scripts/webkitpy/common/net/buildbot.py: 7983 * Scripts/webkitpy/common/net/buildbot_unittest.py: 7984 * Scripts/webkitpy/tool/commands/queries.py: 7985 79862010-04-04 John Gregg <johnnyg@google.com> 7987 7988 Unreviewed, add myself to the committers list. 7989 7990 * Scripts/webkitpy/common/config/committers.py: 7991 79922010-04-04 Robert Hogan <robert@webkit.org> 7993 7994 Unreviewed, add myself to the committers list. 7995 7996 * Scripts/webkitpy/common/config/committers.py: 7997 79982010-04-04 Dumitru Daniliuc <dumi@chromium.org> 7999 8000 Unreviewed, adding my IRC nickname to committers.py 8001 8002 * Scripts/webkitpy/common/config/committers.py: 8003 80042010-04-04 Chris Jerdonek <cjerdonek@webkit.org> 8005 8006 Reviewed by Shinichiro Hamaji. 8007 8008 Refactored check-webkit-style's option-parsing code. 8009 8010 https://bugs.webkit.org/show_bug.cgi?id=37064 8011 8012 * Scripts/check-webkit-style: 8013 - Moved the "WebKit checkout not found" check from 8014 ArgumentParser.parse() to the calling code. 8015 - Moved the --git-commit argument validation from the calling 8016 code to ArgumentParser.parse(). 8017 8018 * Scripts/webkitpy/style/checker_unittest.py: 8019 - Updated a unit test as necessary. 8020 8021 * Scripts/webkitpy/style/optparser.py: 8022 - Renamed ArgumentParser._exit_with_help() to _parse_error() 8023 and made its error_message parameter required. 8024 - Removed the found_checkout parameter from ArgumentParser.parse(). 8025 - Removed the "WebKit checkout not found" check and moved it 8026 to the calling code. 8027 - Added --git-commit argument checking. 8028 8029 * Scripts/webkitpy/style/optparser_unittest.py: 8030 - Adjusted the import statements to be fully qualified. 8031 - Changed the ArgumentParserTest class to inherit from 8032 LoggingTestCase, and updated the class as necessary. 8033 - Added a unit-test for the --git-commit validation. 8034 - Added unit tests for the --git-diff and --git-since variants 8035 of --git-commit. 8036 80372010-04-03 Chris Jerdonek <cjerdonek@webkit.org> 8038 8039 Reviewed by Shinichiro Hamaji. 8040 8041 The check-webkit-style script now logs an ERROR and exits when 8042 encountering a file path that does not exist. Previously, it failed 8043 silently on such paths. 8044 8045 https://bugs.webkit.org/show_bug.cgi?id=36957 8046 8047 * Scripts/webkitpy/common/system/logtesting.py: 8048 - Added a FIXME to rename the LoggingTestCase class to 8049 LoggingTestCaseBase. 8050 8051 * Scripts/webkitpy/style/checker.py: 8052 - In the StyleChecker.check_file() method: 8053 - Added a mock_os_path_exists parameter. 8054 - Renamed the process_file parameter to mock_process_file. 8055 - Added logic to log an error and exist if the given path does 8056 not exist. 8057 8058 * Scripts/webkitpy/style/checker_unittest.py: 8059 - Refactored the StyleCheckerCheckFileTest class slightly to 8060 inherit from LoggingTestCase. 8061 - Added a test method to unit-test the case of a file that 8062 does not exist. 8063 - Adjusted the other test methods as necessary. 8064 80652010-04-03 Adam Barth <abarth@webkit.org> 8066 8067 Reviewed by Eric Seidel. 8068 8069 Add Tiger Bot to the list of "core builders" (builders which block the commit-queue when red) 8070 https://bugs.webkit.org/show_bug.cgi?id=33289 8071 8072 Add Tiger and SnowLeopard Tests to the core builders. This is a bit of 8073 an experiment now that the bots are green. Hopefully we can keep them 8074 on the list and have the tree stay greener. 8075 8076 * Scripts/webkitpy/common/net/buildbot.py: 8077 80782010-04-02 Adam Barth <abarth@webkit.org> 8079 8080 Unreviewed. 8081 8082 Have Eric and Adam watch the SheriffBot 8083 https://bugs.webkit.org/show_bug.cgi?id=37054 8084 8085 * Scripts/webkitpy/tool/bot/sheriff.py: 8086 * Scripts/webkitpy/tool/bot/sheriff_unittest.py: 8087 * Scripts/webkitpy/tool/commands/sheriffbot.py: 8088 80892010-04-02 Adam Barth <abarth@webkit.org> 8090 8091 Reviewed by Darin Adler. 8092 8093 commit-queue should ignore builders when landing rollouts 8094 https://bugs.webkit.org/show_bug.cgi?id=37051 8095 8096 When we moved the "builders are red" check into the master process, we 8097 forgot about rollouts. I thought we had a test covering this case, but 8098 looking at the test, it was a bit too loose. I added a new test and 8099 introduced some new logging technology into MockTool to make the test 8100 tighter. 8101 8102 * Scripts/webkitpy/tool/commands/queues.py: 8103 * Scripts/webkitpy/tool/commands/queues_unittest.py: 8104 * Scripts/webkitpy/tool/mocktool.py: 8105 81062010-04-02 David Levin <levin@chromium.org> 8107 8108 Reviewed by Adam Barth. 8109 8110 sherrifbot should ensure that the rollout reason doesn't start with - (and fix webkit-patch upload). 8111 https://bugs.webkit.org/show_bug.cgi?id=37030 8112 8113 * Scripts/webkitpy/tool/bot/sheriff.py: Ensure that the rollout reason doesn't 8114 start with -. 8115 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: A test with a rollout 8116 reason which starts with -. 8117 * Scripts/webkitpy/tool/steps/createbug.py: Fix webkit-patch upload. 8118 81192010-04-02 Chris Jerdonek <cjerdonek@webkit.org> 8120 8121 Unreviewed. 8122 8123 Fixed check-webkit-style to recognize the short form of the 8124 --verbose option, as stated in --help. 8125 8126 * Scripts/check-webkit-style: 8127 - Tweaked one line. 8128 81292010-04-02 Kevin Ollivier <kevino@theolliviers.com> 8130 8131 [wx] Build fix for DumpRenderTree after addition of layerTreeAsText. 8132 8133 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 8134 (LayoutTestController::layerTreeAsText): 8135 81362010-04-02 Laszlo Gombos <laszlo.1.gombos@nokia.com> 8137 8138 Reviewed by Eric Seidel. 8139 8140 Accept XHTML-MP content type as XHTML content 8141 https://bugs.webkit.org/show_bug.cgi?id=34262 8142 8143 Register xhtmlmp file extension as the new type 8144 for XHTML-MP test content. 8145 8146 * Scripts/run-webkit-tests: 8147 * Scripts/webkitpy/layout_tests/layout_package/test_files.py: 8148 * Scripts/webkitpy/layout_tests/port/lighttpd.conf: 8149 81502010-04-02 Adam Barth <abarth@webkit.org> 8151 8152 Reviewed by Eric Seidel. 8153 8154 create-rollout doesn't fill out ChangeLog 8155 https://bugs.webkit.org/show_bug.cgi?id=37010 8156 8157 The contract between apply_reverse_diff and PrepareChangeLogForRevert 8158 was unclear. I broke filling out the ChangeLog during rollout earlier 8159 when I changed apply_reverse_diff to revert the ChangeLogs because 8160 PrepareChangeLogForRevert thought that it was supposed to do that. 8161 I've now taught PrepareChangeLogsForRevert the new contract. 8162 8163 It's unclear to me how to test this change because it's essentially an 8164 integration issue that requires the file system. At some point we 8165 should think about a testing strategy for integration. As the system 8166 becomes larger, we're running into more of these issues. 8167 8168 * Scripts/webkitpy/common/checkout/api.py: 8169 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: 8170 81712010-04-02 Adam Barth <abarth@webkit.org> 8172 8173 Reviewed by Eric Seidel. 8174 8175 Add cr-win-ews to QueueStatusServer 8176 https://bugs.webkit.org/show_bug.cgi?id=37004 8177 8178 * QueueStatusServer/model/queues.py: 8179 * QueueStatusServer/templates/dashboard.html: 8180 * QueueStatusServer/templates/statusbubble.html: 8181 81822010-04-02 Chris Jerdonek <cjerdonek@webkit.org> 8183 8184 Reviewed by Adam Barth. 8185 8186 Unit-test networktransaction.py's log messages, and add a base 8187 class to make unit-testing log messages even easier. 8188 8189 https://bugs.webkit.org/show_bug.cgi?id=36958 8190 8191 The purpose of this patch is also to provide a mini-tutorial on 8192 how to unit-test Python logging.py messages. 8193 8194 * Scripts/webkitpy/common/net/networktransaction_unittest.py: 8195 - Unit-tested the log messages in test_retry(). 8196 8197 * Scripts/webkitpy/common/system/logtesting.py: 8198 - Adjusted the LogTesting class by moving the code that clears 8199 the array of log messages into a finally block. This prevents 8200 redundant AssertionErrors from getting rendered to the screen 8201 while running unit tests. 8202 - Added a LoggingTestCase class so the setUp() and tearDown() 8203 methods do not need to be implemented in order to test logging. 8204 Rather, TestCase classes can simply inherit from this class. 8205 82062010-04-02 Chris Jerdonek <cjerdonek@webkit.org> 8207 8208 Reviewed by Shinichiro Hamaji. 8209 8210 Re-wrote check-webkit-style's argument parsing code to use 8211 Python's optparser module and more uniform error-handling logic. 8212 8213 https://bugs.webkit.org/show_bug.cgi?id=34676 8214 8215 * Scripts/webkitpy/style/optparser.py: 8216 - Removed "option help" from check-webkit-style's usage string 8217 since that is provided separately by the OptionParser class. 8218 - Also changed the usage string from a function to a constant 8219 string _USAGE. 8220 - Added an _EPILOG string which renders after OptionParser's 8221 usage string and option help. 8222 - In the ArgumentParser class: 8223 - Changed the constructor's stderr_write parameter to a 8224 mock_stderr since the OptionParser accepts a sys.stderr 8225 substitute rather than a sys.stderr.write substitute. 8226 - Changed the constructor to set a _parser data attribute with 8227 an OptionParser instance. 8228 - Added a _create_option_parser() method which instantiates 8229 the OptionParser. 8230 - Updated _exit_with_help() to interact with the OptionParser's 8231 help method. 8232 - Updated the parse() method as necessary. Also changed the 8233 raising of ValueErrors to calls to _exit_with_help(). 8234 8235 * Scripts/webkitpy/style/optparser_unittest.py: 8236 - Removed the CreateUsageTest class since the create_usage method 8237 was replaced by a constant string. 8238 - Added a _MockStdErr class to the ArgumentParserTest class. 8239 - Updated the unit tests as necessary. 8240 8241 82422010-04-02 Adam Barth <abarth@webkit.org> 8243 8244 Reviewed by Eric Seidel. 8245 8246 The master commit-queue process should take responsibility for checking that the builders are green 8247 https://bugs.webkit.org/show_bug.cgi?id=37009 8248 8249 We had a failure where the child process noticed that the builders were 8250 red. We've always had this race condition, but the new optimistic 8251 design made it easier to trigger. 8252 8253 * Scripts/webkitpy/tool/commands/queues.py: 8254 82552010-04-02 Adam Barth <abarth@webkit.org> 8256 8257 Reviewed by Eric Seidel. 8258 8259 Tweak rollout changelog to pass ValidateReviewer check 8260 https://bugs.webkit.org/show_bug.cgi?id=37019 8261 8262 We need to use the magic word "unreviewed" to make the commit-queue 8263 happy when landing rollouts. 8264 8265 * Scripts/webkitpy/common/checkout/changelog.py: 8266 * Scripts/webkitpy/common/checkout/changelog_unittest.py: 8267 82682010-04-02 Chris Jerdonek <cjerdonek@webkit.org> 8269 8270 Unreviewed. 8271 8272 Removed duplicate ChangeLog entry. 8273 82742010-04-02 Chris Jerdonek <cjerdonek@webkit.org> 8275 8276 Rubber-stamped by Eric Seidel. 8277 8278 To the Python 2.4 error message, added a link to the wiki page 8279 that contains instructions on how to upgrade. 8280 8281 * Scripts/test-webkitpy: 8282 - Eliminated a use of the ternary operator in configure_logging() 8283 to let the version warning display in case of Python 2.4. 8284 8285 * Scripts/webkitpy/python24/versioning.py: 8286 - Added this link to the error text: 8287 http://trac.webkit.org/wiki/PythonGuidelines 8288 8289 * Scripts/webkitpy/python24/versioning_unittest.py: 8290 - Updated unit test text. 8291 82922010-04-02 Adam Barth <abarth@webkit.org> 8293 8294 Reviewed by Eric Seidel. 8295 8296 Record the IRC nick of folks who request rollouts 8297 https://bugs.webkit.org/show_bug.cgi?id=36999 8298 8299 * Scripts/webkitpy/common/net/irc/ircbot.py: 8300 * Scripts/webkitpy/tool/bot/irc_command.py: 8301 * Scripts/webkitpy/tool/bot/sheriffircbot.py: 8302 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: 8303 83042010-04-01 Adam Barth <abarth@webkit.org> 8305 8306 Reviewed by Eric Seidel. 8307 8308 Add cr-win-ews 8309 https://bugs.webkit.org/show_bug.cgi?id=36974 8310 8311 Adds support for an Early Warning System for Chromium on Linux. The 8312 interface to the Chromium port is the same on every platform, so we 8313 don't need to create a new Port object for this queue. 8314 8315 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 8316 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 8317 83182010-04-01 Adam Barth <abarth@webkit.org> 8319 8320 Reviewed by Eric Seidel. 8321 8322 Using a failure exit code when failing to load a required import 8323 https://bugs.webkit.org/show_bug.cgi?id=37000 8324 8325 Well spotted by Mark Rowe. 8326 8327 * Scripts/webkitpy/common/system/user.py: 8328 83292010-04-01 Chris Jerdonek <cjerdonek@webkit.org> 8330 8331 Reviewed by Eric Seidel. 8332 8333 Rewrote the revision (r56942) to disable the 79 character line 8334 length limit Python/PEP8 style check. 8335 8336 https://bugs.webkit.org/show_bug.cgi?id=33639#c39 8337 8338 This rewrite puts the disabling not in the PythonProcessor but 8339 in the calling code's default filter rule configuration. This 8340 allows the user to check line-length style from the command-line 8341 if desired. 8342 8343 * Scripts/webkitpy/style/checker.py: 8344 - Added "-pep8/E501" to the _BASE_FILTER_RULES configuration 8345 variable to disable the line-length check. 8346 - Added "-pep8/E501" to the list of recognized style categories 8347 to permit the category to be checked from the command line. 8348 8349 * Scripts/webkitpy/style/processors/python.py: 8350 - Reverted r56942: http://trac.webkit.org/changeset/56942 8351 83522010-04-01 Kinuko Yasuda <kinuko@chromium.org> 8353 8354 Reviewed by Dmitry Titov. 8355 8356 Add FileThread for async file operation support in FileReader and FileWriter 8357 https://bugs.webkit.org/show_bug.cgi?id=36896 8358 8359 Add options to enable FILE_READER and FILE_WRITER support. 8360 8361 * Scripts/build-webkit: 8362 83632010-04-01 Kent Tamura <tkent@chromium.org> 8364 8365 Unreviewed. Add missing license header. 8366 8367 * DumpRenderTree/chromium/TestShellMac.mm: 8368 83692010-04-01 Adam Barth <abarth@webkit.org> 8370 8371 Reviewed by Eric Seidel. 8372 8373 Improve the error handling in rollout a bit 8374 https://bugs.webkit.org/show_bug.cgi?id=36995 8375 8376 This patch does a few things to make the error handling in rollout a 8377 bit more robust. 8378 8379 * Scripts/webkitpy/common/checkout/api.py: 8380 The old logic here was wrong. We don't want to resolve the 8381 ChangeLogs (that would remove the old ChangeLog entry). Instead, 8382 we want to revert the ChangeLogs so we can fill them with the new 8383 message. 8384 * Scripts/webkitpy/tool/commands/download_unittest.py: 8385 Update test expectations because we're using a different mock object. 8386 * Scripts/webkitpy/tool/commands/download.py: 8387 - Added an update command to make updating from the SheriffBot more 8388 robust. 8389 - Now that we have CommitInfo, we can automatically CC the 8390 responsible parties on the bug we create. 8391 - Re-ordered the steps in create-rollout. Our original thinking 8392 was that we always wanted to create the bug, but that's not 8393 really true given how things appear to be playing out. If we 8394 fail to apply the reverse diff, we don't want to create the bug. 8395 * Scripts/webkitpy/tool/commands/sheriffbot.py: 8396 - Use the new, more robust update command. 8397 * Scripts/webkitpy/tool/steps/createbug.py: 8398 Allow commands to pre-load who they want to be CCed on a new bug. 8399 84002010-04-01 Kent Tamura <tkent@chromium.org> 8401 8402 Reviewed by Dimitri Glazkov. 8403 8404 [DRT/Chromium] Add TestShell and WebViewHost class, main(), and so on 8405 https://bugs.webkit.org/show_bug.cgi?id=36814 8406 8407 This change introduces: 8408 - WebViewHost class 8409 It's an implementation of some delegates required by Chromium 8410 WebKit API, and manages painting of a WebView. It's base on 8411 src/webkit/tools/test_shell/test_webview_delegate.{cc,h} of 8412 Chromium rev.40492. 8413 - TestShell class 8414 The TestShell instance holds global states of DumpRenderTree process. 8415 Unlike TestShell class of Chromium test_shell, TestShell instance is 8416 created just once. 8417 - DumpRenderTree.cpp 8418 The program entry. 8419 8420 * DumpRenderTree/chromium/DumpRenderTree.cpp: Added. 8421 * DumpRenderTree/chromium/TestShell.cpp: Added. 8422 * DumpRenderTree/chromium/TestShell.h: Added. 8423 * DumpRenderTree/chromium/TestShellMac.mm: Added. 8424 * DumpRenderTree/chromium/WebViewHost.cpp: Added. 8425 * DumpRenderTree/chromium/WebViewHost.h: Added. 8426 * DumpRenderTree/chromium/config.h: Added. 8427 84282010-04-01 David Levin <levin@chromium.org> 8429 8430 Reviewed by Adam Barth. 8431 8432 sheriffbot rollout should verify that the svn revision is a number. 8433 https://bugs.webkit.org/show_bug.cgi?id=37001 8434 8435 * Scripts/webkitpy/common/net/bugzilla.py: Allow for the message to be None. 8436 * Scripts/webkitpy/tool/bot/sheriff.py: Did verification that svn revision 8437 is a number. Fixed the imports (since the files uses ScriptError and log) 8438 and a typo. 8439 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added a test to verify 8440 the behavior. 8441 84422010-04-01 Adam Barth <abarth@webkit.org> 8443 8444 Reviewed by Eric Seidel. 8445 8446 Print an error message for readline bogosity in MacPorts 8447 https://bugs.webkit.org/show_bug.cgi?id=36979 8448 8449 * Scripts/webkitpy/common/system/user.py: 8450 84512010-04-01 Adam Barth <abarth@webkit.org> 8452 8453 Reviewed by Eric Seidel. 8454 8455 Don't pass --non-interactive to create-rollout 8456 https://bugs.webkit.org/show_bug.cgi?id=36989 8457 8458 It turns out you can't pass --non-interactive to create-rollout. Also, 8459 improve our error reporting slighly to catch the case where we error 8460 out after creating the rollout bug. 8461 8462 * Scripts/webkitpy/tool/bot/irc_command.py: 8463 * Scripts/webkitpy/tool/bot/sheriff.py: 8464 84652010-04-01 Ojan Vafai <ojan@chromium.org> 8466 8467 Reviewed by Eric Seidel. 8468 8469 webkit-patch can incorrectly think the working directory is modified 8470 https://bugs.webkit.org/show_bug.cgi?id=36985 8471 8472 If a file's modification time is modified, but the contents are not, 8473 then diff-index will think the file has been modified unless you do 8474 some crazy update-index call. Instead, call diff --name-only, which 8475 has the index update builtin. 8476 8477 Tried to write a test, but could not reproduce this in a unittest. 8478 To test manually: 8479 touch file-in-repo 8480 git diff-index HEAD 8481 git diff HEAD --name-only 8482 8483 The diff-index call incorrectly shows file-in-repo as modified. 8484 8485 * Scripts/webkitpy/common/checkout/scm.py: 8486 84872010-04-01 Adam Barth <abarth@webkit.org> 8488 8489 Reviewed by Eric Seidel. 8490 8491 Add rollout command to sheriffbot 8492 https://bugs.webkit.org/show_bug.cgi?id=36986 8493 8494 This IRC command creates a new bug an attaches a rollout patch. To 8495 actually commit the rollout, a committer needs to mark the patch 8496 commit-queue+ in bugs.webkit.org. 8497 8498 Also, factored out some of the logic from the queue into a separate 8499 object for easier testing. 8500 8501 * Scripts/webkitpy/common/system/executive.py: 8502 * Scripts/webkitpy/tool/bot/irc_command.py: 8503 * Scripts/webkitpy/tool/bot/sheriff.py: Added. 8504 * Scripts/webkitpy/tool/bot/sheriff_unittest.py: Added. 8505 * Scripts/webkitpy/tool/bot/sheriffircbot.py: 8506 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: 8507 * Scripts/webkitpy/tool/commands/queues.py: 8508 * Scripts/webkitpy/tool/commands/sheriffbot.py: 8509 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 8510 85112010-04-01 Eric Seidel <eric@webkit.org> 8512 8513 Unreviewed, only ignoring chatty style errors. 8514 8515 check-webkit-style: WebKit needs a python style checker 8516 https://bugs.webkit.org/show_bug.cgi?id=33639 8517 8518 Remove the 79 char line limit by ignoring 8519 pep8/E501. Because we have our own report_error 8520 implementation we have to ignore E501 by hand 8521 instead of passing --ignore=E501. 8522 8523 Right now over 1400 lines of our existing python 8524 fail E501 so this rule just generates needless noise. 8525 The rest of WebKit has no wrapping rule so it makes 8526 little sense for our Python to differ here. 8527 8528 * Scripts/webkitpy/style/processors/python.py: 8529 85302010-04-01 Adam Barth <abarth@webkit.org> 8531 8532 Unreviewed. Add cmarrin's IRC nickname. 8533 8534 * Scripts/webkitpy/common/config/committers.py: 8535 85362010-04-01 Adam Barth <abarth@webkit.org> 8537 8538 Unreviewed. 8539 8540 EWS spins hot when unable to build 8541 https://bugs.webkit.org/show_bug.cgi?id=36981 8542 8543 The problem is that the queue engine things we have more work to do, 8544 but the bot isn't actually able to do anything. After this change, we 8545 back off the usual amount. 8546 8547 * Scripts/webkitpy/tool/bot/queueengine.py: 8548 * Scripts/webkitpy/tool/bot/queueengine_unittest.py: 8549 * Scripts/webkitpy/tool/commands/queues.py: 8550 * Scripts/webkitpy/tool/commands/sheriffbot.py: 8551 85522010-04-01 Chris Marrin <cmarrin@apple.com> 8553 8554 Reviewed by Simon Fraser. 8555 8556 Added layerTreeAsText function to DRT (for Mac) 8557 https://bugs.webkit.org/show_bug.cgi?id=36782 8558 8559 This is the DRT side. It exposes the call to JavaScript 8560 through the LayoutTestController. 8561 8562 * DumpRenderTree/LayoutTestController.cpp:Platform independent JavaScript shim 8563 (layerTreeAsTextCallback): 8564 (LayoutTestController::staticFunctions): 8565 * DumpRenderTree/LayoutTestController.h: 8566 * DumpRenderTree/mac/LayoutTestControllerMac.mm:Mac specific plumbing to WebKit 8567 (LayoutTestController::layerTreeAsText): 8568 * DumpRenderTree/win/LayoutTestControllerWin.cpp:Windows specific plumbing to WebKit 8569 (LayoutTestController::layerTreeAsText): 8570 85712010-04-01 Kevin Ollivier <kevino@theolliviers.com> 8572 8573 [wx] Build fix after addition of JavaScriptCore/wtf/text directory. 8574 8575 * wx/build/settings.py: 8576 85772010-04-01 Jian Li <jianli@chromium.org> 8578 8579 Rubber-stamped by David Levin. 8580 8581 Add myself to the reviewers list. 8582 8583 * Scripts/webkitpy/common/config/committers.py: 8584 85852010-04-01 Adam Barth <abarth@webkit.org> 8586 8587 Unreviewed. 8588 8589 Turns out the Chromium Windows bots don't have pdevenv installed. 8590 8591 * Scripts/webkitdirs.pm: 8592 85932010-04-01 Adam Barth <abarth@webkit.org> 8594 8595 Reviewed by Dimitri Glazkov. 8596 8597 Let Chromium Windows build with Visual Studio Express 8598 https://bugs.webkit.org/show_bug.cgi?id=36919 8599 8600 This is horrible, horrible copy/paste code, but that seems to be the 8601 way of webkitdirs.pm. :( 8602 8603 Someone needs to go through an cleanup this code, but I don't have the 8604 heart to do it in this patch. 8605 8606 * Scripts/webkitdirs.pm: 8607 86082010-04-01 Ilya Tikhonovsky <loislo@chromium.org> 8609 8610 Reviewed by Yury Semikhatsky. 8611 8612 Add myself to the committers list. 8613 https://bugs.webkit.org/show_bug.cgi?id=36953 8614 8615 * Scripts/webkitpy/common/config/committers.py: 8616 86172010-04-01 Eric Seidel <eric@webkit.org> 8618 8619 Rubber-stamped by Adam Barth. 8620 8621 Add Snow Leopard Release bot to the list of "core builders" (builders which stop the commit-queue when they turn red) 8622 https://bugs.webkit.org/show_bug.cgi?id=33292 8623 8624 Just adding the "Build" builder for now. 8625 We'll add the "Test" builders when the tests 8626 are less flaky. 8627 8628 * Scripts/webkitpy/common/net/buildbot.py: 8629 * Scripts/webkitpy/common/net/buildbot_unittest.py: 8630 86312010-04-01 Yury Semikhatsky <yurys@chromium.org> 8632 8633 Reviewed by David Levin. 8634 8635 Add myself to the reviewers list. 8636 8637 https://bugs.webkit.org/show_bug.cgi?id=36935 8638 8639 * Scripts/webkitpy/common/config/committers.py: 8640 86412010-03-31 Chris Jerdonek <cjerdonek@webkit.org> 8642 8643 Reviewed by Dave Levin. 8644 8645 Added Python style checking to check-webkit-style using 8646 the third-party pep8 module (via autoinstall). 8647 8648 https://bugs.webkit.org/show_bug.cgi?id=33639 8649 8650 * Scripts/webkitpy/style/checker.py: 8651 - Added PYTHON to FileType. 8652 - Updated ProcessorDispatcher to return a PythonProcessor 8653 for *.py files. 8654 8655 * Scripts/webkitpy/style/checker_unittest.py: 8656 - Updated the ProcessorDispatcher unit tests for *.py files. 8657 8658 * Scripts/webkitpy/style/processors/python.py: Added. 8659 - Added PythonProcessor class. 8660 8661 * Scripts/webkitpy/style/processors/python_unittest.py: Added. 8662 - Added PythonProcessor unit tests. 8663 8664 * Scripts/webkitpy/style/processors/python_unittest_input.py: Added. 8665 - Added a sample Python file to test the PythonProcessor.process() 8666 code path (since pep8 accepts a file path). 8667 8668 * Scripts/webkitpy/style/unittests.py: 8669 - Updated the style unit test file to import python_unittest.py. 8670 8671 * Scripts/webkitpy/style_references.py: 8672 - Adjusted style references to import pep8. 8673 86742010-03-31 Chris Jerdonek <cjerdonek@webkit.org> 8675 8676 Reviewed by Dave Levin. 8677 8678 Rewrote autoinstall.py to support unzipping *.zip files after 8679 download, unzipping and extracting *.tar.gz files after download, 8680 and copying installed files to a given destination directory. 8681 8682 https://bugs.webkit.org/show_bug.cgi?id=35163 8683 8684 These changes will let us autoinstall pep8.py from the web and put 8685 our third-party autoinstalled code in an explicit directory like 8686 webkitpy/thirdparty/autoinstalled. These changes should also speed 8687 up the execution of autoinstalled *.zip packages slightly since 8688 *.pyc files cannot be generated when importing from zipped 8689 packages using the current autoinstall. 8690 8691 * Scripts/test-webkitpy: 8692 - Addressed the FIXME to enable auto-install logging once 8693 autoinstall was rewritten not to log as verbosely. 8694 8695 * Scripts/webkitpy/common/net/bugzilla.py: 8696 - Updated mechanize import statement. 8697 8698 * Scripts/webkitpy/common/net/buildbot.py: 8699 - Updated mechanize import statement. 8700 8701 * Scripts/webkitpy/common/net/irc/ircbot.py: 8702 - Updated ircbot and irclib import statements. 8703 8704 * Scripts/webkitpy/common/net/networktransaction.py: 8705 - Updated mechanize import statement. 8706 8707 * Scripts/webkitpy/common/net/networktransaction_unittest.py: 8708 - Updated mechanize import statement. 8709 8710 * Scripts/webkitpy/common/net/statusserver.py: 8711 - Updated mechanize import statement. 8712 8713 * Scripts/webkitpy/common/system/autoinstall.py: Added. 8714 - Added AutoInstaller class. 8715 - Added sample/testing usage to the __main__ block. 8716 8717 * Scripts/webkitpy/thirdparty/__init__.py: 8718 - Updated the autoinstall lines to use the new autoinstall methods. 8719 - Added pep8.py to the list of auto-installed packages. 8720 - Added a README file to the target autoinstallation directory 8721 so users know that the directory is safe to delete. 8722 8723 * Scripts/webkitpy/thirdparty/autoinstall.py: Removed. 8724 - This is replaced by the rewritten autoinstall 8725 webkitpy/common/system/autoinstall.py. 8726 8727 * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: Removed. 8728 - The target autoinstallation directory is now auto-generated. 8729 87302010-03-31 Chris Jerdonek <cjerdonek@webkit.org> 8731 8732 Reviewed by Shinichiro Hamaji. 8733 8734 Tweak webkitpy's logtesting.LogTesting class to get more mileage out 8735 of our unit tests that test log messages. 8736 8737 https://bugs.webkit.org/show_bug.cgi?id=36886 8738 8739 This patch adds to the LogTesting class's tearDown() method a line 8740 asserting that the array of remaining log messages is empty. This 8741 ensures that no extra log messages are getting logged that the caller 8742 might not be aware of or may have forgotten to check for. 8743 8744 * Scripts/webkitpy/common/system/logtesting.py: 8745 - Modified the tearDown() method as described above. 8746 - Also modified the assertMessages() method to clear the array 8747 of log messages after asserting. 8748 87492010-03-31 Chris Jerdonek <cjerdonek@webkit.org> 8750 8751 Reviewed by Adam Barth. 8752 8753 Added support for a --verbose-logging flag to test-webkitpy. 8754 8755 https://bugs.webkit.org/show_bug.cgi?id=36429 8756 8757 Verbose logging is useful for debugging test-webkitpy code that 8758 runs before the actual unit tests -- things like autoinstalling and 8759 unit-test auto-detection logic. This is different from verbose 8760 logging of the unit tests themselves (which corresponds to the 8761 unittest module's --verbose flag). 8762 8763 * Scripts/test-webkitpy: 8764 - In the configure_logging() method-- 8765 - Added an is_verbose_logging parameter that sets the logging 8766 level to logging.DEBUG instead of logging.INFO. 8767 - Changed the method to throttle the logging level on the 8768 root logger's handler instead of directly on the root logger 8769 itself. 8770 - Enabled logging of the autoinstall module when the flag is set. 8771 8772 * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: 8773 - Added a work-around for a bug in Python 2.6's logging module 8774 that was discovered while working on this patch. 8775 87762010-03-31 Chris Jerdonek <cjerdonek@webkit.org> 8777 8778 Reviewed by Adam Barth. 8779 8780 Enabled Python's logging module for webkit-patch, and replaced 8781 deprecated_logging with Python logging in networktransaction.py. 8782 This eliminates some spurious output when running test-webkitpy. 8783 8784 https://bugs.webkit.org/show_bug.cgi?id=36725 8785 8786 * Scripts/webkit-patch: 8787 - Replaced the configure_logging() function with a call to 8788 the new logutils.configure_logging() function. 8789 8790 * Scripts/webkitpy/common/net/networktransaction.py: 8791 - Replaced the use of deprecated_logging with Python logging. 8792 8793 * Scripts/webkitpy/common/system/logutils.py: 8794 - Added _default_handlers() which creates the default logging 8795 handler for webkitpy. 8796 - Added configure_logging() which configures default logging 8797 for webkitpy. 8798 8799 * Scripts/webkitpy/common/system/logutils_unittest.py: 8800 - Added unit tests for logutils.configure_logging(). 8801 8802 * Scripts/webkitpy/style/checker.py: 8803 - Refactored check-webkit-style's configure_logging() method 8804 to call the new logutils.configure_logging(). 8805 8806 * Scripts/webkitpy/style_references.py: 8807 - Updated references as necessary. 8808 88092010-03-31 Eric Seidel <eric@webkit.org> 8810 8811 Reviewed by Adam Barth. 8812 8813 webkit-patch land fails if not run from the root directory 8814 https://bugs.webkit.org/show_bug.cgi?id=35822 8815 8816 The root of the problem was that ChangeLog.__init__ expects a path 8817 relative to the current working directory, and SCM expects to 8818 return paths relative to the SCM root. Fix it by converting from 8819 SCM-relative to absolute paths in Checkout.modified_changelogs 8820 8821 * Scripts/webkitpy/common/checkout/api.py: 8822 * Scripts/webkitpy/common/checkout/api_unittest.py: 8823 88242010-03-31 Adam Barth <abarth@webkit.org> 8825 8826 Reviewed by Eric Seidel. 8827 8828 Add more tests for webkitpy.common.checkout 8829 https://bugs.webkit.org/show_bug.cgi?id=36926 8830 8831 We don't have a great way of testing checkout, sadly. 8832 8833 * Scripts/webkitpy/common/checkout/api_unittest.py: 8834 88352010-03-31 Adam Barth <abarth@webkit.org> 8836 8837 Reviewed by Eric Seidel. 8838 8839 REGRESSION: EWS crashes on failure 8840 https://bugs.webkit.org/show_bug.cgi?id=36924 8841 8842 Turns out we need to pass one more argument. My test is kind of lame, 8843 but at least it's there. 8844 8845 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 8846 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 8847 88482010-03-31 Chris Jerdonek <cjerdonek@webkit.org> 8849 8850 Unreviewed. 8851 8852 Fixed typo in WebKitTools/ChangeLog: opsys -> ospath. 8853 88542010-03-31 Adam Barth <abarth@webkit.org> 8855 8856 Reviewed by Eric Seidel. 8857 8858 Make the EWS go faster by being optimistic 8859 https://bugs.webkit.org/show_bug.cgi?id=36916 8860 8861 Have the EWS be optimistic that a patch will correctly build. This 8862 should speed up the common case by not requiring two builds for every 8863 patch. 8864 8865 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 8866 * Scripts/webkitpy/tool/commands/queues.py: 8867 88682010-03-31 Adam Barth <abarth@webkit.org> 8869 8870 Reviewed by Eric Seidel. 8871 8872 Add the ability to restart sheriffbot from IRC 8873 https://bugs.webkit.org/show_bug.cgi?id=36909 8874 8875 * Scripts/webkitpy/tool/bot/irc_command.py: 8876 * Scripts/webkitpy/tool/bot/queueengine.py: 8877 * Scripts/webkitpy/tool/bot/sheriffircbot.py: 8878 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: 8879 88802010-03-31 Adam Barth <abarth@webkit.org> 8881 8882 Reviewed by Eric Seidel. 8883 8884 Add win-ews to QueueStatusServer 8885 https://bugs.webkit.org/show_bug.cgi?id=36876 8886 8887 The win-ews is still experimental, but it seems to be more or less 8888 running. We should show its results to the people. 8889 8890 * QueueStatusServer/model/queues.py: 8891 * QueueStatusServer/templates/dashboard.html: 8892 * QueueStatusServer/templates/statusbubble.html: 8893 88942010-03-30 Victor Wang <victorw@chromium.org> 8895 8896 Reviewed by Eric Seidel. 8897 8898 Update rebaseline tool to check the release image diff binary and 8899 fallback to debug if the release version does not exist. 8900 8901 https://bugs.webkit.org/show_bug.cgi?id=36245 8902 8903 * Scripts/webkitpy/layout_tests/port/base.py: 8904 * Scripts/webkitpy/layout_tests/port/chromium.py: 8905 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 8906 89072010-03-31 Eric Seidel <eric@webkit.org> 8908 8909 Reviewed by Adam Barth. 8910 8911 Teach buildbot.py how to parse builder activity from /one_box_per_builder 8912 https://bugs.webkit.org/show_bug.cgi?id=36898 8913 8914 I also removed some obsolete FIXMEs and 8915 refactored one_box_per_builder parsing into multiple 8916 methods for easier reading. 8917 8918 * Scripts/webkitpy/common/net/buildbot.py: 8919 * Scripts/webkitpy/common/net/buildbot_unittest.py: 8920 89212010-03-31 Dirk Pranke <dpranke@chromium.org> 8922 8923 Reviewed by Eric Seidel. 8924 8925 Fix logging in new-run-webkit-tests so that we don't report IMAGE 8926 expected failures as unexpected passes when we run with pixel tests 8927 disabled. 8928 8929 This change splits some of the logic embedded into the TestExpectations 8930 classes out into separate pure functions (result_was_expected, 8931 remove_image_failures) to make them easier to test. This also adds 8932 a parameter to matches_an_expected_result() to indicate whether or 8933 not pixel test results should be included in the expectations. 8934 8935 https://bugs.webkit.org/show_bug.cgi?id=36771 8936 8937 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 8938 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: 8939 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 8940 89412010-03-31 Chris Jerdonek <cjerdonek@webkit.org> 8942 8943 Reviewed by Eric Seidel. 8944 8945 In webkitpy, refactored two calls to os.path.relpath() replacements 8946 to use a common method. 8947 8948 https://bugs.webkit.org/show_bug.cgi?id=36891 8949 8950 * Scripts/webkitpy/common/net/bugzilla.py: 8951 - Replaced the relpath implementation with a call to 8952 webkitpy.common.system.ospath.relpath(). 8953 8954 * Scripts/webkitpy/common/system/ospath.py: Added. 8955 - Moved the relpath() implementation from style/main.py. 8956 8957 * Scripts/webkitpy/common/system/ospath_unittest.py: Added. 8958 - Moved the relpath() unit tests from style/main_unittest.py. 8959 8960 * Scripts/webkitpy/style/main.py: 8961 - Replaced the relpath implementation with a call to 8962 webkitpy.common.system.ospath.relpath(). 8963 8964 * Scripts/webkitpy/style/main_unittest.py: 8965 - Moved the relpath unit tests to ospath_unittest.py. 8966 89672010-03-31 Adam Barth <abarth@webkit.org> 8968 8969 Reviewed by Eric Seidel. 8970 8971 Add a Builder.force_build method 8972 https://bugs.webkit.org/show_bug.cgi?id=36875 8973 8974 We plan to eventually use this in SheriffBot to break deadlocks created 8975 by flaky tests. 8976 8977 * Scripts/webkitpy/common/net/buildbot.py: 8978 89792010-03-31 Adam Barth <abarth@webkit.org> 8980 8981 Reviewed by Eric Seidel. 8982 8983 webkit-patch reads wrong bug url from unified diff context 8984 https://bugs.webkit.org/show_bug.cgi?id=36477 8985 8986 Instead of trying to figure out the bug_id from the diff, we should 8987 just get the information from the Checkout object, which understands 8988 these concepts. 8989 8990 * Scripts/webkitpy/common/checkout/api.py: 8991 * Scripts/webkitpy/common/checkout/commitinfo.py: 8992 * Scripts/webkitpy/tool/commands/download.py: 8993 * Scripts/webkitpy/tool/commands/upload.py: 8994 * Scripts/webkitpy/tool/mocktool.py: 8995 89962010-03-31 Adam Barth <abarth@webkit.org> 8997 8998 Reviewed by Eric Seidel. 8999 9000 webkit-patch commit-queue should land patches optimistically 9001 https://bugs.webkit.org/show_bug.cgi?id=34187 9002 9003 This patch adds an optimistic path to commit-queue and a "fail twice" 9004 requirement for rejecting patches. That means we'll land good patches 9005 faster (via the optmistic first run) and we'll reject many fewer 9006 patches due to flaky tests. 9007 9008 * Scripts/webkitpy/tool/commands/queues.py: 9009 90102010-03-31 Diego Gonzalez <diego.gonzalez@openbossa.org> 9011 9012 Reviewed by Kenneth Rohde Christiansen. 9013 9014 [Qt] Custom user agent for user agent switcher 9015 https://bugs.webkit.org/show_bug.cgi?id=36757 9016 9017 * QtLauncher/main.cpp: 9018 (LauncherWindow::showUserAgentDialog): 9019 90202010-03-31 Eric Seidel <eric@webkit.org> 9021 9022 Reviewed by Adam Barth. 9023 9024 path to committers.py in commit-queue rejection message is wrong 9025 https://bugs.webkit.org/show_bug.cgi?id=36865 9026 9027 This fix would have only been 3 lines long if we had 9028 1. Had access to an SCM object or tool to give us the checkout root 9029 2. Been able to depend on Python 2.6 9030 Instead I've added a bunch of hack code, but at least now 9031 we should never have to update this string again as the location 9032 of committers.py is fully dynamically discovered. :p 9033 9034 * Scripts/webkitpy/common/net/bugzilla.py: 9035 * Scripts/webkitpy/common/net/bugzilla_unittest.py: 9036 90372010-03-31 Shinichiro Hamaji <hamaji@chromium.org> 9038 9039 Unreviewed test fix for r56809. 9040 9041 webkit-patch what-broke throws exception 9042 https://bugs.webkit.org/show_bug.cgi?id=36852 9043 9044 * Scripts/webkitpy/common/checkout/api_unittest.py: 9045 90462010-03-30 Chris Jerdonek <cjerdonek@webkit.org> 9047 9048 Rubber stamped by Dave Levin. 9049 9050 Made check-webkit-style less chatty. 9051 9052 Examples include: 9053 - https://bugs.webkit.org/show_bug.cgi?id=36866#c4 9054 - https://bugs.webkit.org/show_bug.cgi?id=36472#c9 9055 9056 * Scripts/webkitpy/style/checker.py: 9057 - Changed unrecognized file type log message from info to debug. 9058 90592010-03-30 Kevin Ollivier <kevino@theolliviers.com> 9060 9061 [wx] Build fix after new method added. 9062 9063 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 9064 (LayoutTestController::callShouldCloseOnWebView): 9065 90662010-03-30 Eric Seidel <eric@webkit.org> 9067 9068 Reviewed by Adam Barth. 9069 9070 webkit-patch what-broke throws exception 9071 https://bugs.webkit.org/show_bug.cgi?id=36852 9072 9073 * Scripts/webkitpy/common/checkout/api.py: Add missing import StringIO. 9074 * Scripts/webkitpy/common/checkout/api_unittest.py: Test the function which previously threw and exception. 9075 90762010-03-30 Alexey Proskuryakov <ap@apple.com> 9077 9078 Reviewed by Darin Adler. 9079 9080 https://bugs.webkit.org/show_bug.cgi?id=36616 9081 Dvorak-Qwerty keyboard layout gives unexpected results in javascript keydown 9082 9083 https://bugs.webkit.org/show_bug.cgi?id=36797 9084 For non-Roman layouts, keydown Event.keyCode is always 0 9085 9086 * DumpRenderTree/mac/EventSendingController.mm: 9087 (-[EventSendingController keyDown:withModifiers:withLocation:]): Generate a correct keyCode 9088 for keys used in tests (we used to always pass 0 for 'A'). 9089 90902010-03-30 Adam Barth <abarth@webkit.org> 9091 9092 Reviewed by Eric Seidel. 9093 9094 Implement win-ews 9095 https://bugs.webkit.org/show_bug.cgi?id=36809 9096 9097 * Scripts/webkitpy/common/config/ports.py: 9098 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 9099 91002010-03-30 Chris Jerdonek <cjerdonek@webkit.org> 9101 9102 Reviewed by Eric Seidel. 9103 9104 Adjusted test-webkitpy to delete all orphaned *.pyc files 9105 from webkitpy/ prior to importing any modules from webkitpy. 9106 This ensures that no import statements in webkitpy falsely 9107 succeed because of leftover *.pyc files. 9108 9109 https://bugs.webkit.org/show_bug.cgi?id=36599 9110 9111 * Scripts/test-webkitpy: 9112 - Added _clean_pyc_files() to delete orphaned *.pyc files 9113 from a directory. 9114 - Added _clean_webkitpy_with_test() to call and test 9115 _clean_pyc_files(). 9116 - Moved the "import webkitpy.python24.versioning" statement 9117 from the top of the module to the init() method -- immediately 9118 after the call to _clean_webkitpy_with_test(). 9119 91202010-03-30 Fumitoshi Ukai <ukai@chromium.org> 9121 9122 Reviewed by Shinichiro Hamaji. 9123 9124 [Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r') 9125 https://bugs.webkit.org/show_bug.cgi?id=36811 9126 9127 subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle. 9128 We don't need stdin, so use devnull as stdin. 9129 Same as https://bugs.webkit.org/show_bug.cgi?id=36586 9130 9131 * Scripts/webkitpy/layout_tests/port/chromium_win.py: open os.devnull for stdin 9132 91332010-03-29 Eric Seidel <eric@webkit.org> 9134 9135 Unreviewed, build fix only. 9136 9137 * Scripts/webkitpy/tool/steps/validatereviewer.py: Add missing import. 9138 91392010-03-29 Hayato Ito <hayato@chromium.org> 9140 9141 Reviewed by Shinichiro Hamaji. 9142 9143 Remove '_flymake' suffix from base part of file name so that 9144 check-webkit-style uses a correct header guard name when it is called from Emacs's flymake. 9145 9146 https://bugs.webkit.org/show_bug.cgi?id=36573 9147 9148 * Scripts/webkitpy/style/processors/cpp.py: 9149 * Scripts/webkitpy/style/processors/cpp_unittest.py: 9150 91512010-03-29 Chris Jerdonek <cjerdonek@webkit.org> 9152 9153 Reviewed by Eric Seidel. 9154 9155 Get the following test-webkitpy unit test working again: 9156 scm_unittest.SVNTest.test_svn_apply(). 9157 9158 https://bugs.webkit.org/show_bug.cgi?id=36696 9159 9160 * Scripts/webkitpy/common/checkout/scm_unittest.py: 9161 - Add leading spaces to the empty lines of the ChangeLog strings. 9162 - Manually set the _reviewer attribute on the Attachment object 9163 to get the tests to pass. 9164 91652010-03-29 Martin Robinson <mrobinson@webkit.org> 9166 9167 Reviewed by Holger Freyther. 9168 9169 [GTK] suppress (un)desired launcher output that can make layout test to fail with stderr 9170 https://bugs.webkit.org/show_bug.cgi?id=36390 9171 9172 Suppress debugging messages sent to the GLib logger during DRT runs. 9173 9174 * DumpRenderTree/gtk/DumpRenderTree.cpp: 9175 (logHandler): Added. 9176 (main): Use logHandler as the default GLib log message handler. 9177 91782010-03-29 Eric Seidel <eric@webkit.org> 9179 9180 Reviewed by Adam Barth. 9181 9182 sheriff-bot should comment on bugs when builders break 9183 https://bugs.webkit.org/show_bug.cgi?id=36786 9184 9185 * Scripts/webkitpy/tool/commands/sheriffbot.py: 9186 - Add a new _post_blame_comment_to_bug and all it from process_work_item 9187 - Move commit-queue logic into _post_rollout_patch to make its api match the other _post commands. 9188 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 9189 - Test the new _post_blame_comment_to_bug call 9190 91912010-03-29 Eric Seidel <eric@webkit.org> 9192 9193 Reviewed by Adam Barth. 9194 9195 sheriff-bot fails to get information about certain builds 9196 https://bugs.webkit.org/show_bug.cgi?id=36768 9197 9198 This seems to be caused by: 9199 http://buildbot.net/trac/ticket/753 9200 I have no work-around, but for now at least we're logging 9201 the error better. I also added allow_none to our ServerProxy 9202 creation in case that fixes things for other versions of python. 9203 9204 * Scripts/webkitpy/common/net/buildbot.py: 9205 92062010-03-29 Victor Wang <victorw@chromium.org> 9207 9208 Reviewed by Adam Barth. 9209 9210 Add sign in/out link to TestResults appengine 9211 9212 Add a link to main menu for sign in/out to this appengine. 9213 People signed in with admin privilege could perform 9214 actions that are only allowed to admins like deleting files. 9215 9216 https://bugs.webkit.org/show_bug.cgi?id=36767 9217 9218 * TestResultServer/handlers/menu.py: 9219 * TestResultServer/stylesheets/menu.css: 9220 (.sign): 9221 * TestResultServer/templates/menu.html: 9222 92232010-03-29 Eric Seidel <eric@webkit.org> 9224 9225 Reviewed by Adam Barth. 9226 9227 ValidateReviewer step is draconian and un-tested 9228 https://bugs.webkit.org/show_bug.cgi?id=36792 9229 9230 ValidateReviewer logic was commented out in 9231 http://trac.webkit.org/changeset/56744 9232 That was a symptom of the fact that validatereviewer.py 9233 is too inflexible to be used when real humans are driving webkit-patch. 9234 For now we just disable ValidateReviewer when humans are at the keyboard. 9235 9236 * Scripts/webkitpy/tool/steps/validatereviewer.py: 9237 - Only run when in non-interactive mode. 9238 * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Added. 9239 - Test our validation logic to make sure it's sane. 9240 92412010-03-29 Chris Jerdonek <cjerdonek@webkit.org> 9242 9243 Reviewed by Shinichiro Hamaji. 9244 9245 Eliminate explicit slash characters from check-webkit-style's 9246 _rel_path() method to make its implementation more platform 9247 independent. 9248 9249 https://bugs.webkit.org/show_bug.cgi?id=36759 9250 9251 * Scripts/webkitpy/style/main.py: 9252 - Changed to use os.sep instead of slash_chars "/\\". This can 9253 be done since os.path.abspath() converts slashes to os.sep. 9254 92552010-03-29 Dirk Pranke <dpranke@chromium.org> 9256 9257 Reviewed by Dimitri Glazkov. 9258 9259 Change new-run-webkit-tests to not use more than four threads by 9260 default on the mac port until 9261 https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed. 9262 9263 https://bugs.webkit.org/show_bug.cgi?id=36687 9264 9265 * Scripts/webkitpy/layout_tests/port/mac.py: 9266 92672010-03-29 Dirk Pranke <dpranke@chromium.org> 9268 9269 Reviewed by Dimitri Glazkov. 9270 9271 Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance. 9272 9273 https://bugs.webkit.org/show_bug.cgi?id=36691 9274 9275 * Scripts/webkitpy/layout_tests/port/mac.py: 9276 92772010-03-29 Eric Seidel <eric@webkit.org> 9278 9279 Reviewed by Adam Barth. 9280 9281 new-run-webkit-tests fails java/lc3 on a clean checkout 9282 https://bugs.webkit.org/show_bug.cgi?id=36078 9283 9284 * Scripts/webkitpy/layout_tests/port/mac.py: 9285 - Build the java support files in check_build 9286 - Unwrap a line which would still fit under 80col 9287 92882010-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org> 9289 9290 Reviewed by Simon Fraser. 9291 9292 Add support for Widgets 1.0: View Mode Media Feature 9293 https://bugs.webkit.org/show_bug.cgi?id=35446 9294 9295 Add hooks to the Qt DRT for testing the view mode media feature. 9296 9297 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 9298 (LayoutTestController::setViewModeMediaFeature): 9299 * DumpRenderTree/qt/LayoutTestControllerQt.h: 9300 93012010-03-29 Adam Barth <abarth@webkit.org> 9302 9303 Unreviewed. Update expected results for unit tests. 9304 9305 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: 9306 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 9307 93082010-03-29 Adam Barth <abarth@webkit.org> 9309 9310 Unreviewed. I think Eric meant svn_revision. 9311 9312 * Scripts/webkitpy/tool/commands/sheriffbot.py: 9313 93142010-03-26 Eric Seidel <eric@webkit.org> 9315 9316 Reviewed by Adam Barth. 9317 9318 webkit-patch commit-queue should notice if it breaks builders (and roll out its own changes) 9319 https://bugs.webkit.org/show_bug.cgi?id=29311 9320 9321 Now that we have sheriff-bot watching the tree, it can post 9322 rollout patches on behalf of the commit queue. 9323 9324 * Scripts/webkitpy/common/checkout/commitinfo.py: add responsible_parties() 9325 * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: test responsible_parties() 9326 * Scripts/webkitpy/tool/commands/sheriffbot.py: 9327 - Break IRC logic out into _post_irc_warning for easier testing. 9328 - Add _post_rollout_patch for posting rollout patches to bugzilla. 9329 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 9330 - Test _rollout_reason 9331 * Scripts/webkitpy/tool/grammar.py: 9332 - Fix join_with_separators to not add Adam's "oxford comma" for two item lists. 9333 * Scripts/webkitpy/tool/grammar_unittest.py: 9334 - Test join_with_separators 9335 93362010-03-29 Adam Barth <abarth@webkit.org> 9337 9338 Reviewed by Eric Seidel. 9339 9340 Sheriffbot should actually run commands 9341 https://bugs.webkit.org/show_bug.cgi?id=36776 9342 9343 Some minor changes to Sheriffbot: 9344 9345 1) We should actually run commands (by giving control back to the 9346 command processing object. 9347 9348 2) Use URLs instead of just numbers to represent SVN revisions (making 9349 it easier to folks in IRC ot followup). 9350 9351 * Scripts/webkitpy/tool/bot/irc_command.py: 9352 * Scripts/webkitpy/tool/bot/queueengine.py: 9353 * Scripts/webkitpy/tool/commands/sheriffbot.py: 9354 93552010-03-26 Kenneth Rohde Christiansen <kenneth@webkit.org> 9356 9357 Reviewed by Antti Koivisto. 9358 9359 Renaming of frame flattening LayoutTestController method 9360 to setFrameFlatteningEnabled(bool) 9361 9362 * DumpRenderTree/LayoutTestController.cpp: 9363 (setFrameFlatteningEnabledCallback): 9364 (LayoutTestController::staticFunctions): 9365 * DumpRenderTree/LayoutTestController.h: 9366 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 9367 (LayoutTestController::setFrameFlatteningEnabled): 9368 * DumpRenderTree/mac/DumpRenderTree.mm: 9369 (resetDefaultsToConsistentValues): 9370 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 9371 (LayoutTestController::setFrameFlatteningEnabled): 9372 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 9373 (WebCore::WebPage::resetSettings): 9374 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 9375 (LayoutTestController::setFrameFlatteningEnabled): 9376 * DumpRenderTree/qt/LayoutTestControllerQt.h: 9377 * DumpRenderTree/win/DumpRenderTree.cpp: 9378 (resetDefaultsToConsistentValues): 9379 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 9380 (LayoutTestController::setFrameFlatteningEnabled): 9381 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 9382 (LayoutTestController::setFrameFlatteningEnabled): 9383 93842010-03-28 Gustavo Noronha Silva <gns@gnome.org> 9385 9386 No review, rolling out r56679. 9387 http://trac.webkit.org/changeset/56679 9388 https://bugs.webkit.org/show_bug.cgi?id=36454 9389 9390 Lots of tests broken. 9391 9392 * DumpRenderTree/gtk/DumpRenderTree.cpp: 9393 (createWebView): 9394 93952010-03-28 Chris Jerdonek <cjerdonek@webkit.org> 9396 9397 Unreviewed. 9398 9399 Fixed typo in deprecated_logging_unittest.py, which is masking 9400 sys.stderr while running test-webkitpy. 9401 9402 See also-- https://bugs.webkit.org/show_bug.cgi?id=36725#c3 9403 9404 * Scripts/webkitpy/common/system/deprecated_logging_unittest.py: 9405 94062010-03-28 Chris Jerdonek <cjerdonek@webkit.org> 9407 9408 Reviewed by Shinichiro Hamaji. 9409 9410 Renamed check-webkit-style's --debug flag to --verbose to be more 9411 in line with other WebKit scripts. Also renamed the current 9412 --verbose flag to --min-confidence to allow the --debug rename. 9413 9414 https://bugs.webkit.org/show_bug.cgi?id=36521 9415 9416 We also renamed the internal "verbose" variables to "confidence" or 9417 "min_confidence," as appropriate, to avoid confusion with the 9418 --verbose flag, and because the new names are more accurate. 9419 9420 * Scripts/check-webkit-style: 9421 - Renamed is_debug to is_verbose. 9422 9423 * Scripts/webkitpy/style/checker.py: 9424 - Renamed _DEFAULT_VERBOSITY to _DEFAULT_CONFIDENCE. 9425 - Renamed "verbosity" parameters to "min_confidence" throughout. 9426 - Renamed configure_logging()'s is_debug parameter to is_verbose. 9427 9428 * Scripts/webkitpy/style/checker_unittest.py: 9429 - Updated the unit tests as necessary. 9430 9431 * Scripts/webkitpy/style/error_handlers.py: 9432 - Updated the call to StyleCheckerConfiguration.write_style_error(). 9433 9434 * Scripts/webkitpy/style/error_handlers_unittest.py: 9435 - Updated the unit tests as necessary. 9436 9437 * Scripts/webkitpy/style/optparser.py: 9438 - Updated the usage string with the new flag names. 9439 - Renamed the verbosity parameter to min_confidence throughout. 9440 - Renamed the is_debug parameter to is_verbose throughout. 9441 9442 * Scripts/webkitpy/style/optparser_unittest.py: 9443 - Updated the unit tests as necessary. 9444 9445 * Scripts/webkitpy/style/processors/cpp.py: 9446 - Renamed the verbosity parameter to min_confidence throughout. 9447 9448 * Scripts/webkitpy/style/processors/cpp_unittest.py: 9449 - Updated the unit tests as necessary. 9450 94512010-03-28 Chris Jerdonek <cjerdonek@webkit.org> 9452 9453 Unreviewed. 9454 9455 Added back a line that accidentally got deleted in r56690. 9456 9457 * Scripts/check-webkit-style: 9458 94592010-03-28 Chris Jerdonek <cjerdonek@webkit.org> 9460 9461 Reviewed by Shinichiro Hamaji. 9462 9463 Add to check-webkit-style support for checking directories. 9464 9465 https://bugs.webkit.org/show_bug.cgi?id=35234 9466 9467 * Scripts/check-webkit-style: 9468 - Replaced the call to check_file() with a call to check_paths(). 9469 9470 * Scripts/webkitpy/style/checker.py: 9471 - In the StyleChecker class: 9472 - Added a check_paths() method that accepts a list of paths 9473 to files and directories. 9474 - Added a _check_directory() method that checks the files 9475 in a directory. 9476 9477 * Scripts/webkitpy/style/checker_unittest.py: 9478 - Added a StyleCheckerCheckPathsTest to unit-test the new 9479 check_paths() method. 9480 9481 * Scripts/webkitpy/style/optparser.py: 9482 - Updated the usage string. 9483 94842010-03-28 Chris Jerdonek <cjerdonek@webkit.org> 9485 9486 Reviewed by Shinichiro Hamaji. 9487 9488 Changed check-webkit-style to convert paths to paths relative to 9489 the checkout root when invoking check-webkit-style with path 9490 arguments. Also added warning messages where appropriate. 9491 9492 https://bugs.webkit.org/show_bug.cgi?id=35498 9493 9494 Converting paths to paths relative to the checkout root ensures 9495 that style checking will behave as expected (since path-specific 9496 rules assume input paths are relative to a source root). 9497 9498 * Scripts/check-webkit-style: 9499 - Added debug logging of whether the current directory was found 9500 to be in a WebKit checkout. 9501 - Added the found_checkout parameter to the call to parser.parse(). 9502 - Renamed the files variable to paths. 9503 - Added a call to change_directory() prior to checking style. 9504 9505 * Scripts/webkitpy/style/checker.py: 9506 - For StyleChecker.check_file(): 9507 - Updated the docstring. 9508 - Added two log messages. 9509 9510 * Scripts/webkitpy/style/checker_unittest.py: 9511 - Updated a call to parser.parse() with the found_checkout parameter. 9512 9513 * Scripts/webkitpy/style/main.py: Added. 9514 - Added a new file so the code in this patch could be unit-tested, 9515 as opposed to adding new code to check-webkit-style. 9516 - Added the method _rel_path() as a substitute for os.path.relpath(), 9517 which is available only in Python 2.6. 9518 - Added the method change_directory(), which contains most of the 9519 new functionality in this patch. 9520 9521 * Scripts/webkitpy/style/main_unittest.py: Added. 9522 - Added RelPathTest to test main._rel_path(). 9523 - Added ChangeDirectoryTest to test main.change_directory(). 9524 9525 * Scripts/webkitpy/style/optparser.py: 9526 - Updated check-webkit-style's usage string. 9527 - For the ArgumentParser.parse() method: 9528 - Added a found_checkout parameter. 9529 - Renamed filenames to paths. 9530 - Added logic so that an error is raised if no paths are passed 9531 if found_checkout is False. 9532 9533 * Scripts/webkitpy/style/optparser_unittest.py: 9534 - Updated the ArgumentParser.parse() unit tests to include 9535 coverage for the new found_checkout parameter. 9536 9537 * Scripts/webkitpy/style/unittests.py: 9538 - Added an import statement for main_unittest. 9539 9540 * Scripts/webkitpy/style_references.py: 9541 - Renamed SimpleScm to WebKitCheckout. 9542 - Added a detect_checkout() function to allow returning None 9543 instead of a WebKitCheckout instance if no checkout is found. 9544 - Renamed checkout_root to root_path. 9545 95462010-03-27 Sergio Villar Senin <svillar@igalia.com> 9547 9548 Reviewed by Eric Seidel. 9549 9550 Print didHandleOnloadEventsForFrame in the callback of 9551 onload-event signal comming from frame loader 9552 9553 [GTK] Improve reporting of frame loader callbacks in DRT 9554 https://bugs.webkit.org/show_bug.cgi?id=36454 9555 9556 * DumpRenderTree/gtk/DumpRenderTree.cpp: 9557 (webViewOnloadEvent): 9558 (createWebView): added connection to signal::onload-event and 9559 signal callback 9560 95612010-03-27 Sergio Villar Senin <svillar@igalia.com> 9562 9563 Reviewed by Eric Seidel. 9564 9565 Print didCommitLoadForFrame in the callback of signal::load-committed 9566 9567 [GTK] Improve reporting of frame loader callbacks in DRT 9568 https://bugs.webkit.org/show_bug.cgi?id=36454 9569 9570 * DumpRenderTree/gtk/DumpRenderTree.cpp: 9571 (webViewLoadCommitted): 9572 (createWebView): added connection to sinal::load-committed and 9573 signal callback 9574 95752010-03-27 Sergio Villar Senin <svillar@igalia.com> 9576 9577 Reviewed by Eric Seidel. 9578 9579 Print didStartProvisionalLoadForFrame in the callback of 9580 notify::load-status property change notification 9581 9582 [GTK] Improve reporting of frame loader callbacks in DRT 9583 https://bugs.webkit.org/show_bug.cgi?id=36454 9584 9585 * DumpRenderTree/gtk/DumpRenderTree.cpp: 9586 (webInspectorCloseWindow): 9587 (webInspectorInspectWebView): 9588 (createWebView): added connection to notify::load-status and 9589 signal callback 9590 95912010-03-27 Chris Jerdonek <cjerdonek@webkit.org> 9592 9593 Reviewed by Adam Barth. 9594 9595 In webkitpy/, deleted the /unittests.py files since test-webkitpy 9596 now auto-detects all *_unittest.py files. 9597 9598 https://bugs.webkit.org/show_bug.cgi?id=36712 9599 9600 * Scripts/webkitpy/common/net/irc/unittests.py: Removed. 9601 * Scripts/webkitpy/common/system/unittests.py: Removed. 9602 * Scripts/webkitpy/common/thread/unittests.py: Removed. 9603 * Scripts/webkitpy/common/unittests.py: Removed. 9604 * Scripts/webkitpy/python24/unittests.py: Removed. 9605 * Scripts/webkitpy/style/unittests.py: Removed. 9606 * Scripts/webkitpy/tool/unittests.py: Removed. 9607 * Scripts/webkitpy/unittests.py: Removed. 9608 96092010-03-27 Sergio Villar Senin <svillar@igalia.com> 9610 9611 Reviewed by Eric Seidel. 9612 9613 Add a CR after printing didFinishDocumentLoadForFrame 9614 9615 [GTK] Improve reporting of frame loader callbacks in DRT 9616 https://bugs.webkit.org/show_bug.cgi?id=36454 9617 9618 * DumpRenderTree/gtk/DumpRenderTree.cpp: 9619 (webViewLoadFinished): 9620 96212010-03-27 Chris Jerdonek <cjerdonek@webkit.org> 9622 9623 Rubber-stamped by Adam Barth. 9624 9625 Fixed the name of a unit test file in webkitpy. 9626 9627 * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py. 9628 * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: Removed. 9629 96302010-03-26 Chris Jerdonek <cjerdonek@webkit.org> 9631 9632 Reviewed by Adam Barth. 9633 9634 The test-webkitpy script now automatically detects all unit-test 9635 files in webkitpy/. This lets us eliminate the need to have and 9636 maintain all of the unittests.py files. 9637 9638 https://bugs.webkit.org/show_bug.cgi?id=36591 9639 9640 * Scripts/test-webkitpy: 9641 - Replaced the "from webkitpy.unittests import *" with a call 9642 to webkitpy.test.main.Tester().run_tests(). 9643 9644 * Scripts/webkitpy/test/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. 9645 - Required file for the new webkitpy/test/ directory. 9646 9647 * Scripts/webkitpy/test/main.py: Added. 9648 - Added a Tester class that contains the following methods: 9649 - _find_unittest_files() to detect all the unit-test files. 9650 - _modules_from_paths() to convert the paths to the unit-test 9651 files to fully-qualified module names. 9652 - run_tests() which calls the above two methods and then passes 9653 the module names to Python's unittest module. 9654 96552010-03-27 Robert Hogan <robert@webkit.org> 9656 9657 Reviewed by Simon Fraser. 9658 9659 [Qt/Win] Add support to unix and windows NS plugin for executing scripts on setWindow. 9660 9661 https://bugs.webkit.org/show_bug.cgi?id=36701 9662 9663 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 9664 (webkit_test_plugin_new_instance): Add onSetWindow. 9665 (webkit_test_plugin_destroy_instance): Add onSetWindow. 9666 (webkit_test_plugin_set_window): Add onSetWindow. 9667 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 9668 (NPP_New): Add onSetWindow. 9669 (NPP_Destroy): Add onSetWindow. 9670 (NPP_SetWindow): Add onSetWindow. 9671 96722010-03-26 Robert Hogan <robert@roberthogan.net> 9673 9674 Reviewed by Simon Hausmann. 9675 9676 Allow plugins implemented by the application, such as mimetype 'x-qt-plugin', 9677 when pluginsEnabled is false. 9678 9679 Add support for LayoutTestController.WebKitPluginsEnabled 9680 9681 https://bugs.webkit.org/show_bug.cgi?id=32196 9682 9683 * DumpRenderTree/gtk/DumpRenderTree.cpp: 9684 (resetDefaultsToConsistentValues): 9685 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 9686 (copyWebSettingKey): 9687 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 9688 (WebCore::WebPage::resetSettings): 9689 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 9690 (LayoutTestController::overridePreference): 9691 96922010-03-26 Adam Barth <abarth@webkit.org> 9693 9694 Reviewed by Eric Seidel. 9695 9696 Add some basic IRC commands to sheriffbot 9697 https://bugs.webkit.org/show_bug.cgi?id=36684 9698 9699 Adds support for sheriffbot to respond to a "hi" command and a 9700 "last-green-revision" command. It's lame that we're rebuilding 9701 MultiCommandTool, but as discussed in person we'll intergrate the two 9702 once we see what the requirements are. 9703 9704 * Scripts/webkitpy/tool/bot/irc_command.py: Added. 9705 * Scripts/webkitpy/tool/bot/queueengine.py: 9706 * Scripts/webkitpy/tool/bot/queueengine_unittest.py: 9707 * Scripts/webkitpy/tool/bot/sheriffircbot.py: 9708 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added. 9709 * Scripts/webkitpy/tool/commands/queues.py: 9710 * Scripts/webkitpy/tool/commands/queuestest.py: 9711 * Scripts/webkitpy/tool/commands/sheriffbot.py: 9712 * Scripts/webkitpy/tool/main.py: 9713 * Scripts/webkitpy/tool/mocktool.py: 9714 * Scripts/webkitpy/tool/unittests.py: 9715 97162010-03-26 Adam Barth <abarth@webkit.org> 9717 9718 Unreviewed. More errors in the IRC module. I have no idea how to test 9719 ircbot.py, which is too bad. Hopefully we've abstracted it away enough 9720 that we don't have to touch it very much after this patch. 9721 9722 * Scripts/webkitpy/common/net/irc/ircbot.py: 9723 97242010-03-26 Adam Barth <abarth@webkit.org> 9725 9726 Unreviewed. Add a missing "_". 9727 9728 * Scripts/webkitpy/common/net/irc/ircproxy.py: 9729 * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py: Added. 9730 * Scripts/webkitpy/common/net/irc/unittests.py: 9731 97322010-03-26 Adam Barth <abarth@webkit.org> 9733 9734 Unreviewed. Fix a the commit queue after my recent change. 9735 9736 * Scripts/webkitpy/tool/bot/queueengine.py: 9737 97382010-03-26 Dirk Pranke <dpranke@chromium.org> 9739 9740 Unreviewed fix. 9741 9742 Fix the return value for port/base.diff_image (changed from 1/0 to 9743 True/False in bug 34826. 9744 9745 * Scripts/webkitpy/layout_tests/port/base.py: 9746 97472010-03-26 Dirk Pranke <dpranke@chromium.org> 9748 9749 Reviewed by Eric Seidel. 9750 9751 Change the Mac port of new-run-webkit-tests to look for a 9752 test_expectations.txt file in addition to the Skipped files, so we 9753 can track pixel failures. 9754 9755 https://bugs.webkit.org/show_bug.cgi?id=36619 9756 9757 * Scripts/webkitpy/layout_tests/port/mac.py: 9758 97592010-03-26 Dirk Pranke <dpranke@chromium.org> 9760 9761 Reviewed by Eric Seidel. 9762 9763 Implement pixel tests (image diff) properly on the Mac port. 9764 9765 This change introduces a new "ServerPocess" class that can be used 9766 to manage processes that the run-webkit-tests harness forks off and 9767 expects to stay up for longer than a single request/response session. 9768 Both DumpRenderTree and ImageDiff use this style of communication, 9769 although the current code forks off a new ImageDiff for each diff 9770 (We need to restructure other parts of the code to be able to do this 9771 safely in a multi-threaded environment). 9772 9773 Also, now that the ServerProcess abstraction exists, we can probably 9774 clean up and simplify some of the thread management logic in 9775 test_shell_thread as well. 9776 9777 https://bugs.webkit.org/show_bug.cgi?id=34826 9778 9779 * Scripts/webkitpy/layout_tests/port/mac.py: 9780 * Scripts/webkitpy/layout_tests/port/server_process.py: 9781 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 9782 97832010-03-26 Sergio Villar Senin <svillar@igalia.com> 9784 9785 Reviewed by Eric Seidel. 9786 9787 Print didFinishLoadForFrame outcome in DRT 9788 9789 [GTK] Improve reporting of frame loader callbacks in DRT 9790 https://bugs.webkit.org/show_bug.cgi?id=36454 9791 9792 * DumpRenderTree/gtk/DumpRenderTree.cpp: 9793 (webViewLoadCommitted): 9794 97952010-03-26 Eric Seidel <eric@webkit.org> 9796 9797 Unreviewed test fix. 9798 My change conflicted with one of Adam's causing test-webkitpy to fail. 9799 9800 Move commit_message_for_this_commit from scm to checkout 9801 https://bugs.webkit.org/show_bug.cgi?id=36629 9802 9803 * Scripts/webkitpy/common/checkout/api_unittest.py: 9804 - modified_changelogs is now on Checkout instead of scm. 9805 98062010-03-26 Adam Barth <abarth@webkit.org> 9807 9808 Reviewed by Eric Seidel. 9809 9810 Refactor IRCBot controller logic to allow for commands 9811 https://bugs.webkit.org/show_bug.cgi?id=36676 9812 9813 We need to move the controller logic into the tool package so it can 9814 know about commands. The changes to queueengine could go in a 9815 different patch, but we're going to need it anyway. 9816 9817 * Scripts/webkitpy/common/config/irc.py: Added. 9818 * Scripts/webkitpy/common/net/irc/ircbot.py: 9819 * Scripts/webkitpy/common/net/irc/ircproxy.py: 9820 * Scripts/webkitpy/tool/bot/queueengine.py: 9821 * Scripts/webkitpy/tool/bot/sheriffircbot.py: Added. 9822 * Scripts/webkitpy/tool/commands/sheriffbot.py: 9823 * Scripts/webkitpy/tool/main.py: 9824 * Scripts/webkitpy/tool/mocktool.py: 9825 98262010-03-26 Adam Barth <abarth@webkit.org> 9827 9828 Rubber stamped by Eric Seidel. 9829 9830 Move the threading code into its own module. (It has nothing to do with IRC.) 9831 9832 * Scripts/webkitpy/common/net/irc/ircbot.py: 9833 * Scripts/webkitpy/common/net/irc/ircproxy.py: 9834 * Scripts/webkitpy/common/net/irc/messagepump.py: Removed. 9835 * Scripts/webkitpy/common/net/irc/messagepump_unittest.py: Removed. 9836 * Scripts/webkitpy/common/net/irc/threadedmessagequeue.py: Removed. 9837 * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py: Removed. 9838 * Scripts/webkitpy/common/net/irc/unittests.py: 9839 * Scripts/webkitpy/common/thread: Added. 9840 * Scripts/webkitpy/common/thread/__init__.py: Added. 9841 * Scripts/webkitpy/common/thread/messagepump.py: Copied from Scripts/webkitpy/common/net/irc/messagepump.py. 9842 * Scripts/webkitpy/common/thread/messagepump_unittest.py: Copied from Scripts/webkitpy/common/net/irc/messagepump_unittest.py. 9843 * Scripts/webkitpy/common/thread/threadedmessagequeue.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue.py. 9844 * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py. 9845 * Scripts/webkitpy/common/thread/unittests.py: Added. 9846 * Scripts/webkitpy/common/unittests.py: 9847 98482010-03-26 Eric Seidel <eric@webkit.org> 9849 9850 Reviewed by Adam Barth. 9851 9852 Move commit_message_for_this_commit from scm to checkout 9853 https://bugs.webkit.org/show_bug.cgi?id=36629 9854 9855 Finally add some basic unit testing for Checkout.commit_message_for_this_commit 9856 9857 * Scripts/webkitpy/common/checkout/api.py: 9858 * Scripts/webkitpy/common/checkout/api_unittest.py: Added. 9859 * Scripts/webkitpy/common/unittests.py: 9860 98612010-03-26 Diego Gonzalez <diego.gonzalez@openbossa.org> 9862 9863 [Qt] User Agent Switcher on QtLauncher 9864 https://bugs.webkit.org/show_bug.cgi?id=36451 9865 9866 Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-26 9867 Reviewed by Simon Hausmann. 9868 9869 Make possible to change the QtLauncher user agent via 9870 a predefined list. 9871 9872 * QtLauncher/QtLauncher.pro: 9873 * QtLauncher/QtLauncher.qrc: Added. 9874 * QtLauncher/main.cpp: 9875 (LauncherWindow::showUserAgentDialog): 9876 (LauncherWindow::createChrome): 9877 * QtLauncher/useragentlist.txt: Added. 9878 * QtLauncher/webpage.cpp: 9879 (WebPage::userAgentForUrl): 9880 * QtLauncher/webpage.h: 9881 (WebPage::setUserAgent): 9882 98832010-03-26 Victor Wang <victorw@chromium.org> 9884 9885 Reviewed by Adam Barth. 9886 9887 Host layout test flakiness dashboard in TestResultServer appengine. 9888 9889 Flakiness dashboard is a tool to monitor layout test status and 9890 help layout test regression diagnostics. 9891 9892 https://bugs.webkit.org/show_bug.cgi?id=36195 9893 9894 * TestResultServer/handlers/dashboardhandler.py: Added. 9895 - New handler to handle dashboard request 9896 * TestResultServer/handlers/menu.py: 9897 - Add new dashboard links 9898 * TestResultServer/handlers/testfilehandler.py: 9899 - Request routes refactory 9900 * TestResultServer/index.yaml: 9901 * TestResultServer/main.py: 9902 - Add new dashboard request routes and refactor test result file rountes. 9903 * TestResultServer/model/dashboardfile.py: Added. 9904 - Model to access datastore for dashboard files 9905 * TestResultServer/model/testfile.py: 9906 * TestResultServer/stylesheets/dashboardfile.css: Added. 9907 * TestResultServer/templates/dashboardfilelist.html: Added. 9908 * TestResultServer/templates/showfilelist.html: 9909 99102010-03-26 Adam Barth <abarth@webkit.org> 9911 9912 Reviewed by Eric Seidel. 9913 9914 Remove some evil statics from CommitInfo 9915 https://bugs.webkit.org/show_bug.cgi?id=36637 9916 9917 These methods should really be on checkout. You can tell because they 9918 know about ChangeLogs and take an SCM as an argument. :) 9919 9920 * Scripts/webkitpy/common/checkout/api.py: 9921 * Scripts/webkitpy/common/checkout/changelog.py: 9922 * Scripts/webkitpy/common/checkout/commitinfo.py: 9923 * Scripts/webkitpy/tool/commands/queries.py: 9924 99252010-03-23 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 9926 9927 Reviewed by Simon Hausmann. 9928 9929 Add an option to QtLauncher to enable/disable a QGLWidget as Viewport 9930 of the QGraphicsView when the launcher is running on graphicsview mode. 9931 9932 [Qt] QtLauncher needs an option to Enable/Disable a QGLWidget as Viewport 9933 https://bugs.webkit.org/show_bug.cgi?id=36270 9934 9935 * QtLauncher/QtLauncher.pro: 9936 * QtLauncher/main.cpp: 9937 (LauncherWindow::toggleQGLWidgetViewport): 9938 (LauncherWindow::createChrome): 9939 99402010-03-26 Fumitoshi Ukai <ukai@chromium.org> 9941 9942 Reviewed by Shinichiro Hamaji. 9943 9944 [Chromium-Win] websocket_server.py failed to start 9945 https://bugs.webkit.org/show_bug.cgi?id=36586 9946 9947 subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle. 9948 We don't need stdin, so use devnull as stdin. 9949 9950 * Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin 9951 99522010-03-26 Kent Tamura <tkent@chromium.org> 9953 9954 Reviewed by Dimitri Glazkov. 9955 9956 [DRT/Chromium] Add TestNavigationController and TestWebWorker 9957 https://bugs.webkit.org/show_bug.cgi?id=36520 9958 9959 Add LayoutTestController class, which is going to be used by 9960 DumpRenderTree Chromium port. These files are based on: 9961 - src/webkit/tools/test_shell/layout_test_controller.cc 9962 - src/webkit/tools/test_shell/layout_test_controller.h 9963 of Chromium rev.40492. 9964 9965 * DumpRenderTree/chromium/LayoutTestController.cpp: Added. 9966 * DumpRenderTree/chromium/LayoutTestController.h: Added. 9967 99682010-03-25 Charlie Reis <creis@chromium.org> 9969 9970 Reviewed by Adam Barth. 9971 9972 onbeforeunload not called at window close + frame or iframe focused 9973 https://bugs.webkit.org/show_bug.cgi?id=27481 9974 9975 Adds a callShouldCloseOnWebView method to LayoutTestController, 9976 to allow automated testing for bug 27481. 9977 9978 * DumpRenderTree/LayoutTestController.cpp: 9979 (callShouldCloseOnWebViewCallback): 9980 (LayoutTestController::staticFunctions): 9981 * DumpRenderTree/LayoutTestController.h: 9982 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 9983 (LayoutTestController::callShouldCloseOnWebView): 9984 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 9985 (LayoutTestController::callShouldCloseOnWebView): 9986 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 9987 (LayoutTestController::callShouldCloseOnWebView): 9988 * DumpRenderTree/qt/LayoutTestControllerQt.h: 9989 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 9990 (LayoutTestController::callShouldCloseOnWebView): 9991 99922010-03-25 Eric Seidel <eric@webkit.org> 9993 9994 Reviewed by Adam Barth. 9995 9996 Add webkit-patch lkgr for finding last known good revision 9997 https://bugs.webkit.org/show_bug.cgi?id=36626 9998 9999 This is rather slow for now because the command 10000 has to compute this information from the buildbot. 10001 A better long-term solution would be to have a server 10002 somewhere store a pre-computed LKGR and then any 10003 script (like webkit-patch) could just fetch it. 10004 10005 * Scripts/webkitpy/common/net/buildbot.py: 10006 * Scripts/webkitpy/tool/commands/queries.py: 10007 100082010-03-25 Adam Barth <abarth@webkit.org> 10009 10010 Reviewed by Eric Seidel. 10011 10012 Move modified_changelogs (and friends) from scm to checkout 10013 https://bugs.webkit.org/show_bug.cgi?id=36636 10014 10015 These functions know about ChangeLogs, which is forbidden knowledge in 10016 scm.py. 10017 10018 * Scripts/webkitpy/common/checkout/api.py: 10019 * Scripts/webkitpy/common/checkout/changelog.py: 10020 * Scripts/webkitpy/common/checkout/scm.py: 10021 * Scripts/webkitpy/tool/mocktool.py: 10022 * Scripts/webkitpy/tool/steps/abstractstep.py: 10023 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: 10024 * Scripts/webkitpy/tool/steps/revertrevision.py: 10025 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: 10026 * Scripts/webkitpy/tool/steps/validatereviewer.py: 10027 100282010-03-25 Adam Barth <abarth@webkit.org> 10029 10030 Reviewed by Eric Seidel. 10031 10032 Move apply_patch from scm to checkout 10033 https://bugs.webkit.org/show_bug.cgi?id=36635 10034 10035 SCM shouldn't have any knowledge of WebKit scripts. 10036 10037 * Scripts/webkitpy/common/checkout/api.py: 10038 * Scripts/webkitpy/common/checkout/scm.py: 10039 * Scripts/webkitpy/common/checkout/scm_unittest.py: 10040 * Scripts/webkitpy/tool/mocktool.py: 10041 * Scripts/webkitpy/tool/steps/applypatch.py: 10042 100432010-03-25 Eric Seidel <eric@webkit.org> 10044 10045 Unreviewed build fix to un-break webkit-patch land. 10046 Test-case coming in follow-up commit. 10047 10048 Move commit_message_for_this_commit from scm to checkout 10049 https://bugs.webkit.org/show_bug.cgi?id=36629 10050 10051 * Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage 10052 100532010-03-25 Dan Bernstein <mitz@apple.com> 10054 10055 Reviewed by Darin Adler. 10056 10057 <rdar://problem/7728903> Support color bitmap fonts 10058 10059 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf 10060 and ColorBits-A.png. 10061 * DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png. 10062 * DumpRenderTree/fonts/ColorBits.ttf: Added. 10063 * DumpRenderTree/mac/DumpRenderTree.mm: 10064 (activateFonts): Activate ColorBits.ttf. 10065 100662010-03-25 Mark Rowe <mrowe@apple.com> 10067 10068 Remove a printf that was causing commit-log-editor to spew the name of the editor 10069 to the terminal many times during a commit. 10070 10071 * Scripts/commit-log-editor: 10072 100732010-03-25 Adam Barth <abarth@webkit.org> 10074 10075 Reviewed by Eric Seidel. 10076 10077 Move commit_message_for_this_commit from scm to checkout 10078 https://bugs.webkit.org/show_bug.cgi?id=36629 10079 10080 This function requires knowledge of ChangeLogs, but scm shouldn't know 10081 about ChangeLogs. 10082 10083 * Scripts/webkitpy/common/checkout/api.py: 10084 * Scripts/webkitpy/common/checkout/scm.py: 10085 * Scripts/webkitpy/tool/commands/upload.py: 10086 * Scripts/webkitpy/tool/commands/upload_unittest.py: 10087 * Scripts/webkitpy/tool/mocktool.py: 10088 * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py: 10089 * Scripts/webkitpy/tool/steps/commit.py: 10090 100912010-03-25 Adam Barth <abarth@webkit.org> 10092 10093 Reviewed by Eric Seidel. 10094 10095 REGRESSION: webkit-patch land can't land "rubber-stamped" patches 10096 https://bugs.webkit.org/show_bug.cgi?id=36582 10097 10098 Allow a "-" in rubber stamped. 10099 10100 * Scripts/webkitpy/tool/steps/validatereviewer.py: 10101 101022010-03-25 Adam Barth <abarth@webkit.org> 10103 10104 Unreviewed. Fix some copyright lines to remove extraneous comma and 10105 python directive. 10106 10107 * Scripts/webkitpy/tool/bot/patchcollection.py: 10108 * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: 10109 * Scripts/webkitpy/tool/bot/queueengine.py: 10110 * Scripts/webkitpy/tool/bot/queueengine_unittest.py: 10111 * Scripts/webkitpy/tool/commands/download.py: 10112 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 10113 * Scripts/webkitpy/tool/commands/queries.py: 10114 * Scripts/webkitpy/tool/commands/queues.py: 10115 * Scripts/webkitpy/tool/commands/sheriffbot.py: 10116 * Scripts/webkitpy/tool/comments.py: 10117 * Scripts/webkitpy/tool/grammar.py: 10118 * Scripts/webkitpy/tool/multicommandtool.py: 10119 * Scripts/webkitpy/tool/multicommandtool_unittest.py: 10120 101212010-03-25 Simon Fraser <simon.fraser@apple.com> 10122 10123 Reviewed by Darin Adler, Alexey Proskuryakov. 10124 10125 https://bugs.webkit.org/show_bug.cgi?id=36631 10126 Allow the test plugin to run scripts in response to NPP_SetWindow calls 10127 10128 Hook up the ability for the TestNetscapePlugIn to run JavaScript in 10129 response to NPP_SetWindow. 10130 10131 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 10132 (pluginAllocate): 10133 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: 10134 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 10135 (NPP_New): 10136 (NPP_Destroy): 10137 (NPP_SetWindow): 10138 101392010-03-25 Laszlo Gombos <laszlo.1.gombos@nokia.com> 10140 10141 Unreviewed, build fix. 10142 10143 [Qt] Fix QtLauncher guards. 10144 10145 * QtLauncher/main.cpp: 10146 (LauncherWindow::showFPS): 10147 (LauncherWindow::updateFPS): 10148 101492010-03-25 Yury Semikhatsky <yurys@chromium.org> 10150 10151 Reviewed by Pavel Feldman. 10152 10153 Allow running tests with enabled developer extras and closed Web Inspector. Tests that have inspector-enabled/ in their path/url will have developer extras enabled. 10154 10155 https://bugs.webkit.org/show_bug.cgi?id=36610 10156 10157 * DumpRenderTree/LayoutTestController.h: 10158 * DumpRenderTree/gtk/DumpRenderTree.cpp: 10159 (shouldEnableDeveloperExtras): 10160 (runTest): 10161 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 10162 (LayoutTestController::setJavaScriptProfilingEnabled): 10163 (LayoutTestController::setDeveloperExtrasEnabled): 10164 (LayoutTestController::showWebInspector): 10165 (LayoutTestController::closeWebInspector): 10166 * DumpRenderTree/mac/DumpRenderTree.mm: 10167 (shouldEnableDeveloperExtras): 10168 (runTest): 10169 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 10170 (LayoutTestController::setJavaScriptProfilingEnabled): 10171 (LayoutTestController::setDeveloperExtrasEnabled): 10172 (LayoutTestController::showWebInspector): 10173 (LayoutTestController::closeWebInspector): 10174 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 10175 (WebCore::shouldEnableDeveloperExtras): 10176 (WebCore::DumpRenderTree::open): 10177 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 10178 (LayoutTestController::closeWebInspector): 10179 (LayoutTestController::setDeveloperExtrasEnabled): 10180 (LayoutTestController::showWebInspector): 10181 (LayoutTestController::setJavaScriptProfilingEnabled): 10182 * DumpRenderTree/win/DumpRenderTree.cpp: 10183 (shouldEnableDeveloperExtras): 10184 (runTest): 10185 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 10186 (LayoutTestController::setJavaScriptProfilingEnabled): 10187 (LayoutTestController::setDeveloperExtrasEnabled): 10188 (LayoutTestController::showWebInspector): 10189 (LayoutTestController::closeWebInspector): 10190 101912010-03-25 Adam Barth <abarth@webkit.org> 10192 10193 Rubber stamped by Eric Seidel. 10194 10195 Tweaks to sheriffbot to improve latency by keeping the working copy up 10196 to date even when there's no build break. Also, officially move 10197 sheriffbot to #webkit. 10198 10199 (Also teach ValidateReviewer to understand rubber stamps.) 10200 10201 * Scripts/webkitpy/common/net/irc/ircbot.py: 10202 * Scripts/webkitpy/tool/commands/sheriffbot.py: 10203 * Scripts/webkitpy/tool/steps/validatereviewer.py: 10204 102052010-03-22 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 10206 10207 Reviewed by Simon Hausmann. 10208 10209 Not displaying FPS info on the terminal. On S60 and Maemo the 10210 Window title will be used and Status bar will used on desktop. 10211 10212 [Qt] QtLauncher's FPS info should not be displayed on the terminal 10213 https://bugs.webkit.org/show_bug.cgi?id=36244 10214 10215 * QtLauncher/main.cpp: 10216 (LauncherWindow::initializeView): 10217 (LauncherWindow::showFPS): 10218 (LauncherWindow::updateFPS): 10219 * QtLauncher/webview.cpp: 10220 (WebViewGraphicsBased::setFrameRateMeasurementEnabled): 10221 (WebViewGraphicsBased::updateFrameRate): 10222 * QtLauncher/webview.h: 10223 (WebViewGraphicsBased::frameRateMeasurementEnabled): 10224 102252010-03-25 Diego Gonzalez <diego.gonzalez@openbossa.org> 10226 10227 Reviewed by Kenneth Christiansen. 10228 10229 Added missing frame flattening activation on 10230 fast/frames/flattening/frameset-flattening-grid.html; 10231 removed unnecessary CONSOLE MESSAGE from the expected file; 10232 reset the setFrameSetFlatteningEnabled for each test. 10233 10234 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 10235 (WebCore::WebPage::resetSettings): 10236 102372010-03-25 Chris Jerdonek <cjerdonek@webkit.org> 10238 10239 Reviewed by Adam Barth. 10240 10241 Moved deprecated_logging unit test import statement from 10242 webkitpy/unittests.py to webkitpy/common/system/unittests.py. 10243 10244 https://bugs.webkit.org/show_bug.cgi?id=36093 10245 10246 This is part of the master bug to reorganize webkitpy. 10247 10248 * Scripts/webkitpy/common/system/unittests.py: 10249 * Scripts/webkitpy/unittests.py: 10250 102512010-03-25 Chris Jerdonek <cjerdonek@webkit.org> 10252 10253 Reviewed by Adam Barth. 10254 10255 Moved webkit_logging.py to common/system/deprecated_logging.py 10256 inside webkitpy. 10257 10258 https://bugs.webkit.org/show_bug.cgi?id=36093 10259 10260 This is part of the master bug to reorganize webkitpy. 10261 10262 * Scripts/validate-committer-lists: 10263 * Scripts/webkitpy/common/checkout/changelog.py: 10264 * Scripts/webkitpy/common/checkout/scm.py: 10265 * Scripts/webkitpy/common/net/bugzilla.py: 10266 * Scripts/webkitpy/common/net/buildbot.py: 10267 * Scripts/webkitpy/common/net/credentials.py: 10268 * Scripts/webkitpy/common/net/irc/ircproxy.py: 10269 * Scripts/webkitpy/common/net/networktransaction.py: 10270 * Scripts/webkitpy/common/net/statusserver.py: 10271 * Scripts/webkitpy/common/system/deprecated_logging.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging.py. 10272 * Scripts/webkitpy/common/system/deprecated_logging_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging_unittest.py. 10273 * Scripts/webkitpy/common/system/executive.py: 10274 * Scripts/webkitpy/tool/bot/queueengine.py: 10275 * Scripts/webkitpy/tool/commands/download.py: 10276 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 10277 * Scripts/webkitpy/tool/commands/openbugs.py: 10278 * Scripts/webkitpy/tool/commands/queries.py: 10279 * Scripts/webkitpy/tool/commands/queues.py: 10280 * Scripts/webkitpy/tool/commands/sheriffbot.py: 10281 * Scripts/webkitpy/tool/commands/stepsequence.py: 10282 * Scripts/webkitpy/tool/commands/upload.py: 10283 * Scripts/webkitpy/tool/main.py: 10284 * Scripts/webkitpy/tool/mocktool.py: 10285 * Scripts/webkitpy/tool/multicommandtool.py: 10286 * Scripts/webkitpy/tool/steps/abstractstep.py: 10287 * Scripts/webkitpy/tool/steps/applypatch.py: 10288 * Scripts/webkitpy/tool/steps/build.py: 10289 * Scripts/webkitpy/tool/steps/checkstyle.py: 10290 * Scripts/webkitpy/tool/steps/closebug.py: 10291 * Scripts/webkitpy/tool/steps/closebugforlanddiff.py: 10292 * Scripts/webkitpy/tool/steps/confirmdiff.py: 10293 * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: 10294 * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py: 10295 * Scripts/webkitpy/tool/steps/obsoletepatches.py: 10296 * Scripts/webkitpy/tool/steps/preparechangelog.py: 10297 * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py: 10298 * Scripts/webkitpy/tool/steps/runtests.py: 10299 * Scripts/webkitpy/tool/steps/update.py: 10300 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: 10301 * Scripts/webkitpy/tool/steps/validatereviewer.py: 10302 * Scripts/webkitpy/unittests.py: 10303 * Scripts/webkitpy/webkit_logging.py: Removed. 10304 * Scripts/webkitpy/webkit_logging_unittest.py: Removed. 10305 103062010-03-25 Julien Chaffraix <jchaffraix@webkit.org> 10307 10308 Reviewed by Kenneth Rohde Christiansen. 10309 10310 commit-log-editor can call itself in an infinite loop 10311 https://bugs.webkit.org/show_bug.cgi?id=35291 10312 10313 if $editor ends up being commit-log-editor, the script will exec itself 10314 in an infinite loop. 10315 10316 To avoid this, we now check that the $editor variable is not 10317 commit-log-editor to avoid this case. 10318 10319 * Scripts/commit-log-editor: Added an isCommitLogEditor method and 10320 reworked the $editor setting to add this check. 10321 103222010-03-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 10323 10324 Reviewed by Kenneth Rohde Christiansen. 10325 10326 Add a Toggle Frame Flattening option to QtLauncher. 10327 It will be enabled by default on Maemo5 and S60 platforms. 10328 10329 [Qt] Add enable/disable Frame Flattening option to QtLauncher 10330 https://bugs.webkit.org/show_bug.cgi?id=36558 10331 10332 * QtLauncher/main.cpp: 10333 (LauncherWindow::applyPrefs): 10334 (LauncherWindow::toggleFrameFlattening): 10335 (LauncherWindow::createChrome): 10336 103372010-03-25 Zoltan Horvath <zoltan@webkit.org> 10338 10339 Reviewed by Eric Seidel. 10340 10341 svn-create-patch prints a warning for large patches 10342 https://bugs.webkit.org/show_bug.cgi?id=32582 10343 10344 svn-create-patch prints a warning message for larger patches than 20k. 10345 10346 * Scripts/svn-create-patch: 10347 103482010-03-25 Adam Barth <abarth@webkit.org> 10349 10350 Unreviewed. Renamed early_warning_system.py to earlywarningsystem.py. 10351 https://bugs.webkit.org/show_bug.cgi?id=36093 10352 10353 * Scripts/webkitpy/tool/commands/early_warning_system.py: Removed. 10354 * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: Removed. 10355 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system.py. 10356 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system_unittest.py. 10357 * Scripts/webkitpy/tool/main.py: 10358 * Scripts/webkitpy/tool/unittests.py: 10359 103602010-03-25 Chris Jerdonek <cjerdonek@webkit.org> 10361 10362 Reviewed by Adam Barth. 10363 10364 In webkitpy, pushed the unit test import statements in 10365 webkitpy/unittests.py into appropriate unittests.py files in the 10366 new root-level packages beneath webkitpy. 10367 10368 https://bugs.webkit.org/show_bug.cgi?id=36093 10369 10370 This is part of the master bug to reorganize webkitpy. 10371 10372 * Scripts/webkitpy/common/system/unittests.py: 10373 * Scripts/webkitpy/common/unittests.py: Added. 10374 * Scripts/webkitpy/python24/unittests.py: Added. 10375 * Scripts/webkitpy/tool/unittests.py: Added. 10376 * Scripts/webkitpy/unittests.py: 10377 103782010-03-25 Adam Barth <abarth@webkit.org> 10379 10380 Unreviewed. Move WebKitCheckout into the webkitpy.common.checkout 10381 package. 10382 https://bugs.webkit.org/show_bug.cgi?id=36093 10383 10384 * Scripts/webkitpy/common/checkout/api.py: Copied from Scripts/webkitpy/webkitcheckout.py. 10385 * Scripts/webkitpy/tool/main.py: 10386 * Scripts/webkitpy/tool/mocktool.py: 10387 * Scripts/webkitpy/webkitcheckout.py: Removed. 10388 103892010-03-25 Adam Barth <abarth@webkit.org> 10390 10391 Unreviewed. Move OutputCapture to webkitpy.common.system. 10392 https://bugs.webkit.org/show_bug.cgi?id=36093 10393 10394 * Scripts/webkitpy/common/net/bugzilla_unittest.py: 10395 * Scripts/webkitpy/common/net/credentials_unittest.py: 10396 * Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py. 10397 * Scripts/webkitpy/outputcapture.py: Removed. 10398 * Scripts/webkitpy/tool/commands/commandtest.py: 10399 * Scripts/webkitpy/tool/commands/queues_unittest.py: 10400 * Scripts/webkitpy/tool/commands/queuestest.py: 10401 * Scripts/webkitpy/tool/multicommandtool_unittest.py: 10402 * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py: 10403 * Scripts/webkitpy/tool/steps/steps_unittest.py: 10404 * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: 10405 104062010-03-25 Adam Barth <abarth@webkit.org> 10407 10408 Unreviewed. Move user.py to webkitpy.common.system. 10409 10410 * Scripts/webkitpy/common/checkout/scm.py: 10411 * Scripts/webkitpy/common/net/bugzilla.py: 10412 * Scripts/webkitpy/common/net/credentials.py: 10413 * Scripts/webkitpy/common/system/user.py: Copied from Scripts/webkitpy/user.py. 10414 * Scripts/webkitpy/common/system/user_unittest.py: Copied from Scripts/webkitpy/user_unittest.py. 10415 * Scripts/webkitpy/tool/commands/upload.py: 10416 * Scripts/webkitpy/tool/main.py: 10417 * Scripts/webkitpy/unittests.py: 10418 * Scripts/webkitpy/user.py: Removed. 10419 * Scripts/webkitpy/user_unittest.py: Removed. 10420 104212010-03-25 Adam Barth <abarth@webkit.org> 10422 10423 Unreviewed. Move executive.py to webkitpy.common.system. 10424 https://bugs.webkit.org/show_bug.cgi?id=36093 10425 10426 * Scripts/webkitpy/common/checkout/scm.py: 10427 * Scripts/webkitpy/common/checkout/scm_unittest.py: 10428 * Scripts/webkitpy/common/config/ports.py: 10429 * Scripts/webkitpy/common/config/ports_unittest.py: 10430 * Scripts/webkitpy/common/net/credentials.py: 10431 * Scripts/webkitpy/common/net/credentials_unittest.py: 10432 * Scripts/webkitpy/common/system/executive.py: Copied from Scripts/webkitpy/executive.py. 10433 * Scripts/webkitpy/common/system/executive_unittest.py: Copied from Scripts/webkitpy/executive_unittest.py. 10434 * Scripts/webkitpy/executive.py: Removed. 10435 * Scripts/webkitpy/executive_unittest.py: Removed. 10436 * Scripts/webkitpy/layout_tests/port/mac.py: 10437 * Scripts/webkitpy/tool/bot/queueengine.py: 10438 * Scripts/webkitpy/tool/bot/queueengine_unittest.py: 10439 * Scripts/webkitpy/tool/commands/download.py: 10440 * Scripts/webkitpy/tool/commands/early_warning_system.py: 10441 * Scripts/webkitpy/tool/commands/queues.py: 10442 * Scripts/webkitpy/tool/commands/stepsequence.py: 10443 * Scripts/webkitpy/tool/main.py: 10444 * Scripts/webkitpy/tool/steps/checkstyle.py: 10445 * Scripts/webkitpy/tool/steps/preparechangelog.py: 10446 * Scripts/webkitpy/unittests.py: 10447 * Scripts/webkitpy/webkit_logging_unittest.py: 10448 104492010-03-25 Adam Barth <abarth@webkit.org> 10450 10451 Unreviewed. Move grammary.py into webkitpy.tool. 10452 https://bugs.webkit.org/show_bug.cgi?id=36093 10453 10454 * Scripts/webkitpy/grammar.py: Removed. 10455 * Scripts/webkitpy/grammar_unittest.py: Removed. 10456 * Scripts/webkitpy/tool/commands/download.py: 10457 * Scripts/webkitpy/tool/commands/queries.py: 10458 * Scripts/webkitpy/tool/commands/queues.py: 10459 * Scripts/webkitpy/tool/commands/upload.py: 10460 * Scripts/webkitpy/tool/grammar.py: Copied from Scripts/webkitpy/grammar.py. 10461 * Scripts/webkitpy/tool/grammar_unittest.py: Copied from Scripts/webkitpy/grammar_unittest.py. 10462 * Scripts/webkitpy/tool/multicommandtool.py: 10463 * Scripts/webkitpy/tool/steps/obsoletepatches.py: 10464 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: 10465 * Scripts/webkitpy/unittests.py: 10466 104672010-03-25 Chris Jerdonek <cjerdonek@webkit.org> 10468 10469 Reviewed by Adam Barth. 10470 10471 In webkitpy, moved init/ to common/system/. 10472 10473 https://bugs.webkit.org/show_bug.cgi?id=36093 10474 10475 This is part of the master bug to reorganize webkitpy. 10476 10477 * Scripts/webkitpy/common/system: Copied from WebKitTools/Scripts/webkitpy/init. 10478 * Scripts/webkitpy/common/system/logutils.py: 10479 * Scripts/webkitpy/common/system/logutils_unittest.py: 10480 * Scripts/webkitpy/init: Removed. 10481 * Scripts/webkitpy/init/__init__.py: Removed. 10482 * Scripts/webkitpy/init/logtesting.py: Removed. 10483 * Scripts/webkitpy/init/logutils.py: Removed. 10484 * Scripts/webkitpy/init/logutils_unittest.py: Removed. 10485 * Scripts/webkitpy/init/unittests.py: Removed. 10486 * Scripts/webkitpy/python24/versioning_unittest.py: 10487 * Scripts/webkitpy/style_references.py: 10488 * Scripts/webkitpy/unittests.py: 10489 104902010-03-25 Adam Barth <abarth@webkit.org> 10491 10492 Unreviewed. Move stepsequence to webkitpy.tool.commands. 10493 https://bugs.webkit.org/show_bug.cgi?id=36093 10494 10495 * Scripts/webkitpy/stepsequence.py: Removed. 10496 * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: 10497 * Scripts/webkitpy/tool/commands/download.py: 10498 * Scripts/webkitpy/tool/commands/queues.py: 10499 * Scripts/webkitpy/tool/commands/stepsequence.py: Copied from Scripts/webkitpy/stepsequence.py. 10500 105012010-03-25 Adam Barth <abarth@webkit.org> 10502 10503 Unreviewed. Create webkitpy.common.checkout as described in 10504 https://bugs.webkit.org/show_bug.cgi?id=36093 10505 10506 * Scripts/webkitpy/changelogs.py: Removed. 10507 * Scripts/webkitpy/changelogs_unittest.py: Removed. 10508 * Scripts/webkitpy/commitinfo.py: Removed. 10509 * Scripts/webkitpy/commitinfo_unittest.py: Removed. 10510 * Scripts/webkitpy/common/checkout: Added. 10511 * Scripts/webkitpy/common/checkout/__init__.py: Copied from Scripts/webkitpy/common/__init__.py. 10512 * Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py. 10513 * Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py. 10514 * Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py. 10515 * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py. 10516 * Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py. 10517 * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py. 10518 * Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py. 10519 * Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py. 10520 * Scripts/webkitpy/common/net/credentials.py: 10521 * Scripts/webkitpy/diff_parser.py: Removed. 10522 * Scripts/webkitpy/diff_parser_unittest.py: Removed. 10523 * Scripts/webkitpy/layout_tests/port/base.py: 10524 * Scripts/webkitpy/scm.py: Removed. 10525 * Scripts/webkitpy/scm_unittest.py: Removed. 10526 * Scripts/webkitpy/stepsequence.py: 10527 * Scripts/webkitpy/style_references.py: 10528 * Scripts/webkitpy/tool/commands/download.py: 10529 * Scripts/webkitpy/tool/commands/queries.py: 10530 * Scripts/webkitpy/tool/comments.py: 10531 * Scripts/webkitpy/tool/main.py: 10532 * Scripts/webkitpy/tool/mocktool.py: 10533 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: 10534 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: 10535 * Scripts/webkitpy/tool/steps/validatereviewer.py: 10536 * Scripts/webkitpy/unittests.py: 10537 * Scripts/webkitpy/webkitcheckout.py: 10538 105392010-03-25 Chris Jerdonek <cjerdonek@webkit.org> 10540 10541 Reviewed by Adam Barth. 10542 10543 In webkitpy, moved init/versioning.py to python24/. 10544 10545 https://bugs.webkit.org/show_bug.cgi?id=36093 10546 10547 This is part of the master bug to reorganize webkitpy. 10548 10549 * Scripts/test-webkitpy: 10550 * Scripts/webkit-patch: 10551 * Scripts/webkitpy/init/unittests.py: 10552 * Scripts/webkitpy/init/versioning.py: Removed. 10553 * Scripts/webkitpy/init/versioning_unittest.py: Removed. 10554 * Scripts/webkitpy/python24: Added. 10555 * Scripts/webkitpy/python24/__init__.py: Copied from WebKitTools/Scripts/webkitpy/tool/__init__.py. 10556 * Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py. 10557 * Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py. 10558 * Scripts/webkitpy/unittests.py: 10559 105602010-03-25 Adam Barth <abarth@webkit.org> 10561 10562 Unreviewed. 10563 10564 Create webkitpy.common.net as described in 10565 https://bugs.webkit.org/show_bug.cgi?id=36093 10566 10567 * Scripts/webkitpy/bugzilla.py: Removed. 10568 * Scripts/webkitpy/bugzilla_unittest.py: Removed. 10569 * Scripts/webkitpy/buildbot.py: Removed. 10570 * Scripts/webkitpy/buildbot_unittest.py: Removed. 10571 * Scripts/webkitpy/commitinfo.py: 10572 * Scripts/webkitpy/common/net: Added. 10573 * Scripts/webkitpy/common/net/__init__.py: Added. 10574 * Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py. 10575 * Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py. 10576 * Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py. 10577 * Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py. 10578 * Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py. 10579 * Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py. 10580 * Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc. 10581 * Scripts/webkitpy/common/net/irc/ircbot.py: 10582 * Scripts/webkitpy/common/net/irc/ircproxy.py: 10583 * Scripts/webkitpy/common/net/irc/messagepump_unittest.py: 10584 * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py: 10585 * Scripts/webkitpy/common/net/irc/unittests.py: 10586 * Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py. 10587 * Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py. 10588 * Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py. 10589 * Scripts/webkitpy/credentials.py: Removed. 10590 * Scripts/webkitpy/credentials_unittest.py: Removed. 10591 * Scripts/webkitpy/irc: Removed. 10592 * Scripts/webkitpy/irc/__init__.py: Removed. 10593 * Scripts/webkitpy/irc/ircbot.py: Removed. 10594 * Scripts/webkitpy/irc/ircproxy.py: Removed. 10595 * Scripts/webkitpy/irc/messagepump.py: Removed. 10596 * Scripts/webkitpy/irc/messagepump_unittest.py: Removed. 10597 * Scripts/webkitpy/irc/threadedmessagequeue.py: Removed. 10598 * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed. 10599 * Scripts/webkitpy/irc/unittests.py: Removed. 10600 * Scripts/webkitpy/networktransaction.py: Removed. 10601 * Scripts/webkitpy/networktransaction_unittest.py: Removed. 10602 * Scripts/webkitpy/scm_unittest.py: 10603 * Scripts/webkitpy/statusserver.py: Removed. 10604 * Scripts/webkitpy/tool/bot/queueengine.py: 10605 * Scripts/webkitpy/tool/commands/download.py: 10606 * Scripts/webkitpy/tool/commands/queries.py: 10607 * Scripts/webkitpy/tool/commands/queries_unittest.py: 10608 * Scripts/webkitpy/tool/commands/queues.py: 10609 * Scripts/webkitpy/tool/commands/queues_unittest.py: 10610 * Scripts/webkitpy/tool/commands/queuestest.py: 10611 * Scripts/webkitpy/tool/commands/upload.py: 10612 * Scripts/webkitpy/tool/main.py: 10613 * Scripts/webkitpy/tool/mocktool.py: 10614 * Scripts/webkitpy/tool/steps/postdiffforrevert.py: 10615 * Scripts/webkitpy/unittests.py: 10616 106172010-03-25 Chris Jerdonek <cjerdonek@webkit.org> 10618 10619 Reviewed by Adam Barth. 10620 10621 In webkitpy, renamed MockBugzillaTool to MockTool. 10622 10623 * Scripts/webkitpy/tool/commands/commandtest.py: 10624 * Scripts/webkitpy/tool/commands/queries_unittest.py: 10625 * Scripts/webkitpy/tool/commands/queues_unittest.py: 10626 * Scripts/webkitpy/tool/commands/queuestest.py: 10627 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 10628 * Scripts/webkitpy/tool/commands/upload_unittest.py: 10629 * Scripts/webkitpy/tool/mocktool.py: 10630 * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py: 10631 * Scripts/webkitpy/tool/steps/steps_unittest.py: 10632 * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: 10633 106342010-03-25 Chris Jerdonek <cjerdonek@webkit.org> 10635 10636 Reviewed by Adam Barth. 10637 10638 In Scripts/webkitpy, moved webkitport.py and committers.py into 10639 common/config/ (also creating common/config/). 10640 10641 https://bugs.webkit.org/show_bug.cgi?id=36093 10642 10643 This is part of the master bug to reorganize webkitpy. 10644 10645 * Scripts/validate-committer-lists: 10646 * Scripts/webkitpy/bugzilla.py: 10647 * Scripts/webkitpy/bugzilla_unittest.py: 10648 * Scripts/webkitpy/changelogs.py: 10649 * Scripts/webkitpy/commitinfo.py: 10650 * Scripts/webkitpy/commitinfo_unittest.py: 10651 * Scripts/webkitpy/committers.py: Removed. 10652 * Scripts/webkitpy/committers_unittest.py: Removed. 10653 * Scripts/webkitpy/common: Added. 10654 * Scripts/webkitpy/common/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py. 10655 * Scripts/webkitpy/common/config: Added. 10656 * Scripts/webkitpy/common/config/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py. 10657 * Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py. 10658 * Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py. 10659 * Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py. 10660 * Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py. 10661 * Scripts/webkitpy/mock_bugzillatool.py: 10662 * Scripts/webkitpy/tool/commands/early_warning_system.py: 10663 * Scripts/webkitpy/tool/commands/queries.py: 10664 * Scripts/webkitpy/tool/commands/sheriffbot.py: 10665 * Scripts/webkitpy/tool/commands/upload.py: 10666 * Scripts/webkitpy/tool/steps/abstractstep.py: 10667 * Scripts/webkitpy/unittests.py: 10668 * Scripts/webkitpy/webkitport.py: Removed. 10669 * Scripts/webkitpy/webkitport_unittest.py: Removed. 10670 106712010-03-25 Adam Barth <abarth@webkit.org> 10672 10673 Unreviewed. Move mock_bugzillatool.py to tool/mocktool.py. 10674 10675 * Scripts/webkitpy/mock_bugzillatool.py: Removed. 10676 * Scripts/webkitpy/tool/commands/commandtest.py: 10677 * Scripts/webkitpy/tool/commands/queries_unittest.py: 10678 * Scripts/webkitpy/tool/commands/queues_unittest.py: 10679 * Scripts/webkitpy/tool/commands/queuestest.py: 10680 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 10681 * Scripts/webkitpy/tool/commands/upload_unittest.py: 10682 * Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py. 10683 * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py: 10684 * Scripts/webkitpy/tool/steps/steps_unittest.py: 10685 * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: 10686 106872010-03-24 Adam Barth <abarth@webkit.org> 10688 10689 Unreviewed. Move comments.py and multicommandtool.py to their new 10690 home. 10691 10692 * Scripts/webkitpy/comments.py: Removed. 10693 * Scripts/webkitpy/multicommandtool.py: Removed. 10694 * Scripts/webkitpy/multicommandtool_unittest.py: Removed. 10695 * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: 10696 * Scripts/webkitpy/tool/commands/download.py: 10697 * Scripts/webkitpy/tool/commands/openbugs.py: 10698 * Scripts/webkitpy/tool/commands/queries.py: 10699 * Scripts/webkitpy/tool/commands/queues.py: 10700 * Scripts/webkitpy/tool/commands/upload.py: 10701 * Scripts/webkitpy/tool/comments.py: Copied from Scripts/webkitpy/comments.py. 10702 * Scripts/webkitpy/tool/main.py: 10703 * Scripts/webkitpy/tool/multicommandtool.py: Copied from Scripts/webkitpy/multicommandtool.py. 10704 * Scripts/webkitpy/tool/multicommandtool_unittest.py: Copied from Scripts/webkitpy/multicommandtool_unittest.py. 10705 * Scripts/webkitpy/tool/steps/closebugforlanddiff.py: 10706 * Scripts/webkitpy/tool/steps/closepatch.py: 10707 * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py: 10708 * Scripts/webkitpy/unittests.py: 10709 107102010-03-24 Adam Barth <abarth@webkit.org> 10711 10712 Unreviewed. Fixup one import statement I didn't find because the .pyc 10713 masked the error. 10714 10715 * Scripts/webkitpy/stepsequence.py: 10716 107172010-03-24 Adam Barth <abarth@webkit.org> 10718 10719 Unreviewed. Move queueengine.py to its new home. 10720 10721 * Scripts/webkitpy/queueengine.py: Removed. 10722 * Scripts/webkitpy/queueengine_unittest.py: Removed. 10723 * Scripts/webkitpy/tool/bot/queueengine.py: Copied from Scripts/webkitpy/queueengine.py. 10724 * Scripts/webkitpy/tool/bot/queueengine_unittest.py: Copied from Scripts/webkitpy/queueengine_unittest.py. 10725 * Scripts/webkitpy/tool/commands/early_warning_system.py: 10726 * Scripts/webkitpy/tool/commands/queues.py: 10727 * Scripts/webkitpy/unittests.py: 10728 107292010-03-24 Adam Barth <abarth@webkit.org> 10730 10731 Unreviewed. Move patchcollection.py to its new home. 10732 10733 * Scripts/webkitpy/patchcollection.py: Removed. 10734 * Scripts/webkitpy/patchcollection_unittest.py: Removed. 10735 * Scripts/webkitpy/tool/bot: Added. 10736 * Scripts/webkitpy/tool/bot/__init__.py: Added. 10737 * Scripts/webkitpy/tool/bot/patchcollection.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection.py. 10738 * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection_unittest.py. 10739 * Scripts/webkitpy/tool/commands/queues.py: 10740 * Scripts/webkitpy/unittests.py: 10741 107422010-03-24 Chris Jerdonek <cjerdonek@webkit.org> 10743 10744 Reviewed by Adam Barth. 10745 10746 In Scripts/webkitpy, moved steps_references.py and the steps 10747 folder into webkitpy/patch. 10748 10749 https://bugs.webkit.org/show_bug.cgi?id=36093 10750 10751 * Scripts/webkitpy/steps: Removed. 10752 * Scripts/webkitpy/steps/__init__.py: Removed. 10753 * Scripts/webkitpy/steps/abstractstep.py: Removed. 10754 * Scripts/webkitpy/steps/applypatch.py: Removed. 10755 * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Removed. 10756 * Scripts/webkitpy/steps/build.py: Removed. 10757 * Scripts/webkitpy/steps/checkstyle.py: Removed. 10758 * Scripts/webkitpy/steps/cleanworkingdirectory.py: Removed. 10759 * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Removed. 10760 * Scripts/webkitpy/steps/closebug.py: Removed. 10761 * Scripts/webkitpy/steps/closebugforlanddiff.py: Removed. 10762 * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Removed. 10763 * Scripts/webkitpy/steps/closepatch.py: Removed. 10764 * Scripts/webkitpy/steps/commit.py: Removed. 10765 * Scripts/webkitpy/steps/confirmdiff.py: Removed. 10766 * Scripts/webkitpy/steps/createbug.py: Removed. 10767 * Scripts/webkitpy/steps/editchangelog.py: Removed. 10768 * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Removed. 10769 * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Removed. 10770 * Scripts/webkitpy/steps/metastep.py: Removed. 10771 * Scripts/webkitpy/steps/obsoletepatches.py: Removed. 10772 * Scripts/webkitpy/steps/options.py: Removed. 10773 * Scripts/webkitpy/steps/postdiff.py: Removed. 10774 * Scripts/webkitpy/steps/postdiffforcommit.py: Removed. 10775 * Scripts/webkitpy/steps/postdiffforrevert.py: Removed. 10776 * Scripts/webkitpy/steps/preparechangelog.py: Removed. 10777 * Scripts/webkitpy/steps/preparechangelogforrevert.py: Removed. 10778 * Scripts/webkitpy/steps/promptforbugortitle.py: Removed. 10779 * Scripts/webkitpy/steps/reopenbugafterrollout.py: Removed. 10780 * Scripts/webkitpy/steps/revertrevision.py: Removed. 10781 * Scripts/webkitpy/steps/runtests.py: Removed. 10782 * Scripts/webkitpy/steps/steps_unittest.py: Removed. 10783 * Scripts/webkitpy/steps/update.py: Removed. 10784 * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Removed. 10785 * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Removed. 10786 * Scripts/webkitpy/steps/validatereviewer.py: Removed. 10787 * Scripts/webkitpy/steps_references.py: Removed. 10788 * Scripts/webkitpy/stepsequence.py: 10789 * Scripts/webkitpy/tool/commands/download.py: 10790 * Scripts/webkitpy/tool/commands/upload.py: 10791 * Scripts/webkitpy/tool/steps: Copied from WebKitTools/Scripts/webkitpy/steps. 10792 * Scripts/webkitpy/tool/steps/__init__.py: 10793 * Scripts/webkitpy/tool/steps/applypatch.py: 10794 * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py: 10795 * Scripts/webkitpy/tool/steps/build.py: 10796 * Scripts/webkitpy/tool/steps/checkstyle.py: 10797 * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py: 10798 * Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py: 10799 * Scripts/webkitpy/tool/steps/closebug.py: 10800 * Scripts/webkitpy/tool/steps/closebugforlanddiff.py: 10801 * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py: 10802 * Scripts/webkitpy/tool/steps/closepatch.py: 10803 * Scripts/webkitpy/tool/steps/commit.py: 10804 * Scripts/webkitpy/tool/steps/confirmdiff.py: 10805 * Scripts/webkitpy/tool/steps/createbug.py: 10806 * Scripts/webkitpy/tool/steps/editchangelog.py: 10807 * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: 10808 * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py: 10809 * Scripts/webkitpy/tool/steps/metastep.py: 10810 * Scripts/webkitpy/tool/steps/obsoletepatches.py: 10811 * Scripts/webkitpy/tool/steps/postdiff.py: 10812 * Scripts/webkitpy/tool/steps/postdiffforcommit.py: 10813 * Scripts/webkitpy/tool/steps/postdiffforrevert.py: 10814 * Scripts/webkitpy/tool/steps/preparechangelog.py: 10815 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: 10816 * Scripts/webkitpy/tool/steps/promptforbugortitle.py: 10817 * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py: 10818 * Scripts/webkitpy/tool/steps/revertrevision.py: 10819 * Scripts/webkitpy/tool/steps/runtests.py: 10820 * Scripts/webkitpy/tool/steps/steps_unittest.py: 10821 * Scripts/webkitpy/tool/steps/update.py: 10822 * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: 10823 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: 10824 * Scripts/webkitpy/tool/steps/validatereviewer.py: 10825 * Scripts/webkitpy/tool/steps_references.py: Copied from WebKitTools/Scripts/webkitpy/steps_references.py. 10826 * Scripts/webkitpy/unittests.py: 10827 108282010-03-24 Eric Seidel <eric@webkit.org> 10829 10830 Unreviewed, build fix only. 10831 10832 Abstract LayoutTestResults logic for easier reuse 10833 https://bugs.webkit.org/show_bug.cgi?id=36579 10834 10835 * Scripts/webkitpy/buildbot_unittest.py: Add a missing import. 10836 108372010-03-24 Adam Barth <abarth@webkit.org> 10838 10839 Unreviewed. Fix a stray comma to test landing an patch without review. 10840 10841 * Scripts/webkitpy/commitinfo.py: 10842 108432010-03-24 Chris Jerdonek <cjerdonek@webkit.org> 10844 10845 Reviewed by Adam Barth. 10846 10847 In Scripts/webkitpy, moved commands_references.py and the commands 10848 folder into webkitpy/patch. 10849 10850 https://bugs.webkit.org/show_bug.cgi?id=36483 10851 10852 This is part of master bug 36093 to organize webkitpy. 10853 10854 * Scripts/webkitpy/commands: Removed. 10855 * Scripts/webkitpy/commands/__init__.py: Removed. 10856 * Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed. 10857 * Scripts/webkitpy/commands/commandtest.py: Removed. 10858 * Scripts/webkitpy/commands/download.py: Removed. 10859 * Scripts/webkitpy/commands/download_unittest.py: Removed. 10860 * Scripts/webkitpy/commands/early_warning_system.py: Removed. 10861 * Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed. 10862 * Scripts/webkitpy/commands/openbugs.py: Removed. 10863 * Scripts/webkitpy/commands/openbugs_unittest.py: Removed. 10864 * Scripts/webkitpy/commands/queries.py: Removed. 10865 * Scripts/webkitpy/commands/queries_unittest.py: Removed. 10866 * Scripts/webkitpy/commands/queues.py: Removed. 10867 * Scripts/webkitpy/commands/queues_unittest.py: Removed. 10868 * Scripts/webkitpy/commands/queuestest.py: Removed. 10869 * Scripts/webkitpy/commands/sheriffbot.py: Removed. 10870 * Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed. 10871 * Scripts/webkitpy/commands/upload.py: Removed. 10872 * Scripts/webkitpy/commands/upload_unittest.py: Removed. 10873 * Scripts/webkitpy/commands_references.py: Removed. 10874 * Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands. 10875 * Scripts/webkitpy/tool/commands/commandtest.py: 10876 * Scripts/webkitpy/tool/commands/download.py: 10877 * Scripts/webkitpy/tool/commands/download_unittest.py: 10878 * Scripts/webkitpy/tool/commands/early_warning_system.py: 10879 * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: 10880 * Scripts/webkitpy/tool/commands/openbugs_unittest.py: 10881 * Scripts/webkitpy/tool/commands/queries_unittest.py: 10882 * Scripts/webkitpy/tool/commands/queues_unittest.py: 10883 * Scripts/webkitpy/tool/commands/queuestest.py: 10884 * Scripts/webkitpy/tool/commands/sheriffbot.py: 10885 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 10886 * Scripts/webkitpy/tool/commands/upload.py: 10887 * Scripts/webkitpy/tool/commands/upload_unittest.py: 10888 * Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py. 10889 * Scripts/webkitpy/tool/main.py: 10890 * Scripts/webkitpy/unittests.py: 10891 108922010-03-24 Adam Barth <abarth@webkit.org> 10893 10894 Reviewed by Eric Seidel. 10895 10896 Rename webkitpy.patch to webkitpy.tool 10897 https://bugs.webkit.org/show_bug.cgi?id=36580 10898 10899 This is in preparation for the great webkitpy naming cleanup. 10900 10901 * Scripts/webkit-patch: 10902 * Scripts/webkitpy/patch: Removed. 10903 * Scripts/webkitpy/patch/__init__.py: Removed. 10904 * Scripts/webkitpy/patch/patcher.py: Removed. 10905 * Scripts/webkitpy/tool: Copied from WebKitTools/Scripts/webkitpy/patch. 10906 * Scripts/webkitpy/tool/main.py: Copied from WebKitTools/Scripts/webkitpy/patch/patcher.py. 10907 * Scripts/webkitpy/tool/patcher.py: Removed. 10908 109092010-03-24 Eric Seidel <eric@webkit.org> 10910 10911 Reviewed by Adam Barth. 10912 10913 Abstract LayoutTestResults logic for easier reuse 10914 https://bugs.webkit.org/show_bug.cgi?id=36579 10915 10916 * Scripts/webkitpy/buildbot.py: 10917 - Split out logic into new LayoutTestResults class. 10918 * Scripts/webkitpy/buildbot_unittest.py: 10919 - Rename the testing class to match. 10920 * Scripts/webkitpy/commands/queries.py: 10921 - Use the new LayoutTestResults class. 10922 109232010-03-24 Eric Seidel <eric@webkit.org> 10924 10925 Reviewed by Eric Seidel. 10926 10927 Move Bugzilla.prompt_for_component to User.prompt_with_list for re-use 10928 https://bugs.webkit.org/show_bug.cgi?id=36577 10929 10930 * Scripts/webkitpy/bugzilla.py: 10931 - Move prompt_for_component to User 10932 * Scripts/webkitpy/commands/queries.py: 10933 - Add a missing argument_names declaration. 10934 * Scripts/webkitpy/user.py: 10935 - Add prompt_with_list 10936 - Make staticmethods classmethods for easier mocking 10937 109382010-03-24 David Kilzer <ddkilzer@apple.com> 10939 10940 <http://webkit.org/b/36572> commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file 10941 10942 Reviewed by Eric Seidel. 10943 10944 Fixes the following error when committing a file with 10945 "ChangeLog" in the name that isn't a ChangeLog (like 10946 mergeChangeLogs.pl from r56471 and r56472): 10947 10948 $ git commit . 10949 Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at commit-log-editor line 132. 10950 error: There was a problem with the editor 'commit-log-editor'. 10951 Please supply the message using either -m or -F option. 10952 10953 * Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to 10954 the end of the file name when searching for ChangeLog files in a 10955 commit. 10956 109572010-03-24 David Kilzer <ddkilzer@apple.com> 10958 10959 <http://webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if ChangeLog can't be merged 10960 10961 Reviewed by Eric Seidel. 10962 10963 * Scripts/resolve-ChangeLogs: Switched to exec git-merge-file if 10964 the merge attempt fails. 10965 109662010-03-24 Adam Barth <abarth@webkit.org> 10967 10968 Reviewed by Eric Seidel. 10969 10970 webkit-patch or pre-commit hook should validate reviewer lines before committing 10971 https://bugs.webkit.org/show_bug.cgi?id=26927 10972 10973 Validate that patches have valid reivewers listed in their ChangeLogs 10974 before landing. For patches without reviewers can be landed if their 10975 ChangeLogs state that they are unreviewed. 10976 10977 * Scripts/webkitpy/changelogs.py: 10978 * Scripts/webkitpy/commands/download.py: 10979 * Scripts/webkitpy/commitinfo.py: 10980 * Scripts/webkitpy/commitinfo_unittest.py: 10981 * Scripts/webkitpy/mock_bugzillatool.py: 10982 * Scripts/webkitpy/steps/__init__.py: 10983 * Scripts/webkitpy/steps/validatereviewer.py: Added. 10984 109852010-03-19 Holger Hans Peter Freyther <zecke@selfish.org> 10986 10987 Reviewed by David Levin. 10988 10989 Undefined names reported by pyflakes in python scripts 10990 https://bugs.webkit.org/show_bug.cgi?id=36403 10991 10992 Attempt to use names that exist or can exist in the lexical 10993 scope instead of not being available at all. 10994 10995 * Scripts/webkitpy/changelogs.py: Use self._content. 10996 * Scripts/webkitpy/layout_tests/port/base.py: Use os.stat 10997 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Use self._port 10998 * Scripts/webkitpy/style/processors/cpp_unittest.py: Use expected_message_re 10999 110002010-03-24 David Kilzer <ddkilzer@apple.com> 11001 11002 <http://webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeLogs can't merge 11003 11004 Reviewed by Eric Seidel. 11005 11006 When resolve-ChangeLogs fails to merge a patch while running as 11007 a git merge driver, it deletes the original file, which causes 11008 an internal failure and stops git mid-merge: 11009 11010 fatal: Failed to execute internal merge 11011 11012 The fix is to use the --force switch with patch so that it will 11013 always attempt to apply the patch. (The change in 11014 mergeChangeLogs() for the previous commit also fixed this, but 11015 adding --force also prevents any potential user interaction that 11016 patch may want to display.) 11017 11018 * Scripts/VCSUtils.pm: 11019 (mergeChangeLogs): Added --force switch to patch command. Also 11020 changed to use the exit status from the patch command to 11021 determine the return value for this method. 11022 * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added 11023 test to cover this bug. 11024 110252010-03-24 David Kilzer <ddkilzer@apple.com> 11026 11027 <http://webkit.org/b/36560> resolve-ChangeLogs: move mergeChanges() into VCSUtils package 11028 11029 Reviewed by Eric Seidel. 11030 11031 * Scripts/VCSUtils.pm: 11032 (mergeChangeLogs): Copied from mergeChanges() in 11033 resolve-ChangeLogs and renamed. Added method documentation. 11034 Fixed bug found by new tests where the original file to be 11035 patched was deleted when cleaning up after a traditinal rejected 11036 patch failed to apply. 11037 * Scripts/resolve-ChangeLogs: Switched to using 11038 mergeChangeLogs(). 11039 (mergeChanges): Moved to VCSUtils.pm and renamed to 11040 mergeChangeLogs(). 11041 * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added. 11042 110432010-03-24 Eric Seidel <eric@webkit.org> 11044 11045 Reviewed by Adam Barth. 11046 11047 Add support for qt's unassigned list to webkit-patch assign-to-committer 11048 https://bugs.webkit.org/show_bug.cgi?id=36559 11049 11050 * Scripts/webkitpy/bugzilla.py: 11051 - Move Bugzilla.unassigned_email into Bug and make it a set. 11052 * Scripts/webkitpy/bugzilla_unittest.py: 11053 - Test the new Bug.is_unassigned method 11054 * Scripts/webkitpy/commands/upload.py: 11055 - Use the new Bug.is_unassigned method instead of an explicit == 11056 * Scripts/webkitpy/mock_bugzillatool.py: 11057 - Bugzilla.unassigned_email no longer needs mocking 11058 110592010-03-24 Kent Hansen <kent.hansen@nokia.com> 11060 11061 Reviewed by Simon Hausmann. 11062 11063 [Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled 11064 https://bugs.webkit.org/show_bug.cgi?id=36522 11065 11066 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 11067 (LayoutTestController::setXSSAuditorEnabled): Use the new name. 11068 110692010-03-24 Chris Jerdonek <cjerdonek@webkit.org> 11070 11071 Reviewed by Shinichiro Hamaji. 11072 11073 Added to check-webkit-style support for a --debug flag. 11074 11075 https://bugs.webkit.org/show_bug.cgi?id=36100 11076 11077 The --debug flag adjusts the logging level to DEBUG and 11078 includes the logger name and level in each log message. 11079 11080 * Scripts/check-webkit-style: 11081 - Changed the code to check for the --debug flag and pass 11082 the result to the configure_logging() method. 11083 * Scripts/webkitpy/style/checker.py: 11084 - Added an is_debug parameter to configure_logging(). 11085 - Refactored configure_logging() by adding calls to 11086 the following two methods: _create_log_handlers() and 11087 _create_debug_log_handlers(). 11088 * Scripts/webkitpy/style/checker_unittest.py: 11089 - Added unit tests for configure_logging() with is_debug True 11090 by splitting the ConfigureLoggingTest class into 11091 ConfigureLoggingTest and ConfigureLoggingTestBase, and 11092 adding ConfigureLoggingDebugTest. 11093 * Scripts/webkitpy/style/optparser.py: 11094 - Updated the usage string. 11095 - Added an is_debug data attribute to the CommandOptionValues 11096 class. 11097 - Added support for the --debug flag to the ArgumentParser.parse() 11098 method. 11099 - Also added extra error information to the parse() method in 11100 the case of an invalid flag. 11101 * Scripts/webkitpy/style/optparser_unittest.py: 11102 - Updated the unit tests as necessary. 11103 - Also fixed an issue with the CommandOptionValuesTest.test_eq() 11104 unit test. 11105 111062010-03-23 Kent Tamura <tkent@chromium.org> 11107 11108 Reviewed by Dimitri Glazkov. 11109 11110 [DRT/Chromium] Add TestNavigationController and TestWebWorker 11111 https://bugs.webkit.org/show_bug.cgi?id=36489 11112 11113 Add TestNavigationController and TestWebWorker classes, which are 11114 going to be used by DumpRenderTree Chromium port. These files are 11115 based on: 11116 - src/webkit/tools/test_shell/test_navigation_controller.{cc,h} 11117 - src/webkit/tools/test_shell/test_web_worker.h 11118 of Chromium rev.40492. 11119 11120 TestNavigationController has non-style changes. 11121 - Change ContentState type: binary string -> WebHistoryItem 11122 - Remove TestShell dependency by introducing NavigationHost interface. 11123 11124 * DumpRenderTree/chromium/TestNavigationController.cpp: Added. 11125 * DumpRenderTree/chromium/TestNavigationController.h: Added. 11126 * DumpRenderTree/chromium/TestWebWorker.h: Added. 11127 111282010-03-23 Eric Seidel <eric@webkit.org> 11129 11130 Reviewed by Adam Barth. 11131 11132 Add support for revision -> build lookup in buildbot.py and layout test result parsing 11133 https://bugs.webkit.org/show_bug.cgi?id=36474 11134 11135 * Scripts/webkitpy/bugzilla_unittest.py: Added a FIXME about sharing code. 11136 * Scripts/webkitpy/buildbot.py: 11137 - Add support for looking up builds by revision number. 11138 - Add support for fetching and parsing results.html files from buildbot. 11139 - build_for_revision has an allow_failed_lookups option to work around the fact that 11140 our buildbot's xmlrpc calls return failure on old revision numbers. 11141 - Add parsing support for twisted directory listings. 11142 * Scripts/webkitpy/buildbot_unittest.py: 11143 - Unit test all the new code. 11144 * Scripts/webkitpy/commands/queries.py: 11145 - Add a new results-for command which prints all the results for a given revision (very slow due to slow revision lookup) 11146 111472010-03-23 Daniel Bates <dbates@rim.com> 11148 11149 Reviewed by Adam Roben. 11150 11151 https://bugs.webkit.org/show_bug.cgi?id=36048 11152 11153 Detect if the Windows Platform SDK is missing when building with 11154 Visual C++ Express Edition and inform the user to download it. 11155 11156 * Scripts/webkitdirs.pm: 11157 111582010-03-23 Darin Adler <darin@apple.com> 11159 11160 Tell Subversion about more directories that expect to have .pyc files. 11161 11162 * Scripts/webkitpy: Modified property svn:ignore. 11163 * Scripts/webkitpy/irc: Added property svn:ignore. 11164 111652010-03-23 Daniel Bates <dbates@rim.com> 11166 11167 Reviewed by Adam Barth. 11168 11169 https://bugs.webkit.org/show_bug.cgi?id=36149 11170 11171 Import the GNU readline interface to modify the behavior 11172 of raw_input so as to provide line editing support. In 11173 particular this will prevent "delete" characters from 11174 appearing in the returned value for function raw_input. 11175 11176 * Scripts/webkitpy/user.py: 11177 111782010-03-23 Laszlo Gombos <laszlo.1.gombos@nokia.com> 11179 11180 Reviewed by Kenneth Rohde Christiansen. 11181 11182 [Qt] Remove support for Qt v4.4 11183 https://bugs.webkit.org/show_bug.cgi?id=36389 11184 11185 * DumpRenderTree/qt/main.cpp: 11186 (main): 11187 * QtLauncher/mainwindow.cpp: 11188 (MainWindow::MainWindow): 11189 111902010-03-22 Csaba Osztrogonác <ossy@webkit.org> 11191 11192 Reviewed by Adam Barth. 11193 11194 Make build_webkit_command() pass MAKEFLAGS environment variable to make. 11195 https://bugs.webkit.org/show_bug.cgi?id=36440 11196 11197 * Scripts/webkitpy/webkitport.py: 11198 * Scripts/webkitpy/webkitport_unittest.py: 11199 112002010-03-22 Dirk Pranke <dpranke@chromium.org> 11201 11202 Reviewed by Dimitri Glazkov. 11203 11204 Change baseline_path() to point to the upstream locations for the 11205 Chromium ports. Also change the reabselining scripts to use the 11206 correct functions to get the baseline directories, and fix the 11207 script's sys.path to pull in simplejson correctly. 11208 11209 https://bugs.webkit.org/show_bug.cgi?id=36417 11210 11211 * Scripts/rebaseline-chromium-webkit-tests: 11212 - fix sys.path to pick up simplejson properly 11213 * Scripts/webkitpy/layout_tests/port/chromium.py: 11214 - change baseline_path() to use webkit_baseline_path() 11215 - error out correctly if we can't find the chromium base dir 11216 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 11217 - call baseline_path(), not chromium_baseline_path() 11218 112192010-03-22 Chris Jerdonek <cjerdonek@webkit.org> 11220 11221 Reviewed by Adam Barth. 11222 11223 Refactored the cpu_count() code in executive.py. 11224 11225 https://bugs.webkit.org/show_bug.cgi?id=36437 11226 11227 * Scripts/webkitpy/executive.py: 11228 - Moved the import of the multiprocessing module to the top 11229 of the file rather than importing from within a function. 11230 112312010-03-22 Antonio Gomes <tonikitoo@webkit.org> 11232 11233 Unreviewed. 11234 11235 Rolling out r56183: http://trac.webkit.org/changeset/56183 11236 11237 https://bugs.webkit.org/show_bug.cgi?id=36244 11238 11239 Need to roll out because this patch will be re-worked by the author 11240 and other reviewers agreed on it. 11241 112422010-03-22 Chris Jerdonek <cjerdonek@webkit.org> 11243 11244 Reviewed by Adam Barth. 11245 11246 Created a function for getting a module-specific logging.logger 11247 based on the __file__ value of the module. 11248 11249 https://bugs.webkit.org/show_bug.cgi?id=35821 11250 11251 This function allows us to get the module-specific logger for 11252 a module without having to hard-code the fully-qualified name 11253 of the module in the module itself. The code can be the same 11254 in every case: "_log = logutils.get_logger(__file__)". 11255 11256 * Scripts/webkitpy/init/logutils.py: Added. 11257 - Added a module with a get_logger() function to return 11258 a module-specific logger based on the module's __file__ 11259 variable. 11260 11261 * Scripts/webkitpy/init/logutils_unittest.py: Added. 11262 - Added unit tests for logutils.py. 11263 11264 * Scripts/webkitpy/init/unittests.py: 11265 - Added logutils_unittest to the list of imports. 11266 112672010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org> 11268 11269 Reviewed by Simon Hausmann. 11270 11271 [Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes 11272 https://bugs.webkit.org/show_bug.cgi?id=36386 11273 11274 Fix the regression by implementing a null printer for Qt DRT. 11275 11276 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 11277 (WebCore::NullPrinter::NullPaintEngine::begin): 11278 (WebCore::NullPrinter::NullPaintEngine::end): 11279 (WebCore::NullPrinter::NullPaintEngine::type): 11280 (WebCore::NullPrinter::NullPaintEngine::drawPixmap): 11281 (WebCore::NullPrinter::NullPaintEngine::updateState): 11282 (WebCore::NullPrinter::paintEngine): 11283 (WebCore::DumpRenderTree::dryRunPrint): 11284 112852010-03-20 Martin Robinson <mrobinson@webkit.org> 11286 11287 Reviewed by Xan Lopez. 11288 11289 [GTK] eventSender.zoomPageOut() bug? 11290 https://bugs.webkit.org/show_bug.cgi?id=30575 11291 11292 Make zoomPage{In/Out}Callback respect the 1.2f zoom factor that DRT should be using. 11293 11294 * DumpRenderTree/gtk/EventSender.cpp: 11295 (zoomIn): Added. 11296 (zoomOut): Added. 11297 (textZoomInCallback): Use zoomIn helper function. 11298 (textZoomOutCallback): Use zoomOut helper function. 11299 (zoomPageInCallback): Use zoomIn helper function, which respects zoom factor. 11300 (zoomPageOutCallback): Use zoomOut helper function, which respects zoom factor. 11301 113022010-03-20 Kevin Ollivier <kevino@theolliviers.com> 11303 11304 [wx] Build fix after recent database API change. 11305 11306 * wx/browser/browser.cpp: 11307 (MyApp::OnInit): 11308 113092010-03-20 Chris Jerdonek <cjerdonek@webkit.org> 11310 11311 Reviewed by Adam Barth. 11312 11313 Renamed UnitTestLogStream to TestLogStream in webkitpy. 11314 11315 https://bugs.webkit.org/show_bug.cgi?id=36099 11316 11317 TestLogStream is more concise and more consistent with the name of 11318 the module (logtesting rather than logunittesting) and its main 11319 class (LogTesting rather than LogUnitTesting). 11320 11321 * Scripts/webkitpy/init/logtesting.py: 11322 - Renamings. 11323 11324 * Scripts/webkitpy/style/checker_unittest.py: 11325 - Renamings. 11326 11327 * Scripts/webkitpy/style_references.py: 11328 - Renamings. 11329 113302010-03-20 Kevin Ollivier <kevino@theolliviers.com> 11331 11332 [wx] Build fixes for new method in LayoutTestController. 11333 11334 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 11335 (LayoutTestController::setSpatialNavigationEnabled): 11336 * wx/build/settings.py: 11337 113382010-03-20 Dimitri Glazkov <dglazkov@chromium.org> 11339 11340 Unreviewed, tool fix. 11341 11342 Remove vestiges of downstream directory names to unbreak rebaselining tool. 11343 11344 * Scripts/webkitpy/layout_tests/port/chromium.py: Changed paths to use WebKit repo. 11345 113462010-03-20 Dirk Pranke <dpranke@chromium.org> 11347 11348 Reviewed by Dimitri Glazkov. 11349 11350 Re-enable the downstream test_expectations overrides file that was 11351 disabled in bug 36396 / r56287. 11352 11353 https://bugs.chromium.org/show_bug.cgi?id=36401 11354 11355 * Scripts/webkitpy/layout_tests/port/chromium.py: 11356 113572010-03-19 Dirk Pranke <dpranke@chromium.org> 11358 11359 Reviewed by Dimitri Glazkov. 11360 11361 Disable the downstream override expectations temporarily to allow 11362 us to test that we've upstreamed everything correctly. Also, stop 11363 looking at the downstream baselines at all (now you will only be 11364 able to update baselines upstream). In theory this should work, but 11365 if we need to we can always add the downstream dirs back in. 11366 11367 https://bugs.webkit.org/show_bug.cgi?id=36396 11368 11369 * Scripts/webkitpy/layout_tests/port/chromium.py: 11370 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 11371 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 11372 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 11373 113742010-03-19 Dirk Pranke <dpranke@chromium.org> 11375 11376 Reviewed by Dimitri Glazkov. 11377 11378 fix typo in chromium test expectations overrides routine 11379 https://bugs.webkit.org/show_bug.cgi?id=36397 11380 11381 * Scripts/webkitpy/layout_tests/port/chromium.py: 11382 113832010-03-19 Dirk Pranke <dpranke@chromium.org> 11384 11385 Reviewed by Dimitri Glazkov. 11386 11387 Flip the Chromium ports to look first for the test expectations 11388 in LayoutTests/platform/chromium and only afterwards look in the 11389 Chromium repo downstream for overrides. 11390 11391 https://bugs.webkit.org/show_bug.cgi?id=36326 11392 11393 * Scripts/webkitpy/layout_tests/port/chromium.py: 11394 113952010-03-19 James Hawkins <jhawkins@chromium.org> 11396 11397 Unreviewed. 11398 11399 Add myself to the committers list. 11400 11401 * Scripts/webkitpy/committers.py: 11402 114032010-03-19 Adam Barth <abarth@webkit.org> 11404 11405 Unreviewed. 11406 11407 Fix SheriffBot exception lock when we can't retrieve the first build 11408 from buildbot. (I'll ask Eric to review this change after the fact, 11409 but he's at lunch and I want to get the bot unlocked.) 11410 11411 * Scripts/webkitpy/buildbot.py: 11412 * Scripts/webkitpy/buildbot_unittest.py: 11413 114142010-03-19 Alexey Proskuryakov <ap@apple.com> 11415 11416 Reviewed by Darin Adler. 11417 11418 https://bugs.webkit.org/show_bug.cgi?id=36380 11419 websocket/tests/frame-lengths.html times out on Tiger bot 11420 11421 https://bugs.webkit.org/show_bug.cgi?id=35041 11422 websocket/tests/frame-lengths.html / websocket/tests/simple-stress.html fail on Windows bot 11423 11424 Double the timeout (from 15 seconds to 30 seconds). We can increase it more, if necessary - 11425 sampling the DRT process on Mac OS X takes much longer anyway, so it's better to avoid 11426 timing out than to detect it early. 11427 11428 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 11429 (LayoutTestController::setWaitToDump): 11430 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 11431 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 11432 (LayoutTestController::waitUntilDone): 11433 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 11434 * Scripts/run-webkit-tests: 11435 114362010-03-19 Laszlo Gombos <laszlo.1.gombos@nokia.com> 11437 11438 Unreviewed. 11439 11440 Buildfix for Qt v4.5. 11441 11442 * QtLauncher/main.cpp: 11443 (LauncherWindow::LauncherWindow): 11444 (LauncherWindow::applyZoom): 11445 114462010-03-19 Adam Barth <abarth@webkit.org> 11447 11448 Reviewed by Eric Seidel. 11449 11450 Operational tweaks to SheriffBot 11451 https://bugs.webkit.org/show_bug.cgi?id=36385 11452 11453 These changes aren't pretty, but they're helpful to make SheriffBot 11454 work operationally. I plan to iterate in these areas, but I wanted to 11455 get this patch landed so I could be running the bot against TOT. 11456 11457 * Scripts/webkitpy/commands/sheriffbot.py: 11458 * Scripts/webkitpy/irc/ircbot.py: 11459 * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: 11460 114612010-03-19 Eric Seidel <eric@webkit.org> 11462 11463 Reviewed by Adam Barth. 11464 11465 Help sheriff-bot avoid warning about flaky tests (and add more unit testing) 11466 https://bugs.webkit.org/show_bug.cgi?id=36354 11467 11468 * Scripts/webkitpy/buildbot.py: 11469 - Make Build creation easier to Mock and test 11470 * Scripts/webkitpy/buildbot_unittest.py: 11471 - Test finding green to red transitions and suspect revisions 11472 * Scripts/webkitpy/commands/queries.py: 11473 - Make what-broke note when builders have only failed once. 11474 114752010-03-19 Dirk Pranke <dpranke@chromium.org> 11476 11477 Reviewed by Dimitri Glazkov. 11478 11479 Fix the rebaselining tool, which was broken by r36324 when I 11480 added the concept of overridding expectations. 11481 11482 https://bugs.webkit.org/show_bug.cgi?id=36374 11483 11484 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 11485 114862010-03-19 Adam Barth <abarth@webkit.org> 11487 11488 Reviewed by Eric Seidel. 11489 11490 Misc bug fixes to make the SheriffBot actually work 11491 https://bugs.webkit.org/show_bug.cgi?id=36355 11492 11493 With these changes, I can actually run the sheriff-bot from start to 11494 finish. 11495 11496 * Scripts/webkitpy/irc/ircproxy.py: 11497 * Scripts/webkitpy/patch/patcher.py: 11498 * Scripts/webkitpy/statusserver.py: 11499 115002010-03-19 Adam Barth <abarth@webkit.org> 11501 11502 Unreviewed. 11503 11504 Actually import the sheriff-bot command so we can run it. Also, move 11505 the bot to #webkit-test so it doesn't cause a ruckus while we test it. 11506 11507 * Scripts/webkitpy/patch/patcher.py: 11508 * Scripts/webkitpy/irc/ircbot.py: 11509 115102010-03-19 Adam Barth <abarth@webkit.org> 11511 11512 Reviewed by Eric Seidel. 11513 11514 Second cut at SheriffBot 11515 https://bugs.webkit.org/show_bug.cgi?id=36353 11516 11517 This patch should contain a complete SheriffBot that's capable of 11518 saying reasonable things on IRC. I had to refactor the use of 11519 CommitInfo to make the SheriffBot testable, but I did the minimum 11520 necessary. We should grow webkitcheckout over time to contain the 11521 knowledge of ChangeLogs from scm. 11522 11523 * Scripts/webkitpy/commands/sheriffbot.py: 11524 * Scripts/webkitpy/commands/sheriffbot_unittest.py: 11525 * Scripts/webkitpy/mock_bugzillatool.py: 11526 * Scripts/webkitpy/patch/patcher.py: 11527 * Scripts/webkitpy/webkitcheckout.py: Added. 11528 115292010-03-19 Adam Barth <abarth@webkit.org> 11530 11531 Unreviewed. 11532 11533 Fix Hyatt's IRC nickname. 11534 11535 * Scripts/webkitpy/committers.py: 11536 115372010-03-19 Adam Barth <abarth@webkit.org> 11538 11539 Unreviewed. 11540 11541 Add IRC nicknames for the non-reviewer committers. 11542 11543 * Scripts/webkitpy/committers.py: 11544 115452010-03-19 Adam Barth <abarth@webkit.org> 11546 11547 Unreviewed. 11548 11549 More reviewer IRC nicknames. 11550 11551 * Scripts/webkitpy/committers.py: 11552 115532010-03-19 Adam Barth <abarth@webkit.org> 11554 11555 Unreviewed. 11556 11557 Add a bunch of IRC nicknames for reviewers. 11558 11559 * Scripts/webkitpy/committers.py: 11560 115612010-03-19 Zoltan Horvath <zoltan@webkit.org> 11562 11563 Reviewed by Oliver Hunt. 11564 11565 Added USE_SYSTEM_MALLOC flag to build-webkit 11566 https://bugs.webkit.org/show_bug.cgi?id=21272 11567 11568 Add system-alloc flag to build-webkit. It makes easy to switch 11569 between system allocator and TCmalloc. 11570 11571 * Scripts/build-webkit: 11572 115732010-03-19 Adam Barth <abarth@webkit.org> 11574 11575 Unreviewed "build" fix. 11576 11577 Of course, I caused a regression in the file that isn't tested. :( 11578 11579 * Scripts/webkitpy/statusserver.py: 11580 115812010-03-19 Eric Seidel <eric@webkit.org> 11582 11583 Reviewed by Adam Barth. 11584 11585 Add basic "who-broke-it" command and revision -> broken builder association code 11586 https://bugs.webkit.org/show_bug.cgi?id=36352 11587 11588 The "what-broke" command prints builders and what revisions we suspect 11589 broke them. who-broke-it prints revisions and what builders we suspect 11590 they broke. The sheriff-bot needs this revision to broken builder mapping 11591 so this change adds it! 11592 11593 * Scripts/webkitpy/buildbot.py: 11594 * Scripts/webkitpy/commands/queries.py: 11595 115962010-03-19 Eric Seidel <eric@webkit.org> 11597 11598 Reviewed by Adam Barth. 11599 11600 Simplify BuildBot core builder code for easier re-use 11601 https://bugs.webkit.org/show_bug.cgi?id=36350 11602 11603 I simply couldn't see anything through all this Yak-hair. 11604 11605 * Scripts/webkitpy/buildbot.py: 11606 * Scripts/webkitpy/commands/queries.py: 11607 116082010-03-19 Adam Barth <abarth@webkit.org> 11609 11610 Reviewed by Eric Seidel. 11611 11612 committers.py should know IRC nicknames 11613 https://bugs.webkit.org/show_bug.cgi?id=36349 11614 11615 I'll add the actual nicknames in another patch. 11616 11617 * Scripts/webkitpy/committers.py: 11618 * Scripts/webkitpy/committers_unittest.py: 11619 116202010-03-18 Anders Bakken <agbakken@gmail.com> 11621 11622 Reviewed by Simon Hausmann. 11623 11624 https://bugs.webkit.org/show_bug.cgi?id=36318 11625 11626 QtLauncher runs as a GuiClient by default in Qt Embedded which will 11627 make it try to connect to an existing GuiServer. This patch makes it 11628 run like a stand-alone app. 11629 11630 * QtLauncher/main.cpp: 11631 (LauncherApplication::LauncherApplication): 11632 116332010-03-19 Eric Seidel <eric@webkit.org> 11634 11635 Reviewed by Adam Barth. 11636 11637 Move find_green_to_red_transition out of "what-broke" onto Builder for easier re-use 11638 https://bugs.webkit.org/show_bug.cgi?id=36345 11639 11640 * Scripts/webkitpy/buildbot.py: 11641 * Scripts/webkitpy/commands/queries.py: 11642 116432010-03-19 Adam Barth <abarth@webkit.org> 11644 11645 Reviewed by Adam Barth. 11646 11647 Actually pass the IRC password to the IRC object 11648 https://bugs.webkit.org/show_bug.cgi?id=36346 11649 11650 I wanted to do this before, but both patches were in flight. This 11651 patch finally closes the loop and makes the IRCProxy system complete. 11652 11653 * Scripts/webkitpy/patch/patcher.py: 11654 116552010-03-18 Adam Barth <abarth@webkit.org> 11656 11657 Reviewed by Eric Seidel. 11658 11659 Add a StatusServer front end to the SVNRevision table on QueueStatusServer 11660 https://bugs.webkit.org/show_bug.cgi?id=36344 11661 11662 No test because Browser was too hard to mock. :( I couldn't figure 11663 out how to make Mock be a dictionary as well as an object. 11664 11665 * Scripts/webkitpy/statusserver.py: 11666 116672010-03-18 Eric Seidel <eric@webkit.org> 11668 11669 Reviewed by Adam Barth. 11670 11671 Split out CommitInfo class and add unit tests 11672 https://bugs.webkit.org/show_bug.cgi?id=36343 11673 11674 Move more logic out of "what-broke" into a shared CommitInfo 11675 class so that it can be used by other commands and unit tested. 11676 11677 * Scripts/webkitpy/commands/queries.py: 11678 * Scripts/webkitpy/commitinfo.py: Added. 11679 * Scripts/webkitpy/commitinfo_unittest.py: Added. 11680 * Scripts/webkitpy/unittests.py: 11681 116822010-03-18 Laszlo Gombos <laszlo.1.gombos@nokia.com> 11683 11684 Reviewed by Kenneth Rohde Christiansen. 11685 11686 [Qt] Fix LayoutTests/http/tests/appcache/max-size.html 11687 https://bugs.webkit.org/show_bug.cgi?id=36207 11688 11689 Implement setAppCacheMaximumSize() for Qt. 11690 11691 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 11692 (LayoutTestController::setAppCacheMaximumSize): 11693 * DumpRenderTree/qt/LayoutTestControllerQt.h: 11694 116952010-03-18 Adam Barth <abarth@webkit.org> 11696 11697 Reviewed by Eric Seidel. 11698 11699 QueueStatusServer should be able to log broken bots 11700 https://bugs.webkit.org/show_bug.cgi?id=36341 11701 11702 We need to add a new table to the QueueStatusServer to store persistent 11703 information for the SheriffBot. The new table will keep track of which 11704 bots each SVN revision broke. 11705 11706 * QueueStatusServer/handlers/__init__.py: 11707 * QueueStatusServer/handlers/svnrevision.py: Added. 11708 * QueueStatusServer/handlers/updatebase.py: Added. 11709 * QueueStatusServer/handlers/updatestatus.py: 11710 * QueueStatusServer/handlers/updatesvnrevision.py: Added. 11711 * QueueStatusServer/index.yaml: 11712 * QueueStatusServer/main.py: 11713 * QueueStatusServer/model/__init__.py: 11714 * QueueStatusServer/model/svnrevision.py: Added. 11715 * QueueStatusServer/templates/updatesvnrevision.html: Added. 11716 117172010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org> 11718 11719 Reviewed by Darin Adler. 11720 11721 Add a new method to the Qt LayoutTestController for 11722 changing media type and make the DRT support dry-run printing. 11723 11724 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 11725 (WebCore::DumpRenderTree::DumpRenderTree): 11726 (WebCore::DumpRenderTree::dryRunPrint): 11727 * DumpRenderTree/qt/DumpRenderTreeQt.h: 11728 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 11729 (LayoutTestController::setMediaType): 11730 * DumpRenderTree/qt/LayoutTestControllerQt.h: 11731 117322010-03-18 Dirk Pranke <dpranke@chromium.org> 11733 11734 Reviewed by Dimitri Glazkov. 11735 11736 Add upstream LayoutTests/platform/chromium* directories to the 11737 baseline search path for new-run-webkit-tests in preparation for 11738 upstreaming all of the Chromium baselines. Note that this does 11739 not actually create the directories themselves, but that's okay. 11740 11741 https://bugs.webkit.org/show_bug.cgi?id=36324 11742 11743 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 11744 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 11745 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 11746 117472010-03-18 Alexey Proskuryakov <ap@apple.com> 11748 11749 Reviewed by Anders Carlsson. 11750 11751 https://bugs.webkit.org/show_bug.cgi?id=36327 11752 Test that a plug-in can override Node methods of its element 11753 11754 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 11755 (normalizeOverride): 11756 (pluginInvoke): 11757 Override "normalize", and call back to let a test know that the plug-in was called. 11758 117592010-03-17 Dirk Pranke <dpranke@chromium.org> 11760 11761 Reviewed by Dimitri Glazkov. 11762 11763 Add the concept of an "overrides" file for expectations so that we 11764 can store test_expectations both upstream and downstream for a port 11765 that runs both in webkit.org and in a separate repository (like 11766 Chromium). Also add some unit tests for the expectations module. 11767 11768 https://bugs.webkit.org/show_bug.cgi?id=36249 11769 11770 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 11771 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: Added. 11772 * Scripts/webkitpy/layout_tests/port/base.py: 11773 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 11774 117752010-03-18 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 11776 11777 Reviewed by Kenneth Rohde Christiansen. 11778 11779 Add an overlay QGraphicsTextItem to QtLauncher so we can display FPS info 11780 on the launcher and not on the terminal anymore. 11781 11782 [Qt] QtLauncher's FPS info should be displayed on an overlay text item 11783 https://bugs.webkit.org/show_bug.cgi?id=36244 11784 11785 * QtLauncher/webview.cpp: 11786 (WebViewGraphicsBased::WebViewGraphicsBased): 11787 (WebViewGraphicsBased::setFrameRateMeasurementEnabled): 11788 (WebViewGraphicsBased::updateFrameRate): 11789 * QtLauncher/webview.h: 11790 117912010-03-18 Adam Barth <abarth@webkit.org> 11792 11793 Reviewed by Eric Seidel. 11794 11795 First cut at SheriffBot 11796 https://bugs.webkit.org/show_bug.cgi?id=36253 11797 11798 This patch contains a first attempt at writing a sheriff bot. 11799 Currently, we're missing the logic that actually finds the SVN revision 11800 numbers to complain about, but once we have that, we'll have the rest 11801 of the infrustructure to ping IRC and to file bugs. 11802 11803 There's a lot to fill in for the SheriffBot, but this patch give us the 11804 framework in which to do it. 11805 11806 This patch required a bit of refactoring of AbstractQueue because 11807 SheriffBot is the first bot that doesn't process patches (it processes 11808 SVN revisions). Accordingly, I've factored out AbstractPatchQueue to 11809 hold the parts of AbstractQueue that are specific to dealing with 11810 patches. Some of the choices here might not be obvious yet, but we can 11811 tweak them as our needs become clearer. 11812 11813 * Scripts/webkitpy/commands/queues.py: 11814 * Scripts/webkitpy/commands/queues_unittest.py: 11815 * Scripts/webkitpy/commands/sheriffbot.py: Added. 11816 * Scripts/webkitpy/commands/sheriffbot_unittest.py: Added. 11817 * Scripts/webkitpy/mock_bugzillatool.py: 11818 Added a MockIRC object to the mock tool. 11819 * Scripts/webkitpy/multicommandtool.py: 11820 Added a finalize method so the tool can disconnect from IRC 11821 cleanly instead of just droping the socket. 11822 * Scripts/webkitpy/multicommandtool_unittest.py: 11823 * Scripts/webkitpy/patch/patcher.py: 11824 Added support for talking to IRC. 11825 * Scripts/webkitpy/unittests.py: 11826 We should add a commands/unittests.py file at some point to make 11827 the commands module more self-contained. 11828 118292010-03-18 Antti Koivisto <koivisto@iki.fi> 11830 11831 Reviewed by Kenneth Rohde Christiansen. 11832 11833 https://bugs.webkit.org/show_bug.cgi?id=36102 11834 [Qt] Scaling control API for tiled backing store 11835 11836 Add animated smooth zooming to Qt launcher when in tiled mode. 11837 11838 * QtLauncher/main.cpp: 11839 (LauncherWindow::LauncherWindow): 11840 (LauncherWindow::zoomAnimationFinished): 11841 (LauncherWindow::applyZoom): 11842 (LauncherWindow::zoomIn): 11843 (LauncherWindow::zoomOut): 11844 * QtLauncher/webview.h: 11845 (WebViewGraphicsBased::graphicsWebView): 11846 118472010-03-18 Adam Barth <abarth@webkit.org> 11848 11849 Reviewed by Eric Seidel. 11850 11851 Support using IRC accounts with a password 11852 https://bugs.webkit.org/show_bug.cgi?id=36287 11853 11854 Add a global option to specify an IRC password so we can use the 11855 sheriffbot account (which needs a password). 11856 11857 * Scripts/webkitpy/irc/ircbot.py: 11858 * Scripts/webkitpy/irc/ircproxy.py: 11859 * Scripts/webkitpy/patch/patcher.py: 11860 118612010-03-18 Eric Seidel <eric@webkit.org> 11862 11863 Just fixing missing parenthesis typo, no review. 11864 11865 * Scripts/webkitpy/commands/queries.py: '%' has higher precedence than 'or', use parentheses. 11866 118672010-03-18 Alexey Proskuryakov <ap@apple.com> 11868 11869 Reviewed by Adam Roben and Anders Carlsson. 11870 11871 https://bugs.webkit.org/show_bug.cgi?id=36210 11872 plugins/resize-from-plugin.html fails on some platforms 11873 11874 Turns out that most platforms don't use "cross-platform" main.cpp. Copied code added for 11875 the test to their versions of the file. 11876 11877 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 11878 (webkit_test_plugin_set_window): 11879 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 11880 (NPP_SetWindow): 11881 118822010-03-18 Leandro Pereira <leandro@profusion.mobi> 11883 11884 Reviewed by Kenneth Rohde Christiansen. 11885 11886 Add support to run-launcher to open the EFL example browser. 11887 http://webkit.org/b/36181 11888 11889 * Scripts/webkitdirs.pm: 11890 * Scripts/run-launcher: 11891 118922010-03-18 Sergio Villar Senin <svillar@igalia.com> 11893 11894 Reviewed by Xan Lopez. 11895 11896 [GTK] Failing tests http/tests/misc/image-blocked-src-change.html 11897 & http/tests/misc/image-blocked-src-no-change.html 11898 https://bugs.webkit.org/show_bug.cgi?id=36227 11899 11900 * DumpRenderTree/gtk/DumpRenderTree.cpp: 11901 (webViewConsoleMessage): print only the file name instead of the 11902 whole URI when printing messages with local URI's 11903 119042010-03-18 Eric Seidel <eric@webkit.org> 11905 11906 Reviewed by Adam Barth. 11907 11908 Teach what-broke how to look up reviewer and author Committer objects by name 11909 https://bugs.webkit.org/show_bug.cgi?id=36264 11910 11911 * Scripts/webkitpy/commands/queries.py: 11912 - Add committer_by_name lookups for both reviewer and author 11913 - Improve printing in the cases where lookups fail. 11914 * Scripts/webkitpy/committers.py: 11915 - Add committer_by_name 11916 * Scripts/webkitpy/committers_unittest.py: 11917 - Test committer_by_name 11918 119192010-03-17 Adam Barth <abarth@webkit.org> 11920 11921 Reviewed by Eric Seidel. 11922 11923 create-rollout should actually fill out the description 11924 https://bugs.webkit.org/show_bug.cgi?id=36261 11925 11926 * Scripts/webkitpy/commands/download.py: 11927 The % operator was applied to the wrong string. 11928 * Scripts/webkitpy/commands/download_unittest.py: 11929 * Scripts/webkitpy/commands/upload_unittest.py: 11930 * Scripts/webkitpy/mock_bugzillatool.py: 11931 Add support for seeing what we actually do with create_bug. 11932 119332010-03-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 11934 11935 Reviewed by Kenneth Rohde Christiansen. 11936 11937 Accelerated Compositing is now default on QtWebKit so the option 11938 in QtLauncher must be true as default. 11939 11940 [Qt] QtLauncher's Accelerated Compositing option must be true as default 11941 https://bugs.webkit.org/show_bug.cgi?id=36234 11942 11943 * QtLauncher/main.cpp: 11944 (LauncherWindow::applyPrefs): 11945 (LauncherWindow::toggleAcceleratedCompositing): 11946 (LauncherApplication::handleUserOptions): 11947 119482010-03-17 Adam Barth <abarth@webkit.org> 11949 11950 Reviewed by Eric Seidel. 11951 11952 Commit queue should ignore (probably red) builders when landing rollouts 11953 https://bugs.webkit.org/show_bug.cgi?id=36169 11954 11955 When landing a rollout, the builders are probably red, so we need to 11956 ignore them in the subprocess too. Also, we might as well update the 11957 working copy because we haven't validated anything about the current 11958 revision prior to trying to land. 11959 11960 This change is testable, but it requires changing the mock executive to 11961 log its arguments. That will generate a lot of expectation changes, so 11962 I'd like to do that in a separate patch. 11963 11964 * Scripts/webkitpy/commands/queues.py: 11965 119662010-03-17 Chang Shu <chang.shu@nokia.com> 11967 11968 Reviewed by Laszlo Gombos. 11969 11970 https://bugs.webkit.org/show_bug.cgi?id=36139 11971 [Qt] Clean up cache each time DumpRenderTree starts. This behavior 11972 matches other platforms, such as mac and gtk. 11973 11974 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 11975 (WebCore::DumpRenderTree::DumpRenderTree): 11976 119772010-03-17 Adam Barth <abarth@webkit.org> 11978 11979 Unreviewed. 11980 11981 Turns out this needs to be a string. 11982 11983 * Scripts/webkitpy/bugzilla.py: 11984 119852010-03-17 Eric Seidel <eric@webkit.org> 11986 11987 Reviewed by Adam Barth. 11988 11989 Add more infrastructure for sheriff-bot, including making what-broke more awesome 11990 https://bugs.webkit.org/show_bug.cgi?id=36254 11991 11992 * Scripts/webkitpy/bugzilla.py: 11993 - Made the various URL methods return None when passed None. 11994 * Scripts/webkitpy/bugzilla_unittest.py: 11995 - Test that the url methods work as expected. 11996 * Scripts/webkitpy/buildbot.py: 11997 - Add a static Build.build_url so that its possible to generate a build url without a Build object. 11998 - Give users a URL in _fetch_xmlrpc_build_dictionary error message. 11999 * Scripts/webkitpy/changelogs.py: 12000 - Add a new ChangeLogEntry class to encapsulate entry-parsing logic. 12001 - Add is_path_to_changelog to greatly simplify SCM.modified_changelogs code. 12002 - Make ChangeLog.parse_latest_entry_from_file a public method. 12003 * Scripts/webkitpy/changelogs_unittest.py: 12004 - Add tests for new ChangeLog entry parsing. 12005 * Scripts/webkitpy/commands/queries.py: 12006 - Make "what-broke" not print "ok" builders, only failing ones. 12007 - Print much more information on failing builders, including links and authorship/reviewer information. 12008 * Scripts/webkitpy/commands/queues_unittest.py: 12009 - Use a fake_checkout path since fixing the cwd (as part of fixing scm_unittests.py) was breaking tests. 12010 * Scripts/webkitpy/mock_bugzillatool.py: 12011 - Move MockSCM away from using os.getcwd() as that was fragile (and wrong). 12012 * Scripts/webkitpy/patch/patcher.py: 12013 - Remove code which was broken now that this file has moved. 12014 - Code was also redundant now that SCM.find_checkout_root() exists. 12015 * Scripts/webkitpy/scm.py: 12016 - Greatly simplify modified_changelogs now that I understand list comprehensions. 12017 - Expect ChangeLogEntry objects instead of raw strings. 12018 - Add changed_files_for_revision, committer_email_for_revision and contents_at_revision 12019 - Add commit_with_message argument to all sites since someone half-added it before. :( 12020 - Get rid of copy/paste code using _status_regexp() 12021 * Scripts/webkitpy/scm_unittest.py: 12022 - Fix these tests! 12023 - Add new tests for new scm code. 12024 - Fix spelling of "awsome" to "awesome". 12025 120262010-03-17 Daniel Bates <dbates@rim.com> 12027 12028 Rubber-stamped by David Levin. 12029 12030 Add myself to the list of reviewers. 12031 12032 * Scripts/webkitpy/committers.py: 12033 120342010-03-17 Adam Barth <abarth@webkit.org> 12035 12036 Reviewed by Eric Seidel. 12037 12038 Change post-rollout to create-rollout and have it make a new bug 12039 instead of posting the rollout to the old bug. 12040 https://bugs.webkit.org/show_bug.cgi?id=36250 12041 12042 The new bug blocks the old bug instead of adding more complexity to the 12043 old bug. One tricky question is whether to create the bug if we're 12044 unable to create a rollout patch. In this patch, we do create the bug, 12045 but we might revist this question in the future. 12046 12047 * Scripts/webkitpy/bugzilla.py: 12048 * Scripts/webkitpy/commands/download.py: 12049 * Scripts/webkitpy/commands/download_unittest.py: 12050 * Scripts/webkitpy/steps/createbug.py: 12051 120522010-03-17 Adam Barth <abarth@webkit.org> 12053 12054 Reviewed by Eric Seidel. 12055 12056 Add a way for the bots to send messages to IRC 12057 https://bugs.webkit.org/show_bug.cgi?id=36235 12058 12059 We'll use these classes to notify #webkit about bad SVN revisions. 12060 This patch just has some skeleton code for us to play with. 12061 12062 * Scripts/webkitpy/irc/__init__.py: Added. 12063 * Scripts/webkitpy/irc/ircbot.py: Added. 12064 A bot that knows how to talk to IRC. 12065 * Scripts/webkitpy/irc/ircproxy.py: Added. 12066 We need to run the bot on its own thread because the irclib needs 12067 its own mainloop. This class provides an abstraction of the 12068 threading. 12069 * Scripts/webkitpy/irc/messagepump.py: Added. 12070 * Scripts/webkitpy/irc/messagepump_unittest.py: Added. 12071 * Scripts/webkitpy/irc/threadedmessagequeue.py: Added. 12072 A thread-safe message queue for sending messages from the main 12073 thread to the IRC thread. 12074 * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Added. 12075 * Scripts/webkitpy/irc/unittests.py: Added. 12076 * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: 12077 Autoinstall irclib 12078 * Scripts/webkitpy/unittests.py: 12079 120802010-03-17 Victor Wang <victorw@chromium.org> 12081 12082 Reviewed by Dimitri Glazkov. 12083 12084 Fix image_diff syntax in webkitpy/port/base.py. 12085 The syntax is wrong if diff_filename is specified. 12086 12087 https://bugs.webkit.org/show_bug.cgi?id=36230 12088 12089 * Scripts/webkitpy/layout_tests/port/base.py: 12090 120912010-03-16 Diego Gonzalez <diego.gonzalez@openbossa.org> 12092 12093 Reviewed by Kenneth Christiansen. 12094 12095 Provide to QtLauncher a way to change the ViewportUpdateMode 12096 when it's in graphics based mode. 12097 12098 [Qt] Make QtLaucher able to select the ViewportUpdateMode 12099 https://bugs.webkit.org/show_bug.cgi?id=36175 12100 12101 * QtLauncher/main.cpp: 12102 (LauncherWindow::selectViewportUpdateMode): 12103 (LauncherWindow::createChrome): 12104 121052010-03-17 Zoltan Horvath <zoltan@webkit.org> 12106 12107 Reviewed by Darin Adler. 12108 12109 Ambiguous error message when building for unspecified platform 12110 https://bugs.webkit.org/show_bug.cgi?id=30203 12111 12112 Add an extra line information to the error message. 12113 12114 * Scripts/webkitdirs.pm: 12115 121162010-03-16 Adam Barth <abarth@webkit.org> 12117 12118 No review, rolling out r56044. 12119 http://trac.webkit.org/changeset/56044 12120 https://bugs.webkit.org/show_bug.cgi?id=36048 12121 12122 This patch broke Windows Debug (Tests) 12123 12124 * Scripts/webkitdirs.pm: 12125 121262010-03-16 John Abd-El-Malek <jam@chromium.org> 12127 12128 Reviewed by Darin Fisher. 12129 12130 Give keyboard focus to PluginDocuments by default 12131 https://bugs.webkit.org/show_bug.cgi?id=36147 12132 12133 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 12134 (pluginAllocate): 12135 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: 12136 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 12137 (NPP_New): 12138 (NPP_SetWindow): 12139 (handleEventCarbon): 12140 (handleEventCocoa): 12141 121422010-03-16 Sam Weinig <sam@webkit.org> 12143 12144 Reviewed by Mark Rowe. 12145 12146 Fix run-webkit-httpd on Windows. 12147 12148 * Scripts/webkitperl/httpd.pm: 12149 121502010-03-16 Alexey Proskuryakov <ap@apple.com> 12151 12152 Tiger build fix. 12153 12154 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): 12155 Added more type casts to shut down warnings. 12156 121572010-03-16 Alexey Proskuryakov <ap@apple.com> 12158 12159 Reviewed by Darin Adler. 12160 12161 https://bugs.webkit.org/show_bug.cgi?id=36184 12162 YouTube video resizing doesn't work with OOP plug-ins 12163 12164 Added a resizeTo() method, which calls resizePlugin() in JS with the same arguments, 12165 and a lastSetWindowArguments property, which returns a string describing the last NPWindow 12166 passed to NPN_SetWindow. 12167 12168 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 12169 (pluginGetProperty): 12170 (testResizeTo): 12171 (pluginInvoke): 12172 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: 12173 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 12174 (NPP_SetWindow): 12175 121762010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com> 12177 12178 Reviewed by Xan Lopez. 12179 12180 https://bugs.webkit.org/show_bug.cgi?id=35504 12181 [Gtk] Evaluate and fix AtkTable for layout tables 12182 12183 Implements rowCount and columnCount for Gtk in DRT. 12184 12185 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 12186 (AccessibilityUIElement::rowCount): 12187 (AccessibilityUIElement::columnCount): 12188 121892010-03-15 Eric Seidel <eric@webkit.org> 12190 12191 Reviewed by Adam Barth. 12192 12193 Add "what-broke" command for debugging when the tree broke 12194 https://bugs.webkit.org/show_bug.cgi?id=36157 12195 12196 This is another step towards automated sheriffing of the webkit tree. 12197 With this logic our scripts are able to determine what revision broke the 12198 tree. Buildbot should do this for us, but unfortunately buildbot doesn't 12199 expose this kind of aggregate information. 12200 12201 * Scripts/webkitpy/buildbot.py: 12202 - Add new Builder and Build classes (which will eventually replace the custom dictionaries previously used). 12203 - Split out more network logic into _fetch methods which will eventually be their own class for mocking. 12204 - Use XMLRPC to communicate with the buildbot master instead of scraping build pages. 12205 * Scripts/webkitpy/buildbot_unittest.py: 12206 - Test the newly added buildbot classes. 12207 * Scripts/webkitpy/commands/queries.py: 12208 - Add an experimental what-broke command. 12209 122102010-03-15 Daniel Bates <dbates@rim.com> 12211 12212 Reviewed by Eric Seidel. 12213 12214 https://bugs.webkit.org/show_bug.cgi?id=36048 12215 12216 Detect if the Windows Platform SDK is missing when building with 12217 Visual C++ Express Edition and inform the user to download it. 12218 12219 * Scripts/webkitdirs.pm: 12220 122212010-03-15 Adam Barth <abarth@webkit.org> 12222 12223 Reviewed by Eric Seidel. 12224 12225 Let commit-queue land rollout patches even when the tree is red 12226 https://bugs.webkit.org/show_bug.cgi?id=36155 12227 12228 Now the commit-queue will land patches whose name begins with "ROLLOUT " 12229 even if the tree is red. The patches still go through the usual build 12230 and test process, but they can be landed while the tree is on fire. 12231 12232 * Scripts/webkitpy/bugzilla.py: 12233 * Scripts/webkitpy/commands/queues.py: 12234 * Scripts/webkitpy/commands/queues_unittest.py: 12235 * Scripts/webkitpy/commands/queuestest.py: 12236 * Scripts/webkitpy/mock_bugzillatool.py: 12237 122382010-03-15 Adam Barth <abarth@webkit.org> 12239 12240 Reviewed by Eric Seidel. 12241 12242 Add webkit-patch post-rollout to upload rollouts to bugs.webkit.org for easy committing 12243 https://bugs.webkit.org/show_bug.cgi?id=36154 12244 12245 This new command is a mashup of prepare-rollout and post. This command 12246 will be used by an experimental bot to post rollouts of patches that 12247 break things to bugs.webkit.org where they can be landed with the 12248 greatest of ease. 12249 12250 * Scripts/webkitpy/commands/download.py: 12251 * Scripts/webkitpy/commands/download_unittest.py: 12252 * Scripts/webkitpy/steps/__init__.py: 12253 * Scripts/webkitpy/steps/postdiffforrevert.py: Added. 12254 122552010-03-15 Adam Barth <abarth@webkit.org> 12256 12257 Reviewed by Eric Seidel. 12258 12259 webkit-patch rollout should error out on conflicts 12260 https://bugs.webkit.org/show_bug.cgi?id=36151 12261 12262 Instead of blindingly plowing ahead, we now throw an exception if there 12263 are conflicts after applying a reverse diff. 12264 12265 * Scripts/webkitpy/scm.py: 12266 122672010-03-15 Chris Fleizach <cfleizach@apple.com> 12268 12269 Unreviewed layout test fix. 12270 12271 VO not able to perform a VO-spacebar on facebook links 12272 https://bugs.webkit.org/show_bug.cgi?id=36132 12273 12274 GTK needs to implement press for this test to work. 12275 12276 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 12277 (AccessibilityUIElement::press): 12278 122792010-03-15 Chris Fleizach <cfleizach@apple.com> 12280 12281 Unreviewed layout test fix. 12282 12283 VO not able to perform a VO-spacebar on facebook links 12284 https://bugs.webkit.org/show_bug.cgi?id=36132 12285 12286 Windows needs to implement press in DRT. 12287 12288 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 12289 (AccessibilityUIElement::press): 12290 122912010-03-15 Chris Fleizach <cfleizach@apple.com> 12292 12293 Unreviewed. Fix break of layout tests on win and gtk. 12294 12295 VO not able to perform a VO-spacebar on facebook links 12296 https://bugs.webkit.org/show_bug.cgi?id=36132 12297 12298 Attempting to implement press action for windows and gtk. 12299 12300 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 12301 (AccessibilityUIElement::press): 12302 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 12303 (AccessibilityUIElement::press): 12304 123052010-03-15 Chris Fleizach <cfleizach@apple.com> 12306 12307 Reviewed by Beth Dakin. 12308 12309 VO not able to perform a VO-spacebar on facebook links 12310 https://bugs.webkit.org/show_bug.cgi?id=36132 12311 12312 * DumpRenderTree/AccessibilityUIElement.cpp: 12313 (pressCallback): 12314 (AccessibilityUIElement::getJSClass): 12315 * DumpRenderTree/AccessibilityUIElement.h: 12316 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 12317 (AccessibilityUIElement::press): 12318 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 12319 (AccessibilityUIElement::press): 12320 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 12321 (AccessibilityUIElement::press): 12322 123232010-03-15 Mark Rowe <mrowe@apple.com> 12324 12325 Add a new build slave to replace the existing SnowLeopard Leaks build slave which 12326 appears to be suffering a slow and painful death at the hands of its graphics hardware. 12327 12328 * BuildSlaveSupport/build.webkit.org-config/config.json: 12329 123302010-03-15 Dirk Pranke <dpranke@chromium.org> 12331 12332 Reviewed by Alexey Proskuryakov. 12333 12334 Fix a minor case where we'd deference a null pointer if we tried 12335 to run new-run-webkit-tests on an unsupported platform (e.g. 12336 Cygwin's python version). 12337 12338 https://bugs.webkit.org/show_bug.cgi?id=36076 12339 12340 * Scripts/webkitpy/layout_tests/port/factory.py: 12341 123422010-03-15 Darin Adler <darin@apple.com> 12343 12344 Tell Subversion about more directories that expect to have .pyc files. 12345 12346 * Scripts/webkitpy/layout_tests: Added property svn:ignore. 12347 * Scripts/webkitpy/layout_tests/port: Added property svn:ignore. 12348 123492010-03-15 Adam Barth <abarth@webkit.org> 12350 12351 Reviewed by Darin Adler. 12352 12353 Operational scripts from running the EWS 12354 https://bugs.webkit.org/show_bug.cgi?id=36097 12355 12356 These are the scripts I use to manage the EWS on EC2. If someone other 12357 than me wants to run the EWS, these scripts might be helpful. 12358 12359 * EWSTools/boot.sh: Added. 12360 * EWSTools/create-webkit-git: Added. 12361 * EWSTools/screen-config: Added. 12362 * EWSTools/start-queue.sh: Added. 12363 123642010-03-14 Adam Barth <abarth@webkit.org> 12365 12366 Unreviewed. 12367 12368 Fix the webkit-patch bots. Turns out they need the path of the main 12369 script to run properly. 12370 12371 * Scripts/webkit-patch: 12372 * Scripts/webkitpy/patch/patcher.py: 12373 123742010-03-14 Darin Adler <darin@apple.com> 12375 12376 Tell Subversion about more directories that expect to have .pyc files. 12377 12378 * Scripts/webkitpy/init: Added property svn:ignore. 12379 * Scripts/webkitpy/patch: Added property svn:ignore. 12380 * Scripts/webkitpy/thirdparty: Added property svn:ignore. 12381 * Scripts/webkitpy/thirdparty/autoinstalled: Added property svn:ignore. 12382 123832010-03-14 Antti Koivisto <koivisto@iki.fi> 12384 12385 Reviewed by Simon Hausmann. 12386 12387 https://bugs.webkit.org/show_bug.cgi?id=35146 12388 Support tiled backing store 12389 12390 QtLauncher support and build flag in build-webkit. 12391 12392 * QtLauncher/main.cpp: 12393 (LauncherWindow::applyPrefs): 12394 (LauncherWindow::toggleTiledBackingStore): 12395 (LauncherWindow::toggleResizesToContents): 12396 (LauncherWindow::createChrome): 12397 (LauncherApplication::handleUserOptions): 12398 * QtLauncher/webview.cpp: 12399 (WebViewGraphicsBased::WebViewGraphicsBased): 12400 (WebViewGraphicsBased::setResizesToContents): 12401 (WebViewGraphicsBased::resizeEvent): 12402 * QtLauncher/webview.h: 12403 * Scripts/build-webkit: 12404 124052010-03-13 Chris Jerdonek <cjerdonek@webkit.org> 12406 12407 Reviewed by Adam Barth. 12408 12409 The webkit-patch script now displays a warning if run using 12410 a version of Python less than 2.5. This will help users 12411 understand why webkit-patch is erroring out if they are 12412 using Python 2.4, for example. 12413 12414 https://bugs.webkit.org/show_bug.cgi?id=31533 12415 12416 * Scripts/webkit-patch: 12417 - Moved most of the file contents to webkitpy/patch/patcher.py 12418 so the Python version can be checked before interpreting 12419 any code that can cause the script to error out. 12420 - Added a configure_logging() method to enable any version 12421 warnings to show up. 12422 - Added a main() method with calls to configure_logging(), 12423 check_version(), and the main webkit patch method. 12424 12425 * Scripts/webkitpy/patch/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. 12426 - This file is required to make a folder a package. 12427 12428 * Scripts/webkitpy/patch/patcher.py: Added. 12429 - Moved code from Scripts/webkit-patch. 12430 124312010-03-13 Chris Jerdonek <cjerdonek@webkit.org> 12432 12433 Reviewed by Adam Barth. 12434 12435 Changed test-webkitpy so that messages logged as a side-effect 12436 of unit-testing code do not get displayed to the screen. These 12437 messages clutter up the unit test results if not filtered out. 12438 12439 https://bugs.webkit.org/show_bug.cgi?id=35835 12440 12441 * Scripts/test-webkitpy: 12442 - Adjusted the configure_logging() method to filter out any 12443 log messages from webkitpy. 12444 - Also added an INFO message stating that most console logging 12445 is getting suppressed. 12446 12447 * Scripts/webkitpy/init/versioning.py: 12448 - Added a log parameter to the check_version() method. 12449 12450 * Scripts/webkitpy/init/versioning_unittest.py: 12451 - Qualified a call to check_version() with the parameter names. 12452 124532010-03-13 Chris Jerdonek <cjerdonek@webkit.org> 12454 12455 Reviewed by Adam Barth. 12456 12457 The test-webkitpy script now warns the user if the script is 12458 being run using a Python version different from the minimum 12459 version the webkitpy package was meant to support. 12460 12461 https://bugs.webkit.org/show_bug.cgi?id=35788 12462 12463 Warning developers if their Python version is too low will help 12464 them understand why test-webkitpy is failing. Secondly, warning 12465 developers if their Python version is higher than the minimum will 12466 help them understand that their changes may not be okay for the 12467 minimum supported version, even if test-webkitpy is passing. 12468 12469 * Scripts/test-webkitpy: 12470 - Moved the "from ..._unittest import *" lines to the new 12471 file Scripts/webkitpy/unittests.py. This will allow the 12472 version-check warning to be displayed even if an error occurs 12473 while interpreting (i.e. importing) the unit test code. 12474 - Added configure_logging() to configur logging for test-webkitpy. 12475 - Added an init() method to configure logging and check the 12476 current Python version. 12477 12478 * Scripts/webkitpy/init/unittests.py: Added. 12479 - Added a file to import all unit test modules in the 12480 webkitpy.init package. 12481 12482 * Scripts/webkitpy/init/versioning.py: Added. 12483 - Added a _MINIMUM_SUPPORTED_PYTHON_VERSION variable and set 12484 it equal to 2.5. 12485 - Added a compare_version() method to compare the current Python 12486 version against a target version. 12487 - Added a check_version() method to check the current Python 12488 version against the current minimum supported version, and to 12489 log a warning message if the check fails. 12490 12491 * Scripts/webkitpy/init/versioning_unittest.py: Added. 12492 - Added unit tests for the functions in versioning.py. 12493 12494 * Scripts/webkitpy/style/unittests.py: 12495 - Fixed/updated a code comment. 12496 12497 * Scripts/webkitpy/unittests.py: Added. 12498 - Moved the "from ..._unittest import *" lines from test-webkitpy. 12499 125002010-03-13 Chris Jerdonek <cjerdonek@webkit.org> 12501 12502 Reviewed by Adam Barth. 12503 12504 Moved all code in webkitpy/__init__.py to another location. 12505 12506 https://bugs.webkit.org/show_bug.cgi?id=35828 12507 12508 Keeping webkitpy/__init__.py free of non-trivial code allows 12509 calling code to import initialization code from webkitpy 12510 before any errors or log messages occur due to code in 12511 __init__.py. Such initialization code can include things like 12512 version checking code and logging configuration code. This 12513 also lets us move the autoinstall initialization code to a 12514 location where it only executes if it is needed -- something 12515 we have done in this patch. 12516 12517 * Scripts/webkitpy/__init__.py: 12518 - Moved all executable code to the following location: 12519 webkitpy/thirdparty/autoinstalled/__init__.py 12520 - Added a code comment to keep this file free of non-trivial 12521 code. 12522 12523 * Scripts/webkitpy/bugzilla.py: 12524 - Updated mechanize import statement. 12525 12526 * Scripts/webkitpy/networktransaction.py: 12527 - Updated mechanize import statement. 12528 12529 * Scripts/webkitpy/networktransaction_unittest.py: 12530 - Updated mechanize import statement. 12531 12532 * Scripts/webkitpy/statusserver.py: 12533 - Updated mechanize import statement. 12534 12535 * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: Added. 12536 - Copied the code from webkitpy/__init__.py and updated it 12537 as necessary. 12538 125392010-03-13 Chris Jerdonek <cjerdonek@webkit.org> 12540 12541 Reviewed by Adam Barth. 12542 12543 Moved webkitpy/mock.py into webkitpy/thirdparty since it is 12544 third-party code. 12545 12546 https://bugs.webkit.org/show_bug.cgi?id=35499 12547 12548 Updated the import statement in all of the below except where noted. 12549 12550 * Scripts/webkitpy/bugzilla_unittest.py: 12551 * Scripts/webkitpy/commands/commandtest.py: 12552 * Scripts/webkitpy/commands/download_unittest.py: 12553 * Scripts/webkitpy/commands/early_warning_system_unittest.py: 12554 * Scripts/webkitpy/commands/queries_unittest.py: 12555 * Scripts/webkitpy/commands/queues_unittest.py: 12556 * Scripts/webkitpy/commands/queuestest.py: 12557 * Scripts/webkitpy/commands/upload.py: 12558 * Scripts/webkitpy/commands/upload_unittest.py: 12559 * Scripts/webkitpy/commands_references.py: Added. 12560 - Added a file containing an absolute import of Mock so that 12561 the imports in the commands folder can import from this file 12562 (similar to style_references.py). This helps limit the 12563 number of affected files in future refactorings. 12564 12565 * Scripts/webkitpy/credentials_unittest.py: 12566 * Scripts/webkitpy/mock.py: Removed. 12567 - Moved to Scripts/webkitpy/thirdparty. 12568 12569 * Scripts/webkitpy/mock_bugzillatool.py: 12570 * Scripts/webkitpy/patchcollection_unittest.py: 12571 * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: 12572 * Scripts/webkitpy/steps/steps_unittest.py: 12573 * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: 12574 * Scripts/webkitpy/steps_references.py: Added. 12575 - Added a file containing an absolute import of Mock so that 12576 the imports in the steps folder can import from this file 12577 (similar to style_references.py). This helps limit the 12578 number of affected files in future refactorings. 12579 12580 * Scripts/webkitpy/thirdparty/mock.py: Copied from WebKitTools/Scripts/webkitpy/mock.py. 12581 - Also eliminated trailing white space and carriage returns. 12582 125832010-03-12 Robert Hogan <robert@webkit.org> 12584 12585 Reviewed by Adam Barth. 12586 12587 Amend incorrect typo patch for QtLauncher. 12588 12589 https://bugs.webkit.org/show_bug.cgi?id=35877 12590 12591 * QtLauncher/webview.cpp: 12592 (WebViewGraphicsBased::setFrameRateMeasurementEnabled): 12593 125942010-03-13 Victor Wang <victorw@chromium.org> 12595 12596 Add appengine app to host and serve webkit layout test results. 12597 12598 The app allows you post test result files (json) and serve them up. 12599 Chromium flakiness dashboard will first use this app to host results.json 12600 and expectations.json, but the files hosted by this app are not limited 12601 to chromium results or json files. It can be used to host other files if needed. 12602 12603 https://bugs.webkit.org/show_bug.cgi?id=35944 12604 12605 * TestResultServer: Added. 12606 * TestResultServer/app.yaml: Added. 12607 * TestResultServer/handlers: Added. 12608 * TestResultServer/handlers/__init__.py: Added. 12609 * TestResultServer/handlers/menu.py: Added. 12610 * TestResultServer/handlers/testfilehandler.py: Added. 12611 * TestResultServer/index.yaml: Added. 12612 * TestResultServer/main.py: Added. 12613 * TestResultServer/model: Added. 12614 * TestResultServer/model/__init__.py: Added. 12615 * TestResultServer/model/testfile.py: Added. 12616 * TestResultServer/stylesheets: Added. 12617 * TestResultServer/stylesheets/form.css: Added. 12618 * TestResultServer/stylesheets/menu.css: Added. 12619 * TestResultServer/stylesheets/testfile.css: Added. 12620 * TestResultServer/templates: Added. 12621 * TestResultServer/templates/menu.html: Added. 12622 * TestResultServer/templates/showfilelist.html: Added. 12623 * TestResultServer/templates/uploadform.html: Added. 12624 126252010-03-13 Dimitri Glazkov <dglazkov@chromium.org> 12626 12627 Reviewed by David Levin. 12628 12629 new-run-webkit-tests fails with --debug option. 12630 https://bugs.webkit.org/show_bug.cgi?id=36067 12631 12632 * Scripts/webkitpy/layout_tests/port/mac.py: 12633 126342010-03-13 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 12635 12636 Reviewed by Kenneth Rohde Christiansen. 12637 12638 Add "Show FPS" menu option to QtLauncher. 12639 12640 [Qt] QtLauncher need a menu option to show/hide FPS 12641 https://bugs.webkit.org/show_bug.cgi?id=35794 12642 12643 * QtLauncher/main.cpp: 12644 (LauncherWindow::showFPS): 12645 (LauncherWindow::createChrome): 12646 126472010-03-13 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 12648 12649 Reviewed by Kenneth Rohde Christiansen. 12650 12651 Add a "Toggle FullScreen" option to QtLauncher Menu. 12652 12653 [Qt] QtLauncher needs an option to toggle FullScreen Mode 12654 https://bugs.webkit.org/show_bug.cgi?id=35755 12655 12656 * QtLauncher/main.cpp: 12657 (LauncherWindow::init): 12658 (LauncherWindow::eventFilter): 12659 (LauncherWindow::initializeView): 12660 (LauncherWindow::toggleFullScreenMode): 12661 (LauncherWindow::createChrome): 12662 126632010-03-12 Dirk Pranke <dpranke@chromium.org> 12664 12665 Reviewed by Dimitri Glazkov. 12666 12667 Fix typo in websocket_server (path_from_base instead of 12668 path_from_chromium_base). 12669 12670 https://bugs.webkit.org/show_bug.cgi?id=36074 12671 12672 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 12673 126742010-03-12 Dirk Pranke <dpranke@chromium.org> 12675 12676 Reviewed by Adam Barth. 12677 12678 new-run-webkit-tests --new-baseline doesn't work at all. 12679 12680 It attempts to call a method that isn't defined. To fix it, I 12681 removed the unnecessary and unnecessarily confusing 'platform' 12682 argument to the test_type constructor and use the Port object that 12683 is passed in instead, since we are only ever generating a baseline 12684 from the port that is currently executing. 12685 12686 https://bugs.webkit.org/show_bug.cgi?id=36046 12687 12688 * Scripts/webkitpy/layout_tests/port/mac.py: 12689 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 12690 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 12691 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 12692 126932010-03-12 Dirk Pranke <dpranke@chromium.org> 12694 12695 Reviewed by Adam Barth. 12696 12697 Fix new-run-webkit-tests --run-singly 12698 12699 This script option is currently broken - the script attempts to 12700 dereference methods and variables that don't exist, which causes 12701 the Chromium Linux valgrind bot to be quite unhappy. This has been 12702 broken since r54449 when I renamed Port.start_test_driver to 12703 Port.start_driver. 12704 12705 https://bugs.webkit.org/show_bug.cgi?id=36042 12706 12707 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 12708 127092010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12710 12711 Fix critical being printed to stderr on every test. This is 12712 because the jar is only being created when soup hits the HTTP 12713 path. We should reconsider the time of its creation. 12714 12715 * DumpRenderTree/gtk/DumpRenderTree.cpp: 12716 (resetDefaultsToConsistentValues): 12717 127182010-03-12 Adam Roben <aroben@apple.com> 12719 12720 Teach prepare-ChangeLog to find modified selectors in CSS files 12721 12722 Reviewed by Tim Hatcher. 12723 12724 Fixes <http://webkit.org/b/36064> prepare-ChangeLog should extract 12725 modified selectors from CSS files 12726 12727 * Scripts/prepare-ChangeLog: 12728 (get_function_line_ranges): Call get_selector_line_ranges_for_css for 12729 .css files. 12730 (get_selector_line_ranges_for_css): Added. Finds selectors and their 12731 line ranges and returns them. 12732 127332010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12734 12735 Build fix (for EWS). Make sure the new code builds on older soup. 12736 12737 Thanks to Dan Winship. 12738 12739 * DumpRenderTree/gtk/DumpRenderTree.cpp: 12740 (resetDefaultsToConsistentValues): 12741 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 12742 (LayoutTestController::setAlwaysAcceptCookies): 12743 127442010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12745 12746 Reviewed by Eric Carlson. 12747 12748 [GTK] DRT does not handle cookie policy setting 12749 https://bugs.webkit.org/show_bug.cgi?id=36056 12750 12751 Implement cookie accept policy setting for GTK+'s LayoutTestController. 12752 12753 * DumpRenderTree/gtk/DumpRenderTree.cpp: 12754 (resetDefaultsToConsistentValues): 12755 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 12756 (LayoutTestController::setAlwaysAcceptCookies): 12757 127582010-03-12 Adam Langley <agl@chromium.org> 12759 12760 Reviewed by Dimitri Glazkov. 12761 12762 [chromium]: update Linux layout test scripts for RedHat like systems. 12763 12764 (Tested on Fedora 12.) 12765 12766 https://bugs.webkit.org/show_bug.cgi?id=35867 12767 12768 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 12769 127702010-03-12 Adam Roben <aroben@apple.com> 12771 12772 Make svn-create-patch's diffs of ObjC header files more readable 12773 12774 Fixes <http://webkit.org/b/36055>. 12775 12776 Reviewed by John Sullivan. 12777 12778 * Scripts/svn-create-patch: 12779 (diffOptionsForFile): Added. Returns the options that should be passed 12780 to diff for the given file. All the options are the same for all 12781 files, except for the option to specify which lines should be used as 12782 hunk headers. 12783 (generateDiff): Use diffOptionsForFile to get the options to pass to 12784 diff. 12785 (hunkHeaderLineRegExForFile): Added. Returns the regular expression 12786 that should be used by diff to identify lines that should be included 12787 after the "@@" in the hunk header lines of the diff. For ObjC[++] 12788 source files, we use any lines starting with -, +, or 12789 @implementation/@interface/@protocol. For ObjC[++] header files (which 12790 we assume to be any .h files in a mac/ or objc/ directory), we use any 12791 lines starting with @implementation/@interface/@protocol. 12792 127932010-03-12 Jochen Eisinger <jochen@chromium.org> 12794 12795 Reviewed by Jeremy Orlow. 12796 12797 Introduce setWillSendRequestClearHeader to LayoutTestController to selectively remove headers in willSendRequest. Used in http/tests/security/no-referrer.html 12798 https://bugs.webkit.org/show_bug.cgi?id=35920 12799 12800 * DumpRenderTree/LayoutTestController.cpp: 12801 (setWillSendRequestClearHeaderCallback): 12802 (LayoutTestController::staticFunctions): 12803 * DumpRenderTree/LayoutTestController.h: 12804 (LayoutTestController::willSendRequestClearHeaders): 12805 (LayoutTestController::setWillSendRequestClearHeader): 12806 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 12807 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): 12808 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 12809 (ResourceLoadDelegate::willSendRequest): 12810 128112010-03-11 Fumitoshi Ukai <ukai@chromium.org> 12812 12813 Unreviewed. 12814 12815 Fix typo in websocket_server.py 12816 12817 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 12818 128192010-03-11 Garret Kelly <gdk@chromium.org> 12820 12821 Reviewed by Darin Adler. 12822 12823 Fixing minor typo in the commit queue status page. 12824 https://bugs.webkit.org/show_bug.cgi?id=35979 12825 12826 * Scripts/webkitpy/commands/queues.py: 12827 128282010-03-11 Fumitoshi Ukai <ukai@chromium.org> 12829 12830 Unreviewed. 12831 12832 Fix for WebSocket layout test runner on chromium/win port. 12833 12834 * Scripts/webkitpy/layout_tests/port/websocket_server.py: register_cygwin and set CYGWIN_PATH 12835 128362010-03-11 Mark Rowe <mrowe@apple.com> 12837 12838 Reviewed by David Kilzer. 12839 12840 <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version 12841 12842 Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version. 12843 12844 * DumpRenderTree/mac/Configurations/Base.xcconfig: 12845 128462010-03-11 Victor Wang <victorw@chromium.org> 12847 12848 Reviewed by dglazkov@chromium.org. 12849 12850 rebaseline_chromium_webkit_tests can generate new baselines for 12851 all platforms so it needs to know two ports in order to work correctly: 12852 the port that the script is running on and the port that it generates 12853 new baselines for. Update rebaselining tool to handle both port correctly. 12854 12855 https://bugs.webkit.org/show_bug.cgi?id=36032 12856 12857 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 12858 128592010-03-11 Mark Rowe <mrowe@apple.com> 12860 12861 Reviewed by Tim Hatcher. 12862 12863 <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version 12864 12865 Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the 12866 current Mac OS X version unless otherwise specified. 12867 12868 Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR. 12869 12870 Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice 12871 may not be usable when targetting a different Mac OS X version. 12872 12873 Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off 12874 MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used. 12875 12876 * DumpRenderTree/mac/Configurations/Base.xcconfig: 12877 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: 12878 * DumpRenderTree/mac/DumpRenderTree.mm: Wrap the include of mach-o/getsect.h in 'extern "C"' as some versions of the 12879 header in older SDKs do not do this inside the header. 12880 128812010-03-11 Alexey Proskuryakov <ap@apple.com> 12882 12883 Reviewed by Geoff Garen. 12884 12885 https://bugs.webkit.org/show_bug.cgi?id=35965 12886 <rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in 12887 12888 Made rememberedObject a member of PluginObject. A plug-in must not use its references 12889 to browser NPObjects after being destroyed, but this wasn't the case with static variable. 12890 12891 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 12892 (pluginInvoke): 12893 (pluginInvalidate): 12894 (pluginAllocate): 12895 (pluginDeallocate): 12896 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: 12897 128982010-03-11 Simon Fraser <simon.fraser@apple.com> 12899 12900 Reviewed by Oliver Hunt. 12901 12902 https://bugs.webkit.org/show_bug.cgi?id=35905 12903 REGRESSION(55699?): media/video-no-autoplay.html times out on Leopard Commit Bot 12904 12905 Make sure we reset the WebGL preference, so that WebGL doesn't get left 12906 on after being enabled via layoutTestController.overridePreference(), 12907 which in turn causes accelerated compositing to be enabled on Leopard 12908 when we don't want it to be. 12909 12910 * DumpRenderTree/mac/DumpRenderTree.mm: 12911 (resetDefaultsToConsistentValues): 12912 129132010-03-10 Dirk Pranke <dpranke@chromium.org> 12914 12915 Reviewed by Dimitri Glazkov. 12916 12917 rebaseline_chromium_webkit_tests doesn't handle other plaforms 12918 correctly (e.g., if you run on the Mac platform and try to 12919 rebaseline the WIN results, the result gets written into 12920 platform/mac instead of platform/chromium-win). Also, this script 12921 doesn't work on non-Chromium ports, so we need to fix that at some 12922 point. 12923 12924 https://bugs.webkit.org/show_bug.cgi?id=35982 12925 12926 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 12927 129282010-03-10 Daniel Bates <dbates@rim.com> 12929 12930 Reviewed by Simon Hausmann. 12931 12932 https://bugs.webkit.org/show_bug.cgi?id=35840 12933 12934 Updates the subroutine builtDylibPathForName() so that it adds the "d" suffix to 12935 the QtWebKit library name on Windows. This change makes run-launcher work again 12936 under Windows. Moreover, this change corresponds to the change made in change- 12937 set 53924 <http://trac.webkit.org/changeset/53924>. 12938 12939 * Scripts/webkitdirs.pm: 12940 129412010-03-10 Adam Roben <aroben@apple.com> 12942 12943 Roll out the prepare-ChangeLog part of r55870 12944 12945 This change wasn't needed (prepare-ChangeLog calls svn-create-patch 12946 when it's asked to print out diffs for the user) and was screwing up 12947 its ability to find changed function names. 12948 12949 * Scripts/prepare-ChangeLog: 12950 (diffCommand): Change the options we pass to svn-diff back to their 12951 pre-r55870 form. 12952 129532010-03-10 Robert Hogan <robert@webkit.org> 12954 12955 Reviewed by Simon Hausmann. 12956 12957 [Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT 12958 12959 Unskip test fast/events/multiline-link-arrow-navigation.html 12960 12961 https://bugs.webkit.org/show_bug.cgi?id=35593 12962 12963 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 12964 (WebCore::WebPage::resetSettings): 12965 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 12966 (LayoutTestController::overridePreference): 12967 (LayoutTestController::setCaretBrowsingEnabled): 12968 * DumpRenderTree/qt/LayoutTestControllerQt.h: 12969 129702010-03-10 Robert Hogan <robert@webkit.org> 12971 12972 Reviewed by Holger Freyther. 12973 12974 QtLauncher: Fix typo in conditional statement in 12975 WebViewGraphicsBased::setFrameRateMeasurementEnabled. 12976 12977 '=' should be '=='! 12978 12979 https://bugs.webkit.org/show_bug.cgi?id=35877 12980 12981 * QtLauncher/webview.cpp: 12982 (WebViewGraphicsBased::setFrameRateMeasurementEnabled): 12983 129842010-03-10 Chris Jerdonek <cjerdonek@webkit.org> 12985 12986 Reviewed by Shinichiro Hamaji. 12987 12988 Refactored and cleaned up the code for unit-testing logging. 12989 12990 https://bugs.webkit.org/show_bug.cgi?id=35845 12991 12992 * Scripts/webkitpy/init/logtesting.py: 12993 - Added more information to the module docstring. 12994 - Added an assertMessages() method to the UnitTestLogStream 12995 class. This simplifies the calling code. 12996 - Renamed the UnitTestLog class to LogTesting, and reformulated 12997 it as follows: 12998 - Moved the logging configuration code from the __init__ 12999 method to a new static setUp() method. 13000 - Documented the __init__ method to be private. 13001 - Improved the code so that the root logger does not have 13002 its logging level changed. Instead we set the handler's 13003 level. This makes the unit testing more unintrusive. 13004 - Updated the assertMessages() method to call the 13005 UnitTestLogStream class's assertMessages() method. 13006 - More fully documented the class. 13007 13008 * Scripts/webkitpy/style/checker.py: 13009 - Added a logger parameter to the configure_logging() method. 13010 This allows us to prevent test messages from being sent 13011 to the root logger during unit testing, which may be 13012 rendering to the screen, etc. 13013 - Simplified the code by removing the _LevelLoggingFilter class. 13014 - Replaced the _LevelLoggingFilter class with a one-line lambda 13015 expression in configure_logging(). 13016 13017 * Scripts/webkitpy/style/checker_unittest.py: 13018 - Changed relative imports to absolute to comply more with PEP8. 13019 - In the ConfigureLoggingTest class: 13020 - Changed the setUp() method to prevent test messages from 13021 being propagated to the root logger. 13022 - Changed the _log() method to a data attribute. 13023 - Updated to accommodate changes to logtesting.py. 13024 13025 * Scripts/webkitpy/style_references.py: 13026 - Updated an import statement. 13027 130282010-03-10 Evan Martin <evan@chromium.org> 13029 13030 Reviewed by Darin Adler. 13031 13032 Python code for GDB 7 to support native printing of some WebCore types. 13033 13034 * gdb/webcore.py: Added. 13035 130362010-03-10 Adam Roben <aroben@apple.com> 13037 13038 Make svn-create-patch and prepare-ChangeLog show better section 13039 headings for ObjC files 13040 13041 This makes the text at the end of each "@@" line in a diff actually 13042 show the ObjC method or interface that contains the change, rather 13043 than whatever the most-recently-defined C function was. 13044 13045 Fixes <http://webkit.org/b/35970>. 13046 13047 Reviewed by John Sullivan. 13048 13049 * Scripts/svn-create-patch: Pass -F'^[-+@]' to diff so that it will 13050 treat any lines starting with -, +, or @ as section heading lines. 13051 This works well for ObjC files, and shouldn't affect other types of 13052 files. 13053 13054 * Scripts/prepare-ChangeLog: Changed the options passed to diff to 13055 match those used in svn-create-patch. 13056 130572010-03-10 Simon Hausmann <simon.hausmann@nokia.com> 13058 13059 Reviewed by Tor Arne Vestbø. 13060 13061 Link QtLauncher against the WebKit library using a relative rpath. 13062 13063 This makes the launcher and the lib relocatable. 13064 13065 * QtLauncher/QtLauncher.pro: 13066 130672010-03-10 Holger Hans Peter Freyther <zecke@selfish.org> 13068 13069 Rubber-stamped by Simon Hausmann. 13070 13071 [iExploder] Add new CSS Properties and HTML Attributes 13072 13073 The update-iexploder-cssproperties script was used to update 13074 the various input files. The autobuffer HTML Attribute was removed 13075 from WebKit and I manually added it back to the htmlattrs.in like 13076 we have done it for other attributes in the past. 13077 13078 * iExploder/htdocs/cssproperties.in: 13079 * iExploder/htdocs/htmlattrs.in: 13080 * iExploder/htdocs/htmltags.in: 13081 130822010-03-09 Fumitoshi Ukai <ukai@chromium.org> 13083 13084 Unreviewed. 13085 13086 Obvious fix for --cgi-paths of pywebsocket. 13087 13088 * Scripts/run-webkit-websocketserver: 13089 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 13090 130912010-03-09 Jakub Wieczorek <jwieczorek@webkit.org> 13092 13093 Unreviewed. 13094 13095 Adding myself to committers.py. 13096 13097 * Scripts/webkitpy/committers.py: 13098 130992010-03-09 Dirk Pranke <dpranke@chromium.org> 13100 13101 Reviewed by Nate Chapin. 13102 13103 Fix --clobber-old-results in new-run-webkit-tests. 13104 13105 https://bugs.webkit.org/show_bug.cgi?id=35778 13106 13107 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 13108 131092010-03-09 Andy Estes <aestes@apple.com> 13110 13111 Reviewed by Adele Peterson. 13112 13113 Add the ability to dispatch scroll wheel events in DRT. This was 13114 necessary in order to write a test for 13115 https://bugs.webkit.org/show_bug.cgi?id=34700. 13116 13117 * DumpRenderTree/mac/EventSendingController.mm: Add support for two 13118 new methods to EventSender: mouseScrollBy(x, y) and 13119 continuousMouseScrollBy(x, y). The API to generate scroll events on 13120 the mac was added in 10.5, so these methods are NOOPs on Tiger. 13121 (+[EventSendingController isSelectorExcludedFromWebScript:]): 13122 Regiester mouseScrollByX:andY: and continuousMouseScrollByX:andY: 13123 (+[EventSendingController webScriptNameForSelector:]): Map JavaScript 13124 method names to ObjC selectors. 13125 (-[EventSendingController mouseScrollByX:andY:continuously:]): Generate 13126 a scroll wheel event using CGEventCreateScrollWheelEvent() and dispatch 13127 it to WebKit. 13128 (-[EventSendingController continuousMouseScrollByX:andY:]): Generate a 13129 continuous scrolling event by x and y pixels. 13130 (-[EventSendingController mouseScrollByX:andY:]): Generate a notchy 13131 scrolling event by x and y lines. 13132 131332010-03-09 Chris Fleizach <cfleizach@apple.com> 13134 13135 DRT build fix for Tiger. No review. 13136 13137 AX: hit testing a list box doesn't work anymore 13138 https://bugs.webkit.org/show_bug.cgi?id=35893 13139 13140 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 13141 (AccessibilityController::elementAtPoint): 13142 131432010-03-09 Chris Fleizach <cfleizach@apple.com> 13144 13145 Reviewed by Darin Adler. 13146 13147 AX: hit testing a list box doesn't work anymore 13148 https://bugs.webkit.org/show_bug.cgi?id=35893 13149 13150 * DumpRenderTree/AccessibilityController.cpp: 13151 (getElementAtPointCallback): 13152 (AccessibilityController::getJSClass): 13153 * DumpRenderTree/AccessibilityController.h: 13154 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 13155 (AccessibilityController::elementAtPoint): 13156 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 13157 (AccessibilityController::elementAtPoint): 13158 * DumpRenderTree/win/AccessibilityControllerWin.cpp: 13159 (AccessibilityController::elementAtPoint): 13160 131612010-03-03 Fumitoshi Ukai <ukai@chromium.org> 13162 13163 Reviewed by Alexey Proskuryakov. 13164 13165 pywebsocket should support html and cgi in the same directory. 13166 https://bugs.webkit.org/show_bug.cgi?id=34879 13167 13168 Import pywebsocket 0.4.9.2 13169 Specify --server-host 127.0.0.1, so that it only binds listening socket 13170 to 127.0.0.1 to prevent access from non-localhost. 13171 Change --cgi-paths from /websocket/tests/cookies to /websocket/tests, 13172 because pywebsocket 0.4.9.2 supports html and cgi in the same directory 13173 and only executable (httponly-cookies.pl) will be handled as cgi 13174 script. 13175 13176 * Scripts/run-webkit-tests: 13177 * Scripts/run-webkit-websocketserver: 13178 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 13179 * Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: 13180 * Scripts/webkitpy/thirdparty/pywebsocket/example/echo_client.py: 13181 * Scripts/webkitpy/thirdparty/pywebsocket/example/handler_map.txt: Added. 13182 * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/standalone.py: 13183 * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/util.py: 13184 * Scripts/webkitpy/thirdparty/pywebsocket/setup.py: 13185 * Scripts/webkitpy/thirdparty/pywebsocket/test/test_util.py: 13186 * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/README: Added. 13187 * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/hello.pl: Added. 13188 131892010-03-09 Chris Jerdonek <cjerdonek@webkit.org> 13190 13191 Reviewed by Shinichiro Hamaji. 13192 13193 Simplified check-webkit-style's argument parsing code by removing 13194 support for the vestigial "extra flag values" parameter. 13195 13196 https://bugs.webkit.org/show_bug.cgi?id=34677 13197 13198 The "extra flag values" parameter was needed before WebKit 13199 forked check-webkit-style from Google. It was used to pass 13200 through the option parser those command-line flags that WebKit 13201 required but that Google's parser did not support (the --git-commit 13202 flag in particular). 13203 We can remove the parameter now because it is no longer 13204 needed and unnecessarily clutters the argument-parsing code. 13205 13206 * Scripts/webkitpy/style/optparser.py: 13207 - Removed the extra_flag_values parameter from the 13208 CommandOptionValues class's constructor. 13209 - Removed the extra_flags parameter from the ArgumentParser 13210 class's parse() method. 13211 13212 * Scripts/webkitpy/style/optparser_unittest.py: 13213 - Removed from the unit tests all references to the 13214 extra_flag_values variable. 13215 132162010-03-08 Kent Tamura <tkent@chromium.org> 13217 13218 Reviewed by Dimitri Glazkov. 13219 13220 [DRT/Chromium] Add EventSender 13221 https://bugs.webkit.org/show_bug.cgi?id=35859 13222 13223 Add EventSender classes, which are going to be used by 13224 DumpRenderTree Chromium port. These files are based on: 13225 - src/webkit/tools/test_shell/event_sending_controller.cc 13226 - src/webkit/tools/test_shell/event_sending_controller.h 13227 of Chromium rev.40492. 13228 13229 * DumpRenderTree/chromium/EventSender.cpp: Added. 13230 * DumpRenderTree/chromium/EventSender.h: Added. 13231 132322010-03-08 Kent Tamura <tkent@chromium.org> 13233 13234 Reviewed by Dimitri Glazkov. 13235 13236 [DRT/Chromium] Add PlainTextController and TextInputController 13237 https://bugs.webkit.org/show_bug.cgi?id=35852 13238 13239 Add PlainTextController and TextInputController classes, which are going 13240 to be used by DumpRenderTree Chromium port. These files are based on: 13241 - src/webkit/tools/test_shell/plain_text_controller.{cc,h} and 13242 - src/webkit/tools/test_shell/text_input_controller.{cc,h} 13243 of Chromium rev.40492. 13244 13245 * DumpRenderTree/chromium/PlainTextController.cpp: Added. 13246 * DumpRenderTree/chromium/PlainTextController.h: Added. 13247 * DumpRenderTree/chromium/TextInputController.cpp: Added. 13248 * DumpRenderTree/chromium/TextInputController.h: Added. 13249 132502010-03-08 Dumitru Daniliuc <dumi@chromium.org> 13251 13252 Unreviewed, Chromium build fix. 13253 13254 Reverting r55689. 13255 13256 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 13257 132582010-03-08 Fumitoshi Ukai <ukai@chromium.org> 13259 13260 Reviewed by Adam Barth. 13261 13262 Fix webkit-patch post and land to work well with security bug 13263 https://bugs.webkit.org/show_bug.cgi?id=35733 13264 13265 Bugzilla requires authentication to access security bug page, 13266 so call authenticate() if it failed to fetch bug page. 13267 13268 * Scripts/webkitpy/bugzilla.py: 13269 132702010-03-04 Dirk Pranke <dpranke@chromium.org> 13271 13272 Reviewed by Dimitry Glazkov. 13273 13274 Fix --clobber-old-results in new-run-webkit-tests. 13275 13276 https://bugs.webkit.org/show_bug.cgi?id=35778 13277 13278 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 13279 132802010-03-08 Brady Eidson <beidson@apple.com> 13281 13282 Reviewed by NOBODY (but suggested by Steve Falkenburg and fixing a boneheaded mistake on my part last week) 13283 13284 Followup to https://bugs.webkit.org/show_bug.cgi?id=35532 13285 13286 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 13287 (LayoutTestController::apiTestGoToCurrentBackForwardItem): Can't pass in a null BOOL to WebKit APIs. 13288 132892010-03-08 Chris Jerdonek <cjerdonek@webkit.org> 13290 13291 Unreviewed. 13292 13293 Fixed incorrect import statement in validate-committer-lists: 13294 webkitpy.BeautifulSoup -> webkitpy.thirdparty.BeautifulSoup. 13295 13296 * Scripts/validate-committer-lists: 13297 132982010-03-08 Jian Li <jianli@chromium.org> 13299 13300 Reviewed by Dmitry Titov. 13301 13302 Blob.slice support. 13303 https://bugs.webkit.org/show_bug.cgi?id=32993 13304 13305 Add ENABLE_BLOB_SLICE feature define and flag for build-webkit. It is 13306 currently only turned on for Mac. 13307 13308 * Scripts/build-webkit: 13309 133102010-03-08 Gustavo Noronha Silva <gns@gnome.org> 13311 13312 No review, rolling out r55662. 13313 http://trac.webkit.org/changeset/55662 13314 https://bugs.webkit.org/show_bug.cgi?id=35863 13315 13316 Need to be coordinated with bots setup 13317 13318 * Scripts/run-webkit-tests: 13319 133202010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 13321 13322 Reviewed by Holger Freyther. 13323 13324 [GTK] Tests fail when running with ipv6 addresses available, on Debian systems 13325 https://bugs.webkit.org/show_bug.cgi?id=35863 13326 13327 If running on a Debian-based system, also listen on the ipv6 address. 13328 13329 * Scripts/run-webkit-tests: 13330 133312010-03-08 Holger Hans Peter Freyther <zecke@selfish.org> 13332 13333 Reviewed by Darin Adler. 13334 13335 [iexploder] Automatically update htmltags.in and htmlattrs.in too 13336 https://bugs.webkit.org/show_bug.cgi?id=33755 13337 13338 Change the update-iexploder-cssproperites script to update 13339 the htmlattrs.in and htmltags.in of WebKitTools/iExploder/htdocs 13340 automatically as well. 13341 13342 Change the reading and writing code to work with parameters 13343 and extend the method that is parsing the .in files to handle 13344 the HTMLTagNames.in and the HTMLAttributeNames.in files. 13345 13346 Remove custom code to determine the revision of files with a 13347 utility of VCUtils.pm to determine the revision of the directory 13348 these files are located in. This will also work with git checkout. 13349 13350 * Scripts/update-iexploder-cssproperties: 13351 133522010-03-07 Shinichiro Hamaji <hamaji@chromium.org> 13353 13354 Reviewed by Eric Seidel. 13355 13356 check-webkit-style: false positive for empty loop 13357 https://bugs.webkit.org/show_bug.cgi?id=35717 13358 13359 * Scripts/webkitpy/style/processors/cpp.py: 13360 * Scripts/webkitpy/style/processors/cpp_unittest.py: 13361 133622010-03-07 Kent Tamura <tkent@chromium.org> 13363 13364 Reviewed by Dimitri Glazkov. 13365 13366 [DRT/Chromium] Add AccessibilityController and AccessibilityUIElement 13367 https://bugs.webkit.org/show_bug.cgi?id=35774 13368 13369 Add AccessibilityController and AccessibilityUIElement classes, 13370 which are going to be used by DumpRenderTree Chromium port. These 13371 files are based on: 13372 - src/webkit/tools/test_shell/accessibility_controller.{cc,h} and 13373 - src/webkit/tools/test_shell/accessibility_ui_element.{cc,h} 13374 of Chromium rev.40492. 13375 13376 * DumpRenderTree/chromium/AccessibilityController.cpp: Added. 13377 * DumpRenderTree/chromium/AccessibilityController.h: Added. 13378 * DumpRenderTree/chromium/AccessibilityUIElement.cpp: Added. 13379 * DumpRenderTree/chromium/AccessibilityUIElement.h: Added. 13380 133812010-03-06 Hironori Bono <hbono@chromium.org> 13382 13383 Reviewed by Eric Seidel. 13384 13385 [Chromium] Typing into Flash with wmode = opaque|transparent and 13386 non-latin language active outputs as if US keyboard layout active 13387 13388 https://bugs.webkit.org/show_bug.cgi?id=34936 13389 13390 To test keyboard events on the test plugin, this change implements 13391 NPCocoaEventKeyDown and NPCocoaEventKeyUp handlers so the plugin 13392 can write log messages. 13393 13394 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 13395 (handleEventCocoa): Implemented the event handlers for NPCocoaKeyDown 13396 and NPCocoaEventKeyUp. 13397 133982010-03-05 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 13399 13400 Reviewed by Eric Seidel. 13401 13402 Fix Print option on QtLauncher by calling print directly from QWebFrame. 13403 13404 [Qt] QtLauncher Print option is not working on QGraphicsView mode 13405 https://bugs.webkit.org/show_bug.cgi?id=35769 13406 13407 * QtLauncher/main.cpp: 13408 (LauncherWindow::print): 13409 134102010-03-05 Chris Jerdonek <cjerdonek@webkit.org> 13411 13412 Reviewed by Eric Seidel. 13413 13414 Changed the logging code for new-run-webkit-tests to use 13415 module-specific loggers rather than the root logger. This is 13416 a standard practice that allows logging specific to a package 13417 to be configured independently of other modules. 13418 13419 https://bugs.webkit.org/show_bug.cgi?id=35194 13420 13421 Added a line of the form "_log = logging.getLogger(<module>)" 13422 to each module below, where <module> is the fully-qualified 13423 name of the module, and updated the log lines to use the new 13424 _log logger. 13425 13426 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 13427 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 13428 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 13429 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 13430 * Scripts/webkitpy/layout_tests/port/chromium.py: 13431 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 13432 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 13433 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 13434 * Scripts/webkitpy/layout_tests/port/http_server.py: 13435 * Scripts/webkitpy/layout_tests/port/http_server_base.py: 13436 * Scripts/webkitpy/layout_tests/port/mac.py: 13437 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 13438 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 13439 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 13440 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: 13441 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 13442 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 13443 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 13444 134452010-03-05 Dirk Pranke <dpranke@chromium.org> 13446 13447 Reviewed by Eric Siedel. 13448 13449 Split the command-line invocation of the Chromium/python LigHTTPd 13450 server implementation out into its own top level script to make it 13451 a more "public" interface and to resolve some awkward layering 13452 issues. This script will be called directly by other test scripts in 13453 the Chromium tree. 13454 13455 At some point this script should be made to work with Apache-based 13456 implementations and on other ports. I have filed 13457 https://bugs.webkit.org/show_bug.cgi?id=35820 for this. 13458 13459 Also fix a bug in port/factory where options.chromium could be 13460 dereferenced even if it wasn't set, raising an exception. 13461 13462 https://bugs.webkit.org/show_bug.cgi?id=35812 13463 13464 * Scripts/webkitpy/layout_tests/port/factory.py: 13465 * Scripts/webkitpy/layout_tests/port/http_server.py: 13466 * Scripts/new-run-webkit-httpd: Added 13467 134682010-03-02 Antonio Gomes <tonikitoo@webkit.org> 13469 13470 Reviewed by Holger Freyther 13471 Patch by Antonio Gomes <tonikitoo@webkit.org> 13472 13473 [Gtk] Implement setSpatialNavigationEnabled in DRT. 13474 https://bugs.webkit.org/show_bug.cgi?id=35705 13475 13476 * DumpRenderTree/gtk/DumpRenderTree.cpp: 13477 (resetDefaultsToConsistentValues): 13478 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 13479 (LayoutTestController::setSpatialNavigationEnabled): 13480 134812010-02-23 Antonio Gomes <tonikitoo@webkit.org> 13482 13483 Reviewed by Kenneth Christiansen. 13484 Patch by Antonio Gomes <tonikitoo@webkit.org> 13485 13486 Add toggle on/off stub methods for Spatial Navigation in win, gtk and mac LayoutTestController class implementations. 13487 https://bugs.webkit.org/show_bug.cgi?id=35699 13488 13489 * DumpRenderTree/LayoutTestController.cpp: 13490 (setSpatialNavigationEnabledCallback): 13491 (LayoutTestController::staticFunctions): 13492 * DumpRenderTree/LayoutTestController.h: 13493 * DumpRenderTree/gtk/DumpRenderTree.cpp: 13494 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 13495 (LayoutTestController::setSpatialNavigationEnabled): 13496 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 13497 (LayoutTestController::setSpatialNavigationEnabled): 13498 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 13499 (LayoutTestController::setSpatialNavigationEnabled): 13500 135012010-02-18 Antonio Gomes <tonikitoo@webkit.org> 13502 13503 Reviewed by Kenneth Christiansen. 13504 Patch by Antonio Gomes <tonikitoo@webkit.org> 13505 13506 Add toggle on/off mechanism for Spatial Navigation in QtLauncher. 13507 13508 * QtLauncher/main.cpp: 13509 (LauncherWindow::toggleSpatialNavigation): 13510 (LauncherWindow::setupUI): 13511 135122010-03-02 Antonio Gomes <tonikitoo@webkit.org> 13513 13514 Reviewed by Simon Hausmann. 13515 Patch by Antonio Gomes <tonikitoo@webkit.org> 13516 13517 [Qt] Add setSpatialNavigationEnabled method DRT 13518 https://bugs.webkit.org/show_bug.cgi?id=33715 13519 13520 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 13521 (WebCore::WebPage::WebPage): 13522 (WebCore::WebPage::resetSettings): 13523 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 13524 (LayoutTestController::setSpatialNavigationEnabled): 13525 * DumpRenderTree/qt/LayoutTestControllerQt.h: 13526 13527 Unskipped fast/events/spatialnavigation/ 13528 135292010-03-04 Mark Rowe <mrowe@apple.com> 13530 13531 Rubber-stamped by Alice Liu. 13532 13533 Find the framework relative to TARGET_BUILD_DIR as that has a more obvious value during production builds. 13534 13535 * Scripts/check-for-webkit-framework-include-consistency: 13536 135372010-03-04 Kent Tamura <tkent@chromium.org> 13538 13539 Reviewed by Dimitri Glazkov. 13540 13541 [DRT/Chromium] Add CppVariant and CppBoundClass 13542 https://bugs.webkit.org/show_bug.cgi?id=35634 13543 13544 Add CppVariant and CppBoundClass classes, which are going to be 13545 used by DumpRenderTree Chromium port. These files are based on: 13546 - src/webkit/glue/cpp_variant.{cc,h} and 13547 - src/webkit/glue/cpp_bound_class.{cc,h} 13548 of Chromium rev.40492. 13549 13550 * DumpRenderTree/chromium/CppBoundClass.cpp: Added. 13551 * DumpRenderTree/chromium/CppBoundClass.h: Added. 13552 * DumpRenderTree/chromium/CppVariant.cpp: Added. 13553 * DumpRenderTree/chromium/CppVariant.h: Added. 13554 135552010-03-04 Mark Rowe <mrowe@apple.com> 13556 13557 Build fix for older versions of Ruby. 13558 13559 * Scripts/check-for-webkit-framework-include-consistency: 13560 135612010-03-04 Mark Rowe <mrowe@apple.com> 13562 13563 Reviewed by Sam Weinig. 13564 13565 Add a script to verify that WebKit framework headers are internally consistent. 13566 13567 This script detects the following problematic situations: 13568 * An exported WebKit header that includes a header from WebCore. 13569 * An exported WebKit header that includes a header that does not exist in the WebKit framework. 13570 * A public WebKit header that includes a private WebKit header. 13571 13572 * Scripts/check-for-webkit-framework-include-consistency: Added. 13573 135742010-03-04 Dumitru Daniliuc <dumi@chromium.org> 13575 13576 Reviewed by Adam Roben. 13577 13578 Making sure that the correct path is set before invoking 13579 DumpRenderTree on cygwin. 13580 13581 https://bugs.webkit.org/show_bug.cgi?id=35768 13582 13583 * Scripts/run-webkit-tests: 13584 135852010-03-04 Simon Fraser <simon.fraser@apple.com> 13586 13587 Revert the exceptions I just added, and make the error clearer. 13588 13589 * Scripts/check-for-global-initializers: 13590 135912010-03-04 Simon Fraser <simon.fraser@apple.com> 13592 13593 Build fix: add exceptions to the check-for-global-initializers script 13594 for FocusController and SpatialNavigation, and improve the script 13595 to actually print out the globals found. 13596 13597 * Scripts/check-for-global-initializers: 13598 135992010-03-04 Dirk Pranke <dpranke@chromium.org> 13600 13601 Reviewed by Dimitri Glazkov. 13602 13603 Fix dangling reference to "port" instead of "self._port_obj" that 13604 was preventing the http_server from starting on Windows. 13605 13606 * Scripts/webkitpy/layout_tests/port/http_server.py: 13607 136082010-03-04 Diego Gonzalez <diego.gonzalez@openbossa.org> 13609 13610 Reviewed by Simon Hausmann. 13611 13612 Make Qt DumpRenderTree EventSender able to send double click events 13613 13614 LayoutTests: 13615 fast/events/dblclick-addEventListener.html 13616 13617 [Qt] DRT: Send double click event from EventSender 13618 https://bugs.webkit.org/show_bug.cgi?id=35255 13619 13620 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 13621 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 13622 * DumpRenderTree/qt/EventSenderQt.cpp: 13623 (EventSender::EventSender): 13624 (EventSender::mouseDown): 13625 * DumpRenderTree/qt/EventSenderQt.h: 13626 (EventSender::resetClickCount): 13627 136282010-03-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 13629 13630 Reviewed by Tor Arne Vestbø. 13631 13632 [Qt] Make the OUTPUT_DIR variable in qmake projects independent of build-webkit's logic. 13633 13634 This also allows shadow builds relying only on qmake to work properly. 13635 13636 * DumpRenderTree/qt/DumpRenderTree.pro: 13637 * DumpRenderTree/qt/ImageDiff.pro: 13638 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 13639 * QtLauncher/QtLauncher.pro: 13640 136412010-03-04 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 13642 13643 Reviewed by Kenneth Rohde Christiansen. 13644 13645 Enable to use built-product-archive on Qt platform. 13646 13647 * BuildSlaveSupport/built-product-archive: 13648 136492010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 13650 13651 Reviewed by Simon Hausmann. 13652 13653 Add a missing 'm_' to class variables names. 13654 13655 [Qt] QtLauncher is not respecting class variable names 13656 https://bugs.webkit.org/show_bug.cgi?id=35542 13657 13658 * QtLauncher/main.cpp: 13659 (LauncherWindow::LauncherWindow): 13660 (LauncherWindow::init): 13661 (LauncherWindow::sendTouchEvent): 13662 (LauncherWindow::eventFilter): 13663 (LauncherWindow::zoomIn): 13664 (LauncherWindow::zoomOut): 13665 (LauncherWindow::resetZoom): 13666 (LauncherWindow::setEditable): 13667 (LauncherWindow::setTouchMocking): 13668 (LauncherWindow::initializeView): 13669 (LauncherWindow::createChrome): 13670 136712010-03-03 Alexey Proskuryakov <ap@apple.com> 13672 13673 Rubber-stamped by Mark Rowe. 13674 13675 Exclude leaks in Java that build bot complains about. 13676 13677 * Scripts/run-webkit-tests: 13678 136792010-03-03 Chris Marrin <cmarrin@apple.com> 13680 13681 Reviewed by Simon Fraser. 13682 13683 Additional change to separate Accelerated Compositing test from 3D Rendering test 13684 https://bugs.webkit.org/show_bug.cgi?id=35610 13685 13686 I am now using #if ENABLED(3D_RENDERING) to emit the 3DRendering string from 13687 DRT or not. This allows these flags to set independently. I also improved 13688 the code flow in run-webkit-tests a bit. 13689 13690 * DumpRenderTree/win/DumpRenderTree.cpp: 13691 (main): 13692 * Scripts/run-webkit-tests: 13693 136942010-03-03 Chris Marrin <cmarrin@apple.com> 13695 13696 Reviewed by Simon Fraser. 13697 13698 Added ability to print supported features to console to DRT 13699 https://bugs.webkit.org/show_bug.cgi?id=35610 13700 13701 This currently only prints whether or not Accelerated Compositing 13702 and 3D Rendering are supported, which is the only way to tell if you 13703 can run the compositing LayoutTests on Windows. But it can be expanded 13704 to give more information as needed. Currently it prints that both 13705 AcceleratedCompositing and 3DRendering are available if accelerated compositing 13706 is enabled since both have to be turned on together. This allows me to maintain 13707 separate checks for them. 13708 13709 * DumpRenderTree/win/DumpRenderTree.cpp:Added --print-supported-features flag 13710 (main): 13711 * Scripts/run-webkit-tests:Runs DRT and enabled compositing tests if HW comp is available on Windows 13712 137132010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 13714 13715 Reviewed by Simon Hausmann. 13716 13717 Refactor QtLauncher so it respects command line arguments 13718 and inherits settings when you clone or create a new window. 13719 13720 Implemented with help of Kenneth Rohde Christiansen. 13721 13722 [Qt] QtLauncher must be refactored to fix command line arguments usage 13723 https://bugs.webkit.org/show_bug.cgi?id=35536 13724 13725 * QtLauncher/main.cpp: 13726 (LauncherWindow::LauncherWindow): 13727 (LauncherWindow::init): 13728 (LauncherWindow::isGraphicsBased): 13729 (applySetting): 13730 (LauncherWindow::applyPrefs): 13731 (LauncherWindow::initializeView): 13732 (LauncherWindow::newWindow): 13733 (LauncherWindow::cloneWindow): 13734 (LauncherWindow::createChrome): 13735 (main): 13736 * QtLauncher/webview.cpp: 13737 (WebViewGraphicsBased::WebViewGraphicsBased): 13738 (WebViewGraphicsBased::setFrameRateMeasurementEnabled): 13739 * QtLauncher/webview.h: 13740 (WebViewGraphicsBased::itemCacheMode): 13741 (WebViewGraphicsBased::frameRateMeasurementEnabled): 13742 137432010-03-02 Arno Renevier <arno@renevier.net> 13744 13745 Reviewed by Gustavo Noronha Silva. 13746 13747 [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame 13748 https://bugs.webkit.org/show_bug.cgi?id=35210 13749 13750 * DumpRenderTree/gtk/DumpRenderTree.cpp: 13751 (geolocationPolicyDecisionRequested): 13752 (createWebView): 13753 137542010-03-02 Dirk Pranke <dpranke@chromium.org> 13755 13756 Reviewed by David Levin. 13757 13758 Revert r55339 - the Chromium codebase downstream had a temporary 13759 need for WebKitTools/pywebsocket to still exist after Chris Jerdonek 13760 had moved it (scripts still referenced the old location). Those 13761 scripts have been updated to the new location, so it should be safe 13762 to delete this now. 13763 13764 https://bugs.webkit.org/show_bug.cgi?id=35614 13765 13766 * pywebsocket/mod_pywebsocket/standalone.py: Removed. 13767 137682010-03-02 Dirk Pranke <dpranke@chromium.org> 13769 13770 Reviewed by Dimitri Glazkov. 13771 13772 new-run-webkit-tests on chromium-linux tests to see if 13773 layout_test_helper exists, but we don't use layout_test_helper on 13774 linux. The test derefences a None object, and we crash. This fixes 13775 that. 13776 13777 https://bugs.webkit.org/show_bug.cgi?id=35602 13778 13779 * Scripts/webkitpy/layout_tests/port/chromium.py: 13780 13781 2010-03-02 Dirk Pranke <dpranke@chromium.org> 13782 13783 Reviewed by Dimitri Glazkov. 13784 13785 r55388 (bug 35553) worked around a bug in Python's subprocess.Popen() 13786 that was causing DRT to hang on exit in new-run-webkit-tests. 13787 Unfortunately, that workaround doesn't work on chromium-win 13788 (and the script fails completely). The good news is that the check 13789 isn't actually necessary, and so this change makes it conditional. 13790 13791 https://bugs.webkit.org/show_bug.cgi?id=35601 13792 13793 * Scripts/webkitpy/layout_tests/port/chromium.py: 13794 137952010-03-02 Mark Rowe <mrowe@apple.com> 13796 13797 Reviewed by Darin Adler. 13798 13799 Bug 35576: WebKit should tell plug-in instances when private browsing state changes 13800 <http://webkit.org/b/35576> 13801 13802 TestNetscapePlugin is another bit of plug-in code where copy-paste was heavily used 13803 when porting. Update the Windows and UNIX implementations of NPP_New and NPP_SetValue 13804 to provide the expected behavior related to NPNVprivateModeBool. Hopefully this code 13805 duplication can be cleaned up in the future. 13806 13807 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 13808 (webkit_test_plugin_new_instance): 13809 (webkit_test_plugin_set_value): 13810 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 13811 (NPP_New): 13812 (NPP_SetValue): 13813 138142010-03-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 13815 13816 Reviewed by Alexey Proskuryakov. 13817 13818 Test plugin still has issues with releasing objects, and variants 13819 https://bugs.webkit.org/show_bug.cgi?id=35587 13820 13821 Fix the conditions for releasing the variants after calling 13822 invoke, and avoid having a number of objects leak. 13823 13824 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 13825 (testDocumentOpen): 13826 (testWindowOpen): 13827 138282010-03-02 Chris Jerdonek <cjerdonek@webkit.org> 13829 13830 Reviewed by Shinichiro Hamaji. 13831 13832 Refactored the StyleChecker class's file-processing method 13833 _process_file(). This will make it easier to add new 13834 file-processing capabilities to check-webkit-style. 13835 13836 https://bugs.webkit.org/show_bug.cgi?id=35490 13837 13838 * Scripts/webkitpy/style/checker.py: 13839 - Added a _read_lines() method to the StyleChecker class 13840 that extracts the lines from a file. 13841 - Replaced part of _process_file() with a call to the new 13842 _read_lines() method. 13843 - Replaced another part of _process_file() with a call 13844 to the new CarriageReturnProcessor.process() method. 13845 13846 * Scripts/webkitpy/style/processors/common.py: 13847 - Replaced the check_no_carriage_return() function with a 13848 new CarriageReturnProcessor class. 13849 13850 * Scripts/webkitpy/style/processors/common_unittest.py: 13851 - Renamed the CarriageReturnTest class to 13852 CarriageReturnProcessorTest and updated it as necessary. 13853 138542010-03-02 Chris Jerdonek <cjerdonek@webkit.org> 13855 13856 Reviewed by Shinichiro Hamaji. 13857 13858 Started using the logging module in check-webkit-style. 13859 This provides more options for debugging and a more flexible, 13860 uniform way to report messages to the end-user. 13861 13862 https://bugs.webkit.org/show_bug.cgi?id=35484 13863 13864 Also included classes in a central location to facilitate 13865 the unit testing of logging code (setUp and tearDown of unit 13866 test logging configurations, etc). 13867 13868 * Scripts/check-webkit-style: 13869 - Added a call to configure_logging() in the beginning of main(). 13870 - Replaced two calls to sys.stderr.write() with appropriate 13871 logging calls. 13872 13873 * Scripts/webkitpy/init/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. 13874 13875 * Scripts/webkitpy/init/logtesting.py: Added. 13876 - Added a UnitTestLogStream class to capture log output 13877 during unit tests. 13878 - Added a UnitTestLog class that provides convenience methods 13879 for unit-testing logging code. 13880 13881 * Scripts/webkitpy/style/checker.py: 13882 - Added a configure_logging() method. 13883 - Added a _LevelLoggingFilter class to filter out log messages 13884 above a certain logging level. 13885 - Removed the _stderr_write() method from the StyleChecker class 13886 and replaced its use with appropriate logging calls. 13887 13888 * Scripts/webkitpy/style/checker_unittest.py: 13889 - Added a ConfigureLoggingTest class to unit test the 13890 configure_logging() method. 13891 - Updated the StyleCheckerCheckFileTest class as necessary. 13892 13893 * Scripts/webkitpy/style_references.py: 13894 - Added references to logtesting.UnitTestLog and 13895 logtesting.UnitTestLogStream. 13896 138972010-03-01 Chris Fleizach <cfleizach@apple.com> 13898 13899 Fixing broken DRT on Leopard/Tiger. Second try. 13900 13901 AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver 13902 https://bugs.webkit.org/show_bug.cgi?id=35514 13903 13904 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 13905 139062010-03-01 Chris Fleizach <cfleizach@apple.com> 13907 13908 Fixing broken DRT on Leopard/Tiger. 13909 13910 AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver 13911 https://bugs.webkit.org/show_bug.cgi?id=35514 13912 13913 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 13914 139152010-03-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 13916 13917 Reviewed by Eric Seidel. 13918 13919 [GTK] plugins/setProperty.html fails on 64bit Release 13920 https://bugs.webkit.org/show_bug.cgi?id=35425 13921 13922 Check invoke's return code before releasing the variant, since 13923 there's a chance it won't be properly initialized, leading to 13924 memory corruption, in some cases. 13925 13926 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 13927 (testCallback): 13928 (testEnumerate): 13929 (testDocumentOpen): 13930 (testWindowOpen): 13931 (handleCallback): 13932 139332010-03-01 Dirk Pranke <dpranke@chromium.org> 13934 13935 Reviewed by nobody. Build bustage :( 13936 13937 Fix stupid typo that I committed even after David Levin pointed 13938 it out to me :( 13939 13940 https://bugs.webkit.org/show_bug.cgi?id=35553 13941 13942 * Scripts/webkitpy/layout_tests/port/mac.py: 13943 139442010-03-01 Chris Fleizach <cfleizach@apple.com> 13945 13946 Reviewed by Darin Adler. 13947 13948 AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver 13949 https://bugs.webkit.org/show_bug.cgi?id=35514 13950 13951 Add rowCount, columnCount for tables. 13952 13953 * DumpRenderTree/AccessibilityUIElement.cpp: 13954 (rowCountCallback): 13955 (columnCountCallback): 13956 (AccessibilityUIElement::getJSClass): 13957 * DumpRenderTree/AccessibilityUIElement.h: 13958 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 13959 (AccessibilityUIElement::rowCount): 13960 (AccessibilityUIElement::columnCount): 13961 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 13962 (AccessibilityUIElement::rowCount): 13963 (AccessibilityUIElement::columnCount): 13964 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 13965 (AccessibilityUIElement::rowCount): 13966 (AccessibilityUIElement::columnCount): 13967 139682010-03-01 Dirk Pranke <dpranke@chromium.org> 13969 13970 Reviewed by Eric Seidel. 13971 13972 Work around a bug in Python's subprocess.Popen() that keeps us from 13973 cleaning up DumpRenderTree / test_shell properly when we finish the 13974 tests in new-run-webkit-tests. 13975 13976 https://bugs.webkit.org/show_bug.cgi?id=35553 13977 13978 * Scripts/webkitpy/layout_tests/port/chromium.py: 13979 * Scripts/webkitpy/layout_tests/port/mac.py: 13980 139812010-03-01 Arno Renevier <arno@renevier.net> 13982 13983 Reviewed by Xan Lopez. 13984 13985 webkit-build could pass unknown arguments to autogen.sh 13986 https://bugs.webkit.org/show_bug.cgi?id=35454 13987 13988 * Scripts/build-webkit: 13989 139902010-03-01 Dirk Pranke <dpranke@chromium.org> 13991 13992 Rubber-stamped by Dimitri Glazkov. 13993 13994 Fix breakage from r55372. 13995 13996 https://bugs.webkit.org/show_bug.cgi?id=35549 13997 13998 * Scripts/webkitpy/layout_tests/port/chromium.py: 13999 140002010-03-01 Adam Barth <abarth@webkit.org> 14001 14002 Reviewed by Eric Seidel. 14003 14004 EWS can hang for five hours when compile output is too big 14005 https://bugs.webkit.org/show_bug.cgi?id=35545 14006 14007 * Scripts/webkitpy/commands/queues.py: Limit uploads to 1MB instead of 14008 5MB. AppEngine seems to not like 5MB uploads. I'm not sure what the 14009 limit is. Let's try 1MB for a while and see how it goes. 14010 * Scripts/webkitpy/networktransaction.py: Tune the default parameters 14011 to our exponential backoff. I'm not sure why I picked five hours as 14012 the retry limit. That seems way too large. 14013 140142010-03-01 Brady Eidson <beidson@apple.com> 14015 14016 Reviewed by Sam Weinig. 14017 14018 REGRESSION: Telling a WebView to go to its current WebHistoryItem is broken. 14019 <rdar://problem/7699371> and https://bugs.webkit.org/show_bug.cgi?id=35532 14020 14021 * DumpRenderTree/LayoutTestController.cpp: 14022 (apiTestGoToCurrentBackForwardItemCallback): 14023 (LayoutTestController::staticFunctions): 14024 * DumpRenderTree/LayoutTestController.h: 14025 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 14026 (LayoutTestController::apiTestGoToCurrentBackForwardItem): 14027 14028 Stubs for now: 14029 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 14030 (LayoutTestController::apiTestGoToCurrentBackForwardItem): 14031 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 14032 (LayoutTestController::apiTestGoToCurrentBackForwardItem): 14033 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 14034 (LayoutTestController::apiTestGoToCurrentBackForwardItem): 14035 140362010-03-01 Dirk Pranke <dpranke@chromium.org> 14037 14038 Reviewed by David Levin. 14039 14040 General cleanup of error handling in new-run-webkit-tests. 14041 14042 Add Port.check_build() call that is separate from Port.check_sys_deps() 14043 (and add a --nocheck-build flag to skip). This breaks a circular 14044 dependency where you would start the layout test helper before 14045 checking sys deps, but checking sys deps was the thing that told 14046 you if your binaries where there. 14047 14048 Also, made Port.check_sys_deps(), start_helper() and stop_helper() 14049 optional by providing default implementations in the base class 14050 rather than requiring ports to implement the routines regardless 14051 of whether or not they were needed. 14052 14053 Lastly, tweak a bunch of log messages to be cleaner, including 14054 changing messages in thirdparty/autoinstall.py to be silent at 14055 the default log level. 14056 14057 http://bugs.webkit.org/show_bug.cgi?id=35416 14058 14059 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 14060 * Scripts/webkitpy/layout_tests/port/base.py: 14061 * Scripts/webkitpy/layout_tests/port/chromium.py: 14062 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 14063 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 14064 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 14065 * Scripts/webkitpy/layout_tests/port/mac.py: 14066 * Scripts/webkitpy/layout_tests/port/passing.py: 14067 * Scripts/webkitpy/layout_tests/port/test.py: 14068 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 14069 * Scripts/webkitpy/thirdparty/autoinstall.py 14070 140712010-03-01 Dirk Pranke <dpranke@chromium.org> 14072 14073 Reviewed by David Levin. 14074 14075 new-chromium-webkit-tests --platform=mac-leopard diffs are backwards 14076 https://bugs.webkit.org/show_bug.cgi?id=35265 14077 14078 Some parts of the code passed arguments as 14079 "actual, expected" and some passed as "expected, actual". 14080 As you might imagine, this lead to great confusion and wrongness. 14081 Standardize on "expected, actual" as that's the order which is 14082 passed to the underlying diff tool. 14083 14084 Based on a patch by Eric Siedel <eric@webkit.org>. 14085 14086 * Scripts/webkitpy/layout_tests/port/base.py: 14087 * Scripts/webkitpy/layout_tests/port/chromium.py: 14088 * Scripts/webkitpy/layout_tests/port/test.py: 14089 * Scripts/webkitpy/layout_tests/test_types/image_diff.py 14090 140912010-03-01 Chris Jerdonek <cjerdonek@webkit.org> 14092 14093 Unreviewed. 14094 14095 Rolling out: http://trac.webkit.org/changeset/55348 14096 14097 https://bugs.webkit.org/show_bug.cgi?id=35163 14098 14099 Rolling out since the changes to autoinstall do not work 14100 with Python 2.4. In particular, ZipFile.extractall() was 14101 added in Python 2.6. 14102 14103 * Scripts/webkitpy/__init__.py: 14104 * Scripts/webkitpy/bugzilla.py: 14105 * Scripts/webkitpy/init/__init__.py: Removed. 14106 * Scripts/webkitpy/init/autoinstall.py: Removed. 14107 * Scripts/webkitpy/networktransaction.py: 14108 * Scripts/webkitpy/networktransaction_unittest.py: 14109 * Scripts/webkitpy/statusserver.py: 14110 * Scripts/webkitpy/thirdparty/autoinstall.py: Added. 14111 141122010-03-01 Chris Jerdonek <cjerdonek@webkit.org> 14113 14114 Unreviewed. 14115 14116 Rolling out r55350: http://trac.webkit.org/changeset/55350 14117 14118 https://bugs.webkit.org/show_bug.cgi?id=33639 14119 14120 Need to roll out because this patch (pep8) depends on the newly 14121 rewritten autoinstall.py (r55348), which is breaking for people 14122 with Python 2.4: 14123 14124 https://bugs.webkit.org/show_bug.cgi?id=35163#c21 14125 14126 That revision also needs to be rolled out and will be rolled out next. 14127 14128 * Scripts/webkitpy/style/checker.py: 14129 * Scripts/webkitpy/style/checker_unittest.py: 14130 * Scripts/webkitpy/style/processors/python.py: Removed. 14131 * Scripts/webkitpy/style/processors/python_unittest.py: Removed. 14132 * Scripts/webkitpy/style/processors/python_unittest_input.py: Removed. 14133 * Scripts/webkitpy/style/unittests.py: 14134 * Scripts/webkitpy/style_references.py: 14135 141362010-02-28 Chris Jerdonek <cjerdonek@webkit.org> 14137 14138 Reviewed by Shinichiro Hamaji. 14139 14140 Exempted WebKitTools/Scripts/webkitpy/thirdparty from all 14141 style checks except for the whitespace/carriage_return check 14142 and the pep8 tab and trailing white space checks. 14143 14144 https://bugs.webkit.org/show_bug.cgi?id=35497 14145 14146 * Scripts/webkitpy/style/checker.py: 14147 - Adjusted the _PATH_RULES_SPECIFIER configuration as necessary. 14148 - Added enough pep8 categories to _all_categories() for the 14149 unit tests to pass. 14150 14151 * Scripts/webkitpy/style/checker_unittest.py: 14152 - Updated the test_path_rules_specifier() unit test. 14153 141542010-02-27 Chris Jerdonek <cjerdonek@webkit.org> 14155 14156 Reviewed by David Levin. 14157 14158 Added Python style checking to check-webkit-style using 14159 the third-party pep8 module (via autoinstall). 14160 14161 https://bugs.webkit.org/show_bug.cgi?id=33639 14162 14163 * Scripts/webkitpy/style/checker.py: 14164 - Added PYTHON to FileType. 14165 - Updated ProcessorDispatcher to return a PythonProcessor 14166 for *.py files. 14167 14168 * Scripts/webkitpy/style/checker_unittest.py: 14169 - Updated the ProcessorDispatcher unit tests for *.py files. 14170 14171 * Scripts/webkitpy/style/processors/python.py: Added. 14172 - Added PythonProcessor class. 14173 14174 * Scripts/webkitpy/style/processors/python_unittest.py: Added. 14175 - Added PythonProcessor unit tests. 14176 14177 * Scripts/webkitpy/style/processors/python_unittest_input.py: Added. 14178 - Added a sample Python file to test the PythonProcessor.process() 14179 code path (since pep8 accepts a file path). 14180 14181 * Scripts/webkitpy/style/unittests.py: 14182 - Updated the style unit test file to import python_unittest.py. 14183 14184 * Scripts/webkitpy/style_references.py: 14185 - Adjusted style references to import pep8. 14186 141872010-02-26 Chris Jerdonek <cjerdonek@webkit.org> 14188 14189 Reviewed by David Levin. 14190 14191 Rewrote autoinstall.py to support unzipping *.zip files after 14192 download, unzipping and extracting *.tar.gz files after download, 14193 and copying installed files to a destination directory. 14194 14195 https://bugs.webkit.org/show_bug.cgi?id=35163 14196 14197 These changes will allow us to autoinstall pep8.py from the web 14198 and to put our third-party autoinstalled code in an explicit 14199 directory like webkitpy/thirdparty/autoinstalled. They should 14200 also speed up imports from autoinstalled *.zip packages slightly 14201 since *.pyc files cannot be generated when importing from 14202 zipped packages. 14203 14204 * Scripts/webkitpy/__init__.py: 14205 - Updated the autoinstall lines to use the new autoinstall methods. 14206 - Added pep8.py to the list of auto-installed packages. 14207 14208 * Scripts/webkitpy/bugzilla.py: 14209 - Updated mechanize import path. 14210 14211 * Scripts/webkitpy/init/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. 14212 14213 * Scripts/webkitpy/init/autoinstall.py: Added. 14214 - Added AutoInstaller class. 14215 - Added sample testing usage to __main__. 14216 14217 * Scripts/webkitpy/networktransaction.py: 14218 - Updated mechanize import path. 14219 14220 * Scripts/webkitpy/networktransaction_unittest.py: 14221 - Updated mechanize import path. 14222 14223 * Scripts/webkitpy/statusserver.py: 14224 - Updated mechanize import path. 14225 14226 * Scripts/webkitpy/thirdparty/autoinstall.py: Removed. 14227 - Replaced with rewritten autoinstall in init/autoinstall.py. 14228 142292010-02-26 Dirk Pranke <dpranke@chromium.org> 14230 14231 Reviewed by Adam Barth. 14232 14233 Change the default port for new-run-webkit-tests when running on 14234 a Mac from 'chromium-mac' to 'mac'. Add a '--chromium' switch to 14235 pick up the default platform-specific version of chromium instead. 14236 14237 https://bugs.webkit.org/show_bug.cgi?id=35462 14238 14239 * Scripts/webkitpy/layout_tests/port/factory.py: 14240 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 14241 142422010-02-26 Dirk Pranke <dpranke@chromium.org> 14243 14244 Unreviewed, build fix 14245 14246 third time's the charm getting this path right? 14247 14248 * pywebsocket/mod_pywebsocket/standalone.py: 14249 142502010-02-26 Dumitru Daniliuc <dumi@chromium.org> 14251 14252 Unreviewed, build fix. 14253 14254 * pywebsocket/mod_pywebsocket/standalone.py: 14255 142562010-02-26 Dumitru Daniliuc <dumi@chromium.org> 14257 14258 Reviewed by Dimitri Glazkov. 14259 14260 Moving the script to the right location. 14261 14262 * pywebsocket/mod_pywebsocket: Added. 14263 * pywebsocket/mod_pywebsocket/standalone.py: Copied from WebKitTools/pywebsocket/standalone.py. 14264 * pywebsocket/standalone.py: Removed. 14265 142662010-02-26 Dumitru Daniliuc <dumi@chromium.org> 14267 14268 Unreviewed, fixing the license. 14269 14270 * pywebsocket/standalone.py: 14271 142722010-02-26 Dumitru Daniliuc <dumi@chromium.org> 14273 14274 Reviewed by Adam Barth. 14275 14276 Adding pywebsocket/standalone.py back to fix the Chromium webkit 14277 canaries. Once all layout tests pass, we can get in the patch that 14278 moves this directorty to WebKitTools/Scripts, update all Chromium 14279 scripts, and revert this patch. 14280 14281 https://bugs.webkit.org/show_bug.cgi?id=35464 14282 14283 * pywebsocket: Added. 14284 * pywebsocket/standalone.py: Added. 14285 142862010-02-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 14287 14288 Reviewed by Xan Lopez. 14289 14290 [GTK] Needs proper reporting of frame loader callbacks, in DRT 14291 https://bugs.webkit.org/show_bug.cgi?id=32170 14292 14293 Fix reporting of unload handlers, so that it is emitted where 14294 needed, not after it. 14295 14296 * DumpRenderTree/gtk/DumpRenderTree.cpp: 14297 (webViewLoadFinished): 14298 (webViewDocumentLoadFinished): 14299 (createWebView): 14300 143012010-02-26 Antonio Gomes <tonikitoo@webkit.org> 14302 14303 Reviewed by Gustavo Noronha. 14304 Patch by Antonio Gomes <tonikitoo@webkit.org> 14305 14306 [Gtk] Make DRT EventSender::keyDown to consider 'hardware_keycode' field when synthesizing an event. 14307 https://bugs.webkit.org/show_bug.cgi?id=35432 14308 14309 When a directional key-press event (arrow keys, End, Home, PageUp, 14310 PageDown, etc) is synthesized by DRT's EventSender and it targets 14311 an editor (e.g. <input type=text>, <textare>, etc), event is processed 14312 by WebCore::EventHandler. On the other hand, if event target is not 14313 an editor, event is bubbled up to Gtk+ for processing. In such cases, 14314 if 'hardware_keycode' is not provided at event synthesize time 14315 its processing fails (at some point in gtk_bindings_activate_event), 14316 and no scroll action is performed. 14317 14318 Unskip fast/events/node-event-anchor-lock.html 14319 14320 * DumpRenderTree/win/EventSender.cpp: 14321 (keyDownCallback): 14322 * platform/gtk/Skipped: 14323 143242010-02-26 Dimitri Glazkov <dglazkov@chromium.org> 14325 14326 Reviewed by David Levin. 14327 14328 new-webkit-run-tests: Extraneous parenthesis in websocket_server.py 14329 https://bugs.webkit.org/show_bug.cgi?id=35436 14330 14331 * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed extra paren. 14332 143332010-02-26 Chris Jerdonek <cjerdonek@webkit.org> 14334 14335 Reviewed by David Levin. 14336 14337 Moved pywebsocket into the webkitpy/thirdparty directory and added 14338 an associated README.webkit file to the pywebsocket directory. 14339 This makes pywebsocket more consistent with the other third-party 14340 Python code in our repository. 14341 14342 https://bugs.webkit.org/show_bug.cgi?id=35198 14343 14344 * Scripts/run-webkit-tests: 14345 - Updated paths to pywebsocket. 14346 14347 * Scripts/run-webkit-websocketserver: 14348 - Updated paths to pywebsocket. 14349 14350 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 14351 - Updated paths to pywebsocket. 14352 14353 * Scripts/webkitpy/thirdparty/pywebsocket: Copied from WebKitTools/pywebsocket. 14354 * Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added. 14355 - Added a file containing information about the contents 14356 of the pywebsocket directory. This will make it easier to 14357 understand where the third-party code came from and what 14358 local changes have been made. 14359 14360 * pywebsocket: Removed. 14361 * pywebsocket/COPYING: Removed. 14362 * pywebsocket/MANIFEST.in: Removed. 14363 * pywebsocket/README: Removed. 14364 * pywebsocket/example: Removed. 14365 * pywebsocket/example/echo_client.py: Removed. 14366 * pywebsocket/example/echo_wsh.py: Removed. 14367 * pywebsocket/mod_pywebsocket: Removed. 14368 * pywebsocket/mod_pywebsocket/__init__.py: Removed. 14369 * pywebsocket/mod_pywebsocket/dispatch.py: Removed. 14370 * pywebsocket/mod_pywebsocket/handshake.py: Removed. 14371 * pywebsocket/mod_pywebsocket/headerparserhandler.py: Removed. 14372 * pywebsocket/mod_pywebsocket/memorizingfile.py: Removed. 14373 * pywebsocket/mod_pywebsocket/msgutil.py: Removed. 14374 * pywebsocket/mod_pywebsocket/standalone.py: Removed. 14375 * pywebsocket/mod_pywebsocket/util.py: Removed. 14376 * pywebsocket/setup.py: Removed. 14377 * pywebsocket/test: Removed. 14378 * pywebsocket/test/config.py: Removed. 14379 * pywebsocket/test/mock.py: Removed. 14380 * pywebsocket/test/run_all.py: Removed. 14381 * pywebsocket/test/test_dispatch.py: Removed. 14382 * pywebsocket/test/test_handshake.py: Removed. 14383 * pywebsocket/test/test_memorizingfile.py: Removed. 14384 * pywebsocket/test/test_mock.py: Removed. 14385 * pywebsocket/test/test_msgutil.py: Removed. 14386 * pywebsocket/test/test_util.py: Removed. 14387 * pywebsocket/test/testdata: Removed. 14388 * pywebsocket/test/testdata/handlers: Removed. 14389 * pywebsocket/test/testdata/handlers/blank_wsh.py: Removed. 14390 * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Removed. 14391 * pywebsocket/test/testdata/handlers/sub: Removed. 14392 * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Removed. 14393 * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Removed. 14394 * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Removed. 14395 * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Removed. 14396 * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Removed. 14397 * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Removed. 14398 143992010-02-26 Chris Jerdonek <cjerdonek@webkit.org> 14400 14401 Reviewed by Eric Seidel. 14402 14403 Changed the diff_parser module to log to a module-specific 14404 logging.logger rather than the root logger. 14405 14406 https://bugs.webkit.org/show_bug.cgi?id=35391 14407 14408 * Scripts/webkitpy/diff_parser.py: 14409 144102010-02-26 Csaba Osztrogonác <ossy@webkit.org> 14411 14412 Reviewed by Kenneth Rohde Christiansen. 14413 14414 [Qt] LayoutTestController.numberOfPages() should have default parameters 14415 https://bugs.webkit.org/show_bug.cgi?id=35428 14416 14417 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: maxViewWidth and maxViewHeight moved to 14418 LayoutTestController to converge to platform independent implementation. 14419 (WebCore::DumpRenderTree::DumpRenderTree): 14420 (WebCore::DumpRenderTree::open): 14421 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Initialization of maxViewWidth and maxViewHeight added. 14422 * DumpRenderTree/qt/LayoutTestControllerQt.h: 14423 - Default parameters for LayoutTestController.numberOfPages() added. 14424 - maxViewWidth and maxViewHeight members added. 14425 144262010-02-26 Jamey Hicks <jamey.hicks@nokia.com> 14427 14428 Reviewed by Laszlo Gombos. 14429 14430 [Qt] added QWebSettings::setInspectorUrl() and QWebSettings::inspectorUrl() 14431 14432 Enables the use of alternate Web Inspector frontends by changing 14433 the location of the frontend. The location is specified by providing 14434 -inspector-url url 14435 as an argument to QtLauncher. 14436 14437 This is required so that the Web Inspector may be run from an 14438 external process or an external tool such as Eclipse or Aptana may 14439 be used instead of the in-process Web Inspector UI. 14440 14441 https://bugs.webkit.org/show_bug.cgi?id=35340 14442 14443 * QtLauncher/main.cpp: 14444 (LauncherWindow::init): 14445 (LauncherApplication::handleUserOptions): 14446 144472010-02-25 Dirk Pranke <dpranke@chromium.org> 14448 14449 Reviewed by Eric Seidel. 14450 14451 Add a 'passing' port implementation to new-run-webkit-tests that 14452 acts as a wrapper around an existing implementation but stubs out 14453 the actual test invocations (instead, the expected results are echoed 14454 back to the harness). This is useful for coverage and perf testing 14455 of the harness (especially perf testing as it essentially provides 14456 a lower bound on how fast the harness can run). 14457 14458 Also added a --nostart-helper flag to new-run-webkit-tests so that 14459 you can skip starting the layout_test_helper and actually run the 14460 harness even if you don't have a build of that port. 14461 14462 Also fix a bug in the 'test' port implementation to actually 14463 create the results directory under /tmp instead of /. 14464 14465 https://bugs.webkit.org/show_bug.cgi?id=35370 14466 14467 * Scripts/webkitpy/layout_tests/port/factory.py: Modified. 14468 * Scripts/webkitpy/layout_tests/port/passing.py: Added. 14469 * Scripts/webkitpy/layout_tests/port/test.py: Added. 14470 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Modified. 14471 144722010-02-25 Eric Seidel <eric@webkit.org> 14473 14474 Fix typo in my last change. No review. 14475 14476 Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion 14477 https://bugs.webkit.org/show_bug.cgi?id=35408 14478 14479 * Scripts/new-run-webkit-tests: 14480 144812010-02-25 Eric Seidel <eric@webkit.org> 14482 14483 Reviewed by Adam Barth. 14484 14485 Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion 14486 https://bugs.webkit.org/show_bug.cgi?id=35408 14487 14488 * Scripts/new-run-webkit-tests: Added. 14489 * Scripts/run-chromium-webkit-tests: Removed. 14490 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py. 14491 144922010-02-25 Adam Barth <abarth@webkit.org> 14493 14494 Reviewed by David Levin. 14495 14496 EWS leaks memory slowly 14497 https://bugs.webkit.org/show_bug.cgi?id=35395 14498 14499 The EWS bots leak memory very slowly. If you run them for about a 14500 month, each one will take up around 1 GB of virutal memory. If you run 14501 several of them on one machine, you'll eventually exhaust all available 14502 memory and grind the bots to a halt. 14503 14504 This patch introduces a --exit-after-iteration option to the queues so 14505 that we run them for a finite amount of time. Once they exit and 14506 restart, they'll reclaim the leaked memory. I'm not sure how many 14507 iterations I'll end up running them for. I'll need to sort that out 14508 operationally, but my initial guess is around 1000. 14509 14510 * Scripts/webkitpy/commands/queues.py: 14511 * Scripts/webkitpy/commands/queues_unittest.py: 14512 145132010-02-25 Jarkko Sakkinen <jarkko.sakkinen@tieto.com> 14514 14515 Reviewed by Kenneth Rohde Christiansen. 14516 14517 Qt WebGL support 14518 14519 Adds toggling of WebGL support to QtLauncher. 14520 https://bugs.webkit.org/show_bug.cgi?id=35153 14521 14522 * QtLauncher/main.cpp: 14523 (LauncherWindow::toggleWebGL): 14524 (LauncherWindow::setupUI): 14525 145262010-02-25 Ben Murdoch <benm@google.com> 14527 14528 Reviewed by Kenneth Rohde Christiansen. 14529 14530 The target element of a Touch should be the target where that touch originated, not where it is now. 14531 https://bugs.webkit.org/show_bug.cgi?id=34585 14532 14533 * DumpRenderTree/qt/EventSenderQt.cpp: 14534 (EventSender::addTouchPoint): Fix a bug where touch points were not being given unique ids. 14535 145362010-02-24 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 14537 14538 Reviewed by Kenneth Rohde Christiansen. 14539 14540 [Qt] QtLauncher has a border when running on QGraphicsView mode 14541 https://bugs.webkit.org/show_bug.cgi?id=35352 14542 14543 Fix 2-pixels frame on each border of QtLauncher when running on QGraphicsView mode. 14544 14545 * QtLauncher/webview.cpp: 14546 (WebViewGraphicsBased::WebViewGraphicsBased): 14547 145482010-02-23 Dirk Pranke <dpranke@chromium.org> 14549 14550 Reviewed by David Levin. 14551 14552 When the run-chromium-webkit-tests code was landed and the code was 14553 refactored into the 'port' package, I accidentally broke using 14554 http_server.py or websocket_server.py as command-line scripts 14555 (the constructors needed a port object they weren't getting). This 14556 change fixes them so that --server start|stop actually works. 14557 14558 As a part of this, the two files need to be able to call port.get(), 14559 but doing that is awkward from a file inside the package, so I moved 14560 get() into factory.py and imported that into __init__.py so that 14561 http_server.py and websocket_server.py can just import factory. 14562 14563 https://bugs.webkit.org/show_bug.cgi?id=35316 14564 14565 * Scripts/webkitpy/layout_tests/port/__init__.py: 14566 * Scripts/webkitpy/layout_tests/port/factory.py: 14567 * Scripts/webkitpy/layout_tests/port/http_server.py: 14568 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 14569 145702010-02-24 Dirk Pranke <dpranke@chromium.org> 14571 14572 Reviewed by David Levin. 14573 14574 Fix the function signature for check_sys_deps on the mac port, and 14575 fix the ordering of port_obj.check_sys_deps() and 14576 port_obj.start_helper() (helper needs to be started before we check 14577 the system configuration). 14578 14579 http://bugs.webkit.org/show_bug.cgi?id=35367 14580 14581 * Scripts/webkitpy/layout_tests/port/mac.py: 14582 * Scripts/webkitpy/layout_tests/port/test.py: 14583 * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: 14584 145852010-02-24 James Robinson <jamesr@chromium.org> 14586 14587 Reviewed by Eric Seidel. 14588 14589 Provide default username parameter to SVN.commit_with_message(). 14590 14591 * Scripts/webkitpy/scm.py: 14592 145932010-02-24 Dirk Pranke <dpranke@chromium.org> 14594 14595 Reviewed by Eric Siedel. 14596 14597 Check the proper directory for a WebKit SVN version (Chromium does 14598 not check out the entire WebKit tree directly, but rather pulls 14599 individual subdirectories. So, checking for the SVN version in 14600 WebKit/WebCore rather than just in WebKit works more reliably across 14601 different ports). 14602 14603 http://bugs.webkit.org/show_bug.cgi?id=35321 14604 14605 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 14606 146072010-02-24 Alexey Proskuryakov <ap@apple.com> 14608 14609 Reviewed by Dan Bernstein. 14610 14611 https://bugs.webkit.org/show_bug.cgi?id=35357 14612 Two editing tests fail after DumpRenderTree run loop changes 14613 14614 AppKit decided that it wanted to group all editing commands for some reason (and thus undo 14615 reverted them all at once). 14616 14617 * DumpRenderTree/mac/DumpRenderTree.mm: 14618 (dump): Reverted the change that made DumpRenderTree use -[NSApplication run]. 14619 (runTest): Ditto. 14620 (-[DumpRenderTreeApplication isRunning]): Override isRunning with a function that always 14621 returns YES. This is another way to make the Java plug-in work. 14622 146232010-02-23 Adam Roben <aroben@apple.com> 14624 14625 Make commit-log-editor find just-added ChangeLog files 14626 14627 Fixes <http://webkit.org/b/35294> commit-log-editor doesn't find 14628 just-added ChangeLog files 14629 14630 Reviewed by Dave Levin. 14631 14632 * Scripts/commit-log-editor: 14633 (top level): Modified the regular expression that's used to find 14634 modified ChangeLog files to also look for just-added ChangeLog files. 14635 146362010-02-24 Shinichiro Hamaji <hamaji@chromium.org> 14637 14638 Reviewed by Darin Adler. 14639 14640 check-webkit-style false positive for WebCore forwarding header 14641 https://bugs.webkit.org/show_bug.cgi?id=34604 14642 14643 * Scripts/webkitpy/style/checker.py: 14644 * Scripts/webkitpy/style/checker_unittest.py: 14645 146462010-02-23 Alexey Proskuryakov <ap@apple.com> 14647 14648 Reviewed by Mark Rowe. 14649 14650 https://bugs.webkit.org/show_bug.cgi?id=22602 14651 Enable Java in DumpRenderTree (on Mac) 14652 14653 * DumpRenderTree/mac/DumpRenderTree.mm: 14654 (exitApplicationRunLoop): 14655 (dump): 14656 (runTest): 14657 DumpRenderTree now runs an NSApplication, not just an event loop. This way, the Java plug-in 14658 can start without freezing. 14659 14660 * Scripts/run-webkit-tests: Compile java sources in LayputTests/java. 14661 146622010-02-23 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 14663 14664 Reviewed by Kenneth Rohde Christiansen. 14665 14666 [Qt] Need a final integration between QtLauncher and QGVLauncher 14667 https://bugs.webkit.org/show_bug.cgi?id=35292 14668 14669 WebKit coding style fixes. 14670 14671 * QtLauncher/main.cpp: 14672 (LauncherWindow::resetZoom): 14673 146742010-02-23 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 14675 14676 Reviewed by Kenneth Rohde Christiansen. 14677 14678 [Qt] Need a final integration between QtLauncher and QGVLauncher 14679 https://bugs.webkit.org/show_bug.cgi?id=35292 14680 14681 Add cloneWindow feature to QtLauncher, when running on QGraphicsView mode. 14682 14683 * QtLauncher/main.cpp: 14684 (LauncherWindow::LauncherWindow): 14685 (LauncherWindow::~LauncherWindow): 14686 (LauncherWindow::init): 14687 (LauncherWindow::cloneWindow): 14688 (LauncherWindow::setupUI): 14689 146902010-02-23 Dirk Pranke <dpranke@chromium.org> 14691 14692 Reviewed by Dimitri Glazkov. 14693 14694 Fix handling of check_wdiff_install when wdiff isn't installed. 14695 14696 http://bugs.webkit.org/show_bug.cgi?id=35304 14697 14698 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 14699 147002010-02-23 Leandro Pereira <leandro@profusion.mobi> 14701 14702 Reviewed by NOBODY. 14703 14704 Fix false positives for 'delete *pointer' statements. 14705 http://webkit.org/b/35235 14706 14707 * WebKitTools/Scripts/webkitpy/style/processors/cpp.py: 14708 147092010-02-23 Shinichiro Hamaji <hamaji@chromium.org> 14710 14711 Reviewed by Eric Seidel. 14712 14713 [Gtk] Implement layoutTestController.numberOfPages 14714 https://bugs.webkit.org/show_bug.cgi?id=35228 14715 14716 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 14717 (LayoutTestController::numberOfPages): 14718 147192010-02-23 Laszlo Gombos <laszlo.1.gombos@nokia.com> 14720 14721 Reviewed by Kenneth Rohde Christiansen. 14722 14723 [Qt] QtLauncher should not use internal JavaScriptCore and WebCore interfaces 14724 https://bugs.webkit.org/show_bug.cgi?id=35248 14725 14726 * QtLauncher/QtLauncher.pro: 14727 * QtLauncher/utils.h: 14728 147292010-02-23 Daniel Bates <dbates@rim.com> 14730 14731 Reviewed by Eric Seidel. 14732 14733 https://bugs.webkit.org/show_bug.cgi?id=34439 14734 14735 Prompts a person for their SVN username if not already cached (by Subversion). 14736 14737 Currently, webkit-patch is unable to commit to the SVN repo. unless the 14738 WebKit SVN username is already cached (from of a prior commit by hand) 14739 because "svn commit" (called by webkit-patch) defaults to using the system 14740 login name unless the username is already cached or specified on the 14741 command line. 14742 14743 * Scripts/webkitpy/scm.py: Added methods SVN.has_authorization_for_realm and 14744 modified SVN.commit_with_message to call it. Added optional username parameter 14745 to method SVN.commit_with_message. 14746 * Scripts/webkitpy/scm_unittest.py: Added unit test methods: SVNTest.test_commit_with_username, 14747 SVNTest.test_has_authorization_for_realm, and SVNTest.test_not_have_authorization_for_realm. 14748 147492010-02-22 Dirk Pranke <dpranke@chromium.org> 14750 14751 Reviewed by Eric Siedel. 14752 14753 Add more checking for missing binaries and packages to check_sys_deps() 14754 14755 https://bugs.webkit.org/show_bug.cgi?id=35062 14756 14757 * Scripts/webkitpy/layout_tests/port/base.py: 14758 * Scripts/webkitpy/layout_tests/port/chromium.py: 14759 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 14760 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 14761 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 14762 * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: 14763 147642010-02-22 Shinichiro Hamaji <hamaji@chromium.org> 14765 14766 Reviewed by David Levin. 14767 14768 [Gtk] check-webkit-style: GTK style should be allowed in WebKitTools/DumpRenderTree/gtk 14769 https://bugs.webkit.org/show_bug.cgi?id=35229 14770 14771 * Scripts/webkitpy/style/checker.py: 14772 * Scripts/webkitpy/style/checker_unittest.py: 14773 147742010-02-22 James Robinson <jamesr@chromium.org> 14775 14776 Unreviewed. Adding myself to committers list. 14777 14778 * Scripts/webkitpy/committers.py: 14779 147802010-02-22 Simon Fraser <simon.fraser@apple.com> 14781 14782 Reviewed by Darin Adler. 14783 14784 Remove DRT hack that turns off hardware acceleration with older QuickTimes 14785 https://bugs.webkit.org/show_bug.cgi?id=35275 14786 14787 Now that WebKit does a version check to avoid a QuickTime-related 14788 crash (r55100), DumpRenderTree does not need to. 14789 14790 * DumpRenderTree/mac/DumpRenderTree.mm: 14791 (resetDefaultsToConsistentValues): 14792 147932010-02-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 14794 14795 Reviewed by Kenneth Rohde Christiansen. 14796 14797 [Qt] Build the DRT in debug on Mac OS X 14798 14799 * DumpRenderTree/qt/DumpRenderTree.pro: 14800 148012010-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com> 14802 14803 Reviewed by Kenneth Rohde Christiansen. 14804 14805 [Qt] Add support for layout tests on Symbian 14806 https://bugs.webkit.org/show_bug.cgi?id=31589 14807 14808 * DumpRenderTree/qt/DumpRenderTree.pro: 14809 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 14810 * DumpRenderTree/qt/main.cpp: 14811 (main): 14812 148132010-02-20 Chris Jerdonek <cjerdonek@webkit.org> 14814 14815 Reviewed by Adam Barth. 14816 14817 Moved simplejson into webkitpy/thirdparty directory. 14818 14819 https://bugs.webkit.org/show_bug.cgi?id=35196 14820 14821 * Scripts/run-chromium-webkit-tests: 14822 - Added webkitpy/thirdparty to the script's search path. 14823 14824 * Scripts/webkitpy/thirdparty/simplejson: Copied from WebKitTools/simplejson. 14825 - Copied simplejson directory. 14826 14827 * simplejson: Removed. 14828 * simplejson/LICENSE.txt: Removed. 14829 * simplejson/README.txt: Removed. 14830 * simplejson/__init__.py: Removed. 14831 * simplejson/_speedups.c: Removed. 14832 * simplejson/decoder.py: Removed. 14833 * simplejson/encoder.py: Removed. 14834 * simplejson/jsonfilter.py: Removed. 14835 * simplejson/scanner.py: Removed. 14836 148372010-02-20 Chris Jerdonek <cjerdonek@webkit.org> 14838 14839 Reviewed by Adam Barth. 14840 14841 Moved BeautifulSoup to webkitpy/thirdparty directory. 14842 14843 https://bugs.webkit.org/show_bug.cgi?id=35195 14844 14845 * Scripts/webkitpy/BeautifulSoup.py: Removed. 14846 - Moved to webkitpy/thirdparty. 14847 14848 * Scripts/webkitpy/bugzilla.py: 14849 - Updated import statement. 14850 14851 * Scripts/webkitpy/bugzilla_unittest.py: 14852 - Updated import statement. 14853 14854 * Scripts/webkitpy/buildbot.py: 14855 - Updated import statement. 14856 14857 * Scripts/webkitpy/buildbot_unittest.py: 14858 - Updated import statement. 14859 14860 * Scripts/webkitpy/statusserver.py: 14861 - Updated import statement. 14862 14863 * Scripts/webkitpy/thirdparty/BeautifulSoup.py: Copied from WebKitTools/Scripts/webkitpy/BeautifulSoup.py. 14864 148652010-02-20 Chris Jerdonek <cjerdonek@webkit.org> 14866 14867 Reviewed by Adam Barth. 14868 14869 Created a directory for third-party Python code, and moved 14870 autoinstall.py into it. 14871 14872 https://bugs.webkit.org/show_bug.cgi?id=34540 14873 14874 * Scripts/webkitpy/__init__.py: 14875 - Updated "import autoinstall" statement. 14876 14877 * Scripts/webkitpy/autoinstall.py: Removed. 14878 - Moved to thirdparty/autoinstall.py. 14879 14880 * Scripts/webkitpy/thirdparty: Added. 14881 * Scripts/webkitpy/thirdparty/__init__.py: Added. 14882 * Scripts/webkitpy/thirdparty/autoinstall.py: Copied from WebKitTools/Scripts/webkitpy/autoinstall.py. 14883 148842010-02-20 Gustavo Noronha Silva <gns@gnome.org> 14885 14886 Unreviewed, obvious fix for the python failure in our new buildbot 14887 step: 14888 14889 http://build.webkit.org/builders/GTK Linux 32-bit Release/builds/9075/steps/API tests/logs/err.text 14890 14891 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 14892 148932010-02-19 Maciej Stachowiak <mjs@apple.com> 14894 14895 Reviewed by David Levin. 14896 14897 Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases 14898 https://bugs.webkit.org/show_bug.cgi?id=35147 14899 14900 * Scripts/build-webkit: Handle new flag. 14901 149022010-02-19 Leandro Pereira <leandro@profusion.mobi> 14903 14904 Reviewed by Shinichiro Hamaji. 14905 14906 [style-queue] should not complain about identifier names with underscores under WebKit/efl/ewk/ 14907 https://bugs.webkit.org/show_bug.cgi?id=35091 14908 14909 White list unix_hacker_style names in WebKit/efl/ewk because these 14910 are used in the EFL API. 14911 14912 * Scripts/webkitpy/style/checker.py: 14913 - Filter out readability/naming on WebKit/efl/ewk. 14914 149152010-02-19 Eric Seidel <eric@webkit.org> 14916 14917 Reviewed by Adam Barth. 14918 14919 Split out "prepare-rollout" from "rollout" and make --complete-rollout default 14920 https://bugs.webkit.org/show_bug.cgi?id=33745 14921 14922 * Scripts/webkitpy/commands/download.py: 14923 - Add a new AbstractRolloutPrepCommand to share code between PrepareRollout and Rollout 14924 - Add PrepareRollout 14925 * Scripts/webkitpy/commands/download_unittest.py: Test PrepareRollout, remove CompleteRollout tests. 14926 * Scripts/webkitpy/steps/__init__.py: include ReopenBugAfterRollout step. 14927 * Scripts/webkitpy/steps/completerollout.py: Removed. 14928 * Scripts/webkitpy/steps/options.py: remove complete_rollout 14929 * Scripts/webkitpy/steps/reopenbugafterrollout.py: Added. 14930 149312010-02-19 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 14932 14933 Reviewed by Kenneth Rohde Christiansen. 14934 14935 [Qt] Need a final integration between QtLauncher and QGVLauncher 14936 https://bugs.webkit.org/show_bug.cgi?id=35161 14937 14938 Add animated flip support to QtLauncher when running on QGraphicsView mode. 14939 14940 * QtLauncher/main.cpp: 14941 (LauncherWindow::initializeView): 14942 (LauncherWindow::setupUI): 14943 * QtLauncher/webview.cpp: 14944 (WebViewGraphicsBased::WebViewGraphicsBased): 14945 (WebViewGraphicsBased::animatedFlip): 14946 (WebViewGraphicsBased::animatedYFlip): 14947 * QtLauncher/webview.h: 14948 (WebViewGraphicsBased::setYRotation): 14949 (WebViewGraphicsBased::yRotation): 14950 149512010-02-19 Andras Becsi <abecsi@webkit.org> 14952 14953 Reviewed by Kenneth Rohde Christiansen. 14954 14955 [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results 14956 for passing new tests and unskip the passing ones from the Skipped list. 14957 https://bugs.webkit.org/show_bug.cgi?id=35159 14958 14959 * DumpRenderTree/qt/EventSenderQt.cpp: 14960 (EventSender::textZoomIn): 14961 (EventSender::textZoomOut): 14962 * DumpRenderTree/qt/EventSenderQt.h: 14963 149642010-02-19 Laszlo Gombos <laszlo.1.gombos@nokia.com> 14965 14966 Reviewed by Eric Seidel. 14967 14968 [Qt] Clean-up the handling of HTML5 persistent data for LayoutTests 14969 https://bugs.webkit.org/show_bug.cgi?id=35004 14970 14971 DumpRenderTreeQt.cpp calls QWebSettings::enablePersistentStorage which sets up 14972 and enables all HTML5 persistent data. All the other calls for setting the 14973 persistent path or enabling the persistent feature are redundant. 14974 14975 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 14976 (WebCore::WebPage::WebPage): No need to enable AppCache again. 14977 * DumpRenderTree/qt/main.cpp: 14978 (main): No need to setup and enable HTML5 LocalStorage again. 14979 149802010-02-19 Diego Gonzalez <diego.gonzalez@openbossa.org> 14981 14982 Reviewed by Kenneth Rohde Christiansen. 14983 14984 Send the context menu event from contextClick() of EventSender 14985 and do not show context menu in DRT. 14986 14987 LayoutTests: 14988 fast/events/contextmenu-scrolled-page-with-frame.html 14989 14990 [Qt] DRT: Send context menu event from EventSender 14991 https://bugs.webkit.org/show_bug.cgi?id=35131 14992 14993 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 14994 (WebCore::DumpRenderTree::DumpRenderTree): 14995 * DumpRenderTree/qt/EventSenderQt.cpp: 14996 (EventSender::contextClick): 14997 149982010-02-18 Chris Jerdonek <cjerdonek@webkit.org> 14999 15000 Reviewed by Shinichiro Hamaji. 15001 15002 Moved parsing-related code to a separate file. Also increased 15003 the unit test coverage in some affected areas. 15004 15005 https://bugs.webkit.org/show_bug.cgi?id=34675 15006 15007 This revision contains no new functionality. 15008 15009 * Scripts/check-webkit-style: 15010 - Adjusted to call check_webkit_style_parser(). 15011 15012 * Scripts/webkitpy/style/checker.py: 15013 - Added check_webkit_style_parser() to pass checker.py 15014 configuration settings to optparser.py. 15015 - Moved _create_usage() and the CommandOptionValues, 15016 DefaultCommandOptionValues, ArgumentPrinter, and 15017 ArgumentParser classes to optparser.py. 15018 15019 * Scripts/webkitpy/style/checker_unittest.py: 15020 - Moved the ProcessorOptionsTest, ArgumentPrinterTest, and 15021 ArgumentParserTest classes to optparser.py. 15022 - Added the CheckWebKitStyleFunctionTest class to check 15023 the check_webkit_style_configuration() and 15024 check_webkit_style_parser() code paths. 15025 15026 * Scripts/webkitpy/style/optparser.py: Added. 15027 - From checker.py, added _create_usage() and the 15028 CommandOptionValues, DefaultCommandOptionValues, 15029 ArgumentPrinter, and ArgumentParser classes. 15030 - In the ArgumentParser constructor-- 15031 - Added all_categories as a required parameter. 15032 - Removed the default value from the default_options parameter. 15033 15034 * Scripts/webkitpy/style/optparser_unittest.py: Added. 15035 - From checker_unittest.py, added the ProcessorOptionsTest, 15036 ArgumentPrinterTest, and ArgumentParserTest classes. 15037 - Added the CreateUsageTest class to test _create_usage(). 15038 15039 * Scripts/webkitpy/style/unittests.py: 15040 - Added optparser_unittest import. 15041 150422010-02-18 Alexey Proskuryakov <ap@apple.com> 15043 15044 Reviewed by Dan Bernstein. 15045 15046 https://bugs.webkit.org/show_bug.cgi?id=35134 15047 <rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0) 15048 15049 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 15050 (testSetStatus): 15051 (pluginInvoke): 15052 Added a setStatus() method. 15053 150542010-02-18 Brady Eidson <beidson@apple.com> 15055 15056 Reviewed by Sam Weinig. 15057 15058 Particularly constructed WebFrames can try to access a null HistoryItem 15059 <rdar://problem/7638892> and https://bugs.webkit.org/show_bug.cgi?id=35063 15060 15061 Add the specific ability to test this API pattern. 15062 15063 For now only on Mac, perhaps on the main Windows port later, probably not relevant for other ports. 15064 15065 * DumpRenderTree/LayoutTestController.cpp: 15066 (apiTestNewWindowDataLoadBaseURLCallback): 15067 (LayoutTestController::staticFunctions): 15068 * DumpRenderTree/LayoutTestController.h: 15069 15070 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 15071 (-[APITestDelegate initWithCompletionCondition:]): 15072 (-[APITestDelegate webView:didFailLoadWithError:forFrame:]): 15073 (-[APITestDelegate webView:didFailProvisionalLoadWithError:forFrame:]): 15074 (-[APITestDelegate webView:didFinishLoadForFrame:]): 15075 (LayoutTestController::apiTestNewWindowDataLoadBaseURL): Create a WebView, do a loadData: in its 15076 mainFrame, and synchronously wait for main load completion. 15077 15078 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 15079 (LayoutTestController::apiTestNewWindowDataLoadBaseURL): 15080 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 15081 (LayoutTestController::apiTestNewWindowDataLoadBaseURL): 15082 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 15083 (LayoutTestController::apiTestNewWindowDataLoadBaseURL): 15084 150852010-02-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 15086 15087 Reviewed by Eric Seidel. 15088 15089 Teach resolve-ChangeLogs to act as a merge-driver for Git 15090 15091 https://bugs.webkit.org/show_bug.cgi?id=28721 15092 15093 To enable automatic merging of ChangeLog files, use the following command: 15094 15095 git config merge.changelog.driver "resolve-ChangeLogs --merge-driver %O %A %B" 15096 15097 The driver always works in "downstream" merge mode, meaning 15098 it will always put the user's changelog entries on top. 15099 15100 * Scripts/resolve-ChangeLogs: 15101 151022009-12-05 Gustavo Noronha Silva <gns@gnome.org> 15103 15104 Reviewed by Eric Seidel. 15105 15106 Enable running of GTK+ API tests. 15107 15108 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 15109 * Scripts/run-gtk-tests: Added. 15110 151112010-02-18 Shinichiro Hamaji <hamaji@chromium.org> 15112 15113 Reviewed by Adam Barth. 15114 15115 debug-safari doesn't pass --debug option to gdb-safari on MacOSX 15116 https://bugs.webkit.org/show_bug.cgi?id=34411 15117 15118 * Scripts/webkitdirs.pm: 15119 151202010-02-18 Eric Seidel <eric@webkit.org> 15121 15122 Reviewed by Adam Barth. 15123 15124 run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree 15125 https://bugs.webkit.org/show_bug.cgi?id=35053 15126 15127 * Scripts/webkitpy/layout_tests/port/base.py: Add script_path() function for finding scripts. 15128 * Scripts/webkitpy/layout_tests/port/chromium.py: Remove unused argument. 15129 * Scripts/webkitpy/layout_tests/port/mac.py: 15130 - Make sure that calling webkit-build-directory works even if Scripts/ is not in the user's path. 15131 - Call build-dumprendertree (and make sure it succeeds) before running the tests. 15132 151332010-02-16 Chris Jerdonek <cjerdonek@webkit.org> 15134 15135 Reviewed by Shinichiro Hamaji. 15136 15137 Refactored check-webkit-style's ProcessorOptions class into two 15138 classes. This revision contains no new functionality. 15139 15140 https://bugs.webkit.org/show_bug.cgi?id=34674 15141 15142 Divided the ProcessorOptions class into a CommandOptionValues 15143 class (the result of parsing the command-line options) and 15144 a StyleCheckerConfiguration class (which configures the main 15145 StyleChecker). 15146 15147 * Scripts/check-webkit-style: 15148 - Updated main() to convert the parsed command option values 15149 to a StyleCheckConfiguration instance prior to constructing 15150 a StyleChecker. 15151 15152 * Scripts/webkitpy/style/checker.py: 15153 - Added check_webkit_style_configuration() to convert a 15154 CommandOptionValues instance into a StyleCheckerConfiguration 15155 instance. 15156 - Renamed the ProcessorOptions class to CommandOptionValues. 15157 - In the CommandOptionValues class-- 15158 - Replaced the filter_configuration attribute with the 15159 simpler filter_rules attribute. 15160 - Removed the max_reports_per_error attribute. 15161 - Moved the is_reportable() method to the new 15162 StyleCheckerConfiguration class. 15163 - Removed the base_filter_rules attribute from the 15164 DefaultCommandOptionValues class. 15165 - In the ArgumentParser class-- 15166 - Added base_filter_rules to the constructor. 15167 - Changed the parse() method to return a CommandOptionValues 15168 instance instead of a ProcessorOptions instance. 15169 - Created a StyleCheckerConfiguration class. 15170 - Added the data attributes max_reports_per_category, 15171 stderr_write, and verbosity. 15172 - Added is_reportable() (moved from the ProcessorOptions 15173 class) and write_style_error() (moved from the 15174 DefaultStyleErrorHandler class). 15175 - In the StyleChecker class-- 15176 - Replaced the ProcessorOptions options attribute with the 15177 StyleCheckerConfiguration _configuration attribute. 15178 - Removed the _stderr_write attribute. 15179 15180 * Scripts/webkitpy/style/checker_unittest.py: 15181 - Updated the existing unit test classes as necessary. 15182 - Added a StyleCheckerConfigurationTest class. 15183 15184 * Scripts/webkitpy/style/error_handlers.py: 15185 - Updated the DefaultStyleErrorHandler class to accept a 15186 StyleCheckerConfiguration instance instead of a ProcessorOptions 15187 instance and an stderr_write method. 15188 15189 * Scripts/webkitpy/style/error_handlers_unittest.py: 15190 - Updated the unit test classes as necessary. 15191 15192 * Scripts/webkitpy/style/filter.py: 15193 - Addressed the FIXME in the FilterConfiguration class to change 15194 the user_rules attribute to _user_rules (since it is now 15195 accessed only internally). 15196 15197 * Scripts/webkitpy/style/filter_unittest.py: 15198 - Updated to reflect the change from user_rules to _user_rules. 15199 152002010-02-17 Shinichiro Hamaji <hamaji@chromium.org> 15201 15202 Reviewed by Eric Seidel. 15203 15204 Share the DRT values maxViewWidth/Height among ports 15205 https://bugs.webkit.org/show_bug.cgi?id=34474 15206 15207 * DumpRenderTree/LayoutTestController.cpp: 15208 (pageNumberForElementByIdCallback): 15209 * DumpRenderTree/LayoutTestController.h: 15210 (LayoutTestController::maxViewWidth): 15211 (LayoutTestController::maxViewHeight): 15212 * DumpRenderTree/gtk/DumpRenderTree.cpp: 15213 (runTest): 15214 * DumpRenderTree/mac/DumpRenderTree.mm: 15215 (createWebViewAndOffscreenWindow): 15216 (sizeWebViewForCurrentTest): 15217 * DumpRenderTree/win/DumpRenderTree.cpp: 15218 (dump): 15219 (createWebViewAndOffscreenWindow): 15220 152212010-02-17 Shinichiro Hamaji <hamaji@chromium.org> 15222 15223 Reviewed by Eric Seidel. 15224 15225 [Win] Implement test functions for printing 15226 https://bugs.webkit.org/show_bug.cgi?id=34570 15227 15228 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 15229 (LayoutTestController::pageNumberForElementById): 15230 (LayoutTestController::numberOfPages): 15231 152322010-02-17 Fumitoshi Ukai <ukai@chromium.org> 15233 15234 Reviewed by Eric Seidel. 15235 15236 websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests 15237 https://bugs.webkit.org/show_bug.cgi?id=35001 15238 15239 * Scripts/webkitpy/layout_tests/port/websocket_server.py: add -x flag to run pywebsocket. 15240 152412010-02-17 Shinichiro Hamaji <hamaji@chromium.org> 15242 15243 Reviewed by Eric Seidel. 15244 15245 check-webkit-style: Misses variables that contain underscores. 15246 https://bugs.webkit.org/show_bug.cgi?id=33724 15247 15248 - Check identifiers whose types are unsigned. 15249 - Check bitfields properly. 15250 15251 * Scripts/webkitpy/style/processors/cpp.py: 15252 * Scripts/webkitpy/style/processors/cpp_unittest.py: 15253 152542010-02-17 Shinichiro Hamaji <hamaji@chromium.org> 15255 15256 Reviewed by Eric Seidel. 15257 15258 check-webkit-style should report the number of files checked 15259 https://bugs.webkit.org/show_bug.cgi?id=34971 15260 15261 * Scripts/check-webkit-style: 15262 * Scripts/webkitpy/style/checker.py: 15263 * Scripts/webkitpy/style/checker_unittest.py: 15264 152652010-02-17 Diego Gonzalez <diego.gonzalez@openbossa.org> 15266 15267 Reviewed by Ariya Hidayat. 15268 15269 Make possible Qt DRT to get total number of pages to be printed 15270 15271 LayoutTests: 15272 printing/numberOfPages.html 15273 15274 [Qt] DRT: Get total number of pages to be printed 15275 https://bugs.webkit.org/show_bug.cgi?id=34955 15276 15277 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 15278 (LayoutTestController::numberOfPages): 15279 * DumpRenderTree/qt/LayoutTestControllerQt.h: 15280 152812010-02-17 Xan Lopez <xlopez@igalia.com> 15282 15283 Reviewed by Gustavo Noronha. 15284 15285 Update to use new property name. 15286 15287 * DumpRenderTree/gtk/DumpRenderTree.cpp: 15288 (resetDefaultsToConsistentValues): 15289 152902010-02-17 Julien Chaffraix <jchaffraix@webkit.org> 15291 15292 Reviewed by Ariya Hidayat. 15293 15294 Remove some warnings seen when building Qt 15295 https://bugs.webkit.org/show_bug.cgi?id=35017 15296 15297 Using a machine without the needed tools to build WebKit leads to 15298 several errors and warnings. 15299 15300 * Scripts/webkitdirs.pm: Refactored the code testing the command's 15301 presence into a commandExists routine. While doing so removed, stderr 15302 output as it usually does not give anything more than our message. Also 15303 added a Qt check for qmake that was missing. 15304 153052010-02-17 Xan Lopez <xlopez@igalia.com> 15306 15307 Rubber-stamped by Gustavo Noronha. 15308 15309 Disable Java by default in DRT. 15310 15311 * DumpRenderTree/gtk/DumpRenderTree.cpp: 15312 (resetDefaultsToConsistentValues): 15313 153142010-02-15 Chris Jerdonek <cjerdonek@webkit.org> 15315 15316 Reviewed by Shinichiro Hamaji. 15317 15318 Some minor check-webkit-style code clean-ups. This revision 15319 contains no new functionality. 15320 15321 https://bugs.webkit.org/show_bug.cgi?id=34932 15322 15323 * Scripts/check-webkit-style: 15324 - Replaced the call to webkit_argument_defaults() with a 15325 default parameter in the ArgumentParser constructor. 15326 15327 * Scripts/webkitpy/style/checker.py: 15328 - Removed the WEBKIT prefix from the default global variables. 15329 - Prefixed several of the global variables with an underscore 15330 to reflect that they are used internally. 15331 - Renamed _DEFAULT_FILTER_RULES to _BASE_FILTER_RULES. 15332 - Addressed a FIXME by changing the _PATH_RULES_SPECIFIER 15333 configuration from list-tuple pairs to list-list pairs. 15334 - Renamed style_categories() to _all_categories(). 15335 - Renamed webkit_argument_defaults() to _check_webkit_style_defaults(). 15336 - Renamed the ArgumentDefaults class to DefaultCommandOptionValues. 15337 - In the ArgumentParser class-- 15338 - Renamed the doc_print attribute to stderr_write. 15339 - Other minor updates. 15340 15341 * Scripts/webkitpy/style/checker_unittest.py: 15342 - Updated the import statements and unit test classes as necessary. 15343 - Added assertions to test _PATH_RULES_SPECIFIER more fully. 15344 15345 * Scripts/webkitpy/style/error_handlers_unittest.py: 15346 - Updated the unit test classes as necessary. 15347 - Changed StyleErrorHandlerTestBase to store a list of error 15348 messages rather than just the last one. 15349 15350 * Scripts/webkitpy/style/filter.py: 15351 - Altered FilterConfiguration._path_rules_from_path() 15352 to convert the path_rules list to a tuple. 15353 15354 * Scripts/webkitpy/style/filter_unittest.py: 15355 - Updated the unit tests to reflect the change from tuples to 15356 lists in the _PATH_RULES_SPECIFIER configuration variable. 15357 153582010-02-16 Mark Rowe <mrowe@apple.com> 15359 15360 Let's not check garbage in to common build scripts and hose the world now eh guys? 15361 15362 * Scripts/webkitdirs.pm: 15363 153642010-02-16 Eric Seidel <eric@webkit.org> 15365 15366 Reviewed by Adam Barth. 15367 15368 re-factor Skipped list parsing code into multiple functions and unit test it 15369 https://bugs.webkit.org/show_bug.cgi?id=34986 15370 15371 * Scripts/test-webkitpy: Add new unit test. 15372 * Scripts/webkitpy/layout_tests/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. 15373 * Scripts/webkitpy/layout_tests/port/mac.py: Split parsing function into multiple functions for testing. 15374 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: Added. 15375 153762010-02-16 Xan Lopez <xlopez@igalia.com> 15377 15378 Reviewed by Gustavo Noronha. 15379 15380 Enable 'auto-resize-window' in our DRT. 15381 15382 * DumpRenderTree/gtk/DumpRenderTree.cpp: 15383 (resetDefaultsToConsistentValues): 15384 153852010-02-15 Martin Robinson <mrobinson@webkit.org> 15386 15387 Reviewed by Darin Adler. 15388 15389 check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin 15390 https://bugs.webkit.org/show_bug.cgi?id=34834 15391 15392 * Scripts/webkitpy/style/processors/cpp.py: 15393 * Scripts/webkitpy/style/processors/cpp_unittest.py: 15394 153952010-02-12 Alexey Proskuryakov <ap@apple.com> 15396 15397 Reviewed by Kevin Decker. 15398 15399 <rdar://problem/7130641> Browser objects identity is not preserved by Safari 15400 15401 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 15402 (pluginInvoke): Added methods for checking object identity (via refcount). 15403 154042010-02-15 Robert Hogan <robert@roberthogan.net> 15405 15406 Reviewed by Simon Hausmann. 15407 15408 [Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled(). 15409 15410 Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT. 15411 15412 https://bugs.webkit.org/show_bug.cgi?id=33096 15413 15414 This allows the following tests to pass: 15415 15416 inspector/console-format-collections.html 15417 inspector/styles-iframe.html 15418 inspector/syntax-highlight-css.html 15419 inspector/syntax-highlight-javascript.html 15420 inspector/timeline-enum-stability.html 15421 inspector/timeline-layout.html 15422 inspector/timeline-mark-timeline.html 15423 inspector/timeline-paint.html 15424 inspector/timeline-parse-html.html 15425 inspector/timeline-recalculate-styles.html 15426 inspector/timeline-script-tag-1.html 15427 inspector/timeline-script-tag-2.html 15428 inspector/timeline-trivial.html 15429 inspector/cookie-resource-match.html 15430 inspector/elements-img-tooltip.html 15431 inspector/elements-panel-selection-on-refresh.html 15432 inspector/inspected-objects-not-overriden.html 15433 inspector/timeline-event-dispatch.html 15434 inspector/timeline-network-resource.html 15435 inspector/elements-panel-rewrite-href.html 15436 inspector/console-dir.html 15437 inspector/console-dirxml.html 15438 inspector/console-format.html 15439 inspector/console-tests.html 15440 inspector/elements-panel-structure.html 15441 inspector/evaluate-in-frontend.html 15442 inspector/console-clear.html 15443 15444 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 15445 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 15446 (WebCore::isWebInspectorTest): 15447 (WebCore::DumpRenderTree::open): 15448 * DumpRenderTree/qt/DumpRenderTreeQt.h: 15449 (WebCore::DumpRenderTree::display): 15450 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 15451 (LayoutTestController::closeWebInspector): 15452 (LayoutTestController::showWebInspector): 15453 (LayoutTestController::evaluateInWebInspector): 15454 (LayoutTestController::setTimelineProfilingEnabled): 15455 (LayoutTestController::display): 15456 * DumpRenderTree/qt/LayoutTestControllerQt.h: 15457 154582010-02-14 Dirk Pranke <dpranke@chromium.org> 15459 15460 Reviewed by Eric Seidel. 15461 15462 Update rebaseline-chromium-webkit-tests to work with the new code 15463 structure (port objects instead of path_utils and platform_utils). 15464 15465 Added a path_to_test_expectations_file() to the Port interface. 15466 15467 Fixed a bug in the chromium_* platform implementations where the 15468 'target' option was assumed to be set. 15469 15470 * Scripts/rebaseline-chromium-webkit-tests: 15471 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 15472 * Scripts/webkitpy/layout_tests/port/base.py: 15473 * Scripts/webkitpy/layout_tests/port/chromium.py: 15474 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 15475 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 15476 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 15477 * Scripts/webkitpy/layout_tests/port/test.py: 15478 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 15479 154802010-02-14 Eric Seidel <eric@webkit.org> 15481 15482 Reviewed by Darin Adler. 15483 15484 webkit-build-directory misuses terms 15485 https://bugs.webkit.org/show_bug.cgi?id=34822 15486 15487 * Scripts/webkit-build-directory: 15488 - Add --top-level and --configuration options and make using one of them required. 15489 * Scripts/webkitpy/layout_tests/port/mac.py: 15490 - Use --top-level instead of --base. 15491 154922010-02-14 Chang Shu <Chang.Shu@nokia.com> 15493 15494 Reviewed by Laszlo Gombos. 15495 15496 [Qt] Enable appcache feature. 15497 https://bugs.webkit.org/show_bug.cgi?id=34713 15498 15499 Re-land r54543 without the change in DumpRenderTree/qt/main.cpp. 15500 Persistent storage for AppCache is already initialized in 15501 DumpRenderTreeQt.cpp. 15502 15503 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 15504 (WebCore::WebPage::WebPage): 15505 155062010-02-12 Chang Shu <Chang.Shu@nokia.com> 15507 15508 Not Reviewed. 15509 15510 Change case of my email address as a work-around for the following bug. 15511 https://bugs.webkit.org/show_bug.cgi?id=34717 15512 15513 * Scripts/webkitpy/committers.py: 15514 155152010-02-12 Darin Adler <darin@apple.com> 15516 15517 Ignore compiled Python in more of webkitpy. 15518 15519 * Scripts/webkitpy/style/processors: Added property svn:ignore. 15520 155212010-02-12 Diego Gonzalez <diego.gonzalez@openbossa.org> 15522 15523 Reviewed by Kenneth Rohde Christiansen. 15524 15525 Qt DRT now dump the frame loader callbacks when LayoutTestController() 15526 method is called. 15527 15528 LayoutTests: 15529 http/tests/security/mixedContent/data-url-script-in-iframe.html 15530 http/tests/security/mixedContent/empty-url-plugin-in-frame.html 15531 http/tests/security/mixedContent/insecure-css-in-iframe.html 15532 http/tests/security/mixedContent/insecure-iframe-in-iframe.html 15533 http/tests/security/mixedContent/insecure-image-in-iframe.html 15534 http/tests/security/mixedContent/insecure-plugin-in-iframe.html 15535 http/tests/security/mixedContent/insecure-script-in-iframe.html 15536 http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html 15537 http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html 15538 15539 [Qt] Make possible Qt DRT dump frame load callbacks 15540 https://bugs.webkit.org/show_bug.cgi?id=34702 15541 15542 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 15543 (LayoutTestController::reset): 15544 (LayoutTestController::dumpFrameLoadCallbacks): 15545 * DumpRenderTree/qt/LayoutTestControllerQt.h: 15546 155472010-02-12 Simon Hausmann <simon.hausmann@nokia.com> 15548 15549 Reviewed by Antti Koivisto. 15550 15551 Make QtLauncher somewhat useable on S60. 15552 15553 Show the window fullscreen to make scrollbars appear, resize 15554 the toolbar buttons to 16x16 to give more screen space to 15555 web content and moved the location lineedit into a separate 15556 line. 15557 15558 * QtLauncher/main.cpp: 15559 (LauncherWindow::LauncherWindow): 15560 * QtLauncher/mainwindow.cpp: 15561 (MainWindow::buildUI): 15562 155632010-02-12 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 15564 15565 Reviewed by Kenneth Rohde Christiansen. 15566 15567 Support frameset flattening 15568 https://bugs.webkit.org/show_bug.cgi?id=32717 15569 15570 Add FrameSet Flattening support to Mac DRT. 15571 15572 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 15573 (LayoutTestController::setFrameSetFlatteningEnabled): 15574 * DumpRenderTree/win/DumpRenderTree.cpp: 15575 (resetDefaultsToConsistentValues): 15576 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 15577 (LayoutTestController::setXSSAuditorEnabled): 15578 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 15579 (LayoutTestController::setFrameSetFlatteningEnabled): 15580 * DumpRenderTree/LayoutTestController.cpp: 15581 (setFrameSetFlatteningEnabledCallback): 15582 (LayoutTestController::staticFunctions): 15583 * DumpRenderTree/LayoutTestController.h: 15584 * DumpRenderTree/mac/DumpRenderTree.mm: 15585 (resetDefaultsToConsistentValues): 15586 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 15587 (LayoutTestController::setFrameSetFlatteningEnabled): 15588 155892010-02-12 Dirk Pranke <dpranke@chromium.org> 15590 15591 Reviewed by Eric Seidel. 15592 15593 Fix typos in driver_test.py 15594 15595 https://bugs.webkit.org/show_bug.cgi?id=34810 15596 15597 * Scripts/webkitpy/layout_tests/driver_test.py: 15598 155992010-02-12 Simon Hausmann <simon.hausmann@nokia.com> 15600 15601 Reviewed by Kenneth Rohde Christiansen. 15602 15603 [Qt] Make it possible to toggle the use of QGraphicsView in QtLauncher at run-time 15604 https://bugs.webkit.org/show_bug.cgi?id=34844 15605 15606 * QtLauncher/main.cpp: 15607 (LauncherWindow::LauncherWindow): 15608 (LauncherWindow::initializeView): 15609 (LauncherWindow::setupUI): 15610 * QtLauncher/webview.cpp: 15611 (WebViewGraphicsBased::WebViewGraphicsBased): 15612 156132010-02-11 Fumitoshi Ukai <ukai@chromium.org> 15614 15615 Reviewed by Alexey Proskuryakov. 15616 15617 WebSocket ignores HttpOnly cookies, but should use in Handshake. 15618 https://bugs.webkit.org/show_bug.cgi?id=34289 15619 15620 Update pywebsocket to 0.4.8, which supports cgi directories. 15621 run-webkit-tests and run-webkit-websocketserver will run 15622 pywebsocket, specifying /websocket/test/cookies as cgi directory. 15623 15624 * Scripts/run-webkit-tests: 15625 * Scripts/run-webkit-websocketserver: 15626 * pywebsocket/mod_pywebsocket/standalone.py: 15627 * pywebsocket/setup.py: 15628 156292010-02-11 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 15630 15631 Reviewed by Dan Bernstein. 15632 15633 [Mac] Duplicated setXSSAuditorEnabled preference at Mac DRT 15634 https://bugs.webkit.org/show_bug.cgi?id=34798 15635 15636 Remove duplicated setXSSAuditorEnabled preference at Mac DRT 15637 15638 * DumpRenderTree/mac/DumpRenderTree.mm: 15639 (resetDefaultsToConsistentValues): 15640 156412010-02-11 Eric Seidel <eric@webkit.org> 15642 15643 No review, build fix only. 15644 15645 webkitdirs.pm has a crazy amount of duplicated feature detection code 15646 https://bugs.webkit.org/show_bug.cgi?id=34869 15647 15648 * Scripts/build-webkit: Fix typo which broke bots. 15649 156502010-02-11 Eric Seidel <eric@webkit.org> 15651 15652 Reviewed by Adam Barth. 15653 15654 webkitdirs.pm has a crazy amount of duplicated feature detection code 15655 https://bugs.webkit.org/show_bug.cgi?id=34869 15656 15657 * Scripts/build-webkit: Use the new hotness. 15658 * Scripts/run-webkit-tests: ditto 15659 * Scripts/webkitdirs.pm: Remove a bunch of bad duplicate code. 15660 * Scripts/webkitperl/features.pm: Added. 15661 - Simplified the 10 methods in webkitdirs.pm into 2 exported methods in this new file. 15662 156632010-02-11 Daniel Bates <dbates@rim.com> 15664 15665 Reviewed by Adam Barth. 15666 15667 https://bugs.webkit.org/show_bug.cgi?id=34830 15668 15669 Makes method User.prompt static and adds the parameter repeat 15670 to prompt the user up to repeat times. 15671 15672 * Scripts/test-webkitpy: 15673 * Scripts/webkitpy/bugzilla.py: Substituted method User.prompt for method raw_input. 15674 * Scripts/webkitpy/commands/upload.py: Ditto 15675 * Scripts/webkitpy/credentials.py: Ditto 15676 * Scripts/mock_bugzillatool.py: Updated prototype of MockUser.prompt to match User.prompt. 15677 * Scripts/webkitpy/user.py: Made method prompt static and added parameter repeat. 15678 * Scripts/webkitpy/user_unittest.py: Added. 15679 156802010-02-10 Yuzo Fujishima <yuzo@google.com> 15681 15682 Reviewed by Darin Adler. 15683 15684 Allow underscored identifiers in CSSParser.cpp 15685 15686 Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*. 15687 WebCore/css/CSSParser.cpp needs to handle some such identifiers. 15688 We should relax the style rule for the file to allow underscored identifiers. 15689 15690 https://bugs.webkit.org/show_bug.cgi?id=34787 15691 15692 * Scripts/webkitpy/style/checker.py: 15693 156942010-02-11 Eric Seidel <eric@webkit.org> 15695 15696 Rubber-stamped by Adam Barth. 15697 15698 Remove DrawTest, the application I used when bringing up SVG support on the Mac. 15699 The code hasn't been touched (or used) in years. No sense in keeping it in trunk. 15700 15701 * Scripts/build-drawtest: Removed. 15702 * Scripts/run-drawtest: Removed. 15703 * DrawTest: Removed. 15704 157052010-02-11 Eric Seidel <eric@webkit.org> 15706 15707 Reviewed by Adam Barth. 15708 15709 Need a command to clear r+ on obsolete patches in the pending-commit queue. 15710 https://bugs.webkit.org/show_bug.cgi?id=34863 15711 15712 Unfortunately our http://webkit.org/pending-commit bugzilla query is not 15713 smart enough to ignore obsolete patches, so bugs show up there which are 15714 still open, but do not have patches ready for landing on them. 15715 This new command "clean-pending-commit" will remove r+ from obsolete patches 15716 in the pending-commit list. 15717 15718 * Scripts/test-webkitpy: Add grammar_unittest 15719 * Scripts/webkitpy/commands/upload.py: Add clean-pending-commit and make assign-to-committer ignore cq+'d patches. 15720 * Scripts/webkitpy/grammar.py: Add join_with_separators 15721 * Scripts/webkitpy/grammar_unittest.py: Added. 15722 157232010-02-11 Eric Seidel <eric@webkit.org> 15724 15725 Reviewed by Adam Barth. 15726 15727 run-chromium-webkit-tests fails random pixel tests on Mac 15728 https://bugs.webkit.org/show_bug.cgi?id=34862 15729 15730 This is due to the fact that the Mac port has an 15731 invalid path to the image diff tool. Currently it points 15732 to image_diff even though ImageDiff would be correct. We 15733 can't change it to the right path yet without causing the 15734 script to hang. ImageDiff expects to be long-running and 15735 be passed image data over stdin. image_diff (chromium's fork) 15736 expects to be passed command line arguments. 15737 This fix works around the random failures by disabling pixel 15738 tests on mac and logging if the user was trying to run with pixel 15739 tests enabled. 15740 15741 * Scripts/webkitpy/layout_tests/port/mac.py: 15742 157432010-02-11 Nikolas Zimmermann <nzimmermann@rim.com> 15744 15745 Reviewed by Adam Roben. 15746 Try to fix build breakage from r54665. 15747 15748 * Scripts/check-for-global-initializers: 15749 157502010-02-11 Simon Hausmann <simon.hausmann@nokia.com> 15751 15752 Reviewed by Tor Arne Vestbø. 15753 15754 Make it possible to toggle accelerated compositing from the menu 15755 at run-time. 15756 15757 * QtLauncher/main.cpp: 15758 (LauncherWindow::toggleAcceleratedCompositing): 15759 (LauncherWindow::setupUI): 15760 157612010-02-08 Maciej Stachowiak <mjs@apple.com> 15762 15763 Reviewed by Cameron Zwarich. 15764 15765 Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose. 15766 https://bugs.webkit.org/show_bug.cgi?id=34698 15767 15768 * Scripts/build-webkit: 15769 157702010-02-10 Dirk Pranke <dpranke@chromium.org> 15771 15772 Reviewed by Eric Seidel. 15773 15774 Fix various minor bugs keeping run-chromium-webkit-tests from actually 15775 working on the linux and win ports of Chromium. 15776 15777 https://bugs.webkit.org/show_bug.cgi?id=34739 15778 15779 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 15780 * Scripts/webkitpy/layout_tests/port/__init__.py: 15781 * Scripts/webkitpy/layout_tests/port/base.py: 15782 * Scripts/webkitpy/layout_tests/port/chromium.py: 15783 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 15784 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 15785 * Scripts/webkitpy/layout_tests/port/http_server.py: 15786 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 15787 157882010-02-10 Eric Seidel <eric@webkit.org> 15789 15790 Reviewed by David Levin. 15791 15792 run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory 15793 https://bugs.webkit.org/show_bug.cgi?id=34817 15794 15795 This doesn't fix the root cause of us not 15796 correctly failing when support binaries are missing. 15797 This only causes the DumpRenderTree binary not to be 15798 missing in the custom build directory case. 15799 Later patches will make us correctly fail fast when 15800 support binaries (like DumpRenderTree or ImageDiff) are missing. 15801 15802 * Scripts/webkit-build-directory: Added. 15803 - Need a way to re-use the perl logic for finding build directories in non-perl scripts. 15804 * Scripts/webkitpy/layout_tests/port/base.py: Add a FIXME. 15805 * Scripts/webkitpy/layout_tests/port/mac.py: 15806 - Call webkit-build-directory to find the build directory instead of assuming "WebKitBuild" 15807 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Add FIXMEs. 15808 158092010-02-10 Kevin Watters <kevinwatters@gmail.com> 15810 15811 Reviewed by Kevin Ollivier. 15812 15813 [wx] Add Windows complex text support. 15814 15815 https://bugs.webkit.org/show_bug.cgi?id=34759 15816 15817 * wx/build/settings.py: 15818 158192010-02-10 Kevin Ollivier <kevino@theolliviers.com> 15820 15821 [wx] Build fix. Add stub for new LayoutTestController method. 15822 15823 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 15824 (LayoutTestController::numberOfPages): 15825 158262010-02-10 Csaba Osztrogonác <ossy@webkit.org> 15827 15828 Unreviewed. Roll out r54626, because it broke GTK and Win build. 15829 https://bugs.webkit.org/show_bug.cgi?id=32717 15830 15831 * DumpRenderTree/LayoutTestController.cpp: 15832 (LayoutTestController::staticFunctions): 15833 * DumpRenderTree/LayoutTestController.h: 15834 * DumpRenderTree/mac/DumpRenderTree.mm: 15835 (resetDefaultsToConsistentValues): 15836 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 15837 158382010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 15839 15840 Reviewed by Kenneth Rohde Christiansen. 15841 15842 Support frameset flattening 15843 https://bugs.webkit.org/show_bug.cgi?id=32717 15844 15845 Add FrameSet Flattening support to Mac DRT. 15846 15847 * DumpRenderTree/LayoutTestController.cpp: 15848 (setFrameSetFlatteningEnabledCallback): 15849 (LayoutTestController::staticFunctions): 15850 * DumpRenderTree/LayoutTestController.h: 15851 * DumpRenderTree/mac/DumpRenderTree.mm: 15852 (resetDefaultsToConsistentValues): 15853 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 15854 (LayoutTestController::setFrameSetFlatteningEnabled): 15855 158562010-02-08 Jon Honeycutt <jhoneycutt@apple.com> 15857 15858 <rdar://problem/7436875> Crash in Flash when visiting 15859 http://www.cctv.com/default.shtml (WER ID 819298200) [watson 2502260] 15860 15861 Reviewed by Darin Adler. 15862 15863 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 15864 (executeScript): 15865 Moved to an earlier point in the file. 15866 (NPP_New): 15867 If the plug-in has an onDestroy attribute, store its value. 15868 (NPP_Destroy): 15869 If the plug-in has code to run on destruction, run it and free it. 15870 158712010-02-10 Diego Gonzalez <diego.gonzalez@openbossa.org> 15872 15873 Reviewed by Kenneth Rohde Christiansen. 15874 15875 Implement pageNumberForElementById() method in Qt DRT LayoutTestController, 15876 to make Qt DRT able to get page number. 15877 15878 LayoutTests: 15879 printing/page-break-always.html 15880 printing/pageNumerForElementById.html 15881 printing/css2.1/page-break-before-000.html 15882 printing/css2.1/page-break-after-000.html 15883 printing/css2.1/page-break-after-004.html 15884 printing/css2.1/page-break-before-001.html 15885 printing/css2.1/page-break-after-001.html 15886 printing/css2.1/page-break-after-002.html 15887 printing/css2.1/page-break-before-002.html 15888 printing/css2.1/page-break-inside-000.html 15889 15890 [Qt] Make possible Qt DRT get a page number for element by ID 15891 https://bugs.webkit.org/show_bug.cgi?id=34777 15892 15893 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 15894 (LayoutTestController::pageNumberForElementById): 15895 * DumpRenderTree/qt/LayoutTestControllerQt.h: 15896 158972010-02-10 Andras Becsi <abecsi@webkit.org> 15898 15899 Reviewed by Adam Barth. 15900 15901 Make run-iexploder-tests work on Linux. 15902 https://bugs.webkit.org/show_bug.cgi?id=34748 15903 15904 Extract the platform dependant Apache configuration checking code in httpd.pm to a separate function 15905 called getHTTPDConfigPathForTestDirectory and use run-launcher instead of run-safari if run on Linux. 15906 15907 * Scripts/run-iexploder-tests: 15908 * Scripts/webkitperl/httpd.pm: 15909 159102010-02-09 Csaba Osztrogonác <ossy@webkit.org> 15911 15912 [Qt] Unreviewed. Roll-out r54543, because layout tests crash in debug mode. 15913 https://bugs.webkit.org/show_bug.cgi?id=34713 15914 15915 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 15916 (WebCore::WebPage::WebPage): 15917 * DumpRenderTree/qt/main.cpp: 15918 (main): 15919 159202010-02-09 Alejandro G. Castro <alex@igalia.com> 15921 15922 Unreviewed; added myself to committers 15923 15924 * Scripts/webkitpy/committers.py: 15925 159262010-02-09 Yael Aharon <yael.aharon@nokia.com> 15927 15928 Reviewed by Kenneth Rohde Christiansen. 15929 15930 [Qt] Webkit in Qt does not have window.showModalDialog 15931 https://bugs.webkit.org/show_bug.cgi?id=25585 15932 15933 Set the modality flag when createWindow is called with window type WebWindowDialog. 15934 15935 * QtLauncher/main.cpp: 15936 (WebPage::createWindow): 15937 159382010-02-09 Andras Becsi <abecsi@webkit.org> 15939 15940 Unreviewed trivial warning fix. 15941 15942 * Scripts/build-webkit: 15943 159442010-02-09 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 15945 15946 Reviewed by Tor Arne Vestbø. 15947 15948 Add possibility of passing parameters to build-webkit by environment variable, 15949 because the buildbot slaves can't control the arguments. 15950 15951 * Scripts/build-webkit: 15952 159532010-02-09 Chang Shu <Chang.Shu@nokia.com> 15954 15955 Reviewed by Laszlo Gombos. 15956 15957 [Qt] Enable appcache feature. 15958 https://bugs.webkit.org/show_bug.cgi?id=34713 15959 15960 15961 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 15962 (WebCore::WebPage::WebPage): 15963 * DumpRenderTree/qt/main.cpp: 15964 (main): 15965 159662010-02-09 Shinichiro Hamaji <hamaji@chromium.org> 15967 15968 Reviewed by Darin Adler. 15969 15970 Provide a way to get total number of pages to be printed 15971 https://bugs.webkit.org/show_bug.cgi?id=34699 15972 15973 * DumpRenderTree/LayoutTestController.cpp: 15974 (parsePageParameters): 15975 (pageNumberForElementByIdCallback): 15976 (numberOfPagesCallback): 15977 (LayoutTestController::staticFunctions): 15978 * DumpRenderTree/LayoutTestController.h: 15979 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 15980 (LayoutTestController::numberOfPages): 15981 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 15982 (LayoutTestController::numberOfPages): 15983 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 15984 (LayoutTestController::numberOfPages): 15985 159862010-02-08 Alexey Proskuryakov <ap@apple.com> 15987 15988 Reviewed by Darin Adler. 15989 15990 https://bugs.webkit.org/show_bug.cgi?id=34727 15991 Assertion crashes and freezes when plug-in property access results in an exception 15992 15993 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 15994 (pluginGetProperty): Raise an exception when accessing a particular property. 15995 (pluginSetProperty): Ditto. 15996 (pluginInvoke): Added methods to get and set host object properties. 15997 159982010-02-08 Kenneth Rohde Christiansen <kenneth@webkit.org> 15999 16000 Reviewed by Ariya Hidayat. 16001 16002 [Qt] Backport No'am Rosenthal's frame rate measurement 16003 16004 * QtLauncher/main.cpp: 16005 (LauncherWindow::LauncherWindow): 16006 (LauncherApplication::handleUserOptions): 16007 * QtLauncher/webview.cpp: 16008 (WebViewGraphicsBased::WebViewGraphicsBased): 16009 (WebViewGraphicsBased::enableFrameRateMeasurement): 16010 (WebViewGraphicsBased::updateFrameRate): 16011 (WebViewGraphicsBased::paintEvent): 16012 * QtLauncher/webview.h: 16013 160142010-02-08 Kenneth Rohde Christiansen <kenneth@webkit.org> 16015 16016 Reviewed by Tor Arne Vestbø. 16017 16018 [Qt] Make overridePreference complain when it does not 16019 support the preference given. 16020 16021 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 16022 (LayoutTestController::overridePreference): 16023 160242010-02-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 16025 16026 Reviewed by Kenneth Rohde Christiansen. 16027 16028 [Qt] Set stdout/stderr to binary mode for DRT on Windows 16029 16030 This makes sure we don't end up with lots of CRLFs in the 16031 DRT output, which breaks tons of results. Matches what 16032 the Windows DRT does. 16033 16034 * DumpRenderTree/qt/main.cpp: 16035 160362010-02-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 16037 16038 Reviewed by Kenneth Rohde Christiansen. 16039 16040 Build fix for Qt on Windows. 16041 16042 Don't use noreturn directly since it's a gcc attribute. 16043 Instead use the NO_RETURN macro from AlwaysInline.h 16044 16045 * QtLauncher/QtLauncher.pro: 16046 * QtLauncher/utils.h: 16047 160482010-02-05 Chris Jerdonek <cjerdonek@webkit.org> 16049 16050 Reviewed by Shinichiro Hamaji. 16051 16052 Suppressed check-webkit-style's underscore check in Qt's autotests. 16053 Also made the path-specific filter check case-insensitive. 16054 16055 https://bugs.webkit.org/show_bug.cgi?id=34574 16056 16057 * Scripts/webkitpy/style/checker.py: 16058 - Added a list element to _PATH_RULES_SPECIFIER for 16059 directories that should be excluded from the 16060 "readability/naming" category (the category that relates to 16061 underscores in identifiers, for example). 16062 16063 * Scripts/webkitpy/style/checker_unittest.py: 16064 - Added an "end-to-end" test for "WebKit/qt/tests/". 16065 16066 * Scripts/webkitpy/style/filter.py: 16067 - Altered FilterConfiguration's should_check() method to 16068 check for path substring matches case-insensitively. 16069 16070 * Scripts/webkitpy/style/filter_unittest.py: 16071 - Added a test to check case-insensitive path substring matching. 16072 16073 * Scripts/webkitpy/style/processors/cpp.py: 16074 - Removed the hard-coded "WebKit/gtk/webkit/" path reference 16075 since this is now taken care of by the _PATH_RULES_SPECIFIER 16076 configuration variable. 16077 16078 * Scripts/webkitpy/style/processors/cpp_unittest.py: 16079 - Removed the unit test for the GTK directory since this 16080 is now taken care of by the checker._PATH_RULES_SPECIFIER 16081 end-to-end tests. 16082 160832010-02-08 Leith Bade <leith@leithalweapon.geek.nz> 16084 16085 Reviewed by Darin Adler. 16086 16087 Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637 16088 Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows 16089 environemnt variables when there is a space in the user's /home path. 16090 16091 * Scripts/webkitdirs.pm: 16092 - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir(). 16093 160942010-02-05 Alexey Proskuryakov <ap@apple.com> 16095 16096 Reviewed by Oliver Hunt. 16097 16098 https://bugs.webkit.org/show_bug.cgi?id=34670 16099 TestNetscapePlugin should work with Firefox 16100 16101 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if 16102 browser doesn't tell what it supports. 16103 161042010-02-05 Shinichiro Hamaji <hamaji@chromium.org> 16105 16106 Reviewed by Gustavo Noronha Silva. 16107 16108 [Gtk] Implement layoutTestController.pageNumberForElementById 16109 https://bugs.webkit.org/show_bug.cgi?id=34572 16110 16111 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 16112 (LayoutTestController::pageNumberForElementById): 16113 161142010-02-03 Dirk Pranke <dpranke@chromium.org> 16115 16116 Reviewed by Eric Seidel. 16117 16118 Add a simple test implementation and the WebKit Mac implementation 16119 for the layout_tests/port package. Also add a simple test driver of 16120 that interface. 16121 16122 https://bugs.webkit.org/show_bug.cgi?id=34511 16123 16124 * Scripts/webkitpy/layout_tests/driver_test.py: Added. 16125 * Scripts/webkitpy/layout_tests/port/__init__.py: 16126 * Scripts/webkitpy/layout_tests/port/mac.py: Added. 16127 * Scripts/webkitpy/layout_tests/port/test.py: Added. 16128 161292010-02-03 Dirk Pranke <dpranke@chromium.org> 16130 16131 Reviewed by Eric Siedel. 16132 16133 Refactor the port package into an object-oriented style and merge 16134 path_utils into it. We add a 'base' and a 'chromium' object to the 16135 port package; this will allow us to easily add new ports (like 16136 WebKit Mac). 16137 16138 https://bugs.webkit.org/show_bug.cgi?id=34511 16139 16140 * Scripts/rebaseline-chromium-webkit-tests: 16141 * Scripts/run-chromium-webkit-tests: 16142 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 16143 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 16144 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 16145 * Scripts/webkitpy/layout_tests/layout_package/test_files.py: 16146 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 16147 * Scripts/webkitpy/layout_tests/port/__init__.py: 16148 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 16149 * Scripts/webkitpy/layout_tests/port/base.py: Added. 16150 * Scripts/webkitpy/layout_tests/port/chromium.py: Added. 16151 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 16152 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 16153 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 16154 * Scripts/webkitpy/layout_tests/port/http_server.py: 16155 * Scripts/webkitpy/layout_tests/port/http_server_base.py: 16156 * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed. 16157 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 16158 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 16159 * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: 16160 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: 16161 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 16162 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 16163 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 16164 161652010-01-19 Kenneth Rohde Christiansen <kenneth@webkit.org> 16166 16167 Reviewed by Dave Hyatt. 16168 16169 Implement flattening of framesets 16170 https://bugs.webkit.org/show_bug.cgi?id=32717 16171 16172 Add support for testing frame flattening with the Qt DRT 16173 16174 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 16175 (LayoutTestController::setFrameSetFlatteningEnabled): 16176 * DumpRenderTree/qt/LayoutTestControllerQt.h: 16177 161782010-02-03 Chris Jerdonek <cjerdonek@webkit.org> 16179 16180 Reviewed by Shinichiro Hamaji. 16181 16182 Provided a way in check-webkit-style to specify filter rules 16183 on a per file or folder basis, via a configuration variable. 16184 16185 https://bugs.webkit.org/show_bug.cgi?id=33684 16186 16187 * Scripts/webkitpy/style/checker.py: 16188 - Added _PATH_RULES_SPECIFIER configuration variable. 16189 - In ProcessorOptions class-- 16190 - Changed the CategoryFilter attribute to FilterConfiguration. 16191 - Added path parameter to is_reportable(). 16192 - Renamed ArgumentDefaults filter_rules attribute to 16193 base_filter_rules. 16194 - Updated ArgumentPrinter class. 16195 - Added filter rule validation to ArgumentParser (instead of 16196 in CategoryFilter constructor). 16197 16198 * Scripts/webkitpy/style/checker_unittest.py: 16199 - Updated unit tests as necessary. 16200 - Added unit tests for PATH_RULES_SPECIFIER. 16201 16202 * Scripts/webkitpy/style/error_handlers.py: 16203 - Updated DefaultStyleErrorHandler to use file path when 16204 calling is_reportable(). 16205 16206 * Scripts/webkitpy/style/error_handlers_unittest.py: 16207 - Updated unit tests as necessary. 16208 16209 * Scripts/webkitpy/style/filter.py: 16210 - Marked CategoryFilter internal with an underscore. 16211 - Removed argument validation from CategoryFilter. 16212 - Added FilterConfiguration class. 16213 16214 * Scripts/webkitpy/style/filter_unittest.py: 16215 - Updated CategoryFilterTest class. 16216 - Added FilterConfigurationTest unit tests. 16217 16218 * Scripts/webkitpy/style/processors/cpp.py: 16219 - Removed _is_test_filename() code. 16220 - Removed hard-coded path checks from check_include_line(). 16221 16222 * Scripts/webkitpy/style/processors/cpp_unittest.py: 16223 - Removed three unit tests related to exempted files. 16224 162252010-02-05 Kenneth Rohde Christiansen <kenneth@webkit.org> 16226 16227 Reviewed by Ariya Hidayat. 16228 16229 [Qt] Apply the command line options as settings to the 16230 graphics system. 16231 16232 * QtLauncher/main.cpp: 16233 (LauncherWindow::LauncherWindow): 16234 (requiresGraphicsView): 16235 (LauncherApplication::handleUserOptions): 16236 * QtLauncher/webview.h: 16237 (WebViewGraphicsBased::setItemCacheMode): 16238 162392010-02-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 16240 16241 Reviewed by Simon Hausmann. 16242 16243 Notify user that run-webkit-tests has to be run under Cygwin 16244 16245 The script will bail out if run under Windows shell or Msys. 16246 16247 * Scripts/run-webkit-tests: 16248 * Scripts/webkitdirs.pm: 16249 162502010-02-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 16251 16252 Reviewed by Simon Hausmann. 16253 16254 [Qt] Generate convenience headers (QWebView, etc) using qmake 16255 16256 In Qt this is done using syncqt, but we use a pro-file instead 16257 that generates makefile-rules for each of the extra headers. 16258 16259 These extra headers are installed alongside the normal headers. 16260 16261 * Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources 16262 162632010-02-05 Andras Becsi <abecsi@webkit.org> 16264 16265 Unreviewed typo fix. 16266 16267 Fix wrong whitespace alignment introduced in r54342. 16268 16269 * Scripts/run-webkit-tests: 16270 162712010-02-04 Mark Rowe <mrowe@apple.com> 16272 16273 Reviewed by Timothy Hatcher. 16274 16275 Build fix. Remove a symbol corresponding to an inline function from the linker export 16276 file to prevent a weak external failure. 16277 16278 * Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables. 16279 Teach the script how to detect weak external symbols so that these errors can be caught immediately 16280 in the future. 16281 162822010-02-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 16283 16284 Rubberstamped by Oliver Hunt. 16285 16286 [Qt] Make it possible to choose whether the launcher should 16287 use the traditional QWidget based QWebView or the newer 16288 QGraphics based QGraphicsWebView on a QGraphicsView. 16289 16290 * QtLauncher/main.cpp: 16291 (LauncherWindow::LauncherWindow): 16292 (LauncherWindow::eventFilter): 16293 (LauncherWindow::loadStarted): 16294 (LauncherWindow::print): 16295 (LauncherWindow::screenshot): 16296 (LauncherWindow::setEditable): 16297 (LauncherWindow::setupUI): 16298 (main): 16299 * QtLauncher/webview.cpp: 16300 (WebViewGraphicsBased::WebViewGraphicsBased): 16301 (WebViewGraphicsBased::resizeEvent): 16302 (GraphicsWebView::mousePressEvent): 16303 (GraphicsWebView::contextMenuEvent): 16304 * QtLauncher/webview.h: 16305 (WebViewTraditional::WebViewTraditional): 16306 (GraphicsWebView::GraphicsWebView): 16307 (WebViewGraphicsBased::setPage): 16308 163092010-02-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 16310 16311 Rubberstamped by Oliver Hunt. 16312 16313 [Qt] QtLauncher cleanup. 16314 16315 Refactor option handling out in utility functions and make the 16316 arguments more Qt compatible. 16317 16318 * QtLauncher/main.cpp: 16319 (requiresGraphicsView): 16320 (LauncherApplication::handleUserOptions): 16321 * QtLauncher/utils.cpp: 16322 (takeOptionValue): 16323 (formatKeys): 16324 (enumToKeys): 16325 (appQuit): 16326 * QtLauncher/utils.h: 16327 163282010-02-04 Andras Becsi <abecsi@inf.u-szeged.hu> 16329 16330 Reviewed by Tor Arne Vestbø. 16331 16332 Implement a locking and scheduling mechanism for http testing sessions to be able 16333 to run multiple instances of run-webkit-tests parallel on the same machine. 16334 If a test session wants to run http tests and this feature is enabled, the pending 16335 sessions create lockfiles with sequential lock numbers. These locks are used to schedule 16336 the running test sessions in first come first served order. An exclusive lock ensures 16337 that the lock numbers are sequential to avoid deadlocks and starvation. 16338 Because the buildbot master specifies the flags used by slaves we need an environment 16339 variable too to be able to use the feature per-slave. 16340 Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd 16341 flag enables this feature, otherwise this patch has no effect on the testing whatsoever. 16342 16343 https://bugs.webkit.org/show_bug.cgi?id=33153 16344 16345 * Scripts/run-webkit-tests: 16346 * Scripts/webkitperl/httpd.pm: 16347 163482010-01-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 16349 16350 Reviewed by Simon Hausmann. 16351 16352 Make run-webkit-tests work under Cygwin for the Qt port 16353 16354 setPathForRunningWebKitApp() is implemented for the Qt port 16355 by using qmake to query for the location of the Qt libraries. 16356 16357 This requires the original environment (%ENV) to be untouched, 16358 so launchWithCurrentEnv() was refactored to launchWithEnv(), 16359 and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV 16360 instead. This has the added benefit of getting rid of the temp 16361 variables used for storing the current env. 16362 16363 openDumpTool() is also refactored a bit into platform-spesific, 16364 port-spesific, and generic environment variables. 16365 16366 Checks for undef was added a few places to fix Perl concat 16367 warnings when run-webkit-tests is aborted. 16368 16369 https://bugs.webkit.org/show_bug.cgi?id=33895 16370 16371 * Scripts/run-webkit-tests: 16372 * Scripts/webkitdirs.pm: 16373 163742010-02-04 Yuzo Fujishima <yuzo@google.com> 16375 16376 Unreviewed. 16377 16378 Add Yuzo to the committers list. 16379 16380 * Scripts/webkitpy/committers.py: 16381 163822010-02-03 Dirk Pranke <dpranke@chromium.org> 16383 16384 Rubber-stamped by Eric Seidel. 16385 16386 Change "the Chromium name" to "the name of Google Inc." in the licenses 16387 16388 https://bugs.webkit.org/show_bug.cgi?id=34511 16389 16390 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 16391 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 16392 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: 16393 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 16394 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 16395 * Scripts/webkitpy/layout_tests/layout_package/test_files.py: 16396 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 16397 * Scripts/webkitpy/layout_tests/port/__init__.py: 16398 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 16399 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 16400 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 16401 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 16402 * Scripts/webkitpy/layout_tests/port/http_server.py: 16403 * Scripts/webkitpy/layout_tests/port/http_server_base.py: 16404 * Scripts/webkitpy/layout_tests/port/path_utils.py: 16405 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 16406 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 16407 * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: 16408 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: 16409 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 16410 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 16411 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 16412 164132010-02-03 Dirk Pranke <dpranke@chromium.org> 16414 16415 Rubber-stamped by Eric Siedel. 16416 16417 Rename files as part of refactoring the layout_tests package. All 16418 the platform_utils* module, the path_utils.py module, and 16419 the http server and web socket server modules are moved into a new 16420 port/ package. 16421 16422 https://bugs.webkit.org/show_bug.cgi?id=34511 16423 16424 * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Removed. 16425 * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Removed. 16426 * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Removed. 16427 * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Removed. 16428 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 16429 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 16430 * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Removed. 16431 * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Removed. 16432 * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Removed. 16433 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Removed. 16434 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Removed. 16435 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Removed. 16436 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 16437 * Scripts/webkitpy/layout_tests/layout_package/test_files.py: 16438 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 16439 * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Removed. 16440 * Scripts/webkitpy/layout_tests/port: Added. 16441 * Scripts/webkitpy/layout_tests/port/__init__.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils.py. 16442 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py. 16443 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py. 16444 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py. 16445 * Scripts/webkitpy/layout_tests/port/chromium_win.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py. 16446 * Scripts/webkitpy/layout_tests/port/http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server.py. 16447 * Scripts/webkitpy/layout_tests/port/http_server_base.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server_base.py. 16448 * Scripts/webkitpy/layout_tests/port/httpd2.pem: Copied from Scripts/webkitpy/layout_tests/layout_package/httpd2.pem. 16449 * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Copied from Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf. 16450 * Scripts/webkitpy/layout_tests/port/path_utils.py: Copied from Scripts/webkitpy/layout_tests/layout_package/path_utils.py. 16451 * Scripts/webkitpy/layout_tests/port/websocket_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/websocket_server.py. 16452 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 16453 * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: 16454 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: 16455 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 16456 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 16457 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 16458 16459 164602010-02-03 Csaba Osztrogonác <ossy@webkit.org> 16461 16462 Rubber-stamped by Eric Seidel. 16463 16464 Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots 16465 https://bugs.webkit.org/show_bug.cgi?id=34399 16466 16467 * Scripts/run-iexploder-tests: 16468 * Scripts/run-webkit-httpd: 16469 * Scripts/run-webkit-tests: 16470 * Scripts/webkitperl/httpd.pm: Added. 16471 164722010-02-03 Csaba Osztrogonác <ossy@webkit.org> 16473 16474 Rubber-stamped by Eric Seidel. 16475 16476 Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots 16477 16478 * Scripts/run-iexploder-tests: 16479 * Scripts/run-webkit-httpd: 16480 * Scripts/run-webkit-tests: 16481 * Scripts/webkitperl/httpd.pm: Removed. 16482 164832010-02-03 Csaba Osztrogonác <ossy@webkit.org> 16484 16485 Rubber-stamped by Ariya Hidayat. 16486 16487 Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots 16488 https://bugs.webkit.org/show_bug.cgi?id=34399 16489 16490 * DumpRenderTree/win/EventSender.cpp: 16491 (buildModifierFlags): 16492 (mouseDownCallback): 16493 (mouseUpCallback): 16494 (keyDownCallback): 16495 164962010-02-03 Eric Seidel <eric@webkit.org> 16497 16498 No review, just fixing copyrights. 16499 16500 Concerns were expressed about "The Chromium Authors" being 16501 a valid legal entity for copyright assignment in the WebKit repository, 16502 so this change removes all "The Chromium Authors". 16503 16504 I looked at the svn logs in src.chromium.org and failed to find any 16505 non-google contributions to these files, so they are all now 16506 marked as copyright "Google Inc" as all Google contributers assign 16507 copyright to "Google Inc" as part of their employment agreement. 16508 16509 * Scripts/rebaseline-chromium-webkit-tests: 16510 * Scripts/run-chromium-webkit-tests: 16511 * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: 16512 * Scripts/webkitpy/layout_tests/layout_package/http_server.py: 16513 * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: 16514 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 16515 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 16516 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: 16517 * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: 16518 * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: 16519 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: 16520 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: 16521 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: 16522 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 16523 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 16524 * Scripts/webkitpy/layout_tests/layout_package/test_files.py: 16525 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 16526 * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: 16527 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 16528 * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: 16529 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: 16530 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 16531 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 16532 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 16533 165342010-02-03 Kenneth Rohde Christiansen <kenneth@webkit.org> 16535 16536 Reviewed by Ariya Hidayat. 16537 16538 [Qt] QtLauncher, refactor argument handling in preparation of merge 16539 with QGVLauncher 16540 16541 * QtLauncher/main.cpp: 16542 (LauncherApplication::urls): 16543 (LauncherApplication::isRobotized): 16544 (LauncherApplication::applyDefaultSettings): 16545 (LauncherApplication::LauncherApplication): 16546 (LauncherApplication::formatKeys): 16547 (LauncherApplication::enumToKeys): 16548 (fail): 16549 (LauncherApplication::handleUserOptions): 16550 (main): 16551 165522010-02-03 Csaba Osztrogonác <ossy@webkit.org> 16553 16554 Rubber-stamped by Ariya Hidayat. 16555 16556 Rolling out r53889, because it might caused flakeyness on the Windows Test bots 16557 https://bugs.webkit.org/show_bug.cgi?id=34399 16558 16559 * DumpRenderTree/win/EventSender.cpp: 16560 (mouseDownCallback): 16561 (mouseUpCallback): 16562 (keyDownCallback): 16563 165642010-02-03 Csaba Osztrogonác <ossy@webkit.org> 16565 16566 Reviewed by Ariya Hidayat. 16567 16568 [Qt] Fix pixel tests support. 16569 https://bugs.webkit.org/show_bug.cgi?id=27813 16570 16571 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 16572 (WebCore::DumpRenderTree::open): 16573 (WebCore::DumpRenderTree::processLine): 16574 - Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine. 16575 (WebCore::DumpRenderTree::dump): Fixed and renamed variables. 16576 165772010-02-03 Kevin Watters <kevinwatters@gmail.com> 16578 16579 Reviewed by Kevin Ollivier. 16580 16581 [wx] Enable JIT compilation for wx. 16582 16583 https://bugs.webkit.org/show_bug.cgi?id=34536 16584 16585 * wx/build/settings.py: 16586 165872010-02-02 Kevin Ollivier <kevino@theolliviers.com> 16588 16589 [wx] Build fix after introduction of pageNumberForElementById. 16590 16591 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 16592 (LayoutTestController::pageNumberForElementById): 16593 165942010-02-02 Shu Chang <Chang.Shu@nokia.com> 16595 16596 Unreviewed. 16597 16598 Add myself to list of committers. 16599 16600 * Scripts/webkitpy/committers.py: 16601 166022010-02-02 Chris Jerdonek <cjerdonek@webkit.org> 16603 16604 Reviewed by Shinichiro Hamaji. 16605 16606 Moved filter-related check-webkit-style code into a separate 16607 filter module. 16608 16609 https://bugs.webkit.org/show_bug.cgi?id=34408 16610 16611 This is preparatory refactoring for Bug 33684, which will allow 16612 file and folder-specific filter rules. 16613 16614 * Scripts/webkitpy/style/checker.py: 16615 - Removed CategoryFilter class (moved to filter.py). 16616 16617 * Scripts/webkitpy/style/checker_unittest.py: 16618 - Removed CategoryFilter unit tests (moved to filter_unittest.py). 16619 16620 * Scripts/webkitpy/style/filter.py: Added. 16621 - Added CategoryFilter class (moved from checker.py). 16622 16623 * Scripts/webkitpy/style/filter_unittest.py: Added. 16624 - Added CategoryFilter unit tests (moved from checker_unittest.py). 16625 16626 * Scripts/webkitpy/style/unittests.py: 16627 - Added reference to filter_unittest.py. 16628 166292010-02-01 Chris Jerdonek <cjerdonek@webkit.org> 16630 16631 Reviewed by Shinichiro Hamaji. 16632 16633 Addressed FIXME in check-webkit-style so that the carriage-return 16634 check will work for patches. 16635 16636 https://bugs.webkit.org/show_bug.cgi?id=34260 16637 16638 Also added support for limiting the number of errors reported 16639 per category, per file. 16640 16641 * Scripts/webkitpy/style/checker.py: 16642 - Added new "whitespace/carriage_return" category from common.py. 16643 - Added MAX_REPORTS_PER_CATEGORY dictionary. 16644 - Added max_reports_per_category attribute to ProcessorOptions class. 16645 - Refactored StyleChecker._process_file(). 16646 16647 * Scripts/webkitpy/style/checker_unittest.py: 16648 - Updated ProcessorOptionsTest tests. 16649 - Added test to check MAX_REPORTS_PER_CATEGORY. 16650 16651 * Scripts/webkitpy/style/error_handlers.py: 16652 - Added support for suppressing the display of errors after 16653 reaching a per-category maximum (from max_reports_per_category). 16654 16655 * Scripts/webkitpy/style/error_handlers_unittest.py: 16656 - Added test for suppressing error display. 16657 16658 * Scripts/webkitpy/style/processors/common.py: Added. 16659 - Moved carriage-return check to new file. 16660 16661 * Scripts/webkitpy/style/processors/common_unittest.py: Added. 16662 - Added unit tests for carriage-return check. 16663 16664 * Scripts/webkitpy/style/unittests.py: 16665 - Added reference to common_unittest.py. 16666 166672010-02-01 Shinichiro Hamaji <hamaji@chromium.org> 16668 16669 Reviewed by Eric Seidel. 16670 16671 Provide a way to get page number with layoutTestController 16672 https://bugs.webkit.org/show_bug.cgi?id=33840 16673 16674 * DumpRenderTree/LayoutTestController.cpp: 16675 (pageNumberForElementByIdCallback): 16676 (LayoutTestController::staticFunctions): 16677 * DumpRenderTree/LayoutTestController.h: 16678 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 16679 (LayoutTestController::pageNumberForElementById): 16680 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 16681 (LayoutTestController::pageNumberForElementById): 16682 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 16683 (LayoutTestController::pageNumberForElementById): 16684 166852010-02-01 Shinichiro Hamaji <hamaji@chromium.org> 16686 16687 Unreviewed fix for an invalid function call. 16688 16689 check-webkit-style: Remove filename parameter from all functions where no longer used 16690 https://bugs.webkit.org/show_bug.cgi?id=34249 16691 16692 * Scripts/webkitpy/style/checker.py: 16693 166942010-02-01 Diego Gonzalez <diego.gonzalez@openbossa.org> 16695 16696 Reviewed by Kenneth Rohde Christiansen. 16697 16698 [Qt] DRT Provide global flag ability 16699 https://bugs.webkit.org/show_bug.cgi?id=34418 16700 16701 Add the globalFlag property to the Qt LayoutTestController to allow 16702 cross-domain indications. 16703 16704 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 16705 (LayoutTestController::reset): 16706 * DumpRenderTree/qt/LayoutTestControllerQt.h: 16707 (LayoutTestController::globalFlag): 16708 (LayoutTestController::setGlobalFlag): 16709 167102010-02-01 Brady Eidson <beidson@apple.com> 16711 16712 Reviewed by Adele Peterson. 16713 16714 Crash in Safari opening new tabs to "same page" 16715 <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444 16716 16717 Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView: 16718 16719 * DumpRenderTree/LayoutTestController.cpp: 16720 (LayoutTestController::LayoutTestController): 16721 (setNewWindowsCopyBackForwardListCallback): 16722 (LayoutTestController::staticFunctions): 16723 16724 * DumpRenderTree/LayoutTestController.h: 16725 (LayoutTestController::newWindowsCopyBackForwardList): 16726 (LayoutTestController::setNewWindowsCopyBackForwardList): 16727 16728 * DumpRenderTree/mac/UIDelegate.mm: 16729 (-[UIDelegate webView:createWebViewWithRequest:]): 16730 167312010-02-01 Carol Szabo <carol.szabo@nokia.com> 16732 16733 Unreviewed. 16734 16735 Add myself to list of committers. 16736 16737 * Scripts/webkitpy/committers.py: 16738 167392010-02-01 Nate Chapin <japhet@chromium.org> 16740 16741 Rubber-stamped by David Levin. 16742 16743 Add myself to reviewer list. 16744 16745 * Scripts/webkitpy/committers.py: 16746 167472010-01-31 Chris Jerdonek <cjerdonek@webkit.org> 16748 16749 Reviewed by Shinichiro Hamaji. 16750 16751 Moved style error handler code to their own classes, and 16752 related refactoring. Increased unit test code coverage of 16753 style error handling. 16754 16755 https://bugs.webkit.org/show_bug.cgi?id=34379 16756 16757 * Scripts/check-webkit-style: 16758 - Minor change: added error_count variable. 16759 16760 * Scripts/webkitpy/style/checker.py: 16761 - Renamed ProcessorOptions.should_report_error() to is_reportable(). 16762 - In the StyleChecker class-- 16763 - Removed _default_style_error_handler(). 16764 - Added _increment_error_count(). 16765 - Refactored to use DefaultStyleErrorHandler and 16766 PatchStyleErrorHandler constructors. 16767 16768 * Scripts/webkitpy/style/checker_unittest.py: 16769 - In the StyleStyleCheckerTest class-- 16770 - Removed write_sample_error(). 16771 - Removed test_default_style_error_handler(). 16772 16773 * Scripts/webkitpy/style/error_handlers.py: Added. 16774 - Added DefaultStyleErrorHandler class. 16775 - Added PatchStyleErrorHandler class. 16776 16777 * Scripts/webkitpy/style/error_handlers_unittest.py: Added. 16778 - Added unit tests for DefaultStyleErrorHandler and 16779 PatchStyleErrorHandler. 16780 16781 * Scripts/webkitpy/style/unittests.py: 16782 - Added error_handlers unit tests. 16783 167842010-01-29 Mark Rowe <mrowe@apple.com> 16785 16786 Rubber-stamped by Stephanie Lewis. 16787 16788 Fix run-leaks with newer versions of the leaks tool. 16789 16790 * Scripts/run-leaks: 16791 167922010-01-29 Dirk Pranke <dpranke@chromium.org> 16793 16794 Reviewed by Eric Siedel. 16795 16796 Top-level test drivers for running the Chromium port of run-webkit-tests 16797 and being able to rebaseline test results from the test bots. The 16798 files in the Scripts directory are simply wrappers around the files 16799 in webkitpy/layout_tests for convenience. 16800 16801 https://bugs.webkit.org/show_bug.cgi?id=31498 16802 16803 * Scripts/rebaseline-chromium-webkit-tests: Added. 16804 * Scripts/run-chromium-webkit-tests: Added. 16805 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added. 16806 * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added. 16807 168082010-01-29 Dirk Pranke <dpranke@chromium.org> 16809 16810 Reviewed by Eric Siedel. 16811 16812 Add in the second block of python code for the Chromium port 16813 of run-webkit-tests. These files execute different diffs to classify 16814 the various types of failures from a test. 16815 16816 * Scripts/webkitpy/layout_tests/test_types: Added. 16817 * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added. 16818 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added. 16819 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added. 16820 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added. 16821 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added. 16822 168232010-01-29 Dirk Pranke <dpranke@chromium.org> 16824 16825 Reviewed by Eric Siedel. 16826 16827 Check in the first part of the Chromium Python port of the 16828 run-webkit-tests test driver. The files under 16829 layout_tests/layout_layout constitute most of the implementation; 16830 they can be roughly divided into code that parses the 16831 "test_expectations.txt" file that describes how we expect tests to 16832 pass or fail, platform-specific hooks for the different Chromium 16833 ports (in platform_utils*), code for parsing the output of the 16834 tests and generating results files and HTML and JSON for the 16835 dashboards, auxiliary scripts for starting and stopping HTTP and 16836 Web Socket servers, and then one of the actual driver files 16837 (test_shell_thread). Code for actually parsing test output for 16838 failures and the top-level driver scripts will follow shortly. 16839 16840 https://bugs.webkit.org/show_bug.cgi?id=31498 16841 16842 * Scripts/webkitpy/layout_tests: Added. 16843 * Scripts/webkitpy/layout_tests/layout_package: Added. 16844 * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added. 16845 * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added. 16846 * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added. 16847 * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added. 16848 * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added. 16849 - scripts to start and stop apache. Note that the apache file 16850 generates a conf file dynamically, and we should switch to 16851 using the same static conf file that the regular run-webkit-tests 16852 uses, and we can also use the same httpd2.pem file. 16853 16854 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added. 16855 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added. 16856 - scripts to generate the JSON layout test dashboard and the 16857 flakiness dashboard 16858 * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added. 16859 - default configuration for LigHTTPd (used on Windows) 16860 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added. 16861 - utility class that implements progress bars on the console to 16862 be displayed while the tests are running 16863 * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added. 16864 - various routines for manipulating paths and URIs 16865 * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added. 16866 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added. 16867 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added. 16868 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added. 16869 - platform-specific aspects of the drivers (binary names, paths, 16870 process control, etc.) 16871 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added. 16872 - code for parsing the 'test_expectations.txt' file to determine 16873 which tests are expected to fail (and how) on which platforms 16874 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added. 16875 - code for handling different kinds of failures (generating output 16876 in the results, etc.) 16877 * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added. 16878 - code to gather the lists of tests 16879 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added. 16880 - code to actually execute tests via TestShell and process 16881 the output 16882 * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added. 16883 - scripts to start and stop the pywebsocket server 16884 168852010-01-29 Dirk Pranke <dpranke@chromium.org> 16886 16887 Reviewed by Eric Seidel. 16888 16889 Check in a copy of the simplejson library; it will be used by 16890 the Chromium port of run-webkit-tests. 16891 16892 https://bugs.webkit.org/show_bug.cgi?id=31498 16893 16894 * simplejson: Added. 16895 * simplejson/LICENSE.txt: Added. 16896 * simplejson/README.txt: Added. 16897 * simplejson/__init__.py: Added. 16898 * simplejson/_speedups.c: Added. 16899 (ascii_escape_char): 16900 (ascii_escape_unicode): 16901 (ascii_escape_str): 16902 (py_encode_basestring_ascii): 16903 (init_speedups): 16904 * simplejson/decoder.py: Added. 16905 * simplejson/encoder.py: Added. 16906 * simplejson/jsonfilter.py: Added. 16907 * simplejson/scanner.py: Added. 16908 169092010-01-29 Dirk Pranke <dpranke@chromium.org> 16910 16911 No review 16912 16913 Add myself to the committers list 16914 16915 * Scripts/webkitpy/committers.py: 16916 169172010-01-29 Jeremy Orlow <jorlow@chromium.org> 16918 16919 Reviewed by Dimitri Glazkov. 16920 16921 A first step towards the Indexed Database API 16922 https://bugs.webkit.org/show_bug.cgi?id=34342 16923 16924 Add indexed database API. 16925 16926 * Scripts/build-webkit: 16927 169282010-01-29 Andras Becsi <abecsi@webkit.org> 16929 16930 Reviewed by Alexey Proskuryakov. 16931 16932 Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used. 16933 This fixes a regression introduced in r53559. 16934 16935 https://bugs.webkit.org/show_bug.cgi?id=34336 16936 16937 * Scripts/webkitperl/httpd.pm: 16938 169392010-01-28 Jon Honeycutt <jhoneycutt@apple.com> 16940 16941 MSAA: Crash when posting a notification for a detached object 16942 16943 https://bugs.webkit.org/show_bug.cgi?id=34309 16944 <rdar://problem/7409759> 16945 16946 Reviewed by Darin Adler. 16947 16948 * DumpRenderTree/AccessibilityController.h: 16949 Declare new functions. Add new members to store the event hook and the 16950 mapping of accessibility elements to their JS callbacks. 16951 16952 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 16953 (AccessibilityController::notificationReceived): 16954 Stubbed. 16955 (AccessibilityController::addNotificationListener): 16956 Stubbed. 16957 16958 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 16959 (AccessibilityController::notificationReceived): 16960 Stubbed. 16961 (AccessibilityController::addNotificationListener): 16962 Stubbed. 16963 16964 * DumpRenderTree/win/AccessibilityControllerWin.cpp: 16965 (AccessibilityController::AccessibilityController): 16966 Initialize the event hook. 16967 (AccessibilityController::~AccessibilityController): 16968 Remove the event hook. Unprotect all of the JS functions that are stored 16969 in the map. 16970 (logEventProc): 16971 Clean-up a variable. 16972 (stringEvent): 16973 Return a string description of the MSAA event code. 16974 (notificationListenerProc): 16975 Get the accessible object from the event, and query it for IAccessible. 16976 Call the AccessibilityController's notificationReceived(). 16977 (comparableObject): 16978 Use QueryService to obtain the IAccessibleComparable for the 16979 IServiceProvider. 16980 (AccessibilityController::notificationReceived): 16981 Iterate the map of objects that have registered for notification 16982 callbacks. Query each for IServiceProvider, then use comparableObject() 16983 to get an IAccessibleComparable. If we find an object matching the 16984 notified object, call its callback, passing the event that was received. 16985 (AccessibilityController::addNotificationListener): 16986 If we have not created the event hook, create it. Protect the JS 16987 callback function object, and add the object and its callback to our 16988 map. 16989 16990 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 16991 (AccessibilityUIElement::addNotificationListener): 16992 Call through to the AccessibilityController's addNotificationListener(). 16993 16994 * DumpRenderTree/win/DumpRenderTreeWin.h: 16995 Add an extern declaration for the shared FrameLoadDelegate extern, so we 16996 can access it from AccessibilityController. 16997 16998 * DumpRenderTree/win/FrameLoadDelegate.h: 16999 (FrameLoadDelegate::accessibilityController): 17000 Return the AccessibilityController. 17001 170022010-01-29 Shinichiro Hamaji <hamaji@chromium.org> 17003 17004 Reviewed by Darin Adler. 17005 17006 prepare-ChangeLog outputs useless messages for a nonexistent bug ID 17007 https://bugs.webkit.org/show_bug.cgi?id=34313 17008 17009 * Scripts/prepare-ChangeLog: 17010 170112010-01-29 Kenneth Rohde Christiansen <kenneth@webkit.org> 17012 17013 Rubberstamped by Simon Hausmann. 17014 17015 [Qt] Separate implementation from class definition. 17016 17017 * QtLauncher/main.cpp: 17018 (LauncherWindow::webView): 17019 (LauncherWindow::LauncherWindow): 17020 (LauncherWindow::~LauncherWindow): 17021 (LauncherWindow::keyPressEvent): 17022 (LauncherWindow::grabZoomKeys): 17023 (LauncherWindow::sendTouchEvent): 17024 (LauncherWindow::eventFilter): 17025 (LauncherWindow::loadStarted): 17026 (LauncherWindow::loadFinished): 17027 (LauncherWindow::showLinkHover): 17028 (LauncherWindow::zoomIn): 17029 (LauncherWindow::zoomOut): 17030 (LauncherWindow::resetZoom): 17031 (LauncherWindow::toggleZoomTextOnly): 17032 (LauncherWindow::print): 17033 (LauncherWindow::screenshot): 17034 (LauncherWindow::setEditable): 17035 (LauncherWindow::dumpHtml): 17036 (LauncherWindow::selectElements): 17037 (LauncherWindow::setTouchMocking): 17038 (LauncherWindow::newWindow): 17039 (LauncherWindow::setupUI): 17040 170412010-01-29 Kenneth Rohde Christiansen <kenneth@webkit.org> 17042 17043 Reviewed by Ariya Hidayat. 17044 17045 [Qt] On Maemo5, a click/touch in the location bar (when unfocused) 17046 should result in all text selected. 17047 17048 * QtLauncher/locationedit.cpp: 17049 (LocationEdit::focusInEvent): 17050 * QtLauncher/locationedit.h: 17051 170522010-01-29 Kenneth Rohde Christiansen <kenneth@webkit.org> 17053 17054 Reviewed by Ariya Hidayat. 17055 17056 [Qt] Show progress reaching 100% for loads. 17057 17058 * QtLauncher/locationedit.cpp: 17059 (LocationEdit::LocationEdit): 17060 (LocationEdit::setProgress): 17061 (LocationEdit::reset): 17062 (LocationEdit::paintEvent): 17063 * QtLauncher/locationedit.h: 17064 170652010-01-29 Andreas Kling <andreas.kling@nokia.com> 17066 17067 Reviewed by Kenneth Rohde Christiansen. 17068 17069 [Qt] Disable the QtLauncher statusbar on Maemo 17070 17071 https://bugs.webkit.org/show_bug.cgi?id=34330 17072 17073 * QtLauncher/main.cpp: 17074 (LauncherWindow::showLinkHover): 17075 (LauncherWindow::selectElements): 17076 170772010-01-29 Andreas Kling <andreas.kling@nokia.com> 17078 17079 Reviewed by Kenneth Rohde Christiansen. 17080 17081 [Qt] Display page loading progress inside the QtLauncher location bar 17082 17083 https://bugs.webkit.org/show_bug.cgi?id=34210 17084 17085 * QtLauncher/QtLauncher.pro: 17086 * QtLauncher/locationedit.cpp: Added. 17087 (LocationEdit::LocationEdit): 17088 (LocationEdit::setProgress): 17089 (LocationEdit::paintEvent): 17090 * QtLauncher/locationedit.h: Added. 17091 * QtLauncher/mainwindow.cpp: 17092 (MainWindow::buildUI): 17093 * QtLauncher/mainwindow.h: 17094 170952010-01-29 Andreas Kling <andreas.kling@nokia.com> 17096 17097 Reviewed by Kenneth Rohde Christiansen. 17098 17099 [Qt] Add support for Maemo zoom keys in QtLauncher 17100 17101 https://bugs.webkit.org/show_bug.cgi?id=34160 17102 17103 * QtLauncher/main.cpp: 17104 (LauncherWindow::LauncherWindow): 17105 (LauncherWindow::~LauncherWindow): 17106 (LauncherWindow::keyPressEvent): 17107 (LauncherWindow::grabZoomKeys): 17108 171092010-01-29 Benjamin Poulain <benjamin.poulain@nokia.com> 17110 17111 Reviewed by Kenneth Rohde Christiansen. 17112 17113 [Qt] Implement the display() method of the layout test controller 17114 https://bugs.webkit.org/show_bug.cgi?id=34258 17115 17116 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 17117 (WebCore::DumpRenderTree::DumpRenderTree): 17118 (WebCore::DumpRenderTree::showPage): 17119 (WebCore::DumpRenderTree::hidePage): 17120 * DumpRenderTree/qt/DumpRenderTreeQt.h: 17121 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 17122 (LayoutTestController::reset): 17123 (LayoutTestController::display): 17124 * DumpRenderTree/qt/LayoutTestControllerQt.h: 17125 171262010-01-28 Kevin Ollivier <kevino@theolliviers.com> 17127 17128 [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation 17129 implements pthread_t in a way that makes it impossible to check its validity, 17130 which is needed by ThreadingPthreads.cpp. 17131 17132 * DumpRenderTree/wscript: 17133 * wx/build/settings.py: 17134 171352010-01-28 Andras Becsi <abecsi@webkit.org> 17136 17137 Adding myself to the committer list. No review needed. 17138 17139 * Scripts/webkitpy/committers.py: 17140 171412010-01-28 Hayato Ito <hayato@chromium.org> 17142 17143 Reviewed by David Levin. 17144 17145 Remove NULL char from input JS file because 'grep' fails if the file contains NULL char. 17146 17147 https://bugs.webkit.org/show_bug.cgi?id=34252 17148 17149 * Scripts/make-script-test-wrappers: 17150 171512010-01-28 Kevin Ollivier <kevino@theolliviers.com> 17152 17153 [wx] Build fix after removal of the zlib image decoder. 17154 17155 * wx/build/settings.py: 17156 171572010-01-28 Csaba Osztrogonác <ossy@webkit.org> 17158 17159 [Qt] Unreviewed, roll out r54000. 17160 17161 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 17162 (WebCore::DumpRenderTree::DumpRenderTree): 17163 * DumpRenderTree/qt/DumpRenderTreeQt.h: 17164 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 17165 (LayoutTestController::reset): 17166 * DumpRenderTree/qt/LayoutTestControllerQt.h: 17167 (LayoutTestController::display): 17168 171692010-01-28 Benjamin Poulain <benjamin.poulain@nokia.com> 17170 17171 Reviewed by Kenneth Rohde Christiansen. 17172 17173 [Qt] Implement the display() method of the layout test controller 17174 https://bugs.webkit.org/show_bug.cgi?id=34258 17175 17176 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 17177 (WebCore::DumpRenderTree::DumpRenderTree): 17178 (WebCore::DumpRenderTree::showPage): 17179 (WebCore::DumpRenderTree::hidePage): 17180 * DumpRenderTree/qt/DumpRenderTreeQt.h: 17181 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 17182 (LayoutTestController::reset): 17183 (LayoutTestController::display): 17184 * DumpRenderTree/qt/LayoutTestControllerQt.h: 17185 171862010-01-28 Chris Jerdonek <cjerdonek@webkit.org> 17187 17188 Reviewed by Shinichiro Hamaji. 17189 17190 Eliminated the filename parameter from functions in 17191 check-webkit-style's cpp.py where it is no longer used. 17192 17193 https://bugs.webkit.org/show_bug.cgi?id=34249 17194 17195 * Scripts/webkitpy/style/processors/cpp.py: 17196 - Reduced number of occurrences of "filename" variable from 17197 approximately 200 to 120. 17198 17199 * Scripts/webkitpy/style/processors/cpp_unittest.py: 17200 - Refactored unit tests as necessary to accommodate changes to cpp.py. 17201 - Fixed bug in CppStyleTestBase.perform_include_what_you_use() 17202 where the incorrect file extension was getting passed to 17203 cpp_style.check_language(). 17204 172052010-01-28 Chris Jerdonek <cjerdonek@webkit.org> 17206 17207 Reviewed by Shinichiro Hamaji. 17208 17209 In check-webkit-style, eliminated the dependency of 17210 processors/cpp_unittest.py on checker.py. 17211 17212 https://bugs.webkit.org/show_bug.cgi?id=34205 17213 17214 * Scripts/webkitpy/style/checker.py: 17215 - Addressed FIXME by removing STYLE_CATEGORIES data. 17216 - Added style_categories(). 17217 17218 * Scripts/webkitpy/style/checker_unittest.py: 17219 - Minor changes. 17220 17221 * Scripts/webkitpy/style/processors/cpp.py: 17222 - Added categories attribute to CppProcessor class (data 17223 was originally checker.STYLE_CATEGORIES). 17224 17225 * Scripts/webkitpy/style/processors/cpp_unittest.py: 17226 - Addressed FIXME by eliminating "import" from checker.py. 17227 172282010-01-28 Anton Muhin <antonm@chromium.org> 17229 17230 Reviewed by Shinichiro Hamaji. 17231 17232 Improve treatment of conditions and rest of the line for if, else, switch and alikes 17233 https://bugs.webkit.org/show_bug.cgi?id=34173 17234 17235 * Scripts/webkitpy/style/cpp_style.py: 17236 * Scripts/webkitpy/style/cpp_style_unittest.py: 17237 172382010-01-28 Joe Mason <jmason@rim.com> 17239 17240 Reviewed by Adam Barth. 17241 17242 Limit login retries to 5 17243 https://bugs.webkit.org/show_bug.cgi?id=34193 17244 17245 * Scripts/webkitpy/bugzilla.py: 17246 172472010-01-27 Martin Robinson <mrobinson@webkit.org> 17248 17249 Adding myself to the committer list. No review necessary. 17250 17251 * Scripts/webkitpy/committers.py: 17252 172532010-01-27 George Wright <gwright@rim.com> 17254 17255 Reviewed by Adam Treat. 17256 17257 https://bugs.webkit.org/show_bug.cgi?id=34216 17258 17259 Add missing include for wtf/Platform.h 17260 17261 * DumpRenderTree/AccessibilityController.h: 17262 172632010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org> 17264 17265 Reviewed by Kenneth Rohde Christiansen. 17266 17267 [Qt] DRT Provide worker thread ability to track counters 17268 https://bugs.webkit.org/show_bug.cgi?id=34221 17269 17270 Implement workerThreadCount() in LayoutTestController of Qt DRT 17271 17272 Tests: 17273 fast/workers/dedicated-worker-lifecycle.html 17274 fast/workers/shared-worker-frame-lifecycle.html 17275 fast/workers/shared-worker-lifecycle.html 17276 fast/workers/worker-lifecycle.html 17277 17278 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 17279 (LayoutTestController::workerThreadCount): 17280 * DumpRenderTree/qt/LayoutTestControllerQt.h: 17281 172822010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 17283 17284 Rubberstamped by Simon Hausmann. 17285 17286 [Qt] QtLauncher refactoring: 17287 17288 Make the LauncherWindow depend less on the view, so that more 17289 code can be shared in near future. 17290 17291 * QtLauncher/main.cpp: 17292 (LauncherWindow::sendTouchEvent): 17293 (LauncherWindow::loadFinished): 17294 (LauncherWindow::zoomIn): 17295 (LauncherWindow::zoomOut): 17296 (LauncherWindow::resetZoom): 17297 (LauncherWindow::toggleZoomTextOnly): 17298 (LauncherWindow::dumpHtml): 17299 (LauncherWindow::selectElements): 17300 (LauncherWindow::setupUI): 17301 173022010-01-27 Kinuko Yasuda <kinuko@chromium.org> 17303 17304 Reviewed by Eric Seidel. 17305 17306 Correctly handle the KeyLocation argument that has been introduced 17307 recently to test location-dependent key events in EventSender.keyDown. 17308 http://bugs.webkit.org/show_bug.cgi?id=28247 17309 17310 Test: fast/events/keydown-numpad-keys.html 17311 17312 * DumpRenderTree/gtk/EventSender.cpp: 17313 (keyDownCallback): 17314 173152010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 17316 17317 Rubberstamped by Simon Hausmann. 17318 17319 [Qt] QtLauncher refactoring: 17320 17321 Move out code from the MainWindow (renamed to LauncherWindow) 17322 that is not depending on the view, and add it to a new class 17323 called MainWindow. 17324 17325 * QtLauncher/QtLauncher.pro: 17326 * QtLauncher/main.cpp: 17327 (LauncherWindow::LauncherWindow): 17328 (LauncherWindow::eventFilter): 17329 (LauncherWindow::loadStarted): 17330 (LauncherWindow::loadFinished): 17331 (LauncherWindow::newWindow): 17332 (LauncherWindow::setupUI): 17333 (WebPage::createWindow): 17334 (main): 17335 * QtLauncher/mainwindow.cpp: Added. 17336 (MainWindow::MainWindow): 17337 (MainWindow::buildUI): 17338 (MainWindow::page): 17339 (MainWindow::setAddressUrl): 17340 (MainWindow::addCompleterEntry): 17341 (MainWindow::load): 17342 (MainWindow::changeLocation): 17343 (MainWindow::openFile): 17344 * QtLauncher/mainwindow.h: Added. 17345 173462010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 17347 17348 Rubberstamped by Simon Hausmann. 17349 17350 [Qt] QtLauncher, coding style fixes. 17351 17352 * QtLauncher/main.cpp: 17353 (MainWindow::MainWindow): 17354 (MainWindow::sendTouchEvent): 17355 (MainWindow::eventFilter): 17356 (MainWindow::loadURL): 17357 (MainWindow::setupUI): 17358 (WebPage::createPlugin): 17359 173602010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 17361 17362 Rubberstamped by Simon Hausmann. 17363 17364 [Qt] QtLauncher refactoring, separating the webview and 17365 adding a QGraphicsWebView based version. 17366 17367 * QtLauncher/QtLauncher.pro: 17368 * QtLauncher/main.cpp: 17369 (MainWindow::MainWindow): 17370 * QtLauncher/webpage.h: 17371 * QtLauncher/webview.cpp: Added. 17372 (createContextMenu): 17373 (WebViewGraphicsBased::mousePressEvent): 17374 (WebViewTraditional::mousePressEvent): 17375 (WebViewGraphicsBased::contextMenuEvent): 17376 (WebViewTraditional::contextMenuEvent): 17377 * QtLauncher/webview.h: Added. 17378 (WebViewGraphicsBased::WebViewGraphicsBased): 17379 (WebViewTraditional::WebViewTraditional): 17380 173812010-01-27 Alexander Pavlov <apavlov@chromium.org> 17382 17383 Adding myself as committer. No review necessary. 17384 17385 * Scripts/webkitpy/committers.py: 17386 173872010-01-27 Eric Seidel <eric@webkit.org> 17388 17389 Reviewed by Darin Adler. 17390 17391 webkit-patch needs an open-bugs command 17392 https://bugs.webkit.org/show_bug.cgi?id=30793 17393 17394 * Scripts/test-webkitpy: import OpenBugsTest 17395 * Scripts/webkit-patch: import OpenBugs 17396 * Scripts/webkitpy/commands/download_unittest.py: don't import unittest 17397 * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto 17398 * Scripts/webkitpy/commands/queries_unittest.py: ditto 17399 * Scripts/webkitpy/commands/queues_unittest.py: ditto 17400 * Scripts/webkitpy/commands/upload_unittest.py: ditto 17401 * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called. 17402 174032010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 17404 17405 Rubberstamped by Simon Hausmann 17406 17407 [Qt] QtLauncher refactoring, separating utility methods. 17408 17409 * QtLauncher/QtLauncher.pro: 17410 * QtLauncher/main.cpp: 17411 * QtLauncher/utils.cpp: Added. 17412 (urlFromUserInput): 17413 * QtLauncher/utils.h: Added. 17414 174152010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 17416 17417 Rubberstamped by Simon Hausmann 17418 17419 [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy. 17420 17421 * QtLauncher/main.cpp: 17422 (MainWindow::MainWindow): 17423 * QtLauncher/webpage.cpp: 17424 (WebPage::WebPage): 17425 (WebPage::applyProxy): 17426 * QtLauncher/webpage.h: 17427 174282010-01-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 17429 17430 Reviewed by Tor Arne Vestbø. 17431 17432 [Qt] Corrects debug build of DumpRenderTree on Windows. 17433 17434 * DumpRenderTree/qt/DumpRenderTree.pro: 17435 174362010-01-26 Daniel Bates <dbates@webkit.org> 17437 17438 Reviewed by Adam Barth. 17439 17440 https://bugs.webkit.org/show_bug.cgi?id=34070 17441 17442 Moves the try/catch for OSError exceptions in Executive.run_command 17443 to Credentials.read_credentials() so that the unit test 17444 webkitpy.scm_unittest.SCMClassTests.test_error_handlers can 17445 assert that Executive.run_command throws an OSError exception. 17446 17447 * Scripts/webkitpy/credentials.py: 17448 * Scripts/webkitpy/executive.py: Moved try/catch for OSError to 17449 method Credentials.read_credentials(). 17450 * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer 17451 apply: test_run_command_with_bad_command_check_return_code and 17452 test_run_command_with_bad_command_check_calls_error_handler. Added new 17453 test to assert that run_command throws OSError exceptions. 17454 174552010-01-26 Diego Gonzalez <diego.gonzalez@openbossa.org> 17456 17457 Reviewed by Kenneth Rohde Christiansen. 17458 17459 [Qt] DRT WebHistory support 17460 https://bugs.webkit.org/show_bug.cgi?id=34167 17461 17462 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 17463 (LayoutTestController::reset): 17464 (LayoutTestController::webHistoryItemCount): 17465 (LayoutTestController::keepWebHistory): 17466 * DumpRenderTree/qt/LayoutTestControllerQt.h: 17467 174682010-01-26 Kent Tamura <tkent@chromium.org> 17469 17470 Reviewed by Eric Seidel. 17471 17472 [Win] Add modifiers parameter support to Windows DumpRenderTree 17473 https://bugs.webkit.org/show_bug.cgi?id=34068 17474 17475 Add support for functional name modifiers; "addSelectionKey" and 17476 "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown() 17477 and eventSender.mouseUp(). 17478 This change is similar to r53498 for Mac. 17479 17480 * DumpRenderTree/win/EventSender.cpp: 17481 (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM. 17482 (mouseDownCallback): Call buidlModifiersFlags(). 17483 (mouseUpCallback): ditto. 17484 (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey". 17485 174862010-01-26 Chris Jerdonek <cjerdonek@webkit.org> 17487 17488 Reviewed by Eric Seidel. 17489 17490 The Python autoinstall cache directory now only gets created 17491 in the directory containing autoinstall.py. 17492 17493 https://bugs.webkit.org/show_bug.cgi?id=33365 17494 17495 * Scripts/webkitpy/autoinstall.py: 17496 - Also added a README file to the cache directory saying 17497 where it came from. 17498 174992010-01-26 Chris Jerdonek <cjerdonek@webkit.org> 17500 17501 Reviewed by Eric Seidel. 17502 17503 Moved the check-webkit-style processors into a new 17504 webkitpy/style/processors directory. 17505 17506 https://bugs.webkit.org/show_bug.cgi?id=34060 17507 17508 * Scripts/webkitpy/style/checker.py: 17509 * Scripts/webkitpy/style/checker_unittest.py: 17510 * Scripts/webkitpy/style/cpp_style.py: Removed. 17511 * Scripts/webkitpy/style/cpp_style_unittest.py: Removed. 17512 * Scripts/webkitpy/style/processors: Added. 17513 * Scripts/webkitpy/style/processors/__init__.py: Added. 17514 * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py. 17515 * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py. 17516 * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py. 17517 * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py. 17518 * Scripts/webkitpy/style/text_style.py: Removed. 17519 * Scripts/webkitpy/style/text_style_unittest.py: Removed. 17520 * Scripts/webkitpy/style/unittests.py: 17521 175222010-01-26 Kevin Ollivier <kevino@theolliviers.com> 17523 17524 [wx] Build fix, make sure stub function returns a value. 17525 17526 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 17527 (LayoutTestController::counterValueForElementById): 17528 175292010-01-26 Steve Falkenburg <sfalken@apple.com> 17530 17531 Reviewed by Oliver Hunt. 17532 17533 Windows build references non-existent include paths 17534 https://bugs.webkit.org/show_bug.cgi?id=34175 17535 17536 * DumpRenderTree/win/DumpRenderTree.vcproj: 17537 * DumpRenderTree/win/ImageDiff.vcproj: 17538 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 17539 175402010-01-26 Kenneth Rohde Christiansen <kenneth@webkit.org> 17541 17542 Reviewed by Ariya Hidayat. 17543 17544 [Qt] Separating out the UrlLoader from the QtLauncher in it's 17545 own implementation and header file. 17546 17547 * QtLauncher/main.cpp: 17548 (main): 17549 * QtLauncher/urlloader.cpp: Added. 17550 (UrlLoader::UrlLoader): 17551 (UrlLoader::loadNext): 17552 (UrlLoader::init): 17553 (UrlLoader::getUrl): 17554 * QtLauncher/urlloader.h: Added. 17555 175562010-01-25 Chris Jerdonek <cjerdonek@webkit.org> 17557 17558 Reviewed by Shinichiro Hamaji. 17559 17560 Refactored check-webkit-style by removing the file path 17561 parameter from the style error handler functions. 17562 17563 https://bugs.webkit.org/show_bug.cgi?id=34031 17564 17565 * Scripts/webkitpy/style/checker.py: 17566 - Added _default_style_error_handler() to StyleChecker class. 17567 - Moved handle_style_error() to inside _default_style_error_handler(). 17568 17569 * Scripts/webkitpy/style/checker_unittest.py: 17570 - Removed file path from calls to error handler. 17571 17572 * Scripts/webkitpy/style/cpp_style.py: 17573 - Removed file path from calls to error handler. 17574 17575 * Scripts/webkitpy/style/cpp_style_unittest.py: 17576 - Removed file path from calls to error handler. 17577 17578 * Scripts/webkitpy/style/text_style.py: 17579 - Removed file path from calls to error handler. 17580 17581 * Scripts/webkitpy/style/text_style_unittest.py: 17582 - Removed file path from calls to error handler. 17583 175842010-01-25 Jeremy Orlow <jorlow@chromium.org> 17585 17586 Adding myself as reviewer. No review necessary. 17587 17588 * Scripts/webkitpy/committers.py: 17589 175902010-01-25 Chris Jerdonek <cjerdonek@webkit.org> 17591 17592 Reviewed by Adam Barth. 17593 17594 Improved prepare-ChangeLog so that it preserves the relative 17595 indentation of a git commit message. 17596 17597 https://bugs.webkit.org/show_bug.cgi?id=34058 17598 17599 * Scripts/prepare-ChangeLog: 17600 - Also adjusted the script so that it does not add white 17601 space characters to empty lines. 17602 176032010-01-24 Eric Seidel <eric@webkit.org> 17604 17605 No review, rolling out r53763. 17606 http://trac.webkit.org/changeset/53763 17607 https://bugs.webkit.org/show_bug.cgi?id=33895 17608 17609 Broke 20+ tests on Windows. 17610 17611 * Scripts/run-webkit-tests: 17612 * Scripts/webkitdirs.pm: 17613 176142010-01-24 Adam Barth <abarth@webkit.org> 17615 17616 Rubber stamped by Eric Seidel. 17617 17618 More pep8 compliance. 17619 17620 * Scripts/webkitpy/mock_bugzillatool.py: 17621 176222010-01-24 Adam Barth <abarth@webkit.org> 17623 17624 Rubber stamped by Eric Seidel. 17625 17626 More pep8 compliance. 17627 17628 * Scripts/webkitpy/executive.py: 17629 * Scripts/webkitpy/grammar.py: 17630 176312010-01-24 Adam Barth <abarth@webkit.org> 17632 17633 Rubber stamped by Eric Seidel. 17634 17635 More pep8 compliance. 17636 17637 * Scripts/webkitpy/comments.py: 17638 * Scripts/webkitpy/committers.py: 17639 * Scripts/webkitpy/credentials.py: 17640 176412010-01-24 Adam Barth <abarth@webkit.org> 17642 17643 Rubber stamped by Eric Seidel. 17644 17645 Make changelogs.py pass pep8. 17646 17647 * Scripts/webkitpy/changelogs.py: 17648 176492010-01-23 Kenneth Rohde Christiansen <kenneth@webkit.org> 17650 17651 [Qt] Unreviewed build fix 17652 17653 * QtLauncher/QtLauncher.pro: 17654 * QtLauncher/webinspector.h: 17655 176562010-01-23 Kenneth Rohde Christiansen <kenneth@webkit.org> 17657 17658 Rubberstamped by Simon Hausmann. 17659 17660 [Qt] Move the WebInspector class to it's own header file. 17661 17662 * QtLauncher/main.cpp: 17663 * QtLauncher/webinspector.h: Added. 17664 (WebInspector::WebInspector): 17665 (WebInspector::showEvent): 17666 (WebInspector::hideEvent): 17667 176682010-01-23 Robert Hogan <robert@roberthogan.net> 17669 17670 Reviewed by Kenneth Rohde Christiansen. 17671 17672 Qt DRT: respect window.close() and window.closed() 17673 17674 Qt DRT needs to maintain a correct count of open windows 17675 for windowCount(). It also needs to delete windows that 17676 have been closed by window.close(). 17677 17678 This fixes the following tests: 17679 17680 plugins/destroy-during-npp-new.html 17681 fast/dom/Document/early-document-access.html 17682 fast/dom/Window/window-early-properties.html 17683 fast/events/open-window-from-another-frame.html 17684 fast/events/popup-blocking-click-in-iframe.html 17685 17686 https://bugs.webkit.org/show_bug.cgi?id=32953 17687 17688 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 17689 (WebCore::DumpRenderTree::DumpRenderTree): 17690 (WebCore::DumpRenderTree::createWindow): 17691 (WebCore::DumpRenderTree::windowCloseRequested): 17692 * DumpRenderTree/qt/DumpRenderTreeQt.h: 17693 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 17694 (LayoutTestController::maybeDump): 17695 176962010-01-23 Dan Bernstein <mitz@apple.com> 17697 17698 Reviewed by Mark Rowe. 17699 17700 Added a user default for specifying a fallback frameworks path in case 17701 the bundle does not contain frameworks for the current Mac OS X version. 17702 17703 * WebKitLauncher/main.m: 17704 (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary 17705 keyed by the FallbackSystemVersions user default and returns it. 17706 (main): If a frameworks directory for the current system version is not found, 17707 try the fallback. 17708 177092010-01-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 17710 17711 Reviewed by Simon Hausmann. 17712 17713 Make run-webkit-tests work under Cygwin for the Qt port 17714 17715 setPathForRunningWebKitApp() is implemented for the Qt port 17716 by using qmake to query for the location of the Qt libraries. 17717 17718 This requires the original environment (%ENV) to be untouched, 17719 so launchWithCurrentEnv() was refactored to launchWithEnv(), 17720 and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV 17721 instead. This has the added benefit of getting rid of the temp 17722 variables used for storing the current env. 17723 17724 openDumpTool() is also refactored a bit into platform-spesific, 17725 port-spesific, and generic environment variables. 17726 17727 Checks for undef was added a few places to fix Perl concat 17728 warnings when run-webkit-tests is aborted. 17729 17730 https://bugs.webkit.org/show_bug.cgi?id=33895 17731 17732 * Scripts/run-webkit-tests: 17733 * Scripts/webkitdirs.pm: 17734 177352010-01-22 Kevin Watters <kevinwatters@gmail.com> 17736 17737 Reviewed by Kevin Ollivier. 17738 17739 [wx] Remove the Bakefile build system, which is no longer being used. 17740 17741 https://bugs.webkit.org/show_bug.cgi?id=34022 17742 17743 * DumpRenderTree/wx/DumpRenderTree.bkl: Removed. 17744 * wx/browser/browser.bkl: Removed. 17745 * wx/build-wxwebkit: Removed. 17746 177472010-01-22 Gustavo Noronha Silva <gns@gnome.org> 17748 17749 Reviewed by Simon Fraser. 17750 17751 Reset zoom level to 1.0 when resetting view state. This is causing 17752 many tests to fail after svg/custom/text-zoom.xhtml changes the 17753 zoom level. 17754 17755 * DumpRenderTree/gtk/DumpRenderTree.cpp: 17756 (resetDefaultsToConsistentValues): 17757 177582010-01-22 Steve Falkenburg <sfalken@apple.com> 17759 17760 Reviewed by Darin Adler. 17761 17762 https://bugs.webkit.org/show_bug.cgi?id=34025 17763 Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets. 17764 17765 * Scripts/build-webkit: 17766 177672010-01-22 Adam Barth <abarth@webkit.org> 17768 17769 Unreviewed. Arg. Someone renamed limit to output_limit on me. 17770 17771 * Scripts/webkitpy/commands/queues.py: 17772 177732010-01-22 Adam Barth <abarth@webkit.org> 17774 17775 Rubber stamped by Eric Seidel. 17776 17777 Make __init__.py and buildbot.py pass pep8 style checker. 17778 17779 * Scripts/webkitpy/__init__.py: 17780 * Scripts/webkitpy/buildbot.py: 17781 177822010-01-21 Joe Mason <jmason@rim.com> 17783 17784 Reviewed by Adam Barth. 17785 17786 webkit-patch should retry on invalid password 17787 https://bugs.webkit.org/show_bug.cgi?id=33955 17788 17789 Ask for bugs.webkit.org authentication in a loop. 17790 17791 * Scripts/webkitpy/bugzilla.py: 17792 177932010-01-22 Adam Barth <abarth@webkit.org> 17794 17795 Unreviewed. Don't call seek on a NoneType. 17796 17797 * Scripts/webkitpy/statusserver.py: 17798 177992010-01-22 Petri Latvala <petri.latvala@nomovok.com> 17800 17801 Reviewed by David Levin. 17802 17803 check-webkit-style breaks on files with unknown types 17804 https://bugs.webkit.org/show_bug.cgi?id=34001 17805 17806 For files with type FileType.NONE, dispatch_processor returns None. 17807 17808 * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None. 17809 178102010-01-22 Adam Barth <abarth@webkit.org> 17811 17812 Reviewed by Eric Seidel. 17813 17814 Make bugzilla.py and webkitport.py conform to pep8 17815 https://bugs.webkit.org/show_bug.cgi?id=34015 17816 17817 This patch makes webkitport.py and bugzilla.py mostly conform to PEP8 17818 style as enforced by pep8.py. I wasn't able to get rid of all the 17819 errors because I'm not sure how to wrap some lines properly. Also, 17820 there are a few deprication errors that I couldn't resolve easily. 17821 However, this is a massive improvement in compliance. 17822 17823 * Scripts/webkitpy/bugzilla.py: 17824 * Scripts/webkitpy/webkitport.py: 17825 178262010-01-22 Adam Barth <abarth@webkit.org> 17827 17828 Reviewed by Darin Adler. 17829 17830 Limit length of EWS results to 5MB 17831 https://bugs.webkit.org/show_bug.cgi?id=34016 17832 17833 Hopefully this will fix the bug where the results link doesn't appear. 17834 Our current theory is that the results blob is too big and the server 17835 is rejecting the request with a 500 error. That causes us to re-try 17836 the post, but when we re-try the StringIO buffer has its seek pointer 17837 at the end. 17838 17839 * Scripts/webkitpy/commands/queues.py: 17840 * Scripts/webkitpy/statusserver.py: 17841 178422010-01-22 Chris Jerdonek <cjerdonek@webkit.org> 17843 17844 Reviewed by Adam Barth. 17845 17846 Made check-webkit-style able to check patches when script not 17847 run from source root. Also consolidated external references 17848 to a single file. 17849 17850 https://bugs.webkit.org/show_bug.cgi?id=33791 17851 17852 * Scripts/check-webkit-style: 17853 - Changed to import style_references.py. 17854 17855 * Scripts/webkitpy/style/__init__.py: 17856 - Removed __path__ hack that allowed searching Scripts/ directory. 17857 17858 * Scripts/webkitpy/style/checker.py: 17859 - Changed to import style_references.py. 17860 17861 * Scripts/webkitpy/style_references.py: Added. 17862 178632010-01-22 Dmitry Titov <dimich@chromium.org> 17864 17865 Reviewed by Maciej Stachowiak. 17866 17867 Fix the leak of ThreadIdentifiers in threadMap across threads. 17868 https://bugs.webkit.org/show_bug.cgi?id=32689 17869 17870 Add a new test to verify the ThreadIdentifiers are not reused across threads. 17871 The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially, 17872 waiting for the previous thread to terminate before starting the next. 17873 The treads use WTF::currentThread() in their thread function. Without a fix, this 17874 causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function. 17875 It also starts another thread using WTF. Without the fix, this finds pthread handle from previous 17876 threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle(). 17877 The test practically does not affect the DRT run time because the threads end immediately. 17878 17879 * DumpRenderTree/mac/DumpRenderTree.mm: 17880 (runThread): Test thread function. 17881 (testThreadIdentifierMap): 17882 (dumpRenderTree): 17883 178842010-01-22 Kent Tamura <tkent@chromium.org> 17885 17886 Reviewed by Maciej Stachowiak. 17887 17888 Fix a bug that mouseDown:withModifiers: is never called. 17889 https://bugs.webkit.org/show_bug.cgi?id=33989 17890 17891 * DumpRenderTree/mac/EventSendingController.mm: 17892 (+[EventSendingController isSelectorExcludedFromWebScript:]): 17893 (+[EventSendingController webScriptNameForSelector:]): 17894 178952010-01-22 Kenneth Rohde Christiansen <kenneth@webkit.org> 17896 17897 Rubberstamped by Antti Koivisto. 17898 17899 [Qt] Separate out the WebPage class into it's own 17900 cpp/header files. Also, removed the assumption that 17901 the view is a QWebView, in preparation of a merger 17902 of the two Qt WebKit launchers. 17903 17904 * QtLauncher/QtLauncher.pro: 17905 * QtLauncher/main.cpp: 17906 (WebView::mousePressEvent): 17907 * QtLauncher/webpage.cpp: Added. 17908 (WebPage::supportsExtension): 17909 (WebPage::extension): 17910 (WebPage::acceptNavigationRequest): 17911 (WebPage::openUrlInDefaultBrowser): 17912 * QtLauncher/webpage.h: Added. 17913 (WebPage::WebPage): 17914 179152010-01-21 Chris Jerdonek <cjerdonek@webkit.org> 17916 17917 Reviewed by Shinichiro Hamaji. 17918 17919 Refactored to move file name and file-reading related code 17920 from cpp_style.py and text_style.py to checker.py. 17921 17922 https://bugs.webkit.org/show_bug.cgi?id=33775 17923 17924 * Scripts/check-webkit-style: 17925 - Updates caused by changes to checker.py. 17926 17927 * Scripts/webkitpy/style/checker.py: 17928 - Added SKIPPED_FILES_WITH_WARNING list. 17929 - Added SKIPPED_FILES_WITHOUT_WARNING list. 17930 - Added FileType class. 17931 - Added ProcessorDispatcher class. 17932 - In StyleChecker class: 17933 - Renamed process_patch() to check_patch(). 17934 - Renamed process_file() to check_file(). 17935 - Added _process_file(). 17936 - Related refactoring. 17937 - Addressed check_patch() FIXME to share code with process_file(). 17938 17939 * Scripts/webkitpy/style/checker_unittest.py: 17940 - Added ProcessorDispatcherSkipTest class. 17941 - Added ProcessorDispatcherDispatchTest class. 17942 - Added StyleCheckerCheckFileTest class. 17943 17944 * Scripts/webkitpy/style/cpp_style.py: 17945 - Renamed process_file_data() to _process_lines. 17946 - Removed process_file() (moved logic to checker.py). 17947 - Removed can_handle() (moved logic to checker.py). 17948 - Added CppProcessor class. 17949 - Removed is_exempt() (moved logic to checker.py). 17950 - Added process_file_data() back as a wrapper function. 17951 17952 * Scripts/webkitpy/style/cpp_style_unittest.py: 17953 - Removed test_can_handle(). 17954 - Removed test_is_exempt(). 17955 - Added CppProcessorTest class. 17956 17957 * Scripts/webkitpy/style/text_style.py: 17958 - Added TextProcessor class. 17959 - Removed process_file(). 17960 - Removed can_handle(). 17961 17962 * Scripts/webkitpy/style/text_style_unittest.py: 17963 - Removed test_can_handle(). 17964 - Added TextProcessorTest class. 17965 179662010-01-21 Chris Jerdonek <cjerdonek@webkit.org> 17967 17968 Reviewed by David Kilzer. 17969 17970 Create a unit-tested subroutine to parse patch files created 17971 by svn-create-patch. 17972 17973 https://bugs.webkit.org/show_bug.cgi?id=33475 17974 17975 * Scripts/VCSUtils.pm: 17976 - Added parseDiff(). 17977 - Added parsePatch(). 17978 17979 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added. 17980 - Added unit tests for parseDiff(). 17981 17982 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: 17983 - Total number of tests now computed dynamically. 17984 17985 * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added. 17986 - Added unit tests for parsePatch(). 17987 179882010-01-21 Kevin Ollivier <kevino@theolliviers.com> 17989 17990 [wx] Build fix, add new directory to dir list. 17991 17992 * wx/build/settings.py: 17993 179942010-01-21 Adam Barth <abarth@webkit.org> 17995 17996 Reviewed by Eric Seidel. 17997 17998 Make the EWS transactional 17999 https://bugs.webkit.org/show_bug.cgi?id=33978 18000 18001 Now if the EWS gets interrupted in the middle of processing a patch, 18002 the bots will re-process the patch. 18003 18004 * Scripts/test-webkitpy: 18005 * Scripts/webkitpy/commands/queues.py: 18006 * Scripts/webkitpy/commands/queues_unittest.py: 18007 * Scripts/webkitpy/patchcollection.py: 18008 * Scripts/webkitpy/patchcollection_unittest.py: Added. 18009 180102010-01-21 Adam Barth <abarth@webkit.org> 18011 18012 Unreviewed. Add missing "ago" for style in the status bubble. 18013 18014 * QueueStatusServer/templates/statusbubble.html: 18015 180162010-01-21 Adam Barth <abarth@webkit.org> 18017 18018 Reviewed by David Levin. 18019 18020 [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/ 18021 https://bugs.webkit.org/show_bug.cgi?id=33356 18022 18023 White list unix_hacker_style names in WebKit/gtk/webkit because these 18024 are used in the GTK+ API. 18025 18026 * Scripts/webkitpy/style/cpp_style.py: 18027 * Scripts/webkitpy/style/cpp_style_unittest.py: 18028 180292010-01-21 Diego Gonzalez <diego.gonzalez@openbossa.org> 18030 18031 Reviewed by Kenneth Rohde Christiansen. 18032 18033 [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT 18034 https://bugs.webkit.org/show_bug.cgi?id=33945 18035 18036 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 18037 (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): 18038 * DumpRenderTree/qt/LayoutTestControllerQt.h: 18039 180402010-01-21 Simon Hausmann <simon.hausmann@nokia.com> 18041 18042 No review, rolling out 53615 as it causes two 18043 crashes on the bot. 18044 18045 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 18046 (WebCore::DumpRenderTree::DumpRenderTree): 18047 (WebCore::DumpRenderTree::createWindow): 18048 * DumpRenderTree/qt/DumpRenderTreeQt.h: 18049 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 18050 (LayoutTestController::maybeDump): 18051 180522010-01-21 Robert Hogan <robert@roberthogan.net> 18053 18054 Reviewed by Simon Hausmann. 18055 18056 Qt DRT: respect window.close() and window.closed() 18057 18058 Qt DRT needs to maintain a correct count of open windows 18059 for windowCount(). It also needs to delete windows that 18060 have been closed by window.close(). 18061 18062 This fixes the following tests: 18063 18064 plugins/destroy-during-npp-new.html 18065 fast/dom/Document/early-document-access.html 18066 fast/dom/Window/window-early-properties.html 18067 fast/events/open-window-from-another-frame.html 18068 fast/events/popup-blocking-click-in-iframe.html 18069 18070 https://bugs.webkit.org/show_bug.cgi?id=32953 18071 18072 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 18073 (WebCore::DumpRenderTree::DumpRenderTree): 18074 (WebCore::DumpRenderTree::createWindow): 18075 (WebCore::DumpRenderTree::windowCloseRequested): 18076 * DumpRenderTree/qt/DumpRenderTreeQt.h: 18077 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 18078 (LayoutTestController::maybeDump): 18079 180802010-01-20 Eric Seidel <eric@webkit.org> 18081 18082 No review, rolling out r53593. 18083 http://trac.webkit.org/changeset/53593 18084 https://bugs.webkit.org/show_bug.cgi?id=33496 18085 18086 Re-rollout this patch, the commit-queue should not have landed 18087 it again, but it did due to land-diff and rollout both not 18088 clearing flags. 18089 18090 * Scripts/webkitpy/commands/early_warning_system.py: 18091 * Scripts/webkitpy/commands/queues.py: 18092 * Scripts/webkitpy/queueengine.py: 18093 * Scripts/webkitpy/scm.py: 18094 * Scripts/webkitpy/scm_unittest.py: 18095 180962010-01-20 Eric Seidel <eric@webkit.org> 18097 18098 Reviewed by Adam Barth. 18099 18100 webkit-commit-queue status page is confusing 18101 https://bugs.webkit.org/show_bug.cgi?id=33496 18102 18103 This should improve the status page by removing more Fail messages. 18104 To do this, I re-factored the CommitQueue and the AbstractReviewQueues 18105 to behave more like one another. This meant moving where the failure reporting was done. 18106 Previously the AbstractReviewQueue always used the parent process to report the error, 18107 while CommitQueue used the subprocess when possible, and the parent only reported errors 18108 that we didn't know how to handle (bugs in the commit-queue itself). 18109 Now the AbstractReviewQueue follow's the commit-queue's model. This got rid of a try-block 18110 in both implementations and required teaching handle_script_error in each to post Fail messages 18111 to the status server instead of calling exit(1). 18112 18113 This will also make the style-queue share more bug posting logic with other queues: 18114 https://bugs.webkit.org/show_bug.cgi?id=33871 18115 18116 * Scripts/webkitpy/commands/early_warning_system.py: 18117 - Don't exit(1) as that will cause the calling queue to also report Fail to the status server. 18118 Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled. 18119 So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure. 18120 _update_status_for_script_error knows how to post the Fail message to the status server. 18121 - Teach _update_status_for_script_error how to post Fail messages to the status server. 18122 * Scripts/webkitpy/commands/queues.py: 18123 - Remove the try block from process_work_item since the caller already has one. 18124 - Only CC watchers on failure to cut down on commit-queue generated mail. 18125 - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item. 18126 - Abstract _format_script_error_output_for_bug to share code between all queues. 18127 - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output. 18128 - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing. 18129 - Move logging out of _can_build_and_test and make the logs explain what revision we're testing. 18130 - handle_script_error now posts Fail instead of the try block in process_work_item handling it. 18131 * Scripts/webkitpy/queueengine.py: 18132 - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing. 18133 * Scripts/webkitpy/scm.py: 18134 - Add new checkout_revision function. 18135 * Scripts/webkitpy/scm_unittest.py: 18136 - Test our new checkout_revision function. 18137 181382010-01-20 Fumitoshi Ukai <ukai@chromium.org> 18139 18140 Reviewed by Alexey Proskuryakov. 18141 18142 WebSocket: Missing Request-URI, when no tralling slash in host 18143 https://bugs.webkit.org/show_bug.cgi?id=33689 18144 18145 Update pywebsocket to 0.4.7.1, which supports alias for resource 18146 name, so that we could test for ws://127.0.0.1:8880 18147 18148 * Scripts/run-webkit-tests: 18149 * Scripts/run-webkit-websocketserver: 18150 * pywebsocket/mod_pywebsocket/dispatch.py: 18151 * pywebsocket/mod_pywebsocket/handshake.py: 18152 * pywebsocket/mod_pywebsocket/standalone.py: 18153 * pywebsocket/setup.py: 18154 * pywebsocket/test/test_dispatch.py: 18155 * pywebsocket/test/test_handshake.py: 18156 181572010-01-20 Eric Seidel <eric@webkit.org> 18158 18159 No review, rolling out r53537. 18160 http://trac.webkit.org/changeset/53537 18161 https://bugs.webkit.org/show_bug.cgi?id=33496 18162 18163 Added a failure condition to the commit-queue and looks to 18164 have broken the EWS bots 18165 18166 * Scripts/webkitpy/commands/early_warning_system.py: 18167 * Scripts/webkitpy/commands/queues.py: 18168 * Scripts/webkitpy/queueengine.py: 18169 * Scripts/webkitpy/scm.py: 18170 * Scripts/webkitpy/scm_unittest.py: 18171 181722010-01-20 Jon Honeycutt <jhoneycutt@apple.com> 18173 18174 MSAA: accSelect() is not implemented 18175 18176 https://bugs.webkit.org/show_bug.cgi?id=33918 18177 <rdar://problem/7436861> 18178 18179 Reviewed by Darin Adler. 18180 18181 * DumpRenderTree/AccessibilityUIElement.cpp: 18182 (takeFocusCallback): 18183 Call the object's takeFocus() function. 18184 (takeSelectionCallback): 18185 Call its takeSelection() function. 18186 (addSelectionCallback): 18187 Call its addSelection() function. 18188 (removeSelectionCallback): 18189 Call its removeSelection() function. 18190 (AccessibilityUIElement::getJSClass): 18191 Add new functions to the JS class definition. 18192 18193 * DumpRenderTree/AccessibilityUIElement.h: 18194 Declare new functions. 18195 18196 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 18197 (AccessibilityUIElement::takeFocus): 18198 Stubbed. 18199 (AccessibilityUIElement::takeSelection): 18200 Stubbed. 18201 (AccessibilityUIElement::addSelection): 18202 Stubbed. 18203 (AccessibilityUIElement::removeSelection): 18204 Stubbed. 18205 18206 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 18207 (AccessibilityUIElement::takeFocus): 18208 Stubbed. 18209 (AccessibilityUIElement::takeSelection): 18210 Stubbed. 18211 (AccessibilityUIElement::addSelection): 18212 Stubbed. 18213 (AccessibilityUIElement::removeSelection): 18214 Stubbed. 18215 18216 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 18217 (AccessibilityUIElement::takeFocus): 18218 Call the object's accSelect() function, passing the appropriate flag. 18219 (AccessibilityUIElement::takeSelection): 18220 Ditto. 18221 (AccessibilityUIElement::addSelection): 18222 Ditto. 18223 (AccessibilityUIElement::removeSelection): 18224 Ditto. 18225 182262010-01-20 Andras Becsi <abecsi@inf.u-szeged.hu> 18227 18228 Reviewed by Alexey Proskuryakov. 18229 18230 Extract Apache handling to httpd.pm module and use the provided functionality 18231 in scripts where Apache is needed. 18232 The module httpd.pm stores the PID of Apache in a variable and cleans up 18233 the PID directory after Apache properly shut down. Catching INT and TERM 18234 signals allows the scripts to close Apache and clean up its PID directory 18235 even if the testing was interrupted. 18236 18237 https://bugs.webkit.org/show_bug.cgi?id=33153 18238 18239 * Scripts/webkitperl/httpd.pm: Added. 18240 * Scripts/run-iexploder-tests: 18241 * Scripts/run-webkit-httpd: 18242 * Scripts/run-webkit-tests: 18243 182442010-01-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 18245 18246 Reviewed by Simon Hausmann. 18247 18248 [Qt] Make DumpRenderTree build on Windows 18249 18250 * DumpRenderTree/qt/DumpRenderTree.pro: 18251 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 18252 * DumpRenderTree/qt/DumpRenderTreeQt.h: 18253 * DumpRenderTree/qt/main.cpp: 18254 182552010-01-20 Steve Block <steveblock@google.com> 18256 18257 Reviewed by Eric Seidel. 18258 18259 Fix commit bot to land patches in order of the bug last modification date. 18260 https://bugs.webkit.org/show_bug.cgi?id=33395 18261 18262 * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL. 18263 182642010-01-20 Adam Barth <abarth@webkit.org> 18265 18266 Reviewed by Eric Seidel. 18267 18268 Teach check-webkit-style about WebKit/gtk/tests 18269 https://bugs.webkit.org/show_bug.cgi?id=33892 18270 18271 Removes false positives found in 18272 https://bugs.webkit.org/show_bug.cgi?id=30883 18273 18274 * Scripts/webkitpy/style/cpp_style.py: 18275 * Scripts/webkitpy/style/cpp_style_unittest.py: 18276 182772010-01-20 Adam Barth <abarth@webkit.org> 18278 18279 Reviewed by Eric Seidel. 18280 18281 Teach check-webkit-style about QGVLauncher 18282 https://bugs.webkit.org/show_bug.cgi?id=33890 18283 18284 Remove false positives found in 18285 https://bugs.webkit.org/show_bug.cgi?id=33708 18286 18287 * Scripts/webkitpy/style/cpp_style.py: 18288 * Scripts/webkitpy/style/cpp_style_unittest.py: 18289 182902010-01-20 Eric Seidel <eric@webkit.org> 18291 18292 Reviewed by Adam Barth. 18293 18294 webkit-commit-queue status page is confusing 18295 https://bugs.webkit.org/show_bug.cgi?id=33496 18296 18297 This should improve the status page by removing more Fail messages. 18298 To do this, I re-factored the CommitQueue and the AbstractReviewQueues 18299 to behave more like one another. This meant moving where the failure reporting was done. 18300 Previously the AbstractReviewQueue always used the parent process to report the error, 18301 while CommitQueue used the subprocess when possible, and the parent only reported errors 18302 that we didn't know how to handle (bugs in the commit-queue itself). 18303 Now the AbstractReviewQueue follow's the commit-queue's model. This got rid of a try-block 18304 in both implementations and required teaching handle_script_error in each to post Fail messages 18305 to the status server instead of calling exit(1). 18306 18307 This will also make the style-queue share more bug posting logic with other queues: 18308 https://bugs.webkit.org/show_bug.cgi?id=33871 18309 18310 * Scripts/webkitpy/commands/early_warning_system.py: 18311 - Don't exit(1) as that will cause the calling queue to also report Fail to the status server. 18312 Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled. 18313 So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure. 18314 _update_status_for_script_error knows how to post the Fail message to the status server. 18315 - Teach _update_status_for_script_error how to post Fail messages to the status server. 18316 * Scripts/webkitpy/commands/queues.py: 18317 - Remove the try block from process_work_item since the caller already has one. 18318 - Only CC watchers on failure to cut down on commit-queue generated mail. 18319 - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item. 18320 - Abstract _format_script_error_output_for_bug to share code between all queues. 18321 - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output. 18322 - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing. 18323 - Move logging out of _can_build_and_test and make the logs explain what revision we're testing. 18324 - handle_script_error now posts Fail instead of the try block in process_work_item handling it. 18325 * Scripts/webkitpy/queueengine.py: 18326 - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing. 18327 * Scripts/webkitpy/scm.py: 18328 - Add new checkout_revision function. 18329 * Scripts/webkitpy/scm_unittest.py: 18330 - Test our new checkout_revision function. 18331 183322010-01-20 Adam Barth <abarth@webkit.org> 18333 18334 Reviewed by Darin Adler. 18335 18336 Exempt JavaScriptCore/qt/api from style checks 18337 https://bugs.webkit.org/show_bug.cgi?id=33879 18338 18339 Apparently there is a JavaScriptCore API for Qt as well as a WebKit 18340 API. 18341 18342 * Scripts/webkitpy/style/cpp_style.py: 18343 * Scripts/webkitpy/style/cpp_style_unittest.py: 18344 183452010-01-19 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 18346 18347 Reviewed by Simon Hausmann. 18348 18349 [Qt] Don't use QSocketNotifier in the DRT for reading stdin 18350 18351 QSocketNotifier is not available on Windows. Instead we read 18352 stdin synchronously after each test using signals and slots. 18353 18354 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 18355 * DumpRenderTree/qt/DumpRenderTreeQt.h: 18356 * DumpRenderTree/qt/main.cpp: 18357 183582010-01-19 Adam Barth <abarth@webkit.org> 18359 18360 Rubber stamped by Eric Seidel. 18361 18362 Move chromium-ews back to building release only to make the EWS faster. 18363 18364 * Scripts/webkitpy/commands/early_warning_system.py: 18365 183662010-01-17 Jon Honeycutt <jhoneycutt@apple.com> 18367 18368 MSAA: The child <option> elements of a non-multiple <select> are not 18369 exposed 18370 18371 https://bugs.webkit.org/show_bug.cgi?id=33773 18372 <rdar://problem/7550556> 18373 18374 Reviewed by Alice Liu. 18375 18376 * DumpRenderTree/AccessibilityUIElement.cpp: 18377 (getIsVisibleCallback): 18378 Call the object's isVisible() function. 18379 (getIsOffScreenCallback): 18380 Ditto, for isOffScreen(). 18381 (getIsCollapsedCallback): 18382 Ditto, for isCollapsed(). 18383 (getHasPopupCallback): 18384 Ditto, for hasPopup(). 18385 (AccessibilityUIElement::getJSClass): 18386 Add isVisible and isOffScreen attributes. 18387 18388 * DumpRenderTree/AccessibilityUIElement.h: 18389 Declare new functions. 18390 18391 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 18392 (AccessibilityUIElement::isVisible): 18393 Stubbed. 18394 (AccessibilityUIElement::isOffScreen): 18395 Stubbed. 18396 (AccessibilityUIElement::isCollapsed): 18397 Stubbed. 18398 (AccessibilityUIElement::hasPopup): 18399 Stubbed. 18400 18401 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 18402 (AccessibilityUIElement::isVisible): 18403 Stubbed. 18404 (AccessibilityUIElement::isOffScreen): 18405 Stubbed. 18406 (AccessibilityUIElement::isCollapsed): 18407 Stubbed. 18408 (AccessibilityUIElement::hasPopup): 18409 Stubbed. 18410 18411 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 18412 (AccessibilityUIElement::showMenu): 18413 Call the object's accDoDefaultAction() to show its popup menu. 18414 (AccessibilityUIElement::isEnabled): 18415 Check that the object does not have the "unavailable" state. 18416 (AccessibilityUIElement::isVisible): 18417 Check that the object does not have the "invisible" state. 18418 (AccessibilityUIElement::isOffScreen): 18419 Check whether the object has the "offscreen" state. 18420 (AccessibilityUIElement::isCollapsed): 18421 Check whether the object has the "collapsed" state. 18422 (AccessibilityUIElement::hasPopup): 18423 Check whether the object has the "has popup" state. 18424 184252010-01-19 Victor Wang <victorw@chromium.org> 18426 18427 Reviewed by Eric Seidel. 18428 18429 Correct committer name. 18430 https://bugs.webkit.org/show_bug.cgi?id=33868 18431 18432 * Scripts/webkitpy/committers.py: 18433 184342010-01-19 Kent Tamura <tkent@chromium.org> 18435 18436 Reviewed by Darin Adler. 18437 18438 [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp() 18439 https://bugs.webkit.org/show_bug.cgi?id=33783 18440 18441 Some listbox tests check selection behavior by click events with 18442 "meta" or "shift" keys. Behaviors for such modifier keys are 18443 platform-dependent. The new parameter of mouseDown() and mouseUp() 18444 allows to specify not only concrete modifier keys such as 18445 "shiftKey" "metaKey", but also functional names like 18446 "addSelectionKey" "rangeSelectionKey". 18447 18448 * DumpRenderTree/mac/EventSendingController.mm: 18449 (+[EventSendingController isSelectorExcludedFromWebScript:]): 18450 (+[EventSendingController webScriptNameForSelector:]): 18451 (buildModifierFlags): 18452 (-[EventSendingController mouseDown:withModifiers:]): 18453 (-[EventSendingController mouseDown:]): 18454 (-[EventSendingController mouseUp:withModifiers:]): 18455 (-[EventSendingController mouseUp:]): 18456 (-[EventSendingController keyDown:withModifiers:withLocation:]): 18457 184582010-01-19 Adam Barth <abarth@webkit.org> 18459 18460 Reviewed by Eric Seidel. 18461 18462 Unbreak --request-commit 18463 https://bugs.webkit.org/show_bug.cgi?id=33832 18464 18465 * Scripts/webkitpy/bugzilla.py: 18466 184672010-01-19 Eric Seidel <eric@webkit.org> 18468 18469 Reviewed by Adam Barth. 18470 18471 validate-committer-lists throws exception and committers.py needs a refresh 18472 https://bugs.webkit.org/show_bug.cgi?id=33831 18473 18474 * Scripts/validate-committer-lists: use webkit_logging 18475 * Scripts/webkitpy/committers.py: Add recently minted committers. Fix Simon Hausmanns email address list to include his webkit-committers@lists address. 18476 184772010-01-18 Adam Roben <aroben@apple.com> 18478 18479 Add LayoutTestController support for calling new WebKit SPI to 18480 disallow setting document.domain 18481 18482 DRT part of fixing <http://webkit.org/b/33806> 18483 <rdar://problem/7552837> Would like API to disallow setting of 18484 document.domain for pages with certain URL schemes 18485 18486 Reviewed by Sam Weinig. 18487 18488 * DumpRenderTree/LayoutTestController.cpp: 18489 (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls 18490 through to LayoutTestController. 18491 (LayoutTestController::staticFunctions): Added 18492 setDomainRelaxationForbiddenForURLScheme. 18493 18494 * DumpRenderTree/LayoutTestController.h: Added 18495 setDomainRelaxationForbiddenForURLScheme. 18496 18497 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 18498 (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): 18499 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 18500 (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): 18501 Added. Calls through to WebKit. 18502 18503 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 18504 (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): 18505 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 18506 (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): 18507 Stubbed out. 18508 185092010-01-18 Adam Barth <abarth@webkit.org> 18510 18511 Reviewed by Adam Roben. 18512 18513 Rename patches-to-commit to patches-in-commit-queue 18514 https://bugs.webkit.org/show_bug.cgi?id=33789 18515 18516 The command really lists the patches in the commit-queue not all the 18517 patches that are pending-commit (as the FIXME commands). 18518 18519 * Scripts/webkitpy/commands/queries.py: 18520 * Scripts/webkitpy/commands/queries_unittest.py: 18521 185222010-01-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 18523 18524 Reviewed by Simon Hausmann. 18525 18526 [Qt] Force qmake to generate a single makefile for DerivedSources.pro 18527 18528 * Scripts/webkitdirs.pm: 18529 185302010-01-18 Adam Roben <aroben@apple.com> 18531 18532 Clean up use of /useenv when invoking Visual C++ 18533 18534 This change reverts things to their pre-r49485 state. That revision 18535 (and, subsequently, r49664 and r51788) started passing /useenv to 18536 Visual C++, even in cases where we don't want to do so (such as when 18537 invoking Visual C++ Express), in the name of making the Chromium build 18538 work. Now that Chromium isn't using buildVisualStudioProject or 18539 pdevenv, we can put things back they way they were. 18540 18541 Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express 18542 (due to /useenv flag) 18543 18544 Reviewed by Sam Weinig. 18545 18546 * Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this 18547 script anymore. 18548 * Scripts/webkitdirs.pm: 18549 (buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes 18550 care of this itself, and we don't want to pass /useenv when not using 18551 pdevenv (e.g., when using VC++ Express, because that will cause it to 18552 ignore the Platform SDK). 18553 185542010-01-18 Adam Barth <abarth@webkit.org> 18555 18556 Reviewed by Eric Seidel. 18557 18558 webkit-patch land-safely should obsolete old patches 18559 https://bugs.webkit.org/show_bug.cgi?id=33788 18560 18561 When posting a commit-queue+ patch with land-safely, we should 18562 obsolete the old patches on the bug. They're really confusing 18563 because the main use case is to address reviewer feedback on a 18564 previous patch. 18565 18566 * Scripts/webkitpy/commands/upload.py: 18567 * Scripts/webkitpy/commands/upload_unittest.py: 18568 185692010-01-18 Adam Barth <abarth@webkit.org> 18570 18571 Reviewed by David Levin. 18572 18573 webkit-patch should authenticate more often 18574 https://bugs.webkit.org/show_bug.cgi?id=33701 18575 18576 This makes it easier to work with security patches. 18577 18578 * Scripts/webkitpy/bugzilla.py: 18579 185802010-01-18 Adam Barth <abarth@webkit.org> 18581 18582 Reviewed by Darin Adler. 18583 18584 style checker needs to know about GObject-specific requirements 18585 inside WebCore/bindings/gobject/ 18586 https://bugs.webkit.org/show_bug.cgi?id=33606 18587 18588 Add an exception to the underscore rule for certain 18589 GObject-specific names. 18590 18591 * Scripts/webkitpy/style/cpp_style.py: 18592 * Scripts/webkitpy/style/cpp_style_unittest.py: 18593 185942010-01-18 Adam Barth <abarth@webkit.org> 18595 18596 Reviewed by Shinichiro Hamaji. 18597 18598 [check-webkit-style] does understand ResourceHandleWin.h 18599 https://bugs.webkit.org/show_bug.cgi?id=32975 18600 18601 I'm not 100% convinced this fix is correct, but without more examples, 18602 it's hard to generalize. We can always generalize the fix in the 18603 future. 18604 18605 * Scripts/webkitpy/style/cpp_style.py: 18606 * Scripts/webkitpy/style/cpp_style_unittest.py: 18607 186082010-01-18 Adam Barth <abarth@webkit.org> 18609 18610 Unreviewed "build" fix. 18611 18612 * Scripts/webkitpy/bugzilla.py: 18613 186142010-01-18 Adam Barth <abarth@webkit.org> 18615 18616 Unreviewed. Actually make land-safely mark commit-queue+ as 18617 discussed with Eric. 18618 18619 * Scripts/webkitpy/bugzilla.py: 18620 * Scripts/webkitpy/steps/postdiffforcommit.py: 18621 186222010-01-17 Adam Barth <abarth@webkit.org> 18623 18624 Reviewed by Darin Adler. 18625 18626 style-queue complains about one-line macros that include multiple statements 18627 https://bugs.webkit.org/show_bug.cgi?id=33173 18628 18629 Add an exception for multiple statements on a line that starts a macro. 18630 18631 * Scripts/webkitpy/style/cpp_style.py: 18632 * Scripts/webkitpy/style/cpp_style_unittest.py: 18633 186342010-01-17 Adam Barth <abarth@webkit.org> 18635 18636 Reviewed by Darin Adler. 18637 18638 [check-webkit-style] qt unit testing false positives 18639 https://bugs.webkit.org/show_bug.cgi?id=32833 18640 18641 Exempt the Qt API and unit tests from the style checker. 18642 18643 * Scripts/webkitpy/style/cpp_style.py: 18644 * Scripts/webkitpy/style/cpp_style_unittest.py: 18645 186462010-01-17 Adam Barth <abarth@webkit.org> 18647 18648 Reviewed by Darin Adler. 18649 18650 style-check script reports loads of errors on gtk2drawing.c 18651 https://bugs.webkit.org/show_bug.cgi?id=33771 18652 18653 Exempt WebCore/platform/gtk/gtk2drawing.c and 18654 WebCore/platform/gtk/gtk2drawing.h from style checks. 18655 18656 * Scripts/webkitpy/style/cpp_style.py: 18657 * Scripts/webkitpy/style/cpp_style_unittest.py: 18658 186592010-01-17 Chris Jerdonek <cjerdonek@webkit.org> 18660 18661 Reviewed by Shinichiro Hamaji. 18662 18663 Finished eliminating _cpp_style_state global state variable from 18664 check-webkit-style code and eliminating _CppStyleState class. 18665 18666 https://bugs.webkit.org/show_bug.cgi?id=33764 18667 18668 * Scripts/webkitpy/style/checker.py: 18669 - Minor updates caused by changes to cpp_style.py. 18670 18671 * Scripts/webkitpy/style/cpp_style.py: 18672 - Removed _CppStyleState class. 18673 - Removed verbose_level functions. 18674 - Added verbosity as a parameter to _FunctionState constructor. 18675 - Added verbosity as a parameter to process_file(). 18676 - Added verbosity as a parameter to process_file_data(). 18677 18678 * Scripts/webkitpy/style/cpp_style_unittest.py: 18679 - Added helper functions to set verbosity while running tests. 18680 186812010-01-17 Adam Barth <abarth@webkit.org> 18682 18683 Reviewed by Shinichiro Hamaji. 18684 18685 check-webkit-style underscore check should be disabled for Qt methods starting with qt_ 18686 https://bugs.webkit.org/show_bug.cgi?id=33663 18687 18688 * Scripts/webkitpy/style/cpp_style.py: 18689 * Scripts/webkitpy/style/cpp_style_unittest.py: 18690 186912010-01-17 Adam Barth <abarth@webkit.org> 18692 18693 Reviewed by Eric Seidel. 18694 18695 style-queue complains about missing #include of config.h for non-WebCore projects 18696 https://bugs.webkit.org/show_bug.cgi?id=33170 18697 18698 WebKitAPITests are consumers of the WebKit API and therefore do not 18699 need to follow the same include discipline as the rest of WebKit. This 18700 patch exempts them from the include checks. 18701 18702 * Scripts/webkitpy/style/cpp_style.py: 18703 * Scripts/webkitpy/style/cpp_style_unittest.py: 18704 187052010-01-17 Adam Barth <abarth@webkit.org> 18706 18707 Reviewed by Eric Seidel. 18708 18709 EWS (Early Warning Systems) should build both debug and release 18710 https://bugs.webkit.org/show_bug.cgi?id=33681 18711 18712 Build both debug and release for chromium-ews. 18713 18714 * Scripts/webkitpy/commands/early_warning_system.py: 18715 187162010-01-17 Adam Barth <abarth@webkit.org> 18717 18718 Reviewed by Darin Adler. 18719 18720 style-queue should include instructions for how to file bugs against check-webkit-style 18721 https://bugs.webkit.org/show_bug.cgi?id=32345 18722 18723 Added some text to the error message asking folks to file bugs against 18724 false positives. 18725 18726 * Scripts/webkitpy/commands/queues.py: 18727 187282010-01-17 Chris Jerdonek <cjerdonek@webkit.org> 18729 18730 Reviewed by Adam Barth. 18731 18732 Eliminated the error_count global variable and related 18733 check-webkit-style refactoring. 18734 18735 https://bugs.webkit.org/show_bug.cgi?id=33678 18736 18737 * Scripts/check-webkit-style: 18738 - Updated to use webkit_argument_defaults(). 18739 - Renamed styleChecker to style_checker. 18740 18741 * Scripts/webkitpy/style/checker.py: 18742 - Prefixed the three default arguments with WEBKIT_DEFAULT. 18743 - Added webkit_argument_defaults(). 18744 - Added default filter_rules parameter to CategoryFilter constructor. 18745 - Added __ne__() to CategoryFilter class. 18746 - Added __eq__() and __ne__() to ProcessorOptions class. 18747 - Added error_count and _write_error attributes to StyleChecker class. 18748 - Made StyleChecker._handle_error() increment the error count. 18749 18750 * Scripts/webkitpy/style/checker_unittest.py: 18751 - Improved CategoryFilterTest.test_eq(). 18752 - Added CategoryFilterTest.test_ne(). 18753 - Added test_eq() and test_ne() to ProcessorOptionsTest class. 18754 - Updated unit tests to use webkit_argument_defaults(). 18755 - Added StyleCheckerTest class. 18756 18757 * Scripts/webkitpy/style/cpp_style.py: 18758 - Removed references to global error_count. 18759 18760 * Scripts/webkitpy/style/cpp_style_unittest.py: 18761 - Removed CppStyleStateTest class. 18762 187632010-01-15 Jon Honeycutt <jhoneycutt@apple.com> 18764 18765 get_accParent should try to retrieve parent AccessibilityObject, before 18766 calling upon window 18767 18768 https://bugs.webkit.org/show_bug.cgi?id=22893 18769 18770 Reviewed by Darin Adler. 18771 18772 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 18773 (AccessibilityUIElement::parentElement): 18774 Get the object's parent. Query it for IAccessible, and return it. 18775 187762010-01-16 Dan Bernstein <mitz@apple.com> 18777 18778 Reviewed by Mark Rowe. 18779 18780 <rdar://problem/7529519> DumpRenderTree crashes in makeLargeMallocFailSilently() 18781 18782 * DumpRenderTree/mac/CheckedMalloc.cpp: 18783 (makeLargeMallocFailSilently): Temporarily allow writing to the default 18784 malloc zone structure while modifying it. 18785 187862010-01-16 David Kilzer <ddkilzer@apple.com> 18787 18788 Added back removed properties to iExploder input files 18789 18790 While the update-iexploder-cssproperties script works great to 18791 add new properties, it has the side-effect of removing old 18792 properties that once were parsed. 18793 18794 * iExploder/htdocs/cssproperties.in: Added back removed 18795 properties into their own section. 18796 * iExploder/htdocs/htmlattrs.in: Ditto. 18797 187982010-01-16 Holger Hans Peter Freyther <zecke@selfish.org> 18799 18800 Reviewed by David Kilzer. 18801 18802 Update iExploder/htdocs/*.in by running update-iexploder-cssproperties 18803 https://bugs.webkit.org/show_bug.cgi?id=33756 18804 18805 * iExploder/htdocs/cssproperties.in: New CSS attributes 18806 * iExploder/htdocs/htmlattrs.in: New HTML attributes 18807 * iExploder/htdocs/htmltags.in: New HTML tags 18808 188092010-01-15 Chris Jerdonek <chris.jerdonek@gmail.com> 18810 18811 Reviewed by David Kilzer. 18812 18813 Altered parseDiffHeader() to skip unrecognized lines and 18814 other minor clean-ups. 18815 18816 https://bugs.webkit.org/show_bug.cgi?id=33476 18817 18818 * Scripts/VCSUtils.pm: 18819 - Changed parseDiffHeader() as follows: 18820 - Skips over unrecognized lines. 18821 - Addressed FIXME to remove substitution for "diff" line. 18822 - Renamed "version" header hash key to "sourceRevision". 18823 - Eliminated "copiedFromVersion" header hash key. 18824 - Included "sourceRevision" also for copied files. 18825 - Checks that copy revision number matches "sourceRevision". 18826 - No longer returns $foundHeaderEnding. 18827 - Dies if header ending not found. 18828 - Diff header dividing line now always added. 18829 18830 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: 18831 - Made necessary changes in parseDiffHeader() unit tests. 18832 - Shortened the file paths in some test cases. 18833 188342010-01-14 Yuzo Fujishima <yuzo@google.com> 18835 18836 Reviewed by Alexey Proskuryakov. 18837 18838 Update pywebsocket to 0.4.6 18839 https://bugs.webkit.org/show_bug.cgi?id=32299 18840 The newer pywebsocket can handle more simultaneous connections. 18841 18842 * pywebsocket/mod_pywebsocket/handshake.py: 18843 * pywebsocket/mod_pywebsocket/standalone.py: 18844 * pywebsocket/setup.py: 18845 * pywebsocket/test/test_handshake.py: 18846 188472010-01-14 Eric Seidel <eric@webkit.org> 18848 18849 Reviewed by Adam Barth. 18850 18851 REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs 18852 https://bugs.webkit.org/show_bug.cgi?id=33638 18853 18854 * Scripts/webkitpy/bugzilla.py: 18855 - Add Bug.id() to match Attachment.id() 18856 - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers. 18857 - Add back a missing variable to _validate_setter_email found by the new unit tests! 18858 * Scripts/webkitpy/commands/queries.py: 18859 - Add FIXMEs about the commands being confusingly named. 18860 * Scripts/webkitpy/commands/queries_unittest.py: 18861 - Update results to reflect the newly restructured mock bug cache. 18862 * Scripts/webkitpy/commands/queues.py: 18863 - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression). 18864 - Add a FIXME about eventually sorting the patches into some order. 18865 * Scripts/webkitpy/commands/queues_unittest.py: 18866 - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer. 18867 * Scripts/webkitpy/commands/upload_unittest.py: 18868 - Update results to match the newly restructured mock bug cache. 18869 * Scripts/webkitpy/mock_bugzillatool.py: 18870 - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs. 18871 - Add a few more attachments and bug dictionaries for use by the tests. 18872 188732010-01-13 Diego Gonzalez <diego.gonzalez@openbossa.org> 18874 18875 Reviewed by Kenneth Christiansen. 18876 18877 [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController 18878 https://bugs.webkit.org/show_bug.cgi?id=33617 18879 18880 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 18881 (WebCore::WebPage::resetSettings): 18882 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 18883 (LayoutTestController::setUserStyleSheetLocation): 18884 (LayoutTestController::setUserStyleSheetEnabled): 18885 * DumpRenderTree/qt/LayoutTestControllerQt.h: 18886 188872010-01-14 Adam Roben <aroben@apple.com> 18888 18889 Add LayoutTestController API to force 18890 -webView:resource:willSendRequest:: to return null 18891 18892 Enables tests for <rdar://problem/7533333> <http://webkit.org/b/33533> 18893 window.onload never fires if page contains an <iframe> with a bad 18894 scheme or whose load is cancelled by returning null from resource load 18895 delegate's willSendRequest 18896 18897 Reviewed by Brady Eidson. 18898 18899 * DumpRenderTree/LayoutTestController.cpp: 18900 (LayoutTestController::LayoutTestController): Initialize new member. 18901 (setWillSendRequestReturnsNullCallback): Call through to 18902 LayoutTestController. 18903 (LayoutTestController::staticFunctions): Added new function. 18904 18905 * DumpRenderTree/LayoutTestController.h: Added 18906 m_willSendRequestReturnsNull. 18907 (LayoutTestController::willSendRequestReturnsNull): 18908 (LayoutTestController::setWillSendRequestReturnsNull): 18909 Added standard accessors. 18910 18911 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 18912 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): 18913 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 18914 (ResourceLoadDelegate::willSendRequest): 18915 Return null if LayoutTestController says to. 18916 189172010-01-14 Kevin Ollivier <kevino@theolliviers.com> 18918 18919 [wx] Build fix after removal of XBM support. 18920 18921 * wx/build/settings.py: 18922 189232010-01-14 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 18924 18925 Reviewed by Simon Hausmann. 18926 18927 Add support for partial building on Symbian. 18928 18929 The build happens in the source directory as out of source builds are 18930 not supported by qmake for Symbian. 18931 18932 Also the actual build isn't started but it is left to the developer 18933 to choose the architecture/configuration. 18934 18935 * Scripts/webkitdirs.pm: 18936 189372010-01-14 Simon Hausmann <simon.hausmann@nokia.com> 18938 18939 Reviewed by Kenneth Rohde Christiansen. 18940 18941 Add support for "detecting" Symbian environments by either 18942 looking for the EPOCROOT environment variable or via --symbian 18943 being passed on the commandline. 18944 18945 * Scripts/webkitdirs.pm: 18946 189472010-01-14 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 18948 18949 Unreviewed. 18950 18951 [Qt] Use a different Makefile names for sources generation and compilation. 18952 This prevents Makefile overwriting when running build-webkit twice. 18953 18954 * Scripts/webkitdirs.pm: 18955 189562010-01-14 Andreas Kling <andreas.kling@nokia.com> 18957 18958 Reviewed by Kenneth Rohde Christiansen. 18959 18960 [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets. 18961 18962 https://bugs.webkit.org/show_bug.cgi?id=33373 18963 18964 * QtLauncher/main.cpp: 18965 (WebPage::createPlugin): 18966 189672010-01-14 Eric Seidel <eric@webkit.org> 18968 18969 No review, rolling out r53249. 18970 http://trac.webkit.org/changeset/53249 18971 https://bugs.webkit.org/show_bug.cgi?id=33617 18972 18973 This caused http/tests/security/local-user-CSS-from- 18974 remote.html to fail on the Qt Release Build Bot. 18975 18976 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 18977 (WebCore::WebPage::resetSettings): 18978 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 18979 (LayoutTestController::overridePreference): 18980 * DumpRenderTree/qt/LayoutTestControllerQt.h: 18981 189822010-01-14 Chris Jerdonek <chris.jerdonek@gmail.com> 18983 18984 Reviewed by Shinichiro Hamaji. 18985 18986 Moved error() from cpp_style.py to checker.py. 18987 18988 https://bugs.webkit.org/show_bug.cgi?id=33620 18989 18990 * Scripts/check-webkit-style: 18991 - Addressed FIXME to not set global state. 18992 18993 * Scripts/webkitpy/style/checker.py: 18994 - Added argument validation to ProcessorOptions constructor. 18995 - Added should_report_error() to ProcessorOptions class. 18996 - Removed set_options(). 18997 - Added StyleChecker class. 18998 18999 * Scripts/webkitpy/style/checker_unittest.py: 19000 - Added unit test class for ProcessorOptions class. 19001 - Added unit test to check that parse() strips white space. 19002 19003 * Scripts/webkitpy/style/cpp_style.py: 19004 - Removed "filter" and "output_format" methods. 19005 - Removed should_print_error() and error() functions. 19006 - Removed default parameter value from process_file(). 19007 19008 * Scripts/webkitpy/style/cpp_style_unittest.py: 19009 - Removed call to cpp_style._should_print_error(). 19010 - Removed test_filter() and test_filter_appending(). 19011 19012 * Scripts/webkitpy/style/text_style.py: 19013 - Removed default parameter value from process_file(). 19014 190152010-01-14 Diego Gonzalez <diego.gonzalez@openbossa.org> 19016 19017 Reviewed by Kenneth Rohde Christiansen. 19018 19019 [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController 19020 https://bugs.webkit.org/show_bug.cgi?id=33617 19021 19022 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 19023 (WebCore::WebPage::resetSettings): 19024 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 19025 (LayoutTestController::setUserStyleSheetLocation): 19026 (LayoutTestController::setUserStyleSheetEnabled): 19027 * DumpRenderTree/qt/LayoutTestControllerQt.h: 19028 190292010-01-13 Adam Barth <abarth@webkit.org> 19030 19031 Reviewed by Eric Seidel. 19032 19033 Fix CloseBugForLandDiff unittest to actually run 19034 https://bugs.webkit.org/show_bug.cgi?id=33640 19035 19036 * Scripts/webkitpy/mock_bugzillatool.py: 19037 * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: 19038 190392010-01-12 Jon Honeycutt <jhoneycutt@apple.com> 19040 19041 MSAA: selected, selectable, extended selectable, and multiple 19042 selectable states are not reported 19043 19044 https://bugs.webkit.org/show_bug.cgi?id=33574 19045 <rdar://problem/7536826> 19046 19047 Reviewed by Darin Adler. 19048 19049 * DumpRenderTree/AccessibilityUIElement.cpp: 19050 (getIsSelectableCallback): 19051 Return the result of calling isSelectable(). 19052 (getIsMultiSelectableCallback): 19053 Return the result of calling isMultiSelectable(). 19054 (AccessibilityUIElement::getJSClass): 19055 Add isSelected and isMultiSelectable properties to the JSClass 19056 definition. 19057 19058 * DumpRenderTree/AccessibilityUIElement.h: 19059 Declare isSelectable() and isMultiSelectable(). 19060 19061 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 19062 (AccessibilityUIElement::isSelectable): 19063 Stubbed. 19064 (AccessibilityUIElement::isMultiSelectable): 19065 Stubbed. 19066 19067 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 19068 (AccessibilityUIElement::isSelectable): 19069 Stubbed. 19070 (AccessibilityUIElement::isMultiSelectable): 19071 Stubbed. 19072 19073 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 19074 (accessibilityState): 19075 Get the object's state, and return it. 19076 (AccessibilityUIElement::isSelected): 19077 Check the object's selected state. 19078 (AccessibilityUIElement::isSelectable): 19079 Check the object's selectable state. 19080 (AccessibilityUIElement::isMultiSelectable): 19081 Check the object's extended/multiple selectable state. 19082 190832010-01-13 Adam Barth <abarth@webkit.org> 19084 19085 Unreviewed. Repeat the below for CloseBugForLandDiff. 19086 19087 * Scripts/test-webkitpy: 19088 * Scripts/webkitpy/steps/closebugforlanddiff.py: 19089 * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added. 19090 190912010-01-13 Adam Barth <abarth@webkit.org> 19092 19093 Unreviewed. Turn the mac-ews status bubbles back on now that this bot 19094 is running again. 19095 19096 * QueueStatusServer/templates/statusbubble.html: 19097 190982010-01-13 Adam Barth <abarth@webkit.org> 19099 19100 Reviewed by Darin Adler. 19101 19102 REGRESSION(53133): webkit-patch land dies if it can't find a bug id. 19103 https://bugs.webkit.org/show_bug.cgi?id=33634 19104 19105 Deal with the case of no bug patch object in the state. 19106 19107 * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: 19108 * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: 19109 191102010-01-13 Kenneth Russell <kbr@google.com> 19111 19112 Unreviewed; added myself to the committers list. 19113 19114 * Scripts/webkitpy/committers.py: 19115 191162010-01-13 Darin Adler <darin@apple.com> 19117 19118 Ignore compiled Python in more of webkitpy. 19119 19120 * Scripts/webkitpy/commands: Added property svn:ignore. 19121 * Scripts/webkitpy/steps: Added property svn:ignore. 19122 * Scripts/webkitpy/style: Added property svn:ignore. 19123 191242010-01-13 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 19125 19126 Reviewed by Simon Hausmann. 19127 19128 [Qt] Fix build problem related to the pushd command 19129 19130 * Scripts/webkitdirs.pm: 19131 191322010-01-13 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 19133 19134 Reviewed by Simon Hausmann. 19135 19136 [Qt] Split the build process in two different .pro files. 19137 This allows qmake to be run once all source files are available. 19138 19139 * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC. 19140 191412010-01-13 Shinichiro Hamaji <hamaji@chromium.org> 19142 19143 Unreviewed tiny typo fix in docstrings. 19144 19145 * Scripts/webkitpy/style/checker_unittest.py: 19146 191472010-01-13 Chris Jerdonek <chris.jerdonek@gmail.com> 19148 19149 Reviewed by Shinichiro Hamaji. 19150 19151 Created a CategoryFilter class to encapsulate the logic of 19152 filter rules. 19153 19154 https://bugs.webkit.org/show_bug.cgi?id=33454 19155 19156 * Scripts/webkitpy/style/checker.py: 19157 - Added CategoryFilter class. 19158 19159 * Scripts/webkitpy/style/checker_unittest.py: 19160 - Added CategoryFilter unit tests. 19161 19162 * Scripts/webkitpy/style/cpp_style.py: 19163 - Updated filter methods to use CategoryFilter. 19164 19165 * Scripts/webkitpy/style/cpp_style_unittest.py: 19166 - Updated references to filters. 19167 191682010-01-12 Shinichiro Hamaji <hamaji@chromium.org> 19169 19170 Unreviewed. Now I can review :) 19171 19172 * Scripts/webkitpy/committers.py: 19173 191742010-01-12 Brent Fulgham <bfulgham@webkit.org> 19175 19176 Reviewed by Darin Adler. 19177 19178 Extend WinLauncher example with better printing features. 19179 19180 * WinLauncher/PrintWebUIDelegate.cpp: 19181 (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly 19182 larger margins. 19183 (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based 19184 on text metrics. 19185 (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based 19186 on text metrics. 19187 (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along 19188 with separating line. 19189 (PrintWebUIDelegate::drawFooterInRect): 19190 * WinLauncher/PrintWebUIDelegate.h: Remove stubs. 19191 * WinLauncher/WinLauncher.cpp: 19192 (PrintView): Correct loop used to print individual pages. 19193 Previously it started at 0, which is a wild-card to print all 19194 pages at once. 19195 191962010-01-12 Alexey Proskuryakov <ap@apple.com> 19197 19198 Reviewed by Darin Adler. 19199 19200 https://bugs.webkit.org/show_bug.cgi?id=33540 19201 Make it possible to build in debug mode with assertions disabled 19202 19203 * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]): 19204 192052010-01-11 Darin Fisher <darin@chromium.org> 19206 19207 Reviewed by Dimitri Glazkov. 19208 19209 [Chromium] "build-webkit --chromium" should run "make all" on Linux 19210 https://bugs.webkit.org/show_bug.cgi?id=33500 19211 19212 * Scripts/webkitdirs.pm: 19213 192142010-01-12 Eric Seidel <eric@webkit.org> 19215 19216 Reviewed by Adam Barth. 19217 19218 AssignToCommitter does not need to fetch bugs twice 19219 https://bugs.webkit.org/show_bug.cgi?id=33530 19220 19221 This is a no-brainer patch now that we've added Bug.reviewed_patches 19222 19223 * Scripts/webkitpy/commands/upload.py: 19224 192252010-01-12 Eric Seidel <eric@webkit.org> 19226 19227 Reviewed by Adam Barth. 19228 19229 bugzilla.py should have an Attachment object instead of passing around dictionaries 19230 https://bugs.webkit.org/show_bug.cgi?id=31594 19231 19232 * Scripts/webkitpy/bugzilla.py: 19233 - Add a new Attachment class, with accessor methods for all the necessary properties. 19234 - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url()) 19235 - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug 19236 - Move committer validation logic into its own class. 19237 - Committer rejection is only used in one place. Make the new Bug reviewed_patches and commit_queued_patches 19238 handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle 19239 the case where we want to reject patches in bugzilla. 19240 - Simplify fetch_patches_from_commit_queue now that committer validation is simpler. 19241 - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug. 19242 - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it. 19243 - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class. 19244 * Scripts/webkitpy/bugzilla_unittest.py: 19245 - Move test_flag_permission_rejection_message into a new CommitterValidationTest class. 19246 * Scripts/webkitpy/commands/download.py: 19247 - Store "bug_id" in state instead of making a fake patch object. 19248 - Update to use Attachment and Bug objects. 19249 * Scripts/webkitpy/commands/download_unittest.py: 19250 - Update expected results now that our testing framework covers more code. 19251 * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class. 19252 * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class. 19253 * Scripts/webkitpy/commands/queries_unittest.py: ditto. 19254 * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes. 19255 * Scripts/webkitpy/commands/queuestest.py: ditto. 19256 * Scripts/webkitpy/commands/upload.py: ditto. 19257 * Scripts/webkitpy/mock_bugzillatool.py: 19258 - Now that more logic has moved into Attachment and Bug, we have to actually 19259 provide real reviewer emails as well as real reviewer flags. 19260 - Update mock methods to return Attachment objects. 19261 * Scripts/webkitpy/scm.py: Update to use Attachment class. 19262 * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class. 19263 * Scripts/webkitpy/statusserver.py: ditto. 19264 * Scripts/webkitpy/steps/applypatch.py: ditto. 19265 * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto. 19266 * Scripts/webkitpy/steps/closebug.py: ditto. 19267 * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id() 19268 * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class. 19269 * Scripts/webkitpy/steps/obsoletepatches.py: ditto. 19270 * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto. 19271 192722010-01-12 Adam Barth <abarth@webkit.org> 19273 19274 Unreviewed typo fix. :( 19275 19276 * Scripts/webkitpy/commands/early_warning_system.py: 19277 * Scripts/webkitpy/commands/queues.py: 19278 192792010-01-12 Adam Barth <abarth@webkit.org> 19280 19281 Unreviewed. Add "error" to the right part of the message. 19282 19283 * Scripts/webkitpy/commands/queues.py: 19284 192852010-01-12 Adam Barth <abarth@webkit.org> 19286 19287 Reviewed by Eric Seidel. 19288 19289 EWS should show purple when svn-apply fails 19290 https://bugs.webkit.org/show_bug.cgi?id=33527 19291 19292 * Scripts/webkitpy/commands/early_warning_system.py: 19293 * Scripts/webkitpy/commands/queues.py: 19294 192952010-01-12 Adam Barth <abarth@webkit.org> 19296 19297 Reviewed by Eric Seidel. 19298 19299 Remove copy/paste code from subclasses of AbstractReviewQueue 19300 https://bugs.webkit.org/show_bug.cgi?id=33525 19301 19302 * Scripts/webkitpy/commands/early_warning_system.py: 19303 * Scripts/webkitpy/commands/queues.py: 19304 193052010-01-12 Adam Barth <abarth@webkit.org> 19306 19307 Reviewed by Eric Seidel. 19308 19309 Add Gustavo and Xan as gtk-ews watchers 19310 https://bugs.webkit.org/show_bug.cgi?id=33519 19311 19312 * Scripts/webkitpy/commands/early_warning_system.py: 19313 193142010-01-12 Adam Barth <abarth@webkit.org> 19315 19316 Reviewed by Eric Seidel. 19317 19318 webkit-patch shouldn't waste my time for with a component prompt 19319 https://bugs.webkit.org/show_bug.cgi?id=33521 19320 19321 The component field isn't very useful for bugs created with 19322 webkit-patch because they're likely to be resolved quickly. Instead of 19323 always prompting for a component, we should just default to the "New 19324 Bugs" component. If the bug stays around for more than five minutes, 19325 we can assign it a proper component. 19326 19327 * Scripts/webkitpy/bugzilla.py: 19328 193292010-01-12 Adam Barth <abarth@webkit.org> 19330 19331 Reviewed by Eric Seidel. 19332 19333 Add experimental "land-safely" command to webkit-patch 19334 https://bugs.webkit.org/show_bug.cgi?id=33518 19335 19336 * Scripts/webkitpy/commands/upload.py: 19337 * Scripts/webkitpy/commands/upload_unittest.py: 19338 * Scripts/webkitpy/steps/__init__.py: 19339 * Scripts/webkitpy/steps/postdiffforcommit.py: Added. 19340 193412010-01-11 Kevin Ollivier <kevino@theolliviers.com> 19342 19343 [wx] Build fix after introduction of JS_NO_EXPORT 19344 19345 * wx/build/settings.py: 19346 193472010-01-11 Eric Seidel <eric@webkit.org> 19348 19349 No review, rolling out r53079. 19350 http://trac.webkit.org/changeset/53079 19351 https://bugs.webkit.org/show_bug.cgi?id=33197 19352 19353 Adam doens't think this actually works, and believe it caused 19354 a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so 19355 rolling this out. 19356 19357 * Scripts/test-webkitpy: 19358 * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed. 19359 * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed. 19360 * Scripts/webkitpy/commands/download.py: 19361 * Scripts/webkitpy/commands/upload.py: 19362 * Scripts/webkitpy/mock_bugzillatool.py: 19363 193642010-01-10 Adam Barth <abarth@webkit.org> 19365 19366 Reviewed by David Kilzer. 19367 19368 bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files 19369 https://bugs.webkit.org/show_bug.cgi?id=33197 19370 19371 We should just search for bug numbers in the ChangeLogs instead of in 19372 the whole diff. 19373 19374 * Scripts/test-webkitpy: 19375 * Scripts/webkitpy/commands/abstractdiffcommand.py: Added. 19376 * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added. 19377 * Scripts/webkitpy/commands/download.py: 19378 * Scripts/webkitpy/commands/upload.py: 19379 * Scripts/webkitpy/mock_bugzillatool.py: 19380 193812010-01-11 Chris Jerdonek <chris.jerdonek@gmail.com> 19382 19383 Reviewed by David Kilzer. 19384 19385 Created a unit-tested function to parse the header block of 19386 a Git or SVN diff -- for future refactoring of svn-apply and 19387 svn-unapply. 19388 19389 https://bugs.webkit.org/show_bug.cgi?id=33447 19390 19391 * Scripts/VCSUtils.pm: 19392 - Added parseDiffHeader(). 19393 - Removed irrelevant comment from gitdiff2svndiff(). 19394 19395 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added. 19396 - Added 48 unit tests for parseDiffHeader(). 19397 193982010-01-10 Adam Barth <abarth@webkit.org> 19399 19400 Rubber stamped by David Kilzer. 19401 19402 bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files 19403 https://bugs.webkit.org/show_bug.cgi?id=33197 19404 19405 Fix a typo: Commmand -> Command. 19406 19407 * Scripts/webkitpy/commands/abstractsequencedcommand.py: 19408 * Scripts/webkitpy/commands/download.py: 19409 * Scripts/webkitpy/commands/queries.py: 19410 * Scripts/webkitpy/commands/upload.py: 19411 * Scripts/webkitpy/multicommandtool.py: 19412 194132010-01-10 Adam Barth <abarth@webkit.org> 19414 19415 Reviewed by Darin Adler. 19416 19417 Let webkit-patch work with options in $EDITOR 19418 https://bugs.webkit.org/show_bug.cgi?id=33414 19419 19420 The $EDITOR evironment variable might have command line options like 19421 bbedit -w. This patch lets us run those $EDITORs. 19422 19423 * Scripts/webkitpy/user.py: 19424 194252010-01-10 Robert Hogan <robert@roberthogan.net> 19426 19427 Reviewed by Adam Barth. 19428 19429 [Qt] Add enableXSSAuditor support to QWebSettings and DRT. 19430 19431 https://bugs.webkit.org/show_bug.cgi?id=33419 19432 19433 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 19434 (WebCore::WebPage::WebPage): 19435 (WebCore::WebPage::resetSettings): 19436 (WebCore::DumpRenderTree::createWindow): 19437 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 19438 (LayoutTestController::setXSSAuditorEnabled): 19439 * DumpRenderTree/qt/LayoutTestControllerQt.h: 19440 194412010-01-10 Adam Barth <abarth@webkit.org> 19442 19443 Unreviewed cosmetic change. Remove the status bubble for mac-ews 19444 because we don't have hardware for it at the moment. 19445 19446 * QueueStatusServer/templates/statusbubble.html: 19447 194482010-01-09 Daniel Bates <dbates@webkit.org> 19449 19450 No review, rolling out r53044. 19451 http://trac.webkit.org/changeset/53044 19452 https://bugs.webkit.org/show_bug.cgi?id=33419 19453 19454 We need to look into this some more because the Qt 19455 bot is failing the XSSAuditor tests. See bug #33419 19456 for more details. 19457 19458 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 19459 (WebCore::WebPage::WebPage): 19460 (WebCore::WebPage::resetSettings): 19461 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 19462 * DumpRenderTree/qt/LayoutTestControllerQt.h: 19463 194642010-01-09 Daniel Bates <dbates@webkit.org> 19465 19466 Reviewed by Adam Barth. 19467 19468 https://bugs.webkit.org/show_bug.cgi?id=33419 19469 19470 Adds support for the XSSAuditor to the Qt DRT. 19471 19472 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 19473 (WebCore::WebPage::WebPage): 19474 (WebCore::WebPage::resetSettings): 19475 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 19476 (LayoutTestController::setXSSAuditorEnabled): 19477 * DumpRenderTree/qt/LayoutTestControllerQt.h: 19478 194792010-01-09 Adam Barth <abarth@webkit.org> 19480 19481 Reviewed by Eric Seidel. 19482 19483 Retry writes to QueueStatusServer when we get 500 errors 19484 https://bugs.webkit.org/show_bug.cgi?id=33412 19485 19486 This prevents the queues from failing to mark a patch as "pass" or 19487 "fail" when AppEngine throws 500 errors. 19488 19489 * Scripts/test-webkitpy: 19490 * Scripts/webkitpy/networktransaction.py: Added. 19491 * Scripts/webkitpy/networktransaction_unittest.py: Added. 19492 * Scripts/webkitpy/statusserver.py: 19493 * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added. 19494 * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added. 19495 * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added. 19496 194972010-01-09 David Kilzer <ddkilzer@apple.com> 19498 19499 <http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers 19500 19501 Reviewed by Eric Seidel. 19502 19503 * QueueStatusServer/templates/statusbubble.html: Added 19504 -moz-border-radius and -webkit-border-radius to provide rounded 19505 borders in older Firefox and Safari browsers. 19506 195072010-01-09 Chris Jerdonek <chris.jerdonek@gmail.com> 19508 19509 Reviewed by David Kilzer. 19510 19511 Modified VCSUtils::gitdiff2svndiff() to accept strings that 19512 end in vertical white space. 19513 19514 https://bugs.webkit.org/show_bug.cgi?id=33415 19515 19516 * Scripts/VCSUtils.pm: 19517 * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: 19518 195192010-01-08 Eric Seidel <eric@webkit.org> 19520 19521 Reviewed by Adam Barth. 19522 19523 run-javascriptcore-tests needs a --quiet flag 19524 https://bugs.webkit.org/show_bug.cgi?id=33399 19525 19526 Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch. 19527 19528 * Scripts/webkitpy/steps/runtests.py: 19529 195302010-01-08 Andras Becsi <abecsi@inf.u-szeged.hu> 19531 19532 Reviewed by Alexey Proskuryakov. 19533 19534 Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order. 19535 19536 To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize 19537 the time when Apache and WebSocketServer is locked by tests. 19538 Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing, 19539 we need to run http and websocket tests after all other tests. 19540 If one however explicitly specifies the tests to run in the argument list of run-webkit-tests 19541 we need to preserve the given order. 19542 19543 * Scripts/run-webkit-tests: 19544 195452010-01-08 Adam Barth <abarth@webkit.org> 19546 19547 Reviewed by Eric Seidel. 19548 19549 Don't post style-queue pass messages to bugs 19550 https://bugs.webkit.org/show_bug.cgi?id=33404 19551 19552 These messages aren't needed any more now that we have the status 19553 bubble reporting pass events passively. 19554 19555 * Scripts/webkitpy/commands/queues.py: 19556 195572010-01-08 Adam Barth <abarth@webkit.org> 19558 19559 Reviewed by Eric Seidel. 19560 19561 Optimize the number of CPUs used for building Qt and Gtk 19562 https://bugs.webkit.org/show_bug.cgi?id=33394 19563 19564 Instead of hardcoding the number 8, we should read the number of CPUs 19565 from the environment. 19566 19567 * Scripts/webkitpy/executive.py: 19568 * Scripts/webkitpy/webkitport.py: 19569 * Scripts/webkitpy/webkitport_unittest.py: 19570 195712010-01-08 Chris Fleizach <cfleizach@apple.com> 19572 19573 Reviewed by Eric Seidel. 19574 19575 REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot 19576 https://bugs.webkit.org/show_bug.cgi?id=33300 19577 19578 * DumpRenderTree/AccessibilityUIElement.h: 19579 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 19580 (AccessibilityUIElement::AccessibilityUIElement): 19581 (AccessibilityUIElement::~AccessibilityUIElement): 19582 (_accessibilityNotificationCallback): 19583 (AccessibilityUIElement::addNotificationListener): 19584 195852010-01-08 Eric Seidel <eric@webkit.org> 19586 19587 Reviewed by Simon Hausmann. 19588 19589 commit-queue should run run-javascriptcore-tests 19590 https://bugs.webkit.org/show_bug.cgi?id=33376 19591 19592 I also made it run the python and perl unit tests. 19593 19594 * Scripts/webkitpy/steps/runtests.py: 19595 * Scripts/webkitpy/webkitport.py: 19596 195972010-01-07 Andras Becsi <abecsi@inf.u-szeged.hu> 19598 19599 Reviewed by Darin Adler. 19600 19601 Run the http and websocket tests after all other tests. 19602 https://bugs.webkit.org/show_bug.cgi?id=33153 19603 19604 * Scripts/run-webkit-tests: 19605 196062010-01-07 Adam Barth <abarth@webkit.org> 19607 19608 Reviewed by Eric Seidel. 19609 19610 Fix some test-webkitpy expectations 19611 https://bugs.webkit.org/show_bug.cgi?id=33345 19612 19613 I forgot to change these when I added the CheckStyle step. 19614 19615 * Scripts/webkitpy/commands/upload_unittest.py: 19616 196172010-01-07 Adam Barth <abarth@webkit.org> 19618 19619 Reviewed by Eric Seidel. 19620 19621 webkit-patch edit-changelogs (or upload) will open blank files if run outside the root 19622 https://bugs.webkit.org/show_bug.cgi?id=33341 19623 19624 Fix this by moving to the root directory before editing ChangeLogs. 19625 There is a related bug with CheckStyle. 19626 19627 * Scripts/webkitpy/steps/checkstyle.py: 19628 * Scripts/webkitpy/steps/editchangelog.py: 19629 196302010-01-07 Eric Seidel <eric@webkit.org> 19631 19632 Reviewed by Nikolas Zimmermann. 19633 19634 media/unsupported-tracks.html is failing on Snow Leopard Release bot 19635 https://bugs.webkit.org/show_bug.cgi?id=32339 19636 19637 This is a speculative fix. I do not have a Snow Leopard machine to test on 19638 and I've not seen mention of someone being able to reproduce this locally. 19639 19640 Prevent watchdog timer from firing after a test completes but before 19641 the next one starts, causing the error to appear in the next test. 19642 19643 * DumpRenderTree/mac/DumpRenderTree.mm: 19644 (dump): Stop the watchdog before printing #EOF for the test content. 19645 We only need to care about the JavaScript of the test running too long 19646 or some hang in WebCore. Any other failures will be covered by the calling 19647 script's own watchdog timer. 19648 196492010-01-07 Eric Seidel <eric@webkit.org> 19650 19651 Reviewed by Adam Barth. 19652 19653 commit-queue is stuck spinning due to exception 19654 https://bugs.webkit.org/show_bug.cgi?id=33358 19655 19656 * Scripts/webkitpy/commands/queues.py: 19657 - Don't try to stringify the exception. 19658 196592010-01-07 Mark Rowe <mrowe@apple.com> 19660 19661 Reviewed by Jon Honeycutt. 19662 19663 Don't leak a JSStringRef within _accessibilityNotificationCallback. 19664 19665 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 19666 (_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up 19667 when it goes out of scope. 19668 196692010-01-07 Simon Fraser <simon.fraser@apple.com> 19670 19671 Reviewed by Darin Adler. 19672 19673 Add proposed rename of HTMLPlugInImageElement to HTMLEmbeddedObjectElement. 19674 19675 * Scripts/do-webcore-rename: 19676 196772010-01-07 Kim Grönholm <kim.gronholm@nomovok.com> 19678 19679 Reviewed by Antti Koivisto. 19680 19681 Wrong state and TouchLists in TouchEvents 19682 https://bugs.webkit.org/show_bug.cgi?id=32878 19683 19684 * DumpRenderTree/qt/EventSenderQt.cpp: 19685 (EventSender::touchStart): 19686 (EventSender::touchEnd): 19687 (EventSender::clearTouchPoints): 19688 * DumpRenderTree/qt/EventSenderQt.h: 19689 196902010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com> 19691 19692 Reviewed by Adam Barth. 19693 19694 Created a module that runs the style package unit tests. 19695 19696 https://bugs.webkit.org/show_bug.cgi?id=32973 19697 19698 * Scripts/test-webkitpy: 19699 * Scripts/webkitpy/style/unittests.py: Added. 19700 197012010-01-07 Adam Barth <abarth@webkit.org> 19702 19703 Reviewed by Maciej Stachowiak. 19704 19705 Don't print a redundant message when confirming a diff 19706 https://bugs.webkit.org/show_bug.cgi?id=33315 19707 19708 Instead of saying "ERROR: User declined" we should just exit because 19709 the use knows they just declined! 19710 19711 * Scripts/webkitpy/steps/confirmdiff.py: 19712 197132010-01-07 Adam Barth <abarth@webkit.org> 19714 19715 Reviewed by Maciej Stachowiak. 19716 19717 Check style before uploading a patch 19718 https://bugs.webkit.org/show_bug.cgi?id=33314 19719 19720 * Scripts/webkitpy/commands/upload.py: 19721 * Scripts/webkitpy/steps/checkstyle.py: 19722 * Scripts/webkitpy/steps/options.py: 19723 197242010-01-07 Adam Barth <abarth@webkit.org> 19725 19726 Reviewed by Maciej Stachowiak. 19727 19728 Add prepare and post to webkit-patch main help 19729 https://bugs.webkit.org/show_bug.cgi?id=33313 19730 19731 * Scripts/webkitpy/commands/upload.py: 19732 197332010-01-07 Eric Seidel <eric@webkit.org> 19734 19735 Reviewed by Adam Barth. 19736 19737 Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red) 19738 https://bugs.webkit.org/show_bug.cgi?id=33290 19739 19740 Add the Chromium builders to our list of core builders and test that our regexps work. 19741 I also updated our regexp testing to make sure we cover all known builders at build.webkit.org. 19742 19743 * Scripts/webkitpy/buildbot.py: 19744 * Scripts/webkitpy/buildbot_unittest.py: 19745 197462010-01-07 Adam Barth <abarth@webkit.org> 19747 19748 Reviewed by Eric Seidel. 19749 19750 bugzilla-tool needs a new name 19751 https://bugs.webkit.org/show_bug.cgi?id=28459 19752 19753 Rename bugzilla-tool to webkit-patch. Also, rename some commands to 19754 make more sense with the new name. 19755 19756 * Scripts/bugzilla-tool: Removed. 19757 * Scripts/webkit-patch: Added. 19758 * Scripts/webkit-tools-completion.sh: 19759 * Scripts/webkitpy/bugzilla_unittest.py: 19760 * Scripts/webkitpy/commands/download.py: 19761 * Scripts/webkitpy/commands/download_unittest.py: 19762 * Scripts/webkitpy/commands/early_warning_system.py: 19763 * Scripts/webkitpy/commands/queries.py: 19764 * Scripts/webkitpy/commands/queues.py: 19765 * Scripts/webkitpy/commands/queues_unittest.py: 19766 * Scripts/webkitpy/commands/upload.py: 19767 * Scripts/webkitpy/commands/upload_unittest.py: 19768 * Scripts/webkitpy/queueengine.py: 19769 * Scripts/webkitpy/steps/completerollout.py: 19770 197712010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com> 19772 19773 Reviewed by Eric Seidel. 19774 19775 Moved style-related modules to webkitpy.style sub-package. 19776 19777 https://bugs.webkit.org/show_bug.cgi?id=32971 19778 19779 * Scripts/check-webkit-style: 19780 - Updated import statement. 19781 19782 * Scripts/test-webkitpy: 19783 - Updated import statements. 19784 19785 * Scripts/webkitpy/cpp_style.py: Removed. 19786 - Moved to webkitpy/style. 19787 19788 * Scripts/webkitpy/cpp_style_unittest.py: Removed. 19789 - Moved to webkitpy/style. 19790 19791 * Scripts/webkitpy/style.py: Removed. 19792 - Moved to webkitpy/style/checker.py. 19793 19794 * Scripts/webkitpy/style/__init__.py: Added. 19795 - Added containing webkitpy directory to package search path. 19796 19797 * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py. 19798 * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py. 19799 - Updated import statement. 19800 19801 * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py. 19802 * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py. 19803 - Update import statement. 19804 19805 * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py. 19806 * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py. 19807 * Scripts/webkitpy/style_unittest.py: Removed. 19808 - Moved to webkitpy/style/checker_unittest.py. 19809 19810 * Scripts/webkitpy/text_style.py: Removed. 19811 - Moved to webkitpy/style. 19812 19813 * Scripts/webkitpy/text_style_unittest.py: Removed. 19814 - Moved to webkitpy/style. 19815 198162010-01-06 Kinuko Yasuda <kinuko@chromium.org> 19817 19818 Reviewed by Eric Seidel. 19819 19820 [Qt] Support the 3rd argument of EventSender.keyDown that 19821 has been recently added to report keyLocation 19822 (see also: https://bugs.webkit.org/show_bug.cgi?id=28247). 19823 https://bugs.webkit.org/show_bug.cgi?id=33250 19824 19825 Test: fast/events/keydown-numpad-keys.html 19826 19827 * DumpRenderTree/qt/EventSenderQt.cpp: 19828 (EventSender::keyDown): 19829 * DumpRenderTree/qt/EventSenderQt.h: 19830 198312010-01-06 Eric Seidel <eric@webkit.org> 19832 19833 Reviewed by Adam Barth. 19834 19835 Add long_help for all common commands. 19836 https://bugs.webkit.org/show_bug.cgi?id=33261 19837 19838 For now these long_helps are pretty basic. 19839 These were all written to just explain the steps 19840 that each command runs. This style long_help could 19841 be made easier by using: 19842 https://bugs.webkit.org/show_bug.cgi?id=33257 19843 19844 * Scripts/webkitpy/commands/download.py: 19845 * Scripts/webkitpy/commands/queries.py: 19846 198472010-01-06 Diego Gonzalez <diego.gonzalez@openbossa.org> 19848 19849 Reviewed by Kenneth Christiansen. 19850 19851 [Qt] Add page zooming support to Qt DumpRenderTree 19852 https://bugs.webkit.org/show_bug.cgi?id=32898 19853 19854 Patch by Kim Grönholm <kim.gronholm@nomovok.com>, 19855 Diego Gonzalez <diego.gonzalez@openbossa.org> and 19856 Afonso Costa <afonso.costa@openbossa.org> 19857 19858 * DumpRenderTree/qt/EventSenderQt.cpp: 19859 (EventSender::zoomPageIn): 19860 (EventSender::zoomPageOut): 19861 * DumpRenderTree/qt/EventSenderQt.h: 19862 198632010-01-06 Eric Seidel <eric@webkit.org> 19864 19865 No review, just adding Mike Belshe's new bugzilla email at his request. 19866 19867 * Scripts/webkitpy/committers.py: 19868 198692010-01-06 Eric Seidel <eric@webkit.org> 19870 19871 Unreviewed. Rolling out r52869 and r52853 due to bot 19872 and local run-webkit-test failures 19873 19874 REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot 19875 https://bugs.webkit.org/show_bug.cgi?id=33256 19876 19877 The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153 19878 19879 * Scripts/run-webkit-tests: 19880 198812010-01-06 Eric Seidel <eric@webkit.org> 19882 19883 Unreviewed "build" fix. Just adding missing include. 19884 19885 bugzilla-tool rollout --complete-rollout should make a nicer bug comment 19886 https://bugs.webkit.org/show_bug.cgi?id=29212 19887 19888 * Scripts/webkitpy/steps/completerollout.py: 19889 198902010-01-06 Eric Seidel <eric@webkit.org> 19891 19892 Reviewed by Adam Barth. 19893 19894 bugzilla-tool rollout --complete-rollout should make a nicer bug comment 19895 https://bugs.webkit.org/show_bug.cgi?id=29212 19896 19897 * Scripts/webkitpy/bugzilla.py: 19898 - Make reopen_bug robust against the bug already being open. 19899 * Scripts/webkitpy/commands/download.py: 19900 - Remove dead code from Rollout. 19901 * Scripts/webkitpy/steps/completerollout.py: 19902 - Improve the rollout comment. 19903 199042010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu> 19905 19906 Reviewed by Darin Adler. 19907 19908 Set isHttpdOpen to 0 if pidfile does not exist for some reason. 19909 Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256. 19910 19911 * Scripts/run-webkit-tests: 19912 199132010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu> 19914 19915 Reviewed by Darin Adler. 19916 19917 Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(), 19918 and remove the httpd's pidfile directory if httpd terminated. 19919 19920 * Scripts/run-webkit-tests: 19921 199222010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com> 19923 19924 Reviewed by David Levin. 19925 19926 Refactored check-webkit-style's argument parser to not rely 19927 on global state, and improved its error handling and unit 19928 test coverage. 19929 19930 https://bugs.webkit.org/show_bug.cgi?id=32966 19931 19932 * Scripts/check-webkit-style: 19933 - Adjusted to use new argument parser. 19934 19935 * Scripts/webkitpy/cpp_style.py: 19936 - Changed _CppStyleState to accept an array of filter rules 19937 instead of a comma-delimited string. 19938 - Eliminated cpp_style._DEFAULT_FILTER_RULES. 19939 - Eliminated cpp_style._USAGE. 19940 19941 * Scripts/webkitpy/cpp_style_unittest.py: 19942 - Updated test_filter() and test_default_filter(). 19943 19944 * Scripts/webkitpy/style.py: 19945 - Converted style._USAGE to create_usage(). 19946 - Corrected usage instructions by removing 0 as a valid 19947 --verbose flag value. 19948 - Removed use_webkit_styles(). 19949 - Added ProcessorOptions class. 19950 - Added ArgumentDefaults class. 19951 - Added ArgumentPrinter class. 19952 - Removed parse_arguments and added ArgumentParser class. 19953 - Moved exit_with_usage() and exit_with_categories() into 19954 ArgumentParser. 19955 - Refactored parse_arguments() as ArgumentParser.parse(). 19956 - Improved parser error handling. 19957 19958 * Scripts/webkitpy/style_unittest.py: 19959 - Added DefaultArgumentsTest class. 19960 - Addressed FIXME to check style.WEBKIT_FILTER_RULES 19961 against style.STYLE_CATEGORIES. 19962 - Added ArgumentPrinterTest class. 19963 - Added ArgumentParserTest class and rewrote parser unit tests. 19964 199652010-01-05 Adam Roben <aroben@apple.com> 19966 19967 Test that it's safe to call IWebView::close when 19968 IWebView::initWithFrame hasn't been called 19969 19970 Part of <http://webkit.org/b/32827> Crash when calling 19971 IWebView::close, then releasing the WebView, without calling 19972 DestroyWindow 19973 19974 Reviewed by Steve Falkenburg. 19975 19976 * WebKitAPITest/tests/WebViewDestruction.cpp: 19977 (WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close 19978 without ever calling IWebView::initWithFrame and tests that we don't 19979 crash or leak. 19980 199812010-01-05 Adam Roben <aroben@apple.com> 19982 19983 Add more WebViewDestruction tests 19984 19985 Fixes <http://webkit.org/b/33216>. 19986 19987 Reviewed by Eric Seidel. 19988 19989 * WebKitAPITest/tests/WebViewDestruction.cpp: 19990 (WebKitAPITest::NoInitWithFrame): 19991 (WebKitAPITest::CloseThenDestroyViewWindow): 19992 (WebKitAPITest::DestroyViewWindowThenClose): 19993 (WebKitAPITest::DestroyHostWindow): 19994 (WebKitAPITest::DestroyHostWindowThenClose): 19995 (WebKitAPITest::CloseThenDestroyHostWindow): 19996 Added these tests that exercise tearing down a WebView in various 19997 ways, all of which we eventually want to have work. Some of them 19998 currently crash or leak. 19999 200002010-01-05 Robert Hogan <robert@roberthogan.net> 20001 20002 Reviewed by Eric Seidel. 20003 20004 [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT 20005 20006 If you're working from a --minimal or --no-svg build and make changes to the 20007 DRT, then recompile, the build will fail. 20008 20009 This is because the current behavior at build time is to assume that the 20010 previous Qt build supported SVG and consequently delete libQtWebKit.so. 20011 Unfortunately, just deleting libQtWebKit.so will not cause the library to 20012 re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the 20013 linking phase, and attempt to link the DRT with libQtWebKit.so absent. This 20014 results in a link failure on the DRT. 20015 20016 Since re-linking libQtWebKit can take up to ten minutes and should be avoided 20017 in cases where not actually required, remove the assumption that 20018 the previous Qt build supported SVG, and amend the symbol detection to look for 20019 a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks 20020 for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'. 20021 20022 https://bugs.webkit.org/show_bug.cgi?id=32992 20023 20024 * Scripts/webkitdirs.pm: 20025 200262010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com> 20027 20028 Reviewed by David Kilzer. 20029 20030 Switched to generating list of Perl unit test files dynamically, 20031 instead of explicitly. 20032 20033 https://bugs.webkit.org/show_bug.cgi?id=33200 20034 20035 * Scripts/test-webkitperl: 20036 200372010-01-05 Yael Aharon <yael.aharon@nokia.com> 20038 20039 Reviewed by Kenneth Rohde Christiansen. 20040 20041 [Qt] Reimplement EventSender::leapForward 20042 https://bugs.webkit.org/show_bug.cgi?id=33114 20043 20044 Follow Windows implementation of leapForward. When leapForward is called, 20045 messages are queued and posted after the timeout. A new event loop is created to 20046 handle those messages and the additional messages that are created as a result. 20047 20048 * DumpRenderTree/qt/DumpRenderTree.pro: 20049 * DumpRenderTree/qt/EventSenderQt.cpp: 20050 (EventSender::EventSender): 20051 (EventSender::mouseDown): 20052 (EventSender::mouseUp): 20053 (EventSender::mouseMoveTo): 20054 (EventSender::leapForward): 20055 (EventSender::sendOrQueueEvent): 20056 (EventSender::replaySavedEvents): 20057 (EventSender::eventFilter): 20058 * DumpRenderTree/qt/EventSenderQt.h: 20059 200602010-01-05 Adam Barth <abarth@webkit.org> 20061 20062 Reviewed by Darin Adler. 20063 20064 Fix obscure queue crash in queueengine 20065 https://bugs.webkit.org/show_bug.cgi?id=33196 20066 20067 Sometimes we get an exception that can't be stringified. For example: 20068 20069 AttributeError: 'ParseError' object has no attribute 'msg' 20070 20071 In these cases, the whole queue dies because we're in the global 20072 exception handler. Instead of dieing here, we should just print a less 20073 informative message to the console. We're already printing the whole 20074 backtrace anyway, so there's not much point to stringifying the 20075 exception anyway. 20076 20077 * Scripts/webkitpy/queueengine.py: 20078 200792010-01-05 Dominic Mazzoni <dmazzoni@google.com> 20080 20081 Reviewed by Darin Adler. 20082 20083 https://bugs.webkit.org/show_bug.cgi?id=32571 20084 20085 For an object with an aria role of "checkbox" or "radiobutton", 20086 use the "aria-checked" attribute to determine if it's checked. 20087 These changes add an isChecked() method to AccessibilityUIElement 20088 so that we can check for this property from a layout test. 20089 20090 * DumpRenderTree/AccessibilityUIElement.cpp: 20091 (getIsCheckedCallback): 20092 (AccessibilityUIElement::getJSClass): 20093 * DumpRenderTree/AccessibilityUIElement.h: 20094 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 20095 (AccessibilityUIElement::isChecked): 20096 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 20097 (AccessibilityUIElement::isChecked): 20098 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 20099 (AccessibilityUIElement::isChecked): 20100 201012010-01-05 David Levin <levin@chromium.org> 20102 20103 Reviewed by Darin Adler. 20104 20105 Having a comment for the #endif for a header guard is not required WebKit style. 20106 https://bugs.webkit.org/show_bug.cgi?id=33214 20107 20108 * Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit 20109 early when it has all the needed information to continue. 20110 * Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests. 20111 201122010-01-05 Adam Roben <aroben@apple.com> 20113 20114 Share more code in the WebViewDestruction tests 20115 20116 Part of <http://webkit.org/b/33212> Small fixes/improvements to 20117 WebKitAPITest 20118 20119 Reviewed by Sam Weinig. 20120 20121 * WebKitAPITest/tests/WebViewDestruction.cpp: 20122 (WebKitAPITest::createAndInitializeWebView): Renamed from 20123 createWebView. Now initializes the HostWindow and returns the 20124 WebView's HWND via an out-parameter. 20125 (WebKitAPITest::finishWebViewDestructionTest): Added. Code came from 20126 the CloseWithoutDestroyWindow test. 20127 (WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from 20128 CloseWithoutDestroyWindow and changed to use the new functions. 20129 (WebKitAPITest::MainFrameAfterClose): Changed to use the new 20130 functions. 20131 (WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from 20132 NoCloseOrDestroyWindow and changed to use the new functions. 20133 201342010-01-05 Adam Roben <aroben@apple.com> 20135 20136 Don't show HostWindows by default 20137 20138 This was making WebKitAPITest very flashy as windows appeared and 20139 disappeared. 20140 20141 Part of <http://webkit.org/b/33212> Small fixes/improvements to 20142 WebKitAPITest 20143 20144 Reviewed by Sam Weinig. 20145 20146 * WebKitAPITest/HostWindow.cpp: 20147 (WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style 20148 from the window. 20149 201502010-01-05 Adam Roben <aroben@apple.com> 20151 20152 Don't hang in WebKitAPITest if no messages have been posted 20153 20154 Part of <http://webkit.org/b/33212> Small fixes/improvements to 20155 WebKitAPITest 20156 20157 Reviewed by Sam Weinig. 20158 20159 * WebKitAPITest/tests/WebViewDestruction.cpp: 20160 (WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage 20161 to avoid hanging if no messages have been posted. 20162 201632010-01-05 Adam Roben <aroben@apple.com> 20164 20165 Fix WebKitCreateInstance helper 20166 20167 Part of <http://webkit.org/b/33212> Small fixes/improvements to 20168 WebKitAPITest 20169 20170 Reviewed by Sam Weinig. 20171 20172 * WebKitAPITest/tests/WebViewDestruction.cpp: 20173 (WebKitAPITest::WebKitCreateInstance): Pass the pointer straight 20174 through, instead of taking its address. 20175 201762010-01-04 Maciej Stachowiak <mjs@apple.com> 20177 20178 Reviewed by Darin Fisher. 20179 20180 Reorganize, document and rename OS() platform macros. 20181 https://bugs.webkit.org/show_bug.cgi?id=33198 20182 20183 Adapt to name changes. 20184 20185 * DumpRenderTree/DumpRenderTree.h: 20186 * DumpRenderTree/config.h: 20187 201882010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com> 20189 20190 Reviewed by Eric Seidel. 20191 20192 Minor improvements to test-webkit-scripts, as suggested 20193 by an earlier review. 20194 20195 https://bugs.webkit.org/show_bug.cgi?id=33125 20196 20197 * Scripts/test-webkit-scripts: 20198 - Used OptionParser class instead of getopt.getopt(). 20199 - Created main() method for __main__ block. 20200 - Enclosed functions in a class. 20201 202022010-01-05 Chris Fleizach <cfleizach@apple.com> 20203 20204 No review. Fix DRT breakage on Tiger/Leopard. 20205 20206 Add ARIA "Live Region" support 20207 https://bugs.webkit.org/show_bug.cgi?id=33117 20208 20209 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 20210 202112010-01-04 Chris Fleizach <cfleizach@apple.com> 20212 20213 Reviewed by Darin Adler. 20214 20215 Add ARIA "Live Region" support 20216 https://bugs.webkit.org/show_bug.cgi?id=33117 20217 20218 * DumpRenderTree/AccessibilityUIElement.cpp: 20219 (indexOfChildCallback): 20220 (boolAttributeValueCallback): 20221 (stringAttributeValueCallback): 20222 (addNotificationListenerCallback): 20223 (AccessibilityUIElement::getJSClass): 20224 * DumpRenderTree/AccessibilityUIElement.h: 20225 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 20226 (AccessibilityUIElement::indexOfChild): 20227 (AccessibilityUIElement::stringAttributeValue): 20228 (AccessibilityUIElement::boolAttributeValue): 20229 (AccessibilityUIElement::addNotificationListener): 20230 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 20231 (AccessibilityUIElement::indexOfChild): 20232 (AccessibilityUIElement::stringAttributeValue): 20233 (AccessibilityUIElement::boolAttributeValue): 20234 (_accessibilityNotificationCallback): 20235 (AccessibilityUIElement::addNotificationListener): 20236 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 20237 (AccessibilityUIElement::indexOfChild): 20238 (AccessibilityUIElement::stringAttributeValue): 20239 (AccessibilityUIElement::boolAttributeValue): 20240 (AccessibilityUIElement::addNotificationListener): 20241 202422010-01-04 Eric Seidel <eric@webkit.org> 20243 20244 Reviewed by Adam Barth. 20245 20246 bugzilla-tool rollout should require a reason 20247 https://bugs.webkit.org/show_bug.cgi?id=30810 20248 20249 * Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic. 20250 * Scripts/webkitpy/changelogs_unittest.py: Test reason support. 20251 * Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument 20252 * Scripts/webkitpy/commands/download_unittest.py: pass required reason 20253 * Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert 20254 202552010-01-04 Jon Honeycutt <jhoneycutt@apple.com> 20256 20257 MSAA: <select> elements should broadcast value change events 20258 20259 https://bugs.webkit.org/show_bug.cgi?id=33088 20260 20261 <rdar://problem/7332364> 20262 20263 Reviewed by Darin Adler. 20264 20265 * DumpRenderTree/AccessibilityController.cpp: 20266 (logValueChangeEventsCallback): 20267 Start logging value change events. 20268 (AccessibilityController::getJSClass): 20269 Add a "logValueChangeEvents" to the AccessibilityController's JS class 20270 definition. 20271 (AccessibilityController::resetToConsistentState): 20272 Disable logging of value change events. 20273 20274 * DumpRenderTree/AccessibilityController.h: 20275 Declare setLogValueChangeEvents(), and add a member variable for the 20276 value change event hook. 20277 20278 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 20279 (AccessibilityController::setLogValueChangeEvents): 20280 Stubbed. 20281 20282 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 20283 (AccessibilityController::setLogValueChangeEvents): 20284 Stubbed. 20285 20286 * DumpRenderTree/win/AccessibilityControllerWin.cpp: 20287 (AccessibilityController::AccessibilityController): 20288 Initialize new member var. 20289 (AccessibilityController::~AccessibilityController): 20290 Disable logging of value change events. 20291 (logEventProc): 20292 When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object 20293 and its value. 20294 (AccessibilityController::setLogValueChangeEvents): 20295 If disabling logging, unhook the event, and clear the event hook 20296 member var. Otherwise, query for the root element to enable 20297 accessibility, and hook EVENT_OBJECT_VALUECHANGE. 20298 202992010-01-04 Adam Barth <abarth@webkit.org> 20300 20301 Reviewed by Eric Seidel. 20302 20303 long_help for submit-patch 20304 https://bugs.webkit.org/show_bug.cgi?id=33184 20305 20306 * Scripts/webkitpy/commands/upload.py: 20307 203082010-01-04 Adam Barth <abarth@webkit.org> 20309 20310 Reviewed by Eric Seidel. 20311 20312 commit-queue can wrongly reject patches if the buildbots are behind 20313 https://bugs.webkit.org/show_bug.cgi?id=30098 20314 20315 Check to make sure we can currently build and test before trying to 20316 land a patch. 20317 20318 * Scripts/webkitpy/commands/queues.py: 20319 203202010-01-04 Adam Roben <aroben@apple.com> 20321 20322 Add a test harness for the Windows WebKit API, and a few tests 20323 20324 We currently only have tests for a handful of bugs regarding WebView 20325 destruction, but more tests can easily be added later. Eventually 20326 we'll run these tests as part of run-webkit-tests. 20327 20328 Fixes <http://webkit.org/b/33167>. 20329 20330 Reviewed by Sam Weinig. 20331 20332 * WebKitAPITest/HostWindow.cpp: Added. 20333 (WebKitAPITest::HostWindow::HostWindow): Initialize m_window. 20334 (WebKitAPITest::HostWindow::~HostWindow): Destroy our window if 20335 needed. 20336 (WebKitAPITest::HostWindow::initialize): Create our window. 20337 (WebKitAPITest::HostWindow::clientRect): Return our window's client 20338 rect. 20339 (WebKitAPITest::HostWindow::registerWindowClass): Does what it says. 20340 (WebKitAPITest::HostWindow::wndProc): Just call through to 20341 DefWindowProcW. 20342 20343 * WebKitAPITest/HostWindow.h: Added. 20344 (WebKitAPITest::HostWindow::window): Simple getter. 20345 20346 * WebKitAPITest/Test.h: Added. This file defines some macros useful 20347 for writing tests. 20348 20349 * WebKitAPITest/TestsController.cpp: Added. 20350 (WebKitAPITest::TestsController::TestsController): Initialize our 20351 members. 20352 (WebKitAPITest::TestsController::shared): Return the shared instance. 20353 (WebKitAPITest::TestsController::runAllTests): Run a message pump 20354 until a WM_QUIT message is received, then return whether all tests 20355 succeeded. 20356 (WebKitAPITest::TestsController::addTest): Add the test to m_tests and 20357 start running tests soon. 20358 (WebKitAPITest::TestsController::testFailed): Record the failure and 20359 print a message about it to stdout. 20360 (WebKitAPITest::TestsController::runNextTest): If we don't have any 20361 tests to run, post a WM_QUIT message to stop the message pump. 20362 Otherwise, run the test and print whether it passed, then schedule the 20363 next test. 20364 (WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer 20365 to run the next test. 20366 (WebKitAPITest::TestsController::registerWindowClass): Does what it 20367 says. 20368 (WebKitAPITest::TestsController::wndProc): If the runNextTestTimer 20369 fired, call runNextTest(). Pass everything else through to 20370 DefWindowProcW. 20371 20372 * WebKitAPITest/TestsController.h: Added. 20373 20374 * WebKitAPITest/WebKitAPITest.vcproj: Added. 20375 20376 * WebKitAPITest/WebKitAPITestCommon.vsprops: Added. 20377 20378 * WebKitAPITest/main.cpp: Added. 20379 (main): (Mostly) just calls TestsController::runAllTests. 20380 20381 * WebKitAPITest/tests/WebViewDestruction.cpp: Added. 20382 (WebKitAPITest::WebKitCreateInstance): Helper function template to 20383 call through to the real WebKitCreateInstance. 20384 (WebKitAPITest::webViewCount): Helper function to call through to 20385 IWebKitStatistics::webViewCount. 20386 (WebKitAPITest::createWebView): Helper function to create a WebView 20387 and put it inside a HostWindow. 20388 (WebKitAPITest::runMessagePump): Helper function to run a message pump 20389 for a specified number of milliseconds, or until a WM_QUIT message is 20390 received. 20391 (WebKitAPITest::CloseWithoutDestroyWindow): Test for 20392 <http://webkit.org/b/32827>. 20393 (WebKitAPITest::MainFrameAfterClose): Test for 20394 <http://webkit.org/b/32868>. 20395 (WebKitAPITest::NoCloseOrDestroyWindow): Test for 20396 <http://webkit.org/b/33162>. 20397 203982010-01-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 20399 20400 Reviewed by David Kilzer. 20401 20402 Add support for Git's "diff.mnemonicprefix" config option to WebKitTools 20403 20404 https://bugs.webkit.org/show_bug.cgi?id=32820 20405 20406 * Scripts/VCSUtils.pm: 20407 * Scripts/svn-apply: 20408 * Scripts/svn-unapply: 20409 * Scripts/test-webkitperl: Run gitdiff2svndiff test 20410 * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added. 20411 * Scripts/webkitpy/diff_parser.py: 20412 * Scripts/webkitpy/diff_parser_unittest.py: 20413 204142010-01-04 Chris Jerdonek <chris.jerdonek@gmail.com> 20415 20416 Reviewed by David Kilzer. 20417 20418 Divided the Perl unit tests into separate files and put 20419 them in a separate directory, and renamed test-webkit-perl 20420 to test-webkitperl. 20421 20422 https://bugs.webkit.org/show_bug.cgi?id=33124 20423 20424 * Scripts/VCSUtils.pm: 20425 - Renamed generateRunPatchCommand() to generatePatchCommand(). 20426 20427 * Scripts/VCSUtils_unittest.pl: Removed. 20428 - Divided into three files in Scripts/webkitperl/VCSUtils_unittest. 20429 20430 * Scripts/test-webkit-perl: Removed. 20431 - Renamed to test-webkitperl. 20432 20433 * Scripts/test-webkit-scripts: 20434 - Updated paths to test-webkitpy and test-webkitperl. 20435 20436 * Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl. 20437 - Added paths to new test files. 20438 20439 * Scripts/webkitperl: Added. 20440 * Scripts/webkitperl/VCSUtils_unittest: Added. 20441 * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added. 20442 * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added. 20443 * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl. 20444 204452010-01-04 Eric Seidel <eric@webkit.org> 20446 20447 Reviewed by Adam Barth. 20448 20449 Make bugzilla-tool rollout include a bug link in the ChangeLog entry 20450 https://bugs.webkit.org/show_bug.cgi?id=33146 20451 20452 One more step towards better rollouts. 20453 20454 * Scripts/webkitpy/changelogs.py: 20455 * Scripts/webkitpy/changelogs_unittest.py: 20456 * Scripts/webkitpy/steps/preparechangelogforrevert.py: 20457 204582010-01-04 Adam Barth <abarth@webkit.org> 20459 20460 Reviewed by Eric Seidel. 20461 20462 Sort the step options 20463 https://bugs.webkit.org/show_bug.cgi?id=33144 20464 20465 * Scripts/webkitpy/steps/options.py: 20466 204672010-01-04 Eric Seidel <eric@webkit.org> 20468 20469 Reviewed by Adam Barth. 20470 20471 Need support for longer text in per-command help 20472 https://bugs.webkit.org/show_bug.cgi?id=33143 20473 20474 Add some minimal additional help to land-diff and 20475 pave the way for adding better help to all commands. 20476 20477 * Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff 20478 * Scripts/webkitpy/multicommandtool.py: support long_help 20479 * Scripts/webkitpy/multicommandtool_unittest.py: test long_help 20480 204812010-01-04 Adam Barth <abarth@webkit.org> 20482 20483 Reviewed by Eric Seidel. 20484 20485 Add unit test for MarkBugFixed 20486 https://bugs.webkit.org/show_bug.cgi?id=33142 20487 20488 MarkBugFixed is way behind in command technology, but it still needs a 20489 unit test, as the FIXME commands. 20490 20491 Also, remove mark-bug-fixed and create-bug from main help since we have 20492 more modern commands to replace them. 20493 20494 * Scripts/webkitpy/commands/upload.py: 20495 * Scripts/webkitpy/commands/upload_unittest.py: 20496 * Scripts/webkitpy/mock_bugzillatool.py: 20497 204982010-01-04 Adam Barth <abarth@webkit.org> 20499 20500 Reviewed by Eric Seidel. 20501 20502 Add missing unit test for CommitMessageForCurrentDiff 20503 https://bugs.webkit.org/show_bug.cgi?id=33141 20504 20505 * Scripts/webkitpy/commands/upload.py: 20506 * Scripts/webkitpy/commands/upload_unittest.py: 20507 205082010-01-04 Adam Barth <abarth@webkit.org> 20509 20510 Reviewed by Eric Seidel. 20511 20512 Remove raw_input from queues in favor of user.prompt 20513 https://bugs.webkit.org/show_bug.cgi?id=33140 20514 20515 This lets up properly mock out the user interaction instead of hacking 20516 around it with the options. 20517 20518 * Scripts/webkitpy/commands/queues.py: 20519 * Scripts/webkitpy/commands/queuestest.py: 20520 205212010-01-04 Eric Seidel <eric@webkit.org> 20522 20523 Reviewed by Adam Barth. 20524 20525 bugzilla-tool should not require users to install mechanize 20526 https://bugs.webkit.org/show_bug.cgi?id=32635 20527 20528 * Scripts/webkitpy/__init__.py: Add missing declaration for ClientForm (which mechanize requires). 20529 205302010-01-04 Eric Seidel <eric@webkit.org> 20531 20532 Reviewed by Adam Barth. 20533 20534 bugzilla-tool should not require users to install mechanize 20535 https://bugs.webkit.org/show_bug.cgi?id=32635 20536 20537 Use the nifty "autoinstall" module from Daniel Krech: 20538 http://pypi.python.org/pypi/autoinstall/0.2 20539 http://code.google.com/p/pyautoinstall/ 20540 It's available under a WebKit-compatible BSD license. 20541 20542 * Scripts/webkitpy/__init__.py: 20543 - bind "mechanize" to an autoinstall importer which will 20544 auto-download mechanize if necessary. 20545 * Scripts/webkitpy/autoinstall.py: Added. 20546 * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize 20547 * Scripts/webkitpy/statusbot.py: ditto. 20548 * Scripts/webkitpy/webkit_mechanize.py: Removed. 20549 205502010-01-04 Adam Barth <abarth@webkit.org> 20551 20552 Reviewed by Eric Seidel. 20553 20554 [bzt] Move AbstractSequencedCommand to a more general location 20555 https://bugs.webkit.org/show_bug.cgi?id=33137 20556 20557 I do what the FIXME tell me to do. 20558 20559 * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added. 20560 * Scripts/webkitpy/commands/download.py: 20561 * Scripts/webkitpy/commands/upload.py: 20562 205632010-01-04 Adam Barth <abarth@webkit.org> 20564 20565 Reviewed by Eric Seidel. 20566 20567 Rename StatusBot to StatusServer 20568 https://bugs.webkit.org/show_bug.cgi?id=33139 20569 20570 It's not a bot. It's a server. 20571 20572 * Scripts/bugzilla-tool: 20573 * Scripts/webkitpy/bugzilla.py: 20574 * Scripts/webkitpy/commands/early_warning_system.py: 20575 * Scripts/webkitpy/commands/queues.py: 20576 * Scripts/webkitpy/mock_bugzillatool.py: 20577 * Scripts/webkitpy/queueengine.py: 20578 * Scripts/webkitpy/statusbot.py: Removed. 20579 205802010-01-04 Adam Barth <abarth@webkit.org> 20581 20582 Reviewed by Eric Seidel. 20583 20584 [bzt] submit-pach should have a -o/--open option to open the bug after submit 20585 https://bugs.webkit.org/show_bug.cgi?id=33136 20586 20587 Python makes this very easy. 20588 20589 * Scripts/webkitpy/mock_bugzillatool.py: 20590 * Scripts/webkitpy/steps/options.py: 20591 * Scripts/webkitpy/steps/postdiff.py: 20592 * Scripts/webkitpy/user.py: 20593 205942010-01-04 Adam Barth <abarth@webkit.org> 20595 20596 Reviewed by Eric Seidel. 20597 20598 [bzt] Move steps to a submodule 20599 https://bugs.webkit.org/show_bug.cgi?id=33135 20600 20601 For great victory. This will probably introduce some regressions 20602 because our test coverage isn't perfect, but I've tried to be careful. 20603 20604 * Scripts/test-webkitpy: 20605 * Scripts/webkitpy/buildsteps.py: Removed. 20606 * Scripts/webkitpy/buildsteps_unittest.py: Removed. 20607 * Scripts/webkitpy/commands/download.py: 20608 * Scripts/webkitpy/commands/upload.py: 20609 * Scripts/webkitpy/steps/__init__.py: Added. 20610 * Scripts/webkitpy/steps/abstractstep.py: Added. 20611 * Scripts/webkitpy/steps/applypatch.py: Added. 20612 * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added. 20613 * Scripts/webkitpy/steps/build.py: Added. 20614 * Scripts/webkitpy/steps/checkstyle.py: Added. 20615 * Scripts/webkitpy/steps/cleanworkingdirectory.py: Added. 20616 * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added. 20617 * Scripts/webkitpy/steps/closebug.py: Added. 20618 * Scripts/webkitpy/steps/closebugforlanddiff.py: Added. 20619 * Scripts/webkitpy/steps/closepatch.py: Added. 20620 * Scripts/webkitpy/steps/commit.py: Added. 20621 * Scripts/webkitpy/steps/completerollout.py: Added. 20622 * Scripts/webkitpy/steps/confirmdiff.py: Added. 20623 * Scripts/webkitpy/steps/createbug.py: Added. 20624 * Scripts/webkitpy/steps/editchangelog.py: Added. 20625 * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added. 20626 * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added. 20627 * Scripts/webkitpy/steps/metastep.py: Added. 20628 * Scripts/webkitpy/steps/obsoletepatches.py: Added. 20629 * Scripts/webkitpy/steps/options.py: Added. 20630 * Scripts/webkitpy/steps/postdiff.py: Added. 20631 * Scripts/webkitpy/steps/preparechangelog.py: Added. 20632 * Scripts/webkitpy/steps/preparechangelogforrevert.py: Added. 20633 * Scripts/webkitpy/steps/promptforbugortitle.py: Added. 20634 * Scripts/webkitpy/steps/revertrevision.py: Added. 20635 * Scripts/webkitpy/steps/runtests.py: Added. 20636 * Scripts/webkitpy/steps/steps_unittest.py: Added. 20637 * Scripts/webkitpy/steps/update.py: Added. 20638 * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added. 20639 * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added. 20640 * Scripts/webkitpy/stepsequence.py: 20641 206422010-01-04 Daniel Bates <dbates@webkit.org> 20643 20644 Reviewed by Eric Seidel. 20645 20646 https://bugs.webkit.org/show_bug.cgi?id=33097 20647 20648 Cleans up the File menu to better conform to the File menu in Safari 20649 both in terms of options and keyboard shortcuts. Adds a "Quit" menu 20650 options to close all open windows. Also, renames the Tools menu to 20651 Develop. 20652 20653 * QtLauncher/main.cpp: 20654 (MainWindow::setupUI): 20655 206562010-01-04 Daniel Bates <dbates@webkit.org> 20657 20658 https://bugs.webkit.org/show_bug.cgi?id=33039 20659 20660 Unreviewed fix. 20661 20662 * Scripts/webkitpy/credentials.py: 20663 * Scripts/webkitpy/credentials_unittest.py: 20664 206652010-01-04 Daniel Bates <dbates@webkit.org> 20666 20667 Reviewed by Eric Seidel. 20668 20669 https://bugs.webkit.org/show_bug.cgi?id=33039 20670 20671 [bzt] Second attempt to fix an issue where bugzilla-tool dies 20672 when the keychain lookup fails to find an entry for bugs.webkit.org. 20673 20674 * Scripts/webkitpy/credentials.py: 20675 * Scripts/webkitpy/credentials_unittest.py: 20676 206772010-01-04 Eric Seidel <eric@webkit.org> 20678 20679 Reviewed by Adam Barth. 20680 20681 Make Rollout an AbstractSequencedCommmand 20682 https://bugs.webkit.org/show_bug.cgi?id=33133 20683 20684 As suggested by Adam in: 20685 https://bugs.webkit.org/show_bug.cgi?id=33131#c2 20686 20687 * Scripts/webkitpy/commands/download.py: 20688 206892010-01-04 Eric Seidel <eric@webkit.org> 20690 20691 Reviewed by Adam Barth. 20692 20693 Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses 20694 https://bugs.webkit.org/show_bug.cgi?id=33131 20695 20696 Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command 20697 but for now we just deploy it everywhere and don't try to fix up the few valid uses 20698 of Command. 20699 20700 * Scripts/webkitpy/commands/download.py: 20701 * Scripts/webkitpy/commands/queries.py: 20702 * Scripts/webkitpy/commands/upload.py: 20703 * Scripts/webkitpy/multicommandtool.py: 20704 207052010-01-03 Adam Barth <abarth@webkit.org> 20706 20707 Unreviewed "build" fix. Need to import ScriptError. 20708 20709 * Scripts/webkitpy/buildsteps.py: 20710 207112010-01-03 Adam Barth <abarth@webkit.org> 20712 20713 Reviewed by Eric Seidel. 20714 20715 [bzt] Make it easier to run submit-patch when previous run cancelled 20716 https://bugs.webkit.org/show_bug.cgi?id=33070 20717 20718 This patch renames create-review to submit-patch (as requested by 20719 Maciej). 20720 20721 This patch makes it easier to run submit-patch after the user has 20722 already cancelled a previous run of submit-patch by detecting when we 20723 already have ChangeLogs and reading the bug number from them (and not 20724 attempting to recreate them). Aside from performance and the extra 20725 edit step, this command should not subsume post-dif. 20726 20727 Also, added a --email command line argument so that the output of 20728 prepare-ChangeLog makes sense when it can't find the user's email 20729 address. 20730 20731 * Scripts/webkitpy/bugzilla.py: 20732 * Scripts/webkitpy/buildsteps.py: 20733 * Scripts/webkitpy/commands/upload.py: 20734 * Scripts/webkitpy/commands/upload_unittest.py: 20735 * Scripts/webkitpy/mock_bugzillatool.py: 20736 * Scripts/webkitpy/user.py: 20737 207382010-01-03 Eric Seidel <eric@webkit.org> 20739 20740 Reviewed by Adam Barth. 20741 20742 Rename Scripts/modules to Scripts/webkitpy 20743 https://bugs.webkit.org/show_bug.cgi?id=33128 20744 20745 Just search-replace and svn mv commands. 20746 20747 * Scripts/bugzilla-tool: 20748 * Scripts/check-webkit-style: 20749 * Scripts/modules: Removed. 20750 * Scripts/modules/BeautifulSoup.py: Removed. 20751 * Scripts/modules/__init__.py: Removed. 20752 * Scripts/modules/bugzilla.py: Removed. 20753 * Scripts/modules/bugzilla_unittest.py: Removed. 20754 * Scripts/modules/buildbot.py: Removed. 20755 * Scripts/modules/buildbot_unittest.py: Removed. 20756 * Scripts/modules/buildsteps.py: Removed. 20757 * Scripts/modules/buildsteps_unittest.py: Removed. 20758 * Scripts/modules/changelogs.py: Removed. 20759 * Scripts/modules/changelogs_unittest.py: Removed. 20760 * Scripts/modules/commands: Removed. 20761 * Scripts/modules/commands/__init__.py: Removed. 20762 * Scripts/modules/commands/commandtest.py: Removed. 20763 * Scripts/modules/commands/download.py: Removed. 20764 * Scripts/modules/commands/download_unittest.py: Removed. 20765 * Scripts/modules/commands/early_warning_system.py: Removed. 20766 * Scripts/modules/commands/early_warning_system_unittest.py: Removed. 20767 * Scripts/modules/commands/queries.py: Removed. 20768 * Scripts/modules/commands/queries_unittest.py: Removed. 20769 * Scripts/modules/commands/queues.py: Removed. 20770 * Scripts/modules/commands/queues_unittest.py: Removed. 20771 * Scripts/modules/commands/queuestest.py: Removed. 20772 * Scripts/modules/commands/upload.py: Removed. 20773 * Scripts/modules/commands/upload_unittest.py: Removed. 20774 * Scripts/modules/comments.py: Removed. 20775 * Scripts/modules/committers.py: Removed. 20776 * Scripts/modules/committers_unittest.py: Removed. 20777 * Scripts/modules/cpp_style.py: Removed. 20778 * Scripts/modules/cpp_style_unittest.py: Removed. 20779 * Scripts/modules/credentials.py: Removed. 20780 * Scripts/modules/credentials_unittest.py: Removed. 20781 * Scripts/modules/diff_parser.py: Removed. 20782 * Scripts/modules/diff_parser_unittest.py: Removed. 20783 * Scripts/modules/executive.py: Removed. 20784 * Scripts/modules/executive_unittest.py: Removed. 20785 * Scripts/modules/grammar.py: Removed. 20786 * Scripts/modules/mock.py: Removed. 20787 * Scripts/modules/mock_bugzillatool.py: Removed. 20788 * Scripts/modules/multicommandtool.py: Removed. 20789 * Scripts/modules/multicommandtool_unittest.py: Removed. 20790 * Scripts/modules/outputcapture.py: Removed. 20791 * Scripts/modules/patchcollection.py: Removed. 20792 * Scripts/modules/queueengine.py: Removed. 20793 * Scripts/modules/queueengine_unittest.py: Removed. 20794 * Scripts/modules/scm.py: Removed. 20795 * Scripts/modules/scm_unittest.py: Removed. 20796 * Scripts/modules/statusbot.py: Removed. 20797 * Scripts/modules/stepsequence.py: Removed. 20798 * Scripts/modules/style: Removed. 20799 * Scripts/modules/style.py: Removed. 20800 * Scripts/modules/style_unittest.py: Removed. 20801 * Scripts/modules/text_style.py: Removed. 20802 * Scripts/modules/text_style_unittest.py: Removed. 20803 * Scripts/modules/user.py: Removed. 20804 * Scripts/modules/webkit_logging.py: Removed. 20805 * Scripts/modules/webkit_logging_unittest.py: Removed. 20806 * Scripts/modules/webkit_mechanize.py: Removed. 20807 * Scripts/modules/webkitport.py: Removed. 20808 * Scripts/modules/webkitport_unittest.py: Removed. 20809 * Scripts/test-webkit-python: Removed. 20810 * Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python. 20811 * Scripts/validate-committer-lists: 20812 * Scripts/webkitpy: Copied from WebKitTools/Scripts/modules. 20813 * Scripts/webkitpy/bugzilla.py: 20814 * Scripts/webkitpy/bugzilla_unittest.py: 20815 * Scripts/webkitpy/buildbot.py: 20816 * Scripts/webkitpy/buildbot_unittest.py: 20817 * Scripts/webkitpy/buildsteps.py: 20818 * Scripts/webkitpy/buildsteps_unittest.py: 20819 * Scripts/webkitpy/commands/commandtest.py: 20820 * Scripts/webkitpy/commands/download.py: 20821 * Scripts/webkitpy/commands/download_unittest.py: 20822 * Scripts/webkitpy/commands/early_warning_system.py: 20823 * Scripts/webkitpy/commands/early_warning_system_unittest.py: 20824 * Scripts/webkitpy/commands/queries.py: 20825 * Scripts/webkitpy/commands/queries_unittest.py: 20826 * Scripts/webkitpy/commands/queues.py: 20827 * Scripts/webkitpy/commands/queues_unittest.py: 20828 * Scripts/webkitpy/commands/queuestest.py: 20829 * Scripts/webkitpy/commands/upload.py: 20830 * Scripts/webkitpy/commands/upload_unittest.py: 20831 * Scripts/webkitpy/comments.py: 20832 * Scripts/webkitpy/credentials.py: 20833 * Scripts/webkitpy/credentials_unittest.py: 20834 * Scripts/webkitpy/executive.py: 20835 * Scripts/webkitpy/executive_unittest.py: 20836 * Scripts/webkitpy/mock_bugzillatool.py: 20837 * Scripts/webkitpy/multicommandtool.py: 20838 * Scripts/webkitpy/multicommandtool_unittest.py: 20839 * Scripts/webkitpy/queueengine.py: 20840 * Scripts/webkitpy/queueengine_unittest.py: 20841 * Scripts/webkitpy/scm.py: 20842 * Scripts/webkitpy/scm_unittest.py: 20843 * Scripts/webkitpy/statusbot.py: 20844 * Scripts/webkitpy/stepsequence.py: 20845 * Scripts/webkitpy/webkit_logging_unittest.py: 20846 * Scripts/webkitpy/webkitport_unittest.py: 20847 208482010-01-03 Chris Jerdonek <chris.jerdonek@gmail.com> 20849 20850 Reviewed by Eric Seidel. 20851 20852 Added script to test both Perl and Python, and renamed 20853 run-webkit-unittests to test-webkit-python. 20854 20855 https://bugs.webkit.org/show_bug.cgi?id=33045 20856 20857 * Scripts/VCSUtils_unittest.pl: 20858 - Tweaked so it can be run from outside Scripts directory. 20859 20860 * Scripts/run-webkit-unittests: Removed. 20861 - Renamed to test-webkit-python. 20862 20863 * Scripts/test-webkit-perl: 20864 - Tweaked so it can be run from outside Scripts directory. 20865 20866 * Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests. 20867 20868 * Scripts/test-webkit-scripts: Added. 20869 - Runs both test-webkit-perl and test-webkit-python. 20870 208712010-01-03 Adam Barth <abarth@webkit.org> 20872 20873 Reviewed by Eric Seidel. 20874 20875 commit-queue/bugzilla-tool should build both Debug and Release 20876 https://bugs.webkit.org/show_bug.cgi?id=28450 20877 20878 Add a --build-style command that lets the master process tell the child 20879 process to build both debug and release. Eventually we want to teach 20880 the test step to understand this option too, but that's a patch for 20881 another day. 20882 20883 * Scripts/modules/buildsteps.py: 20884 * Scripts/modules/commands/queues.py: 20885 * Scripts/modules/webkitport.py: 20886 * Scripts/modules/webkitport_unittest.py: 20887 208882010-01-03 Jakub Wieczorek <faw217@gmail.com> 20889 20890 Reviewed by Eric Seidel. 20891 20892 [Qt] EventSender: add support for Enter key events 20893 https://bugs.webkit.org/show_bug.cgi?id=33064 20894 20895 Unskip 5 tests that are fixed now. 20896 20897 * DumpRenderTree/qt/EventSenderQt.cpp: 20898 (EventSender::keyDown): 20899 209002010-01-03 Adam Barth <abarth@webkit.org> 20901 20902 Reviewed by Eric Seidel. 20903 20904 [bzt] Add test for previous typo fix 20905 https://bugs.webkit.org/show_bug.cgi?id=33083 20906 20907 A trivial test for a trivial fix, as requested by Eric. 20908 20909 * Scripts/modules/bugzilla_unittest.py: 20910 209112010-01-03 Adam Barth <abarth@webkit.org> 20912 20913 Reviewed by Eric Seidel. 20914 20915 Implement mac-ews 20916 https://bugs.webkit.org/show_bug.cgi?id=33072 20917 20918 The mac-ews is slightly different than the other early warning systems 20919 because we can't run Mac OS X inside a VM. For that reason, we only 20920 process patches that were uploaded by committers. This isn't as much 20921 coverage as the other EWS bots, but it's better than nothing. 20922 20923 * Scripts/modules/commands/early_warning_system.py: 20924 * Scripts/modules/commands/early_warning_system_unittest.py: 20925 * Scripts/modules/commands/queues.py: 20926 * Scripts/modules/commands/queuestest.py: 20927 * Scripts/modules/mock_bugzillatool.py: 20928 209292010-01-03 Chris Jerdonek <chris.jerdonek@gmail.com> 20930 20931 Reviewed by David Kilzer. 20932 20933 Refactored svn-apply and svn-unapply to use a common "patch" 20934 command method, and added unit tests for this new method. 20935 20936 https://bugs.webkit.org/show_bug.cgi?id=33098 20937 20938 * Scripts/VCSUtils.pm: 20939 - Added generateRunPatchCommand(). 20940 - Added runPatchCommand(). 20941 - Added exitStatus() from webkitdirs.pm to address FIXME. 20942 20943 * Scripts/VCSUtils_unittest.pl: 20944 - Added 10 unit tests for generateRunPatchCommand(). 20945 - Added 4 unit tests for runPatchCommand(). 20946 - Added callSilently() method. 20947 20948 * Scripts/svn-apply: 20949 - Refactored applyPatch(). 20950 - Removed $pathScriptWasRunFrom global variable. 20951 - Addressed issue where "--force" option was getting added twice. 20952 20953 * Scripts/svn-unapply: 20954 - Refactored applyPatch(). 20955 - Removed $pathScriptWasRunFrom global variable. 20956 - Added support for --force option. 20957 - Enhanced to return meaningful exit status. 20958 20959 * Scripts/webkitdirs.pm: 20960 - Moved exitStatus() implementation to VCSUtils.pm. 20961 209622009-12-31 Adam Barth <abarth@webkit.org> 20963 20964 Reviewed by Eric Seidel. 20965 20966 [bzt] Implement build-and-test 20967 https://bugs.webkit.org/show_bug.cgi?id=33073 20968 20969 Some of the early warning system bots want to use build-and-test so 20970 they can cover LayoutTests in addition to just compilation. 20971 20972 * Scripts/modules/commands/download.py: 20973 * Scripts/modules/commands/download_unittest.py: 20974 209752009-12-31 Adam Barth <abarth@webkit.org> 20976 20977 Reviewed by Eric Seidel. 20978 20979 Show mac-ews status on QueueStatusServer 20980 https://bugs.webkit.org/show_bug.cgi?id=33076 20981 20982 Also make error status purple. 20983 20984 * QueueStatusServer/model/attachment.py: 20985 * QueueStatusServer/model/queues.py: 20986 * QueueStatusServer/templates/dashboard.html: 20987 * QueueStatusServer/templates/statusbubble.html: 20988 209892009-12-31 Adam Barth <abarth@webkit.org> 20990 20991 Unreviewed. 20992 20993 [bzt] REGRESSION: Bugzila is a typo 20994 https://bugs.webkit.org/show_bug.cgi?id=33074 20995 20996 Eric should test his code before landing! :) 20997 20998 * Scripts/modules/bugzilla.py: 20999 210002009-12-31 Adam Barth <abarth@webkit.org> 21001 21002 Unreviewed. Fix the unit tests! 21003 21004 * Scripts/run-webkit-unittests: 21005 210062009-12-30 Kevin Watters <kevinwatters@gmail.com> 21007 21008 Reviewed by Kevin Ollivier. 21009 21010 [wx] Alter a couple of default settings in the test app. 21011 21012 https://bugs.webkit.org/show_bug.cgi?id=32956 21013 21014 * wx/browser/browser.cpp: 21015 (MyApp::OnInit): 21016 210172009-12-30 Eric Seidel <eric@webkit.org> 21018 21019 Reviewed by Adam Barth. 21020 21021 logging.py should be renamed to webkit_logging.py and eventually die 21022 https://bugs.webkit.org/show_bug.cgi?id=33058 21023 21024 Change all imports of "logging" to webkit_logging, 21025 except the ones which came from Google's cpp_lint.py and diff_parser.py 21026 which clearly are assuming python's logging.py. 21027 21028 * Scripts/modules/bugzilla.py: 21029 * Scripts/modules/buildbot.py: 21030 * Scripts/modules/buildsteps.py: 21031 * Scripts/modules/commands/download.py: 21032 * Scripts/modules/commands/queries.py: 21033 * Scripts/modules/commands/queues.py: 21034 * Scripts/modules/commands/upload.py: 21035 * Scripts/modules/credentials.py: 21036 * Scripts/modules/executive.py: 21037 * Scripts/modules/multicommandtool.py: 21038 * Scripts/modules/queueengine.py: 21039 * Scripts/modules/scm.py: 21040 * Scripts/modules/statusbot.py: 21041 * Scripts/modules/stepsequence.py: 21042 * Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py. 21043 * Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py. 21044 210452009-12-30 Jakub Wieczorek <faw217@gmail.com> 21046 21047 Reviewed by Simon Hausmann. 21048 21049 [Qt] layoutTestController.pathToLocalResource() should return a path, not an URL 21050 https://bugs.webkit.org/show_bug.cgi?id=33051 21051 21052 Moreover, its primary function is to normalize the path in regard of platform 21053 specific directory separators. Therefore, it can simply make use of the 21054 QDir::toNativeSeparators function. 21055 21056 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 21057 (LayoutTestController::pathToLocalResource): 21058 210592009-12-30 David D. Kilzer <ddkilzer@webkit.org> 21060 21061 Fix executable bits for r52646 21062 21063 * Scripts/VCSUtils_unittest.pl: Added property svn:executable. 21064 * Scripts/test-webkit-perl: Ditto. 21065 210662009-12-29 Chris Jerdonek <chris.jerdonek@gmail.com> 21067 21068 Reviewed by David Kilzer. 21069 21070 Fixed a bug in fixChangeLogPatch, made it work correctly in 21071 more circumstances, and added unit tests. 21072 21073 https://bugs.webkit.org/show_bug.cgi?id=32919 21074 21075 * Scripts/VCSUtils.pm: 21076 Rewrote fixChangeLogPatch. 21077 21078 * Scripts/VCSUtils_unittest.pl: Added. 21079 Added 7 unit tests for fixChangeLogPatch. 21080 21081 * Scripts/test-webkit-perl: Added. 21082 Added test harness for unit tests of Perl code. 21083 210842009-12-29 Eric Seidel <eric@webkit.org> 21085 21086 Reviewed by Adam Barth. 21087 21088 Split out BugzillaQueries class from Bugzilla 21089 https://bugs.webkit.org/show_bug.cgi?id=33042 21090 21091 * Scripts/modules/bugzilla.py: 21092 - Split out BugzillaQueries from Bugzilla. 21093 - Try to isolate self.bugzilla usage into helper functions whenever possible. 21094 - Add a bunch of FIXMEs. 21095 - Rename fetch_bug_ids_from_needs_commit_list to fetch_bug_ids_from_pending_commit_list 21096 * Scripts/modules/bugzilla_unittest.py: 21097 - Create a new BugzillaQueriesTest testcase and move logic there. 21098 * Scripts/modules/buildsteps_unittest.py: 21099 - Use Bug 75 instead of 1 since bug 1 doesn't actually exist. 21100 * Scripts/modules/commands/queries.py: 21101 - Update to use bugzilla.queries 21102 * Scripts/modules/commands/queues.py: 21103 - Ditto. 21104 * Scripts/modules/commands/upload.py: 21105 - Ditto. 21106 * Scripts/modules/mock_bugzillatool.py: 21107 - Add a MockBugzillaQueries. 21108 - Make patches and bugs global privates. 21109 - Let _id_to_object_dictionary take a variable argument list instead of an array. 21110 211112009-12-29 Daniel Bates <dbates@webkit.org> 21112 21113 Reviewed by Eric Seidel. 21114 21115 https://bugs.webkit.org/show_bug.cgi?id=33041 21116 21117 Speed up the test method test_read_credentials_with_SVN by not actually 21118 creating an SVN repository to test against (by default). Instead, it is 21119 sufficient to create a temporary directory that does not contain a Git 21120 repository. 21121 21122 Also, renamed method test_read_credentials_with_SVN to 21123 test_read_credentials_without_git_repo, to better reflect what it is 21124 testing. 21125 21126 * Scripts/modules/credentials_unittest.py: 21127 211282009-12-29 Daniel Bates <dbates@webkit.org> 21129 21130 Reviewed by Adam Barth. 21131 21132 https://bugs.webkit.org/show_bug.cgi?id=33039 21133 21134 [bzt] Fixes an issue where bugzilla-tool dies when the keychain lookup 21135 fails to find an entry for bugs.webkit.org. 21136 21137 Under Mac OS X, bugzilla-tool tries to query the keychain and Security 21138 framework (via /usr/sbin/security) for an internet-password entry for 21139 bugs.webkit.org so that it can use it to login to bugs.webkit.org. 21140 However, if no such entry exists then bugzilla-tool dies with an error. 21141 21142 * Scripts/modules/credentials.py: Modified method _parse_security_tool_output to return 21143 [None, None] if /usr/sbin/security cannot find keychain entry for bugs.webkit.org. 21144 * Scripts/modules/credentials_unittest.py: Added method test_security_output_parse_entry_not_found. 21145 211462009-12-29 Eric Seidel <eric@webkit.org> 21147 21148 Rubber-stamped by Adam Barth. 21149 21150 Remove unused BugzillaException. 21151 21152 * Scripts/modules/bugzilla.py: 21153 211542009-12-29 Eric Seidel <eric@webkit.org> 21155 21156 Reviewed by Adam Barth. 21157 21158 Need a script to assign bugs with r+ patches to committers for landing 21159 https://bugs.webkit.org/show_bug.cgi?id=33009 21160 21161 This is just one more small tool to help in the fight against our 21162 ever-growing list of to-be-committed patches. 21163 21164 * Scripts/modules/bugzilla.py: 21165 - Rename assign_to_email to assigned_to_email (typo). 21166 - Add assigned_to_email() method on Bug. 21167 - Add reassign_bug method. 21168 - Add Bugzilla.unassigned_email, eventually should move to some webkit_config.py module. 21169 * Scripts/modules/bugzilla_unittest.py: 21170 - Update test after assigned_to_email rename. 21171 * Scripts/modules/commands/commandtest.py: 21172 - Call bind_to_tool to that self.tool works in Command testing. 21173 * Scripts/modules/commands/download.py: 21174 - Move AbstractDeclarativeCommmand multicommandtool.py, it should be part of Command. 21175 * Scripts/modules/commands/queries_unittest.py: 21176 - One of the test patches is now posted by "eric@webkit.org" which is a committer. 21177 - Eventually we'll mock out CommitterList and be able to better control what's a committer and what's not. 21178 * Scripts/modules/commands/upload.py: 21179 - Add new assign-to-committer command. 21180 * Scripts/modules/commands/upload_unittest.py: 21181 - Add basic assign-to-committer test. 21182 * Scripts/modules/committers.py: 21183 - Add bugzilla_email() accessor. 21184 * Scripts/modules/committers_unittest.py: 21185 - Test our assumption that bugzilla_email is the first email. 21186 * Scripts/modules/mock_bugzillatool.py: 21187 - Add _id_to_object_dictionary for generating bug_cache from list of bugs. 21188 - Remove unused fetch_attachments_from_bug. 21189 - Add fetch_bug support and a bug_cache. 21190 * Scripts/modules/multicommandtool.py: 21191 - Move AbstractDeclarativeCommmand here from download.py 21192 211932009-12-29 Adam Barth <abarth@webkit.org> 21194 21195 Reviewed by Eric Seidel. 21196 21197 [bzt] Don't crash if user types a number during PromptForBugOrTitleStep 21198 https://bugs.webkit.org/show_bug.cgi?id=33038 21199 21200 Simple fix with test. 21201 21202 * Scripts/modules/buildsteps.py: 21203 * Scripts/modules/buildsteps_unittest.py: 21204 212052009-12-29 Adam Barth <abarth@webkit.org> 21206 21207 Reviewed by Eric Seidel. 21208 21209 [bzt] post-diff requires reading to the end 21210 https://bugs.webkit.org/show_bug.cgi?id=33036 21211 21212 Catch the IOError caused by not reading to the end of the diff. We 21213 don't have a good way to test this currently. 21214 21215 * Scripts/modules/user.py: 21216 212172009-12-29 Chang Shu <Chang.Shu@nokia.com> 21218 21219 Reviewed by Adam Barth. 21220 21221 [Qt] Move logic that handles Qt headers before primary headers 21222 so that Qt headers won't be treated as primary headers by mistake. 21223 https://bugs.webkit.org/show_bug.cgi?id=32991 21224 21225 * Scripts/modules/cpp_style.py: 21226 * Scripts/modules/cpp_style_unittest.py: 21227 212282009-12-29 Eric Seidel <eric@webkit.org> 21229 21230 Reviewed by Adam Barth. 21231 21232 Add the start of a Bug object for bugzilla.py 21233 https://bugs.webkit.org/show_bug.cgi?id=32995 21234 21235 This allowed us to get rid of some duplicated "is_obsolete" checks. 21236 21237 * Scripts/modules/bugzilla.py: 21238 - Add a new Bug class, and move patches/unreviewed_patches filtering logic there. 21239 - Add _fetch_bug_page for possible future mocking. 21240 (I did not try to test fetch_*_from_bug now due to difficulties with our current validate_reviewer logic.) 21241 - Rename fetch_bug to fetch_bug_dictionary and add a new fetch_bug which returns a Bug object. 21242 - Use fetch_bug and attachments(), patches(), etc. instead of custom fetch_*_from_bug methods. 21243 - Reduce code in fetch_patches_from_pending_commit_list and fetch_patches_from_review_queue 21244 using list comprehensions. Use a sum(list, []) trick to flatten a list of lists into a single list. 21245 * Scripts/modules/bugzilla_unittest.py: 21246 - Remove an unneeded unicode string marker. 21247 * Scripts/modules/buildsteps.py: 21248 - define __all__ to include just the BuildSteps 21249 * Scripts/modules/commands/download.py: 21250 - import * now that we have an __all__ defined. 21251 * Scripts/modules/commands/upload.py: 21252 - Use fetch_bug_dictionary instead of fetch_bug. 21253 212542009-12-29 Daniel Bates <dbates@webkit.org> 21255 21256 Reviewed by Ariya Hidayat. 21257 21258 https://bugs.webkit.org/show_bug.cgi?id=32925 21259 21260 Adds an Open File dialog to make it convenient to open a file 21261 to view in the browser. 21262 21263 Currently a person must either specify the path to a file as a 21264 command-line argument or type a file URL. Instead, we should 21265 have a file dialog to allow a person to open a file without 21266 memorizing its path. 21267 21268 * QtLauncher/main.cpp: 21269 (MainWindow::MainWindow): Changed urlEdit->setText(qurl.toEncoded()) 21270 to urlEdit->setText(qurl.toString()). 21271 (MainWindow::openFile): Added. 21272 (MainWindow::changeLocation): Moved code to load URL into method 21273 MainWindow::loadURL. 21274 (MainWindow::loadURL): Added. 21275 (MainWindow::setupUI): Added menu item Open File. 21276 212772009-12-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 21278 21279 Reviewed by Holger Freyther. 21280 21281 [GTK] fails fast/harness/use-page-cache.html 21282 https://bugs.webkit.org/show_bug.cgi?id=33013 21283 21284 Make sure settings are forwarded to child WebViews. 21285 21286 * DumpRenderTree/gtk/DumpRenderTree.cpp: 21287 (createWebView): 21288 212892009-12-29 Daniel Bates <dbates@webkit.org> 21290 21291 Reviewed by Eric Seidel. 21292 21293 https://bugs.webkit.org/show_bug.cgi?id=32778 21294 21295 Changes $diffPercentage to be a number to resolve Perl 21296 warning about comparing a string to a number. 21297 21298 * Scripts/run-webkit-tests: 21299 213002009-12-29 Jakub Wieczorek <faw217@gmail.com> 21301 21302 Reviewed by Eric Seidel. 21303 21304 [Qt] DRT: Frame loader callbacks differ from the Mac port 21305 https://bugs.webkit.org/show_bug.cgi?id=32989 21306 21307 Remove messages from the callbacks that should not dump them to match 21308 the expected results for the http/loading tests. 21309 21310 Unskip some http/loading tests which succeed now. 21311 21312 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 21313 (WebCore::DumpRenderTree::dump): 21314 213152009-12-29 Robert Hogan <robert@roberthogan.net> 21316 21317 Reviewed by Eric Seidel. 21318 21319 [Qt] fix fast/dom/Window/window-onFocus.html 21320 21321 Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where 21322 window.onblur was getting dispatched twice from QtWebKit. 21323 21324 https://bugs.webkit.org/show_bug.cgi?id=32990 21325 21326 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 21327 (WebCore::DumpRenderTree::DumpRenderTree): 21328 (WebCore::DumpRenderTree::switchFocus): 21329 * DumpRenderTree/qt/DumpRenderTreeQt.h: 21330 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 21331 (LayoutTestController::setWindowIsKey): 21332 (LayoutTestController::setMainFrameIsFirstResponder): 21333 * DumpRenderTree/qt/LayoutTestControllerQt.h: 21334 213352009-12-28 Kinuko Yasuda <kinuko@chromium.org> 21336 21337 Reviewed by Maciej Stachowiak. 21338 21339 Extended EventSender.keyDown method to take another (3rd) argument 21340 for indicating the keyLocation to make numeric pad key events testable. 21341 Expected values for the argument is one of the KeyLocationCode 21342 specified in DOM Level 3 21343 (http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents). 21344 https://bugs.webkit.org/show_bug.cgi?id=28247 21345 21346 Test: fast/events/keydown-numpad-keys.html 21347 21348 * DumpRenderTree/mac/EventSendingController.mm: 21349 (+[EventSendingController isSelectorExcludedFromWebScript:]): 21350 (+[EventSendingController webScriptNameForSelector:]): 21351 (-[EventSendingController keyDown:withModifiers:withLocation:]): 21352 213532009-12-28 Ariya Hidayat <ariya.hidayat@gmail.com> 21354 21355 Unreviewed, update my email address. 21356 21357 * Scripts/modules/committers.py: 21358 213592009-12-28 Laszlo Gombos <laszlo.1.gombos@nokia.com> 21360 21361 Reviewed by Adam Barth. 21362 21363 [Qt] Fix build break for Qt 4.4 21364 https://bugs.webkit.org/show_bug.cgi?id=30327 21365 21366 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Include QLocale 21367 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Ditto. 21368 * QtLauncher/main.cpp: 21369 (MainWindow::MainWindow): Qt::WA_TranslucentBackground was 21370 introduced in Qt version 4.5 21371 213722009-12-28 Adam Barth <abarth@webkit.org> 21373 21374 Reviewed by Eric Seidel. 21375 21376 [bzt] Add an edit-changelog command 21377 https://bugs.webkit.org/show_bug.cgi?id=32986 21378 21379 This command makes it easier to edit ChangeLogs. It's similar to 21380 prepare-ChangeLog -o, except it works with already existing ChangeLogs. 21381 21382 * Scripts/modules/commands/upload.py: 21383 * Scripts/modules/commands/upload_unittest.py: 21384 213852009-12-28 Adam Barth <abarth@webkit.org> 21386 21387 Reviewed by Eric Seidel. 21388 21389 [bzt] Create an ASAD command for uploading a patch 21390 https://bugs.webkit.org/show_bug.cgi?id=32979 21391 21392 The create-review command goes through the whole process of preparing a 21393 code review, including creating a bug, editing the ChangeLogs, and 21394 uploading the patch. It is indeed the All Sing, All Dance upload 21395 command. 21396 21397 * Scripts/modules/buildsteps.py: 21398 * Scripts/modules/commands/upload.py: 21399 * Scripts/modules/commands/upload_unittest.py: 21400 * Scripts/modules/mock_bugzillatool.py: 21401 * Scripts/modules/user.py: 21402 214032009-12-28 Adam Barth <abarth@webkit.org> 21404 21405 Unreviewed "build" fix (with test!). 21406 21407 * Scripts/modules/bugzilla.py: 21408 * Scripts/modules/bugzilla_unittest.py: 21409 214102009-12-27 Eric Seidel <eric@webkit.org> 21411 21412 Reviewed by Adam Barth. 21413 21414 Add more awesome bug-parsing logic to bugzilla.py in preparation for assign-to-committer command 21415 https://bugs.webkit.org/show_bug.cgi?id=32980 21416 21417 * Scripts/modules/bugzilla.py: 21418 - Add a new _parse_bug_page function and use it in fetch_attachments_from_bug 21419 - Replace fetch_title_from_bug with a new fetch_bug call instead. 21420 - Use list comprehensions where possible to reduce code duplication. 21421 * Scripts/modules/bugzilla_unittest.py: 21422 - Add a minimal bug parsing test. 21423 - Share code between bug parsing and attachment parsing tests with _assert_dictionaries_equal 21424 * Scripts/modules/commands/upload.py: 21425 - Use fetch_bug(bug_id)["title"] instead of fetch_title_from_bug 21426 214272009-12-27 Adam Barth <abarth@webkit.org> 21428 21429 Reviewed by Eric Seidel. 21430 21431 Status bubble shouldn't be transparent for bots that haven't run yet 21432 https://bugs.webkit.org/show_bug.cgi?id=32977 21433 21434 * QueueStatusServer/templates/statusbubble.html: 21435 214362009-12-27 Adam Barth <abarth@webkit.org> 21437 21438 Reviewed by Eric Seidel. 21439 21440 [QueueStatusServer] Run gc cron job less often 21441 https://bugs.webkit.org/show_bug.cgi?id=32958 21442 21443 Now that we've cleaned out the backlog of idle messages, we don't need 21444 to run the gc job every half hour. We could also stop logging the idle 21445 messages, but this seems easier for the time being. 21446 21447 * QueueStatusServer/cron.yaml: 21448 214492009-12-27 Daniel Bates <dbates@webkit.org> 21450 21451 Reviewed by Adam Barth. 21452 21453 https://bugs.webkit.org/show_bug.cgi?id=32896 21454 21455 Fixes an issue where bugzilla-tool tries to read the username and password from 21456 Git regardless of whether Git is installed. In particular, if Git is not 21457 installed then bugzilla-tool dies (with a trace) when it attempts to query Git 21458 for the authentication credentials to log into bugs.webkit.org. 21459 21460 Moreover, modifies Executive.run_command to catch and pass OSError exceptions to 21461 the specified error handler. For instance, the specified error handler will now 21462 be called when the command does not exist (i.e. OSError errno 2). 21463 21464 * Scripts/modules/credentials.py: Added check for Git. 21465 * Scripts/modules/credentials_unittest.py: Added test method 21466 test_read_credentials_with_SVN. 21467 * Scripts/modules/executive.py: Modified method run_command to catch 21468 OSError exceptions (i.e [Errno 2] No such file or directory) and call 21469 the specified error handler. 21470 * Scripts/modules/executive_unittest.py: Added. 21471 * Scripts/run-webkit-unittests: Added import executive_unittest.py. 21472 214732009-12-27 Daniel Bates <dbates@webkit.org> 21474 21475 Unreviewed. Added missing file style_unittest.py that wasn't committed 21476 in change set 52541 (http://trac.webkit.org/changeset/52541) as part of 21477 the patch for bug #32592. 21478 21479 * Scripts/modules/style_unittest.py: Added. 21480 214812009-12-27 Daniel Bates <dbates@webkit.org> 21482 21483 Reviewed by Eric Seidel. 21484 21485 https://bugs.webkit.org/show_bug.cgi?id=32964 21486 21487 [bzt] Updated the unit test based on the change made in bug #32951. 21488 21489 The change made in bug #32951 added the command-line argument: 21490 --makeargs="-j8" to the build-webkit command. However, the associated 21491 unit test was not updated. 21492 21493 * Scripts/modules/webkitport_unittest.py: 21494 214952009-12-27 Yael Aharon <yael.aharon@nokia.com> 21496 21497 Reviewed by Darin Adler. 21498 21499 check-webkit-style should not mark moc files inclusion as errors 21500 https://bugs.webkit.org/show_bug.cgi?id=32669 21501 21502 Add a new header type for moc files, and skip them when checking the order of header files. 21503 21504 * Scripts/modules/cpp_style.py: 21505 215062009-12-26 Adam Barth <abarth@webkit.org> 21507 21508 Reviewed by Eric Seidel. 21509 21510 [bzt] Make the qt build go fast 21511 https://bugs.webkit.org/show_bug.cgi?id=32951 21512 21513 Make use of multiple cores, if available. 21514 21515 * Scripts/modules/webkitport.py: 21516 215172009-12-25 Daniel Bates <dbates@rim.com> 21518 21519 Reviewed by Eric Seidel. 21520 21521 https://bugs.webkit.org/show_bug.cgi?id=32682 21522 21523 Fixes an issue where checkFrameworks always dies with an error under Windows 21524 since the clause "unless (-x $path)" is always satisfied because files under 21525 Windows do not have an explict executable bit. 21526 21527 * Scripts/webkitdirs.pm: 21528 215292009-12-23 Eric Seidel <eric@webkit.org> 21530 21531 Reviewed by Adam Barth. 21532 21533 bugzilla-tool should accept global options anywhere 21534 https://bugs.webkit.org/show_bug.cgi?id=26912 21535 21536 * Scripts/bugzilla-tool: 21537 - Use the new global_options class property. 21538 - Add a handle_global_options callback to avoid needing callbacks for each global option. 21539 * Scripts/modules/multicommandtool.py: 21540 - Make the code use one combined option parser. 21541 This allows us to accept global options anywhere and 21542 individual command options before commands. 21543 - Add a handle_global_options callback to avoid needing callbacks for each global option. 21544 - Make the Command hold the option parser, but allow the tool to override it. 21545 - The default option parser is used for help printing and when Commands are run stand alone, 21546 but are otherwise not used. 21547 - Add Command.main to codify the idea that Commands should support being run stand-alone. 21548 - Change _split_args to _split_command_name_from_args now that args are unified. 21549 * Scripts/modules/multicommandtool_unittest.py: 21550 - Test that "tool" and "tool help" show the same help. 21551 - Test that args are accepted before commands 21552 215532009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com> 21554 21555 Reviewed by David Levin. 21556 21557 Moved some sections of code in preparation to refactor 21558 check-webkit-style's argument parser to avoid setting 21559 global variables. 21560 21561 https://bugs.webkit.org/show_bug.cgi?id=32592 21562 21563 * Scripts/check-webkit-style: 21564 - Moved _USAGE string to style.py. 21565 - Addressed FIXME by eliminating dependencies on cpp_style.py. 21566 21567 * Scripts/modules/cpp_style.py: 21568 - Moved default arguments and style categories to style.py. 21569 - Moved exit_with_usage(), exit_with_categories(), and 21570 parse_arguments() to style.py. 21571 - Removed references in _CppStyleState to the global 21572 variables now in style.py. 21573 21574 * Scripts/modules/cpp_style_unittest.py: 21575 - Moved parse_arguments() unit tests to style_unittest.py. 21576 21577 * Scripts/modules/style.py: 21578 - Added _USAGE string from check-webkit-style. 21579 - Added default arguments and style categories from cpp_style.py. 21580 - Added exit_with_usage(), exit_with_categories(), and 21581 parse_arguments() from cpp_sstyle.py. 21582 21583 * Scripts/modules/style_unittest.py: Added. 21584 - Added parse_arguments() unit tests from cpp_style_unittest.py. 21585 21586 * Scripts/run-webkit-unittests: 21587 - Added unit tests from style_unittest.py. 21588 215892009-12-23 Eric Seidel <eric@webkit.org> 21590 21591 Reviewed by Adam Barth. 21592 21593 commit-queue should mention bug 30084 when rejecting patches until it can be fixed 21594 https://bugs.webkit.org/show_bug.cgi?id=32911 21595 21596 * Scripts/modules/bugzilla.py: Make the message even more fancy. 21597 * Scripts/modules/bugzilla_unittest.py: Test our new fancy message. 21598 215992009-12-23 Laszlo Gombos <laszlo.1.gombos@nokia.com> 21600 21601 Not reviewed, adding myself to the reviewers list. 21602 21603 * Scripts/modules/committers.py: 21604 216052009-12-23 Adam Barth <abarth@webkit.org> 21606 21607 Reviewed by Eric Seidel. 21608 21609 [bzt] Create a prepare-diff command that creates a bug and a ChangeLog 21610 https://bugs.webkit.org/show_bug.cgi?id=32895 21611 21612 The workflow Maciej and I discussed is as follows: 21613 21614 1) Write code. 21615 2) bugzilla-tool prepare-diff 21616 3) Edit ChangeLogs 21617 4) bugzilla-tool post-diff 21618 21619 We might want to experimenting with combining 2-4 into a single 21620 command, but that might be stressful to edit the ChangeLogs modally. 21621 21622 Removed submit-patch since it has the modal ChangeLog editing but none 21623 oof the bug creating fun. 21624 21625 * Scripts/modules/bugzilla.py: 21626 * Scripts/modules/buildsteps.py: 21627 * Scripts/modules/commands/upload.py: 21628 * Scripts/modules/commands/upload_unittest.py: 21629 216302009-12-23 Gabor Loki <loki@webkit.org> 21631 21632 Unreviewed; added myself to the committers list. 21633 21634 * Scripts/modules/committers.py: 21635 216362009-12-22 Adam Barth <abarth@webkit.org> 21637 21638 Reviewed by Maciej Stachowiak. 21639 21640 [bzt] Don't call create-patch twice during post-diff 21641 https://bugs.webkit.org/show_bug.cgi?id=32893 21642 21643 If we call create-patch to get the bug number, cache the diff in the 21644 state so we don't need to call it again. 21645 21646 * Scripts/modules/buildsteps.py: 21647 * Scripts/modules/commands/upload.py: 21648 216492009-12-22 Daniel Bates <dbates@rim.com> 21650 21651 Reviewed by Eric Seidel. 21652 21653 https://bugs.webkit.org/show_bug.cgi?id=32680 21654 21655 Fixes an issue in builtDylibPathForName so that it returns the correct 21656 path to the built QtWebKit library on the Qt Windows port. Currently, 21657 it returns the path to the file named QtWebKit.dll but this file does 21658 not exist on the Qt Windows build. Instead, the file is named 21659 QtWebKit4.dll. 21660 21661 * Scripts/webkitdirs.pm: 21662 216632009-12-22 Marc-Antoine Ruel <maruel@chromium.org> 21664 21665 Reviewed by Adam Roben. 21666 21667 Remove the only dependency on perl-libwin32 in cygwin 21668 21669 * Scripts/num-cpus: 21670 216712009-12-22 Darin Adler <darin@apple.com> 21672 21673 * pywebsocket/mod_pywebsocket: Added property svn:ignore to ignore 21674 generated ".pyc" files. 21675 216762009-12-22 Darin Adler <darin@apple.com> 21677 21678 Reviewed by Mark Rowe. 21679 21680 Turn off datagrid by default, at least for all platforms Apple ships. 21681 The datagrid implementation isn't ready for general web use yet. 21682 21683 * Scripts/build-webkit: Turn off datagrid by default. 21684 216852009-12-22 Eric Seidel <eric@webkit.org> 21686 21687 Reviewed by Darin Adler. 21688 21689 validate-committer-lists fails when run from an SVN checkout 21690 https://bugs.webkit.org/show_bug.cgi?id=31974 21691 21692 * Scripts/validate-committer-lists: 21693 - Make it print a warning message instead of throwing 21694 an exception when running from an SVN checkout. 21695 216962009-12-22 Philippe Normand <pnormand@igalia.com> 21697 21698 Reviewed by Adam Barth. 21699 21700 check-webkit-style should not warn about NULL usage in g_object_{get,set} 21701 https://bugs.webkit.org/show_bug.cgi?id=32858 21702 21703 * Scripts/modules/cpp_style.py: 21704 * Scripts/modules/cpp_style_unittest.py: 21705 217062009-12-22 Simon Hausmann <simon.hausmann@nokia.com> 21707 21708 Rubber-stamped by Holger Freyther. 21709 21710 Moved QtLauncher from WebKit/qt. 21711 21712 * QtLauncher: Copied from WebKit/qt/QtLauncher. 21713 * QtLauncher/QtLauncher.pro: 21714 217152009-12-21 Adam Barth <abarth@webkit.org> 21716 21717 Reviewed by Eric Seidel. 21718 21719 [bzt] Automate the process of calling prepare-ChangeLog 21720 https://bugs.webkit.org/show_bug.cgi?id=32816 21721 21722 This patch automates the process of creating a bug and patch and 21723 uploading it to bugzilla. The first cut just calls 21724 prepare-ChangeLog. 21725 21726 This patch required some refactoring of upload.py to the Step 21727 model, but that's worth doing anyway. 21728 21729 * Scripts/bugzilla-tool: 21730 * Scripts/modules/buildsteps.py: 21731 * Scripts/modules/commands/download.py: 21732 * Scripts/modules/commands/upload.py: 21733 * Scripts/modules/commands/upload_unittest.py: 21734 * Scripts/modules/mock_bugzillatool.py: 21735 217362009-12-21 Darin Adler <darin@apple.com> 21737 21738 * Scripts/do-webcore-rename: Did a rename, so checking in the 21739 version of the script I used. 21740 217412009-12-21 Adam Barth <abarth@webkit.org> 21742 21743 Reviewed by Eric Seidel. 21744 21745 Update status-bubble to show all the queues 21746 https://bugs.webkit.org/show_bug.cgi?id=32838 21747 21748 Also, move statusbubble over to use memcache. 21749 21750 * QueueStatusServer/handlers/statusbubble.py: 21751 * QueueStatusServer/templates/statusbubble.html: 21752 217532009-12-21 Adam Barth <abarth@webkit.org> 21754 21755 Reviewed by Eric Seidel. 21756 21757 Delete the boring "Empty queue" status messages in QueueStatusServer 21758 https://bugs.webkit.org/show_bug.cgi?id=32818 21759 21760 * QueueStatusServer/app.yaml: 21761 * QueueStatusServer/cron.yaml: 21762 * QueueStatusServer/handlers/gc.py: 21763 * QueueStatusServer/main.py: 21764 217652009-12-21 Adam Barth <abarth@webkit.org> 21766 21767 Reviewed by Eric Seidel. 21768 21769 Exception on queue status server 21770 https://bugs.webkit.org/show_bug.cgi?id=32812 21771 21772 Turns out we need to pass the id to the filter. 21773 21774 * QueueStatusServer/filters/webkit_extras.py: 21775 * QueueStatusServer/templates/patch.html: 21776 * QueueStatusServer/templates/recentstatus.html: 21777 217782009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com> 21779 21780 Reviewed by Eric Seidel. 21781 21782 Created "style" folder for code supporting check-webkit-style. 21783 21784 * Scripts/modules/style: Added. 21785 217862009-12-20 Adam Barth <abarth@webkit.org> 21787 21788 Reviewed by Eric Seidel. 21789 21790 REGRESSION: error when running commit-queue 21791 https://bugs.webkit.org/show_bug.cgi?id=32806 21792 21793 Fix typo and add test! 21794 21795 * Scripts/modules/bugzilla.py: 21796 * Scripts/modules/bugzilla_unittest.py: 21797 217982009-12-20 Adam Barth <abarth@webkit.org> 21799 21800 [bzt] Optimize status updates for new dashboard 21801 https://bugs.webkit.org/show_bug.cgi?id=32797 21802 21803 This patch makes the queues slightly more chatty with the web service. 21804 Also, this patch introduces some testing for the queues! 21805 21806 * Scripts/modules/commands/early_warning_system.py: 21807 * Scripts/modules/commands/early_warning_system_unittest.py: Added. 21808 * Scripts/modules/commands/queues.py: 21809 * Scripts/modules/commands/queues_unittest.py: 21810 * Scripts/modules/commands/queuestest.py: Added. 21811 * Scripts/modules/mock_bugzillatool.py: 21812 * Scripts/modules/patchcollection.py: 21813 * Scripts/modules/queueengine.py: 21814 * Scripts/run-webkit-unittests: 21815 218162009-12-20 Adam Barth <abarth@webkit.org> 21817 21818 Reviewed by Eric Seidel. 21819 21820 Prepare QueueStatusServer for new status messages 21821 https://bugs.webkit.org/show_bug.cgi?id=32805 21822 21823 * QueueStatusServer/handlers/recentstatus.py: 21824 * QueueStatusServer/index.html: Removed. 21825 * QueueStatusServer/model/attachment.py: 21826 * QueueStatusServer/model/queues.py: Added. 21827 * QueueStatusServer/templates/recentstatus.html: Added. 21828 218292009-12-20 Shinichiro Hamaji <hamaji@chromium.org> 21830 21831 Reviewed by Adam Barth. 21832 21833 [check-webkit-style] static_cast is not misnamed! 21834 https://bugs.webkit.org/show_bug.cgi?id=32796 21835 21836 * Scripts/modules/cpp_style.py: 21837 * Scripts/modules/cpp_style_unittest.py: 21838 218392009-12-20 Alejandro G. Castro <alex@igalia.com> 21840 21841 Reviewed by Gustavo Noronha Silva. 21842 21843 [GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html 21844 https://bugs.webkit.org/show_bug.cgi?id=32788 21845 21846 Do not increase the click count if we are using a different button. 21847 21848 * DumpRenderTree/gtk/EventSender.cpp: 21849 218502009-12-20 Adam Barth <abarth@webkit.org> 21851 21852 Reviewed by Eric Seidel. 21853 21854 [QueueStatusServer] Add a per-patch details page 21855 https://bugs.webkit.org/show_bug.cgi?id=32784 21856 21857 This is a first cut at a per-patch details page. I'm sure we'll have 21858 to iterate. 21859 21860 * QueueStatusServer/filters/webkit_extras.py: 21861 * QueueStatusServer/handlers/patch.py: Added. 21862 * QueueStatusServer/index.yaml: 21863 * QueueStatusServer/main.py: 21864 * QueueStatusServer/model/attachment.py: 21865 * QueueStatusServer/stylesheets/dashboard.css: 21866 * QueueStatusServer/templates/dashboard.html: 21867 * QueueStatusServer/templates/patch.html: Added. 21868 218692009-12-20 Adam Barth <abarth@webkit.org> 21870 21871 Reviewed by Eric Seidel. 21872 21873 Use memcache to make dashboard to fast 21874 https://bugs.webkit.org/show_bug.cgi?id=32780 21875 21876 * QueueStatusServer/app.yaml: 21877 * QueueStatusServer/handlers/dashboard.py: 21878 * QueueStatusServer/handlers/updatestatus.py: 21879 * QueueStatusServer/model/attachment.py: Added. 21880 218812009-12-19 Brent Fulgham <bfulgham@webkit.org> 21882 21883 Reviewed by Adam Roben. 21884 21885 Provide an example implementation for printing under Windows. 21886 http://bugs.webkit.org/show_bug.cgi?id=32504.` 21887 21888 * WinLauncher/PrintWebUIDelegate.cpp: Added. 21889 (PrintWebUIDelegate::QueryInterface): 21890 (PrintWebUIDelegate::AddRef): 21891 (PrintWebUIDelegate::Release): 21892 (PrintWebUIDelegate::webViewPrintingMarginRect): 21893 * WinLauncher/PrintWebUIDelegate.h: Added. 21894 (PrintWebUIDelegate::PrintWebUIDelegate): 21895 (PrintWebUIDelegate::createWebViewWithRequest): 21896 (PrintWebUIDelegate::webViewShow): 21897 (PrintWebUIDelegate::webViewClose): 21898 (PrintWebUIDelegate::webViewFocus): 21899 (PrintWebUIDelegate::webViewUnfocus): 21900 (PrintWebUIDelegate::webViewFirstResponder): 21901 (PrintWebUIDelegate::makeFirstResponder): 21902 (PrintWebUIDelegate::setStatusText): 21903 (PrintWebUIDelegate::webViewStatusText): 21904 (PrintWebUIDelegate::webViewAreToolbarsVisible): 21905 (PrintWebUIDelegate::setToolbarsVisible): 21906 (PrintWebUIDelegate::webViewIsStatusBarVisible): 21907 (PrintWebUIDelegate::setStatusBarVisible): 21908 (PrintWebUIDelegate::webViewIsResizable): 21909 (PrintWebUIDelegate::setResizable): 21910 (PrintWebUIDelegate::setFrame): 21911 (PrintWebUIDelegate::webViewFrame): 21912 (PrintWebUIDelegate::setContentRect): 21913 (PrintWebUIDelegate::webViewContentRect): 21914 (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): 21915 (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): 21916 (PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt): 21917 (PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage): 21918 (PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener): 21919 (PrintWebUIDelegate::mouseDidMoveOverElement): 21920 (PrintWebUIDelegate::contextMenuItemsForElement): 21921 (PrintWebUIDelegate::validateUserInterfaceItem): 21922 (PrintWebUIDelegate::shouldPerformAction): 21923 (PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo): 21924 (PrintWebUIDelegate::willPerformDragDestinationAction): 21925 (PrintWebUIDelegate::dragSourceActionMaskForPoint): 21926 (PrintWebUIDelegate::willPerformDragSourceAction): 21927 (PrintWebUIDelegate::contextMenuItemSelected): 21928 (PrintWebUIDelegate::hasCustomMenuImplementation): 21929 (PrintWebUIDelegate::trackCustomPopupMenu): 21930 (PrintWebUIDelegate::measureCustomMenuItem): 21931 (PrintWebUIDelegate::drawCustomMenuItem): 21932 (PrintWebUIDelegate::addCustomMenuDrawingData): 21933 (PrintWebUIDelegate::cleanUpCustomMenuDrawingData): 21934 (PrintWebUIDelegate::canTakeFocus): 21935 (PrintWebUIDelegate::takeFocus): 21936 (PrintWebUIDelegate::registerUndoWithTarget): 21937 (PrintWebUIDelegate::removeAllActionsWithTarget): 21938 (PrintWebUIDelegate::setActionTitle): 21939 (PrintWebUIDelegate::undo): 21940 (PrintWebUIDelegate::redo): 21941 (PrintWebUIDelegate::canUndo): 21942 (PrintWebUIDelegate::canRedo): 21943 (PrintWebUIDelegate::printFrame): 21944 (PrintWebUIDelegate::ftpDirectoryTemplatePath): 21945 (PrintWebUIDelegate::webViewHeaderHeight): 21946 (PrintWebUIDelegate::webViewFooterHeight): 21947 (PrintWebUIDelegate::drawHeaderInRect): 21948 (PrintWebUIDelegate::drawFooterInRect): 21949 (PrintWebUIDelegate::canRunModal): 21950 (PrintWebUIDelegate::createModalDialog): 21951 (PrintWebUIDelegate::runModal): 21952 (PrintWebUIDelegate::isMenuBarVisible): 21953 (PrintWebUIDelegate::setMenuBarVisible): 21954 (PrintWebUIDelegate::runDatabaseSizeLimitPrompt): 21955 (PrintWebUIDelegate::paintCustomScrollbar): 21956 (PrintWebUIDelegate::paintCustomScrollCorner): 21957 * WinLauncher/WinLauncher.cpp: Add new UI delegate for print support. 21958 (WinLauncherWebHost::updateAddressBar): check-webkit-style fixes. 21959 (WinLauncherWebHost::QueryInterface): check-webkit-style fixes. 21960 (WinLauncherWebHost::AddRef): check-webkit-style fixes. 21961 (WinLauncherWebHost::Release): check-webkit-style fixes. 21962 (resizeSubViews): check-webkit-style fixes. 21963 (_tWinMain): check-webkit-style fixes. 21964 (MyRegisterClass): check-webkit-style fixes. 21965 (InitInstance): check-webkit-style fixes. 21966 (AbortProc): New print support function. 21967 (getPrinterDC): New print support function. 21968 (initDocStruct): New print support function. 21969 (PrintView): New printing implementation. 21970 (WndProc): Add support for printing. 21971 (MyEditProc): check-webkit-style fixes. 21972 (About): check-webkit-style fixes. 21973 (loadURL): check-webkit-style fixes. 21974 * WinLauncher/WinLauncher.h: 21975 (WinLauncherWebHost::WinLauncherWebHost): 21976 (WinLauncherWebHost::didStartProvisionalLoadForFrame): 21977 (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): 21978 (WinLauncherWebHost::didFailProvisionalLoadWithError): 21979 (WinLauncherWebHost::didCommitLoadForFrame): 21980 (WinLauncherWebHost::didReceiveTitle): 21981 (WinLauncherWebHost::didReceiveIcon): 21982 (WinLauncherWebHost::didFinishLoadForFrame): 21983 (WinLauncherWebHost::didFailLoadWithError): 21984 (WinLauncherWebHost::didChangeLocationWithinPageForFrame): 21985 (WinLauncherWebHost::willPerformClientRedirectToURL): 21986 (WinLauncherWebHost::didCancelClientRedirectForFrame): 21987 (WinLauncherWebHost::willCloseFrame): 21988 (WinLauncherWebHost::windowScriptObjectAvailable): 21989 * WinLauncher/WinLauncher.rc: Add menu entry for printing. 21990 * WinLauncher/WinLauncher.vcproj: Add new files. 21991 * WinLauncher/resource.h: Add menu entry for printing. 21992 219932009-12-19 Adam Barth <abarth@webkit.org> 21994 21995 Unreviewed. Tweak the CSS to make the dashboard prettier. 21996 21997 * QueueStatusServer/stylesheets/dashboard.css: 21998 * QueueStatusServer/templates/dashboard.html: 21999 220002009-12-19 Adam Barth <abarth@webkit.org> 22001 22002 Reviewed by Eric Seidel. 22003 22004 QueueStatusServer needs a human readable dashboard 22005 https://bugs.webkit.org/show_bug.cgi?id=32769 22006 22007 Here is a first cut at the dashboard. There's a lot left to do. 22008 22009 * QueueStatusServer/filters/webkit_extras.py: 22010 * QueueStatusServer/handlers/dashboard.py: Added. 22011 * QueueStatusServer/handlers/patchstatus.py: 22012 * QueueStatusServer/handlers/recentstatus.py: 22013 * QueueStatusServer/handlers/showresults.py: 22014 * QueueStatusServer/handlers/statusbubble.py: 22015 * QueueStatusServer/handlers/updatestatus.py: 22016 * QueueStatusServer/main.py: 22017 * QueueStatusServer/model/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. 22018 * QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py. 22019 * QueueStatusServer/stylesheets/dashboard.css: Added. 22020 * QueueStatusServer/templates/dashboard.html: Added. 22021 * QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html. 22022 * QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html. 22023 220242009-12-19 Daniel Bates <dbates@webkit.org> 22025 22026 Reviewed by Timothy Hatcher. 22027 22028 https://bugs.webkit.org/show_bug.cgi?id=32462 22029 22030 Added --inspector-frontend flag to build-webkit to copy any changes 22031 to the inspector front-end files to the built WebCore framework. This 22032 will make inspector development more consistent with the rest of 22033 WebKit development. 22034 22035 * Scripts/build-webkit: 22036 * Scripts/webkitdirs.pm: 22037 220382009-12-19 Adam Barth <abarth@webkit.org> 22039 22040 Unreviewed fixes for me being terrible at python. 22041 22042 * Scripts/modules/bugzilla.py: 22043 * Scripts/run-webkit-unittests: 22044 220452009-12-18 Adam Barth <abarth@webkit.org> 22046 22047 Reviewed by Eric Seidel. 22048 22049 Split QueueStatus server into modules 22050 https://bugs.webkit.org/show_bug.cgi?id=32768 22051 22052 One monolithic file is no good. 22053 22054 * QueueStatusServer/app.yaml: 22055 * QueueStatusServer/handlers/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. 22056 * QueueStatusServer/handlers/patchstatus.py: Added. 22057 * QueueStatusServer/handlers/recentstatus.py: Added. 22058 * QueueStatusServer/handlers/showresults.py: Added. 22059 * QueueStatusServer/handlers/statusbubble.py: Added. 22060 * QueueStatusServer/handlers/updatestatus.py: Added. 22061 * QueueStatusServer/main.py: Added. 22062 * QueueStatusServer/model.py: Added. 22063 * QueueStatusServer/queue_status.py: Removed. 22064 220652009-12-18 Adam Barth <abarth@webkit.org> 22066 22067 Rubber stamped by Eric Seidel. 22068 22069 Renamed WorkQueue to QueueEngine. WorkQueue is not a queue. 22070 22071 * Scripts/modules/commands/queues.py: 22072 * Scripts/modules/queueengine.py: Added. 22073 * Scripts/modules/queueengine_unittest.py: Added. 22074 * Scripts/modules/stepsequence.py: 22075 * Scripts/modules/workqueue.py: Removed. 22076 * Scripts/modules/workqueue_unittest.py: Removed. 22077 220782009-12-18 Adam Barth <abarth@webkit.org> 22079 22080 Reviewed by Eric Seidel. 22081 22082 Add watches for EWS 22083 https://bugs.webkit.org/show_bug.cgi?id=32767 22084 22085 dglazkov wanted to be added. 22086 22087 * Scripts/modules/bugzilla.py: 22088 * Scripts/modules/commands/early_warning_system.py: 22089 * Scripts/modules/commands/queues.py: 22090 220912009-12-18 Eric Seidel <eric@webkit.org> 22092 22093 Reviewed by David Levin. 22094 22095 move bugzilla.py off of urllib2 22096 https://bugs.webkit.org/show_bug.cgi?id=32729 22097 22098 * Scripts/modules/bugzilla.py: use mechanize for all url fetching. 22099 221002009-12-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 22101 22102 Rubber-stamped by Xan Lopez. 22103 22104 [GTK] New events (pageshow and pagehide) tests failing 22105 https://bugs.webkit.org/show_bug.cgi?id=28823 22106 22107 Original patch by Jan Michael Alonzo. 22108 22109 Disable page cache for tests. 22110 22111 * DumpRenderTree/gtk/DumpRenderTree.cpp: 22112 (resetDefaultsToConsistentValues): 22113 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 22114 (copyWebSettingKey): 22115 (LayoutTestController::overridePreference): 22116 221172009-12-18 Fumitoshi Ukai <ukai@chromium.org> 22118 22119 Reviewed by David Levin. 22120 22121 Check one space before end of line comments. 22122 https://bugs.webkit.org/show_bug.cgi?id=32597 22123 22124 Fix to check one space before end of line comments in whitespace and build/header_guard. 22125 Also fix build/header_guard to use WebKit header guard defines. 22126 22127 * Scripts/modules/cpp_style.py: 22128 * Scripts/modules/cpp_style_unittest.py: 22129 221302009-12-17 Sam Weinig <sam@webkit.org> 22131 22132 Reviewed by Mark Rowe. 22133 22134 Add BUILDING_ON_SNOW_LEOPARD #define. 22135 22136 * DumpRenderTree/mac/DumpRenderTreeMac.h: 22137 221382009-12-17 Yuzo Fujishima <yuzo@google.com> 22139 22140 Reviewed by Alexey Proskuryakov. 22141 22142 Update pywebsocket to 0.4.5 and make handshake checking stricter 22143 https://bugs.webkit.org/show_bug.cgi?id=32249 22144 22145 * Scripts/run-webkit-tests: 22146 * pywebsocket/mod_pywebsocket/handshake.py: 22147 * pywebsocket/mod_pywebsocket/memorizingfile.py: Added. 22148 * pywebsocket/mod_pywebsocket/standalone.py: 22149 * pywebsocket/setup.py: 22150 * pywebsocket/test/test_handshake.py: 22151 * pywebsocket/test/test_memorizingfile.py: Added. 22152 221532009-12-17 Eric Seidel <eric@webkit.org> 22154 22155 Reviewed by Adam Barth. 22156 22157 Command.show_in_main_help should default to False 22158 https://bugs.webkit.org/show_bug.cgi?id=32686 22159 22160 * Scripts/modules/commands/download.py: 22161 * Scripts/modules/commands/queries.py: 22162 * Scripts/modules/commands/queues.py: 22163 * Scripts/modules/commands/upload.py: 22164 * Scripts/modules/multicommandtool.py: 22165 221662009-12-17 Alejandro G. Castro <alex@igalia.com> 22167 22168 Reviewed by Eric Seidel. 22169 22170 Added the key WebKitEnableCaretBrowsing to the 22171 layoutTestController.overridePreference in order to activate caret 22172 browsing. 22173 https://bugs.webkit.org/show_bug.cgi?id=32612 22174 22175 * DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of 22176 the setting. 22177 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new 22178 key in the keytable. 22179 221802009-12-17 Chris Fleizach <cfleizach@apple.com> 22181 22182 Reviewed by David Kilzer. 22183 22184 AX: DRT needs to support URL for accessibility 22185 https://bugs.webkit.org/show_bug.cgi?id=32666 22186 22187 * DumpRenderTree/AccessibilityUIElement.cpp: 22188 (getURLCallback): 22189 (AccessibilityUIElement::getJSClass): 22190 * DumpRenderTree/AccessibilityUIElement.h: 22191 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 22192 (AccessibilityUIElement::url): 22193 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 22194 (AccessibilityUIElement::url): 22195 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 22196 (AccessibilityUIElement::url): 22197 221982009-12-17 Philippe Normand <pnormand@igalia.com> 22199 22200 Unreviewed; added myself to committers 22201 22202 * Scripts/modules/committers.py: 22203 222042009-12-17 Benjamin Otte <otte@gnome.org> 22205 22206 Unreviewed; added myself to committers 22207 22208 * Scripts/modules/committers.py: 22209 222102009-12-17 Adam Barth <abarth@webkit.org> 22211 22212 Rubber stamp by Seidel. 22213 22214 Clean up exception handling in WorkQueue. Basically, a bunch of the 22215 delegate messages can throw exceptions because of network errors. We 22216 want the queues to keep on ticking instead of erroring out. That means 22217 we want to catch generic exceptions and continue looping. 22218 22219 Also, cleaned up the exception handling in the EWS to properly log 22220 failures. 22221 22222 * Scripts/modules/commands/early_warning_system.py: 22223 * Scripts/modules/commands/queues.py: 22224 * Scripts/modules/workqueue.py: 22225 222262009-12-16 Adam Barth <abarth@webkit.org> 22227 22228 Reviewed by Eric Seidel. 22229 22230 [bzt] Make UpdateStep quiet 22231 https://bugs.webkit.org/show_bug.cgi?id=32599 22232 22233 * Scripts/modules/buildsteps.py: 22234 * Scripts/modules/buildsteps_unittest.py: 22235 222362009-12-16 Evan Martin <evan@chromium.org> 22237 22238 Reviewed by Adam Barth. 22239 22240 Add Gtk to the early warning system WebKit port list. 22241 22242 https://bugs.webkit.org/show_bug.cgi?id=32629 22243 22244 * Scripts/modules/commands/early_warning_system.py: 22245 * Scripts/modules/webkitport.py: 22246 * Scripts/modules/webkitport_unittest.py: 22247 222482009-12-16 Eric Seidel <eric@webkit.org> 22249 22250 Reviewed by Adam Barth. 22251 22252 post-diff is failing with exception under guess_reviewer_from_bug 22253 https://bugs.webkit.org/show_bug.cgi?id=32642 22254 22255 Also refactor output capturing code into 22256 OutputCapture.assert_outputs to share more code between tests. 22257 22258 * Scripts/modules/buildsteps.py: 22259 - Add the missing include. 22260 - Give guess_reviewer_from_bug a private underscore. 22261 * Scripts/modules/buildsteps_unittest.py: Added. 22262 - Test to make sure _guess_reviewer_from_bug works as expected. 22263 * Scripts/modules/commands/commandtest.py: 22264 - Custom code is now obsoleted by OutputCapture.assert_outputs 22265 * Scripts/modules/commands/queues_unittest.py: 22266 - ditto 22267 * Scripts/modules/credentials_unittest.py: 22268 - ditto 22269 * Scripts/modules/mock_bugzillatool.py: 22270 - fetch_reviewed_patches_from_bug can never return None 22271 * Scripts/modules/multicommandtool_unittest.py: 22272 - Custom code is now obsoleted by OutputCapture.assert_outputs 22273 * Scripts/modules/outputcapture.py: 22274 - Add assert_outputs to share more code between tests. 22275 * Scripts/run-webkit-unittests: 22276 - Add buildsteps_unittest.py 22277 222782009-12-16 Adam Barth <abarth@webkit.org> 22279 22280 Unreviewed. Added a default argument to _update_status so that callers 22281 don't have to explictly pass None when they don't have a patch object. 22282 22283 * Scripts/modules/commands/queues.py: 22284 222852009-12-16 Kent Tamura <tkent@chromium.org> 22286 22287 Reviewed by David Levin. 22288 22289 check-webkit-style supports for TAB check against text files. 22290 https://bugs.webkit.org/show_bug.cgi?id=32538 22291 22292 * Scripts/check-webkit-style: 22293 Move process_patch() to style.py. 22294 * Scripts/modules/cpp_style.py: 22295 Add can_handle(). 22296 * Scripts/modules/cpp_style_unittest.py: 22297 Add tests for can_handle(). 22298 * Scripts/modules/style.py: 22299 Added. This is a front-end of cpp_style and text_style. It dispatches 22300 files to an appropriate linter. 22301 * Scripts/modules/text_style.py: 22302 Added. This is a linter module for generic text files. It supports 22303 only for TAB checking at this moment. 22304 * Scripts/modules/text_style_unittest.py: 22305 Added. Tests for text_style.py. 22306 * Scripts/run-webkit-unittests: 22307 Add text_style_unittest. 22308 223092009-12-16 Eric Seidel <eric@webkit.org> 22310 22311 Reviewed by David Levin. 22312 22313 bugzilla-tool should not require users to install mechanize 22314 https://bugs.webkit.org/show_bug.cgi?id=32635 22315 22316 Centralize our import logic. 22317 22318 * Scripts/modules/bugzilla.py: use webkit_mechanize 22319 * Scripts/modules/statusbot.py: use webkit_mechanize 22320 * Scripts/modules/webkit_mechanize.py: Added. 22321 223222009-12-16 Eric Seidel <eric@webkit.org> 22323 22324 Reviewed by Adam Barth. 22325 22326 Generalize commit-queue recent status page for all queues 22327 https://bugs.webkit.org/show_bug.cgi?id=32633 22328 22329 * QueueStatusServer/index.html: 22330 - Generalize to support other queues. 22331 * QueueStatusServer/queue_status.py: 22332 - Generalize MainPage to support other queues. 22333 223342009-12-16 Evan Martin <evan@chromium.org> 22335 22336 Reviewed by Adam Barth. 22337 22338 Early warning system server should display output as UTF-8. 22339 22340 https://bugs.webkit.org/show_bug.cgi?id=32625 22341 22342 * QueueStatusServer/queue_status.py: 22343 223442009-12-16 Adam Barth <abarth@webkit.org> 22345 22346 Reviewed by Eric Seidel. 22347 22348 [bzt] Add error handling to the early warning system 22349 https://bugs.webkit.org/show_bug.cgi?id=32594 22350 22351 This should be the last step in making the EWS operational. When we 22352 have a build error, we post the log to QueueStatusServer and add a link 22353 to the bug. 22354 22355 * Scripts/modules/commands/early_warning_system.py: 22356 * Scripts/modules/commands/queues.py: 22357 * Scripts/modules/executive.py: 22358 223592009-12-16 Simon Hausmann <simon.hausmann@nokia.com> 22360 22361 Reviewed by Holger Freyther. 22362 22363 Fix crash with tests that use custom font faces. 22364 22365 https://bugs.webkit.org/show_bug.cgi?id=32600 22366 22367 In the DRT we call QApplication::removeAllApplicationFonts(), to make sure 22368 that custom font faces between tests don't influence each other. Calling this 22369 function in Qt however also invalidates all existing handles with QFontDatabase. 22370 22371 In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(), 22372 which implies a call to WebCore::FontCache::fontCache()->invalidate(). 22373 22374 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 22375 (WebCore::DumpRenderTree::open): 22376 223772009-12-16 Andreas Kling <andreas.kling@nokia.com> 22378 22379 Reviewed by Simon Hausmann. 22380 22381 [Qt] Maintain button state between mouse events. 22382 22383 This allows eventSender to generate drag events. 22384 22385 https://bugs.webkit.org/show_bug.cgi?id=32601 22386 22387 * DumpRenderTree/qt/EventSenderQt.cpp: 22388 (EventSender::mouseDown): 22389 (EventSender::mouseUp): 22390 (EventSender::mouseMoveTo): 22391 * DumpRenderTree/qt/EventSenderQt.h: 22392 223932009-12-15 Chris Jerdonek <chris.jerdonek@gmail.com> 22394 22395 Reviewed by David Levin. 22396 22397 Code clean-up in check-webkit-style as described below. 22398 The only functional changes are minor improvements to the 22399 script's help output. 22400 22401 https://bugs.webkit.org/show_bug.cgi?id=32487 22402 22403 * Scripts/check-webkit-style: 22404 - Added the module docstring from cpp_style.py. 22405 - Improved wording of the --help output and added some of the 22406 default values as substitution strings. 22407 - Called cpp_style.exit_with_usage instead of sys.stderr.write 22408 in main function. 22409 - Made changes caused by changes to cpp_style.py. 22410 22411 * Scripts/modules/cpp_style.py: 22412 - Removed module docstring, as well as redundant _USAGE string 22413 and main() function obsoleted by check-webkit-style. 22414 - Moved specification of default script values from within a 22415 function definition to global variables. 22416 - Moved the default webkit filter rules to be near the other 22417 global variables. 22418 - Renamed "FILTER" global variables to "FILTER_RULES" to 22419 establish unambiguous terminology. 22420 - Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES. 22421 - Changed _STYLE_CATEGORIES from a string to a list. 22422 - Added default webkit filter rules to --filter= output. 22423 - Renamed "print_" methods to "exit_with_" since they exist 22424 and added a temporary display_help parameter. 22425 - Added a temporary display_help parameter to parse_arguments. 22426 22427 * Scripts/modules/cpp_style_unittest.py: 22428 - Made changes caused by changes to cpp_style.py. 22429 - Lower-cased ErrorCollector's ERROR_CATEGORIES instance 22430 variables since they are not global. 22431 224322009-12-15 Adam Barth <abarth@webkit.org> 22433 22434 Unreviewed fix for the style-queue. 22435 Typo: _updates_status -> _update_status 22436 22437 We need to improve our testing infrastructure for the queues. 22438 22439 * Scripts/modules/commands/queues.py: 22440 224412009-12-15 Adam Barth <abarth@webkit.org> 22442 22443 Unreviewed fix for the style-queue. I suspect this is a recent 22444 regression from Eric's change below. 22445 22446 * Scripts/modules/commands/queues.py: 22447 224482009-12-15 Yaar Schnitman <yaar@chromium.org> 22449 22450 Reviewed by Darin Fisher. 22451 22452 update-webkit-chromium to auto-install gclient 22453 22454 https://bugs.webkit.org/show_bug.cgi?id=32587 22455 22456 * Scripts/update-webkit-chromium: 22457 224582009-12-15 Eric Seidel <eric@webkit.org> 22459 22460 Reviewed by Adam Barth. 22461 22462 bugzilla-tool / commit-queue should add results links to bugs when more results are available on the status bot 22463 https://bugs.webkit.org/show_bug.cgi?id=32546 22464 22465 You can see an example of this working in: 22466 https://bugs.webkit.org/show_bug.cgi?id=32585#c3 22467 22468 * QueueStatusServer/queue_status.py: 22469 - Output the id of the newly created status. 22470 * Scripts/modules/commands/queues.py: 22471 - Tweak the commit-queue logging to include a full status link. 22472 * Scripts/modules/statusbot.py: 22473 - update_status should return the newly created status id. 22474 224752009-12-15 Andras Becsi <abecsi@inf.u-szeged.hu> 22476 22477 Reviewed by Tor Arne Vestbø. 22478 22479 [Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable. 22480 22481 * DumpRenderTree/qt/DumpRenderTree.cpp: Removed. 22482 * DumpRenderTree/qt/DumpRenderTree.h: Removed. 22483 * DumpRenderTree/qt/DumpRenderTree.pro: Updated. 22484 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp. 22485 * DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h. 22486 * DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp. 22487 (GCController::GCController): 22488 * DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h. 22489 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 22490 * DumpRenderTree/qt/WorkQueueItem.h: Removed. 22491 * DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes. 22492 * DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h. 22493 * DumpRenderTree/qt/jsobjects.cpp: Removed. 22494 * DumpRenderTree/qt/jsobjects.h: Removed. 22495 * DumpRenderTree/qt/main.cpp: Updated includes. 22496 224972009-12-15 Adam Barth <abarth@webkit.org> 22498 22499 Reviewed by Eric Seidel. 22500 22501 We have two mark-fixed commands 22502 https://bugs.webkit.org/show_bug.cgi?id=32073 22503 22504 * Scripts/mark-bug-fixed: Removed. 22505 * Scripts/modules/commands/upload.py: 22506 * Scripts/modules/commands/upload_unittest.py: 22507 225082009-12-15 Eric Seidel <eric@webkit.org> 22509 22510 Reviewed by Adam Barth. 22511 22512 bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected 22513 https://bugs.webkit.org/show_bug.cgi?id=28286 22514 22515 * QueueStatusServer/index.html: 22516 - Show [results] links if a results log was uploaded. 22517 * QueueStatusServer/queue_status.py: 22518 - Empty file uploads appear as u"" and Blob does not handle unicode, so convert to str(). 22519 * Scripts/modules/commands/queues.py: 22520 - Post to the status bot when a patch fails and include the failure log as a results file. 22521 225222009-12-15 Eric Seidel <eric@webkit.org> 22523 22524 Reviewed by Adam Barth. 22525 22526 queue sub-commands need --status-host so they can report status 22527 https://bugs.webkit.org/show_bug.cgi?id=32313 22528 22529 Make --status-bot a global option and make 22530 run_bugzilla_tool pass --status-bot to sub-commands. 22531 22532 * Scripts/bugzilla-tool: 22533 - Rename _status to status_bot and make it non-lazy. 22534 * Scripts/modules/commands/queues.py: 22535 - Move status updates out of WorkQueue and into individual queues. 22536 * Scripts/modules/commands/queues_unittest.py: 22537 - Test that --status-host is passed to bugzilla-tool when run as subcommand. 22538 * Scripts/modules/mock_bugzillatool.py: 22539 - Add a MockStatusBot 22540 * Scripts/modules/workqueue.py: 22541 - Remove status_host and work_work_logs_directory callbacks. 22542 - Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches! 22543 * Scripts/modules/workqueue_unittest.py: 22544 - Update unit tests to reflect new callbacks. 22545 225462009-12-15 Adam Barth <abarth@webkit.org> 22547 22548 Reviewed by Eric Seidel. 22549 22550 scm_unittest.py is too slow 22551 https://bugs.webkit.org/show_bug.cgi?id=31818 22552 22553 Now we don't run the SCM unit tests unless we get the --all flag on the 22554 command line. Eric and I were commenting out this test because it was 22555 too painful to run. 22556 22557 * Scripts/run-webkit-unittests: 22558 225592009-12-14 Adam Barth <abarth@webkit.org> 22560 22561 Unreviewed. Fix failing unittest. 22562 22563 * Scripts/modules/bugzilla_unittest.py: 22564 225652009-12-14 Eric Seidel <eric@webkit.org> 22566 22567 Reviewed by Adam Barth. 22568 22569 Move Credential handling out into a separate module 22570 https://bugs.webkit.org/show_bug.cgi?id=32531 22571 22572 * Scripts/modules/bugzilla.py: 22573 * Scripts/modules/credentials.py: Added. 22574 * Scripts/modules/credentials_unittest.py: Added. 22575 * Scripts/run-webkit-unittests: 22576 225772009-12-14 Adam Barth <abarth@webkit.org> 22578 22579 Reviewed by Eric Seidel. 22580 22581 Kill _create_step_sequence 22582 https://bugs.webkit.org/show_bug.cgi?id=32539 22583 22584 It's cleaner to represent not having these sequences as an empty 22585 sequence instead of None. 22586 22587 * Scripts/modules/commands/download.py: 22588 * Scripts/modules/stepsequence.py: 22589 225902009-12-14 Adam Barth <abarth@webkit.org> 22591 22592 Unreviewed. Address reviewer comments from an earlier patch. I didn't 22593 do this earlier because I was worried about conflicts in dependent 22594 patches. 22595 22596 * Scripts/modules/commands/download.py: 22597 225982009-12-14 Adam Barth <abarth@webkit.org> 22599 22600 Reviewed by Eric Seidel. 22601 22602 [bzt] Make download commands declarative 22603 https://bugs.webkit.org/show_bug.cgi?id=32469 22604 22605 This patch "properly" factors most of the download commands. These 22606 commands are now largely declarative, which is the final step of this 22607 grand refactoring. 22608 22609 * Scripts/modules/buildsteps.py: 22610 * Scripts/modules/commands/download.py: 22611 226122009-12-14 Adam Barth <abarth@webkit.org> 22613 22614 Reviewed by Eric Seidel. 22615 22616 [bzt] Add AbstractPatchSequencingCommand to remove redundant code 22617 https://bugs.webkit.org/show_bug.cgi?id=32468 22618 22619 Redundant code is bad. This patch moves us towards more declarative 22620 commands. 22621 22622 * Scripts/modules/commands/download.py: 22623 226242009-12-14 Adam Barth <abarth@webkit.org> 22625 22626 Reviewed by Eric Seidel. 22627 22628 [bzt] Kill WebKitApplyingScripts 22629 https://bugs.webkit.org/show_bug.cgi?id=32467 22630 22631 Ah! I've been wanting to do this for a long time. This patch brings 22632 the applying commands into the patch processing fold. 22633 22634 * Scripts/bugzilla-tool: 22635 * Scripts/modules/buildsteps.py: 22636 * Scripts/modules/commands/download.py: 22637 * Scripts/modules/commands/download_unittest.py: 22638 * Scripts/modules/mock_bugzillatool.py: 22639 226402009-12-14 Adam Barth <abarth@webkit.org> 22641 22642 Reviewed by Eric Seidel. 22643 22644 [bzt] Convert rollout to StepSequence 22645 https://bugs.webkit.org/show_bug.cgi?id=32406 22646 22647 * Scripts/modules/buildsteps.py: 22648 * Scripts/modules/commands/download.py: 22649 * Scripts/modules/commands/download_unittest.py: 22650 * Scripts/modules/mock_bugzillatool.py: 22651 226522009-12-14 Adam Barth <abarth@webkit.org> 22653 22654 Reviewed by Eric Seidel. 22655 22656 [bzt] Kill LandingSequence 22657 https://bugs.webkit.org/show_bug.cgi?id=32464 22658 22659 Removes LandingSequence in favor of StepSequence. This required 22660 changing the Step API slightly to carry a general notion of state 22661 instead of carrying patches specifically. 22662 22663 * Scripts/modules/buildsteps.py: 22664 * Scripts/modules/commands/download.py: 22665 * Scripts/modules/commands/queues.py: 22666 * Scripts/modules/landingsequence.py: Removed. 22667 * Scripts/modules/stepsequence.py: 22668 226692009-12-14 Robert Hogan <robert@roberthogan.net> 22670 22671 Reviewed by Eric Seidel. 22672 22673 [Qt] Fix https://bugs.webkit.org/show_bug.cgi?id=32437 22674 22675 Amend the behaviour of DRT::notifyDone to dump only when 22676 the page has finished loading. 22677 22678 This fix permits removal of the following tests from the Qt skipped list: 22679 fast/forms/textarea-linewrap-dynamic.html 22680 fast/forms/textarea-setvalue-submit.html 22681 fast/forms/textarea-hard-linewrap-empty.html 22682 fast/forms/submit-to-url-fragment.html 22683 http/tests/misc/percent-sign-in-form-field-name.html 22684 http/tests/security/escape-form-data-field-names.html 22685 22686 However it also requires the following two to be added to the skipped list: 22687 22688 http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html 22689 svg/custom/use-instanceRoot-as-event-target.xhtml 22690 22691 It appears the behaviour of notifyDone was masking problems with these two 22692 tests. 22693 22694 * DumpRenderTree/qt/DumpRenderTree.cpp: 22695 (WebCore::DumpRenderTree::DumpRenderTree): 22696 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 22697 (LayoutTestController::reset): 22698 (LayoutTestController::processWork): 22699 (LayoutTestController::maybeDump): 22700 (LayoutTestController::notifyDone): 22701 (LayoutTestController::provisionalLoad): 22702 * DumpRenderTree/qt/LayoutTestControllerQt.h: 22703 (LayoutTestController::resetLoadFinished): 22704 227052009-12-14 Simon Hausmann <hausmann@webkit.org> 22706 22707 Reviewed by Holger Freyther. 22708 22709 [Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events 22710 22711 https://bugs.webkit.org/show_bug.cgi?id=32482 22712 22713 * DumpRenderTree/qt/EventSenderQt.cpp: 22714 (EventSender::setTouchModifier): 22715 (EventSender::clearTouchPoints): 22716 (EventSender::sendTouchEvent): 22717 * DumpRenderTree/qt/EventSenderQt.h: 22718 227192009-12-13 Maciej Stachowiak <mjs@apple.com> 22720 22721 Reviewed by Gavin Barraclaugh. 22722 22723 Fix minor problem in sunspider-compare-results which left it broken. 22724 22725 * Scripts/sunspider-compare-results: Declare $parseonly 22726 227272009-12-12 Maciej Stachowiak <mjs@apple.com> 22728 22729 Reviewed by Oliver Hunt. 22730 22731 Give command-line sunspider the ability to handle multiple suites and versions 22732 https://bugs.webkit.org/show_bug.cgi?id=32477 22733 22734 * Scripts/run-sunspider: Updated for changes to command-line parameters. 22735 * Scripts/sunspider-compare-results: ditto 22736 227372009-12-12 Maciej Stachowiak <mjs@apple.com> 22738 22739 Not reviewed, fixing previous comment. 22740 22741 Remove accidental change to sunspider-compare-results 22742 22743 * Scripts/sunspider-compare-results: 22744 227452009-12-11 Yael Aharon <yael.aharon@nokia.com> 22746 22747 Unreviewed build fix for Qt versions < 4.6. 22748 Guard every slot individually with #ifdef. 22749 22750 * DumpRenderTree/qt/EventSenderQt.cpp: 22751 (EventSender::addTouchPoint): 22752 (EventSender::updateTouchPoint): 22753 (EventSender::touchStart): 22754 (EventSender::touchMove): 22755 (EventSender::touchEnd): 22756 (EventSender::clearTouchPoints): 22757 (EventSender::releaseTouchPoint): 22758 (EventSender::sendTouchEvent): 22759 * DumpRenderTree/qt/EventSenderQt.h: 22760 227612009-12-11 Eric Seidel <eric@webkit.org> 22762 22763 Reviewed by Adam Barth. 22764 22765 CommandsTest.assert_execute_outputs doesn't check stderr 22766 https://bugs.webkit.org/show_bug.cgi?id=32352 22767 22768 Fix assert_execute_outputs to check stderr 22769 and then fix all the unit tests which needed to 22770 pass stderr output. 22771 22772 * Scripts/modules/commands/commandtest.py: 22773 * Scripts/modules/commands/download_unittest.py: 22774 * Scripts/modules/commands/upload_unittest.py: 22775 227762009-12-11 Adam Barth <abarth@webkit.org> 22777 22778 Reviewed by Eric Seidel. 22779 22780 [check-webkit-style] False positive for tst_QWebFrame 22781 https://bugs.webkit.org/show_bug.cgi?id=32436 22782 22783 Add an exception for function names that start with "tst_". These are 22784 used by the Qt unit testing framework. 22785 22786 * Scripts/modules/cpp_style.py: 22787 * Scripts/modules/cpp_style_unittest.py: 22788 227892009-12-11 Simon Hausmann <hausmann@webkit.org>, Kim Grönholm <kim.gronholm@nomovok.com> 22790 22791 Reviewed by Antti Koivisto. 22792 22793 Added support for creating synthetic touch events with EventSender 22794 in Qt's DumpRenderTree. 22795 22796 https://bugs.webkit.org/show_bug.cgi?id=32114 22797 22798 * DumpRenderTree/qt/EventSenderQt.cpp: 22799 (EventSender::addTouchPoint): 22800 (EventSender::updateTouchPoint): 22801 (EventSender::touchStart): 22802 (EventSender::touchMove): 22803 (EventSender::touchEnd): 22804 (EventSender::clearTouchPoints): 22805 (EventSender::releaseTouchPoint): 22806 (EventSender::sendTouchEvent): 22807 * DumpRenderTree/qt/EventSenderQt.h: 22808 228092009-12-11 Benjamin Poulain <benjamin.poulain@nokia.com> 22810 22811 Reviewed by Darin Adler. 22812 22813 The values of RuntimeArray are not enumerable 22814 https://bugs.webkit.org/show_bug.cgi?id=29005 22815 22816 * DumpRenderTree/mac/ObjCController.m: 22817 (+[ObjCController isSelectorExcludedFromWebScript:]): 22818 (+[ObjCController webScriptNameForSelector:]): 22819 (-[ObjCController arrayOfString]): 22820 228212009-12-10 Eric Seidel <eric@webkit.org> 22822 22823 No review, just updating unit tests to match recent checkins. 22824 22825 * Scripts/modules/mock_bugzillatool.py: 22826 - Add missing red_core_builders_names method causing exception. 22827 * Scripts/modules/workqueue_unittest.py: 22828 - processutils is dead, use executive.py instead. 22829 228302009-12-10 Eric Seidel <eric@webkit.org> 22831 22832 Reviewed by Adam Barth. 22833 22834 Move run_command onto Executive to make code which uses run_command testable 22835 https://bugs.webkit.org/show_bug.cgi?id=32396 22836 22837 * Scripts/modules/executive.py: 22838 - Move run_command and error handlers onto Executive. 22839 * Scripts/modules/scm.py: 22840 * Scripts/modules/scm_unittest.py: 22841 228422009-12-09 Eric Seidel <eric@webkit.org> 22843 22844 Reviewed by Adam Barth. 22845 22846 bugzilla-tool needs a command to list patches needing cq+ 22847 https://bugs.webkit.org/show_bug.cgi?id=32351 22848 22849 * Scripts/modules/bugzilla.py: 22850 - Parse attacher_email from attachment xml. 22851 * Scripts/modules/bugzilla_unittest.py: 22852 - Test new attacher_email parsing. 22853 * Scripts/modules/commands/queries.py: 22854 - Add PatchesToCommitQueue 22855 * Scripts/modules/commands/queries_unittest.py: 22856 - Tests for PatchesToCommitQueue 22857 * Scripts/modules/mock_bugzillatool.py: 22858 - Add necessary mock methods for running PatchesToCommitQueue 22859 228602009-12-10 Adam Barth <abarth@webkit.org> 22861 22862 Unreviewed. Turns out every StepSequence command needs a --quiet 22863 option. 22864 22865 * Scripts/modules/stepsequence.py: 22866 228672009-12-10 Eric Z. Ayers <zundel@google.com> 22868 22869 Reviewed by Pavel Feldman. 22870 22871 Implements displayWebView() to force an invalidation and repaint. 22872 This fixes a problem running the timeline-paint.html unit test. 22873 22874 https://bugs.webkit.org/show_bug.cgi?id=31729 22875 22876 * DumpRenderTree/gtk/DumpRenderTree.cpp: 22877 (displayWebView): 22878 228792009-12-10 Adam Barth <abarth@webkit.org> 22880 22881 Reviewed by Eric Seidel. 22882 22883 [bzt] Convert more commands to StepSequences 22884 https://bugs.webkit.org/show_bug.cgi?id=32362 22885 22886 We should eventually convert all the commands, but I'm starting with 22887 the easy ones. 22888 22889 * Scripts/modules/commands/download.py: 22890 228912009-12-10 Xan Lopez <xlopez@igalia.com> 22892 22893 Reviewed by Jan Alonzo. 22894 22895 [GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing 22896 https://bugs.webkit.org/show_bug.cgi?id=31103 22897 22898 Give focus to the webviews when we create them, since some tests expect this. 22899 22900 * DumpRenderTree/gtk/DumpRenderTree.cpp: 22901 (main): 22902 229032009-12-10 Eric Seidel <eric@webkit.org> 22904 22905 Reviewed by Adam Barth. 22906 22907 bugzilla-tool "builders are red" error should tell you which builders 22908 https://bugs.webkit.org/show_bug.cgi?id=32211 22909 22910 * Scripts/modules/buildsteps.py: 22911 229122009-12-09 Marwan Al Jubeh <marwan.aljubeh@gmail.com> 22913 22914 Reviewed by Adam Roben. 22915 22916 Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228 22917 Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically 22918 in Windows as part of running update_webkit. 22919 22920 * Scripts/update-webkit: 22921 - Run setupAppleWinEnv() on Apple's Windows port. 22922 * Scripts/webkitdirs.pm: 22923 - Added functions that return the source directory, libraries directory and default build directory on Windows. 22924 - Added isWindowsNT() which tests if the current Windows version is from the Windows NT family. 22925 - Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir 22926 and Cygwin to their desired values. 22927 229282009-12-09 Adam Barth <abarth@webkit.org> 22929 22930 Reviewed by Eric Seidel. 22931 22932 exception thrown when running apply-patches 22933 https://bugs.webkit.org/show_bug.cgi?id=32344 22934 22935 The update step now takes a port option. Once we finish the Steps 22936 refactoring, we won't have to worry about this kind of bug again. 22937 22938 * Scripts/modules/commands/download.py: 22939 229402009-12-09 Adam Barth <abarth@webkit.org> 22941 22942 Unreviewed. Fix ScriptError includes. I don't understand why these 22943 didn't throw during unit testing... 22944 22945 * Scripts/modules/commands/download.py: 22946 * Scripts/modules/logging_unittest.py: 22947 * Scripts/modules/workqueue.py: 22948 229492009-12-09 Adam Barth <abarth@webkit.org> 22950 22951 Reviewed by Eric Seidel. 22952 22953 [bzt] Remove unused PatchCollection class 22954 https://bugs.webkit.org/show_bug.cgi?id=32312 22955 22956 It's dead code. 22957 22958 * Scripts/modules/patchcollection.py: 22959 * Scripts/modules/patchcollection_unittest.py: Removed. 22960 229612009-12-09 Adam Barth <abarth@webkit.org> 22962 22963 Unreviewed "build" fix. CheckStyle needs a --no-upate option. 22964 22965 * Scripts/modules/commands/download.py: 22966 229672009-12-09 Adam Barth <abarth@webkit.org> 22968 22969 Reviewed by Eric Seidel. 22970 22971 [bzt] Convert Build to use Sequence 22972 https://bugs.webkit.org/show_bug.cgi?id=32310 22973 22974 So much prettier. 22975 22976 * Scripts/modules/buildsteps.py: 22977 * Scripts/modules/commands/download.py: 22978 * Scripts/modules/landingsequence.py: 22979 * Scripts/modules/stepsequence.py: Added. 22980 229812009-12-09 Adam Barth <abarth@webkit.org> 22982 22983 Add missing file. 22984 22985 * Scripts/modules/executive.py: Added. 22986 229872009-12-09 Adam Barth <abarth@webkit.org> 22988 22989 Unreviewed "build" fix. 22990 22991 * Scripts/modules/landingsequence.py: 22992 229932009-12-09 Adam Barth <abarth@webkit.org> 22994 22995 Reviewed by Eric Seidel. 22996 22997 [bzt] Implement abstract Steps 22998 https://bugs.webkit.org/show_bug.cgi?id=32212 22999 23000 This is a fairly disruptive change that refactors how we build 23001 commands. Instead of using a landing sequence, we can now assemble a 23002 sequence of steps directly. We still use the landing sequence in the 23003 interim, but this will be removed soon. 23004 23005 * Scripts/bugzilla-tool: 23006 * Scripts/modules/buildsteps.py: 23007 * Scripts/modules/commands/download.py: 23008 * Scripts/modules/commands/early_warning_system.py: 23009 * Scripts/modules/commands/queues.py: 23010 * Scripts/modules/commands/queues_unittest.py: 23011 * Scripts/modules/landingsequence.py: 23012 * Scripts/modules/mock_bugzillatool.py: 23013 * Scripts/modules/processutils.py: Removed. 23014 * Scripts/modules/scm.py: 23015 * Scripts/modules/scm_unittest.py: 23016 * Scripts/modules/webkitport.py: 23017 230182009-12-08 Eric Seidel <eric@webkit.org> 23019 23020 Reviewed by Adam Barth. 23021 23022 run_command and ScriptError should move into processutils.py 23023 https://bugs.webkit.org/show_bug.cgi?id=32305 23024 23025 Turns out there are a zillion callers to run_command. 23026 23027 * Scripts/modules/commands/download.py: 23028 * Scripts/modules/commands/early_warning_system.py: 23029 * Scripts/modules/commands/queues.py: 23030 * Scripts/modules/landingsequence.py: 23031 * Scripts/modules/logging_unittest.py: 23032 * Scripts/modules/processutils.py: 23033 * Scripts/modules/scm.py: 23034 * Scripts/modules/scm_unittest.py: 23035 * Scripts/modules/workqueue.py: 23036 * Scripts/modules/workqueue_unittest.py: 23037 230382009-12-08 Kevin Watters <kevinwatters@gmail.com> 23039 23040 Reviewed by Kevin Ollivier. 23041 23042 [wx] Mac plugins support. 23043 23044 https://bugs.webkit.org/show_bug.cgi?id=32236 23045 23046 * wx/browser/wscript: 23047 230482009-12-08 David Levin <levin@chromium.org> 23049 23050 Reviewed by Adam Barth. 23051 23052 [check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) { 23053 https://bugs.webkit.org/show_bug.cgi?id=32193 23054 23055 * Scripts/modules/cpp_style.py: For the function { rule, if there is space 23056 at the beginning of line, ignore lines which then have a macro. 23057 * Scripts/modules/cpp_style_unittest.py: Add tests to verify the 23058 new behavior. 23059 230602009-12-08 Dmitry Titov <dimich@chromium.org> 23061 23062 Rubber-stamped by David Levin. 23063 23064 Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread." 23065 It may have caused massive increase of reported leaks on the bots. 23066 https://bugs.webkit.org/show_bug.cgi?id=31639 23067 23068 * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed. 23069 230702009-12-08 Dmitry Titov <dimich@chromium.org> 23071 23072 Reviewed by Darin Adler. 23073 23074 Add asserts to RefCounted to make sure ref/deref happens on the right thread. 23075 https://bugs.webkit.org/show_bug.cgi?id=31639 23076 23077 * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added. 23078 230792009-12-08 David Levin <levin@chromium.org> 23080 23081 Reviewed by Adam Barth. 23082 23083 [check-webkit-style] False positive for camel case of JSC op codes 23084 https://bugs.webkit.org/show_bug.cgi?id=32192 23085 23086 * Scripts/modules/cpp_style.py: Added an exception for the JSC op 23087 code functions and const_iterator as well since I noticed a false 23088 positive there when testing the fix. 23089 * Scripts/modules/cpp_style_unittest.py: Added tests for these 23090 changes. 23091 230922009-12-08 Nikolas Zimmermann <nzimmermann@rim.com> 23093 23094 Rubber-stamped by Maciej Stachowiak. 23095 23096 Turn on (SVG) Filters for Win. 23097 https://bugs.webkit.org/show_bug.cgi?id=32224 23098 23099 * Scripts/webkitdirs.pm: 23100 231012009-12-08 Nikolas Zimmermann <nzimmermann@rim.com> 23102 23103 Rubber-stamped by Maciej Stachowiak. 23104 23105 Turn on (SVG) Filters for Gtk. 23106 https://bugs.webkit.org/show_bug.cgi?id=32224 23107 23108 * Scripts/build-webkit: 23109 231102009-12-07 Shinichiro Hamaji <hamaji@chromium.org> 23111 23112 Reviewed by David Levin. 23113 23114 [check-webkit-style] S_OK is a fine identifier 23115 https://bugs.webkit.org/show_bug.cgi?id=32225 23116 23117 * Scripts/modules/cpp_style.py: 23118 * Scripts/modules/cpp_style_unittest.py: 23119 231202009-12-07 Nikolas Zimmermann <nzimmermann@rim.com> 23121 23122 Rubber-stamped by Maciej Stachowiak. 23123 23124 Turn on (SVG) Filters for Qt. 23125 https://bugs.webkit.org/show_bug.cgi?id=32224 23126 23127 * Scripts/build-webkit: 23128 231292009-12-07 Yuzo Fujishima <yuzo@google.com> 23130 23131 Reviewed by Alexey Proskuryakov. 23132 23133 Make run-webkit-websocketserver log to stderr rather than to a file. 23134 https://bugs.webkit.org/show_bug.cgi?id=32234 23135 23136 * Scripts/run-webkit-websocketserver: 23137 231382009-12-07 Dmitry Titov <dimich@chromium.org> 23139 23140 Rubber-stamped by Darin Adler. 23141 23142 Remove ENABLE_SHARED_SCRIPT flags 23143 https://bugs.webkit.org/show_bug.cgi?id=32245 23144 This patch was obtained by "git revert" command and then un-reverting of ChangeLog files. 23145 23146 * Scripts/build-webkit: 23147 231482009-12-07 Simon Fraser <simon.fraser@apple.com> 23149 23150 Reviewed by Darin Adler. 23151 23152 <rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests 23153 23154 The counter that WebView used to keep track of the number of enclosed WebHTMLViews using 23155 accelerated compositing was hard to manage, and maintained incorrectly in a number of cases. 23156 This caused one compositing test make DumpRenderTree think that all subsequent tests 23157 were compositing too. 23158 23159 Replace this counter with notifications, which are only fired if a client (DRT) requests them. The 23160 notification informs the client that a WebHTMLView entered compositing mode (or an already- 23161 compositing WebHTML was added); it does not say when a view becomes uncomposited, or all 23162 compositing subviews were removed, since this is tricky to get right. 23163 23164 DumpRenderTreeWindow listens for this notification, and uses it to turn on window 23165 autodisplay, which is necessary to kick-start Core Animation rendering and animations. 23166 We ensure that window autodisplay is turned off before every test. 23167 23168 * DumpRenderTree/mac/DumpRenderTree.mm: 23169 (createWebViewAndOffscreenWindow): 23170 (resetWebViewToConsistentStateBeforeTesting): 23171 * DumpRenderTree/mac/DumpRenderTreeWindow.h: 23172 * DumpRenderTree/mac/DumpRenderTreeWindow.mm: 23173 (-[DumpRenderTreeWindow close]): 23174 (-[DumpRenderTreeWindow startListeningForAcceleratedCompositingChanges]): 23175 (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]): 23176 231772009-12-07 Nikolas Zimmermann <nzimmermann@rim.com> 23178 23179 Reviewed by Holger Hans Peter Freyther. 23180 23181 Turn on (SVG) Filters support, by default. 23182 https://bugs.webkit.org/show_bug.cgi?id=32224 23183 23184 For now only enable FILTERS build flag on WebKit/mac. Other platforms will follow soon. 23185 23186 * Scripts/build-webkit: 23187 231882009-12-07 Yaar Schnitman <yaar@chromium.org> 23189 23190 Reviewed by Darin Fisher. 23191 23192 Chromium buildbots are not red when they fail 23193 https://bugs.webkit.org/show_bug.cgi?id=32235 23194 23195 * Scripts/build-webkit: 23196 231972009-12-07 Yaar Schnitman <yaar@chromium.org> 23198 23199 Reviewed by Darin Fisher. 23200 23201 Typo in chromium linux builder 23202 https://bugs.webkit.org/show_bug.cgi?id=32238 23203 23204 * Scripts/webkitdirs.pm: 23205 232062009-12-07 Yaar Schnitman <yaar@chromium.org> 23207 23208 Reviewed by Darin Fisher. 23209 23210 fixes to build-webkit --chromium 23211 https://bugs.webkit.org/show_bug.cgi?id=32179 23212 23213 * Scripts/webkitdirs.pm: 23214 232152009-12-07 Eric Seidel <eric@webkit.org> 23216 23217 No review, just adding two recently approved committers. 23218 23219 * Scripts/modules/committers.py: 23220 232212009-12-07 Alexey Proskuryakov <ap@apple.com> 23222 23223 * Scripts/run-webkit-websocketserver: Added property svn:executable. 23224 232252009-12-07 Yuzo Fujishima <yuzo@google.com> 23226 23227 Reviewed by Alexey Proskuryakov. 23228 23229 Add run-webkit-websocketserver 23230 23231 https://bugs.webkit.org/show_bug.cgi?id=31390 23232 23233 * Scripts/run-webkit-websocketserver: Added. 23234 232352009-12-07 Steve Falkenburg <sfalken@apple.com> 23236 23237 Build fix. Be flexible about which version of ICU is used on Windows. 23238 23239 * DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2. 23240 232412009-12-07 Dirk Schulze <krit@webkit.org> 23242 23243 Not reviewed, adding myself to the reviewers list. 23244 23245 * Scripts/modules/committers.py: 23246 232472009-12-06 Eric Seidel <eric@webkit.org> 23248 23249 Reviewed by Adam Barth. 23250 23251 Add an API for uploading results files to StatusBot 23252 https://bugs.webkit.org/show_bug.cgi?id=32210 23253 23254 Add Content-Type: plain/text which was forgotten 23255 from the previous commit when I landed with land-patches 23256 instead of land-diff. 23257 23258 * QueueStatusServer/queue_status.py: 23259 232602009-12-06 Eric Seidel <eric@webkit.org> 23261 23262 Reviewed by Adam Barth. 23263 23264 Status Server needs a way to handle uploaded results 23265 https://bugs.webkit.org/show_bug.cgi?id=32209 23266 23267 * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command 23268 * QueueStatusServer/update_status.html: Add file upload. 23269 232702009-12-06 Eric Seidel <eric@webkit.org> 23271 23272 Reviewed by Adam Barth. 23273 23274 Add an API for uploading results files to StatusBot 23275 https://bugs.webkit.org/show_bug.cgi?id=32210 23276 23277 * Scripts/modules/statusbot.py: 23278 232792009-12-06 Eric Seidel <eric@webkit.org> 23280 23281 Reviewed by Adam Barth. 23282 23283 Status Server needs a way to handle uploaded results 23284 https://bugs.webkit.org/show_bug.cgi?id=32209 23285 23286 * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command 23287 * QueueStatusServer/update_status.html: Add file upload. 23288 232892009-12-06 Adam Barth <abarth@webkit.org> 23290 23291 Reviewed by Eric Seidel. 23292 23293 [bzt] BuildAttachment should not check the builders 23294 https://bugs.webkit.org/show_bug.cgi?id=32207 23295 23296 This is code that got copied here by accident when the class was created. 23297 23298 * Scripts/modules/commands/download.py: 23299 233002009-12-06 Adam Barth <abarth@webkit.org> 23301 23302 Reviewed by Eric Seidel. 23303 23304 [bzt] Make LandingSequence.update aware of ports 23305 https://bugs.webkit.org/show_bug.cgi?id=32208 23306 23307 This is required to make build work on the Chromium port because 23308 Chromium has a custom update-webkit. 23309 23310 * Scripts/modules/landingsequence.py: 23311 233122009-12-06 Adam Barth <abarth@webkit.org> 23313 23314 Reviewed by Eric Seidel. 23315 23316 Add early warning system commands to bugzilla-tool. 23317 23318 * Scripts/bugzilla-tool: 23319 * Scripts/modules/landingsequence.py: 23320 * Scripts/modules/webkitport.py: 23321 233222009-12-06 Adam Barth <abarth@webkit.org> 23323 23324 Reviewed by Eric Seidel. 23325 23326 [bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem 23327 https://bugs.webkit.org/show_bug.cgi?id=32205 23328 23329 * Scripts/modules/commands/early_warning_system.py: Added. 23330 * Scripts/modules/commands/queues.py: 23331 233322009-12-06 Dan Bernstein <mitz@apple.com> 23333 23334 Reviewed by Adele Peterson. 23335 23336 REGRESSION (r51728): update-webkit fails when the current directory is 23337 not inside a Subversion working copy 23338 https://bugs.webkit.org/show_bug.cgi?id=32204 23339 23340 * Scripts/update-webkit: Invoke isSVN() in the correct working 23341 directory. 23342 233432009-12-06 Adam Barth <abarth@webkit.org> 23344 23345 Reviewed by Eric Seidel. 23346 23347 [bzt] Rename AbstractTryQueue to AbstractReviewQueue 23348 https://bugs.webkit.org/show_bug.cgi?id=32202 23349 23350 * Scripts/modules/commands/queues.py: 23351 233522009-12-05 Adam Barth <abarth@webkit.org> 23353 23354 Reviewed by Eric Seidel. 23355 23356 [bzt] Implement ChromiumPort 23357 https://bugs.webkit.org/show_bug.cgi?id=32182 23358 23359 * Scripts/modules/webkitport.py: 23360 * Scripts/modules/webkitport_unittest.py: 23361 233622009-12-05 Adam Barth <abarth@webkit.org> 23363 23364 Reviewed by Eric Seidel. 23365 23366 Move update-webkit into BuildSteps 23367 https://bugs.webkit.org/show_bug.cgi?id=32181 23368 23369 We need to move update-webkit out of SCM.py because SCM isn't supposed to know 23370 that WebKit exists. The proper place for the knowledge of the existence of 23371 update-webkit is in WebKitPort because some ports have specialized update 23372 scripts (analogous to build-webkit). 23373 23374 * Scripts/modules/buildsteps.py: 23375 * Scripts/modules/commands/download.py: 23376 * Scripts/modules/landingsequence.py: 23377 * Scripts/modules/scm.py: 23378 * Scripts/modules/webkitport.py: 23379 233802009-12-05 Adam Barth <abarth@webkit.org> 23381 23382 Reviewed by Eric Seidel. 23383 23384 update-webkit should call git svn rebase and resolve-ChangeLogs -f 23385 https://bugs.webkit.org/show_bug.cgi?id=27162 23386 23387 Teach update-webkit about Git. I didn't add the call to 23388 resolve-ChangeLogs -f because sometimes that script goes bananas. We 23389 can iterate from here, however. 23390 23391 * Scripts/update-webkit: 23392 233932009-12-04 Yael Aharon <yael.aharon@nokia.com> 23394 23395 Unreviewed build fix. 23396 23397 [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h. 23398 23399 * DumpRenderTree/qt/DumpRenderTree.cpp: 23400 234012009-12-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 23402 23403 Reviewed by Adam Treat. 23404 23405 Add some missing methods for showing and hiding the 23406 Web Inspector. 23407 23408 * DumpRenderTree/qt/DumpRenderTree.cpp: 23409 (WebCore::WebPage::WebPage): 23410 (WebCore::WebPage::~WebPage): 23411 (WebCore::WebPage::webInspector): 23412 * DumpRenderTree/qt/DumpRenderTree.h: 23413 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 23414 (LayoutTestController::showWebInspector): 23415 (LayoutTestController::hideWebInspector): 23416 * DumpRenderTree/qt/LayoutTestControllerQt.h: 23417 234182009-12-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 23419 23420 Reviewed by Adam Treat. 23421 23422 Implement the setAllowUniversalAccessFromFileURLs method 23423 for the Qt LayoutTestController. 23424 23425 * DumpRenderTree/qt/DumpRenderTree.cpp: 23426 (WebCore::WebPage::resetSettings): 23427 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 23428 (LayoutTestController::setAllowUniversalAccessFromFileURLs): 23429 * DumpRenderTree/qt/LayoutTestControllerQt.h: 23430 234312009-12-04 Chris Fleizach <cfleizach@apple.com> 23432 23433 Reviewed by Darin Adler. 23434 23435 REGRESSION: AX: buttons now extremely repetitive 23436 https://bugs.webkit.org/show_bug.cgi?id=32164 23437 23438 * DumpRenderTree/AccessibilityUIElement.cpp: 23439 (isAttributeSupportedCallback): 23440 (AccessibilityUIElement::getJSClass): 23441 * DumpRenderTree/AccessibilityUIElement.h: 23442 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 23443 (AccessibilityUIElement::isAttributeSupported): 23444 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 23445 (AccessibilityUIElement::isAttributeSupported): 23446 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 23447 (AccessibilityUIElement::isAttributeSupported): 23448 234492009-12-03 Shinichiro Hamaji <hamaji@chromium.org> 23450 23451 Reviewed by David Levin. 23452 23453 check-webkit-style should check for camelCase variable names 23454 https://bugs.webkit.org/show_bug.cgi?id=32051 23455 23456 * Scripts/modules/cpp_style.py: 23457 * Scripts/modules/cpp_style_unittest.py: 23458 234592009-12-03 Chris Fleizach <cfleizach@apple.com> 23460 23461 Reviewed by Eric Seidel. 23462 23463 AX: VO just says "term" on many web sites 23464 https://bugs.webkit.org/show_bug.cgi?id=32139 23465 23466 * DumpRenderTree/AccessibilityUIElement.cpp: 23467 (getRoleDescriptionCallback): 23468 (AccessibilityUIElement::getJSClass): 23469 * DumpRenderTree/AccessibilityUIElement.h: 23470 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 23471 (AccessibilityUIElement::roleDescription): 23472 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 23473 (AccessibilityUIElement::roleDescription): 23474 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 23475 (AccessibilityUIElement::roleDescription): 23476 234772009-12-03 Chris Fleizach <cfleizach@apple.com> 23478 23479 Reviewed by Beth Dakin. 23480 23481 Implement WAI-ARIA scrollbar role and related property aria-orientation 23482 https://bugs.webkit.org/show_bug.cgi?id=32126 23483 23484 * DumpRenderTree/AccessibilityUIElement.cpp: 23485 (getOrientationCallback): 23486 (AccessibilityUIElement::getJSClass): 23487 * DumpRenderTree/AccessibilityUIElement.h: 23488 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 23489 (AccessibilityUIElement::orientation): 23490 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 23491 (AccessibilityUIElement::orientation): 23492 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 23493 (AccessibilityUIElement::orientation): 23494 234952009-12-03 Eric Carlson <eric.carlson@apple.com> 23496 23497 Reviewed by Adam Roben. 23498 23499 Minor correction to r51663. 23500 23501 * DumpRenderTree/win/DumpRenderTree.cpp: 23502 (addQTDirToPATH): 23503 GetEnvironmentVariable -> GetEnvironmentVariableW. 23504 235052009-12-03 Eric Carlson <eric.carlson@apple.com> 23506 23507 Reviewed by Adam Roben. 23508 23509 ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3) 23510 https://bugs.webkit.org/show_bug.cgi?id=30256 23511 23512 Add the QuickTime dll directory to the PATH environment variable so 23513 inialization can succeed. 23514 23515 * DumpRenderTree/win/DumpRenderTree.cpp: 23516 (addQTDirToPATH): 23517 (initialize): 23518 235192009-12-03 Shu Chang <Chang.Shu@nokia.com> 23520 23521 Reviewed by Kenneth Rohde Christiansen. 23522 23523 [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame. 23524 23525 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 23526 (LayoutTestController::maybeDump): 23527 235282009-12-03 Yuzo Fujishima <yuzo@google.com> 23529 23530 Reviewed by Eric Seidel. 23531 23532 Update pywebsocket to 0.4.3 23533 This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests. 23534 Stack trace is logged now in INFO level. 23535 https://bugs.webkit.org/show_bug.cgi?id=32097 23536 23537 * pywebsocket/mod_pywebsocket/dispatch.py: 23538 * pywebsocket/mod_pywebsocket/msgutil.py: 23539 * pywebsocket/mod_pywebsocket/standalone.py: 23540 * pywebsocket/mod_pywebsocket/util.py: 23541 * pywebsocket/setup.py: 23542 * pywebsocket/test/test_dispatch.py: 23543 * pywebsocket/test/test_util.py: 23544 235452009-12-03 Sam Weinig <sam@webkit.org> 23546 23547 Reviewed by Gavin Barraclough. 23548 23549 Fix JSClassRef leak. 23550 23551 * DumpRenderTree/AccessibilityController.cpp: 23552 (AccessibilityController::makeWindowObject): 23553 * DumpRenderTree/GCController.cpp: 23554 (GCController::makeWindowObject): 23555 * DumpRenderTree/LayoutTestController.cpp: 23556 (LayoutTestController::makeWindowObject): 23557 235582009-12-03 Brady Eidson <beidson@apple.com> 23559 23560 Reviewed by Sam Weinig. 23561 23562 <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API 23563 23564 Keep DRT-win building... 23565 23566 * DumpRenderTree/win/FrameLoadDelegate.h: 23567 (FrameLoadDelegate::didPushStateWithinPageForFrame): 23568 (FrameLoadDelegate::didReplaceStateWithinPageForFrame): 23569 (FrameLoadDelegate::didPopStateWithinPageForFrame): 23570 235712009-12-03 Andras Becsi <abecsi@inf.u-szeged.hu> 23572 23573 Unreviewed build fix. 23574 23575 [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM. 23576 23577 * DumpRenderTree/qt/DumpRenderTree.cpp: 23578 235792009-12-03 Andras Becsi <abecsi@inf.u-szeged.hu> 23580 23581 Reviewed by Kenneth Rohde Christiansen. 23582 23583 [Qt] Refactor DRT to not crash on tests which open child windows from javascript. 23584 Prevent DRT from showing the main view if these childs get deleted. 23585 This fixes https://bugs.webkit.org/show_bug.cgi?id=31591. 23586 23587 * DumpRenderTree/qt/DumpRenderTree.cpp: 23588 (WebCore::WebPage::WebPage): 23589 (WebCore::DumpRenderTree::DumpRenderTree): 23590 (WebCore::DumpRenderTree::~DumpRenderTree): 23591 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 23592 (WebCore::DumpRenderTree::open): 23593 (WebCore::DumpRenderTree::closeRemainingWindows): 23594 (WebCore::DumpRenderTree::createWindow): 23595 (WebCore::DumpRenderTree::windowCount): 23596 * DumpRenderTree/qt/DumpRenderTree.h: 23597 235982009-12-02 Eric Seidel <eric@webkit.org> 23599 23600 Reviewed by Adam Barth. 23601 23602 REGRESSION(51595): commit-queue is throwing exceptions 23603 https://bugs.webkit.org/show_bug.cgi?id=32083 23604 23605 * Scripts/modules/commands/queues.py: 23606 - Don't use default value of [] as it ends up getting shared. 23607 - Make log_progress accept arrays of ints as well as strings. 23608 - Return an exit code from execute() 23609 * Scripts/modules/commands/queues_unittest.py: Added. 23610 - Test to make sure log_progress will accept ints. 23611 - Test to make sure run_bugzilla_tool will accept ints. 23612 * Scripts/modules/workqueue.py: 23613 - Print the stack trace on unexpected exceptions for easier debugging. 23614 * Scripts/run-webkit-unittests: 23615 - Add queues_unittest. 23616 23617 * Scripts/modules/commands/queues.py: 23618 * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py. 23619 * Scripts/modules/mock_bugzillatool.py: 23620 * Scripts/modules/workqueue.py: 23621 * Scripts/run-webkit-unittests: 23622 236232009-12-02 David Levin <levin@chromium.org> 23624 23625 Reviewed by Adam Barth. 23626 23627 check-webkit-style is too noisy about namespace indenting issues. 23628 https://bugs.webkit.org/show_bug.cgi?id=32096 23629 23630 * Scripts/modules/cpp_style.py: 23631 Added a _FileState object to be able to track file level information. In this 23632 case, it simply tracks whether the error has already been given, so that it isn't 23633 done again. 23634 * Scripts/modules/cpp_style_unittest.py: 23635 Modified test cases to pass in the _FileState object and fix a test that expected 23636 to see the namespace error twice (now it only occurs once). No new tests because 23637 existing tests cover the change in functionality. 23638 236392009-12-01 Kevin Ollivier <kevino@theolliviers.com> 23640 23641 Reviewed by Eric Seidel. 23642 23643 [wx] Get DumpRenderTree building after waf switch. 23644 23645 https://bugs.webkit.org/show_bug.cgi?id=32041 23646 23647 * DumpRenderTree/wscript: Added. 23648 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 23649 (LayoutTestController::setTimelineProfilingEnabled): 23650 (LayoutTestController::evaluateScriptInIsolatedWorld): 23651 (LayoutTestController::disableImageLoading): 23652 (LayoutTestController::whiteListAccessFromOrigin): 23653 (LayoutTestController::counterValueForElementById): 23654 * Scripts/build-webkit: 23655 236562009-12-02 Adam Barth <abarth@webkit.org> 23657 23658 Reviewed by Eric Seidel. 23659 23660 [bzt] build-attachment shouldn't check whether the builders are red 23661 https://bugs.webkit.org/show_bug.cgi?id=32062 23662 23663 build-attachment doesn't touch the remote repository, so there isn't a 23664 need to hold off when the builders are red. 23665 23666 * Scripts/modules/commands/download.py: 23667 * Scripts/modules/landingsequence.py: 23668 236692009-12-02 Eric Seidel <eric@webkit.org> 23670 23671 Reviewed by Adam Barth. 23672 23673 REGRESSION(51590): style-queue and build-queue think their empty when they are not 23674 https://bugs.webkit.org/show_bug.cgi?id=32061 23675 23676 * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings. 23677 * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints. 23678 236792009-12-02 Eric Seidel <eric@webkit.org> 23680 23681 Reviewed by Adam Barth. 23682 23683 build-queue is throwing exceptions and complaining about 23684 lack of --no-update on build-attachment. Make it stop. 23685 23686 * Scripts/modules/buildsteps.py: 23687 * Scripts/modules/commands/download.py: 23688 236892009-12-02 Adam Barth <abarth@webkit.org> 23690 23691 Unreviewed "build" fix. Forgot to declare my variables. :( 23692 23693 * QueueStatusServer/queue_status.py: 23694 236952009-12-02 Adam Barth <abarth@webkit.org> 23696 23697 Reviewed by Eric Seidel. 23698 23699 [bzt] Implement status bubble view 23700 https://bugs.webkit.org/show_bug.cgi?id=32057 23701 23702 The status bubble is a compact representation of the queue status for a 23703 given patch. This will eventually help us reduce the comment spam from 23704 the queues. 23705 23706 * QueueStatusServer/index.html: Added HTML5 doctype for sanity. 23707 * QueueStatusServer/queue_status.py: 23708 * QueueStatusServer/status_bubble.html: Added. 23709 237102009-12-02 Eric Seidel <eric@webkit.org> 23711 23712 Reviewed by Adam Barth. 23713 23714 trim commands/*.py includes now that commands are unit tested 23715 https://bugs.webkit.org/show_bug.cgi?id=32056 23716 23717 In the course of ensuring that the unit tests still 23718 passed after this change, I had to actually make them 23719 pass in the first place. 23720 23721 * Scripts/modules/bugzilla.py: 23722 - Fix _parse_attachment_ids_request_query to return ints instead of strings. 23723 * Scripts/modules/commands/download.py: Remove unneeded imports. 23724 * Scripts/modules/commands/queries.py: Ditto. 23725 * Scripts/modules/commands/queues.py: Ditto. 23726 * Scripts/modules/commands/upload.py: Ditto. 23727 * Scripts/modules/scm_unittest.py: 23728 - Fix to expect the \n after the path since echo adds an \n. 23729 237302009-12-01 Yaar Schnitman <yaar@chromium.org> 23731 23732 build-webkit: Remove flex,bison,gperf check for chromium 23733 https://bugs.webkit.org/show_bug.cgi?id=32043 23734 23735 * Scripts/webkitdirs.pm: 23736 237372009-12-01 Chris Fleizach <cfleizach@apple.com> 23738 23739 Build fixage for Windows/GTK for DumpRenderTree. 23740 23741 WAI-ARIA: implement support for ARIA drag and drop 23742 https://bugs.webkit.org/show_bug.cgi?id=32007 23743 23744 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 23745 (AccessibilityUIElement::ariaIsGrabbed): 23746 (AccessibilityUIElement::ariaDropEffects): 23747 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 23748 (AccessibilityUIElement::ariaIsGrabbed): 23749 (AccessibilityUIElement::ariaDropEffects): 23750 237512009-12-01 Chris Fleizach <cfleizach@apple.com> 23752 23753 Reviewed by Darin Adler. 23754 23755 WAI-ARIA: implement support for ARIA drag and drop 23756 https://bugs.webkit.org/show_bug.cgi?id=32007 23757 23758 * DumpRenderTree/AccessibilityUIElement.cpp: 23759 (getARIADropEffectsCallback): 23760 (getARIAIsGrabbedCallback): 23761 (AccessibilityUIElement::getJSClass): 23762 * DumpRenderTree/AccessibilityUIElement.h: 23763 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 23764 (AccessibilityUIElement::ariaIsGrabbed): 23765 (AccessibilityUIElement::ariaDropEffects): 23766 237672009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> 23768 23769 Not reviewed. GTK DRT try 2. 23770 23771 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 23772 (LayoutTestController::sampleSVGAnimationForElementAtTime): 23773 237742009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> 23775 23776 Not reviewed. Try to fix gtk DRT build. 23777 23778 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 23779 237802009-12-01 David Levin <levin@chromium.org> 23781 23782 Reviewed by Eric Seidel. 23783 23784 check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h 23785 https://bugs.webkit.org/show_bug.cgi?id=32033 23786 23787 * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find 23788 instead of startswith. 23789 * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior. 23790 237912009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> 23792 23793 Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well. 23794 23795 * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature. 23796 237972009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> 23798 23799 Reviewed by Simon Fraser. 23800 23801 Add SVG animation test framework with 'snapshot' functionality 23802 https://bugs.webkit.org/show_bug.cgi?id=31897 23803 23804 Add new 'sampleSVGAnimationForElementAtTime' DRT method, 23805 used by the new SVG animation testing framework, implemented 23806 for qt/gtk/win/mac. 23807 23808 * DumpRenderTree/LayoutTestController.cpp: 23809 (sampleSVGAnimationForElementAtTimeCallback): 23810 (LayoutTestController::staticFunctions): 23811 * DumpRenderTree/LayoutTestController.h: 23812 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 23813 (LayoutTestController::sampleSVGAnimationForElementAtTime): 23814 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 23815 (LayoutTestController::sampleSVGAnimationForElementAtTime): 23816 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 23817 (LayoutTestController::sampleSVGAnimationForElementAtTime): 23818 * DumpRenderTree/qt/LayoutTestControllerQt.h: 23819 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 23820 (LayoutTestController::sampleSVGAnimationForElementAtTime): 23821 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 23822 (LayoutTestController::sampleSVGAnimationForElementAtTime): 23823 238242009-12-01 Adam Roben <aroben@apple.com> 23825 23826 Remove user content before running each test on Windows 23827 23828 Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows 23829 23830 Reviewed by Alexey Proskuryakov. 23831 23832 * DumpRenderTree/win/DumpRenderTree.cpp: 23833 (resetWebViewToConsistentStateBeforeTesting): Remove all user content 23834 before each test, which matches Mac. 23835 238362009-12-01 Yuzo Fujishima <yuzo@google.com> 23837 23838 Reviewed by Alexey Proskuryakov. 23839 23840 Make pywebsocket log errors to a file 23841 https://bugs.webkit.org/show_bug.cgi?id=31604 23842 23843 * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory 23844 (by passing the path to the server via a recently added -l option). 23845 238462009-12-01 Adam Roben <aroben@apple.com> 23847 23848 Fix tests that use the TestNetscapePlugin in Debug_Internal builds 23849 23850 Reviewed by Ada Chan. 23851 23852 Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use 23853 TestNetscapePlugin fail in Debug_Internal builds 23854 23855 * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin 23856 directory in Debug and Debug_All builds, but not in Debug_Internal 23857 builds. 23858 238592009-12-01 Adam Roben <aroben@apple.com> 23860 23861 Re-enable DRT's watchdog timer on Windows 23862 23863 It was accidentally disabled in r50907. 23864 23865 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 23866 (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck 23867 into an if condition. 23868 238692009-12-01 Adam Barth <abarth@webkit.org> 23870 23871 Reviewed by Eric Seidel. 23872 23873 check-webkit-style complains about #imports with / in them 23874 https://bugs.webkit.org/show_bug.cgi?id=32022 23875 23876 We need to exclude #import directives in addition to #include from the 23877 binary operator whitespace checks. 23878 23879 * Scripts/modules/cpp_style.py: 23880 * Scripts/modules/cpp_style_unittest.py: 23881 238822009-11-30 Adam Barth <abarth@webkit.org> 23883 23884 Reviewed by Eric Seidel. 23885 23886 check-webkit-style is slightly too verbose 23887 https://bugs.webkit.org/show_bug.cgi?id=32010 23888 23889 check-webkit-style prints out a bunch of "done" lines that seem redundant, 23890 especially for the style-queue. 23891 23892 * Scripts/modules/cpp_style.py: 23893 238942009-11-30 Alejandro G. Castro <alex@igalia.com> 23895 23896 Reviewed by Eric Seidel. 23897 23898 [GTK] Moved the functions that are closing the result log of the 23899 tests to the last line of the runTest function, this avoids 23900 reporting crashes in the wrong test if there is a problem when 23901 reseting the state after the test. 23902 23903 * DumpRenderTree/gtk/DumpRenderTree.cpp: 23904 (dump): 23905 (runTest): 23906 239072009-11-30 Sam Weinig <sam@webkit.org> 23908 23909 Reviewed by Geoffrey Garen. 23910 23911 Fix for https://bugs.webkit.org/show_bug.cgi?id=31286 23912 fast/js/date-proto-generic-invocation breaks another test 23913 23914 Don't cache JSClassRefs, a change to the prototype chain will 23915 last between tests. 23916 23917 * DumpRenderTree/AccessibilityController.cpp: 23918 (AccessibilityController::getJSClass): 23919 * DumpRenderTree/GCController.cpp: 23920 (GCController::getJSClass): 23921 * DumpRenderTree/GCController.h: 23922 * DumpRenderTree/LayoutTestController.cpp: 23923 (LayoutTestController::getJSClass): 23924 239252009-11-30 Yuzo Fujishima <yuzo@google.com> 23926 23927 Reviewed by Alexey Proskuryakov. 23928 23929 Update pywebsocket to 0.4.2.1. 23930 This is to fix a bug that some messages are logged to stderr even when the log file is specified. 23931 https://bugs.webkit.org/show_bug.cgi?id=31976 23932 23933 * pywebsocket/mod_pywebsocket/standalone.py: 23934 * pywebsocket/setup.py: 23935 239362009-11-30 Adam Barth <abarth@webkit.org> 23937 23938 Reviewed by Eric Seidel. 23939 23940 [bzt] Generate pass messages for style-queue 23941 https://bugs.webkit.org/show_bug.cgi?id=31995 23942 23943 With this change, the style-queue posts "pass" messages to bugs as 23944 well. Also, added more information to the state store w.r.t. passing 23945 and failing. 23946 23947 * Scripts/modules/commands/queues.py: 23948 * Scripts/modules/patchcollection.py: 23949 239502009-11-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 23951 23952 Reviewed by Simon Fraser. 23953 23954 Check for WEBKIT_TESTFONTS environment variable in 23955 run-webkit-tests, for GTK+, to have a more prominent error 23956 message. 23957 23958 * Scripts/run-webkit-tests: 23959 239602009-11-30 Yaar Schnitman <yaar@chromium.org> 23961 23962 Reviewed by Dimitri Glazkov. 23963 23964 update-webkit --chromium forces gclient sync 23965 23966 https://bugs.webkit.org/show_bug.cgi?id=31967 23967 23968 * Scripts/update-webkit-chromium: 23969 239702009-11-29 Eric Seidel <eric@webkit.org> 23971 23972 Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights. 23973 23974 * Scripts/modules/committers.py: 23975 239762009-11-29 Eric Seidel <eric@webkit.org> 23977 23978 No review, just adding missing svn property. 23979 23980 Set svn:executable property on new scripts. 23981 These were added by commit-queue commits, but the executable 23982 property was lost due to a bug in svn-apply: 23983 https://bugs.webkit.org/show_bug.cgi?id=27204 23984 23985 * Scripts/update-webkit-chromium: Added property svn:executable. 23986 * Scripts/validate-committer-lists: Added property svn:executable. 23987 239882009-11-29 Eric Seidel <eric@webkit.org> 23989 23990 Reviewed by Adam Barth. 23991 23992 Need a way to validate that committers.py includes all committers/reviewers 23993 https://bugs.webkit.org/show_bug.cgi?id=30970 23994 23995 Add a script which knows how to compare our public committer/reviewer 23996 lists and show discrepancies between them. 23997 23998 Validates mailing lists vs. committers.py: 23999 - committers.py committers missing from webkit-committers@lists 24000 - webkit-committers@lists members missing from committers.py 24001 - committers.py reviewers missing from webkit-reviewers@lists 24002 - webkit-reviewers@lists members missing from committers.py 24003 - webkit-reviewers@lists members missing from committers.py reviewer list 24004 24005 Validates committers.py vs. trunk/ SVN history: 24006 - committers who have not committed in over a year 24007 - SVN committers missing from committers.py 24008 - committers.py members who have no record in SVN. 24009 24010 All of these lists still show "false positives" until a few more committers.py updates are made, like: 24011 https://bugs.webkit.org/show_bug.cgi?id=31366 24012 24013 * Scripts/validate-committer-lists: Added. 24014 240152009-11-28 Adam Barth <abarth@webkit.org> 24016 24017 Reviewed by Eric Seidel. 24018 24019 [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes 24020 https://bugs.webkit.org/show_bug.cgi?id=31950 24021 24022 Now we cache the last status that we get back from QueueStatusServer. 24023 Eventually we'll have to do something more fancy if we want to support 24024 a "try again" button on QueueStatusServer, but we can cross that bridge 24025 when we come to it. 24026 24027 * Scripts/modules/patchcollection.py: 24028 240292009-11-28 Adam Barth <abarth@webkit.org> 24030 24031 Reviewed by Eric Seidel. 24032 24033 StyleQueue scans ~100 bug pages every 5 minutes 24034 https://bugs.webkit.org/show_bug.cgi?id=31947 24035 24036 Instead of getting the pending-review attachment ids by scanning each 24037 bug (which results in a network request), we should just get them all 24038 from webkit.org/pending-review in one shot. 24039 24040 * Scripts/modules/bugzilla.py: 24041 * Scripts/modules/bugzilla_unittest.py: 24042 * Scripts/modules/commands/queries.py: 24043 * Scripts/modules/commands/queries_unittest.py: 24044 * Scripts/modules/commands/queues.py: 24045 * Scripts/modules/mock_bugzillatool.py: 24046 * Scripts/modules/patchcollection.py: 24047 240482009-11-28 Adam Barth <abarth@webkit.org> 24049 24050 Reviewed by Eric Seidel. 24051 24052 [bzt] CC webkit-bot-watchers whenever the bots touch bugs 24053 https://bugs.webkit.org/show_bug.cgi?id=31952 24054 24055 The mailing list is open for anyone to subscribe. 24056 24057 * Scripts/modules/bugzilla.py: 24058 * Scripts/modules/commands/queues.py: 24059 240602009-11-28 Adam Barth <abarth@webkit.org> 24061 24062 Reviewed by Eric Seidel. 24063 24064 [bzt] style-queue should report style errors to bugzilla 24065 https://bugs.webkit.org/show_bug.cgi?id=31945 24066 24067 Currently, we're just logging the style errors locally. With this 24068 patch we'll actually log the errors to bugzilla. Note: I plan to run 24069 with the "local-only" logging during development. 24070 24071 * Scripts/modules/commands/queues.py: 24072 * Scripts/modules/scm.py: 24073 240742009-11-28 Adam Barth <abarth@webkit.org> 24075 24076 Reviewed by Eric Seidel. 24077 24078 [bzt] style-queue shouldn't reject patches from the commit-queue 24079 https://bugs.webkit.org/show_bug.cgi?id=31944 24080 24081 Currently the style-queue subprocess gets confused and thinks its the 24082 commit-queue. If the patch has an error, it rejects it from the 24083 commit-queue. Instead, we should have style-queue specific logic. 24084 This patch doesn't add that logic, but it gives us a callback we can 24085 use to add that logic. 24086 24087 * Scripts/modules/buildsteps.py: 24088 * Scripts/modules/commands/queues.py: 24089 * Scripts/modules/landingsequence.py: 24090 240912009-11-27 Adam Barth <abarth@webkit.org> 24092 24093 Rubber stamped by Eric Seidel. 24094 24095 Rename CommitQueueStatus to QueueStatusServer to allow for more queues. 24096 24097 * CommitQueueStatus: Removed. 24098 * CommitQueueStatus/app.yaml: Removed. 24099 * CommitQueueStatus/filters: Removed. 24100 * CommitQueueStatus/filters/__init__.py: Removed. 24101 * CommitQueueStatus/filters/webkit_extras.py: Removed. 24102 * CommitQueueStatus/index.html: Removed. 24103 * CommitQueueStatus/index.yaml: Removed. 24104 * CommitQueueStatus/queue_status.py: Removed. 24105 * CommitQueueStatus/stylesheets: Removed. 24106 * CommitQueueStatus/stylesheets/main.css: Removed. 24107 * CommitQueueStatus/update_status.html: Removed. 24108 * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus. 24109 241102009-11-27 Adam Barth <abarth@webkit.org> 24111 24112 Reviewed by Eric Seidel. 24113 24114 style-queue should only process each patch once 24115 https://bugs.webkit.org/show_bug.cgi?id=31939 24116 24117 Actually address reviewer comments! 24118 24119 * Scripts/bugzilla-tool: 24120 241212009-11-27 Adam Barth <abarth@webkit.org> 24122 24123 Reviewed by Eric Seidel. 24124 24125 [bzt] style-queue fails to apply a bunch of patches for no reason 24126 https://bugs.webkit.org/show_bug.cgi?id=31942 24127 24128 By passing --non-interactive to check-style, we convince check-style 24129 to pass --force to svn-apply, which lets it apply more patches. 24130 24131 * Scripts/modules/commands/queues.py: 24132 241332009-11-27 Adam Barth <abarth@webkit.org> 24134 24135 Reviewed by Eric Seidel. 24136 24137 [bzt] Support --status-host in style-queue 24138 https://bugs.webkit.org/show_bug.cgi?id=31941 24139 24140 * Scripts/modules/commands/queues.py: 24141 * Scripts/modules/statusbot.py: 24142 241432009-11-27 Adam Barth <abarth@webkit.org> 24144 24145 Reviewed by Eric Seidel. 24146 24147 style-queue should only process each patch once 24148 https://bugs.webkit.org/show_bug.cgi?id=31939 24149 24150 Before processing a patch, the try-queues now ask the web service 24151 whether they have already processed the patch. This is an initial cut 24152 of this functionality. I expect we're make it richer over time. 24153 24154 * Scripts/bugzilla-tool: 24155 * Scripts/modules/commands/queues.py: 24156 * Scripts/modules/patchcollection.py: 24157 241582009-11-27 Adam Barth <abarth@webkit.org> 24159 24160 Reviewed by Eric Seidel. 24161 24162 PatchStatus does not return status 24163 https://bugs.webkit.org/show_bug.cgi?id=31938 24164 24165 We need to parse attachment_id as an int. Otherwise, we can't find 24166 anything in the datastore. 24167 24168 * CommitQueueStatus/queue_status.py: 24169 241702009-11-27 Adam Barth <abarth@webkit.org> 24171 24172 Reviewed by Eric Seidel. 24173 24174 Make commit-queue status not throw an exception where there is not 24175 status 24176 https://bugs.webkit.org/show_bug.cgi?id=31936 24177 24178 We need to actually fetch the results of the query to see what's in the 24179 datastore. 24180 24181 * CommitQueueStatus/queue_status.py: 24182 241832009-11-27 Adam Barth <abarth@webkit.org> 24184 24185 Reviewed by Eric Seidel. 24186 24187 [bzt] unit test ApplyPatches and ApplyAttachment 24188 https://bugs.webkit.org/show_bug.cgi?id=31935 24189 24190 * Scripts/modules/commands/download.py: 24191 * Scripts/modules/commands/download_unittest.py: 24192 241932009-11-27 Adam Barth <abarth@webkit.org> 24194 24195 Reviewed by Eric Seidel. 24196 24197 [bzt] Unit test download commands 24198 https://bugs.webkit.org/show_bug.cgi?id=31923 24199 24200 Adds download_unittest and fixes a bug found while testing. 24201 24202 * Scripts/modules/commands/commandtest.py: 24203 * Scripts/modules/commands/download.py: 24204 Fixed a bug where we'd throw an error because [].append returns 24205 None. 24206 * Scripts/modules/commands/download_unittest.py: Added. 24207 * Scripts/modules/mock_bugzillatool.py: 24208 * Scripts/run-webkit-unittests: 24209 242102009-11-27 Adam Barth <abarth@webkit.org> 24211 24212 Unreviewed "build" fix found while writing unit tests. 24213 24214 * Scripts/modules/commands/download.py: 24215 242162009-11-27 Adam Barth <abarth@webkit.org> 24217 24218 Reviewed by Eric Seidel. 24219 24220 [bzt] Kill WebKitLandingScripts 24221 https://bugs.webkit.org/show_bug.cgi?id=31904 24222 24223 Step 6: Kill the rest. 24224 24225 * Scripts/modules/buildsteps.py: 24226 * Scripts/modules/commands/download.py: 24227 * Scripts/modules/commands/queries.py: 24228 * Scripts/modules/commands/upload.py: 24229 * Scripts/modules/landingsequence.py: 24230 * Scripts/modules/scm.py: 24231 * Scripts/modules/webkitlandingscripts.py: Removed. 24232 242332009-11-27 Adam Barth <abarth@webkit.org> 24234 24235 Reviewed by Eric Seidel. 24236 24237 [bzt] Unit test upload commands 24238 https://bugs.webkit.org/show_bug.cgi?id=31903 24239 24240 Adds unit tests for all but two of the upload commands. The two 24241 remaining ones are more difficult. I'll return to them later. The 24242 goal of these tests is just to run the commands. We can test more 24243 detailed behavior later. 24244 24245 * Scripts/modules/commands/commandtest.py: 24246 * Scripts/modules/commands/upload.py: 24247 * Scripts/modules/commands/upload_unittest.py: 24248 * Scripts/modules/mock.py: Added. 24249 * Scripts/modules/mock_bugzillatool.py: 24250 242512009-11-26 Adam Barth <abarth@webkit.org> 24252 24253 Reviewed by Eric Seidel. 24254 24255 [bzt] Kill WebKitLandingScripts 24256 https://bugs.webkit.org/show_bug.cgi?id=31904 24257 24258 Step 5: Kill run_and_throw_if_fail. 24259 24260 * Scripts/modules/buildsteps.py: 24261 * Scripts/modules/processutils.py: Added. 24262 * Scripts/modules/webkitlandingscripts.py: 24263 242642009-11-26 Adam Barth <abarth@webkit.org> 24265 24266 Reviewed by Eric Seidel. 24267 24268 [bzt] Kill WebKitLandingScripts 24269 https://bugs.webkit.org/show_bug.cgi?id=31904 24270 24271 Step 4: Kill run_webkit_script. 24272 24273 * Scripts/modules/buildsteps.py: 24274 * Scripts/modules/commands/download.py: 24275 * Scripts/modules/webkitlandingscripts.py: 24276 242772009-11-26 Adam Barth <abarth@webkit.org> 24278 24279 Reviewed by Eric Seidel. 24280 24281 [bzt] Kill WebKitLandingScripts 24282 https://bugs.webkit.org/show_bug.cgi?id=31904 24283 24284 Step 3: Kill build_webkit. 24285 24286 * Scripts/modules/buildsteps.py: 24287 * Scripts/modules/landingsequence.py: 24288 * Scripts/modules/webkitlandingscripts.py: 24289 242902009-11-26 Adam Barth <abarth@webkit.org> 24291 24292 Reviewed by Eric Seidel. 24293 24294 [bzt] Kill WebKitLandingScripts 24295 https://bugs.webkit.org/show_bug.cgi?id=31904 24296 24297 Step 2: Kill ensure_builders_are_green. 24298 24299 * Scripts/modules/buildsteps.py: 24300 * Scripts/modules/commands/download.py: 24301 * Scripts/modules/landingsequence.py: 24302 * Scripts/modules/webkitlandingscripts.py: 24303 243042009-11-26 Adam Barth <abarth@webkit.org> 24305 24306 Reviewed by Eric Seidel. 24307 24308 [bzt] Kill WebKitLandingScripts 24309 https://bugs.webkit.org/show_bug.cgi?id=31904 24310 24311 Step 1: Kill prepare_clean_working_directory and run_webkit_tests. 24312 24313 * Scripts/bugzilla-tool: 24314 * Scripts/modules/buildsteps.py: Added. 24315 * Scripts/modules/commands/download.py: 24316 * Scripts/modules/landingsequence.py: 24317 * Scripts/modules/webkitlandingscripts.py: 24318 243192009-11-26 Zoltan Horvath <zoltan@webkit.org> 24320 24321 Reviewed by Adam Barth. 24322 24323 Remove directory prefixes from linux commands 24324 24325 SCM unittests can cause errors on some systems if we use absolute reference to 24326 the commands, so directory prefixes have been removed. 24327 24328 * Scripts/modules/scm_unittest.py: 24329 243302009-11-21 Holger Hans Peter Freyther <zecke@selfish.org> 24331 24332 Reviewed by Kenneth Rohde Christiansen. 24333 24334 Link DumpRenderTree to the Qt Ui Tools 24335 https://bugs.webkit.org/show_bug.cgi?id=31203 24336 24337 Implement QWebPage::createPlugin using the Qt Ui Tools 24338 to be able to create classes like QProgressBar from within 24339 the <object></object> tags This is required for the 24340 new automatic test of Qt Plugins. 24341 24342 * DumpRenderTree/qt/DumpRenderTree.cpp: 24343 (WebCore::WebPage::createPlugin): 24344 * DumpRenderTree/qt/DumpRenderTree.h: 24345 * DumpRenderTree/qt/DumpRenderTree.pro: 24346 243472009-11-25 Yuzo Fujishima <yuzo@google.com> 24348 24349 Reviewed by Eric Seidel. 24350 24351 Update pywebsocket to 0.4.2 24352 24353 Update pywebsocket to 0.4.2 24354 https://bugs.webkit.org/show_bug.cgi?id=31861 24355 24356 * pywebsocket/example/echo_client.py: 24357 * pywebsocket/example/echo_wsh.py: 24358 * pywebsocket/mod_pywebsocket/__init__.py: 24359 * pywebsocket/mod_pywebsocket/dispatch.py: 24360 * pywebsocket/mod_pywebsocket/msgutil.py: 24361 * pywebsocket/mod_pywebsocket/standalone.py: 24362 * pywebsocket/setup.py: 24363 * pywebsocket/test/test_dispatch.py: 24364 * pywebsocket/test/test_msgutil.py: 24365 243662009-11-25 Adam Barth <abarth@webkit.org> 24367 24368 Reviewed by Eric Seidel. 24369 24370 Add unit test for mark-fixed 24371 https://bugs.webkit.org/show_bug.cgi?id=31896 24372 24373 * Scripts/modules/commands/commandtest.py: Added. 24374 * Scripts/modules/commands/queries_unittest.py: 24375 * Scripts/modules/commands/upload_unittest.py: Added. 24376 * Scripts/modules/mock_bugzillatool.py: 24377 * Scripts/run-webkit-unittests: 24378 243792009-11-25 Adam Barth <abarth@webkit.org> 24380 24381 Reviewed by Eric Seidel. 24382 24383 bugzilla-tool should have a mark-fixed command 24384 https://bugs.webkit.org/show_bug.cgi?id=31853 24385 24386 Pretty simple stuff. 24387 24388 * Scripts/modules/commands/upload.py: 24389 243902009-11-25 Eric Seidel <eric@webkit.org> 24391 24392 Reviewed by Adam Barth. 24393 24394 'bugzilla-tool help' should only show common commands like how 'git help' does 24395 https://bugs.webkit.org/show_bug.cgi?id=31772 24396 24397 I also took this opportunity to make 'help' a real Command. 24398 Making 'help' a real command required adding Command.tool (which we've wanted to do for a while). 24399 24400 * Scripts/bugzilla-tool: 24401 - change should_show_command_help to should_show_in_main_help 24402 * Scripts/modules/commands/download.py: 24403 - Mark commands as being shown in main help or not. 24404 - show_in_main_help = False is not required (default is false), 24405 but it seemed to make the commands more self-documenting. 24406 * Scripts/modules/commands/queries.py: ditto 24407 * Scripts/modules/commands/queues.py: ditto 24408 * Scripts/modules/commands/upload.py: ditto 24409 * Scripts/modules/multicommandtool.py: 24410 - Make Command hold a pointer to tool in self.tool. Most Command 24411 subclasses do not take advantage of this yet, but it was required 24412 for HelpCommand to be able to reach the tool from _help_epilog(). 24413 - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help 24414 - Move MultiCommandTool._help_epilog to Command._help_epilog 24415 - Move "help" logic into HelpCommand.execute() 24416 - Change should_show_command_help to should_show_in_main_help and add a default implementation. 24417 * Scripts/modules/multicommandtool_unittest.py: 24418 - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands' 24419 244202009-11-25 Brian Weinstein <bweinstein@apple.com> 24421 24422 Reviewed by Dan Bernstein. 24423 24424 Patch by Mark Rowe. 24425 24426 The buildbots are failing on Windows because when they were upgraded 24427 to 4.0.4, Apple Application Support was not in their path. Add it to 24428 the path to fix the buildots. 24429 24430 * Scripts/webkitdirs.pm: 24431 244322009-11-25 Csaba Osztrogonác <ossy@webkit.org> 24433 24434 Reviewed by David Kilzer. 24435 24436 run-webkit-tests doesn't accept directories/files with --skipped=only parameter 24437 https://bugs.webkit.org/show_bug.cgi?id=31799 24438 24439 * Scripts/run-webkit-tests: Fixed. 24440 244412009-11-25 Zoltan Horvath <zoltan@webkit.org> 24442 24443 Reviewed by Eric Seidel. 24444 24445 Change run_command to give back stderr by default 24446 https://bugs.webkit.org/show_bug.cgi?id=31734 24447 24448 Change run_command to give back stderr by default. 24449 Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches. 24450 Change the related unittest call. 24451 24452 * Scripts/modules/scm.py: 24453 * Scripts/modules/scm_unittest.py: 24454 244552009-11-25 Eric Seidel <eric@webkit.org> 24456 24457 Reviewed by Adam Barth. 24458 24459 Centralize required argument parsing in Command 24460 https://bugs.webkit.org/show_bug.cgi?id=31872 24461 24462 * Scripts/modules/commands/download.py: remove custom required arg message. 24463 * Scripts/modules/commands/upload.py: ditto. 24464 * Scripts/modules/multicommandtool.py: 24465 - Add _parse_required_arguments. 24466 - Pass program name off to OptionParser. 24467 - Add name() for access to tool name. 24468 - Add check_arguments_and_execute and make it return a return code. 24469 - Replace a couple uses of + with %. 24470 * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments 24471 244722009-11-25 Eric Seidel <eric@webkit.org> 24473 24474 Reviewed by Adam Barth. 24475 24476 Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests. 24477 https://bugs.webkit.org/show_bug.cgi?id=31870 24478 24479 * Scripts/modules/commands/queries_unittest.py: Use the new class. 24480 * Scripts/modules/multicommandtool_unittest.py: Ditto. 24481 * Scripts/modules/outputcapture.py: Added. 24482 244832009-11-24 Dmitry Titov <dimich@chromium.org> 24484 24485 Reviewed by Eric Seidel. 24486 24487 Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit 24488 https://bugs.webkit.org/show_bug.cgi?id=31444 24489 24490 * Scripts/build-webkit: 24491 244922009-11-24 Chris Marrin <cmarrin@apple.com> 24493 24494 Reviewed by Simon Fraser. 24495 24496 Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded 24497 https://bugs.webkit.org/show_bug.cgi?id=27314 24498 24499 Now the script allows the directories with these tests to be included on all 24500 platforms but Mac, where they behave the same as always. For all other platforms 24501 the tests need to be excluded using the Skipped files, which is currently done 24502 for all platforms (including win since we're not turned on yet) 24503 24504 * Scripts/webkitdirs.pm: 24505 245062009-11-24 Eric Seidel <eric@webkit.org> 24507 24508 Reviewed by Adam Barth. 24509 24510 queries_unittest.py should test command output 24511 https://bugs.webkit.org/show_bug.cgi?id=31845 24512 24513 * Scripts/modules/commands/queries_unittest.py: 24514 - Capture stdout and stderr and compare with expected strings. 24515 245162009-11-24 Simon Fraser <simon.fraser@apple.com> 24517 24518 No Review. 24519 24520 Fix spelling error ("depenedencies"). 24521 24522 * Scripts/build-webkit: 24523 245242009-11-24 Mark Rowe <mrowe@apple.com> 24525 24526 Land the configuration that includes the two debug GTK Linux builders. 24527 24528 * BuildSlaveSupport/build.webkit.org-config/config.json: 24529 245302009-11-24 David Kilzer <ddkilzer@apple.com> 24531 24532 <http://webkit.org/b/31840> bisect-builds broke after r50080 24533 24534 Reviewed by Dan Bernstein. 24535 24536 * Scripts/bisect-builds: 24537 (mountAndRunNightly): Switched back to using backticks to run 24538 the hdiutil command since exec() will terminate the existing 24539 script, which is not what we want. Store the output of 24540 File::Spec->devnull() in a variable for use in the hdiutil 24541 detach commands. 24542 245432009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com> 24544 24545 Reviewed by Kenneth Rohde Christiansen. 24546 24547 Include "config.h" to meet Coding Style Guidelines 24548 https://bugs.webkit.org/show_bug.cgi?id=31792 24549 24550 * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: 24551 * DumpRenderTree/qt/jsobjects.cpp: 24552 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: 24553 245542009-11-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 24555 24556 Reviewed by Oliver Hunt. 24557 24558 Implement new required function to pass test we used to pass. This 24559 change is required since r51294. 24560 24561 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 24562 (LayoutTestController::setAllowUniversalAccessFromFileURLs): 24563 245642009-11-23 Jakub Wieczorek <faw217@gmail.com> 24565 24566 Reviewed by Kenneth Rohde Christiansen. 24567 24568 [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs. 24569 https://bugs.webkit.org/show_bug.cgi?id=31775 24570 24571 LayoutTestController::dumpBackForwardList() should work with local URLs 24572 as well as with normal URLs (in http tests for instance). 24573 Currently it does not output the latter properly. 24574 24575 Unskip a bunch of passing http/navigation tests. 24576 24577 * DumpRenderTree/qt/DumpRenderTree.cpp: 24578 (WebCore::dumpHistoryItem): 24579 245802009-11-22 Chris Fleizach <cfleizach@apple.com> 24581 24582 Reviewed by Oliver Hunt. 24583 24584 ARIA: support aria-flowto 24585 https://bugs.webkit.org/show_bug.cgi?id=31762 24586 24587 * DumpRenderTree/AccessibilityUIElement.cpp: 24588 (ariaFlowToElementAtIndexCallback): 24589 (AccessibilityUIElement::getJSClass): 24590 * DumpRenderTree/AccessibilityUIElement.h: 24591 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 24592 (AccessibilityUIElement::ariaFlowToElementAtIndex): 24593 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 24594 (AccessibilityUIElement::ariaFlowToElementAtIndex): 24595 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 24596 (AccessibilityUIElement::ariaFlowToElementAtIndex): 24597 245982009-11-22 Antonio Gomes <tonikitoo@webkit.org> 24599 24600 Reviewed by Kenneth Christiansen. 24601 24602 [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen 24603 https://bugs.webkit.org/show_bug.cgi?id=31638 24604 24605 Unfreeze WorkQueue after each test execution. 24606 24607 * DumpRenderTree/qt/DumpRenderTree.cpp: 24608 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 24609 246102009-11-22 Jakub Wieczorek <faw217@gmail.com> 24611 24612 Reviewed by Adam Barth. 24613 24614 [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors 24615 for localhost and 127.0.0.1. 24616 https://bugs.webkit.org/show_bug.cgi?id=31783 24617 24618 Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now. 24619 24620 * DumpRenderTree/qt/DumpRenderTree.cpp: 24621 (WebCore::NetworkAccessManager::NetworkAccessManager): 24622 (WebCore::NetworkAccessManager::sslErrorsEncountered): 24623 (WebCore::WebPage::WebPage): 24624 * DumpRenderTree/qt/DumpRenderTree.h: 24625 246262009-11-22 Chris Evans <cevans@chromium.org> 24627 24628 Reviewed by Adam Barth. 24629 24630 Disable access to file:/// directory listings 24631 https://bugs.webkit.org/show_bug.cgi?id=31329 24632 24633 Implemented setAllowUniversalAccessFromFileURLs to support testing of 24634 file URL security. 24635 24636 * DumpRenderTree/LayoutTestController.cpp: 24637 (setAllowUniversalAccessFromFileURLsCallback): 24638 (LayoutTestController::staticFunctions): 24639 * DumpRenderTree/LayoutTestController.h: 24640 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 24641 (LayoutTestController::setAllowUniversalAccessFromFileURLs): 24642 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 24643 (LayoutTestController::setAllowUniversalAccessFromFileURLs): 24644 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 24645 (LayoutTestController::setAllowUniversalAccessFromFileURLs): 24646 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 24647 (LayoutTestController::setAllowUniversalAccessFromFileURLs): 24648 246492009-11-22 Jakub Wieczorek <faw217@gmail.com> 24650 24651 Reviewed by Kenneth Rohde Christiansen. 24652 24653 [Qt] Fix the timeout of fast/frames/frame-navigation.html 24654 https://bugs.webkit.org/show_bug.cgi?id=31638 24655 24656 The test is timeouting, because it uses the WorkQueue to load a document in one 24657 of the child frames and once the loading is finished, the DRT does not dump the 24658 tree. This is because it waits for the QWebFrame::loadFinished() signal from 24659 the main frame, while it should connect to QWebPage::loadFinished(). 24660 24661 * DumpRenderTree/qt/DumpRenderTree.cpp: 24662 (WebCore::DumpRenderTree::DumpRenderTree): 24663 246642009-11-21 Eric Seidel <eric@webkit.org> 24665 24666 Reviewed by Adam Barth. 24667 24668 bugzilla-tool --help spews way too much text 24669 https://bugs.webkit.org/show_bug.cgi?id=31771 24670 24671 * Scripts/bugzilla-tool: 24672 - Remove self.cached_scm initialization hack. 24673 * Scripts/modules/buildbot.py: 24674 - Make default_host accessible to callers. 24675 * Scripts/modules/commands/download.py: 24676 - Phrase help for all commands consistently and remove spurious help text punctuation. 24677 * Scripts/modules/commands/queries.py: Ditto. 24678 * Scripts/modules/commands/queues.py: Ditto. 24679 * Scripts/modules/commands/upload.py: Ditto. 24680 * Scripts/modules/multicommandtool.py: 24681 - Add HelpPrintingOptionParser.format_epilog to replace 24682 NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize 24683 per-command help (thus removing the need for the cached_scm hack in BugzillaTool). 24684 - Make --help only show a list of commands like "svn help" and "git help" do -- 24685 previously --help was listing all commands and options. 24686 - Sort list of commands alphabetically. 24687 246882009-11-21 Eric Seidel <eric@webkit.org> 24689 24690 No review. Fixing a typo from the previous patch for bug 31767. 24691 24692 AbstractQueue.run_bugzilla_tool throws an exception 24693 https://bugs.webkit.org/show_bug.cgi?id=31769 24694 24695 * Scripts/modules/commands/queues.py: 24696 246972009-11-21 Eric Seidel <eric@webkit.org> 24698 24699 Reviewed by Adam Barth. 24700 24701 commit-queue fails to run with "permissions error" due to bad bugzilla-tool path 24702 https://bugs.webkit.org/show_bug.cgi?id=31767 24703 24704 What we really want to test is BugzillaTool.path() instead of TrivialTool.path(). 24705 Since we don't have a good way to test BugzillaTool pieces, I've 24706 left out a test for now. 24707 24708 * Scripts/bugzilla-tool: 24709 - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue. 24710 * Scripts/modules/commands/queues.py: 24711 - Use tool.path() instead of __file__. 24712 * Scripts/modules/multicommandtool.py: 24713 - Add a new path() method to MultiComandTool. 24714 * Scripts/modules/multicommandtool_unittest.py: 24715 - Provide a path() method. Little point in testing this mock implementation. 24716 247172009-11-21 Adam Barth <abarth@webkit.org> 24718 24719 Unreviewed "build" fix. Turns out I was testing the wrong copy of 24720 WebKitTools. 24721 24722 * Scripts/modules/commands/download.py: 24723 247242009-11-21 Adam Barth <abarth@webkit.org> 24725 24726 Reviewed by Eric Seidel. 24727 24728 Convert check-style to use LandingSequence 24729 https://bugs.webkit.org/show_bug.cgi?id=31763 24730 24731 Instead of manipulating the working copy by hand, we should use the 24732 LandingSequence in CheckStyle. This will make this code eaiser to 24733 test. 24734 24735 * Scripts/modules/commands/download.py: 24736 247372009-11-20 Adam Barth <abarth@webkit.org> 24738 24739 Reviewed by Eric Seidel. 24740 24741 Unit test query commands 24742 https://bugs.webkit.org/show_bug.cgi?id=31755 24743 24744 These tests are pretty rough, but hopefully they'll grow. 24745 24746 * Scripts/modules/commands/queries_unittest.py: Added. 24747 * Scripts/modules/mock_bugzillatool.py: Added. 24748 * Scripts/run-webkit-unittests: 24749 247502009-11-20 Eric Seidel <eric@webkit.org> 24751 24752 Reviewed by Adam Barth. 24753 24754 Fix a bunch of unit test regressions from our recent bugzilla-toll hacking 24755 https://bugs.webkit.org/show_bug.cgi?id=31758 24756 24757 * Scripts/modules/multicommandtool.py: 24758 - Allow passing of explicit commands to MultiCommandTool.__init__ 24759 * Scripts/modules/multicommandtool_unittest.py: 24760 - Use new Command.name naming system. 24761 - Test Command auto-discovery. 24762 * Scripts/modules/workqueue.py: 24763 - bug_id no longer exists, use patch['bug_id'] instead. 24764 * Scripts/modules/workqueue_unittest.py: 24765 - WorkQueues require names now. 24766 - should_proceed_with_work_item must return a patch object. 24767 247682009-11-20 Chris Fleizach <cfleizach@apple.com> 24769 24770 Reviewed by Beth Dakin. 24771 24772 WAI-ARIA: add support for aria-owns 24773 https://bugs.webkit.org/show_bug.cgi?id=31702 24774 24775 * DumpRenderTree/AccessibilityUIElement.cpp: 24776 (ariaOwnsElementAtIndexCallback): 24777 (AccessibilityUIElement::getJSClass): 24778 * DumpRenderTree/AccessibilityUIElement.h: 24779 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 24780 (AccessibilityUIElement::ariaOwnsElementAtIndex): 24781 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 24782 (AccessibilityUIElement::ariaOwnsElementAtIndex): 24783 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 24784 (AccessibilityUIElement::ariaOwnsElementAtIndex): 24785 247862009-11-20 Eric Seidel <eric@webkit.org> 24787 24788 Reviewed by Adam Barth. 24789 24790 Fix exception thrown when running the commit-queue. 24791 24792 * Scripts/modules/statusbot.py: patch is optional. 24793 * Scripts/modules/workqueue.py: WorkQUeue requires a name. 24794 247952009-11-20 Eric Seidel <eric@webkit.org> 24796 24797 Reviewed by Adam Barth. 24798 24799 Teach the StatusBot how to support more than just the commit-queue 24800 https://bugs.webkit.org/show_bug.cgi?id=31754 24801 24802 * Scripts/modules/workqueue.py: Another typo. 24803 248042009-11-20 Eric Seidel <eric@webkit.org> 24805 24806 Reviewed by Adam Barth. 24807 24808 Teach the StatusBot how to support more than just the commit-queue 24809 https://bugs.webkit.org/show_bug.cgi?id=31754 24810 24811 * Scripts/modules/commands/queues.py: Fix silly typo. 24812 248132009-11-20 Eric Seidel <eric@webkit.org> 24814 24815 Reviewed by Adam Barth. 24816 24817 Teach the StatusBot how to support more than just the commit-queue 24818 https://bugs.webkit.org/show_bug.cgi?id=31754 24819 24820 * CommitQueueStatus/index.yaml: 24821 - Add indices required for the new queries. 24822 * CommitQueueStatus/queue_status.py: 24823 - Add a patch-status page and move update_status to update-status. 24824 - Only display "commit-queue" status records for the commit-queue. 24825 - Add support for a queue_name property on status records. 24826 - Fix _int_from_request to actually work. 24827 * CommitQueueStatus/update_status.html: 24828 - Add support for a queue_name on status records. 24829 - Remove unused list of bug ids. 24830 * Scripts/modules/commands/queues.py 24831 - Make the queues pass the patch instead of the bug_id to StatusBot. 24832 * Scripts/modules/statusbot.py: 24833 - Support passing the queue_name to the status updates. 24834 - Support fetching patch status with patch_status(). 24835 * Scripts/modules/workqueue.py: 24836 - Pass the patch to the StatusBot instead of the bug_id. 24837 - Let WorkQueues have a name. 24838 248392009-11-20 Adam Barth <abarth@webkit.org> 24840 24841 Reviewed by Eric Seidel. 24842 24843 Move bugzilla-tool commands into their own file 24844 https://bugs.webkit.org/show_bug.cgi?id=31752 24845 24846 This will let us write unit tests. 24847 24848 * Scripts/bugzilla-tool: 24849 * Scripts/modules/commands/__init__.py: Added. 24850 * Scripts/modules/commands/download.py: Added. 24851 * Scripts/modules/commands/queries.py: Added. 24852 * Scripts/modules/commands/queues.py: Added. 24853 * Scripts/modules/commands/upload.py: Added. 24854 * Scripts/modules/grammar.py: Added. 24855 248562009-11-20 Adam Barth <abarth@webkit.org> 24857 24858 Reviewed by Eric Seidel. 24859 24860 BuildQueue should check if the tree is currently buildable 24861 https://bugs.webkit.org/show_bug.cgi?id=31744 24862 24863 * Scripts/bugzilla-tool: 24864 * Scripts/modules/landingsequence.py: 24865 * Scripts/modules/webkitlandingscripts.py: 24866 248672009-11-20 Adam Barth <abarth@webkit.org> 24868 24869 Reviewed by Eric Seidel. 24870 24871 Move prepare_clean_working_directory into the LandingSequence 24872 https://bugs.webkit.org/show_bug.cgi?id=31743 24873 24874 * Scripts/bugzilla-tool: 24875 * Scripts/modules/landingsequence.py: 24876 248772009-11-20 Yael Aharon <yael.aharon@nokia.com> 24878 24879 Reviewed by Kenneth Rohde Christiansen. 24880 24881 NPN_ReloadPlugins does not reload the page even if reloadPages is true. 24882 https://bugs.webkit.org/show_bug.cgi?id=30460 24883 24884 Added code for calling NPN_ReloadPlugins with reloadPages true and false. 24885 24886 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 24887 (pluginInvoke): 24888 248892009-11-20 Adam Barth <abarth@webkit.org> 24890 24891 Reviewed by Eric Seidel. 24892 24893 Pass the port information to the child process 24894 https://bugs.webkit.org/show_bug.cgi?id=31736 24895 24896 We need to do this so the child process knows what to build! 24897 24898 * Scripts/bugzilla-tool: 24899 * Scripts/modules/landingsequence.py: 24900 * Scripts/modules/webkitport.py: 24901 * Scripts/modules/webkitport_unittest.py: 24902 249032009-11-20 Adam Barth <abarth@webkit.org> 24904 24905 Reviewed by Eric Seidel. 24906 24907 Support Qt port in build-queue 24908 https://bugs.webkit.org/show_bug.cgi?id=31733 24909 24910 * Scripts/bugzilla-tool: 24911 249122009-11-20 Adam Barth <abarth@webkit.org> 24913 24914 Reviewed by Eric Seidel. 24915 24916 Implement a build-queue 24917 https://bugs.webkit.org/show_bug.cgi?id=31725 24918 24919 Currently this just builds the first 10 patches in the review queue. 24920 We'll want to do something smarter soon. 24921 24922 * Scripts/bugzilla-tool: 24923 249242009-11-20 Adam Barth <abarth@webkit.org> 24925 24926 Reviewed by Eric Seidel. 24927 24928 Make commit-queue and style-queue show up in help 24929 https://bugs.webkit.org/show_bug.cgi?id=31724 24930 24931 We need to store their names on their class to make these commands 24932 properly register themselves with MultiCommandTool. 24933 24934 * Scripts/bugzilla-tool: 24935 249362009-11-20 Adam Barth <abarth@webkit.org> 24937 24938 Reviewed by Eric Seidel. 24939 24940 Implement bugzilla-tool build-attachment 24941 https://bugs.webkit.org/show_bug.cgi?id=31722 24942 24943 This command builds an attachment from bugzilla. It leaves the built 24944 patch in the working copy. 24945 24946 * Scripts/bugzilla-tool: 24947 * Scripts/modules/landingsequence.py: 24948 * Scripts/modules/webkitlandingscripts.py: 24949 249502009-11-20 Alejandro G. Castro <alex@igalia.com> 24951 24952 Reviewed by Xan Lopez. 24953 24954 [GTK] DRT release event does not create the state correctly 24955 https://bugs.webkit.org/show_bug.cgi?id=31717 24956 24957 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 24958 249592009-11-20 Eric Seidel <eric@webkit.org> 24960 24961 Reviewed by Adam Barth. 24962 24963 MultiCommandTool should find Command objects automatically instead of with a manual list 24964 https://bugs.webkit.org/show_bug.cgi?id=31710 24965 24966 * Scripts/bugzilla-tool: 24967 * Scripts/modules/multicommandtool.py: 24968 - Use some wild python-fu to crawl all the known subclasses of Command. 24969 249702009-11-20 Adam Barth <abarth@webkit.org> 24971 24972 Unreviewed "build" fix. Added missing import. 24973 24974 * Scripts/bugzilla-tool: 24975 249762009-11-20 Adam Barth <abarth@webkit.org> 24977 24978 Unreviewed "build" fix. I failed to update LandingSequence.test 24979 properly. 24980 24981 * Scripts/modules/landingsequence.py: 24982 249832009-11-20 Adam Barth <abarth@webkit.org> 24984 24985 Reviewed by Eric Seidel. 24986 24987 Create LandingSequence as the all-sing, all-dance landing class 24988 https://bugs.webkit.org/show_bug.cgi?id=31709 24989 24990 Client can inherit from this class to carefully control exactly which 24991 steps they wish to have happen in the landing sequence. 24992 24993 * Scripts/bugzilla-tool: 24994 * Scripts/modules/landingsequence.py: Added. 24995 * Scripts/modules/webkitlandingscripts.py: Added. 24996 249972009-11-19 Adam Barth <abarth@webkit.org> 24998 24999 Reviewed by Eric Seidel. 25000 25001 Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand 25002 https://bugs.webkit.org/show_bug.cgi?id=31707 25003 25004 This is to help when we implement build-attachment. 25005 25006 * Scripts/bugzilla-tool: 25007 250082009-11-19 Adam Barth <abarth@webkit.org> 25009 25010 Reviewed by Eric Seidel. 25011 25012 Support Qt port in bugzilla-tool 25013 https://bugs.webkit.org/show_bug.cgi?id=31701 25014 25015 Now we support building with Qt! 25016 25017 * Scripts/bugzilla-tool: 25018 * Scripts/modules/webkitport.py: Added. 25019 * Scripts/modules/webkitport_unittest.py: Added. 25020 * Scripts/run-webkit-unittests: 25021 250222009-11-19 Zoltan Horvath <zoltan@webkit.org> 25023 25024 Reviewed by Adam Barth. 25025 25026 Remove inserting stderr into patch in bugzilla-tool 25027 https://bugs.webkit.org/show_bug.cgi?id=29914 25028 25029 Modify SCM python module's run_command function to avoid return of stderr 25030 by default, so stderr won't be inserted into the patches. 25031 Modify the related unit test. 25032 25033 * Scripts/modules/scm.py: 25034 * Scripts/modules/scm_unittest.py: 25035 250362009-11-19 Eric Seidel <eric@webkit.org> 25037 25038 Reviewed by Adam Barth. 25039 25040 bugzilla-tool needs per-command help 25041 https://bugs.webkit.org/show_bug.cgi?id=31697 25042 25043 Added support for "bugzilla-tool help command-name" 25044 and a unit test to make sure it works. 25045 25046 * Scripts/modules/multicommandtool.py: 25047 * Scripts/modules/multicommandtool_unittest.py: 25048 250492009-11-19 Eric Seidel <eric@webkit.org> 25050 25051 Reviewed by Adam Barth. 25052 25053 Move MultiCommandTool and Command into a separate file and add some basic unit tests 25054 https://bugs.webkit.org/show_bug.cgi?id=31695 25055 25056 * Scripts/bugzilla-tool: 25057 * Scripts/modules/multicommandtool.py: Added. 25058 * Scripts/modules/multicommandtool_unittest.py: Added. 25059 * Scripts/run-webkit-unittests: 25060 250612009-11-19 Eric Seidel <eric@webkit.org> 25062 25063 No review, just adding a FIXME. 25064 25065 Split out command parsing and help printing from BugzillaTool 25066 https://bugs.webkit.org/show_bug.cgi?id=31688 25067 25068 * Scripts/bugzilla-tool: Add an extra comment about current design failures. 25069 250702009-11-19 Eric Seidel <eric@webkit.org> 25071 25072 Reviewed by Adam Barth. 25073 25074 Split out command parsing and help printing from BugzillaTool 25075 https://bugs.webkit.org/show_bug.cgi?id=31688 25076 25077 * Scripts/bugzilla-tool: 25078 - Add new MultiCommandTool class to contain option parsing and help printing logic. 25079 - Rename private methods to use _ pattern. 25080 - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command. 25081 - 25082 250832009-11-19 Eric Seidel <eric@webkit.org> 25084 25085 Reviewed by Adam Barth. 25086 25087 Re-factor help printing to use modern python idioms 25088 https://bugs.webkit.org/show_bug.cgi?id=31685 25089 25090 * Scripts/bugzilla-tool: 25091 250922009-11-19 Eric Seidel <eric@webkit.org> 25093 25094 Reviewed by Darin Adler. 25095 25096 commit-queue empty queue logs twice 25097 https://bugs.webkit.org/show_bug.cgi?id=31679 25098 25099 * Scripts/bugzilla-tool: 25100 251012009-11-19 Eric Seidel <eric@webkit.org> 25102 25103 Reviewed by Darin Adler. 25104 25105 bugzilla-tool's reviewer/committer rejection message should be clearer 25106 https://bugs.webkit.org/show_bug.cgi?id=31126 25107 25108 Add more explanatory prose to bugzilla-tool's flag permission rejection message. 25109 25110 * Scripts/modules/bugzilla.py: 25111 251122009-11-19 Eric Z. Ayers <zundel@google.com> 25113 25114 Reviewed by Pavel Feldman. 25115 25116 Forces a WM_PAINT event on calling layoutTestController.display() 25117 in order to enable the timeline-paint.html test on Windows. 25118 ::UpdateWindow() does not force an event becaue the window is 25119 not visible. 25120 25121 https://bugs.webkit.org/show_bug.cgi?id=31402 25122 25123 * DumpRenderTree/win/DumpRenderTree.cpp: 25124 (displayWebView): 25125 251262009-11-19 Michelangelo De Simone <michelangelo@webkit.org> 25127 25128 No review needed. 25129 25130 Added myself to committers list. 25131 25132 * Scripts/modules/committers.py: 25133 251342009-11-19 Adam Barth <abarth@webkit.org> 25135 25136 Reviewed by Eric Seidel. 25137 25138 Bugzilla-tool command classes should match command names 25139 https://bugs.webkit.org/show_bug.cgi?id=31666 25140 25141 I renamed all the commands except CommitMessageForCurrentDiff because 25142 the new name would conflict with an existing class. 25143 25144 * Scripts/bugzilla-tool: 25145 251462009-11-19 Pavel Feldman <pfeldman@chromium.org> 25147 25148 Reviewed by Gustavo Noronha Silva. 25149 25150 Web Inspector: Implement "show inspector" in WebKit GTK 25151 API and enable console tests. 25152 25153 https://bugs.webkit.org/show_bug.cgi?id=31669 25154 25155 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 25156 (LayoutTestController::showWebInspector): 25157 251582009-11-19 Kenneth Rohde Christiansen <kenneth@webkit.org> 25159 25160 Reviewed by Simon Hausmann. 25161 25162 Minor refactoring + more documentation. 25163 25164 * DumpRenderTree/qt/DumpRenderTree.cpp: 25165 (WebCore::clearHistory): 25166 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 25167 251682009-11-19 Fumitoshi Ukai <ukai@chromium.org> 25169 25170 Reviewed by Eric Seidel. 25171 25172 Ignore websocket tests when --no-http is specified. 25173 https://bugs.webkit.org/show_bug.cgi?id=31662 25174 25175 * Scripts/run-webkit-tests: 25176 251772009-11-18 Adam Barth <abarth@webkit.org> 25178 25179 Reviewed by Eric Seidel. 25180 25181 Normalize ' and " in bugzilla-tool 25182 https://bugs.webkit.org/show_bug.cgi?id=31655 25183 25184 We decided " is better than ' and we should be consistent. 25185 25186 * Scripts/bugzilla-tool: 25187 251882009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com> 25189 25190 Reviewed by Kenneth Rohde Christiansen. 25191 25192 [Qt] Remove support for Qt v4.3 or older versions 25193 https://bugs.webkit.org/show_bug.cgi?id=29469 25194 25195 * DumpRenderTree/qt/DumpRenderTree.pro: 25196 * DumpRenderTree/qt/ImageDiff.pro: 25197 251982009-11-18 Shinichiro Hamaji <hamaji@chromium.org> 25199 25200 Reviewed by Eric Seidel. 25201 25202 GitTest.test_create_binary_patch fails if /tmp is symlink 25203 https://bugs.webkit.org/show_bug.cgi?id=31536 25204 25205 * Scripts/modules/scm_unittest.py: 25206 252072009-11-18 Yaar Schnitman <yaar@chromium.org> 25208 25209 Reviewed by Darin Adler. 25210 25211 Configuration for Chromium Build Slaves. 25212 25213 https://bugs.webkit.org/show_bug.cgi?id=31442 25214 25215 * BuildSlaveSupport/build.webkit.org-config/config.json: 25216 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 25217 252182009-11-18 Eric Seidel <eric@webkit.org> 25219 25220 Reviewed by Darin Adler. 25221 25222 workqueue.py results in totally broken commit-queue UI 25223 https://bugs.webkit.org/show_bug.cgi?id=31645 25224 25225 * Scripts/bugzilla-tool: 25226 - Remove unneeded use of PatchCollection. 25227 - Grab a new copy of the cq'd patches every run of the queue. 25228 252292009-11-18 Sam Weinig <sam@webkit.org> 25230 25231 Reviewed by Anders Carlsson. 25232 25233 Make the Mac Geolocation API async. 25234 25235 Update DRT to use the new async Mac Geolocation API. 25236 25237 * DumpRenderTree/mac/UIDelegate.mm: 25238 (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]): 25239 252402009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com> 25241 25242 Reviewed by Kenneth Rohde Christiansen. 25243 25244 Add and option to toggle HTML5 datalist support to build-webkit 25245 https://bugs.webkit.org/show_bug.cgi?id=31599 25246 25247 * Scripts/build-webkit: 25248 252492009-11-18 Kevin Watters <kevinwatters@gmail.com> 25250 25251 Reviewed by Kevin Ollivier. 25252 25253 Enable wx plugin support using the Windows implementation as a base. 25254 25255 https://bugs.webkit.org/show_bug.cgi?id=31636 25256 25257 * wx/build/settings.py: 25258 252592009-11-18 Kenneth Rohde Christiansen <kenneth@webkit.org> 25260 25261 Reviewed by Simon Hausmann. 25262 25263 Change the initialization order so that the controllers 25264 will be created before exporting them to the JS DOM window. 25265 25266 * DumpRenderTree/qt/DumpRenderTree.cpp: 25267 (WebCore::DumpRenderTree::DumpRenderTree): 25268 252692009-11-18 Kenneth Rohde Christiansen <kenneth@webkit.org> 25270 25271 Reviewed by Simon Hausmann. 25272 25273 Fix a code copy and paste error. m_page should be page. 25274 25275 * DumpRenderTree/qt/DumpRenderTree.cpp: 25276 (WebCore::DumpRenderTree::createWindow): 25277 252782009-11-17 Mark Rowe <mrowe@apple.com> 25279 25280 Reviewed by Alexey Proskuryakov. 25281 25282 <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X 25283 25284 * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file. 25285 This prevents symlinks from confusing the descendant check. 25286 252872009-11-17 Mark Rowe <mrowe@apple.com> 25288 25289 Reviewed by Alexey Proskuryakov. 25290 25291 <http://webkit.org/b/31602> Failing to start the WebSocket server shouldnât terminate entire test run 25292 25293 If the WebSocket server fails to start have DRT load an error page in place of tests that require the 25294 server to be up rather than having run-webkit-tests abort immediately. 25295 25296 * Scripts/run-webkit-tests: 25297 252982009-11-17 Eric Seidel <eric@webkit.org> 25299 25300 Reviewed by Darin Adler. 25301 25302 commit-queue is failing to set reviewer in ChangeLogs 25303 https://bugs.webkit.org/show_bug.cgi?id=31592 25304 25305 * Scripts/bugzilla-tool: Clarify the "applying" log message. 25306 * Scripts/modules/bugzilla.py: 25307 - Add a new _validate_committer_and_reviewer function as a 25308 temporary solution until we can make a real Attachment object 25309 which knows how to fill in its committer/reviewer fields automatically. 25310 253112009-11-17 Kenneth Rohde Christiansen <kenneth@webkit.org> 25312 25313 Unreviewed buildbot fix. 25314 25315 Revert part of earlier patch and add comment, as it 25316 was causing timeouts on the buildbot. 25317 25318 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 25319 (LayoutTestController::notifyDone): 25320 253212009-11-17 Kenneth Rohde Christiansen <kenneth@webkit.org> 25322 25323 Reviewed by Oliver Hunt. 25324 25325 Make the timeout 15 sec as for the other DRT's and make 25326 it print out the same output when a test timeout. 25327 25328 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 25329 (LayoutTestController::waitUntilDone): 25330 (LayoutTestController::notifyDone): 25331 (LayoutTestController::timerEvent): 25332 253332009-11-17 Joseph Pecoraro <joepeck@webkit.org> 25334 25335 Reviewed by Timothy Hatcher. 25336 25337 Fixed typos in comments. 25338 25339 * Scripts/modules/committers.py: 25340 253412009-11-17 Pavel Feldman <pfeldman@chromium.org> 25342 25343 Reviewed by Timothy Hatcher. 25344 25345 Web Inspector: Make DRT show web inspector for tests in inspector/ folder. 25346 - Updated DRT to show/close inspector for all tests under /inspector 25347 - Introduced LayoutTestController::setTimelineProfilingEnabled and 25348 WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled 25349 - Removed reload on each inspector test 25350 - Renamed fast/inspector to fast/inspector-support in order not to trigger 25351 inspector for those. 25352 - Reimplemented timeline tests in order to get rid of reload there. 25353 - Moved tests that don't require harness into the fast group. 25354 25355 https://bugs.webkit.org/show_bug.cgi?id=31472 25356 25357 * DumpRenderTree/LayoutTestController.cpp: 25358 (setTimelineProfilingEnabledCallback): 25359 (closeWebInspectorCallback): 25360 (LayoutTestController::staticFunctions): 25361 * DumpRenderTree/LayoutTestController.h: 25362 * DumpRenderTree/gtk/DumpRenderTree.cpp: 25363 (shouldOpenWebInspector): 25364 (runTest): 25365 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 25366 (LayoutTestController::setTimelineProfilingEnabled): 25367 * DumpRenderTree/mac/DumpRenderTree.mm: 25368 (shouldOpenWebInspector): 25369 (runTest): 25370 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 25371 (LayoutTestController::setTimelineProfilingEnabled): 25372 * DumpRenderTree/win/DumpRenderTree.cpp: 25373 (shouldOpenWebInspector): 25374 (runTest): 25375 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 25376 (LayoutTestController::setTimelineProfilingEnabled): 25377 253782009-11-17 Oliver Hunt <oliver@apple.com> 25379 25380 Reviewed by Maciej Stachowiak. 25381 25382 Incorrect use of JavaScriptCore API in DumpRenderTree 25383 https://bugs.webkit.org/show_bug.cgi?id=31577 25384 25385 Return undefined rather than a literal null. 25386 25387 * DumpRenderTree/AccessibilityUIElement.cpp: 25388 (setSelectedTextRangeCallback): 25389 (incrementCallback): 25390 (decrementCallback): 25391 (showMenuCallback): 25392 253932009-11-16 Chris Fleizach <cfleizach@apple.com> 25394 25395 Reviewed by Beth Dakin. 25396 25397 AX: aria-labelledby duplicates some of its WAI-ARIA label 25398 https://bugs.webkit.org/show_bug.cgi?id=31565 25399 25400 * DumpRenderTree/AccessibilityUIElement.cpp: 25401 (titleUIElementCallback): 25402 (getIsValidCallback): 25403 (AccessibilityUIElement::getJSClass): 25404 254052009-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org> 25406 25407 Reviewed by Simon Hausmann. 25408 25409 r50942 broke output from created windows. Make the 25410 m_enableTextOutput a member of the DRT and not the 25411 WebPage. 25412 25413 * DumpRenderTree/qt/DumpRenderTree.cpp: 25414 (WebCore::WebPage::WebPage): 25415 (WebCore::WebPage::javaScriptAlert): 25416 (WebCore::WebPage::javaScriptConsoleMessage): 25417 (WebCore::WebPage::javaScriptConfirm): 25418 (WebCore::WebPage::javaScriptPrompt): 25419 (WebCore::WebPage::acceptNavigationRequest): 25420 (WebCore::DumpRenderTree::DumpRenderTree): 25421 (WebCore::DumpRenderTree::open): 25422 (WebCore::DumpRenderTree::createWindow): 25423 * DumpRenderTree/qt/DumpRenderTree.h: 25424 (WebCore::DumpRenderTree::setTextOutputEnabled): 25425 (WebCore::DumpRenderTree::isTextOutputEnabled): 25426 (WebCore::WebPage::shouldInterruptJavaScript): 25427 (WebCore::WebPage::isTextOutputEnabled): 25428 (WebCore::WebPage::setViewGeometry): 25429 254302009-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org> 25431 25432 Reviewed by Gustavo Noronha Silva. 25433 25434 Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin 25435 as the implementation is being used by at least Qt and Gtk+. 25436 25437 Update buildsystems as well. 25438 25439 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 25440 * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: 25441 * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: 25442 * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: 25443 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 25444 * GNUmakefile.am: 25445 254462009-11-16 Yuzo Fujishima <yuzo@google.com> 25447 25448 Reviewed by Alexey Proskuryakov. 25449 25450 Disable wss until all platforms support pyOpenSSL 25451 25452 https://bugs.webkit.org/show_bug.cgi?id=31479 25453 25454 * Scripts/run-webkit-tests: 25455 254562009-11-14 Antonio Gomes <tonikitoo@webkit.org> 25457 25458 Reviewed by Kenneth Christiansen. 25459 25460 [Qt] Implement load error pages support for Qt's DRT. 25461 https://bugs.webkit.org/show_bug.cgi?id=31509 25462 25463 For now, it will not be a default feature, and layout tests 25464 that want to make use of this have to explicitily call 25465 'handleErrorPages();' for the test source. 25466 25467 Any of the other DumpRenderTree's (mac, win and gtk) 25468 support handling error pages. Qt's will be the first. 25469 25470 * DumpRenderTree/qt/DumpRenderTree.cpp: 25471 (WebCore::WebPage::supportsExtension): 25472 (WebCore::WebPage::extension): 25473 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 25474 (LayoutTestController::reset): 25475 * DumpRenderTree/qt/LayoutTestControllerQt.h: 25476 (LayoutTestController::shouldHandleErrorPages): 25477 (LayoutTestController::handleErrorPages): 25478 254792009-11-16 Eric Seidel <eric@webkit.org> 25480 25481 Reviewed by Adam Barth. 25482 25483 Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment 25484 https://bugs.webkit.org/show_bug.cgi?id=31549 25485 25486 Renamed --commit-queue to --non-interactive in most places 25487 and remove the code in land-patches which is no longer needed. 25488 25489 * Scripts/bugzilla-tool: 25490 254912009-11-16 Eric Seidel <eric@webkit.org> 25492 25493 Reviewed by Adam Barth. 25494 25495 The commit-queue should use land-attachment 25496 https://bugs.webkit.org/show_bug.cgi?id=31548 25497 25498 * Scripts/bugzilla-tool: 25499 255002009-11-16 Adam Barth <abarth@webkit.org> 25501 25502 Reviewed by Eric Seidel. 25503 25504 Convert CommitQueue over to PatchCollection 25505 https://bugs.webkit.org/show_bug.cgi?id=31547 25506 25507 Also fixes a bug in workqueue and adds a test! 25508 25509 * Scripts/bugzilla-tool: 25510 * Scripts/modules/workqueue.py: 25511 * Scripts/modules/workqueue_unittest.py: 25512 255132009-11-16 Adam Barth <abarth@webkit.org> 25514 25515 Reviewed by Eric Seidel. 25516 25517 Move StyleQueue over to using PatchCollection 25518 https://bugs.webkit.org/show_bug.cgi?id=31544 25519 25520 That's what the class it's for. 25521 25522 * Scripts/bugzilla-tool: 25523 * Scripts/modules/patchcollection.py: 25524 * Scripts/modules/patchcollection_unittest.py: 25525 255262009-11-16 Eric Seidel <eric@webkit.org> 25527 25528 Reviewed by Adam Barth. 25529 25530 bugzilla-tool needs a land-attachment command 25531 https://bugs.webkit.org/show_bug.cgi?id=31546 25532 25533 * Scripts/bugzilla-tool: 25534 - Move all the logic into AbstractLandingCommand and 25535 add a new LandAttachment command subclass. 25536 - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land. 25537 255382009-11-16 Eric Seidel <eric@webkit.org> 25539 25540 Reviewed by Adam Barth. 25541 25542 Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment 25543 https://bugs.webkit.org/show_bug.cgi?id=31543 25544 25545 Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'. 25546 25547 * Scripts/bugzilla-tool: 25548 255492009-11-16 Eric Seidel <eric@webkit.org> 25550 25551 Reviewed by Adam Barth. 25552 25553 Disable the style queue from posting to the commit queue status page. 25554 25555 * Scripts/bugzilla-tool: 25556 255572009-11-16 Adam Barth <abarth@webkit.org> 25558 25559 Reviewed by Eric Seidel. 25560 25561 Implement PatchCollection 25562 https://bugs.webkit.org/show_bug.cgi?id=31541 25563 25564 This class holds a set of patches and lets clients iterate through 25565 them. Optionally, clients can install a filter. 25566 25567 * Scripts/modules/patchcollection.py: Added. 25568 * Scripts/modules/patchcollection_unittest.py: Added. 25569 * Scripts/run-webkit-unittests: 25570 255712009-11-16 Eric Seidel <eric@webkit.org> 25572 25573 Reviewed by Adam Barth. 25574 25575 bugzilla-tool land-patches will close bugs with patches r=? 25576 https://bugs.webkit.org/show_bug.cgi?id=28230 25577 25578 The commit-queue shouldn't close patches with outstanding reviews on them, 25579 even if many reviewers seem to be against multi-patch bugs. 25580 25581 * Scripts/bugzilla-tool: 25582 255832009-11-16 Eric Seidel <eric@webkit.org> 25584 25585 Reviewed by Adam Barth. 25586 25587 bugzilla-tool check-style should work with attachment ids instead of bug ids 25588 https://bugs.webkit.org/show_bug.cgi?id=31540 25589 25590 * Scripts/bugzilla-tool: 25591 255922009-11-16 Eric Seidel <eric@webkit.org> 25593 25594 Reviewed by Adam Barth. 25595 25596 WorkQueue is the only place that should know about special exit codes 25597 https://bugs.webkit.org/show_bug.cgi?id=31534 25598 25599 Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error 25600 and add tests for handling exit codes. 25601 I also cleaned up workqueue_unittest.py more. 25602 25603 * Scripts/bugzilla-tool: 25604 * Scripts/modules/workqueue.py: 25605 * Scripts/modules/workqueue_unittest.py: 25606 256072009-11-16 Eric Seidel <eric@webkit.org> 25608 25609 Reviewed by Adam Barth. 25610 25611 Re-factor workqueue_unittest to allow for more than one test. 25612 https://bugs.webkit.org/show_bug.cgi?id=31535 25613 25614 * Scripts/modules/workqueue_unittest.py: 25615 256162009-11-16 Eric Seidel <eric@webkit.org> 25617 25618 Reviewed by Adam Barth. 25619 25620 land-patches needs to be re-factored into smaller chunks 25621 https://bugs.webkit.org/show_bug.cgi?id=31532 25622 25623 * Scripts/bugzilla-tool: fix a couple obvious typos. 25624 256252009-11-16 Eric Seidel <eric@webkit.org> 25626 25627 Reviewed by Adam Barth. 25628 25629 land-patches needs to be re-factored into smaller chunks 25630 https://bugs.webkit.org/show_bug.cgi?id=31532 25631 25632 The next patch will move these methods into WebKitLandingScripts. 25633 25634 * Scripts/bugzilla-tool: 25635 - Split out _land_patch and _close_bug_if_no_active_patches. 25636 256372009-11-16 Adam Barth <abarth@webkit.org> 25638 25639 Reviewed by Eric Seidel. 25640 25641 Fix silly copy-and-paste code. I am a terrible coder. 25642 25643 * Scripts/modules/bugzilla.py: 25644 256452009-11-16 Adam Barth <abarth@webkit.org> 25646 25647 Reviewed by Eric Seidel. 25648 25649 Implement a StyleQueue 25650 https://bugs.webkit.org/show_bug.cgi?id=31537 25651 25652 The first iteration of the style queue only produces output locally. 25653 There is also a limit of 10 patches because it's not that useful to 25654 iterate through the entire review queue at this point. We can remove 25655 the limit later. 25656 25657 * Scripts/bugzilla-tool: 25658 * Scripts/modules/bugzilla.py: 25659 256602009-11-16 Adam Barth <abarth@webkit.org> 25661 25662 Reviewed by Eric Seidel. 25663 25664 Unit test WorkQueue 25665 https://bugs.webkit.org/show_bug.cgi?id=31531 25666 25667 Adds basic unit testing for WorkQueue. Just runs through one cycle. 25668 25669 * Scripts/bugzilla-tool: 25670 * Scripts/modules/statusbot.py: 25671 * Scripts/modules/workqueue.py: 25672 * Scripts/modules/workqueue_unittest.py: Added. 25673 * Scripts/run-webkit-unittests: 25674 256752009-11-16 Eric Seidel <eric@webkit.org> 25676 25677 Reviewed by Adam Barth. 25678 25679 bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs 25680 https://bugs.webkit.org/show_bug.cgi?id=31530 25681 25682 * Scripts/bugzilla-tool: 25683 256842009-11-16 Eric Seidel <eric@webkit.org> 25685 25686 Reviewed by Adam Barth. 25687 25688 bugzilla-tool needs apply-attachment 25689 https://bugs.webkit.org/show_bug.cgi?id=31528 25690 25691 * Scripts/bugzilla-tool: 25692 - Add ApplyAttachment command. 25693 - Abstract applying code into WebKitApplyingScripts. 25694 - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional. 25695 * Scripts/modules/bugzilla.py: 25696 - Add fetch_attachment and bug_id_for_attachment_id. 25697 * Scripts/modules/bugzilla_unittest.py: 25698 - Add test for new parsing. 25699 - Fix previous parsing test which broke with Adam's check-style patch (bug 31515). 25700 257012009-11-16 Eric Seidel <eric@webkit.org> 25702 25703 Reviewed by Adam Barth. 25704 25705 Document check-style's use of force_clean. 25706 25707 * Scripts/bugzilla-tool: 25708 * Scripts/modules/scm.py: 25709 257102009-11-16 Adam Barth <abarth@webkit.org> 25711 25712 Reviewed by Eric Seidel. 25713 25714 Move WorkQueue to its own file 25715 https://bugs.webkit.org/show_bug.cgi?id=31529 25716 25717 WorkQueue and WorkQueueDelegate are separate concerns from 25718 bugzilla-tool. Also added a missing include to logging.py. 25719 25720 * Scripts/bugzilla-tool: 25721 * Scripts/modules/logging.py: 25722 * Scripts/modules/workqueue.py: 25723 257242009-11-16 Adam Barth <abarth@webkit.org> 25725 25726 Reviewed by Eric Seidel. 25727 25728 Move OutputTee to logging.py. 25729 25730 * Scripts/bugzilla-tool: 25731 * Scripts/modules/logging.py: 25732 257332009-11-15 Adam Barth <abarth@webkit.org> 25734 25735 Reviewed by Eric Seidel. 25736 25737 Refactor bugzilla-tool to allow for multiple queues 25738 https://bugs.webkit.org/show_bug.cgi?id=31513 25739 25740 Divide the commit queue class into three class to make creating 25741 additional queues easier. 25742 25743 * Scripts/bugzilla-tool: 25744 257452009-11-15 Shinichiro Hamaji <hamaji@chromium.org> 25746 25747 Reviewed by Eric Seidel. 25748 25749 svn-apply may not handle git patches created by bugzilla-tool 25750 https://bugs.webkit.org/show_bug.cgi?id=31457 25751 25752 * Scripts/modules/scm.py: 25753 * Scripts/modules/scm_unittest.py: 25754 257552009-11-15 Shinichiro Hamaji <hamaji@chromium.org> 25756 25757 Reviewed by Eric Seidel. 25758 25759 bugzilla-tool should post git binary diff 25760 https://bugs.webkit.org/show_bug.cgi?id=31458 25761 25762 Add --binary option to Git.create_patch. 25763 25764 * Scripts/modules/scm.py: 25765 * Scripts/modules/scm_unittest.py: 25766 257672009-11-15 Adam Barth <abarth@webkit.org> 25768 25769 Reviewed by Darin Adler. 25770 25771 Add bugzilla-tool check-style 25772 https://bugs.webkit.org/show_bug.cgi?id=31515 25773 25774 * Scripts/bugzilla-tool: 25775 * Scripts/modules/bugzilla.py: 25776 257772009-11-13 Kenneth Rohde Christiansen <kenneth@webkit.org> 25778 25779 Reviewed by Simon Hausmann. 25780 25781 Make the Qt Linux only --valgrind feature, suppress errors 25782 defined in the SuppressedValgrindErrors file. 25783 25784 * Scripts/run-webkit-tests: 25785 257862009-11-13 Kenneth Rohde Christiansen <kenneth@webkit.org> 25787 25788 Reviewed by Simon Hausmann. 25789 25790 Set the locale to C and not to the current one in use on the system. 25791 25792 * DumpRenderTree/qt/DumpRenderTree.cpp: 25793 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 25794 257952009-11-13 Adam Roben <aroben@apple.com> 25796 25797 Add support for 25798 http/tests/security/isolatedWorld/didClearWindowObject.html 25799 25800 Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when 25801 window objects in isolated worlds are cleared 25802 25803 Reviewed by Dave Hyatt. 25804 25805 * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld. 25806 25807 * DumpRenderTree/mac/FrameLoadDelegate.mm: 25808 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): 25809 Added. Moved code here from -webView:didClearWindowObject:forFrame:. 25810 (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]): 25811 Added. Sets a __worldID property on the global object whose value is 25812 the ID of this world. 25813 (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]): 25814 Respond to this new delegate callback by calling through to one of the 25815 above new methods. 25816 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 25817 (worldMap): Added. Returns a HashMap containing all the worlds we've 25818 created. 25819 (worldIDForWorld): Added. Returns the ID for this world, or 0 if we 25820 haven't kept track of this world. 25821 (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap() 25822 instead of declaring our own. 25823 25824 * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld. 25825 25826 * DumpRenderTree/win/FrameLoadDelegate.cpp: 25827 (FrameLoadDelegate::didClearWindowObject): Moved code from hear to 25828 didClearWindowObjectForFrameInStandardWorld. 25829 (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld): 25830 Respond to this new delegate callback by calling through to one of the 25831 below new methods. 25832 (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld): 25833 Added. Sets a __worldID property on the gobal object whose value is 25834 the ID of this world. 25835 (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): 25836 Added. Moved code here from didClearWindowObject. 25837 25838 * DumpRenderTree/win/FrameLoadDelegate.h: Added the 25839 didClearWindowObjectForFrame* functions. 25840 25841 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 25842 (worldMap): Added. Returns a HashMap containing all the worlds we've 25843 created. 25844 (worldIDForWorld): Added. Returns the ID of this world, or 0 if we 25845 haven't kept track of this world. 25846 (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap() 25847 instead of declaring our own. 25848 258492009-11-13 Adam Roben <aroben@apple.com> 25850 25851 Finish replacing worldIDs with world objects 25852 25853 The only remaining use of worldIDs was in a method only used by DRT 25854 for the isolated worlds tests. 25855 25856 Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects 25857 25858 Reviewed by Mark Rowe. 25859 25860 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 25861 (LayoutTestController::evaluateScriptInIsolatedWorld): 25862 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 25863 (LayoutTestController::evaluateScriptInIsolatedWorld): 25864 Updated for changes to WebFrame. Now holds the map of worldID -> world 25865 at this level instead of making WebKit do it. 25866 258672009-11-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 25868 25869 Reviewed by Simon Hausmann. 25870 25871 [Qt] Ensure the DRT does not output anything until first test is run 25872 25873 * DumpRenderTree/qt/DumpRenderTree.cpp: 25874 * DumpRenderTree/qt/DumpRenderTree.h: 25875 258762009-11-13 Kenneth Rohde Christiansen <kenneth@webkit.org> 25877 25878 Reviewed by Tor Arne Vestbø. 25879 25880 Clear the undo stack in before each new test run. 25881 25882 Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes. 25883 25884 * DumpRenderTree/qt/DumpRenderTree.cpp: 25885 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 25886 258872009-11-13 Andras Becsi <becsi.andras@stud.u-szeged.hu> 25888 25889 Reviewed by Kenneth Rohde Christiansen. 25890 25891 [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController. 25892 25893 * DumpRenderTree/qt/DumpRenderTree.cpp: 25894 (WebCore::WebPage::resetSettings): 25895 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 25896 (LayoutTestController::overridePreference): 25897 258982009-11-13 Eric Seidel <eric@webkit.org> 25899 25900 Reviewed by Adam Barth. 25901 25902 Update committers.py based on svn records 25903 https://bugs.webkit.org/show_bug.cgi?id=31366 25904 25905 This list was generated using validate-committer-lists from 25906 https://bugs.webkit.org/show_bug.cgi?id=30970 25907 and makes committers.py current for committers who have 25908 committed in the last 3 years. 25909 25910 * Scripts/modules/committers.py: 25911 259122009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org> 25913 25914 Reviewed by Adam Barth. 25915 25916 The document-open.html test was flaky at times. The test invokes the layout test plugin 25917 which in its destroy stream handler opens a new document. This basically tears down the 25918 stream and the associated plugin instance. The pluginLog function in the layout test 25919 plugin attempts to retrieve the window script object on a torn down plugin instance 25920 which crashed consistently on windows in the debugger. The functions which issue 25921 these logs already have a valid window script object. We now have variants of the pluginLog 25922 function which take in a window script object with and without variable arguments. 25923 25924 https://bugs.webkit.org/show_bug.cgi?id=31067 25925 25926 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 25927 (pluginLogWithWindowObject): 25928 (pluginLogWithWindowObjectVariableArgs): 25929 (pluginLog): 25930 (notifyTestCompletion): 25931 (testDocumentOpen): 25932 (testWindowOpen): 25933 259342009-11-12 Joanmarie Diggs <joanmarie.diggs@gmail.com> 25935 25936 Reviewed by Gustavo Noronha Silva. 25937 25938 https://bugs.webkit.org/show_bug.cgi?id=30997 25939 [Gtk] Implemment AtkDocument 25940 25941 Added testing support. 25942 25943 * DumpRenderTree/AccessibilityUIElement.cpp: 25944 * DumpRenderTree/AccessibilityUIElement.h: 25945 (getDocumentEncodingCallback): 25946 (getDocumentURICallback): 25947 (AccessibilityUIElement::getJSClass): 25948 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 25949 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 25950 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 25951 (AccessibilityUIElement::documentEncoding): 25952 (AccessibilityUIElement::documentURI): 25953 259542009-11-12 Adam Roben <aroben@apple.com> 25955 25956 Replace worldIDs with world objects 25957 25958 Part of <http://webkit.org/b/31414> Implement new SPI for dealing with 25959 user scripts/stylesheets and isolated worlds 25960 25961 Reviewed by Sam Weinig. 25962 25963 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 25964 (LayoutTestController::addUserScript): 25965 (LayoutTestController::addUserStyleSheet): 25966 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 25967 (LayoutTestController::addUserScript): 25968 (LayoutTestController::addUserStyleSheet): 25969 Changed these functions to create a new WebJSWorld each time they're 25970 called and to pass that world to WebKit. 25971 259722009-11-11 Chris Fleizach <cfleizach@apple.com> 25973 25974 Reviewed by Oliver Hunt. 25975 25976 need to implement aria tree roles 25977 https://bugs.webkit.org/show_bug.cgi?id=31284 25978 25979 * DumpRenderTree/AccessibilityUIElement.cpp: 25980 (disclosedRowAtIndexCallback): 25981 (selectedRowAtIndexCallback): 25982 (isEqualCallback): 25983 (isAttributeSettableCallback): 25984 (isActionSupportedCallback): 25985 (disclosedByRowCallback): 25986 (hierarchicalLevelCallback): 25987 (AccessibilityUIElement::getJSClass): 25988 * DumpRenderTree/AccessibilityUIElement.h: 25989 (AccessibilityUIElement::isEqual): 25990 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 25991 (AccessibilityUIElement::hierarchicalLevel): 25992 (AccessibilityUIElement::disclosedRowAtIndex): 25993 (AccessibilityUIElement::selectedRowAtIndex): 25994 (AccessibilityUIElement::disclosedByRow): 25995 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 25996 (AccessibilityUIElement::getChildAtIndex): 25997 (AccessibilityUIElement::disclosedRowAtIndex): 25998 (AccessibilityUIElement::selectedRowAtIndex): 25999 (AccessibilityUIElement::titleUIElement): 26000 (AccessibilityUIElement::parentElement): 26001 (AccessibilityUIElement::disclosedByRow): 26002 (AccessibilityUIElement::hierarchicalLevel): 26003 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 26004 (AccessibilityUIElement::hierarchicalLevel): 26005 (AccessibilityUIElement::disclosedRowAtIndex): 26006 (AccessibilityUIElement::selectedRowAtIndex): 26007 (AccessibilityUIElement::disclosedByRow): 26008 260092009-11-11 Shinichiro Hamaji <hamaji@chromium.org> 26010 26011 Reviewed by Darin Adler. 26012 26013 svn-apply can not handle git binary diffs 26014 https://bugs.webkit.org/show_bug.cgi?id=26830 26015 26016 Support "literal" type git binary diffs. 26017 26018 * Scripts/VCSUtils.pm: 26019 * Scripts/modules/scm_unittest.py: 26020 * Scripts/svn-apply: 26021 260222009-11-11 Dmitry Titov <dimich@chromium.org> 26023 26024 Not reviewed, removing duplicate entry for myself in committers.py. 26025 26026 * Scripts/modules/committers.py: 26027 260282009-11-11 Alexey Proskuryakov <ap@apple.com> 26029 26030 Reviewed by Darin Adler and Mark Rowe. 26031 26032 https://bugs.webkit.org/show_bug.cgi?id=31200 26033 Tests in http/tests/security/mixedContent start to fail when new tests are added 26034 26035 * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug. 26036 260372009-11-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 26038 26039 Reviewed by Jan Alonzo. 26040 26041 Create, and display a window for the inspector, for inspector 26042 tests. 26043 26044 Need to also show/hide the inspector window to avoid having 26045 problems with code assuming it is realized 26046 https://bugs.webkit.org/show_bug.cgi?id=31347 26047 26048 * DumpRenderTree/gtk/DumpRenderTree.cpp: 26049 (webInspectorShowWindow): 26050 (webInspectorCloseWindow): 26051 (webInspectorInspectWebView): 26052 (createWebView): 26053 260542009-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org> 26055 26056 Unreviewed Qt buildbot fix. 26057 26058 My previous fix was wrong, so revert that change and fix it by 26059 returning when the document of the frame has no document element. 26060 Idea is borrowed from mac and win DRT. 26061 26062 * DumpRenderTree/qt/DumpRenderTree.cpp: 26063 (WebCore::DumpRenderTree::dumpFramesAsText): 26064 260652009-11-11 Eric Seidel <eric@webkit.org> 26066 26067 Reviewed byg Kenneth Rohde Christiansen. 26068 26069 Update Kenneth's committer record to include the email he 26070 uses on lists.webkit.org. 26071 26072 * Scripts/modules/committers.py: 26073 260742009-11-11 Eric Seidel <eric@webkit.org> 26075 26076 Reviewed by Gustavo Noronha Silva. 26077 26078 Several committers use separate email addresses for bugzilla and svn.webkit.org 26079 https://bugs.webkit.org/show_bug.cgi?id=31364 26080 26081 Update records for existing committers to include email addresses 26082 used in svn.webkit.org and lists.webkit.org. 26083 Most committers use the same email address in all 3 places, but some use 26084 separate addresses. committers.py needs record of each of these addresses. 26085 26086 * Scripts/modules/committers.py: 26087 260882009-11-11 Eric Seidel <eric@webkit.org> 26089 26090 No review, adding second email address for an existing committer. 26091 26092 Add Yong Li's second bugzilla account to his committer record. 26093 See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27 26094 26095 * Scripts/modules/committers.py: 26096 260972009-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org> 26098 26099 Reviewed by Simon Hausmann. 26100 26101 If the frame has no innerText don't append it, and 26102 do not add a newline which breaks some cross platform 26103 results. 26104 26105 * DumpRenderTree/qt/DumpRenderTree.cpp: 26106 (WebCore::DumpRenderTree::dumpFramesAsText): 26107 261082009-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org> 26109 26110 Reviewed by Simon Hausmann. 26111 26112 Implement missing functionality in the Gtk/Qt TestNetscapePlugin. 26113 26114 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 26115 (webkit_test_plugin_new_instance): 26116 (webkit_test_plugin_destroy_instance): 26117 (webkit_test_plugin_destroy_stream): 26118 261192009-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org> 26120 26121 Reviewed by Mark Rowe. 26122 26123 Implement the functionality needed by plugins/window-open.html 26124 26125 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 26126 (webkit_test_plugin_new_instance): 26127 (webkit_test_plugin_set_window): 26128 261292009-11-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 26130 26131 Reviewed by Simon Hausmann. 26132 26133 [Qt] Force -graphicssystem raster and -style windows when running DRT 26134 26135 * DumpRenderTree/qt/main.cpp: 26136 * Scripts/run-webkit-tests: 26137 261382009-11-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 26139 26140 Reviewed by Simon Hausmann. 26141 26142 Compute correct library paths for Qt 26143 26144 * Scripts/webkitdirs.pm: 26145 261462009-11-10 Mark Rowe <mrowe@apple.com> 26147 26148 Reviewed by Sam Weinig. 26149 26150 <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added 26151 26152 The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error 26153 about the validity of the self-signed certificates used in the regression tests. We would then add the 26154 host to the ignore list for SSL certificate errors and retry the request. If this happened during a test 26155 that had enabled frame load delegate logging this would result in extra log messages being generated, 26156 causing the test to fail. 26157 26158 We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any 26159 tests. 26160 26161 * DumpRenderTree/mac/DumpRenderTree.mm: 26162 (dumpRenderTree): 26163 * DumpRenderTree/mac/FrameLoadDelegate.mm: 26164 (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): 26165 261662009-11-10 Andras Becsi <becsi.andras@stud.u-szeged.hu> 26167 26168 Reviewed by Kenneth Rohde Christiansen. 26169 26170 [Qt] Remove obsolete scrollbar policy settings from DRT constructor. 26171 26172 * DumpRenderTree/qt/DumpRenderTree.cpp: 26173 (WebCore::DumpRenderTree::DumpRenderTree): 26174 261752009-11-10 Philippe Normand <pnormand@igalia.com> 26176 26177 Reviewed by Jan Alonzo. 26178 26179 [GTK] Remove WebSocket configuration from WebKitWebSettings 26180 https://bugs.webkit.org/show_bug.cgi?id=31244 26181 26182 Follow-up of r50724. Don't set the enable-web-socket property 26183 anymore. 26184 26185 * DumpRenderTree/gtk/DumpRenderTree.cpp: 26186 (resetDefaultsToConsistentValues): 26187 261882009-11-10 Oliver Hunt <oliver@apple.com> 26189 26190 Reviewed by Maciej Stachowiak. 26191 26192 Rename 3D Canvas related classes to use WebGL prefix 26193 https://bugs.webkit.org/show_bug.cgi?id=29095 26194 26195 Checkin new version of do-webcore-rename used to do the WebGL type rename, 26196 and upate webkitdirs script to new method of testing for WebGL. 26197 26198 * Scripts/do-webcore-rename: 26199 * Scripts/webkitdirs.pm: 26200 262012009-11-09 Oliver Hunt <oliver@apple.com> 26202 26203 Reviewed by Geoff Garen. 26204 26205 Make do-webcore-rename work with git. 26206 26207 * Scripts/do-webcore-rename: 26208 262092009-11-09 Simon Hausmann <simon.hausmann@nokia.com> 26210 26211 Adding Kenneth to the reviewers list. 26212 26213 * Scripts/modules/committers.py: 26214 262152009-11-09 Martin Robinson <martin.james.robinson@gmail.com> 26216 26217 Reviewed by Jan Alonzo. 26218 26219 [GTK] Expose Page::tabKeyCyclesThroughElements in the API 26220 https://bugs.webkit.org/show_bug.cgi?id=30482 26221 26222 LayoutTestControllerGtk now uses the exposed 26223 Page::tabKeyCyclesThroughElements API 26224 26225 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 26226 (LayoutTestController::setTabKeyCyclesThroughElements): 26227 262282009-11-08 Shu Chang <Chang.Shu@nokia.com> 26229 26230 Reviewed by Holger Freyther. 26231 26232 [Qt] Added support for key code 8 (backspace) in EventSenderQt. 26233 This helps to pass the test case below. Also replaced hardcoded 26234 code numbers with defined constants. 26235 https://bugs.webkit.org/show_bug.cgi?id=31185 26236 26237 Test: editing/undo/undo-deleteWord.html 26238 26239 * DumpRenderTree/qt/EventSenderQt.cpp: 26240 (EventSender::keyDown): 26241 262422009-11-07 Antonio Gomes <tonikitoo@webkit.org> 26243 26244 Reviewed by Holger Freyther. 26245 26246 [Qt] [DRT] Fix wrong logic in LayoutTestController processWork 26247 https://bugs.webkit.org/show_bug.cgi?id=31164 26248 26249 Fixed wrong logic to assume WorkQueue is done in QT's DRT. 26250 26251 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 26252 (LayoutTestController::processWork): 26253 262542009-11-05 Antonio Gomes <tonikitoo@webkit.org> 26255 26256 Reviewed by Holger Freyther. 26257 26258 [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method 26259 https://bugs.webkit.org/show_bug.cgi?id=31158 26260 26261 By invoking a script queue'd by queueScript(), 'true' was beeing returned 26262 always, which from WorkQueue prospective means that a load has been started 26263 and the queue processing should stop and wait for the load to finish. 26264 Spinning it off into a loading and a non-loading variants was the solution 26265 adopted by Mac's DRT to work around this problem. The former keeps returning 26266 'true' while the later executes the script synchronously and returns 'false' 26267 making it possible to the WorkQueue to proceed right away. 26268 26269 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 26270 (LayoutTestController::processWork): 26271 (LayoutTestController::queueLoadingScript): 26272 (LayoutTestController::queueNonLoadingScript): 26273 * DumpRenderTree/qt/LayoutTestControllerQt.h: 26274 * DumpRenderTree/qt/WorkQueueItem.h: 26275 (LoadingScriptItem::LoadingScriptItem): 26276 (LoadingScriptItem::invoke): 26277 (NonLoadingScriptItem::NonLoadingScriptItem): 26278 (NonLoadingScriptItem::invoke): 26279 262802009-11-07 Mark Rowe <mrowe@apple.com> 26281 26282 Rubber-stamped by Cameron Zwarich. 26283 26284 Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH. 26285 26286 * Scripts/commit-log-editor: 26287 262882009-11-07 Mark Rowe <mrowe@apple.com> 26289 26290 Reviewed by Darin Adler. 26291 26292 Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>. 26293 commit-log-editor does not support all the email address configurations that prepare-Changelog supports 26294 26295 Move logic for determining the name and email address to use in a ChangeLog entry from 26296 prepare-ChangeLog to VCSUtils so that commit-log-editor can use it. It wants to check 26297 whether the author of the patch matches committer, and therefore needs access to the 26298 email address that would be used in a ChangeLog entry. 26299 26300 Based on a patch by Pierre d'Herbemont. 26301 26302 * Scripts/VCSUtils.pm: 26303 * Scripts/commit-log-editor: 26304 * Scripts/prepare-ChangeLog: 26305 * Scripts/webkitdirs.pm: 26306 263072009-11-06 Anantanarayanan G Iyengar <ananta@chromium.org> 26308 26309 Reviewed by Adam Barth. 26310 26311 Added functionality to the layout test plugin to invoke document.open and 26312 window.open with default arguments. The associated webkit bug is 26313 https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically 26314 window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't 26315 work in Chromium (V8) if there is no calling javascript context. To achieve this 26316 effect we invoke these functions in the layout test plugin in the NPP_SetWindow 26317 for the window.open test case and in NPP_DestroyStream for the document.open test case. 26318 26319 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 26320 (testDocumentOpen): 26321 (testWindowOpen): 26322 (pluginAllocate): 26323 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: 26324 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 26325 (NPP_New): 26326 (NPP_SetWindow): 26327 (NPP_DestroyStream): 26328 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 26329 (NPP_New): 26330 (NPP_SetWindow): 26331 (NPP_NewStream): 26332 (NPP_DestroyStream): 26333 263342009-11-06 Eric Seidel <eric@webkit.org> 26335 26336 Reviewed by Adam Barth. 26337 26338 bugzilla-tool crashed with exception 26339 https://bugs.webkit.org/show_bug.cgi?id=31092 26340 26341 * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error. 26342 263432009-11-04 Eric Seidel <eric@webkit.org> 26344 26345 No review, just add a line which got left out of the patch uploaded for commit. 26346 26347 commit-queue is crashing when trying to reject patches after unknown failures 26348 https://bugs.webkit.org/show_bug.cgi?id=31091 26349 26350 * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash. 26351 263522009-11-04 Adam Roben <aroben@apple.com> 26353 26354 Remove bogus else clause in bugzilla-tool 26355 26356 Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool 26357 create-bug raises exception after entering bug description 26358 26359 Reviewed by David Kilzer. 26360 26361 * Scripts/bugzilla-tool: 26362 (CreateBug): else clauses are only hit if no exception is raised, so 26363 it makes no sense to try to re-raise the exception in an else clause. 26364 The exception will automatically be re-raised if it doesn't match any 26365 of the except clauses, so we don't have to do anything special here at 26366 all to get the desired behavior. 26367 263682009-11-04 Eric Seidel <eric@webkit.org> 26369 26370 Reviewed by David Kilzer. 26371 26372 svn-apply's fixChangeLogPatch function seems broken 26373 https://bugs.webkit.org/show_bug.cgi?id=30683 26374 26375 Update fixChangeLogPatch to be able to handle patches which 26376 don't start at line 1. 26377 Add unit tests for svn-apply to scm_unittest.py. 26378 26379 * Scripts/VCSUtils.pm: 26380 * Scripts/modules/scm_unittest.py: 26381 263822009-11-04 Chris Fleizach <cfleizach@apple.com> 26383 26384 Reviewed by Beth Dakin. 26385 26386 Need to implement ARIA role="combobox" 26387 https://bugs.webkit.org/show_bug.cgi?id=31096 26388 26389 * DumpRenderTree/AccessibilityUIElement.cpp: 26390 (showMenuCallback): 26391 (getIsExpandedCallback): 26392 (AccessibilityUIElement::getJSClass): 26393 * DumpRenderTree/AccessibilityUIElement.h: 26394 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 26395 (AccessibilityUIElement::isExpanded): 26396 (AccessibilityUIElement::showMenu): 26397 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 26398 (AccessibilityUIElement::isExpanded): 26399 (AccessibilityUIElement::showMenu): 26400 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 26401 (AccessibilityUIElement::isSelected): 26402 (AccessibilityUIElement::isExpanded): 26403 (AccessibilityUIElement::showMenu): 26404 264052009-11-04 Eric Seidel <eric@webkit.org> 26406 26407 Reviewed by Adam Barth. 26408 26409 commit-queue is crashing when trying to reject patches after unknown failures 26410 https://bugs.webkit.org/show_bug.cgi?id=31091 26411 26412 * Scripts/bugzilla-tool: 26413 - patch['id'] was a copy/paste mistake. This code has no 'patch' variable 26414 so we have to find out what the current patch is by asking bugzilla again. 26415 - Discovered that this code was also leaking file descriptors, so fixed that. 26416 264172009-11-04 Adam Roben <aroben@apple.com> 26418 26419 Make run-webkit-tests work for the Debug_Internal Windows 26420 configuration 26421 26422 In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug 26423 suffix. 26424 26425 Fixes <http://webkit.org/b/31123>. 26426 26427 Reviewed by Sam Weinig. 26428 26429 * Scripts/run-webkit-tests: Don't add the _debug suffix in 26430 Debug_Internal, either. 26431 264322009-11-04 Eric Seidel <eric@webkit.org> 26433 26434 Reviewed by Adam Barth. 26435 26436 committers.py needs a way to store non-bugzilla email addresses 26437 https://bugs.webkit.org/show_bug.cgi?id=31037 26438 26439 Make Committer and Reviewer constructors take a single email or a list of emails. 26440 Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email. 26441 Expose reviewers(), used by validate-committer-lists on bug 30970. 26442 26443 * Scripts/modules/committers.py: 26444 * Scripts/modules/committers_unittest.py: Added tests for the new code. 26445 264462009-11-03 Yuzo Fujishima <yuzo@google.com> 26447 26448 Reviewed by David Levin. 26449 26450 Start/Stop Web Socket and Web Socket Secure servers for layout tests. 26451 https://bugs.webkit.org/show_bug.cgi?id=27491 26452 26453 The test path determination logic is changed to handle websocket and websocket/ssl cases. 26454 The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement. 26455 26456 Functions to start or stop Web Socket servers are added. 26457 26458 * Scripts/run-webkit-tests: 26459 264602009-11-03 Eric Seidel <eric@webkit.org> 26461 26462 No review, just changing wording of log message. 26463 26464 Change log string to say "failed" instead of "rejected" 26465 when a commit fails due to an out of date checkout. 26466 This makes grepping the commit-queue log for rejected patches easier. 26467 26468 * Scripts/bugzilla-tool: 26469 264702009-11-03 Eric Seidel <eric@webkit.org> 26471 26472 No review, adding commonly known committers missing from the file. 26473 26474 * Scripts/modules/committers.py: Add committers found by looking at SVN records. 26475 264762009-11-03 Eric Seidel <eric@webkit.org> 26477 26478 No review, just sort-order cleanup. 26479 26480 * Scripts/modules/committers.py: Sort committers/reviewers alphabetically. 26481 264822009-11-03 Stephen White <senorblanco@chromium.org> 26483 26484 (Unreviewed). 26485 26486 Add myself to committers.py. 26487 26488 * Scripts/modules/committers.py: 26489 264902009-11-03 Robin Dunn <robin@alldunn.com> 26491 26492 Reviewed by Kevin Ollviier. 26493 26494 Add packaging scripts for Debian-based Linux distros. 26495 26496 https://bugs.webkit.org/show_bug.cgi?id=31075 26497 26498 * wx/packaging/build-debian-installer.py: Added. 26499 * wx/packaging/debian: Added. 26500 265012009-11-03 Dan Bernstein <mitz@apple.com> 26502 26503 Reviewed by Anders Carlsson and Beth Dakin. 26504 26505 https://bugs.webkit.org/show_bug.cgi?id=31070 26506 26507 Added an 'ondestroy' parameter to the test plug-in. When the plug-in is 26508 destroyed, it executes the value of the 'ondestroy' parameter as a 26509 script. 26510 26511 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 26512 (pluginAllocate): Initialize onDestroy. 26513 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define 26514 onDestroy. 26515 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 26516 (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if 26517 specified. 26518 (NPP_Destroy): Execute the value of 'ondestroy' as a script. 26519 265202009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com> 26521 26522 Reviewed by Xan Lopez. 26523 26524 https://bugs.webkit.org/show_bug.cgi?id=31035 26525 [GTK] some accessibility tests hitting assertion in debug builds 26526 26527 Get the correct Gtk+ object before attempting to turn it into an AtkObject. 26528 26529 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 26530 (AccessibilityController::rootElement): 26531 265322009-11-02 Chris Fleizach <cfleizach@apple.com> 26533 26534 Reviewed by Beth Dakin. 26535 26536 Support ARIA "tab" roles 26537 https://bugs.webkit.org/show_bug.cgi?id=30842 26538 26539 * DumpRenderTree/AccessibilityUIElement.cpp: 26540 * DumpRenderTree/AccessibilityUIElement.h: 26541 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 26542 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 26543 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 26544 265452009-11-01 Eric Seidel <eric@webkit.org> 26546 26547 Reviewed by David Levin. 26548 26549 buildbots should use --exit-after-N-failures 26550 https://bugs.webkit.org/show_bug.cgi?id=30809 26551 26552 Make the bots exit after 20 failures to prevent never-ending 26553 test runs where every test spends a minute crashing. 26554 26555 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 26556 265572009-11-01 Laszlo Gombos <laszlo.1.gombos@nokia.com> 26558 26559 Reviewed by Eric Seidel. 26560 26561 Turn on warnings for QtWebKit for gcc 26562 https://bugs.webkit.org/show_bug.cgi?id=30958 26563 26564 * DumpRenderTree/qt/main.cpp: 26565 (crashHandler): Mark function NO_RETURN 26566 265672009-11-01 Jessie Berlin <jberlin@webkit.org> 26568 26569 Adding myself to the committers list. 26570 26571 * Scripts/modules/committers.py: 26572 265732009-10-30 Jon Honeycutt <jhoneycutt@apple.com> 26574 26575 Fix an issue that Adam noticed in DRT. 26576 26577 Reviewed by Darin Adler. 26578 26579 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 26580 (AccessibilityUIElement::role): 26581 Get the length of the role text, and create a buffer dynamically. 26582 265832009-10-30 Eric Seidel <eric@webkit.org> 26584 26585 No review, rolling out r50105. 26586 http://trac.webkit.org/changeset/50105 26587 26588 This commit was causing: 26589 https://bugs.webkit.org/show_bug.cgi?id=30869 26590 We'll re-implement the feature a different way. 26591 26592 * Scripts/bugzilla-tool: 26593 265942009-10-29 Jon Honeycutt <jhoneycutt@apple.com> 26595 26596 Test for MSAA: Accessibility of headings is not correct 26597 26598 https://bugs.webkit.org/show_bug.cgi?id=30937 26599 26600 Reviewed by Adam Roben. 26601 26602 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 26603 (AccessibilityUIElement::role): 26604 Allow the role returned to be a BSTR. 26605 (AccessibilityUIElement::description): 26606 Fix a copy/paste error. 26607 266082009-10-29 Jon Honeycutt <jhoneycutt@apple.com> 26609 26610 Test for MSAA: Accessibility of links is wrong 26611 26612 https://bugs.webkit.org/show_bug.cgi?id=30928 26613 26614 Reviewed by Darin Adler. 26615 26616 * DumpRenderTree/AccessibilityUIElement.cpp: 26617 (getAccessibilityValueCallback): 26618 Return the accessibility value. 26619 (AccessibilityUIElement::getJSClass): 26620 Added "accessibilityValue" value. 26621 26622 * DumpRenderTree/AccessibilityUIElement.h: 26623 26624 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 26625 (AccessibilityUIElement::accessibilityValue): 26626 Stubbed. 26627 26628 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 26629 (AccessibilityUIElement::accessibilityValue): 26630 Stubbed. 26631 26632 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 26633 (AccessibilityUIElement::accessibilityValue): 26634 Get the object's value, and return it as a JS string. 26635 266362009-10-30 Kevin Ollivier <kevino@theolliviers.com> 26637 26638 Fix typo in command name used by wx build system. 26639 26640 * wx/build/build_utils.py: 26641 266422009-10-30 Adam Barth <abarth@webkit.org> 26643 26644 Reviewed by Darin Adler. 26645 26646 Patch v1 is a dumb default name for patches 26647 https://bugs.webkit.org/show_bug.cgi?id=30952 26648 26649 Let's use "Patch" instead. 26650 26651 * Scripts/bugzilla-tool: 26652 266532009-10-30 Andras Becsi <becsi.andras@stud.u-szeged.hu> 26654 26655 Unreviewed trivial buildfix. 26656 26657 [Qt] Buildfix for r50333. 26658 26659 * DumpRenderTree/qt/DumpRenderTree.pro: 26660 266612009-10-30 Antonio Gomes <tonikitoo@webkit.org> 26662 26663 Reviewed by Holger Freyther. 26664 26665 [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue 26666 https://bugs.webkit.org/show_bug.cgi?id=30953 26667 26668 DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the 26669 same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch 26670 makes qt DRT to share this implementation (as gtk and mac ports do). 26671 26672 * DumpRenderTree/qt/DumpRenderTree.pro: 26673 * DumpRenderTree/qt/WorkQueue.cpp: Removed. 26674 * DumpRenderTree/qt/WorkQueue.h: Removed. 26675 266762009-10-30 Kenneth Rohde Christiansen <kenneth@webkit.org> 26677 26678 Unreviewed potential buildbot fix. 26679 26680 Second try: Reset page history before running each test. 26681 26682 Apparently the QWebHistory::clear() keeps the current page 26683 in history which is not what we want, so we not additionally 26684 sets the history capacity to 0 (forces removing everything) 26685 and then sets it back to its original value. 26686 26687 * DumpRenderTree/qt/DumpRenderTree.cpp: 26688 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 26689 266902009-10-30 Kenneth Rohde Christiansen <kenneth@webkit.org> 26691 26692 Unreviewed potential buildbot fix. 26693 26694 Reset page history before running each test. 26695 26696 * DumpRenderTree/qt/DumpRenderTree.cpp: 26697 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 26698 266992009-10-30 Roland Steiner <rolandsteiner@chromium.org> 26700 26701 Reviewed by Eric Seidel. 26702 26703 Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak. 26704 26705 Bug 28420 - Implement HTML5 <ruby> rendering 26706 (https://bugs.webkit.org/show_bug.cgi?id=28420) 26707 26708 No new tests (no functional change). 26709 26710 * Scripts/build-webkit: 26711 267122009-10-29 Dan Bernstein <mitz@apple.com> 26713 26714 Reviewed by Mark Rowe. 26715 26716 Fix âUndefined subroutineâ errors in svn-*apply by moving the removeEOL subroutine 26717 from the two scripts that define it but donât use it to the script that uses it but doesnât 26718 define it. 26719 26720 * Scripts/VCSUtils.pm: 26721 * Scripts/svn-apply: 26722 * Scripts/svn-unapply: 26723 267242009-10-29 Xan Lopez <xlopez@igalia.com> 26725 26726 Reviewed by Gustavo Noronha. 26727 26728 Use the GTK+ main loop instead of rolling our own mini-version of 26729 it. 26730 26731 * DumpRenderTree/gtk/DumpRenderTree.cpp: 26732 (dump): 26733 (runTest): 26734 (webViewLoadFinished): 26735 267362009-10-29 Kenneth Rohde Christiansen <kenneth@webkit.org> 26737 26738 Reviewed by Oliver Hunt. 26739 26740 Implement the Qt version of DRT dumpBackForwardList(). 26741 26742 * DumpRenderTree/qt/DumpRenderTree.cpp: 26743 (WebCore::dumpHistoryItem): 26744 (WebCore::DumpRenderTree::dumpBackForwardList): 26745 267462009-10-29 Kenneth Rohde Christiansen <kenneth@webkit.org> 26747 26748 Reviewed by Adam Roben. 26749 26750 Implement DRT functionality for Qt introduced in 26751 r28690 and r28705. 26752 26753 - Implemented pathToLocalResource which exposes the functionality of 26754 converting a given unix path to the correct location on Windows. 26755 - Implemented a way to remove machine-dependent information from paths 26756 in layout test results. 26757 26758 * DumpRenderTree/qt/DumpRenderTree.cpp: 26759 (WebCore::urlSuitableForTestResult): 26760 (WebCore::WebPage::javaScriptConsoleMessage): 26761 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 26762 (LayoutTestController::pathToLocalResource): 26763 * DumpRenderTree/qt/LayoutTestControllerQt.h: 26764 267652009-10-28 Roland Steiner <rolandsteiner@chromium.org> 26766 26767 Adding myself to the committers list. 26768 26769 * Scripts/modules/committers.py: 26770 267712009-10-28 Chris Fleizach <cfleizach@apple.com> 26772 26773 Adding myself to the committers list. 26774 26775 * Scripts/modules/committers.py: 26776 267772009-10-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 26778 26779 Reviewed by Jan Alonzo. 26780 26781 [GTK] API to start inspector for a WebView 26782 https://bugs.webkit.org/show_bug.cgi?id=22551 26783 26784 Use the new inspector API to implement the LayoutTestController 26785 interfaces used to test the inspector. 26786 26787 * DumpRenderTree/gtk/DumpRenderTree.cpp: 26788 (webInspectorInspectWebView): 26789 (createWebView): 26790 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 26791 (LayoutTestController::showWebInspector): 26792 (LayoutTestController::closeWebInspector): 26793 (LayoutTestController::evaluateInWebInspector): 26794 267952009-10-28 Shinichiro Hamaji <hamaji@chromium.org> 26796 26797 Reviewed by Eric Seidel. 26798 26799 [Qt] WebFrame::counterValueForElementById must not be exposed 26800 https://bugs.webkit.org/show_bug.cgi?id=30882 26801 26802 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 26803 (LayoutTestController::counterValueForElementById): 26804 268052009-10-28 Kenneth Rohde Christiansen <kenneth@webkit.org> 26806 26807 Rubberstamped by Oliver Hunt. 26808 26809 Fix the warning: 26810 26811 "warning: ignoring return value of 'char* getcwd(char*, size_t)', 26812 declared with attribute warn_unused_result". 26813 26814 by actually checking the result. In the case it is null, an 26815 error has occoured, so treat it as the other fatal errors. 26816 26817 * DumpRenderTree/qt/DumpRenderTree.cpp: 26818 (WebCore::DumpRenderTree::initializeFonts): 26819 268202009-10-27 Shinichiro Hamaji <hamaji@chromium.org> 26821 26822 Reviewed by Darin Adler. 26823 26824 Provide a way to get counter values with layoutTestContoller 26825 https://bugs.webkit.org/show_bug.cgi?id=30555 26826 26827 Define layoutTestContoller.counterValueForElementById. 26828 26829 * DumpRenderTree/LayoutTestController.cpp: 26830 (counterValueForElementByIdCallback): 26831 (LayoutTestController::staticFunctions): 26832 * DumpRenderTree/LayoutTestController.h: 26833 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 26834 (LayoutTestController::counterValueForElementById): 26835 268362009-10-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 26837 26838 Rubberstamped by Oliver Hunt. 26839 26840 Change two methods to be internal for DRT use only. 26841 26842 Part of [Qt] Review all new API in Qt 4.6 26843 https://bugs.webkit.org/show_bug.cgi?id=29843#c11 26844 26845 * DumpRenderTree/qt/DumpRenderTree.cpp: 26846 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 26847 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 26848 (LayoutTestController::whiteListAccessFromOrigin): 26849 268502009-10-27 Eric Seidel <eric@webkit.org> 26851 26852 Reviewed by Adam Barth. 26853 26854 REGRESSION: svn-apply exits(1) when applying a patch with a file add 26855 https://bugs.webkit.org/show_bug.cgi?id=30826 26856 26857 * Scripts/svn-apply: 26858 - Add () around all system() calls. 26859 - Use the correct system() == 0 or die instead of system() or die 26860 - Add descriptive messages to all die statements. 26861 268622009-10-27 Steve Block <steveblock@google.com> 26863 26864 Reviewed by NOBODY. 26865 26866 Adds steveblock@google.com to list of committers. 26867 26868 * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers. 26869 268702009-10-27 Eric Seidel <eric@webkit.org> 26871 26872 Reviewed by Adam Barth. 26873 26874 svn-apply can exit(0) even on patch failure 26875 https://bugs.webkit.org/show_bug.cgi?id=29622 26876 26877 * Scripts/svn-apply: 26878 - Add a bunch of "or die" statements, hopefully catching all 26879 possible cases where failure could still exit(0). 26880 268812009-10-27 Eric Seidel <eric@webkit.org> 26882 26883 Reviewed by Adam Barth. 26884 26885 svn-* scripts should share code through VCSUtils.pm 26886 https://bugs.webkit.org/show_bug.cgi?id=30791 26887 26888 Just moving code into a shared location. 26889 26890 * Scripts/VCSUtils.pm: 26891 * Scripts/prepare-ChangeLog: 26892 * Scripts/resolve-ChangeLogs: 26893 * Scripts/svn-apply: 26894 * Scripts/svn-create-patch: 26895 * Scripts/svn-unapply: 26896 * Scripts/update-webkit: 26897 268982009-10-27 Vadim Zeitlin <vadim@wxwidgets.org> 26899 26900 Suppress a huge number of MSVC warnings when building wxWebKit. 26901 26902 * wx/build/settings.py: 26903 269042009-10-26 Eric Seidel <eric@webkit.org> 26905 26906 No review, just adding Mike Belshe to the committers list. 26907 26908 * Scripts/modules/committers.py: 26909 269102009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com> 26911 26912 Reviewed by Darin Adler. 26913 26914 Make .rc files compile on Windows without depending on MFC headers 26915 https://bugs.webkit.org/show_bug.cgi?id=30750 26916 26917 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use 26918 windows.h instead of afxres.h because it exists even when MFC is not 26919 installed, and is all that's needed here. 26920 26921 * FindSafari/FindSafari.rc: Ditto 26922 269232009-10-24 Eric Seidel <eric@webkit.org> 26924 26925 Reviewed by Adam Barth. 26926 26927 bugzilla-tool post-diff should know how to mark commit-queue=? 26928 https://bugs.webkit.org/show_bug.cgi?id=29202 26929 26930 * Scripts/bugzilla-tool: 26931 - Add --commit-queue option to post-diff, post-commits and create-bug. 26932 * Scripts/modules/bugzilla.py: 26933 - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch. 26934 - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch. 26935 269362009-10-23 Eric Seidel <eric@webkit.org> 26937 26938 Reviewed by Adam Barth. 26939 26940 bugzilla-tool commit-queue does not notice modifications to committers.py 26941 https://bugs.webkit.org/show_bug.cgi?id=30084 26942 26943 * Scripts/bugzilla-tool: 26944 - Make commit-queue re-exec itself instead of using while(1). 26945 - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch. 26946 - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too). 26947 269482009-10-22 Eric Seidel <eric@webkit.org> 26949 26950 Reviewed by Adam Barth. 26951 26952 commit-queue will get stuck on patches if land-patches terminates unexpectedly 26953 https://bugs.webkit.org/show_bug.cgi?id=30634 26954 26955 * Scripts/bugzilla-tool: 26956 - Add a way for land-patches to exit(2) to indicate an error, but one it has handled. 26957 - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'. 26958 269592009-10-26 Yuzo Fujishima <yuzo@google.com> 26960 26961 Reviewed by Eric Seidel. 26962 26963 Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example. 26964 26965 https://bugs.webkit.org/show_bug.cgi?id=30763 26966 26967 * pywebsocket/mod_pywebsocket/__init__.py: 26968 * pywebsocket/mod_pywebsocket/dispatch.py: 26969 * pywebsocket/mod_pywebsocket/headerparserhandler.py: 26970 * pywebsocket/mod_pywebsocket/standalone.py: 26971 * pywebsocket/setup.py: 26972 * pywebsocket/test/test_dispatch.py: 26973 269742009-10-26 Carol Szabo <carol.szabo@nokia.com> 26975 26976 Reviewed by David Levin. 26977 26978 REGRESSION: 2 failures in run-webkit-unittests 26979 https://bugs.webkit.org/show_bug.cgi?id=30645 26980 26981 * Scripts/modules/cpp_style_unittest.py: 26982 Fixed a few test scenarios which apparently lost some spaces from 26983 text literals. 26984 269852009-10-26 Kevin Ollivier <kevino@theolliviers.com> 26986 26987 wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit. 26988 26989 * Scripts/webkitdirs.pm: 26990 269912009-10-26 Csaba Osztrogonác <ossy@webkit.org> 26992 26993 Reviewed by Darin Adler. 26994 26995 Unification of using null device in perl scripts. 26996 https://bugs.webkit.org/show_bug.cgi?id=30572 26997 26998 * Scripts/VCSUtils.pm: 26999 * Scripts/bisect-builds: 27000 * Scripts/resolve-ChangeLogs: 27001 * Scripts/run-iexploder-tests: 27002 * Scripts/run-jsc: 27003 * Scripts/run-mangleme-tests: 27004 * Scripts/run-webkit-tests: 27005 * Scripts/webkitdirs.pm: 27006 Using File::Spec->devnull() instead of hard coded /dev/null. 27007 270082009-10-26 Eric Seidel <eric@webkit.org> 27009 27010 Reviewed by Holger Freyther. 27011 27012 Reviewers are missing from committers.py 27013 https://bugs.webkit.org/show_bug.cgi?id=30733 27014 27015 * Scripts/modules/committers.py: 27016 270172009-10-23 Eric Seidel <eric@webkit.org> 27018 27019 No review, only adding Alice to the list of reviewers. 27020 27021 * Scripts/modules/committers.py: 27022 270232009-10-23 Eric Seidel <eric@webkit.org> 27024 27025 Reviewed by Eric Carlson. 27026 27027 fast/media/mq-transform-02.html failed on Leopard Commit Bot 27028 https://bugs.webkit.org/show_bug.cgi?id=30700 27029 27030 * DumpRenderTree/mac/DumpRenderTree.mm: 27031 (resetDefaultsToConsistentValues): Update QuickTime version check. 27032 270332009-10-23 Kevin Ollivier <kevino@theolliviers.com> 27034 27035 wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 27036 character measurement APIs that are private on Tiger. 27037 27038 * wx/build/settings.py: 27039 270402009-10-22 Gavin Barraclough <barraclough@apple.com> 27041 27042 Reviewed by NOBODY (build fix). 27043 Build fix following bug #30696. 27044 27045 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 27046 (LayoutTestController::evaluateScriptInIsolatedWorld): 27047 270482009-10-22 Gavin Barraclough <barraclough@apple.com> 27049 27050 Reviewed by Sam Weinig & Geoff Garen. 27051 27052 https://bugs.webkit.org/show_bug.cgi?id=30696 27053 Enable isolated-worlds tests on mac. 27054 27055 Add private interface for DRT to invoke execution in a given world. 27056 27057 * DumpRenderTree/LayoutTestController.cpp: 27058 (evaluateScriptInIsolatedWorldCallback): 27059 (LayoutTestController::staticFunctions): 27060 * DumpRenderTree/LayoutTestController.h: 27061 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 27062 (LayoutTestController::evaluateScriptInIsolatedWorld): 27063 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 27064 (LayoutTestController::evaluateScriptInIsolatedWorld): 27065 270662009-10-21 Eric Seidel <eric@webkit.org> 27067 27068 Reviewed by Adam Barth. 27069 27070 bugzilla-tool's "patch failed to download an apply" error should give more information 27071 https://bugs.webkit.org/show_bug.cgi?id=30632 27072 27073 * Scripts/modules/scm.py: 27074 - Use the common run_command method instead of custom POpen code. 27075 - Make run_command know how to take pipes as input. 27076 * Scripts/modules/scm_unittest.py: 27077 - Add new tests to cover change. 27078 - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times. 27079 270802009-10-21 Kent Tamura <tkent@chromium.org> 27081 27082 Unreviewed. Adding myself to the committers list. 27083 27084 * Scripts/modules/committers.py: 27085 270862009-10-21 Robin Dunn <robin@alldunn.com> 27087 27088 Reviewed by Kevin Ollivier. 27089 27090 Update the Windows installer builder to work with Vista / Win 7 and with git. 27091 27092 https://bugs.webkit.org/show_bug.cgi?id=30649 27093 27094 * wx/build/build_utils.py: 27095 * wx/packaging/build-mac-installer.py: 27096 * wx/packaging/build-win-installer.py: 27097 * wx/packaging/wxWebKitInstaller.iss.in: 27098 270992009-10-21 Alejandro G. Castro <alex@igalia.com> 27100 27101 Reviewed by Gustavo Noronha. 27102 27103 [GTK] Added conditional code to avoid using 27104 gdk_window_get_root_coords if we do not have a gtk+ release newer 27105 than 2.17.3. 27106 https://bugs.webkit.org/show_bug.cgi?id=30636 27107 27108 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 27109 271102009-10-21 Shu Chang <Chang.Shu@nokia.com> 27111 27112 Reviewed by Eric Seidel. 27113 27114 [Qt] Added dummy implementation for keepWebHistory() 27115 https://bugs.webkit.org/show_bug.cgi?id=30592 27116 27117 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 27118 (LayoutTestController::keepWebHistory): 27119 * DumpRenderTree/qt/LayoutTestControllerQt.h: 27120 271212009-10-21 Alejandro G. Castro <alex@igalia.com> 27122 27123 Reviewed by Xan Lopez. 27124 27125 [GTK] Fixed the double click condition, it is not double click if 27126 we move in just in one direction. 27127 https://bugs.webkit.org/show_bug.cgi?id=30636 27128 27129 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 27130 271312009-10-21 Alejandro G. Castro <alex@igalia.com> 27132 27133 Reviewed by Xan Lopez. 27134 27135 [GTK] Initialize the events completly before emitting them. 27136 https://bugs.webkit.org/show_bug.cgi?id=30633 27137 27138 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 27139 271402009-10-21 Kevin Ollivier <kevino@theolliviers.com> 27141 27142 wx build fix. Fix for when linking using --as-needed with gcc. 27143 27144 * wx/browser/wscript: 27145 271462009-10-21 Kevin Ollivier <kevino@theolliviers.com> 27147 27148 wxMac 10.4 build fix. Build and link against a version of libcurl new enough 27149 to support all the features used by CURL backend. 27150 27151 * wx/build/settings.py: 27152 * wx/install-unix-extras: 27153 271542009-10-20 Anton Muhin <antonm@chromium.org> 27155 27156 Reviewed by Adam Barth. 27157 27158 Add {ager,antonm,yurys}@chromium.org into committers.py 27159 https://bugs.webkit.org/show_bug.cgi?id=30560 27160 27161 * Scripts/modules/committers.py: 27162 271632009-10-20 Kenneth Rohde Christiansen <kenneth@webkit.org> 27164 27165 Reviewed by Tor Arne Vestbø. 27166 27167 Make the Netscape Test plugin available to the Qt launcher. 27168 27169 * Scripts/run-launcher: 27170 271712009-10-20 Fumitoshi Ukai <ukai@chromium.org> 27172 27173 Reviewed by David Levin. 27174 27175 Removed WebSocket runtime settings. 27176 https://bugs.webkit.org/show_bug.cgi?id=29896 27177 27178 WebSocket runtime configuration is supported by chromium/v8 only. 27179 27180 * DumpRenderTree/mac/DumpRenderTree.mm: 27181 (resetDefaultsToConsistentValues): 27182 * DumpRenderTree/win/DumpRenderTree.cpp: 27183 (resetDefaultsToConsistentValues): 27184 271852009-10-19 Nate Chapin <japhet@chromium.org> 27186 27187 Reviewed by Adam Barth. 27188 27189 Add testFail() to test plugin so we can test our handling of a 27190 plugin invoke call returning false. 27191 27192 https://bugs.webkit.org/show_bug.cgi?id=30239 27193 27194 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail(). 27195 (pluginInvoke): 27196 (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown. 27197 271982009-10-19 Zan Dobersek <zandobersek@gmail.com> 27199 27200 Reviewed by Gustavo Noronha. 27201 27202 Enable DOM pasting when running layout tests. 27203 27204 * DumpRenderTree/gtk/DumpRenderTree.cpp: 27205 (resetDefaultsToConsistentValues): 27206 272072009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org> 27208 27209 Reviewed by Simon Hausmann. 27210 27211 Use the setPreferredContentsSize method instead 27212 of setFixedContentsSize, as the method has been renamed. 27213 27214 * DumpRenderTree/qt/DumpRenderTree.cpp: 27215 (WebCore::DumpRenderTree::open): 27216 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 27217 (LayoutTestController::setFixedContentsSize): 27218 272192009-10-16 Steve Falkenburg <sfalken@apple.com> 27220 27221 Reviewed by Dan Bernstein. 27222 27223 https://bugs.webkit.org/show_bug.cgi?id=30456 27224 Fixes for new Debug_All Windows build configuration. 27225 27226 * DumpRenderTree/win/DumpRenderTree.cpp: 27227 (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming. 27228 * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX. 27229 272302009-10-16 Eric Seidel <eric@webkit.org> 27231 27232 Reviewed by Adam Barth. 27233 27234 commit-queue status bot should list which buildbot is blocking the queue 27235 https://bugs.webkit.org/show_bug.cgi?id=30452 27236 27237 Add new methods and testing. 27238 27239 * Scripts/bugzilla-tool: 27240 * Scripts/modules/buildbot.py: 27241 * Scripts/modules/buildbot_unittest.py: 27242 272432009-10-16 Eric Seidel <eric@webkit.org> 27244 27245 Reviewed by Adam Barth. 27246 27247 run-webkit-tests fails when CWD is not inside a WebKit checkout 27248 https://bugs.webkit.org/show_bug.cgi?id=30451 27249 27250 * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure. 27251 * Scripts/modules/scm_unittest.py: 27252 - Remove use of original_path (we don't need to restore the CWD). 27253 - Don't use '.' to find the webkit checkout, use __file__ instead. 27254 272552009-10-16 Steve Falkenburg <sfalken@apple.com> 27256 27257 Reviewed by Adam Roben. 27258 27259 Add a Debug_All configuration to build entire stack as debug. 27260 Change Debug_Internal to: 27261 - stop using _debug suffix for all WebKit/Safari binaries 27262 - not use _debug as a DLL naming suffix 27263 - use non-debug C runtime lib. 27264 27265 * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration. 27266 * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration. 27267 * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration. 27268 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 27269 Add missing debug.vsprops inherited property sheet. 27270 Add Debug_All configuration. 27271 * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all". 27272 * WinLauncher/WinLauncher.vcproj: 27273 Removed extraneous definitions inherited from vsprops. 27274 Add Debug_All configuration. 27275 272762009-10-16 Carol Szabo <carol.szabo@nokia.com> 27277 27278 Reviewed by David Levin. 27279 27280 check-webkit-style is wrong about indent checking in namespaces 27281 in header files and a few other things 27282 https://bugs.webkit.org/show_bug.cgi?id=30362 27283 27284 The few other things include: 27285 + check-webkit-style does not require spaces around the equal sign 27286 inside 'if' statements and around binary operators that take 27287 numeric literals. 27288 + check-webkit-style reports false errors for the / operator 27289 when part of a filename in the #include directive. 27290 27291 * Scripts/modules/cpp_style.py: 27292 Improved indentation checking and space checking around 27293 binary operators. While the checks are still not perfect, 27294 they are clearly better than before. 27295 * Scripts/modules/cpp_style_unittest.py: 27296 Added test cases for the newly supported checks and modified old 27297 test cases to match the new guidelines 27298 272992009-10-16 Kevin Ollivier <kevino@theolliviers.com> 27300 27301 wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp. 27302 27303 * wx/build/settings.py: 27304 273052009-10-15 Yuzo Fujishima <yuzo@google.com> 27306 27307 Reviewed by David Levin. 27308 27309 Add mod_pywebsocket to test Web Sockets. 27310 http://code.google.com/p/pywebsocket/ 27311 https://bugs.webkit.org/show_bug.cgi?id=27490 27312 27313 * pywebsocket/COPYING: Added. 27314 * pywebsocket/MANIFEST.in: Added. 27315 * pywebsocket/README: Added. 27316 * pywebsocket/example/echo_client.py: Added. 27317 * pywebsocket/example/echo_wsh.py: Added. 27318 * pywebsocket/mod_pywebsocket/__init__.py: Added. 27319 * pywebsocket/mod_pywebsocket/dispatch.py: Added. 27320 * pywebsocket/mod_pywebsocket/handshake.py: Added. 27321 * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added. 27322 * pywebsocket/mod_pywebsocket/msgutil.py: Added. 27323 * pywebsocket/mod_pywebsocket/standalone.py: Added. 27324 * pywebsocket/mod_pywebsocket/util.py: Added. 27325 * pywebsocket/setup.py: Added. 27326 * pywebsocket/test/config.py: Added. 27327 * pywebsocket/test/mock.py: Added. 27328 * pywebsocket/test/run_all.py: Added. 27329 * pywebsocket/test/test_dispatch.py: Added. 27330 * pywebsocket/test/test_handshake.py: Added. 27331 * pywebsocket/test/test_mock.py: Added. 27332 * pywebsocket/test/test_msgutil.py: Added. 27333 * pywebsocket/test/test_util.py: Added. 27334 * pywebsocket/test/testdata/handlers/blank_wsh.py: Added. 27335 * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added. 27336 * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added. 27337 * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added. 27338 * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added. 27339 * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added. 27340 * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added. 27341 * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added. 27342 273432009-10-15 James Robinson <jamesr@google.com> 27344 27345 Reviewed by David Levin. 27346 27347 Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file. 27348 27349 https://bugs.webkit.org/show_bug.cgi?id=30426 27350 27351 * Scripts/modules/cpp_style.py: 27352 * Scripts/modules/cpp_style_unittest.py: 27353 273542009-10-15 Brian Weinstein <bweinstein@apple.com> 27355 27356 Reviewed by Adam Roben. 27357 27358 Fixes <http://webkit.org/b/30411>. 27359 REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows. 27360 27361 Added a check for isChromium() in pdevenv, and pass /useenv if we are not 27362 building Chromium. 27363 27364 * Scripts/pdevenv: 27365 273662009-10-15 Robin Dunn <robin@alldunn.com> 27367 27368 Reviewed by Kevin Ollivier. 27369 27370 Add Mac package building scripts for wx. 27371 27372 https://bugs.webkit.org/show_bug.cgi?id=30405 27373 27374 * wx/build/build_utils.py: 27375 * wx/build/settings.py: 27376 * wx/packaging/build-mac-installer.py: Added. 27377 273782009-10-15 Zan Dobersek <zandobersek@gmail.com> 27379 27380 Reviewed by Gustavo Noronha. 27381 27382 Enable Web Sockets support when running layout tests. 27383 27384 * DumpRenderTree/gtk/DumpRenderTree.cpp: 27385 (resetDefaultsToConsistentValues): 27386 273872009-10-15 Xan Lopez <xlopez@igalia.com> 27388 27389 Reviewed by Gustavo Noronha. 27390 27391 Need to initialize event.button.button, since in most cases a 27392 button number is not passed as an argument. 27393 27394 * DumpRenderTree/gtk/EventSender.cpp: 27395 (mouseDownCallback): 27396 (mouseUpCallback): 27397 273982009-10-15 Kevin Ollivier <kevino@theolliviers.com> 27399 27400 wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to 27401 the OS if none was explicitly set. 27402 27403 * wx/build/settings.py: 27404 274052009-10-14 Pavel Feldman <pfeldman@chromium.org> 27406 27407 Reviewed by Timothy Hatcher. 27408 27409 Web Inspector: enable developers extras within inspector layout tests. 27410 27411 https://bugs.webkit.org/show_bug.cgi?id=30014 27412 27413 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 27414 (LayoutTestController::showWebInspector): 27415 (LayoutTestController::closeWebInspector): 27416 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 27417 (LayoutTestController::showWebInspector): 27418 (LayoutTestController::closeWebInspector): 27419 274202009-10-14 José Millán Soto <jmillan@igalia.com> 27421 27422 Reviewed by Jan Alonzo. 27423 27424 GtkLauncher is using a deprecated signal 27425 https://bugs.webkit.org/show_bug.cgi?id=30364 27426 27427 Modified GtkLauncher to use notify::title signal instead of 27428 deprecated title-changed signal 27429 27430 * GtkLauncher/main.c: 27431 (notify_title_cb): 27432 (create_browser): 27433 274342009-10-14 Brady Eidson <beidson@apple.com> 27435 27436 Reviewed by Sam Weinig. 27437 27438 Don't set the history delegate on new windows that are opened during a test, as the history delegate: 27439 1 - Disables WebHistory 27440 2 - Doesn't make sense in that context anyway. 27441 27442 * DumpRenderTree/win/DumpRenderTree.cpp: 27443 (createWebViewAndOffscreenWindow): 27444 274452009-10-14 Kevin Ollivier <kevino@theolliviers.com> 27446 27447 wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify 27448 the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET. 27449 27450 * wx/build/settings.py: 27451 * wx/install-unix-extras: 27452 274532009-10-14 Brady Eidson <beidson@apple.com> 27454 27455 Reviewed by Sam Weinig. 27456 27457 WebKit Win API should provide a delegate interface for global history. 27458 https://bugs.webkit.org/show_bug.cgi?id=29905 27459 27460 * DumpRenderTree/LayoutTestController.cpp: 27461 (LayoutTestController::LayoutTestController): 27462 * DumpRenderTree/LayoutTestController.h: 27463 (LayoutTestController::dumpHistoryDelegateCallbacks): 27464 (LayoutTestController::setDumpHistoryDelegateCallbacks): 27465 27466 * DumpRenderTree/win/DumpRenderTree.cpp: 27467 (shouldLogHistoryDelegates): 27468 (runTest): 27469 (createWebViewAndOffscreenWindow): 27470 (main): 27471 * DumpRenderTree/win/DumpRenderTree.vcproj: 27472 27473 Add the IWebHistoryDelegate to DRT Windows: 27474 * DumpRenderTree/win/HistoryDelegate.cpp: Added. 27475 (wstringFromBSTR): 27476 (HistoryDelegate::HistoryDelegate): 27477 (HistoryDelegate::~HistoryDelegate): 27478 (HistoryDelegate::QueryInterface): 27479 (HistoryDelegate::AddRef): 27480 (HistoryDelegate::Release): 27481 (HistoryDelegate::didNavigateWithNavigationData): 27482 (HistoryDelegate::didPerformClientRedirectFromURL): 27483 (HistoryDelegate::didPerformServerRedirectFromURL): 27484 (HistoryDelegate::updateHistoryTitle): 27485 (HistoryDelegate::populateVisitedLinksForWebView): 27486 * DumpRenderTree/win/HistoryDelegate.h: Added. 27487 27488 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 27489 (LayoutTestController::removeAllVisitedLinks): 27490 274912009-10-14 Shu Chang <Chang.Shu@nokia.com> 27492 27493 Reviewed by Simon Hausmann. 27494 27495 [Qt] Implement support for setPOSIXLocale on Qt. 27496 https://bugs.webkit.org/show_bug.cgi?id=30268 27497 27498 * DumpRenderTree/qt/DumpRenderTree.cpp: 27499 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 27500 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 27501 (LayoutTestController::setPOSIXLocale): 27502 * DumpRenderTree/qt/LayoutTestControllerQt.h: 27503 275042009-10-13 Stephanie Lewis <slewis@apple.com> 27505 27506 Unreviewed, adding myself to reviewers list. 27507 27508 * Scripts/modules/committers.py: 27509 275102009-10-13 Stephanie Lewis <slewis@apple.com> 27511 27512 Reviewed by Mark Rowe. 27513 27514 Fix null assignment so root tests work again. 27515 27516 * Scripts/webkitdirs.pm: 27517 275182009-10-13 Andras Becsi <becsi.andras@stud.u-szeged.hu> 27519 27520 Reviewed by Simon Hausmann. 27521 27522 [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes 27523 out of jsobjects into separate files to get a more structured DumpRenderTree implementation. 27524 This is done in preparation of implementing missing features in DRT. 27525 No functionality changes made yet. 27526 27527 * DumpRenderTree/qt/DumpRenderTree.cpp: 27528 * DumpRenderTree/qt/DumpRenderTree.pro: 27529 * DumpRenderTree/qt/EventSenderQt.cpp: Added. 27530 (EventSender::EventSender): 27531 (EventSender::mouseDown): 27532 (EventSender::mouseUp): 27533 (EventSender::mouseMoveTo): 27534 (EventSender::leapForward): 27535 (EventSender::keyDown): 27536 (EventSender::contextClick): 27537 (EventSender::scheduleAsynchronousClick): 27538 (EventSender::frameUnderMouse): 27539 * DumpRenderTree/qt/EventSenderQt.h: Added. 27540 (EventSender::clearKillRing): 27541 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added. 27542 (LayoutTestController::LayoutTestController): 27543 (LayoutTestController::reset): 27544 (LayoutTestController::processWork): 27545 (LayoutTestController::maybeDump): 27546 (LayoutTestController::waitUntilDone): 27547 (LayoutTestController::notifyDone): 27548 (LayoutTestController::windowCount): 27549 (LayoutTestController::clearBackForwardList): 27550 (LayoutTestController::dumpEditingCallbacks): 27551 (LayoutTestController::dumpResourceLoadCallbacks): 27552 (LayoutTestController::queueBackNavigation): 27553 (LayoutTestController::queueForwardNavigation): 27554 (LayoutTestController::queueLoad): 27555 (LayoutTestController::queueReload): 27556 (LayoutTestController::queueScript): 27557 (LayoutTestController::provisionalLoad): 27558 (LayoutTestController::timerEvent): 27559 (LayoutTestController::encodeHostName): 27560 (LayoutTestController::decodeHostName): 27561 (LayoutTestController::setJavaScriptProfilingEnabled): 27562 (LayoutTestController::setFixedContentsSize): 27563 (LayoutTestController::setPrivateBrowsingEnabled): 27564 (LayoutTestController::setPopupBlockingEnabled): 27565 (LayoutTestController::pauseAnimationAtTimeOnElementWithId): 27566 (LayoutTestController::pauseTransitionAtTimeOnElementWithId): 27567 (LayoutTestController::numberOfActiveAnimations): 27568 (LayoutTestController::disableImageLoading): 27569 (LayoutTestController::dispatchPendingLoadRequests): 27570 (LayoutTestController::setDatabaseQuota): 27571 (LayoutTestController::clearAllDatabases): 27572 (LayoutTestController::whiteListAccessFromOrigin): 27573 (LayoutTestController::waitForPolicyDelegate): 27574 (LayoutTestController::overridePreference): 27575 * DumpRenderTree/qt/LayoutTestControllerQt.h: Added. 27576 (LayoutTestController::isLoading): 27577 (LayoutTestController::setLoading): 27578 (LayoutTestController::shouldDumpAsText): 27579 (LayoutTestController::shouldDumpBackForwardList): 27580 (LayoutTestController::shouldDumpChildrenAsText): 27581 (LayoutTestController::shouldDumpDatabaseCallbacks): 27582 (LayoutTestController::shouldDumpStatusCallbacks): 27583 (LayoutTestController::shouldWaitUntilDone): 27584 (LayoutTestController::canOpenWindows): 27585 (LayoutTestController::shouldDumpTitleChanges): 27586 (LayoutTestController::waitForPolicy): 27587 (LayoutTestController::dumpAsText): 27588 (LayoutTestController::dumpChildFramesAsText): 27589 (LayoutTestController::dumpDatabaseCallbacks): 27590 (LayoutTestController::dumpStatusCallbacks): 27591 (LayoutTestController::setCanOpenWindows): 27592 (LayoutTestController::dumpBackForwardList): 27593 (LayoutTestController::setCloseRemainingWindowsWhenComplete): 27594 (LayoutTestController::display): 27595 (LayoutTestController::dumpTitleChanges): 27596 (LayoutTestController::dumpSelectionRect): 27597 * DumpRenderTree/qt/TextInputControllerQt.cpp: Added. 27598 (TextInputController::TextInputController): 27599 (TextInputController::doCommand): 27600 * DumpRenderTree/qt/TextInputControllerQt.h: Added. 27601 * DumpRenderTree/qt/WorkQueue.cpp: 27602 * DumpRenderTree/qt/WorkQueue.h: 27603 * DumpRenderTree/qt/WorkQueueItem.h: 27604 * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added. 27605 (findFrameNamed): 27606 (LoadItem::invoke): 27607 (ReloadItem::invoke): 27608 (ScriptItem::invoke): 27609 (BackForwardItem::invoke): 27610 * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files 27611 * DumpRenderTree/qt/jsobjects.h: 27612 276132009-10-13 Dmitry Titov <dimich@chromium.org> 27614 27615 Not reviewed, adding myself to the list of reviewers. 27616 27617 * Scripts/modules/committers.py: 27618 276192009-10-13 Anders Carlsson <andersca@apple.com> 27620 27621 Reviewed by Sam Weinig. 27622 27623 <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API 27624 27625 Make the private browsing mode testable by the test plug-in. 27626 27627 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 27628 (pluginGetProperty): 27629 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: 27630 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 27631 (NPP_New): 27632 (NPP_SetValue): 27633 276342009-10-13 Pavel Feldman <pfeldman@chromium.org> 27635 27636 No review, just adding self to the list of reviewers. 27637 27638 * Scripts/modules/committers.py: 27639 276402009-10-12 Pavel Feldman <pfeldman@chromium.org> 27641 27642 Reviewed by Adam Roben. 27643 27644 Web Inspector: Use proper web view in inspector layout 27645 tests for windows. 27646 27647 https://bugs.webkit.org/show_bug.cgi?id=30298 27648 27649 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 27650 (LayoutTestController::showWebInspector): 27651 (LayoutTestController::closeWebInspector): 27652 (LayoutTestController::evaluateInWebInspector): 27653 276542009-10-12 Fumitoshi Ukai <ukai@chromium.org> 27655 27656 Reviewed by Sam Weinig. 27657 27658 Enable experimentalWebSocket in DumpRenderTree for LayoutTest. 27659 https://bugs.webkit.org/show_bug.cgi?id=29841 27660 27661 * DumpRenderTree/mac/DumpRenderTree.mm: 27662 (resetDefaultsToConsistentValues): 27663 * DumpRenderTree/win/DumpRenderTree.cpp: 27664 (resetDefaultsToConsistentValues): 27665 276662009-10-12 Yaar Schnitman <yaar@chromium.org> 27667 27668 Reviewed by Dimitri Glazkov. 27669 27670 Chromium Port - Windows 27671 https://bugs.webkit.org/show_bug.cgi?id=29969 27672 27673 * Scripts/pdevenv: removed msvc's /useenv for chromium builds 27674 * Scripts/webkitdirs.pm: 27675 276762009-10-12 Csaba Osztrogonac <ossy@webkit.org> 27677 27678 Reviewed by Darin Adler. 27679 27680 jsc scripts cleanup and Qt/GTK fix 27681 https://bugs.webkit.org/show_bug.cgi?id=30288 27682 27683 Duplicated jscPath() moved to webkitdirs.pm. 27684 New jscProductDir() added to webkitdirs.pm instead of duplicated codes. 27685 Configuration added (release/debug) to path for Qt-port on Windows. 27686 27687 * Scripts/run-javascriptcore-tests: 27688 * Scripts/run-jsc: 27689 * Scripts/run-sunspider: 27690 * Scripts/sunspider-compare-results: 27691 * Scripts/webkitdirs.pm: 27692 276932009-10-11 Adam Barth <abarth@webkit.org> 27694 27695 Unreviewed. Add Collin to committers.py. 27696 27697 * Scripts/modules/committers.py: 27698 276992009-10-11 Kevin Ollivier <kevino@theolliviers.com> 27700 27701 wx build fix, add bindings to source/include dirs now that there are sources there. 27702 27703 * wx/build/settings.py: 27704 277052009-10-09 Mark Rowe <mrowe@apple.com> 27706 27707 Reviewed by Brady Eidson. 27708 27709 Enable plug-in halting in DumpRenderTree. 27710 27711 We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins. 27712 This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs. 27713 27714 * DumpRenderTree/mac/DumpRenderTree.mm: 27715 (resetDefaultsToConsistentValues): 27716 * DumpRenderTree/mac/UIDelegate.mm: 27717 (-[UIDelegate webView:shouldHaltPlugin:]): 27718 277192009-10-08 Brady Eidson <beidson@apple.com> 27720 27721 Reviewed by Dan Bernstein. 27722 27723 Ask the History Delegate to populate the visited links hash. 27724 <rdar://problem/7285293> and https://webkit.org/b/29904 27725 27726 Add the ability for LayoutTestController to clear all visited links. 27727 Also lets the History Delegate dump visited links, but only if this test specifically cleared them. 27728 27729 * DumpRenderTree/LayoutTestController.cpp: 27730 (LayoutTestController::LayoutTestController): 27731 (removeAllVisitedLinksCallback): 27732 (LayoutTestController::staticFunctions): 27733 * DumpRenderTree/LayoutTestController.h: 27734 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 27735 (LayoutTestController::removeAllVisitedLinks): 27736 27737 * DumpRenderTree/mac/HistoryDelegate.mm: 27738 (-[HistoryDelegate populateVisitedLinksForWebView:]): 27739 27740 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 27741 (LayoutTestController::removeAllVisitedLinks): 27742 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 27743 (LayoutTestController::removeAllVisitedLinks): 27744 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 27745 (LayoutTestController::removeAllVisitedLinks): 27746 27747 277482009-10-08 Daniel Bates <dbates@webkit.org> 27749 27750 Reviewed by Adam Roben. 27751 27752 https://bugs.webkit.org/show_bug.cgi?id=30175 27753 27754 The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return 27755 the OLE drag-and-drop return value like the function it emulates. Currently, 27756 UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 27757 whether the drag-and-drop operation was successful or was cancelled. 27758 27759 This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 27760 return value according to whether the drop operation was successful or not. 27761 27762 * DumpRenderTree/win/EventSender.cpp: 27763 (doMouseUp): Added parameter oleDragAndDropReturnValue. 27764 (replaySavedEvents): Ditto. 27765 * DumpRenderTree/win/EventSender.h: 27766 * DumpRenderTree/win/UIDelegate.cpp: 27767 (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value. 27768 277692009-10-08 Alejandro G. Castro <alex@igalia.com> 27770 27771 Reviewed by Xan Lopez. 27772 27773 [GTK] Added support for a parameter setting the button that was 27774 pressed in the mouseDown function. 27775 https://bugs.webkit.org/show_bug.cgi?id=30220 27776 27777 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 27778 277792009-10-08 Alejandro G. Castro <alex@igalia.com> 27780 27781 Reviewed by Xan Lopez. 27782 27783 [GTK] Added a line to the bottom of the expected result to match 27784 the output of the test. 27785 https://bugs.webkit.org/show_bug.cgi?id=30220 27786 27787 * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste- 27788 expected.txt: 27789 277902009-10-08 Adam Roben <aroben@apple.com> 27791 27792 Use QueryInterface to get IWebInspectorPrivate 27793 27794 Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be 27795 accessed in a more standard way 27796 27797 Reviewed by John Sullivan and Tim Hatcher. 27798 27799 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 27800 (LayoutTestController::evaluateInWebInspector): Get the IWebInspector 27801 by calling IWebViewPrivate::inspector, then use QueryInterface to get 27802 to the IWebInspectorPrivate interface. 27803 278042009-10-07 Adam Roben <aroben@apple.com> 27805 27806 Implement DRT support for origin whitelisting 27807 27808 Fixes <http://webkit.org/b/30185>. 27809 27810 Reviewed by Eric Seidel. 27811 27812 * DumpRenderTree/win/DumpRenderTree.cpp: 27813 (resetWebViewToConsistentStateBeforeTesting): Reset any origin 27814 whitelist, to match Mac DRT. 27815 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 27816 (LayoutTestController::whiteListAccessFromOrigin): Call through to 27817 IWebViewPrivate::whiteListAccessFromOrigin. 27818 278192009-10-07 Brady Eidson <beidson@apple.com> 27820 27821 Reviewed by Darin Adler. 27822 27823 Send title changes to the global history delegate. 27824 <rdar://problem/7285293> and https://webkit.org/b/29904 27825 27826 * DumpRenderTree/mac/HistoryDelegate.mm: 27827 (-[HistoryDelegate webView:updateHistoryTitle:forURL:]): 27828 278292009-10-07 Adam Barth <abarth@webkit.org> 27830 27831 Unreviewed. Remove some folks from committers.py who were listed on 27832 the WebKit Team wiki page but who weren't actually listed as commit+. 27833 At some point, we should coorelate this list with the committers 27834 mailing list. 27835 27836 * Scripts/modules/committers.py: 27837 278382009-10-07 Adam Barth <abarth@webkit.org> 27839 27840 Unreviewed. Import a bunch of committers from the WebKit Team page on 27841 the wiki into committers.py. 27842 27843 * Scripts/modules/committers.py: 27844 278452009-10-07 Adam Barth <abarth@webkit.org> 27846 27847 Unreviewed. Added Aaron Boodman to committers.py. 27848 27849 * Scripts/modules/committers.py: 27850 278512009-10-07 Evan Martin <evan@chromium.org> 27852 27853 Reviewed by Darin Adler. 27854 27855 Add API to LayoutTestController for re/setting the system locale. 27856 https://bugs.webkit.org/show_bug.cgi?id=18994 27857 27858 * DumpRenderTree/LayoutTestController.cpp: 27859 (setLocaleCallback): 27860 (LayoutTestController::staticFunctions): 27861 (LayoutTestController::setLocale): 27862 * DumpRenderTree/LayoutTestController.h: 27863 278642009-10-06 Shinichiro Hamaji <hamaji@chromium.org> 27865 27866 Reviewed by Jan Alonzo. 27867 27868 [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts 27869 https://bugs.webkit.org/show_bug.cgi?id=29689 27870 27871 Build fix by adding -lfontconfig for DumpRenderTree. 27872 27873 * GNUmakefile.am: 27874 278752009-10-07 Csaba Osztrogonac <oszi@inf.u-szeged.hu> 27876 27877 Reviewed by Simon Hausmann. 27878 27879 Re-enable use-remote-links-to-tests for Qt. Disabled in r46416. 27880 27881 * Scripts/run-webkit-tests: 27882 278832009-10-07 Xan Lopez <xlopez@igalia.com> 27884 27885 Reviewed by Gustavo Noronha. 27886 27887 "delete" in EventSender is the backspace key, not the delete one. 27888 27889 * DumpRenderTree/gtk/EventSender.cpp: 27890 (keyDownCallback): 27891 278922009-10-07 Xan Lopez <xlopez@igalia.com> 27893 27894 Reviewed by Gustavo Noronha. 27895 27896 getChildrenWithRange expects as last parameter the end index, not 27897 the length of the range. Correct this and clarify the variable 27898 names to reflect how the code works. 27899 27900 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 27901 (AccessibilityUIElement::getChildrenWithRange): 27902 (AccessibilityUIElement::getChildAtIndex): 27903 279042009-10-06 Mark Rowe <mrowe@apple.com> 27905 27906 Reviewed by Simon Fraser. 27907 27908 <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH 27909 27910 * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the 27911 the fact we have already changed the working directory to the top of the open source tree. 27912 279132009-10-06 Julie Parent <jparent@chromium.org> 27914 27915 Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email, 27916 rather than my committer email. 27917 27918 * Scripts/modules/committers.py: 27919 279202009-10-06 Jakub Wieczorek <faw217@gmail.com> 27921 27922 Reviewed by Eric Seidel. 27923 27924 [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset(). 27925 27926 r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset 27927 it after each layout test as it should do, making the DRT dump additional output 27928 for all of the subsequent layout tests. 27929 27930 * DumpRenderTree/qt/jsobjects.cpp: 27931 (LayoutTestController::reset): 27932 279332009-10-06 Jakub Wieczorek <faw217@gmail.com> 27934 27935 Reviewed by Simon Hausmann. 27936 27937 [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the 27938 fast/dom/assign-to-window-status.html test, which is passing as a result. 27939 27940 https://bugs.webkit.org/show_bug.cgi?id=30127 27941 27942 * DumpRenderTree/qt/DumpRenderTree.cpp: 27943 (WebCore::DumpRenderTree::DumpRenderTree): 27944 (WebCore::DumpRenderTree::statusBarMessage): 27945 * DumpRenderTree/qt/DumpRenderTree.h: 27946 * DumpRenderTree/qt/jsobjects.h: 27947 (LayoutTestController::shouldDumpStatusCallbacks): 27948 (LayoutTestController::dumpStatusCallbacks): 27949 279502009-10-06 Jakub Wieczorek <faw217@gmail.com> 27951 27952 Reviewed by Simon Hausmann. 27953 27954 [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown() 27955 ignores the argument indicating which mouse button to trigger. 27956 https://bugs.webkit.org/show_bug.cgi?id=30048 27957 27958 This affects the fast/events/mouse-click-events.html layout test. 27959 27960 * DumpRenderTree/qt/jsobjects.cpp: 27961 (EventSender::mouseDown): 27962 (EventSender::mouseUp): 27963 * DumpRenderTree/qt/jsobjects.h: 27964 279652009-10-06 Jakub Wieczorek <faw217@gmail.com> 27966 27967 Reviewed by Simon Hausmann. 27968 27969 [Qt] Fix the EventSender::keyDown() implementation 27970 https://bugs.webkit.org/show_bug.cgi?id=30043 27971 27972 It should post both a key press event and a key release event, 27973 just like other ports do. 27974 27975 * DumpRenderTree/qt/jsobjects.cpp: 27976 (EventSender::keyDown): 27977 279782009-10-05 Kevin Ollivier <kevino@theolliviers.com> 27979 27980 wx build fix. Add jpeg to the list of libs to link against. 27981 27982 * wx/build/settings.py: 27983 279842009-10-05 Jakub Wieczorek <faw217@gmail.com> 27985 27986 Reviewed by Simon Hausmann. 27987 27988 [Qt] EventSender::keyDown() cannot send function-key events. 27989 https://bugs.webkit.org/show_bug.cgi?id=30044 27990 27991 This affects the fast/events/keydown-function-keys.html layout test. 27992 27993 * DumpRenderTree/qt/jsobjects.cpp: 27994 (EventSender::keyDown): 27995 279962009-10-05 Vadim Zeitlin <vadim@wxwidgets.org> 27997 27998 Added --wx-compiler-prefix waf option to allow building wxWebKit with 27999 wxWidgets built using "nmake COMPILER_PREFIX=something-non-default". 28000 28001 * wx/build/settings.py: 28002 * wx/build/wxpresets.py: 28003 280042009-10-05 Pavel Feldman <pfeldman@chromium.org> 28005 28006 Reviewed by Timothy Hatcher. 28007 28008 Web Inspector: add testing harness for Web Inspector. 28009 28010 https://bugs.webkit.org/show_bug.cgi?id=30010 28011 28012 * DumpRenderTree/LayoutTestController.cpp: 28013 (showWebInspectorCallback): 28014 (closeWebInspectorCallback): 28015 (evaluateInWebInspectorCallback): 28016 (LayoutTestController::staticFunctions): 28017 * DumpRenderTree/LayoutTestController.h: 28018 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 28019 (LayoutTestController::showWebInspector): 28020 (LayoutTestController::closeWebInspector): 28021 (LayoutTestController::evaluateInWebInspector): 28022 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 28023 (LayoutTestController::showWebInspector): 28024 (LayoutTestController::closeWebInspector): 28025 (LayoutTestController::evaluateInWebInspector): 28026 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 28027 (LayoutTestController::showWebInspector): 28028 (LayoutTestController::closeWebInspector): 28029 (LayoutTestController::evaluateInWebInspector): 28030 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 28031 (LayoutTestController::showWebInspector): 28032 (LayoutTestController::closeWebInspector): 28033 (LayoutTestController::evaluateInWebInspector): 28034 280352009-10-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 28036 28037 Reviewed by Ariyha Hidayat. 28038 28039 Pass arguments to system() as a string instead of array 28040 28041 When passed as an array entries with a space fail to translate 28042 to two arguments to the child process, so instead of manually 28043 splitting all the entries in @buildArgs we pass the whole thing 28044 as a string instead. 28045 28046 * Scripts/webkitdirs.pm: 28047 280482009-10-04 Carol Szabo <carol.szabo@nokia.com> 28049 28050 Reviewed by David Levin. 28051 28052 check-webkit-style misses whitespace errors for operators: 28053 <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||. 28054 https://bugs.webkit.org/show_bug.cgi?id=30021 28055 28056 * Scripts/modules/cpp_style.py: 28057 Added the operators mentioned above to the same list as == and !=. 28058 280592009-10-02 Julie Parent <jparent@chromium.org> 28060 28061 Unreviewed. 28062 28063 Adding myself and Ojan Vafai as committers, because we are committers. 28064 28065 * Scripts/modules/committers.py: 28066 280672009-10-02 Brian Weinstein <bweinstein@apple.com> 28068 28069 Reviewed by Adam Roben. 28070 28071 svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff, 28072 this will help the patch merging process when TryBots are used. 28073 28074 * Scripts/svn-create-patch: 28075 280762009-10-02 Jakub Wieczorek <faw217@gmail.com> 28077 28078 Reviewed by Simon Hausmann. 28079 28080 [Qt] Implement layoutTestController.overridePreference(). 28081 https://bugs.webkit.org/show_bug.cgi?id=29970 28082 28083 * DumpRenderTree/qt/DumpRenderTree.cpp: 28084 (WebCore::WebPage::WebPage): 28085 (WebCore::WebPage::resetSettings): 28086 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 28087 * DumpRenderTree/qt/jsobjects.cpp: 28088 (LayoutTestController::reset): 28089 (LayoutTestController::setPrivateBrowsingEnabled): 28090 (LayoutTestController::setPopupBlockingEnabled): 28091 (LayoutTestController::overridePreference): 28092 * DumpRenderTree/qt/jsobjects.h: 28093 280942009-10-01 Chris Marrin <cmarrin@apple.com> 28095 28096 Reviewed by Oliver Hunt. 28097 28098 Turn on ENABLE_3D_CANVAS in TOT 28099 https://bugs.webkit.org/show_bug.cgi?id=29906 28100 28101 * Scripts/build-webkit: 28102 281032009-10-01 Kenneth Rohde Christiansen <kenneth@webkit.org> 28104 28105 Rubberstamped by Simon Hausmann. 28106 28107 Enable HTTP tests for Qt 28108 28109 * Scripts/run-webkit-tests: 28110 281112009-10-01 Yaar Schnitman <yaar@chromium.org> 28112 28113 Reviewed by Dimitri Glazkov. 28114 28115 build-webkit --chromium now also works on cygwin. 28116 28117 https://bugs.webkit.org/show_bug.cgi?id=29973 28118 28119 * Scripts/webkitdirs.pm: 28120 281212009-10-01 Zoltan Horvath <zoltan@webkit.org> 28122 28123 Reviewed by Simon Hausmann. 28124 28125 [Qt] Don't use TCmalloc in DumpRenderTree 28126 https://bugs.webkit.org/show_bug.cgi?id=27029 28127 28128 Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT. 28129 28130 * DumpRenderTree/qt/DumpRenderTree.pro: 28131 281322009-10-01 Jakub Wieczorek <faw217@gmail.com> 28133 28134 Reviewed by Simon Hausmann. 28135 28136 [Qt] Implement eventSender.scheduleAsynchronousClick(). 28137 28138 https://bugs.webkit.org/show_bug.cgi?id=29931 28139 28140 * DumpRenderTree/qt/jsobjects.cpp: 28141 (EventSender::scheduleAsynchronousClick): 28142 * DumpRenderTree/qt/jsobjects.h: 28143 281442009-10-01 Jakub Wieczorek <faw217@gmail.com> 28145 28146 Reviewed by Simon Hausmann. 28147 28148 [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove 28149 fast/events/open-window-from-another-frame.html from the Skipped list. 28150 28151 https://bugs.webkit.org/show_bug.cgi?id=29930 28152 28153 * DumpRenderTree/qt/jsobjects.cpp: 28154 (LayoutTestController::setPopupBlockingEnabled): 28155 * DumpRenderTree/qt/jsobjects.h: 28156 281572009-09-30 Cameron McCormack <cam@mcc.id.au> 28158 28159 Unreviewed. 28160 28161 Added myself to the list of committers. 28162 28163 * Scripts/modules/committers.py: 28164 281652009-09-30 Eric Seidel <eric@webkit.org> 28166 28167 No review, just adding Geoff to the list of reviewers. 28168 28169 * Scripts/modules/committers.py: 28170 281712009-09-30 Dan Bernstein <mitz@apple.com> 28172 28173 Reviewed by Sam Weinig. 28174 28175 Added the WebKit Layout Tests fonts that are referenced in 28176 LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css 28177 28178 * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added. 28179 * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added. 28180 281812009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu> 28182 28183 Reviewed by David Kilzer. 28184 28185 Make sunspider scripts work on Windows platform. 28186 https://bugs.webkit.org/show_bug.cgi?id=29656 28187 28188 * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter. 28189 * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter. 28190 * Scripts/webkitdirs.pm: currentPerlPath() added. 28191 281922009-09-29 Brady Eidson <beidson@apple.com> 28193 28194 Rubberstamped by Dan Bernstein. 28195 28196 Fix license and some sorting in new files. 28197 28198 * DumpRenderTree/mac/HistoryDelegate.h: 28199 * DumpRenderTree/mac/HistoryDelegate.mm: 28200 282012009-09-29 Yaar Schnitman <yaar@chromium.org> 28202 28203 Reviewed by David Kilzer. 28204 28205 Fixed how error codes are handled. 28206 https://bugs.webkit.org/show_bug.cgi?id=29898 28207 28208 * Scripts/update-webkit: 28209 * Scripts/update-webkit-chromium: 28210 282112009-09-29 Brady Eidson <beidson@apple.com> 28212 28213 Reviewed by John Sullivan. 28214 28215 Updated way-out-of-date sorting throughout the dump methods/flags. 28216 28217 * DumpRenderTree/LayoutTestController.cpp: 28218 (LayoutTestController::LayoutTestController): 28219 (dumpAsPDFCallback): 28220 (dumpAsTextCallback): 28221 (dumpFrameLoadCallbacksCallback): 28222 (dumpResourceLoadCallbacksCallback): 28223 (LayoutTestController::staticFunctions): 28224 28225 * DumpRenderTree/LayoutTestController.h: 28226 (LayoutTestController::dumpAsText): 28227 (LayoutTestController::setDumpAsText): 28228 (LayoutTestController::dumpFrameLoadCallbacks): 28229 (LayoutTestController::setDumpFrameLoadCallbacks): 28230 (LayoutTestController::dumpSelectionRect): 28231 (LayoutTestController::setDumpSelectionRect): 28232 (LayoutTestController::dumpSourceAsWebArchive): 28233 (LayoutTestController::setDumpSourceAsWebArchive): 28234 (LayoutTestController::dumpStatusCallbacks): 28235 (LayoutTestController::setDumpStatusCallbacks): 28236 (LayoutTestController::dumpTitleChanges): 28237 (LayoutTestController::setDumpTitleChanges): 28238 (LayoutTestController::dumpWillCacheResponse): 28239 (LayoutTestController::setDumpWillCacheResponse): 28240 282412009-09-29 Brady Eidson <beidson@apple.com> 28242 28243 Reviewed by John Sullivan. 28244 28245 WebKit Mac API should provide a delegate interface for global history. 28246 <rdar://problem/7042773> and https://webkit.org/b/29904 28247 28248 Adding the dumping of global history delegate callbacks. 28249 28250 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 28251 28252 Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL: 28253 * DumpRenderTree/mac/DumpRenderTree.mm: 28254 (createWebViewAndOffscreenWindow): 28255 (allocateGlobalControllers): 28256 (shouldLogFrameLoadDelegates): 28257 (shouldLogHistoryDelegates): 28258 (runTest): 28259 28260 Dump history delegate callbacks: 28261 * DumpRenderTree/mac/HistoryDelegate.h: Added. 28262 * DumpRenderTree/mac/HistoryDelegate.mm: Added. 28263 (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]): 28264 (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]): 28265 (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]): 28266 282672009-09-29 Daniel Bates <dbates@webkit.org> 28268 28269 Reviewed by Adam Roben. 28270 28271 https://bugs.webkit.org/show_bug.cgi?id=28902 28272 28273 Fixes an issue where the drop effect returned by Window Dump Render Tree 28274 was always DROPEFFECT_NONE (since it was hard coded to do so). 28275 28276 This patch corrects this issue by determining the actual drop effect 28277 performed by the corresponding drag-and-drop operation so that we can 28278 return it. 28279 28280 * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect. 28281 (DraggingInfo::DraggingInfo): 28282 (DraggingInfo::performedDropEffect): Added method. 28283 (DraggingInfo::setPerformedDropEffect): Added method. 28284 * DumpRenderTree/win/EventSender.cpp: 28285 (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect. 28286 Moved delete draggingInfo to UIDelegate::doDragDrop. 28287 * DumpRenderTree/win/UIDelegate.cpp: 28288 (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect(). 28289 282902009-09-29 Dan Bernstein <mitz@apple.com> 28291 28292 Reviewed by Adam Roben. 28293 28294 Remove copying of unnecessary or nonexistent files from the ImageDiff 28295 post-build event. 28296 28297 * DumpRenderTree/win/ImageDiff.vcproj: 28298 282992009-09-29 Csaba Osztrogonac <oszi@inf.u-szeged.hu> 28300 28301 Reviewed by David Kilzer. 28302 28303 [Qt] Make build-webkit script work on Windows 28304 https://bugs.webkit.org/show_bug.cgi?id=29802 28305 28306 * Scripts/run-webkit-tests: 28307 * Scripts/webkitdirs.pm: 28308 - Removed unnecessary -p switch for mkdir on Windows. 28309 - Use canonical path, which uses slashes or backslashes depends on platform. 28310 - isWindows() only test for Windows and not for Cyqwin. 28311 283122009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu> 28313 28314 Reviewed by Simon Hausmann. 28315 28316 Fix time measurement in build-webkit after refactoring done in r48853. 28317 28318 * Scripts/build-webkit: 28319 283202009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu> 28321 28322 Reviewed by Tor Arne Vestbø. 28323 28324 [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard. 28325 This fixes https://bugs.webkit.org/show_bug.cgi?id=19674. 28326 28327 * DumpRenderTree/qt/DumpRenderTree.cpp: 28328 (WebCore::WebPage::WebPage): 28329 283302009-09-29 Jakub Wieczorek <faw217@gmail.com> 28331 28332 Reviewed by Simon Hausmann. 28333 28334 [Qt] Implement eventSender.contextClick(). 28335 https://bugs.webkit.org/show_bug.cgi?id=29821 28336 28337 * DumpRenderTree/qt/jsobjects.cpp: 28338 (EventSender::contextClick): 28339 * DumpRenderTree/qt/jsobjects.h: 28340 283412009-09-28 Fumitoshi Ukai <ukai@chromium.org> 28342 28343 Reviewed by Eric Seidel. 28344 28345 Add experimentalWebSocketsEnabled in WebPreferences. 28346 https://bugs.webkit.org/show_bug.cgi?id=28941 28347 28348 * DumpRenderTree/mac/DumpRenderTree.mm: 28349 (resetDefaultsToConsistentValues): 28350 * DumpRenderTree/win/DumpRenderTree.cpp: 28351 (resetDefaultsToConsistentValues): 28352 283532009-09-28 Yaar Schnitman <yaar@chromium.org> 28354 28355 Reviewed by David Kilzer. 28356 28357 Integrated chromium port building into webkit tools update-webkit and 28358 build-webkit. 28359 28360 https://bugs.webkit.org/show_bug.cgi?id=29749 28361 28362 * Scripts/build-webkit: When --chromium is specified, will build 28363 the chromium port (currently only Mac is supported). 28364 * Scripts/update-webkit: When --chromium is specified, delegates to 28365 update-webkit-chromium. 28366 * Scripts/webkitdirs.pm: Added chromium specific defs. 28367 * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch 28368 chromium port's dependencies and update its project files. 28369 283702009-09-28 Fumitoshi Ukai <ukai@chromium.org> 28371 28372 Unreviewed. 28373 28374 Add myself to list of committers. 28375 28376 * Scripts/modules/committers.py: 28377 283782009-09-27 Jakub Wieczorek <faw217@gmail.com> 28379 28380 Reviewed by Darin Adler. 28381 28382 run-webkit-tests: Do not strip the metrics when there is no expected result for a test. 28383 https://bugs.webkit.org/show_bug.cgi?id=29771 28384 28385 * Scripts/run-webkit-tests: 28386 283872009-09-27 Jakub Wieczorek <faw217@gmail.com> 28388 28389 Reviewed by Simon Hausmann. 28390 28391 [Qt] Implement layoutTestController.waitForPolicyDelegate. 28392 https://bugs.webkit.org/show_bug.cgi?id=25037 28393 28394 * DumpRenderTree/qt/DumpRenderTree.cpp: 28395 (WebCore::WebPage::acceptNavigationRequest): 28396 * DumpRenderTree/qt/DumpRenderTree.pro: 28397 * DumpRenderTree/qt/jsobjects.cpp: 28398 (LayoutTestController::reset): 28399 (LayoutTestController::notifyDone): 28400 (LayoutTestController::waitForPolicyDelegate): 28401 * DumpRenderTree/qt/jsobjects.h: 28402 (LayoutTestController::waitForPolicy): 28403 284042009-09-26 David Kilzer <ddkilzer@apple.com> 28405 28406 <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch 28407 28408 Reviewed by Eric Seidel. 28409 28410 The -o|--open switch uses the open(1) command on Mac OS X to 28411 open the bug URL in the default web browser. If there are 28412 similar mechanisms on other platforms, they may be added later. 28413 28414 * Scripts/mark-bug-fixed: 28415 (MarkBugFixed.__init__): Added -o|--open switch to list of parse 28416 options. 28417 (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging 28418 code into main() and extracted prompting code into 28419 _prompt_user_for_correctness(). 28420 (MarkBugFixed._open_bug_in_web_browser): Added. 28421 (MarkBugFixed._prompt_user_for_correctness): Added. 28422 (MarkBugFixed.main): Added logging code from 28423 _determine_bug_id_and_svn_revision(). Added code to call 28424 _open_bug_in_web_browser() if the switch is set. Added code to 28425 call _prompt_user_for_correctness() when needed. 28426 * Scripts/modules/bugzilla.py: 28427 (Bugzilla.short_bug_url_for_bug_id): Added. 28428 284292009-09-26 David Kilzer <ddkilzer@apple.com> 28430 28431 svn-unapply and svn-apply don't work when used outside multiple svn working directories 28432 28433 <http://webkit.org/b/29744> 28434 <rdar://problem/7252905> 28435 28436 Reviewed by Eric Seidel. 28437 28438 Some users have a workflow where svn-create-patch, svn-apply and 28439 svn-unapply are used outside of multiple svn working 28440 directories. Instead of aborting the scripts in these cases, 28441 print a warning and assume that Subversion is being used. 28442 28443 * Scripts/VCSUtils.pm: 28444 (determineVCSRoot): Call warn() instead of die() if both isGit() 28445 and isSVN() initially return false. Set $VCSUtils::isSVN to 1 28446 to enforce the assumption about Subversion, then return 28447 determineSVNRoot(). 28448 * Scripts/svn-apply: Switch to using isGit() and isSVN() from 28449 VCSUtils.pm. They both already cache their values and checking 28450 here is redundant since determineVCSRoot() is called later. 28451 284522009-09-26 Zan Dobersek <zandobersek@gmail.com> 28453 28454 Reviewed by Gustavo Noronha. 28455 28456 [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts 28457 https://bugs.webkit.org/show_bug.cgi?id=29689 28458 28459 Load test fonts through FontConfig before each test. 28460 This ensures a more proper rendering of the tests. 28461 28462 * DumpRenderTree/gtk/DumpRenderTree.cpp: 28463 (initializeFonts): 28464 (runTest): 28465 (main): 28466 * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf. 28467 * GNUmakefile.am: 28468 284692009-09-25 David Kilzer <ddkilzer@apple.com> 28470 28471 <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch 28472 28473 Reviewed by Eric Seidel. 28474 28475 * Scripts/mark-bug-fixed: 28476 (MarkBugFixed.__init__): Added -u|--update-only switch to list 28477 of parse options. 28478 (MarkBugFixed.main): When -u|--update-only is specified, add a 28479 comment to the bug without marking it Resolved/Fixed. 28480 284812009-09-25 Darin Adler <darin@apple.com> 28482 28483 Reviewed by Geoffrey Garen. 28484 28485 * Scripts/prepare-ChangeLog: Leave files from the script-tests directory 28486 out, just as we do for the resources directory. 28487 284882009-09-25 Adam Barth <abarth@webkit.org> 28489 28490 Unreviewed. Added Tony to committers.py because he's a 28491 committer now. 28492 28493 * Scripts/modules/committers.py: 28494 284952009-09-25 Eric Seidel <eric@webkit.org> 28496 28497 Reviewed by Simon Fraser. 28498 28499 REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots 28500 https://bugs.webkit.org/show_bug.cgi?id=28624 28501 28502 Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older. 28503 28504 * DumpRenderTree/mac/DumpRenderTree.mm: 28505 (resetDefaultsToConsistentValues): 28506 285072009-09-25 Eric Seidel <eric@webkit.org> 28508 28509 Reviewed by Adam Barth. 28510 28511 commit-queue should auto-retry patches which fail to commit due to out of date files 28512 https://bugs.webkit.org/show_bug.cgi?id=28316 28513 28514 * Scripts/bugzilla-tool: 28515 - Handle new CheckoutNeedsUpdate exception. 28516 * Scripts/modules/logging_unittest.py: 28517 - Call the ScriptError constructor correctly (this test had regressed). 28518 * Scripts/modules/scm.py: 28519 - Added the ability to define custom error handlers for run_command 28520 and added a commit_error_handler which throws CheckoutNeedsUpdate 28521 instead of ScriptError. 28522 - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible. 28523 * Scripts/modules/scm_unittest.py: 28524 - Added tests of new error handlers. 28525 285262009-09-25 Eric Seidel <eric@webkit.org> 28527 28528 Reviewed by Adam Barth. 28529 28530 commit-queue should give better feedback when failing a patch 28531 https://bugs.webkit.org/show_bug.cgi?id=29316 28532 28533 * Scripts/bugzilla-tool: 28534 - Update ScriptError uses to the new constructor format. 28535 - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output 28536 so that we can print to both stdout as well as an output buffer for error reporting. 28537 - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError. 28538 - Use e.message_with_output() when failing a patch (this is the real fix here). 28539 I also removed use of "This patch will require manual commit." as that's not always true. 28540 - Add missing word "bug" from log message. 28541 * Scripts/modules/scm.py: 28542 - Make ScriptError save a bunch more data so that error messages can be nicer. 28543 - Update ScriptError callers. 28544 285452009-09-24 John Gregg <johnnyg@google.com> 28546 28547 Reviewed by Eric Seidel. 28548 28549 Enable switch for notifications (experimental) in Page Settings 28550 https://bugs.webkit.org/show_bug.cgi?id=28930 28551 28552 Now that desktop notifications are controlled by run-time switch, 28553 set that switch to true for DumpRenderTree. 28554 28555 * DumpRenderTree/mac/DumpRenderTree.mm: 28556 (resetDefaultsToConsistentValues): 28557 * DumpRenderTree/win/DumpRenderTree.cpp: 28558 (resetDefaultsToConsistentValues): 28559 * DumpRenderTree/win/UIDelegate.cpp: 28560 (UIDelegate::QueryInterface): 28561 285622009-09-24 Kevin Ollivier <kevino@theolliviers.com> 28563 28564 wx build fix. SnowLeopard fixes for Mac dependencies. 28565 28566 * wx/build/build_utils.py: 28567 * wx/build/settings.py: 28568 * wx/install-unix-extras: 28569 285702009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 28571 28572 Reviewed by Oliver Hunt. 28573 28574 Add support for DRT to send mouse wheel events. 28575 28576 https://bugs.webkit.org/show_bug.cgi?id=29348 28577 [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally 28578 28579 * DumpRenderTree/gtk/EventSender.cpp: 28580 (mouseWheelToCallback): 28581 285822009-09-17 Eric Seidel <eric@webkit.org> 28583 28584 Reviewed by David Levin. 28585 28586 commit-queue needs web-based status reporting 28587 https://bugs.webkit.org/show_bug.cgi?id=29307 28588 28589 Add a first-pass web-based status for the commit-queue. 28590 The bot is currently reachable at: 28591 http://webkit-commit-queue.appspot.com/ 28592 28593 * CommitQueueStatus/app.yaml: Added. 28594 - Application description file required by App Engine. 28595 * CommitQueueStatus/filters/__init__.py: Added. 28596 - Required by python to treat 'filters' as a module. 28597 * CommitQueueStatus/filters/webkit_extras.py: Added. 28598 - Support for turning 'bug 123' and 'patch 123' into links. 28599 This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page). 28600 * CommitQueueStatus/index.html: Added. 28601 * CommitQueueStatus/index.yaml: Added. 28602 - Some auto-generated file from app engine. 28603 * CommitQueueStatus/queue_status.py: Added. 28604 - The core logic of this bot. We could eventually split this file out into pieces. 28605 * CommitQueueStatus/stylesheets/main.css: Added. 28606 - Some basic lame-o CSS to make the page look less awful. 28607 * CommitQueueStatus/update_status.html: Added. 28608 - The form that the commit-queue (or a human) can use to update the status. 28609 * Scripts/bugzilla-tool: 28610 - Add some very basic update_status calls. 28611 * Scripts/modules/statusbot.py: Added. 28612 - Knows how to post to the CommitQueueStatus web application. 28613 286142009-09-24 David Kilzer <ddkilzer@apple.com> 28615 28616 <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch 28617 28618 Reviewed by Adam Roben. 28619 28620 * Scripts/mark-bug-fixed: 28621 (MarkBugFixed.__init__): Added -m|--comment switch to list of 28622 parse options. 28623 (MarkBugFixed.main): When specified, prepend comment from 28624 -m|--comment command-line switch to the bug comment. 28625 286262009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 28627 28628 Reviewed by Jan Alonzo. 28629 28630 [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly 28631 https://bugs.webkit.org/show_bug.cgi?id=29693 28632 28633 Show the window, to be able to synthesize events correctly. 28634 28635 * DumpRenderTree/gtk/DumpRenderTree.cpp: 28636 (runTest): 28637 (main): 28638 286392009-09-24 Oliver Hunt <oliver@apple.com> 28640 28641 Reviewed by NOBODY(rollout) 28642 28643 Roll out r48712 as it is incorrect. 28644 28645 * DumpRenderTree/mac/ObjCController.m: 28646 (+[ObjCController isSelectorExcludedFromWebScript:]): 28647 (+[ObjCController webScriptNameForSelector:]): 28648 286492009-09-24 Benjamin Poulain <benjamin.poulain@nokia.com> 28650 28651 Reviewed by Eric Seidel. 28652 28653 https://bugs.webkit.org/show_bug.cgi?id=29005 28654 The indices of RuntimeArray should be enumerated like for a regular array. 28655 28656 * DumpRenderTree/mac/ObjCController.m: 28657 (+[ObjCController isSelectorExcludedFromWebScript:]): 28658 (+[ObjCController webScriptNameForSelector:]): 28659 (-[ObjCController arrayOfString]): 28660 286612009-09-23 David Kilzer <ddkilzer@apple.com> 28662 28663 <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool 28664 28665 Reviewed by Darin Adler. 28666 28667 Also fixed a bug where specifying a revision on the command-line 28668 as 'r12345' would fail. See <http://webkit.org/b/29699>. 28669 28670 * Scripts/bugzilla-tool: Updated module import statements. 28671 (parse_bug_id): Removed. Moved to bugzilla.py. 28672 (bug_comment_from_svn_revision): Removed. Moved to comments.py. 28673 (bug_comment_from_commit_text): Removed. Moved to comments.py. 28674 (MarkBugFixed): Removed. Code moved to mark-bug-fixed. 28675 (BugzillaTool.__init__): Removed mark-fixed subcommand. 28676 * Scripts/mark-bug-fixed: Added. 28677 * Scripts/modules/bugzilla.py: 28678 (parse_bug_id): Added. Moved from bugzilla-tool. 28679 * Scripts/modules/comments.py: Added. 28680 (bug_comment_from_svn_revision): Added. Moved from bugzilla-tool. 28681 (bug_comment_from_commit_text): Added. Moved from bugzilla-tool. 28682 286832009-09-23 Marshall Culpepper <mculpepper@appcelerator.com> 28684 28685 Reviewed by Eric Seidel. 28686 28687 jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return 28688 "false" in non-implemented stub for setAlwaysAcceptCookies. 28689 https://bugs.webkit.org/show_bug.cgi?id=29661 28690 28691 * DumpRenderTree/win/DumpRenderTree.vcproj: 28692 * DumpRenderTree/win/DumpRenderTree.cpp: 28693 286942009-09-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 28695 28696 Reviewed by Xan Lopez. 28697 28698 [GTK] need to dump number of pending unload handlers 28699 https://bugs.webkit.org/show_bug.cgi?id=29685 28700 28701 Implement dumping of the number of pending unload handlers. 28702 28703 The following tests will pass: 28704 28705 fast/loader/unload-form-about-blank.html 28706 fast/loader/unload-form-post-about-blank.html 28707 fast/loader/unload-form-post.html 28708 fast/loader/unload-form.html 28709 fast/loader/unload-hyperlink.html 28710 fast/loader/unload-javascript-url.html 28711 fast/loader/unload-reload.html 28712 fast/loader/unload-window-location.html 28713 28714 * DumpRenderTree/gtk/DumpRenderTree.cpp: 28715 (getFrameNameSuitableForTestResult): 28716 (webViewLoadFinished): 28717 287182009-09-22 Shinichiro Hamaji <hamaji@chromium.org> 28719 28720 Reviewed by Eric Seidel. 28721 28722 js tests should move into jstests subdirectory instead of resources/ 28723 https://bugs.webkit.org/show_bug.cgi?id=25880 28724 28725 Remove support of resources directory. 28726 28727 * Scripts/make-script-test-wrappers: 28728 287292009-09-22 Eric Seidel <eric@webkit.org> 28730 28731 No review, only fixing typo (missing space character). 28732 28733 Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220 28734 28735 * Scripts/run-webkit-tests: 28736 287372009-09-22 Eric Seidel <eric@webkit.org> 28738 28739 Reviewed by Darin Adler. 28740 28741 run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC) 28742 https://bugs.webkit.org/show_bug.cgi?id=29220 28743 28744 * Scripts/run-webkit-tests: 28745 287462009-09-22 Eric Seidel <eric@webkit.org> 28747 28748 Reviewed by David Kilzer. 28749 28750 svn-apply can't handle single-line binary file additions 28751 https://bugs.webkit.org/show_bug.cgi?id=29100 28752 28753 Fixed the regexp and added a unit test. 28754 28755 * Scripts/modules/scm_unittest.py: 28756 * Scripts/svn-apply: 28757 287582009-09-11 Eric Seidel <eric@webkit.org> 28759 28760 Reviewed by David Kilzer. 28761 28762 post-diff and post-commits should be able to find bug urls in ChangeLogs. 28763 https://bugs.webkit.org/show_bug.cgi?id=29206 28764 28765 * Scripts/bugzilla-tool: 28766 - Share common options by adding a PostDiffAsPatchToBug.posting_options() method. 28767 - Rename --no-comment to --add-log-as-comment and reverse behavior. 28768 Comments tend to just be noise. I'll eventually remove this argument if no one uses it. 28769 - Split out code into helper functions to try and make execute() more legible. 28770 - Make post-diff find the bug url in the ChangeLogs if not passed as an argument. 28771 - Fallback to bug urls in commit diffs, instead of just in commit messages, 28772 meaning post-commits will now find bug urls in ChangeLogs. 28773 287742009-09-21 Csaba Osztrogonac <oszi@inf.u-szeged.hu> 28775 28776 Reviewed by Maciej Stachowiak. 28777 28778 --parse-only parameter wasn't passed to SunSpider/sunspider script. 28779 https://bugs.webkit.org/show_bug.cgi?id=29611 28780 28781 * Scripts/run-sunspider: Missing parameter passing added. 28782 287832009-09-20 David Kilzer <ddkilzer@apple.com> 28784 28785 <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module 28786 28787 Reviewed by Mark Rowe. 28788 28789 The require statement is like the use statement, except that it 28790 is run during script execution instead of during the 'BEGIN' 28791 phase. This makes it possible to change @INC before the require 28792 statement is run. See 'require' and 'use' in the perlfunc(1) 28793 manpage and 'BEGIN' in perlmod(1) manpage. 28794 28795 * Scripts/run-webkit-tests: Replace eval statement with require 28796 statement. 28797 287982009-09-18 Kevin Ollivier <kevino@theolliviers.com> 28799 28800 wx build fixes. Fix the config name under git and allow users to specify 28801 their own waf install for experimenting with new versions. 28802 28803 * Scripts/webkitdirs.pm: 28804 * wx/build/settings.py: 28805 288062009-09-18 Alex Milowski <alex@milowski.com> 28807 28808 Reviewed by Maciej Stachowiak. 28809 28810 Added checkWebCoreMathMLSupport and hasMathMLSupport to support 28811 checking for whether MathML tests should be run 28812 28813 * Scripts/run-webkit-tests: 28814 * Scripts/webkitdirs.pm: 28815 288162009-08-28 Darin Adler <darin@apple.com> 28817 28818 Reviewed by Mark Rowe. 28819 28820 Break more of run-webkit-tests into separate functions 28821 https://bugs.webkit.org/show_bug.cgi?id=29497 28822 28823 Some small steps toward improving run-webkit-tests. My goal is to 28824 refactor much more of the script into functions. Later we can add 28825 parallel test running to the tool. But better structure may help 28826 even if someone decides to translate this into another scripting 28827 language instead. 28828 28829 * Scripts/run-webkit-tests: Break more pieces of the script into 28830 seprate functions. Added readSkippedFiles, findTestsToRun, and 28831 printResults functions. Removed custom code to skip results.html 28832 and instead just put it into the ignoredFiles hash. Fixed some 28833 indentation. Sorted function declarations, global variables, 28834 and options at the top of the file alphabetically so they're not 28835 in a semi-random order. 28836 288372009-09-17 Kevin Ollivier <kevino@theolliviers.com> 28838 28839 wx build fix, add missing dependency. 28840 28841 * wx/browser/wscript: 28842 288432009-09-16 Mark Rowe <mrowe@apple.com> 28844 28845 Split the SnowLeopard build across a few machines. 28846 28847 * BuildSlaveSupport/build.webkit.org-config/config.json: 28848 288492009-09-16 Kevin Ollivier <kevino@theolliviers.com> 28850 28851 wx build fix to support monolithic builds on Windows. 28852 28853 * wx/build/wxpresets.py: 28854 288552009-09-16 Kevin Ollivier <kevino@theolliviers.com> 28856 28857 wx build fix, improve debug support and 2.9 support on MSW. 28858 28859 * wx/build/settings.py: 28860 * wx/build/wxpresets.py: 28861 288622009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 28863 28864 Blind try at fixing new test failure on Windows. 28865 28866 * DumpRenderTree/win/FrameLoadDelegate.cpp: 28867 (FrameLoadDelegate::didReceiveTitle): 28868 288692009-09-15 Alex Milowski <alex@milowski.com> 28870 28871 Reviewed by Tor Arne Vestbø. 28872 28873 Added mathml toggle 28874 28875 * Scripts/build-webkit: 28876 288772009-09-15 Kevin Ollivier <kevino@theolliviers.com> 28878 28879 wx build fix. Allow waf build to support Python < 2.6. 28880 28881 * wx/build/waf_extensions.py: 28882 288832009-09-14 Chris Marrin <cmarrin@apple.com> 28884 28885 Reviewed by Oliver Hunt. 28886 28887 Add LayoutTests infrastructure to enable and disable webgl tests. 28888 https://bugs.webkit.org/show_bug.cgi?id=29254 28889 28890 * Scripts/run-webkit-tests: 28891 * Scripts/webkitdirs.pm: 28892 288932009-09-14 Simon Fraser <simon.fraser@apple.com> 28894 28895 Reviewed by Darin Adler. 28896 28897 Add --iterations option to run-webkit-tests to repeat the tests N times 28898 https://bugs.webkit.org/show_bug.cgi?id=29263 28899 28900 When run with --iterations N, run-webkit-tests will repeat the tests N times. 28901 28902 * Scripts/run-webkit-tests: 28903 289042009-09-14 Brady Eidson <beidson@apple.com> 28905 28906 Not reviewed, maybe should've been: 28907 28908 Cleaning up more Windows-specific fallout from the fix for: 28909 <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160 28910 28911 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 28912 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Correct printf() formatter, 28913 and call the correct method to get the Sender. 28914 289152009-09-14 Jon Honeycutt <jhoneycutt@apple.com> 28916 28917 GTK build fix. 28918 28919 Unreviewed. 28920 28921 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 28922 (AccessibilityController::setLogScrollingStartEvents): 28923 289242009-09-11 Jon Honeycutt <jhoneycutt@apple.com> 28925 28926 DRT/test part of 28927 <rdar://problem/7197644> WebKit should broadcast an MSAA event when 28928 jumping to a named anchor 28929 28930 https://bugs.webkit.org/show_bug.cgi?id=28899 28931 28932 Reviewed by Adam Roben. 28933 28934 * DumpRenderTree/AccessibilityController.cpp: 28935 (logScrollingStartEventsCallback): 28936 Turn on logging of scrolling start events. 28937 (AccessibilityController::getJSClass): 28938 Add a "logScrollingStartEvents" to the AccessibilityController's JS 28939 class definition. 28940 (AccessibilityController::resetToConsistentState): 28941 Turn off logging of scrolling start events. 28942 28943 * DumpRenderTree/AccessibilityController.h: 28944 Declare setLogScrollingStartEvents(). Add a member for the scrolling 28945 start event hook. 28946 28947 * DumpRenderTree/mac/AccessibilityControllerMac.cpp: 28948 (AccessibilityController::setLogScrollingStartEvents): 28949 Stubbed. 28950 28951 * DumpRenderTree/win/AccessibilityControllerWin.cpp: 28952 (AccessibilityController::AccessibilityController): 28953 Initialize the handle to 0. 28954 (logEventProc): 28955 Renamed from logFocusEventProc; now logs scrolling start events, too. 28956 Removed the assertion that the event is a focus event. Added a switch 28957 to print a message for focus, scrolling start, and other, unknown 28958 events. 28959 (AccessibilityController::setLogFocusEvents): 28960 Changed to use logEventProc. 28961 (AccessibilityController::setLogScrollingStartEvents): 28962 If turning logging off, unhook the scrolling start event hook, and clear 28963 the member holding the handle. If turning on, query for the root 28964 accessible, so that accessibility is enabled for the WebView, and call 28965 SetWinEventHook to setup an event hook using logEventProc as the 28966 callback function. 28967 289682009-09-14 Brady Eidson <beidson@apple.com> 28969 28970 Windows build fix. 28971 28972 * DumpRenderTree/LayoutTestController.cpp: 28973 (setAuthenticationPasswordCallback): 28974 (setAuthenticationUsernameCallback): 28975 28976 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 28977 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): 28978 289792009-09-14 Brady Eidson <beidson@apple.com> 28980 28981 Reviewed by Alexey Proskuryakov. 28982 28983 Safari 4 cannot be used to update firmware on Linksys routers. 28984 <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160 28985 28986 Add the ability for DRT to handle authentication challenges. 28987 28988 * DumpRenderTree/LayoutTestController.cpp: 28989 (setAuthenticationPasswordCallback): 28990 (setAuthenticationUsernameCallback): 28991 (setHandlesAuthenticationChallengesCallback): 28992 (LayoutTestController::staticFunctions): 28993 28994 * DumpRenderTree/LayoutTestController.h: 28995 (LayoutTestController::handlesAuthenticationChallenges): 28996 (LayoutTestController::setHandlesAuthenticationChallenges): 28997 (LayoutTestController::authenticationUsername): 28998 (LayoutTestController::setAuthenticationUsername): 28999 (LayoutTestController::authenticationPassword): 29000 (LayoutTestController::setAuthenticationPassword): 29001 29002 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 29003 (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): 29004 29005 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 29006 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): 29007 * DumpRenderTree/win/ResourceLoadDelegate.h: 29008 290092009-09-12 Mark Rowe <mrowe@apple.com> 29010 29011 Reviewed by Dan Bernstein. 29012 29013 Test for <rdar://problem/6954546> and <rdar://problem/7090444>. 29014 29015 Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New. 29016 This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>. 29017 29018 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 29019 (NPP_New): 29020 290212009-09-14 Kevin Ollivier <kevino@theolliviers.com> 29022 29023 wx build fix for non-wxPython builds and a fix for errors when updating swig.py. 29024 29025 * wx/build/build_utils.py: 29026 * wx/build/settings.py: 29027 290282009-09-14 Csaba Osztrogonac <oszi@inf.u-szeged.hu> 29029 29030 Reviewed by Tor Arne Vestbø. 29031 29032 [Qt] Build fix for windows build. 29033 29034 * Scripts/bisect-builds: Add missing paranthesis for tmpdir function. 29035 290362009-09-13 Kevin Ollivier <kevino@theolliviers.com> 29037 29038 Fix typo accidently landed in last commit. 29039 29040 * wx/build/settings.py: 29041 290422009-09-13 Kevin Ollivier <kevino@theolliviers.com> 29043 29044 wx build fix, error out if using the wrong Python. 29045 29046 * wx/build/settings.py: 29047 290482009-09-13 Xan Lopez <xlopez@igalia.com> 29049 29050 Build fix for GTK+ < 2.14. 29051 29052 Do not use gtk_widget_get_window, access the window directly 29053 through the struct. 29054 29055 * DumpRenderTree/gtk/EventSender.cpp: 29056 (contextClickCallback): 29057 (mouseDownCallback): 29058 (mouseUpCallback): 29059 (mouseMoveToCallback): 29060 (keyDownCallback): 29061 290622009-09-13 Martin Robinson <martin.james.robinson@gmail.com> 29063 29064 Reviewed by Xan Lopez and Jan Alonzo. 29065 29066 [GTK] EventSender does not set 'window' property on synthesized GDK events 29067 https://bugs.webkit.org/show_bug.cgi?id=29169 29068 29069 Set the window property on synthesized GDK events in the GTK+ EventSender. 29070 29071 * DumpRenderTree/gtk/EventSender.cpp: 29072 (contextClickCallback): 29073 (mouseDownCallback): 29074 (mouseUpCallback): 29075 (mouseMoveToCallback): 29076 (keyDownCallback): 29077 290782009-09-12 Drew Wilson <atwilson@google.com> 29079 29080 Reviewed by Mark Rowe. 29081 29082 run-webkit-tests has a timeout value that is too low 29083 https://bugs.webkit.org/show_bug.cgi?id=29223 29084 29085 * Scripts/run-webkit-tests: 29086 Changed timeout value to 20 seconds to avoid timing out too early. 29087 290882009-09-11 Kevin Ollivier <kevino@theolliviers.com> 29089 29090 wx build fix. Mark dependencies as mandatory and declare which MSVC versions and 29091 architectures are supported for building wxWebKit. 29092 29093 * wx/build/settings.py: 29094 290952009-09-11 Eric Seidel <eric@webkit.org> 29096 29097 Reviewed by David Levin. 29098 29099 bugzilla-tool rollout threw exception under svn 29100 https://bugs.webkit.org/show_bug.cgi?id=29211 29101 29102 * Scripts/modules/scm.py: add missing return, and convert number arguments to strings. 29103 * Scripts/modules/scm_unittest.py: add testing for this fix. 29104 291052009-09-11 Brian Weinstein <bweinstein@apple.com> 29106 29107 Add myself to the committers list. 29108 29109 * Scripts/modules/committers.py: 29110 291112009-09-11 Eric Seidel <eric@webkit.org> 29112 29113 Reviewed by Adam Barth. 29114 29115 bugzilla-tool land-patches should only fail-fast in --commit-queue mode 29116 https://bugs.webkit.org/show_bug.cgi?id=29201 29117 29118 * Scripts/bugzilla-tool: 29119 291202009-09-11 Adam Roben <aroben@apple.com> 29121 29122 Make commit-log-editor move common prefixes to the top of the log 29123 29124 Fies <http://webkit.org/b/29190> commit-log-editor should move common 29125 prefixes to the top of the commit log 29126 29127 Reviewed by Darin Adler. 29128 29129 * Scripts/commit-log-editor: Find and remove the longest common prefix 29130 ending in a double newline from each ChangeLog entry, then put that 29131 common prefix at the top of the commit log. 29132 (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds, 29133 removes, and returns the longest common prefix ending in a double 29134 newline from a hash of strings 29135 291362009-09-11 Eric Seidel <eric@webkit.org> 29137 29138 Fix obvious typo in previous commit, no review. 29139 29140 bugzilla-tool should automate rollouts 29141 https://bugs.webkit.org/show_bug.cgi?id=26715 29142 29143 * Scripts/bugzilla-tool: add back missing "scm" argument. 29144 291452009-09-11 Eric Seidel <eric@webkit.org> 29146 29147 Reviewed by Adam Barth. 29148 29149 bugzilla-tool should automate rollouts 29150 https://bugs.webkit.org/show_bug.cgi?id=26715 29151 29152 bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit. 29153 The --complete-rollout option will automatically land and update the bug. 29154 Eventually --complete-rollout will be default, but that will require more testing. 29155 29156 This first pass is good enough for others to try and file bugs about. 29157 29158 * Scripts/bugzilla-tool: 29159 - Move modified_changelogs into scm.py. 29160 - Move svn_revision_from_commit_text logic into scm.py. 29161 - Add RolloutCommit command. 29162 * Scripts/modules/bugzilla.py: 29163 - Add reopen_bug command used by RolloutCommit. 29164 * Scripts/modules/scm.py: 29165 - Add functions to support RolloutCommit. 29166 - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge). 29167 - Add a str() call so that svn_commit_log can take a numeric argument. 29168 - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead. 29169 - Made dry_run commits return something that svn_revision_from_commit_text can parse. 29170 * Scripts/modules/scm_unittest.py: 29171 - Add read_from_path for easy file reading. 29172 - Put test4 on a new line to make reverts work w/o conflict. 29173 - Add an "svn update" call so that the checkout revision matches the server revision. 29174 - Add tests for svn_revision_from_commit_text. 29175 - Add a simple test for apply_reverse_diff. 29176 - Add a new self.scm member and use it in the new tests (eventually other tests can use it too). 29177 - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected. 29178 291792009-09-11 Adam Roben <aroben@apple.com> 29180 29181 Get user script/stylesheet tests running on Windows 29182 29183 Fixes <http://webkit.org/b/29181> User script/stylesheet tests are 29184 skipped on Windows 29185 29186 Reviewed by John Sullivan. 29187 29188 * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations 29189 against comsuppw.lib so we can use _bstr_t. 29190 29191 * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include 29192 order, added #include of comutil.h for _bstr_t. 29193 29194 (bstrT): Helper function to convert a JSStringRef to a _bstr_t. 29195 (LayoutTestController::addUserScript): 29196 (LayoutTestController::addUserStyleSheet): 29197 Implemented. Implementations were based on those in 29198 LayoutTestControllerMac.mm. 29199 292002009-09-10 David Kilzer <ddkilzer@apple.com> 29201 29202 <http://webkit.org/b/29147> run-webkit-tests: make -h show help 29203 29204 Reviewed by Mark Rowe. 29205 29206 * Scripts/run-webkit-tests: Updated to make -h switch show help. 29207 292082009-09-10 Fumitoshi Ukai <ukai@chromium.org> 29209 29210 Reviewed by Alexey Proskuryakov. 29211 29212 Add WebCore/websockets directory in wx build system. 29213 https://bugs.webkit.org/show_bug.cgi?id=28038 29214 29215 * wx/build/settings.py: 29216 292172009-09-10 Martin Robinson <martin.james.robinson@gmail.com> 29218 29219 [GTK] EventSender does not properly convert some keyDown strings 29220 https://bugs.webkit.org/show_bug.cgi?id=29119 29221 29222 Add more keyDown string to character code conversions for GTK+ EventSender. 29223 29224 * DumpRenderTree/gtk/EventSender.cpp: 29225 (keyDownCallback): 29226 292272009-09-09 Steve Block <steveblock@google.com> 29228 29229 Reviewed by Maciej Stachowiak. 29230 29231 Geolocation Coordinates::toString() prints bogus values for unspecified properties. 29232 https://bugs.webkit.org/show_bug.cgi?id=29080 29233 29234 * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list. 29235 292362009-09-09 Eric Seidel <eric@webkit.org> 29237 29238 Reviewed by Eric Carlson. 29239 29240 reviewer/committer lookups are backwards 29241 https://bugs.webkit.org/show_bug.cgi?id=29113 29242 29243 I also moved Eric Carlson from the committer list to the reviewer list now that he is one. 29244 29245 * Scripts/modules/bugzilla.py: 29246 * Scripts/modules/committers.py: 29247 292482009-09-09 Cameron McCormack <cam@mcc.id.au> 29249 29250 Reviewed by Eric Seidel. 29251 29252 svn-unapply doesn't revert directories correctly 29253 https://bugs.webkit.org/show_bug.cgi?id=29065 29254 29255 * Scripts/svn-unapply: Make svnStatus consistently return status 29256 lines including a newline. 29257 * Scripts/svn-apply: Keep svnStatus in sync with the one in 29258 svn-unapply, in lieu of moving it to a common file. 29259 292602009-09-09 Cameron McCormack <cam@mcc.id.au> 29261 29262 Reviewed by Eric Seidel. 29263 29264 svn-apply doesn't handle changes to files copied to new directories properly 29265 https://bugs.webkit.org/show_bug.cgi?id=29059 29266 29267 * Scripts/svn-apply: Don't treat "--- revision 0" patches as being 29268 additions if we know that we've just copied a file to this name. 29269 292702009-09-09 Eric Seidel <eric@webkit.org> 29271 29272 Reviewed by David Levin. 29273 29274 commit-queue hangs if a builder has never built 29275 https://bugs.webkit.org/show_bug.cgi?id=29091 29276 29277 * Scripts/modules/buildbot.py: 29278 * Scripts/modules/buildbot_unittest.py: 29279 292802009-09-09 Zan Dobersek <zandobersek@gmail.com> 29281 29282 Reviewed by Gustavo Noronha. 29283 29284 [GTK] DumpRenderTree needs eventSender object and implementation 29285 https://bugs.webkit.org/show_bug.cgi?id=25990 29286 29287 Implements most of the EventSender object's functionality for 29288 the DumpRenderTree tool. Implementation still lacks support 29289 for drag and drop tests and forward leaps. 29290 29291 Based on work by Holger Hans Peter Freyther. 29292 29293 * DumpRenderTree/gtk/DumpRenderTree.cpp: 29294 (runTest): Focus on the view before loading a new test. 29295 (webViewWindowObjectCleared): 29296 * DumpRenderTree/gtk/EventSender.cpp: Added. 29297 (getDragModeCallback): 29298 (setDragModeCallback): 29299 (leapForwardCallback): 29300 (contextClickCallback): 29301 (updateClickCount): 29302 (mouseDownCallback): 29303 (mouseUpCallback): 29304 (mouseMoveToCallback): 29305 (beginDragWithFilesCallback): 29306 (replaySavedEvents): 29307 (keyDownCallback): 29308 (textZoomInCallback): 29309 (textZoomOutCallback): 29310 (zoomPageInCallback): 29311 (zoomPageOutCallback): 29312 (getClass): 29313 (makeEventSender): 29314 * DumpRenderTree/gtk/EventSender.h: Added. 29315 * GNUmakefile.am: Add build rules for EventSender. 29316 293172009-09-09 Daniel Bates <dbates@webkit.org> 29318 29319 Reviewed by Adam Roben. 29320 29321 https://bugs.webkit.org/show_bug.cgi?id=28953 29322 29323 Added pre- and post- build events so that on build failure, the file 29324 buildfailed is written to the directory $(WebKitOutputDir). 29325 29326 * WinLauncher/WinLauncher.vcproj: 29327 293282009-09-09 Kenneth Rohde Christiansen <kenneth@webkit.org> 29329 29330 Unreviewed. 29331 29332 Add myself to list of committers. 29333 29334 * Scripts/modules/committers.py: 29335 293362009-09-08 Eric Seidel <eric@webkit.org> 29337 29338 Reviewed by David Levin. 29339 29340 commit-queue gets stuck if a non-committer sets commit-queue+ or review+ 29341 https://bugs.webkit.org/show_bug.cgi?id=28605 29342 https://bugs.webkit.org/show_bug.cgi?id=28916 29343 29344 * Scripts/bugzilla-tool: 29345 - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit" 29346 comment now that it's used for rejecting patches for invalid committers too. 29347 - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them. 29348 - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916. 29349 * Scripts/modules/bugzilla.py: 29350 - Make _parse_attachment_element not validate reviewer/committer. 29351 - Share flag parsing code in _parse_attachment_flag. 29352 - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails. 29353 - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not. 29354 - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction. 29355 * Scripts/modules/bugzilla_unittest.py: 29356 - Update this test to no longer expect committer/reviewer validation. 29357 * Scripts/modules/committers.py: 29358 - Return None on failed lookups instead of raising Exceptions. 29359 * Scripts/modules/committers_unittest.py: 29360 - Update tests to expect None returns instead of exceptions. 29361 293622009-09-09 David Kilzer <ddkilzer@apple.com> 29363 29364 <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY() 29365 29366 Reviewed by Mark Rowe. 29367 29368 No change to layout test results. 29369 29370 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 29371 (AccessibilityUIElement::clickPointY): Changed to return y value 29372 instead of x value. 29373 293742009-09-08 Dimitri Glazkov <dglazkov@chromium.org> 29375 29376 Reviewed by Mark Rowe. 29377 29378 Reduce dglazkov's boboiness by properly concatenating revision value. 29379 29380 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution 29381 rather than "+". 29382 293832009-09-08 Kevin Ollivier <kevino@theolliviers.com> 29384 29385 wxWebKit Python extension build fix - get swig.py if it doesn't exist. 29386 29387 * wx/build/build_utils.py: 29388 293892009-09-08 Mark Rowe <mrowe@apple.com> 29390 29391 Fix an incorrect variable name in UpdateChromiumSource. 29392 29393 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 29394 293952009-09-08 Mark Rowe <mrowe@apple.com> 29396 29397 Don't check for leaks on the release SnowLeopard builder. 29398 29399 * BuildSlaveSupport/build.webkit.org-config/config.json: 29400 294012009-09-08 Mark Rowe <mrowe@apple.com> 29402 29403 Add a SnowLeopard release builder. 29404 29405 * BuildSlaveSupport/build.webkit.org-config/config.json: 29406 294072009-09-08 David Levin <levin@chromium.org> 29408 29409 Reviewed by Darin Adler. 29410 29411 Remove end of line whitespace check from check-webkit-style. 29412 https://bugs.webkit.org/show_bug.cgi?id=29053 29413 29414 * Scripts/modules/cpp_style.py: 29415 294162009-09-08 Cameron McCormack <cam@mcc.id.au> 29417 29418 Reviewed by Darin Adler. 29419 29420 Fix DumpRenderTree build from clean tree on Tiger 29421 https://bugs.webkit.org/show_bug.cgi?id=28927 29422 29423 * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the 29424 DerivedSources/DumpRenderTree directory exists when 29425 building on Tiger. 29426 294272009-09-08 Kevin Ollivier <kevino@theolliviers.com> 29428 29429 wx build fix after introduction of platform/mock directory. 29430 29431 * wx/build/settings.py: 29432 294332009-09-08 Yael Aharon <yael.aharon@nokia.com> 29434 29435 Unreviewed. 29436 29437 Add myself to list of committers. 29438 29439 * Scripts/modules/committers.py: 29440 294412009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com> 29442 29443 Unreviewed. 29444 29445 Add myself to list of committers. 29446 29447 * Scripts/modules/committers.py: 29448 294492009-09-08 Cameron McCormack <cam@mcc.id.au> 29450 29451 Reviewed by Darin Adler. 29452 29453 prepare-ChangeLog too chatty on file additions 29454 https://bugs.webkit.org/show_bug.cgi?id=29019 29455 29456 * Scripts/prepare-ChangeLog: Omit description of added properties 29457 on newly added files. 29458 294592009-09-08 Steve Block <steveblock@google.com> 29460 29461 Reviewed by Adam Barth. 29462 29463 Adds a LayoutTestController method to set the permission state for Geolocation. 29464 This is required to use the mock Geolocation service for testing. 29465 https://bugs.webkit.org/show_bug.cgi?id=29027 29466 29467 * DumpRenderTree/LayoutTestController.cpp: Modified. 29468 (setDatabaseQuotaCallback): Modified. Style fix. 29469 (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state. 29470 (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController. 29471 * DumpRenderTree/LayoutTestController.h: Modified. 29472 (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state. 29473 (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set. 29474 (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state. 29475 * DumpRenderTree/mac/UIDelegate.mm: Modified. 29476 (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state. 29477 294782009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com> 29479 29480 Reviewed by Simon Hausmann. 29481 29482 [Qt] QtWebKit single API to enable persistency 29483 https://bugs.webkit.org/show_bug.cgi?id=28682 29484 29485 Use the new enablePersistentStorage API instead 29486 of enabling all persistent features one-by-one. 29487 29488 * DumpRenderTree/qt/DumpRenderTree.cpp: 29489 (WebCore::WebPage::WebPage): 29490 (WebCore::DumpRenderTree::DumpRenderTree): 29491 294922009-09-07 Andras Becsi <becsi.andras@stud.u-szeged.hu> 29493 29494 Reviewed by Tor Arne Vestbø. 29495 29496 Refactor --strict switch to --ignore-metrics and correct the 29497 implementation to make the feature usable on all platforms. 29498 https://bugs.webkit.org/show_bug.cgi?id=28907 29499 29500 run-webkit-tests --ignore-metrics strips the font related metrics from 29501 the actual and expected data before comparing them. 29502 In this way the render trees can be checked for obvious differences but 29503 a successful test implies by no means that the layout is actually correct. 29504 29505 * Scripts/run-webkit-tests: 29506 295072009-09-07 Steve Block <steveblock@google.com> 29508 29509 Reviewed by Adam Barth. 29510 29511 Adds a mock Geolocation service. This will be used to provide predictable behavior of the 29512 Geolocation API for use in LayoutTests. Later changes will integrate the the mock 29513 Geolocation service with DumpRenderTree. 29514 https://bugs.webkit.org/show_bug.cgi?id=28264 29515 29516 * DumpRenderTree/LayoutTestController.cpp: Modified. 29517 (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service. 29518 (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service. 29519 (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController. 29520 * DumpRenderTree/LayoutTestController.h: Modified. 29521 * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified. 29522 (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service. 29523 (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service. 29524 295252009-09-07 Drew Wilson <atwilson@google.com> 29526 29527 Reviewed by David Levin. 29528 29529 Enable SHARED_WORKERS by default 29530 https://bugs.webkit.org/show_bug.cgi?id=28959 29531 29532 * Scripts/build-webkit: 29533 295342009-09-07 Kevin Ollivier <kevino@theolliviers.com> 29535 29536 wx build fixes for wx SVN trunk. 29537 29538 * wx/build/settings.py: 29539 295402009-09-04 Kevin Ollivier <kevino@theolliviers.com> 29541 29542 wx build fix. Switch USE_ defines over to the compiler so that they can be 29543 checked by files not including config.h (like WebCorePrefix.h). 29544 29545 * wx/build/settings.py: 29546 295472009-09-04 Adam Barth <abarth@webkit.org> 29548 29549 Unreviewed build fix. 29550 29551 Update declaration of FrameLoadDelegate to reflect that 29552 IWebFrameLoadDelegatePrivate2 inherits from 29553 IWebFrameLoadDelegatePrivate. 29554 29555 * DumpRenderTree/win/FrameLoadDelegate.h: 29556 295572009-09-04 Adam Barth <abarth@webkit.org> 29558 29559 Reviewed by Eric Seidel. 29560 29561 https://bugs.webkit.org/show_bug.cgi?id=24696 29562 29563 Add testing instrumentation for mixed content. 29564 29565 * DumpRenderTree/mac/FrameLoadDelegate.mm: 29566 (-[FrameLoadDelegate webView:]): 29567 (-[FrameLoadDelegate webView:didRunInsecureContent:]): 29568 * DumpRenderTree/win/FrameLoadDelegate.cpp: 29569 (descriptionSuitableForTestResult): 29570 (FrameLoadDelegate::QueryInterface): 29571 (FrameLoadDelegate::didDisplayInsecureContent): 29572 (FrameLoadDelegate::didRunInsecureContent): 29573 * DumpRenderTree/win/FrameLoadDelegate.h: 29574 295752009-09-03 Kevin Watters <kevinwatters@gmail.com> 29576 29577 Reviewed by Kevin Ollivier. 29578 29579 [wx] Frames support 29580 https://bugs.webkit.org/show_bug.cgi?id=19041 29581 29582 * wx/build-wxwebkit: 29583 295842009-09-02 David Kilzer <ddkilzer@apple.com> 29585 29586 <http://webkit.org/b/28880> svn-apply --force doesn't actually work 29587 29588 Reviewed by Eric Seidel. 29589 29590 This fixes "svn-apply --force" and adds unit tests for the 29591 scm.apply_patch() method which uses this script. 29592 29593 * Scripts/svn-apply: Created $globalExitCode variable that 29594 defaults to 0. Exit with a value of $globalExitCode when the 29595 script is finished. 29596 (applyPatch): Ignore a non-zero $exitCode if $force is true, but 29597 set $globalExitCode to $exitCode so that svn-apply exits with a 29598 non-zero status if any patches did not apply cleanly. Also 29599 print out the actual patch command if $force was not true. 29600 29601 * Scripts/modules/scm.py: 29602 (scripts_directory): Added. Extracted from script_path(). 29603 (script_path): Extracted scripts_directory(). 29604 * Scripts/modules/scm_unittest.py: Import urllib. 29605 (SVNTestRepository.setup): Save the original working directory 29606 in test_object since this represents the WebKit repository from 29607 where the unit tests are run. 29608 (SCMTest): Created new super class to hold utility methods. 29609 (SCMTest._create_patch): Creates a patch file on disk and a 29610 dictionary for use with scm.svn_apply(). 29611 (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink 29612 back to WebKitTools/Scripts in the test repository so that 29613 scm.apply_patch() is able to find the svn-apply script. 29614 (SVNTest): Inherit from SCMTest instead of unittest.TestCase. 29615 (SVNTest.tearDown): Make sure to change directories back to the 29616 original_path before the next test. 29617 (SVNTest.test_apply_svn_patch): New test case for applying an 29618 svn patch with scm.apply_patch(). 29619 (SVNTest.test_apply_svn_patch_force): New test case for applying 29620 an svn patch with scm.apply_patch() that conflicts. 29621 (GitTest): Inherit from SCMTest instead of unittest.TestCase. 29622 (GitTest.tearDown): Make sure to change directories back to the 29623 original_path before the next test. 29624 (GitTest.test_apply_git_patch): New test case for applying a git 29625 patch with scm.apply_patch(). 29626 (GitTest.test_apply_git_patch_force): New test case for applying 29627 a git patch with scm.apply_patch() that conflicts. 29628 296292009-09-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 29630 29631 Reviewed by Mark Rowe. 29632 29633 [Qt] Add support for platform-spesific layout-test results 29634 29635 For the Qt port we use the qt-[mac|linux|win] directories and then fall 29636 back to the generic qt directory for both test results and skipped list. 29637 29638 * Scripts/run-webkit-tests: 29639 * Scripts/webkitdirs.pm: 29640 296412009-09-02 Laurent Cerveau <lcerveau@me.com> 29642 29643 Reviewed by David Kilzer. 29644 29645 <http://webkit.org/b/25517> build-webkit script should print build time at end 29646 29647 * Scripts/build-webkit: 29648 Added startTime and endTime variable so that the build time is computed and printed as 29649 part of the build message; display formatting has been separated in a dedicated subroutine. 29650 296512009-09-02 David Kilzer <ddkilzer@apple.com> 29652 29653 <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root 29654 29655 Reviewed by Eric Seidel. 29656 29657 * Scripts/VCSUtils.pm: 29658 (determineSvnRoot): Added back check for repository root that 29659 was removed in r46134 when this code lived in svn-create-patch. 29660 It's necessary to check both the repository root and the 29661 repository UUID in case two different working directories are 29662 checked out from the same repository. 29663 296642009-09-02 Timothy Hatcher <timothy@apple.com> 29665 29666 Use new 512x512 icons for nightly builds. 29667 29668 Rubber-stamped by Mark Rowe. 29669 29670 * WebKitLauncher/webkit.icns: 29671 296722009-09-02 Kevin Ollivier <kevino@theolliviers.com> 29673 29674 waf build fix. Remove local variable shadowing global. 29675 29676 * wx/build/settings.py: 29677 296782009-09-02 Zan Dobersek <zandobersek@gmail.com> 29679 29680 Reviewed by David Kilzer. 29681 29682 Calls exitStatus function from the main package where it is also defined. 29683 29684 * Scripts/VCSUtils.pm: 29685 296862009-09-02 Kevin Ollivier <kevino@theolliviers.com> 29687 29688 waf build fixes for Windows/MSVC and Mac/Snow Leopard. 29689 29690 * wx/browser/wscript: 29691 * wx/build/build_utils.py: 29692 * wx/build/settings.py: 29693 296942009-08-10 Kevin Ollivier <kevino@theolliviers.com> 29695 29696 Reviewed by Eric Seidel. 29697 29698 Changes needed for build-webkit to support the waf build system for the wx port. 29699 29700 https://bugs.webkit.org/show_bug.cgi?id=27619 29701 29702 * Scripts/build-webkit: 29703 * Scripts/run-launcher: 29704 * Scripts/webkitdirs.pm: 29705 297062009-09-02 David Kilzer <ddkilzer@apple.com> 29707 29708 <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts 29709 29710 Reviewed by Eric Seidel. 29711 29712 * Scripts/update-webkit: Added "--accept postpone" to 29713 @svnOptions when running with svn-1.6 or newer. 29714 297152009-09-02 David Kilzer <ddkilzer@apple.com> 29716 29717 Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer() 29718 29719 Reviewed by Eric Seidel. 29720 29721 * Scripts/VCSUtils.pm: 29722 (@EXPORT): Added &isSVNVersion16OrNewer. 29723 (svnVersion): Added. Internal method that gets the SVN version 29724 and caches it. 29725 (isSVNVersion16OrNewer): Added. Method that does the SVN 1.6 29726 version check. 29727 * Scripts/prepare-ChangeLog: Switched to use new 29728 isSVNVersion16OrNewer() method. 29729 * Scripts/resolve-ChangeLogs: Ditto. 29730 * Scripts/svn-create-patch: Ditto. 29731 297322009-09-02 David Kilzer <ddkilzer@apple.com> 29733 29734 Clean up VCSUtils.pm 29735 29736 Reviewed by Eric Seidel. 29737 29738 * Scripts/VCSUtils.pm: Added proper package statement. Fixed 29739 indentation of BEGIN block. Listed each exported method on a 29740 line by itself. Added methods to the export list after adding 29741 the package statement. Sorted module variables. Moved 29742 definiton of $gitRoot next to other module variables. 29743 297442009-09-01 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 29745 29746 Rubber-stamped by Simon Hausmann. 29747 29748 [Qt] Fix layout-test plugins/plugin-javascript-access.html 29749 29750 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 29751 297522009-09-02 Shinichiro Hamaji <hamaji@chromium.org> 29753 29754 Reviewed by Eric Seidel. 29755 29756 js tests should move into jstests subdirectory instead of resources/ 29757 https://bugs.webkit.org/show_bug.cgi?id=25880 29758 29759 make-script-wrappers supports both resources and script-tests directories. 29760 run-webkit-tests ignores files in script-tests. 29761 Move script tests of animations to check the new script is working. 29762 29763 * Scripts/make-script-test-wrappers: 29764 * Scripts/run-webkit-tests: 29765 297662009-09-02 Szabo Carol <carol.szabo@nokia.com> 29767 29768 Reviewed by David Levin. 29769 29770 check-webkit-style uses python from /usr/bin instead of the PATH 29771 https://bugs.webkit.org/show_bug.cgi?id=28225 29772 29773 * Scripts/bugzilla-tool: 29774 * Scripts/check-webkit-style: 29775 * Scripts/run-webkit-unittests: 29776 * Scripts/update-sources-list.py: 29777 Changed the first line from 29778 #!/usr/bin/python 29779 to 29780 #!/usr/bin/env python 29781 which causes python to be invoked from the path location returned 29782 by "which python" when any of these scripts are launched. 29783 these are currently all the python scripts in WebKitTools/Scripts. 29784 297852009-09-01 David Kilzer <ddkilzer@apple.com> 29786 29787 <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards 29788 29789 Reviewed by Adam Barth. 29790 29791 * Scripts/modules/scm.py: 29792 (Git.commit_ids_from_commitish_arguments): Reverse the list of 29793 commits returned from git-rev-list since we always want to post 29794 the oldest patches first to bugs.webkit.org. 29795 * Scripts/modules/scm_unittest.py: 29796 (run): Added return statement to return the output now that we 29797 want it sometimes. 29798 (SVNTestRepository._setup_test_commits): Added a fourth commit 29799 so the GitTest.test_commitish_order() test has more commits to 29800 work with. 29801 (GitTest.test_commitish_order): Added unit test for change to 29802 Git.commit_ids_from_commitish_arguments() in scm.py. 29803 298042009-09-01 David Kilzer <ddkilzer@apple.com> 29805 29806 <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed 29807 29808 Reviewed by David Levin. 29809 29810 The mark-fixed subcommand is for those times when you don't use 29811 bugzilla-tool to commit a patch, but you want to use it to close 29812 the bug with a committed-revision message. 29813 29814 * Scripts/bugzilla-tool: 29815 (bug_comment_from_svn_revision): Added. Extracted from 29816 bug_comment_from_commit_text(). 29817 (bug_comment_from_commit_text): Extracted 29818 bug_comment_from_svn_revision() from this method. 29819 (MarkBugFixed.__init__): Added. 29820 (MarkBugFixed._fetch_commit_log): Added. Retrieves the commit 29821 log from the last commit if no svn revision is specified, else 29822 the commit log for the specified svn revision. 29823 (MarkBugFixed._determine_bug_id_and_svn_revision): Added. 29824 Attempts to determine the bug id and svn revision if one or both 29825 were not defined on the command line. 29826 (MarkBugFixed.execute): Added. Adds a comment about the 29827 revision that fixed the bug and closes the bug. 29828 (BugzillaTool.__init__): Added mark-fixed subcommand. 29829 * Scripts/modules/bugzilla.py: 29830 (Bugzilla.fetch_title_from_bug): Added. Returns the title of a 29831 bug given a bug id. 29832 * Scripts/modules/scm.py: 29833 (SCM.strip_r_from_svn_revision): Added. Utility method to strip 29834 the leading 'r' from an svn revision. 29835 (SCM.svn_commit_log): Added. Subclasses must override. 29836 (SCM.last_svn_commit_log): Added. Subclasses must override. 29837 (SVN.svn_commit_log): Added. Returns svn log for a given 29838 revision. 29839 (SVN.last_svn_commit_log): Added. Uses svnversion to find the 29840 last commit in an svn working directory and then runs svn log. 29841 (Git.svn_commit_log): Added. Returns svn log for a given 29842 revision. 29843 (Git.last_svn_commit_log): Added. Runs git-svn-log with a limit 29844 of one log message. 29845 298462009-09-01 David Kilzer <ddkilzer@apple.com> 29847 29848 <http://webkit.org/b/28880> svn-apply --force doesn't actually work 29849 29850 Reviewed by Brady Eidson. 29851 29852 * Scripts/svn-apply: 29853 (applyPatch): Add "--force" to $options arrayref if $force is 29854 set. 29855 298562009-09-01 David Kilzer <ddkilzer@apple.com> 29857 29858 <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch 29859 29860 Reviewed by Adam Roben. 29861 29862 When git-filter-branch has been invoked to rewrite ChangeLog 29863 files on series of git commits, it changes directories into 29864 .git-rewrite/t before re-running resolve-ChangeLogs. This 29865 causes determineVCSRoot() in VCSUtils.pm to return 29866 ".git-rewrite/t", which causes that path to be prepended to all 29867 ChangeLog paths, which results in an error like this: 29868 29869 error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git. 29870 Died at WebKitTools/Scripts/resolve-ChangeLogs line 376. 29871 29872 The correct way to fix this is not to try to find the repository 29873 root when invoked by git-filter-branch. 29874 29875 * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true, 29876 set $relativePath to '.' instead of calling 29877 chdirReturningRelativePath(determineVCSRoot()). 29878 (isInGitFilterBranch): Added. Checks for the existence of the 29879 MAPPED_PREVIOUS_COMMIT environment variable. 29880 298812009-09-01 Xan Lopez <xlopez@igalia.com> 29882 29883 Reviewed by Gustavo Noronha. 29884 29885 Add support for Fedora distros in the http tests 29886 https://bugs.webkit.org/show_bug.cgi?id=28263 29887 29888 Add detection code for Fedora distribution, and use the proper 29889 httpd conf file when needed. 29890 29891 * Scripts/run-webkit-httpd: 29892 * Scripts/run-webkit-tests: 29893 * Scripts/webkitdirs.pm: 29894 298952009-09-01 Jan Michael Alonzo <jmalonzo@webkit.org> 29896 29897 Reviewed by Eric Seidel. 29898 29899 [Gtk] DRT needs implementation of overridePreference 29900 https://bugs.webkit.org/show_bug.cgi?id=28830 29901 29902 Implement overridePreference. 29903 29904 * DumpRenderTree/gtk/DumpRenderTree.cpp: 29905 (resetDefaultsToConsistentValues): 29906 (setDefaultsToConsistentStateValuesForTesting): 29907 (runTest): 29908 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 29909 (toWebSettingKey): 29910 (LayoutTestController::overridePreference): 29911 299122009-09-01 Joseph Pecoraro <joepeck@webkit.org> 29913 29914 <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying 29915 29916 Reviewed by Eric Seidel. 29917 29918 Jump back and forth between the repository root directory (to apply) and the 29919 directory the script was run from (to find the patch). 29920 29921 * Scripts/svn-apply: 29922 * Scripts/svn-unapply: 29923 299242009-08-31 Adam Roben <aroben@apple.com> 29925 29926 Fall back to a Release version of Safari if a Debug one doesn't exist 29927 29928 <http://webkit.org/b/28849> 29929 29930 Reviewed by Sam Weinig. 29931 29932 * Scripts/webkitdirs.pm: 29933 (safariPath): If the user is working with a Debug build, but there's 29934 no Debug version of Safari present, fall back to using a Release 29935 version of Safari. 29936 299372009-08-31 Adam Roben <aroben@apple.com> 29938 29939 Make safariPath() work for Debug builds of Safari on Windows 29940 29941 <http://webkit.org/b/28849> 29942 29943 Reviewed by Sam Weinig. 29944 29945 * Scripts/webkitdirs.pm: 29946 (safariPath): If the user is working with a Debug build, add the 29947 _debug suffix to Safari.exe. 29948 299492009-08-28 Eric Seidel <eric@webkit.org> 29950 29951 Reviewed by Adam Barth. 29952 29953 commit-queue needs a master process 29954 https://bugs.webkit.org/show_bug.cgi?id=28040 29955 29956 Add a bugzilla-tool commit-queue command 29957 Keeps per-bug logs, but doesn't yet upload them anywhere. 29958 29959 * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue' 29960 * Scripts/modules/buildbot.py: remove noisy log message 29961 * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python 29962 299632009-08-28 Jan Michael Alonzo <jmalonzo@webkit.org> 29964 29965 Reviewed by Gustavo Noronha. 29966 29967 [GTK] Geolocation needs permission API before being enabled by default 29968 29969 Build the Gtk port with geolocation enabled. This option is only 29970 enabled for the buildbot. The autotools option will be enabled by 29971 default once the permissions API is implemented. 29972 29973 * Scripts/build-webkit: 29974 299752009-08-26 Cameron McCormack <cam@mcc.id.au> 29976 29977 Reviewed by David Kilzer. 29978 29979 Make prepare-ChangeLog notice property changes 29980 https://bugs.webkit.org/show_bug.cgi?id=28675 29981 29982 Make the generated ChangeLog entry include a short description of 29983 property changes if there were such changes. Also make 29984 prepare-ChangeLog not bail if the only changes are property changes. 29985 29986 * Scripts/prepare-ChangeLog: 29987 299882009-08-26 Adam Barth <abarth@webkit.org> 29989 29990 Reviewed by Oliver Hunt. 29991 29992 Don't let local files access web URLs 29993 https://bugs.webkit.org/show_bug.cgi?id=28480 29994 29995 A bunch of our LayoutTests rely on our old behavior, so we explicitly 29996 grant local files universal access during testing. Mainly, these tests 29997 involve making XMLHttpRequests for data URLs. 29998 29999 * DumpRenderTree/mac/DumpRenderTree.mm: 30000 (resetDefaultsToConsistentValues): 30001 * DumpRenderTree/qt/DumpRenderTree.cpp: 30002 (WebCore::WebPage::WebPage): 30003 * DumpRenderTree/win/DumpRenderTree.cpp: 30004 (resetDefaultsToConsistentValues): 30005 300062009-08-26 John Gregg <johnnyg@google.com> 30007 30008 Reviewed by David Levin. 30009 30010 Minor style correction and include fix for notifications 30011 https://bugs.webkit.org/show_bug.cgi?id=28745 30012 30013 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: 30014 change to correct EnumStyle 30015 (DRTDesktopNotificationPresenter::checkNotificationPermission): 30016 300172009-08-26 David Levin <levin@chromium.org> 30018 30019 Reviewed by Alexey Proskuryakov. 30020 30021 XMLHttpRequest.withCredentials=false shouldn't save cookies. 30022 https://bugs.webkit.org/show_bug.cgi?id=28743 30023 30024 Added the support to the layout test controller on OSX and 30025 Windows (for CFNETWORK) to allow for changing the accept cookie 30026 policy. 30027 30028 * DumpRenderTree/LayoutTestController.cpp: 30029 (LayoutTestController::LayoutTestController): Added a bool 30030 to track the state of accepting cookies. 30031 (setAlwaysAcceptCookiesCallback): Standard wrapper method 30032 to go from js to a C++ method. 30033 (LayoutTestController::staticFunctions): Added the 30034 setAlwaysAcceptCookies method to the js layoutTestController. 30035 * DumpRenderTree/LayoutTestController.h: 30036 (LayoutTestController::alwaysAcceptCookies): Returns the value. 30037 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 30038 (LayoutTestController::setAlwaysAcceptCookies): Stub out method. 30039 * DumpRenderTree/mac/DumpRenderTree.mm: 30040 (resetDefaultsToConsistentValues): Reset the accept cookie to 30041 its default. 30042 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 30043 (LayoutTestController::setAlwaysAcceptCookies): Does the work for 30044 OSX to change the cookie accept policy. 30045 * DumpRenderTree/win/DumpRenderTree.cpp: 30046 (setAlwaysAcceptCookies): Method to handle all the calls necessary 30047 to change the accept cookie policy on Windows. 30048 (resetDefaultsToConsistentValues): Reset the accept cookie to 30049 its default. 30050 * DumpRenderTree/win/DumpRenderTreeWin.h: 30051 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 30052 (LayoutTestController::setAlwaysAcceptCookies): Stub out method. 30053 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 30054 (LayoutTestController::setAlwaysAcceptCookies): Stub out method. 30055 300562009-08-26 Dimitri Glazkov <dglazkov@chromium.org> 30057 30058 Unreviewed. 30059 30060 Remove accidentally left in clobber option. 30061 https://bugs.webkit.org/show_bug.cgi?id=28400 30062 30063 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option. 30064 300652009-08-26 Dimitri Glazkov <dglazkov@chromium.org> 30066 30067 Reviewed by Mark Rowe. 30068 30069 Add canary-style Chromium WebKit build slave to the waterfall. 30070 https://bugs.webkit.org/show_bug.cgi?id=28400 30071 30072 * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave 30073 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands. 30074 300752009-08-25 Cameron McCormack <cam@mcc.id.au> 30076 30077 Reviewed by Darin Adler. 30078 30079 make-script-test-wrappers should be executable 30080 https://bugs.webkit.org/show_bug.cgi?id=28669 30081 30082 Make make-script-test-wrappers and update-sources-list.py both be 30083 executable. 30084 30085 * Scripts/update-sources-list.py: 30086 * Scripts/make-script-test-wrappers: 30087 300882009-08-25 Brent Fulgham <bfulgham@webkit.org> 30089 30090 Build fix 30091 30092 Revise Debug_Cairo targets to point inherit from the 30093 debug_wincairo.vsprops property sheet so that they link 30094 against the proper libraries in Debug build. 30095 30096 * DumpRenderTree/win/DumpRenderTree.vcproj: 30097 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 30098 * WinLauncher/WinLauncher.vcproj: 30099 301002009-08-25 David Levin <levin@chromium.org> 30101 30102 Reviewed by Adam Roben. 30103 30104 PLATFORM(CFNETWORK) should be USE(CFNETWORK). 30105 https://bugs.webkit.org/show_bug.cgi?id=28713 30106 30107 * DumpRenderTree/win/DumpRenderTree.cpp: 30108 (main): 30109 301102009-08-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 30111 30112 Reviewed by Ariya Hidayat. 30113 30114 [Qt/Mac] Use CONFIG+=build_all only when building libraries 30115 30116 If no configuration is specified when building WebKit we pass the 30117 debug_and_release option to QMake which results in Makefiles for 30118 both configurations being generated. 30119 30120 Previously we built both of these configurations by default, for 30121 all targets (both the QtWebKit framework/dyldlib and the various 30122 executables such as QtLauncher and tests). This makes sense for 30123 the libraries, which get the _debug suffix and can be loaded on 30124 demand by setting the DYLD_IMAGE_SUFFIX, but for executables we 30125 ended up building the same executable twice. 30126 30127 We now only build one instance of each executable, and since this 30128 is a developer build we build the debug-version. Passing either 30129 --debug or --release to build-webkit will override this, and 30130 even in the default case the release version can still be built 30131 by running 'make release' in the the build directory of each 30132 target. 30133 30134 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 30135 * Scripts/webkitdirs.pm: 30136 301372009-08-24 Hironori Bono <hbono@chromium.org> 30138 30139 Reviewed by Adam Barth. 30140 30141 Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet". 30142 <https://bugs.webkit.org/show_bug.cgi?id=27827>. 30143 30144 Because of the lack of mappings from GDK key-codes to WebKit key-codes, 30145 Chromium cannot send valid key-codes to JavaScript when a user types 30146 function keys. This change just copies the mappings from 'KeyEventGtk.cpp'. 30147 30148 To write layout tests for this issue, added mappings from function-key 30149 names to platform-specific key-codes to EventSendingController objects 30150 so that eventSender.keyDown() can send function-key events without using 30151 platform-specific key codes. (Unfortunately, this eventSender.keyDown() change 30152 is only for Mac. So this change adds this new test to Skipped tests for other 30153 platforms to prevent this change from crashing the build trees.) 30154 30155 * DumpRenderTree/mac/EventSendingController.mm: 30156 (-[EventSendingController keyDown:withModifiers:]): 30157 301582009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org> 30159 30160 Reviewed by Xan Lopez. 30161 30162 [Gtk] API for disabling local file access to web URLs 30163 https://bugs.webkit.org/show_bug.cgi?id=28663 30164 30165 Enable this setting for DRT. 30166 30167 * DumpRenderTree/gtk/DumpRenderTree.cpp: 30168 (resetWebViewToConsistentStateBeforeTesting): 30169 301702009-08-22 Adam Barth <abarth@webkit.org> 30171 30172 Revert 47684. We're going to do this later once clients have had a 30173 chance to opt into the setting they like. 30174 30175 * DumpRenderTree/mac/DumpRenderTree.mm: 30176 (resetDefaultsToConsistentValues): 30177 * DumpRenderTree/qt/DumpRenderTree.cpp: 30178 (WebCore::WebPage::WebPage): 30179 * DumpRenderTree/win/DumpRenderTree.cpp: 30180 (resetDefaultsToConsistentValues): 30181 301822009-08-22 Adam Barth <abarth@webkit.org> 30183 30184 Reviewed by Eric Seidel. 30185 30186 Don't let local files access web URLs 30187 https://bugs.webkit.org/show_bug.cgi?id=28480 30188 30189 A bunch of our LayoutTests rely on our old behavior, so we explicitly 30190 grant local files universal access during testing. Mainly, these tests 30191 involve making XMLHttpRequests for data URLs. 30192 30193 * DumpRenderTree/mac/DumpRenderTree.mm: 30194 (resetDefaultsToConsistentValues): 30195 * DumpRenderTree/qt/DumpRenderTree.cpp: 30196 (WebCore::WebPage::WebPage): 30197 * DumpRenderTree/win/DumpRenderTree.cpp: 30198 (resetDefaultsToConsistentValues): 30199 302002009-08-22 Mark Rowe <mrowe@apple.com> 30201 30202 Rubber-stamped by Anders Carlsson. 30203 30204 Bring signed updates to the Mac nightly builds. 30205 30206 * WebKitLauncher/Info.plist: 30207 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: 30208 * WebKitLauncher/WebKitNightlyEnablerSparkle.m: 30209 (initializeSparkle): 30210 * WebKitLauncher/nightly.webkit.org.public.pem: Added. 30211 302122009-08-21 Jan Michael Alonzo <jmalonzo@webkit.org> 30213 30214 Rubberstamped by Simon Fraser. 30215 30216 Remove GNOME keyring support in build-webkit. This dependency's 30217 already been removed in the Gtk port. 30218 30219 * Scripts/build-webkit: 30220 302212009-08-20 Brian Weinstein <bweinstein@apple.com> 30222 30223 Reviewed by Adam Roben. 30224 Based on original patch by Stephanie Lewis. 30225 30226 Added support of the Windows malloc history format to parse-malloc history, so we can 30227 read and parse it. 30228 30229 * Scripts/parse-malloc-history: 30230 302312009-08-20 Chris Fleizach <cfleizach@apple.com> 30232 30233 Reviewed by Darin Adler. 30234 30235 Enable various "grouping" ARIA roles 30236 https://bugs.webkit.org/show_bug.cgi?id=28486 30237 30238 Expose the ability to retrieve the subrole through accessibility for DRT. 30239 30240 * DumpRenderTree/AccessibilityUIElement.cpp: 30241 * DumpRenderTree/AccessibilityUIElement.h: 30242 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 30243 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 30244 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 30245 302462009-08-20 Joseph Pecoraro <joepeck@webkit.org> 30247 30248 Unreviewed. 30249 30250 Added myself as a committer. 30251 30252 * Scripts/modules/committers.py: 30253 302542009-08-20 Xan Lopez <xlopez@igalia.com> 30255 30256 Reviewed by Gustavo Noronha. 30257 30258 Fix memory leaks. 30259 30260 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 30261 (LayoutTestController::whiteListAccessFromOrigin): 30262 (LayoutTestController::pauseAnimationAtTimeOnElementWithId): 30263 (LayoutTestController::pauseTransitionAtTimeOnElementWithId): 30264 302652009-08-20 Eric Seidel <eric@webkit.org> 30266 30267 Reviewed by Adam Barth. 30268 30269 bugzilla-tool post-diff can post partial diffs from SVN checkouts. 30270 https://bugs.webkit.org/show_bug.cgi?id=28445 30271 30272 Pass the checkout root as the cwd. Also wrote a test to ensure this. 30273 30274 * Scripts/modules/scm.py: 30275 * Scripts/modules/scm_unittest.py: 30276 302772009-08-20 Mark Rowe <mrowe@apple.com> 30278 30279 Reviewed by Adele Peterson. 30280 30281 Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue. 30282 30283 * DumpRenderTree/AccessibilityUIElement.cpp: 30284 (attributeValueCallback): 30285 302862009-08-20 Ariya Hidayat <ariya.hidayat@nokia.com> 30287 30288 Unreviewed, build fix. 30289 30290 [Qt] The template-based qMax() compares two qreals. 30291 30292 * DumpRenderTree/qt/ImageDiff.cpp: 30293 (main): 30294 302952009-08-20 David Levin <levin@chromium.org> 30296 30297 Reviewed by David Kilzer. 30298 30299 bugzilla-tool patch retrieval should handle 302 redirects. 30300 https://bugs.webkit.org/show_bug.cgi?id=28485 30301 30302 * Scripts/modules/scm.py: Pass the --location parameter to curl 30303 so that 302's are followed. 30304 303052009-08-20 Aaron Boodman <aa@chromium.org> 30306 30307 One more speculative build for gtk. 30308 30309 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 30310 303112009-08-20 Aaron Boodman <aa@chromium.org> 30312 30313 Speculative build for gtk. 30314 30315 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 30316 (LayoutTestController::whiteListAccessFromOrigin): 30317 303182009-08-20 Mark Rowe <mrowe@apple.com> 30319 30320 Ignore some leaks that are known to originate from ImageIO. 30321 30322 * Scripts/run-webkit-tests: 30323 303242009-08-20 Aaron Boodman <aa@chromium.org> 30325 30326 With David Levin. 30327 30328 Speculative build fix for qt. 30329 30330 * DumpRenderTree/qt/jsobjects.cpp: 30331 (LayoutTestController::whiteListAccessFromOrigin): 30332 * DumpRenderTree/qt/jsobjects.h: 30333 303342009-08-19 Mark Rowe <mrowe@apple.com> 30335 30336 Reviewed by Dan Bernstein. 30337 30338 Fix <http://webkit.org/b/28484> Plug-in-related leaks seen on the build bot 30339 30340 Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit. 30341 30342 * Scripts/check-for-global-initializers: 30343 303442009-08-19 Aaron Boodman <aa@chromium.org> 30345 30346 Reviewed by David Levin. 30347 30348 https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to 30349 specify a more granular policy for cross-origin XHR access. 30350 30351 * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests. 30352 (whiteListAccessFromOriginCallback): Ditto. 30353 (LayoutTestController::staticFunctions): Ditto. 30354 * DumpRenderTree/LayoutTestController.h: Ditto. 30355 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto. 30356 (LayoutTestController::whiteListAccessToOrigin): Ditto. 30357 * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto. 30358 (LayoutTestController::whiteListAccessFromOrigin): Ditto. 30359 * DumpRenderTree/qt/jsobjects.cpp: Ditto. 30360 (LayoutTestController::whiteListAccessFromOrigin): Ditto. 30361 * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin(). 30362 (LayoutTestController::whiteListAccessFromOrigin): Ditto. 30363 * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test. 30364 (resetWebViewToConsistentStateBeforeTesting): Ditto. 30365 * DumpRenderTree/mac/DumpRenderTree.mm: Ditto. 30366 (resetWebViewToConsistentStateBeforeTesting): Ditto. 30367 * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto. 30368 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto. 30369 303702009-08-19 Mark Rowe <mrowe@apple.com> 30371 30372 Rubber-stamped by Dan Bernstein. 30373 30374 Ignore some leaks that are known to originate from QTKit. 30375 30376 * Scripts/run-webkit-tests: 30377 303782009-08-19 Eric Seidel <eric@webkit.org> 30379 30380 Reviewed by Adam Barth. 30381 30382 commit-queue/bugzilla-tool can get wedged if git is mid-rebase 30383 https://bugs.webkit.org/show_bug.cgi?id=28436 30384 30385 Make clean_working_directory cancel rebases too (even though that's a bit of a hack). 30386 This code will only ever be run when --force-clean is passed. 30387 30388 I also added a new unit test to make sure this code actually works. :) 30389 30390 * Scripts/modules/scm.py: 30391 * Scripts/modules/scm_unittest.py: 30392 303932009-08-19 Eric Seidel <eric@webkit.org> 30394 30395 Reviewed by David Levin. 30396 30397 WebKit needs a changelogs.py to hold changelog-related code 30398 https://bugs.webkit.org/show_bug.cgi?id=28477 30399 30400 This is moving code and adding tests. There was only one functional 30401 change (which was removing a trailing newline from the last_entry() result). 30402 30403 * Scripts/bugzilla-tool: 30404 * Scripts/modules/changelogs.py: Added. 30405 * Scripts/modules/changelogs_unittest.py: Added. 30406 * Scripts/run-webkit-unittests: 30407 304082009-08-20 Eric Seidel <eric@webkit.org> 30409 30410 Reviewed by Adam Barth. 30411 30412 bugzilla-tool needs a way to ask build.webkit.org if the bots are passing 30413 https://bugs.webkit.org/show_bug.cgi?id=28222 30414 30415 Basic support for now. This has been in testing for 24 hours now and worked great! 30416 30417 * Scripts/bugzilla-tool: 30418 * Scripts/modules/buildbot.py: Added. 30419 * Scripts/modules/buildbot_unittest.py: Added. 30420 * Scripts/run-webkit-unittests: 30421 304222009-08-19 Jan Michael Alonzo <jmalonzo@webkit.org> 30423 30424 Reviewed by Gustavo Noronha. 30425 30426 [Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the 30427 default timeout used by run-webkit-tests. Mac and Win ports were 30428 recently bumped in http://trac.webkit.org/changeset/r47465. 30429 30430 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 30431 (LayoutTestController::setWaitToDump): 30432 304332009-08-19 David D. Kilzer <ddkilzer@webkit.org> 30434 30435 DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger 30436 30437 Reviewed by Mark Rowe. 30438 30439 Provide pre-generated swig source files for Tiger so it may 30440 benefit from the faster run-webkit-tests. 30441 30442 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm: 30443 Generated by swig. 30444 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added. 30445 Generated by swig. 30446 (swig_type_info::SWIG_TypeNameComp): 30447 (swig_type_info::SWIG_TypeEquiv): 30448 (swig_type_info::SWIG_TypeRegisterTL): 30449 (swig_type_info::SWIG_TypeCheck): 30450 (swig_type_info::SWIG_TypeCast): 30451 (swig_type_info::SWIG_TypeDynamicCast): 30452 (swig_type_info::SWIG_TypeName): 30453 (swig_type_info::SWIG_TypePrettyName): 30454 (swig_type_info::SWIG_TypeQueryTL): 30455 (swig_type_info::SWIG_TypeClientDataTL): 30456 (swig_type_info::SWIG_PackData): 30457 (swig_type_info::SWIG_UnpackData): 30458 (swig_type_info::SWIG_PropagateClientDataTL): 30459 (swig_type_info::SWIG_PackVoidPtr): 30460 (swig_type_info::SWIG_UnpackVoidPtr): 30461 (swig_type_info::SWIG_PackDataName): 30462 (swig_type_info::SWIG_UnpackDataName): 30463 * DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on 30464 Tiger using pre-generated files. 30465 304662009-08-18 Shinichiro Hamaji <hamaji@chromium.org> 30467 30468 Reviewed by David Kilzer. 30469 30470 run-webkit-tests hangs when WebCore tries to log too much 30471 https://bugs.webkit.org/show_bug.cgi?id=15743 30472 30473 Read stdout and stderr in parallel. 30474 30475 * Scripts/run-webkit-tests: 30476 304772009-08-18 Mark Rowe <mrowe@apple.com> 30478 30479 Rubber-stamped by Oliver Hunt. 30480 30481 Add a new build configuration that checks for leaks during the layout tests, 30482 and hook a new machine up to it. 30483 30484 * BuildSlaveSupport/build.webkit.org-config/config.json: 30485 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 30486 304872009-08-18 Aaron Boodman <aa@chromium.org> 30488 30489 Reviewed by Maciej Stachowiak. 30490 30491 https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests. 30492 30493 No new tests: Already covered by existing tests. 30494 30495 * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest. 30496 304972009-08-18 Mark Rowe <mrowe@apple.com> 30498 30499 Rubber-stamped by Geoff Garen. 30500 30501 Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests. 30502 30503 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 30504 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 30505 305062009-08-18 Brian Weinstein <bweinstein@apple.com> 30507 30508 Rubber-stamped by Adam Roben. 30509 30510 Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them, 30511 and removed include to fix building on VC++ Express. 30512 30513 * DumpRenderTree/win/UIDelegate.cpp: 30514 (UIDelegate::exceededDatabaseQuota): 30515 305162009-08-18 Brian Weinstein <bweinstein@apple.com> 30517 30518 Reviewed by Oliver Hunt. 30519 30520 Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support 30521 LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota. 30522 30523 Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface. 30524 Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac. 30525 30526 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 30527 (LayoutTestController::setDatabaseQuota): 30528 * DumpRenderTree/win/UIDelegate.cpp: 30529 (UIDelegate::exceededDatabaseQuota): 30530 305312009-08-18 Peter Kasting <pkasting@google.com> 30532 30533 Reviewed by Eric Seidel. 30534 30535 https://bugs.webkit.org/show_bug.cgi?id=28415 30536 Set svn:eol-style CRLF on all .sln and .vcproj files that don't already 30537 have it. 30538 30539 * record-memory-win/record-memory-win.vcproj: 30540 * WinLauncher/WinLauncher.vcproj: 30541 * WebKitLauncherWin/WebKitLauncherWin.vcproj: 30542 * DumpRenderTree/win/ImageDiff.vcproj: 30543 * FindSafari/FindSafari.vcproj: 30544 305452009-08-18 Drew Wilson <atwilson@google.com> 30546 30547 Reviewed by Eric Seidel. 30548 30549 Need to extend DumpRenderTree to expose number of worker threads 30550 https://bugs.webkit.org/show_bug.cgi?id=28292 30551 30552 Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit. 30553 30554 * DumpRenderTree/LayoutTestController.cpp: 30555 (getWorkerThreadCountCallback): 30556 (LayoutTestController::staticValues): 30557 * DumpRenderTree/LayoutTestController.h: 30558 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 30559 (LayoutTestController::workerThreadCount): 30560 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 30561 (LayoutTestController::workerThreadCount): 30562 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 30563 (LayoutTestController::workerThreadCount): 30564 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 30565 (LayoutTestController::workerThreadCount): 30566 305672009-08-18 Xan Lopez <xlopez@igalia.com> 30568 30569 Reviewed by Jan Alonzo. 30570 30571 Initialize x and y in the GtkAllocation structure to shut up 30572 valgrind. 30573 30574 * DumpRenderTree/gtk/DumpRenderTree.cpp: 30575 (runTest): 30576 305772009-08-17 Shinichiro Hamaji <hamaji@chromium.org> 30578 30579 Reviewed by Darin Adler. 30580 30581 Some HTMLs are modified by make-script-test-wrappers 30582 https://bugs.webkit.org/show_bug.cgi?id=28213 30583 30584 Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into 30585 the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and 30586 re-generated wml/* and Geolocation/* . 30587 30588 * Scripts/make-script-test-wrappers: 30589 305902009-08-17 Shinichiro Hamaji <hamaji@chromium.org> 30591 30592 Reviewed by Eric Seidel. 30593 30594 -webkit-box-orient:horizontal doesn't work on <button> tag 30595 https://bugs.webkit.org/show_bug.cgi?id=34445 30596 30597 Make a flexible button's anonymous child flexible and pass the 30598 parent's box-orient to the anonymous child. 30599 30600 Also, added a renderName for anonymous flexible boxes. 30601 30602 * Scripts/make-script-test-wrappers: 30603 306042009-08-17 Eric Seidel <eric@webkit.org> 30605 30606 Reviewed by Darin Adler. 30607 30608 Can no longer --reset-results of a layout test directory 30609 https://bugs.webkit.org/show_bug.cgi?id=28336 30610 30611 --reset-results and --exit-after-n-failures are incompatible. 30612 30613 * Scripts/run-webkit-tests: 30614 306152009-08-17 David Kilzer <ddkilzer@apple.com> 30616 30617 <http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git 30618 30619 Reviewed by Adam Roben. 30620 30621 New commit message: 30622 Committed r12345: <http://trac.webkit.org/changeset/12345> 30623 30624 * Scripts/bugzilla-tool: 30625 (bug_comment_from_commit_text): Print out a compact, 30626 standardized commit message for both git and svn. 30627 306282009-08-17 Peter Kasting <pkasting@google.com> 30629 30630 Reviewed by Steve Falkenburg. 30631 30632 https://bugs.webkit.org/show_bug.cgi?id=27323 30633 Only add Cygwin to the path when it isn't already there. This avoids 30634 causing problems for people who purposefully have non-Cygwin versions of 30635 executables like svn in front of the Cygwin ones in their paths. 30636 30637 * DumpRenderTree/win/DumpRenderTree.vcproj: 30638 * DumpRenderTree/win/ImageDiff.vcproj: 30639 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 30640 306412009-08-17 David Kilzer <ddkilzer@apple.com> 30642 30643 <http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN() 30644 30645 Reviewed by David Levin. 30646 30647 * Scripts/modules/cpp_style.py: 30648 (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'. 30649 (check_max_min_macros): Added. Returns level 4 error when MAX() 30650 and MIN() macros are used in header files and C++ source files. 30651 (check_style): Added call to check_max_min_macros(). 30652 * Scripts/modules/cpp_style_unittest.py: Added unit tests. 30653 (test_max_macro): Added. 30654 (test_min_macro): Added. 30655 306562009-08-13 Mike Fenton <mike.fenton@torchmobile.com> 30657 30658 Reviewed by Eric Seidel. 30659 30660 Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp 30661 and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp. 30662 30663 https://bugs.webkit.org/show_bug.cgi?id=28268 30664 30665 * platform/graphics/GraphicsContext.cpp: 30666 (WebCore::GraphicsContext::adjustLineToPixelBoundaries): 30667 * platform/graphics/GraphicsContext.h: 30668 * platform/graphics/cairo/GraphicsContextCairo.cpp: 30669 * platform/graphics/qt/GraphicsContextQt.cpp: 30670 306712009-08-10 Mike Fenton <mike.fenton@torchmobile.com> 30672 30673 Reviewed by Adam Treat. 30674 30675 Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and 30676 WebKit style guide. 30677 30678 https://bugs.webkit.org/show_bug.cgi?id=28161 30679 30680 * DumpRenderTree/qt/jsobjects.cpp: 30681 (findFrameNamed): 30682 (LoadItem::invoke): 30683 (LayoutTestController::provisionalLoad): 30684 (LayoutTestController::timerEvent): 30685 (LayoutTestController::pauseAnimationAtTimeOnElementWithId): 30686 (LayoutTestController::pauseTransitionAtTimeOnElementWithId): 30687 (LayoutTestController::numberOfActiveAnimations): 30688 (EventSender::keyDown): 30689 (EventSender::frameUnderMouse): 30690 (TextInputController::doCommand): 30691 306922009-08-16 David Kilzer <ddkilzer@apple.com> 30693 30694 <http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements 30695 30696 Reviewed by David Levin. 30697 30698 In <http://webkit.org/b/28355#c1>, it was noted that new source 30699 files use 'using namespace std;' instead of individual 30700 'using std::foo;' statements. This adds a level 4 check for 30701 such statements. 30702 30703 * Scripts/modules/cpp_style.py: 30704 (_ERROR_CATEGORIES): Added 'build/using_std'. 30705 (check_using_std): Added. 30706 (check_style): Added call to check_using_std(). 30707 * Scripts/modules/cpp_style_unittest.py: 30708 (WebKitStyleTest.test_using_std): Added unit test. 30709 307102009-08-16 David Kilzer <ddkilzer@apple.com> 30711 30712 Backed out r47343 which was mistakenly committed 30713 30714 * Scripts/bugzilla-tool: 30715 * Scripts/modules/scm.py: 30716 307172009-08-16 David Kilzer <ddkilzer@apple.com> 30718 30719 <http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class 30720 30721 Reviewed by David Levin. 30722 30723 The ScriptError class doesn't exist in bugzilla.py, so any 30724 errors print error messages about ScriptError instead of the 30725 actual error: 30726 30727 NameError: global name 'ScriptError' is not defined 30728 30729 * Scripts/modules/bugzilla.py: 30730 (BugzillaError): Added class. Modeled after ScriptError class 30731 in scm.py. 30732 (Bugzilla.authenticate): Changed to use BugzillaError instead of 30733 ScriptError. 30734 (Bugzilla._check_create_bug_response): Ditto. 30735 307362009-08-14 Adam Bergkvist <adam.bergkvist@ericsson.com> 30737 30738 Reviewed by Sam Weinig. 30739 30740 Added EventSource to the build script (default on). 30741 https://bugs.webkit.org/show_bug.cgi?id=14997 30742 30743 * Scripts/build-webkit: 30744 307452009-08-15 Ryosuke Niwa <rniwa@webkit.org> 30746 30747 Unreviewed. 30748 30749 Add myself to list of committers. 30750 30751 * Scripts/modules/committers.py: 30752 307532009-08-15 Jon Honeycutt <jhoneycutt@apple.com> 30754 30755 Fix layout test failures after r47312. 30756 30757 Reviewed by Cameron Zwarich. 30758 30759 * DumpRenderTree/AccessibilityController.h: 30760 Replaced logFocusEvents() with setLogFocusEvents(), which takes a 30761 boolean argument to turn logging of focus events on or off. 30762 Added a function to reset the AccessibilityController to a consistent 30763 state. 30764 30765 * DumpRenderTree/AccessibilityController.cpp: 30766 (logFocusEventsCallback): 30767 Call setLogFocusEvents() to enable logging. 30768 (AccessibilityController::resetToConsistentState): 30769 Call setLogFocusEvents() to disable logging. 30770 30771 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 30772 (AccessibilityController::setLogFocusEvents): 30773 Update stub. 30774 30775 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 30776 (AccessibilityController::setLogFocusEvents): 30777 Update stub. 30778 30779 * DumpRenderTree/mac/DumpRenderTree.mm: 30780 (resetWebViewToConsistentStateBeforeTesting): 30781 Call the FrameLoadDelegate's resetToConsistentState method. 30782 30783 * DumpRenderTree/mac/FrameLoadDelegate.h: 30784 Declare the resetToConsistentState method. 30785 30786 * DumpRenderTree/mac/FrameLoadDelegate.mm: 30787 (-[FrameLoadDelegate resetToConsistentState]): 30788 Call the AccessibilityController's resetToConsistentState() function. 30789 30790 * DumpRenderTree/win/AccessibilityControllerWin.cpp: 30791 (AccessibilityController::~AccessibilityController): 30792 Turn off focus event logging when the controller is destroyed. 30793 (AccessibilityController::setLogFocusEvents): 30794 If the caller passes false, unhook the focus event, and clear 30795 m_focusEventHook. 30796 30797 * DumpRenderTree/win/DumpRenderTree.cpp: 30798 (resetWebViewToConsistentStateBeforeTesting): 30799 Call the FrameLoadDelegate's resetToConsistentState function. 30800 30801 * DumpRenderTree/win/FrameLoadDelegate.h: 30802 Declare the resetToConsistentState() function. 30803 30804 * DumpRenderTree/win/FrameLoadDelegate.cpp: 30805 (FrameLoadDelegate::resetToConsistentState): 30806 Call the AccessibilityController's resetToConsistentState() function. 30807 30808 308092009-08-14 Jon Honeycutt <jhoneycutt@apple.com> 30810 30811 Add a mechanism for logging MSAA focus events. 30812 30813 Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit 30814 nightly (20866) 30815 30816 https://bugs.webkit.org/show_bug.cgi?id=20866 30817 30818 Reviewed by Oliver Hunt. 30819 30820 * DumpRenderTree/AccessibilityController.cpp: 30821 (logFocusEventsCallback): 30822 Call the AccessibilityController's logFocusEvents() function. 30823 (AccessibilityController::getJSClass): 30824 Add a "logFocusEvents" function to the AccessibilityController's JS 30825 class definition. 30826 30827 * DumpRenderTree/AccessibilityController.h: 30828 On Windows, include windows.h, and add a member variable to hold the 30829 handle to the event hook for focus events. Add a declaration for a 30830 function that enables logging of focus events. 30831 30832 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 30833 (AccessibilityController::logFocusEvents): 30834 Stubbed. 30835 30836 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 30837 (AccessibilityController::logFocusEvents): 30838 Stubbed. 30839 30840 * DumpRenderTree/win/AccessibilityControllerWin.cpp: 30841 (AccessibilityController::AccessibilityController): 30842 (AccessibilityController::~AccessibilityController): 30843 If we hooked the focus event, unhook it. 30844 (logFocusEventProc): 30845 When we receive a focus event, get the accessible object for the event, 30846 and log its name to stdout. 30847 (AccessibilityController::logFocusEvents): 30848 Setup the focus event hook to listen for events in the current process. 30849 308502009-08-14 Eric Seidel <eric@webkit.org> 30851 30852 No review. Fix 5-space indent to be 4-spaces. 30853 30854 * Scripts/bugzilla-tool: 30855 308562009-08-14 Laszlo Gombos <laszlo.1.gombos@nokia.com> 30857 30858 Reviewed by Simon Hausmann. 30859 30860 [Qt] Public API to configure the storage path for HTML5 localStorage 30861 https://bugs.webkit.org/show_bug.cgi?id=28036 30862 30863 Turn on LocalStorage support for Qt DumpRenderTree since 30864 LocalStorage is now disabled by defult for QtWebkit. 30865 30866 * DumpRenderTree/qt/DumpRenderTree.cpp: 30867 (WebCore::WebPage::WebPage): 30868 308692009-08-14 Xan Lopez <xlopez@igalia.com> 30870 30871 Reviewed by Jan Alonzo. 30872 30873 Do not unref the main webview, it's owned by its parent 30874 container. Instead destroy the container, which should take care 30875 of everything (not terribly important since we exit right after 30876 that, but still). 30877 30878 * DumpRenderTree/gtk/DumpRenderTree.cpp: 30879 (main): 30880 308812009-08-13 Eric Seidel <eric@webkit.org> 30882 30883 No review, correcting obvious python error seen in the commit queue. 30884 30885 args can be a string or an array. Assuming args is always an array results in 30886 double-spaced text in error logs. 30887 30888 * Scripts/bugzilla-tool: 30889 308902009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 30891 30892 Unreviewed build fix. Include stdio.h for using stdout, stderr, 30893 and fprintf. 30894 30895 * DumpRenderTree/LayoutTestController.cpp: 30896 308972009-08-13 Shinichiro Hamaji <hamaji@chromium.org> 30898 30899 Reviewed by Eric Seidel. 30900 30901 rename make-js-test-wrappers to make-script-test-wrappers 30902 https://bugs.webkit.org/show_bug.cgi?id=28212 30903 30904 * Scripts/make-script-test-wrappers: Renamed from WebKitTools/Scripts/make-js-test-wrappers. 30905 309062009-08-13 Drew Wilson <atwilson@chromium.org> 30907 30908 Unreviewed. 30909 30910 Add myself to list of committers. 30911 30912 * Scripts/modules/committers.py: 30913 309142009-08-13 John Sullivan <sullivan@apple.com> 30915 30916 Unreviewed. 30917 30918 Add myself to list of committers. 30919 30920 * Scripts/modules/committers.py: 30921 309222009-08-13 Eric Seidel <eric@webkit.org> 30923 30924 Correct spelling error in file name. No review. 30925 30926 * Scripts/modules/committers_unittest.py: Renamed from WebKitTools/Scripts/modules/commiters_unittest.py. 30927 * Scripts/run-webkit-unittests: 30928 309292009-08-13 Eric Seidel <eric@webkit.org> 30930 30931 Reviewed by Simon Fraser. 30932 30933 REGRESSION(r47175): error running run-webkit-tests 30934 https://bugs.webkit.org/show_bug.cgi?id=28261 30935 30936 Fix "Use of uninitialized value in concatenation (.) or string at 30937 WebKitTools/Scripts/run-webkit-tests line 191." by setting 30938 $testsPerDumpTool to 1000 by default. 30939 30940 * Scripts/run-webkit-tests: 30941 309422009-08-13 Nate Chapin <japhet@chromium.org> 30943 30944 Unreviewed. 30945 30946 Add myself to list of committers. 30947 30948 * Scripts/modules/committers.py: 30949 309502009-08-13 Brent Fulgham <bfulgham@webkit.org> 30951 30952 Unreviewed. 30953 30954 Add 'Brent Fulgham' to the committers list. 30955 30956 * Scripts/modules/committers.py: 30957 309582009-08-13 Adam Langley <agl@chromium.org> 30959 30960 Review not required. 30961 30962 * Scripts/modules/committers.py: 30963 Adding myself to this list because Eric told me to. 30964 309652009-08-13 Greg Bolsinga <bolsinga@apple.com> 30966 30967 Unreviewed. 30968 30969 Add 'Greg Bolsinga' to the committers list. 30970 30971 * Scripts/modules/committers.py: 30972 309732009-08-13 Adam Roben <aroben@apple.com> 30974 30975 Fix off-by-one result comparisons in media tests on Windows Debug 30976 builds 30977 30978 media/video-played.html seems always to time out in Windows Debug 30979 builds. A race condition between media/video-test.js's "hang" timer and 30980 DumpRenderTree's built-in "watchdog" timer was causing results for 30981 media/video-played.html to be printed twice, causing all future media 30982 tests to be compared to the previous test's results. 30983 30984 The fix is to make the watchdog timer got through the same code path 30985 as calling notifyDone manually, so that the results will only get 30986 printed once. A subsequent patch will remove video-test.js's hang 30987 timer entirely, since it is redundant. 30988 30989 Fixes <http://webkit.org/b/28265>. 30990 30991 Reviewed by Mark Rowe. 30992 30993 * DumpRenderTree/LayoutTestController.cpp: 30994 (LayoutTestController::waitToDumpWatchdogTimerFired): Added. Code came 30995 from Gtk/Mac/Win's watchdog timer handlers, but we now call 30996 notifyDone() instead of dump() so that a subsequent call to 30997 notifyDone() won't print the results out again. 30998 30999 * DumpRenderTree/LayoutTestController.h: Added 31000 waitToDumpWatchdogTimerFired. 31001 31002 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 31003 (waitToDumpWatchdogFired): 31004 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 31005 (waitUntilDoneWatchdogFired): 31006 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 31007 (waitUntilDoneWatchdogFired): 31008 Changed to call waitToDumpWatchdogTimerFired. 31009 310102009-08-13 Eric Carlson <eric.carlson@apple.com> 31011 31012 Unreviewed. 31013 31014 Added 'Eric Carlson' to the committers list. 31015 31016 * Scripts/modules/committers.py: 31017 310182009-08-13 Dirk Schulze <krit@webkit.org> 31019 31020 Unreviewed. 31021 Added 'Dirk Schulze' to the committers list. 31022 31023 * Scripts/modules/committers.py: 31024 310252009-08-13 Adam Roben <aroben@apple.com> 31026 31027 Enable running testapi in run-javascriptcore-tests on Windows 31028 31029 Fixes <http://webkit.org/b/24856> run-javascriptcore-tests should run 31030 testapi on Windows 31031 31032 Reviewed by Mark Rowe. 31033 31034 * Scripts/run-javascriptcore-tests: Allow testapi to run if we're in 31035 the AppleWinWebKit configuration. 31036 310372009-08-13 Adam Roben <aroben@apple.com> 31038 31039 Re-enable testapi in run-javascriptcore-tests on Mac 31040 31041 This seems to have been mistakenly disabled in r47089. 31042 31043 Rubber-stamped by Mark Rowe. 31044 31045 * Scripts/run-javascriptcore-tests: Removed comment markers that were 31046 preventing running testapi. 31047 310482009-08-12 George Staikos <george.staikos@torchmobile.com> 31049 31050 Reviewed by Adam Treat. 31051 31052 Enable WCSS and XHTML-MP flags for build-webkit. 31053 31054 * Scripts/build-webkit: 31055 310562009-08-12 David Kilzer <ddkilzer@apple.com> 31057 31058 run-webkit-tests: document --nthly flag in help message 31059 31060 Reviewed by Simon Fraser. 31061 31062 * Scripts/run-webkit-tests: Added --nthly flag to $usage string. 31063 Also noted that -1|--singly implies --nthly 1. 31064 310652009-08-12 Eric Seidel <eric@webkit.org> 31066 31067 No review, just fixing mismerged ChangeLogs. 31068 310692009-08-12 Eric Seidel <eric@webkit.org> 31070 31071 Reviewed by Mark Rowe. 31072 31073 run-webkit-tests needs a --exit-after-failures=N option 31074 https://bugs.webkit.org/show_bug.cgi?id=28192 31075 31076 Added the option and deployed it to bugzilla-tool. 31077 31078 * Scripts/bugzilla-tool: 31079 * Scripts/run-webkit-tests: 31080 310812009-08-11 Eric Seidel <eric@webkit.org> 31082 31083 Reviewed by Mark Rowe. 31084 31085 bugzilla-tool : various improvements for running the commit-queue 31086 https://bugs.webkit.org/show_bug.cgi?id=28199 31087 31088 Make run_and_throw_if_fail silence STDERR as well as STDIN. 31089 I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the output (per abarth's suggestion). 31090 Change a few "print" statements to "log" so they appear in the output. 31091 Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non-string objects). 31092 Added a little more logging so that --quiet mode is easier to understand. 31093 Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well. 31094 Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc. 31095 Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer. 31096 Made curl call (downloading patch files) quieter. 31097 31098 * Scripts/bugzilla-tool: 31099 * Scripts/modules/bugzilla.py: 31100 * Scripts/modules/scm.py: 31101 311022009-08-12 Peter Kasting <pkasting@google.com> 31103 31104 Reviewed by Darin Adler. 31105 31106 https://bugs.webkit.org/show_bug.cgi?id=27323 31107 Change pattern that strips all trailing whitespace to just remove EOL 31108 chars (\r, \n), to make it clear that varying EOL chars is the primary 31109 problem being solved. 31110 31111 * Scripts/prepare-ChangeLog: 31112 * Scripts/resolve-ChangeLogs: 31113 * Scripts/svn-create-patch: 31114 * Scripts/update-webkit: 31115 311162009-08-12 Kevin Ollivier <kevino@theolliviers.com> 31117 31118 wx waf build fix, add new directories to the build. 31119 31120 * wx/build/settings.py: 31121 311222009-08-11 Adam Roben <aroben@apple.com> 31123 31124 Update DumpRenderTree for IWebUIDelegatePrivate changes 31125 31126 Reviewed by Dave Hyatt. 31127 31128 * DumpRenderTree/win/UIDelegate.h: Updated to match 31129 IWebUIDelegatePrivate. 31130 311312009-08-12 Adam Roben <aroben@apple.com> 31132 31133 Don't try to seek to the end of stdin on Cygwin 31134 31135 Doing so seems to always cause an exception (for unknown reasons). 31136 31137 Fixes <http://webkit.org/b/28159> create-bug throws an exception in 31138 Cygwin 31139 31140 Reviewed by Dave Kilzer. 31141 31142 * Scripts/bugzilla-tool: 31143 (CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors 31144 generated by calling sys.stdin.seek, since these seem to be generated 31145 for no good reason on Cygwin. 31146 311472009-08-12 Adam Roben <aroben@apple.com> 31148 31149 Don't raise an exception when --cc is not passed to create-bug 31150 31151 Fixes <http://webkit.org/b/28158> create-bug throws an exception if 31152 --cc is not specified 31153 31154 Reviewed by Dave Kilzer. 31155 31156 * Scripts/modules/bugzilla.py: 31157 (Bugzilla.create_bug_with_patch): Only set the "cc" field if a CC 31158 string was specified. Otherwise we'll generate an exception about the 31159 "cc" variable not being a string. 31160 311612009-08-11 Eric Seidel <eric@webkit.org> 31162 31163 Reviewed by Adam Barth. 31164 31165 bugzilla-tool : various improvements for running the commit-queue 31166 https://bugs.webkit.org/show_bug.cgi?id=28199 31167 31168 Make run_and_throw_if_fail silence STDERR as well as STDIN. 31169 I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the out 31170 Change a few "print" statements to "log" so they appear in the output. 31171 Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non 31172 Added a little more logging so that --quiet mode is easier to understand. 31173 Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well. 31174 Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc. 31175 Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer. 31176 Made curl call (downloading patch files) quieter. 31177 31178 * Scripts/bugzilla-tool: 31179 * Scripts/modules/bugzilla.py: 31180 * Scripts/modules/scm.py: 31181 311822009-08-11 Eric Seidel <eric@webkit.org> 31183 31184 No review, script regression fix only. 31185 31186 run-webkit-tests --quiet hangs 31187 https://bugs.webkit.org/show_bug.cgi?id=28202 31188 31189 Do a huge dance to get open3 to pipe to /dev/null w/o blocking. 31190 This was what I came up with after discussions in #perl. 31191 31192 * Scripts/run-webkit-tests: 31193 311942009-08-11 John Gregg <johnnyg@google.com> 31195 31196 Reviewed by Maciej Stachowiak. 31197 31198 Switch DumpRenderTree to contain a WebUIDelegate2, which extends 31199 WebUIDelegate, so that the notifications tests will still work. 31200 https://bugs.webkit.org/show_bug.cgi?id=28198 31201 31202 * DumpRenderTree/win/UIDelegate.h: 31203 312042009-08-11 Darin Adler <darin@apple.com> 31205 31206 Try to fix GTK build. 31207 31208 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 31209 (AccessibilityUIElement::stringForRange): Added. 31210 312112009-08-10 Mike Fenton <mike.fenton@torchmobile.com> 31212 31213 Reviewed by Adam Treat. 31214 31215 Add processing for string constants used by the tests to trigger 31216 common actions like up, down, left, right, etc. for the Qt 31217 implementation of DumpRenderTree. 31218 31219 Note this allows fast/forms/textarea-arrow-navigation.html to pass 31220 correctly. 31221 31222 https://bugs.webkit.org/show_bug.cgi?id=28161 31223 31224 * DumpRenderTree/qt/jsobjects.cpp: 31225 (EventSender::keyDown): 31226 312272009-08-11 Chris Fleizach <cfleizach@apple.com> 31228 31229 Reviewed by Darin Adler. 31230 31231 Bug 28200 - ListMarker should be included as part of the text value to parse 31232 https://bugs.webkit.org/show_bug.cgi?id=28200 31233 31234 Add the ability to retrieve a string given a plain NSRange. 31235 31236 * DumpRenderTree/AccessibilityUIElement.cpp: 31237 (stringForRangeCallback): 31238 (AccessibilityUIElement::getJSClass): 31239 * DumpRenderTree/AccessibilityUIElement.h: 31240 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 31241 (AccessibilityUIElement::valueDescription): 31242 (AccessibilityUIElement::stringForRange): 31243 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 31244 (AccessibilityUIElement::stringForRange): 31245 312462009-08-11 Dmitry Titov <dimich@chromium.org> 31247 31248 Reviewed by NOBODY (Speculative fix for the layout test failure). 31249 31250 Fix fast/dom/prototype-inheritance.html 31251 and fast/dom/prototype-inheritance-2.html 31252 broken on Windows by http://trac.webkit.org/changeset/47018 31253 31254 * DumpRenderTree/win/DumpRenderTree.cpp: 31255 (resetDefaultsToConsistentValues): enable app cache in Windows DRT. 31256 312572009-08-11 Eric Seidel <eric@webkit.org> 31258 31259 Reviewed by Adam Barth. 31260 31261 bugzilla-tool: Re-factor shared landing logic into helper class to share more code 31262 https://bugs.webkit.org/show_bug.cgi?id=28193 31263 31264 Added new WebKitLandingScripts class to hold this shared logic. 31265 Also added a view_source_url function to move more webkit-specific urls out of bugzilla-tool core. 31266 31267 * Scripts/bugzilla-tool: 31268 312692009-08-11 Kenneth Rohde Christiansen <kenneth@webkit.org> 31270 31271 Reviewed by Adam Treat. 31272 31273 Fix the current failures on the buildbot. 31274 31275 As Qt hooks up the maybeDump to loadFinished, we need to make 31276 sure that calling dump() will not call maybeDump on loadFinished. 31277 31278 As dump is called my emitting done() which calls dump() and then 31279 setting m_isLoading to false. So in the case m_isLoading is false, 31280 do not dump again. 31281 31282 The current code is confusing, and should be made more clear 31283 in another commit. 31284 31285 * DumpRenderTree/qt/jsobjects.cpp: 31286 (LayoutTestController::maybeDump): 31287 (LayoutTestController::notifyDone): 31288 312892009-08-11 John Gregg <johnnyg@google.com> 31290 31291 Reviewed by Maciej Stachowiak. 31292 31293 Add support for desktop notifications API to DumpRenderTree, 31294 and support for ENABLE_NOTIFICATIONS flag to build-webkit. 31295 31296 * DumpRenderTree/LayoutTestController.cpp: 31297 (grantDesktopNotificationPermissionCallback): 31298 (LayoutTestController::staticFunctions): 31299 (LayoutTestController::grantDesktopNotificationPermission): 31300 (LayoutTestController::checkDesktopNotificationPermission): 31301 * DumpRenderTree/LayoutTestController.h: 31302 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: Added. 31303 (DRTDesktopNotificationPresenter::DRTDesktopNotificationPresenter): 31304 (DRTDesktopNotificationPresenter::QueryInterface): 31305 (DRTDesktopNotificationPresenter::AddRef): 31306 (DRTDesktopNotificationPresenter::Release): 31307 (DRTDesktopNotificationPresenter::showDesktopNotification): 31308 (DRTDesktopNotificationPresenter::cancelDesktopNotification): 31309 (DRTDesktopNotificationPresenter::notificationDestroyed): 31310 (DRTDesktopNotificationPresenter::checkNotificationPermission): 31311 (DRTDesktopNotificationPresenter::requestNotificationPermission): 31312 * DumpRenderTree/win/DRTDesktopNotificationPresenter.h: Added. 31313 * DumpRenderTree/win/DumpRenderTree.vcproj: 31314 * DumpRenderTree/win/UIDelegate.cpp: 31315 (UIDelegate::UIDelegate): 31316 (UIDelegate::desktopNotificationsDelegate): 31317 * DumpRenderTree/win/UIDelegate.h: 31318 * Scripts/build-webkit: 31319 313202009-08-11 Peter Kasting <pkasting@google.com> 31321 31322 Reviewed by Darin Adler. 31323 31324 https://bugs.webkit.org/show_bug.cgi?id=27323 31325 Handle arbitrary line endings when manufacturing patches for additions 31326 with history. 31327 31328 * Scripts/svn-create-patch: 31329 313302009-08-11 Peter Kasting <pkasting@google.com> 31331 31332 Reviewed by Darin Adler. 31333 31334 https://bugs.webkit.org/show_bug.cgi?id=28183 31335 Support VS2008 as well as VS2005 in a few scripts. 31336 31337 * Scripts/pdevenv: Check both $VS80COMNTOOLS and $VS90COMNTOOLS. 31338 * Scripts/webkitdirs.pm: Use $VSINSTALLDIR if available instead of hardcoding the VS2005 dir. 31339 313402009-08-11 Eric Seidel <eric@webkit.org> 31341 31342 Reviewed by Adam Barth. 31343 31344 run-webkit-tests --quiet should not output build-dumprendertree output 31345 https://bugs.webkit.org/show_bug.cgi?id=28189 31346 31347 * Scripts/run-webkit-tests: 31348 313492009-08-11 Eric Seidel <eric@webkit.org> 31350 31351 Reviewed by Darin Adler. 31352 31353 Exception in land-patches 31354 https://bugs.webkit.org/show_bug.cgi?id=27962 31355 31356 Use ("%s" % object) instead of ("" + object). 31357 Added unit tests for logging.py. 31358 31359 * Scripts/modules/logging.py: 31360 * Scripts/modules/logging_unittest.py: Added. 31361 * Scripts/run-webkit-unittests: 31362 313632009-08-11 Dmitry Titov <dimich@chromium.org> 31364 31365 Reviewed by NOBODY (Windows layout tests fix). 31366 31367 Fix for layout tests failures. Need to initialize some preferences early 31368 because WebView on Windows uses them during create time. 31369 31370 * DumpRenderTree/win/DumpRenderTree.cpp: 31371 (main): 31372 313732009-08-11 Dmitry Titov <dimich@chromium.org> 31374 31375 Reviewed by Adam Roben. 31376 31377 Originally implemented by Glenn Wilson <gwilson@chromium.org>. 31378 31379 Added support for overriding default preferences per-test. 31380 See https://bugs.webkit.org/show_bug.cgi?id=20534 31381 31382 * DumpRenderTree/LayoutTestController.cpp: 31383 (overridePreferenceCallback): add wiring for layoutTestController.overridePreference. 31384 (LayoutTestController::staticFunctions): same. 31385 * DumpRenderTree/LayoutTestController.h: same. 31386 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 31387 (LayoutTestController::overridePreference): added empty overridePreference method. 31388 * DumpRenderTree/mac/DumpRenderTree.mm: implemented preference override. 31389 (resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test. 31390 (setDefaultsToConsistentValuesForTesting): new method, sets other details of testing environment, every time DRT starts. 31391 (resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues(). 31392 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 31393 (LayoutTestController::overridePreference): 31394 * DumpRenderTree/win/DumpRenderTree.cpp: 31395 (resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test. 31396 (resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues(). 31397 (createWebViewAndOffscreenWindow): same. 31398 (main): same. 31399 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 31400 (LayoutTestController::overridePreference): 31401 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 31402 (LayoutTestController::overridePreference): 31403 314042009-08-11 Brian Weinstein <bweinstein@apple.com> 31405 31406 Reviewed by Sam Weinig. 31407 31408 Added support for DRT to support arguments for eventSender.mouseDown and eventSender.mouseUp for Windows. 31409 https://bugs.webkit.org/show_bug.cgi?id=28166. 31410 31411 This is a step towards fixing fast/events/mouse-click-events.html on Windows. 31412 31413 * DumpRenderTree/win/EventSender.cpp: 31414 (mouseDownCallback): 31415 (mouseUpCallback): 31416 (replaySavedEvents): 31417 314182009-08-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 31419 31420 Reviewed by Simon Hausmann. 31421 31422 Build the TestNetscapePlugin on Qt/Mac 31423 31424 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 31425 314262009-08-11 Dmitry Titov <dimich@chromium.org> 31427 31428 Reviewed by NOBODY (build fix). 31429 31430 Attempt to fix the Windows test bot. Reverted r47015 caused one of the Windows 31431 bots that runs Layout Tests to save "JS disabled" and "default font 24pt" 31432 preferences permanently. Since these preferences are not initialized explicitly in DRT, 31433 almost all Layout tests are failing. Attempt to fix by explicit 31434 initialization of these into defaults (enabled, 16pt) at the beginning of the DRT. 31435 31436 * DumpRenderTree/win/DumpRenderTree.cpp: 31437 (main): see above. 31438 314392009-08-10 Steve Falkenburg <sfalken@apple.com> 31440 31441 Windows nightly fix. 31442 31443 Reviewed by Ada Chan. 31444 31445 * FindSafari/FindSafari.cpp: 31446 (_tmain): Copy Safari.dll if it exists. 31447 314482009-08-10 David Levin <levin@chromium.org> 31449 31450 Reviewed by David Kilzer. 31451 31452 check-webkit-style doesn't catch braces around single line statements when followed by else. 31453 https://bugs.webkit.org/show_bug.cgi?id=28164 31454 31455 * Scripts/modules/cpp_style.py: Added else to the regex that finds ending }'s when 31456 checking the no braces for "single lines" rule. 31457 * Scripts/modules/cpp_style_unittest.py: Added test case. 31458 314592009-08-10 David Kilzer <ddkilzer@apple.com> 31460 31461 <http://webkit.org/b/28163> bugzilla-tool: scm module should not import bugzilla module 31462 31463 Reviewed by David Levin. 31464 31465 * Scripts/bugzilla-tool: 31466 (parse_bug_id): Added. Moved from CommitMessage.parse_bug_id() 31467 in scm module. 31468 * Scripts/modules/scm.py: Removed import of bugzilla module. 31469 (CommitMessage.parse_bug_id): Deleted. 31470 314712009-08-10 Peter Kasting <pkasting@google.com> 31472 31473 Reviewed by David Kilzer. 31474 31475 https://bugs.webkit.org/show_bug.cgi?id=18599 31476 Work around apparent bug in abs2rel() with symlinked directories. 31477 31478 * Scripts/resolve-ChangeLogs: 31479 314802009-08-10 Dan Bernstein <mitz@apple.com> 31481 31482 Build fix 31483 31484 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 31485 (NPP_New): 31486 314872009-08-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 31488 31489 Reviewed by Simon Hausmann. 31490 31491 Fix a bunch of build warnings in TestNetscapePlugin 31492 31493 * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: 31494 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 31495 314962009-08-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 31497 31498 Reviewed by Adam Roben. 31499 31500 Allow TestNetscapePlugIn to fall back to the Carbon event model 31501 31502 Previously the plugin would fail, even though the Carbon event 31503 model was available. The only way to get the Carbon event model 31504 was to pass the "forcecarbon" argument in the test markup, but no 31505 tests were using this. 31506 31507 Now the plugin uses carbon either if it's forced, or if the Cocoa 31508 event model is not supported. 31509 31510 This helps us run most of the plugin tests on Qt/Mac, which still 31511 does not support the Cocoa event model. 31512 31513 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 31514 (NPP_New): 31515 315162009-08-08 Adam Barth <abarth@webkit.org> 31517 31518 Reviewed by Eric Seidel. 31519 31520 bugzilla-tool needs a --quiet option 31521 https://bugs.webkit.org/show_bug.cgi?id=28060 31522 31523 A first pass at a --quiet option. This doesn't do all the excting 31524 things we might want, but it addresses 80% of the use case. 31525 31526 * Scripts/bugzilla-tool: 31527 315282009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org> 31529 31530 Reviewed by Xan Lopez. 31531 31532 [Gtk] Enable accessibility in Gtk DRT 31533 https://bugs.webkit.org/show_bug.cgi?id=25989 31534 31535 Add Accessibility support to the GTK DRT. 31536 31537 * DumpRenderTree/AccessibilityUIElement.h: 31538 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Added. 31539 (AccessibilityController::AccessibilityController): 31540 (AccessibilityController::~AccessibilityController): 31541 (AccessibilityController::focusedElement): 31542 (AccessibilityController::rootElement): 31543 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Added. 31544 (AccessibilityUIElement::AccessibilityUIElement): 31545 (AccessibilityUIElement::~AccessibilityUIElement): 31546 (AccessibilityUIElement::getLinkedUIElements): 31547 (AccessibilityUIElement::getDocumentLinks): 31548 (AccessibilityUIElement::getChildren): 31549 (AccessibilityUIElement::getChildrenWithRange): 31550 (AccessibilityUIElement::childrenCount): 31551 (AccessibilityUIElement::elementAtPoint): 31552 (AccessibilityUIElement::getChildAtIndex): 31553 (AccessibilityUIElement::allAttributes): 31554 (AccessibilityUIElement::attributesOfLinkedUIElements): 31555 (AccessibilityUIElement::attributesOfDocumentLinks): 31556 (AccessibilityUIElement::titleUIElement): 31557 (AccessibilityUIElement::parentElement): 31558 (AccessibilityUIElement::attributesOfChildren): 31559 (AccessibilityUIElement::parameterizedAttributeNames): 31560 (AccessibilityUIElement::role): 31561 (AccessibilityUIElement::title): 31562 (AccessibilityUIElement::description): 31563 (AccessibilityUIElement::language): 31564 (AccessibilityUIElement::x): 31565 (AccessibilityUIElement::y): 31566 (AccessibilityUIElement::width): 31567 (AccessibilityUIElement::height): 31568 (AccessibilityUIElement::clickPointX): 31569 (AccessibilityUIElement::clickPointY): 31570 (AccessibilityUIElement::intValue): 31571 (AccessibilityUIElement::minValue): 31572 (AccessibilityUIElement::maxValue): 31573 (AccessibilityUIElement::valueDescription): 31574 (AccessibilityUIElement::isEnabled): 31575 (AccessibilityUIElement::insertionPointLineNumber): 31576 (AccessibilityUIElement::isActionSupported): 31577 (AccessibilityUIElement::isRequired): 31578 (AccessibilityUIElement::attributesOfColumnHeaders): 31579 (AccessibilityUIElement::attributesOfRowHeaders): 31580 (AccessibilityUIElement::attributesOfColumns): 31581 (AccessibilityUIElement::attributesOfRows): 31582 (AccessibilityUIElement::attributesOfVisibleCells): 31583 (AccessibilityUIElement::attributesOfHeader): 31584 (AccessibilityUIElement::indexInTable): 31585 (AccessibilityUIElement::rowIndexRange): 31586 (AccessibilityUIElement::columnIndexRange): 31587 (AccessibilityUIElement::lineForIndex): 31588 (AccessibilityUIElement::boundsForRange): 31589 (AccessibilityUIElement::cellForColumnAndRow): 31590 (AccessibilityUIElement::selectedTextRange): 31591 (AccessibilityUIElement::setSelectedTextRange): 31592 (AccessibilityUIElement::attributeValue): 31593 (AccessibilityUIElement::isAttributeSettable): 31594 (AccessibilityUIElement::increment): 31595 (AccessibilityUIElement::decrement): 31596 * DumpRenderTree/gtk/DumpRenderTree.cpp: 31597 (webViewWindowObjectCleared): 31598 (main): 31599 * GNUmakefile.am: 31600 316012009-08-07 Jan Michael Alonzo <jmalonzo@webkit.org> 31602 31603 Unreviewed Gtk build fix. 31604 31605 DRT needs internal WTF symbols so we link to libJavaScriptCore.la 31606 too. Also don't force Gtk to use USE_SYSTEM_MALLOC. 31607 31608 * GNUmakefile.am: 31609 316102009-08-07 Darin Adler <darin@apple.com> 31611 31612 * Scripts/commit-log-editor: Fix unchecked access to environment 31613 variable that may not be there. 31614 316152009-08-07 Mark Rowe <mrowe@apple.com> 31616 31617 Handle the case where only a single test is missing results. 31618 31619 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 31620 316212009-08-07 George Wright <george.wright@torchmobile.com> 31622 31623 Reviewed by Adam Treat 31624 31625 Fix DumpRenderTree for the Qt port to always dump the PNG data unless 31626 the expected and actual hashes match. 31627 31628 https://bugs.webkit.org/show_bug.cgi?id=28077 31629 31630 * DumpRenderTree/qt/DumpRenderTree.cpp: 31631 (WebCore::DumpRenderTree::dump): 31632 316332009-08-07 Pierre d'Herbemont <pdherbemont@apple.com> 31634 31635 Reviewed by Eric Seidel. 31636 31637 commit-log-editor does not produce a git commit log that is git friendly. 31638 https://bugs.webkit.org/show_bug.cgi?id=27754 31639 31640 We make sure we end up with: 31641 - A first paragraph describing the bug. It is eventually prefixed by 31642 "WebKit: <line>" or "WebCore: <line>". This used to be 31643 "WebCore:\n\n<line>". 31644 - The Reviewed By line. 31645 - An eventual Patch By line if author and committer doesn't match. 31646 - The rest of the commit. 31647 31648 * Scripts/commit-log-editor: 31649 316502009-08-07 Adam Barth <abarth@webkit.org> 31651 31652 Unreviewed. (Darin Adler indicated he'd prefer if we landed these 31653 kinds of changes unreviewed, like editing the WebKit Team wiki page.) 31654 31655 Added Pierre d'Herbemont to list of committers. 31656 31657 * Scripts/modules/committers.py: 31658 316592009-08-07 Shinichiro Hamaji <hamaji@chromium.org> 31660 31661 Reviewed by Adele Peterson. 31662 31663 Cannot scroll for box-reflect:right 31664 https://bugs.webkit.org/show_bug.cgi?id=27979 31665 31666 Update m_overflowLeft an m_overflowWidth for reflection just like 31667 m_overflowTop and m_overflowHeight. 31668 31669 * Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflo 31670w-scroll.js 31671 316722009-08-06 Shinichiro Hamaji <hamaji@chromium.org> 31673 31674 Reviewed by Adam Barth. 31675 31676 box-shadow's spread is ignored with <table> 31677 https://bugs.webkit.org/show_bug.cgi?id=28017 31678 31679 Use RenderStyle::getBoxShadowExtent just like RenderBlock. 31680 31681 * Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflow-scroll.js 31682 316832009-08-06 Eric Seidel <eric@webkit.org> 31684 31685 No review, only changing make-js-test-wrappers. 31686 31687 Fix make-js-test-wrappers to ignore a few more js tests 31688 with custom templates. 31689 31690 * Scripts/make-js-test-wrappers: 31691 316922009-08-06 Chris Marrin <cmarrin@apple.com> 31693 31694 Reviewed by David Hyatt. 31695 31696 Added ENABLE_3D_CANVAS flag to build, default to off 31697 31698 * Scripts/build-webkit: 31699 317002009-08-05 Brady Eidson <beidson@apple.com> 31701 31702 Reviewed by Darin Adler. 31703 31704 Win DRT's resource load delegate is missing didReceiveResponse 31705 https://bugs.webkit.org/show_bug.cgi?id=28033 31706 31707 * DumpRenderTree/win/FrameLoadDelegate.cpp: 31708 Added: 31709 (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): 31710 (FrameLoadDelegate::willPerformClientRedirectToURL): 31711 (FrameLoadDelegate::didCancelClientRedirectForFrame): 31712 31713 Minor style cleanup: 31714 (FrameLoadDelegate::didStartProvisionalLoadForFrame): 31715 (FrameLoadDelegate::didReceiveTitle): 31716 (FrameLoadDelegate::didFinishLoadForFrame): 31717 (FrameLoadDelegate::willCloseFrame): 31718 (FrameLoadDelegate::didClearWindowObject): 31719 * DumpRenderTree/win/FrameLoadDelegate.h: 31720 317212009-08-05 Brady Eidson <beidson@apple.com> 31722 31723 Reviewed by Darin Adler. 31724 31725 Win DRT's resource load delegate is missing didReceiveResponse 31726 https://bugs.webkit.org/show_bug.cgi?id=28033 31727 31728 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 31729 (ResourceLoadDelegate::didReceiveResponse): 31730 * DumpRenderTree/win/ResourceLoadDelegate.h: 31731 317322009-08-05 Darin Fisher <darin@chromium.org> 31733 31734 Reviewed by Darin Adler. 31735 31736 Add layoutTestController.dumpWillCacheResponse 31737 https://bugs.webkit.org/show_bug.cgi?id=28010 31738 31739 willCacheResponse is only interesting for embedders of mainline WebKit on Mac. 31740 Splitting off a new dumpWillCacheResponse allows a number of existings tests 31741 to run across platforms. 31742 31743 The test that was specifically verifying willCacheResponse now calls 31744 dumpWillCacheResponse. 31745 31746 * DumpRenderTree/LayoutTestController.cpp: Add dumpWillCacheResponse 31747 (LayoutTestController::LayoutTestController): 31748 (dumpWillCacheResponseCallback): 31749 (LayoutTestController::staticFunctions): 31750 * DumpRenderTree/LayoutTestController.h: 31751 (LayoutTestController::dumpWillCacheResponse): 31752 (LayoutTestController::setDumpWillCacheResponse): 31753 * DumpRenderTree/mac/ResourceLoadDelegate.mm: Inspect dumpWillCacheResponse 31754 instead of dumpResourceLoadCallbacks. 31755 (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]): 31756 317572009-08-05 Jeremy Orlow <jorlow@chromium.org> 31758 31759 Reviewed by Adam Barth. 31760 31761 Add my name to committers.py 31762 https://bugs.webkit.org/show_bug.cgi?id=28013 31763 31764 Add my name to committers.py. 31765 31766 * Scripts/modules/committers.py: 31767 317682009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org> 31769 31770 Reviewed by Simon Hausmann. 31771 31772 A minor refactoring of the Qt DRT to be a bit more similar to 31773 the other DRTs, as well as more understandable. 31774 31775 Splitting up resetJSObjects into a LayoutTestController->reset() 31776 plus a new closeRemainingWindows() method. 31777 31778 Added a resetToConsistentStateBeforeTesting() method to keep 31779 the code in one place, making it easier to verify that we are 31780 doing things properly. 31781 31782 * DumpRenderTree/qt/DumpRenderTree.cpp: 31783 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 31784 (WebCore::DumpRenderTree::open): 31785 (WebCore::DumpRenderTree::closeRemainingWindows): 31786 * DumpRenderTree/qt/DumpRenderTree.h: 31787 317882009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org> 31789 31790 Reviewed by Simon Hausmann. 31791 31792 Make the Qt DRT WorkQueue work similarily to the cross platform 31793 one. This means that all items return true if they started 31794 loading. 31795 31796 This change paves the way for unforking the WorkQueue, if we [Qt] 31797 would like that. 31798 31799 * DumpRenderTree/qt/WorkQueue.cpp: 31800 (WorkQueue::processWork): 31801 * DumpRenderTree/qt/WorkQueue.h: 31802 * DumpRenderTree/qt/WorkQueueItem.h: 31803 * DumpRenderTree/qt/jsobjects.cpp: 31804 (LoadItem::invoke): 31805 (ReloadItem::invoke): 31806 (ScriptItem::invoke): 31807 (BackForwardItem::invoke): 31808 (LayoutTestController::processWork): 31809 (LayoutTestController::maybeDump): 31810 318112009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 31812 31813 Reviewed by Simon Hausmann. 31814 31815 If load of a test fails, don't dump as it will be dumped 31816 in the preceding test, resulting in a invalid incorrect layout. 31817 31818 * DumpRenderTree/qt/jsobjects.cpp: 31819 (LayoutTestController::maybeDump): 31820 318212009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 31822 31823 Reviewed by Simon Hausmann. 31824 31825 Make the Qt DumpRenderTree more similar to the mac one. 31826 31827 Changes include: 31828 1) Reset zoom factor before each test 31829 2) Only dump the backforward list when we got other dump result 31830 3) When we dump the render tree, and got zero result print out: 31831 [mainFrame renderTreeAsExternalRepresentation] 31832 and not: 31833 [frame renderTreeAsExternalRepresentation] 31834 31835 * DumpRenderTree/qt/DumpRenderTree.cpp: 31836 (WebCore::DumpRenderTree::open): 31837 (WebCore::methodNameStringForFailedTest): 31838 (WebCore::DumpRenderTree::dump): 31839 318402009-08-05 chris fleizach <cfleizach@apple.com> 31841 31842 Fix Tiger build breakage. 31843 31844 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 31845 318462009-08-04 Chris Fleizach <cfleizach@apple.com> 31847 31848 Reviewed by Darin Adler. 31849 31850 Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented 31851 https://bugs.webkit.org/show_bug.cgi?id=27994 31852 31853 Expose valueDescription for accessibility. 31854 31855 * DumpRenderTree/AccessibilityUIElement.cpp: 31856 (getValueDescriptionCallback): 31857 (AccessibilityUIElement::getJSClass): 31858 * DumpRenderTree/AccessibilityUIElement.h: 31859 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 31860 (AccessibilityUIElement::valueDescription): 31861 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 31862 (AccessibilityUIElement::valueDescription): 31863 318642009-08-04 Eric Seidel <eric@webkit.org> 31865 31866 Reviewed by Mark Rowe. 31867 31868 REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH 31869 https://bugs.webkit.org/show_bug.cgi?id=28006 31870 31871 Hard-code perl to /usr/bin/perl and swig to /usr/bin/swig 31872 31873 * DumpRenderTree/mac/PerlSupport/Makefile: 31874 318752009-08-04 Adam Barth <abarth@webkit.org> 31876 31877 Reviewed by Darin Adler. 31878 31879 Add pkasting to bugzilla-tool as a committer 31880 https://bugs.webkit.org/show_bug.cgi?id=28002 31881 31882 * Scripts/modules/committers.py: 31883 318842009-08-04 Chris Fleizach <cfleizach@apple.com> 31885 31886 Reviewed by Darin Adler. 31887 31888 Bug 27993 - AXSliders are missing required attributes and actions 31889 https://bugs.webkit.org/show_bug.cgi?id=27993 31890 31891 Add ability to check if any arbitrary action is supported. 31892 31893 * DumpRenderTree/AccessibilityUIElement.cpp: 31894 (isActionSupportedCallback): 31895 (AccessibilityUIElement::getJSClass): 31896 * DumpRenderTree/AccessibilityUIElement.h: 31897 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 31898 (AccessibilityUIElement::isActionSupported): 31899 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 31900 (AccessibilityUIElement::isActionSupported): 31901 319022009-08-04 Adam Barth <abarth@webkit.org> 31903 31904 Reviewed by Eric Seidel. 31905 31906 bugzilla-tool unit tests need a test harness 31907 https://bugs.webkit.org/show_bug.cgi?id=27977 31908 31909 * Scripts/run-webkit-unittests: Added. 31910 319112009-08-04 Mark Rowe <mrowe@apple.com> 31912 31913 Rubber-stamped by Gavin "Gavvy" Barraclough. 31914 31915 Ensure that DumpRenderTreeSupport is regenerated when switching between OS versions 31916 by listing the DumpRenderTree binary as a dependency. Xcode has the smarts to rebuild 31917 DumpRenderTree itself when switching OS versions so this dependency removes the need 31918 for any smarts in the Makefile. 31919 31920 * DumpRenderTree/mac/PerlSupport/Makefile: 31921 319222009-08-04 Eric Seidel <eric@webkit.org> 31923 31924 Reviewed by Adam Barth. 31925 31926 bugzilla-tool needs unit tests 31927 https://bugs.webkit.org/show_bug.cgi?id=26916 31928 31929 Add some basic unit testing for scm.py. 31930 31931 * Scripts/modules/scm.py: 31932 * Scripts/modules/scm_unittest.py: Added. 31933 319342009-08-04 Mike Fenton <mike.fenton@torchmobile.com> 31935 31936 Reviewed by Adam Treat. 31937 31938 Fix --skipped=only mode to honor flags such as --no-http and platform ignored directories by checking 31939 to make sure the Skipped entries are not in the $ignoredDirectories array. Directories commonly included 31940 are (http, media, compositing, wml, wcss). 31941 31942 https://bugs.webkit.org/show_bug.cgi?id=27893 31943 31944 * Scripts/run-webkit-tests: 31945 319462009-08-03 Chris Fleizach <cfleizach@apple.com> 31947 31948 Reviewed by Jon Honeycutt. 31949 31950 Bug 27958 - WAI-ARIA: Implement 'aria-required' attribute. 31951 https://bugs.webkit.org/show_bug.cgi?id=27958 31952 31953 Exposed isRequired to DumpRenderTree for accessibility. 31954 31955 * DumpRenderTree/AccessibilityUIElement.cpp: 31956 (getIsRequiredCallback): 31957 (AccessibilityUIElement::getJSClass): 31958 * DumpRenderTree/AccessibilityUIElement.h: 31959 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 31960 (AccessibilityUIElement::isRequired): 31961 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 31962 (AccessibilityUIElement::isRequired): 31963 319642009-08-04 Adam Barth <abarth@webkit.org> 31965 31966 Reviewed by Eric Seidel. 31967 31968 bugzilla-tool --commit-queue should validate commit-queue setter is a committer 31969 https://bugs.webkit.org/show_bug.cgi?id=27974 31970 31971 With a test! 31972 31973 * Scripts/modules/bugzilla.py: 31974 * Scripts/modules/bugzilla_unittest.py: 31975 319762009-08-04 Eric Seidel <eric@webkit.org> 31977 31978 Reviewed by Adam Barth. 31979 31980 REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs 31981 https://bugs.webkit.org/show_bug.cgi?id=27973 31982 31983 The trailing comma (suppresses newlines) was lost in r46700. 31984 31985 * Scripts/bugzilla-tool: 31986 319872009-08-04 Adam Barth <abarth@webkit.org> 31988 31989 Reviewed by Eric Seidel. 31990 31991 bugzilla-tool has too many fatal errors 31992 https://bugs.webkit.org/show_bug.cgi?id=27969 31993 31994 Replace several fatal errors with ScriptError exceptions. 31995 31996 * Scripts/bugzilla-tool: 31997 * Scripts/modules/bugzilla.py: 31998 * Scripts/modules/scm.py: 31999 320002009-08-04 Eric Seidel <eric@webkit.org> 32001 32002 No review, ChangeLog fix only. 32003 32004 Fix a ChangeLog line-spacing disaster caused by: 32005 https://bugs.webkit.org/show_bug.cgi?id=27973 32006 32007 Still unsure what the fix for bugzilla-tool will be. 32008 320092009-08-04 Adam Barth <abarth@webkit.org> 32010 32011 Reviewed by Eric Seidel. 32012 32013 bugzilla-tool --commit-queue should only land commit-queue+ patches 32014 https://bugs.webkit.org/show_bug.cgi?id=27970 32015 32016 commit-queue mode for bugzilla-tool 32017 https://bugs.webkit.org/show_bug.cgi?id=27918 32018 32019 Make bugzilla tool smart enough to find the commit-queue+ flags and 32020 land those patches. 32021 When we call land-patches with --commit-queue, we should filter the 32022 patches we land to only those that have the commit-queue+ flag set. 32023 That way, when we call bugzilla-tool from a main commit queue process, 32024 we won't land the wrong patches. 32025 32026 * Scripts/bugzilla-tool: 32027 320282009-08-04 Eric Seidel <eric@webkit.org> 32029 32030 Reviewed by Adam Barth. 32031 32032 committer logic should be split out of bugzilla.py into its own module 32033 32034 https://bugs.webkit.org/show_bug.cgi?id=27972 32035 32036 I also added unit tests for the functionality I added. 32037 32038 * Scripts/modules/bugzilla.py: 32039 * Scripts/modules/bugzilla_unittest.py: Added. 32040 * Scripts/modules/commiters_unittest.py: Added. 32041 * Scripts/modules/committers.py: Added. 32042 320432009-08-03 Peter Kasting <pkasting@google.com> 32044 32045 Reviewed by David Kilzer. 32046 32047 https://bugs.webkit.org/show_bug.cgi?id=27323 32048 Handle any kind of line endings in svn-apply and svn-unapply, instead 32049 of assuming LF. 32050 32051 * Scripts/svn-apply: 32052 * Scripts/svn-unapply: 32053 320542009-08-03 Adam Barth <abarth@webkit.org> 32055 32056 Reviewed by Eric Seidel. 32057 32058 bugzilla-tool land-patches needs --queue mode 32059 https://bugs.webkit.org/show_bug.cgi?id=27961 32060 32061 Add a --commit-queue command line option to suppress user interaction. 32062 32063 * Scripts/bugzilla-tool: 32064 * Scripts/modules/scm.py: 32065 320662009-08-03 Mark Rowe <mrowe@apple.com> 32067 32068 Build fix. Add installsrc, installhdrs and install targets. 32069 32070 * DumpRenderTree/mac/PerlSupport/Makefile: 32071 320722009-08-03 Eric Carlson <eric.carlson@apple.com> 32073 32074 Reviewed by Eric Seidel. 32075 32076 HTMLInputElement is not controllable by assistive technologies 32077 https://bugs.webkit.org/show_bug.cgi?id=27941 32078 32079 Accessibility control of a slider required adding increment() and decrement() 32080 methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement. 32081 32082 * DumpRenderTree/AccessibilityUIElement.cpp: 32083 (incrementCallback): New, call UI element increment method. 32084 (decrementCallback): New, call UI element decrement method. 32085 (AccessibilityUIElement::getJSClass): Expose increment and decrement methods. 32086 32087 * DumpRenderTree/AccessibilityUIElement.h: 32088 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 32089 (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper. 32090 (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper. 32091 32092 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 32093 (AccessibilityUIElement::increment): New, do nothing. 32094 (AccessibilityUIElement::decrement): New, do nothing. 32095 320962009-08-02 David D. Kilzer <ddkilzer@webkit.org> 32097 32098 <http://webkit.org/b/27930> bugzilla-tool hates Tor Arne Vestbø 32099 32100 Reviewed by Tor Arne Vestbø. 32101 32102 * Scripts/bugzilla-tool: 32103 (set_reviewer_in_changelog): Made sure reviewer is properly 32104 encoded when calling replace(). 32105 321062009-08-02 Kevin Ollivier <kevino@theolliviers.com> 32107 32108 Reviewed by David Levin. 32109 32110 Script for building the wxBrowser sample app for wx. 32111 https://bugs.webkit.org/show_bug.cgi?id=27619 32112 32113 * wx/browser/wscript: Added. 32114 321152009-08-02 Kevin Ollivier <kevino@theolliviers.com> 32116 32117 Reviewed by Jan Alonzo. 32118 32119 Scripts needed for the waf build. 32120 https://bugs.webkit.org/show_bug.cgi?id=27619 32121 32122 * wx/build: Added. 32123 * wx/build/build_utils.py: Added. 32124 * wx/build/settings.py: Added. 32125 * wx/build/waf_extensions.py: Added. 32126 * wx/build/wxpresets.py: Added. 32127 321282009-08-01 Dan Bernstein <mitz@apple.com> 32129 32130 Reviewed by Darin Adler. 32131 32132 Make pixel test results more consistent across Mac OS X versions 32133 32134 * DumpRenderTree/cg/ImageDiffCG.cpp: 32135 (createDifferenceImage): Avoid color correction when rendering the 32136 images into graphics contexts, so that the actual color values are 32137 compared, regardless of how the images are tagged. 32138 * DumpRenderTree/mac/DumpRenderTree.mm: 32139 (createWebViewAndOffscreenWindow): Set the windowâs color space to the 32140 main screenâs color space, even though the window is off-screen. 32141 321422009-08-01 Mark Rowe <mrowe@apple.com> 32143 32144 Try again to make the Qt build bot happy. 32145 32146 * BuildSlaveSupport/test-result-archive: Create a placeholder file inside the newly-created 32147 directory to prevent 'zip' from failing due to the directory containing no files. 32148 321492009-08-01 Mark Rowe <mrowe@apple.com> 32150 32151 Try and make the Qt build bot happy. 32152 32153 * BuildSlaveSupport/test-result-archive: Handle the case where run-webkit-tests generates 32154 no output files at all and thus does not create the layout-test-results directory. 32155 321562009-08-01 Mark Rowe <mrowe@apple.com> 32157 32158 Move the include of DumpRenderTreeSupport to after DumpRenderTree has been built. 32159 32160 * Scripts/run-webkit-tests: 32161 321622009-08-01 Mark Rowe <mrowe@apple.com> 32163 32164 Reviewed by Sam Weinig and David D. Kilzer. 32165 32166 Fix <https://bugs.webkit.org/show_bug.cgi?id=27923>. 32167 Bug 27923: run-webkit-tests should not invoke "ps" repeatedly on Mac OS X 32168 32169 run-webkit-tests invokes "ps" after each test on Mac OS X to determine whether DumpRenderTree is 32170 in the process of crashing. We can do the same test more efficiently with a simple call to sysctl. 32171 I couldn't find any built-in way of doing this directly from perl, so we do it from a simple C module 32172 instead. This speeds up run-webkit-tests by around 8%. 32173 32174 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 32175 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Added. 32176 (processIsCrashing): 32177 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm: Added. Tiger does not have the SWIG tool 32178 that is used to generate the Perl binding to the C code, so we fall back to the old implementation on Tiger. 32179 * DumpRenderTree/mac/PerlSupport/Makefile: Added. 32180 * Scripts/run-webkit-tests: 32181 321822009-08-01 Mark Rowe <mrowe@apple.com> 32183 32184 Reviewed by David D. Kilzer. 32185 32186 Display the reminder once rather than once per ChangeLog. 32187 32188 * Scripts/prepare-ChangeLog: 32189 321902009-08-01 David Kilzer <ddkilzer@apple.com> 32191 32192 resolve-ChangeLogs: add error checking to git ls-files command on close() 32193 32194 Reviewed by Eric Seidel. 32195 32196 Item 2 of <https://bugs.webkit.org/show_bug.cgi?id=18599#c0>. 32197 32198 * Scripts/resolve-ChangeLogs: Added error checking to close() 32199 after running git ls-files. Added error checking to all 32200 system() calls by checking for a non-zero WEXITSTATUS($?). 32201 Changed "|| die;" expressions to "or die $!;". 32202 322032009-08-01 David Kilzer <ddkilzer@apple.com> 32204 32205 <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths 32206 32207 Reviewed by Eric Seidel. 32208 32209 * Scripts/resolve-ChangeLogs: Used chdirReturningRelativePath() 32210 and determineVCSRoot() to change directories to the root of the 32211 project before running the command and to provide a path for 32212 removeChangeLogArguments() to make sure any ChangeLog arguments 32213 on the command line are still found. 32214 (canonicalRelativePath): Added. Returns a canonical path (e.g., 32215 stripping 'dir/../' from the path) relative to the current 32216 directory. 32217 (removeChangeLogArguments): Added argument which contains a 32218 relative path that must be prepended to any ChangeLog arguments. 32219 Used canonicalRelativePath() and File::Spec->catfile() to 32220 construct a normalized, relative path to each file. 32221 322222009-08-01 David Kilzer <ddkilzer@apple.com> 32223 32224 Implement VCSUtils::chdirReturningRelativePath() 32225 32226 Reviewed by Eric Seidel. 32227 32228 Step 2 to fix: 32229 <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths 32230 32231 * Scripts/VCSUtils.pm: 32232 (VCSUtils::chdirReturningRelativePath): Moved here from 32233 chdirAndGetDifference() in svn-create-patch. 32234 * Scripts/svn-create-patch: Switched to use 32235 chdirReturningRelativePath() instead of chdirAndGetDifference(). 32236 (chdirAndGetDifference): Removed. 32237 322382009-08-01 David Kilzer <ddkilzer@apple.com> 32239 32240 Implement VCSUtils::determineVCSRoot() 32241 32242 Reviewed by Eric Seidel. 32243 32244 Step 1 to fix: 32245 <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths 32246 32247 * Scripts/VCSUtils.pm: Removed reference to webkitdirs module. 32248 (VCSUtils::EXPORT): Added &determineVCSRoot. Realphabetized. 32249 (VCSUtils::determineGitRoot): Added. Based on code in 32250 commit-log-editor. 32251 (VCSUtils::determineVCSRoot): Implemented using 32252 determineGitRoot() and determineSVNRoot(). 32253 * Scripts/commit-log-editor: Replaced use of 32254 topLevelSourceDirectory() with determineVCSRoot(). Resorted 32255 use statements. 32256 (topLevelSourceDirectory): Removed. 32257 322582009-07-31 Daniel Bates <dbates@intudata.com> 32259 32260 Reviewed by Eric Seidel. 32261 32262 https://bugs.webkit.org/show_bug.cgi?id=27757 32263 32264 Resolves Perl redefinition warnings about functions tmpfile and tmpnam which are 32265 defined in both File::Temp and POSIX. 32266 32267 This stops the warnings by preventing the "import" method of File::Temp from being called, 32268 which would otherwise add these functions into the primary namespace. Note, "use POSIX" 32269 will import these functions into the primary namespace anyway. We only need one instance 32270 of these functions in our namespace (or we get redefinition warnings), so lets use the 32271 one's in the POSIX package. 32272 32273 * Scripts/update-webkit-auxiliary-libs: Changed "use File::Temp" to "use File::Temp ()". 32274 * Scripts/update-webkit-support-libs: ditto 32275 322762009-07-31 Laszlo Gombos <laszlo.1.gombos@nokia.com> 32277 32278 Reviewed by Eric Seidel. 32279 32280 Add a top level build option to control datagrid support 32281 https://bugs.webkit.org/show_bug.cgi?id=27915 32282 32283 * Scripts/build-webkit: 32284 322852009-07-31 David Levin <levin@chromium.org> 32286 32287 Reviewed by Adam Treat. 32288 32289 check-webkit-style --git-commit has bugs if you select a commit in the past 32290 https://bugs.webkit.org/show_bug.cgi?id=27908 32291 32292 * Scripts/check-webkit-style: 32293 (main): Made the git-commit command only select the first commit 32294 if a range is given (and print a warning). 32295 * Scripts/modules/scm.py: 32296 (SCM::create_patch_from_local_commit): 32297 (SCM::create_patch_since_local_commit): 32298 (SCM::commit_locally_with_message): 32299 (SCM::discard_local_commits): 32300 Added an error messages in case these aren't overriden. 32301 32302 (Git::create_patch_since_local_commit): 32303 Added this command to allow doing a diff of everything after a given commit. 32304 323052009-07-31 Jan Michael Alonzo <jmalonzo@webkit.org> 32306 32307 Speculative Qt build fix. Not reviewed. 32308 32309 Add LayoutTestController::disableImageLoading() in jsobjects.h. 32310 32311 * DumpRenderTree/qt/jsobjects.h: 32312 323132009-07-31 Brady Eidson <beidson@apple.com> 32314 32315 Reviewed by John Sullivan. 32316 32317 <rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896 32318 Favicons are still loaded when automatic image loading is disabled. 32319 32320 * DumpRenderTree/LayoutTestController.cpp: 32321 (disableImageLoadingCallback): 32322 (LayoutTestController::staticFunctions): 32323 * DumpRenderTree/LayoutTestController.h: 32324 32325 * DumpRenderTree/mac/DumpRenderTree.mm: 32326 (resetWebViewToConsistentStateBeforeTesting): 32327 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 32328 (LayoutTestController::disableImageLoading): 32329 32330 * DumpRenderTree/win/DumpRenderTree.cpp: 32331 (resetWebViewToConsistentStateBeforeTesting): 32332 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 32333 (LayoutTestController::disableImageLoading): 32334 32335 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 32336 (LayoutTestController::disableImageLoading): Stubbed for now. 32337 * DumpRenderTree/qt/jsobjects.cpp: 32338 (LayoutTestController::disableImageLoading): Ditto. 32339 323402009-07-30 Eric Seidel <eric@webkit.org> 32341 32342 Reviewed by David Kilzer. 32343 32344 bugzilla-tool post-commits trunk..head errors out 32345 https://bugs.webkit.org/show_bug.cgi?id=27847 32346 32347 Rename commit_ids_from_range_arguments to commit_ids_from_commitish_arguments 32348 and make it handle the new arguments format proposed in the bug. 32349 32350 * Scripts/bugzilla-tool: 32351 * Scripts/modules/scm.py: 32352 323532009-07-30 Eric Seidel <eric@webkit.org> 32354 32355 Reviewed by David Levin. 32356 32357 clean up build-webkit to use less copy/paste code and remove unneeded SVG warning 32358 https://bugs.webkit.org/show_bug.cgi?id=27857 32359 32360 * Scripts/build-webkit: 32361 323622009-07-31 David Kilzer <ddkilzer@apple.com> 32363 32364 <http://webkit.org/b/27894> bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and python-2.5 32365 32366 Reviewed by Eric Seidel. 32367 32368 * Scripts/modules/bugzilla.py: 32369 (Bugzilla.clear_attachment_review_flag): Specify which 'comment' 32370 form field to use when setting its value. 32371 323722009-07-31 Eric Seidel <eric@webkit.org> 32373 32374 Reviewed by David Kilzer. 32375 32376 bugzilla-tool post-commits obsoletes its own work :( 32377 https://bugs.webkit.org/show_bug.cgi?id=27849 32378 32379 Simple fix. Use .add() instead of .update() 32380 32381 * Scripts/bugzilla-tool: 32382 323832009-07-31 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 32384 32385 Reviewed by Anders Carlsson. 32386 32387 Improve platform-detection in run-webkit-tests 32388 32389 This prevents miss-detection of mac-* over Qt/Mac. 32390 32391 * Scripts/run-webkit-tests: 32392 323932009-07-30 Mark Rowe <mrowe@apple.com> 32394 32395 Reviewed by Cameron Zwarich. 32396 32397 Teach buildbot to detect test cases that are missing results. 32398 32399 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 32400 324012009-07-30 Mark Rowe <mrowe@apple.com> 32402 32403 Things work better when you create the correct directories. 32404 32405 * Scripts/run-webkit-tests: 32406 324072009-07-30 Mark Rowe <mrowe@apple.com> 32408 32409 Include some information about the error when we die. 32410 32411 * Scripts/run-webkit-tests: 32412 324132009-07-30 Mark Rowe <mrowe@apple.com> 32414 32415 Ensure that the path exists before writing results to it. 32416 Hopefully this will make the Windows build bot happy. 32417 32418 * Scripts/run-webkit-tests: 32419 324202009-07-30 Mark Rowe <mrowe@apple.com> 32421 32422 Reviewed by Adam Treat and Jon Honeycutt. 32423 32424 Teach run-webkit-tests to always store the actual results in the results directory for new tests. 32425 This allows us to give a working link to the results from the result summary page, even if we're 32426 not generating new results in to the tree. 32427 32428 * Scripts/run-webkit-tests: 32429 324302009-07-30 Mark Rowe <mrowe@apple.com> 32431 32432 Add a Qt Linux build bot. 32433 32434 * BuildSlaveSupport/build.webkit.org-config/config.json: 32435 324362009-07-30 Jakob Petsovits <jakob.petsovits@torchmobile.com> 32437 32438 Reviewed by Adam Roben. 32439 32440 Add --minimal option to webkit-build. 32441 https://bugs.webkit.org/show_bug.cgi?id=27852 32442 32443 This option disables all optional build features unless 32444 they are explicitly enabled. 32445 32446 * Scripts/build-webkit: 32447 324482009-07-30 Jakub Wieczorek <faw217@gmail.com> 32449 32450 [Qt] Fix build with GCC 4.4. 32451 32452 * DumpRenderTree/qt/ImageDiff.cpp: 32453 324542009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com> 32455 32456 Reviewed by Simon Hausmann. 32457 32458 https://bugs.webkit.org/show_bug.cgi?id=27813 32459 32460 [Qt] Support pixel tests in DumpRenderTree for the Qt port. 32461 32462 * DumpRenderTree/qt/DumpRenderTree.cpp: 32463 (WebCore::DumpRenderTree::DumpRenderTree): 32464 (WebCore::DumpRenderTree::open): 32465 (WebCore::DumpRenderTree::setDumpPixels): 32466 (WebCore::DumpRenderTree::dump): 32467 * DumpRenderTree/qt/DumpRenderTree.h: 32468 * DumpRenderTree/qt/main.cpp: 32469 (main): 32470 324712009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com> 32472 32473 Reviewed by Simon Hausmann. 32474 32475 https://bugs.webkit.org/show_bug.cgi?id=27813 32476 32477 [Qt] Implement ImageDiff. 32478 32479 * DumpRenderTree/qt/ImageDiff.cpp: Added. 32480 * DumpRenderTree/qt/ImageDiff.pro: Added. 32481 324822009-07-30 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 32483 32484 Reviewed by Eric Seidel. 32485 32486 build-webkit: Reorder logic for determining the baseProductDir 32487 32488 https://bugs.webkit.org/show_bug.cgi?id=27699 32489 32490 We now do port-spesific probing for the product dir first, and then 32491 fall back to either the generic WEBKITOUTPUTDIR (which now also works 32492 on Mac), or WebKitBuild. 32493 32494 Then we add the git branch if the git branch build option is enabled. 32495 32496 Finally we massage the product dir based on the port. For example the 32497 Mac port will now always set the SYMROOT and OBJROOT configuration for 32498 XCode. 32499 32500 Note that isAppleWinWebkit() and isCygwin() is not mutually exclusive, 32501 hence the normal if and not elsif in the last two blocks. 32502 32503 * Scripts/webkitdirs.pm: 32504 325052009-07-29 David Kilzer <ddkilzer@apple.com> 32506 32507 <http://webkit.org/b/27082> bugzilla-tool: Add --no-close switch to land-patches 32508 32509 Reviewed by David Levin. 32510 32511 * Scripts/bugzilla-tool: 32512 (LandPatchesFromBugs.__init__): Added --no-close switch. 32513 (LandPatchesFromBugs.land_patches): Don't close the bug if the 32514 --no-close switch was used. Always clear the review+ flag on 32515 every landed patch using the commit_text message when cleared. 32516 This prevents patches from showing up in the commit queue if 32517 reopened and provides consistency with all landed patches. 32518 * Scripts/modules/bugzilla.py: 32519 (Bugzilla.clear_attachment_review_flag): Added. 32520 325212009-07-29 David Kilzer <ddkilzer@apple.com> 32522 32523 <http://webkit.org/b/27815> bugzilla-tool: add -m/--description to post-commits command 32524 32525 Reviewed by Eric Seidel. 32526 32527 * Scripts/bugzilla-tool: 32528 (PostDiffAsPatchToBug.execute): Changed default patch name from 32529 "patch" to "Patch v1". 32530 (PostCommitsAsPatchesToBug.__init__): Added -m/--description 32531 switch. 32532 (PostCommitsAsPatchesToBug.execute): Use description provided by 32533 -m/--description switch first, else fall back to the commit 32534 message. 32535 325362009-07-29 Kenneth Rohde Christiansen <kenneth@webkit.org> 32537 32538 Reviewed by Dave Levin. 32539 32540 Make check-webkit-style support files as arguments. 32541 https://bugs.webkit.org/show_bug.cgi?id=27549 32542 32543 * Scripts/check-webkit-style: 32544 Support files as argument. Change documentation and use basename 32545 on the binary name when used in the documentation. Also do not 32546 die when printing something containing non-ASCII characters. 32547 325482009-08-06 Mike Fenton <mike.fenton@torchmobile.com> 32549 32550 Reviewed by David Levin. 32551 32552 Add validation for pointer and reference declaration as defined by webkit style guidelines to cpp_style.py. 32553 Add unit tests for validation and update existing c style cast test to be run explicitly as c validation. 32554 32555 https://bugs.webkit.org/show_bug.cgi?id=27984 32556 32557 * Scripts/modules/cpp_style.py: 32558 * Scripts/modules/cpp_style_unittest.py: 32559 325602009-07-29 David Kilzer <ddkilzer@apple.com> 32561 32562 <http://webkit.org/b/27119> bugzilla-tool: Add create-bug command 32563 32564 Reviewed by David Levin. 32565 32566 Implement "create-bug" command for bugzilla-tool. 32567 32568 * Scripts/bugzilla-tool: Added CreateBug class. 32569 (CreateBug.__init__): Added. 32570 (CreateBug.create_bug_from_commit): Added. 32571 (CreateBug.create_bug_from_patch): Added. 32572 (CreateBug.prompt_for_bug_title_and_comment): Added. 32573 (CreateBug.execute): Added. 32574 (BugzillaTool.__init__): Added create-bug command. 32575 * Scripts/modules/bugzilla.py: 32576 (Bugzilla.prompt_for_component): Added. 32577 (Bugzilla.check_create_bug_response_returning_bug_id_on_success): Added. 32578 (Bugzilla.create_bug_with_patch): Added. 32579 325802009-07-29 Jan Michael Alonzo <jmalonzo@webkit.org> 32581 32582 Reviewed by Eric Seidel and Xan Lopez. 32583 32584 [Gtk] Enable http/tests/appcache tests 32585 https://bugs.webkit.org/show_bug.cgi?id=27674 32586 32587 Add support for testing http/tests/appcache tests. 32588 32589 * DumpRenderTree/gtk/DumpRenderTree.cpp: 32590 (resetWebViewToConsistentStateBeforeTesting): 32591 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 32592 (LayoutTestController::setAppCacheMaximumSize): 32593 325942009-07-28 Mark Rowe <mrowe@apple.com> 32595 32596 Reviewed by Oliver Hunt. 32597 32598 Prevent nightly builds of WebKit from launching against old Safari versions that we no longer work with. 32599 32600 * WebKitLauncher/main.m: 32601 (checkSafariVersion): Add a minimum required Safari version of 4.0. This matches the requirement on Windows. 32602 (main): If the minimum version requirement is not met, display an alert and bail out. 32603 326042009-07-28 David Levin <levin@chromium.org> 32605 32606 Reviewed by Adam Treat. 32607 32608 cpplint* should be named cpp_style* 32609 https://bugs.webkit.org/show_bug.cgi?id=27752 32610 32611 The files were renamed. A few renames were done: 32612 CppLint -> CppStyle 32613 cpplint -> cpp_style 32614 32615 * Scripts/check-webkit-style: 32616 * Scripts/modules/cpp_style.py: Copied from cpplint.py and 32617 did name fix ups. 32618 * Scripts/modules/cpp_style_unittest.py: Copied from cpplint_unittest.py and 32619 did name fix ups. 32620 * Scripts/modules/cpplint.py: Removed. 32621 * Scripts/modules/cpplint_unittest.py: Removed. 32622 326232009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 32624 32625 Rubber-stamped by Holger Freyther. 32626 32627 Add Steve Falkenburg to bugzilla-tools' reviewers list 32628 32629 * Scripts/modules/bugzilla.py: 32630 326312009-07-28 Zoltan Horvath <hzoltan@inf.u-szeged.hu> 32632 32633 Reviewed by Simon Hausmann. 32634 32635 Implement test result archive support for the Qt port. 32636 32637 * BuildSlaveSupport/test-result-archive: 32638 326392009-07-27 Brady Eidson <beidson@apple.com> 32640 32641 Reviewed by Sam Weinig. 32642 32643 https://bugs.webkit.org/show_bug.cgi?id=27755 32644 Layout tests that dump resource load delegate calls should dump the request method and the response status code. 32645 32646 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 32647 (-[NSURLResponse _drt_descriptionSuitableForTestResult]): 32648 (-[NSURLRequest _drt_descriptionSuitableForTestResult]): 32649 32650 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 32651 (descriptionSuitableForTestResult): 32652 326532009-07-27 Pierre d'Herbemont <pdherbemont@apple.com> 32654 32655 Reviewed by David Levin. 32656 32657 "bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load. 32658 https://bugs.webkit.org/show_bug.cgi?id=27747 32659 32660 modules.bugzilla is not found because not included. 32661 32662 * Scripts/modules/scm.py: Properly import modules.bugzilla. 32663 326642009-07-24 Pierre d'Herbemont <pdherbemont@apple.com> 32665 32666 Reviewed by David Kilzer. 32667 32668 commit-log-editor should allow git commit --amend to regenerate the commit log based on the modifed ChangeLog 32669 https://bugs.webkit.org/show_bug.cgi?id=27664 32670 32671 * Scripts/commit-log-editor: Add --regenerate-log option. 32672 The user is asked if he wants to suppress previous ChangeLog and regenerate it, 32673 if this option is enabled. 32674 326752009-07-27 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu> 32676 32677 Reviewed by Simon Hausmann. 32678 32679 Generating remote links causes a lot of unnecessary spew on Qt build bot too 32680 32681 * Scripts/run-webkit-tests: 32682 326832009-07-25 Kwang Yul Seo <skyul@company100.net> 32684 32685 Reviewed by Darin Adler. 32686 32687 Windows build break due to warning C4819 32688 https://bugs.webkit.org/show_bug.cgi?id=27416 32689 32690 Disable C4819 warning to fix build. 32691 32692 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 32693 326942009-07-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com> 32695 32696 Not reviewed. Add Kevin McCullough as reviewer in bugzilla.py 32697 32698 * Scripts/modules/bugzilla.py: 32699 327002009-07-24 Eli Fidler <eli.fidler@torchmobile.com> 32701 32702 Reviewed by Adam Treat. 32703 32704 Improve git workflow by populating commit messages with ChangeLog entries. 32705 https://bugs.webkit.org/show_bug.cgi?id=27605 32706 32707 If the user doesn't manually modify the ChangeLog files, use 32708 prepare-ChangeLog to populate the git commit message. This behaviour 32709 can be disabled by the 'webkitGenerateCommitMessage' git configuration option. 32710 32711 * Scripts/commit-log-editor: 32712 327132009-07-24 David Levin <levin@chromium.org> 32714 32715 Reviewed by Adam Treat. 32716 32717 cpplint crash when there is a duplicate header followed by another header. 32718 https://bugs.webkit.org/show_bug.cgi?id=27625 32719 32720 * Scripts/modules/cpplint.py: Ensure that include_state.header_types is updated even 32721 there is a duplicate header, which resulted in some code rearrangement. Also, 32722 changed some if's in this function to return early. This avoids having nearly the 32723 whole function content being indented. 32724 * Scripts/modules/cpplint_unittest.py: Added a test which would have exposed the crash. 32725 327262009-07-24 Jakob Petsovits <jakob.petsovits@torchmobile.com> 32727 32728 Reviewed by Adam Treat. 32729 32730 Filetype support changes for cpplint and check_webkit_style 32731 https://bugs.webkit.org/show_bug.cgi?id=27653 32732 32733 Introduce .c support for check_webkit_style, and remove support for 32734 .cc files in favor of .cpp. 32735 32736 * Scripts/check-webkit-style: 32737 * Scripts/modules/cpplint.py: 32738 * Scripts/modules/cpplint_unittest.py: 32739 327402009-07-24 Eli Fidler <eli.fidler@torchmobile.com> 32741 32742 Reviewed by David Levin. 32743 32744 Improve git workflow by populating commit messages with ChangeLog entries. 32745 https://bugs.webkit.org/show_bug.cgi?id=27605 32746 32747 add --[no-]write prepare-ChangeLog options to bash completion 32748 32749 * Scripts/webkit-tools-completion.sh: 32750 327512009-07-24 Andrei Popescu <andreip@google.com> 32752 32753 Reviewed by Anders Carlsson. 32754 32755 ApplicationCache should have size limit 32756 https://bugs.webkit.org/show_bug.cgi?id=22700 32757 32758 Adds a new method on the LayoutTestController that 32759 allows a JS unit test to configure the maximum size 32760 of the Application Cache. 32761 32762 * DumpRenderTree/LayoutTestController.cpp: 32763 (setAppCacheMaximumSizeCallback): 32764 (LayoutTestController::staticFunctions): 32765 * DumpRenderTree/LayoutTestController.h: 32766 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 32767 (LayoutTestController::setAppCacheMaximumSize): 32768 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 32769 (LayoutTestController::setAppCacheMaximumSize): 32770 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 32771 (LayoutTestController::setAppCacheMaximumSize): 32772 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 32773 (LayoutTestController::setAppCacheMaximumSize): 32774 327752009-07-24 Adam Barth <abarth@webkit.org> 32776 32777 Rubber stamped by Eric Seidel. 32778 32779 Added andersca to list of reviewers. 32780 32781 * Scripts/modules/bugzilla.py: 32782 327832009-07-24 Mark Rowe <mrowe@apple.com> 32784 32785 Reviewed by Xan Lopez. 32786 32787 Fix dozens of "Deallocation of a pointer not malloced" messages seen while running 32788 layout tests on the build bot. 32789 32790 Memory allocated via FastMalloc was being deleted via the system memory allocator 32791 due to an inconsistent including of FastMalloc.h. We address this by including it 32792 from config.h and including config.h from every implementation file, as in our other 32793 projects. 32794 32795 * DumpRenderTree/ForwardingHeaders/wtf/FastMalloc.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h. 32796 * DumpRenderTree/config.h: 32797 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 32798 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 32799 * DumpRenderTree/mac/AppleScriptController.m: 32800 * DumpRenderTree/mac/CheckedMalloc.cpp: 32801 * DumpRenderTree/mac/DumpRenderTree.mm: 32802 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: 32803 * DumpRenderTree/mac/DumpRenderTreePasteboard.m: 32804 * DumpRenderTree/mac/DumpRenderTreeWindow.mm: 32805 * DumpRenderTree/mac/EditingDelegate.mm: 32806 * DumpRenderTree/mac/EventSendingController.mm: 32807 * DumpRenderTree/mac/FrameLoadDelegate.mm: 32808 * DumpRenderTree/mac/GCControllerMac.mm: 32809 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 32810 * DumpRenderTree/mac/NavigationController.m: 32811 * DumpRenderTree/mac/ObjCController.m: 32812 * DumpRenderTree/mac/ObjCPlugin.m: 32813 * DumpRenderTree/mac/ObjCPluginFunction.m: 32814 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 32815 * DumpRenderTree/mac/PlainTextController.mm: 32816 * DumpRenderTree/mac/PolicyDelegate.mm: 32817 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 32818 * DumpRenderTree/mac/TextInputController.m: 32819 * DumpRenderTree/mac/UIDelegate.mm: 32820 * DumpRenderTree/mac/WorkQueueItemMac.mm: 32821 328222009-07-24 Mark Rowe <mrowe@apple.com> 32823 32824 Reviewed by Simon Hausmann. 32825 32826 Add a command line option to run-javascriptcore-tests to explicitly opt out of attempting to rebuild JavaScriptCore. 32827 This is primarily useful to speed up the build bots where one machine builds JavaScriptCore and a second runs the tests, 32828 leading to situations where the build system unnecessarily feels that the need to recompile. 32829 32830 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 32831 * Scripts/run-javascriptcore-tests: 32832 328332009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org> 32834 32835 Reviewed by Eric Seidel. 32836 32837 [Gtk] Add implementation of GCController for DRT 32838 https://bugs.webkit.org/show_bug.cgi?id=27636 32839 32840 * DumpRenderTree/gtk/DumpRenderTree.cpp: 32841 (webViewWindowObjectCleared): 32842 (main): 32843 * DumpRenderTree/gtk/GCControllerGtk.cpp: 32844 (GCController::collect): 32845 (GCController::collectOnAlternateThread): 32846 (GCController::getJSObjectCount): 32847 328482009-07-23 Mark Rowe <mrowe@apple.com> 32849 32850 Update build.webkit.org config for new machine. 32851 32852 * BuildSlaveSupport/build.webkit.org-config/config.json: 32853 328542009-07-23 Brady Eidson <beidson@apple.com> 32855 32856 Remove accidentally checked in code. 32857 32858 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 32859 (waitUntilDoneWatchdogFired): 32860 (LayoutTestController::setWaitToDump): 32861 328622009-07-23 Brady Eidson <beidson@apple.com> 32863 32864 Reviewed by Geoff Garen. 32865 32866 WebCore has a few places that don't gracefully handle a null request returned from willSendRequest. 32867 https://bugs.webkit.org/show_bug.cgi?id=27595 32868 32869 Add the ability to tell the LayoutTestController to return a null request for willSendRequest 32870 redirect callbacks. 32871 32872 * DumpRenderTree/LayoutTestController.cpp: 32873 (LayoutTestController::LayoutTestController): 32874 (setWillSendRequestReturnsNullOnRedirectCallback): 32875 (LayoutTestController::staticFunctions): 32876 * DumpRenderTree/LayoutTestController.h: 32877 (LayoutTestController::willSendRequestReturnsNullOnRedirect): 32878 (LayoutTestController::setWillSendRequestReturnsNullOnRedirect): 32879 32880 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 32881 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): 32882 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 32883 (ResourceLoadDelegate::willSendRequest): 32884 328852009-07-23 Mark Rowe <mrowe@apple.com> 32886 32887 Reviewed Oliver Hunt. 32888 32889 Fix DumpRenderTree to not fail an assertion on launch on a new machine. 32890 32891 * DumpRenderTree/mac/DumpRenderTree.mm: 32892 (setDefaultsToConsistentValuesForTesting): Disable the XSS auditor. It being enabled 32893 breaks all of the JavaScript tests within testStringByEvaluatingJavaScriptFromString, 32894 which causes us to exit due to an assertion failure. It's not clear why the XSS auditor 32895 decides to interfere with these tests. 32896 328972009-07-23 Mark Rowe <mrowe@apple.com> 32898 32899 Reviewed by Oliver Hunt. 32900 32901 Update default state of the XSS auditor in GTK DumpRenderTree to match Mac and Windows 32902 in hopes of fixing some layout test failures seen on the build bot. 32903 32904 * DumpRenderTree/gtk/DumpRenderTree.cpp: 32905 (resetWebViewToConsistentStateBeforeTesting): 32906 329072009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com> 32908 32909 Reviewed by Adam Treat. 32910 32911 Fix false positives for switch statement indentation check in cpplint. 32912 https://bugs.webkit.org/show_bug.cgi?id=27615 32913 32914 Makes one-line case statements (e.g. "case foo: bar();") work. 32915 Also a few general improvements to the robustness and readability of 32916 the check, and more test cases. 32917 32918 * Scripts/modules/cpplint.py: 32919 * Scripts/modules/cpplint_unittest.py: 32920 329212009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com> 32922 32923 Reviewed by Adam Treat. 32924 32925 Add check for line-breaking rule #3 to cpplint. 32926 https://bugs.webkit.org/show_bug.cgi?id=27610 32927 32928 "An else if statement should be written as an if statement when 32929 the prior if concludes with a return statement." 32930 32931 Implemented by a multi-line (kind of back-tracking) algorithm. 32932 Comes with loads of unit tests. Fixes the check for label indentation 32933 to be not so overzealous, as it didn't allow for completely unindented 32934 goto labels (at the very start of a line). 32935 32936 * Scripts/modules/cpplint.py: 32937 * Scripts/modules/cpplint_unittest.py: 32938 329392009-07-23 Eli Fidler <eli.fidler@torchmobile.com> 32940 32941 Reviewed by Adam Treat. 32942 32943 Improve git workflow by populating commit messages with ChangeLog entries. 32944 https://bugs.webkit.org/show_bug.cgi?id=27605 32945 32946 add --[no-]write option to optionally output new ChangeLog entries to 32947 stdout instead of modifying ChangeLog files 32948 32949 fix Torch Mobile copyright 32950 32951 * Scripts/prepare-ChangeLog: 32952 329532009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com> 32954 32955 Reviewed by Adam Treat. 32956 32957 Enable cpplint for .c files. 32958 https://bugs.webkit.org/show_bug.cgi?id=27604 32959 32960 Also make sure that the check for NULL does not apply to .c files. 32961 32962 * Scripts/modules/cpplint.py: 32963 * Scripts/modules/cpplint_unittest.py: 32964 329652009-07-22 Steve Falkenburg <sfalken@apple.com> 32966 32967 Checkpoint new Windows nightly launcher. 32968 32969 Reviewed by Mark Rowe. 32970 32971 * WebKitLauncherWin: Added. 32972 * WebKitLauncherWin/Resource.h: Added. 32973 * WebKitLauncherWin/WebKitLauncherWin.cpp: Added. 32974 (getStringValue): Retrieve a string registry value. 32975 (applePathFromRegistry): Get an Apple-related path out of the registry. 32976 (copyEnvironmentVariable): Copy an environment variable. 32977 (safariInstallDir): Helper function to get the install directory for Safari. 32978 (safariBrowserExe): Helper function to get the full path of the Safari executable. 32979 (_tWinMain): Locate Safari and launch it after setting up an environment variable. 32980 * WebKitLauncherWin/WebKitLauncherWin.h: Added. 32981 * WebKitLauncherWin/WebKitLauncherWin.rc: Added. 32982 * WebKitLauncherWin/WebKitLauncherWin.vcproj: Added. 32983 * WebKitLauncherWin/webkit.ico: Added. 32984 329852009-07-22 David Levin <levin@chromium.org> 32986 32987 Reviewed by Adam Treat. 32988 32989 run-webkit-lint should be named check-webkit-style 32990 https://bugs.webkit.org/show_bug.cgi?id=27568 32991 32992 This name better reflects the fact that it is about checking the style of files. 32993 32994 * Scripts/check-webkit-style: Renamed from WebKitTools/Scripts/run-webkit-lint. 32995 329962009-07-22 Takeshi Yoshino <tyoshino@google.com> 32997 32998 Reviewed by Darin Adler. 32999 33000 VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp 33001 https://bugs.webkit.org/show_bug.cgi?id=26375 33002 33003 Make it able to use hexadecimal escape sequences in .*UI_STRING(_KEY)? macros. Now, 33004 the extract-localizable-strings script unescapes hexadecimal escape sequences in string literals 33005 in the macros before writing out them into the file to update. 33006 33007 By this fix, we can eliminate raw UTF-8 strings in source code while using raw UTF-16 big endian 33008 strings in the Localizable.strings file. 33009 33010 Bonus: There's no longer extract-webkit-localizable-strings script. Fix usage message to guide 33011 users to update-webkit-localizable-strings. 33012 33013 * Scripts/extract-localizable-strings: 33014 330152009-07-22 Shinichiro Hamaji <hamaji@google.com> 33016 33017 Reviewed by David Levin. 33018 33019 Tiny typo fixes for cpplint.py 33020 https://bugs.webkit.org/show_bug.cgi?id=27530 33021 33022 * Scripts/modules/cpplint.py: 33023 330242009-07-22 Shinichiro Hamaji <hamaji@chromium.org> 33025 33026 Reviewed by David Levin. 33027 33028 run-webkit-lint checks code which are not changed 33029 https://bugs.webkit.org/show_bug.cgi?id=27529 33030 33031 Add check if the line is newly added. 33032 33033 * Scripts/run-webkit-lint: 33034 330352009-07-22 Shinichiro Hamaji <hamaji@chromium.org> 33036 33037 Reviewed by David Levin. 33038 33039 run-webkit-lint should have --git-commit option 33040 https://bugs.webkit.org/show_bug.cgi?id=27528 33041 33042 * Scripts/modules/cpplint.py: 33043 * Scripts/run-webkit-lint: 33044 330452009-07-22 Peter Kasting <pkasting@google.com> 33046 33047 Reviewed by David Kilzer. 33048 33049 https://bugs.webkit.org/show_bug.cgi?id=27323 33050 Factor svn-create-patch's "determineSvnRoot()" into a function in 33051 VCSUtils.pm so commit-log-editor can use it too. 33052 33053 * Scripts/VCSUtils.pm: Add determineSVNRoot(). 33054 * Scripts/commit-log-editor: Use determineSVNRoot() instead of old 33055 code (which didn't work as well). 33056 * Scripts/svn-create-patch: Remove determineSvnRoot() (moved). 33057 330582009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com> 33059 33060 Reviewed by Adam Treat. 33061 33062 Fix false positives in namespace indentation checks. 33063 https://bugs.webkit.org/show_bug.cgi?id=27567 33064 33065 The regular expression detecting goto labels (in order 33066 to skip those) was too permissive, which caused other 33067 code like "Foo::Bar()" to be treated as a label too, 33068 thereby not stopping the processing loop as expected. 33069 33070 Now comes with a stricter regexp, and more demanding 33071 test cases to check for these issues. 33072 33073 * Scripts/modules/cpplint.py: 33074 * Scripts/modules/cpplint_unittest.py: 33075 330762009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com> 33077 33078 Reviewed by Adam Treat. 33079 33080 Fix cpplint generating false positives for 33081 "primary" includes in headers. 33082 https://bugs.webkit.org/show_bug.cgi?id=27553 33083 33084 Doing so by only flagging includes in header files 33085 as primary when the include filename exactly matches 33086 the header filename. 33087 33088 * Scripts/modules/cpplint.py: 33089 * Scripts/modules/cpplint_unittest.py: 33090 330912009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com> 33092 33093 Reviewed by Adam Treat. 33094 33095 cpplint generates false positives for primary includes 33096 https://bugs.webkit.org/show_bug.cgi?id=27544 33097 33098 Fix false positives for instances when cpplint would 33099 normally classify multiple includes as primary: After 33100 the first primary include, classify subsequent ones as 33101 "other" includes even if they look like primary ones. 33102 33103 * Scripts/modules/cpplint.py: 33104 * Scripts/modules/cpplint_unittest.py: 33105 331062009-07-22 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu> 33107 33108 Reviewed by Simon Hausmann. 33109 33110 Pass XAUTHORITY environment variable to $dumpTool as well. 33111 33112 * Scripts/run-webkit-tests: 33113 331142009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com> 33115 33116 Reviewed by Adam Treat. 33117 33118 Add check for correct wtf includes to cpplint. 33119 https://bugs.webkit.org/show_bug.cgi?id=27524 33120 33121 * Scripts/modules/cpplint.py: 33122 * Scripts/modules/cpplint_unittest.py: 33123 331242009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com> 33125 33126 Reviewed by David Levin. 33127 33128 Add checks for multi-line boolean operator placement. 33129 https://bugs.webkit.org/show_bug.cgi?id=27496 33130 33131 * Scripts/modules/cpplint.py: 33132 * Scripts/modules/cpplint_unittest.py: 33133 331342009-07-21 Adam Treat <adam.treat@torchmobile.com> 33135 33136 Reviewed by David Levin. 33137 33138 We can't match implementation file and primary header exactly 33139 since we have so many files in WebKit where the port suffix 33140 is appended to the filename. 33141 33142 Example: FooQt.cpp and the primary header is Foo.h. 33143 33144 * Scripts/modules/cpplint.py: 33145 331462009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com> 33147 33148 Reviewed by David Levin. 33149 33150 Add checks for switch statement indentation to cpplint. 33151 https://bugs.webkit.org/show_bug.cgi?id=27508 33152 33153 * Scripts/modules/cpplint.py: 33154 * Scripts/modules/cpplint_unittest.py: 33155 331562009-07-21 Kenneth Rohde Christiansen <kenneth@webkit.org> 33157 33158 Reviewed by Adam Treat. 33159 33160 Feature request: cpplint should check for braces - rule 2 33161 https://bugs.webkit.org/show_bug.cgi?id=27497 33162 33163 Add the requested feature: Make sure { is on the same line 33164 as the foreach "keyword". 33165 33166 * Scripts/modules/cpplint.py: 33167 * Scripts/modules/cpplint_unittest.py: 33168 331692009-07-20 Jakob Petsovits <jakob.petsovits@torchmobile.com> 33170 33171 Reviewed by David Levin. 33172 33173 Add checks for namespace indentation to cpplint. 33174 https://bugs.webkit.org/show_bug.cgi?id=27461 33175 33176 * Scripts/modules/cpplint.py: 33177 * Scripts/modules/cpplint_unittest.py: 33178 331792009-07-20 Adam Treat <adam.treat@torchmobile.com> 33180 33181 Reviewed by David Levin. 33182 33183 Add cpplint check for proper include order 33184 https://bugs.webkit.org/show_bug.cgi?id=27462 33185 33186 Add a new check to cpplint to flag cases where the include section of a file 33187 does not match the mandated include order and style of the Webkit coding style 33188 guidelines. 33189 33190 Add associated tests. 33191 33192 * Scripts/modules/cpplint.py: 33193 * Scripts/modules/cpplint_unittest.py: 33194 331952009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 33196 33197 Reviewed by David Levin. 33198 33199 Support lint for patches 33200 https://bugs.webkit.org/show_bug.cgi?id=27291 33201 33202 Add run-webkit-lint script, which lints recent changes in local 33203 repository. Also, modified cpplint.py so that we don't need to 33204 specify verbose level for process_file(). 33205 33206 * Scripts/modules/cpplint.py: 33207 * Scripts/run-webkit-lint: Added. 33208 332092009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 33210 33211 Reviewed by David Levin. 33212 33213 diff_parser should accept lines without trailing \n 33214 https://bugs.webkit.org/show_bug.cgi?id=27483 33215 33216 Normalize the input lines by removing a trailing newline. 33217 Also, add a case for unittest for newly added files. 33218 33219 * Scripts/modules/diff_parser.py: 33220 * Scripts/modules/diff_parser_unittest.py: 33221 332222009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 33223 33224 Reviewed by David Levin. 33225 33226 cpplint.py's process_file() should accept customized error function 33227 https://bugs.webkit.org/show_bug.cgi?id=27487 33228 33229 * Scripts/modules/cpplint.py: 33230 332312009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 33232 33233 Reviewed by David Levin. 33234 33235 cpplint.py should have an interface to get global error count 33236 https://bugs.webkit.org/show_bug.cgi?id=27486 33237 33238 * Scripts/modules/cpplint.py: 33239 * Scripts/modules/cpplint_unittest.py: 33240 332412009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 33242 33243 Reviewed by David Levin. 33244 33245 cpplint's parse_argument should not exit even if no files are specified 33246 https://bugs.webkit.org/show_bug.cgi?id=27489 33247 33248 * Scripts/modules/cpplint.py: 33249 * Scripts/modules/cpplint_unittest.py: 33250 332512009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 33252 33253 Reviewed by David Levin. 33254 33255 diff_parser: s/add_deleted_line/add_old_line/g 33256 https://bugs.webkit.org/show_bug.cgi?id=27484 33257 33258 * Scripts/modules/diff_parser.py: 33259 332602009-07-21 Roland Steiner <rolandsteiner@google.com> 33261 33262 Reviewed by David Levin. 33263 33264 Add ENABLE_RUBY to list of build options 33265 https://bugs.webkit.org/show_bug.cgi?id=27324 33266 33267 * Scripts/build-webkit: Added flag ENABLE_RUBY. 33268 332692009-07-20 Mark Rowe <mrowe@apple.com> 33270 33271 Reviewed by David D. Kilzer. 33272 33273 Fix <https://bugs.webkit.org/show_bug.cgi?id=27482>. 33274 Bug 27482: svn-apply cannot apply patch generated by Windows SVN 33275 33276 A regexp in svn-apply was treating everything prior to a \n as part of the 33277 file name. The native Windows SVN client uses \r\n for line endings which 33278 meant that the \r was being included in the file name. This defeated the 33279 special-case logic for ChangeLogs to apply them with an increased fuzz factor, 33280 meaning that the ChangeLog portions of such patches would fail to apply. 33281 33282 Also updated two other regexps that look like they would hit similar problems 33283 with line-endings so that they will correctly handle patches from Windows SVN. 33284 33285 * Scripts/svn-apply: 33286 332872009-07-20 Peter Kasting <pkasting@google.com> 33288 33289 Reviewed by Mark Rowe. 33290 33291 https://bugs.webkit.org/show_bug.cgi?id=27468 33292 Back out r46060, which caused problems for some Apple developers. 33293 33294 * DumpRenderTree/win/DumpRenderTree.vcproj: 33295 * DumpRenderTree/win/ImageDiff.vcproj: 33296 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 33297 332982009-07-20 Peter Kasting <pkasting@google.com> 33299 33300 Reviewed by Darin Adler. 33301 33302 https://bugs.webkit.org/show_bug.cgi?id=27323 33303 Use shorter, more correct code for determining the current directory, 33304 which works better with symbolic links on some systems. Also switch 33305 from checking repository root to checking UUID, to match scm.py. 33306 33307 * Scripts/svn-create-patch: 33308 333092009-07-20 Mark Rowe <mrowe@apple.com> 33310 33311 Rubber-stamped by Dan Bernstein. 33312 33313 Work around <rdar://problem/7075373> by ensuring that the URL is absolute before handing it off to CoreText. 33314 33315 * DumpRenderTree/mac/DumpRenderTree.mm: 33316 (activateFonts): 33317 333182009-07-20 David Levin <levin@chromium.org> 33319 33320 Reviewed by Adam Treat. 33321 33322 Enable filename completion for run-webkit-test (added "-o default"). 33323 33324 * Scripts/webkit-tools-completion.sh: 33325 333262009-07-20 Simon Hausmann <simon.hausmann@nokia.com> 33327 33328 No review, just adding Gavin Barraclough as reviewer. 33329 33330 * Scripts/modules/bugzilla.py: 33331 333322009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org> 33333 33334 Reviewed by David Levin. 33335 33336 Add support for Qt's foreach to cpplint 33337 https://bugs.webkit.org/show_bug.cgi?id=27386 33338 33339 * Scripts/modules/cpplint.py: 33340 * Scripts/modules/cpplint_unittest.py: 33341 333422009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org> 33343 33344 https://bugs.webkit.org/show_bug.cgi?id=27145 33345 [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615 33346 33347 Reviewed by Gustavo Noronha. 33348 33349 Normalize file URLs. 33350 33351 * DumpRenderTree/gtk/DumpRenderTree.cpp: 33352 (dumpHistoryItem): 33353 333542009-07-17 Peter Kasting <pkasting@google.com> 33355 33356 Reviewed by David Kilzer. 33357 33358 https://bugs.webkit.org/show_bug.cgi?id=27323 33359 Further improve non-Cygwin SVN support. 33360 33361 * Scripts/prepare-ChangeLog: Harmless change to be consistent with other 33362 places that consume whitespace at the end of svn output. 33363 * Scripts/resolve-ChangeLogs: Add support for SVN 1.6. Slightly 33364 optimize svn info parsing based on technique in svn-create-patch. 33365 Normalize paths and consume whitespace in the same way as 33366 prepare-ChangeLog, for Windows systems with a non-Cygwin SVN. Force 33367 diff and patch to run in binary mode so that they won't 33368 "intelligently" screw up line endings. 33369 333702009-07-18 Simon Fraser <simon.fraser@apple.com> 33371 33372 Fix Tiger DRT build. 33373 33374 * DumpRenderTree/mac/DumpRenderTree.mm: 33375 (createWebViewAndOffscreenWindow): 33376 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 33377 333782009-07-17 Simon Fraser <simon.fraser@apple.com> 33379 33380 Reviewed by Dan Bernstein. 33381 33382 DRT doesn't reliably snapshot composited layers 33383 https://bugs.webkit.org/show_bug.cgi?id=27399 33384 33385 If we're doing an "onscreen" pixel capture, it means that we're snapshotting a view 33386 with composited content. In that case we need to force the view to display so that 33387 the composited layers are rendered to the screen. 33388 33389 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 33390 (createBitmapContextFromWebView): 33391 333922009-07-17 Adam Barth <abarth@webkit.org> 33393 33394 Reviewed by David Levin. 33395 33396 bugzilla-tool does not understand nested SVN repos 33397 https://bugs.webkit.org/show_bug.cgi?id=27404 33398 33399 Determine the root of the working copy by looking at SVN's UUIDs. 33400 33401 * Scripts/modules/scm.py: 33402 334032009-07-17 David Levin <levin@chromium.org> 33404 33405 Reviewed by Mark Rowe. 33406 33407 webkit-tools-completion.sh has two typos and sorting issues. 33408 https://bugs.webkit.org/show_bug.cgi?id=27401 33409 33410 * Scripts/webkit-tools-completion.sh: Fix two typos "--dif" and "-clean". 33411 Also, sort all lists including items in the case statement and flags for 33412 the commands. 33413 334142009-07-17 Peter Kasting <pkasting@google.com> 33415 33416 Reviewed by David Kilzer. 33417 33418 https://bugs.webkit.org/show_bug.cgi?id=27323 33419 Tweak some regexes for correctness. 33420 33421 * Scripts/prepare-ChangeLog: Allow 1-character filenames (my previous 33422 change here didn't quite get things right). 33423 * Scripts/update-webkit: Detect conflicting ChangeLogs correctly by not 33424 including any trailing whitespace in the name "ChangeLog", and by 33425 normalizing paths before calling basename() to avoid confusing it. 33426 (normalizePath() copied from prepare-ChangeLog.) 33427 334282009-07-17 Peter Kasting <pkasting@google.com> 33429 33430 Reviewed by Steve Falkenburg. 33431 33432 https://bugs.webkit.org/show_bug.cgi?id=27323 33433 Only add Cygwin to the path when it isn't already there. This avoids 33434 causing problems for people who purposefully have non-Cygwin versions of 33435 executables like svn in front of the Cygwin ones in their paths. 33436 33437 * DumpRenderTree/win/DumpRenderTree.vcproj: 33438 * DumpRenderTree/win/ImageDiff.vcproj: 33439 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 33440 334412009-07-17 David Levin <levin@chromium.org> 33442 33443 Reviewed by Adam Treat. 33444 33445 WebKit should have a bash completion script to aid with common commands. 33446 https://bugs.webkit.org/show_bug.cgi?id=27374 33447 33448 * Scripts/webkit-tools-completion.sh: The script which enables option completion 33449 for several WebKit command line scripts. 33450 334512009-07-17 Peter Kasting <pkasting@google.com> 33452 33453 Reviewed by David Kilzer. 33454 33455 https://bugs.webkit.org/show_bug.cgi?id=27323 33456 Avoid error spew on Macs, and fix a few other tiny details. 33457 33458 * Scripts/svn-create-patch: 33459 334602009-07-17 Adam Treat <adam.treat@torchmobile.com> 33461 33462 Reviewed by Dave Levin. 33463 33464 https://bugs.webkit.org/show_bug.cgi?id=27377 33465 This makes cpplint complain about this for instance: 33466 33467 if (true) 33468 { 33469 int foo; 33470 } 33471 33472 Add the appropriate unit tests. 33473 33474 * Scripts/modules/cpplint.py: 33475 * Scripts/modules/cpplint_unittest.py: 33476 334772009-07-17 Adam Treat <adam.treat@torchmobile.com> 33478 33479 Reviewed by Dave Levin. 33480 33481 https://bugs.webkit.org/show_bug.cgi?id=27377 33482 Don't filter whitespace at the end of the line. This is not 33483 explicitly a rule of webkit coding style, but there is no reason 33484 not to warn of this common style problem. 33485 33486 Don't filter whitespace newline. Now, cpplint will complain 33487 about the following situation: 33488 33489 if (true) { 33490 doSomething(); 33491 doSomethingAgain(); 33492 } 33493 else 33494 doSomething(); 33495 33496 Which is a webkit coding style rule violation. 33497 33498 * Scripts/modules/cpplint.py: 33499 335002009-07-17 Adam Treat <adam.treat@torchmobile.com> 33501 33502 Reviewed by Dave Levin. 33503 33504 https://bugs.webkit.org/show_bug.cgi?id=27377 33505 Move this comment to where it belongs. 33506 33507 * Scripts/modules/cpplint_unittest.py: 33508 335092009-07-17 Brent Fulgham <bfulgham@webkit.org> 33510 33511 Reviewed by Adam Roben. 33512 33513 Correct crash in WinLauncher due to improper mixing of BSTR 33514 and TCHAR types. 33515 https://bugs.webkit.org/show_bug.cgi?id=27381 33516 33517 * WinLauncher/WinLauncher.cpp: 33518 (loadURL): Perform SysReAllocString to update the BSTR with 33519 the contents of the TCHAR string. 33520 335212009-07-17 David Levin <levin@chromium.org> 33522 33523 Reviewed by Adam Treat. 33524 33525 cpplint should flag usages of NULL. 33526 https://bugs.webkit.org/show_bug.cgi?id=27341 33527 33528 * Scripts/modules/cpplint.py: Add the check for NULL test and call it. 33529 Make the collapse_strings method public. 33530 * Scripts/modules/cpplint_unittest.py: Add several tests to verify 33531 the check for NULL behavior. Adjust existing tests due to the 33532 new NULL check: 33533 1. Several had NULL removed (or were just removed completely). 33534 2. Two tests now do an assert that allows the caller to check 33535 that a particular error is one of several that was returned. 33536 335372009-07-17 Shinichiro Hamaji <hamaji@chromium.org> 33538 33539 Reviewed by David Levin. 33540 33541 Add a parser of patches for linter. 33542 https://bugs.webkit.org/show_bug.cgi?id=27363 33543 33544 Adds a simple parser for unified diff format. 33545 33546 * Scripts/modules/diff_parser.py: Added. 33547 * Scripts/modules/diff_parser_unittest.py: Added. 33548 335492009-06-30 Holger Hans Peter Freyther <zecke@selfish.org> 33550 33551 Reviewed by Simon Hausmann. 33552 33553 [GTK+] Remove check to be loadable in firefox 33554 https://bugs.webkit.org/show_bug.cgi?id=27345 33555 33556 if (aMozillaVTable->size < sizeof (NPNetscapeFuncs)) 33557 fails in firefox but no other example in the mozilla tree is 33558 doing that check. Remove and be happy. 33559 33560 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 33561 (NP_Initialize): 33562 335632009-07-17 Adam Treat <adam.treat@torchmobile.com> 33564 33565 Reviewed by Simon Hausmann. 33566 33567 Something about having a single TAB in a style checking tool like this 33568 is equivalent to nails on a chalk board to me... 33569 33570 * Scripts/modules/cpplint.py: 33571 335722009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org> 33573 33574 Reviewed by Simon Hausmann. 33575 33576 Overwrite the plugin directories for the DRT. 33577 Part of https://bugs.webkit.org/show_bug.cgi?id=27215 33578 33579 * DumpRenderTree/qt/DumpRenderTree.cpp: 33580 (WebCore::DumpRenderTree::DumpRenderTree): 33581 335822009-07-16 Fumitoshi Ukai <ukai@chromium.org> 33583 33584 Reviewed by David Levin. 33585 33586 Add --web-sockets flag and ENABLE_WEB_SOCKETS define. 33587 https://bugs.webkit.org/show_bug.cgi?id=27206 33588 33589 Add --web-sockets flag. 33590 33591 * Scripts/build-webkit: add --web-sockets flag. 33592 335932009-07-16 Adam Treat <adam.treat@torchmobile.com> 33594 33595 Reviewed by Dave Levin. 33596 33597 cpplint should check for one line control clauses that are surrounded 33598 by braces 33599 https://bugs.webkit.org/show_bug.cgi?id=27354 33600 33601 * Scripts/modules/cpplint.py: Added the new lint check. 33602 * Scripts/modules/cpplint_unittest.py: Add tests for the new lint check 33603 and fix the other tests as they were not passing this new lint check. 33604 336052009-07-16 Peter Kasting <pkasting@google.com> 33606 33607 Reviewed by David Kilzer. 33608 33609 https://bugs.webkit.org/show_bug.cgi?id=27323 33610 Improve support for WebKit checkouts hosted inside other checkouts 33611 (possible for some ports, e.g. Chromium). 33612 33613 * Scripts/svn-create-patch: Determine SVN root by looking for Repository 33614 Root string and aborting when it's missing or different than what 33615 we've already seen. 33616 336172009-07-16 Peter Kasting <pkasting@google.com> 33618 33619 Reviewed by Adam Roben. 33620 33621 https://bugs.webkit.org/show_bug.cgi?id=27323 33622 Improve support for non-Cygwin SVNs on Windows. 33623 33624 * Scripts/commit-log-editor: Modify regex so that trailing whitespace 33625 (e.g. \r) isn't included in filenames. 33626 * Scripts/prepare-ChangeLog: Fix a case of adding "\n" to the ChangeLog 33627 without normalizing. Normalize file paths early instead of late so 33628 all stages of the script work. Modify regexes so that trailing 33629 whitespace (e.g. \r) isn't included in filenames. 33630 * Scripts/svn-create-patch: Use a regex instead of chomp so we cut off 33631 line endings even if they don't match Perl's. 33632 336332009-07-16 Joseph Pecoraro <joepeck02@gmail.com> 33634 33635 Reviewed by Darin Adler. 33636 33637 WebKitTools/Scripts/svn-create-patch is broken 33638 https://bugs.webkit.org/show_bug.cgi?id=27328 33639 33640 * Scripts/svn-create-patch: one line fix for unusual perl behavior 33641 336422009-07-16 David Levin <levin@chromium.org> 33643 33644 Reviewed by David Kilzer. 33645 33646 cpplint should check for equality comparisons to 0/true/false 33647 https://bugs.webkit.org/show_bug.cgi?id=27333 33648 33649 * Scripts/modules/cpplint.py: Added the new lint check. 33650 * Scripts/modules/cpplint_unittest.py: Add tests for the new lint check 33651 and fix a regex that in another unit test that caused it to fail when 33652 you have a directory with a number in it (like WebKit-2) 33653 336542009-07-16 David D. Kilzer <ddkilzer@webkit.org> 33655 33656 <http://webkit.org/b/27241> bugzilla-tool post-commits silently fails with bad args 33657 33658 Reviewed by Eric Seidel. 33659 33660 * Scripts/bugzilla-tool: 33661 (PostCommitsAsPatchesToBug.execute): Added more error checking 33662 when consuming arguments. 33663 336642009-07-16 David D. Kilzer <ddkilzer@webkit.org> 33665 33666 TOOL FIX: scm.py: CommitMessage.message is ambiguous 33667 33668 Fixes this error when running bugzilla-tool apply-patches 33669 --local-commit: 33670 33671 File "bugzilla-tool", line 188, in apply_patches 33672 scm.commit_locally_with_message(commit_message.message() or patch['name']) 33673 TypeError: 'list' object is not callable 33674 33675 * Scripts/modules/scm.py: After r45940 (and r45971), rename 33676 CommitMessage.message attribute to CommitMessage.message_lines. 33677 (CommitMessage.__init__): 33678 (CommitMessage.body): 33679 (CommitMessage.description): 33680 (CommitMessage.message): 33681 (CommitMessage.parse_bug_id): 33682 336832009-07-16 David D. Kilzer <ddkilzer@webkit.org> 33684 33685 TOOL FIX: bugzilla-tool: import CommitMessage class 33686 33687 * Scripts/bugzilla-tool: After r45940, the CommitMessage class 33688 needs to be imported for commit_message_for_this_commit(). 33689 336902009-07-16 David Levin <levin@chromium.org> 33691 33692 Reviewed by Maciej Stachowiak. 33693 33694 prepare-ChangeLog should display the --bug option in its help text. 33695 https://bugs.webkit.org/show_bug.cgi?id=27334 33696 33697 * Scripts/prepare-ChangeLog: Added the help text. 33698 336992009-07-15 Darin Adler <darin@apple.com> 33700 33701 * Scripts/do-webcore-rename: Check in the version used to 33702 rename parseURL to deprecatedParseURL. 33703 337042009-07-10 David Kilzer <ddkilzer@apple.com> 33705 33706 bugzilla-tool: create CommitMessage class 33707 33708 Reviewed by Eric Seidel. 33709 33710 Create a CommitMessage class to encapsulate related code. 33711 33712 * Scripts/bugzilla-tool: 33713 (bug_id_from_commit_message): Moved to 33714 CommitMessage.parse_bug_id(). 33715 (commit_message_for_this_commit): Return a CommitMessage. 33716 (ApplyPatchesFromBug.apply_patches): Use CommitMessage.message(). 33717 (LandPatchesFromBugs.build_and_commit): Ditto. 33718 (CommitMessageForCurrentDiff.execute): Ditto. 33719 (PostCommitsAsPatchesToBug.execute): Switched from 33720 Git.commit_message_for_commit() to 33721 Git.commit_message_for_local_commit(). Switched from 33722 bug_id_from_commit_message() to CommitMessage.parse_bug_id(). 33723 33724 * Scripts/modules/scm.py: 33725 (first_non_empty_line_after_index): Added. 33726 (CommitMessage.__init__): Added. 33727 (CommitMessage.body): Added. 33728 (CommitMessage.description): Added. 33729 (CommitMessage.message): Added. 33730 (CommitMessage.parse_bug_id): Added. Moved from 33731 bug_id_from_commit_message() in bugzilla-tool. 33732 (Git.commit_message_for_local_commit): Renamed from 33733 commit_message_for_commit(). Return a CommitMessage. 33734 337352009-07-15 Joseph Pecoraro <joepeck02@gmail.com> 33736 33737 Reviewed by David Kilzer. 33738 33739 bugzilla-tool/svn-apply can't handle patches made from a non-root directory 33740 https://bugs.webkit.org/show_bug.cgi?id=26999 33741 33742 * Scripts/svn-create-patch: 33743 337442009-07-15 Shinichiro Hamaji <hamaji@chromium.org> 33745 33746 Reviewed by David Levin. 33747 33748 Move cpplint.py to module directory 33749 https://bugs.webkit.org/show_bug.cgi?id=27302 33750 33751 * Scripts/modules/cpplint.py: Renamed from WebKitTools/Scripts/cpplint.py. 33752 * Scripts/modules/cpplint_unittest.py: Renamed from WebKitTools/Scripts/cpplint_unittest.py. 33753 337542009-07-15 Simon Hausmann <simon.hausmann@nokia.com> 33755 33756 Reviewed by Adam Treat. 33757 33758 https://bugs.webkit.org/show_bug.cgi?id=27295 33759 33760 Re-implement QWebPage::shouldInterruptJavaScript to disable 33761 js interruption and avoid showing a messagebox during Qt DRT 33762 runs when script execution takes a bit longer. 33763 33764 * DumpRenderTree/qt/DumpRenderTree.cpp: 33765 (WebCore::WebPage::shouldInterruptJavaScript): Return false 33766 in re-implemented slot. 33767 337682009-07-15 Zoltan Horvath <hzoltan@inf.u-szeged.hu> 33769 33770 Reviewed by Jan Alonzo. 33771 33772 Fix the DumpRenderTree GTK+ build 33773 https://bugs.webkit.org/show_bug.cgi?id=27290 33774 33775 Set USE_SYSTEM_MALLOC macro for the DumpRenderTree build to 33776 disable using TCmalloc in DumpRenderTree. 33777 33778 * GNUmakefile.am: 33779 337802009-07-14 Steve Falkenburg <sfalken@apple.com> 33781 33782 Reorganize JavaScriptCore headers into: 33783 API: include/JavaScriptCore/ 33784 Private: include/private/JavaScriptCore/ 33785 33786 Reviewed by Darin Adler. 33787 33788 * DumpRenderTree/win/DumpRenderTree.vcproj: 33789 * DumpRenderTree/win/ImageDiff.vcproj: 33790 337912009-07-14 Shinichiro Hamaji <hamaji@chromium.org> 33792 33793 Reviewed by David Levin. 33794 33795 WebKit needs a style linting tool 33796 https://bugs.webkit.org/show_bug.cgi?id=25884 33797 33798 Modifies cpplint (http://google-styleguide.googlecode.com/svn/trunk/cpplint/) 33799 based on WebKit's style guide. 33800 33801 * Scripts/cpplint.py: Added. 33802 * Scripts/cpplint_unittest.py: Added. 33803 338042009-07-14 Laszlo Gombos <laszlo.1.gombos@nokia.com> 33805 33806 Reviewed by Simon Hausmann. 33807 33808 [Qt] DumpRenderTree no longer builds with Qt4.4 33809 https://bugs.webkit.org/show_bug.cgi?id=27257 33810 33811 Flag Qt 4.5 dependency to allow building with Qt 4.4. 33812 33813 * DumpRenderTree/qt/main.cpp: 33814 (main): 33815 338162009-07-13 Brent Fulgham <bfulgham@webkit.org> 33817 33818 Reviewed by Adam Roben. 33819 33820 Add new configuration flag for redistributable Windows build. 33821 https://bugs.webkit.org/show_bug.cgi=27087 33822 33823 * DumpRenderTree/config.h: Check for presence of WIN_CAIRO and 33824 select appropriate configuration. Defaults to standard Apple build. 33825 * DumpRenderTree/win/DumpRenderTree.vcproj: Add new WinCairo.vsprops 33826 to Debug_Cairo and Release_Cairo targets. 33827 338282009-07-13 Simon Hausmann <simon.hausmann@nokia.com> 33829 33830 Reviewed by Ariya Hidayat. 33831 33832 Always run the Qt DRT with the raster graphicssystem on X11, for 33833 increased stability in the image based tests, in particular canvas. 33834 33835 * DumpRenderTree/qt/main.cpp: 33836 (main): 33837 338382009-07-13 Simon Hausmann <simon.hausmann@nokia.com> 33839 33840 Reviewed by Ariya Hidayat. 33841 33842 Fix test netscape plugin usage with the Qt DRT. 33843 33844 * DumpRenderTree/qt/DumpRenderTree.cpp: 33845 (WebCore::WebPage::WebPage): Enable plugins in the settings. 33846 * Scripts/run-webkit-tests: Set the QT_WEBKIT_PLUGIN path to the correct build 33847 directory to make Qt DRT find the test netscape plugin. 33848 338492009-07-13 Simon Hausmann <hausmann@webkit.org> 33850 33851 Reviewed by Ariya Hidayat. 33852 33853 Make sure to disable the fixed contents size when resetting the page/view 33854 state between test runs, to avoid side-effects. 33855 33856 * DumpRenderTree/qt/DumpRenderTree.cpp: 33857 (WebCore::DumpRenderTree::open): Call setFixedContentsSize() with an invalid 33858 QSize to disable the fixed layout. 33859 338602009-07-13 Simon Hausmann <hausmann@webkit.org> 33861 33862 Reviewed by Ariya Hidayat. 33863 33864 When creating new windows, don't forget to connect the new 33865 page's main frame. This ensures that for example the layoutTestController 33866 is also available there. 33867 33868 * DumpRenderTree/qt/DumpRenderTree.cpp: 33869 (WebCore::DumpRenderTree::createWindow): 33870 338712009-07-13 Simon Hausmann <hausmann@webkit.org> 33872 33873 Reviewed by Ariya Hidayat. 33874 33875 Added support for LayoutTestController.setPrivateBrowsingEnabled. 33876 33877 * DumpRenderTree/qt/jsobjects.cpp: 33878 (LayoutTestController::reset): 33879 (LayoutTestController::setPrivateBrowsingEnabled): 33880 * DumpRenderTree/qt/jsobjects.h: 33881 338822009-07-13 Simon Hausmann <hausmann@webkit.org> 33883 33884 Reviewed by Ariya Hidayat. 33885 33886 Added support for database callbacks, storage quota setting, 33887 and clearing of all databases. 33888 33889 * DumpRenderTree/qt/DumpRenderTree.cpp: 33890 (WebCore::DumpRenderTree::DumpRenderTree): 33891 (WebCore::DumpRenderTree::dumpDatabaseQuota): 33892 * DumpRenderTree/qt/DumpRenderTree.h: 33893 * DumpRenderTree/qt/jsobjects.cpp: 33894 (LayoutTestController::reset): 33895 (LayoutTestController::setDatabaseQuota): 33896 (LayoutTestController::clearAllDatabases): 33897 * DumpRenderTree/qt/jsobjects.h: 33898 (LayoutTestController::shouldDumpDatabaseCallbacks): 33899 (LayoutTestController::dumpDatabaseCallbacks): 33900 * DumpRenderTree/qt/main.cpp: 33901 (main): 33902 339032009-07-13 Simon Hausmann <hausmann@webkit.org> 33904 33905 Reviewed by Ariya Hidayat. 33906 33907 Setup the path in the Qt DRT for HTML 5 Databases, to enable some of 33908 the storage layout tests. 33909 33910 * DumpRenderTree/qt/main.cpp: 33911 (main): 33912 339132009-07-13 Simon Hausmann <hausmann@webkit.org> 33914 33915 Reviewed by Ariya Hidayat. 33916 33917 Make the test output more robust by dumping only when the main 33918 frame finishes loading, instead of when _any_ frame finishes. 33919 33920 * DumpRenderTree/qt/DumpRenderTree.cpp: 33921 (WebCore::DumpRenderTree::DumpRenderTree): Connect to the 33922 main frame's loadFinished() signal instead of the page's one. 33923 339242009-07-13 Simon Hausmann <hausmann@webkit.org> 33925 33926 Reviewed by Ariya Hidayat. 33927 33928 Implement the GCController DRT interface. 33929 33930 * DumpRenderTree/qt/DumpRenderTree.cpp: 33931 (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController. 33932 (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine. 33933 * DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController. 33934 * DumpRenderTree/qt/jsobjects.cpp: Implement GCController. 33935 (GCController::GCController): 33936 (GCController::collect): 33937 (GCController::collectOnAlternateThread): 33938 (GCController::getJSObjectCount): 33939 * DumpRenderTree/qt/jsobjects.h: Declare GCController. 33940 339412009-07-13 Simon Hausmann <hausmann@webkit.org> 33942 33943 Reviewed by Ariya Hidayat. 33944 33945 Implement the GCController DRT interface in the Qt DRT. 33946 33947 * DumpRenderTree/qt/DumpRenderTree.cpp: 33948 (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController. 33949 (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine. 33950 * DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController. 33951 * DumpRenderTree/qt/jsobjects.cpp: Implement GCController. 33952 (GCController::GCController): 33953 (GCController::collect): 33954 (GCController::collectOnAlternateThread): 33955 (GCController::getJSObjectCount): 33956 * DumpRenderTree/qt/jsobjects.h: Declare GCController. 33957 339582009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org> 33959 33960 https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT 33961 33962 Reviewed by Gustavo Noronha and Xan Lopez. 33963 33964 Support running of tests that open and close JS windows automatically. 33965 33966 * DumpRenderTree/gtk/DumpRenderTree.cpp: 33967 (dumpFramesAsText): 33968 (dumpBackForwardListForAllWebViews): 33969 (resetWebViewToConsistentStateBeforeTesting): 33970 (dump): 33971 (runTest): 33972 (webViewClose): 33973 (createWebView): 33974 (webViewCreate): 33975 (main): 33976 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: 33977 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 33978 (LayoutTestController::windowCount): 33979 (LayoutTestController::setPopupBlockingEnabled): 33980 339812009-07-13 Shinichiro Hamaji <hamaji@chromium.org> 33982 33983 Reviewed by Maciej Stachowiak. 33984 33985 prepare-ChangeLog should decode HTML entities in short description 33986 https://bugs.webkit.org/show_bug.cgi?id=27122 33987 33988 Decode the short description by adding a function which decodes HTML 33989 entities. It can decode &, <, >, ", and ' . They may be sufficient 33990 as the description seems to be encoded by xml_quote in 33991 http://mxr.mozilla.org/bugzilla/source/Bugzilla/Util.pm 33992 33993 * Scripts/prepare-ChangeLog: 33994 339952009-07-13 Drew Wilson <atwilson@google.com> 33996 33997 Reviewed by David Levin. 33998 33999 Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs 34000 https://bugs.webkit.org/show_bug.cgi?id=26932 34001 34002 Added support for --shared-workers (turned off by default) 34003 34004 * Scripts/build-webkit: 34005 340062009-07-12 Dan Bernstein <mitz@apple.com> 34007 34008 Reviewed by Maciej Stachowiak. 34009 34010 https://bugs.webkit.org/show_bug.cgi?id=27196 34011 Update check-for-global-initializers for the renaming for bidi.cpp to 34012 RenderBlockLineLayout.cpp 34013 34014 * Scripts/check-for-global-initializers: 34015 340162009-07-11 Simon Fraser <simon.fraser@apple.com> 34017 34018 Enable support for accelerated compositing and 3d transforms on Leopard. 34019 <https://bugs.webkit.org/show_bug.cgi?id=20166> 34020 <rdar://problem/6120614> 34021 34022 Reviewed by Oliver Hunt. 34023 34024 * Configurations/FeatureDefines.xcconfig: 34025 * wtf/Platform.h: 34026 340272009-07-10 David Kilzer <ddkilzer@apple.com> 34028 34029 <http://webkit.org/b/27173> svn-apply: Fix typo in git command used to find deleted files 34030 34031 Reviewed by Eric Seidel. 34032 34033 * Scripts/svn-apply: 34034 (scmWillDeleteFile): Changed 'head' to 'HEAD'. 34035 340362009-07-10 David Kilzer <ddkilzer@apple.com> 34037 34038 <http://webkit.org/b/27167> bugzilla-tool: hide help for unsupported commands 34039 34040 Reviewed by Eric Seidel. 34041 34042 When bugzilla-tool -h|--help is invoked in an svn working 34043 directory, don't print help for commands that are only supported 34044 on git working directories. 34045 34046 * Scripts/bugzilla-tool: 34047 (Command.__init__): Added requires_local_commits argument with a 34048 default of False. Set self.requires_local_commits attribute. 34049 (PostCommitsAsPatchesToBug.execute): Removed 34050 SCM.supports_local_commits() check since this is now handled by 34051 BugzillaTool.main(). 34052 (PostCommitsAsPatchesToBug.__init__): Added 34053 requires_local_commits=True argument to Command.__init__(). 34054 (BugzillaTool.commands_usage): Don't print help for commands if 34055 they require local commits and the current SCM doesn't support 34056 them. 34057 (BugzillaTool.main): If command_object requires local commits 34058 and the current SCM doesn't, exit with an error message. 34059 340602009-07-10 David Kilzer <ddkilzer@apple.com> 34061 34062 <http://webkit.org/b/27117> bugzilla-tool: use Mac OS X keychain for authentication 34063 34064 Reviewed by Eric Seidel. 34065 34066 Try reading credentials from git config first, then keychain if 34067 running on Mac OS X, else prompt at the command-line. 34068 34069 * Scripts/modules/bugzilla.py: Added "import platform". 34070 (credentials_from_git): Added. 34071 (credentials_from_keychain): Added. 34072 (is_mac_os_x): Added. 34073 (read_credentials): Added. 34074 (Bugzilla.__init__): Moved instance attribute bug_server to a 34075 static attribute named bug-server_url. 34076 (Bugzilla.bug_server_host): Added. Extracted host name from 34077 bug_server_url. 34078 (Bugzilla.bug_server_regex): Updated to be created using 34079 bug_server_host. 34080 (Bugzilla.bug_server_url): Renamed from bug_server. 34081 (Bugzilla.bug_url_for_bug_id): Updated for renaming of 34082 bug_server to bug_server_url. 34083 (Bugzilla.attachment_url_for_id): Ditto. 34084 (Bugzilla.fetch_bug_ids_from_commit_queue): Ditto. 34085 (Bugzilla.authenticate): Ditto. Updated to use 34086 read_credentials(). 34087 (Bugzilla.add_patch_to_bug): Ditto. 34088 340892009-07-10 David Kilzer <ddkilzer@apple.com> 34090 34091 <http://webkit.org/b/27115> bugzilla-tool: extract duplicate logging methods into a module 34092 34093 Reviewed by Adam Roben. 34094 34095 * Scripts/bugzilla-tool: Removed error() and log() methods and 34096 added import of new logging module. 34097 * Scripts/modules/bugzilla.py: Ditto. Removed "import sys". 34098 * Scripts/modules/scm.py: Ditto. 34099 34100 * Scripts/modules/logging.py: Added. 34101 (log): Added. 34102 (error): Added. Prefix error messages with "ERROR: ". 34103 341042009-07-10 Adam Roben <aroben@apple.com> 34105 34106 Sort all our Xcode projects 34107 34108 Accomplished using sort-Xcode-project-file. 34109 34110 Requested by Dave Kilzer. 34111 34112 * DrawTest/DrawTest.xcodeproj/project.pbxproj: 34113 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 34114 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: 34115 341162009-07-10 Adam Roben <aroben@apple.com> 34117 34118 Print prepare-ChangeLog's reminders to STDERR so they don't end up in 34119 the diff output 34120 34121 Fixes REGRESSION (r45647): prepare-ChangeLog -d puts non-diff lines 34122 into the diff 34123 <https://bugs.webkit.org/show_bug.cgi?id=27150> 34124 34125 Reviewed by Maciej Stachowiak. 34126 34127 * Scripts/prepare-ChangeLog: 34128 341292009-07-08 Adam Roben <aroben@apple.com> 34130 34131 Use case-insensitive comparisons when sorting Xcode project files 34132 34133 This matches the sorting used in Xcode's files list. 34134 34135 Fixes Bug 27079: sort-Xcode-project-file should sort 34136 case-insensitively, to match Xcode's files list 34137 <https://bugs.webkit.org/show_bug.cgi?id=27079> 34138 34139 Reviewed by Dave Kilzer. 34140 34141 * Scripts/sort-Xcode-project-file: 34142 (sortChildrenByFileName): 34143 (sortFilesByFileName): 34144 Lowercase the strings before comparing them so that the comparison 34145 will be case-insensitive. 34146 341472009-07-08 Simon Hausmann <hausmann@webkit.org> 34148 34149 Reviewed by Holger Freyther. 34150 34151 https://bugs.webkit.org/show_bug.cgi?id=27109 34152 34153 Fix side-effects in the Qt DRT with tests using application fonts. 34154 34155 Detect if a test used application fonts and re-initialize the fontconfig 34156 application fontset accordingly. 34157 34158 * DumpRenderTree/qt/DumpRenderTree.cpp: 34159 (WebCore::DumpRenderTree::open): call initializeFonts and remove all application fonts 34160 after running a testcase. 34161 (WebCore::DumpRenderTree::initializeFonts): Moved fontconfig initialization code 34162 here from main. 34163 * DumpRenderTree/qt/DumpRenderTree.h: Declare initializeFonts. 34164 * DumpRenderTree/qt/main.cpp: 34165 (main): Moved fontconfig initialization code to DRT::initializeFonts. 34166 341672009-07-10 Antonio Gomes <antonio.gomes@openbossa.org> 34168 34169 Reviewed by Simon Hausmann. 34170 34171 [QT] [ARM] Add pkg-config entry for FontConfig on DRT.pro 34172 https://bugs.webkit.org/show_bug.cgi?id=26990 34173 34174 Missing pkg-config entry for FontConfig in DRT.pro causes some compilers to 34175 not link fine against FontConfig bits. 34176 34177 * DumpRenderTree/qt/DumpRenderTree.pro: 34178 341792009-07-09 Drew Wilson <atwilson@google.com> 34180 34181 Reviewed by Alexey Proskuryakov. 34182 34183 https://bugs.webkit.org/show_bug.cgi?id=26903 34184 34185 Turned on CHANNEL_MESSAGING by default because the MessageChannel API 34186 can now be implemented for Web Workers and is reasonably stable. 34187 34188 * Scripts/build-webkit: 34189 341902009-07-09 David Kilzer <ddkilzer@apple.com> 34191 34192 <http://webkit.org/b/27114> bugzilla-tool: Parse short bug URL from commit log messages 34193 34194 Reviewed by Adam Roben. 34195 34196 * Scripts/bugzilla-tool: 34197 (bug_id_from_commit_message): Check for the short bug URL before 34198 checking for the longer bugs.webkit.org URL. 34199 342002009-07-08 David Kilzer <ddkilzer@apple.com> 34201 34202 Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and actually work 34203 34204 <https://bugs.webkit.org/show_bug.cgi?id=27062> 34205 34206 Reviewed by Eric Seidel. 34207 34208 Removed the required BUGID argument from the "post-commits" 34209 command and replaced it with a -b|--bug-id switch or parsing the 34210 commit log message for the bug URL. Fixed a bug in the 34211 "post-commits" that would ignore the COMMITISH used and post a 34212 patch of local changes against HEAD. Added --no-commit switch 34213 to disable using the bulk of the ChangeLog entry as the comment 34214 for the new patch. 34215 34216 * Scripts/bugzilla-tool: 34217 (bug_id_from_commit_message): Added. Returns a bug id from the 34218 commit log message, thus enforcing the need for a bug URL in the 34219 message. 34220 (PostCommitsAsPatchesToBug.__init__): Updated help description 34221 to match new behavior of pulling bug ids from commit log 34222 messages instead of from the command line. Added -b|--bug-id 34223 switch and --no-comment switch. 34224 (PostCommitsAsPatchesToBug.execute): Updated to use 34225 bug_id_from_commit_message() to pull bug ids from commit log 34226 messages. Also switched from SCM.create_patch() to use 34227 SCM.create_patch_from_local_commit() to fix a bug where local 34228 repository changes were posted as a patch instead of the 34229 specific COMMITISH. Fall back to -b|--bug-id if no URL is found 34230 in the commit log message. Don't specify a comment for the 34231 patch if --no-comment is used. Set cherry_pick argument to True 34232 for Git.commit_ids_from_range_arguments() since we don't want 34233 implicit commit range behavior for this command. 34234 34235 * Scripts/modules/bugzilla.py: Import datetime module. 34236 (timestamp): Added. Returns a timestamp in the form of 34237 "YYYYMMDDhhmmss". 34238 (Bugzilla.bug_server_regex): Added static attribute. 34239 (Bugzilla.add_patch_to_bug): Construct a more meaningful patch 34240 file name using the bug_id and timestamp(). 34241 34242 * Scripts/modules/scm.py: 34243 (SCM.create_patch_from_local_commit): Added. 34244 (Git.create_patch_from_local_commit): Added. Runs "git diff" to 34245 return a patch for the given commit_id. 34246 342472009-07-08 Maciej Stachowiak <mjs@apple.com> 34248 34249 Reviewed by Mark Rowe. 34250 34251 Make prepare-ChangeLog less shouty 34252 https://bugs.webkit.org/show_bug.cgi?id=27098 34253 34254 * Scripts/prepare-ChangeLog: 34255 342562009-07-08 David Kilzer <ddkilzer@apple.com> 34257 34258 Bug 27083: bugzilla.py: Clean up bug_server use 34259 34260 <https://bugs.webkit.org/show_bug.cgi?id=27083> 34261 34262 Reviewed by Darin Adler. 34263 34264 * Scripts/modules/bugzilla.py: 34265 (Bugzilla.fetch_bug_ids_from_commit_queue): Use bug_server 34266 instead of hard-coding the URL. 34267 (Bugzilla.authenticate): Remove extra '/' before URL path. 34268 (Bugzilla.add_patch_to_bug): Ditto. 34269 342702009-07-08 Brent Fulgham <bfulgham@webkit.org> 34271 34272 Build fix for Windows Cairo. 34273 34274 Cairo build was incorrectly #including the PixelDumpSupportCG.h 34275 instead of PixelDumpSupportCairo.h 34276 34277 * DumpRenderTree/win/PixelDumpSupportWin.cpp: Correct #include 34278 342792009-07-08 David Faure <faure@kde.org> 34280 34281 Reviewed by Ariya Hidayat. 34282 34283 Small documentation improvement for build-webkit --help 34284 34285 * Scripts/build-webkit: mention --debug option 34286 342872009-07-07 Brady Eidson <beidson@apple.com> 34288 34289 Tiger build fix, work around missing NSString API. 34290 34291 * DumpRenderTree/mac/DumpRenderTree.mm: 34292 (dumpHistoryItem): 34293 342942009-07-07 Brady Eidson <beidson@apple.com> 34295 34296 Reviewed by Mark Rowe. 34297 34298 https://bugs.webkit.org/show_bug.cgi?id=27049 - In dumpBackForwardList() mode, DRT should normalize file urls. 34299 34300 Make the dump of a history item agnostic to the layout of filesystem on the testing machine. 34301 34302 * DumpRenderTree/mac/DumpRenderTree.mm: 34303 (dumpHistoryItem): 34304 * DumpRenderTree/win/DumpRenderTree.cpp: 34305 (dumpHistoryItem): 34306 343072009-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 34308 34309 Rubber-stamped by Simon Hausmann. 34310 34311 Correct git url of the Qt test-fonts. 34312 34313 * DumpRenderTree/qt/main.cpp: 34314 (main): 34315 343162009-07-07 Simon Hausmann <hausmann@webkit.org> 34317 34318 Reviewed by Holger Freyther. 34319 34320 Clear the main frame's name between loading pages, like in r36652. This 34321 reduces the side-effects between test cases. 34322 34323 * DumpRenderTree/qt/DumpRenderTree.cpp: 34324 (WebCore::DumpRenderTree::open): 34325 343262009-07-06 Simon Hausmann <hausmann@webkit.org> 34327 34328 Reviewed by Holger Freyther. 34329 34330 Fix various layout tests with Qt's DRT. 34331 34332 Remember to set the focus on the web page before 34333 loading. 34334 34335 * DumpRenderTree/qt/DumpRenderTree.cpp: 34336 (WebCore::DumpRenderTree::open): 34337 343382009-07-07 Simon Hausmann <hausmann@webkit.org> 34339 34340 Reviewed by Tor Arne Vestbø and Holger Freyther. 34341 34342 Fix timeout timer handling in Qt DRT. 34343 34344 Use QBasicTimer instead of startTimer/killTimer, to fix the 34345 problem that starting the timeout timer did not stop a 34346 previously started timer, causing multiple emissions of timeout. 34347 The timerEvent() implementation now also checks the timer id, to 34348 protect against double timeouts. 34349 34350 * DumpRenderTree/qt/jsobjects.cpp: 34351 (LayoutTestController::LayoutTestController): 34352 (LayoutTestController::reset): 34353 (LayoutTestController::waitUntilDone): 34354 (LayoutTestController::notifyDone): 34355 (LayoutTestController::timerEvent): 34356 * DumpRenderTree/qt/jsobjects.h: 34357 343582009-07-06 Eric Seidel <eric@webkit.org> 34359 34360 Reviewed by Maciej Stachowiak. 34361 34362 bugzilla-tool fails to close bugs with bugzilla 3.0 34363 https://bugs.webkit.org/show_bug.cgi?id=27008 34364 34365 Update bugzilla.py to match changes in the bug page "changeform" 34366 Update scm.py to add bug_ids to attachments to make error reporting nicer. 34367 34368 * Scripts/modules/bugzilla.py: 34369 * Scripts/modules/scm.py: 34370 343712009-07-03 Maciej Stachowiak <mjs@apple.com> 34372 34373 Reviewed by Eric Seidel. 34374 34375 bugzilla-tool forgot how to obsolete patches 34376 https://bugs.webkit.org/show_bug.cgi?id=26951 34377 34378 * Scripts/modules/bugzilla.py: 34379 343802009-07-02 Brent Fulgham <bfulgham@webkit.org> 34381 34382 Unreviewed build fix (Cairo this time) for DumpRenderTree. 34383 Put Cairo code back in, but use original include order 34384 for the CG stuff to avoid compile issues. 34385 34386 * DumpRenderTree/win/PixelDumpSupportWin.cpp: 34387 (createBitmapContextFromWebView): 34388 343892009-07-02 Eric Seidel <eric@webkit.org> 34390 34391 Correct blatant typo (missing []), no review. 34392 34393 * Scripts/modules/scm.py: 34394 343952009-07-02 Brent Fulgham <bfulgham@webkit.org> 34396 34397 Windows build fix, no review. 34398 34399 34400 Reverting PixelDumpSupportWin.cpp change to avoid strange 34401 error on the build-bot. 34402 34403 * DumpRenderTree/win/PixelDumpSupportWin.cpp: 34404 (createBitmapContextFromWebView): 34405 344062009-07-02 Brent Fulgham <bfulgham@webkit.org> 34407 34408 Build fix, no review. 34409 34410 * DumpRenderTree/config.h: 34411 344122009-07-02 Eric Seidel <eric@webkit.org> 34413 34414 Reviewed by David Levin. 34415 34416 bugzilla-tool needs to handle login failure 34417 https://bugs.webkit.org/show_bug.cgi?id=26913 34418 34419 We now exit(1) on login failure. 34420 34421 * Scripts/modules/bugzilla.py: 34422 344232009-06-30 Brent Fulgham <bfulgham@webkit.org> 34424 34425 Reviewed by Adam Roben. 34426 34427 Add build support for a Windows Cairo version of 34428 DumpRenderTree. Share as much logic between the 34429 CG and Cairo builds as possible. 34430 https://bugs.webkit.org/show_bug.cgi?id=26457 34431 34432 * DumpRenderTree/PixelDumpSupport.cpp: Added. 34433 (dumpWebViewAsPixelsAndCompareWithExpected): Moved common logic 34434 from CG-specific file. 34435 (printPNG): Moved common logic from CG-specific file. 34436 * DumpRenderTree/PixelDumpSupport.h: Add declaration for new 34437 common printPNG function. 34438 * DumpRenderTree/cairo: Added. 34439 * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Added. 34440 Implement cairo-specific logic for dealing with Cairo surfaces. 34441 (writeFunction): 34442 (printPNG): Cairo-specific PNG handling logic. 34443 (computeMD5HashStringForBitmapContext): New Cairo routine using 34444 the generic BitmapContext signature. 34445 (dumpBitmap): New function containing Cairo-specific portions of 34446 the dumping routine. 34447 * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Added. 34448 Provide Cairo version of the BitmapContext structure so that 34449 dumping routines can work on an abstract type. 34450 (BitmapContext::createByAdoptingBitmapAndContext): 34451 (BitmapContext::~BitmapContext): 34452 (BitmapContext::cairoContext): 34453 (BitmapContext::BitmapContext): 34454 * DumpRenderTree/cg/PixelDumpSupportCG.cpp: 34455 (printPNG): CG-specific PNG handling logic. 34456 (computeMD5HashStringForBitmapContext): Revised to use generic 34457 BitmapContext signature. 34458 (dumpBitmap): New function containing CG-specific portions of 34459 the dumping routine. 34460 * DumpRenderTree/cg/PixelDumpSupportCG.h: Add new signatures. 34461 * DumpRenderTree/win/DumpRenderTree.cpp: Disable CFNetwork logic 34462 when building the non-CFNetwork version. 34463 (main): 34464 * DumpRenderTree/win/DumpRenderTree.vcproj: 34465 * DumpRenderTree/win/PixelDumpSupportWin.cpp: 34466 (createBitmapContextFromWebView): Provide parallel Cairo implementation 34467 of CG bitmap/context setup. 34468 344692009-07-02 Eric Seidel <eric@webkit.org> 34470 34471 No review, just adding Antti as a reviewer. 34472 34473 * Scripts/modules/bugzilla.py: 34474 344752009-07-02 Antonio Gomes <antonio.gomes@openbossa.org> 34476 34477 Reviewed by Simon Hausmann. 34478 34479 https://bugs.webkit.org/show_bug.cgi?id=26896 34480 34481 [Qt] Set DRT's default fontsize to 13. 34482 34483 * DumpRenderTree/qt/DumpRenderTree.cpp: 34484 (WebCore::WebPage::WebPage): 34485 344862009-07-01 Eric Seidel <eric@webkit.org> 34487 34488 Reviewed by Adam Barth. 34489 34490 bugzilla-tool fails for SVN users 34491 https://bugs.webkit.org/show_bug.cgi?id=26914 34492 34493 To fix this I moved svn from -F - to using -m 34494 In order for -m to work I had to move us off of shell=True 34495 To move off of shell=True all call sites for run_command 34496 which take args, need to pass their args as an list instead of a string. 34497 34498 In order for the final bug update to work correctly, I had to 34499 abstract the way that we parse out revision numbers from the commit text. 34500 34501 * Scripts/bugzilla-tool: 34502 * Scripts/modules/scm.py: 34503 345042009-07-01 Eric Seidel <eric@webkit.org> 34505 34506 Reviewed by Maciej Stachowiak. 34507 34508 prepare-ChangeLog should have a --bug= argument and use it for url autofill 34509 https://bugs.webkit.org/show_bug.cgi?id=26383 34510 34511 prepare-ChangeLog now knows how to grab the bug title from bugs.webkit.org 34512 I also added a bit more template text in an effort to get better ChangeLogs 34513 from casual contributers. 34514 34515 * Scripts/prepare-ChangeLog: 34516 345172009-07-01 Eric Seidel <eric@webkit.org> 34518 34519 Reviewed by Adam Roben. 34520 34521 prepare-ChangeLog should fail when EMAIL_ADDRESS or REAL_NAME are missing: 34522 https://bugs.webkit.org/show_bug.cgi?id=26692 34523 34524 I also made prepare-ChangeLog sanity-check names and email addresses a little. 34525 Names must contain a space, and email addresses must contain '@' 34526 34527 Also "fixed" $email_address to $emailAddress. This script uses mixed variable name styles. 34528 34529 * Scripts/prepare-ChangeLog: 34530 345312009-07-01 Chris Fleizach <cfleizach@apple.com> 34532 34533 Reviewed by Beth Dakin. 34534 34535 Bug 26900: AX: Manual spell check with Command-; does not bring up suggestions 34536 https://bugs.webkit.org/show_bug.cgi?id=26900 34537 34538 Expose the ability to get the click point of an element through accessibility. 34539 34540 * DumpRenderTree/AccessibilityUIElement.cpp: 34541 (getClickPointXCallback): 34542 (getClickPointYCallback): 34543 (AccessibilityUIElement::getJSClass): 34544 * DumpRenderTree/AccessibilityUIElement.h: 34545 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 34546 (AccessibilityUIElement::clickPointX): 34547 (AccessibilityUIElement::clickPointY): 34548 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 34549 (AccessibilityUIElement::clickPointX): 34550 (AccessibilityUIElement::clickPointY): 34551 345522009-07-01 Mark Rowe <mrowe@apple.com> 34553 34554 Reviewed by Simon Fraser. 34555 34556 Change how WebKitNightlyEnabler.dylib lies about Safari's identity to LaunchServices. 34557 This makes WebKit.app behave as expected when set as the default web browser on a wider 34558 range of OS versions. 34559 34560 * WebKitLauncher/WebKitNightlyEnabler.m: 34561 (poseAsWebKitApp): 34562 (enableWebKitNightlyBehaviour): 34563 345642009-07-01 Mark Rowe <mrowe@apple.com> 34565 34566 Reviewed by Simon Fraser. 34567 34568 Shuffle some code around in preparation for a change to how poseAsWebKitApp works. 34569 34570 * WebKitLauncher/WebKitNightlyEnabler.m: 34571 (systemVersion): 34572 (webKitLauncherBundle): 34573 (insideSafari4OnTigerTrampoline): 34574 345752009-06-30 Xan Lopez <xlopez@igalia.com> 34576 34577 Reviewed by Jan Alonzo. 34578 34579 https://bugs.webkit.org/show_bug.cgi?id=26877 34580 [GTK] DRT fixes to pass new plugin test 34581 34582 Silence compiler warnings. 34583 34584 Newer GCC don't like using or returning a static string where a 34585 'char*' is expected. Ideally we'd change the function signatures 34586 to return or take 'const char*' I suppose, but since we can't do 34587 that just cast the strings to 'char*'. 34588 34589 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 34590 (webkit_test_plugin_get_value): 34591 345922009-06-30 Xan Lopez <xlopez@igalia.com> 34593 34594 Reviewed by Jan Alonzo. 34595 34596 https://bugs.webkit.org/show_bug.cgi?id=26877 34597 [GTK] DRT fixes to pass new plugin test 34598 34599 Use the common pluginLog function instead of a local copy. 34600 34601 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 34602 (webkit_test_plugin_new_instance): 34603 (webkit_test_plugin_destroy_instance): 34604 (webkit_test_plugin_set_window): 34605 (webkit_test_plugin_handle_event): 34606 346072009-06-30 Xan Lopez <xlopez@igalia.com> 34608 34609 Reviewed by Jan Alonzo. 34610 34611 https://bugs.webkit.org/show_bug.cgi?id=26877 34612 [GTK] DRT fixes to pass new plugin test 34613 34614 Modify our DRT as done in bug #15457 to log logSrc as src in order 34615 to pass test plugins/netscape-plugin-map-data-to-src.html. 34616 34617 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 34618 (webkit_test_plugin_new_instance): 34619 346202009-06-30 Adrien Nader <camaradetux@gmail.com> 34621 34622 Reviewed by Jan Alonzo. 34623 34624 [GTK] GtkLauncher depends on gtk+2-2.15 because of gtk_orientable_set_orientation() 34625 https://bugs.webkit.org/show_bug.cgi?id=26835 34626 34627 * GtkLauncher/main.c: 34628 (create_toolbar): 34629 346302009-06-30 Eric Seidel <eric@webkit.org> 34631 34632 Typo fix only, no review. 34633 34634 Fix typo causing failure during land-diff 34635 34636 * Scripts/bugzilla-tool: 34637 346382009-06-30 Simon Fraser <simon.fraser@apple.com> 34639 34640 Reviewed by Dan Bernstein. 34641 34642 Fix drawing of view background in pixel snapshots when using compositing. 34643 We still need to call -displayIfNeeded to ensure that the NSView drawing 34644 has happened. 34645 34646 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 34647 (createBitmapContextFromWebView): 34648 346492009-06-30 Simon Fraser <simon.fraser@apple.com> 34650 34651 Reviewed by Mark Rowe. 34652 34653 createBitmapContextFromWebView() incorrectly used #ifdef BUILDING_ON_LEOPARD, 34654 and thus failed on SnowLeopard. 34655 34656 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 34657 (createBitmapContextFromWebView): 34658 346592009-06-30 Eric Seidel <eric@webkit.org> 34660 34661 Reviewed by Nikolas Zimmermann. 34662 34663 Make bugzilla tool print a message explaining how to get help on failure: 34664 https://bugs.webkit.org/show_bug.cgi?id=26861 34665 34666 % bugzilla-tool 34667 Usage: bugzilla-tool [options] command [command-options] [command-arguments] 34668 34669 bugzilla-tool: error: No command specified 34670 34671 Type 'bugzilla-tool --help' to see usage. 34672 34673 * Scripts/bugzilla-tool: 34674 346752009-06-30 Eric Seidel <eric@webkit.org> 34676 34677 Reviewed by Maciej Stachowiak. 34678 34679 Include a built copy of BeautifulSoup 3.1.0.1 so that 34680 bugzilla-tool users do not need to install it manually. 34681 https://bugs.webkit.org/show_bug.cgi?id=26833 34682 34683 BeautifulSoup is BSD-licensed (thus WebKit compatible) and available from: 34684 http://www.crummy.com/software/BeautifulSoup 34685 34686 * Scripts/bugzilla-tool: fixed a typo in a log message. 34687 * Scripts/modules/BeautifulSoup.py: Added. 34688 * Scripts/modules/bugzilla.py: 34689 346902009-06-30 Eric Seidel <eric@webkit.org> 34691 34692 Reviewed by Simon Hausmann. 34693 34694 Fix our create_patch handling to not 34695 hang when creating large patches. 34696 https://bugs.webkit.org/show_bug.cgi?id=26834 34697 34698 We're now using StringIO to make an in-memory buffer for the patch 34699 instead of piping from the patch command directly to the upload. 34700 The previous hang was caused by calling wait() when the process had already 34701 filed the stdout buffer. 34702 34703 * Scripts/modules/scm.py: 34704 347052009-06-29 Sam Weinig <sam@webkit.org> 34706 34707 Reviewed by Mark Rowe. 34708 34709 Remove more unused scons support. 34710 34711 * Scripts/build-jsc: 34712 * Scripts/build-webkit: 34713 * Scripts/webkitdirs.pm: 34714 347152009-06-26 Eric Seidel <eric@webkit.org> 34716 34717 Reviewed by David Levin. 34718 34719 Rename land-and-update to land-diff and make it awesome. 34720 https://bugs.webkit.org/show_bug.cgi?id=26734 34721 34722 Renamed land-and-update to land-diff 34723 Made the BUGID argument optional. 34724 Added optional support for building and testing before landing. 34725 34726 land-diff [options] [BUGID] Lands the current working directory diff and updates the bug if provided. 34727 Options: 34728 -r REVIEWER, --reviewer=REVIEWER 34729 Update ChangeLogs to say Reviewed by REVIEWER. 34730 --no-close Leave bug open after landing. 34731 --no-build Commit without building first, implies --no-test. 34732 --no-test Commit without running run-webkit-tests. 34733 34734 * Scripts/bugzilla-tool: 34735 347362009-06-28 Jan Michael Alonzo <jmalonzo@webkit.org> 34737 34738 Gtk build fix - include stdarg.h for va_start/va_end. 34739 34740 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 34741 347422009-06-28 John Abd-El-Malek <jam@chromium.org> 34743 34744 https://bugs.webkit.org/show_bug.cgi?id=15457 34745 34746 Modify NPAPI test plugin to verify that "src" paramater is added when 34747 it's missing but "data" is present. 34748 34749 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 34750 (pluginLog): 34751 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: 34752 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 34753 (NPP_New): 34754 (NPP_Destroy): 34755 (NPP_SetWindow): 34756 (handleEventCarbon): 34757 (handleEventCocoa): 34758 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 34759 (NPP_New): 34760 347612009-06-27 Emilio Pozuelo Monfort <pochu27@gmail.com> 34762 34763 Reviewed by Jan Alonzo. 34764 34765 [GTK] Don't use deprecated GTK+ symbols. 34766 https://bugs.webkit.org/show_bug.cgi?id=26583 34767 34768 * GtkLauncher/main.c: 34769 (create_toolbar): 34770 347712009-06-26 Adam Barth <abarth@webkit.org> 34772 34773 Reviewed by Eric Seidel. 34774 34775 Make SVN work (again?). 34776 34777 * Scripts/modules/scm.py: 34778 347792009-06-26 Chris Fleizach <cfleizach@apple.com> 34780 34781 Reviewed by Oliver Hunt. 34782 34783 Add ability to query isEnabled 34784 34785 * DumpRenderTree/AccessibilityUIElement.cpp: 34786 (getIsEnabledCallback): 34787 (AccessibilityUIElement::getJSClass): 34788 * DumpRenderTree/AccessibilityUIElement.h: 34789 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 34790 (AccessibilityUIElement::isEnabled): 34791 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 34792 (AccessibilityUIElement::isEnabled): 34793 347942009-06-26 Brady Eidson <beidson@apple.com> 34795 34796 Reviewed by Sam Weinig 34797 34798 <rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails 34799 34800 Add a dumpResourceResponseMIMETypes() mode so the ResourceLoadDelegate will dump the mime type from 34801 the NSURLResponse. Needed for the test for this bug fix. 34802 34803 * DumpRenderTree/LayoutTestController.cpp: 34804 (LayoutTestController::LayoutTestController): 34805 (dumpResourceResponseMIMETypesCallback): 34806 (LayoutTestController::staticFunctions): 34807 * DumpRenderTree/LayoutTestController.h: 34808 (LayoutTestController::dumpResourceResponseMIMETypes): 34809 (LayoutTestController::setDumpResourceResponseMIMETypes): 34810 34811 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 34812 (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]): 34813 348142009-06-26 David Kilzer <ddkilzer@apple.com> 34815 34816 Update build-dumprendertree to use buildXCodeProject() 34817 34818 Reviewed by Adam Roben. 34819 34820 * Scripts/build-dumprendertree: Updated to use 34821 buildXCodeProject() when building for isAppleMacWebKit(). This 34822 provides additional command-line switch parsing for free. Also 34823 added --clean and --help switches. Updated copyright. 34824 348252009-06-26 Eric Seidel <eric@webkit.org> 34826 34827 Reviewed by Tor Arne Vestbø. 34828 34829 Remove non-sense --update option to land-patches 34830 and make land-patches update before every patch application. 34831 This makes it slightly less likely that multi-patch landings will fail. 34832 34833 Also updated git diff command to include staged modifications. 34834 34835 * Scripts/bugzilla-tool: 34836 * Scripts/modules/scm.py: 34837 348382009-06-25 Eric Seidel <eric@webkit.org> 34839 34840 Reviewed by Jan Alonzo. 34841 34842 Fix obsolete_attachment to work when passed a comment. 34843 https://bugs.webkit.org/show_bug.cgi?id=26745 34844 34845 * Scripts/modules/bugzilla.py: 34846 348472009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org> 34848 34849 Reviewed by Mark Rowe. 34850 34851 bugzilla-tool apply-patch throws exception in Linux 34852 https://bugs.webkit.org/show_bug.cgi?id=26738 34853 34854 HEAD is case-sensitive in Linux. Convert uses of head to HEAD in 34855 the scm module. 34856 34857 * Scripts/modules/scm.py: 34858 348592009-06-25 Eric Seidel <eric@webkit.org> 34860 34861 Reviewed by Jan Alonzo. 34862 34863 bugzilla-tool post-diff needs to obsolete old patches before posting 34864 https://bugs.webkit.org/show_bug.cgi?id=26740 34865 34866 I've also added a --no-obsolete to disable this behavior. 34867 34868 I also finally updated the bug page parsing to use XML. So much less code! 34869 34870 * Scripts/bugzilla-tool: 34871 * Scripts/modules/bugzilla.py: 34872 348732009-06-25 Eric Seidel <eric@webkit.org> 34874 34875 Reviewed by Mark Rowe. 34876 34877 Call WebKitTools/Scripts scripts by their absolute paths 34878 https://bugs.webkit.org/show_bug.cgi?id=26704 34879 34880 bugzilla-tool used to use whatever build-webkit was in your path. 34881 That could end up building the wrong copy of WebKit. 34882 34883 * Scripts/bugzilla-tool: 34884 * Scripts/modules/scm.py: 34885 348862009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 34887 34888 Reviewed by Dave Levin. 34889 34890 Use unicode() instead of str when reading from bugzilla. 34891 Also add Simon Fraser as a reviewer. 34892 https://bugs.webkit.org/show_bug.cgi?id=26719 34893 34894 * Scripts/modules/bugzilla.py: 34895 348962009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 34897 34898 Reviewed by Simon Hausmann. 34899 34900 Use Q_ASSERT in Qt's DumpRenderTree instead of JSC's ASSERT 34901 34902 The WTFReportAssertionFailure function in JSC is not exported when 34903 building QtWebKit in both debug and release on Mac, so DRT fails to 34904 link. 34905 34906 We can revert this patch once the Qt port builds JSC as a separate 34907 library, and we add the proper export macros to Assertions.cpp 34908 34909 * DumpRenderTree/qt/WorkQueue.cpp: 34910 (WorkQueue::queue): 34911 (WorkQueue::dequeue): 34912 349132009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 34914 34915 Reviewed by Jan Alonzo. 34916 34917 bugzilla-tool: Add Simon Hausmann as reviewer 34918 34919 * Scripts/modules/bugzilla.py: 34920 349212009-06-24 Eric Seidel <eric@webkit.org> 34922 34923 Reviewed by Dave Levin. 34924 34925 Support local commits during apply-patches 34926 and let land-patches take multiple bug ids. 34927 https://bugs.webkit.org/show_bug.cgi?id=26703 34928 34929 I also restructured parts of land-patches into 34930 class methods and static methods in preparation 34931 for future code sharing with other commands. 34932 34933 * Scripts/bugzilla-tool: 34934 * Scripts/modules/bugzilla.py: 34935 * Scripts/modules/scm.py: 34936 349372009-06-25 Eric Seidel <eric@webkit.org> 34938 34939 Reviewed by Tor Arne Vestbø. 34940 34941 Make svn-apply work with Git too 34942 https://bugs.webkit.org/show_bug.cgi?id=26299 34943 34944 Add an --force option to svn-apply and otherwise make svn-apply 34945 exit non-zero when patch application fails. 34946 https://bugs.webkit.org/show_bug.cgi?id=26300 34947 34948 I did not update svn-unapply, because it makes no sense in a Git world. 34949 You don't roll in and out patch files. You make commits and deal with those. 34950 Git users can just git reset --hard to get the same functionality. 34951 34952 * Scripts/svn-apply: 34953 349542009-06-25 Eric Seidel <eric@webkit.org> 34955 34956 Reviewed by Tor Arne Vestbø. 34957 34958 Remove use of os.system to fix reviewers with unicode chars in their names 34959 https://bugs.webkit.org/show_bug.cgi?id=26713 34960 34961 Also change to latin1 encoding of ø to make python happy. 34962 34963 * Scripts/modules/bugzilla.py: 34964 * Scripts/modules/scm.py: 34965 349662009-06-25 Eric Seidel <eric@webkit.org> 34967 34968 Reviewed by Tor Arne Vestbø. 34969 34970 Add Adam Roben and Tor Arne Vestbø to the reviewers list. 34971 34972 * Scripts/modules/bugzilla.py: 34973 349742009-06-24 Chris Fleizach <cfleizach@apple.com> 34975 34976 Windows build fix. 34977 34978 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 34979 (AccessibilityUIElement::language): 34980 349812009-06-24 Chris Fleizach <cfleizach@apple.com> 34982 34983 Reviewed by Oliver Hunt. 34984 34985 Bug 26668: AX: need a way to retrieve the language for an element 34986 Support ability to retrieve AXLanguage for testing 34987 34988 * DumpRenderTree/AccessibilityUIElement.cpp: 34989 (getLanguageCallback): 34990 (AccessibilityUIElement::getJSClass): 34991 * DumpRenderTree/AccessibilityUIElement.h: 34992 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 34993 (AccessibilityUIElement::language): 34994 349952009-06-24 Eric Seidel <eric@webkit.org> 34996 34997 Reviewed by Maciej Stachowiak. 34998 34999 Spell Maciej's name right and add Brady Eidson. 35000 35001 * Scripts/modules/bugzilla.py: 35002 350032009-06-23 Eric Seidel <eric@webkit.org> 35004 35005 Reviewed by Dave Levin. 35006 35007 Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run 35008 https://bugs.webkit.org/show_bug.cgi?id=26669 35009 35010 * Scripts/bugzilla-tool: 35011 * Scripts/modules/scm.py: 35012 350132009-06-23 Takeshi Yoshino <tyoshino@google.com> 35014 35015 Reviewed by Mark Rowe. 35016 35017 Bug 26537: Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists 35018 https://bugs.webkit.org/show_bug.cgi?id=26537 35019 35020 Let determineBaseProductDir subroutine remove 35021 ~/Library/Preferences/xcodebuild.plist. It can prevent xcodebuild from 35022 respecting global settings such as a custom build products directory 35023 (<rdar://problem/5585899>). 35024 35025 * Scripts/webkitdirs.pm: 35026 350272009-06-23 Eric Seidel <eric@webkit.org> 35028 35029 Reviewed by Dave Levin. 35030 35031 Make SCM.run_command smarter, and make all previous 35032 os.system and subprocess.popen use SCM.run_command instead. 35033 https://bugs.webkit.org/show_bug.cgi?id=26666 35034 35035 This makes it easier to handle errors in a standard way throughout all the code. 35036 Since this new code raises by default when the exit_code != 0, 35037 we should prevent future problems of bugzilla-tool continuing after 35038 a git or svn command failed. 35039 35040 * Scripts/modules/scm.py: 35041 350422009-06-23 Joe Mason <joe.mason@torchmobile.com> 35043 35044 Reviewed by Adam Treat. 35045 35046 https://bugs.webkit.org/show_bug.cgi?id=26664 35047 * Scripts/prepare-ChangeLog: Added --git-index mode to list only the 35048 changes which are already staged in the index. Useful to create an 35049 entry for what you're about to commit while ignoring unstaged changes. 35050 350512009-06-23 Anders Carlsson <andersca@apple.com> 35052 35053 Reviewed by Darin Adler. 35054 35055 Update for WebKit changes. 35056 35057 * DumpRenderTree/win/UIDelegate.h: 35058 (UIDelegate::willPerformDragSourceAction): 35059 350602009-06-23 Eric Seidel <eric@webkit.org> 35061 35062 Reviewed by Mark Rowe. 35063 35064 * Scripts/modules/scm.py: Fix commit_with_message to return the commit output. 35065 350662009-06-23 Eric Seidel <eric@webkit.org> 35067 35068 Reviewed by Mark Rowe. 35069 35070 * Scripts/modules/scm.py: Fix error seen when commiting r44979. 35071 350722009-06-18 Eric Seidel <eric@webkit.org> 35073 35074 Reviewed by Dave Levin. 35075 35076 WebKit needs a script to interact with bugzilla and automate 35077 parts of the patch posting and commit processes. 35078 https://bugs.webkit.org/show_bug.cgi?id=26283 35079 35080 This is really a first-draft tool. 35081 It's to the point where it's useful to more people than just me now though. 35082 Git support works. SVN support is written, but mostly untested. 35083 35084 This tool requires BeautifulSoup and mechanize python modules to run: 35085 sudo easy_install BeautifulSoup 35086 sudo easy_install mechanize 35087 35088 More important than the tool itself are the Bugzilla, Git and SVN class abstractions 35089 which I hope will allow easy writing of future tools. 35090 35091 The tool currently implements 10 commands, described below. 35092 35093 Helpers for scripting dealing with the commit queue: 35094 bugs-to-commit Bugs in the commit queue 35095 patches-to-commit Patches attached to bugs in the commit queue 35096 35097 Dealing with bugzilla: 35098 reviewed-patches BUGID r+'d patches on a bug 35099 apply-patches BUGID Applies all patches on a bug to the local working directory without committing. 35100 land-and-update BUGID Lands the current working directory diff and updates the bug. 35101 land-patches [options] BUGID Lands all patches on a bug optionally testing them first 35102 obsolete-attachments BUGID Marks all attachments on a bug as obsolete. 35103 commit-message Prints a commit message suitable for the uncommitted changes. 35104 35105 These effectively replace git-send-bugzilla: 35106 post-diff BUGID Attaches the current working directory diff to a bug as a patch file. 35107 post-commits BUGID COMMITISH Attaches a range of local commits to a bug as patch files. 35108 35109 post-diff works for SVN and Git, post-commits only works for SCMs with local-commit support (like Git) 35110 35111 land-* commands in a Git environment only work with simple patches due to svn-apply bugs: 35112 https://bugs.webkit.org/show_bug.cgi?id=26299 35113 https://bugs.webkit.org/show_bug.cgi?id=26300 35114 35115 This script follows python style (similar to how for Obj-C we follow AppKit style) 35116 http://www.python.org/doc/essays/styleguide.html 35117 The Python community has a strong style culture and the WebKit style guide is silent re: Python. 35118 35119 I've filed a bug to update the WebKit style guide to mention python: 35120 https://bugs.webkit.org/show_bug.cgi?id=26524 35121 35122 * Scripts/bugzilla-tool: Added. 35123 351242009-06-22 Steve Falkenburg <sfalken@apple.com> 35125 35126 Remove errant line of code mistakenly checked in. 35127 35128 * DumpRenderTree/win/DumpRenderTree.cpp: 35129 (main): 35130 351312009-06-22 Steve Falkenburg <sfalken@apple.com> 35132 35133 Pass correct value to setShouldPaintNativeControls. 35134 35135 Rubber stamped by Mark Rowe. 35136 35137 * DumpRenderTree/win/DumpRenderTree.cpp: 35138 (main): 35139 351402009-06-22 Steve Falkenburg <sfalken@apple.com> 35141 35142 Fix last DumpRenderTree change to correctly set preferences flag without crashing. 35143 35144 Reviewed by Mark Rowe. 35145 35146 * DumpRenderTree/win/DumpRenderTree.cpp: 35147 (main): 35148 351492009-06-21 Steve Falkenburg <sfalken@apple.com> 35150 35151 Set up global native controls flag before creating the first WebView. 35152 35153 Reviewed by Darin Adler. 35154 35155 * DumpRenderTree/win/DumpRenderTree.cpp: 35156 (main): 35157 351582009-06-21 Mark Rowe <mrowe@apple.com> 35159 35160 Reviewed by Sam Weinig. 35161 35162 Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates). 35163 35164 * WebKitLauncher/WebKitNightlyEnablerSparkle.m: 35165 (userAgentStringForSparkle): 35166 (initializeSparkle): 35167 351682009-06-21 Mark Rowe <mrowe@apple.com> 35169 35170 Reviewed by Sam Weinig. 35171 35172 Add a hook to the WebKit launcher application to allow a link on the nightly build start page to 35173 trigger an update via the built-in software update mechanism. 35174 35175 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: 35176 * WebKitLauncher/WebKitLauncherURLProtocol.h: Added. 35177 * WebKitLauncher/WebKitLauncherURLProtocol.m: Added. 35178 (+[WebKitLauncherURLProtocol load]): 35179 (+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains. 35180 (+[WebKitLauncherURLProtocol canonicalRequestForRequest:]): 35181 (-[WebKitLauncherURLProtocol startLoading]): 35182 (-[WebKitLauncherURLProtocol stopLoading]): 35183 (-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically 35184 determine whether the x-webkit-launcher is available and working. 35185 (-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread. 35186 (-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error. 35187 351882009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org> 35189 35190 Reviewed by Gustavo Noronha and Xan Lopez. 35191 35192 [Gtk] Implement DRT XSS auditor support 35193 https://bugs.webkit.org/show_bug.cgi?id=26571 35194 35195 * DumpRenderTree/gtk/DumpRenderTree.cpp: 35196 (resetWebViewToConsistentStateBeforeTesting): 35197 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 35198 (LayoutTestController::setXSSAuditorEnabled): 35199 352002009-06-19 Darin Adler <darin@apple.com> 35201 35202 * Scripts/do-webcore-rename: More renaming ideas. 35203 352042009-06-15 Andre Pedralho <andre.pedralho@openbossa.org> 35205 35206 Reviewed by Tor Arne Vestbø. 35207 35208 Only pass --makeargs along if an argument is given. 35209 35210 * Scripts/build-webkit: 35211 352122009-06-19 Adam Barth <abarth@webkit.org> 35213 35214 Unreviewed attempt to fix Windows build. 35215 35216 * DumpRenderTree/win/DumpRenderTree.cpp: 35217 (resetWebViewToConsistentStateBeforeTesting): 35218 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 35219 (LayoutTestController::setXSSAuditorEnabled): 35220 352212009-06-18 Adam Barth <abarth@webkit.org> 35222 35223 Reviewed by Sam Weinig. 35224 35225 https://bugs.webkit.org/show_bug.cgi?id=26199 35226 35227 Add support for testing the XSSAuditor. 35228 35229 * DumpRenderTree/LayoutTestController.cpp: 35230 (setXSSAuditorEnabledCallback): 35231 (LayoutTestController::staticFunctions): 35232 * DumpRenderTree/LayoutTestController.h: 35233 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 35234 (LayoutTestController::setXSSAuditorEnabled): 35235 * DumpRenderTree/mac/DumpRenderTree.mm: 35236 (resetWebViewToConsistentStateBeforeTesting): 35237 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 35238 (LayoutTestController::setXSSAuditorEnabled): 35239 * DumpRenderTree/win/DumpRenderTree.cpp: 35240 (resetWebViewToConsistentStateBeforeTesting): 35241 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 35242 (LayoutTestController::setXSSAuditorEnabled): 35243 (LayoutTestController::setPopupBlockingEnabled): 35244 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 35245 (LayoutTestController::setXSSAuditorEnabled): 35246 352472009-06-18 Darin Adler <darin@apple.com> 35248 35249 Rubber stamped by Mark Rowe. 35250 35251 * DumpRenderTree/mac/DumpRenderTreeWindow.mm: 35252 (-[DumpRenderTreeWindow close]): Resolved crashes seen during regression 35253 tests. The close method can be called on a window that's already closed 35254 so we can't assert here. 35255 352562009-06-17 Steve Falkenburg <sfalken@apple.com> 35257 35258 Updated for consolidated WebKit COM interfaces. 35259 35260 Reviewed by Adam Roben. 35261 35262 * DumpRenderTree/win/FrameLoadDelegate.cpp: 35263 * DumpRenderTree/win/FrameLoadDelegate.h: 35264 * DumpRenderTree/win/UIDelegate.cpp: 35265 * DumpRenderTree/win/UIDelegate.h: 35266 * WinLauncher/WinLauncher.h: 35267 352682009-06-16 Adam Barth <abarth@webkit.org> 35269 35270 Reviewed by Darin Adler. 35271 35272 https://bugs.webkit.org/show_bug.cgi?id=26437 35273 35274 Make the commit-log-editor match the ambient line endings in commit 35275 messages. 35276 35277 * Scripts/commit-log-editor: 35278 352792009-06-16 Xan Lopez <xlopez@igalia.com> 35280 35281 Reviewed by Gustavo Noronha. 35282 35283 Update GtkLauncher to recent API changes in the progress property, 35284 which now goes from 0.0 to 1.0. 35285 35286 * GtkLauncher/main.c: 35287 352882009-06-16 Adam Barth <abarth@webkit.org> 35289 35290 Reviewed by Darin Adler. 35291 35292 https://bugs.webkit.org/show_bug.cgi?id=26000 35293 35294 Teach prepare-ChangeLog to match the line ends that are already present 35295 in ChangeLog files. This helps folks whose use cygwin perl with CR LF 35296 line endings on Windows. 35297 35298 Also, teach prepare-ChangeLog to normalize backslashes in paths. This 35299 helps folks who use Windows SVN prepare correct ChangeLogs. 35300 35301 * Scripts/prepare-ChangeLog: 35302 35303== Rolled over to ChangeLog-2009-06-16 == 35304
