12011-02-16 Anders Carlsson <andersca@apple.com> 2 3 Reviewed by Adam Roben. 4 5 Assertion failure in DrawingAreaImpl::display when calling WKPageForceRepaint on a page that uses accelerated compositing 6 https://bugs.webkit.org/show_bug.cgi?id=54575 7 <rdar://problem/8979594> 8 9 Add test. 10 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 11 * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp: Added. 12 (TestWebKitAPI::didForceRepaint): 13 (TestWebKitAPI::didFinishLoadForFrame): 14 (TestWebKitAPI::TEST): 15 * TestWebKitAPI/Tests/WebKit2/simple-accelerated-compositing.html: Added. 16 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 17 * TestWebKitAPI/win/copy-resources.cmd: 18 192011-02-16 Sergio Villar Senin <svillar@igalia.com> 20 21 Reviewed by Martin Robinson. 22 23 [Gtk] Add support for layoutTestController.setWillSendRequestClearHeader 24 https://bugs.webkit.org/show_bug.cgi?id=54537 25 26 Added handler for resource-request-starting emitted in 27 FrameLoader's willSendRequest(). The current implementation 28 removes the headers set in setWillSendRequestClearHeader. 29 30 * DumpRenderTree/gtk/DumpRenderTree.cpp: 31 (willSendRequestCallback): 32 (createWebView): 33 342011-02-16 Csaba Osztrogonác <ossy@webkit.org> 35 36 Reviewed by Andreas Kling. 37 38 [Qt] Qt build system can't handle removing headers from tree 39 https://bugs.webkit.org/show_bug.cgi?id=54466 40 41 * Scripts/build-webkit: Remove Qt makefiles from productDir before build. 42 432011-02-16 Ilya Tikhonovsky <loislo@chromium.org> 44 45 Reviewed by Yury Semikhatsky. 46 47 Web Inspector: chromium: DRT is crashing on the tests in inspector-enabled folder. 48 https://bugs.webkit.org/show_bug.cgi?id=54548 49 50 * DumpRenderTree/chromium/TestShell.cpp: 51 (TestShell::runFileTest): 52 532011-02-16 Sheriff Bot <webkit.review.bot@gmail.com> 54 55 Unreviewed, rolling out r77898. 56 http://trac.webkit.org/changeset/77898 57 https://bugs.webkit.org/show_bug.cgi?id=54541 58 59 Leopard Debug hasn't compiled for a long time (Requested by 60 abarth on #webkit). 61 62 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 63 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 64 652011-02-15 Xianzhu Wang <wangxianzhu@google.com> 66 67 Reviewed by Kent Tamura. 68 69 Fixed a small bug about --no-timeout option. 70 https://bugs.webkit.org/show_bug.cgi?id=52873 71 72 * DumpRenderTree/chromium/DumpRenderTree.cpp: 73 (main): 74 752011-02-15 Kenneth Russell <kbr@google.com> 76 77 Reviewed by Darin Fisher. 78 79 Allow controlling minimum DOMTimer interval on a per-page basis 80 https://bugs.webkit.org/show_bug.cgi?id=54312 81 82 Implemented new method setMinimumTimerInterval in 83 LayoutTestController for all ports. 84 85 * DumpRenderTree/LayoutTestController.cpp: 86 (setMinimumTimerIntervalCallback): 87 (LayoutTestController::staticFunctions): 88 * DumpRenderTree/LayoutTestController.h: 89 * DumpRenderTree/chromium/LayoutTestController.cpp: 90 (LayoutTestController::LayoutTestController): 91 (LayoutTestController::setMinimumTimerInterval): 92 * DumpRenderTree/chromium/LayoutTestController.h: 93 * DumpRenderTree/chromium/WebViewHost.cpp: 94 (WebViewHost::reset): 95 * DumpRenderTree/gtk/DumpRenderTree.cpp: 96 (resetDefaultsToConsistentValues): 97 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 98 (LayoutTestController::setMinimumTimerInterval): 99 * DumpRenderTree/mac/DumpRenderTree.mm: 100 (resetWebViewToConsistentStateBeforeTesting): 101 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 102 (LayoutTestController::setMinimumTimerInterval): 103 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 104 (WebCore::WebPage::resetSettings): 105 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 106 (LayoutTestController::setMinimumTimerInterval): 107 * DumpRenderTree/qt/LayoutTestControllerQt.h: 108 * DumpRenderTree/win/DumpRenderTree.cpp: 109 (resetWebViewToConsistentStateBeforeTesting): 110 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 111 (LayoutTestController::setMinimumTimerInterval): 112 1132011-02-15 Martin Robinson <mrobinson@igalia.com> 114 115 Reviewed by Xan Lopez. 116 117 [Freetype] Better map CSS font weight to Fontconfig font weight 118 https://bugs.webkit.org/show_bug.cgi?id=54323 119 120 Add the WeightWatcher fonts to the list of sourced fonts when intializing 121 DRT. This will allow us to pass tests that use WeightWatcher. 122 123 * DumpRenderTree/gtk/DumpRenderTree.cpp: 124 (initializeFonts): Source the WebkitWeightWatcher fonts. 125 1262011-02-15 Dirk Pranke <dpranke@chromium.org> 127 128 Reviewed by Tony Chang. 129 130 Make new-run-webkit-tests --processes work under Windows' weird 131 multiprocessing model. This requires us to be running a Python 132 file that can be imported as a module, so I've modified the 133 new-run-webkit-tests script to spawn a subprocess runing 134 webkitpy.layout_tests.run_webkit_tests.py. I've also modified 135 the manager_worker_broker tests because you can't pickle a 136 nested class. This requires us to use globals to pass queues 137 back and forth for testing, but the alternative is to pass extra 138 arguments to start_worker() and that feels like a bad tradeoff 139 just for testing. 140 141 https://bugs.webkit.org/show_bug.cgi?id=54431 142 143 * Scripts/new-run-webkit-tests: 144 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: 145 1462011-02-15 Brady Eidson <beidson@apple.com> 147 148 Reviewed by Darin Adler. 149 150 <rdar://problem/9002047> and https://bugs.webkit.org/show_bug.cgi?id=54426 151 WebFrameLoaderClient::shouldGoToHistoryItem needs implementation 152 153 Add dummy implementations to keep our tools building. 154 155 * MiniBrowser/mac/BrowserWindowController.m: 156 (-[BrowserWindowController awakeFromNib]): 157 158 * WebKitTestRunner/TestController.cpp: 159 (WTR::TestController::initialize): 160 1612011-02-15 David Levin <levin@chromium.org> 162 163 Reviewed by Shinichiro Hamaji. 164 165 check-webkit-style should do some detection for valid uses of WEBKIT_API (in chromium public api). 166 https://bugs.webkit.org/show_bug.cgi?id=52271 167 168 * Scripts/webkitpy/style/checkers/cpp.py: Added the check for WEBKIT_API usage. 169 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests. 170 1712011-02-14 Dirk Pranke <dpranke@chromium.org> 172 173 Unreviewed, build fix. 174 175 Fix minor regression introduced in r78522. For some reason, Python 176 provides a platform.mac_ver() routine on Linux, so we need to 177 check to make sure it's returning something in addition to 178 checking for its existence. 179 180 * Scripts/webkitpy/layout_tests/port/mac.py: 181 1822011-02-14 Dirk Pranke <dpranke@chromium.org> 183 184 Reviewed by Mihai Parparita. 185 186 Clean up the way we handle platform names in 187 new-run-webkit-tests. Previously, if you specified 188 '--platform mac' or '--platform chromium-mac' on the command 189 line, it would use that platform name to determine baseline search 190 paths, etc. This is almost never the right thing to do, because 191 it ignores the existence of version-specific baselines. 192 193 So, I changed this so that ports that support versions must 194 always use a version, and the version should default to the 195 version of the operating system that the port is being run on 196 (e.g., if you're running on Leopard, then passing '--platform 197 mac' will default to the 'mac-leopard' port). This means that 198 port.name() should always include a version-specific suffix if 199 the port supports versions. 200 201 However, we still support things like '--platform mac' as input 202 so that the user doesn't have to explicitly specify a version, 203 both for convenience and so we don't have to make buildbot 204 configs more complicated than they already are. 205 206 Also, I cleaned up how the baselines were being searched 207 on the chromium-mac port (this is one of the two bugs that 208 prompted this refactoring), and made the logic easier to follow 209 and more consistent across the mac and chromium ports 210 211 Lastly, I added a port.get_all_names() method that could be used 212 to get the names of all of the ports to search, rather than having 213 to guess (incorrectly) from the list of directories under 214 LayoutTests/platform (this last thing was necessary because the 215 deduplicate_tests unittest broke as the fallback dirs changed). 216 217 https://bugs.webkit.org/show_bug.cgi?id=54248 218 219 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: 220 * Scripts/webkitpy/layout_tests/port/factory.py: 221 * Scripts/webkitpy/layout_tests/port/factory_unittest.py: 222 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 223 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 224 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: 225 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 226 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 227 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 228 * Scripts/webkitpy/layout_tests/port/mac.py: 229 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 230 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 231 2322011-02-14 Dirk Pranke <dpranke@chromium.org> 233 234 Reviewed by Adam Barth. 235 236 update-webkit hangs in a git-only checkout 237 238 Previously it would hang forever trying to do a 'git svn 239 rebase'. Now, it will default to a 'git pull' if the 240 svn-remote.svn.fetch variable isn't set, and bail out if it 241 doesn't know where to pull from. 242 243 https://bugs.webkit.org/show_bug.cgi?id=54265 244 245 * Scripts/update-webkit: 246 * Scripts/VCSUtils.pm: 247 2482011-02-14 Dirk Pranke <dpranke@chromium.org> 249 250 Reviewed by Mihai Parparita. 251 252 This patch modifies NRWT's Worker clas to use the new 253 WorkerMixin class to actually run tests. With this patch, the 254 multiprocess version of NRWT is fully functional and just needs 255 the values for --worker-model and --child-processes to be corrected 256 in the port/* classes to start using the new code by default. 257 258 https://bugs.webkit.org/show_bug.cgi?id=54082 259 260 * Scripts/webkitpy/layout_tests/layout_package/worker.py: 261 2622011-02-14 Dirk Pranke <dpranke@chromium.org> 263 264 Reviewed by Mihai Parparita. 265 266 This patch shuffles code out of dump_render_tree_thread and 267 single_test_runner and into a new worker_mixin class that will 268 be shared by both TestShellThread and Worker. This change 269 restores single_test_runner to its state as of r77606 - it is 270 stateless again. It also prunes TestShellThread to pretty much 271 just the logic used for the original shared-memory access. 272 273 https://bugs.webkit.org/show_bug.cgi?id=54079 274 275 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 276 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: 277 * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Added. 278 2792011-02-14 Dirk Pranke <dpranke@chromium.org> 280 281 Reviewed by Ojan Vafai. 282 283 This patch updates NRWT to add per-worker and per-shard test stats 284 into TestRunner2, bringing it to parity with TestRunner. 285 286 https://bugs.webkit.org/show_bug.cgi?id=54074 287 288 * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: 289 2902011-02-14 Dirk Pranke <dpranke@chromium.org> 291 292 Reviewed by Tony Chang. 293 294 nrwt multiprocessing: add code to handle interrupts and wedged 295 threads. 296 https://bugs.webkit.org/show_bug.cgi?id=54072 297 298 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: 299 Adds the cancel(), is_alive(), join(), and log_wedged_worker() 300 methods to the WorkerConnection class 301 302 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: 303 * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: 304 * Scripts/webkitpy/layout_tests/layout_package/worker.py: 305 Adds the cancel() method to the Worker class 306 3072011-02-14 Dirk Pranke <dpranke@chromium.org> 308 309 Reviewed by Tony Chang. 310 311 update the NRWT multiprocessing code to spawn multiple workers 312 instead of just using one. 313 314 https://bugs.webkit.org/show_bug.cgi?id=54071 315 316 * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: 317 3182011-02-12 Chang Shu <cshu@webkit.org> 319 320 Unreviewed. 321 322 Update my own email addresses and IRC nickname. 323 324 * Scripts/webkitpy/common/config/committers.py: 325 3262011-02-11 Dirk Pranke <dpranke@chromium.org> 327 328 Reviewed by Tony Chang. 329 330 This patch adds to NRWT most of the support needed to run the new 331 message-based workers in separate threads or processes. The code 332 isn't fully complete yet because we don't support cancel() or 333 is_alive(). 334 335 https://bugs.webkit.org/show_bug.cgi?id=54070 336 337 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: 338 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: 339 * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: 340 * Scripts/webkitpy/layout_tests/port/base.py: 341 * Scripts/webkitpy/layout_tests/port/mock_drt.py: 342 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 343 3442011-02-11 Sailesh Agrawal <sail@chromium.org> 345 346 Reviewed by Kenneth Russell. 347 348 plugins/invalidate_rect.html fails on chromium-mac 349 https://bugs.webkit.org/show_bug.cgi?id=54051 350 351 This change fixes the invalidate_rect.html test failure on Windows. 352 353 There were two problems. First, the test specified that the plugin was window less by doing <embed ... windowedPlugin="false"></embed>. The windowedPlugin parameter was never being read by the plugin. Fix was to simply set the NPPVpluginWindowBool variable based on the parameter. 354 355 The second problem was that the plugin never handled paint events on Windows. Fix was to simply copy the Mac code to handle paint events. 356 357 This change also updates the build path in chromium_win.py to use the new Source directory. 358 359 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 360 (invalidateRect): 361 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 362 (NPP_New): 363 (handleEventWin): 364 (NPP_HandleEvent): 365 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 366 3672011-02-11 Csaba Osztrogonác <ossy@webkit.org> 368 369 Reviewed by Andreas Kling. 370 371 [Qt] Increase the timeout of Qt API tests to 120 seconds. 372 373 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 374 3752011-02-10 Zhenyao Mo <zmo@google.com> 376 377 Unreviewed, build fix. 378 379 * DumpRenderTree/DumpRenderTree.gypi: 380 3812011-02-10 Dirk Pranke <dpranke@chromium.org> 382 383 Reviewed by Tony Chang. 384 385 This patch adds the bulk of the remaining functionality for 386 the NRWT message-passing implementation. The patch adds a new 387 Worker class that will eventually replace the TestShellThread 388 class in dump_render_tree_thread.py, and implements enough of 389 TestRunner2 and the inline version of the manager_worker_broker 390 to actually be able to send a full set of messages back and 391 forth. The Worker stubs do not actually run tests, and there's 392 lots of error handling and stats needed, but this is the core 393 logic. 394 395 https://bugs.webkit.org/show_bug.cgi?id=54068 396 397 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: 398 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: 399 * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: 400 * Scripts/webkitpy/layout_tests/layout_package/worker.py: Added. 401 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 402 4032011-02-10 Zhenyao Mo <zmo@google.com> 404 405 Unreviewed, build fix. 406 407 * DumpRenderTree/DumpRenderTree.gypi: 408 4092011-02-10 Zhenyao Mo <zmo@google.com> 410 411 Unreviewed, build fix. 412 413 * DumpRenderTree/DumpRenderTree.gypi: 414 4152011-02-10 Zhenyao Mo <zmo@google.com> 416 417 Unreviewed, attempt to fix crashing plugin tests. 418 419 * DumpRenderTree/DumpRenderTree.gypi: 420 4212011-02-10 Zhenyao Mo <zmo@google.com> 422 423 Unreviewed, build fix. 424 425 * DumpRenderTree/DumpRenderTree.gypi: 426 4272011-02-10 Sam Weinig <sam@webkit.org> 428 429 Try and fix some crashing tests on the chromium build bot. 430 431 * DumpRenderTree/DumpRenderTree.gypi: 432 4332011-02-10 Anders Carlsson <andersca@apple.com> 434 435 Reviewed by Sam Weinig. 436 437 Log an error if a plug-in test can't be found 438 https://bugs.webkit.org/show_bug.cgi?id=54252 439 440 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 441 (PluginTest::create): 442 Return null if the test wasn't found. 443 444 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 445 (NPP_New): 446 Report an error if PluginTest::create returns null. 447 4482011-02-10 Robert Hogan <robert@webkit.org> 449 450 Reviewed by Laszlo Gombos. 451 452 [Qt] Return menu items from eventSender.contextMenu() 453 https://bugs.webkit.org/show_bug.cgi?id=53039 454 455 * DumpRenderTree/qt/EventSenderQt.cpp: 456 (EventSender::contextClick): 457 * DumpRenderTree/qt/EventSenderQt.h: 458 4592011-02-10 Adam Roben <aroben@apple.com> 460 461 Test showing and hiding the find indicator on Windows 462 463 Test for <http://webkit.org/b/54213> <rdar://problem/8983261> REGRESSION (r78198): Crash in 464 FindIndicator::contentImage when scrolling page 465 466 Reviewed by Steve Falkenburg. 467 468 * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added. 469 (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished. 470 (TestWebKitAPI::findIndicatorCallback): Record that the callback was called, and save the 471 bitmap. 472 (TestWebKitAPI::initialize): Hook up our callbacks. 473 (TestWebKitAPI::TEST): Test showing then hiding the find indicator to see if we crash. 474 475 * TestWebKitAPI/PlatformWebView.h: 476 * TestWebKitAPI/mac/PlatformWebViewMac.mm: 477 (TestWebKitAPI::PlatformWebView::page): 478 * TestWebKitAPI/win/PlatformWebViewWin.cpp: 479 (TestWebKitAPI::PlatformWebView::page): 480 Made page a const member function. 481 482 * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test. 483 4842011-02-10 Mario Sanchez Prada <msanchez@igalia.com> 485 486 Reviewed by Martin Robinson. 487 488 [GTK] Log signals from AtkDocument interface also in AccessibilityController 489 https://bugs.webkit.org/show_bug.cgi?id=54198 490 491 Trace AtkDocument's signals emission through AccessibilityController. 492 493 Also, taken the code related to adding and removing global 494 listeners for ATK signals out to a separate file, for the sake of 495 clarity and to ease future additions. 496 497 * DumpRenderTree/gtk/AccessibilityCallbacks.h: Added. 498 * DumpRenderTree/gtk/AccessibilityCallbacks.cpp: Added 499 (printAccessibilityEvent): Print information about an event. 500 (axObjectEventListener): Global listener for AtkObject's signals. 501 (axDocumentEventListener): Global listener for AtkDocument's signals. 502 (connectAccessibilityCallbacks): Connect all global listeners. 503 (disconnectAccessibilityCallbacks): Disconnect all global listeners. 504 505 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 506 (AccessibilityController::setLogAccessibilityEvents): Call to 507 connectAccessibilityCallbacks and disconnectAccessibilityCallbacks. 508 509 * GNUmakefile.am: Added new files. 510 5112011-02-09 Martin Robinson <mrobinson@igalia.com> 512 513 Reviewed by Gustavo Noronha Silva. 514 515 [GTK] Default error page is interfering with tests which require failed loads 516 https://bugs.webkit.org/show_bug.cgi?id=54157 517 518 Disable the default error page during DRT runs. This prevents unexpected loads 519 from interfering with tests that have planned failed loads. 520 521 * DumpRenderTree/gtk/DumpRenderTree.cpp: 522 (webViewLoadError): Added, disable default handler. 523 (createWebView): Connect the new load-error handler. 524 5252011-02-10 Zoltan Horvath <zoltan@webkit.org> 526 527 Reviewed by Andreas Kling. 528 529 [Qt] Add UrlLoader and command line argument handling to MiniBrowser 530 https://bugs.webkit.org/show_bug.cgi?id=54192 531 532 Copy and modify files from QtTestBrowser's implementation. 533 534 * MiniBrowser/qt/BrowserWindow.cpp: 535 (BrowserWindow::BrowserWindow): 536 (BrowserWindow::newWindow): 537 * MiniBrowser/qt/BrowserWindow.h: 538 * MiniBrowser/qt/MiniBrowser.pro: 539 * MiniBrowser/qt/MiniBrowserApplication.cpp: Copied from QtTestBrowser/launcherwindow.cpp 540 (MiniBrowserApplication::MiniBrowserApplication): 541 (MiniBrowserApplication::handleUserOptions): 542 * MiniBrowser/qt/MiniBrowserApplication.h: Copied from QtTestBrowser/launcherwindow.h 543 (WindowOptions::WindowOptions): 544 (MiniBrowserApplication::urls): 545 (MiniBrowserApplication::isRobotized): 546 (MiniBrowserApplication::robotTimeout): 547 (MiniBrowserApplication::robotExtraTime): 548 * MiniBrowser/qt/UrlLoader.cpp: Copied from QtTestBrowser/urlloader.cpp 549 (UrlLoader::UrlLoader): 550 (UrlLoader::loadNext): 551 (UrlLoader::checkIfFinished): 552 (UrlLoader::frameLoadStarted): 553 (UrlLoader::frameLoadFinished): 554 (UrlLoader::loadUrlList): 555 (UrlLoader::getUrl): 556 * MiniBrowser/qt/UrlLoader.h: Copied from QtTestBrowser/urlloader.h 557 * MiniBrowser/qt/main.cpp: 558 (main): 559 * MiniBrowser/qt/utils.cpp: Copied from QtTestBrowser/utils.cpp 560 (takeOptionValue): 561 (formatKeys): 562 (enumToKeys): 563 (appQuit): 564 (urlFromUserInput): 565 * MiniBrowser/qt/utils.h: Copied from QtTestBrowser/utils.h 566 5672011-02-10 Zoltan Horvath <zoltan@webkit.org> 568 569 Reviewed by Andreas Kling. 570 571 check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt 572 https://bugs.webkit.org/show_bug.cgi?id=54200 573 574 * Scripts/webkitpy/style/checker.py: 575 * Scripts/webkitpy/style/checker_unittest.py: 576 5772011-02-10 Peter Varga <pvarga@webkit.org> 578 579 Reviewed by Csaba Osztrogonác. 580 581 Remove PCRE source from trunk 582 https://bugs.webkit.org/show_bug.cgi?id=54188 583 584 * wx/build/settings.py: 585 5862011-02-10 David Levin <levin@chromium.org> 587 588 Reviewed by Shinichiro Hamaji. 589 590 check-webkit-style should be able to figure out function modifiers and return type. 591 https://bugs.webkit.org/show_bug.cgi?id=54124 592 593 * Scripts/webkitpy/style/checkers/cpp.py: 594 (_rfind_in_lines): A way to search backwards in lines. 595 (_FunctionState.modifiers_and_return_type): 596 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for the new functionality. 597 5982011-02-09 Adam Roben <aroben@apple.com> 599 600 Test that WM_PRINT doesn't trigger an assertion 601 602 Test for <http://webkit.org/b/54145> <rdar://problem/8979559> WM_PRINT doesn't work with new 603 drawing area (assertion failure in DrawingAreaProxyImpl in Debug builds) 604 605 Reviewed by Darin Adler. 606 607 * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Added. 608 (TestWebKitAPI::TEST): Send a WM_PRINT message to a WKView. 609 6102011-02-09 Adam Roben <aroben@apple.com> 611 612 Test that having a WKView paint after being resized while hidden doesn't cause a crash 613 614 Test for <http://webkit.org/b/54142> <rdar://problem/8979365> Crash in 615 DrawingAreaProxyImpl::paint when WKView paints after being resized while hidden 616 617 Reviewed by Darin Adler. 618 619 * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: 620 (TestWebKitAPI::TEST): Force the WKView to paint after resizing it while hidden. 621 6222011-02-09 Adam Roben <aroben@apple.com> 623 624 Add a test that resizes a WKView while it's hidden 625 626 Test for <http://webkit.org/b/54141> <rdar://problem/8979195> WKView draws at wrong size, 627 performs badly if is resized while hidden (assertion fails in 628 BackingStore::incorporateUpdate in Debug builds) 629 630 Reviewed by Darin Adler. 631 632 * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Added. 633 (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished. 634 (TestWebKitAPI::setPageLoaderClient): Hook up our didFinishLoadForFrame callback. 635 (TestWebKitAPI::flushMessages): Load a URL and wait for the load to complete. This ensures 636 that all pending messages have been handled by the UI and web process. 637 (TestWebKitAPI::timerCallback): Kill the timer and record that it fired. 638 (TestWebKitAPI::runForDuration): Set a timer and run the run loop until it fires. 639 (TestWebKitAPI::waitForBackingStoreUpdate): Wait for half a second to give the web process a 640 chance to display, then flush all pending messages. 641 (TestWebKitAPI::TEST): Resize the WKView while it's hidden, then show it again and wait for 642 the backing store to update. This triggers the assertion from bug 54141. 643 644 * TestWebKitAPI/win/PlatformWebViewWin.cpp: 645 (TestWebKitAPI::PlatformWebView::resizeTo): Implemented. 646 647 * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test. 648 6492011-02-10 Philippe Normand <pnormand@igalia.com> 650 651 Unreviewed, GTK build fix after roll out of r78157... 652 653 * GNUmakefile.am: 654 6552011-02-10 Eric Seidel <eric@webkit.org> 656 657 Unreviewed, rolling out r78157. 658 http://trac.webkit.org/changeset/78157 659 https://bugs.webkit.org/show_bug.cgi?id=54150 660 661 Fails on a bunch of bots 662 663 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 664 * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Removed. 665 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 666 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 667 6682011-02-10 Mario Sanchez Prada <msanchez@igalia.com> 669 670 Reviewed by Xan Lopez. 671 672 [GTK] Reset GTK' DRT's AccessibilityController to consistent value before every test 673 https://bugs.webkit.org/show_bug.cgi?id=54185 674 675 * DumpRenderTree/gtk/DumpRenderTree.cpp: 676 (resetDefaultsToConsistentValues): 677 6782011-02-10 Philippe Normand <pnormand@igalia.com> 679 680 Unreviewed GTK build fix. 681 682 Adding 683 Tools/DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp 684 in the build, fixing the 685 plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html 686 test. 687 688 * GNUmakefile.am: 689 6902011-02-10 Mario Sanchez Prada <msanchez@igalia.com> 691 692 Reviewed by Chris Fleizach. 693 694 [GTK] Add support in DRT to log "accessibility events" 695 https://bugs.webkit.org/show_bug.cgi?id=54116 696 697 Added a way to log accessibility related events, in a 698 platform-dependant way. 699 700 Add new function to AccessibilityController. 701 702 * DumpRenderTree/AccessibilityController.h: 703 * DumpRenderTree/AccessibilityController.cpp: 704 (logAccessibilityEventsCallback): New callback. 705 (AccessibilityController::getJSClass): Added new function. 706 (AccessibilityController::resetToConsistentState): Initialized 707 calling setLogAccessibilityEvents(false). 708 709 Provided implementation for the GTK port. 710 711 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 712 (accessibility_event_listener): Common listener for logging 713 information about all the signals emitted by any AtkObject. 714 (AccessibilityController::setLogAccessibilityEvents): Add or 715 remove listeners for signals, as specified by the parameter. 716 717 Provide dummy implementations for mac and win ports. 718 719 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 720 (AccessibilityController::setLogAccessibilityEvents): 721 * DumpRenderTree/win/AccessibilityControllerWin.cpp: 722 (AccessibilityController::setLogAccessibilityEvents): 723 7242011-02-09 Hayato Ito <hayato@chromium.org> 725 726 Reviewed by Tony Chang. 727 728 [NRWT] Remove encoding parameters where we can assume data can be 729 written in binary mode. 730 731 https://bugs.webkit.org/show_bug.cgi?id=54066 732 733 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: 734 * Scripts/webkitpy/layout_tests/port/base.py: 735 7362011-02-09 Dirk Pranke <dpranke@chromium.org> 737 738 Reviewed by Tony Chang. 739 740 nrwt multiprocessing: minor cleanup prior to implementing the new worker 741 742 This patch renames AbstractManager to ManagerConnection and 743 changes some argument names to be more consistent between 744 manager_worker_broker and message_broker. It also fixes a couple 745 of typos in message_broker. These changes will be tested by code 746 introduced in the next patch. 747 748 https://bugs.webkit.org/show_bug.cgi?id=54067 749 750 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: 751 * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: 752 7532011-02-09 Anders Carlsson <andersca@apple.com> 754 755 Reviewed by Sam Weinig. 756 757 Repro crash with Sony Google TV ad at Gizmodo 758 https://bugs.webkit.org/show_bug.cgi?id=54150 759 <rdar://problem/8782346> 760 761 Add a new plug-in test that runs JavaScript that destroys the plug-in from within its NPN_DestroyStream callback. 762 763 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 764 * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Added. 765 (EvaluateJSDestroyingPluginFromDestroyStream::EvaluateJSDestroyingPluginFromDestroyStream): 766 (EvaluateJSDestroyingPluginFromDestroyStream::NPP_Destroy): 767 (EvaluateJSDestroyingPluginFromDestroyStream::NPP_DestroyStream): 768 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 769 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 770 7712011-02-09 David Levin <levin@chromium.org> 772 773 Reviewed by Eric Seidel. 774 775 check-webkit-style: The error message about NULL should be more clear for comments. 776 https://bugs.webkit.org/show_bug.cgi?id=53786 777 778 * Scripts/webkitpy/style/checkers/cpp.py: Clarified the error message. 779 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Fixed the corresponding test. 780 7812011-02-09 Nebojsa Ciric <cira@chromium.org> 782 783 Reviewed by Darin Fisher. 784 785 Implements Locale object of JavaScript internationalization API proposal, as an 786 v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h}) 787 and in this patch we just provide flags, tests and build rules for chromium port. 788 https://bugs.webkit.org/show_bug.cgi?id=49414 789 790 * DumpRenderTree/chromium/TestShell.cpp: 791 (TestShell::TestShell): 792 7932011-02-09 Laszlo Gombos <laszlo.1.gombos@nokia.com> 794 795 Reviewed by Kenneth Rohde Christiansen. 796 797 [Qt] Remove UiTools dependency from MiniBrowser 798 https://bugs.webkit.org/show_bug.cgi?id=54096 799 800 * MiniBrowser/qt/MiniBrowser.pro: 801 8022011-02-08 Hayato Ito <hayato@chromium.org> 803 804 Reviewed by Tony Chang. 805 806 [NRWT] Pull up rebaseline code from compare_output() function defined 807 in text_diff.py and image_diff.py into a SingleTestRunner. 808 809 This patch is a first step for eliminating test_type/* classes. 810 811 https://bugs.webkit.org/show_bug.cgi?id=53071 812 813 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: 814 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 815 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 816 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 817 8182011-02-07 Ojan Vafai <ojan@chromium.org> 819 820 Reviewed by Mihai Parparita. 821 822 stop generating results.json files 823 https://bugs.webkit.org/show_bug.cgi?id=53977 824 825 We've only used incremental_results.json for a while now 826 and there are plans to start generating a results.json file that matches 827 the format of unexpected_results.json. 828 829 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 830 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 831 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: 832 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 833 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 834 8352011-02-08 Sailesh Agrawal <sail@chromium.org> 836 837 Reviewed by Kenneth Russell. 838 839 Invalidate rect doesn't work for windowless plugins on Chromium 840 https://bugs.webkit.org/show_bug.cgi?id=53117 841 842 Added two new utility methods. 843 - layoutTestController.displayInvalidatedRegion() does a paint of any area that has been invalidated. This is different from layoutTestController.display() which explicitly invalidates the entire page then paints. 844 - plugin.invalidateRect(left, top, right, bottom) - invalidates the given rect 845 This is used to test that invalidating a rect correctly causes a repaint of the plugin. 846 847 * DumpRenderTree/LayoutTestController.cpp: 848 (displayInvalidatedRegionCallback): 849 (LayoutTestController::staticFunctions): 850 * DumpRenderTree/LayoutTestController.h: 851 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 852 (invalidateRect): 853 (pluginInvoke): 854 * DumpRenderTree/chromium/LayoutTestController.cpp: 855 (LayoutTestController::LayoutTestController): 856 (LayoutTestController::displayInvalidatedRegion): 857 * DumpRenderTree/chromium/LayoutTestController.h: 858 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 859 8602011-02-08 Dirk Pranke <dpranke@chromium.org> 861 862 Reviewed by Tony Chang. 863 864 new-run-webkit-tests: move the logic that starts and stops the 865 servers from dump_render_tree_thread into single_test_runner 866 so that we can reuse it in the new multiprocessing worker class 867 as well. 868 869 https://bugs.webkit.org/show_bug.cgi?id=53840 870 871 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 872 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: 873 8742011-02-08 Dirk Pranke <dpranke@chromium.org> 875 876 Reviewed by Mihai Parparita. 877 878 new-run-webkit-tests: split out thread stack logging code into a sharable module 879 880 This patch splits out the code used to find and log thread 881 stacks from NRWT-specific packages to something generic and 882 shareable by other python modules. It will be shared in the near 883 future by the manager_worker_broker module, for example. 884 885 https://bugs.webkit.org/show_bug.cgi?id=53656 886 887 * Scripts/webkitpy/common/system/stack_utils.py: Added. 888 * Scripts/webkitpy/common/system/stack_utils_unittest.py: Added. 889 * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: 890 * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: 891 8922011-02-08 Dirk Pranke <dpranke@chromium.org> 893 894 Reviewed by Tony Chang. 895 896 new-run-webkit-tests: move a bunch of testing logic out of 897 dump_render_tree_thread and into single_test_runner so that we 898 will be able to reuse it in the new multiprocessing worker class as well. 899 900 https://bugs.webkit.org/show_bug.cgi?id=53838 901 902 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 903 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: 904 905 9062011-02-08 Dirk Pranke <dpranke@chromium.org> 907 908 Reviewed by Ojan Vafai. 909 910 new-run-webkit-tests: remove no longer needed WatchableThread 911 class. 912 913 https://bugs.webkit.org/show_bug.cgi?id=53839 914 915 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 916 9172011-02-08 Dirk Pranke <dpranke@chromium.org> 918 919 Reviewed by Tony Chang. 920 921 new-run-webkit-tests: add stubs for the Manager objects that 922 will abstract the concurrency implementation (inline / threads / 923 processes). These classes do nothing yet and are not wired up to 924 anything. 925 926 https://bugs.webkit.org/show_bug.cgi?id=53477 927 928 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Added. 929 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Added. 930 9312011-02-08 Dirk Pranke <dpranke@chromium.org> 932 933 Reviewed by Tony Chang. 934 935 new-run-webkit-tests: add simplified message broker for new-style 936 messaging. This change adds a very simple message broker that 937 will be used to shuttle messages between the TestRunner2 manager 938 thread and the Worker threads. For now the class is not used by 939 anything, but the eventual usage can be seen in the patches 940 attached to bug 49566. 941 942 https://bugs.webkit.org/show_bug.cgi?id=53158 943 944 * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Added. 945 * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Added. 946 9472011-02-08 Adam Barth <abarth@webkit.org> 948 949 Reviewed by Dimitri Glazkov. 950 951 chromium-win builder shouldn't run python or perl tests 952 https://bugs.webkit.org/show_bug.cgi?id=54032 953 954 These tests don't pass on this builder because the builder isn't 955 running in cygwin. There isn't really any point in running them and 956 making the bot red forever. 957 958 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 959 9602011-02-08 Brady Eidson <beidson@apple.com> 961 962 Reviewed by Darin Adler. 963 964 <rdar://problem/8972913> and https://bugs.webkit.org/show_bug.cgi?id=54036 965 didChangeBackForwardList should include some context about what changed 966 967 * MiniBrowser/mac/BrowserWindowController.m: 968 (didChangeBackForwardList): 969 9702011-02-08 Sam Weinig <sam@webkit.org> 971 972 Reviewed by Anders Carlsson. 973 974 WK2: Add ability to pass context to policy delegate methods 975 https://bugs.webkit.org/show_bug.cgi?id=54031 976 977 * MiniBrowser/mac/BrowserWindowController.m: 978 (decidePolicyForNavigationAction): 979 (decidePolicyForNewWindowAction): 980 (decidePolicyForMIMEType): 981 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: 982 (TestWebKitAPI::decidePolicyForNavigationAction): 983 (TestWebKitAPI::decidePolicyForNewWindowAction): 984 (TestWebKitAPI::decidePolicyForMIMEType): 985 Update policy client for new API. 986 9872011-02-08 Martin Robinson <mrobinson@igalia.com> 988 989 Reviewed by Xan Lopez. 990 991 [GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled 992 https://bugs.webkit.org/show_bug.cgi?id=54033 993 994 Add an implementation of LayoutTestController.setIconDatabaseEnabled that just 995 call DumpRenderTreeSupportGtk. Turn off the icon database between tests. 996 997 * DumpRenderTree/gtk/DumpRenderTree.cpp: 998 (resetDefaultsToConsistentValues): Turn off the icon database. 999 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 1000 (LayoutTestController::setIconDatabaseEnabled): Call the appropriate DumpRenderTreeSupportGtk 1001 method. 1002 10032011-02-08 Kundu Suchismita <suchi.kundu@nokia.com> 1004 1005 Reviewed by Laszlo Gombos. 1006 1007 Local Storage settings can be enable/disable from "Develop" menu 1008 https://bugs.webkit.org/show_bug.cgi?id=52296 1009 1010 * QtTestBrowser/launcherwindow.cpp: 1011 (LauncherWindow::createChrome): 1012 (LauncherWindow::toggleLocalStorage): 1013 (LauncherWindow::toggleOfflineStorageDatabase): 1014 (LauncherWindow::toggleOfflineWebApplicationCache): 1015 (LauncherWindow::setOfflineStorageDefaultQuota): 1016 * QtTestBrowser/launcherwindow.h: 1017 (WindowOptions::WindowOptions): 1018 * QtTestBrowser/main.cpp: 1019 (LauncherApplication::handleUserOptions): 1020 10212011-02-08 Martin Robinson <mrobinson@igalia.com> 1022 1023 Reviewed by Eric Seidel. 1024 1025 [GTK] EventSender.keyDown does not support non-array modifier arguments 1026 https://bugs.webkit.org/show_bug.cgi?id=53962 1027 1028 Support handling either an array or a string for the modifier argument 1029 to EventSender.keyDown. 1030 1031 * DumpRenderTree/gtk/EventSender.cpp: 1032 (gdkModifierFromJSValue): Added this helper which factors out the 1033 string comparison bits. 1034 (gdkModifersFromJSValue): Test up front whether the value is a string, 1035 to handle it specially. 1036 10372011-02-08 Benjamin Poulain <ikipou@gmail.com> 1038 1039 Reviewed by Csaba Osztrogonác. 1040 1041 openDatabaseSync() stop responding after too many call 1042 https://bugs.webkit.org/show_bug.cgi?id=53945 1043 1044 Reset the database quota to a known state between each test. 1045 1046 Define a quota for the known origins at each test run and delete 1047 all the databases. 1048 This way, the database related test do not depend on previous 1049 allocations. 1050 1051 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 1052 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 1053 (WebCore::DumpRenderTree::dumpDatabaseQuota): 1054 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 1055 (LayoutTestController::reset): 1056 10572011-02-08 Carlos Garcia Campos <cgarcia@igalia.com> 1058 1059 Reviewed by Martin Robinson. 1060 1061 [GTK] DRT's TextInputController is unimplemented on GTK 1062 https://bugs.webkit.org/show_bug.cgi?id=52997 1063 1064 Initial implementation of TextInputController for GTK port. 1065 1066 * DumpRenderTree/gtk/DumpRenderTree.cpp: 1067 (webViewWindowObjectCleared): 1068 * DumpRenderTree/gtk/TextInputController.cpp: Added. 1069 (setMarkedTextCallback): 1070 (insertTextCallback): 1071 (unmarkTextCallback): 1072 (firstRectForCharacterRangeCallback): 1073 (selectedRangeCallback): 1074 (getClass): 1075 (makeTextInputController): 1076 * DumpRenderTree/gtk/TextInputController.h: Added. 1077 * GNUmakefile.am: 1078 10792011-02-07 Tony Chang <tony@chromium.org> 1080 1081 Reviewed by Adam Barth. 1082 1083 clean up python imports 1084 https://bugs.webkit.org/show_bug.cgi?id=53966 1085 1086 Convert "import A.B.C.D as D" to "from A.B.C import D" and 1087 make some imports absolute as required by PEP-8 1088 1089 * Scripts/webkitpy/common/checkout/scm.py: 1090 * Scripts/webkitpy/common/net/irc/ircbot.py: 1091 * Scripts/webkitpy/common/system/logutils.py: 1092 * Scripts/webkitpy/common/system/logutils_unittest.py: 1093 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: 1094 * Scripts/webkitpy/layout_tests/port/chromium.py: 1095 * Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports 1096 * Scripts/webkitpy/layout_tests/port/webkit.py: 1097 * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: 1098 * Scripts/webkitpy/tool/bot/irc_command.py: 1099 * Scripts/webkitpy/tool/bot/sheriffircbot.py: 1100 * Scripts/webkitpy/tool/commands/download.py: 1101 * Scripts/webkitpy/tool/commands/prettydiff.py: 1102 * Scripts/webkitpy/tool/commands/queries.py: 1103 * Scripts/webkitpy/tool/commands/roll.py: 1104 * Scripts/webkitpy/tool/commands/stepsequence.py: 1105 * Scripts/webkitpy/tool/commands/upload.py: 1106 * Scripts/webkitpy/tool/main.py: 1107 11082011-02-07 James Robinson <jamesr@chromium.org> 1109 1110 Reviewed by Adam Barth. 1111 1112 Teach do-webcore-rename about the WebKit move to Source/ 1113 https://bugs.webkit.org/show_bug.cgi?id=53967 1114 1115 * Scripts/do-webcore-rename: 1116 11172011-02-07 Maciej Stachowiak <mjs@apple.com> 1118 1119 Reviewed by Dan Bernstein. 1120 1121 Add resource load client for injected bundle and move willSendRequest there 1122 https://bugs.webkit.org/show_bug.cgi?id=53972 1123 1124 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 1125 (didCreatePage): 1126 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 1127 (WTR::InjectedBundlePage::InjectedBundlePage): 1128 (WTR::InjectedBundlePage::didInitiateLoadForResource): 1129 (WTR::InjectedBundlePage::didReceiveResponseForResource): 1130 (WTR::InjectedBundlePage::didReceiveContentLengthForResource): 1131 (WTR::InjectedBundlePage::didFinishLoadForResource): 1132 (WTR::InjectedBundlePage::didFailLoadForResource): 1133 (WTR::InjectedBundlePage::willSendRequestForFrame): 1134 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 1135 11362011-02-07 Adam Barth <abarth@webkit.org> 1137 1138 Add Leopard Debug back to the core builders. 1139 1140 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 1141 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 1142 11432011-02-07 Adam Klein <adamk@chromium.org> 1144 1145 Reviewed by Jian Li. 1146 1147 [chromium] Remove deprecated method WebNotification::dir 1148 https://bugs.webkit.org/show_bug.cgi?id=53735 1149 1150 * DumpRenderTree/chromium/NotificationPresenter.cpp: 1151 (NotificationPresenter::show): 1152 11532011-02-07 Adam Barth <abarth@webkit.org> 1154 1155 Reviewed by Eric Seidel. 1156 1157 Remove Leopard Debug as a core builder 1158 https://bugs.webkit.org/show_bug.cgi?id=53971 1159 1160 The Leopard Debug builder has been failing to compile for several days. 1161 My understanding is that folks are working on fixing the build, but for 1162 the time being we should probably remove it from the list of core 1163 builders so that the core waterfall can be green. We can certainly add 1164 it back once the build is fixed. 1165 1166 Also, I've removed the Tiger builders because those no longer appear to 1167 be attached to the buildbot master. 1168 1169 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 1170 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 1171 11722011-02-01 Ojan Vafai <ojan@chromium.org> 1173 1174 Reviewed by Adam Roben. 1175 1176 include svn revisions in git diffs for the code review tool to use 1177 https://bugs.webkit.org/show_bug.cgi?id=53569 1178 1179 * Scripts/webkitpy/common/checkout/scm.py: 1180 * Scripts/webkitpy/common/checkout/scm_unittest.py: 1181 11822011-02-03 MORITA Hajime <morrita@google.com> 1183 1184 Reviewed by Darin Fisher. 1185 1186 [Chromium] Should implement EditorClientImpl::requestCheckingOfString() 1187 https://bugs.webkit.org/show_bug.cgi?id=51013 1188 1189 Gave DRT implementation for requestTextCheck(). 1190 1191 * DumpRenderTree/chromium/LayoutTestController.cpp: 1192 (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented. 1193 * DumpRenderTree/chromium/WebViewHost.cpp: 1194 (invokeFinishLastTextCheck): Added. 1195 (WebViewHost::requestTextCheck): Added. 1196 (WebViewHost::finishLastTextCheck): Added. 1197 * DumpRenderTree/chromium/WebViewHost.h: 1198 11992011-02-07 Joone Hur <joone.hur@collabora.co.uk> 1200 1201 Reviewed by Martin Robinson. 1202 1203 [Gtk] Implement layoutTestController.findString 1204 https://bugs.webkit.org/show_bug.cgi?id=50237 1205 1206 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 1207 (LayoutTestController::findString): 1208 12092011-02-07 Chang Shu <chang.shu@nokia.com> 1210 1211 Reviewed by Darin Adler. 1212 1213 We should disable spatial navigation explicitly during the initialization 1214 of DumpRenderTree. 1215 https://bugs.webkit.org/show_bug.cgi?id=53928 1216 1217 * DumpRenderTree/mac/DumpRenderTree.mm: 1218 (resetDefaultsToConsistentValues): 1219 12202011-02-07 Maciej Stachowiak <mjs@apple.com> 1221 1222 Not reviewed. 1223 1224 Fix WebKitTestRunner build on the SL bot. 1225 1226 * WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy 1227 of ICU headers. 1228 12292011-02-07 Csaba Osztrogonác <ossy@webkit.org> 1230 1231 Unreviewed. 1232 1233 [Qt][WK2] Buildfix after r77794. 1234 1235 WebKitTestRunner does not block remote resources or complain about them 1236 https://bugs.webkit.org/show_bug.cgi?id=42139 1237 <rdar://problem/8183942> 1238 1239 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Add missing includepaths. 1240 12412011-02-07 Maciej Stachowiak <mjs@apple.com> 1242 1243 Not reviewed. 1244 1245 More bot appeasement. 1246 1247 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 1248 12492011-02-07 Maciej Stachowiak <mjs@apple.com> 1250 1251 Not reviewed. 1252 1253 Remove accidental references to directories on my laptop. 1254 1255 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 1256 12572011-02-07 Maciej Stachowiak <mjs@apple.com> 1258 1259 Reviewed by Antti Koivisto. 1260 1261 WebKitTestRunner does not block remote resources or complain about them 1262 https://bugs.webkit.org/show_bug.cgi?id=42139 1263 <rdar://problem/8183942> 1264 1265 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 1266 (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required 1267 checks (using KURL, to avoid need to invent a whole URL API). 1268 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore 1269 directly to get at KURL symbols. 1270 12712011-02-06 Maciej Stachowiak <mjs@apple.com> 1272 1273 Reviewed by Daniel Bates. 1274 1275 Add WebKit2 bot to list of expected builders in Python regression test results. 1276 https://bugs.webkit.org/show_bug.cgi?id=53905 1277 1278 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 1279 12802011-02-06 Maciej Stachowiak <mjs@apple.com> 1281 1282 Reviewed by Ryosuke Niwa. 1283 1284 Update test expectations for new core builder 1285 https://bugs.webkit.org/show_bug.cgi?id=53904 1286 1287 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 1288 12892011-02-06 Maciej Stachowiak <mjs@apple.com> 1290 1291 Reviewed by David Levin. 1292 1293 Add WebKit2 test bot to core builders 1294 https://bugs.webkit.org/show_bug.cgi?id=53901 1295 1296 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 1297 12982011-02-06 Ryosuke Niwa <rniwa@webkit.org> 1299 1300 Another unreviewed Chromium build fix. 1301 1302 * DumpRenderTree/chromium/LayoutTestController.cpp: 1303 (LayoutTestController::pathToLocalResource): 1304 13052011-02-06 Ryosuke Niwa <rniwa@webkit.org> 1306 1307 Unreviewed Chromium build fix. 1308 1309 * DumpRenderTree/chromium/LayoutTestController.cpp: 1310 (LayoutTestController::pathToLocalResource): 1311 13122011-02-06 Ryosuke Niwa <rniwa@webkit.org> 1313 1314 Reviewed by Darin Adler. 1315 1316 OwnArraryPtr.h uses deleteOwnedPtr but doesnât include OwnPtrCommon.h 1317 https://bugs.webkit.org/show_bug.cgi?id=52867 1318 1319 * DumpRenderTree/chromium/ImageDiff.cpp: 1320 (Image::craeteFromStdin): Call adoptArrayPtr. 1321 13222011-02-06 James Kozianski <koz@chromium.org> 1323 1324 Reviewed by Ojan Vafai. 1325 1326 Add classes for representing test outputs. 1327 https://bugs.webkit.org/show_bug.cgi?id=52136 1328 1329 These classes will make it easier to write scripts that deal with test 1330 outputs such as rebaselining and deduping scripts. The intent is that 1331 eventually we will be have buildbot return TestOutputs for a 1332 particular build which can be compared with TestOutputs derived from a 1333 local LayoutTests directory. 1334 1335 * Scripts/webkitpy/common/net/testoutput.py: Added. 1336 * Scripts/webkitpy/common/net/testoutput_unittest.py: Added. 1337 * Scripts/webkitpy/common/net/testoutputset.py: Added. 1338 * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added. 1339 * Scripts/webkitpy/common/system/zip_mock.py: Added. 1340 13412011-02-06 Robert Hogan <robert@webkit.org> 1342 1343 Reviewed by Andreas Kling. 1344 1345 [Qt] Clear page's groupName even when not in DRT 1346 https://bugs.webkit.org/show_bug.cgi?id=53874 1347 1348 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 1349 (WebCore::DumpRenderTree::windowCloseRequested): 1350 13512011-02-06 Patrick Gansterer <paroga@webkit.org> 1352 1353 Reviewed by Andreas Kling. 1354 1355 [CMake] Add dependencies for Visual Studio projects 1356 https://bugs.webkit.org/show_bug.cgi?id=53773 1357 1358 Add a WebKit dependecy to WinCELauncher, so CMake can 1359 generate the correct build order for the solution. 1360 1361 * CMakeListsWinCE.txt: 1362 13632011-02-06 Andreas Kling <kling@webkit.org> 1364 1365 Reviewed by Antonio Gomes. 1366 1367 [Qt] MiniBrowser: Clean up handling of titleChanged() signal 1368 https://bugs.webkit.org/show_bug.cgi?id=53869 1369 1370 * MiniBrowser/qt/BrowserView.cpp: 1371 (BrowserView::BrowserView): Remove unnecessary titleChanged() handling. 1372 * MiniBrowser/qt/BrowserWindow.cpp: 1373 (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle(). 1374 * MiniBrowser/qt/BrowserWindow.h: 1375 13762011-02-06 Maciej Stachowiak <mjs@apple.com> 1377 1378 Reviewed by Dan Bernstein. 1379 1380 WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull 1381 https://bugs.webkit.org/show_bug.cgi?id=42690 1382 <rdar://problem/8213851> 1383 1384 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 1385 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 1386 (WTR::InjectedBundlePage::willSendRequestForFrame): 1387 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 1388 (WTR::LayoutTestController::LayoutTestController): 1389 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 1390 (WTR::LayoutTestController::willSendRequestReturnsNull): 1391 (WTR::LayoutTestController::setWillSendRequestReturnsNull): 1392 13932011-02-05 Sheriff Bot <webkit.review.bot@gmail.com> 1394 1395 Unreviewed, rolling out r77720. 1396 http://trac.webkit.org/changeset/77720 1397 https://bugs.webkit.org/show_bug.cgi?id=53854 1398 1399 "Broke nrwt on Chromium win." (Requested by dglazkov|away on 1400 #webkit). 1401 1402 * Scripts/webkitpy/common/system/executive.py: 1403 14042011-02-05 Sheriff Bot <webkit.review.bot@gmail.com> 1405 1406 Unreviewed, rolling out r77725. 1407 http://trac.webkit.org/changeset/77725 1408 https://bugs.webkit.org/show_bug.cgi?id=53844 1409 1410 It broke Qt minimal build (Requested by Ossy_ on #webkit). 1411 1412 * QtTestBrowser/launcherwindow.cpp: 1413 (LauncherWindow::createChrome): 1414 * QtTestBrowser/launcherwindow.h: 1415 (WindowOptions::WindowOptions): 1416 * QtTestBrowser/main.cpp: 1417 (LauncherApplication::handleUserOptions): 1418 14192011-02-04 Martin Robinson <mrobinson@igalia.com> 1420 1421 Reviewed by Adam Barth. 1422 1423 [GTK] plugins/plugin-document-back-forward.html fails 1424 https://bugs.webkit.org/show_bug.cgi?id=53833 1425 1426 Add the new "alert on load" functionality for the Unix version of the 1427 test plugin. This functionality was originally introduced in r77706. 1428 1429 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 1430 (webkit_test_plugin_new_instance): Add new plugin fuctionality. 1431 14322011-02-04 Kundu Suchismita <suchi.kundu@nokia.com> 1433 1434 Reviewed by Andreas Kling. 1435 1436 Local Storage settings can be enable/disable from "Develop" menu 1437 https://bugs.webkit.org/show_bug.cgi?id=52296 1438 1439 * QtTestBrowser/launcherwindow.cpp: 1440 (LauncherWindow::createChrome): 1441 (LauncherWindow::toggleLocalStorage): 1442 (LauncherWindow::toggleOfflineStorageDatabase): 1443 (LauncherWindow::toggleOfflineWebApplicationCache): 1444 (LauncherWindow::setOfflineStorageDefaultQuota): 1445 * QtTestBrowser/launcherwindow.h: 1446 (WindowOptions::WindowOptions): 1447 * QtTestBrowser/main.cpp: 1448 (LauncherApplication::handleUserOptions): 1449 14502011-02-04 Tony Chang <tony@chromium.org> 1451 1452 Reviewed by Eric Seidel. 1453 1454 get test-webkitpy running on win32 python 1455 https://bugs.webkit.org/show_bug.cgi?id=53822 1456 1457 The test harness crashes with a WindowsError because it can't find 1458 'svn' when using subprocess.Popen. This gets us past the error 1459 so we can see the failing tests on the Chromium Win Release Tests 1460 bot. 1461 1462 * Scripts/webkitpy/common/system/executive.py: 1463 14642011-02-04 Martin Robinson <mrobinson@igalia.com> 1465 1466 Reviewed by Gustavo Noronha Silva. 1467 1468 [GTK] fast/events/pagehide-timeout.html fails 1469 https://bugs.webkit.org/show_bug.cgi?id=53771 1470 1471 Add knowledge of the document browser cache model the DRT. When resetting 1472 WebKit settings to consistent values between tests, default to the document 1473 browser cache model. 1474 1475 * DumpRenderTree/gtk/DumpRenderTree.cpp: 1476 (resetDefaultsToConsistentValues): Reset the cache model to the document browser 1477 cache model between tests. 1478 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 1479 (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the 1480 document browser cache model. 1481 14822011-02-04 Adam Barth <abarth@webkit.org> 1483 1484 Reviewed by Eric Seidel. 1485 1486 PluginDocuments don't create widgets for plugins on back/forward 1487 https://bugs.webkit.org/show_bug.cgi?id=53474 1488 1489 Teach the test plugin how to call alert on load. 1490 1491 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 1492 (NPP_New): 1493 14942011-02-04 Adam Roben <aroben@apple.com> 1495 1496 Add a test case for encode/decode of FormData/FormDataElement 1497 1498 If the fix made in r77401 is broken, this new test will crash. 1499 1500 Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>. 1501 1502 Reviewed by Sam Weinig. 1503 1504 * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro. 1505 Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value. 1506 1507 * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added. 1508 (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished. 1509 (TestWebKitAPI::setPageLoaderClient): Hook up the loader client. 1510 (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the 1511 form, an return the session state data. 1512 (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage, 1513 and restore it into another WKPage. 1514 1515 * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added. 1516 1517 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 1518 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 1519 * TestWebKitAPI/win/copy-resources.cmd: 1520 Added new files. 1521 15222011-02-04 Adam Roben <aroben@apple.com> 1523 1524 Move code to run JavaScript tests into its own files 1525 1526 This will allow other tests to use this mechanism. 1527 1528 Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the 1529 world 1530 1531 Reviewed by Sam Weinig. 1532 1533 * TestWebKitAPI/JavaScriptTest.cpp: Added. 1534 * TestWebKitAPI/JavaScriptTest.h: Added. 1535 Moved code here... 1536 1537 * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here. 1538 1539 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 1540 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 1541 Added the new files. 1542 15432011-02-04 Dirk Pranke <dpranke@chromium.org> 1544 1545 Reviewed by Mihai Parparita. 1546 1547 merge test expectations for chromium, chromium-gpu. The 1548 chromium-gpu port will no longer maintain its own 1549 test expectations file. 1550 1551 Also add in a graphics_type() call on the port object to 1552 determine what graphics type to use in the test configuration, 1553 and log the configuration as a config setting. 1554 1555 https://bugs.webkit.org/show_bug.cgi?id=53562 1556 1557 * Scripts/webkitpy/layout_tests/port/base.py: 1558 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 1559 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 1560 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 1561 15622011-02-04 Mikhail Naganov <mnaganov@chromium.org> 1563 1564 Reviewed by Pavel Feldman. 1565 1566 Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings. 1567 https://bugs.webkit.org/show_bug.cgi?id=53781 1568 1569 * Scripts/check-inspector-strings: 1570 15712011-02-04 Adam Roben <aroben@apple.com> 1572 1573 Include the crashing function in the link to a crash log on Mac 1574 1575 Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the 1576 function that crashed on Mac 1577 1578 Reviewed by David Kilzer. 1579 1580 * Scripts/old-run-webkit-tests: 1581 (crashLocation): Moved all the Windows code inside an if instead of using an early return, 1582 but didn't otherwise change it. Added an if for Mac that parses the crashing function out of 1583 the crash log. 1584 15852011-02-04 Adam Roben <aroben@apple.com> 1586 1587 Link to Mac crash logs from results.html 1588 1589 Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in 1590 results.html 1591 1592 Reviewed by David Kilzer. 1593 1594 * Scripts/old-run-webkit-tests: 1595 (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of 1596 ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log. 1597 15982011-02-03 Maciej Stachowiak <mjs@apple.com> 1599 1600 Reviewed by Dan Bernstein. 1601 1602 WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle 1603 https://bugs.webkit.org/show_bug.cgi?id=52897 1604 <rdar://problem/8898294> 1605 1606 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 1607 (WTR::InjectedBundlePage::InjectedBundlePage): 1608 (WTR::InjectedBundlePage::willSendRequestForFrame): 1609 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 1610 16112011-02-03 Ivan KrstiÄ <ike@apple.com> 1612 1613 Unreviewed. 1614 1615 Adding myself to committers.py. 1616 1617 * Scripts/webkitpy/common/config/committers.py: 1618 16192011-02-03 James Kozianski <koz@chromium.org> 1620 1621 Reviewed by Dimitri Glazkov. 1622 1623 Add navigator.registerProtocolHandler behind a flag. 1624 https://bugs.webkit.org/show_bug.cgi?id=52609 1625 1626 * Scripts/build-webkit: 1627 16282011-02-03 Hayato Ito <hayato@chromium.org> 1629 1630 Reviewed by Eric Seidel. 1631 1632 [NRWT] Remove TestArgs class, which is wrongly used. 1633 1634 https://bugs.webkit.org/show_bug.cgi?id=53063 1635 1636 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 1637 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: 1638 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 1639 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 1640 * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: 1641 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 1642 16432011-02-03 Andrew Wason <rectalogic@rectalogic.com> 1644 1645 Reviewed by Kenneth Russell. 1646 1647 Change ENABLE_3D_CANVAS to ENABLE_WEBGL 1648 https://bugs.webkit.org/show_bug.cgi?id=53714 1649 1650 * Scripts/build-webkit: change --3d-canvas build option 1651 to set ENABLE_WEBGL 1652 16532011-02-03 Hayato Ito <hayato@chromium.org> 1654 1655 Reviewed by Tony Chang. 1656 1657 [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and 1658 move _run_single_test() and _process_output() functions from 1659 dump_render_tree_thread.py to a single_test_runner.py as an individual module. 1660 1661 This is clean up and acts as a preparation for elimination of test_types/* 1662 classes. These classes will move to the single_test_runner module introduced 1663 in this patch. 1664 1665 https://bugs.webkit.org/show_bug.cgi?id=53004 1666 1667 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 1668 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added. 1669 * Scripts/webkitpy/layout_tests/layout_package/test_input.py: 1670 * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed. 1671 * Scripts/webkitpy/layout_tests/port/base.py: 1672 * Scripts/webkitpy/layout_tests/port/chromium.py: 1673 * Scripts/webkitpy/layout_tests/port/dryrun.py: 1674 * Scripts/webkitpy/layout_tests/port/test.py: 1675 * Scripts/webkitpy/layout_tests/port/webkit.py: 1676 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 1677 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 1678 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 1679 16802011-02-03 Dirk Pranke <dpranke@chromium.org> 1681 1682 Unreviewed, build fix. 1683 1684 Delete a line that was accidentally missed in r77586; without it 1685 there is still a race between the two threads. 1686 1687 https://bugs.webkit.org/show_bug.cgi?id=51572 1688 1689 * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: 1690 16912011-02-03 Dirk Pranke <dpranke@chromium.org> 1692 1693 Reviewed by Tony Chang. 1694 1695 nrwt: handle "broken pipe" notifications from DRT more cleanly. 1696 1697 https://bugs.webkit.org/show_bug.cgi?id=52927 1698 1699 * Scripts/webkitpy/layout_tests/port/server_process.py: 1700 * Scripts/webkitpy/layout_tests/port/server_process_unittest.py: 1701 17022011-02-03 Dirk Pranke <dpranke@chromium.org> 1703 1704 Reviewed by Kenneth Russell. 1705 1706 Update, resubmit change to bug 51572. I think the race that was 1707 fixed in r76703 caused the hang that caused us to roll this 1708 patch out before, so I'd like to try again. 1709 1710 https://bugs.webkit.org/show_bug.cgi?id=51572 1711 1712 * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: 1713 * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: 1714 17152011-02-03 Daniel Cheng <dcheng@chromium.org> 1716 1717 Unreviewed. 1718 1719 Adding myself to committers.py. 1720 1721 * Scripts/webkitpy/common/config/committers.py: 1722 17232011-02-03 Adam Roben <aroben@apple.com> 1724 1725 Include the crashing function in the link to a crash log 1726 1727 Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the 1728 function that crashed 1729 1730 Reviewed by David Kilzer. 1731 1732 * Scripts/old-run-webkit-tests: 1733 (crashLocation): Added. Returns the location of the crash. 1734 (linksForErrorTest): Include the crash location in the link text for the crash log, if one 1735 could be determined. 1736 17372011-02-03 Dirk Pranke <dpranke@chromium.org> 1738 1739 Unreviewed, build fix. 1740 1741 Actually make the changes suggested by Mihai in his review 1742 of bug 53720 :( 1743 1744 https://bugs.webkit.org/show_bug.cgi?id=53720 1745 1746 * Scripts/webkitpy/layout_tests/port/test_files.py: 1747 * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: 1748 17492011-02-03 Dirk Pranke <dpranke@chromium.org> 1750 1751 Reviewed by Mihai Parparita. 1752 1753 new-run-webkit-tests: Fix bug introduced in r77434 that was 1754 causing us to run the canvas GPU tests on the Mac GPU port. This 1755 bug revealed that we were not setting the port.name() field 1756 properly in many cases, so I've cleaned up all of that code, and 1757 removed a few comments about "version-specific" GPU ports that 1758 don't exist and just confused things. 1759 1760 Testing also revealed that port.abspath_for_test() wasn't 1761 normalizing paths on Windows properly, so I fixed that as well. 1762 1763 https://bugs.webkit.org/show_bug.cgi?id=53719 1764 1765 * Scripts/webkitpy/layout_tests/port/base.py: 1766 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 1767 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 1768 17692011-02-03 Dirk Pranke <dpranke@chromium.org> 1770 1771 Reviewed by Mihai Parparita. 1772 1773 new-run-webkit-tests: fix normalization of paths on windows when gathering files 1774 1775 r77434 introduced a bug that was causing the test expectations 1776 for the GPU ports to not be treated properly. It turns out that 1777 when we gathered the list of test files on Windows, we would 1778 return paths of the form "c:\LayoutTests/fast/canvas", and the 1779 mixture of backslashes and forward slashes was confusing things. 1780 1781 This patch normalizes all of the filenames returned from 1782 test_files.find(), and adds better tests for this (fixing a 1783 couple of other bugs found in the meantime). 1784 1785 https://bugs.webkit.org/show_bug.cgi?id=53720 1786 1787 * Scripts/webkitpy/layout_tests/port/test.py: 1788 * Scripts/webkitpy/layout_tests/port/test_files.py: 1789 * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: 1790 17912011-02-03 Adam Roben <aroben@apple.com> 1792 1793 Add links to Windows crash logs in results.html 1794 1795 Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in 1796 results.html 1797 1798 Reviewed by David Kilzer. 1799 1800 * Scripts/old-run-webkit-tests: 1801 (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from 1802 createDebuggerCommandFile). 1803 (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump 1804 tool has exited. 1805 (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves 1806 it into the test results directory tree. Only implemented for Cygwin currently. 1807 (findNewestFileMatchingGlob): Added. Does what it says. 1808 (htmlForResultsSection): Only link to files that exist. 1809 (linksForErrorTest): Add a link to the crash log. 1810 (deleteExpectedAndActualResults): Delete any old crash log for this test. 1811 (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of 1812 hardcoding it here. 1813 18142011-02-03 Adam Roben <aroben@apple.com> 1815 1816 Tell the debugger the path to the WebKit source tree when saving a crash log 1817 1818 This allows the debugger to include the crashing line of code in the log. 1819 1820 Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line 1821 of code 1822 1823 Reviewed by Sam Weinig. 1824 1825 * Scripts/old-run-webkit-tests: 1826 (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a 1827 file and returns the path to that file. The commands we pass came from 1828 setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the 1829 WebKit source code lives. 1830 (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command 1831 line using -c, save them to a file and specify the path to that file using -cf. This works 1832 around what is presumably a bug in Windows's command line parsing, where having multiple 1833 quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at 1834 all. Also pulled the options we pass to the debugger out into a list that is then join()ed 1835 together to make them easier to modify in the future. 1836 18372011-02-02 Sam Weinig <sam@webkit.org> 1838 1839 Reviewed by Anders Carlsson. 1840 1841 Add notification of the end of a rubber band. 1842 <rdar://problem/8940648> 1843 1844 * MiniBrowser/mac/BrowserWindowController.m: 1845 (-[BrowserWindowController awakeFromNib]): 1846 * WebKitTestRunner/TestController.cpp: 1847 (WTR::TestController::createOtherPage): 1848 (WTR::TestController::initialize): 1849 Stub out the new WKUIClient function. 1850 18512011-02-03 Gabor Rapcsanyi <rgabor@webkit.org> 1852 1853 Unreviewed. 1854 1855 Adding myself to committers.py. 1856 1857 * Scripts/webkitpy/common/config/committers.py: 1858 18592011-02-03 Balazs Kelemen <kbalazs@webkit.org> 1860 1861 Reviewed by Csaba Osztrogonác. 1862 1863 [Qt][WK2] MiniBrowser's window size should be 800x600 1864 https://bugs.webkit.org/show_bug.cgi?id=53670 1865 1866 Make layout test failure debugging easier. 1867 * MiniBrowser/qt/BrowserWindow.cpp: 1868 (BrowserWindow::BrowserWindow): 1869 18702011-02-02 Andy Estes <aestes@apple.com> 1871 1872 Reviewed by Mark Rowe. 1873 1874 'update-webkit' should handle OpenSource and Internal using different 1875 VCSs. 1876 1877 * Scripts/update-webkit: Re-check the VCS type when updating Apple's 1878 Internal directory. 1879 18802011-02-02 Dirk Pranke <dpranke@chromium.org> 1881 1882 Reviewed by Mihai Parparita. 1883 1884 new-run-webkit-tests: hardcode the directories to scan for tests 1885 for GPU bots instead of SKIPping them. See bug 53562 for some 1886 context, but we will now hard-code the list of directories to 1887 use by default instead of skipping over directories in the 1888 expectations file. We do this so that we will be able to merge 1889 the expectations files without getting conflicting SKIP 1890 directives. Note that this change will reduce the # of tests 1891 being run on the Mac GPU bots, because we're accidentally 1892 including some today. 1893 1894 https://bugs.webkit.org/show_bug.cgi?id=53631 1895 1896 * Scripts/webkitpy/layout_tests/port/base.py: 1897 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 1898 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 1899 19002011-02-02 Sam Weinig <sam@webkit.org> 1901 1902 Reviewed by Beth Dakin. 1903 1904 Add ChromeClient function to paint custom overhang areas. 1905 https://bugs.webkit.org/show_bug.cgi?id=53639 1906 1907 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 1908 (WTR::InjectedBundlePage::InjectedBundlePage): 1909 Stub out new callback. 1910 19112011-02-02 Dirk Pranke <dpranke@chromium.org> 1912 1913 Reviewed by Tony Chang. 1914 1915 new-run-webkit-tests: support chromium code paths in mock_drt 1916 1917 https://bugs.webkit.org/show_bug.cgi?id=53471 1918 1919 * Scripts/webkitpy/layout_tests/port/mock_drt.py: 1920 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: 1921 19222011-02-02 Adam Klein <adamk@chromium.org> 1923 1924 Reviewed by Tony Chang. 1925 1926 Update new-run-webkit-tests --chromium to put output under Source/... 1927 https://bugs.webkit.org/show_bug.cgi?id=53612 1928 1929 * BuildSlaveSupport/test-result-archive: 1930 * Scripts/webkitpy/layout_tests/port/chromium.py: 1931 19322011-01-28 Tony Chang <tony@chromium.org> 1933 1934 Reviewed by Eric Seidel. 1935 1936 [chromium] remove --use-test-shell from NRWT 1937 https://bugs.webkit.org/show_bug.cgi?id=53346 1938 1939 I've already started removing some of the bindings like eventSender so 1940 this already doesn't work isn't useful. Also updated some comments to 1941 refer to DRT instead of test_shell. 1942 1943 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 1944 * Scripts/webkitpy/layout_tests/port/chromium.py: 1945 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 1946 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 1947 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 1948 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 1949 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 1950 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 1951 19522011-02-02 Steve Lacey <sjl@chromium.org> 1953 1954 Reviewed by Eric Carlson. 1955 1956 Implement basic media statistics on media elements. 1957 https://bugs.webkit.org/show_bug.cgi?id=53322 1958 1959 * Scripts/build-webkit: 1960 19612011-02-02 Kevin Ollivier <kevino@theolliviers.com> 1962 1963 [wx] Build fixes for wxWebKit. 1964 1965 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 1966 (LayoutTestController::setSerializeHTTPLoads): 1967 * wx/browser/wscript: 1968 * wx/build/build_utils.py: 1969 * wx/build/settings.py: 1970 19712011-02-01 Dirk Pranke <dpranke@chromium.org> 1972 1973 Reviewed by Mihai Parparita. 1974 1975 new-run-webkit-tests: stop skipping so many tests 1976 1977 r77163 introduced a regression where we weren't resetting test 1978 expectations properly and were skipping too many tests as a 1979 result. This patch fixes that and adds a test for it. 1980 1981 https://bugs.webkit.org/show_bug.cgi?id=53551 1982 1983 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 1984 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 1985 19862011-02-01 Dirk Pranke <dpranke@chromium.org> 1987 1988 Reviewed by Tony Chang. 1989 1990 new-run-webkit-tests: add first stub of test_runner2. This 1991 will add support for the 'inline', 'threads', and 'processes' 1992 flags to --worker-model, but for now the implementatios just 1993 fall back on the old ones. 1994 1995 https://bugs.webkit.org/show_bug.cgi?id=53157 1996 1997 * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: 1998 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 1999 20002011-02-01 Mihai Parparita <mihaip@chromium.org> 2001 2002 Reviewed by James Robinson. 2003 2004 [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place 2005 https://bugs.webkit.org/show_bug.cgi?id=53522 2006 2007 * Scripts/run-chromium-webkit-unit-tests: 2008 20092011-02-01 Adam Barth <abarth@webkit.org> 2010 2011 Reviewed by Mihai Parparita. 2012 2013 Using Control-C to cancel webkit-patch or other python tools causes 2014 unpleasant traceback console spew 2015 https://bugs.webkit.org/show_bug.cgi?id=53462 2016 2017 Catch the exception and don't print the stack trace. 2018 2019 * Scripts/webkit-patch: 2020 20212011-02-01 Scott Cameron <sccameron@rim.com> 2022 2023 Reviewed by Daniel Bates. 2024 2025 Use Windows format for MinGW HTTPD path. 2026 https://bugs.webkit.org/show_bug.cgi?id=53503 2027 2028 * Scripts/webkitperl/httpd.pm: 2029 - Use single-quotes around MySys value for $httpdPath in getHTTPDPath() 2030 so that we don't have to escape the space characters in the path. Also, 2031 changed path to Windows-style path and removed FIXME comment. 2032 20332011-02-01 Balazs Kelemen <kbalazs@webkit.org> 2034 2035 Reviewed by Andreas Kling. 2036 2037 [Qt][WK2] Add a way to use shared process model in MiniBrowser 2038 https://bugs.webkit.org/show_bug.cgi?id=53090 2039 2040 * MiniBrowser/qt/BrowserView.cpp: 2041 (BrowserView::BrowserView): Removed the m_context member. 2042 From now the context is guaranteed to be non-null and we 2043 don't need to store that in the object. 2044 * MiniBrowser/qt/BrowserView.h: 2045 * MiniBrowser/qt/BrowserWindow.cpp: 2046 Added static bool to determine that new windows need to be 2047 created with their own context or not. Use the same context 2048 and web process by default to be inilne with the other ports. 2049 (BrowserWindow::BrowserWindow): 2050 (BrowserWindow::newWindow): 2051 * MiniBrowser/qt/BrowserWindow.h: 2052 * MiniBrowser/qt/main.cpp: 2053 (main): Added command line switch to be able to use the 2054 non-shared process model. Simplify the handling of the command line 2055 switches a little bit. 2056 20572011-02-01 Zoltan Horvath <zoltan@webkit.org> 2058 2059 Reviewed by Andreas Kling. 2060 2061 [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser. 2062 https://bugs.webkit.org/show_bug.cgi?id=53491 2063 2064 * MiniBrowser/qt/BrowserWindow.cpp: 2065 (BrowserWindow::BrowserWindow): 2066 (BrowserWindow::toggleFullScreenMode): 2067 * MiniBrowser/qt/BrowserWindow.h: 2068 20692011-02-01 Zoltan Horvath <zoltan@webkit.org> 2070 2071 Reviewed by Andreas Kling. 2072 2073 [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser. 2074 https://bugs.webkit.org/show_bug.cgi?id=53489 2075 2076 Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions 2077 to Settings menu. 2078 2079 * MiniBrowser/qt/BrowserWindow.cpp: 2080 (BrowserWindow::BrowserWindow): 2081 (BrowserWindow::toggleFrameFlattening): 2082 (BrowserWindow::toggleDisableJavaScript): 2083 (BrowserWindow::toggleAutoLoadImages): 2084 * MiniBrowser/qt/BrowserWindow.h: 2085 20862011-01-31 Mihai Parparita <mihaip@chromium.org> 2087 2088 Reviewed by Tony Chang. 2089 2090 [Chromium] Switch chromium-mac to use ChromiumDriver 2091 https://bugs.webkit.org/show_bug.cgi?id=53461 2092 2093 For the sake of consistency with the other Chromium platforms (and so 2094 that chromium-mac picks up special flags like --enable-hardware-gpu), 2095 switch chromium-mac from the WebKitDriver to ChromiumDriver. 2096 2097 * Scripts/webkitpy/layout_tests/port/chromium.py: 2098 20992011-01-31 Dirk Pranke <dpranke@chromium.org> 2100 2101 Reviewed by Mihai Parparita. 2102 2103 The current modifier parsing code in test_expectations is 2104 fragile and hard-coded, so it's not easy to understand the logic 2105 or easily add new types of modifiers (like GPU vs. CPU testing 2106 for graphics tests, or 32-bit vs. 64-bit differences). 2107 2108 This is the first of two patches that will add in more generic 2109 support and then eliminate the GPU-specific test expectations 2110 files for Chromium. 2111 2112 This patch adds two standalone objects for handling modifiers. The 2113 rules for interpreting modifiers, precedence, and conflicts are 2114 given in the docstring to the ModifierMatcher class, which 2115 returns ModifierMatchResult objects. 2116 2117 This patch also adds routines to the Port interface and a 2118 default set of values in the base object, in order to obtain the 2119 values needed on a given test run. These values are then passed 2120 to the expectation parser. This also allows us to clean up the 2121 logic used to lint all of the different configurations in a 2122 single test_expectations.txt file. 2123 2124 The next patch will merge in the separate GPU expectations file. 2125 2126 https://bugs.webkit.org/show_bug.cgi?id=51222 2127 2128 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 2129 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 2130 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 2131 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 2132 * Scripts/webkitpy/layout_tests/port/base.py: 2133 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 2134 * Scripts/webkitpy/layout_tests/port/chromium.py: 2135 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 2136 * Scripts/webkitpy/layout_tests/port/test.py: 2137 * Scripts/webkitpy/layout_tests/port/webkit.py: 2138 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2139 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 2140 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2141 * Tools/Scripts/webkitpy/style/checkers/test_expectations.py: 2142 * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py: 2143 21442011-01-31 Scott Cameron <sccameron@rim.com> 2145 2146 Reviewed by Daniel Bates. 2147 2148 update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment 2149 https://bugs.webkit.org/show_bug.cgi?id=50036 2150 2151 This will add an Apache2.2 configuration file and modifies scripts to allow 2152 running an httpd server in an MSYS environment. 2153 2154 The default Apache2.2 installation path has been preserved and PHP5 modules disabled 2155 in order to allow for simple installation/execution. Simply install the latest 2156 Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to 2157 be able to execute run-webkit-httpd. 2158 2159 2160 * Scripts/run-webkit-httpd: 2161 * Scripts/webkitperl/httpd.pm: 2162 21632011-01-31 Tony Chang <tony@chromium.org> 2164 2165 Reviewed by Eric Seidel. 2166 2167 mac DRT should report RTL scroll offset relative to top right corner 2168 https://bugs.webkit.org/show_bug.cgi?id=53324 2169 2170 * DumpRenderTree/mac/DumpRenderTree.mm: 2171 (dumpFrameScrollPosition): 2172 21732011-01-31 Zoltan Horvath <zoltan@webkit.org> 2174 2175 Reviewed by Andreas Kling. 2176 2177 [Qt] Add Take Screen Shot action to MiniBrowser 2178 https://bugs.webkit.org/show_bug.cgi?id=53422 2179 2180 Add Take Screen Shot action to MiniBrowser's view menu. 2181 2182 * MiniBrowser/qt/BrowserWindow.cpp: 2183 (BrowserWindow::BrowserWindow): 2184 (BrowserWindow::screenshot): 2185 * MiniBrowser/qt/BrowserWindow.h: 2186 21872011-01-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 2188 2189 Reviewed by Xan Lopez. 2190 2191 [GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing 2192 https://bugs.webkit.org/show_bug.cgi?id=53379 2193 2194 Remove left over #ifdef's. I thought all of the conditional code 2195 had been freed from the condition, but I forgot to check DRT. 2196 2197 * DumpRenderTree/gtk/DumpRenderTree.cpp: 2198 (resetDefaultsToConsistentValues): 2199 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 2200 (LayoutTestController::setAlwaysAcceptCookies): 2201 22022011-01-30 Dirk Pranke <dpranke@chromium.org> 2203 2204 Unreviewed, build fix. 2205 2206 Fix regression introduced in r77093 - path.rsplit() doesn't 2207 take keyword arguments. 2208 2209 https://bugs.webkit.org/show_bug.cgi?id=53326 2210 2211 * Scripts/webkitpy/common/system/filesystem_mock.py: 2212 22132011-01-30 Dirk Pranke <dpranke@chromium.org> 2214 2215 Reviewed by Mihai Parparita. 2216 2217 Add more unit tests for rebaseline-chromium-webkit-tests. This 2218 change involves restructuring a bunch of r-c-w-t code to make it 2219 more testable as well. We also add wrapper classes for handling 2220 testing zip files and fetching URLs. 2221 2222 https://bugs.webkit.org/show_bug.cgi?id=53040 2223 2224 * Scripts/webkitpy/common/system/urlfetcher.py: 2225 * Scripts/webkitpy/common/system/urlfetcher_mock.py: 2226 * Scripts/webkitpy/common/system/zipfileset_mock.py: 2227 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2228 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 2229 * Scripts/webkitpy/tool/mocktool.py: 2230 22312011-01-30 Dirk Pranke <dpranke@chromium.org> 2232 2233 Reviewed by Eric Seidel. 2234 2235 Clean up of the filesystem-related modules used in webkitpy. 2236 I've added relpath() to the filesystem interface, modified 2237 ospath.relpath() so that it could work with the filesystem 2238 interface, and modified the fileset* routines to use the 2239 filesystem interface consistently. 2240 2241 This patch also adds a close() routine to the fileset routines 2242 to indicate that the caller is done with the fileset. This 2243 allows zipfileset to clean up after itself when it creates 2244 tempfiles to store downloads. 2245 2246 https://bugs.webkit.org/show_bug.cgi?id=53326 2247 2248 * Scripts/webkitpy/common/system/directoryfileset.py: 2249 * Scripts/webkitpy/common/system/fileset.py: 2250 * Scripts/webkitpy/common/system/filesystem.py: 2251 * Scripts/webkitpy/common/system/filesystem_mock.py: 2252 * Scripts/webkitpy/common/system/filesystem_unittest.py: 2253 * Scripts/webkitpy/common/system/ospath.py: 2254 * Scripts/webkitpy/common/system/zipfileset.py: 2255 * Scripts/webkitpy/common/system/zipfileset_unittest.py: 2256 22572011-01-30 Balazs Kelemen <kbalazs@webkit.org> 2258 2259 Reviewed by Csaba Osztrogonác. 2260 2261 [Qt][WK2]REGRESSION (r76991): Fix build errors 2262 https://bugs.webkit.org/show_bug.cgi?id=53400 2263 2264 Revert the temporary build fix (http://trac.webkit.org/changeset/77088) 2265 and remove WebKit2Prefix.h from the build. 2266 * MiniBrowser/qt/MiniBrowser.pro: 2267 22682011-01-30 Csaba Osztrogonác <ossy@webkit.org> 2269 2270 Unreviewed. 2271 2272 [Qt][WK2] Buildfix. 2273 2274 * MiniBrowser/qt/MiniBrowser.pro: 2275 22762011-01-28 Simon Fraser <simon.fraser@apple.com> 2277 2278 Reviewed by Adam Roben. 2279 2280 define NOMINMAX when building ImageDiff, as we do elsewhere. 2281 2282 Add various clampToInt() methods to MathExtras.h 2283 https://bugs.webkit.org/show_bug.cgi?id=52910 2284 2285 * DumpRenderTree/win/ImageDiffCommon.vsprops: 2286 22872011-01-28 Maciej Stachowiak <mjs@apple.com> 2288 2289 Reviewed by Darin Adler. 2290 2291 WebKitTestRunner needs layoutTestController.setPOSIXLocale 2292 https://bugs.webkit.org/show_bug.cgi?id=42682 2293 2294 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 2295 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 2296 (WTR::InjectedBundle::resetLocalSettings): 2297 (WTR::InjectedBundle::didReceiveMessage): 2298 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 2299 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 2300 (WTR::LayoutTestController::setPOSIXLocale): 2301 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2302 23032011-01-28 Dirk Pranke <dpranke@chromium.org> 2304 2305 Reviewed by Mihai Parparita. 2306 2307 test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths 2308 2309 This patch re-enables this test and changes it to 2310 handle all of the mac platform versions, not just the one 2311 it is running on. 2312 2313 https://bugs.webkit.org/show_bug.cgi?id=53356 2314 2315 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 2316 23172011-01-28 Dirk Pranke <dpranke@chromium.org> 2318 2319 Unreviewed, build fix. 2320 2321 Take two. The fix in 77023 didn't work, because we were 2322 still calling path.abspath_to_uri, which calls _cygpath under 2323 the covers, and it appears the cygpath on the bots does 2324 something different than it does on my machine. This patch 2325 removes the calls to path.abspath_to_uri, so it should be safe. 2326 If it doesn't work, I'll roll it out along with r76982 and 77023. 2327 2328 https://bugs.webkit.org/show_bug.cgi?id=53126 2329 2330 * Scripts/webkitpy/layout_tests/port/test.py: 2331 23322011-01-28 David Kilzer <ddkilzer@apple.com> 2333 2334 <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 2335 <http://webkit.org/b/53353> 2336 2337 Reviewed by Mark Rowe. 2338 2339 * Scripts/webkitdirs.pm: 2340 (checkRequiredSystemConfig): Check the Xcode marketing version 2341 in addition to the DevCoreTools build version before complaining 2342 about an old version of Xcode. Also make the Mac OS X version 2343 check use Perl's built-in version string comparitor. 2344 23452011-01-28 Dirk Pranke <dpranke@chromium.org> 2346 2347 Unreviewed, build fix. 2348 2349 Work around breakage on Win 7 Release bot caused by r76982 2350 and the fact that windows ports use "file:////" instead of 2351 "file:///". Ideally the test code should be isolated from 2352 this, but it isn't yet. Will fix properly in a bit. 2353 2354 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: 2355 23562011-01-28 Dirk Pranke <dpranke@chromium.org> 2357 2358 Reviewed by Tony Chang. 2359 2360 new-run-webkit-tests: change worker model values to 2361 "old-inline", "old-threads" in preparation for test_runner2 / 2362 multiprocessing changes. 2363 2364 https://bugs.webkit.org/show_bug.cgi?id=53156 2365 2366 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 2367 * Scripts/webkitpy/layout_tests/port/base.py: 2368 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 2369 * Scripts/webkitpy/layout_tests/port/mac.py: 2370 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2371 23722011-01-28 Dirk Pranke <dpranke@chromium.org> 2373 2374 Reviewed by Tony Chang. 2375 2376 committers.py - add an IRC nickname for dpranke 2377 https://bugs.webkit.org/show_bug.cgi?id=53335 2378 2379 * Scripts/webkitpy/common/config/committers.py: 2380 23812011-01-28 Dirk Pranke <dpranke@chromium.org> 2382 2383 Reviewed by Tony Chang. 2384 2385 new-run-webkit-tests: add a "mock DRT" port implementation 2386 and a separate class that emulates what we expect the 2387 DumpRenderTree behavior to be. 2388 2389 This will eventually replace port/dryrun.py and allow us to get 2390 better test coverage of the new-run-webkit-tests code as well as 2391 a reference for what new-run-webkit-tests expects from DRT. 2392 2393 This is the first attempt at this, and it is pretty bare-boned. It 2394 really only has been tested on the 'mac' port (and a little on 2395 the 'chromium-mac' port. 2396 2397 https://bugs.webkit.org/show_bug.cgi?id=53126 2398 2399 * Scripts/webkitpy/common/system/filesystem_mock.py: 2400 * Scripts/webkitpy/layout_tests/port/dryrun.py: 2401 * Scripts/webkitpy/layout_tests/port/factory.py: 2402 * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added. 2403 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added. 2404 * Scripts/webkitpy/layout_tests/port/test.py: 2405 24062011-01-28 Pratik Solanki <psolanki@apple.com> 2407 2408 Unreviewed. Removing .swp file checked in by mistake. 2409 2410 * Scripts/.webkitdirs.pm.swp: Removed. 2411 24122011-01-28 Pratik Solanki <psolanki@apple.com> 2413 2414 Reviewed by David Kilzer. 2415 2416 Space not necessary for undefined feature 2417 https://bugs.webkit.org/show_bug.cgi?id=53317 2418 2419 * Scripts/build-webkit: 2420 24212011-01-28 Chang Shu <chang.shu@nokia.com> 2422 2423 Reviewed by Andreas Kling. 2424 2425 Reset NetworkAccessManager to clean up credentials from previous tests. 2426 This change causes no performance overhead either. 2427 https://bugs.webkit.org/show_bug.cgi?id=36688 2428 2429 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 2430 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 2431 (WebCore::DumpRenderTree::open): 2432 * DumpRenderTree/qt/DumpRenderTreeQt.h: 2433 24342011-01-28 Zoltan Horvath <zoltan@webkit.org> 2435 2436 Reviewed by Andreas Kling. 2437 2438 [Qt] Add Zoom Text Only action to MiniBrowser 2439 https://bugs.webkit.org/show_bug.cgi?id=53297 2440 2441 Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides. 2442 2443 * MiniBrowser/qt/BrowserWindow.cpp: 2444 (BrowserWindow::BrowserWindow): 2445 (BrowserWindow::zoomIn): 2446 (BrowserWindow::zoomOut): 2447 (BrowserWindow::resetZoom): 2448 (BrowserWindow::toggleZoomTextOnly): 2449 (BrowserWindow::applyZoom): 2450 * MiniBrowser/qt/BrowserWindow.h: 2451 24522011-01-28 Adam Barth <abarth@webkit.org> 2453 2454 Reviewed by Eric Seidel. 2455 2456 Add webkit-patch roll-chromium-deps 2457 https://bugs.webkit.org/show_bug.cgi?id=53288 2458 2459 This command updates the Source/WebKit/chromium/DEPS file with the 2460 last-known good revision of Chromium (or a revision specified on the 2461 command line). I'd eventually like to turn this into a SheriffBot 2462 command, but this is the first step. 2463 2464 This patch somewhat sprawled because I needed to move a bunch of code 2465 out of ChangeLog that should never have been there in the first place. 2466 Also, I had to fix a bug in MockUser in order to test the new command. 2467 2468 * Scripts/webkitpy/common/checkout/api.py: 2469 * Scripts/webkitpy/common/checkout/changelog.py: 2470 * Scripts/webkitpy/common/checkout/changelog_unittest.py: 2471 * Scripts/webkitpy/common/checkout/deps.py: Added. 2472 * Scripts/webkitpy/common/config/urls.py: 2473 * Scripts/webkitpy/tool/commands/__init__.py: 2474 * Scripts/webkitpy/tool/commands/download_unittest.py: 2475 * Scripts/webkitpy/tool/commands/roll.py: Added. 2476 * Scripts/webkitpy/tool/commands/roll_unittest.py: Added. 2477 * Scripts/webkitpy/tool/commands/upload_unittest.py: 2478 * Scripts/webkitpy/tool/mocktool.py: 2479 * Scripts/webkitpy/tool/steps/__init__.py: 2480 * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added. 2481 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: 2482 * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added. 2483 * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py: 2484 * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added. 2485 * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: 2486 24872011-01-27 Greg Coletta <greg.coletta@nokia.com> 2488 2489 Reviewed by Laszlo Gombos. 2490 2491 Get rid of prefix header dependency for WebKit2 build system 2492 https://bugs.webkit.org/show_bug.cgi?id=50174 2493 2494 Change the style checker so that it enforces config.h include for 2495 WebKit2. 2496 2497 * Scripts/webkitpy/style/checker.py: 2498 24992011-01-27 Maciej Stachowiak <mjs@apple.com> 2500 2501 Reviewed by Darin Adler. 2502 2503 execCommand("Paste") doesn't work in WebKitTestRunner 2504 https://bugs.webkit.org/show_bug.cgi?id=52785 2505 2506 Enable both of the settings needed to allow paste. 2507 2508 * WebKitTestRunner/TestController.cpp: 2509 (WTR::TestController::resetStateToConsistentValues): 2510 25112011-01-27 Jacob Dinu <dinu.jacob@nokia.com> 2512 2513 Reviewed by Andreas Kling. 2514 2515 [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView 2516 https://bugs.webkit.org/show_bug.cgi?id=48440 2517 2518 Preserve user input when toggling use of QGraphicsView 2519 2520 * QtTestBrowser/launcherwindow.cpp: 2521 (LauncherWindow::initializeView): 2522 (LauncherWindow::loadFinished): 2523 * QtTestBrowser/launcherwindow.h: 2524 * QtTestBrowser/mainwindow.cpp: 2525 (MainWindow::addressUrl): 2526 * QtTestBrowser/mainwindow.h: 2527 25282011-01-27 Dirk Pranke <dpranke@chromium.org> 2529 2530 Reviewed by Mihai Parparita. 2531 2532 new-run-webkit-tests: turn off pixel tests correctly by default 2533 for webkit-based ports. r70013 (bug 47510) used 2534 port.set_option_default() to attempt to set default values, but 2535 that didn't work correctly. I have removed set_option_default 2536 for now since it was only being used in two places and in three 2537 useless unit tests. There is a separate bug open to fix the 2538 option parsing (48095), so this workaround is fine for now. 2539 2540 https://bugs.webkit.org/show_bug.cgi?id=53217 2541 2542 * Scripts/webkitpy/layout_tests/port/webkit.py: 2543 * Scripts/webkitpy/layout_tests/port/base.py: 2544 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 2545 25462011-01-27 Balazs Kelemen <kbalazs@webkit.org> 2547 2548 Rubber-stamped by Ariya Hidayat. 2549 2550 Trivial crash fix in WTR. 2551 2552 * WebKitTestRunner/TestController.cpp: 2553 (WTR::TestController::initialize): Increase the size 2554 of the vector by one to be able to store the null character. 2555 25562011-01-27 Balazs Kelemen <kbalazs@webkit.org> 2557 2558 Reviewed by Csaba Osztrogonác. 2559 2560 [Qt][WK2] WTR should be initialized in the same way as DRT 2561 https://bugs.webkit.org/show_bug.cgi?id=53240 2562 2563 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: 2564 (WTR::activateFonts): Added missing initialization steps. 2565 25662011-01-27 Joone Hur <joone.hur@collabora.co.uk> 2567 2568 Unreviewed. 2569 2570 Adding myself to committers.py. 2571 2572 * Scripts/webkitpy/common/config/committers.py: 2573 25742011-01-27 Laszlo Gombos <laszlo.1.gombos@nokia.com> 2575 2576 Reviewed by Csaba Osztrogonác. 2577 2578 [Qt] [Symbian] Move project files into Source 2579 https://bugs.webkit.org/show_bug.cgi?id=52891 2580 2581 Fix the Symbian build after the project files 2582 are moved to Source directory. On Symbian qmake 2583 needs to run in the same directory where the main 2584 pro files (WebKit.pro, Tools.pro) are located. 2585 2586 * Scripts/webkitdirs.pm: Change to the directory where the pro file 2587 is located before running qmake for Symbian. Qmake on Symbian 2588 does not properly honor the "-o" option, work it around by setting 2589 the name of the Makefile to bld.inf. 2590 25912011-01-27 Zoltan Horvath <zoltan@webkit.org> 2592 2593 Reviewed by Andreas Kling. 2594 2595 [Qt] Add simple zooming features to MiniBrowser 2596 https://bugs.webkit.org/show_bug.cgi?id=53231 2597 2598 Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser. 2599 2600 * MiniBrowser/qt/BrowserWindow.cpp: 2601 (BrowserWindow::BrowserWindow): 2602 (BrowserWindow::zoomIn): 2603 (BrowserWindow::zoomOut): 2604 (BrowserWindow::resetZoom): 2605 (BrowserWindow::updateUserAgentList): 2606 (BrowserWindow::applyZoom): 2607 * MiniBrowser/qt/BrowserWindow.h: 2608 26092011-01-26 Maciej Stachowiak <mjs@apple.com> 2610 2611 Reviewed by Dan Bernstein. 2612 2613 WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector 2614 https://bugs.webkit.org/show_bug.cgi?id=42319 2615 2616 Add evaluateInWebInspector and other APIs needed for inspector tests to run. 2617 2618 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 2619 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 2620 (WTR::LayoutTestController::showWebInspector): 2621 (WTR::LayoutTestController::closeWebInspector): 2622 (WTR::LayoutTestController::evaluateInWebInspector): 2623 (WTR::LayoutTestController::setTimelineProfilingEnabled): 2624 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2625 * WebKitTestRunner/TestInvocation.cpp: 2626 (WTR::shouldOpenWebInspector): 2627 (WTR::TestInvocation::invoke): 2628 * WebKitTestRunner/WebKitTestRunnerPrefix.h: 2629 26302011-01-26 Martin Robinson <mrobinson@igalia.com> 2631 2632 Reviewed by Xan Lopez. 2633 2634 [GTK] Pixel dumps do not include scrollbars in output images 2635 https://bugs.webkit.org/show_bug.cgi?id=53216 2636 2637 Show scrollbars in pixel dumps. This will fix pixel dumps for tests 2638 that have scrollbars. 2639 2640 * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: 2641 (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow 2642 instead of the web view itself. 2643 26442011-01-26 Dirk Pranke <dpranke@chromium.org> 2645 2646 Reviewed by Mihai Parparita. 2647 2648 Fix regression introduced in r76322 ... new-run-webkit-tests 2649 was attempting to save the image diff output as a UTF-8-encoded 2650 file. 2651 2652 https://bugs.webkit.org/show_bug.cgi?id=53210 2653 2654 * Scripts/webkitpy/layout_tests/port/webkit.py: 2655 26562011-01-26 Sheriff Bot <webkit.review.bot@gmail.com> 2657 2658 Unreviewed, rolling out r76709. 2659 http://trac.webkit.org/changeset/76709 2660 https://bugs.webkit.org/show_bug.cgi?id=53194 2661 2662 "broke python tests on non-snowleopard platforms" (Requested 2663 by dpranke on #webkit). 2664 2665 * Scripts/webkitpy/layout_tests/port/factory.py: 2666 * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed. 2667 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed. 2668 26692011-01-26 Dirk Pranke <dpranke@chromium.org> 2670 2671 Reviewed by Tony Chang. 2672 2673 new-run-webkit-tests: add a "mock DRT" port implementation 2674 and a separate class that emulates what we expect the 2675 DumpRenderTree behavior to be. 2676 2677 This will eventually replace port/dryrun.py and allow us to get 2678 better test coverage of the new-run-webkit-tests code as well as 2679 a reference for what new-run-webkit-tests expects from DRT. 2680 2681 This is the first attempt at this, and it is pretty bare-boned. It 2682 really only has been tested on the 'mac' port (and a little on 2683 the 'chromium-mac' port. 2684 2685 https://bugs.webkit.org/show_bug.cgi?id=53126 2686 2687 * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added. 2688 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added. 2689 * Scripts/webkitpy/layout_tests/port/factory.py: 2690 26912011-01-26 Xianzhu Wang <wangxianzhu@google.com> 2692 2693 Reviewed by Tony Chang. 2694 2695 Add '--no-timeout' option to Chromium DRT to ease debugging. 2696 https://bugs.webkit.org/show_bug.cgi?id=52873 2697 2698 * DumpRenderTree/chromium/DumpRenderTree.cpp: 2699 (main): 2700 27012011-01-26 Csaba Osztrogonác <ossy@webkit.org> 2702 2703 Reviewed by Andreas Kling. 2704 2705 [Qt] Fix qt_minimal build 2706 https://bugs.webkit.org/show_bug.cgi?id=53172 2707 2708 * QtTestBrowser/locationedit.h: 2709 27102011-01-26 Mansi Mithal <mansi.mithal@nokia.com> 2711 2712 Reviewed by Antonio Gomes. 2713 2714 QtTestBrowser should have a UI Setting to disable plugins 2715 https://bugs.webkit.org/show_bug.cgi?id=52408 2716 2717 Added a new action item named "Disable Plugins" 2718 under the "Settings" menu. 2719 2720 * QtTestBrowser/launcherwindow.cpp: 2721 (LauncherWindow::createChrome): 2722 (LauncherWindow::togglePlugins): 2723 * QtTestBrowser/launcherwindow.h: 2724 27252011-01-25 Patrick Gansterer <paroga@webkit.org> 2726 2727 Reviewed by Adam Barth. 2728 2729 Move main CMakeLists.txt into Source directory 2730 https://bugs.webkit.org/show_bug.cgi?id=52888 2731 2732 * Scripts/webkitdirs.pm: 2733 27342011-01-25 Patrick Gansterer <paroga@webkit.org> 2735 2736 Reviewed by Eric Seidel. 2737 2738 Improve label text in submit-to-ews 2739 https://bugs.webkit.org/show_bug.cgi?id=53130 2740 2741 * QueueStatusServer/templates/submittoews.html: 2742 27432011-01-25 Mansi Mithal <mansi.mithal@nokia.com> 2744 2745 Reviewed by Antonio Gomes. 2746 2747 QtTestBrowser should have a UI Settings to prevent loading images 2748 https://bugs.webkit.org/show_bug.cgi?id=52409 2749 2750 Added a new action item named "DisableAutoLoadImages" 2751 under the "Settings" menu 2752 2753 * QtTestBrowser/launcherwindow.cpp: 2754 (LauncherWindow::createChrome): 2755 (LauncherWindow::toggleAutoLoadImages): 2756 * QtTestBrowser/launcherwindow.h: 2757 27582011-01-25 Dirk Pranke <dpranke@chromium.org> 2759 2760 Reviewed by Tony Chang. 2761 2762 Minor bug fixes and cleanup for filesystem wrappers, port/* test 2763 classes, test_expectations.py. This change adds "test-win" and 2764 "test-mac" variants to the test port so that we can better test 2765 rebaselining, and adds a MockUser() object for reuse in testing. 2766 2767 https://bugs.webkit.org/show_bug.cgi?id=53036 2768 2769 * Scripts/webkitpy/common/system/filesystem.py: 2770 * Scripts/webkitpy/common/system/filesystem_mock.py: 2771 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 2772 * Scripts/webkitpy/layout_tests/port/factory.py: 2773 * Scripts/webkitpy/layout_tests/port/base.py: 2774 * Scripts/webkitpy/layout_tests/port/test.py: 2775 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2776 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 2777 * Scripts/webkitpy/tool/mocktool.py: 2778 27792011-01-25 Tony Chang <tony@chromium.org> 2780 2781 Reviewed by Dimitri Glazkov. 2782 2783 [chromium] remove unused layoutTestController callback 2784 https://bugs.webkit.org/show_bug.cgi?id=53103 2785 2786 This method is used by a test_shell_test, but not needed by DRT. 2787 2788 * DumpRenderTree/chromium/LayoutTestController.cpp: 2789 (LayoutTestController::LayoutTestController): 2790 * DumpRenderTree/chromium/LayoutTestController.h: 2791 27922011-01-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 2793 2794 Reviewed by Andreas Kling. 2795 2796 [GTK] Remove 64 bits release bot from the buildbot master 2797 https://bugs.webkit.org/show_bug.cgi?id=52899 2798 2799 Removes the 64 bits release slave from the buildbot configuration, 2800 so that we can use it as an EWS. 2801 2802 * BuildSlaveSupport/build.webkit.org-config/config.json: 2803 28042011-01-24 Maciej Stachowiak <mjs@apple.com> 2805 2806 Reviewed by Dan Bernstein. 2807 2808 Implement database quota callback to fix storage tests on WebKit2 bot 2809 https://bugs.webkit.org/show_bug.cgi?id=53064 2810 2811 * WebKitTestRunner/TestController.cpp: 2812 (WTR::exceededDatabaseQuota): 2813 (WTR::TestController::createOtherPage): 2814 (WTR::TestController::initialize): 2815 28162011-01-24 Maciej Stachowiak <mjs@apple.com> 2817 2818 Reviewed by Anders Carlsson. 2819 2820 Use designated temp directory for the database for WebKit2 2821 https://bugs.webkit.org/show_bug.cgi?id=53052 2822 2823 Adopt the new WK2 API for this. 2824 2825 * WebKitTestRunner/TestController.cpp: 2826 (WTR::TestController::libraryPathForTesting): 2827 (WTR::TestController::initialize): 2828 * WebKitTestRunner/TestController.h: 2829 * WebKitTestRunner/mac/TestControllerMac.mm: 2830 (WTR::TestController::platformLibraryPathForTesting): 2831 * WebKitTestRunner/qt/TestControllerQt.cpp: 2832 (WTR::TestController::platformLibraryPathForTesting): 2833 * WebKitTestRunner/win/TestControllerWin.cpp: 2834 (WTR::TestController::platformLibraryPathForTesting): 2835 28362011-01-24 Lucas Forschler <lforschler@apple.com> 2837 2838 Reviewed by Stephanie Lewis. 2839 2840 Add a new Leopard test bot. 2841 2842 * BuildSlaveSupport/build.webkit.org-config/config.json: 2843 28442011-01-24 Gyuyoung Kim <gyuyoung.kim@samsung.com> 2845 2846 Reviewed by Adam Barth. 2847 2848 Add EFL Builder to core waterfall 2849 https://bugs.webkit.org/show_bug.cgi?id=52704 2850 2851 Add EFL Builder to the core waterfall again. 2852 2853 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 2854 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 2855 28562011-01-24 Xianzhu Wang <wangxianzhu@google.com> 2857 2858 Reviewed by Tony Chang. 2859 2860 new-run-webkit-tests fails to start HTTP server if there are proxy settings 2861 https://bugs.webkit.org/show_bug.cgi?id=52872 2862 2863 Force disabling proxy to resolve the problem. 2864 2865 * Scripts/webkitpy/layout_tests/port/http_server_base.py: 2866 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 2867 28682011-01-24 Andreas Kling <kling@webkit.org> 2869 2870 Reviewed by Darin Adler. 2871 2872 check-webkit-style: Update exemptions following Source/ move. 2873 https://bugs.webkit.org/show_bug.cgi?id=53017 2874 2875 * Scripts/webkitpy/style/checker.py: 2876 * Scripts/webkitpy/style/checker_unittest.py: 2877 28782011-01-24 Andras Becsi <abecsi@webkit.org> 2879 2880 Rubber-stamped by Csaba Osztrogonác. 2881 2882 [Qt] Move project files into Source 2883 https://bugs.webkit.org/show_bug.cgi?id=52891 2884 2885 * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path 2886 28872011-01-24 Mikhail Naganov <mnaganov@chromium.org> 2888 2889 Reviewed by Yury Semikhatsky. 2890 2891 Web Inspector: Find duplicate strings in localizedStrings.js 2892 2893 https://bugs.webkit.org/show_bug.cgi?id=53005 2894 2895 * Scripts/check-inspector-strings: 2896 28972011-01-24 Zoltan Horvath <zoltan@webkit.org> 2898 2899 Reviewed by Andreas Kling. 2900 2901 [Qt] Regroup MiniBrowser's menubar and add open file action 2902 https://bugs.webkit.org/show_bug.cgi?id=53000 2903 2904 Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu. 2905 2906 * MiniBrowser/qt/BrowserWindow.cpp: 2907 (BrowserWindow::BrowserWindow): 2908 (BrowserWindow::openFile): 2909 (BrowserWindow::~BrowserWindow): 2910 * MiniBrowser/qt/BrowserWindow.h: 2911 29122011-01-24 Csaba Osztrogonác <ossy@webkit.org> 2913 2914 Unreviewed fix after r76496 2915 2916 [Qt] Move project files into Source 2917 https://bugs.webkit.org/show_bug.cgi?id=52891 2918 2919 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path. 2920 * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path. 2921 * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path. 2922 29232011-01-24 Andras Becsi <abecsi@webkit.org> 2924 2925 Reviewed by Csaba Osztrogonác. 2926 2927 [Qt] Move project files into Source 2928 https://bugs.webkit.org/show_bug.cgi?id=52891 2929 2930 * DerivedSources.pro: Renamed from DerivedSources.pro. 2931 * DumpRenderTree/qt/DumpRenderTree.pro: 2932 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 2933 * MiniBrowser/DerivedSources.pro: 2934 * MiniBrowser/qt/MiniBrowser.pro: 2935 * QtTestBrowser/QtTestBrowser.pro: 2936 * Scripts/webkitdirs.pm: 2937 * Tools.pro: Added. 2938 * WebKitTestRunner/DerivedSources.pro: 2939 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: 2940 * WebKitTestRunner/qt/WebKitTestRunner.pro: 2941 29422011-01-22 Geoffrey Garen <ggaren@apple.com> 2943 2944 Reviewed by Dan Bernstein. 2945 2946 Beefed up --threaded mode to catch even more kinds of errors. 2947 https://bugs.webkit.org/show_bug.cgi?id=52971 2948 2949 * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared 2950 context group to force JSC to mark multiple threads. (This used to be 2951 the default, but it changed in SnowLeopard.) 2952 (runJavaScriptThread): Do more locking and unlocking, and more allocation, 2953 to give threading mistakes more chances to show themselves. 2954 (startJavaScriptThreads): 2955 (stopJavaScriptThreads): 2956 29572011-01-22 Robert Hogan <robert@webkit.org> 2958 2959 Reviewed by Andreas Kling. 2960 2961 [Qt] Support layoutTestController.addURLToRedirect() 2962 https://bugs.webkit.org/show_bug.cgi?id=52956 2963 2964 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 2965 (LayoutTestController::addURLToRedirect): 2966 * DumpRenderTree/qt/LayoutTestControllerQt.h: 2967 29682011-01-22 Robert Hogan <robert@webkit.org> 2969 2970 Reviewed by Kenneth Rohde Christiansen. 2971 2972 [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail 2973 https://bugs.webkit.org/show_bug.cgi?id=49802 2974 2975 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 2976 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 2977 (WebCore::DumpRenderTree::open): 2978 29792011-01-21 Adam Barth <abarth@webkit.org> 2980 2981 Reviewed by Maciej Stachowiak. 2982 2983 Disable mac_unittest.py that fails on some of the Mac bots 2984 https://bugs.webkit.org/show_bug.cgi?id=52947 2985 2986 As noted in the comment, this test does not appear to be correct 2987 because the function this test is testing returns different results 2988 depending on which flavor of Mac the test is run on. This patch 2989 disable the test. Hopefully we can re-enable the test once we've 2990 probably insulated the test from its environment. 2991 2992 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 2993 29942011-01-21 Dirk Pranke <dpranke@chromium.org> 2995 2996 Reviewed by Mihai Parparita. 2997 2998 Fix bug introduced in r76322 that caused NRWT to not actually 2999 read the Skipped files properly. 3000 3001 https://bugs.webkit.org/show_bug.cgi?id=52771 3002 3003 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 3004 * Scripts/webkitpy/layout_tests/port/webkit.py: 3005 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: 3006 30072011-01-21 Sam Weinig <sam@webkit.org> 3008 3009 Reviewed by Geoffrey Sean Garen and Mark Rowe. 3010 3011 WebKitTestRunner needs the HOME environment variable to be set. 3012 <rdar://problem/8896573> 3013 3014 * Scripts/old-run-webkit-tests: Set the HOME environment variable if 3015 it exists. 3016 30172011-01-21 Dirk Pranke <dpranke@chromium.org> 3018 3019 Reviewed by Eric Seidel. 3020 3021 Suppress a few remaining integration tests so that none of the 3022 layout_test unit tests ever read from the filesystem or launch 3023 subprocesses that aren't part of the unit tests. 3024 3025 Also fix a minor bug in the printing unit tests that was 3026 incorrectly relying on sys.argv. 3027 3028 https://bugs.webkit.org/show_bug.cgi?id=52863 3029 3030 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 3031 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 3032 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 3033 30342011-01-21 Darin Adler <darin@apple.com> 3035 3036 Fix Mac build. 3037 3038 * MiniBrowser/mac/BrowserWindowController.m: 3039 (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function. 3040 30412011-01-20 Darin Adler <darin@apple.com> 3042 3043 Reviewed by Dan Bernstein. 3044 3045 WebKit2: Implement showModalDialog 3046 https://bugs.webkit.org/show_bug.cgi?id=52855 3047 3048 This fixes WebKitTestRunner to compile, but more work is probably 3049 needed to get it to pass the tests. 3050 3051 * WebKitTestRunner/TestController.cpp: 3052 (WTR::TestController::runModal): Added. Calls through to the 3053 platform-specific version of runModal. 3054 (WTR::TestController::createOtherPage): Changed to be a private 3055 static member function so it can refer to runModal, which is 3056 a private static member function. 3057 (WTR::TestController::initialize): Pass 0 for the runModal 3058 function since we don't need to run the main window modal. 3059 I suspect this is wrong and will need to change. 3060 * WebKitTestRunner/TestController.h: Added declarations for 3061 the functions added above. 3062 * WebKitTestRunner/mac/TestControllerMac.mm: 3063 (WTR::TestController::runModal): Added. Untested implementation. 3064 * WebKitTestRunner/qt/TestControllerQt.cpp: 3065 (WTR::TestController::runModal): Added. 3066 * WebKitTestRunner/win/TestControllerWin.cpp: 3067 (WTR::TestController::runModal): Added. 3068 30692011-01-21 Eric Seidel <eric@webkit.org> 3070 3071 Reviewed by Adam Barth. 3072 3073 Split Host object off from WebKitPatch for easier re-use 3074 https://bugs.webkit.org/show_bug.cgi?id=52284 3075 3076 new-run-webkit-tests and other tools are eventually going to want one of these. 3077 Basically you need to inherit from this class if you want to pretend to be a 3078 self.tool object for Steps/Commands. 3079 3080 * Scripts/webkitpy/common/host.py: Added. 3081 * Scripts/webkitpy/tool/main.py: 3082 30832011-01-20 Dirk Pranke <dpranke@chromium.org> 3084 3085 Reviewed by Adam Barth. 3086 3087 Disable the tests that start and stop the http server and web 3088 server, so that we don't have to worry about port collisions on 3089 the bots. 3090 3091 https://bugs.webkit.org/show_bug.cgi?id=52861 3092 3093 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 3094 30952011-01-20 Dirk Pranke <dpranke@chromium.org> 3096 3097 Reviewed by Eric Seidel. 3098 3099 nrwt: rewrite google_chrome_unittest to use mock filesystem. 3100 3101 https://bugs.webkit.org/show_bug.cgi?id=52772 3102 3103 * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: 3104 31052011-01-20 Dirk Pranke <dpranke@chromium.org> 3106 3107 Reviewed by Eric Siedel. 3108 3109 nrwt: clean up almost all remaining port references, remove 3110 unnecessary import clauses. The only remaining references are 3111 in places where a mock filesystem makes no sense or can't be 3112 used, and in one routine in port/google_chrome_unittest that 3113 I'll rewrite in a separate patch. 3114 3115 https://bugs.webkit.org/show_bug.cgi?id=52771 3116 3117 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 3118 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 3119 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 3120 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 3121 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 3122 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 3123 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 3124 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 3125 * Scripts/webkitpy/layout_tests/port/google_chrome.py: 3126 * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: 3127 * Scripts/webkitpy/layout_tests/port/gtk.py: 3128 * Scripts/webkitpy/layout_tests/port/mac.py: 3129 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 3130 * Scripts/webkitpy/layout_tests/port/qt.py: 3131 * Scripts/webkitpy/layout_tests/port/webkit.py: 3132 * Scripts/webkitpy/layout_tests/port/win.py: 3133 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 3134 31352011-01-20 Dirk Pranke <dpranke@chromium.org> 3136 3137 Reviewed by Mihai Parparita. 3138 3139 remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests 3140 3141 https://bugs.webkit.org/show_bug.cgi?id=52762 3142 3143 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 3144 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 3145 31462011-01-20 Tony Chang <tony@chromium.org> 3147 3148 Reviewed by Ojan Vafai. 3149 3150 [chromium] fix the paths used for the rebaseline tool 3151 https://bugs.webkit.org/show_bug.cgi?id=52857 3152 3153 Some of the bots were renamed so the path to grab the results zip 3154 file has changed. 3155 3156 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 3157 31582011-01-20 Dirk Pranke <dpranke@chromium.org> 3159 3160 Reviewed by Tony Chang. 3161 3162 Fix bug introduced in r72688 / bug 52768 that broke the 3163 generation of the output filename links in the results.html 3164 output. Apparently none of the unit tests actually checked to 3165 make sure the generated links were correct :( 3166 3167 https://bugs.webkit.org/show_bug.cgi?id=52854 3168 3169 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 3170 * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: 3171 31722011-01-20 Alexey Proskuryakov <ap@apple.com> 3173 3174 Reviewed by Darin Adler. 3175 3176 https://bugs.webkit.org/show_bug.cgi?id=52849 3177 Make window.print work with WebKit2 3178 3179 * MiniBrowser/mac/BrowserWindowController.m: 3180 (-[BrowserWindowController awakeFromNib]): 3181 * WebKitTestRunner/TestController.cpp: 3182 (WTR::createOtherPage): 3183 (WTR::TestController::initialize): 3184 Added zeroes to WKPageUIClient structures to avoid build failures. 3185 31862011-01-20 Dirk Pranke <dpranke@chromium.org> 3187 3188 Reviewed by Eric Seidel. 3189 3190 nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff 3191 3192 https://bugs.webkit.org/show_bug.cgi?id=52756 3193 3194 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 3195 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 3196 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 3197 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 3198 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 3199 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 3200 32012011-01-20 Mansi Mithal <mansi.mithal@nokia.com> 3202 3203 Reviewed by Antonio Gomes. 3204 3205 QtTestBrowser should have a seperate menu for Settings 3206 https://bugs.webkit.org/show_bug.cgi?id=52817 3207 3208 Added a new menu item named "Settings" 3209 and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 3210 3211 * QtTestBrowser/launcherwindow.cpp: 3212 (LauncherWindow::createChrome): 3213 32142011-01-20 Sam Weinig <sam@webkit.org> 3215 3216 Reviewed by John Sullivan. 3217 3218 Update update-webkit-localizable-strings with new path to WebKit. 3219 3220 * Scripts/update-webkit-localizable-strings: 3221 32222011-01-20 James Robinson <jamesr@chromium.org> 3223 3224 Reviewed by Darin Fisher. 3225 3226 Implement mozilla's requestAnimationFrame API 3227 https://bugs.webkit.org/show_bug.cgi?id=51218 3228 3229 Chromium DumpRenderTree support for window.webkitRequestAnimationFrame. 3230 3231 * DumpRenderTree/chromium/WebViewHost.cpp: 3232 (invokeScheduleComposite): 3233 (WebViewHost::scheduleAnimation): 3234 (WebViewHost::paintInvalidatedRegion): 3235 * DumpRenderTree/chromium/WebViewHost.h: 3236 32372011-01-20 Maciej Stachowiak <mjs@apple.com> 3238 3239 Reviewed by Adam Roben. 3240 3241 WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld 3242 https://bugs.webkit.org/show_bug.cgi?id=42327 3243 3244 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support 3245 for methods that take their normal arguments but also a JSContextRef. 3246 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition 3247 for evaluateScriptInIsolatedWorld. 3248 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 3249 (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if 3250 this call is for an isolated world. 3251 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 3252 (WTR::worldMap): Helper to create a world map. 3253 (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world. 3254 (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly 3255 added LayoutTestController API. 3256 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 3257 32582011-01-19 Adam Roben <aroben@apple.com> 3259 3260 Convert paths in environment variables back to msys-style inside commit-log-editor 3261 3262 When this script gets run from inside git commit, msys-style paths in the environment will 3263 have been turned into Windows-style paths with forward slashes. This screws up functions 3264 like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert 3265 the paths back to msys-style before doing anything else. 3266 3267 Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when 3268 using msysgit's Perl and multiple ChangeLogs have been edited 3269 3270 Reviewed by David Kilzer. 3271 3272 * Scripts/commit-log-editor: Call fixEnvironment before doing anything else. 3273 (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from 3274 inside git commit), convert Windows-style paths in the environment back to msys-style paths. 3275 32762011-01-20 Zoltan Horvath <zoltan@webkit.org> 3277 3278 [Win] Unreviewed build fix after r76248. 3279 3280 * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added. 3281 32822011-01-20 Zoltan Horvath <zoltan@webkit.org> 3283 3284 Reviewed by Csaba Osztrogonác. 3285 3286 Refactoring of the custom allocation framework 3287 https://bugs.webkit.org/show_bug.cgi?id=49897 3288 3289 Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589). 3290 The modification replaces Noncopyable and FastAllocBase classes and these inherits with their 3291 equivalent macro implementation at the necessary places. 32922011-01-20 Yi Shen <yi.4.shen@nokia.com> 3293 3294 Unreviewed. 3295 3296 Adding myself to committers.py. 3297 3298 * Scripts/webkitpy/common/config/committers.py: 3299 33002011-01-20 Adam Barth <abarth@webkit.org> 3301 3302 Reviewed by Tony Chang. 3303 3304 Chromium builders don't delete unversioned directories when DEPS change 3305 https://bugs.webkit.org/show_bug.cgi?id=52745 3306 3307 If we pass this option to gclient sync, gclient will delete directories 3308 that are no longer part of DEPS instead of leaving them around to 3309 confuse us later. Apparently, the downstream buildbots use this option 3310 already. 3311 3312 * Scripts/update-webkit-chromium: 3313 33142011-01-19 Dirk Pranke <dpranke@chromium.org> 3315 3316 Unreviewed, build fix - I pulled this patch in to fix an issue 3317 revealed by r76195 running on some new bots). Also fix a couple 3318 of other issues revealed in testing. 3319 3320 nrwt: remove fs refs from layout_package/json* 3321 3322 https://bugs.webkit.org/show_bug.cgi?id=52754 3323 3324 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 3325 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 3326 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: 3327 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 3328 * Scripts/webkitpy/layout_tests/port/base.py: 3329 33302011-01-19 Dirk Pranke <dpranke@chromium.org> 3331 3332 Unreviewed, build fix. 3333 3334 Fix a couple of minor bugs discovered while bringing up new bots 3335 for testing. 3336 3337 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 3338 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 3339 33402011-01-19 James Robinson <jamesr@chromium.org> 3341 3342 Unreviewed, rolling out r76194. 3343 http://trac.webkit.org/changeset/76194 3344 https://bugs.webkit.org/show_bug.cgi?id=51218 3345 3346 Caused mysterious compile failure on the chromium win 3347 build.webkit.org bots 3348 3349 * DumpRenderTree/chromium/WebViewHost.cpp: 3350 (WebViewHost::paintInvalidatedRegion): 3351 * DumpRenderTree/chromium/WebViewHost.h: 3352 33532011-01-19 Dirk Pranke <dpranke@chromium.org> 3354 3355 Reviewed by Mihai Parparita. 3356 3357 remove fs refs from test_runner, dump_render_tree_thread 3358 3359 https://bugs.webkit.org/show_bug.cgi?id=52753 3360 3361 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 3362 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 3363 * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py: 3364 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 3365 33662011-01-19 James Robinson <jamesr@chromium.org> 3367 3368 Reviewed by Darin Fisher. 3369 3370 Implement mozilla's requestAnimationFrame API 3371 https://bugs.webkit.org/show_bug.cgi?id=51218 3372 3373 Chromium DumpRenderTree support for window.webkitRequestAnimationFrame. 3374 3375 * DumpRenderTree/chromium/WebViewHost.cpp: 3376 (invokeScheduleComposite): 3377 (WebViewHost::scheduleAnimation): 3378 (WebViewHost::paintInvalidatedRegion): 3379 * DumpRenderTree/chromium/WebViewHost.h: 3380 33812011-01-19 Dirk Pranke <dpranke@chromium.org> 3382 3383 Unreviewed, build fix. 3384 3385 Fix a few incorrect "self._filesystem" references introduced in 3386 r76184. 3387 3388 * Scripts/webkitpy/layout_tests/port/chromium.py: 3389 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 3390 33912011-01-19 Dirk Pranke <dpranke@chromium.org> 3392 3393 Reviewed by Mihai Parparita. 3394 3395 add a .sep property, abspath(), isabs(), mtime(), and 3396 open_text_file_for_writing() to filesystem modules. Some of 3397 these properties are not needed in this patch but will be needed 3398 in subsequent patches (I'm doing this to avoid having to track 3399 multiple versions of a single file). 3400 3401 Also, change most of the port/* modules to use the filesystem 3402 objects instead of referencing the filesystem directly. 3403 3404 https://bugs.webkit.org/show_bug.cgi?id=52748 3405 3406 * Scripts/webkitpy/common/system/filesystem.py: 3407 * Scripts/webkitpy/common/system/filesystem_mock.py: 3408 * Scripts/webkitpy/layout_tests/port/__init__.py: 3409 * Scripts/webkitpy/layout_tests/port/base.py: 3410 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 3411 * Scripts/webkitpy/layout_tests/port/chromium.py: 3412 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 3413 * Scripts/webkitpy/layout_tests/port/config.py: 3414 * Scripts/webkitpy/layout_tests/port/test.py: 3415 * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: 3416 34172011-01-19 Maciej Stachowiak <mjs@apple.com> 3418 3419 Reviewed by Anders Carlsson. 3420 3421 If resetting between tests times out, treat it as a WebProcess crash 3422 https://bugs.webkit.org/show_bug.cgi?id=52757 3423 3424 * WebKitTestRunner/TestController.cpp: 3425 (WTR::TestController::runTest): 3426 34272011-01-19 Alexey Proskuryakov <ap@apple.com> 3428 3429 Reviewed by Darin Adler. 3430 3431 https://bugs.webkit.org/show_bug.cgi?id=52739 3432 Make it possible for a WebKit2 client to print headers and footers 3433 3434 Added dummy implementations for new printing UIClient calls. 3435 3436 * MiniBrowser/mac/BrowserWindowController.m: 3437 (-[BrowserWindowController awakeFromNib]): 3438 * WebKitTestRunner/TestController.cpp: 3439 (WTR::createOtherPage): 3440 (WTR::TestController::initialize): 3441 34422011-01-19 Dirk Pranke <dpranke@chromium.org> 3443 3444 Reviewed by Ojan Vafai. 3445 3446 Change webkitpy/layout_tests/port/test.py to use the 3447 in-memory filesystem for cleaner unit testing. This 3448 change allows us to kill a lot of code that was 3449 specific to the test port, at the cost of being a 3450 little less clear about how things would work if 3451 you didn't have a filesystem. 3452 3453 https://bugs.webkit.org/show_bug.cgi?id=52605 3454 3455 * Scripts/webkitpy/layout_tests/port/test.py: 3456 34572011-01-19 Dirk Pranke <dpranke@chromium.org> 3458 3459 Unreviewed, build fix. 3460 3461 Fix test failure caused by committing attachment 79368 instead 3462 of attachment 79461 on bug 52604. 3463 3464 * Scripts/webkitpy/common/system/filesystem_mock.py: 3465 34662011-01-19 Dirk Pranke <dpranke@chromium.org> 3467 3468 Reviewed by Mihai Parparita. 3469 3470 new-run-webkit-tests: remove use of os.walk, use mock filesystem for better 3471 unit testing. os.walk() is too much of a hassle to implement on 3472 top of the in-memory mock filesystem and adding the necessary 3473 interface to files_under() gives clients a cleaner API anyway 3474 (for this particular usage model). 3475 3476 https://bugs.webkit.org/show_bug.cgi?id=52691 3477 3478 * Scripts/webkitpy/common/system/filesystem.py: 3479 * Scripts/webkitpy/common/system/filesystem_mock.py: 3480 * Scripts/webkitpy/layout_tests/port/test_files.py: 3481 * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: 3482 34832011-01-19 Dirk Pranke <dpranke@chromium.org> 3484 3485 Reviewed by Tony Chang. 3486 3487 Change more modules in the layout-tests code to use the 3488 filesystem wrapper for cleaner unit testing. 3489 3490 This patch also adds the glob() wrapper to the filesystem 3491 abstraction. 3492 3493 https://bugs.webkit.org/show_bug.cgi?id=52604 3494 3495 * Scripts/webkitpy/layout_tests/port/test_files.py: 3496 * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: 3497 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 3498 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 3499 * Scripts/webkitpy/common/system/filesystem.py: 3500 * Scripts/webkitpy/common/system/filesystem_mock.py: 3501 35022011-01-19 Levi Weintraub <leviw@chromium.org> 3503 3504 Unreviewed. 3505 3506 Updating my email addresses and irc nick. 3507 3508 * Scripts/webkitpy/common/config/committers.py: 3509 35102011-01-19 Tony Chang <tony@chromium.org> 3511 3512 Reviewed by Mihai Parparita. 3513 3514 [chromium] [linux] if check-sys-deps fails, output the failure reason 3515 https://bugs.webkit.org/show_bug.cgi?id=52671 3516 3517 * Scripts/webkitpy/common/system/executive_mock.py: Add support for 3518 error handler functions. 3519 * Scripts/webkitpy/layout_tests/port/chromium.py: 3520 output the error text from --check-sys-deps 3521 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 3522 35232011-01-19 Aparna Nandyal <aparna.nand@wipro.com> 3524 3525 Reviewed by Andreas Kling. 3526 3527 [Qt] QtTestBrowser crashes when closing if Facebook is opened 3528 https://bugs.webkit.org/show_bug.cgi?id=52554 3529 3530 QtNetworkAccessManager is created in a thread and set as 3531 member variable in QWebPage. When the thread is destroyed 3532 the object is still used. So fix will set the object to 3533 NULL once the thread is destroyed. 3534 3535 * QtTestBrowser/launcherwindow.cpp: 3536 (LauncherWindow::~LauncherWindow): 3537 35382011-01-18 Maciej Stachowiak <mjs@apple.com> 3539 3540 Rubber stamped by Csaba Osztrogonac 3541 3542 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h 3543 35442011-01-18 Dirk Pranke <dpranke@chromium.org> 3545 3546 Reviewed by Tony Chang. 3547 3548 new-run-webkit-tests: add a --build-directory command line argument 3549 3550 Official Google Chrome builds use a non-standard build directory 3551 location. This patch adds a --build-directory argument that 3552 allows that location to be specified on the command line. Only 3553 Chromium-based builds will use this flag for now, but anyone can 3554 in the future. 3555 3556 There are no unit tests for this since it's difficult to test 3557 until mock filesystems are fully supported in the code. This was 3558 tested by hand for now. 3559 3560 https://bugs.webkit.org/show_bug.cgi?id=52694 3561 3562 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 3563 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 3564 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 3565 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 3566 35672011-01-18 Maciej Stachowiak <mjs@apple.com> 3568 3569 Not reviewed. Bot fix. 3570 3571 Remove an inadvertently committed debugging print. 3572 3573 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 3574 (LayoutTestController::notifyDone): 3575 35762011-01-18 Maciej Stachowiak <mjs@apple.com> 3577 3578 Reviewed by Sam Weinig. 3579 3580 WebKitTestRunner should track loading more like DumpRenderTree 3581 https://bugs.webkit.org/show_bug.cgi?id=52692 3582 3583 Change load tracking to track the current top loading frame, in the manner of DumpRenderTree. 3584 This makes some tests that call notifyDone multiple times pass. 3585 3586 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 3587 (WTR::InjectedBundle::InjectedBundle): 3588 (WTR::InjectedBundle::done): 3589 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 3590 (WTR::InjectedBundle::topLoadingFrame): 3591 (WTR::InjectedBundle::setTopLoadingFrame): 3592 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 3593 (WTR::InjectedBundlePage::InjectedBundlePage): 3594 (WTR::InjectedBundlePage::stopLoading): 3595 (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): 3596 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): 3597 (WTR::InjectedBundlePage::didFinishLoadForFrame): 3598 (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): 3599 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 3600 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 3601 (WTR::LayoutTestController::notifyDone): 3602 * WebKitTestRunner/TestController.cpp: 3603 (WTR::TestController::didReceiveMessageFromInjectedBundle): 3604 36052011-01-18 Mihai Parparita <mihaip@chromium.org> 3606 3607 Reviewed by Kent Tamura. 3608 3609 [Chromium] NRWT looking for DRT binary in the wrong path on Mac 3610 https://bugs.webkit.org/show_bug.cgi?id=52678 3611 3612 Update path now that WebKit is inside Source. 3613 3614 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 3615 36162011-01-18 Robert Hogan <robert@webkit.org> 3617 3618 Reviewed by Simon Hausmann. 3619 3620 [Qt] http/tests/incremental/slow-utf8-text.pl fails 3621 https://bugs.webkit.org/show_bug.cgi?id=44282 3622 3623 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 3624 (WebCore::DumpRenderTree::dump): 3625 36262011-01-18 Dirk Pranke <dpranke@chromium.org> 3627 3628 Reviewed by Mihai Parparita. 3629 3630 Fix a small race condition that could cause the unit tests for 3631 new-run-webkit-tests to fail in a multithreaded environment. 3632 There was a small window in the code where one thread would 3633 check to see if a thread had raised an exception, do something, 3634 and then check to see if the thread was alive. If the other 3635 thread raised an exception and exited in between these two 3636 steps, the exception would be lost. Flipping the order of the 3637 two checks fixes the race, since we will now always check for an 3638 exception on the thread before exiting. 3639 3640 https://bugs.webkit.org/show_bug.cgi?id=51579 3641 3642 * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: 3643 36442011-01-18 Eric Seidel <eric@webkit.org> 3645 3646 Reviewed by Adam Barth. 3647 3648 commit-queue dies when test archiving fails 3649 https://bugs.webkit.org/show_bug.cgi?id=52617 3650 3651 I looked at the machine and it had 10 archives already 3652 thus find_unused_name was returning None. I've upped 3653 the limit to 100 (per bug) and tested the case where 3654 find_unused_name returns None (making archive return None). 3655 3656 * Scripts/webkitpy/common/system/workspace.py: 3657 * Scripts/webkitpy/common/system/workspace_unittest.py: 3658 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 3659 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 3660 * Scripts/webkitpy/tool/commands/queues.py: 3661 36622011-01-18 Dirk Pranke <dpranke@chromium.org> 3663 3664 Reviewed by Ojan Vafai. 3665 3666 Update rebaseline-chromium-webkit-tests unit tests to use a mock 3667 filesystem. Also fix a couple of "with" statements missed by 3668 r76050. 3669 3670 https://bugs.webkit.org/show_bug.cgi?id=52487 3671 3672 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 3673 36742011-01-18 Sergio Villar Senin <svillar@igalia.com> 3675 3676 Reviewed by Martin Robinson. 3677 3678 [Gtk] Build fixes for gtk3 build 3679 https://bugs.webkit.org/show_bug.cgi?id=52648 3680 3681 * DumpRenderTree/gtk/EventSender.cpp: 3682 (beginDragWithFilesCallback): 3683 36842011-01-18 Dirk Pranke <dpranke@chromium.org> 3685 3686 Reviewed by Mihai Parparita. 3687 3688 Update rebaseline-chromium-webkit-tests to use filesystem objects 3689 instead of direct references to os.path, shutil, tempfile, etc. 3690 3691 This patch doesn't change anything, but will allow subsequent 3692 patches to change the unit tests to no longer use the real 3693 filesystem. 3694 3695 This patch adds a bunch more methods to the filesystem object as 3696 well. 3697 3698 https://bugs.webkit.org/show_bug.cgi?id=52482 3699 3700 * Scripts/webkitpy/common/system/filesystem.py: 3701 * Scripts/webkitpy/common/system/filesystem_mock.py: 3702 * Scripts/webkitpy/tool/commands/queues.py: 3703 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 3704 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 3705 37062011-01-18 Dirk Pranke <dpranke@chromium.org> 3707 3708 Reviewed by Mihai Parparita. 3709 3710 new-run-webkit-tests shouldn't crash when you try to run a 3711 directory containing only skipped files. 3712 3713 https://bugs.webkit.org/show_bug.cgi?id=52478 3714 3715 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 3716 * Scripts/webkitpy/layout_tests/port/test.py: 3717 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 3718 37192011-01-18 Adam Bergkvist <adam.bergkvist@ericsson.com> and Martin Robinson <mrobinson@igalia.com> 3720 3721 Reviewed by Gustavo Noronha Silva. 3722 3723 [GTK] The GTK+ EventSender needs support for beginDragWithFiles 3724 https://bugs.webkit.org/show_bug.cgi?id=40833 3725 3726 * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the 3727 GTK+ event sender. 3728 (dragWithFilesDragDataGetCallback): Added. 3729 (dragWithFilesDragEndCallback): Added. 3730 (beginDragWithFilesCallback): Added. 3731 37322011-01-18 Gyuyoung Kim <gyuyoung.kim@samsung.com> 3733 3734 Reviewed by Adam Barth. 3735 3736 ews: Add additional watcher to efl ews 3737 https://bugs.webkit.org/show_bug.cgi?id=52613 3738 3739 Add gyuyoung.kim@samsung.com to watcher list of efl-ews. 3740 3741 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 3742 37432011-01-17 Tony Gentilcore <tonyg@chromium.org> 3744 3745 Reviewed by Alexey Proskuryakov. 3746 3747 Fix some headers with missing or misspelled #ifndef guards 3748 https://bugs.webkit.org/show_bug.cgi?id=52545 3749 3750 * DumpRenderTree/chromium/TestEventPrinter.h: 3751 * DumpRenderTree/chromium/WebPreferences.h: 3752 37532011-01-17 Jessie Berlin <jberlin@apple.com> 3754 3755 Reviewed by Anders Carlsson. 3756 3757 REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when 3758 navigating back to an unreachable URL 3759 https://bugs.webkit.org/show_bug.cgi?id=52388 3760 3761 Add a third parameter (unreachableURL) to queueLoadHTMLString. 3762 3763 * DumpRenderTree/LayoutTestController.cpp: 3764 (queueLoadHTMLStringCallback): 3765 (LayoutTestController::queueLoadHTMLString): 3766 (LayoutTestController::queueLoadAlternateHTMLString): 3767 * DumpRenderTree/LayoutTestController.h: 3768 3769 * DumpRenderTree/WorkQueueItem.h: 3770 (LoadHTMLStringItem::LoadHTMLStringItem): 3771 3772 * DumpRenderTree/chromium/LayoutTestController.cpp: 3773 (WorkItemLoadHTMLString::WorkItemLoadHTMLString): 3774 (WorkItemLoadHTMLString::run): 3775 (LayoutTestController::queueLoadHTMLString): 3776 3777 * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: 3778 (LoadHTMLStringItem::invoke): 3779 * DumpRenderTree/mac/WorkQueueItemMac.mm: 3780 (LoadHTMLStringItem::invoke): 3781 * DumpRenderTree/win/WorkQueueItemWin.cpp: 3782 (LoadHTMLStringItem::invoke): 3783 37842011-01-17 Dan Bernstein <mitz@apple.com> 3785 3786 Rubber-stamped by Mark Rowe. 3787 3788 Update xcodeproj svn:ignore to include xcuserdata. 3789 3790 * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore. 3791 * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore. 3792 * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore. 3793 * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore. 3794 * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore. 3795 37962011-01-17 Csaba Osztrogonác <ossy@webkit.org> 3797 3798 Unreviewed fix after r75908. 3799 3800 Move WebKit into Source 3801 https://bugs.webkit.org/show_bug.cgi?id=52530 3802 3803 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests. 3804 38052011-01-17 Csaba Osztrogonác <ossy@webkit.org> 3806 3807 Unreviewed. 3808 3809 Remove accidentally committed debug printing after r75908. 3810 3811 * Scripts/webkitdirs.pm: 3812 38132011-01-17 John Knottenbelt <jknotten@chromium.org> 3814 3815 Unreviewed. 3816 3817 Add myself to committers list 3818 https://bugs.webkit.org/show_bug.cgi?id=52566 3819 3820 * Scripts/webkitpy/common/config/committers.py: 3821 38222011-01-17 John Knottenbelt <jknotten@chromium.org> 3823 3824 Reviewed by Jeremy Orlow. 3825 3826 GeolocationController should call stopUpdating on destruction 3827 https://bugs.webkit.org/show_bug.cgi?id=52216 3828 3829 fast/dom/Geolocation/window-close-crash.html requires that a 3830 Geolocation watch be started in a secondary window. Consequently, 3831 we need to allow geolocation permission and provide a mock 3832 geolocation position for the secondary window's 3833 GeolocationClientMock. 3834 3835 * DumpRenderTree/chromium/LayoutTestController.cpp: 3836 (LayoutTestController::setGeolocationPermission): 3837 (LayoutTestController::setMockGeolocationPosition): 3838 (LayoutTestController::setMockGeolocationError): 3839 * DumpRenderTree/chromium/TestShell.h: 3840 (TestShell::windowList): 3841 38422011-01-16 Adam Barth <abarth@webkit.org> 3843 3844 Update more include paths to reflect WebKit move. 3845 3846 * DumpRenderTree/chromium/EventSender.cpp: 3847 (EventSender::keyDown): 3848 (EventSender::needsShiftModifier): 3849 * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: 3850 * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: 3851 38522011-01-16 Kent Tamura <tkent@chromium.org> 3853 3854 Unreviewed, Chromium build fix. 3855 3856 * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium 3857 38582011-01-16 Martin Robinson <mrobinson@igalia.com> 3859 3860 Build fix for GTK+ after source directory movement. 3861 3862 * GNUmakefile.am: Correct include paths. 3863 38642011-01-16 Adam Barth <abarth@webkit.org> 3865 3866 Teach svn-apply about WebKit move. 3867 3868 * Scripts/VCSUtils.pm: 3869 38702011-01-16 Adam Barth <abarth@webkit.org> 3871 3872 Rubber-stamped by Eric Seidel. 3873 3874 Move WebKit into Source 3875 https://bugs.webkit.org/show_bug.cgi?id=52530 3876 3877 * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h: 3878 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 3879 * DumpRenderTree/qt/DumpRenderTreeQt.h: 3880 * DumpRenderTree/qt/GCControllerQt.cpp: 3881 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 3882 * DumpRenderTree/qt/PlainTextControllerQt.cpp: 3883 * DumpRenderTree/qt/TextInputControllerQt.cpp: 3884 * DumpRenderTree/wscript: 3885 * QtTestBrowser/launcherwindow.h: 3886 * Scripts/build-webkit: 3887 * Scripts/webkitdirs.pm: 3888 38892011-01-15 Adam Barth <abarth@webkit.org> 3890 3891 Teach svn-apply about WebKit2 move. 3892 3893 * Scripts/VCSUtils.pm: 3894 38952011-01-15 Adam Barth <abarth@webkit.org> 3896 3897 Rubber-stamped by Eric Seidel. 3898 3899 Move WebKit2 into Source 3900 https://bugs.webkit.org/show_bug.cgi?id=52438 3901 3902 * MiniBrowser/qt/MiniBrowser.pro: 3903 * Scripts/build-webkit: 3904 * Scripts/do-file-rename: 3905 * Scripts/do-webcore-rename: 3906 * Scripts/test-webkitpy: 3907 * Scripts/webkitdirs.pm: 3908 * Scripts/webkitpy/style/checker.py: 3909 * WebKitTestRunner/DerivedSources.pro: 3910 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: 3911 * WebKitTestRunner/qt/WebKitTestRunner.pro: 3912 39132011-01-15 Jochen Eisinger <jochen@chromium.org> 3914 3915 Reviewed by David Levin. 3916 3917 [chromium] remove obsolete createView method 3918 https://bugs.webkit.org/show_bug.cgi?id=52437 3919 3920 * DumpRenderTree/chromium/WebViewHost.cpp: 3921 (WebViewHost::createView): 3922 * DumpRenderTree/chromium/WebViewHost.h: 3923 39242011-01-14 Brian Weinstein <bweinstein@apple.com> 3925 3926 Reviewed by Geoff Garen. 3927 3928 ShouldLoadResourceForFrame should use strings, not URLs. 3929 https://bugs.webkit.org/show_bug.cgi?id=52476 3930 3931 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 3932 (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef. 3933 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 3934 39352011-01-14 Tony Gentilcore <tonyg@chromium.org> 3936 3937 Reviewed by David Levin. 3938 3939 Add Tony Gentilcore as a reviewer 3940 https://bugs.webkit.org/show_bug.cgi?id=52480 3941 3942 * Scripts/webkitpy/common/config/committers.py: 3943 39442011-01-14 David Levin <levin@chromium.org> 3945 3946 Reviewed by Eric Seidel. 3947 3948 check-webkit-style: _FunctionState should keep track of where the function name starts. 3949 https://bugs.webkit.org/show_bug.cgi?id=52454 3950 3951 * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to 3952 _FunctionState and logic for setting it correctly. 3953 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests. 3954 39552011-01-14 Vincent Scheib <scheib@chromium.org> 3956 3957 Reviewed by David Levin. 3958 3959 Add support to DumpRenderTree to use the GPU rather than software renderer 3960 https://bugs.webkit.org/show_bug.cgi?id=52333 3961 3962 * DumpRenderTree/chromium/DumpRenderTree.cpp: 3963 (main): 3964 * Scripts/webkitpy/layout_tests/port/chromium.py: 3965 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 3966 39672011-01-14 Tony Chang <tony@chromium.org> 3968 3969 Reviewed by Kent Tamura. 3970 3971 [chromium] update fonts.conf to fix 6 linux tests in drt 3972 https://bugs.webkit.org/show_bug.cgi?id=52411 3973 3974 * DumpRenderTree/chromium/fonts.conf: Update to match the copy in 3975 chromium's src/webkit/tools/test_shell/resources/fonts.conf 3976 39772011-01-14 Eric Seidel <eric@webkit.org> 3978 3979 Original patch from Peter Gal <galpater@inf.u-szeged.hu> 3980 3981 Reviewed by Adam Barth. 3982 3983 Fix when running Tools/Scripts/check-webkit-style without arguments. 3984 https://bugs.webkit.org/show_bug.cgi?id=52261#c16 3985 3986 * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method. 3987 * Scripts/webkitpy/common/checkout/scm_unittest.py: 3988 39892011-01-04 Jochen Eisinger <jochen@chromium.org> 3990 3991 Reviewed by David Levin. 3992 3993 Store the tempdir object in a variable so it doesn't get deleted too early. 3994 https://bugs.webkit.org/show_bug.cgi?id=51875 3995 3996 * Scripts/update-webkit-auxiliary-libs: 3997 * Scripts/update-webkit-support-libs: 3998 39992011-01-14 Eric Seidel <eric@webkit.org> 4000 4001 Unreviewed. Make it work in python 2.5. 4002 4003 webkit-patch suggest-reviewers dies when ChangeLogs are missing 4004 https://bugs.webkit.org/show_bug.cgi?id=49158 4005 4006 * Scripts/webkitpy/common/checkout/api_unittest.py: 4007 40082011-01-14 Sheriff Bot <webkit.review.bot@gmail.com> 4009 4010 Unreviewed, rolling out r75774. 4011 http://trac.webkit.org/changeset/75774 4012 https://bugs.webkit.org/show_bug.cgi?id=52431 4013 4014 gtk builds were broken (Requested by loislo2 on #webkit). 4015 4016 * Scripts/webkitpy/common/checkout/scm.py: 4017 40182011-01-14 David Levin <levin@chromium.org> 4019 4020 Reviewed by Shinichiro Hamaji. 4021 4022 check-webkit-style: _FunctionState should detect pure functions. 4023 https://bugs.webkit.org/show_bug.cgi?id=52428 4024 4025 * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration 4026 is a pure virtual function. 4027 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure 4028 virtual functions are correctly detected. 4029 40302011-01-13 Ilya Tikhonovsky <loislo@chromium.org> 4031 4032 Reviewed by Yury Semikhatsky. 4033 4034 Just small fix for problem with check-webkit-style. 4035 It just didn't work for this patch. 4036 Old code can't concatenate a list of strings with None. 4037 4038 * Scripts/webkitpy/common/checkout/scm.py: 4039 40402011-01-13 David Levin <levin@chromium.org> 4041 4042 Reviewed by Shinichiro Hamaji. 4043 4044 check-webkit-style: _FunctionState should use Position to know where items are. 4045 https://bugs.webkit.org/show_bug.cgi?id=52424 4046 4047 * Scripts/webkitpy/style/checkers/cpp.py: 4048 (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers. 4049 (detect_functions): Changed to pass Position's to _FunctionState.begin and 4050 did some minor clean-up. 4051 (*): Other changes are simply about converting to use the Position's in_FunctionState 4052 instead of line numbers. 4053 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code 4054 to verify the positions stored in _FunctionState. 4055 40562011-01-13 Eric Seidel <eric@webkit.org> 4057 4058 Reviewed by David Levin. 4059 4060 webkit-patch suggest-reviewers dies when ChangeLogs are missing 4061 https://bugs.webkit.org/show_bug.cgi?id=49158 4062 4063 This is not the most elegant, but it is a very safe fix to this bug. 4064 One advantage of catching ScriptError like this instead of adding a 4065 new added_or_modified_files or fixing all changed_files callers 4066 to use a more specific change_files variant, is that we catch 4067 all kinds of ScriptErrors which might cause our (non-essential) 4068 suggest-reviewers code to fail out. This should make passing 4069 --suggest-reviewers to webkit-patch upload much more robust 4070 and may even make it possible for us to make it default. 4071 4072 The root of the problem here is that SCM.changed_files includes 4073 deleted ChangeLog paths (from moves, etc) which then when we ask 4074 SVN/Git for the contents of the file at that revision, the command 4075 errors out and Executive.run_command raises a ScriptError. 4076 4077 In the future we might fix this differently by making all current 4078 callers of chagned_files use a more specific method for requesting 4079 what types of changes they're interested in (adds, modifies, deletes, etc.) 4080 4081 * Scripts/webkitpy/common/checkout/api.py: 4082 * Scripts/webkitpy/common/checkout/api_unittest.py: 4083 40842011-01-13 Dan Bernstein <mitz@apple.com> 4085 4086 Reviewed by Alexey Proskuryakov. 4087 4088 <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL 4089 https://bugs.webkit.org/show_bug.cgi?id=52419 4090 4091 Allow to further control the behavior of the willSendRequest delegate callback by making it 4092 set a different URL in the new request. 4093 4094 * DumpRenderTree/LayoutTestController.cpp: 4095 (addURLToRedirectCallback): Added. 4096 (LayoutTestController::staticFunctions): Added addURLToRedirect. 4097 (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map. 4098 (LayoutTestController::redirectionDestinationForURL): Added this getter. 4099 * DumpRenderTree/LayoutTestController.h: 4100 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 4101 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check 4102 if there is a redirection for the requestâs URL, established by addURLToRedirect(), and if so, 4103 change the URL in the new request to the redirect destination. 4104 41052011-01-13 Eric Seidel <eric@webkit.org> 4106 4107 Reviewed by Mihai Parparita. 4108 4109 webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files 4110 https://bugs.webkit.org/show_bug.cgi?id=52416 4111 4112 Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 4113 UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data 4114 4115 I also added FIXMEs about the changed_files returning deleted files problem 4116 which is causing the other most common exception for suggest-reviewers 4117 (and is probably breaking sheriff-bots blame detection). 4118 4119 * Scripts/webkitpy/common/checkout/api.py: 4120 * Scripts/webkitpy/common/checkout/api_unittest.py: 4121 * Scripts/webkitpy/common/checkout/scm.py: 4122 41232011-01-13 Eric Seidel <eric@webkit.org> 4124 4125 Reviewed by Adam Barth. 4126 4127 results archives from commit-queue are too large to upload 4128 https://bugs.webkit.org/show_bug.cgi?id=52405 4129 4130 * Scripts/webkitpy/common/system/filesystem.py: 4131 * Scripts/webkitpy/common/system/filesystem_mock.py: 4132 * Scripts/webkitpy/tool/commands/queues.py: 4133 41342011-01-13 Alejandro G. Castro <alex@igalia.com> 4135 4136 Reviewed by Martin Robinson. 4137 4138 [gtk] Zero-sized font does not yet work 4139 https://bugs.webkit.org/show_bug.cgi?id=49793 4140 4141 Set minimum-font-size to 0 for the DRT. 4142 4143 * DumpRenderTree/gtk/DumpRenderTree.cpp: 4144 (resetDefaultsToConsistentValues): 4145 41462011-01-13 Csaba Osztrogonác <ossy@webkit.org> 4147 4148 Reviewed by Darin Adler. 4149 4150 Make old-run-webkit-tests more robust on buildbots 4151 https://bugs.webkit.org/show_bug.cgi?id=52364 4152 4153 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script. 4154 41552011-01-13 Csaba Osztrogonác <ossy@webkit.org> 4156 4157 Reviewed by Darin Adler. 4158 4159 Make old-run-webkit-tests more robust on buildbots 4160 https://bugs.webkit.org/show_bug.cgi?id=52364 4161 4162 * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty. 4163 41642011-01-13 Tony Chang <tony@chromium.org> 4165 4166 Reviewed by Kent Tamura. 4167 4168 [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac 4169 https://bugs.webkit.org/show_bug.cgi?id=52332 4170 4171 Forked Info.plist is not longer needed. 4172 4173 * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed. 4174 41752011-01-13 Mikhail Naganov <mnaganov@chromium.org> 4176 4177 Reviewed by Timothy Hatcher. 4178 4179 Web Inspector: Cleanup after r75613 -- make all UI-facing strings 4180 to be passed directly to WebInspector.UIString 4181 4182 https://bugs.webkit.org/show_bug.cgi?id=52365 4183 4184 * Scripts/check-inspector-strings: 4185 41862011-01-13 Sheriff Bot <webkit.review.bot@gmail.com> 4187 4188 Unreviewed, rolling out r74881. 4189 http://trac.webkit.org/changeset/74881 4190 https://bugs.webkit.org/show_bug.cgi?id=52357 4191 4192 The EFL builder has been red for days (Requested by abarth on 4193 #webkit). 4194 4195 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 4196 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 4197 41982011-01-12 Maciej Stachowiak <mjs@apple.com> 4199 4200 Reviewed by David Levin. 4201 4202 Add beforeunload support to WebKitTestRunner 4203 https://bugs.webkit.org/show_bug.cgi?id=52353 4204 4205 This makes a number of currently failing tests pass. 4206 4207 * WebKitTestRunner/TestController.cpp: 4208 (WTR::runBeforeUnloadConfirmPanel): 4209 (WTR::createOtherPage): 4210 (WTR::TestController::initialize): 4211 42122011-01-12 Maciej Stachowiak <mjs@apple.com> 4213 4214 Reviewed by Sam Weinig. 4215 4216 Detect, identify and recover from WebProcess crashes in run-webkit-tests 4217 https://bugs.webkit.org/show_bug.cgi?id=52330 4218 4219 * Scripts/old-run-webkit-tests: Detect when the regression test tool reports 4220 a web process crash. 4221 * WebKitTestRunner/TestController.cpp: 4222 (WTR::TestController::initialize): Set up a processDidCrash 4223 callback. 4224 (WTR::TestController::processDidCrash): Report that the Web process 4225 crashed. 4226 * WebKitTestRunner/TestController.h: 4227 42282011-01-12 David Levin <levin@chromium.org> 4229 4230 Reviewed by Shinichiro Hamaji. 4231 4232 check-webkit-style -- close_expression function doesn't work correctly. 4233 https://bugs.webkit.org/show_bug.cgi?id=52272 4234 4235 * Scripts/webkitpy/style/checkers/cpp.py: 4236 (Position.__str__): Added a way to convert it to a string which is useful in tests. 4237 (Position.__cmp__): Added a way to compare Position which is useful in tests and 4238 generally useful (for upcoming code changes). 4239 (close_expression): Changed to use Position for input and output. 4240 Also, fixed many bugs such as only working correctly for parenthesis, 4241 not working correctly if given an offset in a line and not finding 4242 the real closing element if there were multiple closing elements in 4243 the same line. 4244 (detect_functions): Adjusted due to the change in arguments for 4245 close_expression. 4246 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 4247 (CppStyleTestBase.assert_positions_equal): Added a way to verify that 4248 two positions are the same. 4249 (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods. 4250 (CppStyleTest.test_close_expression): Added tests to catch the issues 4251 that were fixed. 4252 42532011-01-12 Sheriff Bot <webkit.review.bot@gmail.com> 4254 4255 Unreviewed, rolling out r75576. 4256 http://trac.webkit.org/changeset/75576 4257 https://bugs.webkit.org/show_bug.cgi?id=52304 4258 4259 broke rebaseline-chromium-webkit-test (Requested by thakis on 4260 #webkit). 4261 4262 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 4263 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 4264 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 4265 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 4266 * Scripts/webkitpy/layout_tests/port/base.py: 4267 * Scripts/webkitpy/layout_tests/port/chromium.py: 4268 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 4269 * Scripts/webkitpy/layout_tests/port/test.py: 4270 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 4271 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 4272 * Scripts/webkitpy/style/checkers/test_expectations.py: 4273 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: 4274 42752011-01-12 Maciej Stachowiak <mjs@apple.com> 4276 4277 Reviewed by Darin Adler. 4278 4279 Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR 4280 https://bugs.webkit.org/show_bug.cgi?id=52307 4281 4282 * Scripts/old-run-webkit-tests: 4283 42842011-01-12 Koan-Sin Tan <koansin.tan@gmail.com> 4285 4286 Reviewed by Martin Robinson. 4287 4288 [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6 4289 https://bugs.webkit.org/show_bug.cgi?id=50867 4290 4291 Fixed library extention for Mac in webkitdirs.pm and type conflict in 4292 TestNetscapePlugin.cpp 4293 4294 * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+ 4295 * Scripts/webkitdirs.pm: 4296 42972011-01-12 Mikhail Naganov <mnaganov@chromium.org> 4298 4299 Reviewed by Pavel Feldman. 4300 4301 Add check-inspector-strings script. 4302 4303 https://bugs.webkit.org/show_bug.cgi?id=52295 4304 4305 * Scripts/check-inspector-strings: Added. 4306 43072011-01-12 Adam Roben <aroben@apple.com> 4308 4309 Advertise the .testnetscape file extension on Windows 4310 4311 Fixes <http://webkit.org/b/52298> 4312 plugins/no-mime-with-valid-extension.html fails on Windows 4313 4314 Reviewed by Dan Bernstein. 4315 4316 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a 4317 FileExtents field to map the .testnetscape file extension to the 4318 application/x-webkit-test-netscape MIME type, just as we do on Mac. 4319 43202011-01-12 Adam Barth <abarth@webkit.org> 4321 4322 Reviewed by Eric Seidel. 4323 4324 Make webkit-patch support subdirectories for SVN checkouts 4325 https://bugs.webkit.org/show_bug.cgi?id=52261 4326 4327 os.relpath does not exist on Python 2.5, so we need to call our version 4328 of the API. 4329 4330 * Scripts/webkitpy/common/checkout/scm.py: 4331 43322011-01-11 Maciej Stachowiak <mjs@apple.com> 4333 4334 Reviewed by Eric Seidel. 4335 4336 Close additional pages opened during a test once the test completes. 4337 https://bugs.webkit.org/show_bug.cgi?id=52276 4338 4339 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 4340 (WTR::InjectedBundle::done): 4341 43422011-01-11 David Levin <levin@chromium.org> 4343 4344 Reviewed by Eric Seidel. 4345 4346 Errors should be separated from the command line in bot messages. 4347 https://bugs.webkit.org/show_bug.cgi?id=52275 4348 4349 * Scripts/webkitpy/common/system/executive.py: 4350 (ScriptError.message_with_output): Added a newline to separate the command 4351 line from the errors. 4352 * Scripts/webkitpy/common/system/executive_unittest.py: 4353 (ScriptErrorTest.test_message_with_output): Added tests for the various code 4354 paths in message_with_output. 4355 43562011-01-11 Eric Seidel <eric@webkit.org> 4357 4358 Unreviewed. 4359 4360 commit-queue should know how to upload archived results (for test flakes or general failures) 4361 https://bugs.webkit.org/show_bug.cgi?id=52048 4362 4363 The zips are mostly empty due to forgetting -r. 4364 Expected diffs were not being pulled from the archive due 4365 to the archive having longer paths than I realized. 4366 4367 * Scripts/webkitpy/common/system/workspace.py: 4368 * Scripts/webkitpy/common/system/workspace_unittest.py: 4369 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 4370 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: 4371 43722011-01-11 Dirk Pranke <dpranke@chromium.org> 4373 4374 Reviewed by Ojan Vafai. 4375 4376 The current modifier parsing code in test_expectations is 4377 fragile and hard-coded, so it's not easy to understand the logic 4378 or easily add new types of modifiers (like GPU vs. CPU testing 4379 for graphics tests, or 32-bit vs. 64-bit differences). 4380 4381 This is the first of two patches that will add in more generic 4382 support and then eliminate the GPU-specific test expectations 4383 files for Chromium. 4384 4385 This patch adds two standalone objects for handling modifiers. The 4386 rules for interpreting modifiers, precedence, and conflicts are 4387 given in the docstring to the ModifierMatcher class, which 4388 returns ModifierMatchResult objects. 4389 4390 This patch also adds routines to the Port interface and a 4391 default set of values in the base object, in order to obtain the 4392 values needed on a given test run. These values are then passed 4393 to the expectation parser. This also allows us to clean up the 4394 logic used to lint all of the different configurations in a 4395 single test_expectations.txt file. 4396 4397 The next patch will merge in the separate GPU expectations file. 4398 4399 https://bugs.webkit.org/show_bug.cgi?id=51222 4400 4401 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 4402 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 4403 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 4404 * Scripts/webkitpy/layout_tests/port/base.py: 4405 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 4406 * Scripts/webkitpy/layout_tests/port/chromium.py: 4407 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 4408 * Scripts/webkitpy/layout_tests/port/test.py: 4409 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 4410 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 4411 44122011-01-11 Maciej Stachowiak <mjs@apple.com> 4413 4414 Reviewed by Adam Barth. 4415 4416 Make webkit-patch support subdirectories for SVN checkouts 4417 https://bugs.webkit.org/show_bug.cgi?id=52261 4418 4419 * Scripts/webkitpy/common/checkout/scm.py: 4420 * Scripts/webkitpy/style_references.py: 4421 * Scripts/webkitpy/tool/main.py: 4422 * Scripts/webkitpy/tool/steps/preparechangelog.py: 4423 44242011-01-11 Eric Seidel <eric@webkit.org> 4425 4426 Unreviewed. 4427 4428 commit-queue should know how to upload archived results (for test flakes or general failures) 4429 https://bugs.webkit.org/show_bug.cgi?id=52048 4430 4431 I changed the API for archive_last_layout_test_results w/o updating the implementation. Oops. 4432 This fixes an exception seen on the commit-queue when attempting to report flaky tests. 4433 4434 * Scripts/webkitpy/common/system/workspace.py: 4435 * Scripts/webkitpy/common/system/workspace_unittest.py: 4436 * Scripts/webkitpy/tool/commands/queues.py: 4437 44382011-01-11 Sam Weinig <sam@webkit.org> 4439 4440 Roll r75474 back in. 4441 44422011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 4443 4444 Reviewed by Kenneth Rohde Christiansen. 4445 4446 [Qt] Remove uses of QFuture since it isn't supported on all platforms. 4447 https://bugs.webkit.org/show_bug.cgi?id=51204 4448 4449 * QtTestBrowser/webpage.h: 4450 (QtNAMThread::QtNAMThread): 4451 (QtNAMThread::networkAccessManager): 4452 (QtNAMThread::run): 4453 44542011-01-11 Peter Varga <pvarga@webkit.org> 4455 4456 Unreviewed. 4457 4458 Add myself to committers' list. 4459 4460 * Scripts/webkitpy/common/config/committers.py: 4461 44622011-01-11 Eric Seidel <eric@webkit.org> 4463 4464 Reviewed by Adam Barth. 4465 4466 commit-queue should know how to upload archived results (for test flakes or general failures) 4467 https://bugs.webkit.org/show_bug.cgi?id=52048 4468 4469 Now the queue will always upload results. Either the entire zip, or just 4470 the diffs.txt in the case of text failures. 4471 4472 This should make understanding flakes much easier, and paves the way 4473 for having the EWS run layout tests (and upload failures). 4474 4475 In order to upload .zip files I had to teach bugzilla.py to autodetect 4476 mime types from the filename. Since mimetypes.py doesn't include a mapping 4477 for .patch files, I have it add one before calling guess_type. 4478 4479 We may find that always uploading the whole zip instead of just the -diffs.txt 4480 file is preferable, but for now I'm keeping the old behavior because it makes 4481 quickly understanding text failures easy. 4482 4483 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 4484 * Scripts/webkitpy/common/system/workspace.py: Added. 4485 * Scripts/webkitpy/common/system/workspace_unittest.py: Added. 4486 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 4487 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 4488 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 4489 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: 4490 * Scripts/webkitpy/tool/commands/queues.py: 4491 * Scripts/webkitpy/tool/commands/queues_unittest.py: 4492 44932011-01-10 Sheriff Bot <webkit.review.bot@gmail.com> 4494 4495 Unreviewed, rolling out r75464. 4496 http://trac.webkit.org/changeset/75464 4497 https://bugs.webkit.org/show_bug.cgi?id=52193 4498 4499 Followup rollout for 75474 (Requested by Ossy on #webkit). 4500 4501 * MiniBrowser/mac/BrowserWindowController.m: 4502 (-[BrowserWindowController awakeFromNib]): 4503 * MiniBrowser/win/BrowserView.cpp: 4504 (BrowserView::create): 4505 * WebKitTestRunner/TestController.cpp: 4506 (WTR::createOtherPage): 4507 (WTR::TestController::initialize): 4508 45092011-01-10 Laszlo Gombos <laszlo.1.gombos@nokia.com> 4510 4511 Reviewed by Csaba Osztrogonác. 4512 4513 [Qt] Baseline qt_minimal configuration 4514 https://bugs.webkit.org/show_bug.cgi?id=51313 4515 4516 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 4517 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add 4518 QT_NO_UNDOSTACK guard. 4519 4520 * QtTestBrowser/launcherwindow.cpp: 4521 (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER 4522 guards. 4523 (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard. 4524 (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard. 4525 (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard. 4526 (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard. 4527 4528 * QtTestBrowser/launcherwindow.h: 4529 * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard. 4530 * QtTestBrowser/locationedit.h: Ditto. 4531 4532 * QtTestBrowser/mainwindow.cpp: 4533 (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and 4534 QT_NO_UNDOSTACK guards. 4535 (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard. 4536 (MainWindow::changeLocation): Ditto. 4537 (MainWindow::openFile): Add QT_NO_FILEDIALOG guard. 4538 (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard. 4539 4540 * QtTestBrowser/webpage.cpp: 4541 (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard. 4542 (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard. 4543 4544 * QtTestBrowser/webview.cpp: 4545 (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard. 4546 (WebViewGraphicsBased::animatedYFlip): Ditto. 4547 45482011-01-10 Sam Weinig <sam@webkit.org> 4549 4550 Fix build. 4551 4552 * MiniBrowser/mac/BrowserWindowController.m: 4553 (-[BrowserWindowController awakeFromNib]): 4554 * MiniBrowser/win/BrowserView.cpp: 4555 (BrowserView::create): 4556 * WebKitTestRunner/TestController.cpp: 4557 (WTR::createOtherPage): 4558 (WTR::TestController::initialize): 4559 45602011-01-10 Eric Seidel <eric@webkit.org> 4561 4562 Reviewed by Ojan Vafai. 4563 4564 style-queue messages are way too long for big patches 4565 https://bugs.webkit.org/show_bug.cgi?id=52161 4566 4567 We definitely could build much fancier list-to-string-with-limit functions 4568 but this should be sufficient for our needs at the moment. 4569 4570 * Scripts/webkitpy/common/system/executive.py: 4571 * Scripts/webkitpy/common/system/executive_unittest.py: 4572 45732011-01-10 Tony Chang <tony@chromium.org> 4574 4575 Unreviewed, rolling out r75398. 4576 http://trac.webkit.org/changeset/75398 4577 https://bugs.webkit.org/show_bug.cgi?id=52008 4578 4579 Some layout tests are crashing on Chromium Win. 4580 4581 * DumpRenderTree/chromium/WebViewHost.cpp: 4582 (WebViewHost::updatePaintRect): 4583 * DumpRenderTree/chromium/WebViewHost.h: 4584 45852011-01-10 Adam Roben <aroben@apple.com> 4586 4587 Roll out r75392 4588 4589 It isn't needed now that r75289 has been rolled out. 4590 4591 * Scripts/run-javascriptcore-tests: 4592 45932011-01-10 Maciej Stachowiak <mjs@apple.com> 4594 4595 Reviewed by Anders Carlsson. 4596 4597 WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky 4598 https://bugs.webkit.org/show_bug.cgi?id=52160 4599 4600 * WebKitTestRunner/mac/TestControllerMac.mm: 4601 (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout. 4602 Anything that can make runUntil() conditions turn true will happen on a run loop cycle 4603 anyway. 4604 46052011-01-10 Tony Chang <tony@chromium.org> 4606 4607 Reviewed by Mihai Parparita. 4608 4609 [chromium] fix for animated gif layout tests 4610 https://bugs.webkit.org/show_bug.cgi?id=52008 4611 4612 * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect 4613 to trigger gif animations. 4614 (WebViewHostPaintTask::WebViewHostPaintTask): 4615 (WebViewHostPaintTask::runIfValid): 4616 (WebViewHost::updatePaintRect): 4617 * DumpRenderTree/chromium/WebViewHost.h: 4618 (WebViewHost::taskList): 4619 46202011-01-10 Alejandro G. Castro <alex@igalia.com> 4621 4622 Reviewed by Xan Lopez. 4623 4624 [GTK] Fix gtk2 compilation for master 4625 https://bugs.webkit.org/show_bug.cgi?id=51885 4626 4627 * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: 4628 (createBitmapContextFromWebView): Replaced the old 4629 gdk_drawable_get_size with gdk_pixmap_get_size. 4630 46312011-01-10 Patrick Gansterer <paroga@webkit.org> 4632 4633 Reviewed by Laszlo Gombos. 4634 4635 [WINCE] Reenable NPAPI after r75203 4636 https://bugs.webkit.org/show_bug.cgi?id=52109 4637 4638 Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace 4639 it with !isEfl(), because EFL port does not support NPAPI (yet). 4640 4641 * Scripts/build-webkit: 4642 46432011-01-10 Adam Roben <aroben@apple.com> 4644 4645 Skip some asserting JS tests 4646 4647 See <http://webkit.org/b/52156>. 4648 4649 * Scripts/run-javascriptcore-tests: 4650 46512011-01-10 Martin Robinson <mrobinson@igalia.com> 4652 4653 Reviewed by Xan Lopez. 4654 4655 [GTK] build-webkit disable Blob support via arguments passed to automake 4656 https://bugs.webkit.org/show_bug.cgi?id=52097 4657 4658 * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via 4659 build-webkit. 4660 46612011-01-10 Adam Roben <aroben@apple.com> 4662 4663 Use the same name and description for TestNetscapePlugin on Windows and 4664 Mac 4665 4666 Fixes <http://webkit.org/b/52151> 4667 fast/frames/iframe-reparenting-plugins.html fails on Windows 4668 4669 Reviewed by Steve Falkenburg. 4670 4671 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied 4672 the name and description from Mac's Info.plist. 4673 46742011-01-10 Siddharth Mathur <siddharth.mathur@nokia.com> 4675 4676 Reviewed by Laszlo Gombos. 4677 4678 [Qt][WK2] Guard gcc-specific syntax 4679 4680 Non-gcc based compliers choke on the "-include" 4681 syntax for preinclude, place guard around it. 4682 4683 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: 4684 * WebKitTestRunner/qt/WebKitTestRunner.pro: 4685 46862011-01-10 Andreas Kling <kling@webkit.org> 4687 4688 Reviewed by Simon Hausmann. 4689 4690 [Qt] [WK2] MiniBrowser does not load pages opened in new windows 4691 https://bugs.webkit.org/show_bug.cgi?id=52111 4692 4693 When getting a createNewPage() callback from QWKPage, create the 4694 new page with the same QWKContext as the page that is passed to 4695 the callback. 4696 4697 * MiniBrowser/qt/BrowserView.h: 4698 * MiniBrowser/qt/BrowserWindow.cpp: 4699 (newPageFunction): 4700 (BrowserWindow::BrowserWindow): 4701 * MiniBrowser/qt/BrowserWindow.h: 4702 47032011-01-10 Andreas Kling <kling@webkit.org> 4704 4705 Reviewed by Kenneth Rohde Christiansen. 4706 4707 [Qt] MiniBrowser: Remove superfluous createNewPage() callback 4708 4709 BrowserView set its own useless createNewPage() callback on QWKPage. 4710 This was immediately overridden by BrowserWindow anyway, so remove 4711 the BrowserView one. 4712 4713 * MiniBrowser/qt/BrowserView.cpp: 4714 (BrowserView::BrowserView): 4715 47162011-01-10 John Knottenbelt <jknotten@chromium.org> 4717 4718 Reviewed by Jeremy Orlow. 4719 4720 [Chromium] Remove non-client-based Geolocation code 4721 https://bugs.webkit.org/show_bug.cgi?id=50921 4722 4723 * DumpRenderTree/chromium/LayoutTestController.cpp: 4724 (LayoutTestController::setGeolocationPermission): 4725 (LayoutTestController::setMockGeolocationPosition): 4726 (LayoutTestController::setMockGeolocationError): 4727 * DumpRenderTree/chromium/WebViewHost.cpp: 4728 (WebViewHost::geolocationClientMock): 4729 (WebViewHost::reset): 4730 * DumpRenderTree/chromium/WebViewHost.h: 4731 47322011-01-10 Eric Seidel <eric@webkit.org> 4733 4734 Reviewed by Adam Barth. 4735 4736 Commit bot tried to land r? cq+ patch 4737 https://bugs.webkit.org/show_bug.cgi?id=36638 4738 4739 It should now be possible to post a patch with r? and cq+ and the 4740 commit-queue will correctly wait for the r+ before attempting to land the patch. 4741 (This was a feature requested by several users.) 4742 4743 One caveat: We don't actually reject r-, cq+ patches from the queue 4744 (we just ignore them), but I think that's OK for now. 4745 4746 I also noticed that setting r- once a commit-queue node had grabbed 4747 a patch would not properly cancel the landing. That's fixed and 4748 tested in this patch. 4749 4750 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 4751 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 4752 * Scripts/webkitpy/tool/bot/feeders.py: 4753 * Scripts/webkitpy/tool/bot/feeders_unittest.py: 4754 47552011-01-08 Benjamin Poulain <benjamin.poulain@nokia.com> 4756 4757 Reviewed by Kenneth Rohde Christiansen. 4758 4759 [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event 4760 https://bugs.webkit.org/show_bug.cgi?id=51934 4761 4762 When accessing the network from the destructor of QWebPage, the network access manager 4763 was already deleted because the object WebPage was already destructed. 4764 4765 This solve the problem by linking the lifetime of the network access manager to WebPage's QObject. 4766 The object is now destructed in the destructor of QObject. 4767 4768 * QtTestBrowser/webpage.cpp: 4769 (WebPage::WebPage): 4770 (WebPage::setQnamThreaded): 4771 * QtTestBrowser/webpage.h: 4772 (QtNAMThread::QtNAMThread): 4773 47742011-01-08 Eric Seidel <eric@webkit.org> 4775 4776 Reviewed by Ojan Vafai. 4777 4778 test_failures.py should not mention TestShell (long live DumpRenderTree!) 4779 https://bugs.webkit.org/show_bug.cgi?id=52067 4780 4781 I ran test-webkitpy, but didn't bother adding a unit test for this string change. 4782 https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed. 4783 4784 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 4785 47862011-01-08 Eric Seidel <eric@webkit.org> 4787 4788 Reviewed by Mihai Parparita. 4789 4790 commit-queue hangs when the ChangeLog diff is bad 4791 https://bugs.webkit.org/show_bug.cgi?id=52072 4792 4793 * Scripts/webkitpy/tool/steps/validatechangelogs.py: 4794 * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: 4795 47962011-01-08 Adam Barth <abarth@webkit.org> 4797 4798 Teach svn-apply how to re-write WebCore to Source/WebCore. 4799 4800 * Scripts/VCSUtils.pm: 4801 48022011-01-07 Adam Barth <abarth@webkit.org> 4803 4804 Rubber-stamped by Eric Seidel. 4805 4806 Move WebCore to Source 4807 https://bugs.webkit.org/show_bug.cgi?id=52050 4808 4809 Update the tools to understand WebCore's new location. 4810 4811 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 4812 * DumpRenderTree/wscript: 4813 * GNUmakefile.am: 4814 * Scripts/build-webkit: 4815 * Scripts/do-file-rename: 4816 * Scripts/do-webcore-rename: 4817 * Scripts/generate-qt-inspector-resource: 4818 * Scripts/prepare-ChangeLog: 4819 * Scripts/run-bindings-tests: 4820 * Scripts/update-iexploder-cssproperties: 4821 * Scripts/update-sources-list.py: 4822 * Scripts/update-webkit-localizable-strings: 4823 * Scripts/webkitdirs.pm: 4824 * Scripts/webkitpy/common/config/build.py: 4825 * Scripts/webkitpy/common/config/build_unittest.py: 4826 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 4827 * Scripts/webkitpy/style/checker.py: 4828 * Scripts/webkitpy/style/checker_unittest.py: 4829 * WebKitTestRunner/DerivedSources.pro: 4830 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: 4831 * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: 4832 * wx/browser/wscript: 4833 * wx/build/settings.py: 4834 48352011-01-07 Maciej Stachowiak <mjs@apple.com> 4836 4837 Reviewed by Sam Weinig. 4838 4839 Make WebKitTestRunner rest between loads more robust to avoid test crashes 4840 https://bugs.webkit.org/show_bug.cgi?id=52086 4841 4842 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 4843 (WTR::InjectedBundle::didReceiveMessage): 4844 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 4845 (WTR::LayoutTestController::notifyDone): 4846 * WebKitTestRunner/TestController.cpp: 4847 (WTR::TestController::resetStateToConsistentValues): 4848 (WTR::TestController::run): 4849 48502011-01-07 James Robinson <jamesr@chromium.org> 4851 4852 Revert "Implement mozilla's animationTime property" 4853 https://bugs.webkit.org/show_bug.cgi?id=51952 4854 4855 This approach isn't quite right. 4856 4857 * DumpRenderTree/chromium/WebViewHost.cpp: 4858 (WebViewHost::paintInvalidatedRegion): 4859 48602011-01-07 Adam Roben <aroben@apple.com> 4861 4862 Build master fix 4863 4864 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 4865 (RunWebKitTests.start): Don't try to concatenate a list and a string. 4866 48672011-01-07 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> 4868 4869 Reviewed by Csaba Osztrogonác. 4870 4871 run-qtwebkit-tests should be able to kill a testsuite. 4872 4873 Add new option in the script that can setup a timeout for a test. 4874 If the test execution takes more then specified time then the test 4875 would be terminated. 4876 4877 [Qt] run-qtwebkit-tests needs timeout 4878 https://bugs.webkit.org/show_bug.cgi?id=51894 4879 4880 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 4881 * Scripts/run-qtwebkit-tests: 4882 48832011-01-07 Csaba Osztrogonác <ossy@webkit.org> 4884 4885 Unreviewed fix after r75233. 4886 4887 Based on idea from Eric Seidel. 4888 4889 Add remote zip file handling to webkitpy. 4890 https://bugs.webkit.org/show_bug.cgi?id=50901 4891 4892 * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy. 4893 48942011-01-07 Shane Stephens <shanestephens@google.com> 4895 4896 Reviewed by Eric Seidel. 4897 4898 svn-apply: should support git binary delta diffs 4899 https://bugs.webkit.org/show_bug.cgi?id=38864 4900 4901 * Scripts/VCSUtils.pm: 4902 * Scripts/svn-apply: 4903 49042011-01-06 Julie Parent <jparent@chromium.org> 4905 4906 Reviewed by Eric Seidel. 4907 4908 Test Result Server not removing old results. 4909 https://bugs.webkit.org/show_bug.cgi?id=52012 4910 4911 * TestResultServer/model/jsonresults.py: 4912 Fix off-by-one: Truncate if >= num_runs, not just >. 4913 * TestResultServer/model/jsonresults_unittest.py: 4914 Add unit test to test that merging in a new result with the same value 4915 as the last result causes previous result to fall off. 4916 49172011-01-06 James Kozianski <koz@chromium.org> 4918 4919 Reviewed by Mihai Parparita. 4920 4921 Add classes to provide a consistent interface to a set of files. 4922 https://bugs.webkit.org/show_bug.cgi?id=50901 4923 4924 These classes allow us to write code that is agnostic to whether a 4925 particular set of files resides in a local directory or in a zip file 4926 on a remote machine. 4927 4928 * Scripts/webkitpy/common/system/directoryfileset.py: Added. 4929 * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added. 4930 * Scripts/webkitpy/common/system/fileset.py: Added. 4931 * Scripts/webkitpy/common/system/filesystem.py: 4932 * Scripts/webkitpy/common/system/filesystem_mock.py: 4933 * Scripts/webkitpy/common/system/zipfileset.py: Added. 4934 * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added. 4935 49362011-01-06 Eric Seidel <eric@webkit.org> 4937 4938 Reviewed by Adam Barth. 4939 4940 NetworkTransaction should log the url it is retrying 4941 https://bugs.webkit.org/show_bug.cgi?id=52043 4942 4943 * Scripts/webkitpy/common/net/networktransaction.py: 4944 * Scripts/webkitpy/common/net/networktransaction_unittest.py: 4945 49462011-01-06 Steve Falkenburg <sfalken@apple.com> 4947 4948 Windows build fix. 4949 Import os before using it. 4950 4951 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 4952 49532011-01-06 Eric Seidel <eric@webkit.org> 4954 4955 Reviewed by Adam Barth. 4956 4957 StyleQueue fails to report errors when patches have many files 4958 https://bugs.webkit.org/show_bug.cgi?id=52042 4959 4960 This is one of at least two errors preventing style error reporting at the moment. 4961 When we moved to passing the list of files to check explicitly, 4962 we started to exceed the 500 character TEXT field limit for our AppEngine model object. 4963 We could change the type of the QueueStatus.message type, or we could 4964 just teach statusserver.py how to clamp values (and warn when it does). 4965 I chose the latter path. 4966 4967 * Scripts/webkitpy/common/net/statusserver.py: 4968 49692011-01-06 Steve Falkenburg <sfalken@apple.com> 4970 4971 Reviewed by Stephanie Lewis. 4972 4973 Fix syntax error in script. 4974 4975 Windows bots need to archive/unarchive builds to/from configuration-specific directories 4976 https://bugs.webkit.org/show_bug.cgi?id=51996 4977 4978 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 4979 49802011-01-06 Laszlo Gombos <laszlo.1.gombos@nokia.com> 4981 4982 Unreviewed, fixing WinCE build after r75196. 4983 4984 WinCE port does not (yet) support NPAPI. 4985 4986 * Scripts/build-webkit: 4987 49882011-01-06 Xan Lopez <xlopez@igalia.com> 4989 4990 Reviewed by Darin Adler. 4991 4992 File::Spec->rel2abs in sunspider-compare-results mangles parameters 4993 https://bugs.webkit.org/show_bug.cgi?id=52015 4994 4995 * Scripts/sunspider-compare-results: call rel2abs on our arguments 4996 after the platform has been detected, otherwise the script will 4997 mangle things like '--gtk' into '/a/path/--gtk', breaking the 4998 detection. 4999 50002011-01-06 Laszlo Gombos <laszlo.1.gombos@nokia.com> 5001 5002 Reviewed by Eric Seidel. 5003 5004 Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit 5005 https://bugs.webkit.org/show_bug.cgi?id=51346 5006 5007 * Scripts/build-webkit: 5008 50092011-01-06 Steve Falkenburg <sfalken@apple.com> 5010 5011 Reviewed by Adam Roben. 5012 5013 Windows bots need to archive/unarchive builds to/from configuration-specific directories 5014 https://bugs.webkit.org/show_bug.cgi?id=51996 5015 5016 After the configuration directory change, we were archiving the incorrect directory for 5017 build product, so we were running tests on the wrong binaries. 5018 5019 This change archives the correct directory, and also unarchives it into a configuration- 5020 specific directory. 5021 5022 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows. 5023 * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory. 5024 50252011-01-06 Eric Seidel <eric@webkit.org> 5026 5027 Reviewed by Mihai Parparita. 5028 5029 commit-queue mentions "Text diff mismatch" 4 times instead of once per failure 5030 https://bugs.webkit.org/show_bug.cgi?id=52002 5031 5032 See an example of this here: 5033 https://bugs.webkit.org/show_bug.cgi?id=51314#c2 5034 5035 It's due to the fact that we pass around TestFailure() instance 5036 objects and yet expect them to all compare to be the same. 5037 5038 This is bad. We should either have shared instances of these values 5039 or we should just pass around the class names. There are already hacks 5040 in place to make TestFailure objects pass equality tests, I just added 5041 a __hash__ implementation so they can be used in sets as expected. 5042 5043 * Scripts/webkitpy/common/net/layouttestresults_unittest.py: 5044 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 5045 50462011-01-06 Evan Martin <evan@chromium.org> 5047 5048 Reviewed by Tony Chang. 5049 5050 [gdb] handle inaccessible memory and UChar* 5051 https://bugs.webkit.org/show_bug.cgi?id=52003 5052 5053 To pretty-print a UChar*, we just grope around in the memory 5054 looking for a terminating NUL. We need to handle the exception 5055 that can occur when we poke into an invalid location. 5056 5057 Additionally, the logic for choosing which pretty-printer would 5058 early return before hitting the point where we'd use the UChar* 5059 printer. (Did this ever work? How did it regress?) 5060 5061 * gdb/webkit.py: 5062 50632011-01-05 Brian Weinstein <bweinstein@apple.com> 5064 5065 Reviewed by Ada Chan. 5066 5067 WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads 5068 https://bugs.webkit.org/show_bug.cgi?id=51969 5069 5070 Add shouldLoadResourceForFrame to WTR::InjectedBundlePage. 5071 5072 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 5073 (WTR::InjectedBundlePage::InjectedBundlePage): 5074 (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation. 5075 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 5076 50772011-01-06 James Robinson <jamesr@chromium.org> 5078 5079 Reviewed by Simon Fraser. 5080 5081 Implement mozilla's animationTime property 5082 https://bugs.webkit.org/show_bug.cgi?id=51952 5083 5084 Chromium DRT support for webkitAnimationTime. 5085 5086 * DumpRenderTree/chromium/WebViewHost.cpp: 5087 (WebViewHost::paintInvalidatedRegion): 5088 50892011-01-06 Julie Parent <jparent@chromium.org> 5090 5091 Reviewed by Tony Chang. 5092 5093 Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS 5094 https://bugs.webkit.org/show_bug.cgi?id=51217 5095 5096 * TestResultServer/model/jsonresults.py: 5097 Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value. 5098 Adds missing documentation. 5099 * TestResultServer/model/jsonresults_unittest.py: 5100 Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS. 5101 Update test_merge to take a number of builds to truncate at. 5102 51032011-01-06 Adam Barth <abarth@webkit.org> 5104 5105 Reviewed by Eric Seidel. 5106 5107 The EWS should log outside of the working directory 5108 https://bugs.webkit.org/show_bug.cgi?id=51986 5109 5110 This patch prepare us for using git clean -x -d -f in the EWS wrapper 5111 script, which will actually clean the working copy back to a pristine 5112 state instead of leaving untracked directories and ignored files. 5113 5114 * Scripts/webkitpy/tool/commands/queues.py: 5115 * Scripts/webkitpy/tool/commands/queues_unittest.py: 5116 51172011-01-05 Steve Falkenburg <sfalken@apple.com> 5118 5119 Windows build fix. 5120 Back out attempted change to built-product-archive. 5121 5122 * BuildSlaveSupport/built-product-archive: 5123 51242011-01-05 Steve Falkenburg <sfalken@apple.com> 5125 5126 Windows build fix. 5127 Include configuration name when unpacking a build archive. 5128 5129 Needed, since we split Windows build results into configuration-specific directories 5130 under WebKitOutputDir. 5131 5132 * BuildSlaveSupport/built-product-archive: 5133 51342011-01-05 Steve Falkenburg <sfalken@apple.com> 5135 5136 Reviewed by Darin Adler. 5137 5138 Debug and Release builds on Windows clobber each other 5139 https://bugs.webkit.org/show_bug.cgi?id=49185 5140 5141 Changes the structure of WebKitBuild build products directory so we 5142 completely separate each build configuration into independent directories. 5143 5144 Although we previously had per-configuration directories for obj, this change adds 5145 per-configuration directories for bin, lib, obj, and include. Each configuration's 5146 build products are stored within a directory inside of WebKitBuild. 5147 5148 Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir), 5149 defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName). 5150 5151 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: 5152 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: 5153 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: 5154 * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: 5155 * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: 5156 * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: 5157 * DumpRenderTree/win/ImageDiffCommon.vsprops: 5158 * DumpRenderTree/win/ImageDiffPostBuild.cmd: 5159 * DumpRenderTree/win/ImageDiffPreBuild.cmd: 5160 * FindSafari/FindSafari.vcproj: 5161 * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: 5162 * MiniBrowser/MiniBrowserPostBuild.cmd: 5163 * MiniBrowser/MiniBrowserPreBuild.cmd: 5164 * Scripts/webkitdirs.pm: 5165 * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: 5166 * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: 5167 * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: 5168 * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: 5169 * TestWebKitAPI/win/copy-resources.cmd: 5170 * WebKitAPITest/WebKitAPITestCommon.vsprops: 5171 * WebKitAPITest/WebKitAPITestPostBuild.cmd: 5172 * WebKitAPITest/WebKitAPITestPreBuild.cmd: 5173 * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: 5174 * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: 5175 * WebKitTestRunner/win/InjectedBundle.vcproj: 5176 * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: 5177 * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: 5178 * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: 5179 * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: 5180 * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: 5181 * WinLauncher/WinLauncherCommon.vsprops: 5182 * WinLauncher/WinLauncherPostBuild.cmd: 5183 * WinLauncher/WinLauncherPreBuild.cmd: 5184 51852011-01-05 Jan Erik Hanssen <jhanssen@sencha.com> 5186 5187 Reviewed by Ariya Hidayat. 5188 5189 [Qt] TestNetscapePlugin doesn't link on OS X 5190 https://bugs.webkit.org/show_bug.cgi?id=51948 5191 5192 Only add a dependency on libX11 on X11 systems 5193 5194 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 5195 51962011-01-05 Jeff Miller <jeffm@apple.com> 5197 5198 Reviewed by Adam Roben. 5199 5200 check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style 5201 https://bugs.webkit.org/show_bug.cgi?id=51970 5202 5203 * Scripts/webkitpy/style/checker.py: 5204 Add -readability/naming for WebKit2 C API directories. 5205 52062011-01-05 Eric Seidel <eric@webkit.org> 5207 5208 Unreviewed, just fixing one more log error from my previous python patch. 5209 5210 Move LayoutTestResults over to new-run-webkit-tests TestResult architecture 5211 https://bugs.webkit.org/show_bug.cgi?id=51802 5212 5213 webkit-patch failure-reason was logging about parsing errors 5214 due to my misunderstanding of how BeautifulSoup.findAll worked. 5215 5216 Fixed, and added a unit test. 5217 5218 * Scripts/webkitpy/common/net/layouttestresults.py: 5219 * Scripts/webkitpy/common/net/layouttestresults_unittest.py: 5220 52212011-01-05 Benjamin Poulain <benjamin.poulain@nokia.com> 5222 5223 Reviewed by Kenneth Rohde Christiansen. 5224 5225 [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser 5226 https://bugs.webkit.org/show_bug.cgi?id=51951 5227 5228 Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way 5229 to create new window from WebKit. 5230 5231 * MiniBrowser/qt/BrowserWindow.cpp: 5232 (newPageFunction): 5233 (BrowserWindow::BrowserWindow): 5234 (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class 5235 (BrowserWindow::newWindow): 5236 (BrowserWindow::updateUserAgentList): 5237 (BrowserWindow::showUserAgentDialog): 5238 * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to 5239 define the type of the backing store used for new windows. 5240 * MiniBrowser/qt/main.cpp: 5241 (main): 5242 52432011-01-05 Eric Seidel <eric@webkit.org> 5244 5245 Reviewed by Ojan Vafai. 5246 5247 commit-queue should report failure type when reporting flaky tests 5248 https://bugs.webkit.org/show_bug.cgi?id=51900 5249 5250 This patch was a ridiculous amount of plumbing. In the end I like 5251 the NRWT-style TestResult class even less. But now we're passing 5252 a list of TestResult objects from the queue to the FlakyTestReporter. 5253 Thus the FlakyTestReporter can more easily report what type of failure 5254 occurred. 5255 5256 In the process, I found that I was not alone in finding TestResult 5257 cumbersome to use. A bunch of code was trying to create a TestResult 5258 object with default values. However since the constructor didn't make 5259 this easy, some places were getting it wrong (including the TestResult unit test)! 5260 I've fixed the TestResult constructor to have default values for non-essential 5261 arguments. 5262 5263 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 5264 * Scripts/webkitpy/common/net/layouttestresults.py: 5265 * Scripts/webkitpy/common/net/layouttestresults_unittest.py: 5266 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 5267 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 5268 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 5269 * Scripts/webkitpy/layout_tests/layout_package/test_results.py: 5270 * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py: 5271 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 5272 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 5273 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 5274 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 5275 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: 5276 * Scripts/webkitpy/tool/commands/queues.py: 5277 * Scripts/webkitpy/tool/commands/queues_unittest.py: 5278 52792011-01-05 Eric Seidel <eric@webkit.org> 5280 5281 Unreviewed. 5282 5283 Move LayoutTestResults over to new-run-webkit-tests TestResult architecture 5284 https://bugs.webkit.org/show_bug.cgi?id=51802 5285 5286 Add another unit test to cover a previously missing import. 5287 5288 * Scripts/webkitpy/common/net/layouttestresults.py: 5289 * Scripts/webkitpy/common/net/layouttestresults_unittest.py: 5290 52912011-01-05 Mihai Parparita <mihaip@chromium.org> 5292 5293 Reviewed by David Levin. 5294 5295 Add mihaip@chromium.org as a reviewer 5296 https://bugs.webkit.org/show_bug.cgi?id=51966 5297 5298 Add myself as a reviewer. 5299 5300 * Scripts/webkitpy/common/config/committers.py: 5301 53022011-01-05 James Simonsen <simonjam@chromium.org> 5303 5304 Unreviewed. Adding myself to the list of committers. 5305 5306 * Scripts/webkitpy/common/config/committers.py: 5307 53082011-01-05 Eric Seidel <eric@webkit.org> 5309 5310 Unreviewed. 5311 5312 Move LayoutTestResults over to new-run-webkit-tests TestResult architecture 5313 https://bugs.webkit.org/show_bug.cgi?id=51802 5314 5315 Fix two exceptions seen on the bots after my original commit. 5316 5317 * Scripts/webkitpy/common/net/layouttestresults.py: 5318 * Scripts/webkitpy/common/net/layouttestresults_unittest.py: 5319 53202011-01-05 Kundu Suchismita <suchi.kundu@nokia.com> 5321 5322 Reviewed by Andreas Kling. 5323 5324 [Qt]Add local storage settings to QtTestBrowser command line arguments 5325 https://bugs.webkit.org/show_bug.cgi?id=51750 5326 5327 * QtTestBrowser/main.cpp: 5328 (LauncherApplication::handleUserOptions): 5329 Local storage settings can be enable form command line arguments for 5330 QtTestBrowser. 5331 53322011-01-05 Chris Fleizach <cfleizach@apple.com> 5333 5334 Reviewed by Martin Robinson. 5335 5336 GTK: AX: DRT needs to use correct root object method. 5337 https://bugs.webkit.org/show_bug.cgi?id=51911 5338 5339 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 5340 (AccessibilityController::rootElement): 5341 53422011-01-05 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 5343 5344 Rubber-stamped by Csaba Osztrogonác. 5345 5346 Based on idea from Péter Gál. 5347 5348 * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers. 5349 53502011-01-05 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 5351 5352 Reviewed by Adam Barth. 5353 5354 sheriff-bot should be able to do multi-revision rollouts 5355 https://bugs.webkit.org/show_bug.cgi?id=51176 5356 5357 * Scripts/webkitpy/tool/bot/irc_command.py: 5358 * Scripts/webkitpy/tool/bot/sheriff.py: 5359 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: 5360 53612011-01-05 Eric Seidel <eric@webkit.org> 5362 5363 Reviewed by Adam Barth. 5364 5365 queues.webkit.org should have per-bot status pages 5366 https://bugs.webkit.org/show_bug.cgi?id=51906 5367 5368 Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show 5369 statuses from a single queue. Now that we have many bots servicing 5370 some queues (commit-queue, win-ews, etc.) its easy to have the messages 5371 you care about scroll off the end of the 15-message limit on the main page. 5372 5373 Eventually we should probably rename /queue-status to /queue or /queues, 5374 but that's fodder for another patch. 5375 5376 * QueueStatusServer/handlers/queuestatus.py: 5377 * QueueStatusServer/index.yaml: 5378 * QueueStatusServer/main.py: 5379 * QueueStatusServer/templates/includes/singlequeuestatus.html: 5380 - This probably should use a custom filter instead of hard-coding 5381 the URL scheme here, but I couldn't figure out how to easily 5382 create such a filter. Most filters work with "strings" so we can't 5383 pass the status object. We could add a method to the status 5384 object and call that, but that seemed a bit strange too. 5385 * QueueStatusServer/templates/queuestatus.html: 5386 53872011-01-05 Carlos Garcia Campos <cgarcia@igalia.com> 5388 5389 Unreviewed. Adding myself to the list of committers. 5390 5391 * Scripts/webkitpy/common/config/committers.py: 5392 53932011-01-04 Koan-Sin Tan <koansin.tan@gmail.com> 5394 5395 Reviewed by David Levin. 5396 5397 check-webkit-style treated some macros with parentheses after #elif as function calls 5398 https://bugs.webkit.org/show_bug.cgi?id=51695 5399 5400 Ingore function call space checking in any preprocessor directives 5401 (things starting with #). Change search() to match() because 5402 preprocessor directives are supposed to be in the beginning of lines. 5403 5404 * Scripts/webkitpy/style/checkers/cpp.py: 5405 * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases 5406 54072011-01-04 Søren Gjesse <sgjesse@chromium.org> 5408 5409 Reviewed by Tony Chang. 5410 5411 Change the --multi-load test option to --stress-opt 5412 https://bugs.webkit.org/show_bug.cgi?id=50751 5413 5414 * DumpRenderTree/chromium/DumpRenderTree.cpp: 5415 (runTest): 5416 (main): 5417 * DumpRenderTree/chromium/TestShell.cpp: 5418 (TestShell::TestShell): 5419 * DumpRenderTree/chromium/TestShell.h: 5420 (TestShell::stressOpt): 5421 (TestShell::setStressOpt): 5422 (TestShell::stressDeopt): 5423 (TestShell::setStressDeopt): 5424 (TestShell::javaScriptFlags): 5425 (TestShell::setJavaScriptFlags): 5426 * Scripts/webkitpy/layout_tests/port/chromium.py: 5427 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 5428 54292011-01-04 Chris Fleizach <cfleizach@apple.com> 5430 5431 Reviewed by Sam Weinig. 5432 5433 WK2: Support Accessibility 5434 https://bugs.webkit.org/show_bug.cgi?id=51859 5435 5436 Use rootObject() method to get top of accessibility tree. 5437 5438 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 5439 (AccessibilityController::focusedElement): 5440 (AccessibilityController::rootElement): 5441 54422011-01-03 Martin Robinson <mrobinson@igalia.com> 5443 5444 Reviewed by Darin Adler. 5445 5446 Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr 5447 https://bugs.webkit.org/show_bug.cgi?id=51846 5448 5449 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr 5450 back to GRefPtr. 5451 54522011-01-04 Zhe Su <suzhe@chromium.org> 5453 5454 Reviewed by Kenneth Russell. 5455 5456 Fix insertText, setMarkedText and unmarkText methods of 5457 TextInputController to call corresponding methods of WebKit::WebView 5458 rather than WebKit::WebFrame. This change matches the behavior of 5459 chromium browser. 5460 insertText corresponds to WebView::confirmComposition(text) 5461 setMarkedText corresponds to WebView::setComposition(...) 5462 unmarkText corresponds to WebView::confirmComposition() 5463 https://bugs.webkit.org/show_bug.cgi?id=51693 5464 5465 * DumpRenderTree/chromium/TextInputController.cpp: 5466 (TextInputController::insertText): 5467 (TextInputController::setMarkedText): 5468 (TextInputController::unmarkText): 5469 54702011-01-04 Dihan Wickremasuriya <dihan.wickremasuriya@nokia.com> 5471 5472 Reviewed by Laszlo Gombos. 5473 5474 [Qt] [Symbian] Do not remove 0 byte sized files from productDir 5475 5476 On Symbian productDir points to the source directory. Removing all the 5477 empty files from the productDir directory corrupts the svn repository. 5478 5479 * Scripts/build-webkit: 5480 54812011-01-03 Yi Shen <yi.4.shen@nokia.com> 5482 5483 Reviewed by Adam Barth. 5484 5485 [Qt] Add SelectAll option to the context menu for the editor 5486 https://bugs.webkit.org/show_bug.cgi?id=50049 5487 5488 Set shortcut for the SelectAll action. 5489 5490 * QtTestBrowser/mainwindow.cpp: 5491 (MainWindow::buildUI): 5492 54932011-01-03 David Levin <levin@chromium.org> 5494 5495 Reviewed by Eric Seidel. 5496 5497 check-webkit-style shouldn't consider "value" automatically to be a meaningless name. 5498 https://bugs.webkit.org/show_bug.cgi?id=51842 5499 5500 * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value. 5501 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value. 5502 55032011-01-03 Patrick Gansterer <paroga@webkit.org> 5504 5505 Reviewed by David Kilzer. 5506 5507 [WINCE] Adds a build slave. 5508 https://bugs.webkit.org/show_bug.cgi?id=50523 5509 5510 * BuildSlaveSupport/build.webkit.org-config/config.json: Add an 5511 entry for a release build of the WinCE port. 5512 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform 5513 flag to build the WinCE port. 5514 55152011-01-03 Patrick Gansterer <paroga@webkit.org> 5516 5517 Reviewed by David Kilzer. 5518 5519 Add WinCE support to build-webkit 5520 https://bugs.webkit.org/show_bug.cgi?id=51642 5521 5522 * Scripts/build-webkit: 5523 * Scripts/webkitdirs.pm: 5524 55252011-01-03 Eric Seidel <eric@webkit.org> 5526 5527 Reviewed by Adam Barth. 5528 5529 Move LayoutTestResults over to new-run-webkit-tests TestResult architecture 5530 https://bugs.webkit.org/show_bug.cgi?id=51802 5531 5532 I'm not the biggest fan of the test_failures or test_results classes, 5533 but it's better to have one shared set of classes, than separate ones 5534 for new vs. old run-webkit-test result handling. 5535 5536 This moves the ORWT results class "LayoutTestResults" over to using 5537 TestResult and TestFailure classes, making it easy for us to 5538 make all our sheriff-bot and other webkitpy code NRWT ready. 5539 5540 This also makes it a trivial patch to generate results.json information 5541 from ORWT results.html files (for flaky test analysis, etc.) as well 5542 as making it a one-liner to report test failure types when the 5543 commit-queue sees flaky tests. 5544 5545 This patch tried not to add new functionality, but only to replace 5546 the guts of LayoutTestResults, while adding unit tests and hoping 5547 not to break anything. 5548 5549 I also moved callers which assumed User.prompt* were static/class methods 5550 to using them as instance methods (since we'll eventually want to make them such). 5551 5552 In the process of re-writing things, I broke the rebaseline command, so I wrote 5553 a unit test to catch my breakage were I do do so again in the future. 5554 5555 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 5556 * Scripts/webkitpy/common/net/layouttestresults.py: 5557 * Scripts/webkitpy/common/net/layouttestresults_unittest.py: 5558 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 5559 * Scripts/webkitpy/layout_tests/layout_package/test_results.py: 5560 * Scripts/webkitpy/tool/commands/queries.py: 5561 * Scripts/webkitpy/tool/commands/rebaseline.py: 5562 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: 5563 * Scripts/webkitpy/tool/mocktool.py: 5564 55652011-01-03 Adam Barth <abarth@webkit.org> 5566 5567 Reviewed by Simon Fraser. 5568 5569 webkit-patch shouldn't waste time cleaning a working directory that's already clean 5570 https://bugs.webkit.org/show_bug.cgi?id=51840 5571 5572 * Scripts/webkitpy/common/checkout/scm.py: 5573 55742011-01-03 Adam Barth <abarth@webkit.org> 5575 5576 Reviewed by Simon Fraser. 5577 5578 webkit-patch should only hide update output if --quiet 5579 https://bugs.webkit.org/show_bug.cgi?id=51838 5580 5581 As requested by smfr. 5582 5583 * Scripts/webkitpy/tool/steps/update.py: 5584 55852011-01-03 Adam Barth <abarth@webkit.org> 5586 5587 Reviewed by David Levin. 5588 5589 commit-queue shouldn't reject patches twice if two bots process the same patch 5590 https://bugs.webkit.org/show_bug.cgi?id=51805 5591 5592 Before raising an error, we first check whether the patch is still in 5593 the commit-queue. This check is still racy, of course, but the time 5594 window is much smaller. 5595 5596 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 5597 55982011-01-03 Sam Weinig <sam@webkit.org> 5599 5600 Reviewed by Anders Carlsson. 5601 5602 Make run-api-tests less chatty. 5603 https://bugs.webkit.org/show_bug.cgi?id=51831 5604 5605 - Make script quiet by default and add --verbose option (replacing --quiet). 5606 - When not verbose, pipe stdout and stderr to devnull. 5607 5608 * Scripts/run-api-tests: 5609 56102011-01-03 Pratik Solanki <psolanki@apple.com> 5611 5612 Unreviewed. Adding myself to committers.py. 5613 5614 * Scripts/webkitpy/common/config/committers.py: 5615 56162011-01-03 Koan-Sin Tan <koansin.tan@gmail.com> 5617 5618 Reviewed by Xan Lopez. 5619 5620 "Tool/Scripts/run-launcher --gtk" stopped working after 74855 5621 https://bugs.webkit.org/show_bug.cgi?id=51806 5622 5623 Originally, the $libraryName is 'JavaScriptCore'. When building release 5624 one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/' 5625 which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore' 5626 is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 5627 'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird, 5628 so make it 'WebKitBuild/Release/.libs' 5629 5630 * Scripts/webkitdirs.pm: 5631 56322011-01-02 Patrick Gansterer <paroga@webkit.org> 5633 5634 Reviewed by Adam Barth. 5635 5636 Make EFL a core builder 5637 https://bugs.webkit.org/show_bug.cgi?id=51804 5638 5639 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 5640 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 5641 56422011-01-02 Csaba Osztrogonác <ossy@webkit.org> 5643 5644 [Qt] Unreviewed fix after r74855 and r74875. 5645 5646 * BuildSlaveSupport/built-product-archive: 5647 - Create directories explicitly. 5648 - Pass shell=True to subprocess.call(). 5649 56502011-01-02 Csaba Osztrogonác <ossy@webkit.org> 5651 5652 [Qt] Unreviewed fix after r74855. 5653 5654 Move JavaScriptCore to Source 5655 https://bugs.webkit.org/show_bug.cgi?id=51604 5656 5657 * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore 5658 56592011-01-02 Csaba Osztrogonác <ossy@webkit.org> 5660 5661 [Qt] Unreviewed run-javasriptcore-tests fix after r74855. 5662 5663 Move JavaScriptCore to Source 5664 https://bugs.webkit.org/show_bug.cgi?id=51604 5665 5666 * Scripts/webkitdirs.pm: 5667 56682011-01-02 Robert Hogan <robert@webkit.org> 5669 5670 Unreviewed, build fix. 5671 5672 [Qt] Fix DRT build after 74855 5673 5674 * DumpRenderTree/qt/DumpRenderTree.pro: 5675 56762011-01-01 Adam Barth <abarth@webkit.org> 5677 5678 Remove the assumption from the Qt and Gtk builds that every project is 5679 in the root directory. 5680 5681 * Scripts/build-webkit: 5682 56832011-01-01 Adam Barth <abarth@webkit.org> 5684 5685 Reviewed by Eric Seidel. 5686 5687 Teach svn-apply how to apply patches even though JavaScriptCore has moved 5688 https://bugs.webkit.org/show_bug.cgi?id=51796 5689 5690 After this change, svn-apply will magically apply patches to 5691 JavaScriptCore/foo to Source/JavaScriptCore/foo. 5692 5693 * Scripts/VCSUtils.pm: 5694 56952011-01-01 Adam Barth <abarth@webkit.org> 5696 5697 Reviewed by Eric Seidel. 5698 5699 Move JavaScriptCore to Source 5700 https://bugs.webkit.org/show_bug.cgi?id=51604 5701 5702 Update references to JavaScriptCore to point to the new location. 5703 5704 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 5705 * DumpRenderTree/qt/DumpRenderTree.pro: 5706 * DumpRenderTree/qt/ImageDiff.pro: 5707 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 5708 * DumpRenderTree/wscript: 5709 * Scripts/build-jsc: 5710 * Scripts/build-webkit: 5711 * Scripts/do-file-rename: 5712 * Scripts/do-webcore-rename: 5713 * Scripts/run-javascriptcore-tests: 5714 * Scripts/update-javascriptcore-test-results: 5715 * Scripts/webkitdirs.pm: 5716 * Scripts/webkitpy/common/config/build_unittest.py: 5717 * Scripts/webkitpy/style/checker.py: 5718 * Scripts/webkitpy/style/checker_unittest.py: 5719 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 5720 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: 5721 * WebKitTestRunner/qt/WebKitTestRunner.pro: 5722 * wx/build/settings.py: 5723 57242011-01-01 Adam Barth <abarth@webkit.org> 5725 5726 Reviewed by Eric Seidel. 5727 5728 Move Sources to Source 5729 https://bugs.webkit.org/show_bug.cgi?id=51794 5730 5731 Update scripts to point to the new location. 5732 5733 * Scripts/build-webkit: 5734 * Scripts/do-file-rename: 5735 * Scripts/do-webcore-rename: 5736 * Scripts/webkitpy/common/config/build.py: 5737 * Scripts/webkitpy/common/config/build_unittest.py: 5738 57392010-12-31 Kent Tamura <tkent@chromium.org> 5740 5741 Reviewed by Eric Seidel. 5742 5743 [DRT/Chromium] Enable mock spell checker on non-OSX 5744 https://bugs.webkit.org/show_bug.cgi?id=51401 5745 5746 * DumpRenderTree/chromium/WebViewHost.cpp: 5747 (WebViewHost::spellCheck): 5748 57492010-12-31 Adam Barth <abarth@webkit.org> 5750 5751 Reviewed by Ariya Hidayat. 5752 5753 Remove Tools/Scripts/wkstyle 5754 https://bugs.webkit.org/show_bug.cgi?id=51774 5755 5756 This script appears to not have been touched in a while and seems to 5757 have been replaced by check-webkit-style. 5758 5759 * Scripts/wkstyle: Removed. 5760 57612010-12-31 Ilya Tikhonovsky <loislo@chromium.org> 5762 5763 Unreviewed. Coding style fix. 5764 5765 * DumpRenderTree/chromium/TestShell.h: 5766 57672010-12-31 Ilya Tikhonovsky <loislo@chromium.org> 5768 5769 Reviewed by Pavel Feldman. 5770 5771 Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg). 5772 5773 It was a problem with Chromium DRT. DevToolsAgent object instance was 5774 attached not only to the inspected page but to the DevTools window too. 5775 As result all the inspector files were interpreted as a content of inspected page 5776 and were transfered to the DevTools scripts panel for debugging etc. 5777 5778 https://bugs.webkit.org/show_bug.cgi?id=51735 5779 5780 * DumpRenderTree/chromium/TestShell.cpp: 5781 (TestShell::TestShell): 5782 (TestShell::bindJSObjectsToWindow): 5783 (TestShell::createNewWindow): 5784 * DumpRenderTree/chromium/TestShell.h: 5785 57862010-12-31 Adam Barth <abarth@webkit.org> 5787 5788 Rubber-stamped by Eric Seidel. 5789 5790 Move PageLoadTests to PerformanceTests/PageLoad 5791 https://bugs.webkit.org/show_bug.cgi?id=51771 5792 5793 Update references to PageLoadTests to point to the new location. 5794 5795 * Scripts/run-pageloadtest: 5796 * Scripts/webkitpy/common/config/build.py: 5797 57982010-12-31 Adam Barth <abarth@webkit.org> 5799 5800 Rubber-stamped by Eric Seidel. 5801 5802 Move SunSpider into PerformanceTests 5803 https://bugs.webkit.org/show_bug.cgi?id=51769 5804 5805 Update these scripts to point to the new location. 5806 5807 * Scripts/run-sunspider: 5808 * Scripts/sunspider-compare-results: 5809 58102010-12-30 Mihai Parparita <mihaip@chromium.org> 5811 5812 Reviewed by Kent Tamura. 5813 5814 [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's 5815 https://bugs.webkit.org/show_bug.cgi?id=51728 5816 5817 Add implementation of the Mac WebThemeEngine that uses an NSScroller 5818 to render top-level scrollbars. This makes them match the Mac port's 5819 use of an NSScrollView, which means that we'll be able to share more 5820 pixel baselines. 5821 5822 The new rendering code will not be activated until the 5823 USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in 5824 ScrollbarThemeChromiumMac. 5825 5826 * DumpRenderTree/DumpRenderTree.gypi: 5827 * DumpRenderTree/chromium/TestShellMac.mm: 5828 (platformInit): 5829 * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added. 5830 * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added. 5831 (+[FakeActiveWindow alwaysActiveWindow]): 5832 (+[FakeActiveWindow alwaysInactiveWindow]): 5833 (-[FakeActiveWindow initWithActiveControls:]): 5834 (-[FakeActiveWindow _hasActiveControls]): 5835 (WebThemeEngineDRTMac::paintScrollbarThumb): 5836 (stateToHIEnableState): 5837 (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb): 5838 (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb): 5839 58402010-12-30 Konstantin Tokarev <annulen@yandex.ru> 5841 5842 Reviewed by David Kilzer. 5843 5844 [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is 5845 used 5846 https://bugs.webkit.org/show_bug.cgi?id=51672 5847 5848 * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC 5849 with USE_SYSTEM_MALLOC=1 5850 * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC 5851 with USE_SYSTEM_MALLOC=1 5852 58532010-12-30 Laszlo Gombos <laszlo.1.gombos@nokia.com> 5854 5855 Reviewed by David Kilzer. 5856 5857 [Qt] [Symbian] Fix build-webkit script for Symbian 5858 https://bugs.webkit.org/show_bug.cgi?id=51509 5859 5860 Set the OUTPUT_DIR for Symbian to be the same as the source 5861 directory. 5862 5863 * Scripts/webkitdirs.pm: 5864 58652010-12-30 Martin Robinson <mrobinson@igalia.com> 5866 5867 Reviewed by Darin Adler. 5868 5869 check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get 5870 https://bugs.webkit.org/show_bug.cgi?id=51758 5871 5872 Add a check-webkit-style exception for gtk_widget_style_get and NULL usage. 5873 5874 * Scripts/webkitpy/style/checkers/cpp.py: Add the exception. 5875 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this. 5876 58772010-12-29 Patrick Gansterer <paroga@webkit.org> 5878 5879 Unreviewed WinCE buildfix. 5880 5881 * WinCELauncher/main.cpp: Add missing include. 5882 58832010-12-29 Daniel Bates <dbates@rim.com> 5884 5885 Reviewed by Darin Adler. 5886 5887 svn-apply updates date of wrong change log entry for a change log diff that 5888 contains two consecutive entries with the same author and date 5889 https://bugs.webkit.org/show_bug.cgi?id=46061 5890 5891 Fixes an issue where the date of the wrong change log entry may be modified. 5892 Moreover, changes fixChangeLogPatch() to move entries inserted earlier 5893 in a ChangeLog file to the top of the file. 5894 5895 Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged 5896 diff when it detects that the diff inserts a change log entry earlier in a 5897 ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog 5898 change. With the advent of the commit-queue this functionality of bailing out 5899 and hence landing the patch as-is is harmful to the accuracy of the ChangeLog. 5900 Instead, we should always move the change log entry to the top of the ChangeLog file. 5901 5902 A side-effect of this change is that setChangeLogDateAndReviewer() now updates 5903 the date line of the correct change log entry in a ChangeLog diff. 5904 5905 * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top. 5906 5907 * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: 5908 Updated the following unit tests now that we move entries inserted earlier to the top: 5909 - "fixChangeLogPatch: New entry inserted in middle." 5910 (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.") 5911 5912 - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date." 5913 (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.") 5914 5915 * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added. 5916 59172010-12-29 Konstantin Tokarev <annulen@yandex.ru> 5918 5919 Reviewed by Eric Seidel. 5920 5921 [Qt] Fixed compatibility with gold linker on X11 platforms 5922 https://bugs.webkit.org/show_bug.cgi?id=51700 5923 5924 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 5925 Linked TestNetscapePlugin with libX11 on Unix platforms 5926 59272010-12-29 Ademar de Souza Reis Jr <ademar.reis@openbossa.org> 5928 5929 Reviewed by Darin Adler. 5930 5931 Circular dependency in webkitpy.common.checkout.changelog module 5932 https://bugs.webkit.org/show_bug.cgi?id=50475 5933 5934 Remove automatic import of api.Checkout module when any checkout/ 5935 submodule is imported (e.g.: when checkout.scm.Git is imported). 5936 5937 * Scripts/webkitpy/common/checkout/__init__.py: 5938 59392010-12-29 Martin Robinson <mrobinson@igalia.com> 5940 5941 Reviewed by Ojan Vafai. 5942 5943 prepare-ChangeLog should support the -g option for specifying the git-commit 5944 https://bugs.webkit.org/show_bug.cgi?id=51708 5945 5946 Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches 5947 webkit-patch, though the exact meaning of the two options remain different. 5948 5949 * Scripts/prepare-ChangeLog: Add -g. 5950 59512010-12-29 Kent Hansen <kent.hansen@nokia.com> 5952 5953 Reviewed by Simon Hausmann. 5954 5955 [Qt] Fix compilation with Qt in namespace 5956 https://bugs.webkit.org/show_bug.cgi?id=51701 5957 5958 * QtTestBrowser/webview.h: 5959 59602010-12-28 Daniel Bates <dbates@rim.com> 5961 5962 Reviewed by Sam Weinig. 5963 5964 Substitute // MARK: for compiler-specific #pragma mark 5965 https://bugs.webkit.org/show_bug.cgi?id=51657 5966 5967 Fix future compilation warnings about "#pragma mark" on GTK+ bots by 5968 substituting "// MARK:" for "#pragma mark", which provides 5969 analogous code-bookmarking functionality under Xcode. 5970 5971 Also, for consistency, we should substitute "// MARK:" for compiler- 5972 specific "#pragma mark" in the source files for the Mac port. 5973 5974 * DumpRenderTree/AccessibilityTextMarker.cpp: 5975 * DumpRenderTree/cf/WebArchiveDumpSupport.h: 5976 * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: 5977 * DumpRenderTree/mac/ObjCController.m: 5978 * MiniBrowser/mac/AppDelegate.m: 5979 * MiniBrowser/mac/BrowserWindowController.m: 5980 59812010-12-28 Xan Lopez <xlopez@igalia.com> 5982 5983 Reviewed by Eric Seidel. 5984 5985 Add --no-build option to run-sunspider 5986 https://bugs.webkit.org/show_bug.cgi?id=51658 5987 5988 * Scripts/run-sunspider: add --no-build flag to skip building 5989 phase. 5990 59912010-12-27 Daniel Bates <dbates@rim.com> 5992 5993 Rubber-stamped by Martin Robinson. 5994 5995 Append the directory Tools/DumpRenderTree to the list of directories that 5996 do-webcore-rename should search so that it can rename DRT files and 5997 source code. 5998 5999 * Scripts/do-webcore-rename: 6000 60012010-12-27 Eric Seidel <eric@webkit.org> 6002 6003 Reviewed by Adam Barth. 6004 6005 build-webkit should detect missing Java SDK and explain how to install it 6006 https://bugs.webkit.org/show_bug.cgi?id=51651 6007 6008 * Scripts/build-webkit: 6009 60102010-12-26 Martin Robinson <mrobinson@igalia.com> 6011 6012 Reviewed by Daniel Bates. 6013 6014 [GTK] Add support for build-jsc 6015 https://bugs.webkit.org/show_bug.cgi?id=51625 6016 6017 Add GTK+ support to build-jsc now that building the jsc executable as 6018 a standalone target is easy. 6019 6020 * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now. 6021 * Scripts/build-webkit: Pass in the proper target name to buildGtkProject. 6022 * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject 6023 and pass it along to buildAutotoolsProject. 6024 60252010-12-27 David Levin <levin@chromium.org> 6026 6027 Reviewed by Eric Seidel. 6028 6029 check-webkit-style check for meaningless variable names in function declarations. 6030 https://bugs.webkit.org/show_bug.cgi?id=51523 6031 6032 * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp 6033 from the new check and whitespace/parens because the syntax is unusual and 6034 produced a fair number of positives for these checks. 6035 * Scripts/webkitpy/style/checkers/cpp.py: 6036 (_convert_to_lower_with_underscores): Used as a canonical form for type names 6037 and parameter names when determining if the parameter name is useless. 6038 (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec" 6039 (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore 6040 format. 6041 (_check_parameter_name_against_text): Checks to see if the parameter name is in the 6042 text or an acronym of it. 6043 (check_function_definition): Checks function definitions for meaningless variable names. 6044 (process_line): Added call to check_function_definition. 6045 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 6046 (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores. 6047 (CppFunctionsTest.test_create_acronym): Test for _create_acronym. 6048 (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text. 6049 (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check 6050 because when only checking a snippet, there are a lot of bogus functions. 6051 (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter 6052 that I put there previously and just noticed. 6053 (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both 6054 check_function_definition and process_line. 6055 60562010-12-27 Carlos Garcia Campos <cgarcia@igalia.com> 6057 6058 Reviewed by Martin Robinson. 6059 6060 [GTK] Disable flash plugin in GtkLauncher when using gtk3 6061 https://bugs.webkit.org/show_bug.cgi?id=51591 6062 6063 Flash plugin uses gtk2 that is incompatible with gtk3 making 6064 webkit crash when it's built with gtk3. 6065 6066 * GtkLauncher/main.c: 6067 (main): 6068 60692010-12-25 Adam Barth <abarth@webkit.org> 6070 6071 Reviewed by Eric Seidel. 6072 6073 Move ANGLE to Sources/ThirdParty 6074 https://bugs.webkit.org/show_bug.cgi?id=51605 6075 6076 * Scripts/build-webkit: 6077 - Point to the new ANGLE location. 6078 60792010-12-26 David Levin <levin@chromium.org> 6080 6081 Reviewed by Eric Seidel. 6082 6083 check-webkit-style should be able to parse function declaration parameters. 6084 https://bugs.webkit.org/show_bug.cgi?id=51451 6085 6086 * Scripts/webkitpy/style/checkers/cpp.py: 6087 (Position.__init__): Holds simple position information (row, column). 6088 (Parameter.__init__): Holds information about a parameter. 6089 (SingleLineView.__init): Converts multiple lines into a single line for simpler searches. 6090 (SingleLineView.convert_column_to_row): Returns the original row given a column. 6091 (create_skeleton_parameters): Simplifies a parameter list for easier searching. 6092 (find_parameter_name_index): Finds where the parameter name is. 6093 (parameter_list): Generates the list of parameters for a function. 6094 (_FunctionState.begin): Added information to allow determining the parameters 6095 on demand. 6096 (_FunctionState.get_parameter_list): Returns a tuple of function parameters. 6097 (detect_functions): Improve function detection for operator functions and 6098 determine where the parameters end and pass that to _FunctionState.begin. 6099 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 6100 (CppFunctionsTest.test_parameter): Verifies Parameter functionality. 6101 (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality. 6102 (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters. 6103 (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index. 6104 (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list. 6105 Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list. 6106 (FunctionDetectionTest.perform_function_detection): Added support for verifying 6107 the parameters found. 6108 (FunctionDetectionTest.test_function_declaration_detection): Added more function 6109 detection test to verify that we catch the operator functions. 6110 (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros. 6111 (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing. 6112 (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed 6113 because the error. The test is about the bad function name. Fixing the name makes the test exactly like 6114 test_function_length_check_definition_severity1_for_test. 6115 61162010-12-25 Patrick Gansterer <paroga@webkit.org> 6117 6118 Unreviewed WinCE buildfix after r74334. 6119 6120 * CMakeListsWinCE.txt: 6121 61222010-12-24 Sheriff Bot <webkit.review.bot@gmail.com> 6123 6124 Unreviewed, rolling out r74632. 6125 http://trac.webkit.org/changeset/74632 6126 https://bugs.webkit.org/show_bug.cgi?id=51600 6127 6128 makes test-webkitpy hang forever on GTK (Requested by philn-tp 6129 on #webkit). 6130 6131 * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: 6132 * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: 6133 61342010-12-24 Ryuan Choi <ryuan.choi@samsung.com> 6135 6136 Reviewed by Kenneth Rohde Christiansen. 6137 6138 [EFL] Screen doesn't be rendered when changing size of EWebLauncher 6139 https://bugs.webkit.org/show_bug.cgi?id=43528 6140 6141 Remove on_resize because ewk_view_fixed_layout_size_set should not be 6142 called on callback of EVAS_CALLBACK_RESIZE. As it change size of 6143 FrameView, rendering was ignored when _ewk_view_smart_calculate was 6144 called. 6145 6146 * EWebLauncher/main.c: 6147 (browserCreate): 6148 61492010-12-24 Eric Seidel <eric@webkit.org> 6150 6151 Reviewed by Adam Barth. 6152 6153 webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes 6154 https://bugs.webkit.org/show_bug.cgi?id=28291 6155 6156 This is a start. At least now webkit-patch will prompt when your ChangeLog looks questionable. 6157 We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that 6158 to strings with find in the diff. 6159 Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue. 6160 6161 * Scripts/webkitpy/common/checkout/api.py: 6162 * Scripts/webkitpy/common/checkout/diff_parser.py: 6163 * Scripts/webkitpy/tool/steps/abstractstep.py: 6164 * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py: 6165 * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py. 6166 * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py. 6167 * Scripts/webkitpy/tool/steps/validatereviewer.py: 6168 61692010-12-24 Dirk Pranke <dpranke@chromium.org> 6170 6171 Reviewed by Kenneth Russell. 6172 6173 Modify new-run-webkit-tests to shut up and exit when all the threads 6174 are wedged so that test runs complete faster and we don't end up 6175 w/ enormous log files. 6176 6177 https://bugs.webkit.org/show_bug.cgi?id=51572 6178 6179 * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: 6180 * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: 6181 61822010-12-24 Eric Seidel <eric@webkit.org> 6183 6184 Reviewed by David Levin. 6185 6186 commit-queue should better explain how it will re-open bugs and follow duplicate chains 6187 https://bugs.webkit.org/show_bug.cgi?id=51549 6188 6189 I've had multiple people ask me about the commit-queue's behavior 6190 regarding reporting flaky tests. I figured it would be best to just 6191 have the queue explain itself in the bugs it files. 6192 6193 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 6194 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: 6195 61962010-12-24 Shinichiro Hamaji <hamaji@chromium.org> 6197 6198 Reviewed by Eric Seidel. 6199 6200 check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt 6201 https://bugs.webkit.org/show_bug.cgi?id=51467 6202 6203 * Scripts/webkitpy/style/checker.py: 6204 * Scripts/webkitpy/style/checker_unittest.py: 6205 62062010-12-23 Adam Barth <abarth@webkit.org> 6207 6208 Rubber-stamped by Eric Seidel. 6209 6210 Move JavaScriptGlue into Sources 6211 https://bugs.webkit.org/show_bug.cgi?id=51583 6212 6213 These tools refer to JavaScriptGlue and need to be updated to its new 6214 location. 6215 6216 * Scripts/build-webkit: 6217 * Scripts/do-file-rename: 6218 * Scripts/do-webcore-rename: 6219 * Scripts/webkitpy/common/config/build.py: 6220 * Scripts/webkitpy/common/config/build_unittest.py: 6221 62222010-12-23 Lucas Forschler <lforschler@apple.com> 6223 6224 Reviewed by Eric Seidel. 6225 6226 Bug 51539 - update iexploder scripts to point to new location 6227 6228 * Scripts/run-iexploder-tests: 6229 * Scripts/update-iexploder-cssproperties: 6230 62312010-12-23 Evan Martin <evan@chromium.org> 6232 6233 Reviewed by Ryosuke Niwa. 6234 6235 [chromium] LayoutTestController warning in float->int conversion 6236 https://bugs.webkit.org/show_bug.cgi?id=51553 6237 6238 Rather than reading an int, converting to a float, then getting a compiler 6239 warning on passing the float to something that expects an int, instead 6240 just pass around ints. 6241 6242 No tests, fixes a compiler warning. 6243 6244 * DumpRenderTree/chromium/LayoutTestController.cpp: 6245 (parsePageSizeParameters): 6246 (LayoutTestController::pageNumberForElementById): 6247 (LayoutTestController::numberOfPages): 6248 62492010-12-23 Lucas Forschler <lforschler@apple.com> 6250 6251 Reviewed by Darin Adler. 6252 6253 Bug 51537 - iexploder needs cleanup 6254 6255 * iExploder/htdocs: Removed. 6256 * iExploder/htdocs/config.rb: Removed. 6257 * iExploder/htdocs/cssproperties.in: Removed. 6258 * iExploder/htdocs/cssvalues.in: Removed. 6259 * iExploder/htdocs/htmlattrs.in: Removed. 6260 * iExploder/htdocs/htmltags.in: Removed. 6261 * iExploder/htdocs/htmlvalues.in: Removed. 6262 * iExploder/htdocs/iexploder.cgi: Removed. 6263 * iExploder/htdocs/iexploder.rb: Removed. 6264 * iExploder/htdocs/index.html: Removed. 6265 * iExploder/htdocs/webserver.rb: Removed. 6266 * iExploder/iexploder-1.7.2/output: Removed. 6267 * iExploder/tools: Removed. 6268 * iExploder/tools/lasthit.rb: Removed. 6269 * iExploder/tools/osx_last_crash.rb: Removed. 6270 * iExploder/tools/showtest.rb: Removed. 6271 62722010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi> 6273 6274 Reviewed by Kenneth Rohde Christiansen. 6275 6276 [EFL] Make 'single' the default backing store in EWebLauncher 6277 https://bugs.webkit.org/show_bug.cgi?id=51534 6278 6279 'single' is the simplest backing store and the one intended to be the 6280 default in the test browser. By mistake the tiled backing store was 6281 left as default in r72617. 6282 6283 * EWebLauncher/main.c: 6284 (browserCreate): ditto. 6285 62862010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi> 6287 6288 Reviewed by Kenneth Rohde Christiansen. 6289 6290 [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround 6291 https://bugs.webkit.org/show_bug.cgi?id=51533 6292 6293 There's no point in concatenating env("HOME") with "blah", so remove 6294 option from EWebLauncher. 6295 6296 * EWebLauncher/main.c: 6297 (main): ditto. 6298 62992010-12-23 Ilya Tikhonovsky <loislo@chromium.org> 6300 6301 Reviewed by Eric Seidel. 6302 6303 Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug). 6304 6305 Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT. 6306 I just discovered that we have two additional GC runs per each WebViewHost. 6307 Test_shell had no such calls. 6308 These gc runs eat 15% of cpu time. 6309 6310 https://bugs.webkit.org/show_bug.cgi?id=51479 6311 6312 * DumpRenderTree/chromium/WebViewHost.cpp: 6313 (WebViewHost::~WebViewHost): 6314 63152010-12-22 Dirk Pranke <dpranke@chromium.org> 6316 6317 Reviewed by Ojan Vafai. 6318 6319 This change splits out the TestRunner class into its own file. 6320 When we fork the code for message passing, we will create a new 6321 TestRunner, and this change will allow that to be more modular. 6322 6323 While we're at it, split out TestInput and ResultSummary into 6324 their own files, to reduce the size of run_webkit_tests to 6325 something more managable. 6326 6327 https://bugs.webkit.org/show_bug.cgi?id=51092 6328 6329 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 6330 * Scripts/webkitpy/layout_tests/layout_package/result_summary.py: 6331 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 6332 * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py: 6333 * Scripts/webkitpy/layout_tests/layout_package/test_input.py: 6334 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6335 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 6336 6337 2010-12-22 Dirk Pranke <dpranke@chromium.org> 6338 6339 Reviewed by Ojan Vafai. 6340 6341 nrwt multiprocessing - start over, prepare to fork the code 6342 6343 This code cleans up the signatures and implementation of the 6344 TestRunner class so we can easily fork it to run either the 6345 stable implementation or the new, unstable message-passing 6346 implementation. The two variants will have different 6347 implementations of the run_tests() method. We will switch 6348 between the two based on the setting for the '--worker-model' 6349 switch. We rename the two currently valid values to 'old-inline' 6350 and 'old-threads'. 6351 6352 https://bugs.webkit.org/show_bug.cgi?id=51081 6353 6354 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6355 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 6356 63572010-12-22 Victor Wang <victorw@chromium.org> 6358 6359 Reviewed by Darin Fisher. 6360 6361 [Chromium] Update chromium archive test result url in rebaseline script. 6362 6363 https://bugs.webkit.org/show_bug.cgi?id=51503 6364 6365 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 6366 63672010-12-22 Lucas Forschler <lforschler@apple.com> 6368 6369 Reviewed by Alice Liu. 6370 6371 <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess. 6372 Verified on Chrome, Safari, and IE. 6373 With this change, we will record memory from a parent browser window and all child processes. 6374 6375 * record-memory-win/main.cpp: 6376 (ProcessArgs): 6377 (PrintUsage): 6378 (getMemoryInfo): 6379 (printProcessInfo): 6380 (evalProcesses): 6381 (UseImage): 6382 (QueryContinuously): 6383 (ElapsedTime): 6384 63852010-12-22 Lucas Forschler <lforschler@apple.com> 6386 6387 Unreviewed rollout r74489, because it was missing changelog. 6388 6389 * record-memory-win/main.cpp: 6390 63912010-12-22 Ryosuke Niwa <rniwa@webkit.org> 6392 6393 Adding myself as a reviewer. 6394 6395 * Scripts/webkitpy/common/config/committers.py: 6396 63972010-12-22 Andrew Scherkus <scherkus@chromium.org> 6398 6399 Unreviewed. Adding myself to committers.py. 6400 6401 * Scripts/webkitpy/common/config/committers.py: 6402 64032010-12-22 Ariya Hidayat <ariya@sencha.com> 6404 6405 Reviewed by Kenneth Rohde Christiansen. 6406 6407 TestNetscapePlugIn should use #if defined 6408 https://bugs.webkit.org/show_bug.cgi?id=51471 6409 6410 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 6411 (NP_Initialize): 6412 (NPP_New): 6413 64142010-12-22 Ilya Tikhonovsky <loislo@chromium.org> 6415 6416 Reviewed by Yury Semikhatsky. 6417 6418 Web Inspector: [chromium] DRT inspector layout tests are flaky in debug. 6419 6420 DevTools window should be closed explicitly because it has custom deinitialization code. 6421 6422 https://bugs.webkit.org/show_bug.cgi?id=50722 6423 6424 * DumpRenderTree/chromium/TestShell.cpp: 6425 (TestShell::closeRemainingWindows): 6426 64272010-12-22 David Levin <levin@chromium.org> 6428 6429 Reviewed by Shinichiro Hamaji. 6430 6431 check-webkit-style shouldn't complaint about underscores in variables in objective C files. 6432 https://bugs.webkit.org/show_bug.cgi?id=51452 6433 6434 * Scripts/webkitpy/style/checkers/cpp.py: 6435 (_FileState.__init__): Added the information to determine if a file is C or Objective C. 6436 Using the file extension if possible but falling back to the file contents if we have a header file. 6437 (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed. 6438 (_FileState.is_c_or_objective_c): 6439 (check_using_std): Changed to using _FileState to determine the file type. 6440 (check_max_min_macros): Ditto. 6441 (check_for_null): Ditto. 6442 (check_style): Changed the parameters to various calls since they now need _FileState 6443 to determine the file type. 6444 (check_language): Added the file_state parameter so it could be passed 6445 to check_identifier_name_in_declaration. 6446 (check_identifier_name_in_declaration): Don't warn about underscores in variables if 6447 this is an Objective C file. 6448 (_process_lines): Added information for the _FileState constructor (and moved the 6449 call to a place that had the information). 6450 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 6451 (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise 6452 its functionality. 6453 (WebKitStyleTest.test_names): Add tests for underscores in Objective C files. 6454 64552010-12-21 Andy Estes <aestes@apple.com> 6456 6457 Reviewed by Mark Rowe. 6458 6459 Do not build non-Intel architectures for WebKit2-related projects. 6460 https://bugs.webkit.org/show_bug.cgi?id=51440 6461 6462 * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64. 6463 * TestWebKitAPI/Configurations/Base.xcconfig: Ditto. 6464 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. 6465 64662010-12-21 Mihai Parparita <mihaip@chromium.org> 6467 6468 Reviewed by Darin Fisher. 6469 6470 [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin 6471 https://bugs.webkit.org/show_bug.cgi?id=51406 6472 6473 Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT 6474 to WebThemeEngineDRTWin and update references everywhere. 6475 6476 * DumpRenderTree/DumpRenderTree.gypi: 6477 * DumpRenderTree/chromium/TestShellWin.cpp: 6478 * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp. 6479 * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h. 6480 * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp. 6481 * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h. 6482 64832010-12-21 Anders Carlsson <andersca@apple.com> 6484 6485 Reviewed by John Sullivan. 6486 6487 Clicking missing plug-in text does not show a sheet 6488 https://bugs.webkit.org/show_bug.cgi?id=51403 6489 6490 Update for changes to the WebPageUIClient. 6491 6492 * MiniBrowser/mac/BrowserWindowController.m: 6493 (-[BrowserWindowController awakeFromNib]): 6494 * WebKitTestRunner/TestController.cpp: 6495 (WTR::createOtherPage): 6496 (WTR::TestController::initialize): 6497 64982010-12-21 Eric Seidel <eric@webkit.org> 6499 6500 Reviewed by Adam Barth. 6501 6502 commit-queue will report constant failures as flaky if other tests flake 6503 https://bugs.webkit.org/show_bug.cgi?id=51272 6504 6505 This patch just removes functionality and adds testing. 6506 Previously we attempted to report flaky tests when we had 6507 two different tests fail in a row. However, since we stop 6508 running the tests at the first failure, our code was wrong in 6509 trying to determine flakiness from the incomplete runs. 6510 6511 Originally I posted an alternate patch: 6512 https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078 6513 which fixed our flaky logic in this case, however it was decided 6514 that that patch would be too difficult to maintain, so now 6515 I'm just removing the broken logic. 6516 6517 This will dramatically cut-down on our flaky-test false positives 6518 at the (small) cost of the queues being unable to report 6519 any flakiness if the tree is very flaky. (With at least one test 6520 flaking on every run, we'll never report failures anymore.) I think 6521 this is a tradeoff worth making. 6522 6523 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 6524 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 6525 65262010-12-20 Eric Seidel <eric@webkit.org> 6527 6528 Reviewed by Adam Barth. 6529 6530 commit-queue wrongly rejects patches when it can't update itself 6531 https://bugs.webkit.org/show_bug.cgi?id=46636 6532 6533 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 6534 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 6535 * Scripts/webkitpy/tool/commands/queues_unittest.py: 6536 65372010-12-20 Adam Barth <abarth@webkit.org> 6538 6539 Move web sites to Websites directory 6540 https://bugs.webkit.org/show_bug.cgi?id=51323 6541 6542 Update references to BugsSite to point to the new location. 6543 6544 This patch was never officially reviewed (because it was too large to 6545 upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark 6546 Rowe gave me the green light. 6547 6548 * Scripts/old-run-webkit-tests: 6549 * Scripts/webkitpy/common/config/build.py: 6550 * Scripts/webkitpy/common/config/build_unittest.py: 6551 * Scripts/webkitpy/common/prettypatch.py: 6552 * Scripts/webkitpy/layout_tests/port/base.py: 6553 * Scripts/webkitpy/style/main.py: 6554 65552010-12-20 Adrienne Walker <enne@google.com> 6556 6557 Unreviewed. Adding myself to the list of committers. 6558 6559 * webkitpy/common/config/committers.py: 6560 65612010-12-20 Mark Rowe <mrowe@apple.com> 6562 6563 Reviewed by Dan Bernstein. 6564 6565 <rdar://problem/8757601> Don't install header files in to the Resources directory. 6566 6567 * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the 6568 Resources directory. 6569 65702010-12-20 Eric Seidel <eric@webkit.org> 6571 6572 Reviewed by Adam Barth. 6573 6574 commit-queue should include bot id when attaching failure diffs 6575 https://bugs.webkit.org/show_bug.cgi?id=51280 6576 6577 This is a tiny change to include the bot id in the name of the attachment. 6578 Most of this diff is just changing the unit test expectations 6579 now that I hid the comment printing when the comment is None. 6580 6581 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 6582 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: 6583 * Scripts/webkitpy/tool/commands/upload_unittest.py: 6584 * Scripts/webkitpy/tool/mocktool.py: 6585 65862010-12-20 Jeff Miller <jeffm@apple.com> 6587 6588 Reviewed by Dan Bernstein. 6589 6590 Tools/vcbin/midl.exe needs to be rebuilt 6591 https://bugs.webkit.org/show_bug.cgi?id=51347 6592 6593 * vcbin/midl.exe: Rebuilt. 6594 65952010-12-20 David Levin <levin@chromium.org> 6596 6597 Reviewed by Ariya Hidayat. 6598 6599 .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools. 6600 https://bugs.webkit.org/show_bug.cgi?id=51343 6601 6602 Follow up from the WebKitTools -> Tools rename. 6603 6604 * Scripts/webkit-tools-completion.sh: 6605 66062010-12-20 Cosmin Truta <ctruta@chromium.org> 6607 6608 Reviewed by James Robinson. 6609 6610 new-run-webkit-tests ignores trailing EOL differences in text tests 6611 https://bugs.webkit.org/show_bug.cgi?id=36983 6612 6613 Changed the handling of new-line characters within new-run-webkit-tests 6614 to match old-run-webkit-tests. Differences in leading and trailing empty 6615 lines in text expectation files are no longer ignored. 6616 6617 * Scripts/webkitpy/layout_tests/port/base.py: 6618 * Scripts/webkitpy/layout_tests/port/test.py: 6619 Added unit tests. Removed old duplicate unit test entries. 6620 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 6621 66222010-12-20 David Levin <levin@chromium.org> 6623 6624 Reviewed by Shinichiro Hamaji. 6625 6626 check-webkit-style should detect function declarations (and trivial functions). 6627 https://bugs.webkit.org/show_bug.cgi?id=51303 6628 6629 * Scripts/webkitpy/style/checkers/cpp.py: 6630 (_FunctionState.begin): Add is_declaration and changed the line count 6631 start to begin at -1 (which will keep the results consistent, since 6632 the starting line number passed in is one less in this change). 6633 (detect_functions): changed function detection to now catch trivial 6634 functions and declarations. 6635 (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line 6636 of the function as this may look at return values (when processing 6637 a declaration). 6638 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 6639 (FunctionDetectionTest.perform_function_detection): Basic mechanics 6640 of testing the function detection. 6641 (FunctionDetectionTest.test_basic_function_detection): Test a simple 6642 function. 6643 (FunctionDetectionTest.test_function_declaration_detection): Test a 6644 declaration. 6645 (FunctionDetectionTest.test_non_functions): A test case for a case 6646 that caused the code to fail due to the { being in quotes. 6647 (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test 6648 cases to help catch false alarms for return values. 6649 (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that 6650 we don't get false alarms for member variables either. 6651 66522010-12-20 Ryuan Choi <ryuan.choi@samsung.com> 6653 6654 Reviewed by Antonio Gomes. 6655 6656 [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR 6657 https://bugs.webkit.org/show_bug.cgi?id=51319 6658 6659 * CMakeListsEfl.txt: 6660 66612010-12-18 Adam Barth <abarth@webkit.org> 6662 6663 Reviewed by Sam Weinig. 6664 6665 Move WebKitExamplePlugins to Examples 6666 https://bugs.webkit.org/show_bug.cgi?id=51291 6667 6668 * Scripts/webkitpy/common/config/build.py: 6669 66702010-12-17 Csaba Osztrogonác <ossy@webkit.org> 6671 6672 Unreviewed Qt buildfix after r74301. 6673 6674 Rename WebKitTools to Tools 6675 https://bugs.webkit.org/show_bug.cgi?id=49861 6676 6677 * MiniBrowser/DerivedSources.pro: 6678 * MiniBrowser/qt/MiniBrowser.pro: 6679 66802010-12-17 Dan Bernstein <mitz@apple.com> 6681 6682 Reviewed by Simon Fraser. 6683 6684 Rename WebKitTools to Tools 6685 https://bugs.webkit.org/show_bug.cgi?id=49861 6686 6687 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 6688 * CodeCoverage/README: 6689 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 6690 (WebCore::DumpRenderTree::initializeFonts): 6691 * EWSTools/start-commit-queue.sh: 6692 * EWSTools/start-queue.sh: 6693 * GNUmakefile.am: 6694 * MIDLWrapper/MIDLWrapper.cpp: 6695 (wmain): 6696 * MiniBrowser/qt/MiniBrowser.pro: 6697 * Scripts/build-api-tests: 6698 * Scripts/build-dumprendertree: 6699 * Scripts/build-webkit: 6700 * Scripts/build-webkittestrunner: 6701 * Scripts/generate-coverage-data: 6702 * Scripts/old-run-webkit-tests: 6703 * Scripts/run-api-tests: 6704 * Scripts/run-iexploder-tests: 6705 * Scripts/run-javascriptcore-tests: 6706 * Scripts/run-mangleme-tests: 6707 * Scripts/run-sunspider: 6708 * Scripts/run-webkit-websocketserver: 6709 * Scripts/sunspider-compare-results: 6710 * Scripts/test-webkitperl: 6711 * Scripts/test-webkitpy: 6712 * Scripts/update-iexploder-cssproperties: 6713 * Scripts/update-webkit: 6714 * Scripts/update-webkit-localizable-strings: 6715 * Scripts/webkitdirs.pm: 6716 * Scripts/webkitpy/common/checkout/scm.py: 6717 * Scripts/webkitpy/common/checkout/scm_unittest.py: 6718 * Scripts/webkitpy/common/config/committervalidator.py: 6719 * Scripts/webkitpy/common/config/committervalidator_unittest.py: 6720 * Scripts/webkitpy/common/config/ports.py: 6721 * Scripts/webkitpy/common/config/ports_unittest.py: 6722 * Scripts/webkitpy/common/system/logutils_unittest.py: 6723 * Scripts/webkitpy/common/system/ospath_unittest.py: 6724 * Scripts/webkitpy/layout_tests/port/chromium.py: 6725 * Scripts/webkitpy/layout_tests/port/config.py: 6726 * Scripts/webkitpy/layout_tests/port/config_unittest.py: 6727 * Scripts/webkitpy/layout_tests/port/http_server.py: 6728 * Scripts/webkitpy/layout_tests/port/test.py: 6729 * Scripts/webkitpy/style/checker.py: 6730 * Scripts/webkitpy/style/checker_unittest.py: 6731 * Scripts/webkitpy/tool/bot/feeders_unittest.py: 6732 * Scripts/webkitpy/tool/commands/queues_unittest.py: 6733 * Scripts/webkitpy/tool/steps/steps_unittest.py: 6734 * WebKitTestRunner/DerivedSources.pro: 6735 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: 6736 (WTR::activateFonts): 6737 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: 6738 * wx/build/build_utils.py: 6739 67402010-12-16 Antonio Gomes <agomes@rim.com> 6741 6742 Reviewed by Martin Robinson. 6743 6744 Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests 6745 https://bugs.webkit.org/show_bug.cgi?id=51163 6746 6747 Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp), 6748 GTK+'s DRT should also reset to UNIX after each test execution. 6749 6750 * DumpRenderTree/gtk/DumpRenderTree.cpp: 6751 (resetDefaultsToConsistentValues): 6752 67532010-12-17 David Levin <levin@chromium.org> 6754 6755 Reviewed by Eric Seidel. 6756 6757 check-webkit-style should understand WTF #include guards 6758 https://bugs.webkit.org/show_bug.cgi?id=44911 6759 6760 * Scripts/webkitpy/style/checkers/cpp.py: 6761 (get_header_guard_cpp_variable): modify to suggest the WTF style 6762 of header guard when appropriate. 6763 (check_for_header_guard): handle multiple return values from 6764 get_header_guard_cpp_variable 6765 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 6766 (CppStyleTest.test_build_header_guard): Added tests for the WTF 6767 header style. 6768 67692010-12-16 David Levin <levin@chromium.org> 6770 6771 Reviewed by Eric Seidel. 6772 6773 test-webkitpy: unittest for the xml.py checker displays a decprecation warning. 6774 https://bugs.webkit.org/show_bug.cgi?id=51210 6775 6776 The error only shows up when using python 2.6 or later. 6777 6778 * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of 6779 the decprecated field error,message with something equivalent. 6780 67812010-12-16 Mihai Parparita <mihaip@chromium.org> 6782 6783 Reviewed by Eric Seidel. 6784 6785 Add --exit-after-n-failures/crashes to NRWT 6786 https://bugs.webkit.org/show_bug.cgi?id=51160 6787 6788 Abort test run (in a similar way to how control-C is handled) when 6789 --exit-after-n-failures/crashes-or-timeouts are passed and we've reached 6790 that number of unexpected failures/crashes/timeouts. 6791 6792 * Scripts/webkitpy/layout_tests/port/test.py: 6793 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6794 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 6795 67962010-12-16 David Levin <levin@chromium.org> 6797 6798 Reviewed by Shinichiro Hamaji. 6799 6800 check-webkit-style unit tests has some duplicate boilerplate code. 6801 https://bugs.webkit.org/show_bug.cgi?id=49519 6802 6803 * Scripts/webkitpy/style/checkers/cpp.py: 6804 (update_include_state): Replaced the "io" parameter with the global 6805 configuration _unit_test_config. This allowed not calling into 6806 functions at a low level and also not plumbing through the injection 6807 information through many levels of code. 6808 (check_for_include_what_you_use): Ditto. 6809 (process_file_data): Added the ability to set up the unit test config 6810 to allow for injection. 6811 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 6812 (ErrorCollector.__init__): Added support for having a filter for errors. 6813 (ErrorCollector.__call__): Ditto. 6814 (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config. 6815 (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions. 6816 (CppStyleTestBase.perform_single_line_lint): Replace specific calls to 6817 functions in the cpp.py with generic processing and a filter that 6818 indicates what errors should be kept. 6819 (CppStyleTestBase.perform_multi_line_lint): Ditto. 6820 (CppStyleTestBase.perform_language_rules_check): Ditto. 6821 (CppStyleTestBase.perform_function_lengths_check): Ditto. 6822 (CppStyleTestBase.perform_pass_ptr_check): Ditto. 6823 (CppStyleTestBase.perform_include_what_you_use): Ditto. 6824 (CppStyleTest.test_multi_line_comments): Added another 6825 error message which applies to the test case. 6826 (CppStyleTest.test_spacing_for_binary_ops): Fixed test 6827 to not have config.h, since it is processed as a header file. 6828 (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name 6829 style and indentation in checked code. 6830 (OrderOfIncludesTest.test_check_preprocessor_in_include_section): 6831 Fixed line number. 6832 (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): 6833 Ditto. 6834 68352010-12-15 Sheriff Bot <webkit.review.bot@gmail.com> 6836 6837 Unreviewed, rolling out r74136. 6838 http://trac.webkit.org/changeset/74136 6839 https://bugs.webkit.org/show_bug.cgi?id=51135 6840 6841 r74136 breaks chromium canary bots because some tests are not 6842 rebaselined correctly to resolve EOL differences (Requested by 6843 jianli on #webkit). 6844 6845 * Scripts/webkitpy/layout_tests/port/base.py: 6846 * Scripts/webkitpy/layout_tests/port/test.py: 6847 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 6848 68492010-12-15 Adam Roben <aroben@apple.com> 6850 6851 Teach check-webkit-style to check .vcproj and .vsprops files for XML 6852 syntax errors 6853 6854 Fixes <http://webkit.org/b/51103> check-webkit-style should check for 6855 XML syntax errors in .vcproj/.vsprops files 6856 6857 Reviewed by Dave Levin. 6858 6859 * Scripts/webkitpy/style/checker.py: Added lists of file extensions 6860 that should be treated as XML and that should be allowed to contain 6861 carriage returns. (These lists happen to be identical currently.) 6862 (FileType): Added a new XML type. 6863 (CheckerDispatcher.should_check_and_strip_carriage_returns): Added. 6864 Just does a simple file extension check. 6865 (CheckerDispatcher._file_type): Added a case for XML files. 6866 (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML 6867 files (surprise!). 6868 (StyleProcessor.process): Ask the dispatcher whether we should pass the 6869 lines through the carriage checker. 6870 6871 * Scripts/webkitpy/style/checker_unittest.py: 6872 (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns): 6873 Added. Checks a few file names to see if carriage returns are allowed 6874 or not. 6875 (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to 6876 other assert_checker_* functions. 6877 (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other 6878 test_*_paths functions. 6879 (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other 6880 test_*_paths functions. 6881 (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj 6882 file from this test case, as vcproj files now have a type. 6883 (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns): 6884 Added. Similar to the other should_* functions. 6885 (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped): 6886 Added. Checks that carriage returns aren't checked for or stripped for 6887 allowed files. 6888 6889 * Scripts/webkitpy/style/checkers/xml.py: Added. 6890 (XMLChecker.__init__): Simple init method. 6891 (XMLChecker.check): Pass each line through the expat parser, and record 6892 a style error for any errors thrown by the parser. 6893 6894 * Scripts/webkitpy/style/checkers/xml_unittest.py: Added. 6895 (XMLCheckerTest.assert_no_error): Checks that the given XML does not 6896 produce a style error. 6897 (XMLCheckerTest.assert_error): Checks that the given XML produces an 6898 error of the given category on the given line. 6899 (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for 6900 checking that the XMLChecker constructor works properly. 6901 (XMLCheckerTest.test_conflict_marker): Tests that conflict markers 6902 cause a style error (see, e.g., r73887). 6903 (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags 6904 cause a style error (see, e.g., r73773). 6905 (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works 6906 properly. 6907 (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing 6908 tags cause a style error (see, e.g., r72795). 6909 (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a 6910 style error. 6911 69122010-12-15 Lucas Forschler <lforschler@apple.com> 6913 6914 Reviewed by Stephanie Lewis. 6915 6916 https://bugs.webkit.org/show_bug.cgi?id=51117 6917 Add a new leopard test bot 6918 really really commit to trunk this time. 6919 6920 * BuildSlaveSupport/build.webkit.org-config/config.json: 6921 69222010-12-15 Sam Weinig <sam@webkit.org> 6923 6924 Reviewed by Anders Carlsson. 6925 6926 WebKit2: Can't add files to an <input type=file> 6927 https://bugs.webkit.org/show_bug.cgi?id=51087 6928 6929 * MiniBrowser/mac/BrowserWindowController.m: 6930 (runOpenPanel): 6931 (-[BrowserWindowController awakeFromNib]): 6932 Add simple implementation of runOpenPanel callback. 6933 6934 * MiniBrowser/win/BrowserView.cpp: 6935 (BrowserView::create): 6936 * WebKitTestRunner/TestController.cpp: 6937 (WTR::createOtherPage): 6938 (WTR::TestController::initialize): 6939 Stub out runOpenPanel callback. 6940 69412010-12-14 Eric Seidel <eric@webkit.org> 6942 6943 Reviewed by Adam Barth. 6944 6945 commit-queue should upload failure diffs when tests flake 6946 https://bugs.webkit.org/show_bug.cgi?id=51051 6947 6948 To make this testable I needed to pipe FileSystem down onto tool. 6949 We've wanted it there for a long time anyway. 6950 6951 This patch is kinda a big hack. But we don't have a nice 6952 way to read results.html files. I think this will need further 6953 revision before this code actually feels clean. 6954 6955 As part of testing this change, I had to make MockBugzilla.create_bug 6956 actually return an id (like it should) which required updating 6957 a few other unit test results (for the better). 6958 6959 The results_matching_keys change in layouttestresults/rebasline 6960 was an alternate path which I decided not to use in the end, but 6961 I left the change as it seemed an improvement. 6962 6963 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 6964 * Scripts/webkitpy/common/net/layouttestresults.py: 6965 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 6966 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: 6967 * Scripts/webkitpy/tool/commands/queues.py: 6968 * Scripts/webkitpy/tool/commands/rebaseline.py: 6969 * Scripts/webkitpy/tool/main.py: 6970 * Scripts/webkitpy/tool/mocktool.py: 6971 69722010-12-15 Cosmin Truta <ctruta@chromium.org> 6973 6974 Reviewed by James Robinson. 6975 6976 new-run-webkit-tests ignores trailing EOL differences in text tests 6977 https://bugs.webkit.org/show_bug.cgi?id=36983 6978 6979 Changed the handling of new-line characters within new-run-webkit-tests 6980 to match old-run-webkit-tests. Differences in leading and trailing empty 6981 lines in text expectation files are no longer ignored. 6982 6983 * Scripts/webkitpy/layout_tests/port/base.py: 6984 * Scripts/webkitpy/layout_tests/port/test.py: 6985 Added unit tests. Removed old duplicate unit test entries. 6986 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 6987 69882010-12-15 Ojan Vafai <ojan@chromium.org> 6989 6990 Reviewed by Adam Barth. 6991 6992 make status-bubble white-space:nowrap so we can measure it's width without wrapping 6993 https://bugs.webkit.org/show_bug.cgi?id=51149 6994 6995 * QueueStatusServer/templates/statusbubble.html: 6996 69972010-12-15 Ojan Vafai <ojan@chromium.org> 6998 6999 Reviewed by Adam Barth. 7000 7001 have the statusbubble postMessage it's metrics so that embedders can properly size the iframe 7002 https://bugs.webkit.org/show_bug.cgi?id=51125 7003 7004 * QueueStatusServer/templates/statusbubble.html: 7005 70062010-12-15 Darin Adler <darin@apple.com> 7007 7008 * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore. 7009 70102010-12-15 Sheriff Bot <webkit.review.bot@gmail.com> 7011 7012 Unreviewed, rolling out r74117. 7013 http://trac.webkit.org/changeset/74117 7014 https://bugs.webkit.org/show_bug.cgi?id=51113 7015 7016 This broke the GTK1 build. (Requested by mrobinson on 7017 #webkit). 7018 7019 * Scripts/webkitdirs.pm: 7020 70212010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com> 7022 7023 Reviewed by Martin Robinson. 7024 7025 Change generate-forwarding-headers.pl for GTK port usage 7026 (https://bugs.webkit.org/show_bug.cgi?id=37369) 7027 7028 * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script. 7029 70302010-12-14 Kent Tamura <tkent@chromium.org> 7031 7032 Reviewed by Jian Li. 7033 7034 [DRT/Chromium] Remove another unnecessary error message 7035 https://bugs.webkit.org/show_bug.cgi?id=51083 7036 7037 * DumpRenderTree/chromium/WebViewHost.cpp: 7038 (WebViewHost::didInvalidateRect): 7039 70402010-12-14 Lucas Forschler <lforschler@apple.com> 7041 7042 Reviewed by Stephanie Lewis. 7043 7044 Add a new Leopard Debug Test WK2 Bot 7045 7046 * BuildSlaveSupport/build.webkit.org-config/config.json: 7047 70482010-12-14 Ojan Vafai <ojan@chromium.org> 7049 7050 Fix python unittests after http://trac.webkit.org/changeset/74070. 7051 7052 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: 7053 70542010-12-14 Kent Tamura <tkent@chromium.org> 7055 7056 Reviewed by Jian Li. 7057 7058 [DRT/Chromium] Remove a unnecessary error message 7059 https://bugs.webkit.org/show_bug.cgi?id=51069 7060 7061 * DumpRenderTree/chromium/WebViewHost.cpp: 7062 (WebViewHost::paintInvalidatedRegion): 7063 70642010-12-14 Benjamin Kalman <kalman@chromium.org> 7065 7066 Reviewed by Ojan Vafai. 7067 7068 Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK 7069 https://bugs.webkit.org/show_bug.cgi?id=48926 7070 7071 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 7072 Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_. 7073 70742010-12-14 Laszlo Gombos <laszlo.1.gombos@nokia.com> 7075 7076 Reviewed by Eric Seidel. 7077 7078 [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported 7079 https://bugs.webkit.org/show_bug.cgi?id=50231 7080 7081 Guard CONFIG+=link_pkgconfig with !symbian. 7082 7083 * DumpRenderTree/qt/DumpRenderTree.pro: 7084 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: 7085 * WebKitTestRunner/qt/WebKitTestRunner.pro: 7086 70872010-12-14 Philippe Normand <pnormand@igalia.com> 7088 7089 Reviewed by Ojan Vafai. 7090 7091 [new-run-webkit-tests] expectations parsing is slow 7092 https://bugs.webkit.org/show_bug.cgi?id=50635 7093 7094 Avoid expensive iteration of all the tests when checking if a test 7095 file is to be skipped or not. 7096 7097 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 7098 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 7099 * Scripts/webkitpy/layout_tests/port/test.py: 7100 71012010-12-14 Mario Sanchez Prada <msanchez@igalia.com> 7102 7103 Reviewed by Xan Lopez. 7104 7105 [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects 7106 https://bugs.webkit.org/show_bug.cgi?id=27048 7107 7108 Add support in DRT for checking whether an accessibility UI 7109 element is focusable and/or focused. Implemented for GTK. 7110 7111 * DumpRenderTree/AccessibilityUIElement.cpp: 7112 (getIsFocusedCallback): New. 7113 (getIsFocusableCallback): New. 7114 (AccessibilityUIElement::getJSClass): Add the new available 7115 callbacks for isFocused and isFocusable. 7116 * DumpRenderTree/AccessibilityUIElement.h: 7117 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 7118 (AccessibilityUIElement::isFocused): New, implemented by checking 7119 whether the related AtkState value is in the object's state set. 7120 (AccessibilityUIElement::isFocusable): Ditto. 7121 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 7122 (AccessibilityUIElement::isFocused): New, dummy implementation. 7123 (AccessibilityUIElement::isFocusable): Ditto. 7124 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 7125 (AccessibilityUIElement::isFocused): Ditto. 7126 (AccessibilityUIElement::isFocusable): Ditto. 7127 71282010-12-14 Eric Seidel <eric@webkit.org> 7129 7130 Reviewed by Ojan Vafai. 7131 7132 webkit-patch should warn users when they're using a 32-bit git on a 64-bit system 7133 https://bugs.webkit.org/show_bug.cgi?id=50715 7134 7135 This patch makes webkit-patch print the following: 7136 7137 Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit. 7138 Install a 64-bit git for better performance, see: 7139 https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html 7140 7141 I wrote this mostly because I have approximately 8 machines that I use 7142 and making sure each one is using a good Git install seemed folly. 7143 webkit-patch makes a lot of git calls, so using a fast git can shave 7144 several seconds in every invocation. See the webkit-dev thread for more info. 7145 7146 This message will print twice during 'webkit-patch upload', 7147 once from webkit-patch and once from check-webkit-style. 7148 7149 Unfortunately there is no good way to test this due to how machine-dependent 7150 the code is. I considered writing a test for the log message, but it seemed not worth it. 7151 7152 * Scripts/webkitpy/common/checkout/scm.py: 7153 71542010-12-13 Eric Seidel <eric@webkit.org> 7155 7156 Reviewed by Adam Barth. 7157 7158 FlakyTestReporter doesn't understand bots running from multiple email addresses 7159 https://bugs.webkit.org/show_bug.cgi?id=50960 7160 7161 This explains at least one of the dupes of: 7162 https://bugs.webkit.org/show_bug.cgi?id=50863 7163 that we saw filed by the commit-queue this morning. 7164 I think the other one was explained by my previous fix to result counting code. 7165 7166 Since this is really hard to test with a unit test, instead I 7167 create a new (possibly useful in the future) command 7168 which given a layout test path will return you 7169 the one bug which our tools would assume it the flaky test bug. 7170 If some other script wants to use bug-for-test we'll 7171 need to extend it with some options like --create-if-missing or similar. 7172 7173 * Scripts/webkitpy/common/net/bugzilla/bug.py: 7174 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 7175 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 7176 * Scripts/webkitpy/tool/commands/__init__.py: 7177 * Scripts/webkitpy/tool/commands/bugfortest.py: Added. 7178 71792010-12-13 Mihai Parparita <mihaip@chromium.org> 7180 7181 Reviewed by James Robinson. 7182 7183 Add option to build-webkit to not build WebKit2 7184 https://bugs.webkit.org/show_bug.cgi?id=50988 7185 7186 Add support for a --no-webkit2 option to build-webkit. It seems to save 7187 ~1 minute from clean builds and ~10 seconds from no-op builds. 7188 7189 * Scripts/build-webkit: 7190 71912010-12-13 Lucas Forschler <lforschler@apple.com> 7192 7193 Reviewed by Dave Kilzer. 7194 7195 Update iexploder from 1.3.2 to 1.7.2 7196 Move 1.3.2 into its own subdir 7197 Add 1.7.2 into its own subdir 7198 update scripts to point to new 1.3.2 location (avoid breaking existing scripts) 7199 7200 * Scripts/run-iexploder-tests: 7201 * Scripts/update-iexploder-cssproperties: 7202 * iExploder/CHANGELOG.txt: Removed. 7203 * iExploder/LICENSE.txt: Removed. 7204 * iExploder/README.txt: Removed. 7205 * iExploder/htdocs: Removed. 7206 * iExploder/iexploder-1.3.2: Added. 7207 * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt. 7208 * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt. 7209 * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt. 7210 * iExploder/iexploder-1.3.2/htdocs: Added. 7211 * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb. 7212 * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in. 7213 * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in. 7214 * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in. 7215 * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in. 7216 * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in. 7217 * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi. 7218 * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb. 7219 * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html. 7220 * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb. 7221 * iExploder/iexploder-1.3.2/tools: Added. 7222 * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb. 7223 * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb. 7224 * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb. 7225 * iExploder/iexploder-1.7.2: Added. 7226 * iExploder/iexploder-1.7.2/ChangeLog.txt: Added. 7227 * iExploder/iexploder-1.7.2/LICENSE.txt: Added. 7228 * iExploder/iexploder-1.7.2/README.txt: Added. 7229 * iExploder/iexploder-1.7.2/output: Added. 7230 * iExploder/iexploder-1.7.2/src: Added. 7231 * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added. 7232 * iExploder/iexploder-1.7.2/src/config.yaml: Added. 7233 * iExploder/iexploder-1.7.2/src/css-atrules: Added. 7234 * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added. 7235 * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added. 7236 * iExploder/iexploder-1.7.2/src/css-properties: Added. 7237 * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added. 7238 * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added. 7239 * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added. 7240 * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added. 7241 * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added. 7242 * iExploder/iexploder-1.7.2/src/css-pseudo: Added. 7243 * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added. 7244 * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added. 7245 * iExploder/iexploder-1.7.2/src/css-values: Added. 7246 * iExploder/iexploder-1.7.2/src/css-values/dillo: Added. 7247 * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added. 7248 * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added. 7249 * iExploder/iexploder-1.7.2/src/css-values/other: Added. 7250 * iExploder/iexploder-1.7.2/src/css-values/webkit: Added. 7251 * iExploder/iexploder-1.7.2/src/headers: Added. 7252 * iExploder/iexploder-1.7.2/src/headers/dillo: Added. 7253 * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added. 7254 * iExploder/iexploder-1.7.2/src/headers/mozilla: Added. 7255 * iExploder/iexploder-1.7.2/src/headers/webkit: Added. 7256 * iExploder/iexploder-1.7.2/src/html-attrs: Added. 7257 * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added. 7258 * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added. 7259 * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added. 7260 * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added. 7261 * iExploder/iexploder-1.7.2/src/html-attrs/other: Added. 7262 * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added. 7263 * iExploder/iexploder-1.7.2/src/html-tags: Added. 7264 * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added. 7265 * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added. 7266 * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added. 7267 * iExploder/iexploder-1.7.2/src/html-tags/other: Added. 7268 * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added. 7269 * iExploder/iexploder-1.7.2/src/html-values: Added. 7270 * iExploder/iexploder-1.7.2/src/html-values/dillo: Added. 7271 * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added. 7272 * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added. 7273 * iExploder/iexploder-1.7.2/src/html-values/other: Added. 7274 * iExploder/iexploder-1.7.2/src/html-values/webkit: Added. 7275 * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added. 7276 * iExploder/iexploder-1.7.2/src/iexploder.rb: Added. 7277 * iExploder/iexploder-1.7.2/src/index.html: Added. 7278 * iExploder/iexploder-1.7.2/src/media: Added. 7279 * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added. 7280 * iExploder/iexploder-1.7.2/src/media/blank.snd: Added. 7281 * iExploder/iexploder-1.7.2/src/media/blank.wav: Added. 7282 * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added. 7283 * iExploder/iexploder-1.7.2/src/media/bug.gif: Added. 7284 * iExploder/iexploder-1.7.2/src/media/bug.ico: Added. 7285 * iExploder/iexploder-1.7.2/src/media/bug.jng: Added. 7286 * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added. 7287 * iExploder/iexploder-1.7.2/src/media/bug.png: Added. 7288 * iExploder/iexploder-1.7.2/src/media/bug.svg: Added. 7289 * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added. 7290 * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added. 7291 * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added. 7292 * iExploder/iexploder-1.7.2/src/mime-types: Added. 7293 * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added. 7294 * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added. 7295 * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added. 7296 * iExploder/iexploder-1.7.2/src/protocols: Added. 7297 * iExploder/iexploder-1.7.2/src/protocols/dillo: Added. 7298 * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added. 7299 * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added. 7300 * iExploder/iexploder-1.7.2/src/protocols/webkit: Added. 7301 * iExploder/iexploder-1.7.2/src/scanner.rb: Added. 7302 * iExploder/iexploder-1.7.2/src/version.rb: Added. 7303 * iExploder/iexploder-1.7.2/src/webserver.rb: Added. 7304 * iExploder/iexploder-1.7.2/testcases: Added. 7305 * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added. 7306 * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added. 7307 * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added. 7308 * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added. 7309 * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added. 7310 * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added. 7311 * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added. 7312 * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added. 7313 * iExploder/iexploder-1.7.2/tools: Added. 7314 * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added. 7315 * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added. 7316 * iExploder/iexploder-1.7.2/tools/release_src.sh: Added. 7317 * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added. 7318 * iExploder/tools: Removed. 7319 73202010-12-13 Sam Weinig <sam@webkit.org> 7321 7322 Reviewed by Anders Carlsson. 7323 7324 Remove associated page concept from WKView constructor 7325 https://bugs.webkit.org/show_bug.cgi?id=50983 7326 7327 Step 1: Remove associate page constructors from WKView and make 7328 all views use the shared namespace for the context. 7329 7330 * TestWebKitAPI/PlatformWebView.h: 7331 * TestWebKitAPI/mac/PlatformWebViewMac.mm: 7332 * TestWebKitAPI/win/PlatformWebViewWin.cpp: 7333 * WebKitTestRunner/PlatformWebView.h: 7334 * WebKitTestRunner/TestController.cpp: 7335 (WTR::createOtherPage): 7336 * WebKitTestRunner/mac/PlatformWebViewMac.mm: 7337 * WebKitTestRunner/qt/PlatformWebViewQt.cpp: 7338 * WebKitTestRunner/win/PlatformWebViewWin.cpp: 7339 73402010-12-13 Sam Weinig <sam@webkit.org> 7341 7342 Reviewed by Anders Carlsson. 7343 7344 Change the WebKit2 public API so there is no explicit WKPageNamespace object 7345 https://bugs.webkit.org/show_bug.cgi?id=50898 7346 7347 * MiniBrowser/mac/AppDelegate.h: 7348 * MiniBrowser/mac/AppDelegate.m: 7349 * MiniBrowser/mac/BrowserWindowController.h: 7350 * MiniBrowser/mac/BrowserWindowController.m: 7351 * MiniBrowser/win/BrowserView.cpp: 7352 Convert MiniBrowser to not use PageNamespaces. 7353 7354 * TestWebKitAPI/PlatformWebView.h: 7355 * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: 7356 * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: 7357 * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: 7358 * TestWebKitAPI/Tests/WebKit2/Find.cpp: 7359 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: 7360 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: 7361 * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: 7362 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: 7363 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: 7364 * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: 7365 * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: 7366 * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: 7367 * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: 7368 * TestWebKitAPI/mac/PlatformWebViewMac.mm: 7369 * TestWebKitAPI/win/PlatformWebViewWin.cpp: 7370 Convert TestWebKitAPI to not use PageNamespaces. 7371 7372 * WebKitTestRunner/PlatformWebView.h: 7373 * WebKitTestRunner/TestController.cpp: 7374 * WebKitTestRunner/TestController.h: 7375 * WebKitTestRunner/mac/PlatformWebViewMac.mm: 7376 * WebKitTestRunner/qt/PlatformWebViewQt.cpp: 7377 * WebKitTestRunner/win/PlatformWebViewWin.cpp: 7378 Convert WebKitTestRunner to not use PageNamespaces. 7379 73802010-12-13 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 7381 7382 Reviewed by Eric Seidel. 7383 7384 webkit-patch rollout should be able to do multi-revision rollouts 7385 https://bugs.webkit.org/show_bug.cgi?id=33336 7386 7387 Make it possible to pass more than one revision to webkit-patch. 7388 7389 * Scripts/webkitpy/common/checkout/api.py: 7390 * Scripts/webkitpy/common/checkout/changelog.py: 7391 * Scripts/webkitpy/common/checkout/changelog_unittest.py: 7392 * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: 7393 * Scripts/webkitpy/tool/commands/download.py: 7394 * Scripts/webkitpy/tool/commands/download_unittest.py: 7395 * Scripts/webkitpy/tool/mocktool.py: 7396 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: 7397 * Scripts/webkitpy/tool/steps/revertrevision.py: 7398 73992010-12-13 Eric Seidel <eric@webkit.org> 7400 7401 Unreviewed. 7402 7403 Teach webkit-patch how to search bugzilla 7404 https://bugs.webkit.org/show_bug.cgi?id=50500 7405 7406 webkit-patch bug-search fails when there is only one result. 7407 Turns out we needed a bit more logic in our result count parsing code. 7408 7409 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 7410 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: 7411 74122010-12-13 Antti Koivisto <antti@apple.com> 7413 7414 Reviewed by Alexey Proskuryakov. 7415 7416 Add setSerializeHTTPLoads function to allow testing resource load order on OS X. 7417 https://bugs.webkit.org/show_bug.cgi?id=50758 7418 7419 * DumpRenderTree/LayoutTestController.cpp: 7420 (setSerializeHTTPLoadsCallback): 7421 (LayoutTestController::staticFunctions): 7422 * DumpRenderTree/LayoutTestController.h: 7423 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 7424 (LayoutTestController::setSerializeHTTPLoads): 7425 * DumpRenderTree/mac/DumpRenderTree.mm: 7426 (resetDefaultsToConsistentValues): 7427 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 7428 (LayoutTestController::setSerializeHTTPLoads): 7429 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 7430 (LayoutTestController::setSerializeHTTPLoads): 7431 74322010-12-13 Dimitri Glazkov <dglazkov@chromium.org> 7433 7434 Reviewed by Ojan Vafai. 7435 7436 Remove "use-drt" option from test step command line, since the option was removed in r73748. 7437 https://bugs.webkit.org/show_bug.cgi?id=50936 7438 7439 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option. 7440 74412010-12-13 Patrick Gansterer <paroga@webkit.org> 7442 7443 Reviewed by Csaba Osztrogonác. 7444 7445 Add revlink to BuildBot status 7446 https://bugs.webkit.org/show_bug.cgi?id=50914 7447 7448 This adds a hyperlink to trac changeset on the revision numbers. 7449 7450 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 7451 74522010-12-13 Andras Becsi <abecsi@webkit.org> 7453 7454 Reviewed by Csaba Osztrogonác. 7455 7456 [Qt][WK2] Fix build if WebKitTools are not available 7457 https://bugs.webkit.org/show_bug.cgi?id=50242 7458 7459 * MiniBrowser/qt/MiniBrowser.pro: Correct the comment. 7460 * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs. 7461 * MiniBrowser/DerivedSources.pro: Added. 7462 74632010-12-13 Eric Seidel <eric@webkit.org> 7464 7465 Reviewed by Adam Barth. 7466 7467 EWS Queues should remove orpahned pyc files before starting 7468 https://bugs.webkit.org/show_bug.cgi?id=50904 7469 7470 A previous check added a platform.py which caused 7471 EWS bots on some platforms to hit an import exception. 7472 The platform.py file was removed in a subsequent commit, but 7473 the EWS bots in question stayed stuck. This change will 7474 fix those bots once restarted (and prevent this in the future). 7475 7476 I also went ahead and unified start-queue and start-commit-queue 7477 since they were nearly identical. I also added bot_id support 7478 to both force all EWSes to have bot ids as well as get rid of the one 7479 remaining reason why I had my own copies of these scripts. 7480 Hopefully this will be enough to get all the other bot admins 7481 (ahem, Adam, ahem) to move to using these checked in copies as well. 7482 7483 * EWSTools/start-commit-queue.sh: Removed. 7484 * EWSTools/start-queue.sh: 7485 74862010-10-28 MORITA Hajime <morrita@google.com> 7487 7488 Reviewed by Ojan Vafai. 7489 7490 spellcheck does not check pasted text 7491 https://bugs.webkit.org/show_bug.cgi?id=40092 7492 7493 Added LayoutTestController::setAsynchronousSpellCheckingEnabled() 7494 to control the setting. 7495 7496 * DumpRenderTree/LayoutTestController.cpp: 7497 (setAsynchronousSpellCheckingEnabledCallback): 7498 (LayoutTestController::staticFunctions): 7499 * DumpRenderTree/LayoutTestController.h: 7500 * DumpRenderTree/chromium/LayoutTestController.h: 7501 * DumpRenderTree/chromium/LayoutTestController.cpp: 7502 (LayoutTestController::LayoutTestController): 7503 (LayoutTestController::setAsynchronousSpellCheckingEnabled): 7504 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 7505 (LayoutTestController::setAsynchronousSpellCheckingEnabled): 7506 * DumpRenderTree/mac/DumpRenderTree.mm: 7507 (resetDefaultsToConsistentValues): 7508 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 7509 (LayoutTestController::setAsynchronousSpellCheckingEnabled): 7510 * DumpRenderTree/qt/LayoutTestControllerQt.h: 7511 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 7512 (LayoutTestController::setAsynchronousSpellCheckingEnabled): 7513 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 7514 (LayoutTestController::setAsynchronousSpellCheckingEnabled): 7515 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 7516 (LayoutTestController::setAsynchronousSpellCheckingEnabled): 7517 75182010-12-12 Sam Weinig <sam@webkit.org> 7519 7520 Reviewed by Anders Carlsson. 7521 7522 Fix failing API test. It turns out that a pop-state event 7523 is sent before every fragment navigation, so we have to test 7524 for it in addition in PageLoadDidChangeLocationWithinPageForFrame. 7525 7526 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: 7527 (TestWebKitAPI::didSameDocumentNavigationForFrame): 7528 75292010-12-12 Alejandro G. Castro <alex@igalia.com> 7530 7531 Reviewed by Eric Seidel. 7532 7533 [GTK] Add new-run-webkit-tests support to gtk 7534 https://bugs.webkit.org/show_bug.cgi?id=50681 7535 7536 Adding the basic support to run the new-run-webkit-tests. 7537 7538 * Scripts/webkitpy/layout_tests/port/gtk.py: 7539 75402010-10-11 Diego Gonzalez <diegohcg@webkit.org> 7541 7542 Reviewed by Kenneth Rohde Christiansen. 7543 7544 [Qt] Mock DeviceOrientation client for DRT 7545 https://bugs.webkit.org/show_bug.cgi?id=47490 7546 7547 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 7548 (WebCore::DumpRenderTree::DumpRenderTree): 7549 (WebCore::DumpRenderTree::~DumpRenderTree): 7550 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 7551 (LayoutTestController::setMockDeviceOrientation): 7552 75532010-12-11 Philippe Normand <pnormand@igalia.com> 7554 7555 Reviewed by Gustavo Noronha Silva. 7556 7557 [GTK] launcher: disable the Mozilla-style fullscreen API 7558 https://bugs.webkit.org/show_bug.cgi?id=50874 7559 7560 Disabling the fullscreen API until its implementation for GTK is 7561 mature enough. The webview setting for it is already FALSE by 7562 default. 7563 7564 * GtkLauncher/main.c: 7565 (createWindow): 7566 75672010-12-10 Eric Seidel <eric@webkit.org> 7568 7569 Reviewed by Adam Barth. 7570 7571 commit-queue flaky test messages show cryptic version information for mac os x 7572 https://bugs.webkit.org/show_bug.cgi?id=50864 7573 7574 Turns out platform.platform() returns kernel version information 7575 which isn't helpful, and just plain confusing on Mac 7576 (OS X 10.6.5 uses Darwin Kernel 10.5.0). 7577 7578 So I've updated PlatformInfo.display_name() to special case 7579 mac. I also found a bad use of sys.platform in the process 7580 and fixed that. (sys.platform always returns 'darwin' on mac). 7581 7582 * Scripts/webkitpy/common/system/platforminfo.py: 7583 * Scripts/webkitpy/common/system/user.py: 7584 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 7585 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: 7586 * Scripts/webkitpy/tool/commands/queues_unittest.py: 7587 75882010-12-10 Eric Seidel <eric@webkit.org> 7589 7590 Unreviewed. 7591 7592 Exception seen while reporting flaky test with commit-queue. 7593 Just a missing include. 7594 7595 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 7596 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: 7597 75982010-12-10 Kinuko Yasuda <kinuko@chromium.org> 7599 7600 Reviewed by Eric Seidel. 7601 7602 [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility 7603 https://bugs.webkit.org/show_bug.cgi?id=50796 7604 7605 Also updating the test code to use JSONResultsGeneratorBase and 7606 to improve test coverage for incremental cases. 7607 7608 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 7609 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: 7610 76112010-12-10 Joseph Pecoraro <joepeck@webkit.org> 7612 7613 Reviewed by Darin Adler. 7614 7615 prepare-ChangeLog --help doesn't mention --bug shorthand -b 7616 https://bugs.webkit.org/show_bug.cgi?id=50835 7617 7618 * Scripts/prepare-ChangeLog: be more explicit about -b and match file style. 7619 76202010-12-10 Eric Seidel <eric@webkit.org> 7621 7622 Reviewed by Adam Barth. 7623 7624 Bugs created by the commit-queue should all block on a master bug 7625 https://bugs.webkit.org/show_bug.cgi?id=50857 7626 7627 This makes all bugs created by the commit-queue block on: 7628 https://bugs.webkit.org/show_bug.cgi?id=50856 7629 7630 In the process of testing this, I found that the existing 7631 create_bug code was wrong. I also found that existing 7632 unit tests for create-rollout used invalid values 7633 for options.blocks. I fixed both issues and tested. 7634 7635 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 7636 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: 7637 * Scripts/webkitpy/tool/commands/commandtest.py: 7638 * Scripts/webkitpy/tool/commands/download_unittest.py: 7639 * Scripts/webkitpy/tool/commands/upload_unittest.py: 7640 * Scripts/webkitpy/tool/mocktool.py: 7641 * Scripts/webkitpy/tool/steps/options.py: 7642 76432010-12-10 Eric Seidel <eric@webkit.org> 7644 7645 Reviewed by Adam Barth. 7646 7647 Teach webkitpy how to follow duplicate chains when posting comments on flake bugs 7648 https://bugs.webkit.org/show_bug.cgi?id=50853 7649 7650 I also discovered when doing this that the code was posting 7651 the comment on the wrong bug, but that's fixed here too. 7652 7653 * Scripts/webkitpy/common/net/bugzilla/bug.py: 7654 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 7655 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 7656 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: 7657 * Scripts/webkitpy/tool/commands/queues_unittest.py: 7658 * Scripts/webkitpy/tool/mocktool.py: 7659 76602010-12-10 Anders Carlsson <andersca@apple.com> 7661 7662 Reviewed by John Sullivan. 7663 7664 Make WKContextGetStatistics gather global statistics 7665 https://bugs.webkit.org/show_bug.cgi?id=50850 7666 7667 Remove the code that gets the statistics and fills in the per context 7668 statistics information for now. 7669 7670 * MiniBrowser/mac/BrowserStatisticsWindowController.m: 7671 (-[BrowserStatisticsWindowController refreshStatistics:]): 7672 76732010-12-10 Eric Seidel <eric@webkit.org> 7674 7675 Unreviewed. 7676 7677 commit-queue should report port/platform information when commenting on flaky test bugs 7678 https://bugs.webkit.org/show_bug.cgi?id=50839 7679 7680 Renamed platform.py to platforminfo.py. This broke import platform in executive.py 7681 which was only used by new run webkit tests (and clearly not unit tested). 7682 7683 * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py. 7684 * Scripts/webkitpy/tool/main.py: 7685 * Scripts/webkitpy/tool/mocktool.py: 7686 76872010-12-10 Eric Seidel <eric@webkit.org> 7688 7689 Reviewed by Tony Chang. 7690 7691 commit-queue should report port/platform information when commenting on flaky test bugs 7692 https://bugs.webkit.org/show_bug.cgi?id=50839 7693 7694 This was a suggestion from Tony Chang this morning. 7695 I added a platform.py class so I could easily mock the platform call, 7696 but that may not be the final solution for this mocking. 7697 We'll try it and see. 7698 7699 * Scripts/webkitpy/common/system/platform.py: Added. 7700 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 7701 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: 7702 * Scripts/webkitpy/tool/commands/queues_unittest.py: 7703 * Scripts/webkitpy/tool/main.py: 7704 * Scripts/webkitpy/tool/mocktool.py: 7705 77062010-12-10 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com> 7707 7708 Reviewed by Joseph Pecoraro. 7709 7710 Bug 43455 - [Qt]: Implement Application Cache Quotas 7711 https://bugs.webkit.org/show_bug.cgi?id=43455 7712 7713 Introduce functions to allow new appcache layout test origin-quota.html 7714 to work correctly under Qt. 7715 7716 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 7717 (WebCore::DumpRenderTree::DumpRenderTree): 7718 (WebCore::DumpRenderTree::dumpApplicationCacheQuota): 7719 * DumpRenderTree/qt/DumpRenderTreeQt.h: 7720 7721 Introduce functions to allow new appcache layout test origin-quota.html 7722 to be successful under qt. Changes required because LayoutTestControllerQt 7723 does not inherit from LayoutController. 7724 7725 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 7726 (LayoutTestController::reset): 7727 (LayoutTestController::clearAllApplicationCaches): 7728 (LayoutTestController::setApplicationCacheOriginQuota): 7729 * DumpRenderTree/qt/LayoutTestControllerQt.h: 7730 (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks): 7731 (LayoutTestController::dumpApplicationCacheDelegateCallbacks): 7732 77332010-12-10 Eric Seidel <eric@webkit.org> 7734 7735 Reviewed by Adam Barth. 7736 7737 Move buildbot.py into its own module so we can split it out into one-file-per-class 7738 https://bugs.webkit.org/show_bug.cgi?id=50806 7739 7740 We're adding more buildbot logic these days, so it makes sense 7741 to give buildbot its own module. 7742 7743 * Scripts/webkitpy/common/net/buildbot/__init__.py: Added. 7744 * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py. 7745 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py. 7746 * Scripts/webkitpy/common/net/failuremap.py: 7747 * Scripts/webkitpy/common/net/regressionwindow.py: 7748 * Scripts/webkitpy/tool/commands/rebaseline.py: 7749 77502010-12-10 Tony Chang <tony@chromium.org> 7751 7752 Reviewed by Eric Seidel. 7753 7754 Use FileSystem::remove when cleaning up http lock files 7755 https://bugs.webkit.org/show_bug.cgi?id=50830 7756 7757 * Scripts/webkitpy/layout_tests/port/http_lock.py: 7758 77592010-12-10 Joone Hur <joone@kldp.org> 7760 7761 Reviewed by Martin Robinson. 7762 7763 [GTK] DRT needs layoutTestController.setCacheModel 7764 https://bugs.webkit.org/show_bug.cgi?id=50705 7765 7766 webkit_set_cache_mode() is called to set the cache model. 7767 7768 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 7769 (LayoutTestController::setCacheModel): Set the cache model. 7770 77712010-12-10 Tony Chang <tony@chromium.org> 7772 7773 Reviewed by Ojan Vafai. 7774 7775 [chromium] remove --use-drt and add --use-test-shell 7776 https://bugs.webkit.org/show_bug.cgi?id=50701 7777 7778 * Scripts/webkitpy/common/config/ports.py: 7779 * Scripts/webkitpy/common/config/ports_unittest.py: 7780 * Scripts/webkitpy/layout_tests/port/chromium.py: 7781 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 7782 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 7783 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 7784 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 7785 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 7786 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 7787 * Scripts/webkitpy/layout_tests/port/webkit.py: 7788 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 7789 * Scripts/webkitpy/style/checkers/test_expectations.py: 7790 * Scripts/webkitpy/tool/commands/queries.py: 7791 77922010-12-10 John Knottenbelt <jknotten@chromium.org> 7793 7794 Reviewed by Steve Block. 7795 7796 [Chromium] Implement mocks for client-based geolocation 7797 https://bugs.webkit.org/show_bug.cgi?id=46895 7798 7799 * DumpRenderTree/chromium/LayoutTestController.cpp: 7800 (LayoutTestController::setGeolocationPermission): 7801 (LayoutTestController::setMockGeolocationPosition): 7802 (LayoutTestController::setMockGeolocationError): 7803 * DumpRenderTree/chromium/LayoutTestController.h: 7804 * DumpRenderTree/chromium/WebViewHost.cpp: 7805 (WebViewHost::geolocationClient): 7806 (WebViewHost::geolocationClientMock): 7807 (WebViewHost::reset): 7808 * DumpRenderTree/chromium/WebViewHost.h: 7809 78102010-12-10 Alejandro G. Castro <alex@igalia.com> 7811 7812 Reviewed by Martin Robinson. 7813 7814 [GTK] Add hasSpellingMarker support to the DRT 7815 https://bugs.webkit.org/show_bug.cgi?id=50739 7816 7817 Implemented the hasSpellingMarker to support spelling tests. 7818 7819 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 7820 (LayoutTestController::hasSpellingMarker): 7821 78222010-12-10 Eric Seidel <eric@webkit.org> 7823 7824 Reviewed by Ojan Vafai. 7825 7826 webkit-patch: not possible to use build-and-test with local commits 7827 https://bugs.webkit.org/show_bug.cgi?id=33378 7828 7829 Make --no-clean not even check if we have local commits. 7830 It's unclear to me why the code was originally written this way. 7831 I was unable to dig up a reason from svn history. 7832 7833 * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py: 7834 * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py. 7835 78362010-12-10 Mario Sanchez Prada <msanchez@igalia.com> 7837 7838 Reviewed by Martin Robinson. 7839 7840 [GTK] AX: implement isEnabled in DRT 7841 https://bugs.webkit.org/show_bug.cgi?id=50814 7842 7843 Implement AccessibilityUIElement::isEnabled() for GTK. 7844 7845 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 7846 (checkElementState): New function to refactor common code. 7847 (AccessibilityUIElement::isEnabled): Implement this by checking 7848 the current state of the AtkObject. 7849 (AccessibilityUIElement::isSelected): Use the new 7850 checkElementState function. 7851 78522010-12-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 7853 7854 Reviewed by Kenneth Rohde Christiansen. 7855 7856 [Qt][WK2] Add the QWKContext API class to wrap the WebContext. 7857 https://bugs.webkit.org/show_bug.cgi?id=50750 7858 7859 * MiniBrowser/qt/BrowserView.cpp: 7860 (BrowserView::BrowserView): 7861 * MiniBrowser/qt/BrowserView.h: 7862 * WebKitTestRunner/qt/PlatformWebViewQt.cpp: 7863 (WTR::WebView::WebView): 7864 78652010-12-10 Joone Hur <joone@kldp.org> 7866 7867 Reviewed by Xan Lopez. 7868 7869 [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet 7870 https://bugs.webkit.org/show_bug.cgi?id=50808 7871 7872 Unskipping the following test cases: 7873 userscripts/mixed-case-stylesheet.html 7874 userscripts/simple-stylesheet.html 7875 userscripts/user-style-all-frames.html 7876 7877 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 7878 (LayoutTestController::addUserStyleSheet): 7879 78802010-12-10 Joone Hur <joone@kldp.org> 7881 7882 Reviewed by Eric Seidel. 7883 7884 [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet 7885 https://bugs.webkit.org/show_bug.cgi?id=50783 7886 7887 This patch allows to unskip the following test cases: 7888 printing/page-rule-selection.html 7889 printing/page-format-data.html 7890 7891 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 7892 (LayoutTestController::pageProperty): Added. 7893 (LayoutTestController::isPageBoxVisible): Ditto. 7894 (LayoutTestController::pageSizeAndMarginsInPixels): Ditto. 7895 (LayoutTestController::addUserStyleSheet): Ditto. 7896 78972010-12-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 7898 7899 Reviewed by Kenneth Rohde Christiansen. 7900 7901 [Qt] Make QtTestBrowser spawn QNAM in a secondary thread. 7902 7903 A menu allows to switch QNAM back to the same thread. 7904 7905 * QtTestBrowser/launcherwindow.cpp: 7906 (LauncherWindow::initializeView): 7907 (LauncherWindow::createChrome): 7908 (LauncherWindow::toggleThreadedQnam): 7909 * QtTestBrowser/launcherwindow.h: 7910 (WindowOptions::WindowOptions): 7911 * QtTestBrowser/webpage.cpp: 7912 (WebPage::WebPage): 7913 (WebPage::setQnamThreaded): 7914 * QtTestBrowser/webpage.h: 7915 (QnamThread::QnamThread): 7916 (QnamThread::~QnamThread): 7917 (QnamThread::networkAccessManager): 7918 (QnamThread::run): 7919 79202010-12-10 Martin Robinson <mrobinson@igalia.com> 7921 7922 Reviewed by Xan Lopez. 7923 7924 [Gtk] style="font-family: courier" makes text disappear 7925 https://bugs.webkit.org/show_bug.cgi?id=47452 7926 7927 Add a test that verifies that fonts without valid charmaps are 7928 never selected. 7929 7930 * DumpRenderTree/gtk/DumpRenderTree.cpp: 7931 (initializeFonts): Initialize DRT with our font (derived from Ahem) 7932 that has no valid charmap. 7933 * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added. 7934 * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users' 7935 settings which may disable selection of bitmap fonts. 7936 79372010-12-10 Eric Seidel <eric@webkit.org> 7938 7939 Unreviewed. 7940 7941 The commit-queue should file bugs about flaky tests it encounters 7942 https://bugs.webkit.org/show_bug.cgi?id=50803 7943 7944 create_bug_for_flaky_test was insufficiently tested, thus buggy. 7945 Now it's tested. 7946 7947 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 7948 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: 7949 79502010-12-10 Eric Seidel <eric@webkit.org> 7951 7952 Unreviewed. Somehow this last-minute edit didn't quite get committed. 7953 7954 The commit-queue should file bugs about flaky tests it encounters 7955 https://bugs.webkit.org/show_bug.cgi?id=50803 7956 7957 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 7958 79592010-12-09 Eric Seidel <eric@webkit.org> 7960 7961 Reviewed by Adam Barth. 7962 7963 The commit-queue should file bugs about flaky tests it encounters 7964 https://bugs.webkit.org/show_bug.cgi?id=50803 7965 7966 This change got a bit big. I also added a new config.urls file 7967 because I needed to share the view_source_url code with committervalidator.py. 7968 7969 This adds a new class FlakyTestReporter which holds all the logic about 7970 reporting flaky tests to bugzilla. 7971 7972 Right now this code knows how to look up bugs for flaky tests. 7973 If it can't find a bug filed from the commit-queue, it will open a new 7974 one, ccing the relevant people and adding information about the failure. 7975 7976 It is not yet smart enough to chase down duplicate chains, or to include 7977 the actual failure diff. But those can be added in later iterations. 7978 7979 * Scripts/webkitpy/common/checkout/api.py: 7980 * Scripts/webkitpy/common/checkout/changelog.py: 7981 * Scripts/webkitpy/common/checkout/commitinfo.py: 7982 * Scripts/webkitpy/common/config/committervalidator.py: 7983 * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py. 7984 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 7985 * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added. 7986 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py. 7987 * Scripts/webkitpy/tool/bot/irc_command.py: 7988 * Scripts/webkitpy/tool/bot/sheriff.py: 7989 * Scripts/webkitpy/tool/commands/download.py: 7990 * Scripts/webkitpy/tool/commands/queues.py: 7991 * Scripts/webkitpy/tool/commands/queues_unittest.py: 7992 * Scripts/webkitpy/tool/comments.py: 7993 * Scripts/webkitpy/tool/mocktool.py: 7994 * Scripts/webkitpy/tool/steps/commit.py: 7995 79962010-12-09 Eric Seidel <eric@webkit.org> 7997 7998 Reviewed by Adam Barth. 7999 8000 Teach webkit-patch how to search bugzilla 8001 https://bugs.webkit.org/show_bug.cgi?id=50500 8002 8003 This is a step towards teaching webkitpy how to file 8004 new bugs for flaky tests and update them when new flakes occur. 8005 8006 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 8007 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: 8008 * Scripts/webkitpy/tool/commands/__init__.py: 8009 * Scripts/webkitpy/tool/commands/bugsearch.py: Added. 8010 80112010-12-09 Adam Barth <abarth@webkit.org> 8012 8013 Reviewed by Ojan Vafai. 8014 8015 commit-queue errors out due to local commits 8016 https://bugs.webkit.org/show_bug.cgi?id=50766 8017 8018 We seem to be tripping over having local commits in the working copy a 8019 lot recently. I don't quite fully understand what the issue is, but 8020 this patch attempts to solve the problem by adding an explicit clean 8021 step before processing a patch. Previously, we did the cleaning as 8022 part of the apply-attachment step, so this might not actually fix the 8023 problem. 8024 8025 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 8026 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 8027 * Scripts/webkitpy/tool/commands/queues_unittest.py: 8028 80292010-12-09 Dirk Pranke <dpranke@chromium.org> 8030 8031 Reviewed by Ojan Vafai. 8032 8033 Make new-run-webkit-tests --lint-test-files log slightly better 8034 messages and return -1 if lint fails. Remove the 8035 'suppress_errors' keyword param to the TestExpectationsFile 8036 class, and clean up logging and exception raising for error 8037 handling. Also add more unit tests and clean up the unit test code a bit. 8038 8039 https://bugs.webkit.org/show_bug.cgi?id=50205 8040 8041 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 8042 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 8043 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py 8044 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py 8045 * Scripts/webkitpy/layout_tests/port/chromium.py: 8046 * Scripts/webkitpy/style/checkers/test_expectations.py: 8047 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: 8048 80492010-12-09 Tony Chang <tony@chromium.org> 8050 8051 Unreviewed, fix for windows code. We were catching the wrong 8052 exception in Windows. 8053 8054 * Scripts/webkitpy/common/system/filesystem.py: 8055 80562010-12-09 Antonio Gomes <agomes@rim.com> 8057 8058 Reviewed by Martin Robinson. 8059 8060 [Gtk] Populate DumpRenderTreeSupportGtk (part IV) 8061 https://bugs.webkit.org/show_bug.cgi?id=48429 8062 8063 Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now. 8064 8065 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 8066 (LayoutTestController::workerThreadCount): 8067 80682010-12-06 Philippe Normand <pnormand@igalia.com> 8069 8070 Reviewed by Martin Robinson. 8071 8072 [GTK] Support the Mozilla-style Fullscreen Javascript API 8073 https://bugs.webkit.org/show_bug.cgi?id=50572 8074 8075 Enable the Javascript Fullscreen support in the GtkLauncher. Also 8076 make DRT update the Chrome when the WebView settings have been 8077 reset to consistent values. 8078 8079 * DumpRenderTree/gtk/DumpRenderTree.cpp: 8080 (resetDefaultsToConsistentValues): 8081 * GtkLauncher/main.c: 8082 (create_window): 8083 * Scripts/build-webkit: 8084 80852010-12-09 Koan-Sin Tan <koansin.tan@gmail.com> 8086 8087 Reviewed by Tor Arne Vestbø 8088 8089 [Qt] run-launcher doesn't start the browser on Mac OS X 10.6 8090 https://bugs.webkit.org/show_bug.cgi?id=50742 8091 8092 check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib 8093 8094 * Scripts/webkitdirs.pm: 8095 80962010-12-09 Joone Hur <joone@kldp.org> 8097 8098 Reviewed by Martin Robinson. 8099 8100 [GTK] Support for viewport meta tag 8101 https://bugs.webkit.org/show_bug.cgi?id=45443 8102 8103 Add support for testing the viewport properties for WebKitGtk. 8104 8105 * DumpRenderTree/LayoutTestController.cpp: 8106 (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport. 8107 (LayoutTestController::staticFunctions): 8108 * DumpRenderTree/LayoutTestController.h: 8109 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 8110 (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties. 8111 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 8112 (LayoutTestController::dumpConfigurationForViewport): Ditto. 8113 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 8114 (LayoutTestController::dumpConfigurationForViewport): Ditto. 8115 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 8116 (LayoutTestController::dumpConfigurationForViewport): Ditto. 8117 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 8118 (LayoutTestController::dumpConfigurationForViewport): Ditto. 8119 81202010-12-08 William Siegrist <wsiegrist@apple.com> 8121 8122 Reviewed by Eric Seidel. 8123 8124 Migrate buildbot.py from xmlrpc to json. 8125 https://bugs.webkit.org/show_bug.cgi?id=50647 8126 8127 * Scripts/webkitpy/common/net/buildbot.py: 8128 81292010-12-08 Tony Chang <tony@chromium.org> 8130 8131 Reviewed by Eric Seidel. 8132 8133 make starting the websocket server more reliable on windows 8134 https://bugs.webkit.org/show_bug.cgi?id=50712 8135 8136 * Scripts/webkitpy/common/system/filesystem.py: 8137 (remove): Substitute method for os.remove to retry on error on Windows 8138 * Scripts/webkitpy/common/system/filesystem_unittest.py: 8139 * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove 8140 81412010-12-08 Jessie Berlin <jberlin@apple.com> 8142 8143 Reviewed by Adam Roben. 8144 8145 WebKit2: Implement WebChromeClient::exceededDatabaseQuota 8146 https://bugs.webkit.org/show_bug.cgi?id=50656 8147 8148 * MiniBrowser/mac/BrowserWindowController.m: 8149 (-[BrowserWindowController awakeFromNib]): 8150 Indicate that exceededDatabaseQuota is not implemented. 8151 * MiniBrowser/win/BrowserView.cpp: 8152 (BrowserView::create): 8153 Ditto. 8154 * WebKitTestRunner/TestController.cpp: 8155 (WTR::createOtherPage): 8156 Ditto. 8157 (WTR::TestController::initialize): 8158 Ditto. 8159 81602010-12-08 Antonio Gomes <agomes@rim.com> 8161 8162 Reviewed by Martin Robinson. 8163 8164 [Gtk] Populate DumpRenderTreeSupportGtk (part III) 8165 https://bugs.webkit.org/show_bug.cgi?id=48429 8166 8167 Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h: 8168 * webkit_gc_collect_javascript_objects; 8169 * webkit_gc_collect_javascript_objects_on_alternate_thread; 8170 * webkit_gc_count_javascript_objects; 8171 * webkit_web_frame_layout. 8172 8173 These were all only used by GTK+ DRT. 8174 8175 * DumpRenderTree/gtk/EventSender.cpp: 8176 (dispatchEvent): 8177 * DumpRenderTree/gtk/GCControllerGtk.cpp: 8178 (GCController::collect): 8179 (GCController::collectOnAlternateThread): 8180 (GCController::getJSObjectCount): 8181 81822010-12-07 Tony Chang <tony@chromium.org> 8183 8184 Reviewed by Ojan Vafai. 8185 8186 [chromium] force NRWT to use DRT 8187 https://bugs.webkit.org/show_bug.cgi?id=50359 8188 8189 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 8190 81912010-12-06 Sam Weinig <sam@webkit.org> 8192 8193 Reviewed by Anders Carlsson. 8194 8195 Generalize didChangeLocationWithinPageForFrame for all same document navigations 8196 https://bugs.webkit.org/show_bug.cgi?id=50584 8197 8198 * MiniBrowser/mac/BrowserWindowController.m: 8199 (didSameDocumentNavigationForFrame): 8200 (-[BrowserWindowController awakeFromNib]): 8201 (-[BrowserWindowController didSameDocumentNavigationForFrame:]): 8202 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: 8203 (TestWebKitAPI::didSameDocumentNavigationForFrame): 8204 (TestWebKitAPI::TEST): 8205 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 8206 (WTR::InjectedBundlePage::InjectedBundlePage): 8207 (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): 8208 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 8209 * WebKitTestRunner/TestController.cpp: 8210 (WTR::TestController::initialize): 8211 82122010-12-06 Kinuko Yasuda <kinuko@chromium.org> 8213 8214 Reviewed by Ojan Vafai. 8215 8216 Make TestResultsServer return 404 for non-existing results files. 8217 https://bugs.webkit.org/show_bug.cgi?id=50581 8218 8219 * TestResultServer/handlers/testfilehandler.py: 8220 82212010-12-06 Tony Chang <tony@chromium.org> 8222 8223 Reviewed by Ojan Vafai. 8224 8225 [chromium] fix an assert hit in DRT 8226 https://bugs.webkit.org/show_bug.cgi?id=50575 8227 8228 This class uses WTF's RefPtr, but expects chrome's base::RefPtr 8229 semantics. 8230 8231 Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired 8232 (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void 8233 WTF::RefCountedBase::ref()). 8234 8235 * DumpRenderTree/chromium/TestWebWorker.h: 8236 (TestWebWorker::TestWebWorker): 8237 82382010-12-02 Ojan Vafai <ojan@chromium.org> 8239 8240 Reviewed by Eric Seidel. 8241 8242 make webkit-patch command work when the git branch is not synced to the remote svn branch 8243 https://bugs.webkit.org/show_bug.cgi?id=50424 8244 8245 * Scripts/webkitpy/common/checkout/scm.py: 8246 * Scripts/webkitpy/common/checkout/scm_unittest.py: 8247 82482010-12-06 Patrick Gansterer <paroga@webkit.org> 8249 8250 Reviewed by Andreas Kling. 8251 8252 [WINCE] Add build system 8253 https://bugs.webkit.org/show_bug.cgi?id=50522 8254 8255 * CMakeListsWinCE.txt: Added. 8256 82572010-12-03 Mihai Parparita <mihaip@chromium.org> 8258 8259 Reviewed by Tony Chang. 8260 8261 Allow the Chromium port to have Leopard-specific baselines 8262 https://bugs.webkit.org/show_bug.cgi?id=50506 8263 8264 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 8265 82662010-12-03 Tony Chang <tony@chromium.org> 8267 8268 Reviewed by Kent Tamura. 8269 8270 [chromium] fix 2 bugs with inspector tests in DRT 8271 https://bugs.webkit.org/show_bug.cgi?id=50492 8272 8273 Tasks can outlive the tasklist (even when canceled) so this was 8274 causing a crash when ~WebTask() ran. Avoid this by unregistering 8275 when a task is canceled. 8276 8277 Also fix an assert when closing devtool windows by copying some 8278 logic from test_shell. 8279 8280 * DumpRenderTree/chromium/Task.cpp: 8281 (WebTask::~WebTask): 8282 (TaskList::revokeAll): 8283 * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from 8284 the tasklist (since the task can outlive the tasklist). 8285 * DumpRenderTree/chromium/TestShell.h: 8286 (TestShell::devToolsWebView): 8287 * DumpRenderTree/chromium/WebViewHost.cpp: 8288 (WebViewHost::~WebViewHost): Don't load about:blank when closing 8289 a window if the window has devtools loaded. This avoids an 8290 ASSERT and matches test_shell. 8291 82922010-12-06 Alejandro G. Castro <alex@igalia.com> 8293 8294 Reviewed by Martin Robinson. 8295 8296 [GTK] Fix GtkLauncher.c style, use webkit style 8297 https://bugs.webkit.org/show_bug.cgi?id=50542 8298 8299 * GtkLauncher/main.c: 8300 (activateUriEntryCb): 8301 (updateTitle): 8302 (linkHoverCb): 8303 (notifyTitleCb): 8304 (notifyLoadStatusCb): 8305 (notifyProgressCb): 8306 (destroyCb): 8307 (goBackCb): 8308 (goForwardCb): 8309 (create_webViewCb): 8310 (webViewReadyCb): 8311 (closeWebViewCb): 8312 (createBrowser): 8313 (createStatusbar): 8314 (createToolbar): 8315 (createWindow): 8316 (main): 8317 83182010-12-04 Antonio Gomes <agomes@rim.com> 8319 8320 Reviewed by Martin Robinson. 8321 8322 [Gtk] Populate DumpRenderTreeSupportGtk (Part II) 8323 https://bugs.webkit.org/show_bug.cgi?id=48429 8324 8325 Moved more private method declared with WEBKIT_API to 8326 DumpRenderTreeSupportGtk, since they were only being used by DRT. 8327 8328 * DumpRenderTree/gtk/DumpRenderTree.cpp: 8329 (resetDefaultsToConsistentValues): 8330 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 8331 (LayoutTestController::addOriginAccessWhitelistEntry): 8332 (LayoutTestController::execCommand): 8333 (LayoutTestController::isCommandEnabled): 8334 83352010-12-04 Antonio Gomes <agomes@rim.com> 8336 8337 Reviewed by Andreas Kling. 8338 8339 Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp 8340 8341 Method was removed by http://trac.webkit.org/changeset/71604 8342 8343 * DumpRenderTree/gtk/DumpRenderTree.cpp: 8344 83452010-12-05 Alejandro G. Castro <alex@igalia.com> 8346 8347 Reviewed by Xan Lopez. 8348 8349 [GTK] Fix compilation warnings reported by clang 8350 https://bugs.webkit.org/show_bug.cgi?id=50252 8351 8352 * GtkLauncher/main.c: 8353 (create_window): The create_statusbar function does not have 8354 parameters. 8355 83562010-12-05 Robert Hogan <robert@webkit.org> 8357 8358 Reviewed by Andreas Kling. 8359 8360 [Qt] Zero-sized font does not yet work 8361 8362 Fix fast/text/font-size-zero.html 8363 8364 Copy other ports by setting minimumFontSize to 0 for DRT runs. 8365 8366 https://bugs.webkit.org/show_bug.cgi?id=49759 8367 8368 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 8369 (WebCore::WebPage::WebPage): 8370 83712010-12-04 Sam Weinig <sam@webkit.org> 8372 8373 Reviewed by Jon Honeycutt. 8374 8375 WebKit2: Need client functions to notify app when the url changes due to a fragment navigation 8376 https://bugs.webkit.org/show_bug.cgi?id=50511 8377 8378 Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle 8379 signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp) 8380 8381 * MiniBrowser/mac/BrowserWindowController.m: 8382 (didChangeLocationWithinPageForFrame): 8383 (-[BrowserWindowController awakeFromNib]): 8384 (-[BrowserWindowController didChangeLocationWithinPageForFrame:]): 8385 * TestWebKitAPI/PlatformUtilities.cpp: 8386 (TestWebKitAPI::Util::toWK): 8387 * TestWebKitAPI/PlatformUtilities.h: 8388 (TestWebKitAPI::Util::adoptWK): 8389 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 8390 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added. 8391 (TestWebKitAPI::nullJavaScriptCallback): 8392 (TestWebKitAPI::didFinishLoadForFrame): 8393 (TestWebKitAPI::didChangeLocationWithinPageForFrame): 8394 (TestWebKitAPI::TEST): 8395 * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added. 8396 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 8397 * TestWebKitAPI/win/copy-resources.cmd: 8398 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 8399 (WTR::InjectedBundlePage::InjectedBundlePage): 8400 (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame): 8401 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 8402 * WebKitTestRunner/TestController.cpp: 8403 (WTR::TestController::initialize): 8404 84052010-11-08 Antonio Gomes <agomes@rim.com> 8406 8407 Reviewed by Martin Robinson. 8408 8409 [Gtk] Populate DumpRenderTreeSupportGtk 8410 https://bugs.webkit.org/show_bug.cgi?id=48429 8411 8412 Made the previous calls to webkit_web_frame* functions defined as private 8413 APIs in webkitprivate.h go through DRTSupportGtk. 8414 8415 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 8416 (AccessibilityController::focusedElement): 8417 * DumpRenderTree/gtk/DumpRenderTree.cpp: 8418 (dumpFramesAsText): 8419 (resetDefaultsToConsistentValues): 8420 (dump): 8421 (webViewDocumentLoadFinished): 8422 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 8423 (LayoutTestController::counterValueForElementById): 8424 (LayoutTestController::pageNumberForElementById): 8425 (LayoutTestController::numberOfPages): 8426 (LayoutTestController::pauseAnimationAtTimeOnElementWithId): 8427 (LayoutTestController::pauseTransitionAtTimeOnElementWithId): 8428 (LayoutTestController::sampleSVGAnimationForElementAtTime): 8429 (LayoutTestController::numberOfActiveAnimations): 8430 (LayoutTestController::suspendAnimations): 8431 (LayoutTestController::resumeAnimations): 8432 (LayoutTestController::markerTextForListItem): 8433 84342010-12-03 Mihai Parparita <mihaip@chromium.org> 8435 8436 Reviewed by Tony Chang. 8437 8438 Rebaseline server: use pretty text diff output 8439 https://bugs.webkit.org/show_bug.cgi?id=50484 8440 8441 Serve *-pretty-diff.html for text diff output. 8442 8443 * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: 8444 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: 8445 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: 8446 * Scripts/webkitpy/tool/commands/rebaselineserver.py: 8447 84482010-12-03 Sheriff Bot <webkit.review.bot@gmail.com> 8449 8450 Unreviewed, rolling out r73302. 8451 http://trac.webkit.org/changeset/73302 8452 https://bugs.webkit.org/show_bug.cgi?id=50499 8453 8454 Causes crashes in debug LayoutTests (Requested by xan_ on 8455 #webkit). 8456 8457 * DumpRenderTree/chromium/AccessibilityUIElement.cpp: 8458 (AccessibilityUIElement::AccessibilityUIElement): 8459 (AccessibilityUIElement::parentElementCallback): 8460 * DumpRenderTree/chromium/AccessibilityUIElement.h: 8461 * DumpRenderTree/chromium/CppBoundClass.cpp: 8462 * DumpRenderTree/chromium/CppBoundClass.h: 8463 84642010-12-03 Sam Weinig <sam@webkit.org> 8465 8466 Reviewed by Maciej Stachowiak. 8467 8468 Enable <a ping> for Mac/Windows/WebKit2 builds 8469 <rdar://problem/8504473> 8470 https://bugs.webkit.org/show_bug.cgi?id=50488 8471 8472 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: 8473 (TestWebKitAPI::TEST): Test that the default value of 8474 WKPreferencesGetHyperlinkAuditingEnabled is true. 8475 84762010-12-03 Chris Guillory <chris.guillory@google.com> 8477 8478 Reviewed by Chris Fleizach. 8479 8480 Include the FrameView widget of a RenderWidget in the accessibility tree. 8481 https://bugs.webkit.org/show_bug.cgi?id=49106 8482 8483 * DumpRenderTree/chromium/AccessibilityUIElement.cpp: 8484 (AccessibilityUIElement::AccessibilityUIElement): 8485 (AccessibilityUIElement::parentElementCallback): 8486 (AccessibilityUIElement::isEqualCallback): 8487 * DumpRenderTree/chromium/AccessibilityUIElement.h: 8488 * DumpRenderTree/chromium/CppBoundClass.cpp: 8489 (CppBoundClass::getFromCppVariant): 8490 * DumpRenderTree/chromium/CppBoundClass.h: 8491 84922010-12-03 Mihai Parparita <mihaip@chromium.org> 8493 8494 Reviewed by Tony Chang. 8495 8496 Rebaseline server: organize tests by state, add dry run mode 8497 https://bugs.webkit.org/show_bug.cgi?id=50473 8498 8499 Group tests in the menu by state, so that it's easier to see after 8500 processing the queue which failed. 8501 8502 Add support for the --dry-run flag so that it's easier to test changes 8503 such as this (stubs out filesystem and SCM operations). 8504 8505 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: 8506 * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: 8507 * Scripts/webkitpy/tool/commands/rebaselineserver.py: 8508 85092010-12-03 Brady Eidson <beidson@apple.com> 8510 8511 Reviewed by Anders Carlsson. 8512 8513 Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191 8514 WebKit2 Authentication Support 8515 8516 Keep these builds working: 8517 * MiniBrowser/mac/BrowserWindowController.m: 8518 (-[BrowserWindowController awakeFromNib]): 8519 8520 * WebKitTestRunner/TestController.cpp: 8521 (WTR::TestController::initialize): 8522 85232010-12-02 Mihai Parparita <mihaip@chromium.org> 8524 8525 Reviewed by Tony Chang. 8526 8527 Rebaseline server: move existing baselines 8528 https://bugs.webkit.org/show_bug.cgi?id=50421 8529 8530 Implement moving of existing baselines: move all files that are about 8531 to be overwriten by update baselines. 8532 8533 Also fix a typo in the UI JS. 8534 8535 * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: 8536 * Scripts/webkitpy/tool/commands/rebaselineserver.py: 8537 * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: 8538 85392010-12-03 Sheriff Bot <webkit.review.bot@gmail.com> 8540 8541 Unreviewed, rolling out r73211. 8542 http://trac.webkit.org/changeset/73211 8543 https://bugs.webkit.org/show_bug.cgi?id=50450 8544 8545 Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by 8546 yutak on #webkit). 8547 8548 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 8549 85502010-12-03 Sheriff Bot <webkit.review.bot@gmail.com> 8551 8552 Unreviewed, rolling out r73222. 8553 http://trac.webkit.org/changeset/73222 8554 https://bugs.webkit.org/show_bug.cgi?id=50449 8555 8556 r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot. 8557 (Requested by yutak on #webkit). 8558 8559 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 8560 * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: 8561 * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: 8562 * Scripts/webkitpy/layout_tests/port/base.py: 8563 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 8564 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 8565 85662010-12-03 Sheriff Bot <webkit.review.bot@gmail.com> 8567 8568 Unreviewed, rolling out r73228. 8569 http://trac.webkit.org/changeset/73228 8570 https://bugs.webkit.org/show_bug.cgi?id=50448 8571 8572 r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot. 8573 (Requested by yutak on #webkit). 8574 8575 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 8576 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 8577 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 8578 * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: 8579 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 8580 85812010-12-03 Sheriff Bot <webkit.review.bot@gmail.com> 8582 8583 Unreviewed, rolling out r73231. 8584 http://trac.webkit.org/changeset/73231 8585 https://bugs.webkit.org/show_bug.cgi?id=50443 8586 8587 r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot. 8588 (Requested by yutak on #webkit). 8589 8590 * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: 8591 * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: 8592 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 8593 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 8594 85952010-12-03 David Levin <levin@chromium.org> 8596 8597 Reviewed by Shinichiro Hamaji. 8598 8599 check-webkit-style: false positive reported for #if macro 8600 https://bugs.webkit.org/show_bug.cgi?id=48242 8601 8602 * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid 8603 all preprocessor commands. 8604 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test. 8605 86062010-12-02 Eric Seidel <eric@webkit.org> 8607 8608 Reviewed by Adam Barth. 8609 8610 Update the EWSTools scripts to use modern-style git repos 8611 https://bugs.webkit.org/show_bug.cgi?id=50402 8612 8613 * EWSTools/create-webkit-git: 8614 * EWSTools/start-commit-queue.sh: 8615 * EWSTools/start-queue.sh: 8616 86172010-12-02 Simon Fraser <simon.fraser@apple.com> 8618 8619 Fix Chromium Linux plugin tests by not logging 8620 unconditionally from the event handling code. 8621 8622 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 8623 (handleEventX11): 8624 86252010-12-02 Dirk Pranke <dpranke@chromium.org> 8626 8627 Reviewed by Tony Chang. 8628 8629 nrwt multiprocessing - move logic back into run_webkit_tests 8630 8631 This change moves a bunch of logic that I had put into 8632 message_broker back into run_webkit_tests, in a slightly 8633 different format. WorkerMessageBroker needed to become less aware of 8634 the logic the TestRunner class uses, and more generic. 8635 Eventually the MessageBroker will only do generic messaging and 8636 thread/process-pooling, and (almost) all of the 8637 run-webkit-tests-specific logic will be moved to 8638 run_webkit_tests.py and dump_render_tree_thread.py. 8639 8640 The biggest changes are that the Broker can now start a single 8641 worker, but the responsibility for starting all of them is pushed 8642 back to the TestRunner (Manager), and the logic for checking if 8643 the threads are done or wedged is moved back to TestRunner. We 8644 also remove WorkerMessageBroker.cleanup (not needed) and 8645 cancel_workers (they have to be cancelled individually). 8646 8647 The message_broker is now encapsulated inside 8648 TestRunner._run_tests(); it only needs to exist while actually 8649 running the tests. 8650 8651 Also, delete a bunch of tests in message_broker_unittest that no 8652 longer make much sense. 8653 8654 This patch depends on bug 50372. 8655 8656 https://bugs.webkit.org/show_bug.cgi?id=50374 8657 8658 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 8659 * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: 8660 * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: 8661 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 8662 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 8663 86642010-12-02 Hayato Ito <hayato@chromium.org> 8665 8666 Reviewed by Eric Seidel. 8667 8668 Refactor test_types's compare_output() method so that it takes a 8669 TestInput object. 8670 8671 compare_output() will need additional information included in a TestInput 8672 object to support reftests. This change is a pre-requirement of that. 8673 8674 https://bugs.webkit.org/show_bug.cgi?id=50362 8675 8676 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 8677 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 8678 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 8679 * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: 8680 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 8681 86822010-12-02 Simon Fraser <simon.fraser@apple.com> 8683 8684 Reviewed by Anders Carlsson. 8685 8686 Add the ability to run script on 'new' and 'paint' in the test plugin 8687 https://bugs.webkit.org/show_bug.cgi?id=50425 8688 8689 Add "onnew" and "onpaintevent" attributes to the test plugin, 8690 so that tests can run JS at these times. 8691 8692 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 8693 (pluginAllocate): 8694 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: 8695 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 8696 (NPP_New): 8697 (NPP_Destroy): 8698 (handleEventCarbon): 8699 (handleEventCocoa): 8700 (NPP_HandleEvent): 8701 87022010-12-02 Sam Weinig <sam@webkit.org> 8703 8704 Fix Qt build. 8705 8706 * WebKitTestRunner/qt/PlatformWebViewQt.cpp: 8707 (WTR::PlatformWebView::PlatformWebView): 8708 87092010-12-02 Sam Weinig <sam@webkit.org> 8710 8711 Reviewed by Anders Carlsson. 8712 8713 WebKit2 Preferences should be held off the PageGroup, not the Context 8714 https://bugs.webkit.org/show_bug.cgi?id=50414 8715 8716 Update for API changes. 8717 8718 * WebKitTestRunner/PlatformWebView.h: 8719 * WebKitTestRunner/TestController.cpp: 8720 (WTR::createOtherPage): 8721 (WTR::TestController::initialize): 8722 (WTR::TestController::resetStateToConsistentValues): 8723 * WebKitTestRunner/TestController.h: 8724 * WebKitTestRunner/mac/PlatformWebViewMac.mm: 8725 (WTR::PlatformWebView::PlatformWebView): 8726 * WebKitTestRunner/win/PlatformWebViewWin.cpp: 8727 (WTR::PlatformWebView::PlatformWebView): 8728 87292010-12-02 Dirk Pranke <dpranke@chromium.org> 8730 8731 Reviewed by Tony Chang. 8732 8733 new-run-webkit-tests: minor cleanup for multiprocessing work 8734 8735 This change: 8736 * moves worker naming into TestShellThread, eliminating a 8737 parameter to the constructor and putting the responsibility in 8738 the correct place. 8739 * eliminates the _WorkerState() class in message_broker, because 8740 it turns out that state really needs to be in run_webkit_tests 8741 * renames the Broker classes to be module-private. 8742 * fixes a bunch of minor commenting and whitespace issues to 8743 make subsequent patches a bit clearer. 8744 * Adds a Port hook for default_worker_model() so that we can 8745 accomodate the potential for different worker models on 8746 different ports. 8747 * merge in the fix from 50420 for the brokenness introduced in 8748 bug 50367. 8749 8750 This patch depends on bug 50367. 8751 8752 https://bugs.webkit.org/show_bug.cgi?id=50372 8753 8754 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 8755 * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: 8756 * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: 8757 * Scripts/webkitpy/layout_tests/port/base.py: 8758 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 8759 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 8760 87612010-12-02 Dirk Pranke <dpranke@chromium.org> 8762 8763 Reviewed by Tony Chang. 8764 8765 This change is a bunch of cleanup / refactoring of the file 8766 below. It moves a bunch of free functions to methods on the 8767 TestShellThread class, and restructures other methods to be 8768 closer to the structure we'll need for the multiprocessing 8769 rewrite. 8770 8771 It also makes the logic of --run-singly a *lot* easier to follow 8772 by nestling all of the separate-thread logic into a single 8773 routine. 8774 8775 There should be no semantic changes in this patch, just cleanup. 8776 8777 https://bugs.webkit.org/show_bug.cgi?id=50367 8778 8779 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 8780 87812010-12-02 Tony Chang <tony@chromium.org> 8782 8783 Unreviewed, rolling out r73164. 8784 http://trac.webkit.org/changeset/73164 8785 https://bugs.webkit.org/show_bug.cgi?id=50359 8786 8787 broke debugger tests on win 8788 8789 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 8790 87912010-11-30 Mihai Parparita <mihaip@chromium.org> 8792 8793 Reviewed by Tony Chang. 8794 8795 Rebaseline server: add updating of baselines 8796 https://bugs.webkit.org/show_bug.cgi?id=50305 8797 8798 Implements updating of baselines, where we copy -actual.* files over 8799 the current -expected.* files. To do this, we need a 8800 _get_actual_result_files method to get test results files and a 8801 _rebaseline_test method to actually do the file copy and SCM operation. 8802 _rebaseline_test logs output into a buffer, this is useful for both 8803 showing result in the UI and for unit tests. 8804 8805 To make passing around of the various test environment properties 8806 (results directory, filesystem, SCM, etc) easier, add a TestConfig 8807 class for them. 8808 8809 Moving of existing baselines is not implemented yet, this patch is big 8810 enough as it is. 8811 8812 * Scripts/webkitpy/common/system/filesystem.py: 8813 * Scripts/webkitpy/common/system/filesystem_mock.py: 8814 * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: 8815 * Scripts/webkitpy/tool/commands/rebaselineserver.py: 8816 * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: 8817 * Scripts/webkitpy/tool/mocktool.py: 8818 88192010-12-02 Brent Fulgham <bfulgham@webkit.org> 8820 8821 Unreviewed build fix after vcproj updates. 8822 8823 * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure 8824 that WIN_CAIRO is defined for this build. 8825 * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file 8826 to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite' 8827 (these were previously 'Debug_Cairo' and 'Release_Cairo' 8828 88292010-12-02 Sam Weinig <sam@webkit.org> 8830 8831 Reviewed by Anders Carlsson. 8832 8833 WebKit2 needs API to turn on popup blocking 8834 https://bugs.webkit.org/show_bug.cgi?id=50407 8835 8836 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: 8837 (TestWebKitAPI::TEST): 8838 * WebKitTestRunner/TestController.cpp: 8839 (WTR::TestController::resetStateToConsistentValues): 8840 88412010-12-01 Tony Chang <tony@chromium.org> 8842 8843 Reviewed by Ojan Vafai. 8844 8845 [chromium] force NRWT to use DRT 8846 https://bugs.webkit.org/show_bug.cgi?id=50359 8847 8848 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 8849 88502010-12-02 Martin Robinson <mrobinson@igalia.com> 8851 8852 Reviewed by Xan Lopez. 8853 8854 [GTK] DumpRenderTree has two copies of JavaScriptCore 8855 https://bugs.webkit.org/show_bug.cgi?id=49877 8856 8857 * GNUmakefile.am: Remove the second copy of JavaScriptCore from the 8858 LDADD list for DumpRenderTree. 8859 88602010-12-02 Sergio Villar Senin <svillar@igalia.com> 8861 8862 Unreviewed: Added myself to list of Committers. 8863 8864 * Scripts/webkitpy/common/config/committers.py: 8865 88662010-12-01 Mihai Parparita <mihaip@chromium.org> 8867 8868 Reviewed by Adam Barth. 8869 8870 build-webkit --chromium always updates DEPS and re-generates project files 8871 https://bugs.webkit.org/show_bug.cgi?id=50340 8872 8873 Make build-webkit --chromium invoke update-webkit-chromium only when 8874 --update-chromium is passed in, so that we don't add 20 seconds to all 8875 builds. 8876 8877 Making all invocations update was added with r61883, with the goal of 8878 making EWS bots always update. The bots will switch to using this flag 8879 (as will all other webkit-patch build steps) so nothing should change 8880 for them. 8881 8882 * Scripts/webkitdirs.pm: 8883 * Scripts/webkitpy/common/config/ports.py: 8884 * Scripts/webkitpy/common/config/ports_unittest.py: 8885 88862010-12-01 Dirk Pranke <dpranke@chromium.org> 8887 8888 Reviewed by Tony Chang. 8889 8890 new-run-webkit-tests: add a --dry-run / -n flag 8891 https://bugs.webkit.org/show_bug.cgi?id=50045 8892 8893 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 8894 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 8895 88962010-12-01 Steve Falkenburg <sfalken@apple.com> 8897 8898 Reviewed by Adam Roben. 8899 8900 WinCairo build should not use link-time code generation (LTCG) 8901 https://bugs.webkit.org/show_bug.cgi?id=50353 8902 8903 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 8904 * DumpRenderTree/win/DumpRenderTree.vcproj: 8905 * DumpRenderTree/win/ImageDiff.vcproj: 8906 * FindSafari/FindSafari.vcproj: 8907 * MiniBrowser/MiniBrowser.vcproj: 8908 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 8909 * WebKitAPITest/WebKitAPITest.vcproj: 8910 * WebKitLauncherWin/WebKitLauncherWin.vcproj: 8911 * WebKitTestRunner/win/InjectedBundle.vcproj: 8912 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 8913 * WinLauncher/WinLauncher.vcproj: 8914 * record-memory-win/record-memory-win.vcproj: 8915 89162010-12-01 Martin Robinson <mrobinson@igalia.com> 8917 8918 Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force 8919 a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply 8920 adding the file to the sources list was not enough to force the rebuild. 8921 8922 * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: 8923 Remove an empty line at the end of this file to force a rebuild. 8924 89252010-12-01 Sam Weinig <sam@webkit.org> 8926 8927 Fix windows build. 8928 8929 * MiniBrowser/win/BrowserView.cpp: 8930 (BrowserView::create): 8931 89322010-12-01 Martin Robinson <mrobinson@igalia.com> 8933 8934 Add missing file to the TestNetscapePlugin sources list after r73057. 8935 8936 * GNUmakefile.am: Add missing file. 8937 89382010-12-01 Sam Weinig <sam@webkit.org> 8939 8940 Reviewed by Anders Carlsson. 8941 8942 Add PageGrouping to WebKit2 API 8943 https://bugs.webkit.org/show_bug.cgi?id=50332 8944 8945 - Update testing harnesses to deal with new PageGroup API. 8946 8947 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 8948 (WKBundleInitialize): 8949 * TestWebKitAPI/InjectedBundleController.cpp: 8950 (TestWebKitAPI::InjectedBundleController::initialize): 8951 (TestWebKitAPI::InjectedBundleController::didInitializePageGroup): 8952 (TestWebKitAPI::InjectedBundleController::initializeTestNamed): 8953 * TestWebKitAPI/InjectedBundleController.h: 8954 * TestWebKitAPI/InjectedBundleTest.h: 8955 (TestWebKitAPI::InjectedBundleTest::initialize): 8956 (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup): 8957 * TestWebKitAPI/PlatformUtilities.cpp: 8958 (TestWebKitAPI::Util::createContextForInjectedBundleTest): 8959 * TestWebKitAPI/PlatformUtilities.h: 8960 * TestWebKitAPI/PlatformWebView.h: 8961 * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: 8962 (TestWebKitAPI::TEST): 8963 * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: 8964 (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize): 8965 * TestWebKitAPI/mac/PlatformWebViewMac.mm: 8966 (TestWebKitAPI::PlatformWebView::PlatformWebView): 8967 * TestWebKitAPI/win/PlatformWebViewWin.cpp: 8968 (TestWebKitAPI::PlatformWebView::PlatformWebView): 8969 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 8970 (WTR::InjectedBundle::didInitializePageGroup): 8971 (WTR::InjectedBundle::initialize): 8972 (WTR::InjectedBundle::beginTesting): 8973 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 8974 (WTR::InjectedBundle::pageGroup): 8975 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 8976 (WTR::LayoutTestController::addUserScript): 8977 (WTR::LayoutTestController::addUserStyleSheet): 8978 (WTR::LayoutTestController::setXSSAuditorEnabled): 8979 * WebKitTestRunner/TestController.cpp: 8980 * WebKitTestRunner/win/PlatformWebViewWin.cpp: 8981 (WTR::PlatformWebView::PlatformWebView): 8982 89832010-12-01 Steve Falkenburg <sfalken@apple.com> 8984 8985 Reviewed by Adam Roben. 8986 8987 vcproj changes can't be applied cleanly by the Windows EWS bot 8988 https://bugs.webkit.org/show_bug.cgi?id=50328 8989 8990 * CLWrapper/CLWrapper.sln: Modified property svn:eol-style. 8991 * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style. 8992 * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style. 8993 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style. 8994 * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style. 8995 * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style. 8996 * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style. 8997 * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style. 8998 * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style. 8999 * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style. 9000 * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style. 9001 * FindSafari/FindSafari.vcproj: Modified property svn:eol-style. 9002 * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style. 9003 * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style. 9004 * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style. 9005 * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style. 9006 * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style. 9007 * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style. 9008 * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style. 9009 * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style. 9010 * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style. 9011 * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style. 9012 * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style. 9013 * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style. 9014 * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style. 9015 * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style. 9016 * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style. 9017 * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style. 9018 * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style. 9019 * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style. 9020 * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style. 9021 * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style. 9022 * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style. 9023 * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style. 9024 * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style. 9025 * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style. 9026 * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style. 9027 * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style. 9028 * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style. 9029 * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style. 9030 * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style. 9031 * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style. 9032 * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style. 9033 * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style. 9034 * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style. 9035 90362010-12-01 Anders Carlsson <andersca@apple.com> 9037 9038 Reviewed by Darin Adler. 9039 9040 Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New. 9041 https://bugs.webkit.org/show_bug.cgi?id=50336 9042 9043 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 9044 Add new test. 9045 9046 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 9047 (PluginTest::NPP_New): 9048 Add default implementation/ 9049 9050 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: 9051 * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added. 9052 (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew): 9053 (GetUserAgentWithNullNPPFromNPPNew::NPP_New): 9054 Get the user agent. 9055 9056 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 9057 (NPP_New): 9058 Call PluginTest::NPP_New. 9059 9060 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 9061 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 9062 Add new files. 9063 9064 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 9065 (webkit_test_plugin_new_instance): 9066 Call PluginTest::NPP_New. 9067 90682010-12-01 Kevin Ollivier <kevino@theolliviers.com> 9069 9070 [wx] Build fixes after recent trunk changes. 9071 9072 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 9073 (LayoutTestController::findString): 9074 * wx/build/settings.py: 9075 90762010-12-01 Dan Bernstein <mitz@apple.com> 9077 9078 Reviewed by Darin Adler. 9079 9080 WebKitTestRunner needs layoutTestController.findString 9081 https://bugs.webkit.org/show_bug.cgi?id=50238 9082 9083 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString(). 9084 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 9085 (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings. 9086 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto. 9087 90882010-12-01 Steve Falkenburg <sfalken@apple.com> 9089 9090 Try using svn:eol-style native on a vcproj file. 9091 9092 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style. 9093 90942010-12-01 Patrick Gansterer <paroga@webkit.org> 9095 9096 Reviewed by Adam Roben. 9097 9098 [WINCE] Add WinCELauncher 9099 https://bugs.webkit.org/show_bug.cgi?id=50217 9100 9101 * WinCELauncher/main.cpp: Added. 9102 91032010-11-30 Benjamin Poulain <benjamin.poulain@nokia.com> 9104 9105 Reviewed by Kenneth Rohde Christiansen. 9106 9107 [Qt] Implement layoutTestController.findString 9108 https://bugs.webkit.org/show_bug.cgi?id=50236 9109 9110 Add the missing function to the LayoutTestController. 9111 9112 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 9113 (LayoutTestController::findString): 9114 * DumpRenderTree/qt/LayoutTestControllerQt.h: 9115 91162010-11-30 Tony Chang <tony@chromium.org> 9117 9118 Reviewed by Adam Barth. 9119 9120 [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn 9121 https://bugs.webkit.org/show_bug.cgi?id=49036 9122 9123 * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32 9124 for CppVariants. 9125 (LayoutTestController::cppVariantToBool): 9126 (LayoutTestController::cppVariantToInt32): 9127 (LayoutTestController::setDatabaseQuota): 9128 (LayoutTestController::evaluateInWebInspector): 9129 (LayoutTestController::setMockGeolocationError): 9130 91312010-11-30 Eric Seidel <eric@webkit.org> 9132 9133 Reviewed by Tony Chang. 9134 9135 update-webkit should call git fetch before git svn rebase 9136 https://bugs.webkit.org/show_bug.cgi?id=50273 9137 9138 After discussion on webkit-dev, we've decided to move the "default" 9139 git setup to pulling updates from git.webkit.org in preference 9140 to rebuilding the local svn index using git svn fetch every time. 9141 9142 This change should have no effect on people using the "old" git setup 9143 and should dramatically increase the speed of updates for those using 9144 the "new" git setup along with update-webkit. I'm about to move the 9145 EWS and other queues over to this setup once this lands. 9146 9147 * Scripts/update-webkit: 9148 91492010-11-30 Mario Sanchez Prada <msanchez@igalia.com> 9150 9151 Reviewed by Xan Lopez. 9152 9153 GTK: AX: implement press in DRT 9154 https://bugs.webkit.org/show_bug.cgi?id=36146 9155 9156 Implement AccessibilityUIElement::press() for GTK. 9157 9158 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 9159 (AccessibilityUIElement::press): Implemented. 9160 91612010-11-29 Mihai Parparita <mihaip@chromium.org> 9162 9163 Reviewed by Tony Chang. 9164 9165 config.webkit_base_dir returns a path with a trailing slash 9166 https://bugs.webkit.org/show_bug.cgi?id=50197 9167 9168 config.webkit_base_dir() should return a path without a trailing slash, 9169 like all the other methods that return paths. 9170 9171 Undoes MockFileSytem changes by r72640, since they're no longer 9172 necessary for GetBaselinesTest to pass. 9173 9174 * Scripts/webkitpy/common/system/filesystem_mock.py: 9175 * Scripts/webkitpy/layout_tests/port/base.py: 9176 * Scripts/webkitpy/layout_tests/port/config.py: 9177 * Scripts/webkitpy/layout_tests/port/config_unittest.py: 9178 91792010-11-30 Mihai Parparita <mihaip@chromium.org> 9180 9181 Reviewed by Tony Chang. 9182 9183 Rebaseline server: baseline display tweaks 9184 https://bugs.webkit.org/show_bug.cgi?id=50207 9185 9186 Determine which baselines were used when running the tests and highlight 9187 them in the UI. Sort platform names alphabetically. 9188 9189 Also makes the server URL be launched in the user's browser 9190 automatically. 9191 9192 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: 9193 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: 9194 * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: 9195 * Scripts/webkitpy/tool/commands/rebaselineserver.py: 9196 * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: 9197 91982010-11-30 Dan Bernstein <mitz@apple.com> 9199 9200 Reviewed by Anders Carlsson. 9201 9202 <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString 9203 https://bugs.webkit.org/show_bug.cgi?id=50238 9204 9205 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 9206 (WTR::LayoutTestController::findString): Added. 9207 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 9208 92092010-11-30 Steve Falkenburg <sfalken@apple.com> 9210 9211 Reviewed by Adam Roben. 9212 9213 All projects on Windows should use cmd files for build events 9214 https://bugs.webkit.org/show_bug.cgi?id=50213 9215 9216 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: 9217 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added. 9218 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added. 9219 * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: 9220 * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added. 9221 * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added. 9222 * DumpRenderTree/win/ImageDiffCommon.vsprops: 9223 * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added. 9224 * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added. 9225 * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: 9226 * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: 9227 * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: 9228 * MiniBrowser/MiniBrowserPostBuild.cmd: Added. 9229 * MiniBrowser/MiniBrowserPreBuild.cmd: Added. 9230 * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: 9231 * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added. 9232 * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added. 9233 * WebKitAPITest/WebKitAPITestCommon.vsprops: 9234 * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added. 9235 * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added. 9236 * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: 9237 * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: 9238 * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added. 9239 * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added. 9240 * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added. 9241 * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added. 9242 * WinLauncher/WinLauncherCommon.vsprops: 9243 * WinLauncher/WinLauncherPostBuild.cmd: Added. 9244 * WinLauncher/WinLauncherPreBuild.cmd: Added. 9245 92462010-11-29 Dan Bernstein <mitz@apple.com> 9247 9248 GTK DumpRenderTree build fix after r72887. 9249 9250 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 9251 (LayoutTestController::findString): 9252 92532010-11-29 Dan Bernstein <mitz@apple.com> 9254 9255 Windows DumpRenderTree build fix after r72887. 9256 9257 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 9258 (LayoutTestController::findString): Added empty implementation. 9259 92602010-11-29 Dan Bernstein <mitz@apple.com> 9261 9262 Reviewed by Darin Adler. 9263 9264 DumpRenderTree changes for testing the text search API. 9265 https://bugs.webkit.org/show_bug.cgi?id=50038 9266 9267 * DumpRenderTree/LayoutTestController.cpp: 9268 (findStringCallback): 9269 (LayoutTestController::staticFunctions): 9270 * DumpRenderTree/LayoutTestController.h: 9271 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 9272 (LayoutTestController::findString): 9273 * MiniBrowser/mac/BrowserWindowController.m: 9274 (-[BrowserWindowController find:]): 9275 92762010-11-29 Johnny Ding <jnd@chromium.org> 9277 9278 Unreviewed: Add myself to the list of Committers. 9279 9280 * Scripts/webkitpy/common/config/committers.py: 9281 92822010-11-29 Mark Rowe <mrowe@apple.com> 9283 9284 Reviewed by Adele Peterson. 9285 9286 <rdar://problem/8694997> DumpRenderTree fails to build. 9287 9288 * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers. 9289 92902010-11-29 Mark Rowe <mrowe@apple.com> 9291 9292 Reviewed by Adele Peterson. 9293 9294 <rdar://problem/8694997> DumpRenderTree fails to build. 9295 9296 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm. 9297 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c. 9298 * DumpRenderTree/mac/PerlSupport/Makefile: 9299 93002010-11-29 Mario Sanchez Prada <msanchez@igalia.com> 9301 9302 Reviewed by Martin Robinson. 9303 9304 [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes() 9305 https://bugs.webkit.org/show_bug.cgi?id=50154 9306 9307 Added missing checks to allAttributes(). 9308 9309 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 9310 (AccessibilityUIElement::allAttributes): Added missing checks. 9311 93122010-11-29 Laszlo Gombos <laszlo.1.gombos@nokia.com> 9313 9314 Reviewed by Kenneth Rohde Christiansen. 9315 9316 [Qt] Allow pre-generation for package builds for WebKit2 9317 https://bugs.webkit.org/show_bug.cgi?id=50139 9318 9319 Use a build variable for the generated directory path and set the 9320 value based on CONFIG just like for WebKit1. 9321 9322 For non-package builds use a relative base path for the 9323 genrated directory just like for WebKit1. 9324 9325 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: 9326 * WebKitTestRunner/qt/WebKitTestRunner.pro: 9327 93282010-11-28 Laszlo Gombos <laszlo.1.gombos@nokia.com> 9329 9330 Reviewed by Kenneth Rohde Christiansen. 9331 9332 [Qt] Move some build logic from Qt to platform independent code 9333 https://bugs.webkit.org/show_bug.cgi?id=50134 9334 9335 Create target directories inside generate-forwarding-headers.pl. 9336 9337 * Scripts/generate-forwarding-headers.pl: 9338 93392010-11-24 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk> 9340 9341 Reviewed by Martin Robinson. 9342 9343 [GTK] Windowless plugins gets broken key input 9344 https://bugs.webkit.org/show_bug.cgi?id=49927 9345 9346 Convert the XEvent::keycode to ASCII before printing it. Not 9347 doing this was causing false positive in 9348 plugins/keyboard-events.html. 9349 9350 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 9351 (keycode_to_char): 9352 (webkit_test_plugin_handle_event): 9353 93542010-11-24 Jan Erik Hanssen <jhanssen@sencha.com> 9355 9356 Reviewed by Antonio Gomes. 9357 9358 [Qt] Html autofocus not working with QGraphicsWebView 9359 https://bugs.webkit.org/show_bug.cgi?id=43169 9360 9361 Tell the scene to set the webview item as the currently 9362 focused item. This makes the input field with autofocus get 9363 focus as it should. 9364 9365 * QtTestBrowser/webview.cpp: 9366 (WebViewGraphicsBased::WebViewGraphicsBased): 9367 93682010-11-24 Dirk Pranke <dpranke@chromium.org> 9369 9370 Reviewed by Tony Chang. 9371 9372 nrwt - clean up create_driver interface and print out the 9373 command line used for DumpRenderTree/TestShell. 9374 9375 This patch adds a driver_cmd_line() call to the Port class in 9376 order to retrive the command line to print it out (as part of 9377 --print config). 9378 9379 In addition, this patch cleans up the Port.create_driver() 9380 signature and the Driver constructor interface to take a worker 9381 number and no longer require the image_path argument (Chromium's 9382 drivers now synthesize the image_path from the worker number 9383 internally). 9384 9385 https://bugs.webkit.org/show_bug.cgi?id=49934 9386 9387 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 9388 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 9389 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 9390 * Scripts/webkitpy/layout_tests/port/base.py: 9391 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 9392 * Scripts/webkitpy/layout_tests/port/chromium.py: 9393 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 9394 * Scripts/webkitpy/layout_tests/port/dryrun.py: 9395 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 9396 * Scripts/webkitpy/layout_tests/port/test.py: 9397 * Scripts/webkitpy/layout_tests/port/webkit.py: 9398 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 9399 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 9400 94012010-11-24 Ojan Vafai <ojan@chromium.org> 9402 9403 Reviewed by Tony Chang. 9404 9405 [chromium] improve memory usage for test results server and store fewer runs 9406 https://bugs.webkit.org/show_bug.cgi?id=50035 9407 9408 Store fewer runs and don't pass full files around when we only need bools. 9409 Greatly improves error rates on test-results.appspot.com. 9410 9411 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 9412 * TestResultServer/handlers/testfilehandler.py: 9413 * TestResultServer/model/dashboardfile.py: 9414 * TestResultServer/model/jsonresults.py: 9415 94162010-11-24 Dirk Pranke <dpranke@chromium.org> 9417 9418 Reviewed by Tony Chang. 9419 9420 This patch implements the first part of the manager side of the 9421 Broker objects - it handles creating threads, waiting for them 9422 to complete, and running a single-threaded loop as well. 9423 9424 https://bugs.webkit.org/show_bug.cgi?id=49779 9425 9426 * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: 9427 * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: 9428 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 9429 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 9430 94312010-11-24 Mihai Parparita <mihaip@chromium.org> 9432 9433 Reviewed by David Levin. 9434 9435 DRT should not generate pixel output for text/plain tests 9436 https://bugs.webkit.org/show_bug.cgi?id=50002 9437 9438 Modify Mac, Windows and GTK DRT implementations to disable pixel output 9439 when encountering a text/plain response (the Chromium one already does 9440 this, and none of the other ports special-case text/plain output in 9441 the first place). 9442 9443 * DumpRenderTree/gtk/DumpRenderTree.cpp: 9444 (dump): 9445 * DumpRenderTree/mac/DumpRenderTree.mm: 9446 (dump): 9447 * DumpRenderTree/win/DumpRenderTree.cpp: 9448 (dump): 9449 94502010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu> 9451 9452 Unreviewed. 9453 9454 Add my other email address to committers.py. 9455 9456 * Scripts/webkitpy/common/config/committers.py: 9457 94582010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu> 9459 9460 Reviewed by Csaba Osztrogonác. 9461 9462 Make build-webkit --minimal build with ENABLE_INSPECTOR=0 9463 https://bugs.webkit.org/show_bug.cgi?id=49975 9464 9465 * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features, 9466 to enable the script to define it 0 in case of a minimal build. 9467 94682010-11-24 Martin Robinson <mrobinson@igalia.com> 9469 9470 Reviewed by Xan Lopez. 9471 9472 [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient 9473 https://bugs.webkit.org/show_bug.cgi?id=49143 9474 9475 * DumpRenderTree/gtk/DumpRenderTree.cpp: 9476 (createWebView): Call the new connectEditingCallbacks function. 9477 * DumpRenderTree/gtk/EditingCallbacks.cpp: Added. 9478 (dumpNodePath): 9479 (dumpRange): 9480 (insertActionString): 9481 (selectionAffinityString): 9482 (shouldBeginEditing): 9483 (shouldEndEditing): 9484 (shouldInsertNode): 9485 (shouldInsertText): 9486 (shouldDeleteRange): 9487 (shouldShowDeleteInterfaceForElement): 9488 (shouldChangeSelectedRange): 9489 (shouldApplyStyle): 9490 (editingBegan): 9491 (userChangedContents): 9492 (editingEnded): 9493 (selectionChanged): 9494 (connectEditingCallbacks): 9495 * DumpRenderTree/gtk/EditingCallbacks.h: Added. 9496 * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list. 9497 94982010-11-24 Yi Shen <yi.4.shen@nokia.com> 9499 9500 Reviewed by Andreas Kling. 9501 9502 [Qt] Make QtTestBrowser remember the selected user agent 9503 https://bugs.webkit.org/show_bug.cgi?id=50021 9504 9505 Set user agent for a new page by using the old page's 9506 9507 * QtTestBrowser/mainwindow.cpp: 9508 (MainWindow::setPage): 9509 95102010-11-24 Patrick Gansterer <paroga@webkit.org> 9511 9512 Reviewed by Csaba Osztrogonác. 9513 9514 Remove Bakefile build system files 9515 https://bugs.webkit.org/show_bug.cgi?id=49983 9516 9517 r53757 only removed the content, but not the files. 9518 This patch removes that empty files. 9519 9520 * DumpRenderTree/wx/DumpRenderTree.bkl: Removed. 9521 * wx/browser/browser.bkl: Removed. 9522 * wx/build-wxwebkit: Removed. 9523 95242010-11-23 Dirk Pranke <dpranke@chromium.org> 9525 9526 Reviewed by Tony Chang. 9527 9528 This patch cleans up the logic used to shard tests into groups a 9529 bit and adds the --worker-model flag to NRWT. The flag is only 9530 used at the moment to control whether to run single-threaded or 9531 not, but eventually will also allow toggling between threads and 9532 processes. 9533 9534 Also add a minor cleanup with _test_is_slow(), which just 9535 eliminates some repetition and gives slightly better encapsulation. 9536 9537 https://bugs.webkit.org/show_bug.cgi?id=49773 9538 9539 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 9540 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 9541 95422010-11-23 Mihai Parparita <mihaip@chromium.org> 9543 9544 Reviewed by Tony Chang. 9545 9546 Rebaseline server: list current baselines and platforms 9547 https://bugs.webkit.org/show_bug.cgi?id=49991 9548 9549 List existing baselines (with Trac links) for tests. 9550 9551 Add dropdowns for choosing with platform baselines to target (and what 9552 to do with existing ones). 9553 9554 Also fix MockFileSystem.join to behave more like os.path.join (unit 9555 test was ending up with two consecutive slashes in a layout test 9556 path). 9557 9558 * Scripts/webkitpy/common/system/filesystem_mock.py: 9559 * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: 9560 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: 9561 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: 9562 * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: 9563 * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: 9564 * Scripts/webkitpy/tool/commands/rebaselineserver.py: 9565 * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added. 9566 95672010-11-23 Ojan Vafai <ojan@chromium.org> 9568 9569 Reviewed by Tony Chang. 9570 9571 remove timeout argument to urlopen 9572 https://bugs.webkit.org/show_bug.cgi?id=49995 9573 9574 Apparently the version of python we have on the bots doesn't accept a timeout argument. 9575 9576 * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: 9577 95782010-11-23 Sheriff Bot <webkit.review.bot@gmail.com> 9579 9580 Unreviewed, rolling out r72628. 9581 http://trac.webkit.org/changeset/72628 9582 https://bugs.webkit.org/show_bug.cgi?id=49994 9583 9584 This patch is causing layout-test failtures on GTK Linux 9585 64-bit Debug (Requested by ctguil on #webkit). 9586 9587 * DumpRenderTree/chromium/AccessibilityUIElement.cpp: 9588 (AccessibilityUIElement::AccessibilityUIElement): 9589 (AccessibilityUIElement::parentElementCallback): 9590 * DumpRenderTree/chromium/AccessibilityUIElement.h: 9591 * DumpRenderTree/chromium/CppBoundClass.cpp: 9592 * DumpRenderTree/chromium/CppBoundClass.h: 9593 95942010-11-22 Ojan Vafai <ojan@chromium.org> 9595 9596 Reviewed by Tony Chang. 9597 9598 speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com 9599 https://bugs.webkit.org/show_bug.cgi?id=49944 9600 9601 * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: 9602 96032010-11-23 Chris Guillory <chris.guillory@google.com> 9604 9605 Reviewed by Dimitri Glazkov. 9606 9607 Include the FrameView widget of a RenderWidget in the accessibility tree. 9608 https://bugs.webkit.org/show_bug.cgi?id=49106 9609 9610 * DumpRenderTree/chromium/AccessibilityUIElement.cpp: 9611 (AccessibilityUIElement::AccessibilityUIElement): 9612 (AccessibilityUIElement::parentElementCallback): 9613 (AccessibilityUIElement::isEqualCallback): 9614 * DumpRenderTree/chromium/AccessibilityUIElement.h: 9615 * DumpRenderTree/chromium/CppBoundClass.cpp: 9616 (CppBoundClass::getFromCppVariant): 9617 * DumpRenderTree/chromium/CppBoundClass.h: 9618 96192010-11-23 Alex Grilo <abgrilo@profusion.mobi> 9620 9621 Reviewed by Kenneth Rohde Christiansen. 9622 9623 [EFL] Add tiled backing store to EWebLauncher 9624 https://bugs.webkit.org/show_bug.cgi?id=45777 9625 9626 Allow EWebLauncher to choose between single and tiled backing store 9627 9628 * EWebLauncher/main.c: 9629 (on_key_down): 9630 (browserCreate): 9631 (main): 9632 96332010-11-23 Simon Hausmann <simon.hausmann@nokia.com> 9634 9635 Reviewed by Tor Arne Vestbø. 9636 9637 [Qt] Review the setUserPermission & friends API 9638 https://bugs.webkit.org/show_bug.cgi?id=46810 9639 9640 Renamed requestPermissionFromUser to featurePermissionRequested 9641 and cancelRequestsForPermission to featurePermissionRequestCanceled. 9642 9643 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 9644 (WebCore::WebPage::WebPage): 9645 * QtTestBrowser/webpage.cpp: 9646 (WebPage::WebPage): 9647 (WebPage::featurePermissionRequestCanceled): 9648 * QtTestBrowser/webpage.h: 9649 96502010-11-23 Simon Hausmann <simon.hausmann@nokia.com> 9651 9652 Reviewed by Tor Arne Vestbø. 9653 9654 [Qt] Review the setUserPermission & friends API 9655 https://bugs.webkit.org/show_bug.cgi?id=46810 9656 9657 Rename setUserPermission to setFeaturePermission 9658 9659 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 9660 (WebCore::WebPage::requestPermission): 9661 (WebCore::WebPage::permissionSet): 9662 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 9663 (LayoutTestController::grantDesktopNotificationPermission): 9664 * QtTestBrowser/webpage.cpp: 9665 (WebPage::requestPermission): 9666 96672010-11-23 Simon Hausmann <simon.hausmann@nokia.com> 9668 9669 Reviewed by Tor Arne Vestbø. 9670 9671 [Qt] Review the setUserPermission & friends API 9672 https://bugs.webkit.org/show_bug.cgi?id=46810 9673 9674 Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications 9675 and GeolocationPermissionDomain to Geolocation. 9676 9677 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 9678 (WebCore::WebPage::WebPage): 9679 (WebCore::WebPage::requestPermission): 9680 (WebCore::WebPage::cancelPermission): 9681 (WebCore::WebPage::permissionSet): 9682 (WebCore::DumpRenderTree::geolocationPermissionSet): 9683 * DumpRenderTree/qt/DumpRenderTreeQt.h: 9684 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 9685 (LayoutTestController::grantDesktopNotificationPermission): 9686 * QtTestBrowser/webpage.cpp: 9687 (WebPage::WebPage): 9688 (WebPage::requestPermission): 9689 (WebPage::cancelRequestsForPermission): 9690 * QtTestBrowser/webpage.h: 9691 96922010-11-23 Simon Hausmann <simon.hausmann@nokia.com> 9693 9694 Reviewed by Tor Arne Vestbø. 9695 9696 [Qt] Review the setUserPermission & friends API 9697 https://bugs.webkit.org/show_bug.cgi?id=46810 9698 9699 Add a ByUser suffix to PermissionGranted/Denied. In the future 9700 we can add PermissionGrantedByDefault. 9701 9702 9703 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 9704 (WebCore::WebPage::requestPermission): 9705 (WebCore::WebPage::permissionSet): 9706 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 9707 (LayoutTestController::grantDesktopNotificationPermission): 9708 * QtTestBrowser/webpage.cpp: 9709 (WebPage::requestPermission): 9710 97112010-11-18 Satish Sampath <satish@chromium.org> 9712 9713 Reviewed by Jeremy Orlow. 9714 9715 For speech input event, send an event object containing all the recognition results and metadata. 9716 https://bugs.webkit.org/show_bug.cgi?id=49736 9717 9718 Updated DRT by renaming the mock result method on all platforms to the new signature. 9719 9720 * DumpRenderTree/LayoutTestController.cpp: 9721 (addMockSpeechInputResultCallback): 9722 (LayoutTestController::staticFunctions): 9723 * DumpRenderTree/LayoutTestController.h: 9724 * DumpRenderTree/chromium/LayoutTestController.cpp: 9725 (LayoutTestController::LayoutTestController): 9726 (LayoutTestController::addMockSpeechInputResult): 9727 * DumpRenderTree/chromium/LayoutTestController.h: 9728 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 9729 (LayoutTestController::addMockSpeechInputResult): 9730 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 9731 (LayoutTestController::addMockSpeechInputResult): 9732 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 9733 (LayoutTestController::addMockSpeechInputResult): 9734 * DumpRenderTree/qt/LayoutTestControllerQt.h: 9735 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 9736 (LayoutTestController::addMockSpeechInputResult): 9737 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 9738 (LayoutTestController::addMockSpeechInputResult): 9739 97402010-11-22 Dirk Pranke <dpranke@chromium.org> 9741 9742 Reviewed by Tony Chang. 9743 9744 Fix some spacing issues with log messages with 9745 new-run-webkit-tests --verbose. 9746 9747 https://bugs.webkit.org/show_bug.cgi?id=49936 9748 9749 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 9750 97512010-11-22 Ojan Vafai <ojan@chromium.org> 9752 9753 Reviewed by Adam Barth. 9754 9755 update scm to work with different remote branches 9756 https://bugs.webkit.org/show_bug.cgi?id=49949 9757 9758 This works if there are multiple svn tracking branches 9759 and/or if the tracking branch is refs/remots/origin/master 9760 instead of refs/remotes/trunk which is the direction we're trying 9761 to head since that makes fetches faster. 9762 9763 * Scripts/webkitpy/common/checkout/scm.py: 9764 * Scripts/webkitpy/common/checkout/scm_unittest.py: 9765 97662010-11-22 Hayato Ito <hayato@chromium.org> 9767 9768 Reviewed by Shinichiro Hamaji. 9769 9770 Ignore reference files which will be used by reftests when collecting 9771 test cases. 9772 https://bugs.webkit.org/show_bug.cgi?id=49835 9773 9774 * Scripts/webkitpy/layout_tests/port/test_files.py: 9775 * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: 9776 97772010-11-22 Adam Roben <aroben@apple.com> 9778 9779 Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files 9780 9781 Apple's Windows build allows placing header files and import libraries for WebKit's 9782 dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the 9783 $WebKitLibrariesDir environment variable. This is both required for production builds and 9784 convenient for Apple-internal developer builds. Apple's production builds also require that 9785 WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production 9786 builds, the files are copied into that directory tree by the 9787 WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the 9788 copying is done by 9789 JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make. 9790 9791 This .vsprops copying is problematic in one very important case: when a developer updates 9792 their source tree and then tries to build. Visual Studio only reads .vsprops files when a 9793 project is first loaded. So, when Visual Studio is first opened after the .vsprops files are 9794 updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a 9795 build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into 9796 $WebKitLibrariesDir, but Visual Studio will not pick up the changes. The rest of the build 9797 will proceed with out-of-date .vsprops files, which will likely result in a build failure. 9798 9799 To fix this, we now use normal relative paths to access the .vsprops files in the source 9800 tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment 9801 variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is 9802 unset, so the normal relative paths are used to read the .vsprops files out of the source 9803 tree directly. In production builds, this environment variable is set to a fake directory 9804 that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path 9805 is resolved. 9806 9807 For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops: 9808 9809 $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops 9810 9811 In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the 9812 files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds, 9813 JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to 9814 "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for 9815 FeatureDefines.vsprops becomes: 9816 9817 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops 9818 9819 which resolves to: 9820 9821 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops 9822 9823 (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3" 9824 actually exist since they are matched by an equal number of ".." path components.) 9825 9826 Note that Visual Studio still won't pick up changes made to .vsprops files while Visual 9827 Studio is open, but that problem hasn't seemed to cause developers many headaches so far. 9828 9829 Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are 9830 updated 9831 9832 Reviewed by Dave Hyatt. 9833 9834 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 9835 * DumpRenderTree/win/DumpRenderTree.vcproj: 9836 * DumpRenderTree/win/ImageDiff.vcproj: 9837 * FindSafari/FindSafari.vcproj: 9838 * MiniBrowser/MiniBrowser.vcproj: 9839 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 9840 * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: 9841 * WebKitAPITest/WebKitAPITest.vcproj: 9842 * WebKitLauncherWin/WebKitLauncherWin.vcproj: 9843 * WebKitTestRunner/win/InjectedBundle.vcproj: 9844 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 9845 * WinLauncher/WinLauncher.vcproj: 9846 * record-memory-win/record-memory-win.vcproj: 9847 Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops 9848 files. 9849 98502010-11-22 Adam Roben <aroben@apple.com> 9851 9852 Make it possible to run tests on Windows without Visual Studio or VC++ 9853 Express installed 9854 9855 webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express 9856 are not installed. But this function doesn't need to be called when we 9857 already have a build available and are just trying to run the tests. 9858 9859 Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests 9860 because Visual Studio/VC++ Express aren't installed 9861 9862 Reviewed by Dave Hyatt. 9863 9864 * Scripts/webkitdirs.pm: 9865 (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as 9866 it is not needed by this function. Also added a FIXME. 9867 9868 (usingVisualStudioExpress): Call setupCygwinEnv directly rather than 9869 relying on determineConfigurationForVisualStudio doing it. 9870 98712010-11-19 Hayato Ito <hayato@chromium.org> 9872 9873 Reviewed by Shinichiro Hamaji. 9874 9875 Simplify Driver.run_test() so that it takes only one parameter, TestInput. 9876 9877 https://bugs.webkit.org/show_bug.cgi?id=49812 9878 9879 * Scripts/webkitpy/layout_tests/driver_test.py: 9880 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 9881 * Scripts/webkitpy/layout_tests/port/base.py: 9882 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 9883 * Scripts/webkitpy/layout_tests/port/chromium.py: 9884 * Scripts/webkitpy/layout_tests/port/dryrun.py: 9885 * Scripts/webkitpy/layout_tests/port/test.py: 9886 * Scripts/webkitpy/layout_tests/port/webkit.py: 9887 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 9888 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 9889 98902010-11-22 Hayato Ito <hayato@chromium.org> 9891 9892 Reviewed by Tony Chang. 9893 9894 [NRWT] Retry a few times in reading a png image to avoid a race condition. 9895 9896 https://bugs.webkit.org/show_bug.cgi?id=49924 9897 9898 * Scripts/webkitpy/layout_tests/port/chromium.py: 9899 99002010-11-22 João Paulo Rechi Vita <jprvita@profusion.mobi> 9901 9902 Reviewed by Kenneth Rohde Christiansen. 9903 9904 Fix EWebLauncher zoom discretization 9905 https://bugs.webkit.org/show_bug.cgi?id=49810 9906 9907 * EWebLauncher/main.c: 9908 (nearest_zoom_level_get): 9909 (zoom_level_set): 9910 (on_load_finished): 9911 (on_key_down): 9912 99132010-11-21 Sam Weinig <sam@webkit.org> 9914 9915 Rubber-stamped by Dan Bernstein. 9916 9917 Fix ~300 WebKit2 tests by enabling developer extras preference. 9918 9919 * WebKitTestRunner/TestController.cpp: 9920 (WTR::TestController::resetStateToConsistentValues): 9921 99222010-11-21 Sam Weinig <sam@webkit.org> 9923 9924 Reviewed by Dan Bernstein. 9925 9926 Textareas should be resizable by default 9927 https://bugs.webkit.org/show_bug.cgi?id=49892 9928 9929 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 9930 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added. 9931 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 9932 Add preferences test. 9933 99342010-11-19 Mihai Parparita <mihaip@chromium.org> 9935 9936 Reviewed by Tony Chang. 9937 9938 Rebaseline server: checksum-only differences and prefetching 9939 https://bugs.webkit.org/show_bug.cgi?id=49841 9940 9941 Add support for image test results where the only difference is in the 9942 checksum. 9943 9944 Add prefetching of the image results from the next test. 9945 9946 * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: 9947 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: 9948 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: 9949 99502010-11-19 Dirk Pranke <dpranke@chromium.org> 9951 9952 Reviewed by Tony Chang. 9953 9954 nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread 9955 9956 Add the 'worker number' and 'worker name' concepts to the 9957 TestShellThread objects, and move test_types and test_args from 9958 the TestRunner to the TestShellThread. 9959 9960 https://bugs.webkit.org/show_bug.cgi?id=49768 9961 9962 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 9963 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 9964 99652010-11-19 Dirk Pranke <dpranke@chromium.org> 9966 9967 Reviewed by Ojan Vafai. 9968 9969 Do some minor cleanup and bug fixing. 9970 9971 https://bugs.webkit.org/show_bug.cgi?id=49777 9972 9973 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 9974 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 9975 99762010-11-19 Dirk Pranke <dpranke@chromium.org> 9977 9978 Reviewed by Ojan Vafai. 9979 9980 nrwt - config.build_directory() is busted 9981 9982 Fixes a typo that was causing us to usually return the top level 9983 directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The 9984 bug was hidden by test stubs that were too simplistic :(. 9985 9986 https://bugs.webkit.org/show_bug.cgi?id=49815 9987 9988 * Scripts/webkitpy/common/system/executive_mock.py: 9989 * Scripts/webkitpy/layout_tests/port/config.py: 9990 * Scripts/webkitpy/layout_tests/port/config_unittest.py: 9991 99922010-11-19 Steve Falkenburg <sfalken@apple.com> 9993 9994 Reviewed by Adam Roben. 9995 9996 Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files 9997 https://bugs.webkit.org/show_bug.cgi?id=49819 9998 9999 * DumpRenderTree/DumpRenderTree.sln: 10000 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 10001 * DumpRenderTree/win/DumpRenderTree.vcproj: 10002 * DumpRenderTree/win/ImageDiff.vcproj: 10003 * FindSafari/FindSafari.vcproj: 10004 * MiniBrowser/MiniBrowser.vcproj: 10005 * TestWebKitAPI/win/TestWebKitAPI.sln: 10006 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 10007 * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: 10008 * WebKitAPITest/WebKitAPITest.vcproj: 10009 * WebKitLauncherWin/WebKitLauncherWin.vcproj: 10010 * WebKitTestRunner/win/InjectedBundle.vcproj: 10011 * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: 10012 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 10013 * WinLauncher/WinLauncher.vcproj: 10014 * record-memory-win/record-memory-win.vcproj: 10015 100162010-11-19 Adam Roben <aroben@apple.com> 10017 10018 Add some more Windows slaves 10019 10020 This is probably more than we will be using in the immediate future, 10021 but having some extra slave names makes experimenting with different 10022 configurations easier. 10023 10024 Reviewed by Jon Honeycutt. 10025 10026 * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more 10027 Windows slaves and distributed them among the three different Test 10028 builders. 10029 100302010-11-19 Kinuko Yasuda <kinuko@chromium.org> 10031 10032 Reviewed by Ojan Vafai. 10033 10034 [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests 10035 https://bugs.webkit.org/show_bug.cgi?id=49702 10036 10037 Re-landing r72357 with a test fix. 10038 10039 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 10040 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 10041 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: 10042 100432010-11-19 Avi Drissman <avi@google.com> 10044 10045 Reviewed by Antonio Gomes. 10046 10047 Complete support for Unix editing mode 10048 https://bugs.webkit.org/show_bug.cgi?id=49757 10049 10050 * DumpRenderTree/LayoutTestController.cpp: 10051 (setEditingBehaviorCallback): 10052 * DumpRenderTree/chromium/LayoutTestController.cpp: 10053 (LayoutTestController::setEditingBehavior): 10054 100552010-11-19 Adam Roben <aroben@apple.com> 10056 10057 Fix run-javascriptcore-tests when there's a space in the path to 10058 testapi 10059 10060 Reviewed by Sam Weinig. 10061 10062 * Scripts/run-javascriptcore-tests: Use an indirect object when calling 10063 system() to force it to interpret spaces in the path correctly. 10064 100652010-11-19 Adam Roben <aroben@apple.com> 10066 10067 Update scripts for .exe name changes after r72327 10068 10069 As of r72327, the "_debug" suffix is only used in Debug_All builds. 10070 10071 Reviewed by Sam Weinig. 10072 10073 * Scripts/run-javascriptcore-tests: 10074 (testapiPath): 10075 10076 * Scripts/sunspider-compare-results: 10077 (pathToBuiltJSC): 10078 10079 * Scripts/webkitdirs.pm: 10080 (jscPath): 10081 (safariPath): 10082 100832010-11-19 Steve Falkenburg <sfalken@apple.com> 10084 10085 Reviewed by Darin Adler. 10086 10087 Normalize Cairo/CFLite project/solution configuration names 10088 https://bugs.webkit.org/show_bug.cgi?id=49818 10089 10090 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 10091 * DumpRenderTree/win/DumpRenderTree.vcproj: 10092 * DumpRenderTree/win/ImageDiff.vcproj: 10093 * MiniBrowser/MiniBrowser.vcproj: 10094 * TestWebKitAPI/win/TestWebKitAPI.sln: 10095 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 10096 * WebKitAPITest/WebKitAPITest.vcproj: 10097 * WebKitTestRunner/win/InjectedBundle.vcproj: 10098 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 10099 * WinLauncher/WinLauncher.vcproj: 10100 * Scripts/webkitdirs.pm: Updated cairo build configs. 10101 101022010-11-18 Steve Falkenburg <sfalken@apple.com> 10103 10104 Reviewed by Adam Roben. 10105 10106 Windows vcproj configuration names should be normalized across projects 10107 https://bugs.webkit.org/show_bug.cgi?id=49776 10108 10109 * DumpRenderTree/DumpRenderTree.sln: 10110 * FindSafari/FindSafari.vcproj: 10111 * TestWebKitAPI/win/TestWebKitAPI.sln: 10112 * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: 10113 * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added. 10114 * WebKitAPITest/WebKitAPITest.vcproj: 10115 * WebKitAPITest/WebKitAPITestCommon.vsprops: 10116 * WebKitLauncherWin/WebKitLauncherWin.vcproj: 10117 * WebKitTestRunner/WebKitTestRunner.sln: 10118 * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: 10119 * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added. 10120 * record-memory-win/record-memory-win.vcproj: 10121 101222010-11-18 Gavin Barraclough <barraclough@apple.com> 10123 10124 Build fix - as per DRT-mac, always enabled developer extras, 10125 in win/qt/gtk DRT. 10126 10127 This is necessary to enable rich exception messages to be generated 10128 following https://bugs.webkit.org/show_bug.cgi?id=49708. 10129 10130 * DumpRenderTree/gtk/DumpRenderTree.cpp: 10131 (shouldEnableDeveloperExtras): 10132 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 10133 (WebCore::shouldEnableDeveloperExtras): 10134 * DumpRenderTree/win/DumpRenderTree.cpp: 10135 (shouldEnableDeveloperExtras): 10136 101372010-11-18 Sheriff Bot <webkit.review.bot@gmail.com> 10138 10139 Unreviewed, rolling out r72357. 10140 http://trac.webkit.org/changeset/72357 10141 https://bugs.webkit.org/show_bug.cgi?id=49784 10142 10143 It broke test-webkitpy tests since the patch didn't have the 10144 corresponding test update (Requested by kinuko on #webkit). 10145 10146 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 10147 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 10148 101492010-11-18 Mihai Parparita <mihaip@chromium.org> 10150 10151 Reviewed by Tony Chang. 10152 10153 Rebaseline server: add rebaseline queue 10154 https://bugs.webkit.org/show_bug.cgi?id=49763 10155 10156 Add a UI queue (a multi-item <select>) where tests to be baselined 10157 can be enqueued (also supports basic removal). A queue is used instead 10158 of immediately doing rebaselines since SCM operations can take a while. 10159 It's better to go through lots of tests quickly to mark them as 10160 needing rebaselining and then batch the SCM operations. 10161 10162 Also adds a simple log where results can be displayed. 10163 10164 * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: 10165 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: 10166 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: 10167 * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added. 10168 * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: 10169 * Scripts/webkitpy/tool/commands/rebaselineserver.py: 10170 101712010-11-18 Gavin Barraclough <barraclough@apple.com> 10172 10173 Reviewed by Oliver Hunt. 10174 10175 Bug 49708 - Stop recompiling functions to regenerate exception info. 10176 10177 Instead only hold info as necessary â keep divot info is the inspector 10178 is enabled, line number info is debugging or profiling, and handler 10179 info for functions with try/catch. 10180 10181 * DumpRenderTree/mac/DumpRenderTree.mm: 10182 (shouldEnableDeveloperExtras): 10183 - always enable the developer tools from DRT, to ensure we 10184 produce rich error messages on JavaScript exceptions. 10185 101862010-11-18 Kinuko Yasuda <kinuko@chromium.org> 10187 10188 Reviewed by Ojan Vafai. 10189 10190 [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests 10191 https://bugs.webkit.org/show_bug.cgi?id=49702 10192 10193 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 10194 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 10195 101962010-11-18 Dirk Pranke <dpranke@chromium.org> 10197 10198 Reviewed by Tony Chang. 10199 10200 new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes 10201 10202 Create the first version of the 'message_broker' package. This 10203 class will encapsulate all of the threading/multiprocessing and 10204 message-sending details for the communication between the 10205 'manager' object and the 'worker' objects. For the moment, it 10206 just holds some routines and tests for logging thread stacks. 10207 10208 There should be no functional changes in this patch, just moving stuff 10209 around. 10210 10211 https://bugs.webkit.org/show_bug.cgi?id=49707 10212 10213 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 10214 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed. 10215 * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added. 10216 * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added. 10217 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 10218 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 10219 102202010-11-18 Steve Falkenburg <sfalken@apple.com> 10221 10222 Reviewed by Adam Roben. 10223 10224 Remove leftover Windows Debug_Internal configurations 10225 https://bugs.webkit.org/show_bug.cgi?id=49758 10226 10227 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 10228 * DumpRenderTree/win/DumpRenderTree.vcproj: 10229 * DumpRenderTree/win/ImageDiff.vcproj: 10230 * MiniBrowser/MiniBrowser.vcproj: 10231 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 10232 * WebKitAPITest/WebKitAPITest.vcproj: 10233 * WebKitTestRunner/win/InjectedBundle.vcproj: 10234 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 10235 * WinLauncher/WinLauncher.vcproj: 10236 102372010-11-18 Adam Roben <aroben@apple.com> 10238 10239 Add three new Windows XP build slaves 10240 10241 Reviewed by Steve Falkenburg. 10242 10243 * BuildSlaveSupport/build.webkit.org-config/config.json: Added three 10244 new slaves, and added them to the Windows XP Debug (Tests) builder. 10245 102462010-11-18 Daniel Bates <dbates@rim.com> 10247 10248 Reviewed by Adam Roben. 10249 10250 update-webkit-support-libs should fall back to existing 10251 WebKitSupportLibrary version if there is no internet connectivity 10252 https://bugs.webkit.org/show_bug.cgi?id=49503 10253 10254 Fall back to existing support libraries (if present) when there is 10255 no internet connection. 10256 10257 Currently, update-webkit-support-libs dies with an "out-of-date" 10258 error when there is no internet connection because it cannot 10259 retrieve versioning information from developer.apple.com. Because 10260 update-webkit-support-libs fails, build-webkit fails. Instead, 10261 if there is no internet connection and the support libraries are 10262 present then we should warn the user and exit() with success so 10263 that build-webkit can work without an internet connection. 10264 10265 * Scripts/update-webkit-support-libs: 10266 102672010-11-18 Steve Falkenburg <sfalken@apple.com> 10268 10269 Reviewed by Adam Roben. 10270 10271 Debug_Internal Windows configuration is unnecessary, should be removed 10272 https://bugs.webkit.org/show_bug.cgi?id=49753 10273 10274 * DumpRenderTree/win/DumpRenderTree.cpp: 10275 * MiniBrowser/win/stdafx.h: 10276 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: 10277 * WebKitTestRunner/win/TestControllerWin.cpp: 10278 102792010-11-18 Steve Falkenburg <sfalken@apple.com> 10280 10281 Reviewed by Adam Roben. 10282 10283 Clean up vcproj errors 10284 https://bugs.webkit.org/show_bug.cgi?id=49741 10285 10286 * MiniBrowser/MiniBrowser.vcproj: 10287 * WebKitAPITest/WebKitAPITest.vcproj: 10288 * WebKitTestRunner/win/InjectedBundle.vcproj: 10289 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 10290 102912010-11-18 Hayato Ito <hayato@chromium.org> 10292 10293 Reviewed by Shinichiro Hamaji. 10294 10295 [NRWT] Fix a break of '--new-baseline' feature in pixel_test 10296 which is caused by r72249. 10297 10298 https://bugs.webkit.org/show_bug.cgi?id=49751 10299 10300 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 10301 103022010-11-18 Adam Roben <aroben@apple.com> 10303 10304 Implement layoutTestController.waitForPolicyDelegate on Windows 10305 10306 Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>. 10307 10308 Reviewed by Simon Fraser. 10309 10310 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 10311 (LayoutTestController::waitForPolicyDelegate): Implemented by porting 10312 code from LayoutTestControllerMac.mm. 10313 103142010-11-18 Hayato Ito <hayato@chromium.org> 10315 10316 Reviewed by Shinichiro Hamaji. 10317 10318 [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249. 10319 10320 https://bugs.webkit.org/show_bug.cgi?id=49740 10321 10322 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 10323 103242010-11-18 Tony Chang <tony@chromium.org> 10325 10326 Reviewed by Adam Barth. 10327 10328 run platform/chromium/plugins/refcount-leaks.html on all platforms 10329 https://bugs.webkit.org/show_bug.cgi?id=49485 10330 10331 Add PluginObject.testObjectCount which returns the number of allocated 10332 TestObjects. Add PluginObject.testCreateTestObject which allocates 10333 and returns a TestObject. 10334 10335 Add TestObject.refCount which returns the number of refs on the 10336 TestObject. 10337 10338 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 10339 (pluginGetProperty): 10340 (pluginInvoke): 10341 * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: 10342 (getTestObjectCount): 10343 (testAllocate): 10344 (testDeallocate): 10345 (testGetProperty): 10346 (testScriptObjectInvoke): Release a ref to a plugin object that was 10347 previously leaked. 10348 * DumpRenderTree/TestNetscapePlugIn/TestObject.h: 10349 103502010-11-17 Steve Falkenburg <sfalken@apple.com> 10351 10352 Reviewed by Adam Roben. 10353 10354 WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings 10355 https://bugs.webkit.org/show_bug.cgi?id=49711 10356 10357 * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added. 10358 * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added. 10359 * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added. 10360 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 10361 * record-memory-win/record-memory-win-common.vsprops: Added. 10362 * record-memory-win/record-memory-win.vcproj: 10363 103642010-11-18 Andras Becsi <abecsi@inf.u-szeged.hu> 10365 10366 Reviewed by Csaba Osztrogonác. 10367 10368 [Qt][WK2] Only add user agent strings to the list which aren't listed yet. 10369 10370 * MiniBrowser/qt/BrowserWindow.cpp: 10371 (BrowserWindow::updateUserAgentList): 10372 103732010-11-17 Adam Roben <aroben@apple.com> 10374 10375 Don't trigger Windows builds when chromium-win test results change 10376 10377 Reviewed by Mark Rowe. 10378 10379 * Scripts/webkitpy/common/config/build.py: 10380 (_should_file_trigger_build): Changed the regular expression used to 10381 search for directory names to only consider full directory names, 10382 rather than matching directory names where the string we care about is 10383 a suffix of the name. 10384 10385 * Scripts/webkitpy/common/config/build_unittest.py: 10386 (ShouldBuildTest): Added a test. 10387 103882010-11-17 Hayato Ito <hayato@chromium.org> 10389 10390 Reviewed by Shinichiro Hamaji. 10391 10392 Remove a uri member from TestInput class. 10393 10394 https://bugs.webkit.org/show_bug.cgi?id=49691 10395 10396 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 10397 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 10398 103992010-11-17 Adam Roben <aroben@apple.com> 10400 10401 Move FindSafari's settings into a vsprops file 10402 10403 Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file 10404 10405 Reviewed by Steve Falkenburg. 10406 10407 * FindSafari/FindSafari.vcproj: 10408 * FindSafari/FindSafariCommon.vsprops: Added. 10409 104102010-11-17 Adam Roben <aroben@apple.com> 10411 10412 Use a minimum font size of 0 in DRT on Windows 10413 10414 This is the Windows equivalent of r72164. 10415 10416 Rubber-stamped by Dave Hyatt. 10417 10418 * DumpRenderTree/win/DumpRenderTree.cpp: 10419 (resetDefaultsToConsistentValues): 10420 104212010-11-17 Dirk Pranke <dpranke@chromium.org> 10422 10423 Reviewed by Andreas Kling. 10424 10425 webkit-patch pretty-diff shouldn't need to be run from a checkout root in git 10426 https://bugs.webkit.org/show_bug.cgi?id=49639 10427 10428 * Scripts/webkitpy/common/checkout/scm.py: 10429 104302010-11-17 Mihai Parparita <mihaip@chromium.org> 10431 10432 Reviewed by Tony Chang. 10433 10434 Rebaseline server: add loupe for image diffs 10435 https://bugs.webkit.org/show_bug.cgi?id=49692 10436 10437 Add a loupe (magnifiying glass) for inspecting image diffs. Shows an 10438 enlarged area of the expected, actual and diff images side by side. 10439 10440 * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: 10441 * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added. 10442 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: 10443 * Scripts/webkitpy/tool/commands/rebaselineserver.py: 10444 104452010-11-17 Steve Falkenburg <sfalken@apple.com> 10446 10447 Reviewed by Adam Roben. 10448 10449 WebKitLauncherWin should use vsprops for shared build settings 10450 https://bugs.webkit.org/show_bug.cgi?id=49696 10451 10452 * WebKitLauncherWin/WebKitLauncherWin.vcproj: 10453 * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added. 10454 104552010-11-17 Steve Falkenburg <sfalken@apple.com> 10456 10457 Reviewed by Adam Roben. 10458 10459 WinLauncher should use vsprops for shared build settings 10460 https://bugs.webkit.org/show_bug.cgi?id=49695 10461 10462 * WinLauncher/WinLauncher.cpp: 10463 (_tWinMain): 10464 (PrintView): 10465 (WndProc): 10466 (MyEditProc): 10467 * WinLauncher/WinLauncher.vcproj: 10468 * WinLauncher/WinLauncherCommon.vsprops: Added. 10469 104702010-11-17 Steve Falkenburg <sfalken@apple.com> 10471 10472 Delete unused file unintentionally added in last change. 10473 10474 * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed. 10475 104762010-11-17 Steve Falkenburg <sfalken@apple.com> 10477 10478 Reviewed by Adam Roben. 10479 10480 DumpRenderTree on Windows should use a vsprops file for shared project settings 10481 https://bugs.webkit.org/show_bug.cgi?id=49690 10482 10483 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 10484 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added. 10485 * DumpRenderTree/win/DumpRenderTree.vcproj: 10486 * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added. 10487 * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added. 10488 * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added. 10489 * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added. 10490 * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added. 10491 * DumpRenderTree/win/ImageDiff.vcproj: 10492 * DumpRenderTree/win/ImageDiffCommon.vsprops: Added. 10493 104942010-11-17 Hayato Ito <hayato@chromium.org> 10495 10496 Refactor TestTypeBase.compare_output(). 10497 10498 Introduce a TestOutput class and update compare_output() of each test 10499 types so that they can take both actual and expected TestOutput objects. 10500 10501 https://bugs.webkit.org/show_bug.cgi?id=49431 10502 10503 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 10504 * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added. 10505 * Scripts/webkitpy/layout_tests/port/base.py: 10506 * Scripts/webkitpy/layout_tests/port/chromium.py: 10507 * Scripts/webkitpy/layout_tests/port/dryrun.py: 10508 * Scripts/webkitpy/layout_tests/port/test.py: 10509 * Scripts/webkitpy/layout_tests/port/webkit.py: 10510 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 10511 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 10512 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 10513 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 10514 105152010-11-17 Adam Roben <aroben@apple.com> 10516 10517 Make each Windows Test builder use the same OS for all its slaves 10518 10519 Currently each WebKit1 Windows Test builder has one Windows XP slave 10520 and one Windows 7 slave. Having different OSes in a single builder 10521 meant that the builders would alternate between red and green when 10522 there were OS-specific failures. 10523 10524 Fixes <http://webkit.org/b/49688> Windows Test builders alternate 10525 between red and green because of multiple OS versions 10526 10527 Reviewed by Mark Rowe. 10528 10529 * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed 10530 "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows 10531 Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release 10532 (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the 10533 builders for the two WebKit1 builders so that they would all use the 10534 appropriate OS. 10535 105362010-11-17 James Robinson <jamesr@chromium.org> 10537 10538 Reviewed by Dan Bernstein. 10539 10540 [chromium] Set minimum font size to 0 for DRT 10541 https://bugs.webkit.org/show_bug.cgi?id=49677 10542 10543 Followup for http://trac.webkit.org/changeset/72141. 10544 10545 Test: http/tests/misc/acid3.html 10546 10547 * DumpRenderTree/chromium/WebPreferences.cpp: 10548 (WebPreferences::reset): 10549 105502010-11-17 Andras Becsi <abecsi@webkit.org> 10551 10552 Unreviewed build fix. 10553 10554 [Qt] Add missing file I forgot in r72220. 10555 10556 * MiniBrowser/MiniBrowser.qrc: Added. 10557 105582010-11-17 Andras Becsi <abecsi@webkit.org> 10559 10560 Reviewed by Andreas Kling. 10561 10562 [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser. 10563 https://bugs.webkit.org/show_bug.cgi?id=49627 10564 10565 Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser. 10566 10567 * MiniBrowser/MiniBrowser.qrc: Added. 10568 Add it here to prevent qmake from detecting it 10569 since it needs to be copied to the build directory. 10570 * MiniBrowser/qt/BrowserWindow.cpp: 10571 (BrowserWindow::BrowserWindow): 10572 (BrowserWindow::updateUserAgentList): 10573 (BrowserWindow::showUserAgentDialog): 10574 * MiniBrowser/qt/BrowserWindow.h: 10575 * MiniBrowser/qt/MiniBrowser.pro: 10576 105772010-11-17 Adam Roben <aroben@apple.com> 10578 10579 Make changes to the Mac WebKit2 Skipped file trigger Windows builds 10580 10581 We use that file on Windows! 10582 10583 Fixes <http://webkit.org/b/49643> Changes to 10584 LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't 10585 10586 Reviewed by Steve Falkenburg. 10587 10588 * Scripts/webkitpy/common/config/build.py: 10589 (_should_file_trigger_build): Added the mac-wk2 directory and make it 10590 trigger builds on SnowLeopard and Windows. 10591 10592 * Scripts/webkitpy/common/config/build_unittest.py: 10593 (ShouldBuildTest.test_should_build): Added a test. 10594 105952010-11-17 Satish Sampath <satish@chromium.org> 10596 10597 Reviewed by Jeremy Orlow. 10598 10599 Clear the speech input mock explicitly before each test. 10600 https://bugs.webkit.org/show_bug.cgi?id=49660 10601 10602 * DumpRenderTree/chromium/LayoutTestController.cpp: 10603 (LayoutTestController::setMockSpeechInputResult): 10604 * DumpRenderTree/chromium/LayoutTestController.h: 10605 * DumpRenderTree/chromium/WebViewHost.cpp: 10606 (WebViewHost::speechInputController): 10607 (WebViewHost::reset): Invoke speech input mock's clearResults method. 10608 * DumpRenderTree/chromium/WebViewHost.h: 10609 (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController. 10610 106112010-11-17 Alexander Pavlov <apavlov@chromium.org> 10612 10613 Unreviewed, specify IRC nickname in committers.py. 10614 10615 * Scripts/webkitpy/common/config/committers.py: 10616 106172010-11-17 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 10618 10619 Reviewed by Tony Chang. 10620 10621 [NRWT] Make http locking similar to perl implementation 10622 https://bugs.webkit.org/show_bug.cgi?id=49187 10623 10624 * Scripts/webkitpy/common/system/file_lock.py: Added. 10625 * Scripts/webkitpy/common/system/file_lock_unittest.py: Added. 10626 * Scripts/webkitpy/layout_tests/port/http_lock.py: 10627 106282010-11-17 MORITA Hajime <morrita@google.com> 10629 10630 Reviewed by Kent Tamura. 10631 10632 [Chromium][DRT] EventSender.contextClick() should aware spellchecking 10633 https://bugs.webkit.org/show_bug.cgi?id=49366 10634 10635 - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries 10636 according to the spellchecker suggestion 10637 - MockSpellCheck: add fillSuggestionList to provide fake suggestions. 10638 10639 test_expectations.txt will be changed after this change is ported to test_shell. 10640 10641 * DumpRenderTree/chromium/EventSender.cpp: 10642 (makeMenuItemStringsFor): 10643 (EventSender::contextClick): 10644 * DumpRenderTree/chromium/MockSpellCheck.cpp: 10645 (MockSpellCheck::fillSuggestionList): 10646 (MockSpellCheck::initializeIfNeeded): 10647 * DumpRenderTree/chromium/MockSpellCheck.h: 10648 * DumpRenderTree/chromium/WebViewHost.cpp: 10649 (WebViewHost::mockSpellCheck): 10650 * DumpRenderTree/chromium/WebViewHost.h: 10651 106522010-11-16 Dave Hyatt <hyatt@apple.com> 10653 10654 Reviewed by Sam Weinig. 10655 10656 Make sure the pref for minimum font size is just explicitly set to 0 every time, 10657 since the bots have 1 stuck in their plist otherwise. 10658 10659 * DumpRenderTree/mac/DumpRenderTree.mm: 10660 (resetDefaultsToConsistentValues): 10661 106622010-11-16 Mihai Parparita <mihaip@chromium.org> 10663 10664 Reviewed by Tony Chang. 10665 10666 Rebaseline server: compute diffs client-side 10667 https://bugs.webkit.org/show_bug.cgi?id=49640 10668 10669 The image diff output from the DRT is pretty bad on some ports (at 10670 least the Mac one), so it's better to compute diffs on the client by 10671 using <canvas>. 10672 10673 * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: 10674 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: 10675 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: 10676 106772010-11-16 Mihai Parparita <mihaip@chromium.org> 10678 10679 Reviewed by Tony Chang. 10680 10681 Rebaseline server: display test results 10682 https://bugs.webkit.org/show_bug.cgi?id=49626 10683 10684 Adds basic result display to the rebaseline server. On the Python side 10685 this involves: 10686 - Parsing the unexpected_results.json into a dictionary. 10687 - Serving it as JSON under /results.json. 10688 (the JSON -> dict -> JSON transform isn't strictly necessary right now, 10689 but I'll need to have access to the parsed results on the Python side 10690 for follow-up changes). 10691 10692 On the web UI side this adds: 10693 - Markup for display image and text results (expected, actual, diff), 10694 and JS for populating it. 10695 - Markup for breaking down test results by failure type and directory, 10696 and JS for populating it. 10697 10698 * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: 10699 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: 10700 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: 10701 * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added. 10702 * Scripts/webkitpy/tool/commands/rebaselineserver.py: 10703 107042010-11-16 Dirk Pranke <dpranke@chromium.org> 10705 10706 Reviewed by Ojan Vafai. 10707 10708 See Chromium issue http://codereview.chromium.org/5133001/ - we 10709 are modifying the build bots to pass in the builder name with 10710 the "GPU" string appended instead of appending it in the code. 10711 10712 https://bugs.webkit.org/show_bug.cgi?id=49636 10713 10714 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 10715 107162010-11-16 Steve Falkenburg <sfalken@apple.com> 10717 10718 Reviewed by Adam Roben. 10719 10720 Disable LTCG for Windows Release builds. Add new Release_LTCG configuration. 10721 https://bugs.webkit.org/show_bug.cgi?id=49632 10722 10723 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 10724 * DumpRenderTree/win/DumpRenderTree.vcproj: 10725 * DumpRenderTree/win/ImageDiff.vcproj: 10726 * MiniBrowser/MiniBrowser.vcproj: 10727 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 10728 * WebKitLauncherWin/WebKitLauncherWin.vcproj: 10729 * WebKitTestRunner/win/InjectedBundle.vcproj: 10730 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 10731 * WinLauncher/WinLauncher.vcproj: 10732 * record-memory-win/record-memory-win.vcproj: 10733 107342010-11-16 Dirk Pranke <dpranke@chromium.org> 10735 10736 Reviewed by Ojan Vafai. 10737 10738 new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread 10739 10740 Rename the TestInfo class to TestInput to be clearer about its 10741 function, and move the checksum-reading code into dump_render_tree_thread 10742 to avoid cross-thread access. 10743 10744 https://bugs.webkit.org/show_bug.cgi?id=49573 10745 10746 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 10747 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 10748 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 10749 107502010-11-16 Dave Hyatt <hyatt@apple.com> 10751 10752 Fix bustage. Remove the minimum font size pref setting in DumpRenderTree. 10753 10754 * DumpRenderTree/mac/DumpRenderTree.mm: 10755 (resetDefaultsToConsistentValues): 10756 107572010-11-16 Stephanie Lewis <slewis@apple.com> 10758 10759 Reviewed by Geoff Garen. 10760 10761 <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests 10762 10763 Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 10764 for every WebView, and the WebKit API doesn't support that ownership model. 10765 10766 I also fixed a leak in setMockDeviceOrientation by adding a missing release. 10767 10768 * DumpRenderTree/mac/DumpRenderTree.mm: 10769 (createWebViewAndOffscreenWindow): 10770 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 10771 (LayoutTestController::setMockDeviceOrientation): 10772 107732010-11-16 Dirk Pranke <dpranke@chromium.org> 10774 10775 Reviewed by Ojan Vafai. 10776 10777 new-run-webkit-tests: log the process id in --verbose mode 10778 10779 As part of the switch to multi-process mode, we should log the 10780 process id when running w/ --verbose. 10781 10782 https://bugs.webkit.org/show_bug.cgi?id=49571 10783 10784 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 10785 107862010-11-16 Adam Roben <aroben@apple.com> 10787 10788 Only trigger Windows builds when files that we actually use on Windows 10789 are changed 10790 10791 A new Scheduler subclass, PlatformSpecificScheduler, has been added. 10792 It uses the new webkitpy.common.config.build module to determine 10793 whether a particular change should trigger a build on a particular 10794 platform. The Windows builders have been switched to use a 10795 PlatformSpecificScheduler. 10796 10797 The logic to determine whether or not a particular change should 10798 trigger a build on a given platform has only been implemented/tested 10799 for Windows. I tried to make it easy to add more platforms in the 10800 future, but I don't have enough familiarity with all platforms to be 10801 able to implement it for them. 10802 10803 Fixes <http://webkit.org/b/49407> Windows builders kick off builds for 10804 lots irrelevant changes (e.g., rebaselining Chromium test results) 10805 10806 Reviewed by Eric Seidel. 10807 10808 * BuildSlaveSupport/build.webkit.org-config/config.json: Use a 10809 PlatformSpecificScheduler for the Windows builders. 10810 10811 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 10812 (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets 10813 up a ChangeFilter that filters to our branch and will call through to 10814 our filter method, and calls up to our base class. 10815 (PlatformSpecificScheduler.filter): Calls through to 10816 build.should_build to find out whether we should trigger a build for 10817 this change. 10818 10819 * Scripts/webkitpy/common/net/build.py: Added. 10820 (_should_file_trigger_build): Uses a set of directories and regexp 10821 patterns to determine whether the given file should trigger a build on 10822 the given platform. As mentioned earlier, this has only been 10823 implemented for Windows, though I did try to make some guesses about 10824 other platforms. 10825 (should_build): Returns true if any of the files should trigger a 10826 build on the given platform. 10827 10828 * Scripts/webkitpy/common/net/build_unittest.py: Added. 10829 (ShouldBuildTest.test_should_build): Does some basic testing to make 10830 sure we're triggering builds for the right files. It only tests 10831 Windows for now, though I tried to make some guesses about other 10832 platforms. 10833 108342010-11-16 Simon Hausmann <simon.hausmann@nokia.com> 10835 10836 Reviewed by Andreas Kling. 10837 10838 [Qt] Remove synchronous QWebPage::checkPermissions signal 10839 https://bugs.webkit.org/show_bug.cgi?id=46810 10840 10841 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 10842 (WebCore::WebPage::WebPage): 10843 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 10844 (LayoutTestController::grantDesktopNotificationPermission): When granting 10845 permission, grant it directly on the QWebPage/Frame, that will remember it. 10846 * QtTestBrowser/webpage.cpp: 10847 (WebPage::WebPage): 10848 * QtTestBrowser/webpage.h: 10849 10850 108512010-11-16 Andras Becsi <abecsi@inf.u-szeged.hu> 10852 10853 Reviewed by Csaba Osztrogonác. 10854 10855 [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController. 10856 10857 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 10858 (LayoutTestController::reset): 10859 * DumpRenderTree/qt/LayoutTestControllerQt.h: 10860 (LayoutTestController::isPrinting): 10861 (LayoutTestController::setPrinting): 10862 108632010-11-16 Balazs Kelemen <kbalazs@webkit.org> 10864 10865 Reviewed by Andreas Kling. 10866 10867 [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser 10868 https://bugs.webkit.org/show_bug.cgi?id=49587 10869 10870 * MiniBrowser/qt/BrowserView.cpp: 10871 (BrowserView::BrowserView): Added BackingStoreType 10872 argument to ctor. Propagating it to the QGraphicsWKView. 10873 * MiniBrowser/qt/BrowserView.h: 10874 * MiniBrowser/qt/BrowserWindow.cpp: 10875 (BrowserWindow::BrowserWindow): 10876 (BrowserWindow::newWindow): Create the new BrowserWindow 10877 with the same BackingStoreType that this instance has. 10878 * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member. 10879 * MiniBrowser/qt/main.cpp: 10880 (main): Use tiled backing store if got -tiled command line argument. 10881 Avoid redundant copy of command line args. 10882 108832010-11-16 John Knottenbelt <jknotten@chromium.org> 10884 10885 Reviewed by Jeremy Orlow. 10886 10887 Move DeviceOrientationClientMock from LayoutTestController to WebViewHost. 10888 https://bugs.webkit.org/show_bug.cgi?id=48506 10889 10890 This ensures that there is one mock per page WebView / WebViewHost. This is a 10891 design constraint of the DeviceOrientationClientMock because the m_controller 10892 field can only store a pointer to a single instance of the corresponding 10893 DeviceOrientationController. 10894 10895 Test: fast/dom/DeviceOrientation/no-page-cache.html 10896 10897 * DumpRenderTree/chromium/LayoutTestController.cpp: 10898 (LayoutTestController::setMockDeviceOrientation): 10899 (LayoutTestController::deviceOrientationClientMock): 10900 * DumpRenderTree/chromium/LayoutTestController.h: 10901 * DumpRenderTree/chromium/WebViewHost.cpp: 10902 (WebViewHost::deviceOrientationClientMock): 10903 (WebViewHost::deviceOrientationClient): 10904 (WebViewHost::reset): 10905 * DumpRenderTree/chromium/WebViewHost.h: 10906 109072010-11-15 Andras Becsi <abecsi@webkit.org> 10908 10909 Reviewed by Andreas Kling. 10910 10911 [Qt][WK2] Avoid polling in WebKitTestRunner. 10912 https://bugs.webkit.org/show_bug.cgi?id=49542 10913 10914 Make the WK2 testing session about 10-15% faster and decrease random flakiness 10915 resulting from timing skew by removing the millisecond polling from TestControllerQt. 10916 10917 * WebKitTestRunner/TestController.cpp: 10918 (WTR::TestController::didFinishLoadForFrame): 10919 * WebKitTestRunner/TestController.h: 10920 * WebKitTestRunner/TestInvocation.cpp: 10921 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 10922 * WebKitTestRunner/mac/TestControllerMac.mm: 10923 (WTR::TestController::notifyDone): Add method stub. 10924 * WebKitTestRunner/qt/TestControllerQt.cpp: 10925 (WTR::TestControllerRunLoop::instance): 10926 (WTR::TestControllerRunLoop::start): 10927 (WTR::TestControllerRunLoop::stop): 10928 (WTR::TestControllerRunLoop::TestControllerRunLoop): 10929 (WTR::TestControllerRunLoop::timerEvent): 10930 (WTR::TestController::notifyDone): 10931 (WTR::TestController::platformRunUntil): 10932 * WebKitTestRunner/win/TestControllerWin.cpp: 10933 (WTR::TestController::notifyDone): Add method stub. 10934 109352010-11-15 Darin Adler <darin@apple.com> 10936 10937 * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore. 10938 109392010-11-15 Benjamin Poulain <benjamin.poulain@nokia.com> 10940 10941 Reviewed by Andreas Kling. 10942 10943 [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser 10944 https://bugs.webkit.org/show_bug.cgi?id=49544 10945 10946 Add the shortcut to BrowserWindow. 10947 10948 * MiniBrowser/qt/BrowserWindow.cpp: 10949 (BrowserWindow::BrowserWindow): 10950 (BrowserWindow::openLocation): 10951 * MiniBrowser/qt/BrowserWindow.h: 10952 109532010-11-14 David Levin <levin@chromium.org> 10954 10955 Reviewed by Daniel Bates. 10956 10957 check-webkit-style should detect PassRefPtr usage in functions. 10958 https://bugs.webkit.org/show_bug.cgi?id=49513 10959 10960 * Scripts/webkitpy/style/checkers/cpp.py: 10961 (check_for_function_lengths): Revert a comment change that I 10962 accidentally made in r71986. 10963 (check_pass_ptr_usage): Added the code to do the check. 10964 (process_line): Added the call to check_pass_ptr_usage. 10965 (CppChecker): Added the new error category. 10966 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 10967 (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for 10968 testing purposes. 10969 (PassPtrTest::*): The class/functions to unit test the new 10970 functionality. 10971 109722010-11-14 David Levin <levin@chromium.org> 10973 10974 Reviewed by Shinichiro Hamaji. 10975 10976 check-webkit-style function detection and the line count style checks should be separate. 10977 https://bugs.webkit.org/show_bug.cgi?id=49512 10978 10979 * Scripts/webkitpy/style/checkers/cpp.py: Do the separation. 10980 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to 10981 call the detection function and fix line counts in two places now that 10982 the code really only counts the lines in the body of the function. 10983 109842010-11-14 Andreas Kling <kling@webkit.org> 10985 10986 Reviewed by Antonio Gomes. 10987 10988 http/tests/plugins tests print "Unhandled variable" to stderr under Qt 10989 https://bugs.webkit.org/show_bug.cgi?id=33438 10990 10991 Stifle "Unhandled variable" warning to match what the other 10992 TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp 10993 simply returns NPERR_GENERIC_ERROR for unhandled variables.) 10994 10995 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 10996 (webkit_test_plugin_get_value): 10997 109982010-11-13 David Levin <levin@chromium.org> 10999 11000 Reviewed by Eric Seidel. 11001 11002 check-webkit-style function detection crashes on functions in templates. 11003 https://bugs.webkit.org/show_bug.cgi?id=49504 11004 11005 For example "template <bool shouldClose(const Element*)>". 11006 11007 * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out. 11008 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex 11009 function detection test to expose this issue. 11010 110112010-11-12 David Levin <levin@chromium.org> 11012 11013 Reviewed by Shinichiro Hamaji. 11014 11015 check-webkit-style function detection doesn't detect indented functions declaractions. 11016 https://bugs.webkit.org/show_bug.cgi?id=49446 11017 11018 Indented function declarations occur inside class definitions, so 11019 they are a pretty common (and worth detecting). 11020 11021 * Scripts/webkitpy/style/checkers/cpp.py: 11022 Changed regex to allow indentation. 11023 Changed the function start detection to only happen when not in a 11024 function. 11025 Changed function end detection to work based on matching braces 11026 instead of finding a close brace at the beginning of the line. 11027 Fixed close_expression to do what it says when it doesn't find 11028 the close. 11029 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test. 11030 110312010-11-12 Daniel Bates <dbates@rim.com> 11032 11033 Rubber-stamped by Nikolas Zimmermann. 11034 11035 Make do-file-rename rename files in the directory WebKit2. 11036 11037 This also makes the list of searched directories in do-file-rename 11038 consistent with the list of searched directories in the script do-webcore-rename. 11039 11040 * Scripts/do-file-rename: 11041 110422010-11-12 Dirk Pranke <dpranke@chromium.org> 11043 11044 Reviewed by James Robinson. 11045 11046 Attempt yet again to land the fix for bug 49360 (respecting 11047 set-webkit-configuration). We need to handle the cases where 11048 trying to run webkit-build-directory to find out where the 11049 default configuration might be fails (that shows up on some 11050 Chromium bots that apparently don't have perl installed). 11051 11052 https://bugs.webkit.org/show_bug.cgi?id=49360 11053 11054 * Scripts/webkitpy/layout_tests/port/config.py: 11055 * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added. 11056 * Scripts/webkitpy/layout_tests/port/config_unittest.py: 11057 110582010-11-12 Mihai Parparita <mihaip@chromium.org> 11059 11060 Reviewed by Adam Barth. 11061 11062 webkit-patch land logs commit message twice 11063 https://bugs.webkit.org/show_bug.cgi?id=49482 11064 11065 Don't log the comment that's used by bugzilla.close_bug_as_fixed, since 11066 that's just the commit message, which we now output following the 11067 actual commit. 11068 11069 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 11070 110712010-11-12 Tony Chang <tony@chromium.org> 11072 11073 Reviewed by Adam Barth. 11074 11075 run platform/chromium/plugins/script-object-invoke.html on all platforms 11076 https://bugs.webkit.org/show_bug.cgi?id=49280 11077 11078 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 11079 (testScriptObjectInvoke): 11080 (pluginInvoke): 11081 110822010-11-12 Mihai Parparita <mihaip@chromium.org> 11083 11084 Reviewed by Adam Barth. 11085 11086 webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch 11087 https://bugs.webkit.org/show_bug.cgi?id=49471 11088 11089 Right now there's no indication of a successful commit. 11090 11091 * Scripts/webkitpy/tool/commands/download_unittest.py: 11092 * Scripts/webkitpy/tool/steps/commit.py: 11093 110942010-11-12 Kinuko Yasuda <kinuko@chromium.org> 11095 11096 Reviewed by Ojan Vafai. 11097 11098 Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests 11099 https://bugs.webkit.org/show_bug.cgi?id=49354 11100 11101 Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py. 11102 11103 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 11104 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 11105 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: 11106 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 11107 111082010-11-12 Tony Chang <tony@chromium.org> 11109 11110 Reviewed by Kent Tamura. 11111 11112 [chromium] Load a blank page when closing DRT WebViewHosts 11113 https://bugs.webkit.org/show_bug.cgi?id=49417 11114 11115 In test_shell, when we close a window, we first load about:blank 11116 and run GC to fire the destruction logic of the page. In test_shell, 11117 this happens in ~TestShell. In DRT, we manage virtual windows as 11118 WebViewHosts, so we need to replicate this logic in ~WebViewHost. 11119 11120 Managing focus is a bit trickier, since normally you would get window 11121 events to reset the focus to the right window. We do it manually 11122 instead. 11123 11124 This fixes 2 plugin tests on DRT. 11125 11126 * DumpRenderTree/chromium/TestShell.cpp: 11127 (TestShell::~TestShell): Move window close logic to ~WebViewHost. 11128 (TestShell::closeWindow): Move widget close() to WVH destructor and 11129 manage focus manually. 11130 (TestShell::closeRemainingWindows): Comment typo. 11131 * DumpRenderTree/chromium/WebViewHost.cpp: 11132 (WebViewHost::closeWidget): 11133 (invokeCloseWidget): 11134 (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches 11135 test_shell). 11136 (WebViewHost::~WebViewHost): 11137 * DumpRenderTree/chromium/WebViewHost.h: 11138 111392010-11-12 David Levin <levin@chromium.org> 11140 11141 Reviewed by Adam Barth. 11142 11143 cpp.py needs some tidying. 11144 https://bugs.webkit.org/show_bug.cgi?id=49443 11145 11146 * Scripts/webkitpy/style/checkers/cpp.py: 11147 Fix parameter ordering for iteratively_replace_matches_with_char 11148 to mirror other similar functions (and improved comments, etc.) 11149 Also, use a python-ism (for/else) to get rid of a variable that 11150 was there to determine if something had been found in the loop. 11151 111522010-11-12 Robert Kroeger <rjkroege@chromium.org> 11153 11154 Reviewed by James Robinson. 11155 11156 [Chromium/DRT] Make EventSendingController send complete touch events. 11157 https://bugs.webkit.org/show_bug.cgi?id=49285 11158 11159 * DumpRenderTree/chromium/EventSender.cpp: 11160 (EventSender::addTouchPoint): 11161 (EventSender::updateTouchPoint): 11162 (EventSender::sendCurrentTouchEvent): 11163 111642010-11-12 Mihai Parparita <mihaip@chromium.org> 11165 11166 Unreviewed rollout of r71858. 11167 11168 Rollout out r71858 since it breaks new-run-webkit-httpd as used by the 11169 NaCl tests. 11170 11171 * Scripts/webkitpy/layout_tests/port/config.py: 11172 * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed. 11173 * Scripts/webkitpy/layout_tests/port/config_unittest.py: 11174 111752010-11-12 Benjamin Poulain <benjamin.poulain@nokia.com> 11176 11177 Reviewed by Kenneth Rohde Christiansen. 11178 11179 [Qt] TestController::runUntil doesn't honor the timeout parameter 11180 https://bugs.webkit.org/show_bug.cgi?id=48941 11181 11182 Implement the missing timeout of WebKitTestRunner for Qt. 11183 11184 A QElapsedTimer has been added to RunUntilConditionLoop in order 11185 to measure how long the loop has been running. When the timer 11186 is bigger or equal than the timeout, the loop ends even if the 11187 condition is not met. 11188 11189 * WebKitTestRunner/qt/TestControllerQt.cpp: 11190 (WTR::RunUntilConditionLoop::start): 11191 (WTR::RunUntilConditionLoop::run): 11192 (WTR::RunUntilConditionLoop::timerEvent): 11193 (WTR::TestController::platformRunUntil): 11194 111952010-11-11 David Levin <levin@chromium.org> 11196 11197 Reviewed by Shinichiro Hamaji. 11198 11199 check-webkit-style function detection doesn't handle templates with spaces. 11200 https://bugs.webkit.org/show_bug.cgi?id=49427 11201 11202 * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when 11203 finding the function name. 11204 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a 11205 template with a space. 11206 112072010-11-11 Ademar de Souza Reis Jr <ademar.reis@openbossa.org> 11208 11209 Reviewed by Shinichiro Hamaji. 11210 11211 Enable check-webkit-style on Qt files 11212 https://bugs.webkit.org/show_bug.cgi?id=48322 11213 11214 Adding exception for _q_... private slots and 11215 ..._data() methods in tests 11216 11217 * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions 11218 * Scripts/webkitpy/style/checker_unittest.py: improve unittests 11219 112202010-11-11 David Levin <levin@chromium.org> 11221 11222 Reviewed by Shinichiro Hamaji. 11223 11224 check-webkit-style function detection doesn't work for templates and destructors. 11225 https://bugs.webkit.org/show_bug.cgi?id=49425 11226 11227 * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors. 11228 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue. 11229 112302010-11-11 Joone Hur <joone@kldp.org> 11231 11232 Reviewed by Antonio Gomes. 11233 11234 [GTK][DRT] Implement LayoutTestController::nodesFromRect 11235 https://bugs.webkit.org/show_bug.cgi?id=46598 11236 11237 Support nodesFromRect in DRT 11238 11239 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 11240 (LayoutTestController::nodesFromRect): 11241 112422010-11-11 MORITA Hajime <morrita@google.com> 11243 11244 Reviewed by Kent Tamura. 11245 11246 editing/selection/context-menu-on-text.html fails on chromium 11247 https://bugs.webkit.org/show_bug.cgi?id=45898 11248 11249 Enhance Chromium's EventSender::contextClick() to return 11250 array of menu strings. The implementation incomplete because 11251 Although actual context menu is implemented by the browser, 11252 it reflects editability of underlying context thus makes 11253 context-menu-on-text.html passed. 11254 11255 * DumpRenderTree/chromium/EventSender.cpp: 11256 (makeMenuItemStringsFor): Added. 11257 (EventSender::contextClick): Now returns array of menu strings. 11258 * DumpRenderTree/chromium/WebViewHost.cpp: 11259 (WebViewHost::showContextMenu): Now storing given WebContextMenuData object. 11260 (WebViewHost::clearContextMenuData): Added. 11261 (WebViewHost::lastContextMenuData): Added. 11262 * DumpRenderTree/chromium/WebViewHost.h: 11263 112642010-11-11 Dirk Pranke <dpranke@chromium.org> 11265 11266 Unreviewed, build fix. 11267 11268 fix build breakage caused by fix for bug 49380 (r71858). 11269 11270 config_standalone needs to ensure that the packages it needs are 11271 in sys.path. 11272 11273 https://bugs.webkit.org/show_bug.cgi?id=49419 11274 11275 * Scripts/webkitpy/layout_tests/port/config_standalone.py: 11276 112772010-11-11 Dirk Pranke <dpranke@chromium.org> 11278 11279 Reviewed by Adam Roben. 11280 11281 Fix NRWT to respect set-webkit-configuration again :( 11282 11283 This change fixes a typo in config.py that was causing the wrong 11284 value to be read initially and us never actually looking into 11285 the filesystem to get the default configuration. 11286 11287 * Scripts/webkitpy/layout_tests/port/config.py: 11288 * Scripts/webkitpy/layout_tests/port/config_standalone.py: 11289 * Scripts/webkitpy/layout_tests/port/config_unittest.py: 11290 112912010-11-11 Eric Seidel <eric@webkit.org> 11292 11293 Reviewed by Adam Barth. 11294 11295 Split out Bug, Attachment and CommitterValidator from bugzilla.py 11296 https://bugs.webkit.org/show_bug.cgi?id=49403 11297 11298 CommitterValidator really had nothing to do with bugzilla.py. 11299 I've put it next to committers.py for now since its rather tied to that file. 11300 11301 * Scripts/webkitpy/common/config/committervalidator.py: Added. 11302 * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added. 11303 * Scripts/webkitpy/common/net/bugzilla/__init__.py: 11304 * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added. 11305 * Scripts/webkitpy/common/net/bugzilla/bug.py: Added. 11306 * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added. 11307 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 11308 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: 11309 * Scripts/webkitpy/tool/bot/feeders.py: 11310 * Scripts/webkitpy/tool/commands/queues.py: 11311 113122010-11-11 Dirk Pranke <dpranke@chromium.org> 11313 11314 Reviewed by Eric Seidel. 11315 11316 fix missing 'pid' argument for http lockfile checking on win32 11317 https://bugs.webkit.org/show_bug.cgi?id=49363 11318 11319 * Scripts/webkitpy/common/system/executive.py: 11320 113212010-11-11 Eric Seidel <eric@webkit.org> 11322 11323 Rubber-stamped by Adam Barth. 11324 11325 Move bugzilla.py into its own module in preparation for splitting one-file-per-class 11326 https://bugs.webkit.org/show_bug.cgi?id=49402 11327 11328 * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added. 11329 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py. 11330 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py. 11331 113322010-11-10 Chris Guillory <chris.guillory@google.com> 11333 11334 Reviewed by Chris Fleizach. 11335 11336 Use IAccessibleComparable to compare accessibility objects. 11337 https://bugs.webkit.org/show_bug.cgi?id=49118 11338 11339 * DumpRenderTree/AccessibilityUIElement.cpp: 11340 (AccessibilityUIElement::isEqual): 11341 * DumpRenderTree/AccessibilityUIElement.h: 11342 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 11343 (comparableObject): 11344 (AccessibilityUIElement::isEqual): 11345 113462010-11-10 Csaba Osztrogonác <ossy@webkit.org> 11347 11348 Reviewed by David Hyatt. 11349 11350 HTML5 Ruby support should be mandatory feature 11351 https://bugs.webkit.org/show_bug.cgi?id=49272 11352 11353 Remove Ruby as optional feature. 11354 11355 * Scripts/build-webkit: 11356 113572010-11-10 Adam Roben <aroben@apple.com> 11358 11359 Print VC++ Express build logs in the same order that the projects are 11360 built 11361 11362 Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs 11363 in an unhelpful order 11364 11365 Reviewed by Eric Seidel. 11366 11367 * Scripts/print-vse-failure-logs: 11368 (PrintVisualStudioExpressLogs._build_order): Added. Uses 11369 print-msvc-project-dependencies to figure out the order in which 11370 projects are built. 11371 (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs 11372 based on their build order and project name. 11373 (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the 11374 scripts directory from here... 11375 (PrintVisualStudioExpressLogs._scripts_directory): ...to here. 11376 (PrintVisualStudioExpressLogs.main): Sort the logs before printing 11377 them. 11378 113792010-11-10 Adam Roben <aroben@apple.com> 11380 11381 Only print the interesting text from VC++ Express build logs 11382 11383 Fixes <http://webkit.org/b/49325> It's hard to find the interesting 11384 output from print-vse-failure-logs 11385 11386 Reviewed by Eric Seidel. 11387 11388 * Scripts/print-vse-failure-logs: Removed unnecessary os.path import, 11389 added newly-required imports. Removed a comment that was essentially a 11390 FIXME, and is now fixed. 11391 (PrintVisualStudioExpressLogs._relevant_text): Added. Uses 11392 BeautifulSoup to extract the relevant text from the build log. 11393 (PrintVisualStudioExpressLogs.main): Only print the relevant text. 11394 113952010-11-09 Mihai Parparita <mihaip@chromium.org> 11396 11397 Reviewed by Tony Chang. 11398 11399 [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT 11400 https://bugs.webkit.org/show_bug.cgi?id=49286 11401 11402 The tests in http/tests/security/XFrameOptions started to fail after 11403 r71297, since it changed the WebViewHost::assignIdentifierToRequest 11404 logic to always assign identifiers to requests, even if we're not going 11405 to be dumping resource load callbacks at that point. These tests 11406 only call LayoutTestController.dumpResourceLoadCallbacks after the 11407 request is started, thus their expectations have "<unknown>" as the 11408 identifier. Change WebViewHost to the previous behavior, which also 11409 match the other ports'. 11410 11411 * DumpRenderTree/chromium/WebViewHost.cpp: 11412 (WebViewHost::assignIdentifierToRequest): 11413 (WebViewHost::removeIdentifierForRequest): 11414 114152010-11-08 Tony Chang <tony@chromium.org> 11416 11417 Reviewed by Adam Barth. 11418 11419 run platform/chromium/plugins/return-npobject.html on all platforms 11420 https://bugs.webkit.org/show_bug.cgi?id=49103 11421 11422 This tests that we can get an NPObject returned through a method on 11423 an NPAPI Object. 11424 11425 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 11426 (testCallbackReturn): 11427 (pluginInvoke): 11428 114292010-11-09 Sheriff Bot <webkit.review.bot@gmail.com> 11430 11431 Unreviewed, rolling out r71672. 11432 http://trac.webkit.org/changeset/71672 11433 https://bugs.webkit.org/show_bug.cgi?id=49276 11434 11435 It doesn't work on Chromium Windows bot (Requested by Ossy on 11436 #webkit). 11437 11438 * Scripts/webkitpy/common/system/file_lock.py: Removed. 11439 * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed. 11440 * Scripts/webkitpy/layout_tests/port/http_lock.py: 11441 114422010-11-09 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 11443 11444 Reviewed by Tony Chang. 11445 11446 [NRWT] Make http locking similar to perl implementation 11447 https://bugs.webkit.org/show_bug.cgi?id=49187 11448 11449 * Scripts/webkitpy/common/system/file_lock.py: Added. 11450 * Scripts/webkitpy/common/system/file_lock_unittest.py: Added. 11451 * Scripts/webkitpy/layout_tests/port/http_lock.py: 11452 114532010-11-09 James Kozianski <koz@chromium.org> 11454 11455 Reviewed by Eric Seidel. 11456 11457 Clean up imports for webkit-patch. 11458 https://bugs.webkit.org/show_bug.cgi?id=49083 11459 11460 Move some imports from commands into main.py where they are used. 11461 Move command imports into the __init__ of the commands module. 11462 11463 * Scripts/webkitpy/tool/commands/__init__.py: 11464 * Scripts/webkitpy/tool/commands/download.py: 11465 * Scripts/webkitpy/tool/commands/queues.py: 11466 * Scripts/webkitpy/tool/main.py: 11467 114682010-11-09 Yi Shen <yi.4.shen@nokia.com> 11469 11470 Reviewed by Andreas Kling. 11471 11472 [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar 11473 https://bugs.webkit.org/show_bug.cgi?id=49047 11474 11475 * QtTestBrowser/mainwindow.cpp: 11476 (MainWindow::setAddressUrl): 11477 114782010-11-09 Andras Becsi <abecsi@webkit.org> 11479 11480 Reviewed by Csaba Osztrogonác. 11481 11482 Improve old-run-webkit-tests --verbose to show DumpTool opening/closing 11483 https://bugs.webkit.org/show_bug.cgi?id=49252 11484 11485 * Scripts/old-run-webkit-tests: 11486 114872010-11-09 Csaba Osztrogonác <ossy@webkit.org> 11488 11489 Reviewed by Tor Arne Vestbø. 11490 11491 Output of old-run-webkit-tests is buggy in verbose mode 11492 https://bugs.webkit.org/show_bug.cgi?id=49249 11493 11494 * Scripts/old-run-webkit-tests: Redundant outputs removed. 11495 114962010-11-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk> 11497 11498 Reviewed by Martin Robinson. 11499 11500 [GTK] Link with target name set does not work 11501 https://bugs.webkit.org/show_bug.cgi?id=48865 11502 11503 When a new page is created with a name (target=myFrame), the new 11504 mainFrame could not be found because they where not stored in the 11505 same PageGroup. As PageGroup are not exposed externally so the 11506 simpliest solution is to use a global page group name. This also fixes 11507 issue with visited link coloration across pages. After this change the 11508 private function webkit_web_view_set_group_name() was no longer used 11509 so it was removed completly. 11510 11511 * DumpRenderTree/gtk/DumpRenderTree.cpp: 11512 (createWebView): 11513 115142010-11-08 John Knottenbelt <jknotten@chromium.org> 11515 11516 Reviewed by Kent Tamura. 11517 11518 WebViewHost::reset() uses placement new. 11519 https://bugs.webkit.org/show_bug.cgi?id=49069 11520 11521 WebViewHost is using placement destruction / new to simulate a fresh 11522 WebViewHost object at the same address. This is because the WebView remains 11523 open across tests and maintains a pointer to the WebViewHost. 11524 This change resets member variables explictly instead of the placement new dance. 11525 11526 * DumpRenderTree/chromium/WebViewHost.cpp: 11527 (WebViewHost::WebViewHost): 11528 (WebViewHost::reset): 11529 115302010-11-08 Dirk Pranke <dpranke@chromium.org> 11531 11532 Reviewed by Eric Seidel. 11533 11534 Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 11535 It turns out that NRWT can't use the code in scm.find_checkout_root() 11536 because the Chromium bots don't do full checkouts of the WebKit 11537 tree; they only check out subdirectories like WebKitTools/Scripts. 11538 Until we can figure out a better approach for this, I've 11539 restored the base_dir-detecting code from NRWT, which works in 11540 any directory tree, scm or no. 11541 11542 This also restores the files modified in r71475 and r71474. 11543 11544 https://bugs.webkit.org/show_bug.cgi?id=49151 11545 11546 * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py 11547 * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py 11548 115492010-11-08 Eric Seidel <eric@webkit.org> 11550 11551 Reviewed by Adam Barth. 11552 11553 webkit-patch failure-reason explodes if a build is missing 11554 https://bugs.webkit.org/show_bug.cgi?id=49195 11555 11556 This is likely a recent regression. Adding a unit test for this case. 11557 11558 * Scripts/webkitpy/common/net/buildbot.py: 11559 * Scripts/webkitpy/common/net/buildbot_unittest.py: 11560 115612010-11-08 Dan Bernstein <mitz@apple.com> 11562 11563 Reviewed by Darin Adler. 11564 11565 Ignore the system scrollbar setting. 11566 11567 * DumpRenderTree/mac/DumpRenderTree.mm: 11568 (resetDefaultsToConsistentValues): Set the scrollbar default. 11569 115702010-11-05 Adam Roben <aroben@apple.com> 11571 11572 Make webkitpy.common.system.executive_unittest pass when running under 11573 Win32 Python 11574 11575 Fixes <http://webkit.org/b/49033>. 11576 11577 Reviewed by Dave Levin and Eric Seidel. 11578 11579 * Scripts/webkitpy/common/system/executive.py: 11580 (Executive._run_command_with_teed_output): Pass the arguments through 11581 encode_argument_if_needed rather than using Cygwin-specific code here. 11582 (Executive.run_and_throw_if_fail): Use child_process_encoding to decode 11583 the output. 11584 (Executive.run_command): Use encode_argument_if_needed to encode the 11585 arguments and child_process_encoding to decode the output. 11586 (Executive._child_process_encoding): Returns the encoding that should be 11587 used when communicating with child processes. On Windows we use mbcs, 11588 which maps to the current code page. On all other platforms we use 11589 UTF-8. 11590 (Executive._should_encode_child_process_arguments): Returns True if 11591 arguments to child processes need to be encoded. This is currently 11592 only needed on Cygwin and Win32 Python 2.x. 11593 (Executive._encode_argument_if_needed): Encode the argument using 11594 child_process_encoding if we need to encode arguments to child 11595 processes on this platform. 11596 11597 * Scripts/webkitpy/common/system/executive_unittest.py: 11598 (never_ending_command): Added. Returns arguments to run a command that 11599 will not quit until we kill it. On Windows we use wmic, on other 11600 platforms we use yes. 11601 (ExecutiveTest.test_run_command_with_unicode): Changed to expect the 11602 mbcs encoding to be used and for output from the child processes to 11603 have been roundtripped through encode/decode on Win32 Python. When 11604 UTF-8 is the encoding the roundtripping is undetectable, but with mbcs 11605 it's possible that some characters will not be able to be converted 11606 and will be replaced by question marks; the round-tripping allows us 11607 to expect this result. 11608 11609 (ExecutiveTest.test_kill_process): 11610 (ExecutiveTest.test_kill_all): 11611 Use never_ending_command instead of invoking "yes" directly. Expect an 11612 exit code of 1 when using Win32 Python, as that's what seems to happen. 11613 116142010-11-08 Adam Roben <aroben@apple.com> 11615 11616 Roll out r71532 11617 11618 It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default 11619 .bashrc unsets %TEMP%, which broke copy-tools.cmd. 11620 11621 * Scripts/webkitdirs.pm: 11622 116232010-11-08 Tony Chang <tony@chromium.org> 11624 11625 Reviewed by Adam Barth. 11626 11627 run platform/chromium/plugins/nested-plugin-objects.html on all platforms 11628 https://bugs.webkit.org/show_bug.cgi?id=49094 11629 11630 This tests that objects created by plugins are proplery cleaned up. 11631 11632 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 11633 (testPassTestObject): 11634 (pluginInvoke): 11635 * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: 11636 (testAllocate): 11637 (testDeallocate): 11638 (testGetProperty): 11639 (testConstruct): 11640 116412010-11-08 Adam Roben <aroben@apple.com> 11642 11643 Mark Windows builds triggered from Perl as being non-interactive 11644 11645 This affects whether some of our scripts will show alerts vs. printing 11646 to the build log. 11647 11648 Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when 11649 .vsprops files are updated 11650 11651 Reviewed by Steve Falkenburg. 11652 11653 * Scripts/webkitdirs.pm: 11654 (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1. 11655 116562010-11-08 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 11657 11658 Reviewed by Ojan Vafai. 11659 11660 Make http locking default in NRWT. 11661 https://bugs.webkit.org/show_bug.cgi?id=48053 11662 11663 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 11664 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 11665 116662010-11-08 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 11667 11668 Reviewed by Csaba Osztrogonác. 11669 11670 [NRWT] If the http lock fails we shouldn't do any locking 11671 https://bugs.webkit.org/show_bug.cgi?id=49164 11672 11673 If something goes wrong with the locking, the test should keep going. 11674 11675 * Scripts/webkitpy/layout_tests/port/http_lock.py: 11676 116772010-11-08 Adam Roben <aroben@apple.com> 11678 11679 Switch back to using kCGImageAlphaPremultipliedFirst when generating 11680 pixel dumps on Windows 11681 11682 I changed this behavior in r71418 thinking that it was required for 11683 getting plugins to show up in pixel dumps. But it doesn't seem to be 11684 necessary, and was making it impossible to compare new Windows pixel 11685 dumps with existing Windows or Mac pixel dumps (because ImageDiff won't 11686 compare an image with alpha to an image without alpha). 11687 11688 Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare 11689 new Windows pixel results to existing Windows or Mac results 11690 11691 Reviewed by Antti Koivisto. 11692 11693 * DumpRenderTree/win/PixelDumpSupportWin.cpp: 11694 (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst 11695 with kCGImageAlphaPremultipliedFirst. 11696 116972010-11-08 Csaba Osztrogonac <ossy@webkit.org> 11698 11699 Unreviewed, rolling out r71466. 11700 http://trac.webkit.org/changeset/71466 11701 https://bugs.webkit.org/show_bug.cgi?id=48865 11702 11703 It broke layout tests on GTK bots. 11704 11705 * DumpRenderTree/gtk/DumpRenderTree.cpp: 11706 (createWebView): 11707 117082010-11-08 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 11709 11710 Reviewed by Csaba Osztrogonác. 11711 11712 Enable running of Qt API tests on BuildBot 11713 https://bugs.webkit.org/show_bug.cgi?id=49004 11714 11715 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 11716 117172010-11-08 Eric Seidel <eric@webkit.org> 11718 11719 Reviewed by Adam Barth. 11720 11721 Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review 11722 https://bugs.webkit.org/show_bug.cgi?id=49160 11723 11724 Bugzilla doesn't automatically remove r? when a bug gets closed. 11725 This script takes care of that for webkit.org. 11726 11727 * Scripts/webkitpy/common/net/bugzilla.py: 11728 * Scripts/webkitpy/tool/commands/upload.py: 11729 117302010-11-07 Fumitoshi Ukai <ukai@chromium.org> 11731 11732 Unreviewed, rolling out r71474. 11733 http://trac.webkit.org/changeset/71474 11734 https://bugs.webkit.org/show_bug.cgi?id=48280 11735 11736 breaks chromium webkit tests 11737 https://bugs.webkit.org/show_bug.cgi?id=49151 11738 11739 * Scripts/webkitpy/layout_tests/port/base.py: 11740 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 11741 * Scripts/webkitpy/layout_tests/port/config.py: 11742 * Scripts/webkitpy/layout_tests/port/config_unittest.py: 11743 * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: 11744 * Scripts/webkitpy/layout_tests/port/webkit.py: 11745 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 11746 * Scripts/webkitpy/tool/mocktool.py: 11747 117482010-11-07 Fumitoshi Ukai <ukai@chromium.org> 11749 11750 Unreviewed, rolling out r71475. 11751 http://trac.webkit.org/changeset/71475 11752 11753 breaks chromium webkit tests 11754 https://bugs.webkit.org/show_bug.cgi?id=49151 11755 11756 * Scripts/webkitpy/common/newstringio.py: Removed. 11757 * Scripts/webkitpy/common/newstringio_unittest.py: Removed. 11758 * Scripts/webkitpy/common/system/executive_mock.py: Removed. 11759 * Scripts/webkitpy/common/system/filesystem_mock.py: Removed. 11760 * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed. 11761 117622010-11-06 Dirk Pranke <dpranke@chromium.org> 11763 11764 Unreviewed, build fix. 11765 11766 Add files inexplicably not committed in r71474 as part of the 11767 fix for bug 48280. 11768 11769 * Scripts/webkitpy/common/newstringio.py: Added. 11770 * Scripts/webkitpy/common/newstringio_unittest.py: Added. 11771 * Scripts/webkitpy/common/system/executive_mock.py: Added. 11772 * Scripts/webkitpy/common/system/filesystem_mock.py: Added. 11773 * Scripts/webkitpy/layout_tests/port/config_mock.py: Added. 11774 117752010-11-06 Dirk Pranke <dpranke@chromium.org> 11776 11777 Reviewed by Eric Siedel. 11778 11779 new-run-webkit-tests: update port/base and port/webkit to use the 11780 new FileSystem and Config abstractions, pulling more logic out of 11781 the base Port classes into separate, mockable objects. 11782 11783 Also create a MockFileSystem object, a MockConfig object, move 11784 MockExecutive into common/system to be next to executive, and 11785 update the config object to use a FileSystem. 11786 11787 https://bugs.webkit.org/show_bug.cgi?id=48280 11788 11789 * Scripts/webkitpy/common/newstringio.py: Added. 11790 * Scripts/webkitpy/common/newstringio_unittest.py: Added. 11791 * Scripts/webkitpy/common/system/executive_mock.py: Added. 11792 * Scripts/webkitpy/common/system/filesystem_mock.py: Added. 11793 * Scripts/webkitpy/layout_tests/port/base.py: 11794 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 11795 * Scripts/webkitpy/layout_tests/port/config.py: 11796 * Scripts/webkitpy/layout_tests/port/config_mock.py: 11797 * Scripts/webkitpy/layout_tests/port/config_unittest.py: 11798 * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: 11799 * Scripts/webkitpy/layout_tests/port/webkit.py: 11800 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 11801 * Scripts/webkitpy/tool/mocktool.py: 11802 118032010-11-06 Dirk Pranke <dpranke@chromium.org> 11804 11805 Unreviewed, build breakage. 11806 11807 Apparently I uploaded the wrong version of the file to fix 49122 11808 and neither Eric or I noticed - it was missing a dirname() call. 11809 Fixing ... 11810 11811 https://bugs.webkit.org/show_bug.cgi?id=49122 11812 11813 * Scripts/webkitpy/common/checkout/scm.py: 11814 118152010-11-06 Dirk Pranke <dpranke@chromium.org> 11816 11817 Reviewed by Eric Seidel. 11818 11819 webkitpy/tool/* unittests change cwd and don't clean up properly 11820 11821 https://bugs.webkit.org/show_bug.cgi?id=49122 11822 11823 * Scripts/webkitpy/common/checkout/scm.py: 11824 118252010-11-05 Chris Marrin <cmarrin@apple.com> 11826 11827 Reviewed by Simon Fraser. 11828 11829 suspendAnimations/resumeAnimations not present in WebKit2 11830 https://bugs.webkit.org/show_bug.cgi?id=49109 11831 11832 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 11833 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 11834 (WTR::LayoutTestController::suspendAnimations): 11835 (WTR::LayoutTestController::resumeAnimations): 11836 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 11837 118382010-11-05 Tony Chang <tony@chromium.org> 11839 11840 Reviewed by David Levin. 11841 11842 cleanup style in TestNetscapePlugIn/PluginObject.cpp 11843 https://bugs.webkit.org/show_bug.cgi?id=49044 11844 11845 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 11846 (getPluginClass): 11847 (pluginGetProperty): 11848 (pluginSetProperty): 11849 (variantToIdentifier): 11850 (testCallback): 11851 (getURL): 11852 (getURLNotify): 11853 (testInvokeDefault): 11854 (testGetProperty): 11855 (testDocumentOpen): 11856 (testWindowOpen): 11857 (pluginInvoke): 11858 (handleCallback): 11859 (notifyStream): 11860 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: 11861 118622010-11-05 Eric Seidel <eric@webkit.org> 11863 11864 Reviewed by David Levin. 11865 11866 Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests 11867 https://bugs.webkit.org/show_bug.cgi?id=49032 11868 11869 I wrote this file as part of bug 47847, but I forgot to commit it. 11870 No one else noticed it missing because test-webkitpy knows how 11871 to recover in the case where it can't import QueueStatusServer 11872 (which generally occurs due to not having installed the AppEngine SDK). 11873 11874 * QueueStatusServer/__init__.py: Added. 11875 * QueueStatusServer/model/workitems_unittest.py: 11876 - Remove a test which fails. This was probably landed (by me) 11877 from my other machine, which since this __init__.py was missing 11878 I never noticed the failure and landed this invalid test. 11879 Sadly we can't really test remove_work_item as it depends 11880 on .key() working. .key() will throw unless the object 11881 has already been saved it seems. 11882 This may be a mis-design in our remove_work_item implementation, 11883 but for now, just removing the test. 11884 118852010-11-04 Adam Roben <aroben@apple.com> 11886 11887 Teach check-webkit-style about TestNetscapePlugIn 11888 11889 Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of 11890 TestNetscapePlugIn's coding conventions 11891 11892 Reviewed by John Sullivan. 11893 11894 * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with 11895 WebKitAPITest and TestWebKitAPI in having different include order and 11896 naming conventions than WebCore. Added some comments about why the 11897 exceptions exist. 11898 118992010-11-04 Adam Roben <aroben@apple.com> 11900 11901 Add a test that shows that windowed plugins are able to paint 11902 11903 Somehow we never had a test for this before. 11904 11905 Fixes <http://webkit.org/b/49029> Should add a test that shows 11906 windowed plugins can paint 11907 11908 Reviewed by Jon Honeycutt. 11909 11910 * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added. 11911 (DrawsGradient::DrawsGradient): 11912 (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages. 11913 11914 (DrawsGradient::onPaint): 11915 (DrawsGradient::onPrintClient): 11916 These both just call through to paint. 11917 11918 (DrawsGradient::paint): Fills our client area with some gradients. 11919 11920 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link 11921 against Msimg32.lib for ::GradientFill and added DrawsGradient. 11922 11923 * DumpRenderTree/win/PixelDumpSupportWin.cpp: 11924 (createBitmapContextFromWebView): Use WM_PRINT instead of 11925 WM_PRINTCLIENT so that ::DefWindowProc will send 11926 WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows. 11927 Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst 11928 because GDI doesn't support alpha and kCGImageBitmapOrder32Little with 11929 kCGImageBitmapOrder32Host because, who knows, maybe someday Windows 11930 will run on a big-endian platform. 11931 119322010-11-04 Adam Roben <aroben@apple.com> 11933 11934 Extract much of NPNInvalidateRectInvalidatesWindow's code into a 11935 WindowedPluginTest base class 11936 11937 The base class takes care of subclassing the plugin's window so that a 11938 custom WNDPROC is called. This will make it easier to write tests that 11939 need to handle window messages. 11940 11941 Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with 11942 a custom WNDPROC 11943 11944 Reviewed by Jon Honeycutt. 11945 11946 * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp: 11947 (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow): 11948 (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): 11949 (NPNInvalidateRectInvalidatesWindow::wndProc): 11950 (NPNInvalidateRectInvalidatesWindow::testInvalidateRect): 11951 Moved code from here to WindowedPluginTest. Changed to use window() 11952 instead of m_window. 11953 11954 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 11955 Added WindowedPluginTest and added TestNetscapePlugIn/win to the 11956 include path. Also reordered the include path to make a little more 11957 sense and simplified the entry that added TestNetscapePlugIn itself to 11958 the include path. 11959 11960 * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added. 11961 (WindowedPluginTest::WindowedPluginTest): 11962 (WindowedPluginTest::NPP_SetWindow): 11963 (WindowedPluginTest::staticWndProc): 11964 * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added. 11965 (WindowedPluginTest::window): 11966 Code came from NPNInvalidateRectInvalidatesWindow. 11967 119682010-11-04 Adam Roben <aroben@apple.com> 11969 11970 Add a plugin test to show that windowed plugins are clipped correctly 11971 11972 Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed 11973 plugins aren't clipped in WebKit2 on Windows 11974 11975 Reviewed by Jon Honeycutt. 11976 11977 * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added. 11978 (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members. 11979 (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window 11980 region matches the clip rect we know we should have based on 11981 window-region-is-set-to-clip-rect.html, and check that our window class 11982 doesn't have the CS_PARENTDC style. 11983 11984 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 11985 Added WindowRegionIsSetToClipRect. 11986 119872010-11-05 Alejandro G. Castro <alex@igalia.com> 11988 11989 Reviewed by Martin Robinson. 11990 11991 [GTK] Avoid font hinting in the DRT 11992 https://bugs.webkit.org/show_bug.cgi?id=48548 11993 11994 Change the settings to avoid font hinting, it was causing 11995 different results depending on the distribution. 11996 11997 * DumpRenderTree/gtk/DumpRenderTree.cpp: 11998 (initializeGtkFontSettings): 11999 * DumpRenderTree/gtk/fonts/fonts.conf: 12000 120012010-11-05 Eric Seidel <eric@webkit.org> 12002 12003 Reviewed by Adam Barth. 12004 12005 build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode 12006 https://bugs.webkit.org/show_bug.cgi?id=49051 12007 12008 This is a speculative fix. The unit tests cover these methods, however 12009 I don't know if this will fully stop the system.log spam. 12010 12011 * Scripts/webkitpy/layout_tests/port/base.py: 12012 * Scripts/webkitpy/layout_tests/port/webkit.py: 12013 120142010-11-05 Eric Seidel <eric@webkit.org> 12015 12016 Reviewed by Adam Barth. 12017 12018 Add basic support for showing bot id on /queue-status/ pages 12019 https://bugs.webkit.org/show_bug.cgi?id=49037 12020 12021 This support is really simple. Eventually we'll want to 12022 show the bot id in the lock table too, but we don't have 12023 that information stored in the server yet. 12024 12025 * QueueStatusServer/handlers/queuestatus.py: 12026 * QueueStatusServer/handlers/queuestatus_unittest.py: Added. 12027 * QueueStatusServer/templates/includes/singlequeuestatus.html: 12028 120292010-11-04 Dirk Pranke <dpranke@chromium.org> 12030 12031 Reviewed by Adam Barth. 12032 12033 Create a filesystem wrapper that we can use to enforce 12034 particular conventions and use for mocking and dependency 12035 injection down the line. 12036 12037 https://bugs.webkit.org/show_bug.cgi?id=48144 12038 12039 * Scripts/webkitpy/common/system/filesystem.py: Added. 12040 * Scripts/webkitpy/common/system/filesystem_unittest.py: Added. 12041 120422010-11-04 Mihai Parparita <mihaip@chromium.org> 12043 12044 Reviewed by Tony Chang. 12045 12046 run_webkit_tests_unittest fails under Python 2.5 12047 https://bugs.webkit.org/show_bug.cgi?id=49043 12048 12049 Switch from itertools.chain.from_iterable (which was added in 2.6) 12050 to using itertools.chain directly. 12051 12052 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 12053 120542010-11-04 Mihai Parparita <mihaip@chromium.org> 12055 12056 Unreviewed fix to webkit-patch rebaseline-server so that it runs under 12057 Python 2.5 (it needs an import to use the with statement). 12058 12059 * Scripts/webkitpy/tool/commands/rebaselineserver.py: 12060 120612010-11-04 Dirk Pranke <dpranke@chromium.org> 12062 12063 Reviewed by Adam Barth. 12064 12065 new-run-webkit-tests: split out webkit-specific configuration stuff into a new module 12066 12067 The current NRWT code has webkit-specific configuration code (like 12068 _script_path, default configuration, etc.) mixed in with 12069 layout-test-specific stuff in port/base. The configuration code 12070 should be split out into a separate module for easier mocking, 12071 testing, and isolation. 12072 12073 https://bugs.webkit.org/show_bug.cgi?id=48264 12074 12075 * Scripts/webkitpy/layout_tests/port/config.py: Added. 12076 * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added. 12077 120782010-11-04 Mihai Parparita <mihaip@chromium.org> 12079 12080 Reviewed by Tony Chang. 12081 12082 Rebaseline server: initial framework 12083 https://bugs.webkit.org/show_bug.cgi?id=48892 12084 12085 Adds the basic framework for the rebaseline server (details at 12086 http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch 12087 command, which starts an HTTP server that can serve static files or 12088 invoke handler methods on a class. 12089 12090 * Scripts/webkitpy/tool/commands/__init__.py: 12091 * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added. 12092 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added. 12093 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added. 12094 * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added. 12095 120962010-11-04 Dirk Pranke <dpranke@chromium.org> 12097 12098 Reviewed by James Robinson. 12099 12100 new-run-webkit-tests wasn't using DRT by default for 12101 --platform chromium-gpu 12102 12103 The default value was set to False instead of None, which meant 12104 that the platform specific logic wasn't firing to change the 12105 value to True (b/c we were afraid we'd be overriding the user 12106 preference). 12107 12108 https://bugs.webkit.org/show_bug.cgi?id=49038 12109 12110 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 12111 121122010-11-04 Tony Chang <tony@chromium.org> 12113 12114 Reviewed by Adam Barth. 12115 12116 make platform/chromium/plugins/multiple-plugins.html pass on all platforms 12117 https://bugs.webkit.org/show_bug.cgi?id=49026 12118 12119 Have the testObject.bar property return the string "bar". This lets 12120 us run and pass platform/chromium/plugins/multiple-plugins.html on all 12121 platforms. 12122 12123 * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: 12124 (testGetProperty): 12125 121262010-11-04 Mihai Parparita <mihaip@chromium.org> 12127 12128 Reviewed by Tony Chang. 12129 12130 NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc. 12131 https://bugs.webkit.org/show_bug.cgi?id=48878 12132 12133 Add get_tests_run so that it's easy to see which tests get run (and with 12134 what batching) for a given flag combination. Flesh out the various 12135 test cases that have FIXMEs. 12136 12137 Also fixes an off-by-one error (batch sizes were one larger than 12138 expected) and makes --run-part also have wraparound behavior, like 12139 --run-chunk. 12140 12141 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 12142 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 12143 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 12144 121452010-11-04 Erik Arvidsson <arv@chromium.org> 12146 12147 Reviewed by Dimitri Glazkov. 12148 12149 Support box-sizing without the vendor prefix 12150 https://bugs.webkit.org/show_bug.cgi?id=36713 12151 12152 Based on patch by Peter Beverloo <peter@lvp-media.com> 12153 12154 * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing. 12155 121562010-11-04 Csaba Osztrogonác <ossy@webkit.org> 12157 12158 Unreviewed rollout r71340, because it broke Chromium Windows bot. 12159 12160 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 12161 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 12162 121632010-11-04 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 12164 12165 Reviewed by Ojan Vafai. 12166 12167 Make http locking default in NRWT. 12168 https://bugs.webkit.org/show_bug.cgi?id=48053 12169 12170 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 12171 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 12172 121732010-11-04 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 12174 12175 Reviewed by Eric Seidel. 12176 12177 [NRWT] Clear invalid http locks on Windows platform as well 12178 https://bugs.webkit.org/show_bug.cgi?id=48515 12179 12180 * Scripts/webkitpy/common/system/executive.py: 12181 * Scripts/webkitpy/common/system/executive_unittest.py: 12182 * Scripts/webkitpy/layout_tests/port/http_lock.py: 12183 121842010-11-02 Adam Roben <aroben@apple.com> 12185 12186 Reduce our dependence on coreutils when running Python tests 12187 12188 This patch introduces versions of the standard echo and cat utilities 12189 implemented in Python. They are probably missing features of their 12190 coreutils equivalents, but they can do what's necessary for our Python 12191 tests. This is useful on Windows, where these utilities typically 12192 aren't available. 12193 12194 Fixes <http://webkit.org/b/48883> executive_unittest relies on echo 12195 and cat utilities from coreutils, which are not present on Windows 12196 12197 Reviewed by Eric Seidel. 12198 12199 * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use 12200 our Python-based echo and cat. 12201 12202 * Scripts/webkitpy/common/system/fileutils.py: Added. 12203 (make_stdout_binary): On Windows, puts sys.stdout into binary mode so 12204 that \n won't be translated into \r\n. I couldn't think of a good way 12205 to test this directly without touching the filesystem, but it is tested 12206 indirectly by echo_unittest. 12207 12208 * Scripts/webkitpy/test/cat.py: Added. 12209 (command_arguments): Returns a list for invoking cat with the given arguments. 12210 (main): Acts like a simplified version of the coreutils cat utility. 12211 12212 * Scripts/webkitpy/test/cat_unittest.py: Added. 12213 (CatTest.assert_cat): Runs cat with the given input and ensures the 12214 output matches the input. 12215 (CatTest.test_basic): Performs a simple test of cat. 12216 (CatTest.test_no_newline): Tests what happens when the input string 12217 doesn't have a trailing newline. 12218 (CatTest.test_unicode): Tests passing a unicode string to cat. 12219 (CatTest.test_as_command): Tests running cat as a separate command. 12220 12221 * Scripts/webkitpy/test/echo.py: Added. 12222 (command_arguments): Returns a list for invoking echo with the given arguments. 12223 (main): Acts like a simplified version of the coreutils echo utility. 12224 12225 * Scripts/webkitpy/test/echo_unittest.py: Added. 12226 (EchoTest.test_basic): Performs a simple test of echo. 12227 (EchoTest.test_no_newline): Tests passing -n to echo to suppress the 12228 trailing newline. 12229 (EchoTest.test_unicode): Tests passing unicode and non-unicode strings 12230 to echo. 12231 (EchoTest.test_argument_order): Tests what happens when -n is not the 12232 first argument. 12233 (EchoTest.test_empty_arguments): Tests what happens when you pass [] to 12234 echo.main. 12235 (EchoTest.test_no_arguments): Tests what happens when you call 12236 echo.main with no arguments. 12237 (EchoTest.test_as_command): Tests running echo as a separate command. 12238 122392010-11-04 Renata Hodovan <reni@inf.u-szeged.hu> 12240 12241 Unreviewed: Add myself to the list of Committers. 12242 12243 * Scripts/webkitpy/common/config/committers.py: 12244 122452010-11-04 Andreas Kling <kling@webkit.org> 12246 12247 Reviewed by Kenneth Rohde Christiansen. 12248 12249 [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode 12250 12251 In RTC mode the QGraphicsWebView item is the size of the contents, 12252 scrolling works a bit differently (we need to react to scrollRequested.) 12253 12254 Normally QGraphicsView will replay the last mouse event when scrolling, 12255 so to prevent WebKit from getting confused by this we temporarily make 12256 the QGraphicsView non-interactive. 12257 12258 * QtTestBrowser/webview.cpp: 12259 (WebViewGraphicsBased::setPage): 12260 (WebViewGraphicsBased::scrollRequested): 12261 * QtTestBrowser/webview.h: 12262 122632010-11-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 12264 12265 Reviewed by Andreas Kling. 12266 12267 Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt 12268 12269 PLATFORM(MAC) is not defined for the Qt port, as it refers to 12270 the Mac-port, not the Mac OS X operating system. 12271 12272 * WebKitTestRunner/qt/TestControllerQt.cpp: 12273 (WTR::isExistingLibrary): 12274 122752010-11-04 Leonid Ebril <leonid.ebril@nokia.com> 12276 12277 Reviewed by Andreas Kling. 12278 12279 [Qt] Adding iphone user agent string the user agent list for QtTestBrowser 12280 https://bugs.webkit.org/show_bug.cgi?id=48869 12281 12282 * QtTestBrowser/useragentlist.txt: 12283 122842010-11-03 Adam Roben <aroben@apple.com> 12285 12286 Always use uppercase drive names in strings returned by abspath_to_uri 12287 12288 Some versions of cygpath use lowercase drive letters while others use 12289 uppercase, which makes it hard to test the output of code that uses 12290 cygpath. 12291 12292 Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest 12293 fails with Cygwin 1.5 12294 12295 Reviewed by Eric Seidel. 12296 12297 * Scripts/webkitpy/common/system/path.py: 12298 (cygpath): Updated the docstring to indicate that only absolute paths 12299 should be passed for now (though relative paths will work fine). 12300 (_Cygpath.convert): Upper-case the first letter of the converted Windows path. 12301 123022010-11-03 George Guo <George.Guo@Nokia.com> 12303 12304 Reviewed by Andreas Kling. 12305 12306 [Qt] QtTestBrowser : set mmp rule pageddata in Symbian 12307 https://bugs.webkit.org/show_bug.cgi?id=48767 12308 12309 Paging is needd on Symbian devices to support benchmarks tests like 12310 dromaeo.com and Celtic Kane that need a lot of memory to run 12311 12312 * QtTestBrowser/QtTestBrowser.pro: 12313 123142010-11-03 Jenn Braithwaite <jennb@chromium.org> 12315 12316 Reviewed by Dmitry Titov. 12317 12318 Chromium: Update resource tracking when moving a frame between documents 12319 https://bugs.webkit.org/show_bug.cgi?id=48363 12320 12321 * DumpRenderTree/chromium/WebViewHost.cpp: 12322 (WebViewHost::assignIdentifierToRequest): 12323 Always put resource id in map so we can make assumptions about its 12324 presence. 12325 (WebViewHost::removeIdentifierForRequest): 12326 Added. 12327 (WebViewHost::didFinishResourceLoad): 12328 (WebViewHost::didFailResourceLoad): 12329 Check existence of resource id before removing from map. 12330 * DumpRenderTree/chromium/WebViewHost.h: 12331 123322010-11-03 Victor Wang <victorw@chromium.org> 12333 12334 Reviewed by Adam Barth. 12335 12336 [Chromium] update buildbot names in chromium rebaseline tool. 12337 12338 https://bugs.webkit.org/show_bug.cgi?id=48881 12339 12340 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 12341 123422010-11-03 Darin Adler <darin@apple.com> 12343 12344 Updated Xcode projects by opening them with Xcode 3.2.4. 12345 Updated svn:ignore for Xcode projects. 12346 12347 * MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore. 12348 * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore. 12349 * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore. 12350 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4. 12351 123522010-11-03 Adam Roben <aroben@apple.com> 12353 12354 Stop waiting for messages from the web process after a timeout elapses 12355 12356 TestController::runUntil now takes a timeout parameter that specifies 12357 how long to wait for the condition to become true. WebKitTestRunner 12358 takes a --timeout flag that specifies how long the timeout should be. 12359 run-webkit-tests passes this flag to WebKitTestRunner so its timeout 12360 will be similar to run-webkit-tests. 12361 12362 Fixes <http://webkit.org/b/43047> <rdar://problem/8365833> 12363 WebKitTestRunner waits forever if the web process crashes 12364 12365 Reviewed by Darin Adler and Anders Carlsson. 12366 12367 * Scripts/old-run-webkit-tests: 12368 (top level): Moved the GuardMalloc timeout adjustment here from 12369 readFromDumpToolWithTimer. 12370 (openDumpTool): Make WTR use a timeout similar to but slightly shorter 12371 than the one that was specified on the command line. 12372 12373 * WebKitTestRunner/TestController.cpp: 12374 (WTR::TestController::TestController): Initialize our timeout values. 12375 (WTR::TestController::initialize): Parse the --timeout flag and use it 12376 to modify our timeout values. 12377 (WTR::TestController::resetStateToConsistentValues): Changed to use a 12378 short timeout while waiting for the web process to reset and to return 12379 a boolean indicating whether we were able to reset the web process. 12380 Uses a 5-second timeout while waiting for the process to be reset. 12381 (WTR::TestController::runTest): Changed to return a boolean indicating 12382 whether we were able to reset the web process (and thus run the test). 12383 (WTR::TestController::runUntil): Call through to platformRunUntil. 12384 12385 (WTR::TestController::runTestingServerLoop): 12386 (WTR::TestController::run): 12387 Changed to bail if any test can't be run. This will cause the process 12388 to exit. (Unfortunately this will make run-webkit-tests think we 12389 crashed; see <http://webkit.org/b/48943>.) 12390 12391 * WebKitTestRunner/TestController.h: Added platformRunUntil, 12392 m_longTimeout, and m_shortTimeout. 12393 12394 * WebKitTestRunner/TestInvocation.cpp: 12395 (WTR::TestInvocation::invoke): Use a short timeout when waiting for the 12396 initial response and a long timeout when waiting for the test to 12397 complete. Check whether runUntil timed out and print an error message 12398 if so. 12399 12400 * WebKitTestRunner/mac/TestControllerMac.mm: 12401 (WTR::TestController::platformRunUntil): Renamed from runUntil. Pass 12402 [NSDate distantPast] to -[NSRunLoop runMode:beforeDate:] so that we 12403 won't block waiting for the run loop. Only loop until the timeout 12404 elapses. 12405 12406 * WebKitTestRunner/qt/TestControllerQt.cpp: 12407 (WTR::TestController::platformRunUntil): Renamed from runUntil. Added a 12408 FIXME about honoring the timeout. 12409 12410 * WebKitTestRunner/win/TestControllerWin.cpp: 12411 (WTR::TestController::platformRunUntil): Renamed from runUntil. Use 12412 ::MsgWaitForMultipleObjectsEx to implement the timeout. Changed to use 12413 ::PeekMessageW so that we don't block waiting for messages to become 12414 available. 12415 124162010-11-03 Adam Roben <aroben@apple.com> 12417 12418 Add a plugin test that evaluates JS after removing the plugin element 12419 from the document 12420 12421 This test replaces platform/win/plugins/plugin-delayed-destroy.html. 12422 That test was made to prevent a crash very similar to this one, but 12423 unfortunately tested only the mechanism that prevented the crash and 12424 not whether the crash itself was prevented. Since WebKit2 uses a 12425 different mechanism to prevent the crash, the test was failing even 12426 though WebKit2 was not vulnerable to the crash. This new test crashes 12427 if there is no mechanism in place to prevent it and passes in both 12428 WebKit1 and WebKit2. 12429 12430 Fixes <http://webkit.org/b/46711> <rdar://problem/8485903> 12431 platform/win/plugins/plugin-delayed-destroy.html fails in WebKit2 12432 12433 Reviewed by Anders Carlsson. 12434 12435 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 12436 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 12437 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 12438 * GNUmakefile.am: 12439 Added new file. 12440 12441 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 12442 (pluginDeallocate): Make sure we delete the PluginTest object. This 12443 prevents a leak and also allows us to test the crash. 12444 12445 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 12446 (PluginTest::executeScript): Made this into a non-static member 12447 function. 12448 12449 (PluginTest::waitUntilDone): 12450 (PluginTest::notifyDone): 12451 Updated for changes to executeScript. 12452 12453 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added executeScript. 12454 12455 * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp: Added. 12456 (EvaluateJSAfterRemovingPluginElement::EvaluateJSAfterRemovingPluginElement): 12457 Initialize ourselves and tell the test harness to wait. 12458 (EvaluateJSAfterRemovingPluginElement::NPP_DestroyStream): Remove our 12459 plugin element from the document, then execute some JavaScript. If 12460 WebKit does not have appropriate mechanisms in place, we'll be 12461 destroyed inside the first call to executeScript and crash on the 12462 second call. 12463 124642010-11-02 Stephen White <senorblanco@chromium.org> 12465 12466 Reviewed by Tony Chang. 12467 12468 [chromium] Fix LayoutTestController UMRs. 12469 https://bugs.webkit.org/show_bug.cgi?id=48872 12470 12471 * DumpRenderTree/chromium/LayoutTestController.cpp: 12472 (LayoutTestController::LayoutTestController): 12473 124742010-11-03 Kent Tamura <tkent@chromium.org> 12475 12476 Reviewed by Dimitri Glazkov. 12477 12478 REGRESSION: rebaseline-chromium-webkit-tests uses non-zero tolerance for 12479 image dup detection 12480 https://bugs.webkit.org/show_bug.cgi?id=48744 12481 12482 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 12483 - Make a function for option parsing for ease of test 12484 - Set 0 to options.tolerance 12485 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 12486 - Add a test for this change 12487 124882010-11-02 Gyuyoung Kim <gyuyoung.kim@samsung.com> 12489 12490 Unreviewed: Add myself to the list of Committers. 12491 12492 * Scripts/webkitpy/common/config/committers.py: 12493 124942010-11-02 Anders Carlsson <andersca@apple.com> 12495 12496 Fix build. 12497 12498 * TestWebKitAPI/PlatformUtilities.cpp: 12499 (TestWebKitAPI::Util::createContextForInjectedBundleTest): 12500 125012010-11-02 Sam Weinig <sam@webkit.org> 12502 12503 Reviewed by Anders Carlsson. 12504 12505 Add a way to send startup messages on the context which can be posted when a process launches 12506 <rdar://problem/8617928> 12507 https://bugs.webkit.org/show_bug.cgi?id=48838 12508 12509 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 12510 (WKBundleInitialize): 12511 * TestWebKitAPI/InjectedBundleController.cpp: 12512 (TestWebKitAPI::InjectedBundleController::initialize): 12513 (TestWebKitAPI::InjectedBundleController::didReceiveMessage): 12514 * TestWebKitAPI/InjectedBundleController.h: 12515 * TestWebKitAPI/InjectedBundleMain.cpp: 12516 (WKBundleInitialize): 12517 * TestWebKitAPI/PlatformUtilities.cpp: 12518 (TestWebKitAPI::Util::createContextForInjectedBundleTest): 12519 * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: 12520 (WKBundleInitialize): 12521 Update implementations of WKBundleInitialize to take an initial userData 12522 argument. Change TestWebKitAPI to use the new initial userData to initialize 12523 each test's bundle. 12524 125252010-11-02 Benjamin Kalman <kalman@google.com> 12526 12527 Reviewed by Ojan Vafai. 12528 12529 new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests 12530 https://bugs.webkit.org/show_bug.cgi?id=48794 12531 12532 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Strip the "LayoutTests/" prefix from test argument paths. 12533 125342010-11-02 Adam Roben <aroben@apple.com> 12535 12536 Skip webkitpy.layout_tests.run_webkit_tests_unittest.MainTest on Cygwin 12537 Python 2.5.x 12538 12539 It is known to hang on that version of Python. See 12540 <http://webkit.org/b/48614>. 12541 12542 Reviewed by Adam Barth. 12543 12544 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Use 12545 skip_if to skip MainTest on Cygwin Python 2.5.x. 12546 12547 * Scripts/webkitpy/test/skip.py: Added. 12548 (skip_if): If the passed-in condition is false, find all the test_* 12549 methods of the given class and replace them with a function that just 12550 logs that we're skipping these tests. This is loosely based on the 12551 unittest.skip_if decorator added in Python 3.1. 12552 (_skipped_method): Returns a function that just logs that the tests are 12553 being skipped. This is used in place of the actual test_* functions. 12554 12555 * Scripts/webkitpy/test/skip_unittest.py: Added. 12556 (SkipTest.setUp): Create a logger for ourselves and give it a handler 12557 that logs to a private stream. 12558 (SkipTest.tearDown): Reset the logger. 12559 (SkipTest.create_fixture_class): Returns a class that we use to test 12560 skip_if. It has a single test_* method, test_foo, that just calls 12561 through to a callback. 12562 (SkipTest.foo_callback): Record that test_foo was called. 12563 (SkipTest.test_skip_if_false): Pass skip_if a False condition and test 12564 that test_foo does get called. 12565 (SkipTest.test_skip_if_true): Pass skip_if a True condition and test 12566 that test_foo does not get called and the appropriate message gets 12567 logged. 12568 125692010-11-02 Adam Barth <abarth@webkit.org> 12570 12571 Reviewed by Eric Seidel. 12572 12573 webkit-patch should tell check-webkit-style which files were changed so 12574 check-webkit-style doesn't have to stat the whole working copy again 12575 https://bugs.webkit.org/show_bug.cgi?id=48792 12576 12577 * Scripts/webkitpy/tool/mocktool.py: 12578 * Scripts/webkitpy/tool/steps/checkstyle.py: 12579 125802010-11-02 Robert Kroeger <rjkroege@chromium.org> 12581 12582 Reviewed by James Robinson. 12583 12584 [Chromium/DRT] Make EventSendingController honour leapForward for touch events. 12585 https://bugs.webkit.org/show_bug.cgi?id=48777 12586 12587 * DumpRenderTree/chromium/EventSender.cpp: 12588 (EventSender::sendCurrentTouchEvent): 12589 125902010-11-02 Adam Roben <aroben@apple.com> 12591 12592 Only track resource identifiers in DRT when dumpResourceLoadCallbacks 12593 is on 12594 12595 This reverts Windows to our pre-r71097 behavior. That patch made us 12596 track all resource identifiers, including the main resource, so the 12597 main resource's URL started appearing in test output instead of 12598 "<unknown>". Arguably having the main resource's URL is better, but all 12599 other platforms print "<unknown>" and we want to match. 12600 12601 Fixes <http://webkit.org/b/48837> <rdar://problem/8620351> REGRESSION 12602 (r71097): Many http tests failing on Windows 12603 12604 Reviewed by Anders Carlsson. 12605 12606 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 12607 (ResourceLoadDelegate::identifierForInitialRequest): Don't add the 12608 identifier to the URL map if we're not supposed to dump resource load 12609 callbacks. 12610 (ResourceLoadDelegate::removeIdentifierForRequest): Always remove the 12611 identifier from the URL map even if we're already "done". There's no 12612 point in keeping out-of-date identifiers around. 12613 126142010-11-01 Jenn Braithwaite <jennb@chromium.org> 12615 12616 Reviewed by Adam Roben. 12617 12618 Windows: Update resource tracking when moving a frame between documents 12619 https://bugs.webkit.org/show_bug.cgi?id=48364 12620 12621 * DumpRenderTree/win/DumpRenderTree.cpp: 12622 (createWebViewAndOffscreenWindow): 12623 (main): 12624 Give each WebView its own ResourceLoadDelegate instance in order to 12625 make assertions about resource ids on a particular WebView. 12626 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 12627 (ResourceLoadDelegate::identifierForInitialRequest): 12628 Always add id to the map. 12629 (ResourceLoadDelegate::removeIdentifierForRequest): 12630 Added. 12631 (ResourceLoadDelegate::willSendRequest): 12632 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): 12633 (ResourceLoadDelegate::didReceiveResponse): 12634 (ResourceLoadDelegate::didFinishLoadingFromDataSource): 12635 (ResourceLoadDelegate::didFailLoadingWithError): 12636 (ResourceLoadDelegate::descriptionSuitableForTestResult): 12637 Replace static descriptionSuitableForTestResult with static member function to access identifier map. 12638 * DumpRenderTree/win/ResourceLoadDelegate.h: 12639 (ResourceLoadDelegate::urlMap): 12640 Moved within class so that each WebView has its own id map. 12641 126422010-11-01 Ojan Vafai <ojan@chromium.org> 12643 12644 Reviewed by Dimitri Glazkov. 12645 12646 remove debug code from run_webkit_tests.py 12647 https://bugs.webkit.org/show_bug.cgi?id=48800 12648 12649 Remove temporary debug code and make --master-name required 12650 if --test-results-server is set now that all clients set 12651 --master-name. 12652 12653 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 12654 126552010-11-01 Tony Chang <tony@chromium.org> 12656 12657 Reviewed by Kent Tamura. 12658 12659 add plugin event logging for linux 12660 https://bugs.webkit.org/show_bug.cgi?id=48779 12661 12662 This is taken from Chromium's fork of the layout test plugin: 12663 http://git.chromium.org/gitweb/?p=chromium.git/.git;a=blob;f=webkit/tools/npapi_layout_test_plugin/main.cpp;h=3ebdada2f049b3624756438cff852364f86a2ede;hb=HEAD#l348 12664 12665 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 12666 (handleEventX11): 12667 (NPP_HandleEvent): 12668 126692010-11-01 Dirk Pranke <dpranke@chromium.org> 12670 12671 Reviewed by James Robinson. 12672 12673 new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default 12674 https://bugs.webkit.org/show_bug.cgi?id=48790 12675 12676 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 12677 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 12678 126792010-11-01 Adam Barth <abarth@webkit.org> 12680 12681 Reviewed by Eric Seidel. 12682 12683 Teach check-webkit-style how to accept a list of files to diff on the 12684 command line 12685 https://bugs.webkit.org/show_bug.cgi?id=48784 12686 12687 In a future patch, webkit-patch will use this option to improve 12688 performance. I'm landing this in two pieces to avoid causing a version 12689 skew problem for the style-bot. 12690 12691 * Scripts/check-webkit-style: 12692 * Scripts/webkitpy/style/optparser.py: 12693 * Scripts/webkitpy/style/optparser_unittest.py: 12694 * Scripts/webkitpy/style_references.py: 12695 126962010-11-01 Anders Carlsson <andersca@apple.com> 12697 12698 Reviewed by John Sullivan. 12699 12700 Tear down the related WebProcessProxy when a WebContext is deallocated 12701 https://bugs.webkit.org/show_bug.cgi?id=48769 12702 12703 * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: 12704 (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): 12705 We don't support empty URLs anymore, update test to expect a null URL instead. 12706 127072010-11-01 Søren Gjesse <sgjesse@chromium.org> 12708 12709 Reviewed by Andreas Kling. 12710 12711 Fix warning when compiling the chromium port of DumpRenderShell 12712 with clang. 12713 https://bugs.webkit.org/show_bug.cgi?id=48414 12714 12715 * DumpRenderTree/chromium/TestShell.h: 12716 (TestShell::javaScriptFlagsForLoad): 12717 127182010-11-01 Adam Roben <aroben@apple.com> 12719 12720 Fix typo from r71022 12721 12722 * BuildSlaveSupport/build.webkit.org-config/config.json: 12723 127242010-11-01 Adam Roben <aroben@apple.com> 12725 12726 Trigger the Windows Release WebKit2 tests when a Release build 12727 finishes, not when a Debug build finishes 12728 12729 Fixes <http://webkit.org/b/48754> Windows Release WebKit2 tests are 12730 triggered at the wrong time 12731 12732 Reviewed by Sam Weinig. 12733 12734 * BuildSlaveSupport/build.webkit.org-config/config.json: Fixed 12735 triggerable name and trigger. 12736 127372010-11-01 Mario Sanchez Prada <msanchez@igalia.com> 12738 12739 Unreviewed. Adding my IRC nickname to the list of committers. 12740 12741 * Scripts/webkitpy/common/config/committers.py: 12742 127432010-10-31 Robert Hogan <robert@webkit.org> 12744 12745 Reviewed by Antonio Gomes. 12746 12747 [Qt] [Gtk] Plug-ins having upper case in mime type are failing to load 12748 12749 Qt and Gtk are case-sensitive when storing the declared mime-type 12750 of plugins. Since plugin mime-types are lowercased prior to searching 12751 for them in the plugin database, ensure they are loaded with the 12752 mime-type in lower case too. 12753 12754 Change the test netscape plugin to declare its mimetype in sentence 12755 case so that the correct behaviour is enforced. 12756 12757 https://bugs.webkit.org/show_bug.cgi?id=36815 12758 12759 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 12760 (NP_GetMIMEDescription): 12761 127622010-10-31 Robert Hogan <robert@webkit.org> 12763 12764 Reviewed by Antonio Gomes. 12765 12766 [Qt] Support nodesFromRect in DRT 12767 12768 https://bugs.webkit.org/show_bug.cgi?id=48716 12769 12770 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 12771 (LayoutTestController::nodesFromRect): 12772 * DumpRenderTree/qt/LayoutTestControllerQt.h: 12773 127742010-10-30 Andreas Kling <kling@webkit.org> 12775 12776 Reviewed by Antonio Gomes. 12777 12778 [Qt] QtTestBrowser: Switching view type moves the embedded inspector 12779 https://bugs.webkit.org/show_bug.cgi?id=48705 12780 12781 Reinsert the embedded inspector into the splitter after changing 12782 between QWebView/QGraphicsWebView. 12783 12784 * QtTestBrowser/launcherwindow.cpp: 12785 (LauncherWindow::init): 12786 (LauncherWindow::initializeView): 12787 * QtTestBrowser/webinspector.h: 12788 (WebInspector::WebInspector): 12789 127902010-10-28 Antonio Gomes <agomes@rim.com> 12791 12792 Reviewed by Ojan Vafai. 12793 12794 Needs a "LinuxEditingBehavior", perhaps with a better name 12795 https://bugs.webkit.org/show_bug.cgi?id=36627 12796 12797 Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior. 12798 12799 * DumpRenderTree/chromium/LayoutTestController.cpp: 12800 (LayoutTestController::setEditingBehavior): 12801 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 12802 (LayoutTestController::setEditingBehavior): 12803 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 12804 (LayoutTestController::setEditingBehavior): 12805 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 12806 (LayoutTestController::setEditingBehavior): 12807 128082010-10-29 Andreas Kling <kling@webkit.org> 12809 12810 Reviewed by Kenneth Rohde Christiansen. 12811 12812 [Qt] QtTestBrowser: Add keyboard shortcut to toggle full screen (F11) 12813 https://bugs.webkit.org/show_bug.cgi?id=48695 12814 12815 * QtTestBrowser/launcherwindow.cpp: 12816 (LauncherWindow::createChrome): 12817 128182010-10-29 Andreas Kling <kling@webkit.org> 12819 12820 Reviewed by Kenneth Rohde Christiansen. 12821 12822 [Qt] QtTestBrowser: Fix uninitialized read in FpsTimer 12823 https://bugs.webkit.org/show_bug.cgi?id=48675 12824 12825 FpsTimer::m_timer was never initialized and passed to QObject::killTimer() 12826 on startup with in -graphicsbased mode. 12827 12828 * QtTestBrowser/fpstimer.cpp: 12829 (FpsTimer::FpsTimer): 12830 (FpsTimer::numFrames): 12831 (FpsTimer::stop): 12832 (FpsTimer::timerEvent): 12833 * QtTestBrowser/fpstimer.h: 12834 128352010-10-29 Dirk Pranke <dpranke@chromium.org> 12836 12837 Reviewed by Tony Chang. 12838 12839 new-run-webkit-tests: change TestResults to be serializable 12840 12841 In preparation for changing new-run-webkit-tests from 12842 multithreaded to multiprocess, we need to make sure the data 12843 going between the threads is easily serialized over a socket. 12844 12845 This change adds serialization/pickling for the TestResults and 12846 TestFailure objects (using cPickle). 12847 12848 The TestFailure objects included a "has_wdiff" flag for Text 12849 results, but the flag wasn't being used, so I've removed it, 12850 simplifying the state to basically a set of enum objects with 12851 associated methods. 12852 12853 https://bugs.webkit.org/show_bug.cgi?id=48616 12854 12855 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 12856 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 12857 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 12858 * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: 12859 * Scripts/webkitpy/layout_tests/layout_package/test_results.py: Added. 12860 * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:Added. 12861 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 12862 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 12863 128642010-10-29 Dirk Pranke <dpranke@chromium.org> 12865 12866 Reviewed by Ojan Vafai. 12867 12868 new-run-webkit-tests: need to provide separate dashboard results for GPU tests 12869 https://bugs.webkit.org/show_bug.cgi?id=48687 12870 12871 Modify the steps to upload the JSON files to the dashboards so 12872 that the GPU tests don't conflict with the regular tests on a 12873 port. We do this by modifying the --builder-name parameter to 12874 append " - GPU", which should cause the app to treat the results 12875 as a completely new builder. This is a little non-obvious, but 12876 keeps us from having to restructure the app. 12877 12878 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 12879 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 12880 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 12881 128822010-10-29 Ojan Vafai <ojan@chromium.org> 12883 12884 Reviewed by Tony Chang. 12885 12886 [chromium] add debug logging to help diagnose flakiness dashboard issues 12887 https://bugs.webkit.org/show_bug.cgi?id=48657 12888 12889 The appengine app thinks it's getting empty files uploaded. Add some logging 12890 to see if new-run-webkit-tests agrees. 12891 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 12892 128932010-10-29 Dimitri Glazkov <dglazkov@chromium.org> 12894 12895 Reviewed by Ojan Vafai. 12896 12897 [Chromium/DRT] Add master-name flag to new-run-webkit-tests. 12898 https://bugs.webkit.org/show_bug.cgi?id=48649 12899 12900 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added flag. 12901 129022010-10-29 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk> 12903 12904 Reviewed by Martin Robinson. 12905 12906 Enable popup window in GtkLauncher 12907 https://bugs.webkit.org/show_bug.cgi?id=48335 12908 12909 The GtkLauncher application does not support opening new window when 12910 a link with "target=_blank" is clicked or similar call to 12911 window.open(). Instead, GtkLauncher does nothing which breaks 12912 navigation of some websites. 12913 12914 * GtkLauncher/main.c: 12915 (activate_uri_entry_cb): 12916 (update_title): 12917 (link_hover_cb): 12918 (notify_title_cb): 12919 (notify_load_status_cb): 12920 (notify_progress_cb): 12921 (destroy_cb): 12922 (go_back_cb): 12923 (go_forward_cb): 12924 (create_web_view_cb): 12925 (web_view_ready_cb): 12926 (close_web_view_cb): 12927 (create_browser): 12928 (create_statusbar): 12929 (create_toolbar): 12930 (create_window): 12931 (main): 12932 129332010-10-29 Adam Roben <aroben@apple.com> 12934 12935 Teach check-webkit-style about WebKit2's idiosyncracies 12936 12937 Fixes <http://webkit.org/b/48638> Style bot complains about a number 12938 of WebKit2 conventions 12939 12940 Reviewed by Anders Carlsson. 12941 12942 * Scripts/webkitpy/style/checker.py: Excluded some rules for various 12943 WebKit2-related files. Also updated the excluded rules for 12944 WebKitAPITest to match the current code. 12945 129462010-10-29 Csaba Osztrogonác <ossy@webkit.org> 12947 12948 Reviewed by Adam Roben and David Kilzer. 12949 12950 Fix and cleanup of build systems 12951 https://bugs.webkit.org/show_bug.cgi?id=48342 12952 12953 * Scripts/build-webkit: 12954 - Remove unnecessary ENABLE_SANDBOX option. 12955 - Add ENABLE_FULLSCREEN_API option. 12956 129572010-10-28 Adam Roben <aroben@apple.com> 12958 12959 Switch the Windows WebKit2 bot to the Release configuration 12960 12961 We only have one machine testing WebKit2 on Windows right now, and 12962 Debug is just too slow for it to keep up. 12963 12964 Fixes (hopefully!) <http://webkit.org/b/48615> Windows WebKit2 bot is 12965 always way behind 12966 12967 Reviewed by Jon Honeycutt. 12968 12969 * BuildSlaveSupport/build.webkit.org-config/config.json: 12970 129712010-10-29 Leandro Gracia Gil <leandrogracia@google.com> 12972 12973 Reviewed by Jeremy Orlow. 12974 12975 Added a second parameter to setMockSpeechInputResult for 12976 the language used in speech input. 12977 https://bugs.webkit.org/show_bug.cgi?id=47089 12978 12979 * DumpRenderTree/LayoutTestController.cpp: 12980 (setMockSpeechInputResultCallback): 12981 * DumpRenderTree/LayoutTestController.h: 12982 * DumpRenderTree/chromium/LayoutTestController.cpp: 12983 (LayoutTestController::setMockSpeechInputResult): 12984 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 12985 (LayoutTestController::setMockSpeechInputResult): 12986 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 12987 (LayoutTestController::setMockSpeechInputResult): 12988 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 12989 (LayoutTestController::setMockSpeechInputResult): 12990 * DumpRenderTree/qt/LayoutTestControllerQt.h: 12991 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 12992 (LayoutTestController::setMockSpeechInputResult): 12993 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 12994 (LayoutTestController::setMockSpeechInputResult): 12995 (LayoutTestController::pageSizeAndMarginsInPixels): 12996 129972010-10-28 Ojan Vafai <ojan@chromium.org> 12998 12999 Reviewed by Tony Chang. 13000 13001 [chromium] add a result-small.json file for the test dashboard 13002 https://bugs.webkit.org/show_bug.cgi?id=48547 13003 13004 Output both a results.json file and a results-small.json file. 13005 The dashboard will load results-small.json by default so it loads faster. 13006 13007 * TestResultServer/model/jsonresults.py: 13008 * TestResultServer/model/jsonresults_unittest.py: 13009 Added a bunch of sys.path hackery. Unforunately, this uses hardcoded 13010 paths. That obviously needs to be fixed, but at least this way it 13011 clearly documents what paths are necessary. 13012 130132010-10-28 Eric Seidel <eric@webkit.org> 13014 13015 Reviewed by Adam Barth. 13016 13017 webkit-patch upload calls changed_files more often than it should 13018 https://bugs.webkit.org/show_bug.cgi?id=48567 13019 13020 Passing changed_files around everywhere isn't a very elegant solution 13021 but it's the one we have for the moment. I think keeping an explicit 13022 cache on Checkout (or making StepState() a real class) is a better 13023 long-term option. 13024 13025 Previously bug_id_for_this_commit was calling changed_files and the 13026 result was never getting cached on the state. Now we're explicitly 13027 caching the result on the state and passing that to the bug_id_for_this_commit call. 13028 13029 I looked into building unit tests for this. Doing so would require 13030 using a real Checkout object with a MockSCM and overriding the appropriate 13031 calls on SCM to count how often we're stating the file system. 13032 That's a useful set of tests to build for a separate change. 13033 13034 * Scripts/webkitpy/common/checkout/api.py: 13035 * Scripts/webkitpy/tool/commands/download.py: 13036 * Scripts/webkitpy/tool/commands/upload.py: 13037 * Scripts/webkitpy/tool/mocktool.py: 13038 130392010-10-28 Eric Seidel <eric@webkit.org> 13040 13041 Reviewed by Adam Barth. 13042 13043 Make suggest-reviewers slightly faster 13044 https://bugs.webkit.org/show_bug.cgi?id=48562 13045 13046 Add @memoized to one more common call. 13047 13048 * Scripts/webkitpy/common/checkout/api.py: 13049 130502010-10-28 Eric Seidel <eric@webkit.org> 13051 13052 Reviewed by Adam Barth. 13053 13054 webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is still very slow 13055 https://bugs.webkit.org/show_bug.cgi?id=48536 13056 13057 This patch makes it about 40 seconds faster, but it still 13058 takes 1:40. This will require more refinement. 13059 13060 The suggested reviewers list appears to be the same. 13061 13062 I think the next step may be to have it stop the search after 13063 5 reviewers are found. We never want to suggest 30 people. 13064 13065 * Scripts/webkitpy/common/checkout/scm.py: 13066 - Using --remove-empty to theoretically stop lookups past 13067 when a file is removed. I'm not entirely clear that the option 13068 does what it says it does. Example: 13069 git log --pretty=format:%H -5 --remove-empty -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h 13070 returns only one commit 13071 vs. 13072 git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h 13073 which returns 5. I was not aware that wx files were ever removed from the repository? 13074 130752010-10-28 Kinuko Yasuda <kinuko@chromium.org> 13076 13077 Reviewed by David Levin. 13078 13079 [Chromium] Support FileSystem in chromium DRT 13080 https://bugs.webkit.org/show_bug.cgi?id=47643 13081 13082 * DumpRenderTree/chromium/WebViewHost.cpp: 13083 (WebViewHost::openFileSystem): Added. 13084 * DumpRenderTree/chromium/WebViewHost.h: 13085 (WebViewHost::openFileSystem): Added. 13086 130872010-10-28 Sam Weinig <sam@webkit.org> 13088 13089 Reviewed by Anders Carlsson. 13090 13091 WKURLRefs should be allowed to be null 13092 <rdar://problem/8575621> 13093 https://bugs.webkit.org/show_bug.cgi?id=48535 13094 13095 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 13096 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: 13097 (TestWebKitAPI::didStartProvisionalLoadForFrame): 13098 (TestWebKitAPI::didCommitLoadForFrame): 13099 (TestWebKitAPI::didFinishLoadForFrame): 13100 Test that URLs are null pointers when unset. 13101 131022010-10-28 Chris Fleizach <cfleizach@apple.com> 13103 13104 Reviewed by Adele Peterson. 13105 13106 AX: multi select group option does not handle setting of AXSelectedChildren correctly 13107 https://bugs.webkit.org/show_bug.cgi?id=48464 13108 13109 Add support for querying information about selected children to DRT, including: 13110 selectedChildAtIndex 13111 selectedChildrenCount 13112 setSelectedChild 13113 13114 * DumpRenderTree/AccessibilityUIElement.cpp: 13115 (selectedChildAtIndexCallback): 13116 (setSelectedChildCallback): 13117 (selectedChildrenCountCallback): 13118 (AccessibilityUIElement::setSelectedChild): 13119 (AccessibilityUIElement::selectedChildrenCount): 13120 (AccessibilityUIElement::selectedChildAtIndex): 13121 (AccessibilityUIElement::getJSClass): 13122 * DumpRenderTree/AccessibilityUIElement.h: 13123 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 13124 (AccessibilityUIElement::selectedChildAtIndex): 13125 (AccessibilityUIElement::selectedChildrenCount): 13126 (AccessibilityUIElement::setSelectedChild): 13127 131282010-10-27 Sam Weinig <sam@webkit.org> 13129 13130 Reviewed by Anders Carlsson. 13131 13132 Add WebKit2 API for window feature getter/setters 13133 <rdar://problem/8590373> 13134 https://bugs.webkit.org/show_bug.cgi?id=48496 13135 13136 * MiniBrowser/mac/BrowserWindowController.m: 13137 (-[BrowserWindowController awakeFromNib]): 13138 * MiniBrowser/win/BrowserView.cpp: 13139 (BrowserView::create): 13140 * WebKitTestRunner/TestController.cpp: 13141 (WTR::createOtherPage): 13142 (WTR::TestController::initialize): 13143 131442010-10-28 Søren Gjesse <sgjesse@chromium.org> 13145 13146 Reviewed by Tony Chang. 13147 13148 Added support for the DumpRenderTree flags --multiple-loads and --js-flags to the Python test runner. 13149 https://bugs.webkit.org/show_bug.cgi?id=48236 13150 13151 * Scripts/webkitpy/layout_tests/port/chromium.py: 13152 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 13153 131542010-10-28 Sergio Villar Senin <svillar@igalia.com> 13155 13156 Reviewed by Martin Robinson. 13157 13158 [GTK] WebKitWebFrame's load-status is not properly notified to the tests 13159 https://bugs.webkit.org/show_bug.cgi?id=48048 13160 13161 DRT now listens to WebKitWebFrame load-status signals for each 13162 created frame instead of the load-status signal of the 13163 WebKitWebView that only notifies about changes in the main frame. 13164 13165 * DumpRenderTree/gtk/DumpRenderTree.cpp: 13166 (webViewLoadFinished): 13167 (webFrameLoadStatusNotified): 13168 (frameCreatedCallback): 13169 (createWebView): 13170 (main): 13171 131722010-10-28 Tony Chang <tony@chromium.org> 13173 13174 Reviewed by Kent Tamura. 13175 13176 [chromium] fix textInputController.{selectedRange,markedRange} 13177 https://bugs.webkit.org/show_bug.cgi?id=48487 13178 13179 * DumpRenderTree/chromium/TextInputController.cpp: 13180 (TextInputController::markedRange): Return arrays of ints, rather than a string 13181 (TextInputController::selectedRange): Ditto. 13182 131832010-10-27 Ojan Vafai <ojan@chromium.org> 13184 13185 Reviewed by Tony Chang. 13186 13187 [chromium] add a master-name flag to new-run-webkit-tests 13188 https://bugs.webkit.org/show_bug.cgi?id=48488 13189 13190 The test results server now allows adding a master name to 13191 the uploaded files. This lets us distinguish bots that have 13192 the same name, but are on different masters. 13193 13194 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 13195 131962010-10-28 Adam Roben <aroben@apple.com> 13197 13198 Don't append a newline to the test output if the frame has no document 13199 element in WebKitTestRunner 13200 13201 Fixes <http://webkit.org/b/48526> Extra trailing newline when running 13202 plugins/document-open.html in WebKitTestRunner 13203 13204 Reviewed by Anders Carlsson. 13205 13206 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 13207 (WTR::toJS): Added. Turns a UTF-8 C string into a JSStringRef. 13208 (WTR::hasDocumentElement): Added. Uses the JSC API to figure out 13209 whether the frame has a document element. 13210 (WTR::dumpFrameText): Match DRT by bailing (rather than appending an 13211 empty string and a newline) if the frame has no document element. 13212 132132010-10-28 Adam Roben <aroben@apple.com> 13214 13215 Skip npn-invalidate-rect-invalidates-window.html on headless XP 13216 machines 13217 13218 TestNetscapePlugIn never receives a WM_PAINT message on headless XP 13219 machines, so this test times out. Fixing the test is covered by 13220 <http://webkit.org/b/48333>. 13221 13222 * Scripts/old-run-webkit-tests: Skip 13223 npn-invalidate-rect-invalidates-window.html on Windows if accelerated 13224 compositing support is disabled, which likely means we're on a headless 13225 XP machine. 13226 132272010-10-28 Kimmo Kinnunen <kimmok@iki.fi> 13228 13229 Adding myself as a committer. 13230 13231 * Scripts/webkitpy/common/config/committers.py: 13232 132332010-10-27 Eric Seidel <eric@webkit.org> 13234 13235 Reviewed by Adam Barth. 13236 13237 webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is very slow 13238 https://bugs.webkit.org/show_bug.cgi?id=48500 13239 13240 This doesn't fix the problem, but it makes things slightly better. 13241 Each git svn find-rev call takes about .25 seconds on my desktop. 13242 This patch uses a new memoized class to avoid those calls when possible. 13243 13244 The real slowness is still git log on some files, like: 13245 git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h 13246 I'm not yet sure how to make the pathological git logs better. 13247 13248 * Scripts/webkitpy/common/checkout/scm.py: 13249 * Scripts/webkitpy/common/memoized.py: Added. 13250 * Scripts/webkitpy/common/memoized_unittest.py: Added. 13251 132522010-10-27 Eric Seidel <eric@webkit.org> 13253 13254 Reviewed by Ojan Vafai. 13255 13256 EWS bots should not use --quiet when running build-webkit 13257 https://bugs.webkit.org/show_bug.cgi?id=48482 13258 13259 --quiet is only correct when the sub-process does the error reporting. 13260 In the case of _can_build() the parent process is reporting the error. 13261 We'd like the full build log at queues.webkit.org so someone can look 13262 at the log and understand why the EWS is failing to build trunk. 13263 13264 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 13265 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 13266 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 13267 * Scripts/webkitpy/tool/mocktool.py: 13268 132692010-10-27 Brian Weinstein <bweinstein@apple.com> 13270 13271 More Windows build fixage. Rename a variable that was named string. 13272 13273 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 13274 (WTR::hasPrefix): 13275 132762010-10-27 Ojan Vafai <ojan@chromium.org> 13277 13278 Reviewed by Dimitri Glazkov. 13279 13280 [chromium] Make the test results server store which master the bot is on 13281 https://bugs.webkit.org/show_bug.cgi?id=48478 13282 13283 The chromium bots recently changed so that there are multiple slaves with 13284 the same name on different masters. Up till now, the test results server 13285 assumed slave names were unique. Adds a master field to the file in order 13286 to distinguish. 13287 13288 Also, for files that currently lack a master or testtype, set them appropriately. 13289 13290 * TestResultServer/handlers/testfilehandler.py: 13291 * TestResultServer/index.yaml: 13292 * TestResultServer/model/jsonresults.py: 13293 * TestResultServer/model/testfile.py: 13294 * TestResultServer/templates/showfilelist.html: 13295 * TestResultServer/templates/uploadform.html: 13296 132972010-10-26 Darin Adler <darin@apple.com> 13298 13299 Reviewed by Sam Weinig. 13300 13301 WebKitTestRunner needs to support layoutTestController.dumpBackForwardList 13302 https://bugs.webkit.org/show_bug.cgi?id=42322 13303 rdar://problem/8193631 13304 13305 WebKitTestRunner needs to support layoutTestController.clearBackForwardList 13306 https://bugs.webkit.org/show_bug.cgi?id=42333 13307 rdar://problem/8193643 13308 13309 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: 13310 Renamed the product to WebKitTestRunnerInjectedBundle to avoid 13311 name conflicts in the build directory. 13312 13313 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 13314 Added dumpBackForwardList and clearBackForwardList. 13315 13316 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 13317 (WTR::InjectedBundle::InjectedBundle): Removed initialization of m_mainPage. 13318 (WTR::InjectedBundle::didCreatePage): Removed unneeded underscore. 13319 (WTR::InjectedBundle::willDestroyPage): Ditto. 13320 (WTR::InjectedBundle::didReceiveMessage): Ditto. 13321 (WTR::InjectedBundle::initialize): Ditto. 13322 (WTR::InjectedBundle::didCreatePage): Changed code to use m_pages 13323 instead of m_mainPage and m_otherPages. 13324 (WTR::InjectedBundle::willDestroyPage): Ditto. 13325 (WTR::InjectedBundle::page): Ditto. 13326 (WTR::InjectedBundle::beginTesting): Ditto. 13327 (WTR::InjectedBundle::done): Ditto. 13328 (WTR::InjectedBundle::closeOtherPages): Ditto. 13329 (WTR::InjectedBundle::dumpBackForwardListsForAllPages): Added. 13330 13331 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Changed 13332 page function to longer be inline, and pageCount function 13333 to use m_pages. Added dumpBackForwardListsForAllPages, and 13334 removed some underscores. Replaced m_mainPage and m_otherPageas 13335 with m_pages. 13336 13337 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 13338 (WTR::adoptWK): Added. 13339 (WTR::hasPrefix): Added. 13340 (WTR::InjectedBundlePage::reset): Added code to set up 13341 m_previousTestBackForwardListItem. 13342 (WTR::InjectedBundlePage::dump): Added code to call 13343 dumpBackForwardListsForAllPages. 13344 (WTR::compareByTargetName): Added. 13345 (WTR::dumpBackForwardListItem): Added. 13346 (WTR::InjectedBundlePage::dumpBackForwardList): Added. 13347 13348 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added 13349 dumpBackForwardList and m_previousTestBackForwardListItem. 13350 13351 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 13352 (WTR::LayoutTestController::LayoutTestController): Initialize 13353 m_shouldDumpBackForwardListsForAllWindows to false. 13354 (WTR::LayoutTestController::clearBackForwardList): Added. 13355 13356 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 13357 Added dumpBackForwardList, clearBackForwardList, 13358 shouldDumpBackForwardListsForAllWindows, and 13359 m_shouldDumpBackForwardListsForAllWindows. 13360 13361 * WebKitTestRunner/TestController.cpp: 13362 (WTR::TestController::initialize): Set up 13363 didReceiveSynchronousMessageFromInjectedBundle. 13364 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): 13365 Added. 13366 * WebKitTestRunner/TestController.h: Ditto. 13367 13368 * WebKitTestRunner/TestInvocation.cpp: 13369 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): 13370 Added. 13371 * WebKitTestRunner/TestInvocation.h: Ditto. 13372 13373 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 13374 Renamed bundle to WebKitTestRunnerInjectedBundle (see above). 13375 * WebKitTestRunner/mac/TestControllerMac.mm: 13376 (WTR::TestController::initializeInjectedBundlePath): Ditto. 13377 133782010-10-27 Chris Rogers <crogers@google.com> 13379 13380 Reviewed by Chris Marrin. 13381 13382 Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit 13383 https://bugs.webkit.org/show_bug.cgi?id=48279 13384 13385 * Scripts/build-webkit: 13386 133872010-10-27 Eric Seidel <eric@webkit.org> 13388 13389 Unreviewed. 13390 13391 build-webkit should collect Visual Studio Express logs and display them 13392 https://bugs.webkit.org/show_bug.cgi?id=39199 13393 13394 It turns out my previous patch wasn't actually working on the win-ews 13395 machine. So I've fixed my mistakes from before. 13396 13397 * Scripts/build-webkit: 13398 - Windows VSE builds change the CWD while building. Why? Who knows. 13399 * Scripts/print-vse-failure-logs: 13400 - windows VSE builds don't use Debug/Release as I expected, so I've 13401 moved off of --configuration to --top-level and added the /obj 13402 optimization while I was there. 13403 134042010-10-27 Dimitri Glazkov <dglazkov@chromium.org> 13405 13406 Unreviewed, rolling out r70674. 13407 http://trac.webkit.org/changeset/70674 13408 https://bugs.webkit.org/show_bug.cgi?id=48053 13409 13410 Broke Chromium Windows build. 13411 13412 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 13413 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 13414 134152010-10-25 Tony Chang <tony@chromium.org> 13416 13417 Reviewed by Anders Carlsson. 13418 13419 compile TestNetscapePlugIn on chromium linux 13420 https://bugs.webkit.org/show_bug.cgi?id=48274 13421 13422 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 13423 (NP_Initialize): On Linux, plugin funcs are set in initialize. 13424 (NPP_New): Mark the plugin as windowless. 13425 (NPP_GetValue): Handle mime type values. 13426 (NP_GetMIMEDescription): 13427 (NP_GetValue): 13428 * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: define TRUE and FALSE, which are in webkit's npapi.h. 13429 * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Pull in npapi.h to get TRUE/FALSE (matches webkit's npfunctions.h) 13430 134312010-10-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 13432 13433 Reviewed by Anders Carlsson. 13434 13435 Remove contentSizeChanged callbacks as it is no longer 13436 part of the public UIClient. 13437 13438 Make WKPageContentsSizeChangedCallback be a private API 13439 https://bugs.webkit.org/show_bug.cgi?id=48409 13440 13441 * MiniBrowser/mac/BrowserWindowController.m: 13442 (-[BrowserWindowController awakeFromNib]): 13443 * MiniBrowser/win/BrowserView.cpp: 13444 (BrowserView::create): 13445 * WebKitTestRunner/TestController.cpp: 13446 (WTR::createOtherPage): 13447 (WTR::TestController::initialize): 13448 134492010-10-27 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 13450 13451 Reviewed by Ojan Vafai. 13452 13453 Make http locking default in NRWT. 13454 https://bugs.webkit.org/show_bug.cgi?id=48053 13455 13456 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 13457 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 13458 134592010-10-27 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 13460 13461 Reviewed by Tony Chang. 13462 13463 [NRWT] Fix http lock on Windows platform 13464 https://bugs.webkit.org/show_bug.cgi?id=48321 13465 13466 * Scripts/webkitpy/layout_tests/port/http_lock.py: 13467 134682010-10-27 Satish Sampath <satish@chromium.org> 13469 13470 Unreviewed, rolling out r70665. 13471 http://trac.webkit.org/changeset/70665 13472 https://bugs.webkit.org/show_bug.cgi?id=47089 13473 13474 Need to address Alexey's review comments. 13475 13476 * DumpRenderTree/LayoutTestController.cpp: 13477 (setMockSpeechInputResultCallback): 13478 * DumpRenderTree/LayoutTestController.h: 13479 * DumpRenderTree/chromium/LayoutTestController.cpp: 13480 (LayoutTestController::setMockSpeechInputResult): 13481 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 13482 (LayoutTestController::setMockSpeechInputResult): 13483 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 13484 (LayoutTestController::setMockSpeechInputResult): 13485 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 13486 (LayoutTestController::setMockSpeechInputResult): 13487 * DumpRenderTree/qt/LayoutTestControllerQt.h: 13488 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 13489 (LayoutTestController::setMockSpeechInputResult): 13490 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 13491 (LayoutTestController::setMockSpeechInputResult): 13492 134932010-10-27 Leandro Gracia Gil <leandrogracia@google.com> 13494 13495 Reviewed by Jeremy Orlow. 13496 13497 Added a second parameter to setMockSpeechInputResult for 13498 the language used in speech input. 13499 https://bugs.webkit.org/show_bug.cgi?id=47089 13500 13501 * DumpRenderTree/LayoutTestController.cpp: 13502 (setMockSpeechInputResultCallback): 13503 * DumpRenderTree/LayoutTestController.h: 13504 * DumpRenderTree/chromium/LayoutTestController.cpp: 13505 (LayoutTestController::setMockSpeechInputResult): 13506 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 13507 (LayoutTestController::setMockSpeechInputResult): 13508 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 13509 (LayoutTestController::setMockSpeechInputResult): 13510 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 13511 (LayoutTestController::setMockSpeechInputResult): 13512 * DumpRenderTree/qt/LayoutTestControllerQt.h: 13513 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 13514 (LayoutTestController::setMockSpeechInputResult): 13515 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 13516 (LayoutTestController::setMockSpeechInputResult): 13517 (LayoutTestController::pageSizeAndMarginsInPixels): 13518 135192010-10-27 Adam Roben <aroben@apple.com> 13520 13521 Reset TestNetscapePlugIn's NPP_GetValue pointer when 13522 NullNPPGetValuePointer finishes running 13523 13524 Fixes <http://webkit.org/b/48435> REGRESSION (r70655): Many plugins 13525 tests are failing on Qt 13526 13527 Reviewed by Anders Carlsson. 13528 13529 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 13530 (PluginTest::NPP_Destroy): 13531 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: 13532 Added a do-nothing NPP_Destroy implementation. 13533 13534 * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp: 13535 (NullNPPGetValuePointer::NullNPPGetValuePointer): Save the original 13536 NPP_GetValue pointer in m_originalNPPGetValuePointer so we can restore 13537 it later. 13538 (NullNPPGetValuePointer::NPP_Destroy): Added. Restores the original 13539 NPP_GetValue pointer so it can be used in other tests. 13540 13541 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 13542 (NPP_Destroy): 13543 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 13544 (webkit_test_plugin_destroy_instance): 13545 Call through to the PluginTest when NPP_Destroy is called. 13546 135472010-10-26 Brian Weinstein <bweinstein@apple.com> 13548 13549 Reviewed by Adam Roben. 13550 13551 WebKit2 shouldn't try to send an empty user agent 13552 https://bugs.webkit.org/show_bug.cgi?id=48397 13553 13554 Add a test that when we set our custom user agent to an empty string, we don't send 13555 an empty user agent. 13556 13557 * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Added. 13558 (TestWebKitAPI::didRunJavaScript): Make sure that the result of navigator.userAgent isn't empty. 13559 (TestWebKitAPI::TEST): Set our custom user agent to the empty string, and run navigator.userAgent. 13560 13561 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add the new file. 13562 * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto. 13563 135642010-10-27 Adam Roben <aroben@apple.com> 13565 13566 Check in file I forgot in r70653 13567 13568 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 13569 (NP_Initialize): Save the NPPluginFuncs struct the browser passed to us 13570 so we can be naughty and modify it later. 13571 135722010-10-27 Adam Roben <aroben@apple.com> 13573 13574 Test that WebKit doesn't crash if the plugin passes 0 for its 13575 NPP_GetValue pointer 13576 13577 Test for <http://webkit.org/b/48433> Crash in 13578 NetscapePlugin::shouldLoadSrcURL when using Shockwave Director 10.3 in 13579 WebKit2 on Windows 13580 13581 Reviewed by Eric Carlson. 13582 13583 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 13584 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 13585 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 13586 * GNUmakefile.am: 13587 Added NullNPPGetValuePointer.cpp. 13588 13589 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 13590 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: 13591 Set up a place to store the NPPluginFuncs struct the browser passed to us. 13592 13593 * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp: Added. 13594 (NullNPPGetValuePointer::NullNPPGetValuePointer): Null out the 13595 NPP_GetValue pointer we passed to the browser to simulate a plugin that 13596 doesn't implement NPP_GetValue. 13597 (NullNPPGetValuePointer::NPP_GetValue): Print an error message. If this 13598 function is called, it means that WebKit has changed in a way that 13599 makes this test invalid. 13600 13601 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 13602 (NP_GetEntryPoints): Save the NPPluginFuncs struct the browser passed 13603 to us so we can be naughty and modify it later. 13604 136052010-10-27 Ademar de Souza Reis Jr <ademar.reis@openbossa.org> 13606 13607 Reviewed by Andreas Kling. 13608 13609 Remove references to ancient QGVLauncher and QtLauncher 13610 https://bugs.webkit.org/show_bug.cgi?id=48430 13611 13612 QtTestBrowser substitutes both and has checks enabled. 13613 13614 * Scripts/webkitpy/style/checker.py: remove references 13615 * Scripts/webkitpy/style/checker_unittest.py: ditto 13616 136172010-10-27 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 13618 13619 Reviewed by Ojan Vafai. 13620 13621 [NRWT] Don't use image hash when it's no need in single test mode. 13622 https://bugs.webkit.org/show_bug.cgi?id=48326 13623 13624 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 13625 136262010-10-27 David Kilzer <ddkilzer@apple.com> 13627 13628 Fix leak of CFMutableDictionaryRef in createXMLStringFromWebArchiveData() 13629 13630 Reviewed by Adam Roben. 13631 13632 Follow-up fix for: <https://bugs.webkit.org/show_bug.cgi?id=48278> 13633 13634 * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: 13635 (createXMLStringFromWebArchiveData): Use RetainPtr<> to fix a 13636 leak introduced in r70613. 13637 136382010-10-27 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 13639 13640 Reviewed by Csaba Osztrogonác. 13641 13642 [NRWT] Add platform specific baseline search paths for Qt port 13643 https://bugs.webkit.org/show_bug.cgi?id=48428 13644 13645 * Scripts/webkitpy/layout_tests/port/qt.py: 13646 136472010-10-27 Adam Roben <aroben@apple.com> 13648 13649 Catch exceptions when checking if we're inside a git working directory 13650 13651 Fixes <http://webkit.org/b/48420> REGRESSION (r70562): test-webkitpy 13652 fails on systems without git installed 13653 13654 Reviewed by Anders Carlsson. 13655 13656 * Scripts/webkitpy/common/net/credentials.py: 13657 (Credentials._credentials_from_git): Put the call to 13658 Git.in_working_directory inside the try/except since it, too, attempts 13659 to execute git and thus will throw on systems that don't have git 13660 installed. 13661 136622010-10-27 Nikolas Zimmermann <nzimmermann@rim.com> 13663 13664 Reviewed by David Kilzer. 13665 13666 Convert DumpRenderTree webarchive code to CoreFoundation 13667 https://bugs.webkit.org/show_bug.cgi?id=48278 13668 13669 CFPropertyListCreateWithData and CFPropertyListCreateData are only available in 10.6+. 13670 Replace CFPropertyListCreateWithData by a combination of CFReadStreamCreateWithBytesNoCopy and CFPropertyListCreateFromStream. 13671 Replace CFPropertyListCreateData by CFPropertyListCreateXMLData. 13672 13673 These changes are wrapped in BUILDING_ON_LEOPARD, as the methods are deprecated on 10.6+. 13674 13675 * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: 13676 (createXMLStringFromWebArchiveData): 13677 136782010-10-26 Antonio Gomes <agomes@rim.com> 13679 13680 Reviewed by Martin Robinson. 13681 13682 Remove the absolute path used to include DumpRenderTreeSupportGtk.h from LayoutTestController.h 13683 13684 It turns out this is rather unneeded since WebKitTools/GNUMakefile.am has WebKit/gtk/ in its include 13685 path, and then we can just do #include "WebCoreSupport/DumpRenderTreeSupportGtk.h" 13686 13687 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 13688 136892010-10-26 David Kilzer <ddkilzer@apple.com> 13690 13691 Rename WebArchiveDumpSupport.mm to WebArchiveDumpSupport.cpp 13692 13693 Reviewed by Adam Roben. 13694 13695 Part 4 of 4: <http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation 13696 13697 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 13698 Updated for file moves and renames. 13699 * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Renamed from DumpRenderTree/mac/WebArchiveDumpSupport.mm. 13700 * DumpRenderTree/cf/WebArchiveDumpSupport.h: Renamed from DumpRenderTree/mac/WebArchiveDumpSupport.h. 13701 137022010-10-26 David Kilzer <ddkilzer@apple.com> 13703 13704 Convert WebArchiveDumpSupport.mm from NS objects to CF types 13705 13706 Reviewed by Adam Roben. 13707 13708 Part 3 of 4: <http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation 13709 13710 In order to share WebArchive code between the Mac and Windows 13711 ports, the code in WebArchiveDumpSupport.mm was converted from 13712 Cocoa to C++ using CoreFoundation (CF) types. 13713 13714 * DumpRenderTree/mac/DumpRenderTree.mm: 13715 (dump): Renamed serializeWebArchiveToXML() to 13716 createXMLStringFromWebArchiveData() and added HardAutorelease() 13717 to prevent leaks. 13718 * DumpRenderTree/mac/WebArchiveDumpSupport.h: 13719 (createXMLStringFromWebArchiveData): Renamed from 13720 serializeWebArchiveToXML(). Changed to use CF types. 13721 (createCFURLResponseFromResponseData): Renamed from 13722 unarchiveNSURLResponseFromResponseData(). Changed to use CF 13723 types for its parameter and return type. 13724 * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Replaced use of 13725 NS objects with CF types. It will be renamed to *.cpp in a 13726 future commit. 13727 (convertMIMEType): Changed to use case-insensitive string 13728 comparisons. 13729 (convertWebResourceDataToString): 13730 (normalizeHTTPResponseHeaderFields): 13731 (normalizeWebResourceURL): 13732 (convertWebResourceResponseToDictionary): 13733 (compareResourceURLs): 13734 (createXMLStringFromWebArchiveData): 13735 * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: 13736 (createCFURLResponseFromResponseData): Renamed from 13737 unarchiveNSURLResponseFromResponseData(). Changed to use CF 13738 types for its parameter and return type. 13739 137402010-10-26 David Kilzer <ddkilzer@apple.com> 13741 13742 Extract use of NSKeyedUnarchiver from WebArchiveDumpSupport.mm 13743 13744 Reviewed by Adam Roben. 13745 13746 Part 2 of 4: <http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation 13747 13748 There is no equivalent to NSKeyedUnarchiver in CoreFoundation, 13749 so extract it into a platform-specific source file. 13750 13751 * DumpRenderTree/mac/WebArchiveDumpSupport.h: 13752 (unarchiveNSURLResponseFromResponseData): Added declaration. 13753 * DumpRenderTree/mac/WebArchiveDumpSupport.mm: 13754 (convertWebResourceResponseToDictionary): Extracted code to 13755 unarchiveNSURLResponseFromResponseData() in 13756 WebArchiveDumpSupportMac.mm. Updated logic to return early if 13757 nil is returned from unarchiveNSURLResponseFromResponseData(). 13758 * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: 13759 (unarchiveNSURLResponseFromResponseData): Added. Extracted 13760 code from convertWebResourceResponseToDictionary() in 13761 WebArchiveDumpSupport.mm. 13762 137632010-10-26 David Kilzer <ddkilzer@apple.com> 13764 13765 Extract call to -[WebHTMLRepresentation supportedNonImageMIMETypes] from WebArchiveDumpSupport.mm 13766 13767 Reviewed by Adam Roben. 13768 13769 Part 1 of 4: <http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation 13770 13771 The call to -[WebHTMLRepresentation supportedNonImageMIMETypes] 13772 is not cross-platform between Mac and Windows, so extract it 13773 into a platform-specific source file. 13774 13775 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added 13776 WebArchiveDumpSupportMac.mm to the project. 13777 * DumpRenderTree/mac/WebArchiveDumpSupport.h: 13778 (supportedNonImageMIMETypes): Added declaration. 13779 * DumpRenderTree/mac/WebArchiveDumpSupport.mm: 13780 (convertWebResourceDataToString): Replaced call to 13781 -[WebHTMLRepresentation supportedNonImageMIMETypes] with 13782 supportedNonImageMIMETypes(). 13783 * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Added. 13784 (supportedNonImageMIMETypes): Added. Extracted from 13785 WebArchiveDumpSupport.mm. 13786 137872010-10-26 Antonio Gomes <agomes@rim.com> 13788 13789 Reviewed by Martin Robinson. 13790 13791 [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea) 13792 https://bugs.webkit.org/show_bug.cgi?id=48199 13793 13794 Implements support to WebKitTabToLinksPreferenceKey through LayoutTestController::overridePreference. 13795 The corresponding DumpRenderTreeSupportGtk method is called in the DRT context only. 13796 13797 * DumpRenderTree/gtk/DumpRenderTree.cpp: 13798 (resetDefaultsToConsistentValues): 13799 (createWebView): 13800 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 13801 (LayoutTestController::overridePreference): 13802 138032010-10-26 Ariya Hidayat <ariya@sencha.com> 13804 13805 Unreviewed, change the order of my emails for bugzilla autocompletion. 13806 13807 * Scripts/webkitpy/common/config/committers.py: 13808 138092010-10-26 Eric Seidel <eric@webkit.org> 13810 13811 Reviewed by David Kilzer. 13812 13813 build-webkit should collect Visual Studio Express logs and display them 13814 https://bugs.webkit.org/show_bug.cgi?id=39199 13815 13816 * Scripts/build-webkit: 13817 * Scripts/print-vse-failure-logs: Added. 13818 * Scripts/webkitdirs.pm: 13819 138202010-10-26 David Kilzer <ddkilzer@apple.com> 13821 13822 <http://webkit.org/b/48224> build-webkit: add support for --meter-tag switch 13823 13824 Reviewed by Csaba Osztrogonác. 13825 13826 * Scripts/build-webkit: Added support for --meter-tag switch. 13827 It should have been added with r60820. 13828 138292010-10-26 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org> 13830 13831 Reviewed by Dumitru Daniliuc. 13832 13833 check-webkit-style fails on operator+=, operator-=, ... methods 13834 https://bugs.webkit.org/show_bug.cgi?id=48258 13835 13836 * Scripts/webkitpy/style/checkers/cpp.py: Added exceptions 13837 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit-tests 13838 138392010-10-26 Ojan Vafai <ojan@chromium.org> 13840 13841 Reviewed by Tony Chang. 13842 13843 remove DEFER support from new-run-webkit-tests 13844 https://bugs.webkit.org/show_bug.cgi?id=48387 13845 13846 DEFER was needed when we were trying to ship Chrome beta. 13847 Now it's just extra complication. 13848 13849 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 13850 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 13851 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 13852 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 13853 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 13854 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: 13855 138562010-10-26 Eric Seidel <eric@webkit.org> 13857 13858 Unreviewed. Adding import with_statement to fix python 2.5. 13859 13860 Teach webkit-patch how to read credentials from the environment 13861 https://bugs.webkit.org/show_bug.cgi?id=48275 13862 13863 * Scripts/webkitpy/common/net/credentials_unittest.py: 13864 - import with_statement to fix python 2.5. 13865 138662010-10-26 Alexey Proskuryakov <ap@apple.com> 13867 13868 Reviewed by Sam Weinig. 13869 13870 https://bugs.webkit.org/show_bug.cgi?id=48375 13871 <rdar://problem/8392724> Need delegate calls in PageLoaderClient to indicate if we have 13872 loaded insecure content 13873 13874 Updated for WebKit2 changes. 13875 13876 * MiniBrowser/mac/BrowserWindowController.m: 13877 (didDisplayInsecureContentForFrame): 13878 (didRunInsecureContentForFrame): 13879 (-[BrowserWindowController awakeFromNib]): 13880 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 13881 (WTR::InjectedBundlePage::InjectedBundlePage): 13882 (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame): 13883 (WTR::InjectedBundlePage::didRunInsecureContentForFrame): 13884 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 13885 * WebKitTestRunner/TestController.cpp: 13886 (WTR::TestController::initialize): 13887 138882010-10-26 Adam Roben <aroben@apple.com> 13889 13890 Clear up confusion between "3D rendering" and "accelerated compositing" 13891 13892 WebKit has no software-based 3D rendering implementation, so 3D 13893 rendering can only be enabled when accelerated compositing is. But DRT 13894 was falsely reporting that 3D rendering was available on machines that 13895 don't support accelerated compositing, leading to much confusion. 13896 13897 Reviewed by Darin Adler. 13898 13899 Fixes <http://webkit.org/b/48370> REGRESSION (r70540): Many 13900 transforms/3d tests are failing on the XP bots 13901 13902 * DumpRenderTree/win/DumpRenderTree.cpp: 13903 (main): When ENABLE(3D_RENDERING) is turned on, only report that 3D 13904 rendering is available when acclerated compositing is also available. 13905 13906 * Scripts/old-run-webkit-tests: Skip tests that use the 13907 -webkit-transform-3d media query when 3D rendering is disabled, 13908 rather than when accelerated compositing is disabled. 13909 139102010-10-26 Eric Seidel <eric@webkit.org> 13911 13912 Reviewed by Ojan Vafai. 13913 13914 Remove rietveld code now that it's unused 13915 https://bugs.webkit.org/show_bug.cgi?id=48359 13916 13917 Was cool that we added this support, but now that it's 13918 not used it makes little sense to keep it around. 13919 We can always restore this code from SVN if we need it. 13920 13921 * Scripts/webkitpy/common/config/__init__.py: 13922 * Scripts/webkitpy/common/net/bugzilla.py: 13923 * Scripts/webkitpy/common/net/bugzilla_unittest.py: 13924 * Scripts/webkitpy/common/net/rietveld.py: Removed. 13925 * Scripts/webkitpy/common/net/rietveld_unittest.py: Removed. 13926 * Scripts/webkitpy/thirdparty/__init__.py: 13927 * Scripts/webkitpy/tool/commands/download.py: 13928 * Scripts/webkitpy/tool/commands/download_unittest.py: 13929 * Scripts/webkitpy/tool/commands/queues.py: 13930 * Scripts/webkitpy/tool/commands/queues_unittest.py: 13931 * Scripts/webkitpy/tool/main.py: 13932 * Scripts/webkitpy/tool/mocktool.py: 13933 * Scripts/webkitpy/tool/steps/__init__.py: 13934 * Scripts/webkitpy/tool/steps/postcodereview.py: Removed. 13935 139362010-10-26 Anders Carlsson <andersca@apple.com> 13937 13938 Reviewed by Sam Weinig. 13939 13940 pageDidScroll callback should be on the UI process client rather than (or in addition to) the web process client 13941 https://bugs.webkit.org/show_bug.cgi?id=48366 13942 <rdar://problem/8595202> 13943 13944 * MiniBrowser/mac/BrowserWindowController.m: 13945 (-[BrowserWindowController awakeFromNib]): 13946 * WebKitTestRunner/TestController.cpp: 13947 (WTR::createOtherPage): 13948 (WTR::TestController::initialize): 13949 139502010-10-26 Eric Seidel <eric@webkit.org> 13951 13952 Reviewed by Tony Chang. 13953 13954 Teach webkit-patch how to read credentials from the environment 13955 https://bugs.webkit.org/show_bug.cgi?id=48275 13956 13957 This makes it possible for svn users to have their bugzilla credentials 13958 stored in their environment instead of typing them every time. 13959 13960 We need this for making it easy to run the win-ews bot (which currently 13961 uses svn instead of git). 13962 13963 * Scripts/webkitpy/common/net/credentials.py: 13964 * Scripts/webkitpy/common/net/credentials_unittest.py: 13965 139662010-10-26 Kenichi Ishibashi <bashi@google.com> 13967 13968 Reviewed by Kent Tamura. 13969 13970 Input Method inserts conversion candidates unexpectedly 13971 https://bugs.webkit.org/show_bug.cgi?id=46868 13972 13973 Adds setComposition() to TextInputController to make DRT emulate 13974 an input method behavior. 13975 13976 * DumpRenderTree/chromium/TextInputController.cpp: 13977 (TextInputController::TextInputController): 13978 (TextInputController::setComposition): Added. 13979 * DumpRenderTree/chromium/TextInputController.h: 13980 139812010-10-26 Simon Fraser <simon.fraser@apple.com> 13982 13983 Reviewed by Sam Weinig. 13984 13985 Support layoutTestController.layerTreeAsText in WebKitTestRunner 13986 https://bugs.webkit.org/show_bug.cgi?id=42145 13987 13988 Implement layerTreeAsText() in WebKitTestRunner. 13989 13990 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 13991 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 13992 (WTR::LayoutTestController::layerTreeAsText): 13993 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 13994 139952010-10-26 Adam Barth <abarth@webkit.org> 13996 13997 Reviewed by Eric Seidel. 13998 13999 webkit-patch rollout produces incorrect patch when using svn move 14000 https://bugs.webkit.org/show_bug.cgi?id=48244 14001 14002 We need to flush our caches when we modify the working copy. 14003 14004 * Scripts/webkitpy/tool/steps/revertrevision.py: 14005 140062010-10-26 Eric Seidel <eric@webkit.org> 14007 14008 Reviewed by Adam Barth. 14009 14010 commit-queue flaky test message can list the same author more than once 14011 https://bugs.webkit.org/show_bug.cgi?id=48268 14012 14013 tonikitoo reported to me over IRC this morning that he's seen 14014 the commit-queue report flaky tests with author lists like: 14015 "adam, adam and adam", suggesting we're not uniquing authors 14016 before writing the message. 14017 14018 I fixed the uniquing and added a bunch more unit testing. 14019 14020 * Scripts/webkitpy/tool/commands/queues.py: 14021 * Scripts/webkitpy/tool/commands/queues_unittest.py: 14022 * Scripts/webkitpy/tool/mocktool.py: 14023 140242010-10-26 Adam Roben <aroben@apple.com> 14025 14026 Pull in the FeatureDefines*.vsprops files when building DRT 14027 14028 This ensures that various ENABLE() macros will get set correctly. 14029 (Prior to r70320 we were picking up the ENABLE(3D_RENDERING) flag 14030 through wtf/Platform.h.) 14031 14032 Fixes <http://webkit.org/b/48343> REGRESSION (r70320): DumpRenderTree 14033 says 3D_RENDERING is disabled even when it is enabled 14034 14035 Reviewed by Ada Chan. 14036 14037 * DumpRenderTree/win/DumpRenderTree.vcproj: Added 14038 FeaturesDefines*.vsprops to all configurations. 14039 14040 * DumpRenderTree/win/DumpRenderTreeWin.h: Touched to force a rebuild. 14041 140422010-10-26 Søren Gjesse <sgjesse@chromium.org> 14043 14044 Reviewed by Dimitri Glazkov. 14045 14046 Added options --multiple-loads and --js-flags to chromium DumpRenderTree. The option --multiple-loads=X 14047 is used to have DumpRenderTree load each test it runs X times. To be able to have more fine-grained control 14048 of how the JavaScript engine behaves for each load the flag --js-flags can specify a list of flag-sets like this 14049 14050 --js-flags="--xxx,--noxxx --yyy,--noyyy" 14051 14052 First load will run with --xxx, the second with --yyy and the third without any (the 'no' prefix is handled by 14053 V8 to turn off the flag). 14054 14055 The changes to the Python test runner will be in a separate change. 14056 14057 14058 * DumpRenderTree/chromium/DumpRenderTree.cpp: 14059 (runTest): 14060 (main): 14061 * DumpRenderTree/chromium/TestShell.cpp: 14062 (TestShell::TestShell): 14063 (TestShell::runFileTest): 14064 (TestShell::testFinished): 14065 * DumpRenderTree/chromium/TestShell.h: 14066 (TestShell::loadCount): 14067 (TestShell::setLoadCount): 14068 (TestShell::javaScriptFlagsForLoad): 14069 (TestShell::setJavaScriptFlags): 14070 (TestShell::setDumpWhenFinished): 14071 140722010-10-26 Adam Roben <aroben@apple.com> 14073 14074 Skip more tests that depend on accelerated compositing when accelerated 14075 compositing is disabled 14076 14077 Fixes <http://webkit.org/b/48329> Some tests fail when accelerated 14078 compositing is disabled 14079 14080 Reviewed by John Sullivan. 14081 14082 * Scripts/old-run-webkit-tests: Added more tests to skip when 14083 accelerated compositing is disable. The tests all have output that 14084 changes depending on whether accelerated compositing is enabled. 14085 140862010-10-25 Eric Seidel <eric@webkit.org> 14087 14088 Reviewed by Adam Barth. 14089 14090 webkit-patch should clean up svn locks when passed --force-clean 14091 https://bugs.webkit.org/show_bug.cgi?id=48269 14092 14093 * Scripts/webkitpy/common/checkout/scm.py: 14094 140952010-10-25 Anders Carlsson <andersca@apple.com> 14096 14097 Reviewed by Adam Roben. 14098 14099 Add a pageDidScroll BundleUIClient callback 14100 https://bugs.webkit.org/show_bug.cgi?id=48260 14101 <rdar://problem/8531159> 14102 14103 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 14104 (WTR::InjectedBundlePage::InjectedBundlePage): 14105 141062010-10-25 Johnny Ding <jnd@chromium.org> 14107 14108 Reviewed by Tony Chang. 14109 14110 Dump the gesture status of frame in frame load callbacks in DumpRenderTree 14111 by adding a new method dumpUserGestureInFrameLoadCallbacks. 14112 Now only dump the gesture status in "DidStartProvisionalLoad" callback. 14113 https://bugs.webkit.org/show_bug.cgi?id=47849 14114 14115 * DumpRenderTree/LayoutTestController.cpp: 14116 (LayoutTestController::LayoutTestController): 14117 (dumpUserGestureInFrameLoadCallbacksCallback): 14118 (LayoutTestController::staticFunctions): 14119 * DumpRenderTree/LayoutTestController.h: 14120 (LayoutTestController::dumpUserGestureInFrameLoadCallbacks): 14121 (LayoutTestController::setDumpUserGestureInFrameLoadCallbacks): 14122 * DumpRenderTree/chromium/LayoutTestController.cpp: 14123 (LayoutTestController::LayoutTestController): 14124 (LayoutTestController::dumpUserGestureInFrameLoadCallbacks): 14125 (LayoutTestController::reset): 14126 * DumpRenderTree/chromium/LayoutTestController.h: 14127 (LayoutTestController::shouldDumpUserGestureInFrameLoadCallbacks): 14128 (LayoutTestController::setShouldDumpUserGestureInFrameLoadCallbacks): 14129 * DumpRenderTree/chromium/TestShell.h: 14130 (TestShell::shouldDumpUserGestureInFrameLoadCallbacks): 14131 * DumpRenderTree/chromium/WebViewHost.cpp: 14132 (WebViewHost::didStartProvisionalLoad): 14133 (WebViewHost::printFrameUserGestureStatus): 14134 * DumpRenderTree/chromium/WebViewHost.h: 14135 * DumpRenderTree/mac/FrameLoadDelegate.mm: 14136 (-[WebFrame _drt_printFrameUserGestureStatus]): 14137 (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): 14138 (-[FrameLoadDelegate webView:didCommitLoadForFrame:]): 14139 (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): 14140 (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): 14141 (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): 14142 (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): 14143 (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]): 14144 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 14145 (LayoutTestController::reset): 14146 (LayoutTestController::dumpUserGestureInFrameLoadCallbacks): 14147 * DumpRenderTree/qt/LayoutTestControllerQt.h: 14148 141492010-10-25 Sheriff Bot <webkit.review.bot@gmail.com> 14150 14151 Unreviewed, rolling out r70442. 14152 http://trac.webkit.org/changeset/70442 14153 https://bugs.webkit.org/show_bug.cgi?id=48248 14154 14155 http locking doesn't work on Windows (Requested by Ossy on 14156 #webkit). 14157 14158 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 14159 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 14160 141612010-10-25 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 14162 14163 Reviewed by Ojan Vafai. 14164 14165 Make http locking default in NRWT. 14166 https://bugs.webkit.org/show_bug.cgi?id=48053 14167 14168 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 14169 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 14170 141712010-10-25 David Kilzer <ddkilzer@apple.com> 14172 14173 <http://webkit.org/b/48185> build-webkit: add support for --progress-tag switch 14174 (Re-landing r70413 after Qt minimal buildfix: r70440.) 14175 14176 Reviewed by Kenneth Rohde Christiansen. 14177 14178 * Scripts/build-webkit: Added support for --progress-tag switch. 14179 It should have been added with r57051. 14180 141812010-10-24 Adam Barth <abarth@webkit.org> 14182 14183 Reviewed by David Kilzer. 14184 14185 webkit-patch upload fails when the patch removes a file 14186 https://bugs.webkit.org/show_bug.cgi?id=48187 14187 14188 We need to use "--" to separate file names from the rest of the 14189 command. 14190 14191 * Scripts/webkitpy/common/checkout/scm.py: 14192 141932010-10-24 Sheriff Bot <webkit.review.bot@gmail.com> 14194 14195 Unreviewed, rolling out r70413. 14196 http://trac.webkit.org/changeset/70413 14197 https://bugs.webkit.org/show_bug.cgi?id=48210 14198 14199 It broke Qt minimal build (Requested by Ossy on #webkit). 14200 14201 * Scripts/build-webkit: 14202 142032010-10-24 Yi Shen <yi.4.shen@nokia.com> 14204 14205 Reviewed by Andreas Kling. 14206 14207 [Qt][QtTestBrowser] Toggle use of QGraphicsView messes up the menu 14208 https://bugs.webkit.org/show_bug.cgi?id=48141 14209 14210 * QtTestBrowser/launcherwindow.cpp: 14211 (LauncherWindow::init): 14212 (LauncherWindow::initializeView): 14213 (LauncherWindow::toggleWebView): 14214 142152010-10-24 Daniel Bates <dbates@rim.com> 14216 14217 Reviewed by David Kilzer. 14218 14219 Fix Perl uninitialized warnings in VCSUtils::svnStatus() 14220 and VCSUtils::removeEOL(). 14221 https://bugs.webkit.org/show_bug.cgi?id=48196 14222 14223 VCSUtils::svnStatus() concatenates the output of svn status with 14224 a new line character and svn status may return no output (say for 14225 a file that has not been added, deleted, or modified). We should 14226 only concatenate the output of svn status if there is some. 14227 14228 Also, VCSUtils::removeEOL() should ensure that its argument 14229 is initialized before performing a string substitution. 14230 14231 * Scripts/VCSUtils.pm: 14232 - Modified removeEOL() to return "" if its argument is undefined. 14233 - Exported removeEOL() so that it can be tested. 14234 * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Added. 14235 142362010-10-24 David Kilzer <ddkilzer@apple.com> 14237 14238 <http://webkit.org/b/48185> build-webkit: add support for --progress-tag switch 14239 14240 Reviewed by Kenneth Rohde Christiansen. 14241 14242 * Scripts/build-webkit: Added support for --progress-tag switch. 14243 It should have been added with r57051. 14244 142452010-10-24 David Kilzer <ddkilzer@apple.com> 14246 14247 <http://webkit.org/b/48184> build-webkit: reformat support variables for better maintainability 14248 14249 Reviewed by Daniel Bates. 14250 14251 * Scripts/build-webkit: Alphabetized the @features array based 14252 on the name of the feature. Reformatted the list of support 14253 variables so that they match the order of @features, and so that 14254 each has its own line. This makes it easy to add new variables 14255 in the correct order. 14256 142572010-10-23 Eric Seidel <eric@webkit.org> 14258 14259 Reviewed by Adam Barth. 14260 14261 EWS never removes invalid patch ids 14262 https://bugs.webkit.org/show_bug.cgi?id=48173 14263 14264 This is just sticking another finger in the dam. 14265 However this adds more unit testing which will help 14266 us make sure we're always releasing patches once we 14267 redesign the release_patch API and call these from 14268 a more central place. 14269 14270 * Scripts/webkitpy/tool/commands/queues.py: 14271 * Scripts/webkitpy/tool/commands/queues_unittest.py: 14272 * Scripts/webkitpy/tool/mocktool.py: 14273 - Added the ability to request invalid patches. 14274 Log a warning message to make sure we don't ever have 14275 tests use invalid patch fetches by mistake. 14276 142772010-10-23 Dan Bernstein <mitz@apple.com> 14278 14279 Build fix. Add stub implementations for required NSDraggingInfo methods. 14280 14281 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: 14282 (-[DumpRenderTreeDraggingInfo draggingFormation]): 14283 (-[DumpRenderTreeDraggingInfo setDraggingFormation:]): 14284 (-[DumpRenderTreeDraggingInfo animatesToDestination]): 14285 (-[DumpRenderTreeDraggingInfo setAnimatesToDestination:]): 14286 (-[DumpRenderTreeDraggingInfo numberOfValidItemsForDrop]): 14287 (-[DumpRenderTreeDraggingInfo setNumberOfValidItemsForDrop:]): 14288 (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]): 14289 142902010-10-23 David Kilzer <ddkilzer@apple.com> 14291 14292 <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header 14293 14294 Reviewed by Sam Weinig. 14295 14296 The only method defined in WebHTMLRepresentationInternal.h is 14297 also defined in WebHTMLRepresentation.h, so use that instead. 14298 14299 * DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Removed. 14300 * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Switched to use 14301 WebHTMLRepresentation.h. 14302 143032010-10-23 Sheriff Bot <webkit.review.bot@gmail.com> 14304 14305 Unreviewed, rolling out r70367. 14306 http://trac.webkit.org/changeset/70367 14307 https://bugs.webkit.org/show_bug.cgi?id=48176 14308 14309 It made 8-10 tests crash on Qt bot (Requested by Ossy on 14310 #webkit). 14311 14312 * DumpRenderTree/LayoutTestController.cpp: 14313 (setCustomPolicyDelegateCallback): 14314 * DumpRenderTree/LayoutTestController.h: 14315 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 14316 (LayoutTestController::setCustomPolicyDelegate): 14317 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 14318 (LayoutTestController::setCustomPolicyDelegate): 14319 * DumpRenderTree/mac/PolicyDelegate.h: 14320 * DumpRenderTree/mac/PolicyDelegate.mm: 14321 (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): 14322 (-[PolicyDelegate setPermissive:]): 14323 (-[PolicyDelegate setControllerToNotifyDone:]): 14324 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 14325 (LayoutTestController::setCustomPolicyDelegate): 14326 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 14327 (LayoutTestController::setCustomPolicyDelegate): 14328 143292010-10-22 Eric Seidel <eric@webkit.org> 14330 14331 Reviewed by Adam Barth. 14332 14333 EWS never releases patches which fail to apply 14334 https://bugs.webkit.org/show_bug.cgi?id=48171 14335 14336 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 14337 * Scripts/webkitpy/tool/commands/queues.py: 14338 143392010-10-22 Eric Seidel <eric@webkit.org> 14340 14341 Unreviewed. 14342 14343 Make the EWS queues restart themselves more often. 14344 This matches the commit-queue. 14345 14346 * EWSTools/start-queue.sh: 14347 143482010-10-22 Eric Seidel <eric@webkit.org> 14349 14350 Reviewed by Adam Barth. 14351 14352 commit-queue should not pass --quiet to subcommands now that the parent command does the reporting 14353 https://bugs.webkit.org/show_bug.cgi?id=48165 14354 14355 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 14356 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 14357 * Scripts/webkitpy/tool/commands/queues_unittest.py: 14358 143592010-10-22 Mario Sanchez Prada <msanchez@igalia.com> 14360 14361 Adding myself as a committer. 14362 14363 * Scripts/webkitpy/common/config/committers.py: 14364 143652010-10-20 Anders Carlsson <andersca@apple.com> 14366 14367 Reviewed by Adam Barth and Darin Adler. 14368 14369 Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work 14370 https://bugs.webkit.org/show_bug.cgi?id=48014 14371 <rdar://problem/8202716> 14372 14373 * DumpRenderTree/LayoutTestController.cpp: 14374 (setCustomPolicyDelegateCallback): 14375 Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument. 14376 14377 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 14378 (LayoutTestController::setCustomPolicyDelegate): 14379 Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument. 14380 14381 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 14382 (LayoutTestController::setCustomPolicyDelegate): 14383 Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument. 14384 14385 * DumpRenderTree/mac/PolicyDelegate.h: 14386 * DumpRenderTree/mac/PolicyDelegate.mm: 14387 (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]): 14388 If _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond is true, call [listener ignore] after one second. 14389 14390 (-[PolicyDelegate setCallIgnoreInDecidePolicyForMIMETypeAfterOneSecond:]): 14391 Update _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond. 14392 14393 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 14394 (LayoutTestController::setCustomPolicyDelegate): 14395 Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument. 14396 14397 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 14398 (LayoutTestController::setCustomPolicyDelegate): 14399 Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument. 14400 144012010-10-22 Sam Weinig <sam@webkit.org> 14402 14403 Reviewed by Anders Carlsson. 14404 14405 Rename the InjectedBundle for TestWebKitAPI to InjectedBundleTestWebKitAPI.bundle 14406 14407 * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: 14408 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 14409 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: 14410 (TestWebKitAPI::Util::createInjectedBundlePath): 14411 144122010-10-22 Dirk Pranke <dpranke@chromium.org> 14413 14414 Reviewed by Eric Seidel. 14415 14416 test-webkitpy fails when passed -v (or any other option) 14417 14418 Fix port/base_unittest to pass an explicit list of arguments 14419 rather than accidentally picking up sys.argv. 14420 14421 https://bugs.webkit.org/show_bug.cgi?id=48071 14422 14423 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 14424 144252010-10-22 Brian Weinstein <bweinstein@apple.com> 14426 14427 Windows build fix. Update the createNewPage callback to account for the new 14428 arguments. 14429 14430 * MiniBrowser/win/BrowserView.cpp: 14431 (createNewPage): 14432 144332010-10-22 Sam Weinig <sam@webkit.org> 14434 14435 Reviewed by Anders Carlsson. 14436 14437 WebKit2 needs to pass the current event modifier flags when requesting a new window 14438 https://bugs.webkit.org/show_bug.cgi?id=48140 14439 14440 * MiniBrowser/mac/BrowserWindowController.m: 14441 (createNewPage): 14442 * WebKitTestRunner/TestController.cpp: 14443 (WTR::createOtherPage): 14444 Update for new signature for the WKPageCreateNewPageCallback. 14445 144462010-10-22 Eric Seidel <eric@webkit.org> 14447 14448 Unreviewed. Just adding a test case. 14449 14450 The style-queue was not recognizing new patches. It turns 14451 out I had fixed this in an earlier change, but just not 14452 deployed to queues.webkit.org. As part of investigating why it 14453 was broken, I wrote a test for my previous change which I'm now landing. 14454 14455 * QueueStatusServer/model/queues_unittest.py: 14456 144572010-10-22 Eric Seidel <eric@webkit.org> 14458 14459 Reviewed by Adam Barth. 14460 14461 EWS does not need to process obsolete patches 14462 https://bugs.webkit.org/show_bug.cgi?id=48093 14463 14464 This was an easy change, but to test it I had to pipe 14465 real Attachment objects into the queue testing system. 14466 Doing so revealed a whole bunch of bugs in our unit tests, 14467 which I fixed as part of this patch. 14468 14469 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 14470 - This is the actual code change. This will not reduce the 14471 backlog in the EWS queues much, but it will make rejections 14472 much quicker for obsolete patches or closed bugs. 14473 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 14474 - Test my new code. 14475 - Used a real attachment object and got rid of MockPatch 14476 - Shared code between the mac-ews and cr-mac-ews tests. 14477 * Scripts/webkitpy/tool/commands/queues_unittest.py: 14478 - Can't use MockPatch anymore. 14479 - Removing MockPatch found more bugs here! 14480 * Scripts/webkitpy/tool/commands/queuestest.py: 14481 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 14482 * Scripts/webkitpy/tool/mocktool.py: 14483 - MockBugzilla should not be a "Mock" object. Right now tool.bugs() 14484 is allowed, but wrong. Making it not a Mock will make tool.bugs() correctly fail. 14485 144862010-10-22 Sheriff Bot <webkit.review.bot@gmail.com> 14487 14488 Unreviewed, rolling out r70301. 14489 http://trac.webkit.org/changeset/70301 14490 https://bugs.webkit.org/show_bug.cgi?id=48126 14491 14492 "Lang attribute layout tests failing" (Requested by satish on 14493 #webkit). 14494 14495 * DumpRenderTree/LayoutTestController.cpp: 14496 (setMockSpeechInputResultCallback): 14497 * DumpRenderTree/LayoutTestController.h: 14498 * DumpRenderTree/chromium/LayoutTestController.cpp: 14499 (LayoutTestController::setMockSpeechInputResult): 14500 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 14501 (LayoutTestController::setMockSpeechInputResult): 14502 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 14503 (LayoutTestController::setMockSpeechInputResult): 14504 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 14505 (LayoutTestController::setMockSpeechInputResult): 14506 * DumpRenderTree/qt/LayoutTestControllerQt.h: 14507 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 14508 (LayoutTestController::setMockSpeechInputResult): 14509 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 14510 (LayoutTestController::setMockSpeechInputResult): 14511 145122010-10-22 Leandro Gracia Gil <leandrogracia@google.com> 14513 14514 Reviewed by Jeremy Orlow. 14515 14516 Added a second parameter to setMockSpeechInputResult for 14517 the language used in speech input. 14518 https://bugs.webkit.org/show_bug.cgi?id=47089 14519 14520 * DumpRenderTree/LayoutTestController.cpp: 14521 (setMockSpeechInputResultCallback): 14522 * DumpRenderTree/LayoutTestController.h: 14523 * DumpRenderTree/chromium/LayoutTestController.cpp: 14524 (LayoutTestController::setMockSpeechInputResult): 14525 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 14526 (LayoutTestController::setMockSpeechInputResult): 14527 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 14528 (LayoutTestController::setMockSpeechInputResult): 14529 * DumpRenderTree/qt/LayoutTestControllerQt.h: 14530 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 14531 (LayoutTestController::setMockSpeechInputResult): 14532 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 14533 (LayoutTestController::setMockSpeechInputResult): 14534 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 14535 (LayoutTestController::setMockSpeechInputResult): 14536 145372010-10-21 MORITA Hajime <morrita@google.com> 14538 14539 Reviewed by Kent Tamura. 14540 14541 [Win][DRT] should have LayoutTestController.hasSpellingMarker() 14542 https://bugs.webkit.org/show_bug.cgi?id=47885 14543 14544 - Implemented LayoutTestController.hasSpellingMarker(), 14545 - Added fake spellcheck implementation. 14546 14547 * DumpRenderTree/win/DumpRenderTree.cpp: 14548 (main): 14549 * DumpRenderTree/win/EditingDelegate.cpp: 14550 (indexOfFirstWordCharacter): 14551 (wordLength): 14552 (EditingDelegate::checkSpellingOfString): 14553 * DumpRenderTree/win/EditingDelegate.h: 14554 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 14555 (LayoutTestController::hasSpellingMarker): 14556 145572010-10-21 Mihai Parparita <mihaip@chromium.org> 14558 14559 Unreviewed. Re-enable test that was mistakenly disabled by r67974. 14560 14561 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 14562 145632010-10-21 Mihai Parparita <mihaip@chromium.org> 14564 14565 Unreviewed fix for rebaseline-chromium-webkit-tests. 14566 14567 Port.diff_image no longer has a tolerance parameter. Also, use 14568 get_option('tolerance') which is safer if the options object doesn't 14569 define a tolerance attribute (it doesn't for the one used in 14570 rebaseline_chromium_webkit_tests). 14571 14572 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 14573 * Scripts/webkitpy/layout_tests/port/webkit.py: 14574 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 14575 145762010-10-21 Mihai Parparita <mihaip@chromium.org> 14577 14578 Reviewed by Ojan Vafai. 14579 14580 Add support for --tolerance in NRWT 14581 https://bugs.webkit.org/show_bug.cgi?id=47959 14582 14583 Add support for the --tolerance flag in NRWT. The Port.diff_image 14584 signature shouldn't need a tolerance parameter (it's not set per test), 14585 just have ports that use it (currently only WebKitPort) read it from 14586 the options object. 14587 14588 * Scripts/webkitpy/layout_tests/port/chromium.py: 14589 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 14590 * Scripts/webkitpy/layout_tests/port/test.py: 14591 * Scripts/webkitpy/layout_tests/port/webkit.py: 14592 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 14593 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 14594 145952010-10-21 Eric Seidel <eric@webkit.org> 14596 14597 Reviewed by Adam Barth. 14598 14599 Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch 14600 https://bugs.webkit.org/show_bug.cgi?id=48088 14601 14602 This is a first-pass. Works, but we'll eventually 14603 turn this on by default, refine the suggestion algorithm 14604 and possibly move it to a different place in the upload step order. 14605 14606 * Scripts/webkitpy/common/checkout/api.py: 14607 * Scripts/webkitpy/tool/commands/download_unittest.py: 14608 * Scripts/webkitpy/tool/commands/upload.py: 14609 * Scripts/webkitpy/tool/commands/upload_unittest.py: 14610 * Scripts/webkitpy/tool/mocktool.py: 14611 * Scripts/webkitpy/tool/steps/__init__.py: 14612 * Scripts/webkitpy/tool/steps/options.py: 14613 146142010-10-21 Mario Sanchez Prada <msanchez@igalia.com> 14615 14616 Reviewed by Chris Fleizach. 14617 14618 [GTK] Segfault while testing accessibility/iframe-bastardization.html 14619 https://bugs.webkit.org/show_bug.cgi?id=30123 14620 14621 Check m_element before actually using it to get the parent. 14622 14623 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 14624 (AccessibilityUIElement::parentElement): Add an extra check to 14625 make sure m_element points to a valid value before actually using 14626 it to get the parent. Also, assert ATK_IS_OBJECT(m_element). 14627 146282010-10-21 Anders Carlsson <andersca@apple.com> 14629 14630 Reviewed by Adam Roben. 14631 14632 Crash evaluating JavaScript string that throws an exception 14633 https://bugs.webkit.org/show_bug.cgi?id=48092 14634 <rdar://problem/8487657> 14635 14636 Add a test that evaluates a JavaScript string that throws an exception and check that 14637 the callback is called. 14638 14639 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 14640 * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Added. 14641 (TestWebKitAPI::didRunJavaScript): 14642 (TestWebKitAPI::WebKit2_EvaluateJavaScript): 14643 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 14644 146452010-10-21 Adam Roben <aroben@apple.com> 14646 14647 Test that the plugin's HWND is invalidated when NPN_InvalidateRect is 14648 called 14649 14650 Test for <http://webkit.org/b/48086> <rdar://problem/8482944> 14651 Silverlight doesn't repaint in WebKit2 14652 14653 Reviewed by Anders Carlsson. 14654 14655 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 14656 (PluginTest::NPN_InvalidateRect): Added. Calls through to the browser. 14657 (executeScript): Added. Asks the browser to evaluate the script. 14658 14659 (PluginTest::waitUntilDone): 14660 (PluginTest::notifyDone): 14661 Added. Calls through to layoutTestController. 14662 14663 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added 14664 * NPN_InvalidateRect and waitUntilDone/notifyDone. 14665 14666 * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp: Added. 14667 (TemporaryWindowMover::moveSucceeded): 14668 (TemporaryWindowMover::TemporaryWindowMover): 14669 (TemporaryWindowMover::~TemporaryWindowMover): 14670 This class moves a window on-screen and shows it, then moves it back and hides it. 14671 14672 (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow): 14673 Initialize our members. 14674 (NPNInvalidateRectInvalidatesWindow::~NPNInvalidateRectInvalidatesWindow): 14675 Delete our window mover if it hasn't been deleted already. 14676 (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Subclass the 14677 plugin HWND and move the test harness window on screen. 14678 (NPNInvalidateRectInvalidatesWindow::wndProc): Call through to onPaint 14679 when we get a WM_PAINT message. 14680 (NPNInvalidateRectInvalidatesWindow::onPaint): Do the test and tell 14681 LayoutTestController we're done. 14682 (NPNInvalidateRectInvalidatesWindow::testInvalidateRect): Validate 14683 ourselves, invalidate our lower-right quadrant via NPN_InvalidateRect, 14684 then check that our HWND's invalid region is the rect that we 14685 invalidated. 14686 14687 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 14688 * Added NPNInvalidateRectInvalidatesWindow. 14689 146902010-10-21 Daniel Bates <dbates@rim.com> 14691 14692 Add Git-support to do-file-rename 14693 https://bugs.webkit.org/show_bug.cgi?id=48015 14694 14695 Fix tools. Export function scmMoveOrRenameFile so that it can be called from 14696 do-file-rename and do-webcore-rename. I inadvertently left this out of the patch. 14697 14698 * Scripts/VCSUtils.pm: 14699 147002010-10-21 Eric Seidel <eric@webkit.org> 14701 14702 Reviewed by Adam Barth. 14703 14704 mac-ews is not properly releasing patches 14705 https://bugs.webkit.org/show_bug.cgi?id=48076 14706 14707 mac-ews overrides process_work_item, so it was not calling 14708 release_work_item like the default process_work_item would. 14709 To fix this I made all the status-reporting methods just 14710 release the patch. I expect we'll iterate on this design further. 14711 14712 * Scripts/webkitpy/common/net/statusserver.py: 14713 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 14714 * Scripts/webkitpy/tool/commands/queues.py: 14715 * Scripts/webkitpy/tool/commands/queues_unittest.py: 14716 147172010-10-18 Martin Robinson <mrobinson@igalia.com> 14718 14719 Reviewed by Gustavo Noronha Silva. 14720 14721 [GTK] mathml flaky tests after adding SystemFonts to the theme 14722 https://bugs.webkit.org/show_bug.cgi?id=47727 14723 14724 The Fontconfig setup in the GTK+ now specifically checks for and 14725 loads the STIX fonts for MathML tests. 14726 14727 * DumpRenderTree/gtk/DumpRenderTree.cpp: 14728 (initializeFonts): Add hooks for loading the STIX fonts specifically. 14729 147302010-10-20 Adam Roben <aroben@apple.com> 14731 14732 Test that the UI client gets notified when WKView receives a WM_CLOSE 14733 message 14734 14735 Test for <http://webkit.org/b/48044> <rdar://problem/8488446> Pressing 14736 Ctrl+W when viewing a full-page PDF destroys the WKView but doesn't 14737 close its parent window 14738 14739 Reviewed by Jon Honeycutt. 14740 14741 * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Added. 14742 (TestWebKitAPI::close): Record that this function was called. 14743 (TestWebKitAPI::WebKit2_WMCloseCallsUIClientClose): Create a WKView, 14744 send it a WM_CLOSE message, and test that the UI client's close 14745 callback got called. Note that this will hang if the bug is 14746 reintroduced; <http://webkit.org/b/48043> covers making TestWebKitAPI 14747 able to handle hangs. 14748 14749 * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test. 14750 147512010-10-20 Adam Roben <aroben@apple.com> 14752 14753 Make prepare-ChangeLog much faster when using git 14754 14755 This change also seems to make it detect renames better in some cases. 14756 14757 Fixes <http://webkit.org/b/48040> prepare-ChangeLog is slow when using 14758 git 14759 14760 Reviewed by David Kilzer. 14761 14762 * Scripts/prepare-ChangeLog: 14763 (statusCommand): 14764 (createPatchCommand): 14765 Use "-M -C" instead of "-C -C -M" to tell git-diff to detect renames 14766 and copies. The two "-C"s were making it read many more files than were 14767 necessary. 14768 147692010-10-21 Sam Weinig <sam@webkit.org> 14770 14771 Reviewed by Adam Roben. 14772 14773 Null frame passed when running alert from UserScript run at document start 14774 <rdar://problem/8573809> 14775 https://bugs.webkit.org/show_bug.cgi?id=48036 14776 14777 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 14778 * TestWebKitAPI/InjectedBundleController.cpp: 14779 (TestWebKitAPI::InjectedBundleController::didReceiveMessage): 14780 (TestWebKitAPI::InjectedBundleController::initializeTestNamed): 14781 * TestWebKitAPI/InjectedBundleController.h: 14782 * TestWebKitAPI/InjectedBundleTest.h: 14783 (TestWebKitAPI::InjectedBundleTest::initialize): 14784 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 14785 * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Added. 14786 (TestWebKitAPI::runJavaScriptAlert): 14787 (TestWebKitAPI::TEST): 14788 * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Added. 14789 (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::DocumentStartUserScriptAlertCrashTest): 14790 (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize): 14791 Add test for invoking an alert during a UserScript run at document start. 14792 147932010-10-21 Andreas Kling <kling@webkit.org> 14794 14795 Reviewed by Adam Roben. 14796 14797 TestNetscapePlugIn: Actually call NPP_SetWindow on Unix 14798 14799 We were just returning NPERR_NO_ERROR previously. 14800 14801 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 14802 (webkit_test_plugin_set_window): 14803 148042010-10-21 David Kilzer <ddkilzer@apple.com> 14805 14806 <http://webkit.org/b/48051> Move macros from DumpRenderTreeMac.h to config.h 14807 14808 Reviewed by Adam Roben. 14809 14810 * DumpRenderTree/config.h: Moved macros to here... 14811 * DumpRenderTree/mac/DumpRenderTreeMac.h: ...from here. 14812 Addresses a FIXME comment from r28419. 14813 148142010-10-21 David Kilzer <ddkilzer@apple.com> 14815 14816 <http://webkit.org/b/48047> Fix warnings found by check-Xcode-source-file-types 14817 14818 Reviewed by Adam Roben. 14819 14820 Fixes the following warnings: 14821 14822 WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'PixelDumpSupport.cpp'. 14823 WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'LayoutTestController.cpp'. 14824 WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'WorkQueue.cpp'. 14825 WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'cg/PixelDumpSupportCG.cpp'. 14826 WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'GCController.cpp'. 14827 5 issues found for WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj. 14828 14829 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 14830 Removed explicit file type for *.cpp files above to make them 14831 match other C++ source files. This exposed the fact that 14832 DumpRenderTreeMac.h was not safe to include in C++ source, which 14833 caused PixelDumpSupport.cpp and PixelDumpSupportCG.cpp to fail 14834 to build. 14835 * DumpRenderTree/PixelDumpSupport.cpp: Adjusted header order. 14836 * DumpRenderTree/mac/DumpRenderTreeMac.h: Made safe to include 14837 in C++ source files. Included CoreFoundation/CoreFoundation.h 14838 to make sure all CF types were defined. Removed CFStringRef 14839 typedef. 14840 148412010-10-21 Adam Roben <aroben@apple.com> 14842 14843 Attempt to fix plugins/pass-different-npp-struct.html on GTK. 14844 14845 See <http://webkit.org/b/47690>. 14846 14847 * GNUmakefile.am: Added PassDifferentNPPStruct.cpp. 14848 148492010-10-21 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 14850 14851 Reviewed by Csaba Osztrogonác. 14852 14853 [NRWT] Set ImageDiff path on Qt port 14854 https://bugs.webkit.org/show_bug.cgi?id=48052 14855 14856 * Scripts/webkitpy/layout_tests/port/qt.py: 14857 148582010-10-21 Adam Barth <abarth@webkit.org> 14859 14860 Reviewed by Eric Seidel. 14861 14862 Don't CC authors of flaky tests 14863 https://bugs.webkit.org/show_bug.cgi?id=48038 14864 14865 Some authors found this too annoying. We'll look for another way to 14866 close the flaky test loop. 14867 14868 * Scripts/webkitpy/tool/commands/queues.py: 14869 * Scripts/webkitpy/tool/commands/queues_unittest.py: 14870 148712010-10-21 Eric Seidel <eric@webkit.org> 14872 14873 Reviewed by Adam Barth. 14874 14875 commit-queue should run run-webkit-tests with --no-new-test-results 14876 https://bugs.webkit.org/show_bug.cgi?id=47998 14877 14878 * Scripts/webkitpy/tool/steps/runtests.py: 14879 * Scripts/webkitpy/tool/steps/steps_unittest.py: 14880 148812010-10-21 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 14882 14883 Reviewed by Ojan Vafai. 14884 14885 [NRWT] Get child process number from an environment variable 14886 https://bugs.webkit.org/show_bug.cgi?id=47981 14887 14888 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 14889 148902010-10-20 David Kilzer <ddkilzer@apple.com> 14891 14892 <http://webkit.org/b/47754> New script to verify explicit source file types in Xcode project files 14893 14894 Reviewed by Darin Adler. 14895 14896 The script parses an Xcode project file and makes sure the file 14897 extension matches the explicit file type set for all source 14898 files. Note that the majority of source files will have their 14899 type set by Xcode, so the script doesn't check them since there 14900 is no need to second-guess Xcode. 14901 14902 * Scripts/check-Xcode-source-file-types: Added. Code borrowed 14903 heavily from sort-Xcode-project-file. 14904 149052010-10-20 Adam Roben <aroben@apple.com> 14906 14907 Windows build fix 14908 14909 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added missing #include. 14910 149112010-10-20 Adam Roben <aroben@apple.com> 14912 14913 Qt test fix 14914 14915 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Added 14916 PassDifferentNPPStruct.cpp. 14917 149182010-10-20 Sam Weinig <sam@webkit.org> 14919 14920 Reviewed by Adam Roben. 14921 14922 Add ability to test injected bundle API using TestWebKitAPI 14923 https://bugs.webkit.org/show_bug.cgi?id=48027 14924 14925 * TestWebKitAPI/InjectedBundleController.cpp: Added. 14926 * TestWebKitAPI/InjectedBundleController.h: Added. 14927 Shared main object for bundle functionality. 14928 14929 * TestWebKitAPI/InjectedBundleMain.cpp: Added. 14930 Bundle entry point. 14931 14932 * TestWebKitAPI/InjectedBundleTest.h: Added. 14933 Base class for which the bundle portion of a test derives from. 14934 14935 * TestWebKitAPI/PlatformUtilities.h: 14936 * TestWebKitAPI/PlatformUtilities.cpp: Added. 14937 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: 14938 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: 14939 (TestWebKitAPI::Util::createInjectedBundlePath): 14940 (TestWebKitAPI::Util::createURLForResource): 14941 (TestWebKitAPI::Util::URLForNonExistentResource): 14942 Add helper to create a context with the shared injected bundle, 14943 and send the initial message to set up the test. 14944 14945 * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Added. 14946 * TestWebKitAPI/InjectedBundle-Info.plist: Added. 14947 Add mac configuration files. 14948 14949 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 14950 Add the new files. 14951 14952 * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Added. 14953 * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Added. 14954 Add a simple initial bundle test. 14955 149562010-10-20 Eric Seidel <eric@webkit.org> 14957 14958 Unreviewed. Fixing /release-patch url used by the EWS bots. 14959 14960 EWS should test patches with r+ 14961 https://bugs.webkit.org/show_bug.cgi?id=35460 14962 14963 * Scripts/webkitpy/common/net/statusserver.py: 14964 - I changed the URL during development, and 404s are 14965 intentionally silenced during release_patch. 14966 149672010-10-14 Adam Roben <aroben@apple.com> 14968 14969 Test that passing a different NPP struct back to the browser doesn't 14970 cause an assertion failure 14971 14972 Test for <http://webkit.org/b/47690> <rdar://problem/8553020> 14973 Assertion failure in NetscapePlugin::fromNPP when using Shockwave in 14974 WebKit2 14975 14976 Reviewed by John Sullivan. 14977 14978 * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp: Copied from WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp. 14979 (PassDifferentNPPStruct::PassDifferentNPPStruct): Initialize our 14980 members. 14981 (PassDifferentNPPStruct::NPP_SetWindow): Pass a different NPP to the 14982 browser than the one it gave us in NPP_New and see if it works. 14983 14984 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 14985 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 14986 Added PassDifferentNPPStruct. 14987 149882010-10-19 Adam Roben <aroben@apple.com> 14989 14990 Gently nudge old-run-webkit-tests toward working with Win32 Perl 14991 14992 This makes old-run-webkit-tests able to build DRT and find all the 14993 tests to run. It even invokes DRT and passes it the list of tests. But 14994 DRT ends up hung blocking on I/O. 14995 14996 Fixes <http://webkit.org/b/47961> Get old-run-webkit-tests mostly 14997 working with Win32 Perl 14998 14999 Reviewed by David Kilzer. 15000 15001 * Scripts/old-run-webkit-tests: 15002 - Use File::Spec instead of manually concatenating paths 15003 - Use dirname instead of manually stripping off the base name 15004 - Use isCygwin/isWindows/isAppleWinWebKit more judiciously 15005 - Explicitly invoke Perl when running Perl scripts 15006 - Quote paths when using them in regular expressions to allow them 15007 to include characters that have special meanings in regular 15008 expressions 15009 15010 * Scripts/run-webkit-tests: Use File::Spec instead of manually 15011 concatenating paths. 15012 15013 * Scripts/webkitdirs.pm: 15014 - Remove the unused $windowsTmpPath variable 15015 - Use isCygwin/isWindows/isAppleWinWebKit more judiciously 15016 - Only pass paths to cygpath when using Cygwin Perl 15017 - Only use pdevenv when using Cygwin Perl, for now 15018 150192010-10-20 Daniel Bates <dbates@rim.com> 15020 15021 Reviewed by Martin Robinson. 15022 15023 Add Git-support to do-file-rename 15024 https://bugs.webkit.org/show_bug.cgi?id=48015 15025 15026 Also, abstracts the SCM move/rename functionality in do-file-rename and 15027 do-webcore-rename into a common function VCSUtils::scmMoveOrRenameFile(). 15028 15029 Currently, do-file-rename is hard coded to assume the SCM is Subversion. 15030 Instead, we should abstract the rename logic to be SCM-independent. This 15031 will allow us to add Git support as well move such functionality into 15032 our SCM library VCSUtils, where it can be shared by do-webcore-rename. 15033 15034 * Scripts/VCSUtils.pm: 15035 - Added function scmMoveOrRenameFile. 15036 * Scripts/do-file-rename: Modified to call VCSUtils::scmMoveOrRenameFile(). 15037 * Scripts/do-webcore-rename: Ditto. 15038 150392010-10-20 Adam Roben <aroben@apple.com> 15040 15041 Fix old-run-webkit-tests when there's a space in the path to DRT 15042 15043 Reviewed by Jon Honeycutt. 15044 15045 * Scripts/old-run-webkit-tests: Quote the path to DRT before executing 15046 it. 15047 150482010-10-20 Kenneth Russell <kbr@google.com> 15049 15050 Reviewed by Dimitri Glazkov. 15051 15052 Regression in chromium_gpu_unittests after r70175 15053 https://bugs.webkit.org/show_bug.cgi?id=48008 15054 15055 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 15056 150572010-10-20 Kenneth Russell <kbr@google.com> 15058 15059 Reviewed by James Robinson. 15060 15061 chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations fallback 15062 https://bugs.webkit.org/show_bug.cgi?id=48005 15063 15064 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 15065 150662010-10-20 Adam Barth <abarth@webkit.org> 15067 15068 Reviewed by Eric Seidel. 15069 15070 webkit-patch doesn't get along with git rm 15071 https://bugs.webkit.org/show_bug.cgi?id=47940 15072 15073 Turns out we need to pass "--" to tell git this is a path. 15074 15075 * Scripts/webkitpy/common/checkout/scm.py: 15076 150772010-10-20 Robert Hogan <robert@webkit.org> 15078 15079 Reviewed by Antonio Gomes. 15080 15081 [Qt] Fix layoutTestController.getJsObjectCount 15082 15083 Qt Bridge doesn't know size_t so pass result as unsigned int. 15084 15085 Unskip fast/dom/gc-10.html 15086 15087 https://bugs.webkit.org/show_bug.cgi?id=47931 15088 15089 * DumpRenderTree/qt/GCControllerQt.cpp: 15090 (GCController::getJSObjectCount): 15091 * DumpRenderTree/qt/GCControllerQt.h: 15092 150932010-10-20 Sheriff Bot <webkit.review.bot@gmail.com> 15094 15095 Unreviewed, rolling out r70149. 15096 http://trac.webkit.org/changeset/70149 15097 https://bugs.webkit.org/show_bug.cgi?id=47989 15098 15099 "Build breaks in mac and win" (Requested by satish on 15100 #webkit). 15101 15102 * DumpRenderTree/LayoutTestController.cpp: 15103 (setMockSpeechInputResultCallback): 15104 * DumpRenderTree/LayoutTestController.h: 15105 * DumpRenderTree/chromium/LayoutTestController.cpp: 15106 (LayoutTestController::setMockSpeechInputResult): 15107 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 15108 (LayoutTestController::setMockSpeechInputResult): 15109 151102010-10-20 Leandro Gracia Gil <leandrogracia@google.com> 15111 15112 Reviewed by Jeremy Orlow. 15113 15114 Added a second parameter to setMockSpeechInputResult for 15115 the language used in speech input. 15116 https://bugs.webkit.org/show_bug.cgi?id=47089 15117 15118 * DumpRenderTree/LayoutTestController.cpp: 15119 (setMockSpeechInputResultCallback): 15120 * DumpRenderTree/LayoutTestController.h: 15121 * DumpRenderTree/chromium/LayoutTestController.cpp: 15122 (LayoutTestController::setMockSpeechInputResult): 15123 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 15124 (LayoutTestController::setMockSpeechInputResult): 15125 151262010-10-19 Adam Roben <aroben@apple.com> 15127 15128 Teach update-webkit-support-libs about the new versioning of 15129 WebKitSupportLibrary 15130 15131 Fixes <http://webkit.org/b/47915> update-webkit-support-libs should 15132 check version numbers instead of modification times 15133 15134 Reviewed by Sam Weinig. 15135 15136 * Scripts/update-webkit-support-libs: Fetch the expected version 15137 number from developer.apple.com, then compare with the version number 15138 of the extracted library and of the zipped library to see if anything 15139 needs to be done. Removed code that tracked the modified timestamp of 15140 the library, as it is no longer needed. 15141 151422010-10-19 Eric Seidel <eric@webkit.org> 15143 15144 Reviewed by Adam Barth. 15145 15146 EWS should test patches with r+ 15147 https://bugs.webkit.org/show_bug.cgi?id=35460 15148 15149 * QueueStatusServer/handlers/submittoews.py: 15150 * QueueStatusServer/model/queues.py: 15151 * Scripts/webkitpy/tool/bot/patchcollection.py: Removed. 15152 * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Removed. 15153 * Scripts/webkitpy/tool/commands/queues.py: 15154 151552010-10-19 Eric Seidel <eric@webkit.org> 15156 15157 Reviewed by Adam Barth. 15158 15159 Teach feeder-queue how to feed the EWS bots 15160 https://bugs.webkit.org/show_bug.cgi?id=47943 15161 15162 queues.webkit.org already knew how to accept EWS submissions 15163 via /submit-to-ews. This teaches the feeder queue how to post 15164 to that page with any new r? patches it sees. 15165 15166 * QueueStatusServer/model/activeworkitems_unitest.py: Added. 15167 - More unit testing is always a good thing. 15168 * Scripts/webkitpy/common/net/bugzilla.py: 15169 * Scripts/webkitpy/common/net/statusserver.py: 15170 * Scripts/webkitpy/tool/bot/feeders.py: 15171 * Scripts/webkitpy/tool/commands/queues.py: 15172 * Scripts/webkitpy/tool/commands/queues_unittest.py: 15173 * Scripts/webkitpy/tool/mocktool.py: 15174 151752010-10-19 Eric Seidel <eric@webkit.org> 15176 15177 Unreviewed, just fixing test-webkitpy. I'm really on a roll today. 15178 15179 commit-queue gets stuck when release-patch returns 404 15180 https://bugs.webkit.org/show_bug.cgi?id=47935 15181 15182 Fix test-webkitpy and unittest NetworkTransaction. 15183 15184 * Scripts/webkitpy/common/net/networktransaction.py: 15185 * Scripts/webkitpy/common/net/networktransaction_unittest.py: 15186 151872010-10-19 Eric Seidel <eric@webkit.org> 15188 15189 Unreviewed. 15190 15191 commit-queue gets stuck when release-patch returns 404 15192 https://bugs.webkit.org/show_bug.cgi?id=47935 15193 15194 Turns out ClientForm gets upset if passed an int() instead of a string type. 15195 Yay for untestable code. 15196 15197 * Scripts/webkitpy/common/net/statusserver.py: 15198 151992010-10-19 Eric Seidel <eric@webkit.org> 15200 15201 Unreviewed. Will get Adam's commentary after his meeting 15202 for now this gets the commit-cluster back running. 15203 15204 commit-queue gets stuck when release-patch returns 404 15205 https://bugs.webkit.org/show_bug.cgi?id=47935 15206 15207 I taught NetworkTransaction the basics of 404 handling. 15208 We'll want to go back and teach it how to handle urllib2 404's too 15209 and then deploy it to the places that want it. 15210 15211 * QueueStatusServer/handlers/releasepatch.py: 15212 * Scripts/webkitpy/common/net/buildbot.py: 15213 * Scripts/webkitpy/common/net/networktransaction.py: 15214 * Scripts/webkitpy/common/net/statusserver.py: 15215 152162010-10-19 Eric Seidel <eric@webkit.org> 15217 15218 Unreviewed. Fixing typos in my previous commit. 15219 15220 Make patch release explicit and not a magic part of "retry" status 15221 https://bugs.webkit.org/show_bug.cgi?id=47909 15222 15223 All of these typos again due to our inability to unit 15224 test much of this code. I added one unit test where 15225 possible. activeworkitems_unittest.py will be in a separate patch. 15226 15227 * QueueStatusServer/handlers/releasepatch.py: 15228 * QueueStatusServer/main.py: 15229 * QueueStatusServer/model/activeworkitems.py: 15230 * QueueStatusServer/model/workitems.py: 15231 * QueueStatusServer/model/workitems_unittest.py: 15232 * QueueStatusServer/templates/releasepatch.html: 15233 * Scripts/webkitpy/common/net/statusserver.py: 15234 152352010-10-19 Tony Chang <tony@chromium.org> 15236 15237 Reviewed by Kent Tamura. 15238 15239 [chromium] Use webkit's TestNetscapePlugIn in DRT mac 15240 https://bugs.webkit.org/show_bug.cgi?id=47850 15241 15242 * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Added. Forked 15243 because we're going to name our plugin WebKitTestNetscapePlugIn 15244 temporarily until the chromium forked plugin goes away. 15245 152462010-10-19 Eric Seidel <eric@webkit.org> 15247 15248 Reviewed by Adam Barth. 15249 15250 Make patch release explicit and not a magic part of "retry" status 15251 https://bugs.webkit.org/show_bug.cgi?id=47909 15252 15253 This moves us another step closer to running r+ patches on the EWS bots. 15254 Currently all bots just spam /update-work-items with their list of current 15255 work items. queues.webkit.org uses that data for display. As part of making 15256 the EWS run r+ patches, we're moving the official list of patches-to-process 15257 into the server, and feeding them out to bots one at a time. We need to be 15258 able to remove patches from the queues one at a time instead of just spamming 15259 /update-work-items with a new complete list. That's what this patch adds. 15260 15261 * QueueStatusServer/handlers/nextpatch.py: 15262 * QueueStatusServer/handlers/queuestatus.py: 15263 * QueueStatusServer/handlers/releasepatch.py: Added. 15264 * QueueStatusServer/handlers/statusbubble_unittest.py: 15265 - Fix a typo causing test failure. This was not caught by the bots 15266 because they don't have AppEngineLauncher installed and thus don't run 15267 the QueueStatusServer tests. 15268 * QueueStatusServer/handlers/updatestatus.py: 15269 * QueueStatusServer/model/activeworkitems.py: 15270 * QueueStatusServer/templates/releasepatch.html: Added. 15271 * Scripts/webkitpy/common/net/statusserver.py: 15272 * Scripts/webkitpy/tool/commands/queues.py: 15273 * Scripts/webkitpy/tool/mocktool.py: 15274 152752010-10-19 Eric Seidel <eric@webkit.org> 15276 15277 Reviewed by Adam Barth. 15278 15279 cr-mac bubble has caused status bubbles to wrap 15280 https://bugs.webkit.org/show_bug.cgi?id=47928 15281 15282 We now have too many EWSes to fit in the bugs.webkit.org 15283 status-bubble iframe when more than a couple EWS builds are pending. 15284 To fix this I've reduced the space taken up by queue position, 15285 and also moved cr-mac to the end of the list (since it's going to be 15286 triple-digits for a while). 15287 15288 * QueueStatusServer/model/queues.py: 15289 * QueueStatusServer/templates/statusbubble.html: 15290 152912010-10-19 Kenneth Russell <kbr@google.com> 15292 15293 Reviewed by David Levin. 15294 15295 chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations 15296 https://bugs.webkit.org/show_bug.cgi?id=47874 15297 15298 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 15299 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 15300 153012010-10-19 Tony Chang <tony@chromium.org> 15302 15303 Reviewed by Kent Tamura. 15304 15305 [chromium] DumpRenderTree shouldn't put '.' in include path 15306 https://bugs.webkit.org/show_bug.cgi?id=47877 15307 15308 Fix include paths. 15309 15310 * DumpRenderTree/chromium/AccessibilityController.cpp: 15311 * DumpRenderTree/chromium/AccessibilityUIElement.cpp: 15312 * DumpRenderTree/chromium/AccessibilityUIElement.h: 15313 * DumpRenderTree/chromium/CppBoundClass.cpp: 15314 * DumpRenderTree/chromium/CppVariant.cpp: 15315 * DumpRenderTree/chromium/CppVariant.h: 15316 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: 15317 * DumpRenderTree/chromium/DRTDevToolsAgent.h: 15318 * DumpRenderTree/chromium/DRTDevToolsCallArgs.h: 15319 * DumpRenderTree/chromium/DRTDevToolsClient.cpp: 15320 * DumpRenderTree/chromium/DRTDevToolsClient.h: 15321 * DumpRenderTree/chromium/EventSender.cpp: 15322 * DumpRenderTree/chromium/EventSender.h: 15323 * DumpRenderTree/chromium/LayoutTestController.cpp: 15324 * DumpRenderTree/chromium/LayoutTestController.h: 15325 * DumpRenderTree/chromium/MockSpellCheck.cpp: 15326 * DumpRenderTree/chromium/NotificationPresenter.cpp: 15327 * DumpRenderTree/chromium/NotificationPresenter.h: 15328 * DumpRenderTree/chromium/PlainTextController.cpp: 15329 * DumpRenderTree/chromium/Task.cpp: 15330 * DumpRenderTree/chromium/TestNavigationController.h: 15331 * DumpRenderTree/chromium/TestShell.cpp: 15332 * DumpRenderTree/chromium/TestWebWorker.h: 15333 * DumpRenderTree/chromium/TextInputController.cpp: 15334 * DumpRenderTree/chromium/WebPreferences.cpp: 15335 * DumpRenderTree/chromium/WebPreferences.h: 15336 * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: 15337 * DumpRenderTree/chromium/WebThemeEngineDRT.h: 15338 * DumpRenderTree/chromium/WebViewHost.cpp: 15339 * DumpRenderTree/chromium/WebViewHost.h: 15340 153412010-10-19 Sam Weinig <sam@webkit.org> 15342 15343 Reviewed by Dan Bernstein. 15344 15345 Need to include WKErrorRef in the WKPageDidFail... functions 15346 https://bugs.webkit.org/show_bug.cgi?id=47871 15347 15348 Update tools for new parameter in failure callbacks. 15349 15350 * MiniBrowser/mac/BrowserWindowController.m: 15351 (didFailProvisionalLoadWithErrorForFrame): 15352 (didFailLoadWithErrorForFrame): 15353 (-[BrowserWindowController updateProvisionalURLForFrame:]): 15354 * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: 15355 (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): 15356 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 15357 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): 15358 (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): 15359 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 15360 153612010-10-19 Luiz Agostini <luiz.agostini@openbossa.org> 15362 15363 Reviewed by Antti Koivisto. 15364 15365 [Qt] WebKit2 MacOS build fix 15366 https://bugs.webkit.org/show_bug.cgi?id=47897 15367 15368 Qt WebKit2 MacOS build fix. 15369 15370 * WebKitTestRunner/PlatformWebView.h: 15371 * WebKitTestRunner/qt/TestControllerQt.cpp: 15372 153732010-10-19 Adam Barth <abarth@webkit.org> 15374 15375 Reviewed by Eric Seidel. 15376 15377 webkit-patch stats the filesystem too many times 15378 https://bugs.webkit.org/show_bug.cgi?id=47883 15379 15380 This patch attempts to cache the list of changed files more agressively 15381 and to use that list to compute the diff instead of stating the file 15382 system again. 15383 15384 * Scripts/webkitpy/common/checkout/api.py: 15385 * Scripts/webkitpy/common/checkout/scm.py: 15386 * Scripts/webkitpy/tool/mocktool.py: 15387 * Scripts/webkitpy/tool/steps/abstractstep.py: 15388 * Scripts/webkitpy/tool/steps/editchangelog.py: 15389 * Scripts/webkitpy/tool/steps/preparechangelog.py: 15390 153912010-10-19 David Kilzer <ddkilzer@apple.com> 15392 15393 <http://webkit.org/b/47741> Make sort-Xcode-project-file a little more friendly 15394 15395 Reviewed by Darin Adler. 15396 15397 * Scripts/sort-Xcode-project-file: 15398 - Don't print an error message about missing arguments when 15399 -h|--help is used. 15400 - Allow Xcode project files to be specified as Project.xcodeproj 15401 instead of Project.xcodeproj/project.pbxproj. 15402 154032010-10-18 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 15404 15405 Reviewed by Andreas Kling. 15406 15407 [Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode. 15408 https://bugs.webkit.org/show_bug.cgi?id=47809 15409 15410 Connecting a call to load from the loadFinished signal can cause 15411 re-entrance crashes in WebCore. This patch uses a timer to do so, 15412 also giving some time to subsequent frames to finish loading. 15413 15414 * QtTestBrowser/urlloader.cpp: 15415 (UrlLoader::UrlLoader): 15416 (UrlLoader::loadNext): 15417 (UrlLoader::checkIfFinished): 15418 (UrlLoader::frameLoadStarted): 15419 (UrlLoader::frameLoadFinished): 15420 * QtTestBrowser/urlloader.h: 15421 154222010-10-19 Sergio Villar SenÃn <svillar@igalia.com> 15423 15424 Reviewed by Xan Lopez. 15425 15426 [GTK] http/history tests are failing 15427 https://bugs.webkit.org/show_bug.cgi?id=36173 15428 15429 Clear the history each time a test is run. Return the actual 15430 history item count when calling 15431 LayoutTestController::webHistoryItemCount 15432 15433 * DumpRenderTree/gtk/DumpRenderTree.cpp: 15434 (resetDefaultsToConsistentValues): 15435 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 15436 (LayoutTestController::webHistoryItemCount): 15437 154382010-10-18 Eric Seidel <eric@webkit.org> 15439 15440 Reviewed by Adam Barth. 15441 15442 Add Chromium Mac EWS to the list of queues at queues.webkit.org 15443 https://bugs.webkit.org/show_bug.cgi?id=47878 15444 15445 * QueueStatusServer/model/queues.py: 15446 154472010-10-18 Eric Seidel <eric@webkit.org> 15448 15449 Reviewed by Adam Barth. 15450 15451 queues.webkit.org/next_patch is always 404 15452 https://bugs.webkit.org/show_bug.cgi?id=47881 15453 15454 With the addition of the Queue class, I changed most of the 15455 code to lookup WorkItems using get_or_insert with a key_name 15456 instead of WorkItems.all().filter(queue_name=). 15457 Because the new get_or_insert code uses an explicit key_name 15458 (which is obviously different from the previously autogenerated 15459 ones), there were new WorkItem records created for each queue. 15460 However, some parts of the code still use WorkItems.all().filter, 15461 thus some parts were getting the new record and some parts the old record. 15462 15463 The same basic bug was occurring with ActiveWorkItems, because I 15464 changed the key_name for that class as well. 15465 15466 To fix this I've moved more of the code over to using Queue.*work_items. 15467 I've also enabled the datastore_admin (new in GAE 1.3.8) so that 15468 we can go delete the old WorkItems records. 15469 I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8). 15470 15471 * QueueStatusServer/app.yaml: 15472 * QueueStatusServer/handlers/queuestatus.py: 15473 * QueueStatusServer/handlers/recentstatus.py: 15474 * QueueStatusServer/handlers/updatestatus.py: 15475 * QueueStatusServer/handlers/updateworkitems.py: 15476 154772010-10-18 Eric Seidel <eric@webkit.org> 15478 15479 Reviewed by Adam Barth. 15480 15481 Correct a bunch of typos in QueueStatusServer 15482 https://bugs.webkit.org/show_bug.cgi?id=47880 15483 15484 These are all due to our complete lack of unit testing in QueueStatusServer. 15485 I added a couple unit tests to cover a few of these fixes, but most of these 15486 are still only caught by actually running the application. 15487 15488 * QueueStatusServer/handlers/nextpatch.py: 15489 * QueueStatusServer/handlers/statusbubble.py: 15490 * QueueStatusServer/handlers/statusbubble_unittest.py: Added. 15491 * QueueStatusServer/handlers/updateworkitems.py: 15492 * QueueStatusServer/model/attachment.py: 15493 * QueueStatusServer/model/queuepropertymixin.py: 15494 * QueueStatusServer/model/queuepropertymixin_unittest.py: 15495 * QueueStatusServer/model/workitems.py: 15496 * QueueStatusServer/model/workitems_unittest.py: Added. 15497 154982010-10-18 Adam Barth <abarth@webkit.org> 15499 15500 Disable this test because it's failing on the bots and the authors 15501 aren't around to fix it. 15502 15503 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 15504 155052010-10-18 Adam Barth <abarth@webkit.org> 15506 15507 Reviewed by Eric Seidel. 15508 15509 CC authors of flaky tests when the commit-queue hits a flaky test 15510 https://bugs.webkit.org/show_bug.cgi?id=47872 15511 15512 * Scripts/webkitpy/common/checkout/api.py: 15513 * Scripts/webkitpy/common/net/layouttestresults.py: 15514 * Scripts/webkitpy/tool/commands/queues.py: 15515 * Scripts/webkitpy/tool/commands/queues_unittest.py: 15516 * Scripts/webkitpy/tool/mocktool.py: 15517 155182010-10-18 Eric Seidel <eric@webkit.org> 15519 15520 Reviewed by Adam Barth. 15521 15522 Make it possible to run a chromium-mac-ews builder 15523 https://bugs.webkit.org/show_bug.cgi?id=47876 15524 15525 Since we can't run Mac OS X in a VM, we need to only run committer patches. 15526 There was a multiple inheritance problem which was holding this patch back, 15527 but I decided to just ignore the problem and go with a functional hack for now. 15528 15529 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 15530 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 15531 155322010-10-18 Kenneth Russell <kbr@google.com> 15533 15534 Reviewed by Tony Chang. 15535 15536 Regression in run_webkit_tests_unittest from r70017 15537 https://bugs.webkit.org/show_bug.cgi?id=47875 15538 15539 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 15540 155412010-10-18 Adam Barth <abarth@webkit.org> 15542 15543 Reviewed by Eric Seidel. 15544 15545 Implement webkit-patch suggest-reviewers 15546 https://bugs.webkit.org/show_bug.cgi?id=47866 15547 15548 * Scripts/webkitpy/common/checkout/api.py: 15549 - The main logic. We look at the last five changes to each 15550 modified (non-ChangeLog) file and collect up the reviewers of 15551 those changes as well as the authors of those changes who are 15552 reviewers. 15553 * Scripts/webkitpy/common/checkout/api_unittest.py: 15554 - Test the logic with some fun mocks. 15555 * Scripts/webkitpy/common/checkout/scm.py: 15556 - Fix a bug when you have local git commits. 15557 * Scripts/webkitpy/common/checkout/scm_unittest.py: 15558 - Test that the bug is fixed. 15559 * Scripts/webkitpy/tool/commands/queries.py: 15560 - Add the query. 15561 155622010-10-18 Kenneth Russell <kbr@google.com> 15563 15564 Reviewed by Eric Seidel. 15565 15566 new-run-webkit-tests produces corrupt PNG baselines on Windows 15567 https://bugs.webkit.org/show_bug.cgi?id=47867 15568 15569 * Scripts/webkitpy/layout_tests/port/base.py: 15570 155712010-10-18 Eric Seidel <eric@webkit.org> 15572 15573 Reviewed by Adam Barth. 15574 15575 Make it possible to submit patches to the EWS bots 15576 https://bugs.webkit.org/show_bug.cgi?id=47869 15577 15578 * QueueStatusServer/handlers/nextpatch.py: 15579 - Move more logic into Queue, so that it can be shared with SubmitToEWS. 15580 * QueueStatusServer/handlers/queuestatus.py: 15581 - Fix two typos from a previous commit. 15582 * QueueStatusServer/handlers/submittoews.py: Added. 15583 * QueueStatusServer/handlers/updatestatus.py: 15584 - Use the new is_retry_request method to share this (hacky) code with SubmitToEWS 15585 * QueueStatusServer/main.py: 15586 - Add /submit-to-ews 15587 * QueueStatusServer/model/queuepropertymixin.py: 15588 - Fix circular imports caused by adding Queue.work_items() 15589 * QueueStatusServer/model/queues.py: 15590 - Add work_items() and active_work_items() 15591 * QueueStatusServer/model/queuestatus.py: 15592 * QueueStatusServer/model/workitems.py: 15593 - Add transaction-safe add/remove methods. 15594 * QueueStatusServer/templates/submittoews.html: Added. 15595 155962010-10-18 Eric Seidel <eric@webkit.org> 15597 15598 Reviewed by Adam Barth. 15599 15600 Deploy Queue class in more places throughout QueueStatusServer 15601 https://bugs.webkit.org/show_bug.cgi?id=47855 15602 15603 I also caught two typos from the previous change. Unfortunately 15604 I don't yet know how to unittest request handlers yet. 15605 15606 * QueueStatusServer/handlers/dashboard.py: 15607 * QueueStatusServer/handlers/statusbubble.py: 15608 * QueueStatusServer/handlers/updateworkitems.py: 15609 * QueueStatusServer/model/activeworkitems.py: 15610 * QueueStatusServer/model/attachment.py: 15611 * QueueStatusServer/model/queuepropertymixin.py: Added. 15612 * QueueStatusServer/model/queuepropertymixin_unittest.py: Added. 15613 * QueueStatusServer/model/queuestatus.py: 15614 * QueueStatusServer/model/workitems.py: 15615 156162010-10-18 Adam Barth <abarth@webkit.org> 15617 15618 Reviewed by Eric Seidel. 15619 15620 scm.py should be able tell us what revisions made changes to a given file 15621 https://bugs.webkit.org/show_bug.cgi?id=47863 15622 15623 Look again, your SCM.py can now log files. 15624 15625 * Scripts/webkitpy/common/checkout/scm.py: 15626 * Scripts/webkitpy/common/checkout/scm_unittest.py: 15627 156282010-10-18 Dirk Pranke <dpranke@chromium.org> 15629 15630 Reviewed by Eric Siedel. 15631 15632 new-run-webkit-tests: clean up the options-parsing code in the port 15633 classes. 15634 15635 This change modifies the Port interface to have a get_option() and 15636 set_option_default() method for accessing the options argument 15637 passed to the constructor. If the constructor is not passed an 15638 options argument, we default to a MockOptions() argument from 15639 mocktool, which has the same semantics we want. 15640 15641 Note that there is a disadvantage to port.get_option('foo') over 15642 port._options.foo, which is that you lose some of the checking 15643 for whether 'foo' is set (typos result in the default value, not 15644 an exception being raised. This is desired in this case, since the 15645 Port class is not allowed to assume that options does have any 15646 particular values set, and so this change ensures that all of 15647 the subclasses are following the same, intended, logic. 15648 15649 Arguably this is the wrong semantics to have, and the Port 15650 classes should be able to assume a default set of 15651 attributes/arguments, but that change will need to wait for a 15652 different CL where we can modify new-run-webkit-tests to pull a 15653 list of arguments from the port factory routines. 15654 15655 Also, add unit tests for webkitpy.tool.mocktool.MockOptions . 15656 15657 https://bugs.webkit.org/show_bug.cgi?id=47510 15658 15659 * Scripts/webkitpy/layout_tests/port/base.py: 15660 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 15661 * Scripts/webkitpy/layout_tests/port/chromium.py: 15662 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 15663 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 15664 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 15665 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 15666 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 15667 * Scripts/webkitpy/layout_tests/port/dryrun.py: 15668 * Scripts/webkitpy/layout_tests/port/factory_unittest.py: 15669 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 15670 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 15671 * Scripts/webkitpy/layout_tests/port/test.py: 15672 * Scripts/webkitpy/layout_tests/port/webkit.py: 15673 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 15674 * Scripts/webkitpy/tool/mocktool_unittest.py: Added. 15675 156762010-10-18 Dirk Pranke <dpranke@chromium.org> 15677 15678 Reviewed by Eric Seidel. 15679 15680 Re-submit a revised version of r69638 - enabling new-run-webkit-tests 15681 under cygwin. The initial version had a bug in base:uri_to_test_name 15682 that was causing tests to fail. This version corrects that bug, but 15683 also makes the code safer by calling cygpath more reliably, and 15684 leaving a long-running cygpath process open. 15685 15686 This patch also corrects a couple of minor bugs in http_lock_unittest, 15687 chromium_unittest, and dedpulicate_tests_unittest that showed up 15688 while testing this. 15689 15690 https://bugs.webkit.org/show_bug.cgi?id=47220 15691 15692 * Scripts/webkitpy/common/system/path.py: 15693 * Scripts/webkitpy/common/system/path_unittest.py: 15694 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 15695 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 15696 * Scripts/webkitpy/layout_tests/port/base.py: 15697 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 15698 * Scripts/webkitpy/layout_tests/port/chromium.py: 15699 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 15700 * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: 15701 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 15702 157032010-10-18 Eric Seidel <eric@webkit.org> 15704 15705 Reviewed by Adam Barth. 15706 15707 Add Queue class and add minimal unittesting of QueueStatusServer code 15708 https://bugs.webkit.org/show_bug.cgi?id=47847 15709 15710 * QueueStatusServer/handlers/dashboard.py: 15711 * QueueStatusServer/handlers/queuestatus.py: 15712 * QueueStatusServer/handlers/recentstatus.py: 15713 * QueueStatusServer/handlers/statusbubble.py: 15714 * QueueStatusServer/handlers/updateworkitems.py: 15715 * QueueStatusServer/model/attachment.py: 15716 * QueueStatusServer/model/queues.py: 15717 * QueueStatusServer/model/queues_unittest.py: Added. 15718 * QueueStatusServer/model/svnrevision.py: 15719 * Scripts/test-webkitpy: 15720 * Scripts/webkitpy/test/main.py: 15721 157222010-10-18 Anders Carlsson <andersca@apple.com> 15723 15724 Fix build. 15725 15726 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 15727 (handleEventCarbon): 15728 157292010-10-18 Stuart Morgan <stuartmorgan@chromium.org> 15730 15731 Reviewed by Eric Seidel. 15732 15733 Switch to using the new Carbon NPAPI event declarations, and remove 15734 the old ones. 15735 15736 https://bugs.webkit.org/show_bug.cgi?id=40784 15737 15738 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 15739 (handleEventCarbon): 15740 157412010-10-18 David Levin <levin@chromium.org> 15742 15743 Reviewed by Adam Barth. 15744 15745 check-webkit-style should treat the GObject binding directory like other GTK directories. 15746 https://bugs.webkit.org/show_bug.cgi?id=47796 15747 15748 * Scripts/webkitpy/style/checker.py: Added the GObject binding directory 15749 with the other gtk directories (and fixed typo). 15750 157512010-10-18 David Levin <levin@chromium.org> 15752 15753 Reviewed by Oliver Hunt. 15754 15755 check-webkit-style needs to ignore underscores in opcode names and vm_throw 15756 https://bugs.webkit.org/show_bug.cgi?id=47789 15757 15758 * Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory. 15759 * Scripts/webkitpy/style/checkers/cpp.py: Added special cased names. 15760 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases. 15761 157622010-10-18 MORITA Hajime <morrita@google.com> 15763 15764 Reviewed by Kent Tamura. 15765 15766 TextInputController.hasSpellingMarkers() should be owned by LayoutTestController 15767 https://bugs.webkit.org/show_bug.cgi?id=47659 15768 15769 Moved hasSpellingMarkers() from TextInputController to 15770 LayoutTestController. Currently the implementation is available 15771 only for Mac and for Chromium. 15772 15773 * DumpRenderTree/LayoutTestController.cpp: 15774 (hasSpellingMarkerCallback): 15775 (LayoutTestController::staticFunctions): 15776 * DumpRenderTree/LayoutTestController.h: 15777 * DumpRenderTree/chromium/LayoutTestController.cpp: 15778 (LayoutTestController::LayoutTestController): 15779 (LayoutTestController::hasSpellingMarker): 15780 * DumpRenderTree/chromium/LayoutTestController.h: 15781 * DumpRenderTree/chromium/TextInputController.cpp: 15782 (TextInputController::TextInputController): 15783 (TextInputController::makeAttributedString): 15784 * DumpRenderTree/chromium/TextInputController.h: 15785 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 15786 (LayoutTestController::hasSpellingMarker): 15787 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 15788 (LayoutTestController::hasSpellingMarker): 15789 * DumpRenderTree/mac/TextInputController.m: 15790 (+[TextInputController isSelectorExcludedFromWebScript:]): 15791 (+[TextInputController webScriptNameForSelector:]): 15792 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 15793 (LayoutTestController::hasSpellingMarker): 15794 * DumpRenderTree/qt/LayoutTestControllerQt.h: 15795 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 15796 (LayoutTestController::hasSpellingMarker): 15797 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 15798 (LayoutTestController::hasSpellingMarker): 15799 158002010-10-18 Adam Barth <abarth@webkit.org> 15801 15802 Reviewed by David Levin. 15803 15804 commit-queue's flaky test notice is very Pythony 15805 https://bugs.webkit.org/show_bug.cgi?id=47790 15806 15807 This patch make the list of tests delimted by \n instead of just 15808 converting the array to a string. 15809 15810 * Scripts/webkitpy/tool/commands/queues.py: 15811 * Scripts/webkitpy/tool/commands/queues_unittest.py: 15812 158132010-10-14 Antonio Gomes <agomes@rim.com> 15814 15815 Reviewed by Martin Robinson and Xan Lopez. 15816 15817 [Gtk]: DRT does not support frame flattening testing 15818 https://bugs.webkit.org/show_bug.cgi?id=38650 15819 15820 Implement DRT's support for toggling on/off frame flattening 15821 support. 15822 15823 * DumpRenderTree/gtk/DumpRenderTree.cpp: 15824 (resetDefaultsToConsistentValues): 15825 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 15826 (LayoutTestController::setFrameFlatteningEnabled): 15827 158282010-10-15 Dirk Pranke <dpranke@chromium.org> 15829 15830 Reviewed by Eric Siedel. 15831 15832 mocktool.MockOptions is inheriting from Mock, which has the side 15833 effect of defaulting any attribute to another MockObject. So, 15834 MockOptions().foo would always evaluate to true. This was 15835 covering over bugs in the unit tests, and is probably the wrong 15836 default behavior for anything attempting to mock out the options 15837 argument returned from optparse.parse_args(). 15838 15839 This patch changes the default behavior. The new MockOptions() 15840 class takes an optional list of keyword parameters to set; this 15841 patch doesn't use that feature but the fix for bug 47510 will. 15842 15843 Also, this patch just fills in the default values necessary to 15844 get all of the tests to pass; I didn't stare at each test by 15845 hand to determine the "right" values. We can either fix that in 15846 subsequent patches or let me know if we want to do that now (and 15847 give me some guidance on what those values might want to be). 15848 15849 https://bugs.webkit.org/show_bug.cgi?id=47709 15850 15851 * Scripts/webkitpy/tool/commands/commandtest.py: 15852 * Scripts/webkitpy/tool/commands/download_unittest.py: 15853 * Scripts/webkitpy/tool/commands/upload_unittest.py: 15854 * Scripts/webkitpy/tool/mocktool.py: 15855 * Scripts/webkitpy/tool/steps/steps_unittest.py: 15856 * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: 15857 158582010-10-15 Simon Fraser <simon.fraser@apple.com> 15859 15860 Fix the build; need to add new slot to PageUIClient callbacks. 15861 15862 * MiniBrowser/mac/BrowserWindowController.m: 15863 (-[BrowserWindowController awakeFromNib]): 15864 * WebKitTestRunner/TestController.cpp: 15865 (WTR::createOtherPage): 15866 (WTR::TestController::initialize): 15867 158682010-10-15 Simon Fraser <simon.fraser@apple.com> 15869 15870 Add Matt Delaney to committers.py. 15871 15872 * Scripts/webkitpy/common/config/committers.py: 15873 158742010-10-15 Tony Chang <tony@chromium.org> 15875 15876 Reviewed by Kent Tamura. 15877 15878 [chromium] compile TestNetscapePlugIn on Chromium mac 15879 https://bugs.webkit.org/show_bug.cgi?id=47633 15880 15881 * DumpRenderTree/DumpRenderTree.gypi: files to compile 15882 * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining 15883 (NP_GetEntryPoints): 15884 (NPP_New): 15885 (NPP_Destroy): 15886 (NPP_HandleEvent): 15887 (NPP_GetValue): 15888 * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added. 15889 * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added. 15890 * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added. 15891 158922010-10-15 Leandro Pereira <leandro@profusion.mobi> 15893 15894 Reviewed by Gustavo Noronha Silva. 15895 15896 build-webkit: Should die when make fails when build a CMake project 15897 https://bugs.webkit.org/show_bug.cgi?id=47726 15898 15899 * Scripts/webkitdirs.pm: If make fails, die immediately. 15900 159012010-10-15 Sheriff Bot <webkit.review.bot@gmail.com> 15902 15903 Unreviewed, rolling out r69809. 15904 http://trac.webkit.org/changeset/69809 15905 https://bugs.webkit.org/show_bug.cgi?id=47725 15906 15907 Broke chromium mac compile (Requested by japhet on #webkit). 15908 15909 * DumpRenderTree/DumpRenderTree.gypi: 15910 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 15911 (NP_GetEntryPoints): 15912 (NPP_New): 15913 (NPP_Destroy): 15914 (NPP_HandleEvent): 15915 (NPP_GetValue): 15916 * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed. 15917 * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed. 15918 * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed. 15919 159202010-10-15 Adam Barth <abarth@webkit.org> 15921 15922 Reviewed by Adam Barth. 15923 15924 test-webkitpy fails on Linux 15925 https://bugs.webkit.org/show_bug.cgi?id=47713 15926 15927 The old code failed on Linux because the MacPort tries to read 15928 something out of platform that doesn't make sense on Linux. 15929 15930 * Scripts/webkitpy/tool/mocktool.py: 15931 159322010-10-14 Balazs Kelemen <kbalazs@webkit.org> 15933 15934 Reviewed by Kenneth Rohde Christiansen. 15935 15936 [Qt] WTR is sloooow 15937 https://bugs.webkit.org/show_bug.cgi?id=47695 15938 15939 * WebKitTestRunner/qt/TestControllerQt.cpp: 15940 Change the timer interval of RunUntilConditionLoop from 15941 50 milliseconds to 1 to avoid wasting time after the 15942 test had been finished. 15943 159442010-10-14 Eric Seidel <eric@webkit.org> 15945 15946 Unreviewed, just fixing an exception seen on the commit-queue. 15947 15948 I should have unit tested this function before. 15949 15950 * Scripts/webkitpy/tool/commands/queues.py: 15951 * Scripts/webkitpy/tool/commands/queues_unittest.py: 15952 159532010-10-14 Eric Seidel <eric@webkit.org> 15954 15955 Reviewed by Adam Barth. 15956 15957 commit-queue should not fail patches due to flaky tests 15958 https://bugs.webkit.org/show_bug.cgi?id=47647 15959 15960 This patch makes it so that the *same* flaky test has to fail 15961 twice in a row to have a false negative from a flaky test. 15962 15963 If different flaky tests fail (or if a test fails and then passes 15964 in a second run) then we will warn in the bug that we encountered 15965 a flaky test. 15966 15967 This patch grew to include moving port off of steps onto tool 15968 (which Adam wrote and then I integrated), as well as removing the 15969 use of tool from CommitQueueTask. 15970 15971 * Scripts/webkitpy/common/config/ports.py: 15972 - Added a layout_test_results_path method. This covers old-run-webkit-tests 15973 but doesn't cover NRWT. This is probably not the long term solution, but 15974 putting this knowledge on port makes more sense than in LayoutTestResults. 15975 * Scripts/webkitpy/common/net/buildbot.py: 15976 - LayoutTestResults shouldn't know how to fetch from the network, make 15977 the Build code do that instead. 15978 * Scripts/webkitpy/common/net/buildbot_unittest.py: 15979 - Code style fix. 15980 * Scripts/webkitpy/common/net/layouttestresults.py: 15981 - Remove code for reading from the network. 15982 * Scripts/webkitpy/common/net/layouttestresults_unittest.py: 15983 - Test the new entrypoint. 15984 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 15985 - Make the delegate interface explicit. 15986 - Remove the _tool member, since using the delegate for 15987 everything is cleaner. 15988 - Teach the testing logic how to deal with flaky tests. 15989 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 15990 - Update to match the CommitQueueTask changes. 15991 * Scripts/webkitpy/tool/commands/queues.py: 15992 - Use the new CommitQueueTaskDelegate interface. 15993 * Scripts/webkitpy/tool/commands/queues_unittest.py: 15994 - Fix the SecondThoughtsCommitQueue test which was broken. 15995 - Add a new test to make sure the flaky test reporting works. 15996 * Scripts/webkitpy/tool/main.py: 15997 - Store the port on the tool object. 15998 * Scripts/webkitpy/tool/mocktool.py: 15999 - Add a port() accessor to MockTool 16000 * Scripts/webkitpy/tool/steps/abstractstep.py: 16001 - Move port() off of Step and onto Tool. 16002 * Scripts/webkitpy/tool/steps/build.py: 16003 * Scripts/webkitpy/tool/steps/preparechangelog.py: 16004 * Scripts/webkitpy/tool/steps/runtests.py: 16005 * Scripts/webkitpy/tool/steps/steps_unittest.py: 16006 - Two tests with the same name! only the latter was being run. 16007 * Scripts/webkitpy/tool/steps/update.py: 16008 160092010-10-14 Dirk Pranke <dpranke@chromium.org> 16010 16011 Reviewed by Eric Seidel. 16012 16013 new-run-webkit-tests will now handle missing Ruby installs (or 16014 missing PrettyPatch scripts) more cleanly - previously this 16015 would be detected when we actually tried to create the diff, and 16016 the error message was obscure. Now we'll log a warning up front 16017 and otherwise be silent. 16018 16019 This change also refactors some global variables to be class or 16020 instance variables to be slightly more testable and more 16021 modular. There are no cases where we create lots of port objects 16022 and can't afford to test for configurations repeatedly, so 16023 there's no performance concern here. 16024 16025 https://bugs.webkit.org/show_bug.cgi?id=47466 16026 16027 * Scripts/webkitpy/layout_tests/port/base.py: 16028 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 16029 * Scripts/webkitpy/layout_tests/port/chromium.py: 16030 160312010-10-08 Martin Robinson <mrobinson@igalia.com> 16032 16033 Reviewed by Xan Lopez. 16034 16035 [GTK] Form controls do not respect GTK+ font size 16036 https://bugs.webkit.org/show_bug.cgi?id=47134 16037 16038 * DumpRenderTree/gtk/DumpRenderTree.cpp: 16039 (initializeGtkFontSettings): Initialize the font control size when running 16040 DumpRenderTree to a standard value. 16041 160422010-10-14 Tony Chang <tony@chromium.org> 16043 16044 Reviewed by Kent Tamura. 16045 16046 [chromium] compile TestNetscapePlugIn on Chromium mac 16047 https://bugs.webkit.org/show_bug.cgi?id=47633 16048 16049 * DumpRenderTree/DumpRenderTree.gypi: files to compile 16050 * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining 16051 (NP_GetEntryPoints): 16052 (NPP_New): 16053 (NPP_Destroy): 16054 (NPP_HandleEvent): 16055 (NPP_GetValue): 16056 * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added. 16057 * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added. 16058 * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added. 16059 160602010-10-14 Victor Wang <victorw@chromium.org> 16061 16062 Reviewed by Nate Chapin. 16063 16064 [Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff. 16065 16066 https://bugs.webkit.org/show_bug.cgi?id=47686 16067 16068 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 16069 160702010-10-14 Eric Seidel <eric@webkit.org> 16071 16072 Reviewed by Adam Barth. 16073 16074 test-webkitpy spews Delegate terminated queue messages 16075 https://bugs.webkit.org/show_bug.cgi?id=47678 16076 16077 * Scripts/webkitpy/tool/bot/queueengine_unittest.py: 16078 160792010-10-14 Adam Roben <aroben@apple.com> 16080 16081 Test that pressing the Alt key generates a WM_SYSCOMMAND message 16082 16083 Test for <http://webkit.org/b/47671> <rdar://problem/8435594> Pressing 16084 the Alt key when MiniBrowser's WKView is focused doesn't send focus to 16085 the menu bar 16086 16087 Reviewed by Steve Falkenburg. 16088 16089 * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added 16090 TestWebKitAPI/win to the include path so that WindowMessageObserver 16091 can be found. 16092 16093 * TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and 16094 Windows-specific members. 16095 (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): 16096 Added this simple setter. 16097 16098 * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added. 16099 (TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver): 16100 Initialize our lone data member. 16101 (TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand): 16102 Simple getter. 16103 (TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record 16104 when a WM_SYSCOMMAND message is received. 16105 (TestWebKitAPI::didNotHandleKeyEventCallback): Record when a 16106 WM_SYSKEYUP message is not handled. 16107 (TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate 16108 pressing the Alt key and check that a WM_SYSCOMMAND message got sent 16109 to the WKView's parent window. 16110 16111 * TestWebKitAPI/win/PlatformWebViewWin.cpp: 16112 (TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a 16113 member function so it could access PlatformWebView::wndProc. Use 16114 PlatformWebView::wndProc as the WNDPROC. 16115 (TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new 16116 data member and pass the this pointer to CreateWindowEx so we can 16117 store it on the HWND. 16118 (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some 16119 constants from here to the top of the file. 16120 (TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends 16121 the same messages that Notepad receives when you press the Alt key. 16122 (TestWebKitAPI::PlatformWebView::wndProc): Added. 16123 - When WM_CREATE is received, we set the PlatformWebView instance 16124 pointer as a property on the HWND so we can access it later. 16125 - For other messages, we try to get the PlatformWebView instance 16126 pointer from the HWND property. 16127 - When WM_NCDESTROY is received (which is the last message we will 16128 receive), we remove the PlatformWebView instance property. 16129 - Pass messages to the parent window's message observer, if there is 16130 one. 16131 - Pass all messages through to ::DefWindowProcW. 16132 16133 * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver 16134 and AltKeyGeneratesWMSysCommand. 16135 16136 * TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be 16137 used to observe messages sent to one or more windows. 16138 161392010-10-01 Martin Robinson <mrobinson@igalia.com> 16140 16141 Reviewed by Holger Freyther. 16142 16143 [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558 16144 https://bugs.webkit.org/show_bug.cgi?id=47033 16145 16146 * DumpRenderTree/gtk/DumpRenderTree.cpp: 16147 (initializeGtkFontSettings): Added this method which initializes XSettings 16148 font settings to consistent values before running a test. For the one test 16149 in which we need subpixel aliasing turned on, do that. 16150 (initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings. 16151 (runTest): Pass the testURL to initializeFonts. 16152 161532010-10-14 Adam Barth <abarth@webkit.org> 16154 16155 Reviewed by Eric Seidel. 16156 16157 ChromiumXVFBPort.run_webkit_tests_command has infinite recursion 16158 https://bugs.webkit.org/show_bug.cgi?id=47655 16159 16160 * Scripts/webkitpy/common/config/ports.py: 16161 * Scripts/webkitpy/common/config/ports_unittest.py: 16162 161632010-10-13 Eric Seidel <eric@webkit.org> 16164 16165 Reviewed by Adam Barth. 16166 16167 beat diff_parser with the ugly stick 16168 https://bugs.webkit.org/show_bug.cgi?id=47626 16169 16170 * Scripts/webkitpy/common/checkout/diff_parser.py: 16171 * Scripts/webkitpy/style/patchreader.py: 16172 * Scripts/webkitpy/style/patchreader_unittest.py: 16173 161742010-10-13 Eric Seidel <eric@webkit.org> 16175 16176 Reviewed by Adam Barth. 16177 16178 Break LayoutTestResults out into its own file 16179 https://bugs.webkit.org/show_bug.cgi?id=47637 16180 16181 * Scripts/webkitpy/common/net/buildbot.py: 16182 * Scripts/webkitpy/common/net/buildbot_unittest.py: 16183 * Scripts/webkitpy/common/net/layouttestresults.py: Added. 16184 * Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added. 16185 161862010-10-13 Adam Barth <abarth@webkit.org> 16187 16188 Unreviewed. 16189 16190 Chromium port can't run JavaScriptCore tests 16191 https://bugs.webkit.org/show_bug.cgi?id=47654 16192 16193 This lets webkit-patch build-and-test work on Chromium. 16194 16195 * Scripts/webkitpy/common/config/ports.py: 16196 * Scripts/webkitpy/tool/steps/runtests.py: 16197 161982010-10-13 Adam Barth <abarth@webkit.org> 16199 16200 Reviewed by Eric Seidel. 16201 16202 Make --port a global option and pass the port information to the commit-queue subprocess 16203 https://bugs.webkit.org/show_bug.cgi?id=47650 16204 16205 This patch paves the way to run the commit-queue on a non-Mac port. 16206 16207 * Scripts/webkitpy/tool/commands/queues.py: 16208 * Scripts/webkitpy/tool/commands/queues_unittest.py: 16209 * Scripts/webkitpy/tool/commands/queuestest.py: 16210 * Scripts/webkitpy/tool/main.py: 16211 * Scripts/webkitpy/tool/steps/options.py: 16212 * Scripts/webkitpy/tool/steps/preparechangelog.py: 16213 * Scripts/webkitpy/tool/steps/runtests.py: 16214 * Scripts/webkitpy/tool/steps/update.py: 16215 162162010-10-13 Adam Barth <abarth@webkit.org> 16217 16218 Reviewed by Eric Seidel. 16219 16220 Introduce the ChromiumXVFBPort for running commit-queue on EC2 16221 https://bugs.webkit.org/show_bug.cgi?id=47653 16222 16223 I'm not entirely sure this is the best way to do this, but we need to 16224 run the tests under XVFB on EC2 because the EC2 instances don't have a 16225 real monitor hooked up. This patch adds a ChromiumXVFBPort that runs 16226 that way. The idea is that XVFB is like a platform for the Chromium 16227 port, but we don't have a real notion of platform separate from port. 16228 16229 * Scripts/webkitpy/common/config/ports.py: 16230 162312010-10-13 Sergio Villar Senin <svillar@igalia.com> 16232 16233 Reviewed by Martin Robinson. 16234 16235 [GTK] Add HTTP caching support 16236 https://bugs.webkit.org/show_bug.cgi?id=44261 16237 16238 Add include paths for the new soup HTTP cache code. 16239 16240 * GNUmakefile.am: Add paths for the new soup HTTP cache code. 16241 162422010-10-13 Yi Shen <yi.4.shen@nokia.com> 16243 16244 Reviewed by Antonio Gomes. 16245 16246 [Qt] QtTestBrowser shows two Url input fields 16247 https://bugs.webkit.org/show_bug.cgi?id=47613 16248 16249 * QtTestBrowser/mainwindow.cpp: 16250 (MainWindow::MainWindow): 16251 (MainWindow::buildUI): 16252 162532010-10-13 Yi Shen <yi.4.shen@nokia.com> 16254 16255 Reviewed by Tony Chang. 16256 16257 [gdb] Add pretty-print supports for UString, Identifier and JSString 16258 https://bugs.webkit.org/show_bug.cgi?id=47601 16259 16260 * gdb/webkit.py: 16261 162622010-10-13 Adam Barth <abarth@webkit.org> 16263 16264 Reviewed by Eric Seidel. 16265 16266 Add list of Ubuntu packages needed by the EWS bots 16267 https://bugs.webkit.org/show_bug.cgi?id=47628 16268 16269 I've been copy/pasting this list between bots, but it's better to have 16270 this checked in. 16271 16272 * EWSTools/ubuntu-ews-packages: Added. 16273 162742010-10-13 Leandro Pereira <leandro@profusion.mobi> 16275 16276 Reviewed by Csaba Osztrogonác. 16277 16278 [EFL] Adds a build slave. 16279 https://bugs.webkit.org/show_bug.cgi?id=47290 16280 16281 * BuildSlaveSupport/build.webkit.org-config/config.json: Add an 16282 entry for a release build of the EFL port. 16283 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform 16284 flag to build the EFL port. 16285 162862010-10-13 Adam Barth <abarth@webkit.org> 16287 16288 Reviewed by Csaba Osztrogonác. 16289 16290 webkit-patch build shouldn't need --build to actually build! 16291 https://bugs.webkit.org/show_bug.cgi?id=47438 16292 16293 Yeah, requiring --build for the build command is really dumb. We did 16294 this originally because the build step is usually optional in other 16295 commands. We don't have a good way of reversing the default for an 16296 option in one command. This approach is slightly hacky since --build 16297 still shows up as an option on the help page, but at least it makes 16298 progress. Passing --build is harmless, so the EWS bots shouldn't 16299 explode because of this change. 16300 16301 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 16302 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 16303 * Scripts/webkitpy/tool/commands/download.py: 16304 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 16305 * Scripts/webkitpy/tool/commands/queues_unittest.py: 16306 163072010-10-13 Sheriff Bot <webkit.review.bot@gmail.com> 16308 16309 Unreviewed, rolling out r69638. 16310 http://trac.webkit.org/changeset/69638 16311 https://bugs.webkit.org/show_bug.cgi?id=47595 16312 16313 "Broke win and chromium-win bots" (Requested by dglazkov on 16314 #webkit). 16315 16316 * Scripts/webkitpy/common/system/path.py: 16317 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 16318 * Scripts/webkitpy/layout_tests/port/base.py: 16319 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 16320 * Scripts/webkitpy/layout_tests/port/chromium.py: 16321 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 16322 163232010-10-13 John Knottenbelt <jknotten@chromium.org> 16324 16325 Reviewed by Steve Block. 16326 16327 First step towards client-based Geolocation in Chromium. Build 16328 fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define. 16329 https://bugs.webkit.org/show_bug.cgi?id=47586 16330 16331 * DumpRenderTree/chromium/WebViewHost.cpp: 16332 * DumpRenderTree/chromium/WebViewHost.h: 16333 163342010-10-13 Adam Roben <aroben@apple.com> 16335 16336 Test that pressing the spacebar in a text field does not scroll the 16337 document 16338 16339 Test for <http://webkit.org/b/47544> <rdar://problem/8540645> 16340 REGRESSION: Pressing spacebar in a text field in WebKit2 does not 16341 insert a space, scrolls the page instead 16342 16343 Reviewed by Sam Weinig. 16344 16345 * TestWebKitAPI/PlatformUtilities.h: Added isKeyDown. 16346 16347 * TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress. 16348 16349 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 16350 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 16351 * TestWebKitAPI/win/copy-resources.cmd: 16352 Added new files. 16353 16354 * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added. 16355 (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): 16356 We use this to track what the result of calling into JavaScript was. 16357 (TestWebKitAPI::didFinishLoadForFrame): Records when the page 16358 finishes loading. 16359 (TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down 16360 event is not handled. 16361 (TestWebKitAPI::javaScriptCallback): Records that JavaScript finished 16362 executing and whether the result matched our expectation. 16363 (TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef. 16364 (TestWebKitAPI::runJSTest): Calls into JS, waits for the call to 16365 complete, and returns whether we got back the expected result. 16366 (TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing 16367 spacebar inside a text field does not scroll the document and that 16368 pressing it outside the text field does scroll the document. 16369 16370 * TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added. 16371 16372 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: 16373 (TestWebKitAPI::Util::isKeyDown): Checks the event's type. 16374 16375 * TestWebKitAPI/mac/PlatformWebViewMac.mm: 16376 (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied 16377 code from DRT's EventSendingController. 16378 16379 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: 16380 (TestWebKitAPI::Util::isKeyDown): Checks the message's type. 16381 16382 * TestWebKitAPI/win/PlatformWebViewWin.cpp: 16383 (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the 16384 same messages that get sent when you press spacebar in Notepad. 16385 163862010-10-13 Adam Roben <aroben@apple.com> 16387 16388 Fix a couple of issues with the TestWebKitAPI build 16389 16390 * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: 16391 * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: 16392 Fixed a typo. 16393 16394 * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops 16395 to set our output and intermediate directories so that we don't spew 16396 files into the source tree. 16397 163982010-10-13 Balazs Kelemen <kbalazs@webkit.org> 16399 16400 Reviewed by Csaba Osztrogonác. 16401 16402 WTR should accept relative paths 16403 https://bugs.webkit.org/show_bug.cgi?id=47486 16404 16405 * WebKitTestRunner/StringFunctions.h: 16406 * WebKitTestRunner/TestInvocation.cpp: 16407 (WTR::createWKURL): Moved from StringFunctions.h since it is 16408 used only here. Extend relative paths to absolute. 16409 164102010-10-12 Adam Roben <aroben@apple.com> 16411 16412 Make TestWebKitAPI work on Windows 16413 16414 Fixes <http://webkit.org/b/47552> <rdar://problem/8541708>. 16415 16416 Reviewed by Sam Weinig. 16417 16418 * Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows. 16419 16420 * Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be 16421 run on Windows. 16422 (runTest): Added code to run TestWebKitAPI.exe on Windows and to die 16423 on unsupported platforms. 16424 (populateTests): Added code to run TestWebKitAPI.exe on Windows and to 16425 die on other platforms. Extracted some formerly-Mac-specific code to 16426 be cross-platform and made it handle any style of line-endings. 16427 16428 * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added. 16429 Links against CFLite. 16430 16431 * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added. 16432 Contains most properties for the project. 16433 16434 * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: 16435 Added. Links against CoreFoundation. 16436 16437 * TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific 16438 section and moved the cross-platform section after the 16439 platform-specific parts. 16440 16441 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added. 16442 (TestWebKitAPI::Util::run): Runs a normal message pump until we're 16443 done. 16444 (TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString. 16445 (TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the 16446 resource path. 16447 (TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus 16448 WKURL. 16449 16450 * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added. 16451 (TestWebKitAPI::registerWindowClass): 16452 (TestWebKitAPI::PlatformWebView::PlatformWebView): 16453 (TestWebKitAPI::PlatformWebView::~PlatformWebView): 16454 (TestWebKitAPI::PlatformWebView::page): 16455 This was mostly copied from WebKitTestRunner's PlatformWebView. 16456 16457 * TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both 16458 TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the 16459 build-api-tests script. 16460 16461 * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds 16462 TestWebKitAPI.exe. 16463 16464 * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls 16465 through to copy-resources.cmd. 16466 16467 * TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into 16468 or deletes resources from TestWebKitAPI.resources. 16469 16470 * TestWebKitAPI/win/main.cpp: Added. 16471 (main): Calls through to TestsController. 16472 164732010-10-13 Gyuyoung Kim <gyuyoung.kim@samsung.com> 16474 16475 Reviewed by Kenneth Rohde Christiansen. 16476 16477 [EFL] Support viewport configuration and add new arguments for WebKit EFL 16478 https://bugs.webkit.org/show_bug.cgi?id=47084 16479 16480 Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port 16481 needs to be modified according to the changes. 16482 16483 * EWebLauncher/main.c: 16484 (on_viewport_changed): 16485 164862010-10-12 Dirk Pranke <dpranke@chromium.org> 16487 16488 Reviewed by Eric Seidel. 16489 16490 This patch enables new-run-webkit-tests (in particular the 16491 chromium-win port) to run under Cygwin as well as Win32. Mostly 16492 this just required some conversions from cygwin paths to Win32 16493 paths when we spawn off Win32 binaries like test_shell. 16494 16495 https://bugs.webkit.org/show_bug.cgi?id=47220 16496 16497 * Scripts/webkitpy/common/system/path.py: 16498 - Expose the cygpath() function for path conversion 16499 16500 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 16501 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 16502 - shift filename->uri conversion in the TestInfo objects to the 16503 dump_render_tree thread 16504 16505 * Scripts/webkitpy/layout_tests/port/base.py: 16506 * Scripts/webkitpy/layout_tests/port/chromium.py: 16507 - use cygpath() 16508 165092010-10-12 Yuta Kitamura <yutak@chromium.org> 16510 16511 Unreviewed. Add Yuta Kitamura (yutak) to the committers list. 16512 16513 * Scripts/webkitpy/common/config/committers.py: 16514 165152010-10-12 Sam Weinig <sam@webkit.org> 16516 16517 Reviewed by Dan Bernstein. 16518 16519 When a provisional load fails, the provisional URL returned 16520 from WKFrameCopyProvisionalURL should be empty 16521 <rdar://problem/8540878> 16522 https://bugs.webkit.org/show_bug.cgi?id=47546 16523 16524 Add test. 16525 16526 * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: 16527 (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): 16528 165292010-10-12 Anders Carlsson <andersca@apple.com> 16530 16531 Reviewed by Sam Weinig. 16532 16533 Start fleshing out find page overlays 16534 https://bugs.webkit.org/show_bug.cgi?id=47559 16535 16536 * MiniBrowser/mac/BrowserWindowController.m: 16537 (-[BrowserWindowController find:]): 16538 Pass kWKFindOptionsShowOverlay to WKPageFindString. 16539 165402010-10-12 Robert Hogan <robert@webkit.org> 16541 16542 Reviewed by Antonio Gomes. 16543 16544 [Qt] editing/input/emacs-ctrl-o.html 16545 16546 ctrl-o is bound to a sequence of commands on Mac, namely: 16547 insertParagraphSeparator then moveLeft. In the DRT, we just interpret 16548 ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a 16549 result we only issue one command, so don't generate the change in caret 16550 position that results in the extra editing delegate messages. 16551 16552 So for the sake of not managing suspicious-looking differences, just 16553 make DRT issue the appropriate edit commands to pass the test. 16554 16555 https://bugs.webkit.org/show_bug.cgi?id=47548 16556 16557 * DumpRenderTree/qt/EventSenderQt.cpp: 16558 (EventSender::keyDown): 16559 165602010-10-12 Anders Carlsson <andersca@apple.com> 16561 16562 Reviewed by Sam Weinig. 16563 16564 Add a simple Find UI to MiniBrowser 16565 https://bugs.webkit.org/show_bug.cgi?id=47553 16566 16567 * MiniBrowser/mac/BrowserWindow.xib: 16568 Add Find panel. 16569 16570 * MiniBrowser/mac/BrowserWindowController.h: 16571 * MiniBrowser/mac/BrowserWindowController.m: 16572 (-[BrowserWindowController performFindPanelAction:]): 16573 Show the find panel. 16574 16575 (-[BrowserWindowController find:]): 16576 Tell the WKPageRef to find the given string. 16577 165782010-10-12 Tony Chang <tony@chromium.org> 16579 16580 Unreviewed, fixing DRT compile on Windows after r69586. 16581 16582 * DumpRenderTree/chromium/WebThemeEngineDRT.h: 16583 165842010-10-12 Tony Chang <tony@chromium.org> 16585 16586 Unreviewed, trying to fix NRWT on Windows. 16587 16588 * Scripts/webkitpy/layout_tests/port/http_lock.py: 16589 165902010-10-12 Balazs Kelemen <kbalazs@webkit.org> 16591 16592 Reviewed by Kenneth Rohde Christiansen. 16593 16594 [Qt][WTR] Checking the path of the injected bundle is bogus 16595 https://bugs.webkit.org/show_bug.cgi?id=47541 16596 16597 * WebKitTestRunner/qt/TestControllerQt.cpp: 16598 (WTR::isExistingLibrary): Added (static helper). 16599 Extend the path with the appropriate suffix(es) on the 16600 platform and check that the file exists. 16601 (WTR::TestController::initializeInjectedBundlePath): 16602 There were two bugs with the path checking: 16603 - the condition should have been inverted 16604 - QLibrary::fileName does not give back the filename 16605 with the library suffix so we cannot check 16606 that existance of the file this way. 16607 166082010-10-12 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 16609 16610 Reviewed by Tony Chang. 16611 16612 Implement http locking in NRWT. 16613 https://bugs.webkit.org/show_bug.cgi?id=47072 16614 16615 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 16616 * Scripts/webkitpy/layout_tests/port/base.py: 16617 * Scripts/webkitpy/layout_tests/port/http_lock.py: Added. 16618 * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added. 16619 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 16620 166212010-10-12 Mark Rowe <mrowe@apple.com> 16622 16623 Fix the 32-bit WebKit2 build. 16624 16625 * MiniBrowser/mac/BrowserWindowController.m: 16626 (getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns. 16627 (setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects. 16628 166292010-10-11 Tony Chang <tony@chromium.org> 16630 16631 Reviewed by Adam Barth. 16632 16633 change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one 16634 https://bugs.webkit.org/show_bug.cgi?id=47513 16635 16636 bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete, 16637 which doesn't actually work. 16638 16639 * Scripts/webkitpy/common/config/committers.py: 16640 166412010-10-11 Prasad Tammana <prasadt@chromium.org> 16642 16643 Reviewed by Dmitry Titov. 16644 16645 Added support for showModalDialog on chromium port. 16646 16647 Implement showModalDialog for Layout tests for chromium port 16648 https://bugs.webkit.org/show_bug.cgi?id=46759 16649 16650 * DumpRenderTree/chromium/WebViewHost.cpp: 16651 (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop. 16652 (WebViewHost::runModal): Start a nested message loop and remember that. 16653 (WebViewHost::WebViewHost): Initialize m_inModalLoop. 16654 * DumpRenderTree/chromium/WebViewHost.h: Add m_inModalLoop. 16655 166562010-10-11 Martin Robinson <mrobinson@igalia.com> 16657 16658 Reviewed by Gustavo Noronha Silva. 16659 16660 [GTK] Cleanup font selection code for the Freetype backend 16661 https://bugs.webkit.org/show_bug.cgi?id=47503 16662 16663 Update DRT to set values for the cursive and fantasy font families, so 16664 that we can generate consistent results for tests that use these families. 16665 Add some missing information to fonts.conf. 16666 16667 * DumpRenderTree/gtk/DumpRenderTree.cpp: 16668 (resetDefaultsToConsistentValues): Always set the fantasy and cursive font 16669 family names. 16670 * DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts 16671 to our default serif font. Eventually we may want to import or require some "real" 16672 fonts, but this should at least ensure consistent rendering during test runs. Also 16673 add aliases for some other commonly used fonts in tests (Arial and Lucida Grande). 16674 Finally, add a missing oblique specification for DejaVu Serif, which was resulting 16675 in some incorrect baselines for the synthetic oblique test. 16676 166772010-10-11 Adam Barth <abarth@webkit.org> 16678 16679 Unreviewed. 16680 16681 Fix sheriffbot not to crash when there are failing tests. It turns out 16682 Python sets don't support the + operator. We need to use union 16683 instead. There's a more elegant way to do this in Python 2.6, but we 16684 need this code to work in 2.5. 16685 16686 * Scripts/webkitpy/common/net/failuremap.py: 16687 * Scripts/webkitpy/common/net/failuremap_unittest.py: 16688 166892010-10-10 Robert Hogan <robert@webkit.org> 16690 16691 Unreviewed, fix failing test from r69468. 16692 16693 [Qt] Put all DRT-created pages in a page group 16694 16695 Fix on r69468. 16696 16697 Because we don't delete closed pages immediately in DRT we need 16698 to remove them from the page group explicitly instead. 16699 16700 Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html 16701 16702 https://bugs.webkit.org/show_bug.cgi?id=47469 16703 16704 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 16705 (WebCore::DumpRenderTree::windowCloseRequested): 16706 167072010-10-10 Leandro Pereira <leandro@profusion.mobi> 16708 16709 Reviewed by Adam Barth. 16710 16711 commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the 16712 EFL-EWS bot is up and running. 16713 https://bugs.webkit.org/show_bug.cgi?id=47277 16714 16715 * QueueStatusServer/handlers/statusbubble.py: 16716 167172010-10-10 Robert Hogan <robert@webkit.org> 16718 16719 Reviewed by Antonio Gomes. 16720 16721 [Qt] Put all DRT-created pages in a page group 16722 16723 https://bugs.webkit.org/show_bug.cgi?id=47469 16724 16725 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 16726 (WebCore::DumpRenderTree::DumpRenderTree): 16727 (WebCore::DumpRenderTree::createWindow): 16728 167292010-10-09 Sam Weinig <sam@webkit.org> 16730 16731 Reviewed by Dan Bernstein. 16732 16733 WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped 16734 <rdar://problem/8173667> 16735 https://bugs.webkit.org/show_bug.cgi?id=47461 16736 16737 * TestWebKitAPI/PlatformUtilities.h: 16738 * TestWebKitAPI/Test.h: 16739 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 16740 * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added. 16741 (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): 16742 (TestWebKitAPI::TEST): 16743 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: 16744 (TestWebKitAPI::Util::URLForNonExistentResource): 16745 Adds a test for the frame load state after a failed provisional load. I wanted to test 16746 the frame load state after a committed load failed, but I don't believe that is possible 16747 to do without hooking up the http server to serve a long loading page. 16748 167492010-10-09 Sam Weinig <sam@webkit.org> 16750 16751 Reviewed by Dan Bernstein. 16752 16753 Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage 16754 <rdar://problem/8447690> 16755 https://bugs.webkit.org/show_bug.cgi?id=47459 16756 16757 * MiniBrowser/mac/BrowserWindowController.m: 16758 (runBeforeUnloadConfirmPanel): 16759 (-[BrowserWindowController awakeFromNib]): 16760 * WebKitTestRunner/TestController.cpp: 16761 (WTR::createOtherPage): 16762 (WTR::TestController::initialize): 16763 167642010-10-09 Sam Weinig <sam@webkit.org> 16765 16766 Reviewed by Dan Bernstein. 16767 16768 Need implementation of ChromeClient windowRect related functions. 16769 <rdar://problem/8469476> 16770 https://bugs.webkit.org/show_bug.cgi?id=47386 16771 16772 * MiniBrowser/mac/BrowserWindowController.m: 16773 (getWindowFrame): 16774 (setWindowFrame): 16775 (-[BrowserWindowController awakeFromNib]): 16776 * WebKitTestRunner/PlatformWebView.h: 16777 * WebKitTestRunner/TestController.cpp: 16778 (WTR::TestController::initialize): 16779 * WebKitTestRunner/mac/PlatformWebViewMac.mm: 16780 (WTR::PlatformWebView::windowFrame): 16781 (WTR::PlatformWebView::setWindowFrame): 16782 * WebKitTestRunner/qt/PlatformWebViewQt.cpp: 16783 (WTR::PlatformWebView::windowFrame): 16784 (WTR::PlatformWebView::setWindowFrame): 16785 * WebKitTestRunner/win/PlatformWebViewWin.cpp: 16786 (WTR::PlatformWebView::windowFrame): 16787 (WTR::PlatformWebView::setWindowFrame): 16788 167892010-10-08 Adam Barth <abarth@webkit.org> 16790 16791 Unreviewed (Eric is on vacation in this change is trivial). 16792 16793 Add a "clean" command to webkit-patch to clean the working directory 16794 https://bugs.webkit.org/show_bug.cgi?id=47436 16795 16796 This command is useful when using SVN because "svn revert" leaves 16797 unversioned files behind. 16798 16799 * Scripts/webkitpy/tool/commands/download.py: 16800 168012010-10-08 Andras Becsi <abecsi@webkit.org> 16802 16803 Unreviewed build fix. 16804 16805 [Qt] Add missing limits.h include since the Qt version currently 16806 ran on the bot does need that. 16807 16808 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: 16809 168102010-10-08 Balazs Kelemen <kbalazs@webkit.org> 16811 16812 Reviewed by Csaba Osztrogonác. 16813 16814 [Qt] Turn on building WTR 16815 https://bugs.webkit.org/show_bug.cgi?id=47349 16816 16817 * Scripts/webkitdirs.pm: 16818 168192010-10-08 Balazs Kelemen <kbalazs@webkit.org> 16820 16821 Reviewed by Andreas Kling. 16822 16823 [Qt] TestController needs its platform dependent methods 16824 https://bugs.webkit.org/show_bug.cgi?id=47413 16825 16826 * WebKitTestRunner/qt/TestControllerQt.cpp: 16827 (WTR::TestController::initializeInjectedBundlePath): 16828 If the WTR_INJECTEDBUNDLE_PATH environmental variable is 16829 set then use that otherwise use the path where the bundle 16830 lives in a normal trunk build. 16831 (WTR::TestController::initializeTestPluginDirectory): 16832 Set the bundle's value. It is not used currently. 16833 (WTR::TestController::platformInitializeContext): 16834 * WebKitTestRunner/qt/WebKitTestRunner.pro: 16835 168362010-10-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 16837 16838 Reviewed by Kenneth Rohde Christiansen. 16839 16840 WTR: Prevent sending the Done message twice on test timeout. 16841 https://bugs.webkit.org/show_bug.cgi?id=47410 16842 16843 When InjectedBundle::done() calls stopLoading, this may trigger 16844 InjectedBundlePage::didFailLoadWithErrorForFrame which calls 16845 InjectedBundle::done() itself later in the stack. 16846 This would output the timeout failure message twice and confuse 16847 the run-webkit-tests script. 16848 16849 This patch adds a third state, Stopping, which prevents WebCore 16850 errors to trigger done() when testing is over. 16851 16852 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 16853 (WTR::InjectedBundle::done): 16854 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 16855 168562010-10-08 Andras Becsi <abecsi@webkit.org> 16857 16858 Reviewed by Kenneth Rohde Christiansen. 16859 16860 [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts(). 16861 Original code by Simon Hausmann. 16862 https://bugs.webkit.org/show_bug.cgi?id=47402 16863 16864 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added. 16865 (WTR::activateFonts): 16866 168672010-10-08 Andras Becsi <abecsi@webkit.org> 16868 16869 Reviewed by Csaba Osztrogonác. 16870 16871 [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests. 16872 https://bugs.webkit.org/show_bug.cgi?id=47401 16873 16874 * Scripts/build-webkittestrunner: 16875 * Scripts/old-run-webkit-tests: 16876 168772010-10-07 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 16878 16879 Reviewed by Kenneth Rohde Christiansen. 16880 16881 [Qt] WTR first compile: fix compile issues. 16882 https://bugs.webkit.org/show_bug.cgi?id=47343 16883 16884 * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: 16885 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 16886 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 16887 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 16888 * WebKitTestRunner/TestController.cpp: 16889 * WebKitTestRunner/TestInvocation.cpp: 16890 168912010-10-07 Antonio Gomes <agomes@rim.com> 16892 16893 Reviewed by Simon Fraser. 16894 16895 [Mac] [DRT] implement setSpatialNavigationEnabled 16896 https://bugs.webkit.org/show_bug.cgi?id=47291 16897 16898 Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT 16899 so it can track regression on the existing implementation and future improvements 16900 we are making. 16901 16902 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 16903 (LayoutTestController::setSpatialNavigationEnabled): 16904 169052010-10-07 Dirk Pranke <dpranke@chromium.org> 16906 16907 Reviewed by Adam Barth. 16908 16909 rebaseline-chromium-webkit-tests relied on the filename_to_uri() 16910 hook in the Port infrastructure to generate URIs for the files 16911 in its summary HTML report; however, that method is supposed to only 16912 be used for test files (and should really be renamed), so this would 16913 crash. 16914 16915 This change adds a new "path" module to the system package with a 16916 routine called abspath_to_uri() that handles converting paths to 16917 file: URIs independently of anything in the layout_tests package, 16918 and changes the code to use this. At some point in the near future 16919 the layout_tests/port/* code should use this as well. 16920 16921 This change also deletes a bunch of unused code and fixes some 16922 comments in rebaseline_chromium_webkit_tests.py. 16923 16924 https://bugs.webkit.org/show_bug.cgi?id=47319 16925 16926 * Scripts/webkitpy/common/system/path.py: Added. 16927 * Scripts/webkitpy/common/system/path_unittest.py: Added. 16928 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 16929 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 16930 169312010-10-07 Martin Robinson <mrobinson@igalia.com> 16932 16933 Reviewed by Gustavo Noronha Silva. 16934 16935 [GTK] The FreeType backend does not respect the FC_EMBOLDEN property 16936 https://bugs.webkit.org/show_bug.cgi?id=46216 16937 16938 Fix my latest commit, as it contained some bad changes from a merge gone wrong. 16939 16940 * DumpRenderTree/gtk/DumpRenderTree.cpp: 16941 (initializeFonts): Also initialize the DevaVu Sans font. 16942 169432010-10-07 Daniel Cheng <dcheng@chromium.org> 16944 16945 Reviewed by Tony Chang. 16946 16947 [chromium] Minor naming cleanup in WebDragData, part 2 16948 https://bugs.webkit.org/show_bug.cgi?id=47227 16949 16950 Update DRT to use the renamed methods. 16951 16952 * DumpRenderTree/chromium/EventSender.cpp: 16953 (EventSender::beginDragWithFiles): 16954 * DumpRenderTree/chromium/WebViewHost.cpp: 16955 (addDRTFakeFileToDataObject): 16956 169572010-10-07 Anders Carlsson <andersca@apple.com> 16958 16959 Reviewed by Sam Weinig. 16960 16961 Add a WKPageFindClient, hook up WKPageCountStringMatches 16962 https://bugs.webkit.org/show_bug.cgi?id=47373 16963 16964 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 16965 Remove hard coded paths. 16966 16967 * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: 16968 (TestWebKitAPI::TEST): 16969 Fix expected result. 16970 16971 * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added. 16972 (TestWebKitAPI::didFinishLoadForFrame): 16973 (TestWebKitAPI::didCountStringMatches): 16974 (TestWebKitAPI::TEST): 16975 * TestWebKitAPI/Tests/WebKit2/find.html: Added. 16976 Add test for WKPageCountStringMatches. 16977 169782010-09-21 Martin Robinson <mrobinson@igalia.com> 16979 16980 Reviewed by Chris Fleizach. 16981 16982 [GTK] The FreeType backend does not respect the FC_EMBOLDEN property 16983 https://bugs.webkit.org/show_bug.cgi?id=46216 16984 16985 * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN 16986 for DejaVu Serif when there is no bold version available. This is necessary to 16987 properly test the property in layout tests. 16988 169892010-10-07 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>, Andras Becsi <abecsi@webkit.org>, Balazs Kelemen <kbalazs@webkit.org> 16990 16991 Reviewed by Kenneth Rohde Christiansen. 16992 16993 [Qt] Add WTR's InjectedBundle build files. 16994 https://bugs.webkit.org/show_bug.cgi?id=47333 16995 16996 * Scripts/webkitdirs.pm: 16997 * WebKitTestRunner/DerivedSources.pro: Added. 16998 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added. 16999 * WebKitTestRunner/WebKitTestRunner.pro: Added. 17000 * WebKitTestRunner/qt/DerivedSources.pro: Removed. 17001 Content merged in ../DerivedSources.pro 17002 170032010-10-07 Sheriff Bot <webkit.review.bot@gmail.com> 17004 17005 Unreviewed, rolling out r69315. 17006 http://trac.webkit.org/changeset/69315 17007 https://bugs.webkit.org/show_bug.cgi?id=47363 17008 17009 Forgot to add the new files (Requested by kbalazs on #webkit). 17010 17011 * Scripts/webkitdirs.pm: 17012 * WebKitTestRunner/qt/DerivedSources.pro: Added. 17013 170142010-10-07 Sam Weinig <sam@webkit.org> 17015 17016 Reviewed by Anders Carlsson. 17017 17018 Change API tester to ask the executable for the list of all 17019 tests instead of relying on the directory structure. 17020 https://bugs.webkit.org/show_bug.cgi?id=47359 17021 17022 * Scripts/run-test-webkit-api: Added. 17023 * Scripts/webkitdirs.pm: 17024 Add additional script to just launch the api tester with the correct settings. 17025 17026 * Scripts/run-api-tests: 17027 Change to use the new --dump-tests options to build the list of tests and change 17028 output to reflect a (suite, testcase) tuple for each test. Also adds some color. 17029 17030 * TestWebKitAPI/Test.h: 17031 (TestWebKitAPI::Test::Register::Register): 17032 * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: 17033 (TestWebKitAPI::TEST): 17034 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: 17035 (TestWebKitAPI::TEST): 17036 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: 17037 (TestWebKitAPI::TEST): 17038 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: 17039 (TestWebKitAPI::TEST): 17040 * TestWebKitAPI/Tests/WebKit2/WKString.cpp: 17041 (TestWebKitAPI::TEST): 17042 * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: 17043 (TestWebKitAPI::TEST): 17044 Give each test a suite name in addition to the test name. 17045 17046 * TestWebKitAPI/TestsController.cpp: 17047 (TestWebKitAPI::TestsController::dumpTestNames): 17048 (TestWebKitAPI::TestsController::runTestNamed): 17049 * TestWebKitAPI/TestsController.h: 17050 * TestWebKitAPI/mac/main.mm: 17051 (main): 17052 Add option to print all registered tests. 17053 170542010-10-07 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>, Andras Becsi <abecsi@webkit.org>, Balazs Kelemen <kbalazs@webkit.org> 17055 17056 Reviewed by Kenneth Rohde Christiansen. 17057 17058 [Qt] Add WTR's InjectedBundle build files. 17059 https://bugs.webkit.org/show_bug.cgi?id=47333 17060 17061 * Scripts/webkitdirs.pm: 17062 * WebKitTestRunner/DerivedSources.pro: Added. 17063 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added. 17064 * WebKitTestRunner/WebKitTestRunner.pro: Added. 17065 * WebKitTestRunner/qt/DerivedSources.pro: Removed. 17066 Content merged in ../DerivedSources.pro 17067 170682010-10-07 Balazs Kelemen <kbalazs@webkit.org> 17069 17070 Unreviewed. Do a renaming that was recommended by the reviewer 17071 (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253) 17072 17073 * WebKitTestRunner/qt/TestControllerQt.cpp: 17074 (WTR::RunUntilConditionLoop::start): 17075 (WTR::RunUntilConditionLoop::RunUntilConditionLoop): 17076 (WTR::TestController::runUntil): 17077 170782010-10-07 Balazs Kelemen <kbalazs@webkit.org> 17079 17080 Reviewed by Kenneth Rohde Christiansen. 17081 17082 [Qt] Watchdog timer implementation for WTR 17083 https://bugs.webkit.org/show_bug.cgi?id=47337 17084 17085 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out 17086 the definition of the timer type to a typedef. 17087 * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added. 17088 Timer implementation with QTimer and a helper QObject class. 17089 (WTR::WatchdogTimerHelper::instance): 17090 (WTR::WatchdogTimerHelper::timerFired): 17091 (WTR::WatchdogTimerHelper::WatchdogTimerHelper): 17092 (WTR::LayoutTestController::platformInitialize): 17093 (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer): 17094 (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded): 17095 170962010-10-07 Balazs Kelemen <kbalazs@webkit.org> 17097 17098 Unreviewed buildfix for 69297 again 17099 17100 * WebKitTestRunner/TestController.cpp: 17101 (WTR::blankURL): 17102 171032010-10-07 Balazs Kelemen <Balazs Kelemen> 17104 17105 Unreviewed trivial build fix for r69297 17106 17107 * WebKitTestRunner/TestController.cpp: 17108 (WTR::blankURL): 17109 171102010-10-07 Balazs Kelemen <kbalazs@webkit.org> 17111 17112 Reviewed by Kenneth Rohde Christiansen. 17113 17114 WebKitTestRunner should be portable 17115 https://bugs.webkit.org/show_bug.cgi?id=45393 17116 17117 Use only the WebKit API for working with urls. 17118 * WebKitTestRunner/StringFunctions.h: 17119 (WTR::createWKURL): 17120 * WebKitTestRunner/TestController.cpp: 17121 (WTR::blankURL): 17122 (WTR::TestController::resetStateToConsistentValues): 17123 (WTR::TestController::didFinishLoadForFrame): 17124 171252010-10-07 Carlos Garcia Campos <cgarcia@igalia.com> 17126 17127 Reviewed by Xan Lopez. 17128 17129 [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3 17130 https://bugs.webkit.org/show_bug.cgi?id=47332 17131 17132 * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: 17133 (createBitmapContextFromWebView): 17134 171352010-10-06 Chris Guillory <chris.guillory@google.com> 17136 17137 Reviewed by Chris Fleizach. 17138 17139 Remove unused accessibility functions from webkit. 17140 https://bugs.webkit.org/attachment.cgi?bugid=46707 17141 17142 * DumpRenderTree/chromium/WebViewHost.cpp: 17143 (WebViewHost::postAccessibilityNotification): 17144 * DumpRenderTree/chromium/WebViewHost.h: 17145 171462010-10-06 Lucas Forschler <lforschler@apple.com> 17147 17148 Reviewed by Adam Roben. 17149 17150 Fix the sunspider-compare-results to actually use the passed in value for $root. 17151 17152 * Scripts/sunspider-compare-results: 17153 171542010-10-06 Balazs Kelemen <kbalazs@webkit.org> 17155 17156 Reviewed by Kenneth Rohde Christiansen. 17157 17158 [Qt] Runloop implementation for WTR 17159 https://bugs.webkit.org/show_bug.cgi?id=47280 17160 17161 * WebKitTestRunner/qt/TestControllerQt.cpp: 17162 Implemented TestController::runUntil by a timerEvent 17163 and a QEventLoop. We step into the event loop from runUntil. 17164 While we are waiting in the loop a timerEvent is periodically 17165 checking the value of the condition. Once the condition has 17166 becoming true the timerEvent wakes us up. 17167 (WTR::RunUntilLoop::start): 17168 (WTR::RunUntilLoop::RunUntilLoop): 17169 (WTR::RunUntilLoop::run): 17170 (WTR::RunUntilLoop::timerEvent): 17171 (WTR::TestController::platformInitialize): 17172 (WTR::TestController::runUntil): 17173 * WebKitTestRunner/qt/main.cpp: 17174 Start the main event loop first and creating the TestController later. 17175 (Launcher::Launcher): 17176 (Launcher::~Launcher): 17177 (Launcher::launch): Creating the TestController. 17178 (main): Setting up a timer for calling Launcher::launch from 17179 the main event loop. 17180 171812010-10-06 Dirk Pranke <dpranke@chromium.org> 17182 17183 Reviewed by Kenneth Russell. 17184 17185 new-run-webkit-tests: fix typo in chromium-gpu that was trying to 17186 enable 'accelerated-composting' instead of 'accelerated-compositing'. 17187 17188 https://bugs.webkit.org/show_bug.cgi?id=47312 17189 17190 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 17191 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 17192 171932010-10-06 Balazs Kelemen <kbalazs@webkit.org> 17194 17195 Reviewed by Kenneth Rohde Christiansen. 17196 17197 [Qt] PlatformWebView implementation for WebKitTestRunner 17198 https://bugs.webkit.org/show_bug.cgi?id=47276 17199 17200 The implementation follows the way how 17201 we use the API in MiniBrowser. 17202 * WebKitTestRunner/PlatformWebView.h: 17203 * WebKitTestRunner/qt/PlatformWebViewQt.cpp: 17204 (WTR::WebView::wkView): 17205 (WTR::WebView::~WebView): 17206 (WTR::WebView::WebView): 17207 (WTR::PlatformWebView::PlatformWebView): 17208 (WTR::PlatformWebView::~PlatformWebView): 17209 (WTR::PlatformWebView::resizeTo): 17210 (WTR::PlatformWebView::page): 17211 (WTR::PlatformWebView::focus): 17212 * WebKitTestRunner/qt/WebKitTestRunner.pro: 17213 172142010-10-06 Balazs Kelemen <kbalazs@webkit.org> 17215 17216 Reviewed by Kenneth Rohde Christiansen. 17217 17218 [Qt] Add WebKitTestRunner's build files 17219 https://bugs.webkit.org/show_bug.cgi?id=44155 17220 17221 Parts was taken by Zoltan Horvath's patch. 17222 17223 * Scripts/generate-forwarding-headers.pl: Moved from WebKit2. 17224 * Scripts/webkitdirs.pm: Make the generated files needed by WTR. 17225 * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for 17226 PlatformWKView and PlatformWindow (void* for now). 17227 Buildfix the case when __APPLE__ is not defined. 17228 * WebKitTestRunner/qt/DerivedSources.pro: Added. 17229 * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added. 17230 Empty stub implementation. 17231 (WTR::registerWindowClass): 17232 (WTR::PlatformWebView::PlatformWebView): 17233 (WTR::PlatformWebView::~PlatformWebView): 17234 (WTR::PlatformWebView::resizeTo): 17235 (WTR::PlatformWebView::page): 17236 (WTR::PlatformWebView::focus): 17237 * WebKitTestRunner/qt/TestControllerQt.cpp: Added. 17238 Empty stub implementation. 17239 (WTR::registerWindowClass): 17240 (WTR::TestController::runUntil): 17241 (WTR::TestController::platformInitialize): 17242 (WTR::TestController::initializeInjectedBundlePath): 17243 (WTR::TestController::initializeTestPluginDirectory): 17244 (WTR::TestController::platformInitializeContext): 17245 * WebKitTestRunner/qt/WebKitTestRunner.pro: Added. 17246 * WebKitTestRunner/qt/main.cpp: Added. 17247 (main): 17248 172492010-10-06 Tony Chang <tony@chromium.org> 17250 17251 Unreviewed, rolling out r69202. 17252 http://trac.webkit.org/changeset/69202 17253 https://bugs.webkit.org/show_bug.cgi?id=46937 17254 17255 Broke compile of test_shell 17256 17257 * DumpRenderTree/chromium/EventSender.cpp: 17258 (EventSender::beginDragWithFiles): 17259 * DumpRenderTree/chromium/WebViewHost.cpp: 17260 (addDRTFakeFileToDataObject): 17261 172622010-10-06 Daniel Cheng <dcheng@chromium.org> 17263 17264 Reviewed by Tony Chang. 17265 17266 [chromium] Minor naming cleanup in WebDragData, part 2 17267 https://bugs.webkit.org/show_bug.cgi?id=46937 17268 17269 Update DRT to use the renamed methods. 17270 17271 * DumpRenderTree/chromium/EventSender.cpp: 17272 (EventSender::beginDragWithFiles): 17273 * DumpRenderTree/chromium/WebViewHost.cpp: 17274 (addDRTFakeFileToDataObject): 17275 172762010-10-06 David Kilzer <ddkilzer@apple.com> 17277 17278 <http://webkit.org/b/47270> Move WebArchive serialization code into its own file 17279 17280 Reviewed by Adam Roben. 17281 17282 This is the first step in making webarchive tests work on 17283 Windows. 17284 17285 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added 17286 new files to the project. 17287 * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved 17288 to WebArchiveDumpSupport.mm. 17289 * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added. 17290 * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm. 17291 (serializeWebArchiveToXML): 17292 172932010-10-05 Daniel Bates <dbates@rim.com> 17294 17295 Reviewed by David Kilzer. 17296 17297 Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog 17298 https://bugs.webkit.org/show_bug.cgi?id=46058 17299 17300 Make VCSUtils::fixChangeLogPatch() return a reference to a hash 17301 structure so as to support returning additional information 17302 about a change log diff. 17303 17304 Currently, VCSUtils::fixChangeLogPatch() returns a string that 17305 represents the change log diff. Towards supporting the return 17306 of additional information, such as whether the change log diff 17307 inserts an entry at the top of the ChangeLog file, we need to 17308 make VCSUtils::fixChangeLogPatch() return a reference to hash 17309 structure. 17310 17311 * Scripts/VCSUtils.pm: 17312 - Modified fixChangeLogPatch() to return a reference to a 17313 hash structure. 17314 - Added documentation to fixChangeLogPatch(). 17315 - Modified call site in mergeChangeLogs() as necessary. 17316 * Scripts/svn-apply: 17317 - Modified call site in patch() as necessary. 17318 * Scripts/svn-create-patch: 17319 - Modified call site in generateDiff() as necessary. 17320 * Scripts/svn-unapply: 17321 - Modified call site in patch() as necessary. 17322 * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: 17323 - Modified the unit tests as necessary. 17324 173252010-10-05 Tony Chang <tony@chromium.org> 17326 17327 Reviewed by Darin Adler. 17328 17329 fix the link to the expected image on windows 17330 https://bugs.webkit.org/show_bug.cgi?id=47228 17331 17332 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On 17333 windows, the file must be opened in binary mode when writing 17334 binary data. 17335 173362010-10-05 Adam Barth <abarth@webkit.org> 17337 17338 Update expected result of unittest to match Tony's change below. 17339 17340 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 17341 173422010-10-05 Tony Chang <tony@chromium.org> 17343 17344 Reviewed by Ojan Vafai (over the shoulder). 17345 17346 Paper over errors in image_diff so we don't crash the whole test run. 17347 17348 * Scripts/webkitpy/layout_tests/port/chromium.py: 17349 173502010-10-05 Tony Chang <tony@chromium.org> 17351 17352 Unreviewed, make shutil.rmtree more resiliant to errors 17353 since windows was raising WindowsError: The process cannot access the file because it 17354 is being used by another process. 17355 17356 * Scripts/webkitpy/layout_tests/port/chromium.py: 17357 173582010-10-05 Tony Chang <tony@chromium.org> 17359 17360 Reviewed by Ojan Vafai. 17361 17362 [chromium] fix image diffing in NRWT 17363 https://bugs.webkit.org/show_bug.cgi?id=47128 17364 17365 * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using 17366 NamedTemporaryFile since it doesn't work on Windows. 17367 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 17368 173692010-10-05 Kenneth Russell <kbr@google.com> 17370 17371 Reviewed by Tony Chang. 17372 17373 [chromium] Implement layerTreeAsText in DumpRenderTree 17374 https://bugs.webkit.org/show_bug.cgi?id=47216 17375 17376 Plumbed Frame::layerTreeAsText through Chromium's WebKit API to 17377 make it callable from DumpRenderTree. 17378 17379 No new tests; verified with existing compositor layout tests. 17380 17381 * DumpRenderTree/chromium/LayoutTestController.cpp: 17382 (LayoutTestController::LayoutTestController): 17383 (LayoutTestController::layerTreeAsText): 17384 * DumpRenderTree/chromium/LayoutTestController.h: 17385 173862010-10-05 Brent Fulgham <bfulgham@webkit.org> 17387 17388 Unreviewed build correction. 17389 17390 * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug 17391 property sheet so proper libraries are linked. 17392 173932010-10-05 Robert Hogan <robert@webkit.org> 17394 17395 Reviewed by Andreas Kling. 17396 17397 [Qt] Fix url conversion in QWebHistory 17398 17399 Converting from KURL to WFT::String to QUrl does not 17400 permit proper percent encoding later. 17401 17402 https://bugs.webkit.org/show_bug.cgi?id=47048 17403 17404 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 17405 (WebCore::dumpHistoryItem): 17406 174072010-10-05 Anders Carlsson <andersca@apple.com> 17408 17409 Reviewed by Sam Weinig. 17410 17411 REGRESSION (r68966?): All dumpAsText test fail on WebKit2 17412 https://bugs.webkit.org/show_bug.cgi?id=47188 17413 <rdar://problem/8514104> 17414 17415 When constructing the std::string, use the real string length instead of the maximum buffer size. 17416 17417 * TestWebKitAPI/PlatformUtilities.h: 17418 (TestWebKitAPI::Util::toSTD): 17419 * WebKitTestRunner/StringFunctions.h: 17420 (WTR::toSTD): 17421 174222010-10-04 Sam Weinig <sam@webkit.org> 17423 17424 Reviewed by Mark Rowe. 17425 17426 Add MIMEType accessor to WKFrame 17427 <rdar://problem/8347683> 17428 https://bugs.webkit.org/show_bug.cgi?id=47138 17429 17430 * TestWebKitAPI/PlatformUtilities.h: 17431 (TestWebKitAPI::Util::toSTD): 17432 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 17433 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added. 17434 (TestWebKitAPI::didStartProvisionalLoadForFrame): 17435 (TestWebKitAPI::didCommitLoadForFrame): 17436 (TestWebKitAPI::didFinishLoadForFrame): 17437 (TestWebKitAPI::TEST): 17438 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added. 17439 (TestWebKitAPI::didStartProvisionalLoadForFrame): 17440 (TestWebKitAPI::didCommitLoadForFrame): 17441 (TestWebKitAPI::didFinishLoadForFrame): 17442 (TestWebKitAPI::TEST): 17443 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: 17444 (TestWebKitAPI::TEST): 17445 * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed. 17446 * TestWebKitAPI/Tests/WebKit2/icon.png: Added. 17447 * TestWebKitAPI/Tests/WebKit2/simple.html: Added. 17448 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: 17449 (TestWebKitAPI::Util::createURLForResource): 17450 174512010-10-05 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 17452 17453 Reviewed by Ojan Vafai. 17454 17455 [NRWT] Rename current_dir to current_group because it's not a directory 17456 https://bugs.webkit.org/show_bug.cgi?id=47169 17457 17458 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 17459 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 17460 174612010-10-04 Dirk Pranke <dpranke@chromium.org> 17462 17463 Unreviewed, build fix. 17464 17465 r69065 broke test-webkitpy by trying to create a '/tmp-X' directory, 17466 which can't always be done. This test uses tempfile.mkdtemp(), which 17467 should be safe. 17468 17469 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 17470 174712010-10-04 Dirk Pranke <dpranke@chromium.org> 17472 17473 Unreviewed, build fix. 17474 17475 Add missing "from __future__ import with_statement" that was 17476 breaking test-webkitpy on the Leopard bots (broke in r69040). 17477 17478 * Scripts/webkitpy/layout_tests/port/google_chrome.py: 17479 174802010-10-04 Sheriff Bot <webkit.review.bot@gmail.com> 17481 17482 Unreviewed, rolling out r69066. 17483 http://trac.webkit.org/changeset/69066 17484 https://bugs.webkit.org/show_bug.cgi?id=47163 17485 17486 Made NRWT reliability worse. (Requested by tkent on #webkit). 17487 17488 * Scripts/webkitpy/layout_tests/port/chromium.py: 17489 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 17490 174912010-10-04 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 17492 17493 Reviewed by Tony Chang. 17494 17495 [NRWT] Reverse the http tests to alphabetical order. 17496 https://bugs.webkit.org/show_bug.cgi?id=47075 17497 17498 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 17499 175002010-10-04 Robert Hogan <robert@webkit.org> 17501 17502 Reviewed by Andreas Kling. 17503 17504 [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html 17505 17506 We need to queue back and forward navigations in the DRT from the 17507 LayoutTestController so that maybeDump() knows about them. 17508 17509 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 17510 (LayoutTestController::queueBackNavigation): 17511 (LayoutTestController::queueForwardNavigation): 17512 175132010-10-04 Tony Chang <tony@chromium.org> 17514 17515 Reviewed by Kent Tamura. 17516 17517 [chromium] fix image diffing in NRWT 17518 https://bugs.webkit.org/show_bug.cgi?id=47128 17519 17520 * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the 17521 temp file and check the image_diff error code more carefully 17522 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 17523 175242010-10-04 Dirk Pranke <dpranke@chromium.org> 17525 17526 Reviewed by Adam Barth. 17527 17528 aroben's change in r68792 actually broke new-run-webkit-tests when 17529 running the DRT code path. His change was intended to fix the 17530 way we were converting windows paths to URIs when running under 17531 Cygwin (the paths were getting one too many "/" on the front). 17532 However, the change ended up breaking the chromium_win port, which 17533 had slightly different logic. 17534 17535 This patch removes the port-specific code and adds tests to make 17536 sure we're getting the behavior we expect. The Port object no longer 17537 exposes a get_absolute_path() method that can be used outside of 17538 of converting test filenames, because it's unreliable otherwise 17539 (we don't have the right context to know which conversion is intended). 17540 17541 https://bugs.webkit.org/show_bug.cgi?id=47140 17542 17543 * Scripts/webkitpy/layout_tests/port/base.py: 17544 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 17545 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 17546 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 17547 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 17548 175492010-10-04 Dirk Pranke <dpranke@chromium.org> 17550 17551 Unreviewed, build fix. 17552 17553 Handle crash introduced in r69040 if we are not running in a 17554 Chromium checkout. 17555 17556 * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: 17557 175582010-10-04 Dirk Pranke <dpranke@chromium.org> 17559 17560 Reviewed by Tony Chang. 17561 17562 Add a way for us to have test expectations that are specific to the 17563 official builds of Google Chrome (as opposed to Chromium). This change 17564 looks for an additional "test_expectations_chrome.txt" file in 17565 Chromium's repository (webkit/tools/layout_tests), and uses the 17566 concatenation of that file and the regular test_expectations.txt 17567 file for test overrides. 17568 17569 https://bugs.webkit.org/show_bug.cgi?id=46854 17570 17571 * Scripts/webkitpy/layout_tests/port/google_chrome.py: 17572 * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: 17573 175742010-10-04 Simon Fraser <simon.fraser@apple.com> 17575 17576 Color tests in the list based on existing pass/fail result. 17577 17578 Fix the summary data to account for htmlOnly and nonHTML tests. 17579 17580 * CSSTestSuiteHarness/harness/harness.css: 17581 (#test-list > option.pass): 17582 (#test-list > option.fail): 17583 (#test-list > option.skipped): 17584 * CSSTestSuiteHarness/harness/harness.js: 17585 (Test): 17586 (Test.prototype.statusForFormat): 17587 (TestSuite.prototype.fillTestList): 17588 (TestSuite.prototype.updateTestList): 17589 (TestSuite.prototype.recordResult): 17590 (TestSuite.prototype.markTestCompleted): 17591 (TestSuite.prototype.countTestsWithFlag): 17592 (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction): 17593 (TestSuite.prototype.queryDatabaseForSummary): 17594 175952010-10-04 Chris Fleizach <cfleizach@apple.com> 17596 17597 Reviewed by Beth Dakin. 17598 17599 AX: doAXRangeForLine does not work 17600 https://bugs.webkit.org/show_bug.cgi?id=47101 17601 17602 DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute. 17603 17604 * DumpRenderTree/AccessibilityUIElement.cpp: 17605 (rangeForLineCallback): 17606 (AccessibilityUIElement::rangeForLine): 17607 (AccessibilityUIElement::getJSClass): 17608 * DumpRenderTree/AccessibilityUIElement.h: 17609 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 17610 (AccessibilityUIElement::rangeForLine): 17611 176122010-10-04 Andrey Kosyakov <caseq@chromium.org> 17613 17614 Unreviewed. Adding myself to the committers list. 17615 17616 * Scripts/webkitpy/common/config/committers.py: 17617 176182010-10-04 Sam Weinig <sam@webkit.org> 17619 17620 Reviewed by Anders Carlsson. 17621 17622 Add ability to set the CacheModel in Webkit2 17623 https://bugs.webkit.org/show_bug.cgi?id=47066 17624 17625 * MiniBrowser/mac/AppDelegate.m: 17626 (-[BrowserAppDelegate init]): Opt minibrowser into 17627 a PrimaryWebBrowser cache model. 17628 176292010-10-03 Simon Fraser <simon.fraser@apple.com> 17630 17631 Make sure to enter all tests when creating the database 17632 for the first time. 17633 17634 When migrating to a new version of the suite, be sure to 17635 sync up the database and testinfo.data by removing old 17636 tests, and inserting new ones. 17637 17638 * CSSTestSuiteHarness/harness/harness.js: 17639 (TestSuite.prototype.openDatabase.creation): 17640 (TestSuite.prototype.databaseCreated): 17641 (TestSuite.prototype.populateDatabaseFromTestInfoData): 17642 (TestSuite.prototype.insertTest): 17643 176442010-10-03 Simon Fraser <simon.fraser@apple.com> 17645 17646 More work on treating HTML4 and XHTML1 independently; when 17647 changing the format, rebuild the test list, and update the 17648 numbers in the chapter popup. 17649 17650 * CSSTestSuiteHarness/harness/harness.js: 17651 (Test): 17652 (Test.prototype.runForFormat): 17653 (Test.prototype.completedForFormat): 17654 (ChapterSection): 17655 (ChapterSection.prototype.countTests): 17656 (Chapter): 17657 (Chapter.prototype.description): 17658 (Chapter.prototype.countTests): 17659 (Chapter.prototype.testCount): 17660 (Chapter.prototype.untestedCount): 17661 (TestSuite.prototype.buildChapters): 17662 (TestSuite.prototype.loadCurrentTest): 17663 (TestSuite.prototype.updateProgressLabel): 17664 (TestSuite.prototype.processFlags): 17665 (TestSuite.prototype.formatChanged): 17666 176672010-10-03 Simon Fraser <simon.fraser@apple.com> 17668 17669 Update test suite version 20101001. 17670 17671 Handle database migration, and delete tests from the db that are 17672 not present in testinfo.data. 17673 17674 Load about:blank into the test frame before the test url, to make 17675 missing tests more obvious. 17676 17677 * CSSTestSuiteHarness/harness/harness.js: 17678 (TestSuite.prototype.loadTest): 17679 (TestSuite.prototype.openDatabase.creation): 17680 (TestSuite.prototype.openDatabase.migration1_0To1_1): 17681 (TestSuite.prototype.openDatabase.if.return): 17682 (TestSuite.prototype.databaseReady): 17683 (TestSuite.prototype.populateDatabaseFromTestInfoData): 17684 (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction): 17685 (TestSuite.prototype.syncDatabaseWithTestInfoData): 17686 176872010-10-02 Simon Fraser <simon.fraser@apple.com> 17688 17689 Add the ability to jump to a specific test. 17690 17691 * CSSTestSuiteHarness/harness/harness.html: 17692 * CSSTestSuiteHarness/harness/harness.js: 17693 (TestSuite.prototype.goToTestByName): 17694 (TestSuite.prototype.switchToFormat): 17695 176962010-10-02 Simon Fraser <simon.fraser@apple.com> 17697 17698 For a ref test, load the ref in the same format (HTML4 vs XHTML1) 17699 as the test. 17700 17701 * CSSTestSuiteHarness/harness/harness.js: 17702 (TestSuite.prototype.loadRef): 17703 177042010-10-02 Simon Fraser <simon.fraser@apple.com> 17705 17706 Update the UI to reflect the fact that each test needs to be tested 17707 in both HTML4 and XHTML1 format. 17708 17709 * CSSTestSuiteHarness/harness/harness.js: 17710 (Test): 17711 (Chapter.prototype.description): 17712 (Chapter.prototype.untestedCount): 17713 (TestSuite.prototype.fillChapterPopup): 17714 (TestSuite.prototype.updateChapterPopup): 17715 (TestSuite.prototype.fillTestList): 17716 (TestSuite.prototype.updateTestList): 17717 (TestSuite.prototype.goToNextIncompleteTest): 17718 (TestSuite.prototype.firstIncompleteTestIndex): 17719 (TestSuite.prototype.recordResult): 17720 (TestSuite.prototype.formatChanged): 17721 (TestSuite.prototype.markTestCompleted): 17722 (TestSuite.prototype.resetTestStatus): 17723 177242010-10-01 Simon Fraser <simon.fraser@apple.com> 17725 17726 Add the ability to remove results for re-testing, and 17727 to import results. 17728 17729 * CSSTestSuiteHarness/harness/harness.css: 17730 (.custom button): 17731 (#overlay): 17732 (#overlay.visible): 17733 (.overlay-contents): 17734 (.overlay-contents textarea): 17735 (.overlay-contents .buttons): 17736 (.overlay-contents .note): 17737 (.overlay-contents .buttons button): 17738 * CSSTestSuiteHarness/harness/harness.html: 17739 * CSSTestSuiteHarness/harness/harness.js: 17740 (TestSuite.prototype.importResults): 17741 (TestSuite.prototype.clearResults): 17742 (TestSuite.prototype.markTestCompleted): 17743 (TestSuite.prototype.resetTestStatus): 17744 (TestSuite.prototype.storeTestResult): 17745 (TestSuite.prototype.importTestResults): 17746 (TestSuite.prototype.clearTestResults): 17747 177482010-10-01 Sam Weinig <sam@webkit.org> 17749 17750 Reviewed by Jon Honeycutt. 17751 17752 Deploy the new WKString functions to remove most uses of CF from 17753 the WebKitTestRunner. 17754 17755 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 17756 (WTR::InjectedBundle::didReceiveMessage): 17757 (WTR::InjectedBundle::done): 17758 * WebKitTestRunner/StringFunctions.h: 17759 (WTR::toWK): 17760 (WTR::toJS): 17761 (WTR::toSTD): 17762 (WTR::operator<<): 17763 (WTR::copyURLString): 17764 * WebKitTestRunner/TestController.cpp: 17765 (WTR::TestController::resetStateToConsistentValues): 17766 (WTR::TestController::didFinishLoadForFrame): 17767 * WebKitTestRunner/TestInvocation.cpp: 17768 (WTR::TestInvocation::invoke): 17769 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 17770 177712010-10-01 Mihai Parparita <mihaip@chromium.org> 17772 17773 Unreviewed TestResultsServer change. 17774 17775 Add files introduced by http://crrev.com/61273 to the list of dashboard 17776 files to update. 17777 17778 * TestResultServer/handlers/dashboardhandler.py: 17779 177802010-10-01 Brian Weinstein <bweinstein@apple.com> 17781 17782 Build Fix for Windows. 17783 17784 * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from 17785 WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/ 17786 ForwardingHeaders to the include path. 17787 177882010-10-01 Sam Weinig <sam@webkit.org> 17789 17790 Reviewed by Anders Carlsson. 17791 17792 Add SPI to convert a WKStringRef to a JSStringRef and vice-versa. 17793 17794 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 17795 * TestWebKitAPI/Tests/WebKit2/WKString.cpp: 17796 (TestWebKitAPI::TEST): 17797 * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added. 17798 (TestWebKitAPI::TEST): 17799 178002010-10-01 Sam Weinig <sam@webkit.org> 17801 17802 Reviewed by Kenneth Rohde Christiansen. 17803 17804 Add additional WKString API 17805 https://bugs.webkit.org/show_bug.cgi?id=46958 17806 17807 Add basic WKStringRef tests. 17808 17809 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 17810 * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added. 17811 178122010-10-01 Sam Weinig <sam@webkit.org> 17813 17814 Reviewed by Dan Bernstein. 17815 17816 Add makefile for TestWebKitAPI and call it from the base makefile. 17817 17818 * Makefile: 17819 * TestWebKitAPI/Makefile: Added. 17820 178212010-10-01 Sam Weinig <sam@webkit.org> 17822 17823 Reviewed by Adam Roben. 17824 17825 Remove unnecessary ForwardingHeaders from test runners. 17826 https://bugs.webkit.org/show_bug.cgi?id=47010 17827 17828 * TestWebKitAPI/Configurations/Base.xcconfig: 17829 * TestWebKitAPI/ForwardingHeaders: Removed. 17830 * WebKitTestRunner/Configurations/Base.xcconfig: 17831 * WebKitTestRunner/ForwardingHeaders: Removed. 17832 178332010-09-30 Adam Barth <abarth@webkit.org> 17834 17835 Reviewed by Eric Seidel. 17836 17837 WebSocket tests are flaky 17838 https://bugs.webkit.org/show_bug.cgi?id=46956 17839 17840 Update these tools to understand how to run the WebSocket tests off the 17841 Apache server. 17842 17843 * Scripts/old-run-webkit-tests: 17844 * Scripts/webkitpy/layout_tests/port/base.py: 17845 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 17846 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 17847 178482010-10-01 Adam Roben <aroben@apple.com> 17849 17850 Encode Executive command arguments using UTF-8 on Cygwin 17851 17852 Cygwin's Python's os.execv doesn't support unicode command arguments. 17853 Cygwin's execv expects arguments to be encoded using the current code 17854 page. But code pages are limited in what characters they can handle, 17855 and our tests include characters that the English code page can't 17856 handle. So for now we'll just encode everything in UTF-8 on Cygwin, 17857 which can handle all characters but might confuse some commands, for 17858 expediency's sake. I'm sure we'll run into cases where UTF-8 isn't 17859 good enough, but we can deal with that when the problem arises. 17860 17861 Reviewed by Adam Barth. 17862 17863 Fixes <http://webkit.org/b/46892> <rdar://problem/8496639> 17864 webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode 17865 fails on Windows 17866 17867 * Scripts/webkitpy/common/system/executive.py: 17868 (Executive._run_command_with_teed_output): 17869 (Executive.run_command): 17870 On Cygwin, encode arguments using UTF-8. 17871 178722010-10-01 Sam Weinig <sam@webkit.org> 17873 17874 Reviewed by Adam Roben. 17875 17876 Add simple API tester for WebKit2 17877 https://bugs.webkit.org/show_bug.cgi?id=46953 17878 17879 This adds a very simple testing infrastructure for testing APIs exposed 17880 through the WebKit project. It consists of two parts: 1) a project that 17881 builds the all the tests 2) a script that searches the tests directory and 17882 calls the tester once for each test. 17883 17884 This adds the infrastructure and two tests: 17885 - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures. 17886 - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API. 17887 17888 This currently only works on the mac, but is designed to be easily ported 17889 to any platform. 17890 17891 * Scripts/run-api-tests: Added. 17892 * Scripts/build-api-tests: Added. 17893 Scripts to build/run the tests. 17894 17895 * TestWebKitAPI: Added. 17896 * TestWebKitAPI/Configurations: Added. 17897 * TestWebKitAPI/Configurations/Base.xcconfig: Added. 17898 * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added. 17899 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added. 17900 * TestWebKitAPI/ForwardingHeaders: Added. 17901 * TestWebKitAPI/ForwardingHeaders/wtf: Added. 17902 * TestWebKitAPI/PlatformUtilities.h: Added. 17903 * TestWebKitAPI/PlatformWebView.h: Added. 17904 (TestWebKitAPI::PlatformWebView::platformView): 17905 * TestWebKitAPI/StringFunctions.h: Added. 17906 * TestWebKitAPI/Test.h: Added. 17907 (TestWebKitAPI::Test::~Test): 17908 (TestWebKitAPI::Test::name): 17909 (TestWebKitAPI::Test::Register::Register): 17910 (TestWebKitAPI::Test::Register::create): 17911 (TestWebKitAPI::Test::Test): 17912 * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added. 17913 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added. 17914 * TestWebKitAPI/TestWebKitAPIPrefix.h: Added. 17915 * TestWebKitAPI/TestsController.cpp: Added. 17916 (TestWebKitAPI::TestsController::shared): 17917 (TestWebKitAPI::TestsController::TestsController): 17918 (TestWebKitAPI::TestsController::runTestNamed): 17919 (TestWebKitAPI::TestsController::testFailed): 17920 (TestWebKitAPI::TestsController::registerCreateTestFunction): 17921 * TestWebKitAPI/TestsController.h: Added. 17922 * TestWebKitAPI/mac: Added. 17923 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added. 17924 (TestWebKitAPI::Util::run): 17925 (TestWebKitAPI::Util::createURLForResource): 17926 * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added. 17927 (TestWebKitAPI::PlatformWebView::PlatformWebView): 17928 (TestWebKitAPI::PlatformWebView::resizeTo): 17929 (TestWebKitAPI::PlatformWebView::~PlatformWebView): 17930 (TestWebKitAPI::PlatformWebView::page): 17931 (TestWebKitAPI::PlatformWebView::focus): 17932 * TestWebKitAPI/mac/main.mm: Added. 17933 Infrastructure. 17934 17935 * TestWebKitAPI/Tests: Added. 17936 * TestWebKitAPI/Tests/WTF: Added. 17937 * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added. 17938 * TestWebKitAPI/Tests/WebKit2: Added. 17939 * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added. 17940 (TestWebKitAPI::State::State): 17941 * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added. 17942 Proof of concept tests. 17943 179442010-10-01 Adam Roben <aroben@apple.com> 17945 17946 Don't assume AccessibleObjectFromEvent succeeds 17947 17948 Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in 17949 DumpRenderTree!notificationListenerProc when running 17950 plugins/access-after-page-destroyed.html 17951 17952 Reviewed by Sam Weinig. 17953 17954 * DumpRenderTree/win/AccessibilityControllerWin.cpp: 17955 (notificationListenerProc): Check both the return value of 17956 AccessibleObjectFromEvent and the object it returns, as MSDN 17957 recommends. 17958 179592010-10-01 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 17960 17961 Reviewed by Tony Chang. 17962 17963 [NRWT] Put the http and websocket tests first in the test list. 17964 https://bugs.webkit.org/show_bug.cgi?id=46453 17965 17966 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 17967 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 17968 179692010-10-01 Fady Samuel <fsamuel@chromium.org> 17970 17971 Unreviewed, adding myself to the committer list. 17972 17973 * Scripts/webkitpy/common/config/committers.py: 17974 179752010-10-01 Adam Roben <aroben@apple.com> 17976 17977 Test NPN_GetValue(NPNVnetscapeWindow) 17978 17979 Test for <http://webkit.org/b/46726> <rdar://problem/8486319> 17980 Right-clicking on windowless Flash plugin in WebKit2 makes a context 17981 menu appear in the bottom-right corner of the screen 17982 17983 Reviewed by Anders Carlsson. 17984 17985 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 17986 (PluginTest::NPN_GetValue): Added. Calls through to the browser. 17987 17988 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue. 17989 17990 * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added. 17991 (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members. 17992 (GetValueNetscapeWindow::NPP_SetWindow): Test that 17993 NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it 17994 isn't our HWND. 17995 17996 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 17997 Added GetValueNetscapeWindow. 17998 179992010-10-01 Andreas Kling <andreas.kling@nokia.com> 18000 18001 Unreviewed, adding my webkit.org identity to reviewer list. 18002 18003 * Scripts/webkitpy/common/config/committers.py: 18004 180052010-09-30 Adam Barth <abarth@webkit.org> 18006 18007 Reviewed by Eric Seidel. 18008 18009 The WebSocket server should flush its logs 18010 https://bugs.webkit.org/show_bug.cgi?id=46946 18011 18012 The WebSocket server logs are truncated because the driver just 18013 terminates the child. It should run Python without buffering so we can 18014 see the end of the log. 18015 18016 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 18017 180182010-09-30 Simon Fraser <simon.fraser@apple.com> 18019 18020 Add a button to jump to the next untested test. 18021 18022 * CSSTestSuiteHarness/harness/harness.css: 18023 (.test-type): 18024 (.name > button): 18025 * CSSTestSuiteHarness/harness/harness.html: 18026 * CSSTestSuiteHarness/harness/harness.js: 18027 (Chapter.prototype.description): 18028 (Chapter.prototype.untestedCount): 18029 (TestSuite.prototype.testInfoDataLoaded): 18030 (TestSuite.prototype.fillChapterPopup): 18031 (TestSuite.prototype.updateChapterPopup): 18032 (TestSuite.prototype.buildTestListForChapter): 18033 (TestSuite.prototype.goToNextIncompleteTest): 18034 (TestSuite.prototype.firstIncompleteTestIndex): 18035 (TestSuite.prototype.testCompletionStateChanged): 18036 180372010-09-29 Jon Honeycutt <jhoneycutt@apple.com> 18038 18039 WebKit2 on Windows should use Windows fonts for the various standard 18040 font families 18041 https://bugs.webkit.org/show_bug.cgi?id=43499 18042 <rdar://problem/8272758> 18043 18044 Reviewed by Adam Roben. 18045 18046 * WebKitTestRunner/TestController.cpp: 18047 (WTR::TestController::resetStateToConsistentValues): 18048 Use the Mac fonts for running tests. This matches DRT behavior. 18049 180502010-09-30 Adam Barth <abarth@webkit.org> 18051 18052 Third attempt. We need a better integration test environment. 18053 18054 * Scripts/webkitpy/common/net/failuremap.py: 18055 * Scripts/webkitpy/common/net/failuremap_unittest.py: 18056 180572010-09-30 Robert Hogan <robert@webkit.org> 18058 18059 Reviewed by Andreas Kling. 18060 18061 [Qt] Support for PlainTextController 18062 18063 Unskip editing/text-iterator/basic-iteration.html 18064 18065 https://bugs.webkit.org/show_bug.cgi?id=38805 18066 18067 * DumpRenderTree/qt/DumpRenderTree.pro: 18068 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 18069 (WebCore::DumpRenderTree::DumpRenderTree): 18070 (WebCore::DumpRenderTree::initJSObjects): 18071 * DumpRenderTree/qt/DumpRenderTreeQt.h: 18072 * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added. 18073 (PlainTextController::PlainTextController): 18074 (PlainTextController::plainText): 18075 * DumpRenderTree/qt/PlainTextControllerQt.h: Added. 18076 180772010-09-30 Adam Barth <abarth@webkit.org> 18078 18079 Unreviewed. Second attempt to fix sheriffbot. 18080 18081 * Scripts/webkitpy/common/net/buildbot.py: 18082 180832010-09-30 Adam Barth <abarth@webkit.org> 18084 18085 Unreviewed. 18086 18087 This patch should stop the sheriffbot from throwing an exception. 18088 18089 * Scripts/webkitpy/common/net/buildbot.py: 18090 180912010-09-30 Brian Weinstein <bweinstein@apple.com> 18092 18093 Reviewed by Adam Roben. 18094 18095 The same bots shouldn't run both Windows Debug Tests and Windows Release Tests. 18096 https://bugs.webkit.org/show_bug.cgi?id=46926 18097 18098 * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 18099 Release Tests, and two bots running Windows Debug Tests, instead of four running both. 18100 181012010-09-30 Adam Barth <abarth@webkit.org> 18102 18103 Reviewed by Eric Seidel. 18104 18105 webkit-patch find-flaky-tests should print results URLs 18106 https://bugs.webkit.org/show_bug.cgi?id=46917 18107 18108 Printing out the results URL makes find-flaky-tests more actionable 18109 because you can see what happens when a test fails. The output from 18110 the script is still pretty noisy, but it seems useful. 18111 18112 * Scripts/webkitpy/tool/commands/queries.py: 18113 181142010-09-30 Chris Marrin <cmarrin@apple.com> 18115 18116 Reviewed by Simon Fraser. 18117 18118 Make 2D accelerated canvas rendering build on Mac 18119 https://bugs.webkit.org/show_bug.cgi?id=46007 18120 18121 Added ACCELERATED_2D_CANVAS to build-webkit 18122 18123 * Scripts/build-webkit: 18124 181252010-09-29 Kenneth Russell <kbr@google.com> 18126 18127 Reviewed by Dimitri Glazkov. 18128 18129 [chromium] Add accelerated compositing support to DumpRenderTree and test_shell 18130 https://bugs.webkit.org/show_bug.cgi?id=46849 18131 18132 Added offscreen code path for WebGraphicsContext3DDefaultImpl which 18133 works with the compositor integration in both DumpRenderTree and 18134 test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint 18135 and thereby trigger the compositor's readback code path. Added support 18136 for --enable-accelerated-compositing to DumpRenderTree. 18137 18138 Tested in both test_shell and DumpRenderTree on Linux, the latter by 18139 modifying a compositing layout test, dumping the pixels and verifying 18140 that they matched the output when the compositor was active. 18141 18142 * DumpRenderTree/chromium/DumpRenderTree.cpp: 18143 (main): 18144 * DumpRenderTree/chromium/TestShell.cpp: 18145 (TestShell::TestShell): 18146 (TestShell::resetWebSettings): 18147 * DumpRenderTree/chromium/TestShell.h: 18148 (TestShell::setAcceleratedCompositingEnabled): 18149 * DumpRenderTree/chromium/WebPreferences.cpp: 18150 (WebPreferences::reset): 18151 (WebPreferences::applyTo): 18152 * DumpRenderTree/chromium/WebPreferences.h: 18153 * DumpRenderTree/chromium/WebViewHost.cpp: 18154 (WebViewHost::scheduleComposite): 18155 * DumpRenderTree/chromium/WebViewHost.h: 18156 181572010-09-30 Adam Roben <aroben@apple.com> 18158 18159 Ensure that QueueEngine cleans up its log files when its delegate 18160 tells it to stop processing work 18161 18162 Reviewed by Adam Barth. 18163 18164 Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests 18165 in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on 18166 Windows 18167 18168 * Scripts/webkitpy/tool/bot/queueengine.py: 18169 (QueueEngine.run): Stop ourselves normally (including cleaning up log 18170 files) when the delegate tells us to stop processing work. 18171 18172 * Scripts/webkitpy/tool/bot/queueengine_unittest.py: 18173 (LoggingDelegate.__init__): Moved code here from 18174 RaisingDelegate.__init__. 18175 (LoggingDelegate.expeced_callbacks): Added the stop_work_queue 18176 callback. 18177 (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate. 18178 (RaisingDelegate.__init__): Removed code that LoggingDelegate takes 18179 care of for us now. 18180 (QueueEngineTest.test_trivial): Make sure we got the expected stop 18181 message. 18182 (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly 18183 remove the callbacks that are related to processing a single work 18184 item, rather than removing all callbacks after a certain point, as 18185 there are now more callbacks we expect to receive at the end. 18186 181872010-09-30 Adam Roben <aroben@apple.com> 18188 18189 Fix path -> URL conversion on Cygwin 18190 18191 Reviewed by Adam Barth. 18192 18193 Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests 18194 in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows 18195 18196 * Scripts/webkitpy/layout_tests/port/base.py: 18197 (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by 18198 assuming paths already have a leading slash. 18199 182002010-09-30 Adam Roben <aroben@apple.com> 18201 18202 Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can 18203 be called more than once 18204 18205 The NPP_SetWindow call made when the plugin is torn down was confusing 18206 us, and was causing us to spew an error into the next test. 18207 18208 Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION 18209 (r68520): plugins/access-after-page-destroyed.html failing on Windows 18210 18211 Reviewed by Anders Carlsson. 18212 18213 * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: 18214 (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow): 18215 Initialize member. 18216 (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if 18217 this isn't the first time this is called. 18218 182192010-09-30 Eric Seidel <eric@webkit.org> 18220 18221 Reviewed by Adam Barth. 18222 18223 webkit-patch upload warns that I'm using Xcode when I'm not 18224 https://bugs.webkit.org/show_bug.cgi?id=46869 18225 18226 String.find returns -1 when not found, so switched to "in". 18227 18228 * Scripts/webkitpy/common/system/user.py: 18229 * Scripts/webkitpy/common/system/user_unittest.py: 18230 182312010-09-30 Eric Seidel <eric@webkit.org> 18232 18233 Reviewed by Adam Barth. 18234 18235 webkit-patch failure-reason dies if non-trunk commits are in the blame range 18236 https://bugs.webkit.org/show_bug.cgi?id=46866 18237 18238 I also made failure-reason use RegressionWindow in a cleaner way. 18239 18240 * Scripts/webkitpy/tool/commands/queries.py: 18241 182422010-09-29 Adam Barth <abarth@webkit.org> 18243 18244 Reviewed by Eric Seidel. 18245 18246 webkit-patch find-flaky-tests 18247 https://bugs.webkit.org/show_bug.cgi?id=46876 18248 18249 This command helps us find flaky tests so we can squash them. 18250 18251 * Scripts/webkitpy/tool/commands/queries.py: 18252 182532010-09-29 Simon Fraser <simon.fraser@apple.com> 18254 18255 Fix export to use '?' instead of 'null' for 18256 tests with no results. 18257 18258 * CSSTestSuiteHarness/harness/harness.js: 18259 182602010-09-29 Simon Fraser <simon.fraser@apple.com> 18261 18262 Add a warning when a test requires special steps. 18263 Add a Print Preview button for 'paged' tests that 18264 brings up the print dialog, allowing the user to 18265 judge paged media tests. 18266 18267 * CSSTestSuiteHarness/harness/harness.css: 18268 * CSSTestSuiteHarness/harness/harness.html: 18269 * CSSTestSuiteHarness/harness/harness.js: 18270 (TestSuite.prototype.loadTest): 18271 (TestSuite.prototype.processFlags): 18272 182732010-09-29 Adam Barth <abarth@webkit.org> 18274 18275 Reviewed by Eric Seidel. 18276 18277 Remove revisions_casuing_failures 18278 https://bugs.webkit.org/show_bug.cgi?id=46872 18279 18280 This function exists only to be unit tested. 18281 18282 * Scripts/webkitpy/common/net/failuremap.py: 18283 * Scripts/webkitpy/common/net/failuremap_unittest.py: 18284 * Scripts/webkitpy/tool/mocktool.py: 18285 182862010-09-29 Adam Barth <abarth@webkit.org> 18287 18288 Reviewed by Eric Seidel. 18289 18290 SheriffBot should post the list of failing tests to bugs 18291 https://bugs.webkit.org/show_bug.cgi?id=46871 18292 18293 * Scripts/webkitpy/common/net/buildbot.py: 18294 * Scripts/webkitpy/common/net/failuremap.py: 18295 * Scripts/webkitpy/common/net/regressionwindow.py: 18296 * Scripts/webkitpy/tool/bot/sheriff.py: 18297 * Scripts/webkitpy/tool/bot/sheriff_unittest.py: 18298 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 18299 * Scripts/webkitpy/tool/commands/queues_unittest.py: 18300 * Scripts/webkitpy/tool/commands/sheriffbot.py: 18301 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 18302 * Scripts/webkitpy/tool/commands/upload_unittest.py: 18303 * Scripts/webkitpy/tool/mocktool.py: 18304 183052010-09-29 Brent Fulgham <bfulgham@webkit.org> 18306 18307 Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe. 18308 18309 [WinCairo] Adds a build slave. 18310 https://bugs.webkit.org/show_bug.cgi?id=46360 18311 18312 * BuildSlaveSupport/build.webkit.org-config/config.json: Add 18313 entries for a debug build of the WinCairo port. 18314 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add 18315 platform flag to configuration for wincairo (like gtk, chromium, etc.) 18316 * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo' 18317 * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo' 18318 183192010-09-29 Adam Barth <abarth@webkit.org> 18320 18321 Reviewed by Eric Seidel. 18322 18323 Move more SheriffBot smarts into FailureMap 18324 https://bugs.webkit.org/show_bug.cgi?id=46703 18325 18326 This patch pushes the FailureMap model object further into the 18327 SheriffBot machine. In addition, it moves a couple operations on this 18328 object from SheriffBot itself to the model. 18329 18330 Eventually, FailureMap will be the canonical context object for 18331 SheriffBot operations. FailureMap represents a map of the current 18332 failures on the bots that might require remediation. 18333 18334 * Scripts/webkitpy/common/net/failuremap.py: 18335 * Scripts/webkitpy/common/net/regressionwindow.py: 18336 * Scripts/webkitpy/tool/commands/queries.py: 18337 * Scripts/webkitpy/tool/commands/sheriffbot.py: 18338 * Scripts/webkitpy/tool/mocktool.py: 18339 183402010-09-29 Tony Chang <tony@chromium.org> 18341 18342 Reviewed by James Robinson. 18343 18344 [chromium] enable -Werror for DRT and webkit_unit_tests on Linux 18345 https://bugs.webkit.org/show_bug.cgi?id=46829 18346 18347 * DumpRenderTree/chromium/DRTDevToolsClient.cpp: 18348 (DRTDevToolsClient::DRTDevToolsClient): 18349 * DumpRenderTree/chromium/TestShell.cpp: 18350 (TestShell::TestShell): 18351 * DumpRenderTree/chromium/WebViewHost.cpp: 18352 (WebViewHost::postAccessibilityNotification): 18353 (WebViewHost::WebViewHost): 18354 183552010-09-29 Chris Fleizach <cfleizach@apple.com> 18356 18357 Reviewed by Darin Adler. 18358 18359 AX: implement CSS3 Speech "speak" 18360 https://bugs.webkit.org/show_bug.cgi?id=46827 18361 18362 * DumpRenderTree/AccessibilityUIElement.cpp: 18363 (speakCallback): 18364 (AccessibilityUIElement::speak): 18365 (AccessibilityUIElement::getJSClass): 18366 * DumpRenderTree/AccessibilityUIElement.h: 18367 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 18368 (AccessibilityUIElement::speak): 18369 183702010-09-29 Mihai Parparita <mihaip@chromium.org> 18371 18372 Reviewed by Adam Barth. 18373 18374 Record bot ID when updating queue status 18375 https://bugs.webkit.org/show_bug.cgi?id=46764 18376 18377 Since we now have multiple bots handling patches from the commit queue, 18378 we need to differentiate status updates from them, so that we can group 18379 the queue status page in a less confusing way. 18380 18381 * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input 18382 * QueueStatusServer/model/queuestatus.py: Add bot_id property 18383 * QueueStatusServer/templates/updatestatus.html: Add bot_id input 18384 * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser 18385 * Scripts/webkitpy/common/net/statusserver.py: Add bot_id 18386 * Scripts/webkitpy/common/net/statusserver_unittest.py: Added. 18387 * Scripts/webkitpy/tool/main.py: Add --bot-id 18388 * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser 18389 183902010-09-29 Simon Fraser <simon.fraser@apple.com> 18391 18392 No review. 18393 18394 References always refert to a file in .xht format, even 18395 for HTML tests, so fix their loading. 18396 18397 * CSSTestSuiteHarness/harness/harness.js: 18398 (TestSuite.prototype.loadRef): 18399 184002010-09-28 Johnny Ding <jnd@chromium.org> 18401 18402 Reviewed by Adam Barth. 18403 18404 https://bugs.webkit.org/show_bug.cgi?id=41292 18405 Add a new parameter to the test plugin to allow specifying a script 18406 and a mouse/keyboard event. The specified script will be evaluated 18407 in the browser when the specified event is received by the plugin. 18408 18409 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 18410 (pluginAllocate): 18411 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: 18412 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 18413 (NPP_New): 18414 (handleEventCarbon): 18415 (handleEventCocoa): 18416 184172010-09-28 Simon Fraser <simon.fraser@apple.com> 18418 18419 Fix export by adding missing argument. 18420 18421 * CSSTestSuiteHarness/harness/harness.js: 18422 (TestSuite.prototype.showResultsForAllTests): 18423 184242010-09-28 Kevin Ollivier <kevino@theolliviers.com> 18425 18426 [wx] Build fix, add missing import. 18427 18428 * wx/packaging/build-win-installer.py: 18429 184302010-09-28 Simon Fraser <simon.fraser@apple.com> 18431 18432 No review 18433 18434 Show which tests have been run by dimming them out in the test list. 18435 18436 Adjust some element sizes. 18437 18438 * CSSTestSuiteHarness/harness/harness.css: 18439 (#test-list > option.untested): 18440 (#test-list > option.completed): 18441 (#output): 18442 (.output-options): 18443 * CSSTestSuiteHarness/harness/harness.js: 18444 (Test): 18445 (TestSuite.prototype.fillTestList): 18446 (TestSuite.prototype.updateTestList): 18447 (TestSuite.prototype.setSelectedChapter): 18448 (TestSuite.prototype.recordResult): 18449 (TestSuite.prototype.markTestCompleted): 18450 (TestSuite.prototype.testCompletionStateChanged): 18451 (TestSuite.prototype.loadTestStatus): 18452 184532010-09-28 Simon Fraser <simon.fraser@apple.com> 18454 18455 No review. 18456 18457 Implement export of various queries on the test database, sharing 18458 code with that which displays results inline. 18459 18460 * CSSTestSuiteHarness/harness/harness.js: 18461 (): 18462 (TestSuite.prototype.exportResultsCompletion.var): 18463 (TestSuite.prototype.exportResultsCompletion): 18464 (TestSuite.prototype.showResultsForCompletedTests): 18465 (TestSuite.prototype.exportResultsForCompletedTests): 18466 (TestSuite.prototype.showResultsForAllTests): 18467 (TestSuite.prototype.exportResultsForAllTests): 18468 (TestSuite.prototype.exportResultsForTestsNotRun): 18469 (TestSuite.prototype.exportResultsForTestsWithStatus): 18470 (TestSuite.prototype.exportResultsForTestsWithMismatchedResults): 18471 184722010-09-28 Simon Fraser <simon.fraser@apple.com> 18473 18474 No review. 18475 18476 Work around uncertainty about the order of database 18477 transactions when creating the database, so that we don't 18478 try to query the table before it has been created. 18479 18480 * CSSTestSuiteHarness/harness/harness.js: 18481 (TestSuite): 18482 (TestSuite.prototype.databaseCreated): 18483 (TestSuite.prototype.storeTestResult): 18484 (TestSuite.prototype.populateDatabaseFromTestInfoData): 18485 (TestSuite.prototype.queryDatabaseForTestsWithStatus): 18486 (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus): 18487 (TestSuite.prototype.queryDatabaseForCompletedTests): 18488 (TestSuite.prototype.queryDatabaseForTestsNotRun): 18489 184902010-09-28 Tony Chang <tony@chromium.org> 18491 18492 Reviewed by Eric Seidel. 18493 18494 add python keyring support to webkit-patch 18495 https://bugs.webkit.org/show_bug.cgi?id=41269 18496 18497 * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using 18498 the python keyring module 18499 * Scripts/webkitpy/common/net/credentials_unittest.py: 18500 * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params. 18501 * Scripts/webkitpy/common/system/user_unittest.py: 18502 * Scripts/webkitpy/tool/mocktool.py: 18503 185042010-09-28 Martin Robinson <mrobinson@igalia.com> 18505 18506 Reviewed by Gustavo Noronha Silva. 18507 18508 [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings 18509 https://bugs.webkit.org/show_bug.cgi?id=46740 18510 18511 * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common 18512 fonts which can be used to fully test FontConfig rendering settings. 18513 185142010-09-28 Martin Robinson <mrobinson@igalia.com> 18515 18516 Reviewed by Gustavo Noronha Silva. 18517 18518 [gtk] Fedora has a different path for the liberation fonts 18519 https://bugs.webkit.org/show_bug.cgi?id=46709 18520 18521 When searching for DRT fonts, also look in the path where those fonts 18522 are commonly found on Fedora systems. 18523 18524 * DumpRenderTree/gtk/DumpRenderTree.cpp: 18525 (initializeFonts): Include logic for looking for Fedora-style font paths. 18526 185272010-09-28 Martin Robinson <mrobinson@igalia.com> 18528 18529 Reviewed by Andreas Kling. 18530 18531 run-webkit-tests needs an updated list of directories with webgl tests 18532 https://bugs.webkit.org/show_bug.cgi?id=46747 18533 18534 Update the list of directories containing WebGL tests and a unit test 18535 which depends on this list. 18536 18537 * Scripts/old-run-webkit-tests: Update the list of directories. 18538 * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto. 18539 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result. 18540 185412010-09-28 Adam Barth <abarth@webkit.org> 18542 18543 Reviewed by Eric Seidel. 18544 18545 Introduce FailureMap to summaries the failures status of all the bots 18546 https://bugs.webkit.org/show_bug.cgi?id=46700 18547 18548 This patch gives the SheriffBot a handle on the list of failing tests. 18549 18550 * Scripts/webkitpy/common/net/buildbot.py: 18551 * Scripts/webkitpy/common/net/failuremap.py: Added. 18552 * Scripts/webkitpy/tool/commands/queries.py: 18553 * Scripts/webkitpy/tool/commands/sheriffbot.py: 18554 * Scripts/webkitpy/tool/mocktool.py: 18555 185562010-09-28 Adam Roben <aroben@apple.com> 18557 18558 Update for the addition of WKPageUIClient::didNotHandleKeyEvent 18559 18560 Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to 18561 tell a WebKit2 client application that a key event was not handled 18562 18563 Reviewed by Kenneth Rohde Christiansen and Sam Weinig. 18564 18565 * MiniBrowser/mac/BrowserWindowController.m: 18566 (-[BrowserWindowController awakeFromNib]): 18567 * MiniBrowser/win/BrowserView.cpp: 18568 (BrowserView::create): 18569 * WebKitTestRunner/TestController.cpp: 18570 (WTR::createOtherPage): 18571 (WTR::TestController::initialize): 18572 185732010-09-28 Simon Fraser <simon.fraser@apple.com> 18574 18575 Unreviewed. 18576 18577 Update the CSSTestSuiteHarness to not scrape the XHTML chapter files 18578 for the test order, but instead use information from testinfo.data. 18579 18580 * CSSTestSuiteHarness/harness/harness.html: 18581 * CSSTestSuiteHarness/harness/harness.js: 18582 185832010-09-28 Kevin Ollivier <kevino@theolliviers.com> 18584 18585 [wx] Build fix, don't try to get the svn revision from the git repo when packaging, 18586 it causes the process to hang on the gitorious repo. 18587 18588 * wx/packaging/build-mac-installer.py: 18589 * wx/packaging/build-win-installer.py: 18590 185912010-09-28 Adam Roben <aroben@apple.com> 18592 18593 Test that a plugin's HWND is sized/positioned before NPP_SetWindow is 18594 called 18595 18596 Reviewed by Anders Carlsson. 18597 18598 Test for <http://webkit.org/b/46716> <rdar://problem/8482014> 18599 Full-page Adobe Reader does not paint until window is resized 18600 18601 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 18602 (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at 18603 this level. 18604 18605 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared 18606 NPP_SetWindow. 18607 18608 * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added. 18609 (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that 18610 the plugin's HWND has a non-zero size and that its size/position 18611 matches that specified in the NPWindow. 18612 18613 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 18614 (NPP_SetWindow): Call through to the PluginTest. 18615 18616 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 18617 Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder 18618 the files as it saw fit. 18619 186202010-09-28 Benjamin Poulain <benjamin.poulain@nokia.com> 18621 18622 Reviewed by Andreas Kling. 18623 18624 [Qt] Remove support for Qt 4.5 18625 https://bugs.webkit.org/show_bug.cgi?id=46718 18626 18627 Remove the code for versions of Qt prior to 4.6. 18628 18629 * DumpRenderTree/qt/EventSenderQt.cpp: 18630 (EventSender::addTouchPoint): 18631 (EventSender::updateTouchPoint): 18632 (EventSender::setTouchModifier): 18633 (EventSender::touchStart): 18634 (EventSender::touchMove): 18635 (EventSender::touchEnd): 18636 (EventSender::clearTouchPoints): 18637 (EventSender::releaseTouchPoint): 18638 (EventSender::sendTouchEvent): 18639 * DumpRenderTree/qt/EventSenderQt.h: 18640 * DumpRenderTree/qt/TextInputControllerQt.cpp: 18641 (TextInputController::setMarkedText): 18642 * QtTestBrowser/launcherwindow.cpp: 18643 (LauncherWindow::LauncherWindow): 18644 (LauncherWindow::initializeView): 18645 (LauncherWindow::createChrome): 18646 (LauncherWindow::sendTouchEvent): 18647 (LauncherWindow::eventFilter): 18648 (LauncherWindow::applyZoom): 18649 (LauncherWindow::setTouchMocking): 18650 * QtTestBrowser/launcherwindow.h: 18651 * QtTestBrowser/utils.cpp: 18652 (urlFromUserInput): 18653 * QtTestBrowser/webview.cpp: 18654 (WebViewGraphicsBased::animatedFlip): 18655 (WebViewGraphicsBased::animatedYFlip): 18656 * QtTestBrowser/webview.h: 18657 (WebViewGraphicsBased::setYRotation): 18658 186592010-09-28 Ä°smail Dönmez <ismail@namtrac.org> 18660 18661 Reviewed by Andreas Kling. 18662 18663 Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable 18664 which should point to wcecompat installation. Needs wcecompat 18665 library from http://github.com/mauricek/wcecompat . 18666 18667 * DumpRenderTree/qt/DumpRenderTree.pro: 18668 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 18669 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 18670 186712010-09-28 Daniel Bates <dbates@rim.com> 18672 18673 Rollout changeset 68493 <http://trac.webkit.org/changeset/68493> 18674 <https://bugs.webkit.org/show_bug.cgi?id=39136> 18675 18676 Rollout changeset 68493 because it broke Sheriffbot's rollout feature. 18677 In particular, this change caused Sheriffbot to raise an exception when 18678 trying to parse the bug id on a bug page. We need to look into this 18679 some more. 18680 18681 * Scripts/webkitpy/common/net/bugzilla.py: 18682 * Scripts/webkitpy/common/net/bugzilla_unittest.py: 18683 * Scripts/webkitpy/tool/bot/sheriff.py: 18684 * Scripts/webkitpy/tool/commands/download.py: 18685 * Scripts/webkitpy/tool/commands/queues.py: 18686 * Scripts/webkitpy/tool/commands/upload.py: 18687 * Scripts/webkitpy/tool/steps/closebug.py: 18688 * Scripts/webkitpy/tool/steps/obsoletepatches.py: 18689 * Scripts/webkitpy/tool/steps/preparechangelog.py: 18690 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: 18691 186922010-09-28 Adam Barth <abarth@webkit.org> 18693 18694 Reviewed by Eric Seidel. 18695 18696 Move RegressionWindow further up the dependency chain 18697 https://bugs.webkit.org/show_bug.cgi?id=46698 18698 18699 Baby steps towards pushing this information into bug posts. 18700 18701 * Scripts/webkitpy/common/net/buildbot.py: 18702 * Scripts/webkitpy/common/net/buildbot_unittest.py: 18703 * Scripts/webkitpy/common/net/regressionwindow.py: 18704 * Scripts/webkitpy/tool/commands/queries.py: 18705 187062010-09-27 Daniel Bates <dbates@rim.com> 18707 18708 Reviewed by Adam Barth. 18709 18710 sheriffbot can't roll out security patches 18711 https://bugs.webkit.org/show_bug.cgi?id=39136 18712 18713 Make SheriffBot determine if it's authorized to view a bug 18714 whose change it wants to rollout before it tries to rollout 18715 the change. 18716 18717 Moreover, make both webkit-patch and Sheriffbot provide human- 18718 readable error messages when they are not authorized to view 18719 a bug and when a bug number is invalid. 18720 18721 Currently, Sheriffbot does not parse Bugzilla bugs for 18722 <bug error="...">, which indicates an error when retrieving 18723 a bug. In particular, error="NotPermitted" if a person (or bot) 18724 is not authorized to view a bug. For such error="NotPermitted" bugs, 18725 Sheriffbot raises an exception when parsing the bug report and 18726 this exception does not explicitly indicate Sheriffbot's lack 18727 of authorization. Instead, Sheriffbot should explicitly check 18728 for the presence <bug error="..."> before operating on a bug 18729 and error with a human-readable message if it's not permitted 18730 to view it. 18731 18732 * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class. 18733 * Scripts/webkitpy/common/net/bugzilla_unittest.py: 18734 - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error(). 18735 - Added unit test test_bug_parsing_for_bugzilla_not_found_error(). 18736 - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error(). 18737 * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError. 18738 * Scripts/webkitpy/tool/commands/download.py: Ditto. 18739 * Scripts/webkitpy/tool/commands/queues.py: Ditto. 18740 * Scripts/webkitpy/tool/commands/upload.py: Ditto. 18741 * Scripts/webkitpy/tool/steps/closebug.py: Ditto. 18742 * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto. 18743 * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto. 18744 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto. 18745 187462010-09-27 Adam Barth <abarth@webkit.org> 18747 18748 Reviewed by Eric Seidel. 18749 18750 Expose more more failure information from Buildbot to SheriffBot 18751 https://bugs.webkit.org/show_bug.cgi?id=46697 18752 18753 This patch moves the information about what tests failured closer to 18754 SheriffBot. There are still a couple more patches to go before 18755 SheriffBot can post this information to bugs, but this is a step in 18756 that direction. Yay for unit tests, which caught some bugs in earlier 18757 versions of this patch. 18758 18759 * Scripts/webkitpy/common/net/buildbot.py: 18760 * Scripts/webkitpy/common/net/buildbot_unittest.py: 18761 * Scripts/webkitpy/common/net/regressionwindow.py: Added. 18762 * Scripts/webkitpy/tool/commands/queries.py: 18763 187642010-09-27 Eric Seidel <eric@webkit.org> 18765 18766 Unreviewed. Fixing 500 error seen in the status server. 18767 18768 It turns out that a = b = []; b.append(1); then a[0] will be 1! 18769 This should have been obvious to me, I guess, but it was not what I was expecting. 18770 18771 * QueueStatusServer/model/activeworkitems.py: 18772 187732010-09-27 Adam Barth <abarth@webkit.org> 18774 18775 Reviewed by Eric Seidel. 18776 18777 commit-queue should reject patches that fail to land 18778 https://bugs.webkit.org/show_bug.cgi?id=46694 18779 18780 This can happen, for example, if there's no reviewer. Without this 18781 patch, we'll keep retrying the patch. 18782 18783 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 18784 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 18785 187862010-09-27 Simon Fraser <simon.fraser@apple.com> 18787 18788 Rubber-stamped by Adele Peterson. 18789 18790 Add a harness for running the CSS 2.1 test suite. 18791 18792 This harness assumes that you've got a local a copy of the suite 18793 adjacent to the 'harness' directory. 18794 18795 The harness lets you go through the tests in chapter order, 18796 denoting pass/fail/skipped for each test. 18797 18798 It uses a client-side database to store the results of testing. 18799 18800 * CSSTestSuiteHarness/harness/harness.css: Added. 18801 * CSSTestSuiteHarness/harness/harness.html: Added. 18802 * CSSTestSuiteHarness/harness/harness.js: Added. 18803 188042010-09-27 Eric Seidel <eric@webkit.org> 18805 18806 Reviewed by Adam Barth. 18807 18808 Patch locks should expire if a patch is marked for retry 18809 https://bugs.webkit.org/show_bug.cgi?id=46682 18810 18811 This was part Adam's original CommitQueueTask design, 18812 but support for it was missing from the server. 18813 I added the support, but triggering lock-release based on this 18814 special "retry" status feels a bit strange so I added a FIXME. 18815 18816 I also changed the text in queuestatus.html to say "Lock Acquired" 18817 since "Last Activity" isn't really true. We only update the lock 18818 date when the patch is started, not on every status update. 18819 18820 I also noticed an exception in next-patch, which I fixed by re-writing 18821 the unzip logic in activeworkitems.py again. 18822 18823 * QueueStatusServer/handlers/updatestatus.py: 18824 * QueueStatusServer/model/activeworkitems.py: 18825 * QueueStatusServer/templates/queuestatus.html: 18826 188272010-09-27 Tony Chang <tony@chromium.org> 18828 18829 Reviewed by David Levin. 18830 18831 [chromium] fix a warning when compiling DRT on 32-bit linux 18832 https://bugs.webkit.org/show_bug.cgi?id=46641 18833 18834 * DumpRenderTree/chromium/TestEventPrinter.cpp: 18835 (DRTPrinter::handleImage): 18836 188372010-09-27 Eric Seidel <eric@webkit.org> 18838 18839 Reviewed by Adam Barth. 18840 18841 queue-status should report when the patch was last locked to a queue 18842 https://bugs.webkit.org/show_bug.cgi?id=46674 18843 18844 This isn't necessarily the best way to expose this information 18845 but having this accessible via the web interface is very 18846 useful until we come up with a nicer way to display this. 18847 18848 I also cleaned up the code in activeworkitems.py a little 18849 to use list comprehensions and to have the code work with 18850 pairs instead of two lists at once. Eventually I think those 18851 item/time pairs need to be their own little helper class. 18852 18853 * QueueStatusServer/handlers/queuestatus.py: 18854 * QueueStatusServer/model/activeworkitems.py: 18855 * QueueStatusServer/templates/queuestatus.html: 18856 188572010-09-27 Tony Chang <tony@chromium.org> 18858 18859 Reviewed by David Levin. 18860 18861 [chromium] fix detection of missing fonts on DRT 18862 https://bugs.webkit.org/show_bug.cgi?id=46651 18863 18864 * DumpRenderTree/chromium/TestShellGtk.cpp: 18865 (setupFontconfig): Only print an error message if lohit isn't found in both locations. 18866 188672010-09-27 Tony Chang <tony@chromium.org> 18868 18869 Reviewed by Dimitri Glazkov. 18870 18871 add webkit unit tests to the chromium testers 18872 https://bugs.webkit.org/show_bug.cgi?id=46669 18873 18874 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 18875 * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration. 18876 188772010-09-27 Kwang Yul Seo <skyul@company100.net> 18878 18879 Unreviewed. 18880 18881 Adding myself to the committers list. 18882 18883 * Scripts/webkitpy/common/config/committers.py: 18884 188852010-09-27 Mihai Parparita <mihaip@chromium.org> 18886 18887 Reviewed by Eric Seidel. 18888 18889 webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console 18890 https://bugs.webkit.org/show_bug.cgi?id=46634 18891 18892 Use OutputCapture to prevent console spam (and also check for expected 18893 output). 18894 18895 * Scripts/webkitpy/common/system/user_unittest.py: 18896 188972010-09-27 Eric Seidel <eric@webkit.org> 18898 18899 Reviewed by James Robinson. 18900 18901 start-commit-queue should abort any rebases in progress 18902 https://bugs.webkit.org/show_bug.cgi?id=46640 18903 18904 webkit-patch commit-queue would do this itself, but this just 18905 helps ensure that the commit-queue script is properly updated 18906 before we run it (in the case where a previous rebase is in 18907 progress the git svn rebase would not work before we run the 18908 commit-queue). 18909 18910 * EWSTools/start-commit-queue.sh: 18911 189122010-09-18 Martin Robinson <mrobinson@igalia.com> 18913 18914 Reviewed by Gustavo Noronha Silva. 18915 18916 [GTK] Clean up the DRT fonts.conf and switch to Liberation 18917 https://bugs.webkit.org/show_bug.cgi?id=46038 18918 18919 Switch to Liberation fonts for GTK+ layout tests. This will make our 18920 test results metric-compatible with many Windows/Chromium results. It 18921 also simplifies the fonts.conf that we load and prepares the way for 18922 fixing many font bugs. 18923 18924 * DumpRenderTree/gtk/DumpRenderTree.cpp: 18925 (initializeFonts): Initialize a known list of fonts instead of loading 18926 every font in the WEBKIT_TESTFONTS directory. 18927 * DumpRenderTree/gtk/fonts.conf: Removed. 18928 * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF. 18929 * DumpRenderTree/gtk/fonts/fonts.conf: Added. 18930 * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that 18931 we can load both fonts.conf and AHEM____.TTF from this location. 18932 * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since 18933 it is no longer used. 18934 189352010-09-26 Mihai Parparita <mihaip@chromium.org> 18936 18937 Reviewed by Ojan Vafai. 18938 18939 new-run-webkit-httpd fails if Perl is not installed 18940 https://bugs.webkit.org/show_bug.cgi?id=46602 18941 18942 Make Port._read_configuration catch all exceptions, since trying to run 18943 perl (because of _webkit_build_directory) when it's not installed throws 18944 a WindowsError or OSError, not an IOError (this became an issue after 18945 r68268, since ChromiumPort ends up calling Port.default_configuration in 18946 its constructor, which means that we're ending up on this codepath in 18947 non-NRWT cases too, e.g. for the Chromium NaCl tests, which use 18948 new-run-webkit-httpd). 18949 18950 * Scripts/webkitpy/layout_tests/port/base.py: 18951 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 18952 189532010-09-26 Gyuyoung Kim <gyuyoung.kim@samsung.com> 18954 18955 Reviewed by Antonio Gomes. 18956 18957 [EFL] Add setting API to set a local storage database path. 18958 https://bugs.webkit.org/show_bug.cgi?id=45446 18959 18960 Add a setting API to set local storage database path. 18961 18962 * EWebLauncher/main.c: 18963 (on_key_down): 18964 (browserCreate): 18965 (main): 18966 189672010-09-26 Sam Weinig <sam@webkit.org> 18968 18969 Reviewed by Anders Carlsson. 18970 18971 Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API 18972 https://bugs.webkit.org/show_bug.cgi?id=46587 18973 18974 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 18975 189762010-09-26 Antonio Gomes <agomes@rim.com> 18977 18978 Reviewed by Kenneth Rohde Christiansen. 18979 18980 DRT/Mac nodesFromRect support 18981 18982 [Mac][DRT] Implement LayoutTestController::nodesFromRect 18983 https://bugs.webkit.org/show_bug.cgi?id=46580 18984 18985 Implements LayoutTestController::nodesFromRect for Mac DRT, and 18986 adding stubs for GTK+ and Windows. 18987 18988 * DumpRenderTree/LayoutTestController.cpp: 18989 (nodesFromRectCallback): 18990 (LayoutTestController::staticFunctions): 18991 * DumpRenderTree/LayoutTestController.h: 18992 (LayoutTestController::LayoutTestController::nodesFromRect): 18993 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 18994 (LayoutTestController::nodesFromRect): 18995 189962010-09-25 Nicolas Weber <thakis@chromium.org> 18997 18998 Reviewed by Adam Barth. 18999 19000 https://bugs.webkit.org/show_bug.cgi?id=46555 19001 Fix typo in prepare-ChangeLog's help output. 19002 19003 * Scripts/prepare-ChangeLog: 19004 190052010-09-24 Sam Weinig <sam@webkit.org> 19006 19007 Reviewed by Darin Adler. 19008 19009 Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:] 19010 <rdar://problem/8359279> 19011 https://bugs.webkit.org/show_bug.cgi?id=46546 19012 19013 * MiniBrowser/mac/BrowserWindowController.m: 19014 (mouseDidMoveOverElement): 19015 (-[BrowserWindowController awakeFromNib]): 19016 * MiniBrowser/win/BrowserView.cpp: 19017 (mouseDidMoveOverElement): 19018 (BrowserView::create): 19019 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 19020 (WTR::InjectedBundlePage::InjectedBundlePage): 19021 * WebKitTestRunner/TestController.cpp: 19022 (WTR::createOtherPage): 19023 (WTR::TestController::initialize): 19024 190252010-09-24 Mihai Parparita <mihaip@chromium.org> 19026 19027 Reviewed by Adam Barth. 19028 19029 Allow rebaselines for webkit-patch rebaseline to be chosen 19030 https://bugs.webkit.org/show_bug.cgi?id=46407 19031 19032 Instead of always rebaselining all failing tests, allow a subset to be 19033 chosen. 19034 19035 * Scripts/webkitpy/common/system/user.py: 19036 * Scripts/webkitpy/tool/commands/rebaseline.py: 19037 190382010-09-24 Ryosuke Niwa <rniwa@webkit.org> 19039 19040 Reviewed by Tony Chang. 19041 19042 [chromium] Implement TextInputController::firstRectForCharacterRange 19043 https://bugs.webkit.org/show_bug.cgi?id=38100 19044 19045 Implemented TextInputController::firstRectForCharacterRange for chromium platform. 19046 No new tests are added since we need to implement the same feature in chromium side 19047 in order to enable any tests that uses this function. 19048 19049 * DumpRenderTree/chromium/TextInputController.cpp: 19050 (TextInputController::firstRectForCharacterRange): Added. 19051 190522010-09-24 Adam Barth <abarth@webkit.org> 19053 19054 Reviewed by Eric Seidel. 19055 19056 commit-queue reports land failures as "PASS" 19057 https://bugs.webkit.org/show_bug.cgi?id=46530 19058 19059 We were ignoring the return value of land instead of passing it back to 19060 CommitQueue. Of course, this was the one case I forgot to test! 19061 19062 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 19063 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 19064 190652010-09-24 Kenichi Ishibashi <bashi@google.com> 19066 19067 Reviewed by Eric Seidel. 19068 19069 new-run-webkit-tests prints out nothing when build-dumprendertree fails 19070 https://bugs.webkit.org/show_bug.cgi?id=37563 19071 19072 Print error message when build-dumprendertree fails. 19073 19074 * Scripts/webkitpy/layout_tests/port/webkit.py: 19075 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 19076 190772010-09-24 Mihai Parparita <mihaip@chromium.org> 19078 19079 Reviewed by Tony Chang. 19080 19081 NRWT doesn't respect config set with set-webkit-configuration 19082 https://bugs.webkit.org/show_bug.cgi?id=46278 19083 19084 Use Port.default_configuration() instead of hardcoding Release in 19085 ChromiumPort configuration initialization, so that we still inherit the 19086 configuration set by set-webkit-configuration. 19087 19088 * Scripts/webkitpy/layout_tests/port/chromium.py: 19089 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 19090 190912010-09-24 Chang Shu <chang.shu@nokia.com> 19092 19093 Reviewed by Csaba Osztrogonác. 19094 19095 [Qt] Fix the code to check file existence. 19096 https://bugs.webkit.org/show_bug.cgi?id=46465 19097 19098 * QtTestBrowser/main.cpp: 19099 (main): 19100 191012010-09-23 Tony Chang <tony@chromium.org> 19102 19103 Unreviewed, rolling out r68232. 19104 http://trac.webkit.org/changeset/68232 19105 19106 Broken NRWT on the canary bots. 19107 19108 * Scripts/webkitpy/layout_tests/port/chromium.py: 19109 191102010-09-23 Dirk Pranke <dpranke@chromium.org> 19111 19112 Unreviewed, build fix. 19113 19114 r68008 broke new-run-webkit-tests in that the chromium ports no 19115 longer respect set-webkit-configuration. The correct fix for this 19116 is being pursued in bug 46278 (along with a bunch of unit tests), 19117 but in the meantime I'm reverting the particular lines that broke 19118 things. This was tested by hand. 19119 19120 * Scripts/webkitpy/layout_tests/port/chromium.py: 19121 191222010-09-23 Sam Weinig <sam@webkit.org> 19123 19124 Reviewed by Anders Carlsson. 19125 19126 WebKit2 API: Need way to know when a frame is removed from the hierarchy 19127 <rdar://problem/8414062> 19128 https://bugs.webkit.org/show_bug.cgi?id=46432 19129 19130 * MiniBrowser/mac/BrowserWindowController.m: 19131 (didRemoveFrameFromHierarchy): 19132 (-[BrowserWindowController awakeFromNib]): 19133 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 19134 (WTR::InjectedBundlePage::InjectedBundlePage): 19135 * WebKitTestRunner/TestController.cpp: 19136 (WTR::TestController::initialize): 19137 191382010-09-23 Tony Chang <tony@chromium.org> 19139 19140 Reviewed by Dimitri Glazkov. 19141 19142 [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime 19143 https://bugs.webkit.org/show_bug.cgi?id=46426 19144 19145 * DumpRenderTree/chromium/LayoutTestController.cpp: 19146 (LayoutTestController::LayoutTestController): 19147 (LayoutTestController::sampleSVGAnimationForElementAtTime): 19148 * DumpRenderTree/chromium/LayoutTestController.h: 19149 191502010-09-23 Martin Robinson <mrobinson@igalia.com> 19151 19152 Reviewed by Nate Chapin. 19153 19154 [GTK] r68199 introduced two test failures 19155 https://bugs.webkit.org/show_bug.cgi?id=46424 19156 19157 Fix a regression handling preference overrides that are attached to boolean properties. 19158 19159 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 19160 (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match 19161 so we must check for that when converting a string to a boolean. 19162 191632010-09-23 Dimitri Glazkov <dglazkov@chromium.org> 19164 19165 Reviewed by David Levin. 19166 19167 Fix a condition check in ServerProcess, which becomes relevant when reading binary data. 19168 https://bugs.webkit.org/show_bug.cgi?id=46406 19169 19170 This breaks when the method is called with specified size of data (image data), and the 19171 buffer hasn't yet reached this size. 19172 19173 * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of 19174 index larger than 0. 19175 191762010-09-23 Martin Robinson <mrobinson@igalia.com> 19177 19178 Reviewed by Nate Chapin. 19179 19180 [GTK] Some tests from r68174 fail on the GTK+ bots 19181 https://bugs.webkit.org/show_bug.cgi?id=46396 19182 19183 Simplify LayoutTestController::overridePreference to make it easier for 19184 people unfamiliar with the code to keep the list of preferences up to date. 19185 Add the conversion for enable-hyperlink-auditing. 19186 19187 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 19188 (LayoutTestController::overridePreference): Use a simple if-else block to determine 19189 out the property name for overrridePreference. Also simplify the logic for setting 19190 string properties. Add the conversion for enable-hyperlink-auditing. 19191 191922010-09-23 Tony Chang <tony@chromium.org> 19193 19194 Reviewed by David Levin. 19195 19196 [chromium] add caretBrowsingEnabled to WebSettings and DRT 19197 https://bugs.webkit.org/show_bug.cgi?id=46388 19198 19199 * DumpRenderTree/chromium/LayoutTestController.cpp: 19200 (LayoutTestController::overridePreference): 19201 * DumpRenderTree/chromium/WebPreferences.cpp: 19202 (WebPreferences::reset): 19203 (WebPreferences::applyTo): 19204 * DumpRenderTree/chromium/WebPreferences.h: 19205 192062010-09-23 Nate Chapin <japhet@chromium.org> 19207 19208 Reviewed by Darin Fisher. 19209 19210 Allow DRT to toggle hyperlink auditing (i.e., <a ping>). 19211 https://bugs.webkit.org/show_bug.cgi?id=30458 19212 19213 * DumpRenderTree/chromium/LayoutTestController.cpp: 19214 (LayoutTestController::overridePreference): 19215 * DumpRenderTree/chromium/WebPreferences.cpp: 19216 (WebPreferences::reset): 19217 (WebPreferences::applyTo): 19218 * DumpRenderTree/chromium/WebPreferences.h: 19219 * DumpRenderTree/gtk/DumpRenderTree.cpp: 19220 (resetDefaultsToConsistentValues): 19221 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 19222 (LayoutTestController::overridePreference): 19223 192242010-09-21 Stephen White <senorblanco@chromium.org> 19225 19226 Reviewed by David Levin. 19227 19228 Implement --enable-accelerated-2d-canvas flag in DumpRenderTree. 19229 https://bugs.webkit.org/show_bug.cgi?id=46208 19230 19231 This flag allows the layout tests to be run with or without accelerated 19232 2D canvas rendering. 19233 19234 * DumpRenderTree/chromium/DumpRenderTree.cpp: 19235 (main): 19236 Declare the new flag string, and check for it on startup. 19237 * DumpRenderTree/chromium/TestShell.cpp: 19238 (TestShell::TestShell): 19239 Add a boolean for the new flag, in order to preserve its value over 19240 preferences reset. 19241 (TestShell::resetWebSettings): 19242 Set the new flag to the stored value on reset. 19243 * DumpRenderTree/chromium/TestShell.h: 19244 (TestShell::setAccelerated2dCanvasEnabled): 19245 Add an accessor for the new flag. 19246 * DumpRenderTree/chromium/WebPreferences.cpp: 19247 (WebPreferences::reset): 19248 Initialize the new flag to false. 19249 (WebPreferences::applyTo): 19250 Copy the flag's value to the WebSettings. 19251 * DumpRenderTree/chromium/WebPreferences.h: 19252 Add the new flag. 19253 192542010-09-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 19255 19256 Reviewed by Simon Hausmann. 19257 19258 [Qt] Refactor QtWebKitPlatformPlugin interface 19259 19260 Make it easier to keep source-compability for the 19261 QtWebKitPlatformPlugin interface, and run qmake 19262 on the example (but not build) for convenience. 19263 19264 https://bugs.webkit.org/show_bug.cgi?id=46345 19265 19266 * Scripts/webkitdirs.pm: 19267 192682010-09-23 Adam Barth <abarth@webkit.org> 19269 19270 Reviewed by Eric Seidel. 19271 19272 Tweak some status messages that Eric thought were confusing 19273 https://bugs.webkit.org/show_bug.cgi?id=46342 19274 19275 * Scripts/webkitpy/tool/commands/queues.py: 19276 * Scripts/webkitpy/tool/commands/queues_unittest.py: 19277 192782010-09-22 Adam Barth <abarth@webkit.org> 19279 19280 Reviewed by Eric Seidel. 19281 19282 Fix comm-queue typo 19283 https://bugs.webkit.org/show_bug.cgi?id=46339 19284 19285 We were missing a "self". The real problem is that we didn't have an 19286 integration test for the failure case. 19287 19288 * Scripts/webkitpy/tool/commands/queues.py: 19289 * Scripts/webkitpy/tool/commands/queues_unittest.py: 19290 192912010-09-22 Adam Barth <abarth@webkit.org> 19292 19293 Reviewed by Eric Seidel. 19294 19295 commit-queue should log more detailed messages to the QueueStatusServer 19296 https://bugs.webkit.org/show_bug.cgi?id=46333 19297 19298 When I created CommitQueueTask, I removed most of the previous logging. 19299 This patch adds back more detailed logging so folks can see their patch 19300 progress through the queue. 19301 19302 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 19303 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 19304 * Scripts/webkitpy/tool/commands/queues.py: 19305 * Scripts/webkitpy/tool/commands/queues_unittest.py: 19306 193072010-09-22 Mihai Parparita <mihaip@chromium.org> 19308 19309 Reviewed by Darin Fisher. 19310 19311 [Chromium] User style layout tests don't pass on Chromium 19312 https://bugs.webkit.org/show_bug.cgi?id=46069 19313 19314 Fix a typo in LayoutTestController::addUserStyleSheet that was causing a 19315 crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT 19316 behavior from other ports. 19317 19318 * DumpRenderTree/chromium/LayoutTestController.cpp: 19319 (LayoutTestController::addUserStyleSheet): 19320 193212010-09-22 Brent Fulgham <bfulgham@webkit.org> 19322 19323 Reviewed by Martin Robinson. 19324 19325 [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build. 19326 https://bugs.webkit.org/show_bug.cgi?id=46303. 19327 19328 * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added. 19329 * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved 19330 CoreFoundation-specific stuff to new MiniBrowserCoreFoundation 19331 property sheet. 19332 * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added. 19333 * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use 19334 appropriate property sheet for the build types. 19335 * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the 19336 configuration to use appropriate property sheet for CoreFoundation 19337 and CFLite-style builds. 19338 193392010-09-22 Adam Barth <abarth@webkit.org> 19340 19341 Reviewed by Eric Seidel. 19342 19343 Optimize commit-queue performance for green trees 19344 https://bugs.webkit.org/show_bug.cgi?id=46254 19345 19346 This patch redesigns the controller logic for the commit-queue. In the 19347 new design, the controller exercises much finer-grained control over 19348 the landing process. In particular: 19349 19350 - Patches that fail to apply now get rejected almost immediately. 19351 - Patches that fail to build get rejects after two builds (instead of 19352 three builds and one test run). 19353 - Patches that run into a flaky test now get accepted after one build 19354 and two test runs instead of three full build-and-test runs. 19355 19356 The main cost of these optimizations is that we don't find out the tree 19357 has a failing test until the very end of the process, but if the tree 19358 has a busted test, there's not much we can do anyway. We might as well 19359 burn commit-queue resources spinning optimisticly. 19360 19361 * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added. 19362 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added. 19363 * Scripts/webkitpy/tool/commands/queues.py: 19364 193652010-09-22 Brent Fulgham <bfulgham@webkit.org> 19366 19367 Reviewed by Martin Robinson. 19368 19369 [WinCairo] Update WebKitTestRunner and DumpRenderTree Build. 19370 https://bugs.webkit.org/show_bug.cgi?id=46303. 19371 19372 * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources 19373 for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the 19374 WinCairo build. 19375 * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added. 19376 * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo 19377 build targets that use the new InjectedBundleCFLite.vsprops file. 19378 193792010-09-22 Dirk Pranke <dpranke@chromium.org> 19380 19381 Unreviewed, build fix. 19382 19383 Fix bustage of rebaseline-chromium-webkit-tests resulting from 19384 r67974. Really need better unit tests for this tool :( 19385 19386 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 19387 193882010-09-22 Adam Roben <aroben@apple.com> 19389 19390 Unbreak test-webkitpy 19391 19392 * Scripts/webkitpy/test/main.py: 19393 (Tester.run_tests): Add a line that mysteriously got deleted. 19394 193952010-09-22 Adam Roben <aroben@apple.com> 19396 19397 Make test-webkitpy test WebKit2's scripts 19398 19399 These scripts can't be in WebKitTools due to limitations of Apple's 19400 build process. But that doesn't mean we can't test them! 19401 19402 Fixes <http://webkit.org/b/46297> test-webkitpy should test code in 19403 WebKit2/Scripts 19404 19405 Reviewed by Adam Barth. 19406 19407 * Scripts/test-webkitpy: 19408 (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test. 19409 Now takes an external_package_paths parameter and cleans both webkitpy 19410 and any external packages. 19411 (init): Added an external_package_paths parameter which we pass along 19412 to _clean_packages_with_test. 19413 (top level): Add WebKit2/Scripts/webkit2 as our only external package 19414 and pass it along to init and Tester.run_tests. 19415 19416 * Scripts/webkitpy/test/main.py: 19417 (Tester.run_tests): Added an optional external_package_paths 19418 parameter. We modify sys.path so that the external packages can be 19419 imported, and search for unittest files inside all external packages 19420 in addition to inside webkitpy. 19421 194222010-09-22 Dirk Pranke <dpranke@chromium.org> 19423 19424 Reviewed by Tony Chang. 19425 19426 new-run-webkit-tests: r68063 broke linux python tests 19427 19428 Add a missing "from __future__ import with_statement" to this 19429 new file; the perils of testing only on the Mac and by review :( 19430 19431 https://bugs.webkit.org/show_bug.cgi?id=46293 19432 19433 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 19434 194352010-09-22 Dirk Pranke <dpranke@chromium.org> 19436 19437 Reviewed by Tony Chang. 19438 19439 Add a 'chromium-gpu' set of ports that will test the accelerated 19440 GPU paths. This patch adds: 19441 19442 - support for the '--accelerated-compositing' and 19443 'accelerated-2d-canvas' flags to new-run-webkit-tests (and the 19444 'no-' flags) 19445 - adds a new set of Ports that will look under 19446 platform/chromium-gpu-$OS/ for baselines before looking in the 19447 regular chromium search path 19448 - adds a new test_expectations.txt file in platform/chromium-gpu 19449 that skips all but the tests we actually want to run with 19450 acceleration. 19451 19452 This patch will allow us to run both with and without acceleration 19453 and to change the defaults for both the regular and -gpu options 19454 as the code evolves. 19455 19456 We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to 19457 each test bot. 19458 19459 https://bugs.webkit.org/show_bug.cgi?id=46225 19460 19461 * Scripts/webkitpy/layout_tests/port/chromium.py: 19462 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 19463 * Scripts/webkitpy/layout_tests/port/factory.py: 19464 * Scripts/webkitpy/layout_tests/port/webkit.py: 19465 194662010-09-22 Jamey Hicks <jamey.hicks@nokia.com> 19467 19468 Reviewed by Kenneth Rohde Christiansen. 19469 19470 [Qt] Web Inspector: Remote Web Inspector support for QtWebKit 19471 https://bugs.webkit.org/show_bug.cgi?id=43988 19472 19473 Runs a web debug server on port specified by QtTestBrowser 19474 argument -remote-inspector-port. Property 19475 _q_webInspectorServerPort of the QWebPage instance will be set 19476 according to the argument. All pages with that property set will 19477 be remotely inspectable. 19478 19479 URL for remote inspection of first QWebPage is 19480 http://localhost:9222/webkit/inspector/inspector.html?page=1 19481 where 1 is the number of the QWebPage instance. 19482 19483 The base URL yields an index page with links to the individual inspectors: 19484 http://localhost:9222/ 19485 19486 * QtTestBrowser/launcherwindow.cpp: 19487 (LauncherWindow::init): 19488 * QtTestBrowser/launcherwindow.h: 19489 * QtTestBrowser/main.cpp: 19490 (LauncherApplication::handleUserOptions): 19491 194922010-09-22 Adam Roben <aroben@apple.com> 19493 19494 Fix webkit-patch failure-reason now that build.webkit.org has been 19495 updated 19496 19497 Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes 19498 every time 19499 19500 Reviewed by Eric Seidel. 19501 19502 * Scripts/webkitpy/common/net/buildbot.py: 19503 (BuildBot._file_cell_text): Added. Travels down the firstChild chain 19504 looking for an element that contains text, then returns it. 19505 (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the 19506 text out of the cells. This way it doesn't matter whether the cells 19507 have <b> children (as for cells in directory rows) or not (as for 19508 cells in file rows) 19509 (BuildBot._parse_twisted_directory_listing): Look for rows that have 19510 the "directory" or "file" class, rather than rows with any class, 19511 since header rows now have a class attribute. 19512 19513 * Scripts/webkitpy/common/net/buildbot_unittest.py: 19514 (BuildBotTest._example_directory_listing): Updated to more closely 19515 match the markup that build.webkit.org is producing now. 19516 195172010-09-21 Dirk Pranke <dpranke@chromium.org> 19518 19519 Unreviewed, build fix. 19520 19521 new-run-webkit-tests: fix bug introduced in r68008 where if you 19522 specify --chromium and no --platform, and you're running on 19523 windows, you use the 'chromium-win' port by default instead of the 19524 version-specific port. This breaks the buildbots. 19525 19526 It will be good for this refactoring to settle down so I can 19527 rewrite the logic for default ports and the unit tests to be 19528 clearer (and the testing more comprehensive). 19529 19530 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 19531 195322010-09-21 Dirk Pranke <dpranke@chromium.org> 19533 19534 Reviewed by Adam Barth. 19535 19536 Modify the Port interface to take only a series of keyword arguments 19537 in the constructor, and modify Port/factory.get() to accomodate that, 19538 and to accept user=XXX as an argument so we can pass 19539 webkitpy.common.system.user.User objects in. 19540 19541 Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests 19542 to use the common routine in webkitpy.common.system.user.open_url() 19543 to display HTML files. 19544 19545 There was a routine in the Port interface to do the same thing, 19546 but I see no need for a port-specific hook for this, since it is 19547 something that will always be executed by the host environment 19548 and displaying web pages has nothing to do with running layout tests. 19549 19550 Note that new-run-webkit-tests used to use test_shell to display 19551 the page; this is potentially useful so that you can actually click 19552 from a result to the broken page; however, since DumpRenderTree 19553 doesn't support this functionality, it will be going away eventually. 19554 19555 https://bugs.webkit.org/show_bug.cgi?id=46128 19556 19557 * Scripts/webkitpy/layout_tests/port/base.py: 19558 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 19559 * Scripts/webkitpy/layout_tests/port/chromium.py: 19560 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 19561 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 19562 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 19563 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 19564 * Scripts/webkitpy/layout_tests/port/dryrun.py: 19565 * Scripts/webkitpy/layout_tests/port/factory.py: 19566 * Scripts/webkitpy/layout_tests/port/google_chrome.py: 19567 * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: 19568 * Scripts/webkitpy/layout_tests/port/gtk.py: 19569 * Scripts/webkitpy/layout_tests/port/mac.py: 19570 * Scripts/webkitpy/layout_tests/port/qt.py: 19571 * Scripts/webkitpy/layout_tests/port/test.py: 19572 * Scripts/webkitpy/layout_tests/port/webkit.py: 19573 * Scripts/webkitpy/layout_tests/port/win.py: 19574 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 19575 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 19576 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 19577 195782010-09-21 Lucas De Marchi <lucas.demarchi@profusion.mobi> 19579 19580 Reviewed by Kenneth Rohde Christiansen. 19581 19582 [EFL] Get fresh theme when running EWebLauncher 19583 https://bugs.webkit.org/show_bug.cgi?id=46210 19584 19585 If user tried to run EWebLauncher outside of the build tree, it would 19586 not find the theme and fallback to the installed one. However, since 19587 EWebLauncher is not installed, we always want to take the theme from 19588 the just compiled source code. If user had never installed WebKit's 19589 EFL port it could even receive a segv since no theme would be found. 19590 19591 Now EWebLauncher does not fallback to the installed theme and CMake 19592 gives as DATA_DIR the directory of the theme it has just built. 19593 19594 * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to 19595 EWebLauncher. 19596 * EWebLauncher/main.c: Use only the theme from build director. Do not 19597 fallback to others as this could hide real bugs. 19598 (quit): 19599 (browserCreate): 19600 (findThemePath): 19601 (main): 19602 196032010-09-21 Dirk Pranke <dpranke@chromium.org> 19604 19605 Unreviewed, build fix. 19606 19607 Don't pass the --test-shell arg to the Chromium Mac port of DRT; 19608 it just confuses it. 19609 19610 https://bugs.webkit.org/show_bug.cgi?id=46230 19611 19612 * Scripts/webkitpy/layout_tests/port/webkit.py: 19613 196142010-09-21 Lucas Forschler <lforschler@apple.com> 19615 19616 Reviewed by Stephanie Lewis. 19617 19618 Make a new buildbot for Leopard Debug Test 19619 19620 * BuildSlaveSupport/build.webkit.org-config/config.json: 19621 196222010-09-21 Dirk Pranke <dpranke@chromium.org> 19623 19624 Unreviewed, build fix. 19625 19626 Fix breakage of Chromium Mac DRT port caused by r67905. 19627 19628 https://bugs.webkit.org/show_bug.cgi?id=46230 19629 19630 * Scripts/webkitpy/layout_tests/port/webkit.py: 19631 196322010-09-21 Dirk Pranke <dpranke@chromium.org> 19633 19634 Unreviewed, build fix. 19635 19636 Add missing import of 'tempfile'. 19637 19638 * Scripts/webkitpy/layout_tests/port/chromium.py: 19639 196402010-09-17 Dirk Pranke <dpranke@chromium.org> 19641 19642 Reviewed by Ojan Vafai. 19643 19644 new-run-webkit-tests: pull the list of tests from the Port, and 19645 make it possible to run with no actual test files in the filesystem. 19646 19647 This set of changes allows us to delete the special 19648 webkitpy/layout_tests/data directory and test the generic code without 19649 touching the filesystem (except to write results). This speeds up 19650 test-webkitpy substantially. 19651 19652 This also cleans up and removes several code paths in the generic 19653 code and fixes some minor bugs, notably in the test_expectations 19654 parsing, which was previously fragile if the tests weren't present. 19655 19656 We also change the way we diff image results to be able to do so 19657 in memory, without relying on files. This slows down chromium 19658 test_shell, which always writes images to files, but should speed 19659 up DRT and ImageDiff-based implementations slightly. 19660 19661 Note that pulling the list of tests to run from the Port will allow 19662 ports to specify what tests to run as an inclusive list; previously 19663 you could only do this as an exclusive list by using a 19664 test_expectations file or Skipped files; nothing actually uses this 19665 feature yet and it's unclear if it should be used. 19666 19667 Note that there are no functional changes -- apart from now 19668 always printing out the location of the checksum file when we are 19669 tracing test runs -- and the total number of lines of non-test code 19670 actually drops by two. 19671 19672 There is some more cleanup that can be done in the Port/Driver 19673 interface and in some handling of filenames, but I'll save that 19674 for another change. 19675 19676 https://bugs.webkit.org/show_bug.cgi?id=45801 19677 19678 * Scripts/webkitpy/layout_tests/data/*: Removed. 19679 - no longer need special mock layout_tests_directory in the 19680 repository. 19681 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 19682 - add code to display missing text files, checksums when tracing 19683 - update to not look at the filesystem directly. 19684 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 19685 - add more unit tests 19686 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 19687 - remove tests_are_present flag 19688 - update with changes in Port interface - no longer access 19689 the filesystem directly, although we still use os.path for 19690 filename manipulation. 19691 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 19692 - add more unit tests 19693 * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed. 19694 - renamed to port/test_files.py 19695 * Scripts/webkitpy/layout_tests/port/base.py: 19696 - change diff_image() to expect actual image data, not filenames 19697 - add expected_checksum(), expected_image(), expected_text() to 19698 return the content of the files so that we don't need a filesystem 19699 - add path_exists(), path_isdir() for filesystem-like access. 19700 - add test_dirs() to keep clobber-test-results from needing to 19701 actually look at a real layout tests dir 19702 - add tests() to return the list of tests to run on the port 19703 (calls port/test_files to do the work). 19704 - add update_baseline() to be able to save new baselines 19705 - add uri_to_test_name() from port/dryrun.py so we can easily check 19706 filename_to_uri() 19707 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 19708 - add more unit tests 19709 * Scripts/webkitpy/layout_tests/port/chromium.py: 19710 - change diff_image() to accept image content, not filenames. 19711 This will be slower for test_shell/image_diff, but faster 19712 for DRT/ImageDiff. 19713 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 19714 - add more unit tests 19715 * Scripts/webkitpy/layout_tests/port/dryrun.py: 19716 - simplify greatly 19717 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 19718 - add more unit tests 19719 * Scripts/webkitpy/layout_tests/port/test.py: 19720 - massive rewrite to use in-script list of tests and expectations 19721 * Scripts/webkitpy/layout_tests/port/test_files.py: 19722 - rename from layout_package/test_files. 19723 * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: 19724 - add unit tests 19725 * Scripts/webkitpy/layout_tests/port/webkit.py: 19726 - update diff_image() to take image contents, not files. Should 19727 make things slightly faster. 19728 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 19729 - update with changes to diff_image() 19730 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 19731 - update with changes to diff_image() 19732 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 19733 - remove tests_are_present from test_expectations 19734 - pull the list of tests from port.tests() instead 19735 of calling test_files.py directly. 19736 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 19737 - update unit tests 19738 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 19739 - update with changes to 19740 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 19741 - update with change in Port interface 19742 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 19743 - update with change in Port interface 19744 * Scripts/webkitpy/style/checkers/test_expectations.py: 19745 - remove the tests_are_present flag 19746 197472010-09-21 Anders Carlsson <andersca@apple.com> 19748 19749 Disable logging. 19750 19751 * MiniBrowser/mac/MiniBrowser_Prefix.pch: 19752 197532010-09-21 Tony Chang <tony@chromium.org> 19754 19755 Reviewed by Kent Tamura. 19756 19757 add a script for running webkit_unit_tests 19758 https://bugs.webkit.org/show_bug.cgi?id=46014 19759 19760 * Scripts/run-chromium-webkit-unit-tests: Added. 19761 197622010-09-21 Fridrich Strba <fridrich.strba@bluewin.ch> 19763 19764 Reviewed by Martin Robinson. 19765 19766 Fix linking problems on Windows. 19767 https://bugs.webkit.org/show_bug.cgi?id=45844 19768 19769 * GNUmakefile.am: link the executables with winmm.dll 19770 197712010-09-21 Adam Barth <abarth@webkit.org> 19772 19773 Reviewed by Eric Seidel. 19774 19775 feeder-queue svn updates more often than needed 19776 https://bugs.webkit.org/show_bug.cgi?id=46171 19777 19778 We don't need to poll SVN every time we feed the feeders. Rather, we 19779 can count on the wrapper shell script to auto-update the queue. 19780 19781 * Scripts/webkitpy/tool/commands/queues.py: 19782 * Scripts/webkitpy/tool/commands/queues_unittest.py: 19783 197842010-09-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 19785 19786 Reviewed by Andreas Kling. 19787 19788 [Qt] Add robot loader timeout and extra time options. 19789 https://bugs.webkit.org/show_bug.cgi?id=46172 19790 19791 [-robot-timeout <s>]: Load the next page after s seconds if the current 19792 page didn't finish loading. 19793 [-robot-extra-time <s>]: Wait s seconds after the current page finished 19794 loading before loading the next one. This should allow some time for the 19795 page's JavaScript to execute. 19796 19797 * QtTestBrowser/launcherwindow.cpp: 19798 (LauncherWindow::applyPrefs): 19799 * QtTestBrowser/main.cpp: 19800 (LauncherApplication::robotTimeout): 19801 (LauncherApplication::robotExtraTime): 19802 (LauncherApplication::LauncherApplication): 19803 (LauncherApplication::handleUserOptions): 19804 (main): 19805 * QtTestBrowser/urlloader.cpp: 19806 (UrlLoader::UrlLoader): 19807 (UrlLoader::loadNext): 19808 (UrlLoader::loadUrlList): 19809 * QtTestBrowser/urlloader.h: 19810 198112010-09-21 Pavel Podivilov <podivilov@chromium.org> 19812 19813 Unreviewed. 19814 19815 Adding myself to the committers list. 19816 19817 * Scripts/webkitpy/common/config/committers.py: 19818 198192010-09-20 Philippe Normand <pnormand@igalia.com> 19820 19821 Reviewed by Eric Carlson. 19822 19823 [GTK] enhanced context menu for media elements 19824 https://bugs.webkit.org/show_bug.cgi?id=45021 19825 19826 EventSender::contextClick() now returns an array of js 19827 objects. Each object has a title property and a click() method. 19828 19829 * DumpRenderTree/gtk/EventSender.cpp: 19830 (getMenuItemTitleCallback): 19831 (setMenuItemTitleCallback): 19832 (menuItemClickCallback): 19833 (getMenuItemClass): 19834 (contextClickCallback): 19835 198362010-09-20 Hayato Ito <hayato@chromium.org> 19837 19838 Unreviewed. 19839 Adding myself to the committers list. 19840 19841 * Scripts/webkitpy/common/config/committers.py: 19842 198432010-09-20 Adam Barth <abarth@webkit.org> 19844 19845 Reviewed by Eric Seidel. 19846 19847 The tool member variable should be called _tool 19848 https://bugs.webkit.org/show_bug.cgi?id=46160 19849 19850 Created by find-and-replace. 19851 19852 * Scripts/webkitpy/tool/commands/download.py: 19853 * Scripts/webkitpy/tool/commands/openbugs.py: 19854 * Scripts/webkitpy/tool/commands/queries.py: 19855 * Scripts/webkitpy/tool/commands/queues.py: 19856 * Scripts/webkitpy/tool/commands/queues_unittest.py: 19857 * Scripts/webkitpy/tool/commands/rebaseline.py: 19858 * Scripts/webkitpy/tool/commands/sheriffbot.py: 19859 * Scripts/webkitpy/tool/commands/upload.py: 19860 * Scripts/webkitpy/tool/multicommandtool.py: 19861 198622010-09-20 Adam Barth <abarth@webkit.org> 19863 19864 I ran the tests before landing but ignored the fact that they failed. :( 19865 19866 * Scripts/webkitpy/tool/commands/queues.py: 19867 198682010-09-20 Adam Barth <abarth@webkit.org> 19869 19870 Reviewed by Eric Seidel. 19871 19872 Add a feeder queue that polls bugs.webkit.org for the commit-cluster 19873 https://bugs.webkit.org/show_bug.cgi?id=46141 19874 19875 The feeder-queue polls bugs.webkit.org every 30 seconds and updates the 19876 list of work items on the status server. The individual commit-cluster 19877 nodes then grab the patches from the server and process them. 19878 19879 * Scripts/webkitpy/tool/bot/feeders.py: Added. 19880 * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added. 19881 * Scripts/webkitpy/tool/commands/queues.py: 19882 * Scripts/webkitpy/tool/commands/queues_unittest.py: 19883 * Scripts/webkitpy/tool/commands/queuestest.py: 19884 198852010-09-20 Leandro Pereira <leandro@profusion.mobi> 19886 19887 Reviewed by Darin Adler. 19888 19889 build-webkit: Add support for CMake build system 19890 https://bugs.webkit.org/show_bug.cgi?id=44979 19891 19892 * Scripts/build-webkit: Add "--efl" command-line option to build the 19893 EFL port of WebKit. 19894 * Scripts/webkitdirs.pm: Define buildCMakeProject() and 19895 buildEflCMakeProject() subroutines. 19896 198972010-09-20 Dirk Pranke <dpranke@chromium.org> 19898 19899 Reviewed by Ojan Vafai. 19900 19901 new-run-webkit-tests: refactor command line args getting passed to DRT 19902 19903 This change cleans up some argument parsing between functions to get 19904 rid of some overlapping data structures. There should be no functional 19905 changes in this patch; it is pure refactoring in preparation for 19906 landing the Chrome GPU port and adding a generic way to pass 19907 args to DRT/TestShell. 19908 19909 https://bugs.webkit.org/show_bug.cgi?id=46135 19910 19911 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 19912 - pass the options argument explicitly to the threads and drivers, 19913 also consolidate the passing of options to the driver. 19914 - pass options directly to process_output() to remove a couple 19915 parameters (minor cleanup). 19916 * Scripts/webkitpy/layout_tests/port/base.py: 19917 - pass the options argument to Port.create_driver(). 19918 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 19919 - update Port.create_driver() test 19920 * Scripts/webkitpy/layout_tests/port/chromium.py: 19921 - pass the options argument to Port.create_driver(), and clean up 19922 building of the cmd line for DRT. 19923 * Scripts/webkitpy/layout_tests/port/dryrun.py: 19924 - pass the options argument to Port.create_driver() 19925 * Scripts/webkitpy/layout_tests/port/test.py: 19926 - pass the options argument to Port.create_driver() 19927 * Scripts/webkitpy/layout_tests/port/webkit.py: 19928 - pass the options argument to Port.create_driver(), and clean up 19929 building of the cmd line for DRT. 19930 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 19931 - consolidate args in _get_dump_render_tree_args and rename to 19932 _get_test_args(); move all of the command-line args to the 19933 Port implementations. 19934 199352010-09-20 Andrew Wilson <atwilson@chromium.org> 19936 19937 Revert change which was accidentally committed along with some expectation changes. 19938 19939 * Scripts/webkitpy/layout_tests/port/base.py: 19940 199412010-09-20 Mihai Parparita <mihaip@chromium.org> 19942 19943 Reviewed by Adam Barth. 19944 19945 Add explicit --force-patch flag to webkitpy tools 19946 https://bugs.webkit.org/show_bug.cgi?id=46103 19947 19948 It wasn't obvious until I read the applypatch.py source code that 19949 --non-interfactive implies passing --force to patch. Add --force-patch 19950 as an alias to the flag, so that this behavior is more discoverable. 19951 19952 * Scripts/webkitpy/tool/steps/applypatch.py: 19953 * Scripts/webkitpy/tool/steps/options.py: 19954 199552010-09-20 Eric Seidel <eric@webkit.org> 19956 19957 Unreviewed, adding a line which got dropped and is trivially correct (and tested). 19958 19959 commit-queue can't land patches 19960 https://bugs.webkit.org/show_bug.cgi?id=46138 19961 19962 Add a line of code I forgot in my last commit. 19963 19964 * Scripts/webkitpy/common/net/bugzilla.py: 19965 * Scripts/webkitpy/common/net/bugzilla_unittest.py: 19966 199672010-09-20 Adam Barth <abarth@webkit.org> 19968 19969 Reviewed by Eric Seidel. 19970 19971 The commit-cluster bots still race to lock patch_ids 19972 https://bugs.webkit.org/show_bug.cgi?id=46130 19973 19974 It turns out we need to use a transaction object to make the 19975 read/modify/write lock operation atomic. From reading the AppEngine 19976 documentation, I think this patch should do what we want. It's hard to 19977 test locally because the test instance isn't distributed in the same 19978 way the production instance is. 19979 19980 * QueueStatusServer/handlers/nextpatch.py: 19981 * QueueStatusServer/model/activeworkitems.py: Added. 19982 199832010-09-20 Andy Estes <aestes@apple.com> 19984 19985 Reviewed by Adam Barth. 19986 19987 REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes 19988 https://bugs.webkit.org/show_bug.cgi?id=40961 19989 19990 Implement WebKitUsePreHTML5ParserQuirks preference. 19991 19992 * DumpRenderTree/mac/DumpRenderTree.mm: 19993 (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks 19994 to false after a test finishes. 19995 199962010-09-20 Adam Roben <aroben@apple.com> 19997 19998 Windows build fix 19999 20000 * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put 20001 $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so 20002 we'll pick up the most recent versions of the headers. 20003 200042010-09-20 Eric Seidel <eric@webkit.org> 20005 20006 Reviewed by Adam Barth. 20007 20008 commit-queue should check commit-queue+ again just before committing 20009 https://bugs.webkit.org/show_bug.cgi?id=32679 20010 20011 Added a _revalidate_patch check, right before landing. 20012 20013 Since _revalidate_patch passes the patch_id from the work item 20014 back to bugzilla, I had to fix all of the previous queue tests to 20015 use valid attachment ids (that's the majority of this change). 20016 20017 In order to validate that the bug was still open, I had to teach 20018 bugzilla.Bug about open/closed states. 20019 20020 * Scripts/webkitpy/common/net/bugzilla.py: 20021 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 20022 * Scripts/webkitpy/tool/commands/queues.py: 20023 * Scripts/webkitpy/tool/commands/queues_unittest.py: 20024 * Scripts/webkitpy/tool/commands/queuestest.py: 20025 * Scripts/webkitpy/tool/mocktool.py: 20026 200272010-09-20 Mihai Parparita <mihaip@chromium.org> 20028 20029 Unreviewed. 20030 20031 Adding myself as a comitter. 20032 20033 * Scripts/webkitpy/common/config/committers.py: 20034 200352010-09-20 Adam Barth <abarth@webkit.org> 20036 20037 Reviewed by Eric Seidel. 20038 20039 Two instances of commit-queue try to process the same patch 20040 https://bugs.webkit.org/show_bug.cgi?id=46113 20041 20042 This patch makes next-patch atomic so that the server won't vend the 20043 same patch twice in the same hour. 20044 20045 * QueueStatusServer/handlers/nextpatch.py: 20046 200472010-09-20 Adam Roben <aroben@apple.com> 20048 20049 Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows 20050 20051 We were previously trying to use a CFRunLoopTimer, but since Windows 20052 doesn't use CFRunLoop on most threads this doesn't work. Now we use a 20053 Windows-style timer on Windows. 20054 20055 I also replaced all uses of "watchdog" with "watchdog timer". 20056 20057 Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump 20058 watchdog timer doesn't work on Windows 20059 20060 Reviewed by Anders Carlsson. 20061 20062 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 20063 (WTR::InjectedBundlePage::dump): Updated for rename. 20064 20065 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed 20066 platform-specific functions. 20067 (WTR::LayoutTestController::LayoutTestController): Added call to 20068 platformInitialize. 20069 (WTR::LayoutTestController::waitUntilDone): Changed to call 20070 initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work 20071 right in this function. 20072 (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for 20073 rename. 20074 20075 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new 20076 members needed to support the watchdog timer abstraction. Replaced 20077 some "watchdog"s with "watchdog timer". 20078 20079 * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: 20080 Added. 20081 (WTR::LayoutTestController::platformInitialize): Does nothing on this 20082 platform. 20083 (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here 20084 from LayoutTestController.cpp and changed to use an early return. 20085 (WTR::waitUntilDoneWatchdogTimerFired): Moved here from 20086 LayoutTestController.cpp. 20087 (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded): 20088 Moved code here from LayoutTestController::waitUntilDone and changed 20089 to use an early return. 20090 20091 * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: 20092 Added. 20093 (WTR::LayoutTestController::platformInitialize): Initialize our 20094 watchdog timer. 20095 (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added. 20096 Kills and clears the watchdog timer. 20097 (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the 20098 LayoutTestController member function of the same name. 20099 (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded): 20100 Added. Sets up the timer if it isn't already set. 20101 20102 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added 20103 LayoutTestControllerMac.mm. 20104 20105 * WebKitTestRunner/win/InjectedBundle.vcproj: Added 20106 LayoutTestControllerWin.cpp. 20107 201082010-09-20 Martin Robinson <mrobinson@igalia.com> 20109 20110 Reviewed by Daniel Bates. 20111 20112 [GTK] fast/forms/listbox-selection.html fails 20113 https://bugs.webkit.org/show_bug.cgi?id=45942 20114 20115 Use the gdkModifersFromJSValue helper to parse all appropriate modifier 20116 strings in keyDownCallback. 20117 20118 * DumpRenderTree/gtk/EventSender.cpp: 20119 (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 20120 modifier parsing logic. 20121 201222010-09-19 Sam Weinig <sam@webkit.org> 20123 20124 Reviewed by Anders Carlsson. 20125 20126 WebKit2 decidePolicyForNavigationAction should include mouse button information 20127 <rdar://problem/8413165> 20128 https://bugs.webkit.org/show_bug.cgi?id=46060 20129 20130 * MiniBrowser/mac/BrowserWindowController.m: 20131 (decidePolicyForNavigationAction): 20132 (decidePolicyForNewWindowAction): 20133 201342010-09-19 Daniel Bates <dbates@rim.com> 20135 20136 Reviewed by Martin Robinson. 20137 20138 Add unit tests for diffs that delete or modify a change log entry 20139 or describe changes that are far apart 20140 https://bugs.webkit.org/show_bug.cgi?id=46046 20141 20142 Add additional unit tests to test change log diffs that contain 20143 deletions or changes that are far apart from each other in the 20144 ChangeLog file. 20145 20146 * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: 20147 - Added the following unit tests: 20148 "fixChangeLogPatch: [no change] In-place change." 20149 "fixChangeLogPatch: [no change] Remove first entry." 20150 "fixChangeLogPatch: [no change] Remove entry in the middle." 20151 "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)." 20152 201532010-09-19 Sam Weinig <sam@webkit.org> 20154 20155 Reviewed by Anders Carlsson. 20156 20157 Replace WKBundleRangeRef with WKBundleRangeHandleRef. 20158 https://bugs.webkit.org/show_bug.cgi?id=46054 20159 20160 The new one acts like WKBundleNodeHandleRef and allows for getting a 20161 wrapper in a specific world for the handle. 20162 20163 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 20164 (WTR::propertyValue): 20165 (WTR::propertyValueDouble): 20166 (WTR::propertyValueInt): 20167 (WTR::numericWindowPropertyValue): 20168 (WTR::toStr): 20169 (WTR::InjectedBundlePage::shouldBeginEditing): 20170 (WTR::InjectedBundlePage::shouldEndEditing): 20171 (WTR::InjectedBundlePage::shouldInsertNode): 20172 (WTR::InjectedBundlePage::shouldInsertText): 20173 (WTR::InjectedBundlePage::shouldDeleteRange): 20174 (WTR::InjectedBundlePage::shouldChangeSelectedRange): 20175 (WTR::InjectedBundlePage::shouldApplyStyle): 20176 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 20177 201782010-09-19 Kent Tamura <tkent@chromium.org> 20179 20180 Unreviewed. Fix WebGL test regressions by r67809. 20181 20182 * DumpRenderTree/chromium/WebPreferences.cpp: 20183 (WebPreferences::applyTo): Call setExperimentalWebGLEnabled(). 20184 201852010-09-19 Kent Tamura <tkent@chromium.org> 20186 20187 Reviewed by Adam Barth. 20188 20189 [DRT/Chromium] Fix a WebSettings handling bug 20190 https://bugs.webkit.org/show_bug.cgi?id=45945 20191 20192 Before this change, Chromium DRT reset WebSettings for every new 20193 window. It was wrong. 20194 If new window is not the first one, we have to apply the same 20195 settings as the first window. So, we introduce WebPreference to 20196 store the current settings, and apply it to new windows. It's same 20197 as test_shell's behavior. 20198 20199 * DumpRenderTree/DumpRenderTree.gypi: 20200 * DumpRenderTree/chromium/LayoutTestController.cpp: 20201 Use WebPreferences instead of WebSettings. 20202 (LayoutTestController::setUserStyleSheetEnabled): 20203 (LayoutTestController::setUserStyleSheetLocation): 20204 (LayoutTestController::setAuthorAndUserStylesEnabled): 20205 (LayoutTestController::setPopupBlockingEnabled): 20206 (LayoutTestController::disableImageLoading): 20207 (LayoutTestController::setJavaScriptCanAccessClipboard): 20208 (LayoutTestController::setXSSAuditorEnabled): 20209 (LayoutTestController::setAllowUniversalAccessFromFileURLs): 20210 (LayoutTestController::setAllowFileAccessFromFileURLs): 20211 (LayoutTestController::overridePreference): 20212 (LayoutTestController::setEditingBehavior): 20213 * DumpRenderTree/chromium/TestShell.cpp: 20214 (TestShell::resetWebSettings): Use WebPreferences. 20215 (TestShell::runFileTest): ditto. 20216 (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView. 20217 * DumpRenderTree/chromium/TestShell.h: 20218 (TestShell::preferences): 20219 (TestShell::applyPreferences): 20220 * DumpRenderTree/chromium/WebPreferences.cpp: Added. 20221 * DumpRenderTree/chromium/WebPreferences.h: Added. 20222 202232010-09-18 Prasad Tammana <prasadt@chromium.org> 20224 20225 Reviewed by David Levin. 20226 20227 update-webkit --chromium spitting out a spurious error 20228 https://bugs.webkit.org/show_bug.cgi?id=45868 20229 20230 * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient. 20231 202322010-09-18 Sam Weinig <sam@webkit.org> 20233 20234 Reviewed by Dan Bernstein. 20235 20236 Improve/unify the PageLoadClient interfaces 20237 https://bugs.webkit.org/show_bug.cgi?id=46043 20238 20239 * MiniBrowser/mac/BrowserWindowController.m: 20240 (didStartProvisionalLoadForFrame): 20241 (didReceiveServerRedirectForProvisionalLoadForFrame): 20242 (didFailProvisionalLoadWithErrorForFrame): 20243 (didCommitLoadForFrame): 20244 (didFinishDocumentLoadForFrame): 20245 (didFinishLoadForFrame): 20246 (didFailLoadWithErrorForFrame): 20247 (didReceiveTitleForFrame): 20248 (didFirstLayoutForFrame): 20249 (didFirstVisuallyNonEmptyLayoutForFrame): 20250 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 20251 (WTR::InjectedBundlePage::InjectedBundlePage): 20252 (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): 20253 (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame): 20254 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): 20255 (WTR::InjectedBundlePage::didCommitLoadForFrame): 20256 (WTR::InjectedBundlePage::didFinishLoadForFrame): 20257 (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): 20258 (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): 20259 (WTR::InjectedBundlePage::didReceiveTitleForFrame): 20260 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 20261 * WebKitTestRunner/TestController.cpp: 20262 (WTR::TestController::didReceiveMessageFromInjectedBundle): 20263 (WTR::TestController::didFinishLoadForFrame): 20264 * WebKitTestRunner/TestController.h: 20265 202662010-09-17 Eric Seidel <eric@webkit.org> 20267 20268 Unreviewed. Adding a shell script I use to run the 20269 commit-queue. Now that multiple machines run the cq, 20270 it makes sense to share the script between them. 20271 20272 * EWSTools/start-commit-queue.sh: Added. 20273 202742010-09-17 Brian Weinstein <bweinstein@apple.com> 20275 20276 Reviewed by Jon Honeycutt. 20277 20278 The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are 20279 slightly harder to read, so this reverts the previous background colors for various 20280 states, making it easier to read. 20281 20282 * BuildSlaveSupport/build.webkit.org-config/public_html/default.css: 20283 (.success): 20284 (.failure): 20285 (.warnings): 20286 (.exception): 20287 (.start,.running,td.building): 20288 (.offline,td.offline): 20289 202902010-09-17 Sheriff Bot <webkit.review.bot@gmail.com> 20291 20292 Unreviewed, rolling out r67692. 20293 http://trac.webkit.org/changeset/67692 20294 https://bugs.webkit.org/show_bug.cgi?id=46011 20295 20296 broke layout test dashboard (Requested by johnny_g on 20297 #webkit). 20298 20299 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 20300 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: 20301 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 20302 203032010-09-17 Martin Robinson <mrobinson@igalia.com> 20304 20305 Reviewed by Oliver Hunt. 20306 20307 Style bot complains about cairo forward declaration naming 20308 https://bugs.webkit.org/show_bug.cgi?id=45867 20309 20310 Exclude Cairo forward declarations from indentifiers with underscores checks. 20311 20312 * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations. 20313 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this. 20314 203152010-09-16 Kinuko Yasuda <kinuko@chromium.org> 20316 20317 Reviewed by Ojan Vafai. 20318 20319 Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests 20320 https://bugs.webkit.org/show_bug.cgi?id=45408 20321 20322 This change also tries to remove duplicated upload_results_json methods 20323 in run_webkit_tests.py and json_results_generator.py. 20324 20325 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 20326 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: 20327 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 20328 203292010-09-16 Antonio Gomes <tonikitoo@webkit.org> 20330 20331 Reviewed by Andreas Kling. 20332 20333 [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set. 20334 20335 Recently r67554 changed the way different views use the WebPage class: it was previously being shared between 20336 different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's 20337 were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking 20338 all page specific stuff to the UI. 20339 20340 * QtTestBrowser/launcherwindow.cpp: 20341 (LauncherWindow::initializeView): 20342 * QtTestBrowser/mainwindow.cpp: 20343 (MainWindow::MainWindow): 20344 (MainWindow::buildUI): 20345 (MainWindow::setPage): 20346 * QtTestBrowser/mainwindow.h: 20347 203482010-09-12 Antonio Gomes <tonikitoo@webkit.org> 20349 20350 Reviewed by Andreas Kling. 20351 20352 Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method. 20353 20354 This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView 20355 object will move to the qgraphicsscene instead of the qgraphicsview. 20356 20357 * QtTestBrowser/webview.cpp: 20358 (WebViewGraphicsBased::setPage): 20359 (WebViewGraphicsBased::setResizesToContents): 20360 (WebViewGraphicsBased::resizeEvent): 20361 (WebViewGraphicsBased::animatedFlip): 20362 * QtTestBrowser/webview.h: 20363 (WebViewGraphicsBased::setItemCacheMode): 20364 (WebViewGraphicsBased::itemCacheMode): 20365 203662010-09-12 Antonio Gomes <tonikitoo@webkit.org> 20367 20368 Reviewed by Andreas Kling. 20369 20370 Moved setYRotation method body out of the class (WebViewGraphicsBased) definition. 20371 20372 We usually separate methods whose body are larger than a few lines from the class definition. 20373 20374 * QtTestBrowser/webview.h: 20375 (WebViewGraphicsBased::yRotation): 20376 (WebViewGraphicsBased::setYRotation): 20377 203782010-09-12 Antonio Gomes <tonikitoo@webkit.org> 20379 20380 Reviewed by Andreas Kling. 20381 20382 Make initializeView method of LauncherWindow private. 20383 20384 No one else needs to be able to call it but LauncherWindow. 20385 Also moving the declation of isGraphicsBased method down in the same file, in order 20386 to better group related methods. 20387 20388 * QtTestBrowser/launcherwindow.h: 20389 203902010-09-12 Antonio Gomes <tonikitoo@webkit.org> 20391 20392 Reviewed by Andreas Kling. 20393 20394 Make the getter 'page' method of MainWindow const. 20395 20396 * QtTestBrowser/mainwindow.cpp: 20397 (MainWindow::page): 20398 * QtTestBrowser/mainwindow.h: 20399 204002010-09-12 Antonio Gomes <tonikitoo@webkit.org> 20401 20402 Reviewed by Andreas Kling. 20403 20404 Remove useless parameter from MainWindow class' constructor. 20405 20406 The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also 20407 not referred in the constructor body and does not make much sense. 20408 20409 * QtTestBrowser/mainwindow.cpp: 20410 (MainWindow::MainWindow): 20411 * QtTestBrowser/mainwindow.h: 20412 204132010-09-15 Tony Chang <tony@chromium.org> 20414 20415 Reviewed by Kent Tamura. 20416 20417 [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations 20418 https://bugs.webkit.org/show_bug.cgi?id=42151 20419 20420 * DumpRenderTree/chromium/LayoutTestController.cpp: 20421 (LayoutTestController::LayoutTestController): 20422 (WorkItemLoadHTMLString::WorkItemLoadHTMLString): 20423 (WorkItemLoadHTMLString::run): 20424 (LayoutTestController::queueLoadHTMLString): 20425 (LayoutTestController::reset): 20426 (LayoutTestController::setDeferMainResourceDataLoad): 20427 * DumpRenderTree/chromium/LayoutTestController.h: 20428 (LayoutTestController::deferMainResourceDataLoad): 20429 * DumpRenderTree/chromium/WebViewHost.cpp: 20430 (WebViewHost::didCreateDataSource): 20431 204322010-09-16 Adrienne Walker <enne@google.com> 20433 20434 Reviewed by Kenneth Russell. 20435 20436 Add script to synchronize WebKit and Khronos WebGL tests 20437 https://bugs.webkit.org/show_bug.cgi?id=42336 20438 20439 * Scripts/update-webgl-conformance-tests: Added. 20440 * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added. 20441 * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added. 20442 204432010-09-16 Sam Weinig <sam@webkit.org> 20444 20445 Reviewed by Anders Carlsson. 20446 20447 Add support for sending synchronous messages from the InjectedBundle to the WKContext 20448 <rdar://problem/8365320> 20449 https://bugs.webkit.org/show_bug.cgi?id=44785 20450 20451 * MiniBrowser/mac/AppDelegate.m: 20452 (didReceiveSynchronousMessageFromInjectedBundle): 20453 (-[BrowserAppDelegate init]): 20454 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 20455 (didCreatePage): 20456 * WebKitTestRunner/TestController.cpp: 20457 (WTR::TestController::initialize): 20458 204592010-09-16 Leonid Ebril <leonid.ebril@nokia.com> 20460 20461 Reviewed by Andreas Kling. 20462 20463 [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform. 20464 https://bugs.webkit.org/show_bug.cgi?id=45885 20465 20466 Avoid creation of an additional window for screenshot to prevent overlapping with original window. 20467 20468 * QtTestBrowser/launcherwindow.cpp: 20469 (LauncherWindow::screenshot): 20470 204712010-09-16 Anders Carlsson <andersca@apple.com> 20472 20473 Fix clang++ build. 20474 20475 * MiniBrowser/mac/BrowserWindowController.m: 20476 (-[BrowserWindowController zoomIn:]): 20477 (-[BrowserWindowController zoomOut:]): 20478 (-[BrowserWindowController resetZoom:]): 20479 Remove trailing semicolons. 20480 204812010-09-16 Sheriff Bot <webkit.review.bot@gmail.com> 20482 20483 Unreviewed, rolling out r67628. 20484 http://trac.webkit.org/changeset/67628 20485 https://bugs.webkit.org/show_bug.cgi?id=45904 20486 20487 broke the build (Requested by eric_carlson on #webkit). 20488 20489 * DumpRenderTree/gtk/EventSender.cpp: 20490 (contextClickCallback): 20491 204922010-09-16 Balazs Kelemen <kbalazs@webkit.org> 20493 20494 Unreviewed. 20495 20496 Adding myself as a comitter. 20497 20498 * Scripts/webkitpy/common/config/committers.py: 20499 205002010-09-15 Philippe Normand <pnormand@igalia.com> 20501 20502 Reviewed by Eric Carlson. 20503 20504 [GTK] enhanced context menu for media elements 20505 https://bugs.webkit.org/show_bug.cgi?id=45021 20506 20507 EventSender::contextClick() now returns an array of js 20508 objects. Each object has a title property and a click() method. 20509 20510 * DumpRenderTree/gtk/EventSender.cpp: 20511 (getMenuItemTitleCallback): 20512 (setMenuItemTitleCallback): 20513 (menuItemClickCallback): 20514 (getMenuItemClass): 20515 (contextClickCallback): 20516 205172010-09-14 Philippe Normand <pnormand@igalia.com> 20518 20519 Reviewed by Eric Carlson and Martin Robinson. 20520 20521 [GTK] eventSender.contextClick() should return the contents of the context menu 20522 https://bugs.webkit.org/show_bug.cgi?id=39102 20523 20524 Make the eventSender use the new private WebKitGtk+ API to 20525 retrieve the context-menu item titles and store them in an array. 20526 20527 * DumpRenderTree/gtk/EventSender.cpp: 20528 (contextClickCallback): 20529 205302010-09-16 Eric Uhrhane <ericu@chromium.org> 20531 20532 Reviewed by Jian Li. 20533 20534 Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM. 20535 https://bugs.webkit.org/show_bug.cgi?id=45798 20536 20537 * Scripts/build-webkit: 20538 205392010-09-16 Robert Hogan <robert@webkit.org> 20540 20541 Reviewed by Antonio Gomes. 20542 20543 [Qt] Support globalhistory tests 20544 https://bugs.webkit.org/show_bug.cgi?id=45774 20545 20546 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 20547 (WebCore::isGlobalHistoryTest): 20548 (WebCore::DumpRenderTree::open): 20549 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 20550 (LayoutTestController::reset): 20551 (LayoutTestController::dumpHistoryCallbacks): 20552 (LayoutTestController::removeAllVisitedLinks): 20553 * DumpRenderTree/qt/LayoutTestControllerQt.h: 20554 205552010-09-10 Tony Chang <tony@chromium.org> 20556 20557 Reviewed by Eric Seidel. 20558 20559 deduplicate-tests should be runnable from any WebKit directory 20560 https://bugs.webkit.org/show_bug.cgi?id=44709 20561 20562 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: 20563 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 20564 205652010-09-15 Tony Chang <tony@chromium.org> 20566 20567 Reviewed by Kent Tamura. 20568 20569 [chromium] sort testing methods in DRT 20570 https://bugs.webkit.org/show_bug.cgi?id=45850 20571 20572 * DumpRenderTree/chromium/EventSender.cpp: 20573 (EventSender::EventSender): 20574 * DumpRenderTree/chromium/LayoutTestController.cpp: 20575 (LayoutTestController::LayoutTestController): 20576 * DumpRenderTree/chromium/TextInputController.cpp: 20577 (TextInputController::TextInputController): 20578 205792010-09-15 Mihai Parparita <mihaip@chromium.org> 20580 20581 Reviewed by Adam Barth. 20582 20583 CQ status shows items out of order 20584 https://bugs.webkit.org/show_bug.cgi?id=45846 20585 20586 Only group consecutive status items with the same patch ID into the same 20587 group, so that overall item ordering is preserved. 20588 20589 Also don't indent status items that only have a single item in their 20590 group. 20591 20592 * QueueStatusServer/handlers/queuestatus.py: 20593 * QueueStatusServer/templates/includes/singlequeuestatus.html: Added. 20594 * QueueStatusServer/templates/queuestatus.html: 20595 205962010-09-15 Eric Seidel <eric@webkit.org> 20597 20598 Reviewed by Adam Barth. 20599 20600 Add queue start/stop messages 20601 https://bugs.webkit.org/show_bug.cgi?id=45853 20602 20603 I ended up needing to clean up a bunch of our unit testing 20604 in order to test this new code path nicely. 20605 20606 There are also a few PEP8 changes needed to pass check-webkit-style. 20607 20608 * Scripts/webkitpy/tool/bot/queueengine.py: 20609 * Scripts/webkitpy/tool/bot/queueengine_unittest.py: 20610 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 20611 * Scripts/webkitpy/tool/commands/queues.py: 20612 * Scripts/webkitpy/tool/commands/queues_unittest.py: 20613 * Scripts/webkitpy/tool/commands/queuestest.py: 20614 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 20615 206162010-09-15 Simon Fraser <simon.fraser@apple.com> 20617 20618 https://bugs.webkit.org/show_bug.cgi?id=45849 20619 WKURLCreateWithCFURL crashes with null url 20620 20621 Fix MiniBrowser crash when the url is not parseable. 20622 20623 * MiniBrowser/mac/BrowserWindowController.m: 20624 (-[BrowserWindowController fetch:]): 20625 206262010-09-15 Patrick Gansterer <paroga@paroga.com> 20627 20628 Unreviewed. 20629 20630 Adding myself to the committers list. 20631 20632 * Scripts/webkitpy/common/config/committers.py: 20633 206342010-09-14 Eric Seidel <eric@webkit.org> 20635 20636 Reviewed by Adam Barth. 20637 20638 Make it possible to run more than one commit-queue instance 20639 https://bugs.webkit.org/show_bug.cgi?id=45786 20640 20641 Mostly we need to make sure the two (or more) instances get 20642 different patches to work on. To do this, I re-worked 20643 the code responsible for getting the next work item to 20644 round trip through the status server. The status server only 20645 vends patches from the work items list, only if those patches 20646 have not had status reported for them in the last hour. 20647 20648 This is another step towards making all queues go through the 20649 status server, thus making it possible to run more than one 20650 instance of various EWS bots (as requested in bug 44292). 20651 20652 The webkitpy changes are already covered by existing unit tests. 20653 The QueueStatusSever sadly has no testing infrastructure yet. :( 20654 20655 * QueueStatusServer/handlers/nextpatch.py: Added. 20656 * QueueStatusServer/index.yaml: 20657 * QueueStatusServer/main.py: 20658 * Scripts/webkitpy/tool/commands/queues.py: 20659 206602010-09-15 Mihai Parparita <mihaip@chromium.org> 20661 20662 Reviewed by Tony Chang. 20663 20664 NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html 20665 https://bugs.webkit.org/show_bug.cgi?id=45791 20666 20667 Force filenames to be raw bytes before running difflib.unified_diff. 20668 20669 * Scripts/webkitpy/layout_tests/port/base.py: 20670 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 20671 206722010-09-15 Simon Hausmann <simon.hausmann@nokia.com> 20673 20674 Reviewed by Tor Arne Vestbø. 20675 20676 [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled 20677 https://bugs.webkit.org/show_bug.cgi?id=35247 20678 20679 The main issue when changing the views is that the plugins and any other components that 20680 depend on view specific attributes such as the native window id are not teared down. 20681 Even if we had a tear-down procedure, we'd have to re-initialize the plugin after 20682 switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so 20683 we decided to work around this in QtTestBrowser by making toggling between QWebView 20684 and QGraphicsWebView also re-create the page. 20685 20686 * QtTestBrowser/launcherwindow.cpp: 20687 (LauncherWindow::initializeView): 20688 * QtTestBrowser/mainwindow.h: 20689 206902010-09-14 Mihai Parparita <mihaip@chromium.org> 20691 20692 Reviewed by Adam Barth. 20693 20694 Send webkit accessibility notifications to Chromium 20695 https://bugs.webkit.org/show_bug.cgi?id=45156 20696 20697 Move printf inside shouldDumpAccessibilityNotifications check. 20698 20699 * DumpRenderTree/chromium/WebViewHost.cpp: 20700 (WebViewHost::postAccessibilityNotification): 20701 207022010-09-14 Tony Chang <tony@chromium.org> 20703 20704 Reviewed by Kent Tamura. 20705 20706 [chromium] fix http/tests/security/local-user-CSS-from-remote.html 20707 https://bugs.webkit.org/show_bug.cgi?id=45788 20708 20709 * DumpRenderTree/chromium/LayoutTestController.cpp: 20710 (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome 20711 207122010-09-14 Tony Chang <tony@chromium.org> 20713 20714 Reviewed by Ojan Vafai. 20715 20716 [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed 20717 https://bugs.webkit.org/show_bug.cgi?id=45768 20718 20719 * DumpRenderTree/chromium/TestShell.cpp: 20720 (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward. 20721 207222010-09-14 Kevin Ollivier <kevino@theolliviers.com> 20723 20724 [wx] Build fix, add newly added directories to the directory list. 20725 20726 * wx/build/settings.py: 20727 207282010-09-14 Sam Weinig <sam@webkit.org> 20729 20730 Reviewed by Anders Carlsson. 20731 20732 Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef. 20733 https://bugs.webkit.org/show_bug.cgi?id=45785 20734 20735 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 20736 (WTR::propertyValue): 20737 (WTR::numericWindowPropertyValue): 20738 (WTR::dumpPath): 20739 (WTR::toStr): 20740 (WTR::operator<<): 20741 (WTR::InjectedBundlePage::InjectedBundlePage): 20742 (WTR::InjectedBundlePage::shouldInsertNode): 20743 (WTR::InjectedBundlePage::shouldBeginEditing): 20744 (WTR::InjectedBundlePage::shouldEndEditing): 20745 (WTR::InjectedBundlePage::shouldInsertText): 20746 (WTR::InjectedBundlePage::shouldDeleteRange): 20747 (WTR::InjectedBundlePage::shouldChangeSelectedRange): 20748 (WTR::InjectedBundlePage::shouldApplyStyle): 20749 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 20750 207512010-09-14 Adam Barth <abarth@webkit.org> 20752 20753 Fix two typos in commit-queue. The first is harmless. The second 20754 causes the queue to reject patches when the build is broken. :( 20755 20756 * Scripts/webkitpy/tool/commands/queues.py: 20757 * Scripts/webkitpy/tool/commands/queues_unittest.py: 20758 207592010-09-14 Chris Guillory <chris.guillory@google.com> 20760 20761 Reviewed by Chris Fleizach. 20762 20763 Send all accessibility notifications to Chromium. 20764 https://bugs.webkit.org/show_bug.cgi?id=45156 20765 20766 * DumpRenderTree/chromium/WebViewHost.cpp: 20767 (WebViewHost::postAccessibilityNotification): 20768 * DumpRenderTree/chromium/WebViewHost.h: 20769 207702010-09-14 Adam Barth <abarth@webkit.org> 20771 20772 Reviewed by Eric Seidel. 20773 20774 commit-queue is slow during the day 20775 https://bugs.webkit.org/show_bug.cgi?id=45780 20776 20777 Thanks to the new logging, we've noticed that checkout-is-out-of-date 20778 errors in the first pass of landing don't retry the land. Instead, 20779 they're treated as failures and cause the commit-queue to do two more 20780 builds before really trying to land the patch. Worse, in the second 20781 build, we can get bitten by a flaky test. 20782 20783 This patch takes a slightly different approach to the commit-queue's 20784 main control logic. We now use a separate subprocess for building and 20785 testing and for landing. This means we should very rarely see the 20786 checkout-is-out-of-date error, and when we do see it, we should retry 20787 more quickly. If my understanding is correct, this should be a big 20788 speed win for the commit-queue. 20789 20790 * Scripts/webkitpy/tool/commands/download.py: 20791 * Scripts/webkitpy/tool/commands/queues.py: 20792 * Scripts/webkitpy/tool/commands/queues_unittest.py: 20793 207942010-09-14 Tony Chang <tony@chromium.org> 20795 20796 Reviewed by Dimitri Glazkov. 20797 20798 [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme 20799 https://bugs.webkit.org/show_bug.cgi?id=45762 20800 20801 * DumpRenderTree/chromium/LayoutTestController.cpp: 20802 (LayoutTestController::LayoutTestController): 20803 (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): 20804 * DumpRenderTree/chromium/LayoutTestController.h: 20805 208062010-09-14 Csaba Osztrogonác <ossy@webkit.org> 20807 20808 Adding myself as a reviewer. 20809 20810 * Scripts/webkitpy/common/config/committers.py: 20811 208122010-09-14 Zoltan Horvath <zoltan@webkit.org> 20813 20814 Reviewed by Kenneth Rohde Christiansen. 20815 20816 [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist 20817 https://bugs.webkit.org/show_bug.cgi?id=45736 20818 20819 Build-webkit has showed a warning when WebKitBuild didn't exist, add 20820 an additional condition to avoid it. 20821 20822 * Scripts/build-webkit: 20823 208242010-09-13 Eric Seidel <eric@webkit.org> 20825 20826 Reviewed by Adam Barth. 20827 20828 commit-queue should log when it's retrying due to checkout out of date error 20829 https://bugs.webkit.org/show_bug.cgi?id=45725 20830 20831 This will allow us to better track how often we see these errors 20832 and how long it takes the queue to recover from them. 20833 20834 In order to pass the tests, I had to correct an error 20835 from a previous change. The UnitTestPort should not have 20836 ever been using the base port method as that will read 20837 a file from disk. If the unit tests haven't passed the contents 20838 it should raise an IOError as though the file doesn't exist. 20839 20840 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 20841 * Scripts/webkitpy/tool/commands/queues.py: 20842 * Scripts/webkitpy/tool/commands/queues_unittest.py: 20843 208442010-09-13 Mihai Parparita <mihaip@chromium.org> 20845 20846 Reviewed by Adam Barth. 20847 20848 Upload results when cq patch landing fails 20849 https://bugs.webkit.org/show_bug.cgi?id=45683 20850 20851 Include script errors when CommitQueue._land fails. 20852 20853 * Scripts/webkitpy/tool/commands/queues.py: 20854 208552010-09-13 Chris Fleizach <cfleizach@apple.com> 20856 20857 Reviewed by David Kilzer. 20858 20859 AX: accessibilityIsIgnored is returning nil when return value expects a BOOL 20860 https://bugs.webkit.org/show_bug.cgi?id=45548 20861 20862 * DumpRenderTree/AccessibilityUIElement.cpp: 20863 (isIgnoredCallback): 20864 (AccessibilityUIElement::getJSClass): 20865 * DumpRenderTree/AccessibilityUIElement.h: 20866 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 20867 (AccessibilityUIElement::isIgnored): 20868 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 20869 (AccessibilityUIElement::isIgnored): 20870 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 20871 (AccessibilityUIElement::isIgnored): 20872 208732010-09-13 Csaba Osztrogonác <ossy@webkit.org> 20874 20875 Reviewed by Andreas Kling. 20876 20877 jscPath() is incorrect in Windows' cmd.exe shell 20878 https://bugs.webkit.org/show_bug.cgi?id=45651 20879 20880 * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows. 20881 208822010-09-13 Chris Fleizach <cfleizach@apple.com> 20883 20884 Reviewed by Darin Adler. 20885 20886 REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject 20887 https://bugs.webkit.org/show_bug.cgi?id=43807 20888 20889 * DumpRenderTree/AccessibilityUIElement.cpp: 20890 (textMarkerForPointCallback): 20891 (AccessibilityUIElement::textMarkerForPoint): 20892 (AccessibilityUIElement::getJSClass): 20893 * DumpRenderTree/AccessibilityUIElement.h: 20894 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 20895 (AccessibilityUIElement::textMarkerForPoint): 20896 208972010-09-13 Andreas Kling <andreas.kling@nokia.com> 20898 20899 Reviewed by Kenneth Rohde Christiansen. 20900 20901 [Qt] build-webkit: Add --v8 option to build against V8 20902 20903 Note that V8 is picked up from QtScript, so this currently requires building 20904 against the experimental qt-script-v8 branch. 20905 20906 * Scripts/build-webkit: 20907 209082010-09-13 Hans Wennborg <hans@chromium.org> 20909 20910 Reviewed by Jeremy Orlow. 20911 20912 Add WebDeviceOrientationClientMock::create() and use it from DRT. 20913 https://bugs.webkit.org/show_bug.cgi?id=45650 20914 20915 Do not use the WebDeviceOrientationClientMock constructor directly, 20916 but use the create() member function. 20917 20918 This should fix the linker errors for the multi-DLL Chromium DRT build. 20919 20920 * DumpRenderTree/chromium/LayoutTestController.cpp: 20921 (LayoutTestController::setMockDeviceOrientation): 20922 (LayoutTestController::deviceOrientationClient): 20923 209242010-08-27 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org> 20925 20926 Reviewed by Antti Koivisto. 20927 20928 Add support for testing the viewport meta tag algorithm, 20929 based on the following draft spec: 20930 20931 http://people.opera.com/rune/TR/ED-css-viewport-20100806/ 20932 20933 Add common handling of viewport meta tag based on new Opera spec 20934 https://bugs.webkit.org/show_bug.cgi?id=44201 20935 20936 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 20937 (LayoutTestController::dumpConfigurationForViewport): 20938 * DumpRenderTree/qt/LayoutTestControllerQt.h: 20939 209402010-09-12 Kent Tamura <tkent@chromium.org> 20941 20942 Reviewed by Tony Chang. 20943 20944 [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h 20945 https://bugs.webkit.org/show_bug.cgi?id=45517 20946 20947 Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h 20948 20949 * DumpRenderTree/chromium/ImageDiff.cpp: 20950 (Image::craeteFromStdin): 20951 (Image::createFromFilename): 20952 (diffImages): 20953 * DumpRenderTree/chromium/TestShell.cpp: 20954 (TestShell::dumpImage): 20955 209562010-09-10 MORITA Hajime <morrita@google.com> 20957 20958 Reviewed by Tony Chang. 20959 20960 [Chromium] Implement textInputController.hasSpellingMarker() for Chromium 20961 https://bugs.webkit.org/show_bug.cgi?id=45441 20962 20963 Added TextInputController::hasSpellingMarker(). 20964 20965 * DumpRenderTree/chromium/TextInputController.cpp: 20966 (TextInputController::TextInputController): 20967 (TextInputController::hasSpellingMarker): 20968 * DumpRenderTree/chromium/TextInputController.h: 20969 209702010-09-12 Dirk Pranke <dpranke@chromium.org> 20971 20972 Unreviewed, build fix. 20973 20974 My last change accidentally contained a local change to the 20975 rebaselinig script; webkit-patch land picked it up without telling 20976 me and committed it :( 20977 20978 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 20979 209802010-09-11 Maciej Stachowiak <mjs@apple.com> 20981 20982 Reviewed by Anders Carlsson. 20983 20984 Attempt to fix Windows MiniBrowser build (untested) 20985 https://bugs.webkit.org/show_bug.cgi?id=45609 20986 20987 * MiniBrowser/win/BrowserView.cpp: 20988 (runJavaScriptConfirm): 20989 (runJavaScriptPrompt): 20990 209912010-09-11 Sam Weinig <sam@webkit.org> 20992 20993 Reviewed by Maciej Stachowiak. 20994 20995 Fix zoom related tests when testing WebKit2. 20996 20997 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: 20998 (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same. 20999 210002010-09-11 Sam Weinig <sam@webkit.org> 21001 21002 Reviewed by Dan Bernstein. 21003 21004 Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:] 21005 <rdar://problem/8359252> 21006 https://bugs.webkit.org/show_bug.cgi?id=45605 21007 21008 * MiniBrowser/mac/BrowserWindowController.m: 21009 (setStatusText): 21010 (contentsSizeChanged): 21011 (-[BrowserWindowController awakeFromNib]): 21012 * MiniBrowser/win/BrowserView.cpp: 21013 (runJavaScriptConfirm): 21014 (runJavaScriptPrompt): 21015 (setStatusText): 21016 (contentsSizeChanged): 21017 (BrowserView::create): 21018 * WebKitTestRunner/TestController.cpp: 21019 (WTR::createOtherPage): 21020 (WTR::TestController::initialize): 21021 210222010-09-11 Sam Weinig <sam@webkit.org> 21023 21024 Reviewed by Dan Bernstein. 21025 21026 Add callback mechanism for the getting the source of a frame 21027 <rdar://problem/8364681> 21028 https://bugs.webkit.org/show_bug.cgi?id=45604 21029 21030 Add ability to dump the main frame's source to the console. 21031 21032 * MiniBrowser/mac/BrowserWindowController.h: 21033 * MiniBrowser/mac/BrowserWindowController.m: 21034 (-[BrowserWindowController dumpSourceToConsole:]): 21035 * MiniBrowser/mac/MainMenu.xib: 21036 210372010-09-11 Eric Seidel <eric@webkit.org> 21038 21039 Reviewed by Adam Barth. 21040 21041 Remove unneeded Empty Queue messages 21042 https://bugs.webkit.org/show_bug.cgi?id=45602 21043 21044 We already have a /gc job to delete these. 21045 recentstatus.py is already smart enough to use the 21046 most recent of the workitems last update or the most recent status, 21047 so removing these should not change the _last_status_date() return 21048 value more than a few milliseconds. 21049 21050 These messages just spam the recent status log. 21051 21052 * Scripts/webkitpy/tool/commands/queues.py: 21053 210542010-09-11 Mihai Parparita <mihaip@chromium.org> 21055 21056 Reviewed by Adam Barth. 21057 21058 Fix Python exception when generating synthetic patch IDs 21059 https://bugs.webkit.org/show_bug.cgi?id=45592 21060 21061 Can't concatenate strings and numbers directly. 21062 21063 * QueueStatusServer/handlers/queuestatus.py: 21064 210652010-09-11 Mihai Parparita <mihaip@chromium.org> 21066 21067 Reviewed by Adam Barth. 21068 21069 Group statuses in queue status by patch ID 21070 https://bugs.webkit.org/show_bug.cgi?id=45588 21071 21072 Group statuses by patch ID so that the status page is easier 21073 to scan. 21074 21075 * QueueStatusServer/handlers/queuestatus.py: 21076 * QueueStatusServer/stylesheets/dashboard.css: 21077 (.status-group): 21078 (.status-bug): 21079 (.status-group ul): 21080 (.status-group ul li): 21081 (.status-group ul li:hover): 21082 (.status-cell): 21083 (.status-cell:hover): 21084 (.status-cell.pass): 21085 (.status-cell.fail): 21086 (.status-cell.pending): 21087 (.status-cell.error): 21088 * QueueStatusServer/templates/dashboard.html: 21089 * QueueStatusServer/templates/queuestatus.html: 21090 210912010-09-11 Mihai Parparita <mihaip@chromium.org> 21092 21093 Reviewed by Tony Chang. 21094 21095 Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT 21096 https://bugs.webkit.org/show_bug.cgi?id=45479 21097 21098 Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after 21099 implementation in ResourceLoadDelegate in the Mac port). 21100 21101 * DumpRenderTree/chromium/LayoutTestController.cpp: 21102 (LayoutTestController::LayoutTestController): 21103 (LayoutTestController::dumpResourceResponseMIMETypes): 21104 (LayoutTestController::reset): 21105 * DumpRenderTree/chromium/LayoutTestController.h: 21106 (LayoutTestController::setShouldDumpResourceResponseMIMETypes): 21107 (LayoutTestController::shouldDumpResourceResponseMIMETypes): 21108 * DumpRenderTree/chromium/TestShell.h: 21109 (TestShell::shouldDumpResourceResponseMIMETypes): 21110 * DumpRenderTree/chromium/WebViewHost.cpp: 21111 (WebViewHost::didReceiveResponse): 21112 211132010-09-11 Eric Seidel <eric@webkit.org> 21114 21115 Reviewed by Adam Barth. 21116 21117 queues.webkit.org should expose /remote_api for data upload/download 21118 https://bugs.webkit.org/show_bug.cgi?id=45559 21119 21120 * QueueStatusServer/app.yaml: 21121 - /remote_api is a standard app-engine service which allows use of 21122 the bulk uploader for data upload/download. Exposing this 21123 (for admin access only) allows us to use 21124 211252010-09-10 Sam Weinig <sam@webkit.org> 21126 21127 Reviewed by Dan Bernstein. 21128 21129 Add zoom support to WebKit2 API 21130 <rdar://problem/7660657> 21131 https://bugs.webkit.org/show_bug.cgi?id=45585 21132 21133 - Add zoom options to MiniBrowser that mimic Safari's options using 21134 the new WebKit2 zoom APIs. 21135 - Switch uses of float for the zoom APIs to use double. 21136 21137 * MiniBrowser/mac/BrowserWindowController.h: 21138 * MiniBrowser/mac/BrowserWindowController.m: 21139 (-[BrowserWindowController initWithPageNamespace:]): 21140 (-[BrowserWindowController validateMenuItem:]): 21141 (-[BrowserWindowController validateUserInterfaceItem:]): 21142 (-[BrowserWindowController currentZoomFactor]): 21143 (-[BrowserWindowController setCurrentZoomFactor:]): 21144 (-[BrowserWindowController canZoomIn]): 21145 (-[BrowserWindowController zoomIn:]): 21146 (-[BrowserWindowController canZoomOut]): 21147 (-[BrowserWindowController zoomOut:]): 21148 (-[BrowserWindowController canResetZoom]): 21149 (-[BrowserWindowController resetZoom:]): 21150 (-[BrowserWindowController toggleZoomMode:]): 21151 * MiniBrowser/mac/MainMenu.xib: 21152 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: 21153 (WTR::EventSendingController::textZoomIn): 21154 (WTR::EventSendingController::textZoomOut): 21155 (WTR::EventSendingController::zoomPageIn): 21156 (WTR::EventSendingController::zoomPageOut): 21157 211582010-09-10 Robert Hogan <robert@webkit.org> 21159 21160 Reviewed by Andreas Kling. 21161 21162 [Qt] Fix crash in DRT in standalone mode 21163 21164 https://bugs.webkit.org/show_bug.cgi?id=45454 21165 21166 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 21167 (WebCore::DumpRenderTree::loadNextTestInStandAloneMode): 21168 211692010-09-10 Sam Weinig <sam@webkit.org> 21170 21171 Reviewed by Darin Adler. 21172 21173 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom. 21174 Precursor to <rdar://problem/7660657> 21175 https://bugs.webkit.org/show_bug.cgi?id=45522 21176 21177 Update for changes to the Bundle API to allow separate control of page and text zoom 21178 levels. 21179 21180 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: 21181 (WTR::EventSendingController::textZoomIn): 21182 (WTR::EventSendingController::textZoomOut): 21183 (WTR::EventSendingController::zoomPageIn): 21184 (WTR::EventSendingController::zoomPageOut): 21185 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 21186 (WTR::InjectedBundlePage::reset): 21187 211882010-09-10 Yael Aharon <yael.aharon@nokia.com> 21189 21190 Reviewed by Andreas Kling. 21191 21192 [Qt] Support click event for notifications 21193 https://bugs.webkit.org/show_bug.cgi?id=44836 21194 21195 Add support for simulateDesktopNotificationClick by calling 21196 back to DumpRenderTreeSupportQt.cpp. 21197 21198 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 21199 (LayoutTestController::simulateDesktopNotificationClick): 21200 * DumpRenderTree/qt/LayoutTestControllerQt.h: 21201 212022010-09-10 Mihai Parparita <mihaip@chromium.org> 21203 21204 Reviewed by Eric Seidel. 21205 21206 Update queue status when patches fail their first land attempt 21207 https://bugs.webkit.org/show_bug.cgi?id=45583 21208 21209 Add a few more _update_status calls to make it more obvious if a patch is 21210 being retried because tests failed. 21211 21212 * Scripts/webkitpy/tool/commands/queues.py: 21213 212142010-09-10 Balazs Kelemen <kb@inf.u-szeged.hu> 21215 21216 Reviewed by Andreas Kling. 21217 21218 [Qt] MiniBrowser crashes with multiply windows when closing one of them 21219 https://bugs.webkit.org/show_bug.cgi?id=45536 21220 21221 * MiniBrowser/qt/BrowserView.cpp: 21222 (BrowserView::BrowserView): Reference the context instead of adopting it 21223 because it can be shared across different views. 21224 212252010-09-10 Tony Chang <tony@chromium.org> 21226 21227 Unreviewed, rolling out r67241. 21228 http://trac.webkit.org/changeset/67241 21229 https://bugs.webkit.org/show_bug.cgi?id=44709 21230 21231 Accidentally committed. 21232 21233 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: 21234 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 21235 212362010-09-10 Tony Chang <tony@chromium.org> 21237 21238 Reviewed by Ojan Vafai. 21239 21240 deduplicate-tests should be runnable from any WebKit directory 21241 https://bugs.webkit.org/show_bug.cgi?id=44709 21242 21243 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: 21244 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 21245 212462010-09-10 Tony Chang <tony@chromium.org> 21247 21248 Unreviewed, rolling out r67216. 21249 http://trac.webkit.org/changeset/67216 21250 https://bugs.webkit.org/show_bug.cgi?id=44709 21251 21252 Broke 21253 21254 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: 21255 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 21256 212572010-09-10 Tony Chang <tony@chromium.org> 21258 21259 Reviewed by Ojan Vafai. 21260 21261 deduplicate-tests should be runnable from any WebKit directory 21262 https://bugs.webkit.org/show_bug.cgi?id=44709 21263 21264 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: 21265 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 21266 212672010-09-09 Hans Wennborg <hans@chromium.org> 21268 21269 Reviewed by Jeremy Orlow. 21270 21271 Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree. 21272 https://bugs.webkit.org/show_bug.cgi?id=45460 21273 21274 This enables DumpRenderTree to run layout tests for DeviceOrientation. 21275 21276 Also declare the LayoutTestController destructor out-of-line. 21277 Otherwise the implicit destructor would cause compiler errors because 21278 of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member. 21279 21280 * DumpRenderTree/chromium/LayoutTestController.cpp: 21281 (LayoutTestController::~LayoutTestController): 21282 (LayoutTestController::setMockDeviceOrientation): 21283 (LayoutTestController::deviceOrientationClient): 21284 * DumpRenderTree/chromium/LayoutTestController.h: 21285 * DumpRenderTree/chromium/WebViewHost.cpp: 21286 (WebViewHost::deviceOrientationClient): 21287 * DumpRenderTree/chromium/WebViewHost.h: 21288 212892010-09-09 Sheriff Bot <webkit.review.bot@gmail.com> 21290 21291 Unreviewed, rolling out r67119. 21292 http://trac.webkit.org/changeset/67119 21293 https://bugs.webkit.org/show_bug.cgi?id=45505 21294 21295 Extra newlines in results (Requested by tony^work on #webkit). 21296 21297 * DumpRenderTree/chromium/LayoutTestController.cpp: 21298 (LayoutTestController::LayoutTestController): 21299 (LayoutTestController::reset): 21300 * DumpRenderTree/chromium/LayoutTestController.h: 21301 * DumpRenderTree/chromium/TestShell.h: 21302 * DumpRenderTree/chromium/WebViewHost.cpp: 21303 (printResponseDescription): 21304 (printNodeDescription): 21305 (printRangeDescription): 21306 (WebViewHost::shouldBeginEditing): 21307 (WebViewHost::shouldEndEditing): 21308 (WebViewHost::shouldInsertNode): 21309 (WebViewHost::shouldChangeSelectedRange): 21310 (WebViewHost::shouldDeleteRange): 21311 (WebViewHost::shouldApplyStyle): 21312 (WebViewHost::didBeginEditing): 21313 (WebViewHost::didChangeSelection): 21314 (WebViewHost::didChangeContents): 21315 (WebViewHost::didEndEditing): 21316 (WebViewHost::decidePolicyForNavigation): 21317 (WebViewHost::didCancelClientRedirect): 21318 (WebViewHost::didStartProvisionalLoad): 21319 (WebViewHost::didReceiveServerRedirectForProvisionalLoad): 21320 (WebViewHost::didFailProvisionalLoad): 21321 (WebViewHost::didCommitProvisionalLoad): 21322 (WebViewHost::didFinishDocumentLoad): 21323 (WebViewHost::didHandleOnloadEvents): 21324 (WebViewHost::didFailLoad): 21325 (WebViewHost::didFinishLoad): 21326 (WebViewHost::didChangeLocationWithinPage): 21327 (WebViewHost::willSendRequest): 21328 (WebViewHost::didReceiveResponse): 21329 (WebViewHost::didFinishResourceLoad): 21330 (WebViewHost::didFailResourceLoad): 21331 (WebViewHost::didDisplayInsecureContent): 21332 (WebViewHost::didRunInsecureContent): 21333 (WebViewHost::printFrameDescription): 21334 213352010-09-09 Michael Saboff <msaboff@apple.com> 21336 21337 Unreviewed, adding myself to committers list. 21338 21339 * Scripts/webkitpy/common/config/committers.py: 21340 213412010-09-09 Mihai Parparita <mihaip@chromium.org> 21342 21343 Reviewed by Tony Chang. 21344 21345 Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT 21346 https://bugs.webkit.org/show_bug.cgi?id=45479 21347 21348 Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after 21349 implementation in ResourceLoadDelegate in the Mac port). 21350 21351 * DumpRenderTree/chromium/LayoutTestController.cpp: 21352 (LayoutTestController::LayoutTestController): 21353 (LayoutTestController::dumpResourceResponseMIMETypes): 21354 (LayoutTestController::reset): 21355 * DumpRenderTree/chromium/LayoutTestController.h: 21356 (LayoutTestController::setShouldDumpResourceResponseMIMETypes): 21357 (LayoutTestController::shouldDumpResourceResponseMIMETypes): 21358 * DumpRenderTree/chromium/TestShell.h: 21359 (TestShell::shouldDumpResourceResponseMIMETypes): 21360 * DumpRenderTree/chromium/WebViewHost.cpp: 21361 (WebViewHost::didReceiveResponse): 21362 213632010-09-09 Mihai Parparita <mihaip@chromium.org> 21364 21365 Reviewed by Daniel Bates. 21366 21367 svn-apply tries to delete directories it shouldn't 21368 https://bugs.webkit.org/show_bug.cgi?id=45424 21369 21370 isDirectoryEmptyForRemoval had the wrong check. If an item in the 21371 directory is itself a directory, then the directory is definitely 21372 not empty. 21373 21374 * Scripts/svn-apply: 21375 213762010-09-09 Chris Fleizach <cfleizach@apple.com> 21377 21378 Fixing GTK and windows build failure. 21379 21380 AX: Support AccessibilityTextMarkers in DRT 21381 https://bugs.webkit.org/show_bug.cgi?id=44778 21382 21383 * DumpRenderTree/AccessibilityTextMarker.h: 21384 (AccessibilityTextMarker::platformTextMarker): 21385 (AccessibilityTextMarkerRange::platformTextMarkerRange): 21386 * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: 21387 (AccessibilityTextMarker::platformTextMarker): 21388 (AccessibilityTextMarkerRange::platformTextMarkerRange): 21389 213902010-09-09 Chris Fleizach <cfleizach@apple.com> 21391 21392 Reviewed by David Kilzer. 21393 21394 AX: Support AccessibilityTextMarkers in DRT 21395 https://bugs.webkit.org/show_bug.cgi?id=44778 21396 21397 Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 21398 that WebCore uses when vending information about its VisiblePositions through AX. 21399 21400 There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic 21401 methods for encapsulating and checking equality. 21402 21403 This will allow future bug fixes in the text marker system to be adequately tested. 21404 21405 * DumpRenderTree/AccessibilityTextMarker.cpp: Added. 21406 (toTextMarker): 21407 (isMarkerEqualCallback): 21408 (markerFinalize): 21409 (AccessibilityTextMarker::makeJSAccessibilityTextMarker): 21410 (AccessibilityTextMarker::getJSClass): 21411 (toTextMarkerRange): 21412 (isMarkerRangeEqualCallback): 21413 (markerRangeFinalize): 21414 (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange): 21415 (AccessibilityTextMarkerRange::getJSClass): 21416 * DumpRenderTree/AccessibilityTextMarker.h: Added. 21417 (AccessibilityTextMarker::platformTextMarker): 21418 (AccessibilityTextMarkerRange::platformTextMarkerRange): 21419 (AccessibilityTextMarker::AccessibilityTextMarker): 21420 (AccessibilityTextMarker::~AccessibilityTextMarker): 21421 (AccessibilityTextMarker::isEqual): 21422 (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange): 21423 (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange): 21424 (AccessibilityTextMarkerRange::isEqual): 21425 * DumpRenderTree/AccessibilityUIElement.cpp: 21426 (textMarkerRangeForElementCallback): 21427 (textMarkerRangeLengthCallback): 21428 (textMarkerRangeForMarkersCallback): 21429 (startTextMarkerForTextMarkerRangeCallback): 21430 (endTextMarkerForTextMarkerRangeCallback): 21431 (accessibilityElementForTextMarkerCallback): 21432 (AccessibilityUIElement::textMarkerRangeForElement): 21433 (AccessibilityUIElement::textMarkerRangeLength): 21434 (AccessibilityUIElement::startTextMarkerForTextMarkerRange): 21435 (AccessibilityUIElement::endTextMarkerForTextMarkerRange): 21436 (AccessibilityUIElement::accessibilityElementForTextMarker): 21437 (AccessibilityUIElement::getJSClass): 21438 * DumpRenderTree/AccessibilityUIElement.h: 21439 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 21440 * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added. 21441 (AccessibilityTextMarker::AccessibilityTextMarker): 21442 (AccessibilityTextMarker::~AccessibilityTextMarker): 21443 (AccessibilityTextMarker::isEqual): 21444 (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange): 21445 (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange): 21446 (AccessibilityTextMarkerRange::isEqual): 21447 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 21448 (AccessibilityUIElement::textMarkerRangeForElement): 21449 (AccessibilityUIElement::textMarkerRangeLength): 21450 (AccessibilityUIElement::textMarkerRangeForMarkers): 21451 (AccessibilityUIElement::startTextMarkerForTextMarkerRange): 21452 (AccessibilityUIElement::endTextMarkerForTextMarkerRange): 21453 (AccessibilityUIElement::accessibilityElementForTextMarker): 21454 * DumpRenderTree/win/DumpRenderTree.vcproj: 21455 214562010-08-25 Tony Chang <tony@chromium.org> 21457 21458 Reviewed by Ojan Vafai. 21459 21460 don't delete duplicates needed because of intermediate results 21461 https://bugs.webkit.org/show_bug.cgi?id=44653 21462 21463 Also, output the full path so we can pipe the output to rm. 21464 21465 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: 21466 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 21467 214682010-09-09 Balazs Kelemen <kb@inf.u-szeged.hu> 21469 21470 Reviewed by Andreas Kling. 21471 21472 [Qt] MiniBrowser does not starts properly 21473 https://bugs.webkit.org/show_bug.cgi?id=45459 21474 21475 Do not try set up the first window by calling newWindow on a 21476 newly created BrowserWindow since it creates a new object. 21477 * MiniBrowser/qt/BrowserWindow.cpp: 21478 (BrowserWindow::BrowserWindow): 21479 * MiniBrowser/qt/main.cpp: 21480 (main): 21481 214822010-09-09 Martin Robinson <mrobinson@igalia.com> 21483 21484 Reviewed by Xan Lopez. 21485 21486 [GTK] Get ImageDiff building on Win32 21487 https://bugs.webkit.org/show_bug.cgi?id=45353 21488 21489 * DumpRenderTree/gtk/ImageDiff.cpp: 21490 (main): Switch from using strtok to g_strsplit. 21491 214922010-09-09 Zoltan Horvath <zoltan@webkit.org> 21493 21494 Reviewed by Andreas Kling. 21495 21496 [Qt] Modify load method of MiniBrowser's BrowserView class 21497 https://bugs.webkit.org/show_bug.cgi?id=45442 21498 21499 Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK. 21500 21501 * MiniBrowser/qt/BrowserView.cpp: 21502 (BrowserView::load): 21503 * MiniBrowser/qt/BrowserView.h: 21504 * MiniBrowser/qt/BrowserWindow.cpp: 21505 (BrowserWindow::load): 21506 215072010-09-09 Tony Chang <tony@chromium.org> 21508 21509 Reviewed by Ojan Vafai. 21510 21511 fix show_results in new-run-webkit-tests 21512 https://bugs.webkit.org/show_bug.cgi?id=45413 21513 21514 * Scripts/webkitpy/layout_tests/port/chromium.py: 21515 215162010-09-08 Victor Wang <victorw@chromium.org> 21517 21518 Reviewed by Ojan Vafai. 21519 21520 [Chromium] Fix test results server to make sure 21521 it does not have corrupted data. 21522 21523 results.json file size coulbe be >1M and we split 21524 the data into multiple data store entries in this 21525 case. This patch fixes the issue that the data may 21526 be corrupted if data store error happens in the middle 21527 of saving multiple entries. 21528 21529 https://bugs.webkit.org/show_bug.cgi?id=45063 21530 21531 * TestResultServer/model/datastorefile.py: 21532 215332010-09-08 Peter Varga <pvarga@inf.u-szeged.hu> 21534 21535 Reviewed by Kenneth Rohde Christiansen. 21536 21537 Fix ignoring return value warning in case of gcc 4.4.4 21538 https://bugs.webkit.org/show_bug.cgi?id=45384 21539 21540 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 21541 (testPostURLFile): 21542 If fwrite have written zero byte then the testPostURLFile function 21543 returns with false as tempFile can't be opened. 21544 * DumpRenderTree/qt/ImageDiff.cpp: 21545 (main): 21546 Put fwrite function into an if condition without body to avoid 21547 warning. It is safe because this function writes to the stdout. 21548 215492010-09-08 Satish Sampath <satish@chromium.org> 21550 21551 Unreviewed, adding myself to committers list. 21552 21553 * Scripts/webkitpy/common/config/committers.py: 21554 215552010-09-08 Hans Wennborg <hans@chromium.org> 21556 21557 Unreviewed. 21558 21559 Adding myself as a committer in committers.py. 21560 21561 * Scripts/webkitpy/common/config/committers.py: 21562 215632010-09-08 Zoltan Horvath <zoltan@webkit.org> 21564 21565 Reviewed by Simon Hausmann. 21566 21567 [Qt] Refactor MiniBrowser 21568 https://bugs.webkit.org/show_bug.cgi?id=45173 21569 21570 Split BrowserWindow into two source files and headers. Remove unnecessary header includes. 21571 21572 * MiniBrowser/qt/BrowserView.cpp: Added. 21573 (createNewPage): 21574 (BrowserView::BrowserView): 21575 (BrowserView::resizeEvent): 21576 (BrowserView::load): 21577 (BrowserView::view): 21578 * MiniBrowser/qt/BrowserView.h: Added. 21579 (BrowserView::~BrowserView): 21580 * MiniBrowser/qt/BrowserWindow.cpp: 21581 * MiniBrowser/qt/BrowserWindow.h: 21582 * MiniBrowser/qt/MiniBrowser.pro: 21583 215842010-09-08 Adam Barth <abarth@webkit.org> 21585 21586 Rubber-stamped by Eric Seidel. 21587 21588 Rename DocLoader to CachedResourceLoader because that's what it does. 21589 21590 * Scripts/do-webcore-rename: 21591 215922010-09-07 Kinuko Yasuda <kinuko@chromium.org> 21593 21594 Reviewed by Ojan Vafai. 21595 21596 Enable incremental results.json generation for non-layout tests. 21597 https://bugs.webkit.org/show_bug.cgi?id=45315 21598 21599 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.) Also add a code to upload results json files to the app-engine server. Need a chromium change to actually start the uploading. 21600 21601 * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too. 21602 21603 216042010-09-07 Dirk Pranke <dpranke@chromium.org> 21605 21606 Unreviewed, build fix 21607 21608 Missed one test in mac_unittest.py in previous change; for some 21609 reason the method is listed twice. I will fix both for now, but will 21610 figure this out in a later, not-time-sensitive patch. 21611 21612 https://bugs.webkit.org/show_bug.cgi?id=45357 21613 21614 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 21615 216162010-09-07 Kent Tamura <tkent@chromium.org> 21617 21618 Reviewed by Tony Chang. 21619 21620 test-webkitpy: Fix load error of 21621 webkitpy/layout_tests/port/factory_unittest.py on Win32 Python 21622 https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short 21623 21624 * Scripts/webkitpy/layout_tests/port/server_process.py: 21625 Avoid to import fcntl on win32. Win32 Python doesn't have fcntl 21626 and we don't use server_process.py on Win32 Python. However 21627 unittest.py tries to load everything in a module. 21628 216292010-09-07 Dirk Pranke <dpranke@chromium.org> 21630 21631 Reviewed by Kent Tamura. 21632 21633 Fix regression introduced in previous change to new-run-webkit-tests 21634 (bug 45090) to not try to run unittests for the Mac implementation 21635 of the Port interface if we aren't running on a Mac. 21636 21637 Also fix the overrides implementation mock in the chromium unittests 21638 to fix the case where there are overrides checked in that cause 21639 problems. 21640 21641 https://bugs.webkit.org/show_bug.cgi?id=45357 21642 21643 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 21644 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 21645 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 21646 216472010-09-01 Dirk Pranke <dpranke@chromium.org> 21648 21649 Reviewed by Ojan Vafai. 21650 21651 new-run-webkit-tests: still more unit tests 21652 21653 Clean up and remove unnecessary code. Biggest notable change is 21654 moving the chromium-specific imagediff code from port/base to 21655 port/chromium. 21656 21657 Add more unit tests for run_webkit_tests.py, port/base.py, 21658 port/factory.py, port/dryrun.py, and 21659 layout_package/dump_render_tree_thread.py 21660 21661 This covers almost all of the generic and test code paths except for 21662 a few error paths involving invalid or port-specific command line 21663 arguments, and the code path for uploading results files to the 21664 buildbots. 21665 21666 https://bugs.webkit.org/show_bug.cgi?id=45090 21667 21668 * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added. 21669 * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt. 21670 * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html. 21671 * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt. 21672 * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html. 21673 * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt: 21674 * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt. 21675 * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html. 21676 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 21677 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added. 21678 * Scripts/webkitpy/layout_tests/port/base.py: 21679 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 21680 * Scripts/webkitpy/layout_tests/port/chromium.py: 21681 * Scripts/webkitpy/layout_tests/port/dryrun.py: 21682 * Scripts/webkitpy/layout_tests/port/factory_unittest.py: 21683 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 21684 * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added. 21685 * Scripts/webkitpy/layout_tests/port/server_process.py: 21686 * Scripts/webkitpy/layout_tests/port/test.py: 21687 * Scripts/webkitpy/layout_tests/port/webkit.py: 21688 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 21689 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 21690 216912010-09-07 Joseph Pecoraro <joepeck@webkit.org> 21692 21693 Reviewed by Darin Adler. 21694 21695 Provide a way to trigger a <select multiple> onchange event on changes 21696 https://bugs.webkit.org/show_bug.cgi?id=45192 21697 21698 Adds a selector on ObjCController for testing 21699 -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and 21700 its different uses. 21701 21702 * DumpRenderTree/mac/ObjCController.m: 21703 (+[ObjCController isSelectorExcludedFromWebScript:]): 21704 (+[ObjCController webScriptNameForSelector:]): 21705 (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]): 21706 217072010-09-07 James Robinson <jamesr@chromium.org> 21708 21709 Rubber-stamped by Dimitri Glazkov. 21710 21711 Move myself from the committer to the reviewer list. 21712 21713 * Scripts/webkitpy/common/config/committers.py: 21714 217152010-09-07 Tony Chang <tony@chromium.org> 21716 21717 Reviewed by Darin Fisher. 21718 21719 [chromium] Make a public flag for how DRT generates bitmaps on Linux 21720 https://bugs.webkit.org/show_bug.cgi?id=45133 21721 21722 * DumpRenderTree/chromium/TestShell.cpp: 21723 (TestShell::dumpImage): 21724 217252010-09-07 Kent Tamura <tkent@chromium.org> 21726 21727 Reviewed by Dimitri Glazkov. 21728 21729 [DRT/Chromium] Implement --check-layout-test-sys-deps 21730 https://bugs.webkit.org/show_bug.cgi?id=45283 21731 21732 * DumpRenderTree/chromium/DumpRenderTree.cpp: 21733 (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies(). 21734 * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies(). 21735 * DumpRenderTree/chromium/TestShellGtk.cpp: 21736 (checkLayoutTestSystemDependencies): Add an empty implementation. 21737 * DumpRenderTree/chromium/TestShellMac.mm: 21738 (checkLayoutTestSystemDependencies): Add an empty implementation. 21739 * DumpRenderTree/chromium/TestShellWin.cpp: 21740 (checkLayoutTestSystemDependencies): Port similar function of test_shell. 21741 217422010-09-07 Jessie Berlin <jberlin@apple.com> 21743 21744 Unreviewed. Mac build fix. 21745 21746 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 21747 (didClearWindowObjectForFrame): 21748 217492010-09-07 Jessie Berlin <jberlin@apple.com> 21750 21751 Reviewed by Darin Adler. 21752 21753 Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for 21754 https://bugs.webkit.org/show_bug.cgi?id=45217 21755 21756 Make WebKitTestRunner work with this change. 21757 21758 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 21759 (WTR::InjectedBundlePage::didClearWindowForFrame): 21760 Make sure the ScriptWorld here is the normal world, since that is no longer being done in 21761 WebFrameLoaderClient. 21762 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 21763 217642010-09-07 Philippe Normand <pnormand@igalia.com> 21765 21766 Unreviewed, build fix. 21767 21768 webkit-patch command to find the ports covering a specific layout test 21769 https://bugs.webkit.org/show_bug.cgi?id=42832 21770 21771 * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the 21772 tests are present when building the expectations. This is needed 21773 for the unittests. 21774 217752010-09-06 Philippe Normand <pnormand@igalia.com> 21776 21777 Reviewed by Adam Barth. 21778 21779 webkit-patch command to find the ports covering a specific layout test 21780 https://bugs.webkit.org/show_bug.cgi?id=42832 21781 21782 To use it: webkit-patch skipped-ports some/layout/test.html 21783 21784 * Scripts/webkitpy/layout_tests/port/base.py: 21785 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 21786 * Scripts/webkitpy/layout_tests/port/chromium.py: 21787 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 21788 * Scripts/webkitpy/layout_tests/port/factory.py: 21789 * Scripts/webkitpy/layout_tests/port/factory_unittest.py: 21790 * Scripts/webkitpy/layout_tests/port/test.py: 21791 * Scripts/webkitpy/layout_tests/port/webkit.py: 21792 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: 21793 * Scripts/webkitpy/tool/commands/queries.py: 21794 * Scripts/webkitpy/tool/commands/queries_unittest.py: 21795 * Scripts/webkitpy/tool/main.py: 21796 * Scripts/webkitpy/tool/mocktool.py: 21797 217982010-09-07 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 21799 21800 Reviewed by Eric Seidel. 21801 21802 [NRWT] Add temp directory to all running drivers. 21803 https://bugs.webkit.org/show_bug.cgi?id=45261 21804 21805 * Scripts/webkitpy/layout_tests/port/webkit.py: 21806 218072010-09-06 Dimitri Glazkov <dglazkov@chromium.org> 21808 21809 Reviewed by Kent Tamura. 21810 21811 [Chromium/DRT] Empty out user stylesheet after each test run. 21812 https://bugs.webkit.org/show_bug.cgi?id=45282 21813 21814 This should significantly cut down on the number of the mysterious flaky tests 21815 whose diffs looked like the page was blown up to a very lage size. This 21816 was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html, 21817 which set the base body font to 100px. 21818 21819 Since the user stylesheet was never reset, _all_ pixel tests that ran after it in 21820 the same thread failed. 21821 21822 * DumpRenderTree/chromium/TestShell.cpp: 21823 (TestShell::resetWebSettings): Set user stylesheet to an empty URL. 21824 218252010-09-06 Kent Tamura <tkent@chromium.org> 21826 21827 Reviewed by Dimitri Glazkov. 21828 21829 [DRT/Chromium] Do not generate pixel results for text/plain resources 21830 https://bugs.webkit.org/show_bug.cgi?id=45253 21831 21832 * DumpRenderTree/chromium/TestShell.cpp: 21833 (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain. 21834 218352010-09-06 Ojan Vafai <ojan@chromium.org> 21836 21837 Reviewed by Kent Tamura. 21838 21839 print out correct error when a DRT thread dies in NRWT 21840 https://bugs.webkit.org/show_bug.cgi?id=45281 21841 21842 Not sure why, but with the parens, python 2.6.5 on Linux 21843 gives an error that raise takes 5 arguments and 0 were given. 21844 Didn't test other platforms or python versions, but putting it 21845 all on one line fixes it and correctly prints the exception 21846 from the DRT thread. 21847 21848 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 21849 218502010-09-06 Eric Seidel <eric@webkit.org> 21851 21852 Unreviewed, just adding some emails from lists.webkit.org. 21853 21854 Update committers.py to include emails from lists.webkit.org 21855 as found by the validate-committer-lists script. 21856 21857 * Scripts/webkitpy/common/config/committers.py: 21858 218592010-09-06 Martin Robinson <mrobinson@igalia.com> 21860 21861 Reviewed by Xan Lopez. 21862 21863 [GTK] Small code cleanup in DumpRenderTreeGtk.cpp 21864 https://bugs.webkit.org/show_bug.cgi?id=45213 21865 21866 * DumpRenderTree/gtk/DumpRenderTree.cpp: 21867 (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't 21868 have to surround the invocation with #ifdefs. 21869 (useLongRunningServerMode): Added. 21870 (runTestingServerLoop): Added. 21871 (initializeGlobalsFromCommandLineOptions): Added. 21872 (runTest): Removed ifdefs. 21873 (main): Use new helper functions. 21874 218752010-09-06 Martin Robinson <mrobinson@igalia.com> 21876 21877 Reviewed by Xan Lopez. 21878 21879 [GTK] EventSender should support modifier keys with mouseDown and mouseUp events 21880 https://bugs.webkit.org/show_bug.cgi?id=45235 21881 21882 Add support for interpreting the modifier key arguments to the mouseDown and mouseUp 21883 methods of the EventSender. 21884 21885 * DumpRenderTree/gtk/EventSender.cpp: 21886 (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd 21887 with the current modifiers. 21888 (contextClickCallback): Always send no modifiers when preparing the mouse event. 21889 (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask. 21890 (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent. 21891 (mouseUpCallback): Ditto. 21892 218932010-09-05 Peter Kasting <pkasting@google.com> 21894 21895 Reviewed by Adam Barth. 21896 21897 Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac. 21898 https://bugs.webkit.org/show_bug.cgi?id=45155 21899 21900 * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac. 21901 (EventSender::handleMouseWheel): 21902 219032010-09-05 Yury Semikhatsky <yurys@chromium.org> 21904 21905 Reviewed by Joseph Pecoraro. 21906 21907 Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used 21908 https://bugs.webkit.org/show_bug.cgi?id=45179 21909 21910 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: 21911 * DumpRenderTree/chromium/DRTDevToolsAgent.h: 21912 219132010-09-05 Andreas Kling <andreas.kling@nokia.com> 21914 21915 Rubber-stamped by Daniel Bates. 21916 21917 Adding myself as reviewer. 21918 21919 * Scripts/webkitpy/common/config/committers.py: 21920 219212010-09-04 Daniel Bates <dbates@rim.com> 21922 21923 Reviewed by Martin Robinson. 21924 21925 Teach svn-apply/unapply about svn:mergeinfo 21926 https://bugs.webkit.org/show_bug.cgi?id=45236 21927 21928 Recognize the svn:mergeinfo property and ignore it for now. 21929 21930 Currently, svn-apply/unapply recognize only '+' and '-' 21931 property changes within a diff. We should add support 21932 to recognize "Merged" and "Reverse-merged" changes as well. 21933 Because svn:mergeinfo is metadata that is used only by SVN 21934 and tends to be error-prone and/or nuisance (*), we will ignore 21935 it for now. 21936 (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>. 21937 21938 * Scripts/VCSUtils.pm: 21939 - Modified parseSvnProperty() to recognize "Merged" and 21940 "Reverse-merged" as the start of a property value. 21941 * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl: 21942 - Added the following unit tests: 21943 "simple: add svn:mergeinfo" 21944 "simple: delete svn:mergeinfo" 21945 "simple: modified svn:mergeinfo" 21946 * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: 21947 - Added the following unit tests: 21948 "simple: add svn:mergeinfo" 21949 "simple: delete svn:mergeinfo" 21950 "simple: modified svn:mergeinfo" 21951 "simple: modified svn:mergeinfo using SVN 1.4 syntax" 21952 "'Merged' change followed by 'Merged' change" 21953 "'Reverse-merged' change followed by 'Reverse-merged' change" 21954 * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl: 21955 - Added the following unit tests: 21956 "'Merged' change" 21957 "'Reverse-merged' change" 21958 "'Reverse-merged' change followed by 'Merge' change" 21959 "'Merged' change followed by 'Merge' change" 21960 "'Reverse-merged' change followed by 'Reverse-merged' change" 21961 "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change" 21962 219632010-09-04 Lucas De Marchi <lucas.demarchi@profusion.mobi> 21964 21965 Reviewed by Kenneth Rohde Christiansen. 21966 21967 [EFL] Move test browser to WebKitTools directory 21968 https://bugs.webkit.org/show_bug.cgi?id=45212 21969 21970 Follow other ports like QT and GTK which moved the test browser to 21971 WebKitTools directory. 21972 21973 * CMakeListsEfl.txt: Added. 21974 * EWebLauncher/main.c: Added. 21975 (print_history): 21976 (zoom_level_set): 21977 (on_ecore_evas_resize): 21978 (title_set): 21979 (viewport_set): 21980 (on_title_changed): 21981 (on_progress): 21982 (on_load_finished): 21983 (on_toolbars_visible_set): 21984 (on_toolbars_visible_get): 21985 (on_statusbar_visible_set): 21986 (on_statusbar_visible_get): 21987 (on_scrollbars_visible_set): 21988 (on_scrollbars_visible_get): 21989 (on_menubar_visible_set): 21990 (on_menubar_visible_get): 21991 (on_tooltip_text_set): 21992 (on_inputmethod_changed): 21993 (on_viewport_changed): 21994 (on_mouse_down): 21995 (on_focus_out): 21996 (on_focus_in): 21997 (on_resized): 21998 (on_key_down): 21999 (on_browser_del): 22000 (on_closeWindow): 22001 (quit): 22002 (browserCreate): 22003 (browserDestroy): 22004 (closeWindow): 22005 (main_signal_exit): 22006 (findThemePath): 22007 (main): 22008 220092010-09-03 Simon Fraser <simon.fraser@apple.com> 22010 22011 Reviewed by Adam Roben. 22012 22013 Set project dependencies so that they build serially. This fixes 22014 issues when running run-webkit-tests if DRT is not built yet. 22015 22016 * DumpRenderTree/DumpRenderTree.sln: 22017 220182010-09-03 Dimitri Glazkov <dglazkov@chromium.org> 22019 22020 Reviewed by Adam Barth. 22021 22022 Fix reading configuraiton in NWRT to work on Windows. 22023 https://bugs.webkit.org/show_bug.cgi?id=45180 22024 22025 * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do 22026 with the file otherwise. 22027 220282010-09-03 Chris Rogers <crogers@google.com> 22029 22030 Unreviewed 22031 22032 Add myself to the committers list 22033 https://bugs.webkit.org/show_bug.cgi?id=45189 22034 22035 * Scripts/webkitpy/common/config/committers.py: 22036 220372010-09-03 Andrey Kosyakov <caseq@chromium.org> 22038 22039 Reviewed by Yury Semikhatsky. 22040 22041 http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot 22042 Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms. 22043 https://bugs.webkit.org/show_bug.cgi?id=45137 22044 22045 * Scripts/webkitpy/layout_tests/port/lighttpd.conf: 22046 220472010-09-03 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 22048 22049 Reviewed by Eric Seidel. 22050 22051 Add feature detection support to NRWT. 22052 https://bugs.webkit.org/show_bug.cgi?id=41842 22053 22054 * Scripts/webkitpy/layout_tests/port/base.py: 22055 * Scripts/webkitpy/layout_tests/port/qt.py: 22056 * Scripts/webkitpy/layout_tests/port/webkit.py: 22057 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added. 22058 220592010-09-03 Hironori Bono <hbono@chromium.org> 22060 22061 Reviewed by Kent Tamura. 22062 22063 Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests 22064 and implements it for Mac. 22065 https://bugs.webkit.org/show_bug.cgi?id=41832 22066 22067 * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:] 22068 and bind it so we can call it from JavaScript. 22069 (+[TextInputController isSelectorExcludedFromWebScript:]): 22070 (+[TextInputController webScriptNameForSelector:]): 22071 (-[TextInputController hasSpellingMarker:length:]): 22072 220732010-09-02 Eric Seidel <eric@webkit.org> 22074 22075 Reviewed by Adam Barth. 22076 22077 Add a unit test for commit-queue retries 22078 https://bugs.webkit.org/show_bug.cgi?id=45162 22079 22080 I think commit-queue retries are not correctly avoiding 22081 build and test on retries. So I started testing the code. 22082 Unfortunately this test did not find the bug. But now 22083 that we have the test we might as well keep it. 22084 I also fixed a broken import in validate-committer-lists. 22085 22086 * Scripts/validate-committer-lists: 22087 * Scripts/webkitpy/tool/commands/queues_unittest.py: 22088 220892010-09-02 Kent Tamura <tkent@chromium.org> 22090 22091 Reviewed by Dimitri Glazkov. 22092 22093 [DRT/Chromium] Remove dependency to base/task.h and base/timer.h 22094 https://bugs.webkit.org/show_bug.cgi?id=45091 22095 22096 Task.{cpp,h} introduces a simpler version of Chromium 22097 base/task.h. It doesn't have TupleN and Method. 22098 22099 * DumpRenderTree/DumpRenderTree.gypi: 22100 Add Task.cpp and Task.h 22101 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: 22102 (DRTDevToolsAgent::DRTDevToolsAgent): 22103 (DRTDevToolsAgent::reset): 22104 (DRTDevToolsAgent::asyncCall): 22105 (DRTDevToolsAgent::frontendLoaded): 22106 * DumpRenderTree/chromium/DRTDevToolsAgent.h: 22107 (DRTDevToolsAgent::taskList): Added to use MethodTask<T>. 22108 * DumpRenderTree/chromium/DRTDevToolsClient.cpp: 22109 (DRTDevToolsClient::DRTDevToolsClient): 22110 (DRTDevToolsClient::~DRTDevToolsClient): 22111 (DRTDevToolsClient::reset): 22112 (DRTDevToolsClient::asyncCall): 22113 * DumpRenderTree/chromium/DRTDevToolsClient.h: 22114 (DRTDevToolsClient::taskList): Added to use MethodTask<T>. 22115 * DumpRenderTree/chromium/EventSender.cpp: 22116 (EventSender::EventSender): 22117 (EventSender::reset): 22118 (EventSender::scheduleAsynchronousClick): 22119 * DumpRenderTree/chromium/EventSender.h: 22120 (EventSender::taskList): Added to use MethodTask<T>. 22121 * DumpRenderTree/chromium/LayoutTestController.cpp: 22122 (LayoutTestController::LayoutTestController): 22123 (LayoutTestController::WorkQueue::processWorkSoon): 22124 (LayoutTestController::waitUntilDone): 22125 (LayoutTestController::notifyDone): 22126 (LayoutTestController::reset): 22127 * DumpRenderTree/chromium/LayoutTestController.h: 22128 (LayoutTestController::taskList): Added to use MethodTask<T>. 22129 (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>. 22130 * DumpRenderTree/chromium/NotificationPresenter.cpp: 22131 (deferredDisplayDispatch): 22132 (NotificationPresenter::show): 22133 * DumpRenderTree/chromium/Task.cpp: Added. 22134 * DumpRenderTree/chromium/Task.h: Added. 22135 221362010-09-02 Steve Block <steveblock@google.com> 22137 22138 Reviewed by Adam Barth. 22139 22140 Hook up LayoutTestController.setMockDeviceOrientation() on Mac. 22141 https://bugs.webkit.org/show_bug.cgi?id=43181 22142 22143 * DumpRenderTree/mac/DumpRenderTree.mm: 22144 (createWebViewAndOffscreenWindow): 22145 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 22146 (LayoutTestController::setMockDeviceOrientation): 22147 221482010-08-31 Adam Roben <aroben@apple.com> 22149 22150 Fix flashiness when resizing the browser window on Windows 22151 22152 Reviewed by Sam Weinig. 22153 22154 * MiniBrowser/win/BrowserWindow.cpp: 22155 (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't 22156 periodically fill the window with white. 22157 221582010-09-02 Peter Kasting <pkasting@google.com> 22159 22160 Reviewed by Dimitri Glazkov. 22161 22162 Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK. 22163 https://bugs.webkit.org/show_bug.cgi?id=45073 22164 22165 * DumpRenderTree/chromium/EventSender.cpp: 22166 (EventSender::EventSender): 22167 (EventSender::mouseScrollBy): 22168 (EventSender::continuousMouseScrollBy): 22169 (EventSender::sendCurrentTouchEvent): 22170 (EventSender::handleMouseWheel): 22171 * DumpRenderTree/chromium/EventSender.h: 22172 * DumpRenderTree/gtk/EventSender.cpp: 22173 (mouseScrollByCallback): 22174 (continuousMouseScrollByCallback): 22175 221762010-09-01 Dirk Pranke <dpranke@chromium.org> 22177 22178 Reviewed by Tony Chang. 22179 22180 Land a patched version of r66542 - change TestRunner to have an 22181 separate cleanup method and fix the ordering of cleanup between 22182 TestRunner and the printing module, and then wrap everything in a 22183 try/finally block to ensure reliable cleanup without needing to 22184 rely on stuff happening in the destructor of the TestRunner. 22185 22186 Also refactor run_webkit_tests.run() to be much smaller and cleaner 22187 by creating a bunch of helper methods and moving more stuff into 22188 the TestRunner class. 22189 22190 This fixes the crash at the end of the linux test run of 22191 new-run-webkit-tests (and undoes the rollout in 66547). 22192 22193 https://bugs.webkit.org/show_bug.cgi?id=44902 22194 22195 * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added. 22196 * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added. 22197 * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added. 22198 * Scripts/webkitpy/layout_tests/data/passes/error.html: Added. 22199 * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt: 22200 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 22201 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 22202 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 22203 * Scripts/webkitpy/layout_tests/port/base.py: 22204 * Scripts/webkitpy/layout_tests/port/test.py: 22205 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 22206 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 22207 222082010-09-01 Mark Rowe <mrowe@apple.com> 22209 22210 Reviewed by Adam Roben. 22211 22212 Fix TestNetscapePlugIn to compile without access to QuickDraw private headers. 22213 22214 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 22215 222162010-09-01 Brian Weinstein <bweinstein@apple.com> 22217 22218 Reviewed by Adam Roben. 22219 22220 Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess 22221 and WebKitTestRunner. 22222 22223 * BuildSlaveSupport/win/kill-old-processes: 22224 222252010-09-01 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 22226 22227 Reviewed by Antonio Gomes. 22228 22229 [Qt] Remove obsolete include path from DumpRenderTree.pro 22230 22231 * DumpRenderTree/qt/DumpRenderTree.pro: 22232 222332010-09-01 Mahesh Kulkarni <mahesh.kulkarni@nokia.com> 22234 22235 Reviewed by Laszlo Gombos. 22236 22237 [Qt] QWebPage::allowGeolocationRequest should be async API 22238 https://bugs.webkit.org/show_bug.cgi?id=41364 22239 22240 Implements new async API for geolocation permission similar to 22241 Notification. WebPage maintains list of geolocation permission request 22242 QtWebkit and set's when LayoutTestController gets the access from test JS 22243 22244 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 22245 (WebCore::WebPage::WebPage): 22246 (WebCore::WebPage::resetSettings): 22247 (WebCore::WebPage::requestPermission): 22248 (WebCore::WebPage::cancelPermission): 22249 (WebCore::WebPage::permissionSet): 22250 (WebCore::DumpRenderTree::DumpRenderTree): 22251 (WebCore::DumpRenderTree::processLine): 22252 (WebCore::DumpRenderTree::geolocationPermissionSet): 22253 * DumpRenderTree/qt/DumpRenderTreeQt.h: 22254 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 22255 (LayoutTestController::reset): 22256 (LayoutTestController::setGeolocationPermission): 22257 (LayoutTestController::setGeolocationPermissionCommon): 22258 * DumpRenderTree/qt/LayoutTestControllerQt.h: 22259 222602010-09-01 Andras Becsi <abecsi@webkit.org> 22261 22262 Reviewed by Antti Koivisto. 22263 22264 [Qt] Auto-generate WebKit2 forwarding headers 22265 https://bugs.webkit.org/show_bug.cgi?id=44692 22266 22267 * MiniBrowser/qt/BrowserWindow.h: use source style includes 22268 * MiniBrowser/qt/MiniBrowser.pro: add missing include paths 22269 * Scripts/enumerate-included-framework-headers: Removed. 22270 222712010-08-31 Ademar de Souza Reis Jr <ademar.reis@openbossa.org> 22272 22273 Reviewed by Adam Barth. 22274 22275 Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary 22276 https://bugs.webkit.org/show_bug.cgi?id=44789 22277 22278 * Scripts/webkitpy/common/net/bugzilla.py: 22279 222802010-08-31 Leandro Pereira <leandro@profusion.mobi> 22281 22282 Reviewed by Adam Barth. 22283 22284 ews: Add support for EFL-EWS 22285 https://bugs.webkit.org/show_bug.cgi?id=44982 22286 22287 * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list. 22288 * Scripts/webkitpy/common/config/ports.py: Define a EflPort class 22289 and add it to the ports dict. 22290 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a 22291 EflEWS class. 22292 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add 22293 a test case for the EFL EWS. 22294 222952010-08-31 Alexey Proskuryakov <ap@apple.com> 22296 22297 Reviewed by Sam Weinig. 22298 22299 https://bugs.webkit.org/show_bug.cgi?id=42195 22300 <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled 22301 22302 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 22303 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled): 22304 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 22305 Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method 22306 makes WebProcess use a different value for this preference than UIProcess thinks it uses. 22307 22308 * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): 22309 Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess, 22310 which forgets its override. 22311 223122010-08-31 Sam Weinig <sam@webkit.org> 22313 22314 Reviewed by Gavin Barraclough. 22315 22316 WebKitTestRunner needs layoutTestController.addUserStyleSheet 22317 https://bugs.webkit.org/show_bug.cgi?id=42680 22318 22319 WebKitTestRunner needs layoutTestController.addUserScript 22320 https://bugs.webkit.org/show_bug.cgi?id=42681 22321 22322 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 22323 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 22324 (WTR::InjectedBundle::beginTesting): 22325 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 22326 (WTR::LayoutTestController::addUserScript): 22327 (WTR::LayoutTestController::addUserStyleSheet): 22328 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 22329 223302010-08-31 Dirk Pranke <dpranke@chromium.org> 22331 22332 Unreviewed, rolling out r66542. 22333 http://trac.webkit.org/changeset/66542 22334 https://bugs.webkit.org/show_bug.cgi?id=44902 22335 22336 r66542 - the weird logging dependencies in Python stuck again ... 22337 22338 * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed. 22339 * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed. 22340 * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed. 22341 * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed. 22342 * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt: 22343 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 22344 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 22345 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 22346 * Scripts/webkitpy/layout_tests/port/base.py: 22347 * Scripts/webkitpy/layout_tests/port/test.py: 22348 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 22349 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 22350 223512010-08-31 Dumitru Daniliuc <dumi@chromium.org> 22352 22353 Reviewed by Tony Chang. 22354 22355 Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT. 22356 22357 * DumpRenderTree/chromium/LayoutTestController.cpp: 22358 (LayoutTestController::LayoutTestController): 22359 (LayoutTestController::markerTextForListItem): 22360 * DumpRenderTree/chromium/LayoutTestController.h: 22361 223622010-08-31 Dirk Pranke <dpranke@chromium.org> 22363 22364 Reviewed by Ojan Vafai. 22365 22366 new-run-webkit-tests: add more unit tests 22367 22368 Add more unit tests for new-run-webkit-tests; we now cover all but 22369 the most obscure code paths in the generic code. We still need to 22370 add coverage for the http server and web socket paths, and add better 22371 coverage of the platform-specific logic. Note that the rebaselining 22372 tool is still not well tested. 22373 22374 Also clean up some of the configuration logic for the printing 22375 module and the way it interacts with the Python logging module; that 22376 is a crufty interface, to be certain. 22377 22378 https://bugs.webkit.org/show_bug.cgi?id=44902 22379 22380 * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added. 22381 * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added. 22382 * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added. 22383 * Scripts/webkitpy/layout_tests/data/passes/error.html: Added. 22384 * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt: 22385 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 22386 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 22387 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 22388 * Scripts/webkitpy/layout_tests/port/base.py: 22389 * Scripts/webkitpy/layout_tests/port/test.py: 22390 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 22391 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 22392 223932010-08-31 Darin Adler <darin@apple.com> 22394 22395 Reviewed by Anders Carlsson. 22396 22397 * Scripts/check-for-global-initializers: Add a file that ends up having global initializers 22398 in a debug build when built with certain compilers. 22399 224002010-08-31 Martin Robinson <mrobinson@igalia.com> 22401 22402 Reviewed by Gustavo Noronha Silva. 22403 22404 [GTK] Isolate all GTK+ typedefs into one file 22405 https://bugs.webkit.org/show_bug.cgi?id=44900 22406 22407 * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs. 22408 224092010-08-31 Eric Seidel <eric@webkit.org> 22410 22411 Reviewed by Adam Barth. 22412 22413 Show more status on queue status pages 22414 https://bugs.webkit.org/show_bug.cgi?id=44938 22415 22416 I upped the number of status lines from 6 to 15 -- 22417 this has been bugging me for a while... 22418 22419 I also disabled showing the chromium-win EWS queue 22420 since it's been down for almost 5 months now. 22421 22422 * QueueStatusServer/handlers/dashboard.py: 22423 * QueueStatusServer/handlers/queuestatus.py: 22424 * QueueStatusServer/model/queues.py: 22425 224262010-08-31 Zoltan Horvath <zoltan@webkit.org> 22427 22428 Reviewed by Antonio Gomes. 22429 22430 [Qt] Read command line arguments and open them as URLs in new windows 22431 https://bugs.webkit.org/show_bug.cgi?id=44944 22432 22433 Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows. 22434 22435 * MiniBrowser/qt/main.cpp: 22436 (main): 22437 224382010-08-31 Adrian Perez <aperez@igalia.com> 22439 22440 Reviewed by Martin Robinson. 22441 22442 Support scripts to run Buildbot slaves under daemontools (gtk related) 22443 https://bugs.webkit.org/show_bug.cgi?id=40053 22444 22445 * BuildSlaveSupport/gtk: Added. 22446 * BuildSlaveSupport/gtk/README: Added. 22447 * BuildSlaveSupport/gtk/buildbot: Added. 22448 * BuildSlaveSupport/gtk/buildbot/log: Added. 22449 * BuildSlaveSupport/gtk/buildbot/log/run: Added. 22450 * BuildSlaveSupport/gtk/buildbot/run: Added. 22451 * BuildSlaveSupport/gtk/crashmon: Added. 22452 * BuildSlaveSupport/gtk/crashmon/crashmon: Added. 22453 * BuildSlaveSupport/gtk/crashmon/log: Added. 22454 * BuildSlaveSupport/gtk/crashmon/log/run: Added. 22455 * BuildSlaveSupport/gtk/crashmon/run: Added. 22456 * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added. 22457 * BuildSlaveSupport/gtk/pulseaudio: Added. 22458 * BuildSlaveSupport/gtk/pulseaudio/run: Added. 22459 * BuildSlaveSupport/gtk/xvfb: Added. 22460 * BuildSlaveSupport/gtk/xvfb/log: Added. 22461 * BuildSlaveSupport/gtk/xvfb/log/run: Added. 22462 * BuildSlaveSupport/gtk/xvfb/run: Added. 22463 224642010-08-27 John Gregg <johnnyg@google.com> 22465 22466 Reviewed by David Levin. 22467 22468 Notifications should support a click event. 22469 Adds necessary hooks to chromium's DRT so that clicks on desktop notifications 22470 can be simulated during a layout test. Requires storing a list of active 22471 notifications so that they can be referred to later for clicking. 22472 https://bugs.webkit.org/show_bug.cgi?id=44800 22473 22474 * DumpRenderTree/chromium/LayoutTestController.cpp: 22475 (LayoutTestController::LayoutTestController): 22476 (LayoutTestController::simulateDesktopNotificationClick): 22477 * DumpRenderTree/chromium/LayoutTestController.h: 22478 * DumpRenderTree/chromium/NotificationPresenter.cpp: 22479 (NotificationPresenter::simulateClick): 22480 (NotificationPresenter::show): 22481 (NotificationPresenter::cancel): 22482 (NotificationPresenter::objectDestroyed): 22483 * DumpRenderTree/chromium/NotificationPresenter.h: 22484 224852010-08-30 Alice Liu <alice.liu@apple.com> 22486 22487 Reviewed by Darin Adler. 22488 22489 Add missing parts of didFinishDocumentLoadForFrame 22490 https://bugs.webkit.org/show_bug.cgi?id=44913 22491 22492 * MiniBrowser/mac/BrowserWindowController.m: 22493 (didFinishDocumentLoadForFrame): Added 22494 (-[BrowserWindowController awakeFromNib]): Updated struct 22495 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 22496 (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr 22497 * WebKitTestRunner/TestController.cpp: 22498 (WTR::TestController::initialize): Updated struct 22499 225002010-08-30 Vangelis Kokkevis <vangelis@chromium.org> 22501 22502 Unreviewed: Add myself to the list of Committers. 22503 22504 * Scripts/webkitpy/common/config/committers.py: 22505 225062010-08-30 Kent Tamura <tkent@chromium.org> 22507 22508 Reviewed by Adam Barth. 22509 22510 Fix fast/notifications/notifications-display-close-events.html failure 22511 https://bugs.webkit.org/show_bug.cgi?id=44585 22512 22513 Apply http://crrev.com/48893. We should dispatch display events 22514 asynchronously. 22515 22516 * DumpRenderTree/chromium/NotificationPresenter.cpp: 22517 (deferredDisplayDispatch): 22518 (NotificationPresenter::show): 22519 225202010-08-30 Robert Hogan <robert@webkit.org> 22521 22522 Reviewed by Simon Hausmann. 22523 22524 allow ports with windowed plugins to support windowless plugin tests 22525 22526 https://bugs.webkit.org/show_bug.cgi?id=40730 22527 22528 Ports that implement plugins windowed by default need to have a way of 22529 supporting plugin tests that assume the plugin is windowless. Add this 22530 feature to the tests and support it in the webkit test plugin. Also 22531 add mouse and keyboard event logging to the webkit-test plugin on Unix. 22532 22533 Unskip the following tests on Qt: 22534 22535 plugins/mouse-events.html 22536 plugins/keyboard-events.html 22537 plugins/mouse-events-fixedpos.html 22538 22539 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 22540 (pluginSetProperty): 22541 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 22542 (NPP_New): 22543 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 22544 (webkit_test_plugin_handle_event): 22545 225462010-08-30 Kevin Ollivier <kevino@theolliviers.com> 22547 22548 [wx] Build fix after addition of fileapi directory in WebCore. 22549 22550 * wx/build/settings.py: 22551 225522010-08-30 Alejandro G. Castro <alex@igalia.com> 22553 22554 Reviewed by Xan Lopez. 22555 22556 Fixed compilation error, now that we have included the 22557 GtkVersioning.h we have to remove some version dependent code from 22558 EventSender. 22559 22560 * DumpRenderTree/gtk/EventSender.cpp: 22561 225622010-08-30 Alejandro G. Castro <alex@igalia.com> 22563 22564 Reviewed by Martin Robinson. 22565 22566 [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer 22567 are deprecated 22568 https://bugs.webkit.org/show_bug.cgi?id=44787 22569 22570 We have replaced GtkVersioning.cpp with GtkVersioning.c and 22571 created a function (getDefaultGDKPointerDevice) to get the pointer 22572 of the window with the new APIs. We added that function to DRT and 22573 copyandpaste unit test. 22574 22575 * DumpRenderTree/gtk/EventSender.cpp: 22576 (prepareMouseButtonEvent): 22577 (mouseMoveToCallback): 22578 (keyDownCallback): 22579 * GNUmakefile.am: 22580 225812010-08-30 Zoltan Horvath <zoltan@webkit.org> 22582 22583 Reviewed by Kenneth Rohde Christiansen. 22584 22585 [Qt] Add new window menu to MiniBrowser 22586 22587 Implement newWindow function and add a menu item for opening new window in MiniBrowser. 22588 22589 * MiniBrowser/qt/BrowserWindow.cpp: 22590 (BrowserWindow::BrowserWindow): 22591 (BrowserWindow::newWindow): 22592 * MiniBrowser/qt/BrowserWindow.h: 22593 * MiniBrowser/qt/main.cpp: 22594 (main): 22595 225962010-08-29 James Robinson <jamesr@chromium.org> 22597 22598 Reviewed by David Levin. 22599 22600 Make failing the download step fail the build 22601 https://bugs.webkit.org/show_bug.cgi?id=44298 22602 22603 If the download step fails on a test bot, this ensures that 22604 the build goes red instead of only the download step going red 22605 and the overall build staying green. 22606 22607 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 22608 226092010-08-29 Kent Tamura <tkent@chromium.org> 22610 22611 Reviewed by Dimitri Glazkov. 22612 22613 [DRT/Chromium] Remove dependency to base/keyboard_codes.h 22614 https://bugs.webkit.org/show_bug.cgi?id=44847 22615 22616 * DumpRenderTree/chromium/EventSender.cpp: 22617 Use webkit_support::VKEY_* instead of base::VKEY_*. 22618 226192010-08-29 Darin Adler <darin@apple.com> 22620 22621 https://bugs.webkit.org/show_bug.cgi?id=40589 22622 22623 * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty 22624 function names. 22625 226262010-08-26 Holger Hans Peter Freyther <holger@moiji-mobile.com> 22627 22628 Reviewed by Darin Adler. 22629 22630 [iExploder] Add new CSS Properties and HTML Attributes 22631 https://bugs.webkit.org/show_bug.cgi?id=44746 22632 22633 Updated the files with the update-iexploder-cssproperties script 22634 and manually readded the -webkit-binding CSS Property to the list. 22635 22636 * iExploder/htdocs/cssproperties.in: 22637 * iExploder/htdocs/htmlattrs.in: 22638 * iExploder/htdocs/htmltags.in: 22639 226402010-08-26 Holger Hans Peter Freyther <holger@moiji-mobile.com> 22641 22642 Reviewed by Darin Adler. 22643 22644 Fix Coverage build after the addition of ANGLE 22645 https://bugs.webkit.org/show_bug.cgi?id=44744 22646 22647 ANGLE is using libtool to build a static library and the version of 22648 libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage 22649 parameters. The easiest way to handle this is to not build ANGLE with 22650 coverage information. 22651 22652 This is achieved by applying the XCode options for each project 22653 separately and exclude ANGLE. 22654 22655 * Scripts/build-webkit: Remove -framework AppKit due link errors. 22656 * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE. 22657 226582010-08-28 Kevin Ollivier <kevino@theolliviers.com> 22659 22660 [wx] Build fix after directory addition. 22661 22662 * wx/build/settings.py: 22663 226642010-08-28 Chris Guillory <chris.guillory@google.com> 22665 22666 Reviewed by Chris Fleizach. 22667 22668 Add AX notification for childrenChanged 22669 https://bugs.webkit.org/show_bug.cgi?id=44472 22670 22671 * DumpRenderTree/chromium/AccessibilityController.cpp: 22672 (AccessibilityController::AccessibilityController): 22673 (AccessibilityController::reset): 22674 (AccessibilityController::getRootElement): 22675 (AccessibilityController::dumpAccessibilityNotifications): 22676 * DumpRenderTree/chromium/AccessibilityController.h: 22677 (AccessibilityController::shouldDumpAccessibilityNotifications): 22678 * DumpRenderTree/chromium/WebViewHost.cpp: 22679 (WebViewHost::didChangeAccessibilityObjectChildren): 22680 * DumpRenderTree/chromium/WebViewHost.h: 22681 226822010-08-28 Eric Seidel <eric@webkit.org> 22683 22684 Reviewed by Adam Barth. 22685 22686 Update commit-queue failure message 22687 https://bugs.webkit.org/show_bug.cgi?id=44798 22688 22689 The commit-queue auto-restarts itself and has for a very long time. 22690 No need for people to email me to request a restart anymore. 22691 22692 * Scripts/webkitpy/common/net/bugzilla.py: 22693 * Scripts/webkitpy/common/net/bugzilla_unittest.py: 22694 * Scripts/webkitpy/tool/commands/queues_unittest.py: 22695 226962010-07-27 Jer Noble <jer.noble@apple.com> 22697 22698 Reviewed by Eric Carlson. 22699 22700 Add JavaScript API to allow a page to go fullscreen. 22701 rdar://problem/6867795 22702 22703 Added basic full screen support to DumpRenderTree: when a webView requests 22704 that DumpRenderTree go "full screen", just call the provided callback listener object's 22705 will/did Enter/Exit full screen methods. Also, register a new user default which 22706 enables full screen support. 22707 22708 * DumpRenderTree/mac/DumpRenderTree.mm: 22709 (resetDefaultsToConsistentValues): 22710 * DumpRenderTree/mac/UIDelegate.mm: 22711 (-[UIDelegate webView:supportsFullscreenForElement:]): 22712 (-[UIDelegate webView:enterFullscreenForElement:listener:]): 22713 (-[UIDelegate webView:exitFullscreenForElement:listener:]): 22714 227152010-08-27 Benjamin Poulain <benjamin.poulain@nokia.com> 22716 22717 Unreviewed. Add myself to the committers list. 22718 22719 * Scripts/webkitpy/common/config/committers.py: 22720 227212010-08-27 Kent Tamura <tkent@chromium.org> 22722 22723 Reviewed by Pavel Feldman. 22724 22725 [DRT/Chromium] Fix inspector test failures 22726 https://bugs.webkit.org/show_bug.cgi?id=44748 22727 22728 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: 22729 (DRTDevToolsAgent::createClientMessageLoop): 22730 Returns a valid WebKitClientMessageLoop instance 22731 * DumpRenderTree/chromium/DRTDevToolsAgent.h: 22732 227332010-08-26 Jon Honeycutt <jhoneycutt@apple.com> 22734 22735 Add Windows WebKit2 Tester to buildbot 22736 <rdar://problem/7887703> 22737 22738 Reviewed by Dan Bernstein. 22739 22740 * BuildSlaveSupport/build.webkit.org-config/config.json: 22741 227422010-08-26 Philippe Normand <pnormand@igalia.com> 22743 22744 Reviewed by Martin Robinson. 22745 22746 [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations 22747 https://bugs.webkit.org/show_bug.cgi?id=42152 22748 22749 * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: 22750 (LoadHTMLStringItem::invoke): Implementation using 22751 webkit_web_frame_load_string(). 22752 227532010-08-25 Jon Honeycutt <jhoneycutt@apple.com> 22754 22755 <rdar://problem/8334338> run-webkit-tests sometimes hangs when using 22756 WebKitTestRunner (44331) 22757 22758 Reviewed by Darin Adler. 22759 22760 * WebKitTestRunner/TestController.cpp: 22761 (WTR::TestController::initialize): 22762 The hang occurs when WebKitTestRunner begins launching the WebKit2 22763 web process then exits before it finishes launching. Work around this by 22764 looking for the --print-supported-features argument and exiting without 22765 creating the web process. 22766 227672010-08-26 Dirk Pranke <dpranke@chromium.org> 22768 22769 Reviewed by Tony Chang. 22770 22771 new-run-webkit-tests: add rebaselining tests for test_expectations 22772 22773 This patch adds more unit tests for the rebaselining code in the 22774 test_expectations module. It doesn't add any tests for 22775 rebaseline_chromium_webkit_tests itself; that will come some other 22776 time. 22777 22778 https://bugs.webkit.org/show_bug.cgi?id=44648 22779 22780 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 22781 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 22782 227832010-08-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 22784 22785 Reviewed by Martin Robinson. 22786 22787 [GTK] Add HTTP caching support 22788 https://bugs.webkit.org/show_bug.cgi?id=44261 22789 22790 Ignore new soup API that we decided to merge into the soup backend 22791 while it is being cooked. It follows the libsoup style, and will 22792 be removed from WebKit as soon as it is merged into libsoup. 22793 22794 * Scripts/webkitpy/style/checker.py: 22795 227962010-08-26 Mahesh Kulkarni <mahesh.kulkarni@nokia.com> 22797 22798 Reviewed by Kenneth Rohde Christiansen. 22799 22800 [Qt] DumpRenderTree runs only one test from command mode 22801 https://bugs.webkit.org/show_bug.cgi?id=44012 22802 22803 Enables support to run multiple test files and single 22804 folder containing html files in stand alone mode 22805 22806 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 22807 (WebCore::DumpRenderTree::DumpRenderTree): 22808 (WebCore::DumpRenderTree::processArgsLine): 22809 (WebCore::DumpRenderTree::loadNextTestInStandAloneMode): 22810 (WebCore::DumpRenderTree::processLine): 22811 (WebCore::DumpRenderTree::dump): 22812 * DumpRenderTree/qt/DumpRenderTreeQt.h: 22813 (WebCore::DumpRenderTree::setStandAloneMode): 22814 (WebCore::DumpRenderTree::isStandAloneMode): 22815 * DumpRenderTree/qt/main.cpp: 22816 (main): 22817 228182010-08-25 Martin Robinson <mrobinson@igalia.com> 22819 22820 Updating webkitpy test expectations. 22821 22822 * Scripts/webkitpy/tool/steps/steps_unittest.py: 22823 228242010-08-25 Ojan Vafai <ojan@chromium.org> 22825 22826 Reviewed by Eric Seidel. 22827 22828 fix the always squash git config 22829 https://bugs.webkit.org/show_bug.cgi?id=44651 22830 22831 Fix help text and apparently underscores are not allowed 22832 in git config keys. 22833 22834 * Scripts/webkitpy/common/checkout/scm.py: 22835 * Scripts/webkitpy/tool/steps/commit.py: 22836 228372010-08-25 Darin Adler <darin@apple.com> 22838 22839 Reviewed by John Sullivan. 22840 22841 * Scripts/commit-log-editor: Fix perl warning for people who have no 22842 value for SVN_LOG_EDITOR or CVS_LOG_EDITOR. 22843 228442010-08-25 Ojan Vafai <ojan@chromium.org> 22845 22846 Reviewed by Eric Seidel. 22847 22848 stop blocking commits when the bots are red 22849 https://bugs.webkit.org/show_bug.cgi?id=44644 22850 22851 This check currently is just annoying. It doesn't actually 22852 help keep the tree green. We can always add it back later 22853 if we decide the tree is generally more green. 22854 22855 * Scripts/webkitpy/tool/commands/download_unittest.py: 22856 * Scripts/webkitpy/tool/mocktool.py: 22857 * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: 22858 228592010-08-25 Eric Seidel <eric@webkit.org> 22860 22861 Reviewed by Simon Fraser. 22862 22863 REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot 22864 https://bugs.webkit.org/show_bug.cgi?id=38912 22865 22866 I know of nothing else to do but skip all media tests for the cq. 22867 22868 * Scripts/webkitpy/tool/steps/runtests.py: 22869 228702010-08-25 Dirk Pranke <dpranke@chromium.org> 22871 22872 Reviewed by Ojan Vafai. 22873 22874 new-run-webkit-tests: add more unit tests for test_expectations 22875 This adds unit tests to cover (almost?) all of the non-rebaselining 22876 functionality. 22877 22878 https://bugs.webkit.org/show_bug.cgi?id=44579 22879 22880 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 22881 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 22882 228832010-08-25 Dirk Pranke <dpranke@chromium.org> 22884 22885 Reviewed by Ojan Vafai. 22886 22887 new-run-webkit-tests: add more unit tests 22888 22889 This change adds more unit tests for the image_diff, test_failures, 22890 and test_files modules, bringing them to 100% coverage (and adds a 22891 couple tests to run_webkit_tests while we're at it). 22892 22893 This test also turns on the "dryrun" port for testing when run on 22894 the mac, increasing coverage in a few other places. 22895 22896 https://bugs.webkit.org/show_bug.cgi?id=44578 22897 22898 * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added. 22899 * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added. 22900 * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added. 22901 * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html. 22902 * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added. 22903 * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added. 22904 * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html. 22905 * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added. 22906 * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt: 22907 * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added. 22908 * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: 22909 * Scripts/webkitpy/layout_tests/port/test.py: 22910 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 22911 229122010-08-25 Dirk Pranke <dpranke@chromium.org> 22913 22914 Reviewed by Ojan Vafai. 22915 22916 new-run-webkit-tests: add more unit tests for layout_package/printing.py 22917 22918 This change adds more unit tests to get the test coverage to 100% 22919 for the printing module. This code is actually pretty crufty and 22920 has some layering violations that need to be cleaned up but I'll 22921 save that for another CL after we get all the unit tests written and 22922 we fix the multithreading issues. At least now we'll be able to tell 22923 if we break things. 22924 22925 https://bugs.webkit.org/show_bug.cgi?id=44576 22926 22927 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 22928 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 22929 229302010-08-25 Ojan Vafai <ojan@chromium.org> 22931 22932 Reviewed by Adam Barth. 22933 22934 new-run-webkit-tests should respect set-webkit-configuration 22935 https://bugs.webkit.org/show_bug.cgi?id=44633 22936 22937 Moves the getting of the configuration into the base Port so that 22938 chromium ports use it as well. In the downstream chromium port, 22939 this should still just return Release. 22940 22941 * Scripts/webkitpy/layout_tests/port/base.py: 22942 * Scripts/webkitpy/layout_tests/port/webkit.py: 22943 229442010-08-25 Tony Chang <tony@chromium.org> 22945 22946 Not reviewed, changing svn props for a script. 22947 22948 * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style. 22949 229502010-08-25 Adam Barth <abarth@webkit.org> 22951 22952 Reviewed by Eric Seidel. 22953 22954 Remove WebKit2 from core builders 22955 https://bugs.webkit.org/show_bug.cgi?id=44625 22956 22957 This builder was added to the core builders by accident. It doesn't 22958 appear to be green enough to be a core builder yet. 22959 22960 * Scripts/webkitpy/common/net/buildbot.py: 22961 * Scripts/webkitpy/common/net/buildbot_unittest.py: 22962 229632010-08-19 Adam Roben <aroben@apple.com> 22964 22965 Test that NP_Initialize and NP_GetEntryPoints are called in the 22966 correct order 22967 22968 The order differs between Mac and Windows (see r38858). 22969 22970 Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in 22971 NP_Initialize when loading QuickTime when running 22972 plugins/embed-attributes-setting.html in WebKit2 on Windows 22973 22974 Reviewed by John Sullivan. 22975 22976 * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and 22977 a boolean to record whether NP_GetEntryPoints has been called. 22978 (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been 22979 called yet. This matches Flash and QuickTime's behavior. 22980 (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called 22981 yet. This matches Silverlight's behavior. 22982 229832010-08-25 Martin Robinson <mrobinson@igalia.com> 22984 22985 Reviewed by Gustavo Noronha Silva. 22986 22987 Cairo and EFL port shouldn't depend on glib. 22988 https://bugs.webkit.org/show_bug.cgi?id=44354 22989 22990 Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and 22991 adoptPlatformRef. 22992 22993 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 22994 (AccessibilityUIElement::isSelected): 22995 229962010-08-25 Ojan Vafai <ojan@chromium.org> 22997 22998 Fix order of Timothy's email address. The script, and 22999 other tools all assume that the first email is the bugzilla address. 23000 23001 * Scripts/webkitpy/common/config/committers.py: 23002 230032010-08-24 Kent Tamura <tkent@chromium.org> 23004 23005 Reviewed by Pavel Feldman. 23006 23007 [DRT/Chromium] Fix 26 inspector test crashes 23008 https://bugs.webkit.org/show_bug.cgi?id=44580 23009 23010 - DRTDevToolsAgent has a reference to the main WebView. So we 23011 should not clear it in closeDevTools() and should clear it in 23012 ~TestShell(). 23013 - DRTDevToolsClient has a reference to a DevTools WebView and no 23014 way to update it. So we should delete DRTDevToolsClient instances 23015 in closeDevTools(). 23016 23017 * DumpRenderTree/chromium/TestShell.cpp: 23018 (TestShell::~TestShell): 23019 (TestShell::closeDevTools): 23020 230212010-08-24 Eric Seidel <eric@webkit.org> 23022 23023 Reviewed by Adam Barth. 23024 23025 unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this 23026 https://bugs.webkit.org/show_bug.cgi?id=44584 23027 23028 * Scripts/webkitpy/tool/commands/queues_unittest.py: 23029 230302010-08-24 Eric Seidel <eric@webkit.org> 23031 23032 Reviewed by Adam Barth. 23033 23034 commit-queue and EWS bots should report all failures 23035 https://bugs.webkit.org/show_bug.cgi?id=41820 23036 23037 Right now commit-queue/EWS only report failures when the 23038 patch under testing fails. We should report all failures 23039 to the status server so that we can diagnose when the bots 23040 are wedged w/o needing to log into the machines. 23041 23042 I also reduced the amount of data we upload since we've seen 23043 timeouts during status upload. 23044 23045 * Scripts/webkitpy/common/system/executive.py: 23046 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 23047 * Scripts/webkitpy/tool/commands/queues.py: 23048 * Scripts/webkitpy/tool/commands/queues_unittest.py: 23049 230502010-08-24 Eric Seidel <eric@webkit.org> 23051 23052 Reviewed by Adam Barth. 23053 23054 Remove HTML5 parser testing infrastructure now that we don't need it 23055 https://bugs.webkit.org/show_bug.cgi?id=44581 23056 23057 * DumpRenderTree/mac/DumpRenderTree.mm: 23058 (resetDefaultsToConsistentValues): 23059 (initializeGlobalsFromCommandLineOptions): 23060 * Scripts/old-run-webkit-tests: 23061 * Scripts/test-html5-parser: Removed. 23062 230632010-08-24 Kent Tamura <tkent@chromium.org> 23064 23065 Reviewed by Dimitri Glazkov. 23066 23067 [DRT/Chromium] Fix 28 inspector test crashes 23068 https://bugs.webkit.org/show_bug.cgi?id=44574 23069 23070 Reset DevToolsClient and DevToolsAgent before closing a DevTools 23071 WebView in order to avoid accessing to a deleted WebView instance. 23072 23073 * DumpRenderTree/chromium/TestShell.cpp: 23074 (TestShell::closeDevTools): 23075 230762010-08-24 Dirk Pranke <dpranke@chromium.org> 23077 23078 Reviewed by Ojan Vafai. 23079 23080 new-run-webkit-tests: clean up code for test_types, test_failures 23081 23082 Add a bunch of unit tests for webkitpy.layout_tests.test_types and 23083 webkitpy.layout_tests.layout_package.test_failures, and remove 23084 some dead code and otherwise clean up things. 23085 23086 https://bugs.webkit.org/show_bug.cgi?id=44559 23087 23088 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 23089 * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added. 23090 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 23091 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 23092 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 23093 * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added. 23094 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 23095 230962010-08-24 Dirk Pranke <dpranke@chromium.org> 23097 23098 Reviewed by Eric Seidel. 23099 23100 new-run-webkit-tests: revise unit testing strategy for test failures 23101 23102 This change revamps the way we store test data for new-run-webkit-tests. 23103 Previously we had a few copies of test files from the main test tree. 23104 Now we have a bunch of completely fake test data and use the test 23105 data to generate different kinds of test failures, getting 23106 much better coverage. 23107 23108 https://bugs.webkit.org/show_bug.cgi?id=44556 23109 23110 * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added. 23111 * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added. 23112 * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added. 23113 * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added. 23114 * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added. 23115 * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added. 23116 * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added. 23117 * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added. 23118 * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added. 23119 * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added. 23120 * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added. 23121 * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added. 23122 * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added. 23123 * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added. 23124 * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added. 23125 * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added. 23126 * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added. 23127 * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed. 23128 * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed. 23129 * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed. 23130 * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed. 23131 * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed. 23132 * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed. 23133 * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed. 23134 * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed. 23135 * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed. 23136 * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed. 23137 * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added. 23138 * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added. 23139 * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added. 23140 * Scripts/webkitpy/layout_tests/data/passes/image.html: Added. 23141 * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added. 23142 * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added. 23143 * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added. 23144 * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added. 23145 * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added. 23146 * Scripts/webkitpy/layout_tests/data/passes/text.html: Added. 23147 * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed. 23148 * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed. 23149 * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed. 23150 * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added. 23151 * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added. 23152 * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added. 23153 * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt: 23154 * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed. 23155 * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed. 23156 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 23157 * Scripts/webkitpy/layout_tests/port/test.py: 23158 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 23159 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: 23160 231612010-08-24 Dirk Pranke <dpranke@chromium.org> 23162 23163 Reviewed by Eric Seidel. 23164 23165 speed up new-run-webkit-tests unit tests 23166 23167 Add a --no-record-results flag that turns off generating the JSON 23168 results file on every test run. Generating the file requires us to 23169 fetch the old results down from the bots, which can be slow. This 23170 flag is off by default. 23171 23172 Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s. 23173 23174 These changes together shorten the test cycle from ~4.5s to ~1.5s 23175 - a 3x speedup. 23176 23177 https://bugs.webkit.org/show_bug.cgi?id=44553 23178 23179 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 23180 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 23181 231822010-08-24 Tony Chang <tony@chromium.org> 23183 23184 Reviewed by Eric Seidel. 23185 23186 [chromium] fix the platform result fallback order on mac/win 23187 https://bugs.webkit.org/show_bug.cgi?id=44483 23188 23189 * Scripts/webkitpy/layout_tests/port/google_chrome.py: 23190 231912010-08-24 Xan Lopez <xlopez@igalia.com> 23192 23193 Reviewed by Martin Robinson. 23194 23195 Set a device to the event struct when building with GTK+ 3.x, it's 23196 mandatory. 23197 23198 * DumpRenderTree/gtk/EventSender.cpp: 23199 (keyDownCallback): 23200 232012010-08-24 Martin Robinson <mrobinson@igalia.com> 23202 23203 Reviewed by Xan Lopez. 23204 23205 [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events 23206 https://bugs.webkit.org/show_bug.cgi?id=44534 23207 23208 Fix two double-frees introduced in my previous commit. 23209 23210 * DumpRenderTree/gtk/EventSender.cpp: 23211 (contextClickCallback): Copy the event before using it again. 23212 (keyDownCallback): Ditto. 23213 232142010-08-24 Martin Robinson <mrobinson@igalia.com> 23215 23216 Reviewed by Xan Lopez. 23217 23218 [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events 23219 https://bugs.webkit.org/show_bug.cgi?id=44534 23220 23221 * DumpRenderTree/gtk/EventSender.cpp: 23222 (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow 23223 when setting it on the event. It is dereferenced by gdk_event_free(...). 23224 (contextClickCallback): Ditto. 23225 (mouseDownCallback): Ditto. 23226 (mouseUpCallback): Ditto. 23227 (mouseMoveToCallback): Ditto. 23228 (mouseWheelToCallback): Ditto. 23229 (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent. 23230 (dispatchEvent): Ditto. Also free the event when we are done with it. 23231 (keyDownCallback): Use gdk_event_new and reference the GdkWindow. 23232 232332010-08-24 Andras Becsi <abecsi@webkit.org> 23234 23235 [Qt] WebKit2 build fix. 23236 23237 * Scripts/enumerate-included-framework-headers: 23238 Remove stray global option form sed. 23239 232402010-08-24 Kent Tamura <tkent@chromium.org> 23241 23242 Reviewed by Jeremy Orlow. 23243 23244 [DRT/Chromium] Support for IndexedDB tests 23245 https://bugs.webkit.org/show_bug.cgi?id=44490 23246 23247 * DumpRenderTree/chromium/TestShell.cpp: 23248 (TestShell::TestShell): Enable IndexedDB. 23249 232502010-08-23 Martin Robinson <mrobinson@igalia.com> 23251 23252 Reviewed by Gustavo Noronha Silva. 23253 23254 [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons 23255 https://bugs.webkit.org/show_bug.cgi?id=44465 23256 23257 Initialize the axes field of mouse button and motion events to null. 23258 This is the value that should be used for events originating from the 23259 mouse device. 23260 23261 * DumpRenderTree/gtk/EventSender.cpp: 23262 (prepareMouseButtonEvent): Initalize button event axes field to null. 23263 (mouseMoveToCallback): Initialize motion event axes field to null. 23264 232652010-08-23 Sheriff Bot <webkit.review.bot@gmail.com> 23266 23267 Unreviewed, rolling out r65703. 23268 http://trac.webkit.org/changeset/65703 23269 https://bugs.webkit.org/show_bug.cgi?id=44460 23270 23271 "Causing lots of crashes on Snow Leopard when running the 23272 layout tests" (Requested by eseidel2 on #webkit). 23273 23274 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 23275 (NP_Initialize): 23276 (NP_GetEntryPoints): 23277 232782010-08-23 Jon Honeycutt <jhoneycutt@apple.com> 23279 23280 Layout tests do not run when using WebKitTestRunner in a Debug build. 23281 https://bugs.webkit.org/show_bug.cgi?id=44409 23282 23283 Reviewed by Dan Bernstein. 23284 23285 * WebKitTestRunner/win/TestControllerWin.cpp: 23286 (WTR::TestController::initializeInjectedBundlePath): 23287 Use InjectedBundle_debug.dll when building Debug. 23288 232892010-08-23 Xan Lopez <xlopez@igalia.com> 23290 23291 Reviewed by Martin Robinson. 23292 23293 [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support 23294 https://bugs.webkit.org/show_bug.cgi?id=42026 23295 23296 If a GTK+ 3.x build is present return that as the library to use, 23297 otherwise fallback to the GTK+ 2.x build. 23298 23299 * Scripts/webkitdirs.pm: 23300 233012010-08-23 Balazs Kelemen <kb@inf.u-szeged.hu> 23302 23303 Reviewed by Ariya Hidayat. 23304 23305 [Qt] Find needed forwarding headers for WebKit2 automatically 23306 https://bugs.webkit.org/show_bug.cgi?id=44336 23307 23308 * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here. 23309 The new script does not satisfy the needs of this file however using normal includes 23310 is generally better here. 23311 * MiniBrowser/qt/MiniBrowser.pro: Added include paths. 23312 * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 23313 given frameworks by files in the current directory (and subdirectories). 23314 In the future this needs to be rewritten in perl for being able to use on Windows. 23315 233162010-08-22 No'am Rosenthal <noam.rosenthal@nokia.com> 23317 23318 Reviewed by Ariya Hidayat. 23319 23320 [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument 23321 https://bugs.webkit.org/show_bug.cgi?id=43010 23322 23323 * QtTestBrowser/launcherwindow.cpp: 23324 (LauncherWindow::applyPrefs): 23325 * QtTestBrowser/main.cpp: 23326 (LauncherApplication::handleUserOptions): 23327 233282010-08-21 Sam Weinig <sam@webkit.org> 23329 23330 Reviewed by Dan Bernstein. 23331 23332 Remove specialized retain/release functions in favor of a single one for WKTypeRefs 23333 https://bugs.webkit.org/show_bug.cgi?id=44386 23334 23335 * MiniBrowser/mac/AppDelegate.m: 23336 (didRecieveMessageFromInjectedBundle): 23337 (didNavigateWithNavigationData): 23338 (-[BrowserAppDelegate init]): 23339 (-[BrowserAppDelegate applicationWillTerminate:]): 23340 * MiniBrowser/mac/BrowserStatisticsWindowController.m: 23341 (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]): 23342 (-[BrowserStatisticsWindowController dealloc]): 23343 * MiniBrowser/mac/BrowserWindowController.m: 23344 (-[BrowserWindowController initWithPageNamespace:]): 23345 (-[BrowserWindowController fetch:]): 23346 (-[BrowserWindowController windowWillClose:]): 23347 (-[BrowserWindowController applicationTerminating]): 23348 (closePage): 23349 (runJavaScriptAlert): 23350 (runJavaScriptConfirm): 23351 (runJavaScriptPrompt): 23352 (-[BrowserWindowController updateProvisionalURLForFrame:]): 23353 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 23354 (didClearWindowObjectForFrame): 23355 * MiniBrowser/win/BrowserView.cpp: 23356 (BrowserView::goToURL): 23357 * WebKitTestRunner/win/PlatformWebViewWin.cpp: 23358 (WTR::PlatformWebView::~PlatformWebView): 23359 233602010-08-20 Benjamin Poulain <benjamin.poulain@nokia.com> 23361 23362 Reviewed by Kenneth Rohde Christiansen. 23363 23364 WebKit does not build with Python 2.3 23365 https://bugs.webkit.org/show_bug.cgi?id=44373 23366 23367 Replaced the function sorted() by a call to sort() 23368 on the entry list. 23369 The function sorted() has been added to Python 2.4. 23370 The function method sort() of List works with older 23371 versions of Python. 23372 23373 * Scripts/create-html-entity-table: 23374 233752010-08-20 Martin Robinson <mrobinson@igalia.com> 23376 23377 Reviewed by Pavel Feldman. 23378 23379 Web Inspector: Inspector tests were disabled for GTK. 23380 https://bugs.webkit.org/show_bug.cgi?id=43977 23381 23382 * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate 23383 path before running tests. 23384 233852010-08-20 Daniel Bates <dbates@rim.com> 23386 23387 Reviewed by Eric Seidel. 23388 23389 svn-apply doesn't detect empty line with Windows line endings 23390 after property value 23391 https://bugs.webkit.org/show_bug.cgi?id=43981 23392 23393 Part 2 of 2 23394 23395 Add unit tests that were not landed in the first commit. 23396 23397 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: 23398 - Added the following test cases: 23399 "SVN: binary file (isBinary true) using Windows line endings" 23400 "SVN: property diff, followed by file change diff using Windows line endings" 23401 "SVN: two consecutive property diffs using Windows line endings" 23402 "SVN: binary file with executable bit change usng Windows line endings" 23403 "SVN: binary file followed by property change on different file using Windows line endings" 23404 "SVN: binary file followed by file change on different file using Windows line endings" 23405 "SVN: file change diff with property change, followed by property change diff using Windows line endings" 23406 "SVN: file change diff with property change, followed by file change diff using Windows line endings" 23407 * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: 23408 - Added the following test cases: 23409 "add svn:executable, followed by empty line and start of next diff using Windows line endings" 23410 "add svn:executable, followed by empty line and start of next property diff using Windows line endings" 23411 "multi-line '+' change, followed by empty line and start of next diff using Windows line endings" 23412 "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings" 23413 "add svn:executable, followed by empty line and start of binary patch using Windows line endings" 23414 "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings" 23415 "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings" 23416 "single-line '+' with trailing new line using Windows line endings" 23417 "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings" 23418 "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings" 23419 "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings" 23420 * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl: 23421 - Added the following test cases: 23422 "single-line '-' change followed by empty line with Windows line endings" 23423 "multi-line '+' change and start of binary patch with Windows line endings" 23424 234252010-08-20 Daniel Bates <dbates@rim.com> 23426 23427 Reviewed by Eric Seidel. 23428 23429 svn-apply doesn't detect empty line with Windows line endings 23430 after property value 23431 https://bugs.webkit.org/show_bug.cgi?id=43981 23432 23433 Fixes an issue where an empty line following the property value 23434 in an SVN property change diff would not be detected if it had 23435 Windows line endings (i.e. ended in CRLF). Hence it was consumed 23436 as if it was part of a multi-line property value. 23437 23438 * Scripts/VCSUtils.pm: 23439 - Modified parseSvnPropertyValue() to detect empty line 23440 with Windows line endings. 23441 - Added toWindowsLineEndings(). 23442 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: 23443 - Added the following test cases: 23444 "SVN: binary file (isBinary true) using Windows line endings" 23445 "SVN: property diff, followed by file change diff using Windows line endings" 23446 "SVN: two consecutive property diffs using Windows line endings" 23447 "SVN: binary file with executable bit change usng Windows line endings" 23448 "SVN: binary file followed by property change on different file using Windows line endings" 23449 "SVN: binary file followed by file change on different file using Windows line endings" 23450 "SVN: file change diff with property change, followed by property change diff using Windows line endings" 23451 "SVN: file change diff with property change, followed by file change diff using Windows line endings" 23452 * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: 23453 - Added the following test cases: 23454 "add svn:executable, followed by empty line and start of next diff using Windows line endings" 23455 "add svn:executable, followed by empty line and start of next property diff using Windows line endings" 23456 "multi-line '+' change, followed by empty line and start of next diff using Windows line endings" 23457 "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings" 23458 "add svn:executable, followed by empty line and start of binary patch using Windows line endings" 23459 "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings" 23460 "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings" 23461 "single-line '+' with trailing new line using Windows line endings" 23462 "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings" 23463 "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings" 23464 "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings" 23465 * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl: 23466 - Added the following test cases: 23467 "single-line '-' change followed by empty line with Windows line endings" 23468 "multi-line '+' change and start of binary patch with Windows line endings" 23469 234702010-08-19 David Kilzer <ddkilzer@apple.com> 23471 23472 BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins 23473 23474 * MiniBrowser/mac/BrowserWindowController.m: 23475 (decidePolicyForNavigationAction): Updated method signature. 23476 (decidePolicyForNewWindowAction): Updated method signature. 23477 234782010-08-19 Adam Roben <aroben@apple.com> 23479 23480 Test that NP_Initialize and NP_GetEntryPoints are called in the 23481 correct order 23482 23483 The order differs between Mac and Windows (see r38858). 23484 23485 Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in 23486 NP_Initialize when loading QuickTime when running 23487 plugins/embed-attributes-setting.html in WebKit2 on Windows 23488 23489 Reviewed by Sam Weinig. 23490 23491 * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and 23492 a boolean to record whether NP_GetEntryPoints has been called. 23493 (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been 23494 called yet. This matches Flash and QuickTime's behavior. Crash on Mac 23495 if NP_GetEntryPoints has been called already. This matches 23496 Silverlight's behavior. 23497 234982010-08-19 Adam Roben <aroben@apple.com> 23499 23500 Make build-webkittestrunner build TestNetscapePlugIn on Windows 23501 23502 Fixes <http://webkit.org/b/44268> <rdar://problem/8330388> 23503 23504 Reviewed by Sam Weinig. 23505 23506 * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn. 23507 Threaded it in between ImageDiff and InjectedBundleGenerated. 23508 235092010-08-19 Ojan Vafai <ojan@chromium.org> 23510 23511 Reviewed by Adam Barth. 23512 23513 install rietveld's upload script from a versioned url 23514 https://bugs.webkit.org/show_bug.cgi?id=44291 23515 23516 autoinstall expects the file at a given URL to never change. 23517 In order to be able to update the file, we need to be able to 23518 change the path. 23519 23520 * Scripts/webkitpy/thirdparty/__init__.py: 23521 235222010-08-19 Ojan Vafai <ojan@chromium.org> 23523 23524 Reviewed by Adam Barth. 23525 23526 add --webkit_patch_id to reitveld uploads 23527 https://bugs.webkit.org/show_bug.cgi?id=44289 23528 23529 This is the first step in having rietveld store which 23530 patches have been uploaded and getting rid of the 23531 in-rietveld flag. 23532 23533 * Scripts/webkitpy/common/net/rietveld.py: 23534 * Scripts/webkitpy/tool/mocktool.py: 23535 * Scripts/webkitpy/tool/steps/postcodereview.py: 23536 235372010-08-19 Kenneth Russell <kbr@google.com> 23538 23539 Reviewed by David Levin. 23540 23541 Adjust my status from committer to reviewer 23542 https://bugs.webkit.org/show_bug.cgi?id=44277 23543 23544 * Scripts/webkitpy/common/config/committers.py: 23545 235462010-08-19 Pavel Feldman <pfeldman@chromium.org> 23547 23548 Reviewed by Yury Semikhatsky. 23549 23550 Chromium DevTools: remove injected script fetcher from test harness. 23551 https://bugs.webkit.org/show_bug.cgi?id=44266 23552 23553 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: 23554 * DumpRenderTree/chromium/DRTDevToolsAgent.h: 23555 235562010-08-19 Pavel Feldman <pfeldman@chromium.org> 23557 23558 Reviewed by Yury Semikhatsky. 23559 23560 Chromium DevTools: There is no need in resource-based InjectedScript.js source. 23561 Now that we populate front-end after its onload handler, we don't need 23562 to install injected script early. Exposing injected script source on the WebCore 23563 level here. 23564 https://bugs.webkit.org/show_bug.cgi?id=44029 23565 23566 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: 23567 (DRTDevToolsAgent::runtimePropertyChanged): 23568 (DRTDevToolsAgent::delayedFrontendLoaded): 23569 (DRTDevToolsAgent::frontendLoaded): 23570 * DumpRenderTree/chromium/DRTDevToolsAgent.h: 23571 235722010-08-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 23573 23574 Reviewed by Kenneth Rohde Christiansen. 23575 23576 [Gtk] Enable view mode media feature layout test 23577 https://bugs.webkit.org/show_bug.cgi?id=43278 23578 23579 Add view mode media feature testing infrastructure, and add 23580 placeholder methods for the other platforms' 23581 LayoutTestControllers. 23582 23583 * DumpRenderTree/LayoutTestController.cpp: 23584 (setViewModeMediaFeatureCallback): 23585 (LayoutTestController::staticFunctions): 23586 * DumpRenderTree/LayoutTestController.h: 23587 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 23588 (LayoutTestController::setViewModeMediaFeature): 23589 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 23590 (LayoutTestController::setViewModeMediaFeature): 23591 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 23592 (LayoutTestController::setViewModeMediaFeature): 23593 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 23594 (LayoutTestController::setViewModeMediaFeature): 23595 235962010-08-18 Mark Rowe <mrowe@apple.com> 23597 23598 Reviewed by Sam Weinig. 23599 23600 Make it so the WebKit2 test slave runs the WebKit2 tests 23601 23602 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 23603 236042010-08-18 Sam Weinig <sam@webkit.org> 23605 23606 Reviewed by Mark Rowe. 23607 23608 Make run-webkit-tests --webkit-test-runner build DumpRenderTree 23609 in addition to WebKitTestRunner to get the DumpRenderTreeSupport 23610 module and the TestNetscapePlugin. 23611 23612 * Scripts/old-run-webkit-tests: 23613 236142010-08-18 Adam Roben <aroben@apple.com> 23615 23616 Fix hang when saving crash logs on Windows 23617 23618 * Scripts/old-run-webkit-tests: 23619 (setUpWindowsCrashLogSaving): 23620 (END): 23621 Pass -s to regtool so it will write the Auto value as a string instead 23622 of as a number. This was causing a "do you want to debug?" dialog to 23623 appear. 23624 236252010-08-17 Victor Wang <victorw@chromium.org> 23626 23627 Unreviewed. Fixed chromium incremental test json upload. 23628 Quote builder name and test results server in url. 23629 23630 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 23631 236322010-08-17 Laszlo Gombos <laszlo.1.gombos@nokia.com> 23633 23634 Reviewed by Ariya Hidayat. 23635 23636 [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies 23637 https://bugs.webkit.org/show_bug.cgi?id=44124 23638 23639 Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 23640 Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark 23641 Symbian dependencies. 23642 23643 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 23644 (WebCore::DumpRenderTree::open): 23645 * QtTestBrowser/launcherwindow.cpp: 23646 (LauncherWindow::init): 23647 (LauncherWindow::toggleFullScreenMode): 23648 (LauncherWindow::showFPS): 23649 (LauncherWindow::updateFPS): 23650 * QtTestBrowser/launcherwindow.h: 23651 (WindowOptions::WindowOptions): 23652 * QtTestBrowser/mainwindow.cpp: 23653 (MainWindow::buildUI): 23654 236552010-08-17 Dirk Pranke <dpranke@chromium.org> 23656 23657 Reviewed by David Levin. 23658 23659 new-run-webkit-tests: remove --show-sources option 23660 23661 --show-sources is pretty much obsolete with --trace everything, so 23662 I'm removing it. 23663 23664 Also rename a couple of methods in the TestTextDiff class to make their 23665 intended visibility (private) more obvious. 23666 23667 https://bugs.webkit.org/show_bug.cgi?id=44143 23668 23669 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 23670 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 23671 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 23672 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 23673 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 23674 236752010-08-17 Dirk Pranke <dpranke@chromium.org> 23676 23677 Reviewed by David Levin. 23678 23679 remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work) 23680 23681 This code bit-rotted at some point more than a year ago, and nobody seems 23682 to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests 23683 should support instead, making this flag unnecessary anyway. 23684 23685 https://bugs.webkit.org/show_bug.cgi?id=44141 23686 23687 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 23688 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 23689 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed. 23690 236912010-08-17 Victor Wang <victorw@chromium.org> 23692 23693 Reviewed by Ojan Vafai. 23694 23695 Update json results generator to have incremental json including 23696 results for tests that pass in current run but failed before. 23697 23698 https://bugs.webkit.org/show_bug.cgi?id=44119 23699 23700 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 23701 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 23702 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 23703 237042010-08-17 Dirk Pranke <dpranke@chromium.org> 23705 23706 Reviewed by Eric Seidel. 23707 23708 fix test-webkitpy, add easy way to find a checkout root 23709 23710 test-webkitpy currently doesn't work right if run from someplace other 23711 than the checkout root, and it spews a bunch of debug logging because 23712 the deduplicate_tests tests contaminates the test environment. 23713 23714 This patch cleans up the deduplicate_tests unit tests, and creates 23715 two new methods in scm.py: find_checkout_root() and default_scm(), 23716 both of which use a single algorithm for guessing what checkout root 23717 to use if you aren't explicitly told one from a path. 23718 23719 https://bugs.webkit.org/show_bug.cgi?id=44001 23720 23721 * Scripts/deduplicate-tests: 23722 * Scripts/webkitpy/common/checkout/scm.py: 23723 * Scripts/webkitpy/common/checkout/scm_unittest.py: 23724 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: 23725 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 23726 * Scripts/webkitpy/layout_tests/port/test.py: 23727 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 23728 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 23729 * Scripts/webkitpy/tool/main.py: 23730 237312010-08-17 Victor Wang <victorw@chromium.org> 23732 23733 Reviewed by Ojan Vafai. 23734 23735 Add support to the test results server for downloading json that 23736 contains test list only. 23737 23738 This is for json results generator to generate incremental json 23739 results so that it includes results not only for tests failed in 23740 current run, but also tests failed before. 23741 23742 Also set the results type to "N" (no data) instead of "P" (pass) 23743 if test results cannot be found in incremental json file. 23744 23745 https://bugs.webkit.org/show_bug.cgi?id=44117 23746 23747 * TestResultServer/handlers/testfilehandler.py: 23748 * TestResultServer/model/jsonresults.py: 23749 * TestResultServer/model/jsonresults_unittest.py: 23750 237512010-08-17 Adam Roben <aroben@apple.com> 23752 23753 Use the right path style 23754 23755 * Scripts/old-run-webkit-tests: 23756 237572010-08-17 Adam Roben <aroben@apple.com> 23758 23759 Fix typo 23760 23761 * Scripts/old-run-webkit-tests: 23762 237632010-08-17 Adam Roben <aroben@apple.com> 23764 23765 Don't hang when running run-webkit-tests as a non-Administrator on 23766 Vista/7 23767 23768 * Scripts/old-run-webkit-tests: 23769 (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the 23770 post-mortem debugger, rather than using NTSD itself. The latter waits 23771 for user input when it fails to set the registry values; the former 23772 does not. 23773 237742010-08-17 Adam Roben <aroben@apple.com> 23775 23776 Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to 23777 save crash logs on Windows 23778 23779 The crash logs are saved to /tmp/layout-test-results and have names 23780 like CrashLog_02bc_2010-08-17_14-36-20-108.txt. 23781 23782 Unfortunately, crashes in the WebKit2 web process are recorded as 23783 time-outs by run-webkit-tests. Fixing this is covered by 23784 <http://webkit.org/b/44121>. 23785 23786 Fixes <http://webkit.org/b/37859> <rdar://problem/7883560> 23787 DumpRenderTree should save a stack trace and/or dump file when it 23788 crashes 23789 23790 Reviewed by Sam Weinig. 23791 23792 * DumpRenderTree/win/DumpRenderTree.cpp: 23793 (exceptionFilter): 23794 (main): 23795 * WebKitTestRunner/win/TestControllerWin.cpp: 23796 (WTR::exceptionFilter): 23797 (WTR::TestController::platformInitialize): 23798 These changes set up an exception filter that prints #CRASHED to 23799 stderr, then lets the exception propagate normally. This allows 23800 run-webkit-tests to detect when we've crashed even when a post-mortem 23801 debugger attaches to the process. 23802 23803 * Scripts/old-run-webkit-tests: 23804 (top level): Declared some variables used by the crash-log-saving 23805 code. 23806 (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so 23807 that the post-mortem debugger has access to it. 23808 (toCygwinPath): Added. This is the opposite of toWindowsPath. 23809 (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to 23810 stderr, consider it a crash. 23811 (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem 23812 debugger, then sets ntsd as the post-mortem debugger. ntsd is 23813 configured to save a crash log and then quit automatically. 23814 (END): Added. Restores the previous post-mortem debugger when the 23815 script exits. 23816 238172010-08-17 Victor Wang <victorw@chromium.org> 23818 23819 Reviewed by ojan@chromium.org. 23820 23821 Update test results server: 23822 1. Normalize test results and times after merging (prune tests where 23823 all runs pass or do not have data, truncate all test items to max 23824 number of builds) 23825 2. times should be int not string. 23826 3. when inserting a new test item, should keep old data regardless 23827 whether or not they have same item type with new one. 23828 23829 https://bugs.webkit.org/show_bug.cgi?id=43861 23830 23831 * TestResultServer/model/jsonresults.py: 23832 * TestResultServer/model/jsonresults_unittest.py: 23833 238342010-08-16 Sam Weinig <sam@webkit.org> 23835 23836 Reviewed by Mark Rowe. 23837 23838 Add WebKit2 Mac tester to buildbot. 23839 23840 * BuildSlaveSupport/build.webkit.org-config/config.json: 23841 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 23842 238432010-08-16 Paul Sawaya <psawaya@apple.com> 23844 23845 Reviewed by Chris Marrin. 23846 23847 Added shader validation via ANGLE 23848 https://bugs.webkit.org/show_bug.cgi?id=42405 23849 23850 Added ANGLE to webkit build 23851 23852 * Scripts/build-webkit: 23853 238542010-08-16 Kevin Ollivier <kevino@theolliviers.com> 23855 23856 [wx] Build fix, do not build WebCore as a convenience library as this leads to 23857 errors in the Win build w/export symbols and causes problems with DOM bindings 23858 debugging in gdb. 23859 23860 * DumpRenderTree/wscript: 23861 * Scripts/build-webkit: 23862 * wx/browser/wscript: 23863 * wx/build/settings.py: 23864 * wx/build/waf_extensions.py: 23865 238662010-08-16 Dan Bernstein <mitz@apple.com> 23867 23868 Build fix. 23869 23870 * WebKitTestRunner/TestController.cpp: 23871 (WTR::createOtherPage): Initialize the contentsSizeChanged member. 23872 (WTR::TestController::initialize): Ditto. 23873 238742010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu> 23875 23876 Reviewed by Kenneth Rohde Christiansen. 23877 23878 Handle content size change in WebKit2 23879 Re-landing after fix. 23880 23881 https://bugs.webkit.org/show_bug.cgi?id=43198 23882 23883 * MiniBrowser/mac/BrowserWindowController.m: 23884 (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0. 23885 * MiniBrowser/win/BrowserView.cpp: 23886 (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0. 23887 238882010-08-16 Sheriff Bot <webkit.review.bot@gmail.com> 23889 23890 Unreviewed, rolling out r65419. 23891 http://trac.webkit.org/changeset/65419 23892 https://bugs.webkit.org/show_bug.cgi?id=44053 23893 23894 Broke the Windows build (Requested by bbandix on #webkit). 23895 23896 * MiniBrowser/mac/BrowserWindowController.m: 23897 (-[BrowserWindowController awakeFromNib]): 23898 * MiniBrowser/win/BrowserView.cpp: 23899 (BrowserView::create): 23900 239012010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu> 23902 23903 Reviewed by Kenneth Rohde Christiansen. 23904 23905 Handle content size change in WebKit2 23906 23907 https://bugs.webkit.org/show_bug.cgi?id=43198 23908 23909 * MiniBrowser/mac/BrowserWindowController.m: 23910 (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0. 23911 * MiniBrowser/win/BrowserView.cpp: 23912 (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0. 23913 239142010-08-16 Ariya Hidayat <ariya@sencha.com> 23915 23916 Add my new email address to committers.py. 23917 23918 * Scripts/webkitpy/common/config/committers.py: 23919 239202010-08-16 Zoltan Horvath <zoltan@webkit.org> 23921 23922 Add my old e-mail addresses to committers.py. 23923 23924 * Scripts/webkitpy/common/config/committers.py: 23925 239262010-08-15 Jon Honeycutt <jhoneycutt@apple.com> 23927 23928 WebEditorClient::didBeginEditing is never called in WebKit2 23929 https://bugs.webkit.org/show_bug.cgi?id=42939 23930 23931 Reviewed by Sam Weinig. 23932 23933 * WebKitTestRunner/PlatformWebView.h: 23934 Declare focus(). 23935 23936 * WebKitTestRunner/TestController.cpp: 23937 (WTR::TestController::resetStateToConsistentValues): 23938 Focus the PlatformWebView. 23939 23940 * WebKitTestRunner/mac/PlatformWebViewMac.mm: 23941 (WTR::PlatformWebView::focus): 23942 Stubbed. 23943 23944 * WebKitTestRunner/win/PlatformWebViewWin.cpp: 23945 (WTR::PlatformWebView::focus): 23946 Focus the view. 23947 239482010-08-15 Jon Honeycutt <jhoneycutt@apple.com> 23949 23950 run-webkit-tests should not strip editing callbacks when using 23951 WebKitTestRunner on Windows 23952 https://bugs.webkit.org/show_bug.cgi?id=44000 23953 23954 Reviewed by Mark Rowe. 23955 23956 * Scripts/old-run-webkit-tests: 23957 Leave $stripEditingCallbacks undefined until we look for command-line 23958 arguments. If using WebKit2, set it to 0 if not explicity set on the 23959 command line. Later, set it to isCygwin() to match old behavior if it is 23960 not yet defined. 23961 239622010-08-15 Kevin Ollivier <kevino@theolliviers.com> 23963 23964 [wx] Build fix, remove define always set to the correct value by wtf/Platform.h. 23965 23966 * wx/build/settings.py: 23967 239682010-08-14 Martin Robinson <mrobinson@igalia.com> 23969 23970 Reviewed by Kenneth Rohde Christiansen. 23971 23972 [GTK] autogen.sh not executed if build-webkit options change 23973 https://bugs.webkit.org/show_bug.cgi?id=42266 23974 23975 Rerun autogen.sh in situations where the arguments to build-webkit have 23976 changed since the previous build. This will fix some issues on the bots 23977 where the build does not notice changes to default build-webkit arguments. 23978 23979 * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments. 23980 239812010-08-14 Eric Seidel <eric@webkit.org> 23982 23983 Unreviewed. Another fix to support python 2.3. 23984 23985 Add support for MathML entities 23986 https://bugs.webkit.org/show_bug.cgi?id=43949 23987 23988 * Scripts/webkitpy/thirdparty/simplejson/decoder.py: 23989 - It looks like our simplejson is version 1.7.3 which 23990 should be python 2.3 compatible. But someone modified 23991 our copy slightly from the original source. 23992 I've removed the relative import in hopes this fixes 23993 the problem. 23994 239952010-08-13 Eric Seidel <eric@webkit.org> 23996 23997 Unreviewed. Build fix only. 23998 23999 Add support for MathML entities 24000 https://bugs.webkit.org/show_bug.cgi?id=43949 24001 24002 * Scripts/create-html-entity-table: 24003 - Hack sys.path to avoid executing 2.5 dependent python 24004 on systems (like chromium-win and Tiger) which do not have 2.5 python. 24005 240062010-08-13 Adam Barth <abarth@webkit.org> 24007 24008 Reviewed by Eric Seidel. 24009 24010 Rename some concepts in HTML entity search to be more self-documenting 24011 https://bugs.webkit.org/show_bug.cgi?id=44004 24012 24013 Reflect name change in generator script. 24014 24015 * Scripts/create-html-entity-table: 24016 240172010-08-12 Adam Barth <abarth@webkit.org> 24018 24019 Reviewed by Eric Seidel. 24020 24021 Add support for MathML entities 24022 https://bugs.webkit.org/show_bug.cgi?id=43949 24023 24024 A script for generating the C++ state data structure describing all the 24025 entities from a JSON description. 24026 24027 * Scripts/create-html-entity-table: Added. 24028 240292010-08-13 Dirk Pranke <dpranke@chromium.org> 24030 24031 Reviewed by Eric Seidel. 24032 24033 Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to 24034 check for exceptions on all threads, not just the first thread. 24035 24036 This change also changes the logging behavior for wedged threads 24037 to only dump the stacks of threads that are actually wedged. 24038 24039 Refactor the thread classes in the dump_render_tree_thread module 24040 to make the contract between TestRunner and TestShellThread clearer. 24041 24042 Added a bunch of unit tests. 24043 https://bugs.webkit.org/show_bug.cgi?id=38561 24044 24045 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 24046 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 24047 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 24048 240492010-08-13 Kenichi Ishibashi <bashi@google.com> 24050 24051 Reviewed by Shinichiro Hamaji. 24052 24053 Add test_expectations.txt syntax checker to check-webkit-style. 24054 https://bugs.webkit.org/show_bug.cgi?id=43899 24055 24056 Just utilizing layout_tests/layout_package/test_expectations.py for checking 24057 the syntax of test_expectations.txt. 24058 This change also moves tab checking class from style/checkers/text.py to 24059 style/checkers/common.py for sharing code. 24060 24061 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 24062 * Scripts/webkitpy/style/checker.py: 24063 * Scripts/webkitpy/style/checkers/common.py: 24064 * Scripts/webkitpy/style/checkers/common_unittest.py: 24065 * Scripts/webkitpy/style/checkers/test_expectations.py: Added. 24066 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added. 24067 * Scripts/webkitpy/style/checkers/text.py: 24068 * Scripts/webkitpy/style_references.py: 24069 240702010-08-12 Jon Honeycutt <jhoneycutt@apple.com> 24071 24072 WebKitTestRunner does not correctly resize WebView for W3C SVG tests 24073 https://bugs.webkit.org/show_bug.cgi?id=43945 24074 24075 Reviewed by Sam Weinig. 24076 24077 * WebKitTestRunner/TestInvocation.cpp: 24078 (WTR::sizeWebViewForCurrentTest): 24079 Allow for a Windows-style path. 24080 24081 * WebKitTestRunner/win/PlatformWebViewWin.cpp: 24082 (WTR::PlatformWebView::resizeTo): 24083 Call SetWindowPos to resize the view window. 24084 240852010-08-12 David Levin <levin@chromium.org> 24086 24087 Build break fix. 24088 24089 * WebKitTestRunner/TestController.cpp: 24090 (WTR::TestController::resetStateToConsistentValues): Removed usage 24091 of a variable that doesn't exist in the class. 24092 240932010-08-12 Jon Honeycutt <jhoneycutt@apple.com> 24094 24095 WebKitTestRunner needs to run tests without using native controls 24096 https://bugs.webkit.org/show_bug.cgi?id=43772 24097 24098 Reviewed by Sam Weinig. 24099 24100 * WebKitTestRunner/TestController.cpp: 24101 (WTR::TestController::initialize): 24102 Call platformInitializeContext(). 24103 24104 * WebKitTestRunner/TestController.h: 24105 Declare platformInitializeContext(). 24106 24107 * WebKitTestRunner/mac/TestControllerMac.mm: 24108 (WTR::TestController::platformInitializeContext): 24109 Stubbed. 24110 24111 * WebKitTestRunner/win/TestControllerWin.cpp: 24112 (WTR::TestController::platformInitializeContext): 24113 Call WKContextSetShouldPaintNativeControls() to disable native control 24114 drawing. 24115 241162010-08-12 Sam Weinig <sam@webkit.org> 24117 24118 Reviewed by Alexey Proskuryakov. 24119 24120 WebKitTestRunner should be more aggressive about ensuring consistent state between tests 24121 https://bugs.webkit.org/show_bug.cgi?id=43653 24122 24123 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 24124 (WTR::InjectedBundle::InjectedBundle): 24125 (WTR::InjectedBundle::didReceiveMessage): 24126 (WTR::InjectedBundle::beginTesting): 24127 (WTR::InjectedBundle::done): 24128 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 24129 (WTR::InjectedBundle::isTestRunning): 24130 (WTR::InjectedBundle::): 24131 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 24132 (WTR::InjectedBundlePage::stopLoading): 24133 (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): 24134 (WTR::InjectedBundlePage::dump): 24135 (WTR::InjectedBundlePage::didFinishLoadForFrame): 24136 (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): 24137 (WTR::InjectedBundlePage::didReceiveTitleForFrame): 24138 (WTR::InjectedBundlePage::didClearWindowForFrame): 24139 (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): 24140 (WTR::InjectedBundlePage::willAddMessageToConsole): 24141 (WTR::InjectedBundlePage::willSetStatusbarText): 24142 (WTR::InjectedBundlePage::willRunJavaScriptAlert): 24143 (WTR::InjectedBundlePage::willRunJavaScriptConfirm): 24144 (WTR::InjectedBundlePage::shouldBeginEditing): 24145 (WTR::InjectedBundlePage::shouldEndEditing): 24146 (WTR::InjectedBundlePage::shouldInsertNode): 24147 (WTR::InjectedBundlePage::shouldInsertText): 24148 (WTR::InjectedBundlePage::shouldDeleteRange): 24149 (WTR::InjectedBundlePage::shouldChangeSelectedRange): 24150 (WTR::InjectedBundlePage::shouldApplyStyle): 24151 (WTR::InjectedBundlePage::didBeginEditing): 24152 (WTR::InjectedBundlePage::didEndEditing): 24153 (WTR::InjectedBundlePage::didChange): 24154 (WTR::InjectedBundlePage::didChangeSelection): 24155 Don't do any work if we are not currently running a test. 24156 24157 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 24158 * WebKitTestRunner/StringFunctions.h: 24159 (WTR::toCF): 24160 Add conversion function for WKURLRef -> CFURLRef 24161 24162 * WebKitTestRunner/TestController.cpp: 24163 (WTR::TestController::TestController): 24164 (WTR::TestController::initialize): 24165 (WTR::TestController::resetStateToConsistentValues): 24166 (WTR::TestController::runTest): 24167 (WTR::TestController::didFinishLoadForFrame): 24168 * WebKitTestRunner/TestController.h: 24169 (WTR::TestController::): 24170 * WebKitTestRunner/TestInvocation.cpp: 24171 (WTR::TestInvocation::invoke): 24172 * WebKitTestRunner/TestInvocation.h: 24173 Move resetting code to TestController. 24174 24175 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 24176 * WebKitTestRunner/mac/TestControllerMac.mm: 24177 (WTR::TestController::runUntil): 24178 * WebKitTestRunner/mac/TestInvocationMac.mm: Removed. 24179 * WebKitTestRunner/win/TestControllerWin.cpp: 24180 (WTR::TestController::runUntil): 24181 * WebKitTestRunner/win/TestInvocationWin.cpp: Removed. 24182 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 24183 Move runUntil to TestController. 24184 241852010-08-12 Lucas De Marchi <lucas.demarchi@profusion.mobi> 24186 24187 Unreviewed. 24188 24189 Adding myself to the committers list. 24190 24191 * Scripts/webkitpy/common/config/committers.py: 24192 241932010-08-12 Hayato Ito <hayato@chromium.org> 24194 24195 Reviewed by Tony Chang. 24196 24197 Merge pretty printers for gdb. 24198 https://bugs.webkit.org/show_bug.cgi?id=43850 24199 24200 We need to update webcore.py because basic string classes have moved to WTF from WebCore. 24201 It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'. 24202 webcore.py is left for backward compatibility. 24203 24204 * gdb/webcore.py: 24205 * gdb/webkit.py: Added. 24206 * gdb/wtf.py: Removed. 24207 242082010-08-11 Tony Chang <tony@chromium.org> 24209 24210 Reviewed by David Levin. 24211 24212 [chromium] add google-chrome layout test result directories 24213 https://bugs.webkit.org/show_bug.cgi?id=43889 24214 24215 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 24216 * Scripts/webkitpy/layout_tests/port/factory.py: 24217 * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added. 24218 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 24219 242202010-08-11 Kent Tamura <tkent@chromium.org> 24221 24222 Reviewed by Dimitri Glazkov. 24223 24224 [DRT/Chromium] Disable accelerated compositing 24225 https://bugs.webkit.org/show_bug.cgi?id=43894 24226 24227 Disable accelerated compositing because DRT is not ready for 24228 it. This change fixes hundreds of test crashes on Windows and 24229 Linux. 24230 24231 * DumpRenderTree/chromium/TestShell.cpp: 24232 (TestShell::resetWebSettings): 24233 242342010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 24235 24236 Unreviewed. Adding my Collabora personality to the list. 24237 24238 * Scripts/webkitpy/common/config/committers.py: 24239 242402010-08-11 Martin Robinson <mrobinson@igalia.com> 24241 24242 Adding myself as a reviewer. 24243 24244 * Scripts/webkitpy/common/config/committers.py: 24245 242462010-08-11 Daniel Bates <dbates@rim.com> 24247 24248 Reviewed by Darin Adler. 24249 24250 Perl warnings when running commit-log-editor 24251 https://bugs.webkit.org/show_bug.cgi?id=43856 24252 24253 Fixes Perl warnings introduced by the patch for Bug #40548. 24254 24255 Perl doesn't have symbolic names for True/False. Instead, we 24256 should use boolean values. Moreover, the variable installedEditorApplication 24257 is not be used and should be renamed builtEditorApplication so that it 24258 uses the existing machinery to set the commit log editor application. 24259 24260 * Scripts/commit-log-editor: 24261 242622010-08-11 Adam Barth <abarth@webkit.org> 24263 24264 Reviewed by Eric Seidel. 24265 24266 Trying waiting for httpd lock in the EWS 24267 https://bugs.webkit.org/show_bug.cgi?id=43833 24268 24269 If this works, we can probably run the tests on the mac-ews, which 24270 would be very exciting. :) 24271 24272 * Scripts/webkitpy/tool/steps/runtests.py: 24273 242742010-08-11 Marcus Bulach <bulach@chromium.org> 24275 24276 Reviewed by Eric Seidel. 24277 24278 Check in a script to list redundant test outputs. 24279 https://bugs.webkit.org/show_bug.cgi?id=37630 24280 24281 If e.g. platform/mac-leopard is missing an expected test output, we 24282 fall back on platform/mac. This means it's possible to grow redundant 24283 test outputs, where we have the same expected data in both a platform 24284 directory and another platform it falls back on. 24285 (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398) 24286 24287 * Scripts/deduplicate-tests: Added. 24288 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added. 24289 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added. 24290 242912010-08-11 Antonio Gomes <tonikitoo@webkit.org> 24292 24293 Reviewed by Ariya Hidayat. 24294 24295 [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken 24296 https://bugs.webkit.org/show_bug.cgi?id=43853 24297 24298 LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly. 24299 It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to 24300 QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected 24301 to slots at all. 24302 24303 * QtTestBrowser/launcherwindow.cpp: 24304 (LauncherWindow::createChrome): 24305 (LauncherWindow::animatedFlip): 24306 (LauncherWindow::animatedYFlip): 24307 * QtTestBrowser/launcherwindow.h: 24308 243092010-08-11 Antonio Gomes <tonikitoo@webkit.org> 24310 24311 Reviewed by Simon Hausmann. 24312 24313 [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken 24314 https://bugs.webkit.org/show_bug.cgi?id=43851 24315 24316 All window options data (including the bool holding if the view is either QWebView or 24317 QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow. 24318 When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were 24319 not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were 24320 getting broken. 24321 24322 Patch addresses this issue. 24323 24324 * QtTestBrowser/launcherwindow.cpp: 24325 (LauncherWindow::createChrome): 24326 (LauncherWindow::toggleWebView): 24327 (LauncherWindow::toggleAcceleratedCompositing): 24328 243292010-08-10 Antonio Gomes <tonikitoo@webkit.org> 24330 24331 Reviewed by Ariya Hidayat. 24332 24333 [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects 24334 https://bugs.webkit.org/show_bug.cgi?id=43831 24335 24336 Only instantiate QStateMachine and friends associated to the YRotation action on demand. 24337 24338 * QtTestBrowser/webview.cpp: 24339 (WebViewGraphicsBased::WebViewGraphicsBased): 24340 (WebViewGraphicsBased::animatedYFlip): 24341 243422010-08-11 Darin Adler <darin@apple.com> 24343 24344 Reviewed by John Sullivan. 24345 24346 Improved editor options for prepare-ChangeLog and commit-log-editor 24347 https://bugs.webkit.org/show_bug.cgi?id=40548 24348 24349 * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR 24350 values like "xed --launch --wait" work properly. 24351 24352 * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can 24353 use a command line tool with the $openChangeLogs feature. 24354 243552010-08-11 Yury Semikhatsky <yurys@chromium.org> 24356 24357 Reviewed by Pavel Feldman. 24358 24359 Web Inspector: remove InjectDispatch.js 24360 https://bugs.webkit.org/show_bug.cgi?id=43835 24361 24362 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: 24363 * DumpRenderTree/chromium/DRTDevToolsAgent.h: 24364 243652010-08-10 Dirk Pranke <dpranke@chromium.org> 24366 24367 Reviewed by Eric Seidel. 24368 24369 webkit-patch should refuse to run under Win32 Python 24370 https://bugs.webkit.org/show_bug.cgi?id=40962 24371 24372 Given that there are lots of places in webkit-patch's code that 24373 assume unix-style filenames (forward slashes), webkit-patch fails 24374 with weird file-not-found errors when run under a native windows 24375 Python. It would be nice if we just trapped this and errored out 24376 at the beginning, rather than producing unpredictable errors. 24377 24378 * Scripts/webkit-patch: 24379 243802010-08-10 Kent Tamura <tkent@chromium.org> 24381 24382 Unreviewed, build fix. 24383 24384 Chromium build fix for r65107. 24385 24386 * DumpRenderTree/chromium/LayoutTestController.cpp: 24387 (LayoutTestController::suspendAnimations): 24388 (LayoutTestController::resumeAnimations): 24389 243902010-08-10 Sergio Villar Senin <svillar@igalia.com> 24391 24392 Reviewed by Xan Lopez. 24393 24394 [GTK] http/tests/media/video-cookie.html fails 24395 https://bugs.webkit.org/show_bug.cgi?id=42240 24396 24397 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 24398 (LayoutTestController::setAlwaysAcceptCookies): create the 24399 SoupCookieJar if it does not exist. Otherwise the accept policy 24400 won't be set. 24401 244022010-08-10 Chris Marrin <cmarrin@apple.com> 24403 24404 Reviewed by Oliver Hunt. 24405 24406 Add suspendAnimations/resumeAnimation API to DRT 24407 https://bugs.webkit.org/show_bug.cgi?id=43733 24408 24409 Adds suspendAnimations() and resumeAnimations() to LayoutTestController. 24410 Calls functions with the same names on AnimationController for the 24411 mainFrame. 24412 24413 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 24414 * DumpRenderTree/LayoutTestController.cpp: 24415 (suspendAnimationsCallback): 24416 (resumeAnimationsCallback): 24417 (LayoutTestController::staticFunctions): 24418 * DumpRenderTree/LayoutTestController.h: 24419 * DumpRenderTree/chromium/LayoutTestController.cpp: 24420 (LayoutTestController::LayoutTestController): 24421 (LayoutTestController::suspendAnimations): 24422 (LayoutTestController::resumeAnimations): 24423 * DumpRenderTree/chromium/LayoutTestController.h: 24424 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 24425 (LayoutTestController::suspendAnimations): 24426 (LayoutTestController::resumeAnimations): 24427 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 24428 (LayoutTestController::suspendAnimations): 24429 (LayoutTestController::resumeAnimations): 24430 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 24431 (LayoutTestController::suspendAnimations): 24432 (LayoutTestController::resumeAnimations): 24433 * DumpRenderTree/qt/LayoutTestControllerQt.h: 24434 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 24435 (LayoutTestController::suspendAnimations): 24436 (LayoutTestController::resumeAnimations): 24437 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 24438 (LayoutTestController::suspendAnimations): 24439 (LayoutTestController::resumeAnimations): 24440 244412010-08-10 Dimitri Glazkov <dglazkov@chromium.org> 24442 24443 Reviewed by Ojan Vafai. 24444 24445 [Chromium/DRT] Enable saving layout test results. 24446 https://bugs.webkit.org/show_bug.cgi?id=43796 24447 24448 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more 24449 parameters to the new-run-webkit-tests, including the name 24450 of the test results server. 24451 244522010-08-10 Jian Li <jianli@chromium.org> 24453 24454 More chromium build fix. 24455 24456 * DumpRenderTree/chromium/MockSpellCheck.cpp: 24457 (MockSpellCheck::spellCheckWord): 24458 (MockSpellCheck::initializeIfNeeded): 24459 * DumpRenderTree/chromium/NotificationPresenter.cpp: 24460 (NotificationPresenter::grantPermission): 24461 (NotificationPresenter::show): 24462 (NotificationPresenter::checkPermission): 24463 244642010-08-10 Jian Li <jianli@chromium.org> 24465 24466 Chromium build fix. 24467 24468 * DumpRenderTree/chromium/MockSpellCheck.cpp: 24469 * DumpRenderTree/chromium/NotificationPresenter.cpp: 24470 244712010-08-10 Victor Wang <victorw@chromium.org> 24472 24473 Reviewed by Ojan Vafai. 24474 24475 Update test results server merge logic so the aggregated 24476 results and times are updated for tests that are 24477 in aggragated json but not in incremental json. 24478 24479 Also update unittest to test this case. 24480 24481 https://bugs.webkit.org/show_bug.cgi?id=43769 24482 24483 * TestResultServer/model/jsonresults.py: 24484 * TestResultServer/model/jsonresults_unittest.py: 24485 244862010-08-09 Antonio Gomes <tonikitoo@webkit.org> 24487 24488 Reviewed by Ariya Hidayat. 24489 24490 [Qt] QtTestBrowser: proper set scene rect 24491 24492 When resizesToContents is ON scene's rect is set to the boundary of 24493 the mainFrame. However, navigating to other web page should keep resizing 24494 scene's rect according to the new document loaded. Patch addresses this issue. 24495 24496 Now resizesToContents and scrolling properly work on QtTestBrowser. 24497 24498 * QtTestBrowser/webview.cpp: 24499 (WebViewGraphicsBased::setPage): 24500 (WebViewGraphicsBased::contentsSizeChanged): 24501 (WebViewGraphicsBased::setResizesToContents): 24502 (WebViewGraphicsBased::resizeEvent): 24503 * QtTestBrowser/webview.h: 24504 245052010-08-09 Antonio Gomes <tonikitoo@webkit.org> 24506 24507 Reviewed by Ariya Hidayat. 24508 24509 [Qt] QtTestBrowser: Clean up LauncherWindow code. 24510 24511 * QtTestBrowser/launcherwindow.cpp: 24512 (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init(). 24513 (LauncherWindow::init): Fixed comments. 24514 (LauncherWindow::applyPrefs): Move the method around. 24515 (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments. 24516 245172010-08-09 Antonio Gomes <tonikitoo@webkit.org> 24518 24519 Reviewed by Ariya Hidayat. 24520 24521 [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on. 24522 24523 It gets control+0 the same visual effect as control++ or control-. 24524 24525 * QtTestBrowser/launcherwindow.cpp: 24526 (LauncherWindow::toggleZoomTextOnly): 24527 245282010-08-09 Antonio Gomes <tonikitoo@webkit.org> 24529 24530 Reviewed by Ariya Hidayat. 24531 24532 [Qt] QtTestBrowser:: make m_zoomLevels a static member. 24533 24534 Not all instances of LauncherWindow need its own m_zoomLevel. 24535 24536 * QtTestBrowser/launcherwindow.cpp: 24537 * QtTestBrowser/launcherwindow.h: 24538 245392010-08-09 Sam Weinig <sam@webkit.org> 24540 24541 Reviewed by Geoffrey Garen. 24542 24543 Add zoom support for injected bundle 24544 https://bugs.webkit.org/show_bug.cgi?id=43759 24545 24546 Use zoom factor SPI to implement zoom related eventSender functions. 24547 24548 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: 24549 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: 24550 (WTR::EventSendingController::textZoomIn): 24551 (WTR::EventSendingController::textZoomOut): 24552 (WTR::EventSendingController::zoomPageIn): 24553 (WTR::EventSendingController::zoomPageOut): 24554 * WebKitTestRunner/InjectedBundle/EventSendingController.h: 24555 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 24556 (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test. 24557 245582010-08-09 Gavin Barraclough <barraclough@apple.com> 24559 24560 Speculative chromium build fix III. 24561 24562 * DumpRenderTree/chromium/MockSpellCheck.h: 24563 * DumpRenderTree/chromium/NotificationPresenter.h: 24564 * DumpRenderTree/chromium/WebViewHost.h: 24565 (WebViewHost::addClearHeader): 24566 (WebViewHost::clearHeaders): 24567 245682010-08-09 Ojan Vafai <ojan@chromium.org> 24569 24570 Reviewed by Tony Chang. 24571 24572 increase the number of test results that we save 24573 https://bugs.webkit.org/show_bug.cgi?id=43763 24574 24575 Now that we do incremental uploads, we can increase the number of 24576 results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html. 24577 24578 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 24579 245802010-08-09 Evan Martin <evan@chromium.org> 24581 24582 Reviewed by Tony Chang. 24583 24584 [chromium] DRT error print statement incorrectly tries to print a FILE* 24585 https://bugs.webkit.org/show_bug.cgi?id=43747 24586 24587 * DumpRenderTree/chromium/ImageDiff.cpp: 24588 (writeFile): pass the correct pointer. 24589 245902010-08-09 Victor Wang <victorw@chromium.org> 24591 24592 Reviewed by Ojan Vafai. 24593 24594 Upload incremental test results json to server by default. 24595 24596 https://bugs.webkit.org/show_bug.cgi?id=43743 24597 24598 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 24599 246002010-08-09 Eric Seidel <eric@webkit.org> 24601 24602 Reviewed by Adam Barth. 24603 24604 EWS bots wait 2 minutes between patches 24605 https://bugs.webkit.org/show_bug.cgi?id=43731 24606 24607 * Scripts/webkitpy/tool/bot/queueengine.py: 24608 - Don't sleep after failures. This was a hold-over from 24609 an earlier design. 24610 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 24611 - EWS bots were not properly reporting true/false from process_work_item. 24612 They were always returning None, thus false, thus always logging 24613 as a failure and sleeping 2 minutes after each patch. 24614 246152010-08-09 Sam Weinig <sam@webkit.org> 24616 24617 Reviewed by Anders Carlsson. 24618 24619 Stub out EventSender for WebKitTestRunner 24620 https://bugs.webkit.org/show_bug.cgi?id=43703 24621 24622 * WebKitTestRunner/DerivedSources.make: 24623 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: 24624 Add ability to pass javascript arguments to the wrapped object. 24625 24626 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added. 24627 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added. 24628 (WTR::EventSendingController::create): 24629 (WTR::EventSendingController::EventSendingController): 24630 (WTR::EventSendingController::~EventSendingController): 24631 (WTR::EventSendingController::wrapperClass): 24632 (WTR::setExceptionForString): 24633 (WTR::EventSendingController::mouseDown): 24634 (WTR::EventSendingController::mouseUp): 24635 (WTR::EventSendingController::mouseMoveTo): 24636 (WTR::EventSendingController::keyDown): 24637 (WTR::EventSendingController::contextClick): 24638 (WTR::EventSendingController::leapForward): 24639 (WTR::EventSendingController::textZoomIn): 24640 (WTR::EventSendingController::textZoomOut): 24641 (WTR::EventSendingController::zoomPageIn): 24642 (WTR::EventSendingController::zoomPageOut): 24643 (WTR::EventSendingController::makeWindowObject): 24644 * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added. 24645 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 24646 (WTR::InjectedBundle::reset): 24647 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 24648 (WTR::InjectedBundle::eventSendingController): 24649 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 24650 (WTR::InjectedBundlePage::didClearWindowForFrame): 24651 Add stubbed out EventSenderController. 24652 24653 * WebKitTestRunner/InjectedBundle/GCController.h: 24654 Remove incorrect comment. 24655 24656 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 24657 * WebKitTestRunner/win/InjectedBundle.vcproj: 24658 Add new files. 24659 246602010-08-08 Kent Tamura <tkent@chromium.org> 24661 24662 Unreviewed, trivial fix. 24663 24664 Fix "WindowsError: [Error 32] The process cannot access the file 24665 because it is being used by another process" introduced by r64959. 24666 24667 * BuildSlaveSupport/test-result-archive: 24668 246692010-08-08 Kent Tamura <tkent@chromium.org> 24670 24671 Reviewed by Tony Chang. 24672 24673 Chromium buildbot: Avoid "zip" command dependency 24674 https://bugs.webkit.org/show_bug.cgi?id=43470 24675 24676 * BuildSlaveSupport/test-result-archive: 24677 For Chromium port, creates a zip archive with zipfile package of Python 24678 instead of external "zip" command. We'd like to avoid additional 24679 command installation. 24680 246812010-08-08 Jon Honeycutt <jhoneycutt@apple.com> 24682 24683 WebKitTestRunner should add the QuickTime dir to the PATH environment 24684 variable 24685 https://bugs.webkit.org/show_bug.cgi?id=43686 24686 24687 Reviewed by Dan Bernstein. 24688 24689 * WebKitTestRunner/win/TestControllerWin.cpp: 24690 (WTR::addQTDirToPATH): 24691 Copied from DRT. 24692 (WTR::TestController::platformInitialize): 24693 Call addQTDirToPath(). 24694 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 24695 Link to shlwapi.lib for SHGetValue. 24696 246972010-08-07 Sam Weinig <sam@webkit.org> 24698 24699 Reviewed by Maciej Stachowiak. 24700 24701 WebKitTestRunner needs layoutTestController.dumpTitleChanges 24702 <rdar://problem/8213861> 24703 https://bugs.webkit.org/show_bug.cgi?id=42683 24704 24705 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 24706 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 24707 (WTR::InjectedBundlePage::didReceiveTitleForFrame): 24708 (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): 24709 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 24710 (WTR::LayoutTestController::LayoutTestController): 24711 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 24712 (WTR::LayoutTestController::dumpTitleChanges): 24713 (WTR::LayoutTestController::shouldDumpTitleChanges): 24714 247152010-08-07 Sam Weinig <sam@webkit.org> 24716 24717 Reviewed by Anders Carlsson. 24718 24719 WebKitTestRunner needs to print onunload handler information 24720 <rdar://problem/8213831> 24721 https://bugs.webkit.org/show_bug.cgi?id=42703 24722 24723 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 24724 (WTR::operator<<): 24725 (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): 24726 247272010-08-07 Sam Weinig <sam@webkit.org> 24728 24729 Reviewed by Anders Carlsson. 24730 24731 Add additional loader client functions need to complete WebKitTestRunner 24732 https://bugs.webkit.org/show_bug.cgi?id=43684 24733 24734 Remove unnecessary and jarring underscores as well. 24735 24736 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 24737 (didClearWindowObjectForFrame): 24738 (didCreatePage): 24739 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 24740 (WTR::InjectedBundlePage::InjectedBundlePage): 24741 (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): 24742 (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame): 24743 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): 24744 (WTR::InjectedBundlePage::didCommitLoadForFrame): 24745 (WTR::InjectedBundlePage::didFinishLoadForFrame): 24746 (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): 24747 (WTR::InjectedBundlePage::didReceiveTitleForFrame): 24748 (WTR::InjectedBundlePage::didClearWindowForFrame): 24749 (WTR::InjectedBundlePage::didCancelClientRedirectForFrame): 24750 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): 24751 (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame): 24752 (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): 24753 (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame): 24754 (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame): 24755 (WTR::InjectedBundlePage::didRunInsecureContentForFrame): 24756 (WTR::InjectedBundlePage::willAddMessageToConsole): 24757 (WTR::InjectedBundlePage::willSetStatusbarText): 24758 (WTR::InjectedBundlePage::willRunJavaScriptAlert): 24759 (WTR::InjectedBundlePage::willRunJavaScriptConfirm): 24760 (WTR::InjectedBundlePage::willRunJavaScriptPrompt): 24761 (WTR::InjectedBundlePage::shouldBeginEditing): 24762 (WTR::InjectedBundlePage::shouldEndEditing): 24763 (WTR::InjectedBundlePage::shouldInsertNode): 24764 (WTR::InjectedBundlePage::shouldInsertText): 24765 (WTR::InjectedBundlePage::shouldDeleteRange): 24766 (WTR::InjectedBundlePage::shouldChangeSelectedRange): 24767 (WTR::InjectedBundlePage::shouldApplyStyle): 24768 (WTR::InjectedBundlePage::didBeginEditing): 24769 (WTR::InjectedBundlePage::didEndEditing): 24770 (WTR::InjectedBundlePage::didChange): 24771 (WTR::InjectedBundlePage::didChangeSelection): 24772 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 24773 247742010-08-07 Dan Bernstein <mitz@apple.com> 24775 24776 Build fix. 24777 24778 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references 24779 to JSGCController.{cpp,h} relative to the build root. 24780 247812010-08-07 Sam Weinig <sam@webkit.org> 24782 24783 Reviewed by Anders Carlsson. 24784 24785 WebKitTestRunner needs GCController 24786 <rdar://problem/8213834> 24787 https://bugs.webkit.org/show_bug.cgi?id=42701 24788 24789 * WebKitTestRunner/DerivedSources.make: 24790 * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added. 24791 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: 24792 (WTR::setProperty): 24793 * WebKitTestRunner/InjectedBundle/GCController.cpp: Added. 24794 (WTR::GCController::create): 24795 (WTR::GCController::GCController): 24796 (WTR::GCController::~GCController): 24797 (WTR::GCController::wrapperClass): 24798 (WTR::GCController::collect): 24799 (WTR::GCController::collectOnAlternateThread): 24800 (WTR::GCController::getJSObjectCount): 24801 (WTR::GCController::makeWindowObject): 24802 * WebKitTestRunner/InjectedBundle/GCController.h: Added. 24803 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 24804 (WTR::InjectedBundle::reset): 24805 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 24806 (WTR::InjectedBundle::bundle): 24807 (WTR::InjectedBundle::gcController): 24808 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 24809 (WTR::InjectedBundlePage::didClearWindowForFrame): 24810 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 24811 (WTR::LayoutTestController::keepWebHistory): 24812 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 24813 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 24814 * WebKitTestRunner/win/InjectedBundle.vcproj: 24815 248162010-08-05 Jon Honeycutt <jhoneycutt@apple.com> 24817 24818 WebKitTestRunner needs to be able to set the font smoothing type 24819 https://bugs.webkit.org/show_bug.cgi?id=43406 24820 24821 Reviewed by Adam Roben. 24822 24823 * WebKitTestRunner/TestInvocation.cpp: 24824 (WTR::TestInvocation::resetPreferencesToConsistentValues): 24825 Set the font smoothing level to 24826 kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT. 24827 248282010-08-06 Jon Honeycutt <jhoneycutt@apple.com> 24829 24830 Fix a missed variable rename. 24831 24832 Unreviewed. 24833 24834 * Scripts/old-run-webkit-tests: 24835 248362010-08-06 Jon Honeycutt <jhoneycutt@apple.com> 24837 24838 mac-wk2/Skipped should be used on Windows when running regression tests 24839 https://bugs.webkit.org/show_bug.cgi?id=43494 24840 24841 Reviewed by Adam Roben. 24842 24843 * Scripts/old-run-webkit-tests: 24844 If the platform is win-wk2, also read the mac-wk2 skipped list. 24845 248462010-08-06 Kent Tamura <tkent@chromium.org> 24847 24848 Reviewed by Dimitri Glazkov. 24849 24850 [DRT/Chromium] Should revoke scheduled tasks 24851 https://bugs.webkit.org/show_bug.cgi?id=43560 24852 24853 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: 24854 (DRTDevToolsAgent::reset): Calls RevokeAll(). 24855 * DumpRenderTree/chromium/DRTDevToolsAgent.h: 24856 * DumpRenderTree/chromium/DRTDevToolsClient.cpp: 24857 (DRTDevToolsClient::reset): Calls RevokeAll(). 24858 * DumpRenderTree/chromium/DRTDevToolsClient.h: 24859 * DumpRenderTree/chromium/EventSender.cpp: 24860 (EventSender::reset): Calls RevokeAll(). 24861 * DumpRenderTree/chromium/LayoutTestController.cpp: 24862 (LayoutTestController::reset): Calls RevokeAll(). 24863 * DumpRenderTree/chromium/TestShell.cpp: 24864 (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset(). 24865 248662010-08-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 24867 24868 Reviewed by Antonio Gomes. 24869 24870 [Qt] Fix the DRT build on Mac OS X 24871 24872 * DumpRenderTree/qt/DumpRenderTree.pro: 24873 248742010-08-06 Jochen Eisinger <jochen@chromium.org> 24875 24876 Reviewed by Pavel Feldman. 24877 24878 Rietvield's upload.py moved to a different location. 24879 https://bugs.webkit.org/show_bug.cgi?id=43613 24880 24881 * Scripts/webkitpy/thirdparty/__init__.py: 24882 248832010-05-23 Eric Seidel <eric@webkit.org> 24884 24885 Reviewed by Adam Barth. 24886 24887 QueueStatusServer needs better queue-status pages 24888 https://bugs.webkit.org/show_bug.cgi?id=39562 24889 24890 The primary goal of this patch is to display queue 24891 positions somewhere on the site so that it's easier 24892 for commit-queue users to know when their pach will 24893 be landed. I also tried to improve the root page 24894 to be more useful than the previous wall of status text. 24895 24896 * QueueStatusServer/handlers/recentstatus.py: 24897 * QueueStatusServer/main.py: 24898 * QueueStatusServer/model/queues.py: 24899 * QueueStatusServer/templates/recentstatus.html: 24900 249012010-08-05 Victor Wang <victorw@chromium.org> 24902 24903 Reviewed by Ojan Vafai. 24904 24905 Add option to generate/upload incremental json results to test result server. 24906 Also refactor the json results generator unittest code to test 24907 incremental and aggregated json results. 24908 24909 https://bugs.webkit.org/show_bug.cgi?id=43519 24910 24911 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 24912 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 24913 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: 24914 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 24915 249162010-08-05 Jian Li <jianli@chromium.org> 24917 24918 Reviewed by David Levin. 24919 24920 Unify blob related feature defines to ENABLE(BLOB). 24921 https://bugs.webkit.org/show_bug.cgi?id=43081 24922 24923 * Scripts/build-webkit: 24924 249252010-08-05 Satish Sampath <satish@chromium.org> 24926 24927 Reviewed by Jeremy Orlow. 24928 24929 Add speech input controller mock in WebKit and a layout test. 24930 https://bugs.webkit.org/show_bug.cgi?id=43477 24931 24932 Added LayoutTestController::setMockSpeechInputResultCallback method. 24933 24934 * DumpRenderTree/LayoutTestController.cpp: 24935 (setMockSpeechInputResultCallback): Wrapper invoking the member function. 24936 (LayoutTestController::staticFunctions): 24937 * DumpRenderTree/LayoutTestController.h: 24938 * DumpRenderTree/chromium/LayoutTestController.cpp: 24939 (LayoutTestController::LayoutTestController): 24940 (LayoutTestController::setMockSpeechInputResult): Sets the mock result. 24941 (LayoutTestController::speechInputController): Creates the mock controller. 24942 * DumpRenderTree/chromium/LayoutTestController.h: 24943 * DumpRenderTree/chromium/WebViewHost.cpp: 24944 (WebViewHost::speechInputController): Creates the mock controller. 24945 * DumpRenderTree/chromium/WebViewHost.h: 24946 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 24947 (LayoutTestController::setMockSpeechInputResult): dummy method. 24948 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 24949 (LayoutTestController::setMockSpeechInputResult): dummy method. 24950 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 24951 (LayoutTestController::setMockSpeechInputResult): dummy method. 24952 * DumpRenderTree/qt/LayoutTestControllerQt.h: 24953 * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method. 24954 (LayoutTestController::setMockSpeechInputResult): 24955 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method. 24956 (LayoutTestController::setMockSpeechInputResult): 24957 249582010-08-04 Adam Roben <aroben@apple.com> 24959 24960 Fix the path to TestNetscapePlugin's directory on Windows 24961 24962 Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to 24963 load TestNetscapePlugin 24964 24965 Reviewed by Jon Honeycutt. 24966 24967 * WebKitTestRunner/win/TestControllerWin.cpp: 24968 (WTR::TestController::initializeTestPluginDirectory): 24969 TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's 24970 next to WebKitTestRunner.exe. Previously we were passing the directory 24971 that contains WebKitTestRunner.exe. Also fixed some leaks. 24972 249732010-08-05 Kenichi Ishibashi <bashi@google.com> 24974 24975 Reviewed by Shinichiro Hamaji. 24976 24977 check-webkit-style returns non-zero when patch is entirely minus lines. 24978 https://bugs.webkit.org/show_bug.cgi?id=38169 24979 24980 * Scripts/check-webkit-style: 24981 Check whether a patch contains modified files that are entirely minus lines. 24982 * Scripts/webkitpy/style/filereader.py: 24983 Add a variable that holds number of files that contain only deleted lines. 24984 * Scripts/webkitpy/style/patchreader.py: 24985 Count up modified files that contain only deleted lines. 24986 249872010-08-05 Pavel Feldman <pfeldman@chromium.org> 24988 24989 Reviewed by Yury Semikhatsky. 24990 24991 DevTools: get rid of delayed command dispatching on front-end side. 24992 24993 https://bugs.webkit.org/show_bug.cgi?id=43479 24994 24995 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: 24996 (DRTDevToolsAgent::detach): 24997 (DRTDevToolsAgent::frontendLoaded): 24998 * DumpRenderTree/chromium/DRTDevToolsAgent.h: 24999 * DumpRenderTree/chromium/DRTDevToolsClient.cpp: 25000 (DRTDevToolsClient::~DRTDevToolsClient): 25001 (DRTDevToolsClient::sendFrontendLoaded): 25002 * DumpRenderTree/chromium/DRTDevToolsClient.h: 25003 250042010-08-04 Kenichi Ishibashi <bashi@google.com> 25005 25006 Reviewed by Shinichiro Hamaji. 25007 25008 Fixes check-webkit-style false positive on "new uint32_t." 25009 https://bugs.webkit.org/show_bug.cgi?id=43077 25010 25011 * Scripts/webkitpy/style/checkers/cpp.py: 25012 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 25013 250142010-08-04 Kent Tamura <tkent@chromium.org> 25015 25016 Reviewed by Dimitri Glazkov. 25017 25018 [DRT/Chromium] Remove base/linked_ptr.h dependency 25019 https://bugs.webkit.org/show_bug.cgi?id=43472 25020 25021 Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>. 25022 We need to use RefPtr<> because m_pendingEntry points an object in 25023 m_entries or not in m_entries. 25024 25025 * DumpRenderTree/chromium/TestNavigationController.cpp: 25026 (TestNavigationEntry::create): Added. 25027 (TestNavigationController::activeEntry): 25028 (TestNavigationController::didNavigateToEntry): 25029 (TestNavigationController::discardPendingEntry): 25030 (TestNavigationController::insertEntry): 25031 (TestNavigationController::navigateToPendingEntry): 25032 * DumpRenderTree/chromium/TestNavigationController.h: 25033 * DumpRenderTree/chromium/WebViewHost.cpp: 25034 (WebViewHost::loadURLForFrame): 25035 Use TestNavigationEntry::create(). 25036 (WebViewHost::updateURL): 25037 Use RefPtr<>. 25038 (WebViewHost::updateSessionHistory): 25039 Remove unnecessary static_cast<>. 25040 250412010-08-04 Kent Tamura <tkent@chromium.org> 25042 25043 Reviewed by Dimitri Glazkov. 25044 25045 Fix a problem that "archived test results" step doesn't work on Chromium buildbots 25046 https://bugs.webkit.org/show_bug.cgi?id=43333 25047 25048 * BuildSlaveSupport/test-result-archive: 25049 - Make layoutTestResultsDir local and pass it to archiveTestResults() 25050 - Adjust layoutTestResultsDir for Chromium 25051 250522010-08-04 Kent Tamura <tkent@chromium.org> 25053 25054 Reviewed by Dimitri Glazkov. 25055 25056 NRWT: websocket_server startup detection failure 25057 https://bugs.webkit.org/show_bug.cgi?id=43466 25058 25059 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 25060 Increase timeout value: 5 second -> 10 second 25061 250622010-08-04 Victor Wang <victorw@chromium.org> 25063 25064 Reviewed by Ojan Vafai. 25065 25066 -. Add result.json incremental merging functionality to test results app engine. 25067 -. blobstore is not suitable for AE data merging and there is no API to 25068 programatically edit existing blob or write a new one yet, so replace blobstore 25069 with datastore. If file is oversize (>1000*1000 bytes), store file data in 25070 multiple datastore entries. 25071 -. Fix styles. 25072 25073 Test: jsonresults_unittest to test merging logics. 25074 25075 https://bugs.webkit.org/show_bug.cgi?id=38599 25076 25077 * TestResultServer/handlers/dashboardhandler.py: 25078 * TestResultServer/handlers/menu.py: 25079 * TestResultServer/handlers/testfilehandler.py: 25080 * TestResultServer/main.py: 25081 * TestResultServer/model/dashboardfile.py: 25082 * TestResultServer/model/datastorefile.py: Added. 25083 * TestResultServer/model/jsonresults.py: Added. 25084 * TestResultServer/model/jsonresults_unittest.py: Added. 25085 * TestResultServer/model/testfile.py: 25086 * TestResultServer/templates/uploadform.html: 25087 250882010-08-04 Antonio Gomes <tonikitoo@webkit.org> 25089 25090 Reviewed by Kenneth Christiansen. 25091 25092 [Qt] [QtTestBrowser] Remove unneeded QAction class members 25093 https://bugs.webkit.org/show_bug.cgi?id=43518 25094 25095 LauncherWindow class has two totally unneeded class members: m_flopAnimated and 25096 m_flipYAnimated. Also, in initializeView method there are some dead code block 25097 trying to connect them at the wrong time, when they have not been instanciated. 25098 25099 This patch: 25100 25101 - removes the two cited class members in favor of local variables in createChrome method; 25102 - removes the dead code block. 25103 25104 * QtTestBrowser/launcherwindow.cpp: 25105 (LauncherWindow::LauncherWindow): 25106 (LauncherWindow::initializeView): 25107 (LauncherWindow::createChrome): 25108 * QtTestBrowser/launcherwindow.h: 25109 251102010-08-04 Antonio Gomes <tonikitoo@webkit.org> 25111 25112 Reviewed by Simon Hausmann and Kenneth Christiansen. 25113 25114 [Qt] [QtTestBrowser] Clean up static and global menu state controls 25115 https://bugs.webkit.org/show_bug.cgi?id=43448 25116 25117 After LauncherWindow class was refactored out of from main.cpp, all global variables that 25118 were hanging in main.cpp became temporarily public static class members of newly added 25119 LauncherWindow class. This design was not properly handling the initial purpose of the 25120 global variables: newly created launcher windows should inherit the settings of the originating 25121 one. 25122 25123 In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It 25124 comprises all data needed to handling the goal described above. 25125 25126 * QtTestBrowser/launcherwindow.cpp: 25127 (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object 25128 holding all user settings configured in the menus and command line. 25129 It also receices an optional QGraphicsScene points in case we are doing 25130 a "Clone Window". 25131 (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its 25132 value. 25133 (LauncherWindow::initializeView): Ditto. 25134 (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX 25135 (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly 25136 apply the preferences is provided by m_userData. 25137 (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX 25138 (LauncherWindow::toggleResizesToContents): Ditto. 25139 (LauncherWindow::toggleWebGL): Ditto. 25140 (LauncherWindow::toggleFrameFlattening): Ditto. 25141 (LauncherWindow::toggleQGLWidgetViewport): Ditto. 25142 (LauncherWindow::changeViewportUpdateMode): Ditto. 25143 (LauncherWindow::showFPS): Ditto. 25144 (LauncherWindow::newWindow): Changed to pass the userData. 25145 (LauncherWindow::cloneWindow): Ditto. 25146 * QtTestBrowser/launcherwindow.h: 25147 (WindowOptions::WindowOptions): 25148 * QtTestBrowser/main.cpp: 25149 (requiresGraphicsView): 25150 (LauncherApplication::handleUserOptions): 25151 (main): 25152 251532010-08-04 Kevin Ollivier <kevino@theolliviers.com> 25154 25155 [wx] Build fix for gcc not importing all symbols from convenience libraries. 25156 Works on 10.6 only for Mac until the build system is reworked. 25157 25158 * wx/build/settings.py: 25159 251602010-08-04 Markus Goetz <Markus.Goetz@nokia.com> 25161 25162 Reviewed by Simon Hausmann. 25163 25164 [Qt] Change wording in QtTestBrowser 25165 https://bugs.webkit.org/show_bug.cgi?id=43241 25166 25167 * QtTestBrowser/launcherwindow.cpp: 25168 (LauncherWindow::createChrome): 25169 251702010-08-04 Aaron Boodman <aa@chromium.org> 25171 25172 Reviewed by Eric Seidel. 25173 25174 prepare-ChangeLog fails mysteriously if curl doesn't support ssl 25175 https://bugs.webkit.org/show_bug.cgi?id=43460 25176 25177 * Scripts/prepare-ChangeLog: 25178 251792010-08-03 MORITA Hajime <morrita@google.com> 25180 25181 Reviewed by Tony Chang. 25182 25183 [DRT] Assertion failed when drag and move a draggable element. 25184 https://bugs.webkit.org/show_bug.cgi?id=41695 25185 25186 mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started. 25187 But Cocoa doesn't call mouseDragged() until dragging is done. 25188 Other part of DumpRenderTree also assumes Cocoa behavior and an assertion 25189 on UIDelegate failed when mouseDragged() is called during dragging. 25190 This change eliminated the mouseDragged() call when dragging begins, 25191 which is implicated by draggingInfo instance. 25192 25193 * DumpRenderTree/mac/EventSendingController.mm: 25194 (-[EventSendingController mouseMoveToX:Y:]): 25195 25196 Test: fast/events/dragging-mouse-moves.html 25197 251982010-08-02 Steve Block <steveblock@google.com> 25199 25200 Reviewed by Alexey Proskuryakov. 25201 25202 Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately 25203 https://bugs.webkit.org/show_bug.cgi?id=40002 25204 25205 The code in LayoutTestController::setGeolocationPermission() was moved to 25206 setGeolocationPermissionCommon() to allow each port to provide its own 25207 implementation of setGeolocationPermission(). 25208 25209 For the Mac port, setGeolocationPermission() notifies the UIDelegate of the 25210 new permission, so it can call back to WebCore if permission requests are in 25211 progress and are waiting for a response. A minor fix to the Mac 25212 MockGeolocationProvider was also required to make sure that the mock provider 25213 calls back to WebCore when it is first started. 25214 25215 For other ports, LayoutTestController::setGeolocationPermission() is not 25216 implemented. 25217 25218 * DumpRenderTree/LayoutTestController.cpp: 25219 (LayoutTestController::setGeolocationPermissionCommon): 25220 * DumpRenderTree/LayoutTestController.h: 25221 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 25222 (LayoutTestController::setGeolocationPermission): 25223 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 25224 (LayoutTestController::setGeolocationPermission): 25225 * DumpRenderTree/mac/MockGeolocationProvider.mm: 25226 (-[MockGeolocationProvider registerWebView:]): 25227 * DumpRenderTree/mac/UIDelegate.h: 25228 * DumpRenderTree/mac/UIDelegate.mm: 25229 (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]): 25230 (-[UIDelegate setGeolocationPermission:]): 25231 (-[UIDelegate dealloc]): 25232 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 25233 (LayoutTestController::setGeolocationPermission): 25234 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 25235 (LayoutTestController::setGeolocationPermission): 25236 252372010-08-03 Kent Tamura <tkent@chromium.org> 25238 25239 Reviewed by Dimitri Glazkov. 25240 25241 [DRT/Chromium] Implement --testshell-startup-dialog 25242 https://bugs.webkit.org/show_bug.cgi?id=40616 25243 25244 * DumpRenderTree/chromium/DumpRenderTree.cpp: 25245 (main): Check --testshell-startup-dialog, and call openStartUpDialog() 25246 if it is specfied. 25247 * DumpRenderTree/chromium/TestShell.h: 25248 Declare openStartUpDialog(). 25249 * DumpRenderTree/chromium/TestShellGtk.cpp: 25250 (openStartupDialog): 25251 * DumpRenderTree/chromium/TestShellMac.mm: 25252 (openStartupDialog): 25253 * DumpRenderTree/chromium/TestShellWin.cpp: 25254 (openStartupDialog): 25255 252562010-08-03 Kent Tamura <tkent@chromium.org> 25257 25258 Reviewed by Dimitri Glazkov. 25259 25260 [DRT/Chromium] Remove dependency of base/md5.h 25261 https://bugs.webkit.org/show_bug.cgi?id=43403 25262 25263 * DumpRenderTree/chromium/TestShell.cpp: 25264 (TestShell::dumpImage): Use wtf/MD5.h 25265 252662010-08-03 Joseph Pecoraro <joepeck@webkit.org> 25267 25268 Reviewed by David Kilzer. 25269 25270 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) 25271 https://bugs.webkit.org/show_bug.cgi?id=40627 25272 25273 Part 6 - LayoutTest and Cleanup 25274 25275 Allow tests to delete application caches and set application cache 25276 origin quotas, so they can be tested. 25277 25278 * DumpRenderTree/LayoutTestController.cpp: 25279 (LayoutTestController::LayoutTestController): 25280 (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller. 25281 (clearAllApplicationCachesCallback): should delete all application caches. 25282 (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests. 25283 (LayoutTestController::staticFunctions): 25284 * DumpRenderTree/LayoutTestController.h: 25285 (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output. 25286 (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached. 25287 25288 Mac implementation. 25289 25290 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 25291 (LayoutTestController::clearAllApplicationCaches): delete application caches. 25292 (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost. 25293 * DumpRenderTree/mac/UIDelegate.mm: 25294 (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix. 25295 (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota. 25296 25297 Stub implementations for other platforms. 25298 25299 * DumpRenderTree/chromium/LayoutTestController.cpp: 25300 (LayoutTestController::LayoutTestController): 25301 (LayoutTestController::clearAllApplicationCaches): 25302 (LayoutTestController::setApplicationCacheOriginQuota): 25303 * DumpRenderTree/chromium/LayoutTestController.h: 25304 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 25305 (LayoutTestController::clearAllApplicationCaches): 25306 (LayoutTestController::setApplicationCacheOriginQuota): 25307 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 25308 (LayoutTestController::clearAllApplicationCaches): 25309 (LayoutTestController::setApplicationCacheOriginQuota): 25310 * DumpRenderTree/qt/LayoutTestControllerQt.h: 25311 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 25312 (LayoutTestController::clearAllApplicationCaches): 25313 (LayoutTestController::setApplicationCacheOriginQuota): 25314 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 25315 (LayoutTestController::clearAllApplicationCaches): 25316 (LayoutTestController::setApplicationCacheOriginQuota): 25317 253182010-08-03 Joseph Pecoraro <joepeck@webkit.org> 25319 25320 Reviewed by David Kilzer. 25321 25322 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) 25323 https://bugs.webkit.org/show_bug.cgi?id=40627 25324 25325 Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers 25326 25327 Change old style calls to make use of the managers. 25328 25329 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 25330 (LayoutTestController::setDatabaseQuota): 25331 * DumpRenderTree/mac/UIDelegate.mm: 25332 (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): 25333 253342010-08-03 Mark Rowe <mrowe@apple.com> 25335 25336 Add a new Leopard build slave to run the release tests. 25337 25338 * BuildSlaveSupport/build.webkit.org-config/config.json: 25339 253402010-08-03 Jon Honeycutt <jhoneycutt@apple.com> 25341 25342 WebKitTestRunner needs to activate the Mac font ascent hack 25343 https://bugs.webkit.org/show_bug.cgi?id=43404 25344 25345 Reviewed by Darin Adler. 25346 25347 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 25348 (WTR::InjectedBundle::initialize): 25349 Call WKBundleActivateMacFontAscentHack(). 25350 253512010-08-03 Alex Milowski <alex@milowski.com> 25352 25353 Reviewed by Beth Dakin. 25354 25355 Changed the default for MathML support so that is is enabled by default. 25356 25357 * Scripts/build-webkit: 25358 253592010-08-03 Sam Weinig <sam@webkit.org> 25360 25361 Roll r64566 back in this time with all the overloads in place.. 25362 25363 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 25364 (WTR::InjectedBundlePage::shouldInsertNode): 25365 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 25366 * WebKitTestRunner/StringFunctions.h: 25367 * WebKitTestRunner/TestInvocation.cpp: 25368 (WTR::TestInvocation::resetPreferencesToConsistentValues): 25369 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 25370 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 25371 253722010-08-03 Sam Weinig <sam@webkit.org> 25373 25374 Rollout r64566. It broke all the WebKit2 tests. 25375 25376 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 25377 (WTR::operator<<): 25378 (WTR::InjectedBundlePage::shouldInsertNode): 25379 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 25380 * WebKitTestRunner/StringFunctions.h: Removed. 25381 * WebKitTestRunner/TestInvocation.cpp: 25382 (WTR::createWKURL): 25383 (WTR::WKStringToUTF8): 25384 (WTR::TestInvocation::resetPreferencesToConsistentValues): 25385 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 25386 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 25387 253882010-08-03 Sam Weinig <sam@webkit.org> 25389 25390 Reviewed by Anders Carlsson. 25391 25392 WTR: Move all the utility functions for working with strings to a shared header. 25393 https://bugs.webkit.org/show_bug.cgi?id=43386 25394 25395 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 25396 (WTR::InjectedBundlePage::shouldInsertNode): 25397 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 25398 * WebKitTestRunner/StringFunctions.h: Added. 25399 * WebKitTestRunner/TestInvocation.cpp: 25400 (WTR::TestInvocation::resetPreferencesToConsistentValues): 25401 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 25402 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 25403 254042010-08-02 Antonio Gomes <tonikitoo@webkit.org> 25405 25406 Reviewed by Kenneth Christiansen. 25407 25408 [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents 25409 https://bugs.webkit.org/show_bug.cgi?id=43168 25410 25411 QGraphicsWebView resizesToContents property has to work together with QWebPage's 25412 setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser. 25413 25414 * QtTestBrowser/launcherwindow.cpp: 25415 (LauncherWindow::applyPrefs): 25416 * QtTestBrowser/webview.cpp: 25417 (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes 25418 needed when toggle resizesToContents on/off. 25419 (WebViewGraphicsBased::resizeEvent): 25420 * QtTestBrowser/webview.h: 25421 (WebViewGraphicsBased::setCustomLayoutSize): Setter helper. 25422 (WebViewGraphicsBased::customLayoutSize): Getter helper. 25423 254242010-08-03 Jochen Eisinger <jochen@chromium.org> 25425 25426 Unreviewed. Adding myself as committer. 25427 25428 * Scripts/webkitpy/common/config/committers.py: 25429 254302010-08-02 Pavel Feldman <pfeldman@chromium.org> 25431 25432 Reviewed by Yury Semikhatsky. 25433 25434 Chromium DevTools: Get rid of DevTools RPC. 25435 25436 https://bugs.webkit.org/show_bug.cgi?id=43335 25437 25438 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: 25439 (DRTDevToolsAgent::sendMessageToInspectorFrontend): 25440 (DRTDevToolsAgent::call): 25441 * DumpRenderTree/chromium/DRTDevToolsAgent.h: 25442 * DumpRenderTree/chromium/DRTDevToolsCallArgs.h: 25443 (DRTDevToolsCallArgs::DRTDevToolsCallArgs): 25444 * DumpRenderTree/chromium/DRTDevToolsClient.cpp: 25445 (DRTDevToolsClient::sendMessageToBackend): 25446 (DRTDevToolsClient::call): 25447 * DumpRenderTree/chromium/DRTDevToolsClient.h: 25448 254492010-08-02 Kent Tamura <tkent@chromium.org> 25450 25451 Reviewed by Dimitri Glazkov. 25452 25453 [DRT/Chromium] Remove dependencies to some Chromium headers 25454 https://bugs.webkit.org/show_bug.cgi?id=43396 25455 25456 * DumpRenderTree/chromium/CppVariant.h: 25457 Remove base/basictypes.h because webkit_support.h contains it. 25458 * DumpRenderTree/chromium/EventSender.cpp: 25459 (getCurrentEventTimeSec): Use new wrapper function. 25460 * DumpRenderTree/chromium/TestNavigationController.h: 25461 Remove base/basictypes.h because webkit_support.h contains it. 25462 * DumpRenderTree/chromium/TestShell.cpp: 25463 (dumpHistoryItem): Use new wrapper function. 25464 * DumpRenderTree/chromium/WebViewHost.cpp: 25465 (WebViewHost::cancelledError): Use new wrapper function. 25466 (WebViewHost::didFailResourceLoad): Use new wrapper function. 25467 254682010-08-02 Martin Robinson <mrobinson@igalia.com> 25469 25470 Reviewed by Xan Lopez. 25471 25472 [GTK] DRT implement execCommand() 25473 https://bugs.webkit.org/show_bug.cgi?id=35351 25474 25475 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 25476 (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name. 25477 (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled. 25478 (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled. 25479 254802010-08-02 Sam Weinig <sam@webkit.org> 25481 25482 Reviewed by Anders Carlsson. 25483 25484 Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2). 25485 25486 * Scripts/old-run-webkit-tests: 25487 254882010-08-02 Jon Honeycutt <jhoneycutt@apple.com> 25489 25490 WebKitTestRunner needs to support loading custom fonts (via the 25491 WEBKIT_TESTFONTS environment variable) 25492 https://bugs.webkit.org/show_bug.cgi?id=42782 25493 25494 Reviewed by Adam Roben. 25495 25496 * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: 25497 (WTR::fontsPath): 25498 Copied from DRT code. Removed the fallback to DumpRenderTree.resources/, 25499 as this directory doesn't appear to be created anymore. 25500 (WTR::activateFonts): 25501 Loop through the fonts, and call AddFontResourceExW() for each. 25502 255032010-08-02 Jon Honeycutt <jhoneycutt@apple.com> 25504 25505 Restore the WebKitTestRunner.sln that was removed, and remove the 25506 correct one. 25507 25508 Rubber-stamped by Sam Weinig. 25509 25510 * WebKitTestRunner/WebKitTestRunner.sln: Added. 25511 * WebKitTestRunner/win/WebKitTestRunner.sln: Removed. 25512 255132010-08-02 Jon Honeycutt <jhoneycutt@apple.com> 25514 25515 Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live. 25516 25517 Remove the unused WebKitTestRunner.sln. 25518 25519 Reviewed by Sam Weinig. 25520 25521 * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: 25522 * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed. 25523 * WebKitTestRunner/WebKitTestRunner.sln: Removed. 25524 * WebKitTestRunner/win/InjectedBundle.vcproj: Added. 25525 * WebKitTestRunner/win/WebKitTestRunner.sln: 25526 255272010-08-02 Sam Weinig <sam@webkit.org> 25528 25529 Fix the windows build. 25530 25531 * WebKitTestRunner/win/main.cpp: 25532 255332010-07-29 Jon Honeycutt <jhoneycutt@apple.com> 25534 25535 Add a Skipped list on Windows, and have run-webkit-tests respect it. 25536 25537 Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so 25538 there are zero tests failing 25539 https://bugs.webkit.org/show_bug.cgi?id=43374 25540 25541 Reviewed by Adam Roben. 25542 25543 * Scripts/old-run-webkit-tests: 25544 If using WebKitTestRunner and Apple Windows WebKit, set the platform to 25545 win-wk2. When building the result hierarchy, if the platform is win-wk2, 25546 add it first to the list of platforms. 25547 255482010-08-02 Darin Adler <darin@apple.com> 25549 25550 Reviewed by Sam Weinig. 25551 25552 WebKitTestRunner needs layoutTestController.setCanOpenWindows 25553 https://bugs.webkit.org/show_bug.cgi?id=42321 25554 25555 WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete 25556 https://bugs.webkit.org/show_bug.cgi?id=42779 25557 25558 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added 25559 setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount 25560 25561 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 25562 (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of 25563 waiting for the first call to didCreatePage. 25564 (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page 25565 is created. Put other pages into a map. 25566 (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction 25567 of the main page. 25568 (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than 25569 the main page. 25570 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and 25571 closeOtherPages functions. 25572 25573 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 25574 (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than 25575 the main page affect dumping. 25576 (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto. 25577 25578 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 25579 (WTR::LayoutTestController::LayoutTestController): Initialize the new 25580 m_shouldCloseExtraWindows member. 25581 (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now. 25582 (WTR::LayoutTestController::windowCount): Added. 25583 25584 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 25585 Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete, 25586 windowCount, shouldCloseExtraWindowsAfterRunningTest, and 25587 m_shouldCloseExtraWindows. 25588 25589 * WebKitTestRunner/TestController.cpp: 25590 (WTR::TestController::shared): Return a pointer to the shared copy, but 25591 don't allocate and leak it. This seemed cleaner than adding an explicit 25592 finalize call to go along with the explicit initialize call. 25593 (WTR::TestController::TestController): Added calls to the initialize and 25594 run function, which are now done automatically. 25595 (WTR::TestController::~TestController): Added, since it's called now. 25596 (WTR::closeOtherPage): Added. Used to close pages other than the main page. 25597 (WTR::createOtherPage): Added. Used to create pages other than the main page. 25598 (WTR::TestController::initialize): Added code to set up createOtherPage. 25599 (WTR::TestController::run): Removed unused return value. 25600 * WebKitTestRunner/TestController.h: Made constructor and destructor public, 25601 and initialize and run private. Changed m_mainWebView to be an OwnPtr. 25602 25603 * WebKitTestRunner/mac/PlatformWebViewMac.mm: 25604 (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed 25605 to avoid releasing the window twice. Another way to handle it would be to 25606 remove the release, but this approach is slightly more robust because it works 25607 even if some other code calls the close method an extra time. 25608 25609 * WebKitTestRunner/mac/main.mm: 25610 (main): Use a stack-allocated TestController object instead of calling 25611 initalize and run on a globally allocated one. 25612 256132010-08-02 Tony Chang <tony@chromium.org> 25614 25615 Reviewed by David Levin. 25616 25617 add myself to the reviewers list 25618 https://bugs.webkit.org/show_bug.cgi?id=43366 25619 25620 * Scripts/webkitpy/common/config/committers.py: 25621 256222010-08-02 Anders Carlsson <andersca@apple.com> 25623 25624 Reviewed by Sam Weinig. 25625 25626 Cache JSNPObjects and fix bugs in the object map 25627 https://bugs.webkit.org/show_bug.cgi?id=43368 25628 25629 Test that we correctly throw exceptions when trying to do things to a JSObject that used to 25630 wrap an NPObject that came from a plug-in that is now destroyed. 25631 25632 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 25633 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: 25634 (PluginTest::Object::getProperty): 25635 (PluginTest::Object::NP_GetProperty): 25636 (PluginTest::Object::npClass): 25637 * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added. 25638 (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin): 25639 (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty): 25640 (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty): 25641 (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue): 25642 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 25643 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 25644 * GNUmakefile.am: 25645 256462010-08-02 Martin Robinson <mrobinson@igalia.com> 25647 25648 Reviewed by Xan Lopez. 25649 25650 [Gtk] DOM listeners get wrong keycodes for some keys 25651 https://bugs.webkit.org/show_bug.cgi?id=35170 25652 25653 Add support to all event senders for simulating keypad insert 25654 and print screen keys. 25655 25656 * DumpRenderTree/chromium/EventSender.cpp: 25657 (EventSender::keyDown): Add support for generating keypad insert and print screen. 25658 * DumpRenderTree/gtk/EventSender.cpp: 25659 (keyDownCallback): Ditto. 25660 * DumpRenderTree/mac/EventSendingController.mm: 25661 (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto. 25662 * DumpRenderTree/qt/EventSenderQt.cpp: 25663 (EventSender::keyDown): Ditto. 25664 * DumpRenderTree/win/EventSender.cpp: 25665 (keyDownCallback): Ditto. 25666 256672010-08-02 Martin Robinson <mrobinson@igalia.com> 25668 25669 Build fix for building against development versions of GTK+. GTK 2.22 25670 has not yet been released, so these function definitions must be conditionalized 25671 on the development version. 25672 25673 * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build. 25674 256752010-08-02 Tony Chang <tony@chromium.org> 25676 25677 Reviewed by Kent Tamura. 25678 25679 [chromium] use ChromiumDriver on Linux when running webkit tests 25680 https://bugs.webkit.org/show_bug.cgi?id=43273 25681 25682 * Scripts/webkitpy/layout_tests/port/chromium.py: 25683 256842010-08-02 Kent Tamura <tkent@chromium.org> 25685 25686 Reviewed by Dimitri Glazkov. 25687 25688 [DRT/Chromium] Always initialize GTK 25689 https://bugs.webkit.org/show_bug.cgi?id=43327 25690 25691 Call gtk_init() in order to fix plugin test crash. 25692 25693 * DumpRenderTree/chromium/DumpRenderTree.cpp: 25694 (main): Pass argc/argv to platformInit(). 25695 * DumpRenderTree/chromium/TestShell.h: 25696 * DumpRenderTree/chromium/TestShellGtk.cpp: 25697 (platformInit): Update parameters, call gtk_init(). 25698 * DumpRenderTree/chromium/TestShellMac.mm: 25699 (platformInit): Update parameters. 25700 * DumpRenderTree/chromium/TestShellWin.cpp: 25701 (platformInit): Update parameters. 25702 257032010-08-02 Balazs Kelemen <kb@inf.u-szeged.hu> 25704 25705 Reviewed by Simon Hausmann. 25706 25707 [Qt] Generate forwarding headers for WebKit2 25708 25709 https://bugs.webkit.org/show_bug.cgi?id=43336 25710 25711 * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources. 25712 257132010-08-02 Fumitoshi Ukai <ukai@chromium.org> 25714 25715 Reviewed by Kent Tamura. 25716 25717 WebSocket server should start with SO_REUSEADDR 25718 https://bugs.webkit.org/show_bug.cgi?id=43329 25719 25720 Pulls in pywebsocket-0.5.2. 25721 pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR. 25722 http://code.google.com/p/pywebsocket/source/detail?r=273 25723 25724 * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version 25725 257262010-08-01 Kent Tamura <tkent@chromium.org> 25727 25728 Reviewed by Dimitri Glazkov. 25729 25730 [DRT/Chromium] Remove string_util.h dependency 25731 https://bugs.webkit.org/show_bug.cgi?id=43312 25732 25733 * DumpRenderTree/chromium/LayoutTestController.cpp: 25734 (LayoutTestController::pathToLocalResource): 25735 Use string::find() instead of StartsWithASCII(). 25736 (LayoutTestController::cppVariantToInt32): 25737 Use strtol() instead of StringToNumber(). 25738 257392010-08-01 Sam Weinig <sam@webkit.org> 25740 25741 Reviewed by Anders Carlsson. 25742 25743 Add ability to reset frame names for WebKitTestRunner 25744 https://bugs.webkit.org/show_bug.cgi?id=43316 25745 25746 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 25747 (WTR::InjectedBundle::reset): 25748 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 25749 (WTR::InjectedBundlePage::reset): 25750 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 25751 257522010-08-01 Anders Carlsson <andersca@apple.com> 25753 25754 Reviewed by Sam Weinig. 25755 25756 Implement NPN_RemoveProperty 25757 https://bugs.webkit.org/show_bug.cgi?id=43315 25758 25759 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 25760 Add NPRuntimeRemoveProperty.cpp 25761 25762 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 25763 (PluginTest::NPN_GetStringIdentifier): 25764 (PluginTest::NPN_GetIntIdentifier): 25765 (PluginTest::NPN_RemoveProperty): 25766 Add NPN_ helpers. 25767 25768 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: 25769 Support more NPClass functions. 25770 25771 * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added. 25772 (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty): 25773 Test for NPN_RemoveProperty. 25774 25775 (NPRuntimeRemoveProperty::TestObject::hasMethod): 25776 (NPRuntimeRemoveProperty::TestObject::invoke): 25777 Add a testRemoveProperty method. 25778 25779 (NPRuntimeRemoveProperty::NPP_GetValue): 25780 Return the test object. 25781 25782 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 25783 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 25784 * GNUmakefile.am: 25785 Add NPRuntimeRemoveProperty.cpp 25786 257872010-07-30 Anders Carlsson <andersca@apple.com> 25788 25789 Reviewed by Sam Weinig. 25790 25791 Add an NPObject class template helper to TestNetscapePlugin 25792 https://bugs.webkit.org/show_bug.cgi?id=43288 25793 25794 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: 25795 Add some template magic to be able to figure out if a class has a member function of a given type. 25796 25797 (PluginTest::Object::create): 25798 Create an object. 25799 25800 (PluginTest::Object::invokeDefault): 25801 Add dummy function, this should never be called. 25802 25803 (PluginTest::Object::Object): 25804 Initialize m_pluginTest to 0. 25805 25806 (PluginTest::Object::~Object): 25807 Add virtual destructor. 25808 25809 (PluginTest::Object::NP_Allocate): 25810 Create a new object. 25811 25812 (PluginTest::Object::NP_Deallocate): 25813 Delete the object. 25814 25815 (PluginTest::Object::NP_InvokeDefault): 25816 Call invokeDefault. 25817 25818 (PluginTest::Object::npClass): 25819 Initialize the NPClass struct. 25820 25821 * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: 25822 (DocumentOpenInDestroyStream::NPP_DestroyStream): 25823 Move this inline. 25824 25825 * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp: 25826 (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault): 25827 (PluginScriptableNPObjectInvokeDefault::NPP_GetValue): 25828 Use the PluginTest::Object class template. 25829 258302010-07-31 Sam Weinig <sam@webkit.org> 25831 25832 Reviewed by Dan Bernstein. 25833 25834 Patch for https://bugs.webkit.org/show_bug.cgi?id=43305 25835 Add back WKBundleFrameCopyInnerText to fix ~50 test failures 25836 due to SVGElements not having the innerText function. 25837 25838 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 25839 (WTR::dumpFrameText): 25840 258412010-07-30 Sam Weinig <sam@webkit.org> 25842 25843 Reviewed by Maciej Stachowiak. 25844 25845 Patch for https://bugs.webkit.org/show_bug.cgi?id=43290 25846 Add structured message passing from the injected bundle to UIProcess 25847 25848 * MiniBrowser/mac/AppDelegate.m: 25849 (didRecieveMessageFromInjectedBundle): 25850 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 25851 (didClearWindowForFrame): 25852 (didRecieveMessage): 25853 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 25854 (WTR::InjectedBundle::done): 25855 (WTR::InjectedBundle::didReceiveMessage): 25856 * WebKitTestRunner/TestController.cpp: 25857 (WTR::TestController::initialize): 25858 (WTR::TestController::didReceiveMessageFromInjectedBundle): 25859 * WebKitTestRunner/TestController.h: 25860 * WebKitTestRunner/TestInvocation.cpp: 25861 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 25862 * WebKitTestRunner/TestInvocation.h: 25863 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 25864 258652010-07-30 Sam Weinig <sam@webkit.org> 25866 25867 Reviewed by Anders Carlsson. 25868 25869 Patch for https://bugs.webkit.org/show_bug.cgi?id=43275 25870 Make WKArrayRef more usable. 25871 25872 Remove now unnecessary const_casts. 25873 25874 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 25875 (WTR::dumpDescendantFrameScrollPositions): 25876 (WTR::dumpDescendantFramesText): 25877 258782010-07-30 Sam Weinig <sam@webkit.org> 25879 25880 Reviewed by Anders Carlsson. 25881 25882 Patch for https://bugs.webkit.org/show_bug.cgi?id=43274 25883 Add first pass of structured message passing. 25884 25885 Update Minibrowser and WebKitTestRunner to work with the new post message 25886 function. 25887 25888 * MiniBrowser/mac/AppDelegate.m: 25889 (didRecieveMessageFromInjectedBundle): 25890 (-[BrowserAppDelegate init]): 25891 * MiniBrowser/mac/MiniBrowser_Prefix.pch: 25892 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 25893 (didStartProvisionalLoadForFrame): 25894 (didReceiveServerRedirectForProvisionalLoadForFrame): 25895 (didFailProvisionalLoadWithErrorForFrame): 25896 (didCommitLoadForFrame): 25897 (didFinishLoadForFrame): 25898 (didFailLoadWithErrorForFrame): 25899 (didReceiveTitleForFrame): 25900 (didClearWindowForFrame): 25901 (didCreatePage): 25902 (willDestroyPage): 25903 (didRecieveMessage): 25904 (WKBundleInitialize): 25905 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 25906 (WTR::InjectedBundle::_didReceiveMessage): 25907 (WTR::InjectedBundle::didReceiveMessage): 25908 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 25909 * WebKitTestRunner/TestInvocation.cpp: 25910 (WTR::TestInvocation::invoke): 25911 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 25912 259132010-07-30 Anders Carlsson <andersca@apple.com> 25914 25915 Try to fix the layout test failures. 25916 25917 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 25918 (webkit_test_plugin_get_value): 25919 259202010-07-29 Anders Carlsson <andersca@apple.com> 25921 25922 Reviewed by Adam Roben. 25923 25924 Replace plugins/npruntime/bindings-test.html with a more sophisticated test 25925 https://bugs.webkit.org/show_bug.cgi?id=43232 25926 25927 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 25928 Add PluginScriptableNPObjectInvokeDefault.cpp. 25929 25930 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 25931 Remove invokeDefault callback function. 25932 25933 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 25934 (PluginTest::create): 25935 Move this to the top of the file. 25936 25937 (PluginTest::NPP_GetValue): 25938 Add default implementation. 25939 25940 (PluginTest::NPN_CreateObject): 25941 Add NPN_ wrapper. 25942 25943 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: 25944 (PluginTest::identifier): 25945 Add identifier getter. 25946 25947 * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: 25948 (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream): 25949 Add "using namespace std". 25950 25951 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 25952 (NPP_GetValue): 25953 Give PluginTest a chance to return a value. 25954 25955 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 25956 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 25957 * GNUmakefile.am: 25958 Add PluginScriptableNPObjectInvokeDefault.cpp. 25959 25960 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 25961 (webkit_test_plugin_get_value): 25962 Give PluginTest a chance to return a value. 25963 259642010-07-30 Steve Block <steveblock@google.com> 25965 25966 Reviewed by Steve Block. 25967 25968 Add LayoutTestController methods to test DeviceOrientation 25969 https://bugs.webkit.org/show_bug.cgi?id=39589 25970 25971 * DumpRenderTree/LayoutTestController.cpp: 25972 (setMockDeviceOrientationCallback): 25973 (LayoutTestController::staticFunctions): 25974 * DumpRenderTree/LayoutTestController.h: 25975 * DumpRenderTree/chromium/LayoutTestController.cpp: 25976 (LayoutTestController::LayoutTestController): 25977 (LayoutTestController::setMockDeviceOrientation): 25978 * DumpRenderTree/chromium/LayoutTestController.h: 25979 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 25980 (LayoutTestController::setMockDeviceOrientation): 25981 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 25982 (LayoutTestController::setMockDeviceOrientation): 25983 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 25984 (LayoutTestController::setMockDeviceOrientation): 25985 * DumpRenderTree/qt/LayoutTestControllerQt.h: 25986 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 25987 (LayoutTestController::setMockDeviceOrientation): 25988 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 25989 (LayoutTestController::setMockDeviceOrientation): 25990 * Scripts/build-webkit: 25991 259922010-07-29 Antonio Gomes <tonikitoo@webkit.org> 25993 25994 Reviewed by Kenneth Christiansen. 25995 25996 [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken 25997 https://bugs.webkit.org/show_bug.cgi?id=43209 25998 25999 When -resizes-to-content was being passed as a command line parameter it was simply 26000 not being set (although the corresponding menu item was marked as ON). 26001 User had to toggle the menu OFF and then ON again for it to take place. 26002 26003 Reason: LauncherWindow::applyPrefs method sets many user options passed in from 26004 the command line, but not resizesToContents. Patch addresses that. 26005 26006 * QtTestBrowser/launcherwindow.cpp: 26007 (LauncherWindow::createChrome): 26008 (LauncherWindow::applyPrefs): 26009 (LauncherWindow::toggleResizesToContents): 26010 * QtTestBrowser/webview.h: 26011 (WebViewGraphicsBased::resizesToContents): 26012 260132010-07-29 Antonio Gomes <tonikitoo@webkit.org> 26014 26015 Rubber-stamped by Simon Fraser. 26016 26017 [Qt] QtTestBrowser: more method grouping and clean ups. 26018 26019 Moving blocks of code around. Basically grouping related methods close to each. 26020 26021 * QtTestBrowser/launcherwindow.cpp: 26022 (LauncherWindow::initializeView): 26023 (LauncherWindow::createChrome): 26024 (LauncherWindow::changeViewportUpdateMode): 26025 (LauncherWindow::showFPS): 26026 (LauncherWindow::newWindow): 26027 (LauncherWindow::cloneWindow): 26028 * QtTestBrowser/launcherwindow.h: 26029 260302010-07-30 Mahesh Kulkarni <mahesh.kulkarni@nokia.com> 26031 26032 Reviewed by Tor Arne Vestbø. 26033 26034 [QT][Symbian] QtTestBrowser missing location capabilities 26035 https://bugs.webkit.org/show_bug.cgi?id=43235 26036 26037 QtTestBrowser missing capabilities to use QtMobility::QLocation. 26038 26039 * QtTestBrowser/QtTestBrowser.pro: 26040 260412010-07-29 Anders Carlsson <andersca@apple.com> 26042 26043 Add PluginTest.cpp 26044 26045 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 26046 260472010-07-29 Dirk Pranke <dpranke@chromium.org> 26048 26049 Reviewed by Eric Seidel. 26050 26051 Update download URLs for python irclib package; the old URLs 26052 pointed at a specific mirror host and not the general sourceforge 26053 URLs. 26054 26055 https://bugs.webkit.org/show_bug.cgi?id=43228 26056 26057 * Scripts/webkitpy/thirdparty/__init__.py: 26058 260592010-07-29 Anders Carlsson <andersca@apple.com> 26060 26061 Fix typo. 26062 26063 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 26064 260652010-07-29 Anders Carlsson <andersca@apple.com> 26066 26067 Another attempt at fixing the Qt and GTK+ build. 26068 26069 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 26070 (webkit_test_plugin_new_instance): 26071 (webkit_test_plugin_destroy_stream): 26072 260732010-07-29 Anders Carlsson <andersca@apple.com> 26074 26075 Another build fix attempt. 26076 26077 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 26078 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 26079 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 26080 (webkit_test_plugin_new_instance): 26081 * GNUmakefile.am: 26082 260832010-07-29 Anders Carlsson <andersca@apple.com> 26084 26085 Try to fix Windows and Unix builds. 26086 26087 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 26088 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 26089 (webkit_test_plugin_new_instance): 26090 (webkit_test_plugin_destroy_stream): 26091 260922010-07-29 Anders Carlsson <andersca@apple.com> 26093 26094 Reviewed by Sam Weinig. 26095 26096 Refactor TestNetscapePlugin so tests can be split in separate files 26097 https://bugs.webkit.org/show_bug.cgi?id=43220 26098 26099 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 26100 Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp. 26101 26102 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 26103 (pluginAllocate): 26104 Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream. 26105 26106 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: 26107 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added. 26108 (PluginTest::PluginTest): 26109 Initialize m_npp and the test identifier. 26110 26111 (PluginTest::createTestFunctions): 26112 Return the map from identifiers to createTest functions. 26113 26114 (PluginTest::registerCreateTestFunction): 26115 Insert the identifier and create function pair in the map. 26116 26117 (PluginTest::create): 26118 Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object. 26119 26120 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added. 26121 (PluginTest::Register::Register): 26122 Helper class template for registering plug-in tests. 26123 26124 (PluginTest::Register::create): 26125 Create a new test of the given type. 26126 26127 * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added. 26128 (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream): 26129 Add a test that calls testDocumentOpen from its NPP_DestroyStream callback. 26130 26131 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 26132 (NPP_New): 26133 Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream". 26134 26135 (NPP_DestroyStream): 26136 Call the plug-in test NPP_DestroyStream member function. 26137 26138 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 26139 Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp. 26140 261412010-07-29 Martin Robinson <mrobinson@igalia.com> 26142 26143 Unreviewed build fix. 26144 26145 Add missing second argument to assert_lint in new style checker tests. 26146 26147 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 26148 261492010-07-29 Anders Carlsson <andersca@apple.com> 26150 26151 Reviewed by Adam Roben. 26152 26153 check-webkit-style shouldn't complain about NPAPI functions 26154 https://bugs.webkit.org/show_bug.cgi?id=43211 26155 26156 Allow underscores in functions that start with NPN_, NPP_ or NP_. 26157 26158 * Scripts/webkitpy/style/checkers/cpp.py: 26159 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 26160 261612010-07-29 Victor Wang <victorw@chromium.org> 26162 26163 Unreviewed, rolling out r64270. 26164 http://trac.webkit.org/changeset/64270 26165 https://bugs.webkit.org/show_bug.cgi?id=39589 26166 26167 The patch breaks chromium webkit unittest 26168 26169 * DumpRenderTree/LayoutTestController.cpp: 26170 (LayoutTestController::staticFunctions): 26171 * DumpRenderTree/LayoutTestController.h: 26172 * DumpRenderTree/chromium/LayoutTestController.cpp: 26173 (LayoutTestController::LayoutTestController): 26174 * DumpRenderTree/chromium/LayoutTestController.h: 26175 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 26176 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 26177 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 26178 * DumpRenderTree/qt/LayoutTestControllerQt.h: 26179 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 26180 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 26181 * Scripts/build-webkit: 26182 261832010-07-29 Antonio Gomes <tonikitoo@webkit.org> 26184 26185 Reviewed by Kenneth Christiansen. 26186 26187 [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp 26188 https://bugs.webkit.org/show_bug.cgi?id=43199 26189 26190 There is no sense in keeping WebPage method definitions in main.cpp once 26191 webpage.cpp already exists. 26192 26193 No behavior change. 26194 26195 * QtTestBrowser/main.cpp: 26196 * QtTestBrowser/webpage.cpp: 26197 (WebPage::createWindow): 26198 (WebPage::createPlugin): 26199 262002010-07-29 Antonio Gomes <tonikitoo@webkit.org> 26201 26202 Reviewed by Kenneth Christiansen. 26203 26204 [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser) 26205 https://bugs.webkit.org/show_bug.cgi?id=43170 26206 26207 Moving LauncherWindow class out of main.cpp to its own .cpp and .h files: 26208 launcherwindow.{cpp|h} 26209 26210 No behavior change. 26211 26212 Also changed all global static variables (named "gXXX") from main.cpp to 26213 static public variables of the LauncherWindow class. 26214 26215 * QtTestBrowser/QtTestBrowser.pro: 26216 * QtTestBrowser/launcherwindow.cpp: Added. 26217 * QtTestBrowser/launcherwindow.h: Added. 26218 * QtTestBrowser/main.cpp: 26219 (LauncherApplication::handleUserOptions): 26220 (main): 26221 262222010-07-29 Martin Robinson <mrobinson@igalia.com> 26223 26224 Reviewed by Xan Lopez. 26225 26226 Build fix for building against GTK+ 3.x. GSEAL requires that we 26227 access internals of the GdkDragContext via methods. For older versions 26228 of GTK+, define those methods. 26229 26230 * DumpRenderTree/gtk/EventSender.cpp: 26231 (gdk_drag_context_get_selected_action): Added. 26232 (gdk_drag_context_get_actions): Added. 26233 (dispatchEvent): Use the two new accessor methods. 26234 262352010-07-29 Adam Roben <aroben@apple.com> 26236 26237 Always say "plugins directory" when referring to a directory 26238 containing one or more plugins 26239 26240 Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin 26241 directory" when it means "plugins directory" 26242 26243 Reviewed by John Sullivan. 26244 26245 * WebKitTestRunner/TestController.cpp: 26246 (WTR::TestController::initialize): Updated for rename. 26247 262482010-07-29 Adam Roben <aroben@apple.com> 26249 26250 Always say "directory" when referring to a plugin directory 26251 26252 Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path" 26253 when it means "plugin directory" 26254 26255 Reviewed by John Sullivan. 26256 26257 * WebKitTestRunner/TestController.cpp: 26258 (WTR::TestController::initialize): Updated for renames. 26259 26260 * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to 26261 m_testPluginDirectory. 26262 (WTR::TestController::testPluginDirectory): Renamed from 26263 testPluginPath. 26264 26265 * WebKitTestRunner/mac/TestControllerMac.mm: 26266 (WTR::TestController::initializeTestPluginDirectory): 26267 * WebKitTestRunner/win/TestControllerWin.cpp: 26268 (WTR::TestController::initializeTestPluginDirectory): 26269 Renamed from initializeTestPluginPath and updated for rename. 26270 262712010-07-29 Csaba Osztrogonác <ossy@webkit.org> 26272 26273 Reviewed by Antonio Gomes. 26274 26275 Initialize all members of NPClass struct. 26276 https://bugs.webkit.org/show_bug.cgi?id=43193 26277 26278 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 26279 262802010-07-29 Csaba Osztrogonác <ossy@webkit.org> 26281 26282 Reviewed by Antonio Gomes. 26283 26284 Warning fix on platforms where XP_MACOSX is undefined. 26285 https://bugs.webkit.org/show_bug.cgi?id=43192 26286 26287 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: 26288 Use #if defined(XP_MACOSX) instead of #if XP_MACOSX . 26289 262902010-07-29 Adam Roben <aroben@apple.com> 26291 26292 Give find-included-framework-headers our standard license 26293 26294 * Scripts/find-included-framework-headers: Used the license from 26295 WebCore/LICENSE-APPLE. 26296 262972010-07-29 Adam Roben <aroben@apple.com> 26298 26299 Speed up find-included-framework-headers 26300 26301 We only do one invocation of find now, no longer pipe to grep, and 26302 replace uniq with sort -u. 26303 26304 Also added a license header. 26305 26306 * Scripts/find-included-framework-headers: 26307 263082010-07-29 Steve Block <steveblock@google.com> 26309 26310 Reviewed by Jeremy Orlow. 26311 26312 Add LayoutTestController methods to test DeviceOrientation 26313 https://bugs.webkit.org/show_bug.cgi?id=39589 26314 26315 * DumpRenderTree/LayoutTestController.cpp: 26316 (setMockDeviceOrientationCallback): 26317 (LayoutTestController::staticFunctions): 26318 * DumpRenderTree/LayoutTestController.h: 26319 * DumpRenderTree/chromium/LayoutTestController.cpp: 26320 * DumpRenderTree/chromium/LayoutTestController.h: 26321 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 26322 (LayoutTestController::setMockDeviceOrientation): 26323 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 26324 (LayoutTestController::setMockDeviceOrientation): 26325 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 26326 (LayoutTestController::setMockDeviceOrientation): 26327 * DumpRenderTree/qt/LayoutTestControllerQt.h: 26328 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 26329 (LayoutTestController::setMockDeviceOrientation): 26330 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 26331 (LayoutTestController::setMockDeviceOrientation): 26332 * Scripts/build-webkit: 26333 263342010-07-28 Kenichi Ishibashi <bashi@google.com> 26335 26336 Reviewed by Shinichiro Hamaji. 26337 26338 Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814> 26339 check-webkit-style gives false positives in single-line functions. 26340 26341 * Scripts/webkitpy/style/checkers/cpp.py: 26342 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 26343 263442010-07-28 Darin Adler <darin@apple.com> 26345 26346 Reviewed by Sam Weinig. 26347 26348 WebKitTestRunner needs to support layoutTestController.execCommand 26349 <https://bugs.webkit.org/show_bug.cgi?id=42538> 26350 26351 WebKitTestRunner needs layoutTestController.isCommandEnabled 26352 <https://bugs.webkit.org/show_bug.cgi?id=42671> 26353 26354 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 26355 Added execCommand and isCommandEnabled. 26356 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 26357 (WTR::LayoutTestController::execCommand): Added. 26358 (WTR::LayoutTestController::isCommandEnabled): Added. 26359 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto. 26360 263612010-07-28 Kent Tamura <tkent@chromium.org> 26362 26363 Reviewed by Dimitri Glazkov. 26364 26365 [DRT/Chromium] Introduce drt_expectations.txt for NRWT 26366 https://bugs.webkit.org/show_bug.cgi?id=43123 26367 26368 Introduce LayoutTests/platform/chromium/drt_expectations.txt, 26369 which overrides test expectations only for DumpRenderTree, in 26370 order to manage what problems are investigated. 26371 This change will be reverted when we switch to DRT completely. 26372 26373 * Scripts/webkitpy/layout_tests/port/chromium.py: 26374 Add drt_expectations.txt content to the result of 26375 test_expectations_overrides() if --use-drt is specified. 26376 263772010-07-28 Brady Eidson <beidson@apple.com> 26378 26379 Reviewed by Darin Adler. 26380 26381 First pass at visited link support for WK2 26382 https://bugs.webkit.org/show_bug.cgi?id=43157 26383 26384 * MiniBrowser/mac/AppDelegate.m: 26385 (didNavigateWithNavigationData): 26386 (didPerformClientRedirect): 26387 (didPerformServerRedirect): 26388 (didUpdateHistoryTitle): 26389 (populateVisitedLinks): Added for the new version of the HistoryClient. 26390 (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s) 26391 26392 * MiniBrowser/mac/BrowserWindowController.m: 26393 (-[BrowserWindowController awakeFromNib]): 26394 263952010-07-28 Robin Dunn <robin@alldunn.com> 26396 26397 Reviewed by Kevin Ollivier. 26398 26399 Add DOM bindings support for wx port. 26400 26401 * DumpRenderTree/wscript: 26402 * wx/browser/wscript: 26403 * wx/build/settings.py: 26404 264052010-07-28 Tony Chang <tony@chromium.org> 26406 26407 Reviewed by Kent Tamura. 26408 26409 [chromium] cleanup temp files left by Linux DRT 26410 https://bugs.webkit.org/show_bug.cgi?id=43062 26411 26412 * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS 26413 * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left 26414 by crashed DRTs 26415 264162010-07-28 Antonio Gomes <tonikitoo@webkit.org> 26417 26418 Rubber-stamped by Kenneth Christiansen. 26419 26420 More Developer menu items reordering. 26421 26422 Grouping related menu items together, visually and logically (in the code). 26423 26424 No behavior change. 26425 26426 * QtTestBrowser/main.cpp: 26427 (LauncherWindow::createChrome): 26428 264292010-07-27 Kinuko Yasuda <kinuko@chromium.org> 26430 26431 Reviewed by Ojan Vafai. 26432 26433 Add FILE_SYSTEM build flag for FileSystem API 26434 https://bugs.webkit.org/show_bug.cgi?id=42915 26435 26436 * Scripts/build-webkit: 26437 264382010-07-27 Martin Robinson <mrobinson@igalia.com> 26439 26440 Reviewed by David Levin. 26441 26442 Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to 26443 https://bugs.webkit.org/show_bug.cgi?id=43090 26444 26445 * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods. 26446 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior. 26447 264482010-07-27 Kent Tamura <tkent@chromium.org> 26449 26450 Unreviewed, trivial typo fix. 26451 26452 * Scripts/webkitpy/layout_tests/port/chromium.py: 26453 Fix a wrong method name committed by r64109. 26454 264552010-07-27 Sam Weinig <sam@webkit.org> 26456 26457 Reviewed by Anders Carlsson. 26458 26459 Patch for https://bugs.webkit.org/show_bug.cgi?id=43087 26460 Clean up handling of strings at the WebKit2 API layer. 26461 26462 * MiniBrowser/mac/BrowserWindowController.m: 26463 (runJavaScriptAlert): 26464 (runJavaScriptConfirm): 26465 (runJavaScriptPrompt): 26466 (didNavigateWithNavigationData): 26467 (-[BrowserWindowController updateProvisionalURLForFrame:]): 26468 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 26469 (_didClearWindowForFrame): 26470 264712010-07-27 Ojan Vafai <ojan@chromium.org> 26472 26473 Reviewed by Eric Seidel. 26474 26475 webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash' 26476 https://bugs.webkit.org/show_bug.cgi?id=42984 26477 26478 squash and no_squash have been intentionally erroring for a couple weeks now. 26479 But post-commits was just broken. Just remove squash/no_squash. 26480 26481 * Scripts/webkitpy/tool/steps/abstractstep.py: 26482 * Scripts/webkitpy/tool/steps/options.py: 26483 264842010-07-27 Kevin Ollivier <kevino@theolliviers.com> 26485 26486 [wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND. 26487 26488 * wx/build/settings.py: 26489 264902010-07-27 Adam Roben <aroben@apple.com> 26491 26492 Mac build fix 26493 26494 * MiniBrowser/mac/BrowserWindowController.m: 26495 (processDidExit): 26496 (-[BrowserWindowController awakeFromNib]): 26497 Added processDidExit support. 26498 264992010-07-26 Antonio Gomes <tonikitoo@webkit.org> 26500 26501 Rubber-stamped by Simon Hausmann. 26502 26503 [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible. 26504 26505 Move some less useful menu items on Developers menu from the top to the bottom, so 26506 QGraphicsView menu goes to the top, and becomes more quickly accessible. 26507 26508 * QtTestBrowser/main.cpp: 26509 (LauncherWindow::createChrome): 26510 265112010-07-26 Adam Roben <aroben@apple.com> 26512 26513 Fix the path to InjectedBundle.dll in Debug_Internal builds 26514 26515 Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load 26516 InjectedBundle.dll in the Debug_Internal configuration 26517 26518 Reviewed by Anders Carlsson. 26519 26520 * WebKitTestRunner/win/TestControllerWin.cpp: 26521 (WTR::TestController::initializeInjectedBundlePath): Add the _debug 26522 suffix only in Debug_All builds. 26523 265242010-07-25 Mahesh Kulkarni <mahesh.kulkarni@nokia.com> 26525 26526 Reviewed by Darin Adler. 26527 26528 https://bugs.webkit.org/show_bug.cgi?id=42947 26529 Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw 26530 error. Without which dumpRenderTree crashes. 26531 26532 * Scripts/old-run-webkit-tests: 26533 265342010-07-27 Kent Tamura <tkent@chromium.org> 26535 26536 Reviewed by Dimitri Glazkov. 26537 26538 https://bugs.webkit.org/show_bug.cgi?id=42956 26539 [DRT/Chromium] Fix "out of sync" assertion error 26540 26541 Fix an assertion error on Windows like the following: 26542 100721 20:16:46 chromium.py:386 CRITICAL Test got out of sync: 26543 |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html| 26544 |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html| 26545 26546 * Scripts/webkitpy/layout_tests/port/chromium.py: 26547 If the url matches with "file:///[a-z]:", does case-ignore comparison. 26548 GURL capitalize the driver letter of a file: URL. 26549 265502010-07-26 Darin Adler <darin@apple.com> 26551 26552 Reviewed by Sam Weinig. 26553 26554 WebKitTestRunner needs to support layoutTestController.counterValueForElementById 26555 https://bugs.webkit.org/show_bug.cgi?id=42537 26556 26557 WebKitTestRunner needs layoutTestController.markerTextForListItem 26558 https://bugs.webkit.org/show_bug.cgi?id=42549 26559 26560 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: 26561 Fixed _paramterExpression typo. Improved support for string type as a 26562 return value, so we don't try to include DOMString.h and we can convert 26563 the string to a JSValue by calling JSValueMakeStringOrNull. 26564 26565 * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: 26566 Added JSValueMakeStringOrNull, used by the code generator. 26567 26568 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 26569 Added counterValueForElementById and markerTextForListItem. 26570 26571 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 26572 Moved constant to the top of the file. 26573 (WTR::toCF): Added. Converts strings to CFStringRef. 26574 (WTR::toWK): Added. Converts strings to WKStringRef. 26575 (WTR::toJS): Added. Converts strings to JSStringRef. 26576 (WTR::setProperty): Moved this function to the top of the file 26577 rather than having it down where it's used inside the class. Also 26578 renamed it so it's a separate function rather than an overload of 26579 JSObjectSetProperty. 26580 (WTR::propertyValue): Copied this here from InjectedBundlePage.cpp. 26581 Should move it somewhere we can share it. 26582 (WTR::propertyObject): Ditto. 26583 (WTR::getElementById): Added. Calls getElementById through the magic 26584 of JavaScript. 26585 (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): 26586 Chagned to use toWK instead of four local variables. 26587 (WTR::LayoutTestController::counterValueForElementById): Added. 26588 Calls WKBundleFrameCopyCounterValue. 26589 (WTR::LayoutTestController::markerTextForListItem): Added. 26590 Calls WKBundleFrameCopyMarkerText. 26591 26592 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 26593 Added counterValueForElementById and markerTextForListItem. 26594 265952010-07-26 Martin Robinson <mrobinson@igalia.com> 26596 26597 Reviewed by Gustavo Noronha Silva. 26598 26599 [GTK] The EventSender should support simulating drop events 26600 https://bugs.webkit.org/show_bug.cgi?id=39844 26601 26602 Add initial dropping support to the GTK+ EventSender. 26603 26604 * DumpRenderTree/gtk/DumpRenderTree.cpp: 26605 (createWebView): Listen for some new drag-and-drop signals. 26606 * DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext. 26607 (dispatchEvent): 26608 Detect situations where a drag is either starting or ending and massage 26609 GTK+ into sending the appropriate signals to the WebView. 26610 (replaySavedEvents): Remove comment. 26611 (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender. 26612 (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins. 26613 (dragEndCallback): Clear the currentDragSourceContext when a drag ends. 26614 (dragFailedCallback): Disable the GTK+ drag failed animation. 26615 * DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks. 26616 266172010-07-26 Daniel Bates <dbates@rim.com> 26618 26619 Reviewed by Darin Adler. 26620 26621 svn-unapply warns of uninitialized variable when unapplying 26622 a patch that describes an svn move operation 26623 https://bugs.webkit.org/show_bug.cgi?id=42036 26624 26625 Fixes Perl uninitialized variable warnings when un-applying 26626 a patch that moves a file. 26627 26628 * Scripts/svn-unapply: 26629 - Modified patch() so that it initializes $patch to the empty 26630 string when we don't have svnConvertedText (such as when 26631 reversing a diff that represents a svn copy/move operation). 26632 266332010-07-26 Sam Weinig <sam@webkit.org> 26634 26635 Reviewed by Anders Carlsson. 26636 26637 Move some non-APIish functions into private headers. 26638 26639 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 26640 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 26641 266422010-07-26 Sam Weinig <sam@webkit.org> 26643 26644 Reviewed by Anders Carlsson. 26645 26646 Fix for https://bugs.webkit.org/show_bug.cgi?id=42986 26647 Add prompt and confirm client functions to WebKit2 26648 26649 * MiniBrowser/mac/BrowserWindowController.m: 26650 (-[BrowserWindowController awakeFromNib]): 26651 266522010-07-26 Adam Roben <aroben@apple.com> 26653 26654 Windows build fix 26655 26656 * MiniBrowser/MiniBrowser.vcproj: 26657 * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: 26658 Removed empty attributes so the values will be picked up from the 26659 vsprops files. (Also removed a couple of attributes that accidentally 26660 duplicated values from the vsprops files.) 26661 266622010-07-26 Brian Weinstein <bweinstein@apple.com> 26663 26664 Rubber-stamped by Adam Roben. 26665 26666 Touch MiniBrowser's stdafx to fix the build. 26667 26668 * MiniBrowser/win/stdafx.h: 26669 266702010-07-26 Hayato Ito <hayato@chromium.org> 26671 26672 Reviewed by Shinichiro Hamaji. 26673 26674 Add pretty printer of WTF::Vector for GDB 7. 26675 26676 https://bugs.webkit.org/show_bug.cgi?id=40909 26677 26678 * gdb/wtf.py: Added. 26679 266802010-07-26 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 26681 26682 Reviewed by Simon Hausmann. 26683 26684 [Qt] Fix feature detection regexp 26685 26686 We were missing the last feature 26687 26688 * Scripts/webkitdirs.pm: 26689 266902010-07-25 Darin Adler <darin@apple.com> 26691 26692 Reviewed by Dan Bernstein. 26693 26694 WebKitTestRunner needs to support layoutTestController.dumpSelectionRect 26695 https://bugs.webkit.org/show_bug.cgi?id=42326 26696 26697 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 26698 Added dumpSelectionRect. 26699 26700 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 26701 (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this 26702 does nothing because its purpose is to change pixel test output and 26703 we do not have pixel tests implemented yet. 26704 267052010-07-25 Darin Adler <darin@apple.com> 26706 26707 Reviewed by Maciej Stachowiak. 26708 26709 WebKitTestRunner needs to support layoutTestController.keepWebHistory 26710 https://bugs.webkit.org/show_bug.cgi?id=42323 26711 26712 Added keepWebHistory and computedStyleIncludingVisitedInfo. 26713 26714 Also fixed misspellings of the word "receive". 26715 26716 Also tweaked the names of some of the LayoutTestController members. 26717 26718 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: 26719 Added support for a type named "object" that is passed and returns as 26720 a JSValueRef. 26721 26722 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 26723 Added keepWebHistory and computedStyleIncludingVisitedInfo. Also 26724 put setAcceptsEditing up nearer the top. 26725 26726 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 26727 (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive. 26728 (WTR::InjectedBundle::initialize): Ditto. 26729 (WTR::InjectedBundle::didReceiveMessage): Ditto. 26730 (WTR::InjectedBundle::reset): Reset the state of visited links between 26731 tests. Also eliminated the unused argument to the LayoutTestController 26732 create function. 26733 (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added. 26734 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto. 26735 26736 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 26737 (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing 26738 instead of acceptsEditing. 26739 (WTR::InjectedBundlePage::shouldEndEditing): Ditto. 26740 (WTR::InjectedBundlePage::shouldInsertNode): Ditto. 26741 (WTR::InjectedBundlePage::shouldInsertText): Ditto. 26742 (WTR::InjectedBundlePage::shouldDeleteRange): Ditto. 26743 (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto. 26744 (WTR::InjectedBundlePage::shouldApplyStyle): Ditto. 26745 26746 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 26747 (WTR::LayoutTestController::create): Removed uneeded argument. 26748 (WTR::LayoutTestController::LayoutTestController): Removed unneeded 26749 argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing. 26750 (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs 26751 about the fact that this works on the main frame. 26752 (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto. 26753 (WTR::LayoutTestController::keepWebHistory): Added. 26754 (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added. 26755 (WTR::JSObjectSetProperty): Added. Helper to make the function below 26756 cleaner. 26757 (WTR::LayoutTestController::makeWindowObject): Changed to use the 26758 overload of JSObjectSetProperty above. 26759 26760 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to 26761 match above. 26762 26763 * WebKitTestRunner/TestController.cpp: 26764 (WTR::TestController::initialize): Fixed mispellings of receive. 26765 (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto. 26766 (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto. 26767 * WebKitTestRunner/TestController.h: Ditto. 26768 * WebKitTestRunner/TestInvocation.cpp: 26769 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto. 26770 * WebKitTestRunner/TestInvocation.h: Ditto. 26771 267722010-07-25 Alexey Proskuryakov <ap@apple.com> 26773 26774 Reviewed by Sam Weinig. 26775 26776 https://bugs.webkit.org/show_bug.cgi?id=42193 26777 Support layoutTestController.dumpEditingDelegates in WebKitTestRunner 26778 26779 Step 2 - add the rest of editing delegates. 26780 26781 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 26782 (WTR::operator<<): Fixed to not crash when range is null. 26783 (WTR::InjectedBundlePage::InjectedBundlePage): 26784 (WTR::InjectedBundlePage::_shouldEndEditing): 26785 (WTR::InjectedBundlePage::_shouldInsertNode): 26786 (WTR::InjectedBundlePage::_shouldInsertText): 26787 (WTR::InjectedBundlePage::_shouldDeleteRange): 26788 (WTR::InjectedBundlePage::_shouldChangeSelectedRange): 26789 (WTR::InjectedBundlePage::_shouldApplyStyle): 26790 (WTR::InjectedBundlePage::_didBeginEditing): 26791 (WTR::InjectedBundlePage::_didEndEditing): 26792 (WTR::InjectedBundlePage::_didChange): 26793 (WTR::InjectedBundlePage::_didChangeSelection): 26794 (WTR::InjectedBundlePage::shouldEndEditing): 26795 (WTR::InjectedBundlePage::shouldInsertNode): 26796 (WTR::InjectedBundlePage::shouldInsertText): 26797 (WTR::InjectedBundlePage::shouldDeleteRange): 26798 (WTR::InjectedBundlePage::shouldChangeSelectedRange): 26799 (WTR::InjectedBundlePage::shouldApplyStyle): 26800 (WTR::InjectedBundlePage::didBeginEditing): 26801 (WTR::InjectedBundlePage::didEndEditing): 26802 (WTR::InjectedBundlePage::didChange): 26803 (WTR::InjectedBundlePage::didChangeSelection): 26804 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 26805 268062010-07-24 Chris Fleizach <cfleizach@apple.com> 26807 26808 Reviewed by David Kilzer. 26809 26810 AX: need a layout test testing misspelled words in attributed strings 26811 https://bugs.webkit.org/show_bug.cgi?id=42899 26812 26813 * DumpRenderTree/AccessibilityUIElement.cpp: 26814 (attributedStringForRangeCallback): 26815 (attributedStringRangeIsMisspelledCallback): 26816 (AccessibilityUIElement::getJSClass): 26817 * DumpRenderTree/AccessibilityUIElement.h: 26818 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 26819 (AccessibilityUIElement::attributedStringForRange): 26820 (AccessibilityUIElement::attributedStringRangeIsMisspelled): 26821 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 26822 (AccessibilityUIElement::attributedStringForRange): 26823 (AccessibilityUIElement::attributedStringRangeIsMisspelled): 26824 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 26825 (AccessibilityUIElement::attributedStringForRange): 26826 (AccessibilityUIElement::attributedStringRangeIsMisspelled): 26827 268282010-07-23 David Kilzer <ddkilzer@apple.com> 26829 26830 <http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles 26831 26832 Reviewed by Mark Rowe. 26833 26834 * Scripts/check-for-inappropriate-files-in-framework: Added 26835 check for the SHALLOW_BUNDLE environment variable so that the 26836 script will work with iOS WebKit builds. 26837 * Scripts/check-for-webkit-framework-include-consistency: Ditto. 26838 268392010-07-22 Darin Adler <darin@apple.com> 26840 26841 Reviewed by Sam Weinig. 26842 26843 Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2 26844 https://bugs.webkit.org/show_bug.cgi?id=42847 26845 26846 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 26847 (WTR::operator<<): Replaced the WKStringToUTF8 function with 26848 a set of overloaded stream operators. 26849 (WTR::dumpPath): Changed to use ostringstream and return a string. 26850 (WTR::propertyValue): Added. 26851 (WTR::propertyObject): Added. 26852 (WTR::propertyString): Added. 26853 (WTR::numericWindowPropertyValue): Changed to call propertyValue. 26854 (WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence 26855 since we now have suitable streaming functions. 26856 (WTR::dumpFrameText): Use propertyObject and propertyString instead of 26857 WKBundleFrameCopyInnerText. 26858 (WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence 26859 since we now have suitable streaming functions. 26860 (WTR::InjectedBundlePage::dump): Ditto. 26861 (WTR::InjectedBundlePage::willAddMessageToConsole): Ditto. 26862 (WTR::InjectedBundlePage::willSetStatusbarText): Ditto. 26863 (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto. 26864 (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto. 26865 (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto. 26866 268672010-07-22 Alexey Proskuryakov <ap@apple.com> 26868 26869 Reviewed by Sam Weinig and Darin Adler. 26870 26871 https://bugs.webkit.org/show_bug.cgi?id=42193 26872 Support layoutTestController.dumpEditingDelegates in WebKitTestRunner 26873 26874 Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests 26875 fixed, but this makes difference one line smaller on many editing tests. 26876 26877 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 26878 Added dumpEditingCallbacks() and setAcceptsEditing(). 26879 26880 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 26881 (WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree. 26882 (WTR::operator<<): Print a range. 26883 (WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing 26884 clients. 26885 (WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far. 26886 (WTR::InjectedBundlePage::shouldBeginEditing): Ditto. 26887 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client 26888 calls. 26889 26890 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 26891 (WTR::LayoutTestController::LayoutTestController): 26892 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 26893 (WTR::LayoutTestController::dumpEditingCallbacks): 26894 (WTR::LayoutTestController::setAcceptsEditing): 26895 (WTR::LayoutTestController::acceptsEditing): 26896 (WTR::LayoutTestController::shouldDumpEditingCallbacks): 26897 Store m_acceptsEditing and m_dumpEditingCallbacks. 26898 268992010-07-22 Yael Aharon <yael.aharon@nokia.com> 26900 26901 Reviewed by Laszlo Gombos. 26902 26903 [Qt] QtWebKit needs public API for Notifications. 26904 https://bugs.webkit.org/show_bug.cgi?id=41413 26905 26906 Update DumpRenderTree and QtTestBrowser to use the new API. 26907 Add new DRT API to flag that notifications permission requests should be ignored. 26908 26909 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 26910 (WebCore::WebPage::WebPage): 26911 (WebCore::WebPage::requestPermission): 26912 (WebCore::WebPage::checkPermission): 26913 (WebCore::WebPage::cancelRequestsForPermission): 26914 * DumpRenderTree/qt/DumpRenderTreeQt.h: 26915 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 26916 (LayoutTestController::reset): 26917 (LayoutTestController::ignoreDesktopNotificationPermissionRequests): 26918 (LayoutTestController::checkDesktopNotificationPermission): 26919 * DumpRenderTree/qt/LayoutTestControllerQt.h: 26920 (LayoutTestController::ignoreReqestForPermission): 26921 * QtTestBrowser/main.cpp: 26922 (LauncherWindow::LauncherWindow): 26923 * QtTestBrowser/webpage.cpp: 26924 (WebPage::WebPage): 26925 (WebPage::requestPermission): 26926 (WebPage::checkPermission): 26927 (WebPage::cancelRequestsForPermission): 26928 * QtTestBrowser/webpage.h: 26929 269302010-07-22 Darin Adler <darin@apple.com> 26931 26932 Reviewed by Sam Weinig. 26933 26934 WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText 26935 https://bugs.webkit.org/show_bug.cgi?id=42325 26936 26937 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 26938 Added dumpChildFramesAsText. 26939 26940 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 26941 (WTR::dumpFrameText): Added. 26942 (WTR::dumpDescendantFramesText): Added. 26943 (WTR::InjectedBundlePage::dumpAllFramesText): Added. 26944 (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function 26945 instead of the shouldDumpAsText function, and added a case for AllFramesText. 26946 26947 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText. 26948 26949 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 26950 (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with 26951 m_whatToDump. 26952 26953 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added 26954 dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive, 26955 and shouldDumpSourceAsWebArchive. Added whatToDump. 26956 269572010-07-22 Adam Roben <aroben@apple.com> 26958 26959 Windows build fix 26960 26961 Inspired by r63881. 26962 26963 * MiniBrowser/MiniBrowser.vcproj: 26964 * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: 26965 Removed pre- and post-build events so they will be inherited from the 26966 vsprops files. 26967 269682010-07-21 Darin Adler <darin@apple.com> 26969 26970 Reviewed by Sam Weinig. 26971 26972 WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions 26973 https://bugs.webkit.org/show_bug.cgi?id=42548 26974 26975 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 26976 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 26977 (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file. 26978 (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name. 26979 Changed to a file-internal function instead of a member function. 26980 (WTR::dumpDescendantFrameScrollPositions): Added. 26981 (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added. 26982 (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when 26983 appropriate. Also streamlined all the WKStringToUTF8 call sites. 26984 (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8. 26985 (WTR::InjectedBundlePage::willSetStatusbarText): Ditto. 26986 (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto. 26987 (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto. 26988 (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto. 26989 26990 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes. 26991 26992 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 26993 (WTR::LayoutTestController::LayoutTestController): Initialize 26994 m_shouldDumpAllFrameScrollPositions. 26995 (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from 26996 shouldDumpFrameScrollPositions. 26997 26998 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a 26999 bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions, 27000 and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition. 27001 270022010-07-21 Darin Adler <darin@apple.com> 27003 27004 Reviewed by Sam Weinig. 27005 27006 WebKitTestRunner needs to support dumping of scroll position 27007 https://bugs.webkit.org/show_bug.cgi?id=42514 27008 27009 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 27010 (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef. 27011 27012 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 27013 (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef 27014 instead of JSContextRef. 27015 (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate. 27016 (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition. 27017 (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added. 27018 (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef 27019 instead of JSContextRef. 27020 27021 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from 27022 arguments that simply repeat the argument type. Added dumpFrameScrollPosition. 27023 27024 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 27025 (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently 27026 returns false. 27027 (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently 27028 returns false. 27029 (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches 27030 the logic in DumpRenderTree. 27031 27032 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes. 27033 27034 * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore. 27035 270362010-07-21 Kevin Ollivier <kevino@theolliviers.com> 27037 27038 [wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs. 27039 27040 * wx/build/settings.py: 27041 270422010-07-21 Sam Weinig <sam@webkit.org> 27043 27044 Reviewed by Anders Carlsson. 27045 27046 Patch for https://bugs.webkit.org/show_bug.cgi?id=42539 27047 WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages 27048 27049 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 27050 (WTR::InjectedBundlePage::InjectedBundlePage): 27051 (WTR::InjectedBundlePage::_willAddMessageToConsole): 27052 (WTR::InjectedBundlePage::_willSetStatusbarText): 27053 (WTR::InjectedBundlePage::_willRunJavaScriptAlert): 27054 (WTR::InjectedBundlePage::_willRunJavaScriptConfirm): 27055 (WTR::InjectedBundlePage::_willRunJavaScriptPrompt): 27056 (WTR::InjectedBundlePage::willAddMessageToConsole): 27057 (WTR::InjectedBundlePage::willSetStatusbarText): 27058 (WTR::InjectedBundlePage::willRunJavaScriptAlert): 27059 (WTR::InjectedBundlePage::willRunJavaScriptConfirm): 27060 (WTR::InjectedBundlePage::willRunJavaScriptPrompt): 27061 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 27062 270632010-07-21 Adam Roben <aroben@apple.com> 27064 27065 Give InjectedBundle our standard set of configurations (minus the 27066 *_Cairo variants) 27067 27068 InjectedBundle's Debug_All configuration was the same as is Debug 27069 configuration, and it was missing a Debug_Internal configuration. 27070 27071 Fixes <http://webkit.org/b/42749> InjectedBundle's build 27072 configurations are screwy 27073 27074 Reviewed by Darin Adler. 27075 27076 * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added 27077 debug_internal.vsprops and debug_all.vsprops to the Debug_All 27078 configuration. Added a Debug_Internal configuration. 27079 27080 * WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal 27081 variant of InjectedBundle when we're using the Debug_Internal solution 27082 configuration. 27083 270842010-07-21 Adam Roben <aroben@apple.com> 27085 27086 Move InjectedBundle's settings to a vsprops file 27087 27088 This will make it easier to change settings for all configurations, 27089 and to add new configurations. 27090 27091 Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops 27092 files 27093 27094 Reviewed by Darin Adler. 27095 27096 * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added. 27097 Moved settings here... 27098 * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from 27099 here. 27100 271012010-07-21 Adam Roben <aroben@apple.com> 27102 27103 Give MiniBrowser our standard set of configurations (minus the *_Cairo 27104 variants) 27105 27106 MiniBrowser already had a configuration called "Release", but it was 27107 using mostly the same settings as Debug. And its Debug configuration 27108 was using the settings that Debug_Internal should be using. 27109 27110 Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations 27111 are screwy 27112 27113 Reviewed by Darin Adler. 27114 27115 * MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from 27116 the Debug configuration. Remove debug.vsprops and 27117 debug_internal.vsprops from the Release configuration and replace them 27118 with release.vsprops. Added Debug_Internal and Debug_All 27119 configurations. 27120 271212010-07-21 Adam Roben <aroben@apple.com> 27122 27123 Move MiniBrowser's settings to a vsprops file 27124 27125 This will make it easier to change settings for all configurations, 27126 and to add new configurations. 27127 27128 MiniBrowser should use vsprops files 27129 https://bugs.webkit.org/show_bug.cgi?id=42745 27130 27131 Reviewed by Darin Adler. 27132 27133 * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved 27134 settings here... 27135 * MiniBrowser/MiniBrowser.vcproj: ...from here. 27136 271372010-07-21 Adam Roben <aroben@apple.com> 27138 27139 Fix compiler warnings when building MiniBrowser 27140 27141 Also cleaned up the .vcproj a bit. 27142 27143 Fixes <http://webkit.org/b/42743>. 27144 27145 Reviewed by Darin Adler. 27146 27147 * MiniBrowser/MiniBrowser.vcproj: Removed all settings that are 27148 already defined in .vsprops files. This also fixes a warning about 27149 /EDITANDCONTINUE being incompatible with /SAFESEH. 27150 27151 * MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so 27152 that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE 27153 being redefined. (I think this will also get us closer to building 27154 with VC++ Express.) 27155 271562010-07-20 Sam Weinig <sam@webkit.org> 27157 27158 Reviewed by Jon Honeycutt. 27159 27160 Fix obvious typo. 27161 27162 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 27163 (WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value. 27164 271652010-07-20 Tony Chang <tony@chromium.org> 27166 27167 Reviewed by Kent Tamura. 27168 27169 [chromium] by default, dumpAsText should disable pixel results 27170 https://bugs.webkit.org/show_bug.cgi?id=42715 27171 27172 * DumpRenderTree/chromium/LayoutTestController.cpp: 27173 (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override 27174 271752010-07-20 Adam Roben <aroben@apple.com> 27176 27177 Windows build fix 27178 27179 * MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny 27180 WebKit.lib instead of the old, dusty WebKit2.lib. 27181 271822010-07-20 Adam Roben <aroben@apple.com> 27183 27184 Stop linking WebKitTestRunner against getopt 27185 27186 Use of getopt was removed in r63700. 27187 27188 Fixes <http://webkit.org/b/42714> WebKitTestRunner links against 27189 getopt, but doesn't need to 27190 27191 Reviewed by Sam Weinig. 27192 27193 * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib 27194 from all configurations. 27195 271962010-07-20 Adam Roben <aroben@apple.com> 27197 27198 Make run-webkit-tests --webkit-test-runner "work" on Windows 27199 27200 WebKitTestRunner crashes on launch, but at least the scripts build and 27201 launch it! 27202 27203 Fixes <http://webkit.org/b/42709> run-webkit-tests 27204 --webkit-test-runner bails with an error on Windows 27205 27206 Reviewed by Anders Carlsson. 27207 27208 * Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on 27209 Windows. 27210 * WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following 27211 projects (from first-built to last-built): FindSafari, ImageDiff, 27212 InjectedBundleGenerated, InjectedBundle, WebKitTestRunner. 27213 272142010-07-20 Adam Roben <aroben@apple.com> 27215 27216 Change build-webkit back to building WebKit.sln on Windows 27217 27218 WebKit.sln builds all the same projects as WebKit2.sln, and the latter 27219 is being removed. 27220 27221 Rubber-stamped in advance by Steve Falkenburg. 27222 27223 * Scripts/build-webkit: 27224 272252010-07-20 Adam Roben <aroben@apple.com> 27226 27227 Windows build fix 27228 27229 * MiniBrowser/win/BrowserWindow.cpp: Added missing #include. 27230 272312010-07-20 Joseph Pecoraro <joepeck@webkit.org> 27232 27233 Reviewed by Geoffrey Garen. 27234 27235 WebScriptObject Should Allow Safely Checking For Key Existence 27236 https://bugs.webkit.org/show_bug.cgi?id=42613 27237 27238 Normal ObjCController workflow for a WebScriptObject test. 27239 27240 * DumpRenderTree/mac/ObjCController.m: 27241 (+[ObjCController isSelectorExcludedFromWebScript:]): 27242 (+[ObjCController webScriptNameForSelector:]): 27243 (-[ObjCController testHasWebScriptKey:]): 27244 272452010-07-20 Chris Marrin <cmarrin@apple.com> 27246 27247 Reviewed by Simon Fraser. 27248 27249 https://bugs.webkit.org/show_bug.cgi?id=42118 27250 Disable compositing/webgl tests if WebGL is not enabled 27251 27252 * Scripts/old-run-webkit-tests: 27253 272542010-07-20 Anton Muhin <antonm@chromium.org> 27255 27256 Reviewed by Darin Adler. 27257 27258 Print additional information about exception if failed to connect to apache (in verbose mode). 27259 https://bugs.webkit.org/show_bug.cgi?id=42627 27260 27261 * Scripts/webkitpy/layout_tests/port/http_server_base.py: 27262 272632010-07-20 Tony Chang <tony@chromium.org> 27264 27265 Reviewed by David Levin. 27266 27267 [chromium] only pass --force to gclient sync if explicitly stated 27268 https://bugs.webkit.org/show_bug.cgi?id=42581 27269 27270 * BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should 27271 always pass --force since it's hard to do manual cleanups 27272 * Scripts/update-webkit-chromium: only pass --force if --force is 27273 passed in 27274 272752010-07-19 Anders Carlsson <andersca@apple.com> 27276 27277 Fix build. 27278 27279 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 27280 Paths of generated files should be relative to the build product. 27281 272822010-07-19 Daniel Bates <dbates@rim.com> 27283 27284 Reviewed by Adam Roben. 27285 27286 [Win] Implement LayoutTestController::markerTextForListItem() 27287 https://bugs.webkit.org/show_bug.cgi?id=37930 27288 27289 Implements DRT support for markerTextForListItem in the Windows port. 27290 27291 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 27292 (LayoutTestController::markerTextForListItem): Implemented. 27293 272942010-07-19 Jessie Berlin <jberlin@apple.com> 27295 27296 Windows build fix. Unreviewed. 27297 27298 * WebKitTestRunner/win/TestControllerWin.cpp: 27299 (WTR::TestController::initializeTestPluginPath): 27300 273012010-07-19 Sam Weinig <sam@webkit.org> 27302 27303 Reviewed by Jon Honeycutt. 27304 27305 Remove dependency on getopt from WebKitTestRunner. 27306 27307 - Simplify options parsing and eliminate unused options. 27308 27309 * WebKitTestRunner/TestController.cpp: 27310 (WTR::TestController::TestController): 27311 (WTR::TestController::initialize): 27312 * WebKitTestRunner/TestController.h: 27313 (WTR::TestController::testPluginPath): 27314 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 27315 * WebKitTestRunner/mac/TestControllerMac.mm: 27316 (WTR::TestController::platformInitialize): 27317 (WTR::TestController::initializeTestPluginPath): 27318 * WebKitTestRunner/win/TestControllerWin.cpp: 27319 (WTR::TestController::platformInitialize): 27320 (WTR::TestController::initializeTestPluginPath): 27321 273222010-07-19 Diego Gonzalez <diegohcg@webkit.org> 27323 27324 Reviewed by Antonio Gomes. 27325 27326 [Qt] MiniBrowser: Progress indication at address bar 27327 https://bugs.webkit.org/show_bug.cgi?id=42565 27328 27329 Make possible to see load progress at address bar based on 27330 QtTestBrowser solution 27331 27332 * MiniBrowser/qt/BrowserWindow.cpp: 27333 (BrowserWindow::BrowserWindow): 27334 (BrowserWindow::loadProgress): 27335 * MiniBrowser/qt/BrowserWindow.h: 27336 273372010-07-19 Diego Gonzalez <diegohcg@webkit.org> 27338 27339 Reviewed by Antonio Gomes. 27340 27341 [Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load 27342 https://bugs.webkit.org/show_bug.cgi?id=42564 27343 27344 * MiniBrowser/qt/BrowserWindow.cpp: 27345 (BrowserView::load): 27346 (BrowserWindow::BrowserWindow): 27347 (BrowserWindow::titleChanged): 27348 (BrowserWindow::urlChanged): 27349 * MiniBrowser/qt/BrowserWindow.h: 27350 273512010-07-19 Sam Weinig <weinig@apple.com> 27352 27353 Reviewed by Adam Roben. 27354 27355 Patch for https://bugs.webkit.org/show_bug.cgi?id=42532 27356 Auto-generate the JS bindings for WebKitTestRunner's script objects. 27357 27358 * WebKitTestRunner/Configurations/Base.xcconfig: 27359 * WebKitTestRunner/Configurations/DebugRelease.xcconfig: 27360 * WebKitTestRunner/DerivedSources.make: Added. 27361 * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added. 27362 * WebKitTestRunner/InjectedBundle/Bindings: Added. 27363 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added. 27364 * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added. 27365 (WTR::JSWrappable::~JSWrappable): 27366 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added. 27367 (WTR::JSWrapper::wrap): 27368 (WTR::JSWrapper::unwrap): 27369 (WTR::unwrapObject): 27370 (WTR::JSWrapper::initialize): 27371 (WTR::JSWrapper::finalize): 27372 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added. 27373 (WTR::toJS): 27374 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added. 27375 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 27376 (WTR::InjectedBundlePage::dump): 27377 (WTR::InjectedBundlePage::setStatusbarText): 27378 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 27379 (WTR::LayoutTestController::wrapperClass): 27380 (WTR::LayoutTestController::waitUntilDone): 27381 (WTR::LayoutTestController::makeWindowObject): 27382 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 27383 (WTR::LayoutTestController::shouldDumpAsText): 27384 (WTR::LayoutTestController::dumpAsText): 27385 (WTR::LayoutTestController::shouldDumpStatusCallbacks): 27386 (WTR::LayoutTestController::dumpStatusCallbacks): 27387 (WTR::LayoutTestController::waitToDump): 27388 (WTR::LayoutTestController::testRepaint): 27389 (WTR::LayoutTestController::repaintSweepHorizontally): 27390 * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: 27391 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 27392 * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added. 27393 * WebKitTestRunner/win/build-generated-files.sh: Added. 27394 273952010-07-19 Mark Rowe <mrowe@apple.com> 27396 27397 Clean up the buildbot configuration a little. 27398 27399 * BuildSlaveSupport/build.webkit.org-config/config.json: 27400 274012010-07-19 Chris Marrin <cmarrin@apple.com> 27402 27403 Reviewed by Darin Adler. 27404 27405 https://bugs.webkit.org/show_bug.cgi?id=42118 27406 Disable WebGL on Leopard for now. 27407 27408 LayoutTests fail on some graphics hardware on Leopard because one of the features we use, 27409 GL_ARB_framebuffer_object, is not universally available in Leopard like it is in 27410 SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a 27411 software OpenGL driver on machines without this support. 27412 27413 * Scripts/build-webkit: 27414 274152010-07-19 Simon Fraser <simon.fraser@apple.com> 27416 27417 Reviewed by Brady Eidson. 27418 27419 Fix MiniBrowser to update URL as you browse 27420 https://bugs.webkit.org/show_bug.cgi?id=42591 27421 27422 Hook up various loading notifications to update the URL bar in MiniBrowser. 27423 27424 * MiniBrowser/mac/BrowserWindowController.m: 27425 (_didStartProvisionalLoadForFrame): 27426 (_didReceiveServerRedirectForProvisionalLoadForFrame): 27427 (_didFailProvisionalLoadWithErrorForFrame): 27428 (_didCommitLoadForFrame): 27429 (_didFailLoadWithErrorForFrame): 27430 (-[BrowserWindowController updateProvisionalURLForFrame:]): 27431 (-[BrowserWindowController didStartProvisionalLoadForFrame:]): 27432 (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]): 27433 (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]): 27434 (-[BrowserWindowController didFailLoadWithErrorForFrame:]): 27435 (-[BrowserWindowController didCommitLoadForFrame:]): 27436 274372010-07-19 Alexey Proskuryakov <ap@apple.com> 27438 27439 Reviewed by Darin Adler. 27440 27441 https://bugs.webkit.org/show_bug.cgi?id=42586 27442 Log all canceled authentication attempts in DumpRenderTree 27443 27444 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 27445 (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): 27446 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 27447 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): 27448 It's important to know whether an auth sheet appeared. Added logging to "no preset credentials" 27449 case. 27450 274512010-07-19 Sheriff Bot <webkit.review.bot@gmail.com> 27452 27453 Unreviewed, rolling out r63671. 27454 http://trac.webkit.org/changeset/63671 27455 https://bugs.webkit.org/show_bug.cgi?id=42575 27456 27457 broke windows (Requested by weinig on #webkit). 27458 27459 * WebKitTestRunner/Configurations/Base.xcconfig: 27460 * WebKitTestRunner/Configurations/DebugRelease.xcconfig: 27461 * WebKitTestRunner/DerivedSources.make: Removed. 27462 * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed. 27463 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed. 27464 * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed. 27465 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed. 27466 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed. 27467 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed. 27468 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 27469 (WTR::InjectedBundlePage::dump): 27470 (WTR::InjectedBundlePage::setStatusbarText): 27471 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 27472 (WTR::LayoutTestController::setWaitToDump): 27473 (WTR::displayCallback): 27474 (WTR::dumpAsTextCallback): 27475 (WTR::dumpStatusCallbacksCallback): 27476 (WTR::waitUntilDoneCallback): 27477 (WTR::notifyDoneCallback): 27478 (WTR::numberOfActiveAnimationsCallback): 27479 (WTR::pauseAnimationAtTimeOnElementWithIdCallback): 27480 (WTR::repaintSweepHorizontallyCallback): 27481 (WTR::testRepaintCallback): 27482 (WTR::layoutTestControllerObjectFinalize): 27483 (WTR::LayoutTestController::makeWindowObject): 27484 (WTR::LayoutTestController::getJSClass): 27485 (WTR::LayoutTestController::staticFunctions): 27486 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 27487 (WTR::LayoutTestController::dumpAsText): 27488 (WTR::LayoutTestController::setDumpAsText): 27489 (WTR::LayoutTestController::dumpStatusCallbacks): 27490 (WTR::LayoutTestController::setDumpStatusCallbacks): 27491 (WTR::LayoutTestController::setTestRepaint): 27492 (WTR::LayoutTestController::setTestRepaintSweepHorizontally): 27493 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 27494 274952010-07-19 Sam Weinig <sam@webkit.org> 27496 27497 Reviewed by Adam Roben. 27498 27499 Patch for https://bugs.webkit.org/show_bug.cgi?id=42532 27500 Auto-generate the JS bindings for WebKitTestRunner's script objects. 27501 27502 * WebKitTestRunner/Configurations/Base.xcconfig: 27503 * WebKitTestRunner/Configurations/DebugRelease.xcconfig: 27504 * WebKitTestRunner/DerivedSources.make: Added. 27505 * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added. 27506 * WebKitTestRunner/InjectedBundle/Bindings: Added. 27507 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added. 27508 * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added. 27509 (WTR::JSWrappable::~JSWrappable): 27510 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added. 27511 (WTR::JSWrapper::wrap): 27512 (WTR::JSWrapper::unwrap): 27513 (WTR::unwrapObject): 27514 (WTR::JSWrapper::initialize): 27515 (WTR::JSWrapper::finalize): 27516 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added. 27517 (WTR::toJS): 27518 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added. 27519 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 27520 (WTR::InjectedBundlePage::dump): 27521 (WTR::InjectedBundlePage::setStatusbarText): 27522 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 27523 (WTR::LayoutTestController::wrapperClass): 27524 (WTR::LayoutTestController::waitUntilDone): 27525 (WTR::LayoutTestController::makeWindowObject): 27526 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 27527 (WTR::LayoutTestController::shouldDumpAsText): 27528 (WTR::LayoutTestController::dumpAsText): 27529 (WTR::LayoutTestController::shouldDumpStatusCallbacks): 27530 (WTR::LayoutTestController::dumpStatusCallbacks): 27531 (WTR::LayoutTestController::waitToDump): 27532 (WTR::LayoutTestController::testRepaint): 27533 (WTR::LayoutTestController::repaintSweepHorizontally): 27534 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 27535 275362010-07-19 Tony Chang <tony@chromium.org> 27537 27538 Reviewed by David Levin. 27539 27540 fix chromium linux compile on ubuntu maverick 27541 https://bugs.webkit.org/show_bug.cgi?id=42528 27542 27543 * Scripts/webkitdirs.pm: add a chomp to eat a newline that breaks the make command line 27544 275452010-07-19 Adam Roben <aroben@apple.com> 27546 27547 When dumping a response's MIME type, print its URL's last path 27548 component rather than its suitable-for-test-result form 27549 27550 This matches the Mac behavior. 27551 27552 Fixes <http://webkit.org/b/42276> 27553 http/tests/loading/preload-slow-loading.php and 27554 http/tests/mime/uppercase-mime-type.html fail on Windows 27555 27556 Reviewed by Anders Carlsson. 27557 27558 * DumpRenderTree/win/DumpRenderTree.cpp: 27559 (urlSuitableForTestResult): Moved code to actually extract the last 27560 path component from here... 27561 (lastPathComponent): ...to here. 27562 27563 * DumpRenderTree/win/DumpRenderTreeWin.h: Added lastPathComponent. 27564 27565 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 27566 (ResourceLoadDelegate::didReceiveResponse): Use the URL's last path 27567 component, rather than its suitable-for-test-result form, to match 27568 Mac. 27569 275702010-07-19 Anders carlsson <andersca@apple.com> 27571 27572 Reviewed by Adam Roben. 27573 27574 WebKit2 does not have application cache 27575 https://bugs.webkit.org/show_bug.cgi?id=42552 27576 27577 * WebKitTestRunner/TestInvocation.cpp: 27578 (WTR::TestInvocation::resetPreferencesToConsistentValues): 27579 Set up default preferences. Right now just enables the web application cache. 27580 27581 (WTR::TestInvocation::invoke): 27582 Call resetPreferencesToConsistentValues. 27583 27584 * WebKitTestRunner/TestInvocation.h: 27585 275862010-07-19 Kent Tamura <tkent@chromium.org> 27587 27588 Reviewed by Adam Roben. 27589 27590 Fix NewRunWebKitTests to work on Windows. 27591 https://bugs.webkit.org/show_bug.cgi?id=41180 27592 27593 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 27594 Specifying python explicitly. 27595 275962010-07-18 Anders Carlsson <andersca@apple.com> 27597 27598 Reviewed by Dan Bernstein. 27599 27600 Add dumping of statusbar text to WebKitTestRunner 27601 https://bugs.webkit.org/show_bug.cgi?id=42516 27602 27603 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 27604 (WTR::InjectedBundlePage::InjectedBundlePage): 27605 (WTR::InjectedBundlePage::_setStatusbarText): 27606 (WTR::InjectedBundlePage::setStatusbarText): 27607 Dump the statusbar text. 27608 27609 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 27610 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 27611 (WTR::LayoutTestController::LayoutTestController): 27612 Initialize m_dumpStatusCallbacks to false. 27613 27614 (WTR::dumpStatusCallbacksCallback): 27615 Implement JSC callback. 27616 27617 (WTR::LayoutTestController::staticFunctions): 27618 Add dumpStatusCallbacks. 27619 27620 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 27621 (WTR::LayoutTestController::dumpStatusCallbacks): 27622 (WTR::LayoutTestController::setDumpStatusCallbacks): 27623 Add setter and getter for m_dumpStatusCallbacks. 27624 276252010-07-17 Anders Carlsson <andersca@apple.com> 27626 27627 Reviewed by Maciej Stachowiak. 27628 27629 * WebKitTestRunner/TestController.cpp: 27630 (WTR::TestController::initialize): 27631 Get the test plug-in path and set it on the context. 27632 27633 * WebKitTestRunner/TestController.h: 27634 * WebKitTestRunner/mac/TestControllerMac.mm: 27635 (WTR::TestController::initializeInjectedBundlePath): 27636 Simplify this code by using NSBundle. 27637 27638 (WTR::TestController::testPluginPath): 27639 Return the test plug-in path. 27640 27641 * WebKitTestRunner/win/TestControllerWin.cpp: 27642 (WTR::TestController::testPluginPath): 27643 Ditto. 27644 276452010-07-16 Adam Barth <abarth@webkit.org> 27646 27647 Reviewed by Eric Seidel. 27648 27649 Teach webkitpy about queues.webkit.org 27650 https://bugs.webkit.org/show_bug.cgi?id=42492 27651 27652 * Scripts/webkitpy/common/net/statusserver.py: 27653 276542010-07-16 Ada Chan <adachan@apple.com> 27655 27656 Reviewed by Alice Liu. 27657 27658 Fix Windows build. 27659 27660 * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: 27661 276622010-07-16 Sam Weinig <sam@webkit.org> 27663 27664 Reviewed by Anders Carlsson. 27665 27666 Fix for https://bugs.webkit.org/show_bug.cgi?id=42482 27667 <rdar://problem/8197701> 27668 Add notification of when the BackForwardList changes 27669 to aid invalidation of Back/Forward related UI elements. 27670 27671 * MiniBrowser/mac/BrowserWindowController.m: 27672 (_didStartProvisionalLoadForFrame): 27673 (_didCommitLoadForFrame): 27674 (_didFailLoadWithErrorForFrame): 27675 (_didChangeBackForwardList): 27676 (-[BrowserWindowController awakeFromNib]): 27677 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 27678 276792010-07-16 Kent Tamura <tkent@chromium.org> 27680 27681 Reviewed by Darin Fisher. 27682 27683 [Chromium] <input type=number> UI implementation for Windows 27684 https://bugs.webkit.org/show_bug.cgi?id=42259 27685 27686 * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: 27687 (WebThemeEngineDRT::paintSpinButton): 27688 Added. Check state consistency and use existing arrow painting code. 27689 * DumpRenderTree/chromium/WebThemeEngineDRT.h: 27690 276912010-07-16 Alice Liu <alice.liu@apple.com> 27692 27693 Reviewed by Sam Weinig. 27694 27695 https://bugs.webkit.org/show_bug.cgi?id=42430 27696 Make WebKitTestRunner on Windows actually load and run a test 27697 27698 * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Export WKBundleInitialize. 27699 (WKBundleInitialize): 27700 * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added. Output is a dll. 27701 * WebKitTestRunner/TestInvocation.cpp: Create a Windows-style path on Windows 27702 (WTR::createWKURL): 27703 * WebKitTestRunner/WebKitTestRunnerPrefix.h: Change check for Windows platform to match 27704 other existing checks, and avoid including Platform.h 27705 * WebKitTestRunner/win/PlatformWebViewWin.cpp: 27706 (WTR::registerWindowClass): Added. 27707 (WTR::PlatformWebView::PlatformWebView): Implemented. 27708 (WTR::PlatformWebView::~PlatformWebView): Implemented. 27709 (WTR::PlatformWebView::page): Implemented. 27710 * WebKitTestRunner/win/TestControllerWin.cpp: 27711 (WTR::TestController::initializeInjectedBundlePath): Implemented. Provide build 27712 configuration specific path to InjectedBundle.dll. 27713 * WebKitTestRunner/win/TestInvocationWin.cpp: 27714 (WTR::TestInvocation::runUntil): Implemented. 27715 * WebKitTestRunner/win/WebKitTestRunner.sln: Added InjectedBundle project. 27716 * WebKitTestRunner/win/WebKitTestRunner.vcproj: Cleaned up unnecessary dependencies. 27717 277182010-07-16 Brady Eidson <beidson@apple.com> 27719 27720 Reviewed by Sam Weinig. 27721 27722 Make revalidation of back/forward work a little better with page loads 27723 https://bugs.webkit.org/show_bug.cgi?id=42470 27724 27725 * MiniBrowser/mac/BrowserWindow.xib: 27726 * MiniBrowser/mac/BrowserWindowController.h: 27727 * MiniBrowser/mac/BrowserWindowController.m: 27728 (-[BrowserWindowController validateToolbar]): 27729 (_didStartProvisionalLoadForFrame): 27730 (_didCommitLoadForFrame): 27731 (_didFailLoadWithErrorForFrame): 27732 277332010-07-16 Nikolas Zimmermann <nzimmermann@rim.com> 27734 27735 Reviewed by Dirk Schulze. 27736 27737 Add possibility to dumpAsText and generate a pixel test result 27738 https://bugs.webkit.org/show_bug.cgi?id=42374 27739 27740 Add optional parameter to setDumpAsText() to allow generating a pixel test result even if dumpAsText mode. 27741 setDumpAsText(true) will also generate a pixel test result now, when running run-webkit-tests --pixel-tests. 27742 27743 This is needed for the svg/dynamic-updates tests, which don't want render tree dumps but text dumps + a pixel test result. 27744 At some point DRT changed to not generate pixel test results when using dumpAsText - which makes sense, but breaks the svg/dynamic-updates test. 27745 27746 Implemented for all DRT platforms, except Qt, as it's not clear how arguments to functions like "setDumpAsText" are handled. 27747 (Qt always dumps pixel tests when using --pixel-tests mode, so it does not break anything) 27748 27749 * DumpRenderTree/LayoutTestController.cpp: 27750 (LayoutTestController::LayoutTestController): 27751 (dumpAsTextAndPixelsCallback): 27752 (LayoutTestController::staticFunctions): 27753 * DumpRenderTree/LayoutTestController.h: 27754 (LayoutTestController::dumpAsTextAndPixels): 27755 (LayoutTestController::setDumpAsTextAndPixels): 27756 * DumpRenderTree/chromium/LayoutTestController.cpp: 27757 (LayoutTestController::LayoutTestController): 27758 (LayoutTestController::dumpAsTextAndPixels): 27759 (LayoutTestController::reset): 27760 * DumpRenderTree/chromium/LayoutTestController.h: 27761 (LayoutTestController::shouldDumpAsTextAndPixels): 27762 * DumpRenderTree/chromium/TestShell.cpp: 27763 (TestShell::dump): 27764 * DumpRenderTree/gtk/DumpRenderTree.cpp: 27765 (dump): 27766 * DumpRenderTree/mac/DumpRenderTree.mm: 27767 (dump): 27768 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 27769 (WebCore::DumpRenderTree::dump): 27770 * DumpRenderTree/win/DumpRenderTree.cpp: 27771 (dump): 27772 * DumpRenderTree/wx/DumpRenderTreeWx.cpp: 27773 (dump): 27774 277752010-07-16 Kent Hansen <kent.hansen@nokia.com> 27776 27777 Unreviewed. Adding myself as committer. 27778 27779 * Scripts/webkitpy/common/config/committers.py: 27780 277812010-07-16 Shinichiro Hamaji <hamaji@chromium.org> 27782 27783 Another uneviewed attempt to fix build. 27784 27785 Printing test results differ between machines, we should use ImageDiff instead 27786 https://bugs.webkit.org/show_bug.cgi?id=20011 27787 27788 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 27789 (createPagedBitmapContext): 27790 277912010-07-16 Shinichiro Hamaji <hamaji@chromium.org> 27792 27793 Unreviewed tiger build fix. 27794 27795 Printing test results differ between machines, we should use ImageDiff instead 27796 https://bugs.webkit.org/show_bug.cgi?id=20011 27797 27798 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 27799 (createBitmapContext): 27800 (createBitmapContextFromWebView): 27801 278022010-07-15 Shinichiro Hamaji <hamaji@chromium.org> 27803 27804 Unreviewed build fix. 27805 27806 Printing test results differ between machines, we should use ImageDiff instead 27807 https://bugs.webkit.org/show_bug.cgi?id=20011 27808 27809 * DumpRenderTree/PixelDumpSupport.cpp: 27810 (dumpWebViewAsPixelsAndCompareWithExpected): 27811 278122010-07-15 Shinichiro Hamaji <hamaji@chromium.org> 27813 27814 Reviewed by Darin Adler. 27815 27816 Printing test results differ between machines, we should use ImageDiff instead 27817 https://bugs.webkit.org/show_bug.cgi?id=20011 27818 27819 * DumpRenderTree/PixelDumpSupport.cpp: 27820 (dumpWebViewAsPixelsAndCompareWithExpected): 27821 * DumpRenderTree/PixelDumpSupport.h: 27822 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 27823 (createBitmapContext): This function was added to share bitmap context creation code. 27824 (createBitmapContextFromWebView): 27825 (createPagedBitmapContext): 27826 278272010-07-15 Yuta Kitamura <yutak@chromium.org> 27828 27829 Reviewed by Kent Tamura. 27830 27831 Pull in pywebsocket-0.5.1 27832 https://bugs.webkit.org/show_bug.cgi?id=42353 27833 27834 pywebsocket-0.5.1 contains a small bug fix (*) that should fix a worker test 27835 in Chromium. There is no other functional change. 27836 27837 (*) http://code.google.com/p/pywebsocket/source/detail?r=265 27838 27839 * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version to 0.5.1. 27840 278412010-07-15 Brady Eidson <beidson@apple.com> 27842 27843 Reviewed by Sam Weinig. 27844 27845 Add toolbar and toolbar item validation for MiniBrowser 27846 https://bugs.webkit.org/show_bug.cgi?id=42422 27847 27848 * MiniBrowser/MBToolbarItem.h: Added. 27849 * MiniBrowser/MBToolbarItem.m: Added. 27850 (-[MBToolbarItem validate]): 27851 27852 * MiniBrowser/mac/BrowserWindowController.m: 27853 (-[BrowserWindowController validateUserInterfaceItem:]): 27854 27855 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: 27856 * MiniBrowser/mac/BrowserWindow.xib: 27857 278582010-07-15 Victor Wang <victorw@chromium.org> 27859 27860 Unreviewed, add victorw irc nickname to committer list. 27861 27862 * Scripts/webkitpy/common/config/committers.py: 27863 278642010-07-15 Adam Roben <aroben@apple.com> 27865 27866 Make killing Apache more reliable (on both Mac and Windows) 27867 27868 We previously had two ways of determining whether we had succeeded in 27869 killing Apache: 27870 1) checking the return value of kill(0, $apachePID) 27871 2) checking whether Apache's PID file still exists 27872 27873 On Cygwin, Apache doesn't always delete its PID file when it exits, 27874 making (2) unreliable. We unfortunately misdiagnosed this as an 27875 impotency of Perl's kill function, which led to r63177 and r63355. 27876 27877 Now that we know that the real problem is that Apache doesn't always 27878 delete its PID file on Windows, we can make a much better fix: always 27879 use method (1) to determine whether we've killed Apache. 27880 27881 Fixes <http://webkit.org/b/42415> Killing Apache is unreliable, 27882 leading to regression test failures (and general annoyance). 27883 27884 Reviewed by Anders Carlsson. 27885 27886 * Scripts/webkitperl/httpd.pm: 27887 (openHTTPD): Moved killing code from here to killHTTPD. Added a call 27888 to delete the PID file in case Apache doesn't do this itself when 27889 killed. Our later logic relies on the PID file being deleted after 27890 this point. 27891 (closeHTTPD): Removed killing logic and changed to just call killHTTPD 27892 instead. killHTTPD's logic is a bit different from the logic we had 27893 here, for the reasons stated above. 27894 (killHTTPD): Added. Code came from openHTTPD. 27895 (handleInterrupt): Bonus fix for Mac: don't hang when pressing Ctrl-C! 27896 On Mac, don't try to kill Apache when we receive a signal, as Apache 27897 will already have been killed by this point (though for some reason 27898 this isn't detected by our killing logic in killHTTPD). On Cygwin, we 27899 still need to kill Apache manually. 27900 279012010-07-15 Sam Weinig <sam@webkit.org> 27902 27903 Reviewed by Anders Carlsson. 27904 27905 Patch for https://bugs.webkit.org/show_bug.cgi?id=42399 27906 Update MiniBrowser for WKFrameNavigationType 27907 27908 * MiniBrowser/mac/BrowserWindowController.m: 27909 (_decidePolicyForNavigationAction): 27910 (_decidePolicyForNewWindowAction): 27911 279122010-07-15 Stephanie Lewis <slewis@apple.com> 27913 27914 Reviewed by Geoff Garen. 27915 27916 http://bugs.webkit.org/show_bug.cgi?id=42406 27917 Make SunSpider work better with roots. 27918 27919 * Scripts/sunspider-compare-results: fix argument bug 27920 * Scripts/webkitdirs.pm: look inside JavaScriptCore if jsc isn't top-level. 27921 279222010-07-15 Brady Eidson <beidson@apple.com> 27923 27924 Reviewed by Sam Weinig. 27925 27926 Hook up back/forward in MiniBrowser 27927 https://bugs.webkit.org/show_bug.cgi?id=42397 27928 27929 * MiniBrowser/mac/BrowserWindow.xib: 27930 * MiniBrowser/mac/BrowserWindowController.h: 27931 * MiniBrowser/mac/BrowserWindowController.m: 27932 (-[BrowserWindowController goBack:]): 27933 (-[BrowserWindowController goForward:]): 27934 279352010-07-15 Daniel Bates <dbates@rim.com> 27936 27937 Reviewed by Darin Adler. 27938 27939 [Mac] Implement LayoutTestController::markerTextForListItem() 27940 https://bugs.webkit.org/show_bug.cgi?id=37929 27941 27942 Implements DRT support for markerTextForListItem in the Mac port. 27943 27944 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 27945 (LayoutTestController::markerTextForListItem): Implemented. 27946 279472010-07-15 Adam Barth <abarth@webkit.org> 27948 27949 Unreviewed. 27950 27951 Update the port names to be more specific. Before this patch, 27952 port-specific results for Mac would end up in the wrong place. 27953 27954 * Scripts/webkitpy/tool/commands/rebaseline.py: 27955 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: 27956 279572010-07-14 Eric Seidel <eric@webkit.org> 27958 27959 Reviewed by Adam Barth. 27960 27961 WebKit needs a rebaselining tool (finally) 27962 https://bugs.webkit.org/show_bug.cgi?id=42339 27963 27964 This is a very basic rebaselining tool. It's not 27965 quite as fancy as chromium's as it will only handle 27966 updating failing results. It cannot yet handle adding new 27967 results, or updating results where the results should not 27968 replace existing results. 27969 27970 * Scripts/webkitpy/layout_tests/port/base.py: 27971 * Scripts/webkitpy/tool/commands/__init__.py: 27972 * Scripts/webkitpy/tool/commands/queries.py: 27973 * Scripts/webkitpy/tool/commands/rebaseline.py: Added. 27974 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added. 27975 279762010-07-14 Sheriff Bot <webkit.review.bot@gmail.com> 27977 27978 Unreviewed, rolling out r63352. 27979 http://trac.webkit.org/changeset/63352 27980 https://bugs.webkit.org/show_bug.cgi?id=42341 27981 27982 Broke plugin-initiate-popup-window.html and plugin-javascript- 27983 access.html on snow leopard (Requested by abarth on #webkit). 27984 27985 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 27986 (pluginAllocate): 27987 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: 27988 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 27989 (NPP_New): 27990 (handleEventCarbon): 27991 (handleEventCocoa): 27992 279932010-07-14 Maciej Stachowiak <mjs@apple.com> 27994 27995 Reviewed by Mark Rowe. 27996 27997 Lower WebKitTestRunner notifyDone timeout to 6.0 for now, to make it easier to grind through the failures. 27998 27999 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 28000 280012010-07-14 Sheriff Bot <webkit.review.bot@gmail.com> 28002 28003 Unreviewed, rolling out r63346. 28004 http://trac.webkit.org/changeset/63346 28005 https://bugs.webkit.org/show_bug.cgi?id=42295 28006 28007 Broke lots of tests, some of which probably just need new 28008 results (Requested by aroben on #webkit). 28009 28010 * DumpRenderTree/win/DumpRenderTree.cpp: 28011 (urlSuitableForTestResult): 28012 280132010-07-14 Adam Roben <aroben@apple.com> 28014 28015 Speed up killing of Apache on Windows 28016 28017 Fixes <http://webkit.org/b/42289> Killing Apache (and thus quitting 28018 run-webkit-tests) takes a long time on Windows 28019 28020 Reviewed by Darin Adler and Jon Honeycutt. 28021 28022 * Scripts/webkitperl/httpd.pm: 28023 (closeHTTPD): Use taskkill to kill Apache and its child processes. 28024 Perl's kill seems ineffectual. We were already using taskkill, but 28025 only after trying kill 20 times. Since kill never works, let's just 28026 skip it entirely. 28027 280282010-07-14 Johnny Ding <jnd@chromium.org> 28029 28030 Reviewed by Adam Barth. 28031 28032 https://bugs.webkit.org/show_bug.cgi?id=41292 28033 Add a new parameter to the test plugin to allow to specify a script and a 28034 mouse/keyboard event. The specified script will be evaluated in the browser 28035 when the specified event is received by the plugin. 28036 28037 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 28038 (pluginAllocate): 28039 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: 28040 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 28041 (NPP_New): 28042 (handleEventCarbon): 28043 (handleEventCocoa): 28044 280452010-07-14 Adam Roben <aroben@apple.com> 28046 28047 Make urlSuitableForTestResult work for http: URLs, too 28048 28049 Fixes <http://webkit.org/b/42276> 28050 http/tests/loading/preload-slow-loading.php and 28051 http/tests/mime/uppercase-mime-type.html fail on Windows. 28052 28053 Reviewed by Darin Adler. 28054 28055 * DumpRenderTree/win/DumpRenderTree.cpp: 28056 (urlSuitableForTestResult): Don't bail if the URL starts with http://. 28057 We want this function to work for those URLs, too! 28058 280592010-07-13 Maciej Stachowiak <mjs@apple.com> 28060 28061 Reviewed by Oliver Hunt. 28062 28063 Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests 28064 https://bugs.webkit.org/show_bug.cgi?id=42227 28065 28066 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 28067 (WTR::LayoutTestController::LayoutTestController): Initialize new bool 28068 members. 28069 (WTR::LayoutTestController::display): Dummy method. 28070 (WTR::displayCallback): Call the dummy. 28071 (WTR::repaintSweepHorizontallyCallback): ditto 28072 (WTR::testRepaintCallback): ditto 28073 (WTR::LayoutTestController::staticFunctions): Expose new methods. 28074 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 28075 (WTR::LayoutTestController::setTestRepaint): Set the flag (which currently does 28076 nothing). 28077 (WTR::LayoutTestController::setTestRepaintSweepHorizontally): ditto 28078 280792010-07-13 Andreas Kling <andreas.kling@nokia.com> 28080 28081 Unreviewed. Adding myself as committer. 28082 28083 * Scripts/webkitpy/common/config/committers.py: 28084 280852010-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 28086 28087 Reviewed by Darin Adler. 28088 28089 Prevent assertion/duplicate loads for non-deferred subtitute-data loads 28090 28091 https://bugs.webkit.org/show_bug.cgi?id=30879 28092 28093 MainResourceLoader uses the member m_initialRequest to store requests for future 28094 deferred loads. When doing the actual load in handleDataLoadNow(), we therefore 28095 have to clear this request so that subsequent entries into the loader will not 28096 start yet another load. 28097 28098 This can happen as a result of a PageGroupLoadDeferrer going out of scope when 28099 returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false), 28100 but only in the case of using both substitute-data and non-deferred main resource 28101 load together. That's why two new DRT functions were added: 28102 28103 * queueLoadHTMLString() 28104 * setDeferMainResourceLoad() 28105 28106 The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac 28107 and Win the hook uses new SPI in WebDataSource. For Qt a new static member was 28108 added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt. 28109 28110 * DumpRenderTree/LayoutTestController.cpp: 28111 (LayoutTestController::LayoutTestController): 28112 (queueLoadHTMLStringCallback): 28113 (setDeferMainResourceDataLoadCallback): 28114 (LayoutTestController::staticFunctions): 28115 (LayoutTestController::queueLoadHTMLString): 28116 * DumpRenderTree/LayoutTestController.h: 28117 (LayoutTestController::deferMainResourceDataLoad): 28118 (LayoutTestController::setDeferMainResourceDataLoad): 28119 * DumpRenderTree/WorkQueueItem.h: 28120 (LoadHTMLStringItem::LoadHTMLStringItem): 28121 * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: 28122 (LoadHTMLStringItem::invoke): 28123 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 28124 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): 28125 * DumpRenderTree/mac/WorkQueueItemMac.mm: 28126 (LoadHTMLStringItem::invoke): 28127 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 28128 (LayoutTestController::reset): 28129 (LayoutTestController::setDeferMainResourceDataLoad): 28130 (LayoutTestController::queueLoadHTMLString): 28131 * DumpRenderTree/qt/LayoutTestControllerQt.h: 28132 * DumpRenderTree/qt/WorkQueueItemQt.cpp: 28133 (LoadHTMLStringItem::invoke): 28134 * DumpRenderTree/qt/WorkQueueItemQt.h: 28135 (LoadHTMLStringItem::LoadHTMLStringItem): 28136 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 28137 (ResourceLoadDelegate::willSendRequest): 28138 * DumpRenderTree/win/WorkQueueItemWin.cpp: 28139 (LoadHTMLStringItem::invoke): 28140 * DumpRenderTree/wx/WorkQueueItemWx.cpp: 28141 (LoadHTMLStringItem::invoke): 28142 281432010-07-13 Maciej Stachowiak <mjs@apple.com> 28144 28145 Reviewed by Nikolas Zimmermann. 28146 28147 Activate test fonts for layout tests in WebKitTestRunner (on Mac) 28148 https://bugs.webkit.org/show_bug.cgi?id=42153 28149 28150 * WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added. 28151 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 28152 (WTR::InjectedBundle::initialize): Activate fonts on startup. 28153 * WebKitTestRunner/InjectedBundle/mac: Added. 28154 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added. 28155 (WTR::activateFonts): Activate our fonts. 28156 * WebKitTestRunner/InjectedBundle/win: Added. 28157 * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added. 28158 (WTR::activateFonts): Dummy version. 28159 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle; 28160 add more files. 28161 * WebKitTestRunner/fonts: Added. 28162 * WebKitTestRunner/fonts/AHEM____.TTF: Added. 28163 * WebKitTestRunner/fonts/ColorBits-A.png: Added. 28164 * WebKitTestRunner/fonts/ColorBits.ttf: Added. 28165 * WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added. 28166 * WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added. 28167 * WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added. 28168 * WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added. 28169 * WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added. 28170 * WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added. 28171 * WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added. 28172 * WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added. 28173 * WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added. 28174 * WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added. 28175 * WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added. 28176 281772010-07-13 Dumitru Daniliuc <dumi@chromium.org> 28178 28179 Reviewed by Eric Seidel. 28180 28181 Remove check-header-includes, as it didn't turn out to be very useful. 28182 https://bugs.webkit.org/show_bug.cgi?id=41970 28183 28184 * Scripts/check-header-includes: Removed. 28185 281862010-07-12 Steve Falkenburg <sfalken@apple.com> 28187 28188 Reviewed by Maciej Stachowiak. 28189 28190 Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots) 28191 https://bugs.webkit.org/show_bug.cgi?id=40922 28192 28193 Always build WebKit2 on Windows. Necessary since our WebKit build on 28194 Windows is packaged into a DLL with WebKit2. 28195 28196 * Scripts/build-webkit: Always build WebKit2 on Windows. 28197 281982010-07-12 Brian Weinstein <bweinstein@apple.com> 28199 28200 Reviewed by Steve Falkenburg. 28201 28202 One http test timing out on Windows can cause all future tests to time out 28203 https://bugs.webkit.org/show_bug.cgi?id=42146 28204 28205 There have been multiple times on the Windows bots where one http test timing out causes all future 28206 http tests to time out. This is because the httpd process becomes unresponsive. When an http test 28207 times out, we should restart httpd on Cygwin to prevent this. 28208 28209 * Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it. 28210 * Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if 28211 using kill fails. 28212 282132010-07-12 Maciej Stachowiak <mjs@apple.com> 28214 28215 Reviewed by Dan Bernstein. 28216 28217 Remove use of auto_ptr in WebKitTestRunner 28218 https://bugs.webkit.org/show_bug.cgi?id=42134 28219 28220 Replaced auto_ptr with PassOwnPtr / OwnPtr. 28221 28222 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 28223 (WTR::WKStringToUTF8): 28224 (WTR::InjectedBundlePage::dump): 28225 (WTR::InjectedBundlePage::addMessageToConsole): 28226 * WebKitTestRunner/TestInvocation.cpp: 28227 (WTR::WKStringToUTF8): 28228 (WTR::TestInvocation::didRecieveMessageFromInjectedBundle): 28229 282302010-07-12 Maciej Stachowiak <mjs@apple.com> 28231 28232 Reviewed by Sam Weinig. 28233 28234 Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it) 28235 https://bugs.webkit.org/show_bug.cgi?id=42132 28236 28237 * Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of 28238 platform directories. 28239 282402010-07-12 Maciej Stachowiak <mjs@apple.com> 28241 28242 Reviewed by Anders Carlsson. 28243 28244 Make WebKitTestRunner resize the view specially for the W3C SVG tests. 28245 https://bugs.webkit.org/show_bug.cgi?id=42126 28246 28247 * WebKitTestRunner/PlatformWebView.h: 28248 * WebKitTestRunner/TestInvocation.cpp: 28249 (WTR::TestInvocation::TestInvocation): Store the path as a C 28250 string for later use. 28251 (WTR::TestInvocation::~TestInvocation): 28252 (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper 28253 size, depending on whether this is a W3C SVG test. 28254 (WTR::TestInvocation::invoke): Call the size function. 28255 * WebKitTestRunner/TestInvocation.h: 28256 * WebKitTestRunner/mac/PlatformWebViewMac.mm: 28257 (WTR::PlatformWebView::resizeTo): Implement. 28258 * WebKitTestRunner/win/PlatformWebViewWin.cpp: 28259 (WTR::PlatformWebView::resizeTo): Placeholder. 28260 282612010-07-12 Mario Sanchez Prada <msanchez@igalia.com> 28262 28263 Reviewed by Xan Lopez. 28264 28265 Ensure DRT loads GAIL (Gtk+ module), for a11y tests 28266 https://bugs.webkit.org/show_bug.cgi?id=38648 28267 28268 Add the GTK_MODULES envvar (set to "gail") to the clean 28269 environment when running DRT for the Gtk+ port 28270 28271 * Scripts/old-run-webkit-tests: 28272 282732010-07-12 Martin Robinson <mrobinson@igalia.com> 28274 28275 Reviewed by Dirk Schulze. 28276 28277 [GTK] Support pixel tests 28278 https://bugs.webkit.org/show_bug.cgi?id=31518 28279 28280 Finish support for pixel tests on GTK+. 28281 28282 * DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only 28283 works on CoreFoundation systems) and add missing cstdio include. 28284 * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found 28285 in JSC library. MD5.cpp and MD5.h are only available for the Windows build. 28286 (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride 28287 of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate 28288 the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported 28289 by the ANSI standard and this fails on Linux, so unroll the loop here. 28290 * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior. 28291 (BitmapContext::BitmapContext): There is no reason to check the value of the 28292 m_context member in the constructor and it certainly should not be freed. Instead 28293 just initialize it with the incoming value. 28294 * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes. 28295 (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to 28296 dump pixels. 28297 * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added. 28298 (createBitmapContextFromWebView): 28299 * GNUmakefile.am: Add new files to the build. 28300 283012010-07-12 Adam Barth <abarth@webkit.org> 28302 28303 Unreviewed. 28304 28305 Remove stray "raise e" that got included in a previous patch. This 28306 caused the EWS bots to turn red instead of purple when a patch failed 28307 to apply. 28308 28309 * Scripts/webkitpy/tool/commands/stepsequence.py: 28310 283112010-07-12 Sheriff Bot <webkit.review.bot@gmail.com> 28312 28313 Unreviewed, rolling out r63101. 28314 http://trac.webkit.org/changeset/63101 28315 https://bugs.webkit.org/show_bug.cgi?id=42103 28316 28317 Broke one API test (Requested by xan_ on #webkit). 28318 28319 * Scripts/old-run-webkit-tests: 28320 283212010-07-12 Alexey Proskuryakov <ap@apple.com> 28322 28323 Reviewed by Adam Roben. 28324 28325 https://bugs.webkit.org/show_bug.cgi?id=13075 28326 XMLHttpRequest with failed authentication should set status to 401 28327 28328 https://bugs.webkit.org/show_bug.cgi?id=6871 28329 <rdar://problem/3363403> 401 error page is never shown 28330 28331 Fix crashes in Windows DumpRenderTree. 28332 28333 * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge): 28334 If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge() 28335 again on a destroyed sender. 28336 283372010-07-12 Adam Roben <aroben@apple.com> 28338 28339 Windows failure-to-launch fix 28340 28341 * DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and 28342 CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like 28343 we already do for CoreFoundation, CFNetwork, etc. 28344 283452010-07-12 Mario Sanchez Prada <msanchez@igalia.com> 28346 28347 Reviewed by Xan Lopez. 28348 28349 Ensure DRT loads GAIL (Gtk+ module), for a11y tests 28350 https://bugs.webkit.org/show_bug.cgi?id=38648 28351 28352 Add the GTK_MODULES envvar (set to "gail") to the clean 28353 environment when running DRT for the Gtk+ port 28354 28355 * Scripts/old-run-webkit-tests: 28356 283572010-07-09 Alexey Proskuryakov <ap@apple.com> 28358 28359 Reviewed by Darin Adler. 28360 28361 https://bugs.webkit.org/show_bug.cgi?id=13075 28362 XMLHttpRequest with failed authentication should set status to 401 28363 28364 https://bugs.webkit.org/show_bug.cgi?id=6871 28365 <rdar://problem/3363403> 401 error page is never shown 28366 28367 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 28368 (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): 28369 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 28370 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): 28371 Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed 28372 the Cancel button. 28373 283742010-07-12 Andreas Kling <andreas.kling@nokia.com> 28375 28376 Reviewed by Tor Arne Vestbø. 28377 28378 [Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser 28379 https://bugs.webkit.org/show_bug.cgi?id=42082 28380 28381 * QtTestBrowser/main.cpp: 28382 (LauncherWindow::createChrome): 28383 * QtTestBrowser/mainwindow.cpp: 28384 (MainWindow::openLocation): 28385 * QtTestBrowser/mainwindow.h: 28386 283872010-07-12 Adam Roben <aroben@apple.com> 28388 28389 Make the Python autoinstaller not use a dead SourceForge server 28390 28391 Fixes <http://webkit.org/b/42080> webkit-patch is broken due to 28392 offline SourceForge server 28393 28394 Reviewed by Anders Carlsson. 28395 28396 * Scripts/webkitpy/thirdparty/__init__.py: Use 28397 surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net, 28398 which seems to be down. 28399 284002010-07-12 Adam Roben <aroben@apple.com> 28401 28402 Make run-webkit-tests print how many tests timed out when exiting 28403 early 28404 28405 The number of timed-out tests is taken into account when deciding 28406 whether to exit early. Leaving it out of the output just makes the 28407 script look buggy (because it might say something like "Exiting early 28408 after 0 crashes."). 28409 28410 Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing 28411 messages when exiting early due to crashes and time-outs 28412 28413 Reviewed by Anders Carlsson. 28414 28415 * Scripts/old-run-webkit-tests: 28416 (stopRunningTestsEarlyIfNeeded): When stopping, print the number of 28417 timed-out tests, too. 28418 284192010-07-11 Maciej Stachowiak <mjs@apple.com> 28420 28421 Reviewed by Dan Bernstein. 28422 28423 Implement animation-related methods for WebKitTestRunner 28424 https://bugs.webkit.org/show_bug.cgi?id=42053 28425 28426 Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many 28427 animation tests were hanging otherwise. 28428 28429 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 28430 (WTR::LayoutTestController::numberOfActiveAnimations): 28431 (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): 28432 (WTR::numberOfActiveAnimationsCallback): 28433 (WTR::pauseAnimationAtTimeOnElementWithIdCallback): 28434 (WTR::LayoutTestController::staticFunctions): 28435 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 28436 284372010-07-11 Daniel Bates <dbates@rim.com> 28438 28439 Reviewed by David Kilzer. 28440 28441 Enable executable support for svn-apply and svn-unapply 28442 https://bugs.webkit.org/show_bug.cgi?id=39409 28443 28444 Connect up the Git and SVN executable bit support in parseDiff() so that 28445 executable bit changes are propagated via the returned diff hash to the 28446 patch function in svn-apply and svn-unapply. 28447 28448 * Scripts/VCSUtils.pm: 28449 - Modified parseDiff() to call parseSvnDiffProperties when 28450 it finds the start of an SVN property change diff. 28451 - Removed FIXME comment above parseSvnDiffProperties() since 28452 it is now being used by parseDiff(). 28453 - Export method scmToggleExecutableBit() now that we added the 28454 executableBitDelta hash key. (This should have been exported 28455 when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>). 28456 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: 28457 - Updated results for: 28458 "rename (with executable bit change)" 28459 - Test value of executableBitDelta (now that we have support). 28460 "SVN: binary file (isBinary true)" 28461 - Remove the property change diff from svnConvertedText. We plan 28462 to remove svnConvertedText in the future. So, we decided 28463 against adding such support to any new code, such as the 28464 property parsing routines. Therefore, we do not keep SVN 28465 converted text for property change diffs. 28466 - Added unit tests: 28467 "SVN: file change diff with property change diff" 28468 "SVN: file change diff, followed by property change diff on different file" 28469 "SVN: property diff, followed by file change diff" 28470 "SVN: copied file with property change" 28471 "SVN: two consecutive property diffs" 28472 "SVN: binary file with executable bit change" 28473 "SVN: binary file followed by property change on different file" 28474 "SVN: binary file followed by file change on different file" 28475 "SVN: file change diff with property change, followed by property change diff" 28476 "SVN: file change diff with property change, followed by file change diff" 28477 284782010-07-11 Maciej Stachowiak <mjs@apple.com> 28479 28480 Reviewed by Dan Bernstein. 28481 28482 Implement waitUntilDone and notifyDone for WebKitTestRunner 28483 https://bugs.webkit.org/show_bug.cgi?id=42049 28484 28485 With this fix, most of the DOM tests pass. 28486 28487 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 28488 (WTR::InjectedBundle::didCreatePage): Track the main page. Not 28489 a great way to do it in the future case where we may get multiple 28490 pages - we really need a way to send it over from the ui process. 28491 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 28492 (WTR::InjectedBundle::page): A way to get the main page. 28493 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 28494 (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false. 28495 (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we 28496 are loading. 28497 (WTR::InjectedBundlePage::dump): Factor into a method so this can be 28498 called by the layout test controller. Also, cancel any pending watchdogs. 28499 (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading. 28500 (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto. 28501 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 28502 (WTR::InjectedBundlePage::isLoading): A way to track if we are loading. 28503 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 28504 (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump 28505 to false. 28506 (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 28507 the watchdog. 28508 (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer. 28509 (WTR::LayoutTestController::setWaitToDump): Set the flag. 28510 (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case 28511 where waitUntilDone times out. 28512 (WTR::LayoutTestController::notifyDone): Dump, if loading is done. 28513 (WTR::waitUntilDoneCallback): JS glue for waitUntilDone. 28514 (WTR::notifyDoneCallback): JS glue for notifyDone. 28515 (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone 28516 to the layoutController. 28517 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 28518 (WTR::LayoutTestController::waitToDump): Inline method to get the wait state. 28519 285202010-07-09 Brian Weinstein <bweinstein@apple.com> 28521 28522 Rubber-stamped by Dan Bernstein. 28523 28524 Windows testers running Windows 7 were hanging during test_kill_process. Changing the 28525 number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to 28526 slow down the tests). 28527 28528 * Scripts/webkitpy/common/system/executive.py: 28529 285302010-07-09 Luiz Agostini <luiz.agostini@openbossa.org> 28531 28532 Reviewed by Kenneth Rohde Christiansen. 28533 28534 [Qt] Mac build fix 28535 https://bugs.webkit.org/show_bug.cgi?id=41967 28536 28537 Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore. 28538 28539 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 28540 285412010-07-09 Diego Gonzalez <diegohcg@webkit.org> 28542 28543 Reviewed by Antonio Gomes. 28544 28545 [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar 28546 https://bugs.webkit.org/show_bug.cgi?id=41966 28547 28548 * MiniBrowser/qt/BrowserWindow.cpp: 28549 (BrowserWindow::BrowserWindow): 28550 285512010-07-09 Leon Clarke <leonclarke@google.com> 28552 28553 Reviewed by Adam Barth. 28554 28555 add support for link prefetching 28556 https://bugs.webkit.org/show_bug.cgi?id=3652 28557 28558 * Scripts/build-webkit: 28559 285602010-07-09 Ojan Vafai <ojan@chromium.org> 28561 28562 Reviewed by Adam Barth. 28563 28564 r63004 broke some python tests 28565 https://bugs.webkit.org/show_bug.cgi?id=42007 28566 28567 AbstractStep now checks options.no_squash and options.squash, so 28568 they needed to have real values. Mock would return an object for those, 28569 which would then act as if the values were True. 28570 28571 * Scripts/webkitpy/tool/commands/commandtest.py: 28572 * Scripts/webkitpy/tool/commands/download_unittest.py: 28573 * Scripts/webkitpy/tool/commands/stepsequence.py: 28574 * Scripts/webkitpy/tool/commands/upload_unittest.py: 28575 * Scripts/webkitpy/tool/mocktool.py: 28576 * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py: 28577 * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: 28578 * Scripts/webkitpy/tool/steps/steps_unittest.py: 28579 * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: 28580 * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: 28581 285822010-07-09 Ojan Vafai <ojan@chromium.org> 28583 28584 Reviewed by Adam Barth. 28585 28586 --squash should go away and become the default 28587 https://bugs.webkit.org/show_bug.cgi?id=39624 28588 28589 If there are local commits and working copy changes, then prompt the user 28590 whether to continue. Setting git config webkit-patch.commit_should_always_squash 28591 true bypasses the prompt. 28592 28593 --git-commit=HEAD.. operates on working copy changes only. 28594 --git-commit=committish operates on a range of commits as a single commit. 28595 e.g. --git-commit=HEAD only operates on the HEAD commit. 28596 --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit. 28597 28598 --no-squash and --squash are left in with descriptive error messages if used. 28599 28600 * Scripts/check-webkit-style: 28601 * Scripts/webkitpy/common/checkout/api.py: 28602 * Scripts/webkitpy/common/checkout/api_unittest.py: 28603 * Scripts/webkitpy/common/checkout/scm.py: 28604 * Scripts/webkitpy/common/checkout/scm_unittest.py: 28605 * Scripts/webkitpy/common/net/rietveld.py: 28606 * Scripts/webkitpy/common/system/user.py: 28607 * Scripts/webkitpy/style/optparser.py: 28608 * Scripts/webkitpy/style_references.py: 28609 * Scripts/webkitpy/tool/commands/download.py: 28610 * Scripts/webkitpy/tool/commands/upload.py: 28611 * Scripts/webkitpy/tool/mocktool.py: 28612 * Scripts/webkitpy/tool/steps/abstractstep.py: 28613 * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py: 28614 * Scripts/webkitpy/tool/steps/checkstyle.py: 28615 * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed. 28616 * Scripts/webkitpy/tool/steps/commit.py: 28617 * Scripts/webkitpy/tool/steps/options.py: 28618 * Scripts/webkitpy/tool/steps/preparechangelog.py: 28619 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: 28620 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: 28621 * Scripts/webkitpy/tool/steps/validatereviewer.py: 28622 286232010-07-09 Mark Rowe <mrowe@apple.com> 28624 28625 Add two new Windows test build slaves. 28626 28627 * BuildSlaveSupport/build.webkit.org-config/config.json: 28628 286292010-07-09 Albert J. Wong <ajwong@chromium.org> 28630 28631 Reviewed by David Levin. 28632 28633 rebaseline_chromium_webkit_tests missing --use_drt option on linux 28634 https://bugs.webkit.org/show_bug.cgi?id=41985 28635 28636 This adds in the --use_drt option for rebaseline_chromium_webkit_tests 28637 so that it works on linux. This is essentially a "compile-fix" for the 28638 script. 28639 28640 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 28641 286422010-07-09 Nico Weber <thakis@chromium.org> 28643 28644 Unreviewed. Adding myself as committer. 28645 28646 * Scripts/webkitpy/common/config/committers.py: 28647 286482010-07-09 David Kilzer <ddkilzer@apple.com> 28649 28650 Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git" 28651 28652 This reverts commit r62692. 28653 28654 * Scripts/commit-log-editor: 28655 286562010-07-08 Kinuko Yasuda <kinuko@chromium.org> 28657 28658 Reviewed by Ojan Vafai. 28659 28660 cleanup json_results_generator dependencies so that non-layout-tests can also use it safely 28661 https://bugs.webkit.org/show_bug.cgi?id=38693 28662 28663 Introduced a new base class JSONResultsGeneratorBase that doesn't 28664 have any dependency on layout_tests packages. 28665 Turned JSONResultsGenerator into a wrapper class of the base class 28666 so that the old code can work with it during the cleanup. 28667 28668 Added json_results_generator_unittest.py. 28669 28670 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 28671 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 28672 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added 28673 286742010-07-09 Abhishek Arya <inferno@chromium.org> 28675 28676 Unreviewed. 28677 28678 Marking myself as a committer. 28679 28680 * Scripts/webkitpy/common/config/committers.py: 28681 286822010-07-09 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org> 28683 28684 Reviewed by Antti Koivisto. 28685 28686 Implement MiniBrowser for Qt. 28687 https://bugs.webkit.org/show_bug.cgi?id=40233 28688 28689 * MiniBrowser/qt/BrowserWindow.cpp: Added. 28690 (createNewPage): 28691 (BrowserView::BrowserView): 28692 (BrowserView::resizeEvent): 28693 (BrowserView::load): 28694 (BrowserView::view): 28695 (BrowserWindow::BrowserWindow): 28696 (BrowserWindow::load): 28697 (BrowserWindow::changeLocation): 28698 (BrowserWindow::~BrowserWindow): 28699 * MiniBrowser/qt/BrowserWindow.h: Added. 28700 (BrowserView::~BrowserView): 28701 * MiniBrowser/qt/MiniBrowser.pro: Added. 28702 * MiniBrowser/qt/main.cpp: Added. 28703 (main): 28704 287052010-07-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> 28706 28707 Reviewed by Simon Hausmann. 28708 28709 Introduce the Qt autotest launcher. 28710 28711 Qt autotests should be executed more frequently, ideally by the Qt 28712 build bot. This is the first step to provide the tests more accessible. 28713 28714 [Qt] It should be easier to run all Qt's autotests. 28715 https://bugs.webkit.org/show_bug.cgi?id=31625 28716 28717 * Scripts/run-qtwebkit-tests: Added. 28718 287192010-07-09 Adam Barth <abarth@webkit.org> 28720 28721 Reviewed by Eric Seidel. 28722 28723 commit-queue should merge to TOT when checkout needs update 28724 https://bugs.webkit.org/show_bug.cgi?id=41944 28725 28726 There are a bunch of different designs that are possible here. This 28727 one merges to top of tree by cleaning out the working copy and 28728 re-applying the patch. Once you decide to merge that way, you need to 28729 decide who's going to retry. In this patch, we retry in the child 28730 process instead of plumbing the failure reason to the master process. 28731 28732 This patch is difficult to test end-to-end, but hopefully it will work. 28733 :) 28734 28735 * Scripts/webkitpy/tool/commands/queues.py: 28736 * Scripts/webkitpy/tool/commands/stepsequence.py: 28737 * Scripts/webkitpy/tool/multicommandtool.py: 28738 * Scripts/webkitpy/tool/multicommandtool_unittest.py: 28739 287402010-07-09 Dumitru Daniliuc <dumi@chromium.org> 28741 28742 Reviewed by Darin Adler. 28743 28744 Add a script to check for unnecessary includes in header files. 28745 https://bugs.webkit.org/show_bug.cgi?id=41894 28746 28747 * Scripts/check-header-includes: Added. 28748 287492010-07-09 Adam Barth <abarth@webkit.org> 28750 28751 Reviewed by Eric Seidel. 28752 28753 Add --html5-treebuilder option to run-webkit-tests 28754 https://bugs.webkit.org/show_bug.cgi?id=41922 28755 28756 We're down to one or two regressions in the HTML5lib test suite. It's 28757 getting to be time to look at fixing LayoutTests. 28758 28759 * Scripts/old-run-webkit-tests: 28760 287612010-07-08 Simon Fraser <simon.fraser@apple.com> 28762 28763 Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting 28764 in the drawing model never getting set on Tiger. 28765 28766 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 28767 (NPP_New): 28768 287692010-07-08 Aaron Boodman <aa@chromium.org> 28770 28771 Reviewed by Timothy Hatcher. 28772 28773 Add the ability for user scripts and user styles to affect just the top frame. 28774 28775 https://bugs.webkit.org/show_bug.cgi?id=41529 28776 28777 * DumpRenderTree/LayoutTestController.h: Added new allFrames param. 28778 * DumpRenderTree/LayoutTestController.cpp: Ditto. 28779 (addUserScriptCallback): 28780 (addUserStyleSheetCallback): 28781 * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto. 28782 (LayoutTestController::addUserScript): 28783 (LayoutTestController::addUserStyleSheet): 28784 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto. 28785 (LayoutTestController::addUserScript): 28786 (LayoutTestController::addUserStyleSheet): 28787 * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto. 28788 (LayoutTestController::addUserScript): 28789 (LayoutTestController::addUserStyleSheet): 28790 * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto. 28791 (LayoutTestController::addUserScript): 28792 (LayoutTestController::addUserStyleSheet): 28793 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto. 28794 (LayoutTestController::addUserScript): 28795 (LayoutTestController::addUserStyleSheet): 28796 287972010-07-08 Adele Peterson <adele@apple.com> 28798 28799 Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler. 28800 28801 Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721 28802 <rdar://problem/8158561> Missing plug-in indicator should have a pressed state 28803 28804 Log when the missing plugin button is pressed. 28805 28806 * DumpRenderTree/mac/UIDelegate.mm: 28807 (-[UIDelegate webView:didPressMissingPluginButton:]): 28808 * DumpRenderTree/win/UIDelegate.cpp: 28809 (UIDelegate::QueryInterface): 28810 (UIDelegate::createWebViewWithRequest): 28811 (UIDelegate::drawBackground): 28812 (UIDelegate::decidePolicyForGeolocationRequest): 28813 (UIDelegate::didPressMissingPluginButton): 28814 * DumpRenderTree/win/UIDelegate.h: 28815 288162010-07-08 Simon Fraser <simon.fraser@apple.com> 28817 28818 Fix the Tiger build. 28819 28820 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 28821 (NPP_New): 28822 288232010-07-08 Simon Fraser <simon.fraser@apple.com> 28824 28825 Fix windows build. 28826 28827 #ifdef code for Mac. 28828 28829 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 28830 (NPP_New): 28831 288322010-07-08 Simon Fraser <simon.fraser@apple.com> 28833 28834 Reviewed by Anders Carlsson. 28835 28836 Allow the TestPlugin to use Core Animation rendering for testing 28837 https://bugs.webkit.org/show_bug.cgi?id=41872 28838 28839 Add the ability for the TestPlugin to use the CoreAnimation rendering model 28840 when available, based on the "drawingmodel" attribute of the embed tag: 28841 drawingmodel="coreanimation" 28842 28843 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm 28844 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect 28845 when building on Tiger. Add a void* coreAnimationLayer member. 28846 28847 * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added. 28848 (createCoreAnimationLayer): Obj-C method to create the CALayer. 28849 28850 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 28851 (NPP_New): Look for the drawingmodel attribute to decide which drawing 28852 model to use. 28853 (NPP_Destroy): Release the CALayer if we have one. 28854 (NPP_GetValue): Return the retained CALayer. 28855 288562010-07-08 Martin Robinson <mrobinson@igalia.com> 28857 28858 Reviewed by Xan Lopez. 28859 28860 [GTK] Support pixel tests 28861 https://bugs.webkit.org/show_bug.cgi?id=31518 28862 28863 Convert this file from CRLF to NL line endings. It will soon 28864 be used on more than just the WinCairo platform. 28865 28866 * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: 28867 (writeFunction): 28868 (printPNG): 28869 (computeMD5HashStringForBitmapContext): 28870 (dumpBitmap): 28871 288722010-07-08 Steve Falkenburg <sfalken@apple.com> 28873 28874 Reviewed by Darin Adler. 28875 28876 Enable Data Execution Prevention for our test harnesses on Windows 28877 https://bugs.webkit.org/show_bug.cgi?id=41882 28878 28879 * DumpRenderTree/win/DumpRenderTree.vcproj: 28880 * DumpRenderTree/win/ImageDiff.vcproj: 28881 * WebKitAPITest/WebKitAPITest.vcproj: 28882 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 28883 288842010-07-07 Robert Hogan <robert@webkit.org> 28885 28886 Reviewed by Kenneth Rohde Christiansen. 28887 28888 [Qt] Add DRT support for pageProperty etc. 28889 28890 https://bugs.webkit.org/show_bug.cgi?id=41584 28891 28892 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 28893 (LayoutTestController::isPageBoxVisible): 28894 (LayoutTestController::pageSizeAndMarginsInPixels): 28895 (LayoutTestController::pageProperty): 28896 (LayoutTestController::addUserStyleSheet): 28897 * DumpRenderTree/qt/LayoutTestControllerQt.h: 28898 288992010-07-08 Martin Robinson <mrobinson@igalia.com> 28900 28901 Reviewed by Xan Lopez. 28902 28903 Remove a warnings from the ImageDiff build by using the proper 28904 printf format string for the gsize data type. 28905 28906 * DumpRenderTree/gtk/ImageDiff.cpp: 28907 (printImage): Use the proper printf format string for the gsize data type. 28908 289092010-07-08 Alice Liu <alice.liu@apple.com> 28910 28911 Reviewed by Sam Weinig. 28912 28913 https://bugs.webkit.org/show_bug.cgi?id=41653 28914 Add new WebKitTestRunner project for Windows 28915 28916 * WebKitTestRunner/WebKitTestRunnerPrefix.h: 28917 Similar to how it's done in DumpRenderTree, define max and min early 28918 on so that they don't get replaced by a macro requiring 2 arguments. 28919 28920 * WebKitTestRunner/win: Added. 28921 * WebKitTestRunner/win/WebKitTestRunner.sln: Added. 28922 * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added. 28923 * WebKitTestRunner/win/main.cpp: Added. 28924 (main): Implemented 28925 28926 Added these files with stubbed out functions: 28927 * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added. 28928 (WTR::PlatformWebView::PlatformWebView): 28929 (WTR::PlatformWebView::~PlatformWebView): 28930 (WTR::PlatformWebView::page): 28931 * WebKitTestRunner/win/TestControllerWin.cpp: Added. 28932 (WTR::TestController::initializeInjectedBundlePath): 28933 * WebKitTestRunner/win/TestInvocationWin.cpp: Added. 28934 (WTR::TestInvocation::runUntil): 28935 289362010-07-07 Martin Robinson <mrobinson@igalia.com> 28937 28938 Reviewed by Gustavo Noronha Silva. 28939 28940 [GTK] Implement ImageDiff and add it to the build system 28941 https://bugs.webkit.org/show_bug.cgi?id=41779 28942 28943 Add the initial implementation of the ImageDiff tool for the GTK+ 28944 port. This is an essential tool for doing pixel tests. The implementation 28945 is based on the Mac and Chromium ports. 28946 28947 * DumpRenderTree/gtk/ImageDiff.cpp: Added. 28948 (readPixbufFromStdin): Added. 28949 (differenceImageFromDifferenceBuffer): Ditto. 28950 (calculateDifference): Ditto. 28951 (printImage): Ditto. 28952 (printImageDifferences): Ditto. 28953 (main): Ditto. 28954 * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts. 28955 289562010-07-08 Jay Civelli <jcivelli@chromium.org> 28957 28958 Unreviewed. Adding myself as a committer. 28959 28960 * Scripts/webkitpy/common/config/committers.py: 28961 289622010-07-08 Adam Roben <aroben@apple.com> 28963 28964 Make Windows stop running tests from platform/mac 28965 28966 r62742 made a change (at my suggestion!) that caused us to start 28967 looking for tests in platform/mac, rather than just looking for 28968 expected results in platform/mac. This patch just undoes that part of 28969 r62742. 28970 28971 Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs 28972 tests from platform/mac, but shouldn't 28973 28974 Reviewed by Antti Koivisto and Anders Carlsson. 28975 28976 * Scripts/old-run-webkit-tests: 28977 (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms, 28978 so we won't look in those directories for tests to run. 28979 (expectedDirectoryForTest): Added back code from pre-r62742 to look in 28980 platform/mac-snowleopard and platform/mac for expected results. 28981 289822010-07-08 Antonio Gomes <tonikitoo@webkit.org> 28983 28984 Unreviewed. Adding myself as a reviewer. 28985 28986 * Scripts/webkitpy/common/config/committers.py: 28987 289882010-07-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 28989 28990 Update my e-mail in committers.py 28991 28992 * Scripts/webkitpy/common/config/committers.py: 28993 289942010-07-07 Daniel Bates <dbates@rim.com> 28995 28996 Reviewed by Dumitru Daniliuc. 28997 28998 VCSUtils.pm complains about uninitialized value $newLine 28999 https://bugs.webkit.org/show_bug.cgi?id=41333 29000 29001 Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of 29002 an array when fixing a change log entry that overlaps with an earlier 29003 entry. In particular, when a patch contains a change log entry inserted 29004 earlier in the change log file, but after an entry with the same author 29005 and date. 29006 29007 * Scripts/VCSUtils.pm: 29008 - Added for-loop constraint to fixChangeLogPatch() so that it does not 29009 read off the end of the @overlappingLines array. 29010 * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test. 29011 290122010-07-07 Anders Carlsson <andersca@apple.com> 29013 29014 Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard. 29015 29016 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 29017 (NPP_New): 29018 290192010-07-07 Kent Tamura <tkent@chromium.org> 29020 29021 Reviewed by Adam Barth. 29022 29023 [DRT/Chromium] Support for indeterminate checkbox 29024 https://bugs.webkit.org/show_bug.cgi?id=41747 29025 29026 Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499 29027 29028 * DumpRenderTree/chromium/WebThemeControlDRT.cpp: 29029 (WebThemeControlDRT::draw): 29030 * DumpRenderTree/chromium/WebThemeControlDRT.h: 29031 (WebThemeControlDRT::): 29032 * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: 29033 (WebThemeEngineDRT::paintButton): 29034 290352010-07-07 Sam Weinig <sam@webkit.org> 29036 29037 Reviewed by Mark Rowe. 29038 29039 Clean up MiniBrowser Xcode project. 29040 29041 - Use xcconfig files. 29042 - Rename plists to canonical Info.plist 29043 - Remove localizations. 29044 29045 * MiniBrowser/Configurations: Added. 29046 * MiniBrowser/Configurations/Base.xcconfig: Added. 29047 * MiniBrowser/Configurations/DebugRelease.xcconfig: Added. 29048 * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added. 29049 * MiniBrowser/Configurations/WebBundle.xcconfig: Added. 29050 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: 29051 * MiniBrowser/WebBundle-Info.plist: Removed. 29052 * MiniBrowser/mac/BrowserStatisticsWindowController.m: 29053 (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]): 29054 * MiniBrowser/mac/BrowserWindow.xib: Added. 29055 * MiniBrowser/mac/BrowserWindowController.m: 29056 (-[BrowserWindowController initWithPageNamespace:]): 29057 * MiniBrowser/mac/English.lproj: Removed. 29058 * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed. 29059 * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed. 29060 * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed. 29061 * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist. 29062 * MiniBrowser/mac/MainMenu.xib: Added. 29063 * MiniBrowser/mac/MiniBrowser-Info.plist: Removed. 29064 * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist. 29065 290662010-07-07 Kent Tamura <tkent@chromium.org> 29067 29068 Reviewed by Dimitri Glazkov. 29069 29070 [DRT/Chromium] Fix two regressions 29071 https://bugs.webkit.org/show_bug.cgi?id=41745 29072 29073 * DumpRenderTree/chromium/WebViewHost.cpp: 29074 (WebViewHost::paintInvalidatedRegion): 29075 Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg 29076 and svg/custom/use-on-g-containing-foreignObject-and-image.svg 29077 though test_shell does it twice. Probably DRT needs it because 29078 DRT delays painting as possible. 29079 290802010-07-07 Anders Carlsson <andersca@apple.com> 29081 29082 Try to fix build. 29083 29084 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 29085 (webkit_test_plugin_destroy_stream): 29086 290872010-07-07 Anders Carlsson <andersca@apple.com> 29088 29089 Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp 29090 29091 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 29092 (webkit_test_plugin_new_stream): 29093 (webkit_test_plugin_destroy_stream): 29094 (webkit_test_plugin_write_ready): 29095 (webkit_test_plugin_write): 29096 290972010-07-07 Sam Weinig <sam@webkit.org> 29098 29099 Reviewed by Mark Rowe. 29100 29101 Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 29102 29103 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: 29104 291052010-07-07 Anders Carlsson <andersca@apple.com> 29106 29107 Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms. 29108 29109 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 29110 (NPP_New): 29111 (NPP_HandleEvent): 29112 291132010-07-07 Brian Weinstein <bweinstein@apple.com> 29114 29115 Reviewed by Adam Roben. 29116 29117 Need to have a way to specify different results for Windows XP and 7 29118 https://bugs.webkit.org/show_bug.cgi?id=41776 29119 29120 Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7 29121 subdirectories, so we can have different results for tests on Windows XP, Windows 29122 Vista, and Windows 7. 29123 29124 Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac. 29125 Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac. 29126 Windows 7 will try the order: win-7, win, mac-snowleopard, mac. 29127 29128 This matches the behavior of the mac. 29129 29130 * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP 29131 or Vista, try looking in other win-* subdirectories before win. 29132 * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows 29133 we are running. 29134 291352010-07-07 Kent Tamura <tkent@chromium.org> 29136 29137 Reviewed by Dimitri Glazkov. 29138 29139 [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions 29140 https://bugs.webkit.org/show_bug.cgi?id=41753 29141 29142 The original code of the following functions in 29143 test_shell_devtools_client.cc have NOTIMPLEMENTED(), not 29144 ASSERT_NOT_REACHED(). The program shouldn't stop at these 29145 functions. 29146 29147 * DumpRenderTree/chromium/DRTDevToolsClient.cpp: 29148 (DRTDevToolsClient::activateWindow): 29149 (DRTDevToolsClient::closeWindow): 29150 (DRTDevToolsClient::dockWindow): 29151 (DRTDevToolsClient::undockWindow): 29152 291532010-07-07 Anders Carlsson <andersca@apple.com> 29154 29155 Reviewed by Sam Weinig. 29156 29157 Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function 29158 https://bugs.webkit.org/show_bug.cgi?id=41821 29159 29160 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 29161 (pluginGetProperty): 29162 (pluginSetProperty): 29163 (pluginAllocate): 29164 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: 29165 Add and initialize the returnNegativeOneFromWrite property. 29166 29167 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 29168 (NPP_NewStream): 29169 Set the stream type to NP_NORMAL so we'll get write callbacks. 29170 29171 (NPP_DestroyStream): 29172 Treat the onstreamdestroy attribute as a function name and not a string. 29173 29174 (NPP_WriteReady): 29175 Have this return a nonzero value. 29176 29177 (NPP_Write): 29178 If returnNegativeOneFromWrite is true return -1. 29179 291802010-07-07 Kevin Ollivier <kevino@theolliviers.com> 29181 29182 [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the 29183 latest version is selected by default, and allows the version to be specified. 29184 29185 * wx/build/settings.py: 29186 291872010-07-07 Chris Fleizach <cfleizach@apple.com> 29188 29189 Reviewed by Darin Adler. 29190 29191 AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area 29192 https://bugs.webkit.org/show_bug.cgi?id=41810 29193 29194 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 29195 (AccessibilityUIElement::selectedTextRange): 29196 291972010-07-07 Martin Robinson <mrobinson@igalia.com> 29198 29199 Unreviewed. 29200 29201 Build fix after r62700. 29202 29203 * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn 29204 source file locations. 29205 292062010-07-07 Ojan Vafai <ojan@chromium.org> 29207 29208 Reviewed by David Levin. 29209 29210 change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts 29211 https://bugs.webkit.org/show_bug.cgi?id=41814 29212 29213 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 29214 * Scripts/old-run-webkit-tests: 29215 292162010-07-07 Ojan Vafai <ojan@chromium.org> 29217 29218 Reviewed by David Levin. 29219 29220 add --exit-after-n-crashes to run-webkit-tests 29221 https://bugs.webkit.org/show_bug.cgi?id=41811 29222 29223 Change the bots at build.webkit.org to use --exit-after-n-crashes 29224 instead of --exit-after-n-failures since we want to be able to have 29225 more than 20 failures on those bots, but more than 20 crashes means 29226 something should be rolled out. 29227 29228 * Scripts/old-run-webkit-tests: 29229 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 29230 292312010-07-07 Brian Weinstein <bweinstein@apple.com> 29232 29233 Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the 29234 TestNetscapePlugin project, because this was removed from the tree. 29235 29236 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 29237 292382010-07-07 Anders Carlsson <andersca@apple.com> 29239 29240 Reviewed by Simon Fraser. 29241 29242 Unify Mac and Windows TestNetscapePlugin main.cpp files 29243 https://bugs.webkit.org/show_bug.cgi?id=41798 29244 29245 * DumpRenderTree/DumpRenderTree.sln: 29246 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 29247 (strcasecmp): 29248 (NP_Initialize): 29249 (NP_GetEntryPoints): 29250 (NP_Shutdown): 29251 (NPP_New): 29252 (NPP_Destroy): 29253 (NPP_HandleEvent): 29254 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 29255 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed. 29256 292572010-07-07 Kevin Ollivier <kevino@theolliviers.com> 29258 29259 [wx] Build fix. pageProperty needs to return a value. 29260 29261 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 29262 (LayoutTestController::pageProperty): 29263 292642010-07-07 David Kilzer <ddkilzer@apple.com> 29265 29266 <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git 29267 29268 Reviewed by Anders Carlsson. 29269 29270 For both svn and git, commit-log-editor is invoked from the root 29271 of the working directory. Unlike svn, git returns a list of 29272 changed files that are relative to the directory where the 29273 command was invoked. This caused the ChangeLog file in the root 29274 directory to be read instead of the ChangeLog in the current 29275 directory. 29276 29277 The fix is to use $ENV{PWD} as the base directory when fixing 29278 the path to the ChangeLog files. With svn, this has no net 29279 effect since $ENV{PWD} is the root of the working directory and 29280 the ChangeLog paths are already relative to that directory. 29281 With git, $ENV{PWD} is the directory that the commit was invoked 29282 from, which fixes the ChangeLog paths so that the correct files 29283 are read when creating the commit log entry. 29284 29285 Note that the call to makeFilePathRelative() was supposed to 29286 address this issue, but it doesn't because (a) it does nothing 29287 with svn working directories by design, and (b) it does nothing 29288 with git working directories because it's invoked when the 29289 current directory is the root of the working directory, thus 29290 giving no relative path. 29291 29292 * Scripts/commit-log-editor: Removed call to 29293 makeFilePathRelative() since since it does nothing. Moved code 29294 to fix up $changeLog path so that it's fixed before trying to 29295 open the file, and use $ENV{PWD} as the base path. Also use 29296 canonicalizePath() to clean up paths with "../" in them. 29297 292982010-07-07 Anders Carlsson <andersca@apple.com> 29299 29300 Another attempt at fixing the Qt build. 29301 29302 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 29303 293042010-07-07 Anders Carlsson <andersca@apple.com> 29305 29306 Try to fix Qt build. 29307 29308 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 29309 293102010-07-07 Anders Carlsson <andersca@apple.com> 29311 29312 Reviewed by Simon Fraser. 29313 29314 Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories 29315 https://bugs.webkit.org/show_bug.cgi?id=41781 29316 29317 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 29318 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp. 29319 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h. 29320 * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp. 29321 * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h. 29322 * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist. 29323 * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp. 29324 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def. 29325 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc. 29326 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added. 29327 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def. 29328 * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h. 29329 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed. 29330 293312010-07-07 Andras Becsi <abecsi@webkit.org> 29332 29333 Unreviewed trivial fix. 29334 29335 Remove DUMPRENDERTREE_TEMP environment variable from NRWT 29336 which was checked in accidentally in r62635. 29337 29338 * Scripts/webkitpy/layout_tests/port/webkit.py: 29339 293402010-07-07 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 29341 29342 Reviewed by Eric Seidel. 29343 29344 Pass port specific environment to server process. 29345 https://bugs.webkit.org/show_bug.cgi?id=41593 29346 29347 * Scripts/webkitpy/layout_tests/port/qt.py: 29348 * Scripts/webkitpy/layout_tests/port/webkit.py: 29349 293502010-07-06 Kent Tamura <tkent@chromium.org> 29351 29352 Reviewed by Shinichiro Hamaji. 29353 29354 Fix a wrong dup detection of rebaseline-chromium-webkit-tests 29355 https://bugs.webkit.org/show_bug.cgi?id=41644 29356 29357 rebaseline-chromium-webkit-tests used ImageDiff with 0.1% 29358 tolerance. We don't need tolerance for rebaseline. 29359 29360 * Scripts/webkitpy/layout_tests/port/base.py: 29361 Add optional tolerance parameter to diff_image(). 29362 * Scripts/webkitpy/layout_tests/port/test.py: 29363 Add optional tolerance parameter to diff_image(). 29364 * Scripts/webkitpy/layout_tests/port/webkit.py: 29365 Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command. 29366 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 29367 diff_files() always calls diff_image() with tolerance=0. 29368 diff_files() is used only by rebaseline-chromium-webkit-tests. 29369 293702010-07-06 Sam Weinig <sam@webkit.org> 29371 29372 Fix MiniBrowser build. 29373 29374 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 29375 293762010-07-06 Sam Weinig <sam@webkit.org> 29377 29378 Reviewed by Anders Carlsson. 29379 29380 Add support for dumping the contents of messages to the console to WebKitTestRunner 29381 29382 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 29383 (WTR::InjectedBundlePage::InjectedBundlePage): 29384 (WTR::InjectedBundlePage::_addMessageToConsole): 29385 (WTR::InjectedBundlePage::addMessageToConsole): 29386 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 29387 293882010-07-06 Sam Weinig <sam@webkit.org> 29389 29390 Reviewed by Anders Carlsson. 29391 29392 Patch for https://bugs.webkit.org/show_bug.cgi?id=41708 29393 Add dumpAsText support for WebKitTestRunner 29394 29395 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 29396 (WTR::InjectedBundle::InjectedBundle): 29397 (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test. 29398 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 29399 (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText 29400 API to dump the main frames text. 29401 294022010-07-06 Darin Adler <darin@apple.com> 29403 29404 Fix Chromium build. 29405 29406 * DumpRenderTree/chromium/WebViewHost.cpp: 29407 (WebViewHost::didCreateDataSource): Call leakPtr instead of release. 29408 (WebViewHost::didNavigateWithinPage): Ditto. 29409 (WebViewHost::updateURL): Ditto. 29410 294112010-07-06 Martin Robinson <mrobinson@igalia.com> 29412 29413 Reviewed by Xan Lopez. 29414 29415 [GTK] build-webkit should not run autogen.sh unconditionally 29416 https://bugs.webkit.org/show_bug.cgi?id=41704 29417 29418 * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile 29419 doesn't exist. Autotools should re-run autogen.sh when necessary. Also do 29420 some very minor cleanup. 29421 294222010-07-06 Darin Adler <darin@apple.com> 29423 29424 Try to fix Chromium build. 29425 29426 * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h. 29427 294282010-07-06 Darin Adler <darin@apple.com> 29429 29430 Fix build. 29431 29432 * WebKitAPITest/TestsController.cpp: 29433 (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release. 29434 294352010-07-06 Roland Steiner <rolandsteiner@chromium.org> 29436 29437 Reviewed by Kent Tamura. 29438 29439 Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT 29440 https://bugs.webkit.org/show_bug.cgi?id=40558 29441 29442 Upstream DevTools for Chromium DRT. 29443 (original Chromium files rev. 51287) 29444 29445 * DumpRenderTree/DumpRenderTree.gypi: 29446 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added. 29447 (DRTDevToolsAgent::DRTDevToolsAgent): 29448 (DRTDevToolsAgent::setWebView): 29449 (DRTDevToolsAgent::sendMessageToFrontend): 29450 (DRTDevToolsAgent::forceRepaint): 29451 (DRTDevToolsAgent::runtimeFeatureStateChanged): 29452 (DRTDevToolsAgent::injectedScriptSource): 29453 (DRTDevToolsAgent::injectedScriptDispatcherSource): 29454 (DRTDevToolsAgent::debuggerScriptSource): 29455 (DRTDevToolsAgent::asyncCall): 29456 (DRTDevToolsAgent::call): 29457 (DRTDevToolsAgent::webDevToolsAgent): 29458 (DRTDevToolsAgent::attach): 29459 (DRTDevToolsAgent::detach): 29460 (DRTDevToolsAgent::setTimelineProfilingEnabled): 29461 (DRTDevToolsAgent::evaluateInWebInspector): 29462 (DRTDevToolsAgent::dispatchMessageLoop): 29463 * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added. 29464 (DRTDevToolsAgent::~DRTDevToolsAgent): 29465 (DRTDevToolsAgent::hostIdentifier): 29466 * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp: 29467 * DumpRenderTree/chromium/DRTDevToolsCallArgs.h: 29468 (DRTDevToolsCallArgs::DRTDevToolsCallArgs): 29469 (DRTDevToolsCallArgs::~DRTDevToolsCallArgs): 29470 (DRTDevToolsCallArgs::callsCount): 29471 * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added. 29472 (DRTDevToolsClient::DRTDevToolsClient): 29473 (DRTDevToolsClient::~DRTDevToolsClient): 29474 (DRTDevToolsClient::sendMessageToAgent): 29475 (DRTDevToolsClient::sendDebuggerCommandToAgent): 29476 (DRTDevToolsClient::activateWindow): 29477 (DRTDevToolsClient::closeWindow): 29478 (DRTDevToolsClient::dockWindow): 29479 (DRTDevToolsClient::undockWindow): 29480 (DRTDevToolsClient::asyncCall): 29481 (DRTDevToolsClient::call): 29482 (DRTDevToolsClient::allMessagesProcessed): 29483 * DumpRenderTree/chromium/DRTDevToolsClient.h: 29484 * DumpRenderTree/chromium/EventSender.cpp: 29485 * DumpRenderTree/chromium/LayoutTestController.cpp: 29486 (LayoutTestController::LayoutTestController): 29487 (LayoutTestController::closeWebInspector): 29488 (LayoutTestController::setTimelineProfilingEnabled): 29489 (LayoutTestController::evaluateInWebInspector): 29490 * DumpRenderTree/chromium/LayoutTestController.h: 29491 * DumpRenderTree/chromium/TestShell.cpp: 29492 (TestShell::TestShell): 29493 (TestShell::~TestShell): 29494 (TestShell::createDRTDevToolsClient): 29495 (TestShell::showDevTools): 29496 (TestShell::closeDevTools): 29497 (TestShell::runFileTest): 29498 (TestShell::createNewWindow): 29499 * DumpRenderTree/chromium/TestShell.h: 29500 (TestShell::drtDevToolsAgent): 29501 (TestShell::drtDevToolsClient): 29502 * DumpRenderTree/chromium/config.h: 29503 295042010-07-06 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 29505 29506 Reviewed by Eric Seidel. 29507 29508 Don't pass image hash to DRT when pixel tests are disabled. 29509 https://bugs.webkit.org/show_bug.cgi?id=41597 29510 29511 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 29512 295132010-07-05 Csaba Osztrogonác <ossy@webkit.org> 29514 29515 Reviewed by Eric Seidel. 29516 29517 REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory 29518 https://bugs.webkit.org/show_bug.cgi?id=41612 29519 29520 * Scripts/ensure-valid-python: File::Temp::tempdir call fixed. 29521 295222010-07-05 Adam Barth <abarth@webkit.org> 29523 29524 Reviewed by Eric Seidel. 29525 29526 We should be able to specify a bug to block for webkit-patch upload 29527 https://bugs.webkit.org/show_bug.cgi?id=41648 29528 29529 This will be useful for working on the HTML5 parser. 29530 29531 * Scripts/webkitpy/tool/steps/createbug.py: 29532 * Scripts/webkitpy/tool/steps/options.py: 29533 295342010-07-05 Martin Robinson <mrobinson@igalia.com> 29535 29536 Reviewed by Oliver Hunt. 29537 29538 The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h 29539 https://bugs.webkit.org/show_bug.cgi?id=41017 29540 29541 * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h 29542 * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change. 29543 295442010-07-04 MORITA Hajime <morrita@google.com> 29545 29546 rebaseline-chromium-webkit-tests: UnicodeDecodeError 29547 https://bugs.webkit.org/show_bug.cgi?id=41589 29548 29549 * run() method can result non-utf-8 bytes, that causes utf-8 29550 decoding fail. Fixed to disable decoding. 29551 * Fixed Git.find_checkout_root() to make a test pass. 29552 29553 * Scripts/webkitpy/common/checkout/scm.py: 29554 * Scripts/webkitpy/common/checkout/scm_unittest.py: 29555 295562010-07-03 Patrick Gansterer <paroga@paroga.com> 29557 29558 Reviewed by Simon Hausmann. 29559 29560 [Qt] Fix DumpRenderTree userStyleSheet handling. 29561 https://bugs.webkit.org/show_bug.cgi?id=41570 29562 29563 DumpRenderTree did only set the userStyleSheet at 29564 layoutTestController.setUserStyleSheetEnabled(). 29565 29566 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 29567 (LayoutTestController::reset): 29568 (LayoutTestController::setUserStyleSheetLocation): 29569 (LayoutTestController::setUserStyleSheetEnabled): 29570 * DumpRenderTree/qt/LayoutTestControllerQt.h: 29571 295722010-07-03 Robert Hogan <robert@webkit.org> 29573 29574 Reviewed by Kenneth Rohde Christiansen. 29575 29576 [Qt] support dumpChildFrameScrollPositions 29577 29578 https://bugs.webkit.org/show_bug.cgi?id=41088 29579 29580 Unskip: 29581 29582 http/tests/navigation/anchor-subframeload.html 29583 http/tests/navigation/relativeanchor-frames.html 29584 29585 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 29586 (WebCore::DumpRenderTree::dumpFrameScrollPosition): 29587 (WebCore::DumpRenderTree::dump): 29588 * DumpRenderTree/qt/DumpRenderTreeQt.h: 29589 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 29590 (LayoutTestController::reset): 29591 * DumpRenderTree/qt/LayoutTestControllerQt.h: 29592 (LayoutTestController::shouldDumpChildFrameScrollPositions): 29593 (LayoutTestController::dumpChildFrameScrollPositions): 29594 295952010-07-02 Sam Weinig <sam@webkit.org> 29596 29597 Reviewed by Anders Carlsson. 29598 29599 Rename new scripts so that they don't make autocompleting run-webkit-tests annoying. 29600 29601 * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner. 29602 * Scripts/debug-webkittestrunner: Removed. 29603 * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner. 29604 * Scripts/run-webkittestrunner: Removed. 29605 296062010-07-02 Brian Weinstein <bweinstein@apple.com> 29607 29608 Reviewed by Steve Falkenburg. 29609 29610 Some http tests fail on Windows with Cygwin 1.7 29611 https://bugs.webkit.org/show_bug.cgi?id=41537 29612 29613 With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ 29614 doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we 29615 just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup. 29616 29617 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 29618 (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 29619 SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work. 29620 296212010-06-23 Martin Robinson <mrobinson@igalia.com> 29622 29623 Reviewed by Gustavo Noronha Silva. 29624 29625 [GTK] Separate DerivedSources per-project 29626 https://bugs.webkit.org/show_bug.cgi?id=41109 29627 29628 The JavaScriptCore cppflags used to include the top-level DerivedSources directory 29629 allowing the tools to build as a side-effect. Now that the top-level directory 29630 is no longer in the list of JavaScriptCore includes, include it explicitly. 29631 29632 * GNUmakefile.am: 29633 296342010-07-01 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 29635 29636 Reviewed by Kenneth Rohde Christiansen. 29637 29638 [Qt] Make context menus show up in the right place in QTestBrowser 29639 29640 Context menus were shown at scene-relative coordinates for 29641 QGraphicsWebView while QMenu expects them to be global. The 29642 change to the QWidget case was to get rid of the mapToGlobal. 29643 29644 * QtTestBrowser/webview.cpp: 29645 296462010-07-01 Robert Hogan <robert@webkit.org> 29647 29648 Reviewed by Kenneth Rohde Christiansen. 29649 29650 [Qt] dump frames in ascending alphabetical order of title 29651 29652 https://bugs.webkit.org/show_bug.cgi?id=41261 29653 29654 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 29655 (WebCore::dumpHistoryItem): 29656 296572010-07-01 Martin Robinson <mrobinson@igalia.com> 29658 29659 Unreviewed. 29660 29661 Fix the GTK+ build after r62278. 29662 29663 * Scripts/webkitdirs.pm: If the make arguments have already been specified, 29664 let them override the automatic CPU detection for autotools builds. 29665 296662010-07-01 Martin Robinson <mrobinson@igalia.com> 29667 29668 Unreviewed. 29669 29670 Fix the Windows build after r62278. 29671 29672 * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories. 29673 296742010-07-01 Martin Robinson <mrobinson@igalia.com> 29675 29676 Reviewed by Gustavo Noronha Silva. 29677 29678 [GTK] build-webkit does not detect the number of CPUs 29679 https://bugs.webkit.org/show_bug.cgi?id=41469 29680 29681 Pass the appropriate -j<#> flag to make when building autotools builds. 29682 This causes make to spawn that many number of child processes for doing 29683 parallel builds. 29684 29685 * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number 29686 of CPUs. This makes the script work across more platforms. 29687 * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the 29688 number of CPUs across several platforms. Use this new function to determine the appropriate 29689 arguments to pass to make for doing parallel builds with autotools build files. 29690 296912010-07-01 Simon Hausmann <simon.hausmann@nokia.com> 29692 29693 Rubber-stamped by Laszlo Gombos. 29694 29695 [Qt][Symbian] Bumped up the maximum heap size to 96MB 29696 29697 * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration 29698 and use the one from WebKit.pri instead. 29699 297002010-07-01 Adam Barth <abarth@webkit.org> 29701 29702 Reviewed by Eric Seidel. 29703 29704 Promote webkit-patch land-safely to main help 29705 https://bugs.webkit.org/show_bug.cgi?id=41446 29706 29707 I've been using this command a bunch and recommending it to folks. We 29708 should show it in main help as it's past the experimental phase. 29709 29710 * Scripts/webkitpy/tool/commands/upload.py: 29711 297122010-06-28 MORITA Hajime <morrita@google.com> 29713 29714 Reviewed by Shinichiro Hamaji. 29715 29716 rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit 29717 https://bugs.webkit.org/show_bug.cgi?id=38775 29718 29719 - Introduced SCM.show_head() and SCM.diff_for_file(). 29720 - Replaced direct svn invocations with newly implement SCM methods. 29721 29722 * Scripts/webkitpy/common/checkout/scm.py: 29723 * Scripts/webkitpy/common/checkout/scm_unittest.py: 29724 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 29725 297262010-06-30 Simon Fraser <simon.fraser@apple.com> 29727 29728 Reviewed by Sam Weinig. 29729 29730 Allow MiniBrowser to open local files 29731 https://bugs.webkit.org/show_bug.cgi?id=41104 29732 29733 Wire up the openDocument: message with an NSOpenPanel, so we can open 29734 local files. 29735 29736 Also change the xib so that the window remembers its size. 29737 29738 * MiniBrowser/mac/AppDelegate.m: 29739 (-[BrowserAppDelegate frontmostBrowserWindowController]): 29740 (-[BrowserAppDelegate openDocument:]): 29741 (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]): 29742 * MiniBrowser/mac/English.lproj/BrowserWindow.xib: 29743 297442010-06-30 Sam Weinig <sam@webkit.org> 29745 29746 Rubber-stamped by Anders Carlsson. 29747 29748 Add debug-webkittestrunner and cleanup related scripts. 29749 29750 * Scripts/debug-webkittestrunner: Added. 29751 * Scripts/run-webkittestrunner: 29752 * Scripts/webkitdirs.pm: 29753 297542010-06-30 Kevin Ollivier <kevino@theolliviers.com> 29755 29756 [wx] Build fix after recent changes to LayoutTestController. 29757 29758 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 29759 (LayoutTestController::pageSizeAndMarginsInPixels): 29760 297612010-06-29 Sam Weinig <sam@webkit.org> 29762 29763 Reviewed by Anders Carlsson. 29764 29765 Patch for https://bugs.webkit.org/show_bug.cgi?id=41389 29766 Make WebKitTestRunner work with more than one test at a time. 29767 29768 This converts WebKitTestRunner to a similar model as DumpRenderTree, 29769 where there is a single WKView and each test is run it, rather than 29770 the design I was using where each test got its own WKView. 29771 29772 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 29773 (WTR::InjectedBundle::didRecieveMessage): 29774 (WTR::InjectedBundle::reset): 29775 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 29776 * WebKitTestRunner/TestController.cpp: 29777 (WTR::TestController::initialize): 29778 (WTR::TestController::runTest): 29779 (WTR::TestController::_didRecieveMessageFromInjectedBundle): 29780 (WTR::TestController::didRecieveMessageFromInjectedBundle): 29781 * WebKitTestRunner/TestController.h: 29782 (WTR::TestController::mainWebView): 29783 (WTR::TestController::pageNamespace): 29784 (WTR::TestController::context): 29785 * WebKitTestRunner/TestInvocation.cpp: 29786 (WTR::TestInvocation::TestInvocation): 29787 (WTR::TestInvocation::~TestInvocation): 29788 (WTR::TestInvocation::invoke): 29789 (WTR::TestInvocation::didRecieveMessageFromInjectedBundle): 29790 * WebKitTestRunner/TestInvocation.h: 29791 297922010-06-30 Simon Hausmann <simon.hausmann@nokia.com> 29793 29794 Reviewed by Laszlo Gombos. 29795 29796 [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0 29797 https://bugs.webkit.org/show_bug.cgi?id=40446 29798 29799 We quickly run out of memory on Symbian when loading web pages. This is 29800 caused by the default heap size, which is not suited for a web browser. 29801 29802 This change bumps the max heap size to 32MB. 29803 29804 * QtTestBrowser/QtTestBrowser.pro: 29805 298062010-06-30 Eric Seidel <eric@webkit.org> 29807 29808 Reviewed by Adam Barth. 29809 29810 webkit-patch land allow the user to continue even if the builders are red 29811 https://bugs.webkit.org/show_bug.cgi?id=41395 29812 29813 I don't think it's good that we've been teaching people 29814 to always pass --ignore-builders. At least land is now 29815 useable w/o --ignore-builders. 29816 29817 * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: 29818 298192010-06-29 Robert Hogan <robert@webkit.org> 29820 29821 Reviewed by Kenneth Rohde Christiansen. 29822 29823 [Qt] support dumpResourceResponseMIMETypes 29824 https://bugs.webkit.org/show_bug.cgi?id=41260 29825 29826 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 29827 (LayoutTestController::reset): 29828 (LayoutTestController::dumpResourceResponseMIMETypes): 29829 * DumpRenderTree/qt/LayoutTestControllerQt.h: 29830 298312010-06-29 Diego Gonzalez <diegohcg@webkit.org> 29832 29833 Reviewed by Kenneth Rohde Christiansen. 29834 29835 [Qt] Resize scene when Qt DRT WebPage receives a geometry change request 29836 https://bugs.webkit.org/show_bug.cgi?id=41173 29837 29838 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 29839 (WebCore::WebPage::setViewGeometry): 29840 * DumpRenderTree/qt/DumpRenderTreeQt.h: 29841 298422010-06-29 Diego Gonzalez <diegohcg@webkit.org> 29843 29844 Reviewed by Simon Hausmann. 29845 29846 [Qt] Deal with postEvent in case of graphics based DRT 29847 https://bugs.webkit.org/show_bug.cgi?id=41174 29848 29849 QGraphicsScene does not have a postEvent method, so make scene 29850 send the event, in case of graphics based DRT, and delete it after that. 29851 29852 * DumpRenderTree/qt/EventSenderQt.cpp: 29853 (EventSender::scheduleAsynchronousClick): 29854 (EventSender::replaySavedEvents): 29855 (EventSender::postEvent): 29856 * DumpRenderTree/qt/EventSenderQt.h: 29857 298582010-06-29 Diego Gonzalez <diegohcg@webkit.org> 29859 29860 Reviewed by Kenneth Rohde Christiansen. 29861 29862 [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT 29863 https://bugs.webkit.org/show_bug.cgi?id=41172 29864 29865 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 29866 (WebCore::DumpRenderTree::switchFocus): 29867 298682010-06-29 Mario Sanchez Prada <msanchez@igalia.com> 29869 29870 Reviewed by Xan Lopez. 29871 29872 [Gtk] Make DRT more coherent with other ports to allow reusing more tests 29873 https://bugs.webkit.org/show_bug.cgi?id=40009 29874 29875 Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes 29876 are used when returning those values, for coherency with other ports. 29877 29878 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 29879 (AccessibilityUIElement::role): 29880 (AccessibilityUIElement::title): 29881 (AccessibilityUIElement::description): 29882 298832010-06-29 Sheriff Bot <webkit.review.bot@gmail.com> 29884 29885 Unreviewed, rolling out r62106. 29886 http://trac.webkit.org/changeset/62106 29887 https://bugs.webkit.org/show_bug.cgi?id=41346 29888 29889 "Broke editing tests" (Requested by xan_ on #webkit). 29890 29891 * Scripts/old-run-webkit-tests: 29892 298932010-06-29 Mario Sanchez Prada <msanchez@igalia.com> 29894 29895 Reviewed by Xan Lopez. 29896 29897 Ensure DRT loads GAIL (Gtk+ module), for a11y tests 29898 https://bugs.webkit.org/show_bug.cgi?id=38648 29899 29900 Add the GTK_MODULES envvar (set to "gail") to the clean 29901 environment when running DRT for the Gtk+ port 29902 29903 * Scripts/old-run-webkit-tests: 29904 299052010-06-28 Adam Barth <abarth@webkit.org> 29906 29907 Unreviewed. 29908 29909 Switch test-html5-parser back to using runner.html. 29910 29911 * Scripts/test-html5-parser: 29912 299132010-06-28 Adam Barth <abarth@webkit.org> 29914 29915 Reviewed by Eric Seidel. 29916 29917 Restore webkit-runner.html for use with new tree builder 29918 https://bugs.webkit.org/show_bug.cgi?id=41317 29919 29920 For now, we just want to run webkit-runner when we test-html5-parser. 29921 29922 * Scripts/test-html5-parser: 29923 299242010-06-23 John Gregg <johnnyg@google.com> 29925 29926 Reviewed by Kent Tamura. 29927 29928 add ENABLE_DIRECTORY_UPLOAD build support 29929 https://bugs.webkit.org/show_bug.cgi?id=41100 29930 29931 * Scripts/build-webkit: 29932 299332010-06-28 Gustavo Noronha Silva <gns@gnome.org> 29934 29935 Rubber-stamped by Xan Lopez. 29936 29937 Update webkitdirs's knowledge of our library's name. 29938 29939 * Scripts/webkitdirs.pm: 29940 299412010-06-28 Sam Weinig <sam@webkit.org> 29942 29943 Reviewed by Anders Carlsson. 29944 29945 Patch for https://bugs.webkit.org/show_bug.cgi?id=41299 29946 Build up WebKitTestRunner output in the InjectedBundle 29947 29948 Simplify WebKitTestRunner by building up the output in the InjectedBundle 29949 and sending it over postMessage when done, instead of using the async 29950 WKPageRenderTreeExternalRepresentation. 29951 29952 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 29953 (WTR::InjectedBundle::done): 29954 (WTR::InjectedBundle::didRecieveMessage): 29955 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 29956 (WTR::InjectedBundle::os): 29957 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 29958 (WTR::WKStringToUTF8): 29959 (WTR::InjectedBundlePage::didFinishLoadForFrame): 29960 (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): 29961 * WebKitTestRunner/TestInvocation.cpp: 29962 (WTR::WKStringToUTF8): 29963 (WTR::TestInvocation::TestInvocation): 29964 (WTR::TestInvocation::invoke): 29965 (WTR::TestInvocation::initializeMainWebView): 29966 (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle): 29967 (WTR::TestInvocation::didRecieveMessageFromInjectedBundle): 29968 * WebKitTestRunner/TestInvocation.h: 29969 299702010-06-28 Robert Hogan <robert@webkit.org> 29971 29972 Unreviewed, rolling out r62021. 29973 http://trac.webkit.org/changeset/62021 29974 https://bugs.webkit.org/show_bug.cgi?id=41261 29975 29976 Broke http/navigation tests among other 29977 29978 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 29979 (WebCore::DumpRenderTree::dumpFramesAsText): 29980 299812010-06-28 Sam Weinig <sam@webkit.org> 29982 29983 Reviewed by Anders Carlsson. 29984 29985 Add run-webkittestrunner to run WebKitTestRunner with the appropriate 29986 environment. 29987 29988 * Scripts/run-webkittestrunner: Added. 29989 * Scripts/webkitdirs.pm: 29990 299912010-06-28 Robert Hogan <robert@webkit.org> 29992 29993 Reviewed by Kenneth Rohde Christiansen. 29994 29995 [Qt] dump frames in ascending alphabetical order of title 29996 29997 https://bugs.webkit.org/show_bug.cgi?id=41261 29998 29999 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 30000 (WebCore::DumpRenderTree::dumpFramesAsText): 30001 300022010-06-28 Robert Hogan <robert@webkit.org> 30003 30004 Reviewed by Kenneth Rohde Christiansen. 30005 30006 [Qt] dump bf history of child windows 30007 30008 https://bugs.webkit.org/show_bug.cgi?id=41266 30009 30010 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 30011 (WebCore::DumpRenderTree::dumpBackForwardList): 30012 (WebCore::DumpRenderTree::dump): 30013 * DumpRenderTree/qt/DumpRenderTreeQt.h: 30014 300152010-06-28 Sam Weinig <sam@webkit.org> 30016 30017 Reviewed by Anders Carlsson. 30018 30019 Patch for https://bugs.webkit.org/show_bug.cgi?id=41288 30020 WebKit2: Add frame API for InjectedBundle code 30021 30022 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 30023 (_didClearWindowForFrame): 30024 300252010-06-28 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 30026 30027 Reviewed by Kenneth Rohde Christiansen. 30028 30029 [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode). 30030 https://bugs.webkit.org/show_bug.cgi?id=38597 30031 30032 Fix behavior so reload button really acts as a load and a reload button. 30033 30034 * QtTestBrowser/mainwindow.cpp: 30035 (MainWindow::changeLocation): 30036 300372010-06-28 Xan Lopez <xlopez@igalia.com> 30038 30039 Reviewed by Gustavo Noronha. 30040 30041 [GTK] Does not compile with -DGSEAL_ENABLE 30042 https://bugs.webkit.org/show_bug.cgi?id=37851 30043 30044 Fix build with GSEAL enabled. 30045 30046 * DumpRenderTree/gtk/EventSender.cpp: 30047 (gtk_widget_get_window): 30048 (prepareMouseButtonEvent): 30049 (mouseMoveToCallback): 30050 (mouseWheelToCallback): 30051 (keyDownCallback): 30052 300532010-06-28 Xan Lopez <xlopez@igalia.com> 30054 30055 Reviewed by Gustavo Noronha. 30056 30057 [GTK] Add support for GTK+3 30058 https://bugs.webkit.org/show_bug.cgi?id=41253 30059 30060 Adapt build system for 3.x support. 30061 30062 * GNUmakefile.am: 30063 300642010-06-10 Mahesh Kulkarni <mahesh.kulkarni@nokia.com> 30065 30066 Reviewed by Simon Hausmann. 30067 30068 [QT][S60] build-webkit scripts picks wrong make spec for windows build 30069 https://bugs.webkit.org/show_bug.cgi?id=41198 30070 30071 Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 30072 30073 * Scripts/webkitdirs.pm: 30074 (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well 30075 300762010-06-28 Eric Seidel <eric@webkit.org> 30077 30078 Reviewed by Adam Barth. 30079 30080 Make it possible to test the new HTML5 TreeBuilder 30081 https://bugs.webkit.org/show_bug.cgi?id=41276 30082 30083 Adam was concerned that someone might make their port 30084 depend on this setting (I guess we had some trouble with that 30085 with the HTML5Parser setting), so I littered the code with warnings. 30086 30087 test-html5-parser now tests this code path. 30088 30089 * DumpRenderTree/mac/DumpRenderTree.mm: 30090 (resetDefaultsToConsistentValues): 30091 (initializeGlobalsFromCommandLineOptions): 30092 * Scripts/test-html5-parser: 30093 300942010-06-27 MORITA Hajime <morrita@google.com> 30095 30096 Unreviewed. 30097 30098 Some never-called @staticmethods touched self. 30099 Fixed it to replace these self with a class. 30100 30101 * Scripts/webkitpy/common/checkout/scm.py: 30102 301032010-06-27 MORITA Hajime <morrita@google.com> 30104 30105 Unreviewed. 30106 30107 Fixed exception raising syntax that is pointed out at 30108 https://bugs.webkit.org/show_bug.cgi?id=41153 30109 30110 * Scripts/webkitpy/common/checkout/scm.py: 30111 * Scripts/webkitpy/common/checkout/scm_unittest.py: 30112 Removed a bad line that I accidentally checked-in at last revision. 30113 301142010-06-24 MORITA Hajime <morrita@google.com> 30115 30116 Reviewed by Eric Seidel. 30117 30118 rebaseline-chromium-webkit-tests should add or remove files to local git repository 30119 https://bugs.webkit.org/show_bug.cgi?id=41153 30120 30121 - Added SCM.add() and SCM.remove() 30122 - Replaced "svn add" and "svn remove" 30123 rebaseline_chromium_webkit_tests.py: in with SCM method equivalents. 30124 - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py 30125 for debugging purpose. 30126 30127 * Scripts/webkitpy/common/checkout/scm.py: 30128 * Scripts/webkitpy/common/checkout/scm_unittest.py: 30129 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 30130 301312010-06-25 Yuzo Fujishima <yuzo@google.com> 30132 30133 Reviewed by Shinichiro Hamaji. 30134 30135 Improve default value handling for page format properties. 30136 https://bugs.webkit.org/show_bug.cgi?id=41150 30137 30138 * DumpRenderTree/LayoutTestController.cpp: 30139 (parsePageNumber): 30140 (parsePageNumberSizeMarings): 30141 (pageSizeAndMarginsInPixelsCallback): 30142 (LayoutTestController::staticFunctions): 30143 * DumpRenderTree/LayoutTestController.h: 30144 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 30145 (LayoutTestController::pageSizeAndMarginsInPixels): 30146 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 30147 (LayoutTestController::pageSizeAndMarginsInPixels): 30148 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 30149 (LayoutTestController::pageSizeAndMarginsInPixels): 30150 301512010-06-21 Robert Hogan <robert@webkit.org> 30152 30153 Reviewed by Kenneth Rohde Christiansen. 30154 30155 [Qt] DRT Support for setCustomPolicyDelegate 30156 30157 https://bugs.webkit.org/show_bug.cgi?id=39564 30158 30159 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 30160 (LayoutTestController::setCustomPolicyDelegate): 30161 * DumpRenderTree/qt/LayoutTestControllerQt.h: 30162 301632010-06-26 Robert Hogan <robert@webkit.org> 30164 30165 Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879 30166 30167 Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer 30168 exported. 30169 30170 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 30171 301722010-06-26 Tony Gentilcore <tonyg@chromium.org> 30173 30174 Reviewed by Dimitri Glazkov. 30175 30176 Add a build-webkit option for enabling Web Timing support. 30177 https://bugs.webkit.org/show_bug.cgi?id=38924 30178 30179 * Scripts/build-webkit: 30180 301812010-06-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 30182 30183 Reviewed by Kenneth Rohde Christiansen. 30184 30185 [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode). 30186 https://bugs.webkit.org/show_bug.cgi?id=38597 30187 30188 Make the reload button act as a load button as well. 30189 30190 * QtTestBrowser/mainwindow.cpp: 30191 (MainWindow::buildUI): 30192 (MainWindow::changeLocation): 30193 301942010-06-25 Prasad Tammana <prasadt@chromium.org> 30195 30196 Reviewed by Dmitry Titov. 30197 30198 Add empty abortModal() method to all platforms. 30199 https://bugs.webkit.org/show_bug.cgi?id=40864 30200 30201 Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in 30202 platform independent LayoutTestController code. Without this change, layout tests using LayoutTestController tests 30203 that use abortModal will become mac specific which is not desirable. 30204 30205 * DumpRenderTree/LayoutTestController.cpp: 30206 (abortModalCallback): 30207 (LayoutTestController::staticFunctions): 30208 * DumpRenderTree/LayoutTestController.h: 30209 * DumpRenderTree/chromium/LayoutTestController.cpp: 30210 (LayoutTestController::LayoutTestController): 30211 (LayoutTestController::abortModal): 30212 * DumpRenderTree/chromium/LayoutTestController.h: 30213 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 30214 (LayoutTestController::abortModal): 30215 * DumpRenderTree/qt/LayoutTestControllerQt.h: 30216 (LayoutTestController::abortModal): 30217 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 30218 (LayoutTestController::abortModal): 30219 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 30220 (LayoutTestController::abortModal): 30221 302222010-06-25 Sam Weinig <sam@webkit.org> 30223 30224 Reviewed by Anders Carlsson. 30225 30226 Patch for https://bugs.webkit.org/show_bug.cgi?id=41226 30227 Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController. 30228 30229 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added. 30230 (WTR::InjectedBundle::shared): 30231 (WTR::InjectedBundle::InjectedBundle): 30232 (WTR::InjectedBundle::_didCreatePage): 30233 (WTR::InjectedBundle::_willDestroyPage): 30234 (WTR::InjectedBundle::_didRecieveMessage): 30235 (WTR::InjectedBundle::initialize): 30236 (WTR::InjectedBundle::didCreatePage): 30237 (WTR::InjectedBundle::willDestroyPage): 30238 (WTR::InjectedBundle::didRecieveMessage): 30239 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added. 30240 (WTR::InjectedBundle::layoutTestController): 30241 * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: 30242 (WKBundleInitialize): 30243 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added. 30244 (WTR::InjectedBundlePage::InjectedBundlePage): 30245 (WTR::InjectedBundlePage::~InjectedBundlePage): 30246 (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame): 30247 (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame): 30248 (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame): 30249 (WTR::InjectedBundlePage::_didCommitLoadForFrame): 30250 (WTR::InjectedBundlePage::_didFinishLoadForFrame): 30251 (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame): 30252 (WTR::InjectedBundlePage::_didReceiveTitleForFrame): 30253 (WTR::InjectedBundlePage::_didClearWindowForFrame): 30254 (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): 30255 (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame): 30256 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): 30257 (WTR::InjectedBundlePage::didCommitLoadForFrame): 30258 (WTR::InjectedBundlePage::didFinishLoadForFrame): 30259 (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): 30260 (WTR::InjectedBundlePage::didReceiveTitleForFrame): 30261 (WTR::InjectedBundlePage::didClearWindowForFrame): 30262 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added. 30263 (WTR::InjectedBundlePage::page): 30264 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added. 30265 (WTR::LayoutTestController::create): 30266 (WTR::LayoutTestController::LayoutTestController): 30267 (WTR::LayoutTestController::~LayoutTestController): 30268 (WTR::dumpAsTextCallback): 30269 (WTR::layoutTestControllerObjectFinalize): 30270 (WTR::LayoutTestController::makeWindowObject): 30271 (WTR::LayoutTestController::getJSClass): 30272 (WTR::LayoutTestController::staticFunctions): 30273 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added. 30274 (WTR::LayoutTestController::dumpAsText): 30275 (WTR::LayoutTestController::setDumpAsText): 30276 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 30277 302782010-06-25 Sam Weinig <sam@webkit.org> 30279 30280 Reviewed by Anders Carlsson. 30281 30282 Make WebKitTestRunner really work with run-webkit-tests. 30283 30284 - Add Forwarding headers to allow some cleanup. 30285 30286 * WebKitTestRunner/ForwardingHeaders: Added. 30287 * WebKitTestRunner/ForwardingHeaders/wtf: Added. 30288 * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added. 30289 * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added. 30290 * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added. 30291 * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added. 30292 * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added. 30293 * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added. 30294 * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added. 30295 * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added. 30296 * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added. 30297 * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added. 30298 * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added. 30299 * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added. 30300 * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added. 30301 * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added. 30302 * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added. 30303 * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added. 30304 * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added. 30305 * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added. 30306 * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added. 30307 * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added. 30308 * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added. 30309 * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added. 30310 * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added. 30311 * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added. 30312 * WebKitTestRunner/TestInvocation.cpp: 30313 (WTR::TestInvocation::dump): Dump the right number of #EOFs. 30314 * WebKitTestRunner/TestInvocation.h: 30315 303162010-06-25 Sam Weinig <sam@webkit.org> 30317 30318 Reviewed by Mark Rowe. 30319 30320 Add support for WebKitTestRunner to old-run-webkit-tests 30321 30322 - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use. 30323 30324 * Scripts/build-webkittestrunner: Added. 30325 * Scripts/old-run-webkit-tests: 30326 303272010-06-25 Adam Barth <abarth@webkit.org> 30328 30329 Reviewed by David Levin. 30330 30331 Incremental build failed on Chromium ews 30332 https://bugs.webkit.org/show_bug.cgi?id=41011 30333 30334 The division of responsibility between update-webkit --chromium and 30335 build-webkit --chromium is slightly unclear. In this patch, we make 30336 build-webkit --chromium also update DEPS and re-run GYP in case the 30337 developer has changed either since they updated. 30338 30339 This change is also helpful for the EWS, which wants to update DEPS and 30340 re-run GYP after applying patches, but the EWS doesn't want to run 30341 update-webkit --chromium because it has a dirty working copy. 30342 30343 * Scripts/webkitdirs.pm: 30344 303452010-06-25 Robert Hogan <robert@webkit.org> 30346 30347 Reviewed by Simon Hausmann. 30348 30349 [Qt] Support evaluateScriptInIsolatedWorld() 30350 30351 https://bugs.webkit.org/show_bug.cgi?id=40079 30352 30353 Remove evaluateScriptInIsolatedWorld() from QtWebKit API. 30354 Remove QWebScriptWorld from exported headers. 30355 Confine support to DumpRenderTreeSupportQt so that the tests can pass. 30356 30357 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 30358 (LayoutTestController::reset): 30359 (LayoutTestController::evaluateScriptInIsolatedWorld): 30360 * DumpRenderTree/qt/LayoutTestControllerQt.h: 30361 303622010-06-25 Anders Carlsson <andersca@apple.com> 30363 30364 Revert accidental part and add a newline. 30365 30366 * MiniBrowser/mac/AppDelegate.m: 30367 * MiniBrowser/mac/MiniBrowser_Prefix.pch: 30368 303692010-06-25 Anders Carlsson <andersca@apple.com> 30370 30371 Rubber-stamped by Dan Bernstein. 30372 30373 Add a LOG macro that expands to a no-op by default. 30374 30375 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: 30376 * MiniBrowser/mac/AppDelegate.m: 30377 (_didRecieveMessageFromInjectedBundle): 30378 * MiniBrowser/mac/BrowserWindowController.m: 30379 (-[BrowserWindowController windowShouldClose:]): 30380 (_didStartProvisionalLoadForFrame): 30381 (_didReceiveServerRedirectForProvisionalLoadForFrame): 30382 (_didFailProvisionalLoadWithErrorForFrame): 30383 (_didCommitLoadForFrame): 30384 (_didFinishLoadForFrame): 30385 (_didFailLoadWithErrorForFrame): 30386 (_didReceiveTitleForFrame): 30387 (_didFirstLayoutForFrame): 30388 (_didFirstVisuallyNonEmptyLayoutForFrame): 30389 (_didBecomeUnresponsive): 30390 (_didBecomeResponsive): 30391 (_decidePolicyForNavigationAction): 30392 (_decidePolicyForNewWindowAction): 30393 (_createNewPage): 30394 (_showPage): 30395 (_closePage): 30396 (_didNavigateWithNavigationData): 30397 (_didPerformClientRedirect): 30398 (_didPerformServerRedirect): 30399 (_didUpdateHistoryTitle): 30400 * MiniBrowser/mac/MiniBrowser_Prefix.pch: 30401 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 30402 (_didClearWindowForFrame): 30403 (_didCreatePage): 30404 (_willDestroyPage): 30405 (_didRecieveMessage): 30406 304072010-06-24 Adam Barth <abarth@webkit.org> 30408 30409 Reviewed by Eric Seidel. 30410 30411 commit-queue is taking too long to land patches because of red trees 30412 https://bugs.webkit.org/show_bug.cgi?id=41194 30413 30414 Instead of checking for the tree to be green, we'll just spin hot 30415 trying to land patches. This is probably too extreme in ignoring the 30416 tree, but I think we should try it for a while to see if we have 30417 trouble. That will help us find the right balance. 30418 30419 * Scripts/webkitpy/tool/commands/queues.py: 30420 * Scripts/webkitpy/tool/commands/queues_unittest.py: 30421 304222010-06-24 Martin Robinson <mrobinson@igalia.com> 30423 30424 Reviewed by Xan Lopez. 30425 30426 [GTK] Clean up the use of gdk_window_get_root_coords in EventSender 30427 https://bugs.webkit.org/show_bug.cgi?id=40843 30428 30429 Define the version for old GTK+s in a way that is forward-compatible 30430 and clean up the logic a bit. 30431 30432 * DumpRenderTree/gtk/EventSender.cpp: 30433 (gdk_window_get_root_coords): Renamed and cleaned up. 30434 (prepareMouseButtonEvent): Remove #ifdefs. 30435 (mouseMoveToCallback): Remove #ifdefs. 30436 304372010-06-24 Dimitri Glazkov <dglazkov@chromium.org> 30438 30439 Reviewed by Eric Seidel. 30440 30441 Fix NewRunWebKitTests to work on Windows. 30442 https://bugs.webkit.org/show_bug.cgi?id=41180 30443 30444 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments, 30445 because Windows fails to understand what we're asking of it. 30446 304472010-06-24 Martin Robinson <mrobinson@igalia.com> 30448 30449 Reviewed by Xan Lopez. 30450 30451 [GTK] The url passed to the WebView during layout tests is invalid 30452 https://bugs.webkit.org/show_bug.cgi?id=40832 30453 30454 Set the test URL to the full real file URL and do a small cleanup. 30455 Previously a URL like file://relative/path/to/test.html was passed 30456 to the WebView. This malformed file URL would be returned by 30457 webkit_web_view_get_url and webkit_web_frame_get_url. 30458 30459 * DumpRenderTree/gtk/DumpRenderTree.cpp: 30460 (shouldLogFrameLoadDelegates): Change to take a const string& as the argument. 30461 (shouldOpenWebInspector): Change to take a const string& as the argument. 30462 (shouldEnableDeveloperExtras): Change to take a const string& as the argument. 30463 (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable. 30464 304652010-06-24 Sam Weinig <sam@webkit.org> 30466 30467 Reviewed by Anders Carlsson. 30468 30469 Fix WebKitTestRunner Makefile typos. 30470 30471 * WebKitTestRunner/Makefile: 30472 304732010-06-24 Adele Peterson <adele@apple.com> 30474 30475 Reviewed by Eric Carlson. 30476 30477 DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events 30478 https://bugs.webkit.org/show_bug.cgi?id=41085 30479 30480 * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): 30481 Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects. 30482 304832010-06-23 Sam Weinig <sam@webkit.org> 30484 30485 Reviewed by Anders Carlsson. 30486 30487 Patch for https://bugs.webkit.org/show_bug.cgi?id=41086 30488 Add new WebKitTestRunner project (ie. DRT for WebKit2). 30489 30490 - Mac only. 30491 - run-webkit-tests has not been modified to call it yet. 30492 - Only dumps the render tree at this time. 30493 30494 * WebKitTestRunner: Added. 30495 * WebKitTestRunner/Configurations: Added. 30496 * WebKitTestRunner/Configurations/Base.xcconfig: Added. 30497 * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added. 30498 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added. 30499 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added. 30500 * WebKitTestRunner/InjectedBundle: Added. 30501 * WebKitTestRunner/InjectedBundle-Info.plist: Added. 30502 * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added. 30503 (_didStartProvisionalLoadForFrame): 30504 (_didReceiveServerRedirectForProvisionalLoadForFrame): 30505 (_didFailProvisionalLoadWithErrorForFrame): 30506 (_didCommitLoadForFrame): 30507 (_didFinishLoadForFrame): 30508 (_didFailLoadWithErrorForFrame): 30509 (_didReceiveTitleForFrame): 30510 (_didClearWindow): 30511 (_didCreatePage): 30512 (_willDestroyPage): 30513 (_didRecieveMessage): 30514 (WKBundleInitialize): 30515 * WebKitTestRunner/Makefile: Added. 30516 * WebKitTestRunner/PlatformWebView.h: Added. 30517 (WTR::PlatformWebView::platformView): 30518 * WebKitTestRunner/TestController.cpp: Added. 30519 (WTR::TestController::shared): 30520 (WTR::TestController::TestController): 30521 (WTR::TestController::initialize): 30522 (WTR::TestController::runTest): 30523 (WTR::TestController::runTestingServerLoop): 30524 (WTR::TestController::run): 30525 * WebKitTestRunner/TestController.h: Added. 30526 (WTR::TestController::verbose): 30527 (WTR::TestController::injectedBundlePath): 30528 * WebKitTestRunner/TestInvocation.cpp: Added. 30529 (WTR::createWKURL): 30530 (WTR::TestInvocation::TestInvocation): 30531 (WTR::TestInvocation::~TestInvocation): 30532 (WTR::TestInvocation::invoke): 30533 (WTR::TestInvocation::dump): 30534 (WTR::TestInvocation::initializeMainWebView): 30535 (WTR::TestInvocation::didStartProvisionalLoadForFrame): 30536 (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame): 30537 (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame): 30538 (WTR::TestInvocation::didCommitLoadForFrame): 30539 (WTR::TestInvocation::didFinishLoadForFrame): 30540 (WTR::TestInvocation::didFailLoadForFrame): 30541 (WTR::TestInvocation::renderTreeExternalRepresentationFunction): 30542 (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction): 30543 * WebKitTestRunner/TestInvocation.h: Added. 30544 * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added. 30545 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added. 30546 * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added. 30547 * WebKitTestRunner/mac: Added. 30548 * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added. 30549 (WTR::PlatformWebView::PlatformWebView): 30550 (WTR::PlatformWebView::~PlatformWebView): 30551 (WTR::PlatformWebView::page): 30552 * WebKitTestRunner/mac/TestInvocationMac.mm: Added. 30553 (WTR::TestInvocation::runUntil): 30554 * WebKitTestRunner/mac/main.mm: Added. 30555 (main): 30556 305572010-06-24 Luiz Agostini <luiz.agostini@openbossa.org> 30558 30559 Unreviewed. Adding myself to the committers list. 30560 30561 * Scripts/webkitpy/common/config/committers.py: 30562 305632010-06-23 Kevin Ollivier <kevino@theolliviers.com> 30564 30565 [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT. 30566 30567 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 30568 (LayoutTestController::isPageBoxVisible): 30569 (LayoutTestController::pageAreaRectInPixels): 30570 (LayoutTestController::preferredPageSizeInPixels): 30571 * wx/build/settings.py: 30572 305732010-06-23 James Robinson <jamesr@chromium.org> 30574 30575 Unreviewed. Add my IRC handle to committers.py so the sheriffbot can yell at me. 30576 30577 * Scripts/webkitpy/common/config/committers.py: 30578 305792010-06-23 Kent Tamura <tkent@chromium.org> 30580 30581 Reviewed by Dimitri Glazkov. 30582 30583 Correct Chromium test configuration 30584 https://bugs.webkit.org/show_bug.cgi?id=41057 30585 30586 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 30587 - Add "--use-drt" option for NRWT. It is required for Chromium and 30588 ignored for other platforms. 30589 - Skip JSC test on Chromium 30590 * BuildSlaveSupport/test-result-archive: 30591 Add Chromium support. 30592 305932010-06-23 Sam Weinig <sam@webkit.org> 30594 30595 Reviewed by Anders Carlsson. 30596 30597 Fix for https://bugs.webkit.org/show_bug.cgi?id=41073 30598 WebKit2: Flesh out more of the InjectedBundle client API 30599 30600 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 30601 (_didStartProvisionalLoadForFrame): 30602 (_didReceiveServerRedirectForProvisionalLoadForFrame): 30603 (_didFailProvisionalLoadWithErrorForFrame): 30604 (_didCommitLoadForFrame): 30605 (_didFinishLoadForFrame): 30606 (_didFailLoadWithErrorForFrame): 30607 (_didReceiveTitleForFrame): 30608 (_didClearWindowForFrame): 30609 (_didCreatePage): 30610 (_willDestroyPage): 30611 (WKBundleInitialize): 30612 306132010-06-23 Yuzo Fujishima <yuzo@google.com> 30614 30615 Reviewed by Shinichiro Hamaji. 30616 30617 Implement page format data programming interface. 30618 Add methods for testing. 30619 https://bugs.webkit.org/show_bug.cgi?id=37538 30620 30621 * DumpRenderTree/LayoutTestController.cpp: 30622 (parsePageNumber): 30623 (isPageBoxVisibleCallback): 30624 (pageAreaRectInPixelsCallback): 30625 (preferredPageSizeInPixelsCallback): 30626 (LayoutTestController::staticFunctions): 30627 * DumpRenderTree/LayoutTestController.h: 30628 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 30629 (LayoutTestController::isPageBoxVisible): 30630 (LayoutTestController::pageAreaRectInPixels): 30631 (LayoutTestController::preferredPageSizeInPixels): 30632 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 30633 (LayoutTestController::isPageBoxVisible): 30634 (LayoutTestController::pageAreaRectInPixels): 30635 (LayoutTestController::preferredPageSizeInPixels): 30636 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 30637 (LayoutTestController::isPageBoxVisible): 30638 (LayoutTestController::pageAreaRectInPixels): 30639 (LayoutTestController::preferredPageSizeInPixels): 30640 306412010-06-23 Sam Magnuson <smagnuson@netflix.com> 30642 30643 Reviewed by Shinichiro Hamaji. 30644 30645 Follow proper convention for if/switch/while as I've discovered 30646 them to be through my review processes. 30647 https://bugs.webkit.org/show_bug.cgi?id=40723 30648 30649 Modified test so that if( foo ) is not allowed as it appears not 30650 to be the accepted convention. 30651 30652 * Scripts/webkitpy/style/checkers/cpp.py: 30653 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 30654 306552010-06-22 Eric Seidel <eric@webkit.org> 30656 30657 Reviewed by Adam Barth. 30658 30659 Run clean-header-guards to fix some header guards 30660 https://bugs.webkit.org/show_bug.cgi?id=41044 30661 30662 No functional changes, thus no tests. 30663 30664 This entire change was generated by running 30665 clean-header-guards, and then reverting changes 30666 to files which shouldn't be changed. Those which 30667 are left all should be updated. 30668 30669 Some of these changes are just fixing 755 permissions 30670 to be 644, since it seems various files have the wrong 30671 execute bit which don't need it. clean-header-guards 30672 made those (welcome) permission fixes unintentionally. 30673 30674 * DumpRenderTree/chromium/WebThemeControlDRT.h: 30675 * DumpRenderTree/chromium/WebThemeEngineDRT.h: 30676 * QtTestBrowser/fpstimer.h: 30677 306782010-06-22 Adam Barth <abarth@webkit.org> 30679 30680 Reviewed by Eric Seidel. 30681 30682 Rename HTMLDocumentParser to LegacyHTMLDocumentParser 30683 https://bugs.webkit.org/show_bug.cgi?id=41043 30684 30685 Update the hash. 30686 30687 * Scripts/do-webcore-rename: 30688 306892010-06-22 Sam Magnuson <smagnuson@netflix.com> 30690 30691 Reviewed by Shinichiro Hamaji. 30692 30693 Follow proper convention for variable declaration spacing. 30694 https://bugs.webkit.org/show_bug.cgi?id=40724 30695 30696 Modified test so that 'int a;' is not allowed. 30697 30698 * Scripts/webkitpy/style/checkers/cpp.py: 30699 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 30700 307012010-06-22 Eric Seidel <eric@webkit.org> 30702 30703 Unreviewed. Add Tony Gentilcore now that he's a committer. 30704 30705 * Scripts/webkitpy/common/config/committers.py: 30706 307072010-06-22 Eric Seidel <eric@webkit.org> 30708 30709 Reviewed by Adam Barth. 30710 30711 Remove Gtk 64-Release bot from core since it's broken 30712 https://bugs.webkit.org/show_bug.cgi?id=41022 30713 30714 This bot alone has been responsible for more than 72 hours of 30715 commit-queue blockage in the last week. The bot is broken -- keeps 30716 losing its display server or similar. Until the Gtk folks can fix the 30717 bot, we need to remove it from core. The WebKit community can't keep 30718 it green as is. 30719 30720 * Scripts/webkitpy/common/net/buildbot.py: 30721 * Scripts/webkitpy/common/net/buildbot_unittest.py: 30722 307232010-06-21 Dumitru Daniliuc <dumi@chromium.org> 30724 30725 Reviewed by Eric Seidel. 30726 30727 Fix the Windows build. 30728 https://bugs.webkit.org/show_bug.cgi?id=40972 30729 30730 * DumpRenderTree/win/ImageDiff.vcproj: 30731 307322010-06-21 Prasad Tammana <prasadt@chromium.org> 30733 30734 Reviewed by Darin Adler, Dmitry Titov. 30735 30736 DumpRenderTree should allow tests with modal dialogs 30737 https://bugs.webkit.org/show_bug.cgi?id=35350 30738 30739 * DumpRenderTree/LayoutTestController.cpp: 30740 (abortModalCallback): 30741 (LayoutTestController::staticFunctions): 30742 * DumpRenderTree/LayoutTestController.h: 30743 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 30744 (LayoutTestController::abortModal): 30745 Add abortModal method to LayoutTestController and make it available from script. 30746 30747 * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog. 30748 (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call 30749 abortModal from when modal window closes. 30750 (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop. 30751 307522010-06-21 Simon Fraser <simon.fraser@apple.com> 30753 30754 Reviewed by Anders Carlsson. 30755 30756 Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea 30757 https://bugs.webkit.org/show_bug.cgi?id=40948 30758 30759 Have the script look in WebKit2. 30760 30761 * Scripts/do-webcore-rename: 30762 307632010-06-21 Robert Hogan <robert@webkit.org> 30764 30765 Reviewed by Kenneth Rohde Christiansen. 30766 30767 [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html 30768 30769 It's a Mac-specific test so just add the required LayoutTestController 30770 function as a no-op to avoid failing. Similar approach adopted by other 30771 ports. 30772 30773 https://bugs.webkit.org/show_bug.cgi?id=33344 30774 30775 * DumpRenderTree/qt/LayoutTestControllerQt.h: 30776 (LayoutTestController::addDisallowedURL): 30777 307782010-06-21 Sam Weinig <sam@webkit.org> 30779 30780 Reviewed by Anders Carlsson. 30781 30782 Patch for https://bugs.webkit.org/show_bug.cgi?id=40940 30783 Add message passing support to the WebKit2 API. 30784 30785 - Add some test messages. 30786 30787 * MiniBrowser/mac/AppDelegate.m: 30788 (_didRecieveMessageFromInjectedBundle): 30789 (-[BrowserAppDelegate init]): 30790 * MiniBrowser/mac/WebBundle/WebBundleMain.m: 30791 (_didClearWindow): 30792 (_didCreatePage): 30793 (_didRecieveMessage): 30794 (WKBundleInitialize): 30795 307962010-06-21 Drew Wilson <atwilson@chromium.org> 30797 30798 Unreviewed. 30799 30800 Rolling back 61551 and 61555 due to test failures. 30801 30802 * DumpRenderTree/LayoutTestController.cpp: 30803 (LayoutTestController::staticFunctions): 30804 * DumpRenderTree/LayoutTestController.h: 30805 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 30806 (LayoutTestController::setEditingBehavior): 30807 * DumpRenderTree/mac/UIDelegate.mm: 30808 308092010-06-21 Anders Carlsson <andersca@apple.com> 30810 30811 Reviewed by Sam Weinig. 30812 30813 Make DumpRenderTree build with clang++ 30814 30815 * DumpRenderTree/mac/DumpRenderTreePasteboard.m: 30816 (-[LocalPasteboard setPropertyList:forType:]): 30817 * DumpRenderTree/mac/DumpRenderTreeWindow.mm: 30818 (-[DumpRenderTreeWindow keyDown:]): 30819 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 30820 (LayoutTestController::elementDoesAutoCompleteForElementWithId): 30821 (LayoutTestController::isCommandEnabled): 30822 308232010-06-21 Satish Sampath <satish@chromium.org> 30824 30825 Reviewed by Steve Block. 30826 30827 Speech Input Patch 0: Added compilation argument to conditionally compile pending patches. 30828 https://bugs.webkit.org/show_bug.cgi?id=40878 30829 30830 * Scripts/build-webkit: 30831 308322010-06-21 Kent Tamura <tkent@chromium.org> 30833 30834 Reviewed by Dimitri Glazkov. 30835 30836 [DRT/Chromium] Initialization for http/tests/loading/ 30837 https://bugs.webkit.org/show_bug.cgi?id=40902 30838 30839 * DumpRenderTree/chromium/TestShell.cpp: 30840 (TestShell::runFileTest): 30841 308422010-06-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 30843 30844 Unreviewed. 30845 30846 Adding myself to the committers list. 30847 30848 * Scripts/webkitpy/common/config/committers.py: 30849 308502010-06-20 Kent Tamura <tkent@chromium.org> 30851 30852 Reviewed by Dimitri Glazkov. 30853 30854 [DRT/Chromium] Add --allow-external-pages option 30855 https://bugs.webkit.org/show_bug.cgi?id=40762 30856 30857 Add --allow-external-pages introduced by Chromium r45403. 30858 http://src.chromium.org/viewvc/chrome?view=rev&revision=45403 30859 30860 * DumpRenderTree/chromium/DumpRenderTree.cpp: 30861 (main): 30862 * DumpRenderTree/chromium/TestShell.cpp: 30863 (TestShell::TestShell): 30864 * DumpRenderTree/chromium/TestShell.h: 30865 (TestShell::allowExternalPages): 30866 (TestShell::setAllowExternalPages): 30867 * DumpRenderTree/chromium/WebViewHost.cpp: 30868 (WebViewHost::willSendRequest): 30869 308702010-06-20 Joseph Pecoraro <joepeck@webkit.org> 30871 30872 Reviewed by Adam Barth. 30873 30874 Sheriffbot: Should allow "r" in SVN_REVISION 30875 https://bugs.webkit.org/show_bug.cgi?id=40889 30876 30877 * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists 30878 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r. 30879 308802010-06-20 Joseph Pecoraro <joepeck@webkit.org> 30881 30882 Reviewed by Dimitri Glazkov. 30883 30884 Python Tests Fail after r61508 30885 https://bugs.webkit.org/show_bug.cgi?id=40891 30886 30887 Test's regex list needed to be updated to match the new 30888 regex list in the source code. Added new bots to the 30889 example_buildbots list. 30890 30891 Regex list fixed in r61512. Updated bot list. 30892 30893 * Scripts/webkitpy/common/net/buildbot_unittest.py: 30894 308952010-06-20 Dimitri Glazkov <dglazkov@chromium.org> 30896 30897 Unreviewed, build fix. 30898 30899 Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508. 30900 30901 * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp. 30902 309032010-06-19 Justin Schuh <jschuh@chromium.org> 30904 30905 Unreviewed. 30906 30907 Adding myself to the committers list. 30908 30909 * Scripts/webkitpy/common/config/committers.py: 30910 309112010-06-19 Sam Weinig <sam@webkit.org> 30912 30913 Reviewed by Anders Carlsson. 30914 30915 Fix for https://bugs.webkit.org/show_bug.cgi?id=40882 30916 Add ability to have a WebProcess per WebContext. 30917 30918 Move to use new shared contexts API. 30919 30920 * MiniBrowser/mac/AppDelegate.h: 30921 * MiniBrowser/mac/AppDelegate.m: 30922 (-[BrowserAppDelegate init]): 30923 (-[BrowserAppDelegate getCurrentPageNamespace]): 30924 (-[BrowserAppDelegate validateMenuItem:]): 30925 (-[BrowserAppDelegate _setProcessModel:]): 30926 (-[BrowserAppDelegate setSharedProcessProcessModel:]): 30927 (-[BrowserAppDelegate setSharedThreadProcessModel:]): 30928 * MiniBrowser/win/BrowserView.cpp: 30929 (BrowserView::create): 30930 309312010-06-02 Robert Hogan <robert@webkit.org> 30932 30933 Reviewed by Adam Barth. 30934 30935 [Qt] Support evaluateScriptInIsolatedWorld() 30936 30937 https://bugs.webkit.org/show_bug.cgi?id=40079 30938 30939 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 30940 (LayoutTestController::evaluateScriptInIsolatedWorld): 30941 * DumpRenderTree/qt/LayoutTestControllerQt.h: 30942 309432010-06-18 Dimitri Glazkov <dglazkov@chromium.org> 30944 30945 Reviewed by Darin Adler. 30946 30947 Add three more non-core Chromium builders to start testing DumpRenderTree. 30948 https://bugs.webkit.org/show_bug.cgi?id=40335 30949 30950 * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders. 30951 309522010-06-18 Drew Wilson <atwilson@chromium.org> 30953 30954 Reviewed by Darin Fisher. 30955 30956 [Chromium] Plumbing for top-level frame names 30957 https://bugs.webkit.org/show_bug.cgi?id=40430 30958 30959 * DumpRenderTree/chromium/WebViewHost.cpp: 30960 (WebViewHost::reset): 30961 Changed obsolete call to clearName() to use setName(WebString()) instead. 30962 309632010-06-18 Sam Weinig <weinig@apple.com> 30964 30965 Rolling http://trac.webkit.org/changeset/61297 back in. 30966 30967 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: 30968 * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed. 30969 * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added. 30970 (_didClearWindow): 30971 (_didCreatePage): 30972 (WKBundleInitialize): 30973 309742010-06-18 Alexey Proskuryakov <ap@apple.com> 30975 30976 Reviewed by Darin Adler. 30977 30978 https://bugs.webkit.org/show_bug.cgi?id=40803 30979 TestNetscapePlugin has an incorrect implementation of "property" property 30980 30981 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't 30982 pass a static string back, it's going to be released by NPAPI implementation. 30983 309842010-06-18 Leandro Pereira <leandro@profusion.mobi> 30985 30986 Unreviewed. 30987 30988 Adding myself to the committers list. 30989 30990 * Scripts/webkitpy/common/config/committers.py: 30991 309922010-06-17 Tony Chang <tony@chromium.org> 30993 30994 Reviewed by Kent Tamura. 30995 30996 [chromium] cleanup redundant DEPS value and remove buildbot cleanup code 30997 https://bugs.webkit.org/show_bug.cgi?id=40615 30998 30999 * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts 31000 310012010-06-17 Ada Chan <adachan@apple.com> 31002 31003 Rolling out http://trac.webkit.org/changeset/61297 due to build errors. 31004 31005 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: 31006 * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c. 31007 * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed. 31008 310092010-06-17 Darin Adler <darin@apple.com> 31010 31011 One more try at fix for Chromium build. 31012 31013 * DumpRenderTree/chromium/TestShell.cpp: 31014 (TestShell::TestShell): Use set again instead of =. 31015 310162010-06-17 Darin Adler <darin@apple.com> 31017 31018 Fix Chromium build. 31019 31020 I didn't realize that neither Chromium nor Qt share the DumpRenderTree 31021 code with all the other platforms! Wow, that should be fixed at some point. 31022 31023 * DumpRenderTree/chromium/TestShell.cpp: 31024 (TestShell::TestShell): Changed back to using "new". 31025 * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr. 31026 310272010-06-17 Simon Hausmann <simon.hausmann@nokia.com> 31028 31029 Unreviewed Qt build fix. 31030 31031 LayoutTestController in the Qt DRT is not using refs :) 31032 31033 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 31034 (WebCore::DumpRenderTree::DumpRenderTree): 31035 310362010-06-17 Darin Adler <darin@apple.com> 31037 31038 Reviewed by Sam Weinig. 31039 31040 Use adoptRef and create functions in more code paths 31041 https://bugs.webkit.org/show_bug.cgi?id=40760 31042 31043 * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr. 31044 31045 * DumpRenderTree/LayoutTestController.cpp: 31046 (LayoutTestController::create): Added. 31047 * DumpRenderTree/LayoutTestController.h: Declare the create function. 31048 31049 * DumpRenderTree/chromium/TestShell.cpp: 31050 (TestShell::TestShell): Use create instead of new. 31051 * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr. 31052 31053 * DumpRenderTree/gtk/DumpRenderTree.cpp: 31054 (runTest): Use RefPtr and create instead of OwnPtr and new. 31055 31056 * DumpRenderTree/mac/DumpRenderTree.mm: 31057 (runTest): Use RefPtr and create instead of OwnPtr and new. 31058 31059 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 31060 (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef 31061 instead of new. 31062 31063 * DumpRenderTree/win/DumpRenderTree.cpp: 31064 (runTest): Use RefPtr and create instead of OwnPtr and new. 31065 31066 * DumpRenderTree/wx/DumpRenderTreeWx.cpp: 31067 (runTest): Use RefPtr and create instead of OwnPtr and new. 31068 (MyApp::OnInit): Removed unneeded code to delete the layout 31069 test controller. This is done during each test. 31070 310712010-06-17 Kent Tamura <tkent@chromium.org> 31072 31073 Reviewed by Shinichiro Hamaji. 31074 31075 [DRT/Chromium] Fix a bug of Windows pixel tests 31076 https://bugs.webkit.org/show_bug.cgi?id=40763 31077 31078 * DumpRenderTree/chromium/TestEventPrinter.cpp: 31079 (TestShellPrinter::handleImage): 31080 310812010-06-16 Kent Tamura <tkent@chromium.org> 31082 31083 Reviewed by Shinichiro Hamaji. 31084 31085 [DRT/Chromium] Fix crash on Mac Release 31086 https://bugs.webkit.org/show_bug.cgi?id=40759 31087 31088 * DumpRenderTree/chromium/WebViewHost.cpp: 31089 (WebViewHost::paintRect): We should not use m_canvas directly because 31090 it is created lazily in canvas(). 31091 310922010-06-16 Kevin Ollivier <kevino@theolliviers.com> 31093 31094 [wx] Build fix after new method addition. 31095 31096 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 31097 (LayoutTestController::pageProperty): 31098 310992010-06-16 Kent Tamura <tkent@chromium.org> 31100 31101 Reviewed by Dimitri Glazkov. 31102 31103 [DRT/Chromium] Set current working directory for each of tests 31104 https://bugs.webkit.org/show_bug.cgi?id=40668 31105 31106 This change fixes tests with eventSender.beginDragWithFiles(). 31107 31108 * DumpRenderTree/chromium/DumpRenderTree.cpp: 31109 (runTest): 31110 311112010-06-16 Martin Robinson <mrobinson@igalia.com> 31112 31113 Reviewed by Gustavo Noronha Silva. 31114 31115 [GTK] r60803 broke media/controls-drag-timebar.html 31116 https://bugs.webkit.org/show_bug.cgi?id=40269 31117 31118 Only queue events while the mouse button is down, if drag mode is enabled. Some 31119 tests may disable drag mode, to prevent the queuing of events in this situation. 31120 31121 * DumpRenderTree/gtk/EventSender.cpp: 31122 (sendOrQueueEvent): Only queue events here if dragMode is true. 31123 311242010-06-16 Martin Robinson <mrobinson@igalia.com> 31125 31126 Reviewed by Gustavo Noronha Silva. 31127 31128 [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT 31129 https://bugs.webkit.org/show_bug.cgi?id=40600 31130 31131 * DumpRenderTree/gtk/EventSender.cpp: 31132 (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME. 31133 311342010-06-16 Adam Barth <abarth@webkit.org> 31135 31136 Reviewed by Dimitri Glazkov. 31137 31138 Add a hidden land-cowboy command to webkit-patch to help land quick 31139 build fixes. 31140 31141 * Scripts/webkitpy/tool/commands/download.py: 31142 * Scripts/webkitpy/tool/steps/preparechangelog.py: 31143 311442010-06-16 Adam Roben <aroben@apple.com> 31145 31146 Convert console messages to UTF-8 before printing them 31147 31148 Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234): 31149 http/tests/security/xssAuditor/embed-tag-null-char.html and 31150 http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on 31151 Windows. (I can't test the fix because Apache is crashing on my 31152 computer.) 31153 31154 Reviewed by Alexey Proskuryakov. 31155 31156 * DumpRenderTree/win/DumpRenderTree.cpp: 31157 (toUTF8): Extracted the code into an overload that takes a wide string 31158 and a length, then added an overload that takes a wstring. 31159 31160 * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8 31161 overload. 31162 31163 * DumpRenderTree/win/UIDelegate.cpp: 31164 (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to 31165 UTF-8 instead of letting printf convert to the current code page. 31166 311672010-06-16 Drew Wilson <atwilson@chromium.org> 31168 31169 Reviewed by Kent Tamura. 31170 31171 [Chromium] Plumbing for top-level frame names 31172 https://bugs.webkit.org/show_bug.cgi?id=40430 31173 31174 * DumpRenderTree/chromium/WebViewHost.cpp: 31175 (WebViewHost::createView): 31176 Migrate to new createView() API. 31177 * DumpRenderTree/chromium/WebViewHost.h: 31178 Remove obsolete createView() methods, add new createView() API that takes a frameName parameter. 31179 311802010-06-16 Diego Gonzalez <diegohcg@webkit.org> 31181 31182 Reviewed by Kenneth Rohde Christiansen. 31183 31184 [Qt] Scroll wheel event support to graphics based DRT 31185 https://bugs.webkit.org/show_bug.cgi?id=40577 31186 31187 * DumpRenderTree/qt/EventSenderQt.cpp: 31188 (EventSender::continuousMouseScrollBy): 31189 (EventSender::createGraphicsSceneWheelEvent): 31190 * DumpRenderTree/qt/EventSenderQt.h: 31191 311922010-06-16 Adam Roben <aroben@apple.com> 31193 31194 Remove a stray newline from the Windows version of TestNetscapePlugin 31195 31196 Reviewed by Alexey Proskuryakov. 31197 31198 Fixes <http://webkit.org/b/40728> 31199 plugins/geturlnotify-during-document-teardown.html fails on Windows 31200 31201 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 31202 (NPP_Destroy): Removed extra newline that the Mac version doesn't 31203 have. 31204 312052010-06-16 Adam Roben <aroben@apple.com> 31206 31207 Respect LayoutTestController::isPrinting on Windows 31208 31209 This gets some printing tests closer to passing (like 31210 printing/page-rule-in-media-query.html). 31211 31212 Fixes <http://webkit.org/b/40727>. 31213 31214 Reviewed by Dan Bernstein. 31215 31216 * DumpRenderTree/win/DumpRenderTree.cpp: 31217 (dump): Pass LayoutTestController::isPrinting to 31218 IWebFramePrivate::renderTreeAsExternalRepresentation. 31219 312202010-06-15 Adam Barth <abarth@webkit.org> 31221 31222 Reviewed by Eric Seidel. 31223 31224 Enable HTML5 lexer 31225 https://bugs.webkit.org/show_bug.cgi?id=40650 31226 31227 * DumpRenderTree/mac/DumpRenderTree.mm: 31228 (initializeGlobalsFromCommandLineOptions): 31229 312302010-06-10 Yuzo Fujishima <yuzo@google.com> 31231 31232 Reviewed by Shinichiro Hamaji. 31233 31234 Implement render style selection for pages to support CSS3 Paged Media. 31235 https://bugs.webkit.org/show_bug.cgi?id=35961 31236 31237 * DumpRenderTree/LayoutTestController.cpp: 31238 (parsePagePropertyParameters): 31239 (pagePropertyCallback): 31240 (LayoutTestController::staticFunctions): 31241 * DumpRenderTree/LayoutTestController.h: 31242 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 31243 (LayoutTestController::pageProperty): 31244 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 31245 (LayoutTestController::pageProperty): 31246 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 31247 (LayoutTestController::pageProperty): 31248 312492010-06-15 Sam Weinig <sam@webkit.org> 31250 31251 Reviewed by Anders Carlsson. 31252 31253 Fix for https://bugs.webkit.org/show_bug.cgi?id=40630 31254 WebKit2: Add mechanism to inject code into the WebProcess on startup 31255 31256 Add initial InjectedBundle support. 31257 31258 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: 31259 * MiniBrowser/WebBundle-Info.plist: Added. 31260 Add test InjectedBundle to the project. 31261 31262 * MiniBrowser/mac/AppDelegate.m: 31263 (-[BrowserAppDelegate init]): 31264 Get the path to the WebBundle from the the main bundle and pass it to the new 31265 WKContextCreateWithInjectedBundlePath function. 31266 31267 * MiniBrowser/mac/BrowserWindowController.m: 31268 (_didChangeProgress): 31269 Fix the build. This has been broken for a while. 31270 31271 * MiniBrowser/mac/WebBundle: Added. 31272 * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added. 31273 (_didCreatePage): 31274 (WKBundleInitialize): 31275 Add really basic InjectedBundle. 31276 31277 * MiniBrowser/win/BrowserView.cpp: 31278 (BrowserView::create): 31279 Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code. 31280 312812010-06-15 Dumitru Daniliuc <dumi@chromium.org> 31282 31283 Reviewed by Darin Adler. 31284 31285 Adding myself to the reviewers list. 31286 https://bugs.webkit.org/show_bug.cgi?id=40693 31287 31288 * Scripts/webkitpy/common/config/committers.py: 31289 312902010-06-15 Martin Robinson <mrobinson@igalia.com> 31291 31292 Reviewed by Xan Lopez. 31293 31294 Switch to using GIO methods instead of realpath in GtkLauncher to determine 31295 the file URI. This should remove warnings about realpath being undefined 31296 when compiling with '-ansi'. 31297 31298 * GtkLauncher/main.c: 31299 (filenameToURL): Use GIO instead of realpath to determine file URI. 31300 313012010-06-15 Adam Roben <aroben@apple.com> 31302 31303 Remove the redundant set-apple-windows-environment-variables script 31304 31305 Apparently update-webkit does this for you these days. 31306 31307 Rubber-stamped by Steve Falkenburg. 31308 31309 * Scripts/set-apple-windows-environment-variables: Removed. 31310 313112010-06-14 Adam Roben <aroben@apple.com> 31312 31313 Add a script to set the WebKitOutputDir and WebKitLibrariesDir 31314 environment variables 31315 31316 Fixes <http://webkit.org/b/40595>. 31317 31318 Reviewed by Steve Falkenburg. 31319 31320 * Scripts/set-apple-windows-environment-variables: Added. 31321 (to_windows_path): Passes the passed-in path through cygpath to 31322 generate a Windows-style path. 31323 (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment 31324 variables to their defaults, if they aren't already set. 31325 313262010-06-14 Adam Roben <aroben@apple.com> 31327 31328 Speed up run-safari/debug-safari on Windows 31329 31330 Fixes <http://webkit.org/b/40586>. 31331 31332 Reviewed by Steve Falkenburg. 31333 31334 * Scripts/webkitdirs.pm: 31335 (runSafari): When debugging, set up the environment to run Safari 31336 using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to 31337 actually launch the debugger. When not debugging, just run WebKit.exe 31338 and it will do the rest for us. 31339 313402010-06-15 Diego Gonzalez <diegohcg@webkit.org> 31341 31342 Reviewed by Kenneth Rohde Christiansen. 31343 31344 [Qt] DRT EventSender support to graphics context events 31345 https://bugs.webkit.org/show_bug.cgi?id=40324 31346 31347 * DumpRenderTree/qt/EventSenderQt.cpp: 31348 (EventSender::contextClick): 31349 313502010-06-14 Tony Chang <tony@chromium.org> 31351 31352 Reviewed by Darin Fisher. 31353 31354 [chromium] checkout chromium third_party directly 31355 https://bugs.webkit.org/show_bug.cgi?id=40556 31356 31357 * Scripts/update-webkit-chromium: some migration code for the bots 31358 313592010-06-14 Alexey Proskuryakov <ap@apple.com> 31360 31361 Chromium build fix. 31362 31363 * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently 31364 named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE. 31365 313662010-06-14 Alexey Proskuryakov <ap@apple.com> 31367 31368 Reviewed by Darin Adler. 31369 31370 https://bugs.webkit.org/show_bug.cgi?id=40529 31371 eventSender.keyDown("delete") incorrectly sends a backspace on some platforms 31372 31373 * DumpRenderTree/mac/EventSendingController.mm: 31374 (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken 31375 event for "delete" - it had virtual key code from forward delete, and text from backspace. 31376 Fixed "delete" to mean forward delete. 31377 31378 * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): 31379 * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback): 31380 * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): 31381 Mac DRT confusion has propagated to other platforms, fixing those. 31382 313832010-06-14 Martin Robinson <mrobinson@igalia.com> 31384 31385 Reviewed by Xan Lopez. 31386 31387 Small GtkLauncher build fix for some systems. 31388 31389 * GtkLauncher/main.c: Add <limit.h> include. 31390 313912010-06-14 Mahesh Kulkarni <mahesh.kulkarni@nokia.com> 31392 31393 Reviewed by Laszlo Gombos. 31394 31395 [Qt] navigator.geolocation support for Qt port 31396 https://bugs.webkit.org/show_bug.cgi?id=39724 31397 31398 Implementation for geolocation cases to DumpRenderTreeQt 31399 31400 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 31401 (WebCore::WebPage::allowGeolocationRequest): 31402 * DumpRenderTree/qt/DumpRenderTreeQt.h: 31403 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 31404 (LayoutTestController::setGeolocationPermission): 31405 (LayoutTestController::setMockGeolocationError): 31406 (LayoutTestController::setMockGeolocationPosition): 31407 * DumpRenderTree/qt/LayoutTestControllerQt.h: 31408 (LayoutTestController::isGeolocationPermissionSet): 31409 (LayoutTestController::geolocationPermission): 31410 314112010-06-13 Nathan Lawrence <nlawrence@apple.com> 31412 31413 Reviewed by Darin Adler. 31414 31415 Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to 31416 be a way of overwriting the Xcode system path. Making 31417 $WEBKITOUTPUTDIR take precedence over the system default would make 31418 this possible. 31419 31420 * Scripts/webkitdirs.pm: 31421 314222010-06-13 Chris Fleizach <cfleizach@apple.com> 31423 31424 Reviewed by Darin Adler. 31425 31426 AX: link won't return linked element if URL contains # 31427 https://bugs.webkit.org/show_bug.cgi?id=40192 31428 31429 * DumpRenderTree/AccessibilityUIElement.cpp: 31430 (linkedUIElementAtIndexCallback): 31431 (AccessibilityUIElement::getJSClass): 31432 * DumpRenderTree/AccessibilityUIElement.h: 31433 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 31434 (AccessibilityUIElement::linkedUIElementAtIndex): 31435 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 31436 (AccessibilityUIElement::linkedUIElementAtIndex): 31437 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 31438 (AccessibilityUIElement::linkedUIElementAtIndex): 31439 314402010-06-13 Adam Barth <abarth@webkit.org> 31441 31442 Reviewed by Darin Adler. 31443 31444 webkit-patch should add a bug URL to ChangeLogs if they don't have one yet 31445 https://bugs.webkit.org/show_bug.cgi?id=39550 31446 31447 This can cause an extra request to bugs.webkit.org durig upload, but it 31448 shouldn't be too bad. Also, this won't work if you remove the 31449 boilerplate created by prepare-ChangeLog. 31450 31451 * Scripts/webkitpy/common/checkout/changelog.py: 31452 * Scripts/webkitpy/common/checkout/changelog_unittest.py: 31453 * Scripts/webkitpy/common/net/bugzilla.py: 31454 * Scripts/webkitpy/tool/steps/abstractstep.py: 31455 * Scripts/webkitpy/tool/steps/preparechangelog.py: 31456 * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added. 31457 314582010-06-08 Robert Hogan <robert@webkit.org> 31459 31460 Reviewed by Eric Seidel. 31461 31462 [Qt] Add support for callShouldCloseOnWebView() to DRT 31463 https://bugs.webkit.org/show_bug.cgi?id=40330 31464 31465 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 31466 (LayoutTestController::callShouldCloseOnWebView): 31467 * DumpRenderTree/qt/LayoutTestControllerQt.h: 31468 (LayoutTestController::setCallCloseOnWebViews): 31469 314702010-06-12 Eric Seidel <eric@webkit.org> 31471 31472 Reviewed by Daniel Bates. 31473 31474 do-webcore-rename should have a --verbose option 31475 https://bugs.webkit.org/show_bug.cgi?id=40497 31476 31477 * Scripts/do-webcore-rename: 31478 - Unified how we handle skipping files/directories 31479 this will allow us to "black list" certain files and 31480 directories when performing renames. 31481 - Made do-webcore-rename log what it's skipping when passed --verbose. 31482 314832010-06-12 Darin Adler <darin@apple.com> 31484 31485 * Scripts/run-bindings-tests: Fixed a typo in a message. 31486 314872010-06-12 Kent Tamura <tkent@chromium.org> 31488 31489 Reviewed by Dimitri Glazkov. 31490 31491 [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout 31492 https://bugs.webkit.org/show_bug.cgi?id=40402 31493 31494 _build_path() of each Chromium port check existence of build path 31495 of Chromium checkout first, then check existence of build path of 31496 WebKit-only checkout. 31497 31498 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 31499 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 31500 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 31501 315022010-06-12 Robert Hogan <robert@webkit.org> 31503 31504 Reviewed by Kenneth Rohde Christiansen. 31505 31506 [Qt] Back-forward list dumping is incorrect 31507 31508 https://bugs.webkit.org/show_bug.cgi?id=36392 31509 31510 Support dumping child history items in DRT. 31511 31512 Unskip: 31513 31514 fast/loader/frame-src-change-added-to-history.html 31515 fast/loader/frame-src-change-not-added-to-history.html 31516 fast/loader/frame-location-change-not-added-to-history.html 31517 31518 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 31519 (WebCore::dumpHistoryItem): 31520 315212010-06-10 Ojan Vafai <ojan@chromium.org> 31522 31523 Reviewed by Eric Seidel. 31524 31525 upload all patches that lack in-rietveld to rietveld 31526 https://bugs.webkit.org/show_bug.cgi?id=40444 31527 31528 If it's a patch, then we'll try to upload it as long as it 31529 doesn't have in-rietveld set. No longer set in-rietveld? since 31530 it's not needed. 31531 31532 * Scripts/webkitpy/common/net/bugzilla.py: 31533 315342010-06-10 Ojan Vafai <ojan@chromium.org> 31535 31536 Reviewed by Darin Fisher. 31537 31538 Fix rietveld upload when message length > 100 characters 31539 https://bugs.webkit.org/show_bug.cgi?id=40457 31540 31541 * Scripts/webkitpy/common/net/rietveld.py: 31542 315432010-06-11 Yael Aharon <yael.aharon@nokia.com> 31544 31545 Reviewed by Laszlo Gombos. 31546 31547 [Qt] There should be a way to enable popups in QtTestBrowser 31548 https://bugs.webkit.org/show_bug.cgi?id=40427 31549 31550 * QtTestBrowser/main.cpp: 31551 (LauncherWindow::toggleJavascriptCanOpenWindows): 31552 (LauncherWindow::createChrome): 31553 315542010-06-10 Adam Barth <abarth@webkit.org> 31555 31556 Reviewed by Daniel Bates. 31557 31558 Make SheriffBot more chatty 31559 https://bugs.webkit.org/show_bug.cgi?id=40463 31560 31561 People seem to like to talk to SheriffBot, so let's make him chat back. 31562 31563 * Scripts/webkitpy/thirdparty/__init__.py: 31564 * Scripts/webkitpy/tool/bot/irc_command.py: 31565 * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added. 31566 * Scripts/webkitpy/tool/bot/sheriffircbot.py: 31567 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: 31568 315692010-06-10 Brian Weinstein <bweinstein@apple.com> 31570 31571 Reviewed by Darin Adler. 31572 31573 Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server. 31574 31575 Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist, 31576 and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking 31577 WEXITSTATUS on $result instead of just comparing $result to 0. 31578 31579 * Scripts/update-webkit-auxiliary-libs: 31580 315812010-06-10 Ojan Vafai <ojan@chromium.org> 31582 31583 Reviewed by Alexey Proskuryakov. 31584 31585 don't use Exception.message as it's deprecated in python 2.6+ 31586 https://bugs.webkit.org/show_bug.cgi?id=40449 31587 31588 * Scripts/webkitpy/tool/commands/queues.py: 31589 315902010-06-10 Ojan Vafai <ojan@chromium.org> 31591 31592 Reviewed by Adam Barth. 31593 31594 fix handle_script_error in rietveld upload queue and add testing for handle_script_error 31595 https://bugs.webkit.org/show_bug.cgi?id=40436 31596 31597 * Scripts/webkitpy/common/system/outputcapture.py: 31598 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 31599 * Scripts/webkitpy/tool/commands/queues.py: 31600 * Scripts/webkitpy/tool/commands/queues_unittest.py: 31601 * Scripts/webkitpy/tool/commands/queuestest.py: 31602 * Scripts/webkitpy/tool/mocktool.py: 31603 316042010-06-10 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com> 31605 31606 Reviewed by Simon Hausmann. 31607 31608 [Qt] *All* WebGL layout tests fail! 31609 https://bugs.webkit.org/show_bug.cgi?id=40296 31610 31611 Added test for WebKitWebGLEnabled to 31612 LayoutTestController::overridePreference(). 31613 31614 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 31615 (LayoutTestController::overridePreference): 31616 316172010-06-10 Diego Gonzalez <diegohcg@webkit.org> 31618 31619 Reviewed by Kenneth Rohde Christiansen. 31620 31621 [Qt] DRT EventSender support to graphics mouse events activation 31622 https://bugs.webkit.org/show_bug.cgi?id=40017 31623 31624 * DumpRenderTree/qt/EventSenderQt.cpp: 31625 (EventSender::mouseDown): 31626 (EventSender::mouseUp): 31627 (EventSender::mouseMoveTo): 31628 (EventSender::keyDown): 31629 (EventSender::contextClick): 31630 (EventSender::sendTouchEvent): 31631 (EventSender::sendOrQueueEvent): 31632 (EventSender::eventFilter): 31633 (EventSender::createGraphicsSceneMouseEvent): 31634 (EventSender::sendEvent): 31635 * DumpRenderTree/qt/EventSenderQt.h: 31636 (EventSender::isGraphicsBased): 31637 316382010-06-09 Adam Barth <abarth@webkit.org> 31639 31640 Reviewed by Ojan Vafai. 31641 31642 webkit-patch upload fails for security bugs because there's no rietveld flag 31643 https://bugs.webkit.org/show_bug.cgi?id=40309 31644 31645 There's probably a more elegant way of seeing whether the form control 31646 exists, but this seems to work. 31647 31648 * Scripts/webkitpy/common/net/bugzilla.py: 31649 316502010-06-09 Ojan Vafai <ojan@chromium.org> 31651 31652 Reviewed by Adam Barth. 31653 31654 make rietveld upload faster and avoid posting to bug on errors 31655 https://bugs.webkit.org/show_bug.cgi?id=40389 31656 31657 Only grab the first item of the upload queue instead of trying 31658 to compute the whole list upfront (which is O(n) bugzilla lookups!). 31659 31660 Also, don't post comments to the bug when uploading fails. 31661 31662 * Scripts/webkitpy/common/net/bugzilla.py: 31663 * Scripts/webkitpy/tool/commands/queues.py: 31664 * Scripts/webkitpy/tool/commands/queues_unittest.py: 31665 * Scripts/webkitpy/tool/commands/stepsequence.py: 31666 * Scripts/webkitpy/tool/mocktool.py: 31667 316682010-06-09 Ojan Vafai <ojan@chromium.org> 31669 31670 Reviewed by Adam Barth. 31671 31672 Rietveld upload queue fails when setting in-rietveld flag 31673 https://bugs.webkit.org/show_bug.cgi?id=40371 31674 31675 Make the comment arguments to set_flag_on_attachment optional 31676 and add it to the MockBugzilla. 31677 31678 * Scripts/webkitpy/common/net/bugzilla.py: 31679 * Scripts/webkitpy/tool/bot/queueengine.py: 31680 * Scripts/webkitpy/tool/commands/download_unittest.py: 31681 * Scripts/webkitpy/tool/commands/queues.py: 31682 * Scripts/webkitpy/tool/commands/queues_unittest.py: 31683 * Scripts/webkitpy/tool/mocktool.py: 31684 316852010-06-09 Kenneth Russell <kbr@google.com> 31686 31687 Reviewed by Dimitri Glazkov. 31688 31689 Rename FloatArray to Float32Array 31690 https://bugs.webkit.org/show_bug.cgi?id=40323 31691 31692 Used do-webcore-rename to perform renaming. Manually undid 31693 incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp, 31694 WebCore/manual-tests/resources/ArrayParameterTestApplet.java and 31695 ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran 31696 all layout tests on Safari; built Chromium and ran selected WebGL 31697 tests. 31698 31699 * Scripts/do-webcore-rename: 31700 317012010-06-08 Tony Chang <tony@chromium.org> 31702 31703 Reviewed by David Levin. 31704 31705 [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out 31706 https://bugs.webkit.org/show_bug.cgi?id=40285 31707 31708 * Scripts/webkitdirs.pm: 31709 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 31710 317112010-06-03 Roland Steiner <rolandsteiner@chromium.org> 31712 31713 Reviewed by Tamura Kent. 31714 31715 Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT 31716 https://bugs.webkit.org/show_bug.cgi?id=40052 31717 31718 Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907 31719 31720 * DumpRenderTree/DumpRenderTree.gypi: 31721 * DumpRenderTree/chromium/TestShellWin.cpp: 31722 (platformInit): 31723 * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added. 31724 (WebKit::): 31725 (WebKit::WebThemeControlDRT::WebThemeControlDRT): 31726 (WebKit::WebThemeControlDRT::~WebThemeControlDRT): 31727 (WebKit::WebThemeControlDRT::box): 31728 (WebKit::WebThemeControlDRT::line): 31729 (WebKit::WebThemeControlDRT::triangle): 31730 (WebKit::WebThemeControlDRT::roundRect): 31731 (WebKit::WebThemeControlDRT::oval): 31732 (WebKit::WebThemeControlDRT::circle): 31733 (WebKit::WebThemeControlDRT::nestedBoxes): 31734 (WebKit::WebThemeControlDRT::markState): 31735 (WebKit::WebThemeControlDRT::draw): 31736 (WebKit::WebThemeControlDRT::drawTextField): 31737 (WebKit::WebThemeControlDRT::drawProgressBar): 31738 * DumpRenderTree/chromium/WebThemeControlDRT.h: Added. 31739 (WebKit::WebThemeControlDRT::): 31740 * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added. 31741 (WebKit::): 31742 (WebKit::WebThemeEngineDRT::paintButton): 31743 (WebKit::WebThemeEngineDRT::paintMenuList): 31744 (WebKit::WebThemeEngineDRT::paintScrollbarArrow): 31745 (WebKit::WebThemeEngineDRT::paintScrollbarThumb): 31746 (WebKit::WebThemeEngineDRT::paintScrollbarTrack): 31747 (WebKit::WebThemeEngineDRT::paintTextField): 31748 (WebKit::WebThemeEngineDRT::paintTrackbar): 31749 (WebKit::WebThemeEngineDRT::paintProgressBar): 31750 * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added. 31751 (WebKit::WebThemeEngineDRT::WebThemeEngineDRT): 31752 317532010-06-08 Sheriff Bot <webkit.review.bot@gmail.com> 31754 31755 Unreviewed, rolling out r60878. 31756 http://trac.webkit.org/changeset/60878 31757 https://bugs.webkit.org/show_bug.cgi?id=40349 31758 31759 broke linux build (Requested by tony^work on #webkit). 31760 31761 * Scripts/webkitdirs.pm: 31762 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 31763 317642010-06-08 Tony Chang <tony@chromium.org> 31765 31766 Reviewed by David Levin. 31767 31768 [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out 31769 https://bugs.webkit.org/show_bug.cgi?id=40285 31770 31771 * Scripts/webkitdirs.pm: 31772 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 31773 317742010-06-08 Kenneth Russell <kbr@google.com> 31775 31776 Unreviewed, build fix. 31777 31778 Fix build breakage from 38145 31779 https://bugs.webkit.org/show_bug.cgi?id=40346 31780 31781 The fix for bug 38145 broke the Chromium Win build because 31782 Microsoft's cmath doesn't define log2. Suggested fix by zmo is to 31783 change log2(x) to log(x) / log(2). Built and ran WebGL layout 31784 tests in Safari on Mac OS X. Changed download mirrors for 31785 python-irclib to working ones. 31786 31787 * Scripts/webkitpy/thirdparty/__init__.py: 31788 317892010-06-08 Fumitoshi Ukai <ukai@chromium.org> 31790 31791 Reviewed by Eric Seidel. 31792 31793 old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests 31794 https://bugs.webkit.org/show_bug.cgi?id=39058 31795 31796 * Scripts/old-run-webkit-tests: 31797 use sourceDir() to find ensure-valid-python in checkPythonVersion() 31798 317992010-06-08 Andras Becsi <abecsi@webkit.org> 31800 31801 Unreviewed buildfix after r60479. 31802 31803 [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK 31804 versions other than 2.17.3. 31805 31806 * DumpRenderTree/gtk/EventSender.cpp: 31807 (getRootCoords): 31808 318092010-06-07 Martin Robinson <mrobinson@igalia.com> 31810 31811 Reviewed by Oliver Hunt. 31812 31813 [GTK] Mouse movement should not trigger a replay of saved events in the event sender 31814 https://bugs.webkit.org/show_bug.cgi?id=40267 31815 31816 When a mouse button is down, automatically queue mouse motion events and 31817 do not play them back until the mouse button is released. This matches the 31818 behavior of other ports' EventSenders. 31819 31820 * DumpRenderTree/gtk/EventSender.cpp: 31821 (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion. 31822 (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true. 31823 318242010-06-07 Nikolas Zimmermann <nzimmermann@rim.com> 31825 31826 Reviewed by Sam Weinig. 31827 31828 Add CPP bindings generator 31829 https://bugs.webkit.org/show_bug.cgi?id=38279 31830 31831 Integrate CPP bindings in run-bindings-tests. 31832 31833 * Scripts/run-bindings-tests: 31834 318352010-06-04 Tony Gentilcore <tonyg@chromium.org> 31836 31837 Reviewed by Ojan Vafai. 31838 31839 Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633. 31840 https://bugs.webkit.org/show_bug.cgi?id=40183 31841 31842 * Scripts/webkitpy/tool/steps/preparechangelog.py: 31843 318442010-06-04 Martin Robinson <mrobinson@igalia.com> 31845 31846 Unreviewed. 31847 31848 Add my new email and IRC nick to committers.py. 31849 31850 * Scripts/webkitpy/common/config/committers.py: 31851 318522010-06-04 Kinuko Yasuda <kinuko@chromium.org> 31853 31854 Unreviewed. 31855 31856 Revert changes in json_results_generator.py's _get_svn_revision. 31857 31858 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 31859 318602010-06-04 Martin Robinson <mrobinson@igalia.com> 31861 31862 Reviewed by Xan Lopez. 31863 31864 [GTK] GtkLauncher should support relative file paths 31865 https://bugs.webkit.org/show_bug.cgi?id=39944 31866 31867 Allow GtkLauncher to handle relative file paths passed via command-line arguments. 31868 31869 * GtkLauncher/main.c: 31870 (filename_to_url): Added. 31871 (main): Try to resolve arguments as relative file URLs first. 31872 318732010-06-04 Martin Robinson <mrobinson@igalia.com> 31874 31875 Reviewed by Xan Lopez. 31876 31877 [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly 31878 https://bugs.webkit.org/show_bug.cgi?id=40182 31879 31880 Instead of invoking signal handlers directly via g_signal_emit_by_name, call 31881 gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit 31882 without breaking DRT. 31883 31884 * DumpRenderTree/gtk/EventSender.cpp: 31885 (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly. 31886 (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event. 31887 318882010-06-04 Anders Carlsson <andersca@apple.com> 31889 31890 Reviewed by David Hyatt. 31891 31892 Make the editing/spelling/context-menu-suggestions.html test more robust 31893 https://bugs.webkit.org/show_bug.cgi?id=40178 31894 31895 Change the contextClick method to return an array of strings describing the context menu items. 31896 31897 * DumpRenderTree/mac/EventSendingController.mm: 31898 (+[EventSendingController isSelectorExcludedFromWebScript:]): 31899 (+[EventSendingController webScriptNameForSelector:]): 31900 (-[EventSendingController contextClick]): 31901 319022010-06-03 Kinuko Yasuda <kinuko@chromium.org> 31903 31904 Reviewed by Shinichiro Hamaji. 31905 31906 Clean up chromium-specific code from json_results_generator.py. 31907 https://bugs.webkit.org/show_bug.cgi?id=39665 31908 31909 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 31910 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 31911 * Scripts/webkitpy/layout_tests/port/base.py: 31912 * Scripts/webkitpy/layout_tests/port/chromium.py: 31913 319142010-06-04 Tony Gentilcore <tonyg@chromium.org> 31915 31916 Reviewed by Adam Barth. 31917 31918 Utilize new takeFirst() method where appropriate. 31919 https://bugs.webkit.org/show_bug.cgi?id=40089 31920 31921 * DumpRenderTree/chromium/EventSender.cpp: 31922 (EventSender::replaySavedEvents): 31923 * DumpRenderTree/chromium/LayoutTestController.cpp: 31924 (LayoutTestController::WorkQueue::processWork): 31925 (LayoutTestController::WorkQueue::reset): 31926 319272010-06-04 Yael Aharon <yael.aharon@nokia.com> 31928 31929 Reviewed by Simon Hausmann. 31930 31931 [Qt] QtTestLauncher should allow notifications by default. 31932 https://bugs.webkit.org/show_bug.cgi?id=40078 31933 31934 * QtTestBrowser/main.cpp: 31935 (NotificationsPermissionController::NotificationsPermissionController): 31936 (NotificationsPermissionController::checkPermission): 31937 (NotificationsPermissionController::requestPermission): 31938 (LauncherWindow::LauncherWindow): 31939 319402010-06-04 Tony Gentilcore <tonyg@chromium.org> 31941 31942 Reviewed by Adam Barth. 31943 31944 Detect whether the user's environment can open a browser. 31945 https://bugs.webkit.org/show_bug.cgi?id=40136 31946 31947 Some environments like cygwin silently fail webbrowser.open() causing 31948 webkit-patch upload not to display any diff. This detects environments 31949 where webbrowser.open() would fail by testing if webbrowser.get() 31950 raises an exception. 31951 31952 * Scripts/webkitpy/common/system/user.py: 31953 * Scripts/webkitpy/tool/mocktool.py: 31954 * Scripts/webkitpy/tool/steps/confirmdiff.py: 31955 319562010-06-03 Tony Gentilcore <tonyg@chromium.org> 31957 31958 Reviewed by David Levin. 31959 31960 Add dependencies required to link with VS Express 2005. 31961 https://bugs.webkit.org/show_bug.cgi?id=40038 31962 31963 Visual Studio implicitly links against these libs. 31964 VC++ Express does not. 31965 31966 * WebKitAPITest/WebKitAPITestCommon.vsprops: 31967 * WinLauncher/WinLauncher.vcproj: 31968 319692010-06-03 Fumitoshi Ukai <ukai@chromium.org> 31970 31971 Reviewed by David Levin. 31972 31973 bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py 31974 https://bugs.webkit.org/show_bug.cgi?id=40105 31975 31976 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 31977 - kill pywebsocket process when url is not alive and the process is not 31978 terminated, not to leave pywebsocket server running. 31979 - fix codecs.open parameters. 31980 319812010-06-03 Fumitoshi Ukai <ukai@chromium.org> 31982 31983 Reviewed by Alexey Proskuryakov. 31984 31985 old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests 31986 https://bugs.webkit.org/show_bug.cgi?id=39058 31987 31988 * Scripts/ensure-valid-python: 31989 - Perl 5.8 doesn't have File::Temp->newdir(). Use File::Temp->tempdir() instead. 31990 - Add --check-only and --help option. 31991 - --check-only option only checks python version and don't try to install Python 2.5. 31992 - Set executable bit. 31993 * Scripts/old-run-webkit-tests: 31994 - Check if it can run the websocket tests by calling ensure-valid-python --check-only. 31995 319962010-05-14 Ojan Vafai <ojan@chromium.org> 31997 31998 Reviewed by Adam Barth. 31999 32000 add a RietveldUploadQueue to upload in-rietveld? patches to rietveld 32001 https://bugs.webkit.org/show_bug.cgi?id=38918 32002 32003 Patches with in-rietveld? get uploaded to rietveld and get marked 32004 in-rietveld+. If the upload fails, they are marked in-rietveld- 32005 and an error is logged to the bug, like the commit-queue. 32006 32007 Also, get rid of --fancy-review and the ability to upload to rietveld 32008 using webkit-patch upload/post. 32009 32010 * Scripts/webkitpy/common/net/bugzilla.py: 32011 * Scripts/webkitpy/common/net/bugzilla_unittest.py: 32012 * Scripts/webkitpy/tool/commands/download.py: 32013 * Scripts/webkitpy/tool/commands/download_unittest.py: 32014 * Scripts/webkitpy/tool/commands/queues.py: 32015 * Scripts/webkitpy/tool/commands/queues_unittest.py: 32016 * Scripts/webkitpy/tool/commands/upload.py: 32017 * Scripts/webkitpy/tool/commands/upload_unittest.py: 32018 * Scripts/webkitpy/tool/mocktool.py: 32019 * Scripts/webkitpy/tool/steps/options.py: 32020 * Scripts/webkitpy/tool/steps/postcodereview.py: 32021 320222010-05-24 Ojan Vafai <ojan@chromium.org> 32023 32024 Reviewed by Chris Jerdonek. 32025 32026 many webkit-patch commands fail in a non-svn tracking git checkout 32027 https://bugs.webkit.org/show_bug.cgi?id=38156 32028 32029 If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master). 32030 If neither exists, then error out. This makes webkit-patch work 32031 for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit 32032 to checkout webkit. The fallback to master is for people who don't 32033 do the steps on that page for tracking svn. 32034 32035 * Scripts/webkitpy/common/checkout/scm.py: 32036 * Scripts/webkitpy/common/checkout/scm_unittest.py: 32037 320382010-06-03 Mike Fenton <mifenton@rim.com> 32039 32040 Unreviewed. 32041 32042 Reverse e-mail for myself in committers.py to correspond with bugzilla account. 32043 32044 * Scripts/webkitpy/common/config/committers.py: 32045 320462010-06-03 Pavel Feldman <pfeldman@chromium.org> 32047 32048 Reviewed by Yury Semikhatsky. 32049 32050 Web Inspector: a number of fixes that make InspectorController 32051 happy with null redirects. 32052 32053 https://bugs.webkit.org/show_bug.cgi?id=40109 32054 32055 * DumpRenderTree/gtk/DumpRenderTree.cpp: 32056 (runTest): 32057 * DumpRenderTree/mac/DumpRenderTree.mm: 32058 (runTest): 32059 * DumpRenderTree/win/DumpRenderTree.cpp: 32060 (runTest): 32061 320622010-06-02 Tasuku Suzuki <tasuku.suzuki@nokia.com> 32063 32064 Reviewed by Shinichiro Hamaji. 32065 32066 [Qt] Fix compilation with QT_NO_PROPERTIES 32067 https://bugs.webkit.org/show_bug.cgi?id=38324 32068 32069 * QtTestBrowser/main.cpp: 32070 (LauncherWindow::init): 32071 320722010-06-02 Diego Gonzalez <diegohcg@webkit.org> 32073 32074 Reviewed by Kenneth Rohde Christiansen. 32075 32076 [Qt] Make possible run DRT with QGraphicsWebView 32077 https://bugs.webkit.org/show_bug.cgi?id=40016 32078 32079 Make possible to use a environment variable for switching backend. 32080 Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt 32081 32082 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 32083 (WebCore::WebViewGraphicsBased::WebViewGraphicsBased): 32084 (WebCore::DumpRenderTree::DumpRenderTree): 32085 * DumpRenderTree/qt/DumpRenderTreeQt.h: 32086 (WebCore::DumpRenderTree::setGraphicsBased): 32087 (WebCore::DumpRenderTree::isGraphicsBased): 32088 (WebCore::WebViewGraphicsBased::graphicsView): 32089 (WebCore::WebViewGraphicsBased::setPage): 32090 * Scripts/old-run-webkit-tests: 32091 320922010-06-02 Csaba Osztrogonác <ossy@webkit.org> 32093 32094 Reviewed by Eric Seidel. 32095 32096 Slave lost shouldn't be recognized as build failed. 32097 https://bugs.webkit.org/show_bug.cgi?id=39282 32098 32099 * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green. 32100 * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost. 32101 321022010-06-01 Yael Aharon <yael.aharon@nokia.com> 32103 32104 Reviewed by Kenneth Rohde Christiansen. 32105 32106 [Qt] Fix the lifecycle of notification objects 32107 https://bugs.webkit.org/show_bug.cgi?id=40003 32108 32109 Remove the dependency of notifications on QWebPage. 32110 32111 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 32112 (WebCore::requestPermissionCallback): 32113 (WebCore::WebPage::WebPage): 32114 (WebCore::DumpRenderTree::requestPermission): 32115 * DumpRenderTree/qt/DumpRenderTreeQt.h: 32116 321172010-06-02 Sheriff Bot <webkit.review.bot@gmail.com> 32118 32119 Unreviewed, rolling out r60559. 32120 http://trac.webkit.org/changeset/60559 32121 https://bugs.webkit.org/show_bug.cgi?id=40055 32122 32123 It broke python unit test (Requested by Ossy on #webkit). 32124 32125 * Scripts/webkitpy/common/net/buildbot.py: 32126 321272010-06-02 Csaba Osztrogonác <ossy@webkit.org> 32128 32129 Reviewed by Eric Seidel. 32130 32131 Slave lost shouldn't be recognized as build failed. 32132 https://bugs.webkit.org/show_bug.cgi?id=39282 32133 32134 * Scripts/webkitpy/common/net/buildbot.py: 32135 321362010-06-02 Tony Gentilcore <tonyg@chromium.org> 32137 32138 Reviewed by Eric Seidel. 32139 32140 Fix crash caused when assigned_to is disabled 32141 https://bugs.webkit.org/show_bug.cgi?id=40039 32142 32143 * Scripts/webkitpy/common/net/bugzilla.py: 32144 321452010-06-02 Sterling Swigart <sswigart@google.com> 32146 32147 Reviewed by David Levin. 32148 32149 Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches. 32150 https://bugs.webkit.org/show_bug.cgi?id=39906 32151 32152 * Scripts/build-webkit: 32153 321542010-06-01 Raine Makelainen <raine.makelainen@nokia.com> 32155 32156 Reviewed by Simon Hausmann. 32157 32158 Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard. 32159 32160 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 32161 (WebCore::WebPage::WebPage): 32162 (WebCore::WebPage::resetSettings): 32163 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 32164 (LayoutTestController::setJavaScriptCanAccessClipboard): 32165 321662010-06-01 Alexey Proskuryakov <ap@apple.com> 32167 32168 Reviewed by Mark Rowe. 32169 32170 A nicer Tiger build fix. 32171 32172 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 32173 * DumpRenderTree/mac/Configurations/Base.xcconfig: 32174 Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig. 32175 321762010-06-01 Alexey Proskuryakov <ap@apple.com> 32177 32178 A real Tiger build fix. 32179 32180 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS 32181 for all configurations, not just debug. 32182 321832010-06-01 Alexey Proskuryakov <ap@apple.com> 32184 32185 Tiger build fix. 32186 32187 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS. 32188 321892010-06-01 Martin Robinson <mrobinson@igalia.com> 32190 32191 Reviewed by Xan Lopez. 32192 32193 [GTK] Get more mouse tests passing 32194 https://bugs.webkit.org/show_bug.cgi?id=39040 32195 32196 Reproduce the logic from the Windows EventSender for mapping 32197 button numbers to GDK button numbers. Move this logic to the 32198 prepareMouseButtonEvent helper. 32199 32200 * DumpRenderTree/gtk/EventSender.cpp: 32201 (prepareMouseButtonEvent): Reproduce Windows logic. 32202 (contextClickCallback): Move mapping logic to prepareMouseButtonEvent. 32203 (mouseDownCallback): Ditto. 32204 (mouseUpCallback): Ditto. 32205 322062010-06-01 Alexey Proskuryakov <ap@apple.com> 32207 32208 Reviewed by Sam Weinig. 32209 32210 https://bugs.webkit.org/show_bug.cgi?id=39434 32211 REGRESSION (r59811): Geolocation callbacks cannot be created 32212 32213 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider. 32214 32215 * DumpRenderTree/mac/DumpRenderTree.mm: 32216 (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 32217 (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak 32218 into subsequent tests. 32219 32220 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 32221 (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider. 32222 (LayoutTestController::setMockGeolocationError): Ditto. 32223 32224 * DumpRenderTree/mac/MockGeolocationProvider.h: Added. 32225 * DumpRenderTree/mac/MockGeolocationProvider.mm: Added. 32226 (+[MockGeolocationProvider shared]): 32227 (-[MockGeolocationProvider dealloc]): 32228 (-[MockGeolocationProvider setPosition:]): 32229 (-[MockGeolocationProvider setError:]): 32230 (-[MockGeolocationProvider registerWebView:]): 32231 (-[MockGeolocationProvider unregisterWebView:]): 32232 (-[MockGeolocationProvider lastPosition]): 32233 (-[MockGeolocationProvider stopTimer]): 32234 (-[MockGeolocationProvider timerFired]): 32235 32236 * DumpRenderTree/mac/UIDelegate.mm: 32237 (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]): 32238 This delegate method must send a response. I'm not sure what the two-stage check is supposed 32239 to achieve, it seems unnecessary. 32240 322412010-05-12 Martin Robinson <mrobinson@igalia.com> 32242 32243 Reviewed by Xan Lopez. 32244 32245 [GTK] Double clicks cause three button press events 32246 https://bugs.webkit.org/show_bug.cgi?id=38853 32247 32248 WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS 32249 and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses 32250 the GDK event queue entirely, we simply do not send the extra event. 32251 32252 * DumpRenderTree/gtk/EventSender.cpp: 32253 (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately. 32254 (dispatchEvent): Properly handle GDK_3BUTTON_PRESS. 32255 322562010-06-01 Martin Robinson <mrobinson@igalia.com> 32257 32258 Not reviewed. Build fix. 32259 32260 Fix GTK+ build caused by a bad merge. 32261 32262 * DumpRenderTree/gtk/EventSender.cpp: 32263 (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here. 32264 322652010-06-01 Martin Robinson <mrobinson@webkit.org> 32266 32267 Reviewed by Xan Lopez. 32268 32269 [GTK] Double clicks cause three button press events 32270 https://bugs.webkit.org/show_bug.cgi?id=38853 32271 32272 Small EventSender cleanups. Consolidate some common code. Style fixes. 32273 32274 * DumpRenderTree/gtk/EventSender.cpp: 32275 (prepareMouseButtonEvent): Added. 32276 (contextClickCallback): Use prepareMouseButtonEvent. 32277 (mouseDownCallback): Use prepareMouseButtonEvent. 32278 (mouseUpCallback): Use prepareMouseButtonEvent. 32279 (mouseMoveToCallback): Small style fix. 32280 322812010-06-01 Martin Robinson <mrobinson@igalia.com> 32282 32283 Reviewed by Xan Lopez. 32284 32285 [GTK] Double clicks cause three button press events 32286 https://bugs.webkit.org/show_bug.cgi?id=38853 32287 32288 Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test 32289 to pause for a specified amount of time. It is used in the processing of drag- 32290 -and-drop data as well as to separate distinct mouse double-clicks in some tests. 32291 This patch enables tests that rely on the latter behavior to pass. 32292 32293 * DumpRenderTree/gtk/DumpRenderTree.cpp: 32294 (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame. 32295 * DumpRenderTree/gtk/EventSender.cpp: 32296 (leapForwardCallback): Add support for adjusting the time offset on leapForward(). 32297 (contextClickCallback): Use sendOrQueueEvent. 32298 (updateClickCount): Take the time offset into account when counting clicks. 32299 (mouseDownCallback): Use sendOrQueueEvent. 32300 (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton. 32301 (mouseUpCallback): Use sendOrQueueEvent. 32302 (mouseMoveToCallback): Ditto. 32303 (mouseWheelToCallback): Ditto. 32304 (sendOrQueueEvent): Added. 32305 (dispatchEvent): Added. 32306 (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent. 32307 (makeEventSender): Only initialize the EventSender when loading the top frame. 32308 * DumpRenderTree/gtk/EventSender.h: Ditto. 32309 323102010-06-01 Martin Robinson <mrobinson@igalia.com> 32311 32312 Reviewed by Xan Lopez. 32313 32314 [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot 32315 https://bugs.webkit.org/show_bug.cgi?id=39101 32316 32317 Work around timing issues for render tree dumps by pumping the 32318 main loop before doing the dump. Resize events are asynchronous 32319 in GTK+, so sometimes resize requests are still pending when DRT 32320 dumps the tree. 32321 32322 * DumpRenderTree/gtk/DumpRenderTree.cpp: 32323 (dump): Pump the main loop before dumping the render tree. 32324 323252010-05-31 Kent Tamura <tkent@chromium.org> 32326 32327 Reviewed by Dimitri Glazkov. 32328 32329 [DRT/Chromium] Fix crash of a test after another test with multiple windows 32330 https://bugs.webkit.org/show_bug.cgi?id=39942 32331 32332 If a test opens multiple windows, focuses on non-main window, and 32333 the focused window is closed, TestShell::m_focusedWidget points a 32334 deleted object. 32335 32336 * DumpRenderTree/chromium/TestShell.cpp: 32337 (TestShell::closeWindow): Clear m_focusedWidget. 32338 323392010-05-30 Kent Tamura <tkent@chromium.org> 32340 32341 Reviewed by Dimitri Glazkov. 32342 32343 new-run-webkit-tests: Support DRT on Chromium-win 32344 https://bugs.webkit.org/show_bug.cgi?id=39810 32345 32346 Add --test-shell flag to DRT/Chromium, and it changes DRT so that 32347 it behaves like test_shell about command analysis, printing 32348 format, pixel dumping, and timeout handling. 32349 32350 chromium.py and chromium_win.py supports the --test-shell flag and 32351 DRT/Chromium-win binary names. 32352 32353 * DumpRenderTree/DumpRenderTree.gypi: Add new files. 32354 * DumpRenderTree/chromium/DumpRenderTree.cpp: 32355 (runTest): Support for test_shell-style command. 32356 (main): Introduce --test-shell. 32357 * DumpRenderTree/chromium/TestEventPrinter.cpp: Added. 32358 * DumpRenderTree/chromium/TestEventPrinter.h: Added. 32359 TestEventPrinter class manages stdio output and image output. 32360 TestEventPrinter.cpp has two implementations; DRTPrinter and 32361 TestShellPrinter. 32362 * DumpRenderTree/chromium/TestShell.cpp: 32363 Some changes for TestEventPrinter. 32364 (TestShell::TestShell): 32365 (TestShell::runFileTest): 32366 (TestShell::testTimedOut): 32367 (TestShell::dump): 32368 (TestShell::dumpImage): 32369 * DumpRenderTree/chromium/TestShell.h: 32370 (TestShell::printer): 32371 (TestShell::layoutTestTimeout): 32372 (TestShell::layoutTestTimeoutForWatchDog): 32373 (TestShell::setLayoutTestTimeout): 32374 * DumpRenderTree/chromium/TestShellWin.cpp: 32375 (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog(). 32376 * Scripts/webkitpy/layout_tests/port/chromium.py: 32377 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 32378 323792010-05-30 Robert Hogan <robert@webkit.org> 32380 32381 Reviewed by Kenneth Rohde Christiansen. 32382 32383 [Qt] Enhance Qt DRT implementation to support platform scroll wheel events. 32384 32385 https://bugs.webkit.org/show_bug.cgi?id=36004 32386 32387 * DumpRenderTree/qt/EventSenderQt.cpp: 32388 (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match 32389 Scrollbar::pixelsPerLineStep() for DRT testing. 32390 (EventSender::mouseScrollBy): Added 32391 (EventSender::continuousMouseScrollBy): Added 32392 * DumpRenderTree/qt/EventSenderQt.h: 32393 323942010-05-28 Adam Barth <abarth@webkit.org> 32395 32396 Reviewed by David Levin. 32397 32398 webkit-patch should support CHANGE_LOG_EDIT_APPLICATION 32399 https://bugs.webkit.org/show_bug.cgi?id=39546 32400 32401 One sublty is that we want to wait for the user to finish editing the 32402 ChangeLog before moving on to the next step. That means we want to pass 32403 -W to open. However, if the user is using Xcode to edit the ChangeLog, 32404 we don't want them to have to exit the Xcode application. For this reason, 32405 we create a new instance of the application with -n. 32406 32407 Overall, xed seems like a better solution, so we recommend that too. 32408 32409 * Scripts/webkitpy/common/system/user.py: 32410 * Scripts/webkitpy/tool/mocktool.py: 32411 * Scripts/webkitpy/tool/steps/editchangelog.py: 32412 324132010-05-21 Dirk Pranke <dpranke@chromium.org> 32414 32415 Reviewed by Ojan Vafai. 32416 32417 new-run-webkit-tests: fix handling of Ctrl-C to exit even if some 32418 threads are wedged. Also, the script will print the results of the 32419 tests completed when the interrupt occurs. 32420 32421 https://bugs.webkit.org/show_bug.cgi?id=33238 32422 32423 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 32424 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 32425 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 32426 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 32427 324282010-05-28 Darin Adler <darin@apple.com> 32429 32430 Ignore more Python messiness. 32431 32432 * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore. 32433 * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore. 32434 * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore. 32435 * Scripts/webkitpy/test: Added property svn:ignore. 32436 * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore. 32437 324382010-05-28 Chris Fleizach <cfleizach@apple.com> 32439 32440 Reviewed by Beth Dakin. 32441 32442 Adding myself as a reviewer. 32443 32444 * Scripts/webkitpy/common/config/committers.py: 32445 324462010-05-28 Chris Fleizach <cfleizach@apple.com> 32447 32448 Build fix. No review. 32449 32450 AX: need to catch NSAccessibilityExceptions in DRT 32451 https://bugs.webkit.org/show_bug.cgi?id=39881 32452 32453 It looks like Tiger doesn't like seeing a NSMakeRange inside a @try. 32454 32455 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 32456 (AccessibilityUIElement::rowIndexRange): 32457 (AccessibilityUIElement::columnIndexRange): 32458 (AccessibilityUIElement::selectedTextRange): 32459 324602010-05-28 Chris Fleizach <cfleizach@apple.com> 32461 32462 Reviewed by Darin Adler. 32463 32464 AX: need to catch NSAccessibilityExceptions in DRT 32465 https://bugs.webkit.org/show_bug.cgi?id=39881 32466 32467 Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 32468 because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions. 32469 32470 So DRT should wrap exception handlers around its AX related calls. 32471 32472 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 32473 (attributesOfElement): 32474 (AccessibilityUIElement::getLinkedUIElements): 32475 (AccessibilityUIElement::getDocumentLinks): 32476 (AccessibilityUIElement::getChildren): 32477 (AccessibilityUIElement::getChildrenWithRange): 32478 (AccessibilityUIElement::ariaOwnsElementAtIndex): 32479 (AccessibilityUIElement::ariaFlowToElementAtIndex): 32480 (AccessibilityUIElement::disclosedRowAtIndex): 32481 (AccessibilityUIElement::selectedRowAtIndex): 32482 (AccessibilityUIElement::titleUIElement): 32483 (AccessibilityUIElement::parentElement): 32484 (AccessibilityUIElement::disclosedByRow): 32485 (AccessibilityUIElement::stringAttributeValue): 32486 (AccessibilityUIElement::boolAttributeValue): 32487 (AccessibilityUIElement::isAttributeSettable): 32488 (AccessibilityUIElement::isAttributeSupported): 32489 (AccessibilityUIElement::role): 32490 (AccessibilityUIElement::subrole): 32491 (AccessibilityUIElement::roleDescription): 32492 (AccessibilityUIElement::title): 32493 (AccessibilityUIElement::description): 32494 (AccessibilityUIElement::orientation): 32495 (AccessibilityUIElement::stringValue): 32496 (AccessibilityUIElement::language): 32497 (AccessibilityUIElement::helpText): 32498 (AccessibilityUIElement::x): 32499 (AccessibilityUIElement::y): 32500 (AccessibilityUIElement::width): 32501 (AccessibilityUIElement::height): 32502 (AccessibilityUIElement::clickPointX): 32503 (AccessibilityUIElement::clickPointY): 32504 (AccessibilityUIElement::intValue): 32505 (AccessibilityUIElement::minValue): 32506 (AccessibilityUIElement::maxValue): 32507 (AccessibilityUIElement::valueDescription): 32508 (AccessibilityUIElement::insertionPointLineNumber): 32509 (AccessibilityUIElement::isActionSupported): 32510 (AccessibilityUIElement::isEnabled): 32511 (AccessibilityUIElement::isRequired): 32512 (AccessibilityUIElement::isSelected): 32513 (AccessibilityUIElement::isExpanded): 32514 (AccessibilityUIElement::hierarchicalLevel): 32515 (AccessibilityUIElement::ariaIsGrabbed): 32516 (AccessibilityUIElement::ariaDropEffects): 32517 (AccessibilityUIElement::lineForIndex): 32518 (AccessibilityUIElement::boundsForRange): 32519 (AccessibilityUIElement::stringForRange): 32520 (AccessibilityUIElement::attributesOfColumnHeaders): 32521 (AccessibilityUIElement::attributesOfRowHeaders): 32522 (AccessibilityUIElement::attributesOfColumns): 32523 (AccessibilityUIElement::attributesOfRows): 32524 (AccessibilityUIElement::attributesOfVisibleCells): 32525 (AccessibilityUIElement::attributesOfHeader): 32526 (AccessibilityUIElement::rowCount): 32527 (AccessibilityUIElement::columnCount): 32528 (AccessibilityUIElement::indexInTable): 32529 (AccessibilityUIElement::rowIndexRange): 32530 (AccessibilityUIElement::columnIndexRange): 32531 (AccessibilityUIElement::cellForColumnAndRow): 32532 (AccessibilityUIElement::selectedTextRange): 32533 (AccessibilityUIElement::setSelectedTextRange): 32534 (AccessibilityUIElement::increment): 32535 (AccessibilityUIElement::decrement): 32536 (AccessibilityUIElement::showMenu): 32537 (AccessibilityUIElement::press): 32538 (AccessibilityUIElement::url): 32539 (AccessibilityUIElement::hasPopup): 32540 325412010-05-28 Yael Aharon <yael.aharon@nokia.com> 32542 32543 Reviewed by Laszlo Gombos. 32544 32545 [Qt] Pass all web notification layout tests 32546 https://bugs.webkit.org/show_bug.cgi?id=39146 32547 32548 Mimic Chromium's test_shell security model in Qt's DRT. 32549 It makes a list of origins which were granted permission to display 32550 notifications, and only those origins can display notifications. 32551 32552 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 32553 (WebCore::checkPermissionCallback): 32554 (WebCore::requestPermissionCallback): 32555 (WebCore::WebPage::WebPage): 32556 (WebCore::DumpRenderTree::checkPermission): 32557 (WebCore::DumpRenderTree::requestPermission): 32558 * DumpRenderTree/qt/DumpRenderTreeQt.h: 32559 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 32560 (LayoutTestController::reset): 32561 (LayoutTestController::grantDesktopNotificationPermission): 32562 (LayoutTestController::checkDesktopNotificationPermission): 32563 * DumpRenderTree/qt/LayoutTestControllerQt.h: 32564 325652010-05-27 Philippe Normand <pnormand@igalia.com> 32566 32567 Reviewed by Shinichiro Hamaji. 32568 32569 check-webkit-style complains about use of NULL in GTK function calls that require sentinels 32570 https://bugs.webkit.org/show_bug.cgi?id=39372 32571 32572 Don't warn about NULL in g_*() calls. Zero can't be used instead 32573 for calls like g_build_filename and g_object_get/set. 32574 32575 * Scripts/webkitpy/style/checkers/cpp.py: 32576 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 32577 325782010-05-27 Luiz Agostini <luiz.agostini@openbossa.org> 32579 32580 Reviewed by Kenneth Rohde Christiansen. 32581 32582 [Qt] Platform plugin example 32583 https://bugs.webkit.org/show_bug.cgi?id=39489 32584 32585 Exempting directory WebKit/qt/examples/ from style guide. 32586 32587 * Scripts/webkitpy/style/checker.py: 32588 325892010-05-26 Philippe Normand <pnormand@igalia.com> 32590 32591 Reviewed by David Levin. 32592 32593 [style] Allow usage of NULL in gst_*_many() 32594 https://bugs.webkit.org/show_bug.cgi?id=39740 32595 32596 Don't warn if NULL is used by gst_*_many() functions. Zero can't 32597 be used for the reason explained in Bug 32858. 32598 32599 * Scripts/webkitpy/style/checkers/cpp.py: 32600 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 32601 326022010-05-27 Adam Barth <abarth@webkit.org> 32603 32604 Reviewed by Eric Seidel. 32605 32606 Update script to run the normal version of the parser tests. 32607 32608 * Scripts/test-html5-parser: 32609 326102010-05-27 Adam Barth <abarth@webkit.org> 32611 32612 Reviewed by Eric Seidel. 32613 32614 Add HTML5 parser support to run-webkit-tests 32615 https://bugs.webkit.org/show_bug.cgi?id=39815 32616 32617 * Scripts/old-run-webkit-tests: 32618 326192010-05-26 Adam Barth <abarth@webkit.org> 32620 32621 Reviewed by Eric Seidel. 32622 32623 Make HTML5 lexer not ASSERT when resuming partial parses 32624 https://bugs.webkit.org/show_bug.cgi?id=39755 32625 32626 Add webkit-resumer.html to the HTML5 parser test suite. 32627 32628 * Scripts/test-html5-parser: 32629 326302010-05-24 Tony Chang <tony@chromium.org> 32631 32632 Reviewed by Kent Tamura. 32633 32634 [chromium] setup fonts on chromium linux DRT 32635 https://bugs.webkit.org/show_bug.cgi?id=39644 32636 32637 * DumpRenderTree/chromium/TestShellGtk.cpp: 32638 (setupFontconfig): 32639 (platformInit): 32640 * DumpRenderTree/chromium/WebViewHost.cpp: 32641 (WebViewHost::paintRect): Fix a bug where in release builds, we didn't initialize m_canvas. 32642 * DumpRenderTree/chromium/fonts.conf: Added. 32643 326442010-05-24 Dirk Pranke <dpranke@chromium.org> 32645 32646 Reviewed by Dimitri Glazkov. 32647 32648 Re-commit r58765 - it had been rolled out to see if it was causing 32649 a perf regression (in r59787 and r59789), but that does not seem to 32650 have been the case. 32651 32652 https://bugs.webkit.org/show_bug.cgi?id=39605 32653 32654 * DumpRenderTree/chromium/NotificationPresenter.cpp: 32655 (NotificationPresenter::show): 32656 326572010-05-25 Ojan Vafai <ojan@chromium.org> 32658 32659 Reviewed by Chris Jerdonek. 32660 32661 remove suppression of rietveld logging 32662 https://bugs.webkit.org/show_bug.cgi?id=39693 32663 32664 Now that we only upload to rietveld explicitly, e.g. on the bot 32665 or via webkit-patch post-attachment-to-rietveld, we should print 32666 all the rietveld logging. It was suppressed before to avoid making 32667 webkit-patch upload too noisy. 32668 32669 * Scripts/webkitpy/common/net/rietveld.py: 32670 326712010-05-25 Antonio Gomes <tonikitoo@webkit.org> 32672 32673 Reviewed by Ojan Vafai. 32674 32675 [Qt] Expose the editing behavior setting in DRT to test all editing code paths 32676 https://bugs.webkit.org/show_bug.cgi?id=39680 32677 32678 Implement LayoutTestController::setEditingBehavior in Qt's DRT. 32679 32680 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 32681 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 32682 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 32683 (LayoutTestController::setEditingBehavior): 32684 326852010-05-25 Kevin Ollivier <kevino@theolliviers.com> 32686 32687 [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 32688 32689 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 32690 (LayoutTestController::setEditingBehavior): 32691 * wx/build/settings.py: 32692 326932010-05-24 Antonio Gomes <tonikitoo@webkit.org> 32694 32695 Reviewed by Eric Seidel and Kent Tamura (for the Chromium part). 32696 32697 editingBehavior settings needs to be set back to a reasonable default between tests 32698 https://bugs.webkit.org/show_bug.cgi?id=39433 32699 32700 Similarly to r59861, hard code the default setting during reset for Gtk and Chromium, 32701 so that the serialized version of the setting stays in sync with expectations. 32702 32703 * DumpRenderTree/chromium/TestShell.cpp: 32704 (TestShell::resetWebSettings): 32705 * DumpRenderTree/gtk/DumpRenderTree.cpp: 32706 (resetDefaultsToConsistentValues): 32707 327082010-05-24 Eric Seidel <eric@webkit.org> 32709 32710 Reviewed by Adam Barth. 32711 32712 webkit-patch land calls scm.changed_files 4 times! 32713 https://bugs.webkit.org/show_bug.cgi?id=39584 32714 32715 * Scripts/webkitpy/tool/commands/download_unittest.py: 32716 - Assert that we don't call modified_changelogs too often. 32717 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: 32718 - Use cached changelogs list instead of calling modified_changelogs directly. 32719 * Scripts/webkitpy/tool/steps/validatereviewer.py: 32720 - ditto. 32721 327222010-05-24 Kent Tamura <tkent@chromium.org> 32723 32724 Reviewed by Dimitri Glazkov. 32725 32726 [DRT/Chromium] Import layout_test_helper for Windows 32727 https://bugs.webkit.org/show_bug.cgi?id=39581 32728 32729 Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp. 32730 http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc 32731 32732 * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added. 32733 327342010-05-24 Kent Tamura <tkent@chromium.org> 32735 32736 Reviewed by Dimitri Glazkov. 32737 32738 [DRT/Chromium] Reset frame name 32739 https://bugs.webkit.org/show_bug.cgi?id=39586 32740 32741 This change fixes about 70 unexpected results. 32742 32743 * DumpRenderTree/chromium/WebViewHost.cpp: 32744 (WebViewHost::reset): 32745 327462010-05-24 Marcus Bulach <bulach@chromium.org> 32747 32748 Reviewed by Kent Tamura. 32749 32750 [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h 32751 https://bugs.webkit.org/show_bug.cgi?id=39587 32752 32753 * DumpRenderTree/chromium/WebViewHost.cpp: 32754 (WebViewHost::geolocationService): 32755 327562010-05-24 Robert Hogan <robert@webkit.org> 32757 32758 Reviewed by Laszlo Gombos. 32759 32760 [Qt] DRT Support for removeOriginAccessWhitelistEntry 32761 32762 Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html 32763 32764 [Qt] DRT Support for removeOriginAccessWhitelistEntry 32765 https://bugs.webkit.org/show_bug.cgi?id=39565 32766 32767 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 32768 (LayoutTestController::removeOriginAccessWhitelistEntry): 32769 327702010-05-24 Marcus Bulach <bulach@google.com> 32771 32772 Reviewed by Ojan Vafai. 32773 32774 _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head. 32775 https://bugs.webkit.org/show_bug.cgi?id=39603 32776 32777 * Scripts/webkitpy/common/checkout/scm.py: 32778 32779== Rolled over to ChangeLog-2010-05-24 == 32780
