| cf1488f378638819eeb5fc276213437f6cbd0783 |
|
31-Aug-2012 |
Chris Craik <ccraik@google.com> |
Avoid unsafe use of SkRefCnt::getRefCnt() in ImagesManager
The function isn't threadsafe, so races would occur and certain textures
wouldn't be removed from ImagesManager's master list. The list would then be
iterated over, all items dereferenced, and bad times would ensue.
The SkRefCnt class uses atomic inc/dec to decide when to destroy an object, but
reading such an integer non-atomically isn't safe. Instead use the real signal
we're looking for - when the ImageTexture is deleted - to know when to remove
the ImageTexture from ImagesManager's list.
Mutual exclusion from editing the list is now maintained by only unref-ing the
ImageTexture within releaseImage, which holds the ImagesManager's m_imagesLock
(which we already do anyway).
bug:6859278
Change-Id: I75ebf79f2617484e7df355d6539226ce64882369
/external/webkit/Source/WebCore/platform/graphics/android/rendering/ImagesManager.cpp
|
| 336afb7e61c87d8d75aa8027118c3b54965c979e |
|
24-May-2012 |
Nicolas Roard <nicolasroard@google.com> |
Fix memory leak
bug:6535726
Change-Id: Id944448a9dbafa951fd3c7eab0f248380d0a5314
/external/webkit/Source/WebCore/platform/graphics/android/rendering/ImagesManager.cpp
|
| efa55f30473bf9e73383966273558efd8d946b7b |
|
23-May-2012 |
Chris Craik <ccraik@google.com> |
Add tracing to interesting/potentially costly functions
bug:6530473 bug:6344165
Change-Id: I40b190036af8c021134d5ac450e3217098ba2296
/external/webkit/Source/WebCore/platform/graphics/android/rendering/ImagesManager.cpp
|
| 2e510fd5b5a30f1315c272d44ae3aa4cba355498 |
|
06-Apr-2012 |
Nicolas Roard <nicolasroard@google.com> |
Reorganize platform/graphics/android
Change-Id: Idc67155cfa99784dcd931e705336bfa063ecae46
/external/webkit/Source/WebCore/platform/graphics/android/rendering/ImagesManager.cpp
|