History log of /packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
1df6df7e33601f1dcd6358a1eea9c34bc6373927 05-Jun-2012 John Reck <jreck@google.com> Don't show stale thumbnails

Bug: 6610952
We don't null item.thumbnail because we want to recycle the bitmap
if the item changes, so add a boolean saying whether or not we have
an actual thumbnail to show to avoid showing stale data

Change-Id: Ibfd485cb7f3ea8991222b8e99704170bf331472b
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
9ee87d9ce5aae1460f53bea66bfcafd3671505a0 04-May-2012 John Reck <jreck@google.com> Fix getItemId()

Bug: 6446119

Change-Id: If8c13c9f2cb9b93c6f3575f12111059aeeacd5cb
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
af991f93d09bf4d2db3c7a8c03ca3ca4352bed83 25-Apr-2012 John Reck <jreck@google.com> Remove unused code

Change-Id: Ia38f8aabbb5cfa1cceab160f4285e7b86aac2c17
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
f94abcf44fc1611f76e55461f48220e621fc31b7 11-Oct-2011 John Reck <jreck@google.com> Load bookmarks asynchronously

Bug: 5297900

Change-Id: I8b728cfe06799099e21c402d5da7087507209ffa
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
d18ac4b36b057a6a403cb060dfc10761b7394548 13-Apr-2012 John Reck <jreck@google.com> Support BOOKMARK_TYPE

Bug: 6332869
Bug: 5494697
Bookmark type also gives us an easy way to localize Other Bookmarks

Change-Id: Iab208da0cb1b2af5d256990cdc4ab5c11821523b
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
23c61dd30cd2f4a96ab2b01a5878badc79380c6a 29-Sep-2011 John Reck <jreck@google.com> Update folder asset usage

Bug: 5066431

Change-Id: Icc4ea38e64881d0f67d3cbbd0b6bda7138f4a0b4
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
9db9529bdb7490ccd72fbe66f7e9c9d7cdd73899 20-Jun-2011 John Reck <jreck@google.com> Re-enable list view mode

Bug: 4645489

Change-Id: Id6eab53a6cb73083781c96a41bfeffec6eae0498
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
f3828cd09f12cbf2980af72187628a608db8e938 15-Jun-2011 John Reck <jreck@google.com> Remove magic paddings from bookmark view

Use calculated sizes to correctly center without the need for
"magic" padding values.

Change-Id: Ida64a80243df9bf05355dd1db1047fc16c10b726
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
71efc2bbf08574425a387c992e24cb9eaf0a6e6c 10-May-2011 John Reck <jreck@google.com> Initial pass at collapsable bookmarks

Change bookmark view to show all bookmarks
Group by account_name

Change-Id: I2c252c9f0e8d4df4271649dbe9bf3db336f921df
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
18e93f72fdfdd57ecaebe80ecccc9fecfbb16c8f 21-Mar-2011 John Reck <jreck@google.com> Tab switcher cleanup

Make it holo and clean up the code

Change-Id: I6462cb72f104a2c076fd2ce2da876c74de8e783a
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
5a72f1858c2f73be3558c6cdaa2c84b4c36fa748 14-Jan-2011 Michael Kolb <kolby@google.com> asset drop & naming

drop in new assets
get naming in sync with UX
Note: not all resources are included yet
item_background...xm will be enabled when all required resources come in

Change-Id: I321084abd25ef6c533f1f3da636a246e7ee00547
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
0ce8a942a895cfe1d432076a95f3ed3798ccb002 15-Jan-2011 John Reck <jreck@google.com> History UI update

Change-Id: If4af6e37252f297bc1744af65df4bc2f123f41dd
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
b3417f0a68a1efc64604ea354ae7f856ce79cb16 14-Jan-2011 John Reck <jreck@google.com> Bookmark UI update

Change-Id: Ibdf7f93f7c5863d7108044dcd40d3866ff02518a
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
439c9a58765aa6aab95d55422ee61ea8360e912d 14-Dec-2010 John Reck <jreck@google.com> Spec update for Bookmark widget

Bug: 3286323
This updates both the assets for the bookmark widget and slightly
alters its behavior to match the updated spec. There are now two
touch targets in the header, one launches the browser and the other
launches the bookmarks view.

Change-Id: I1e8864983852af8421280b86421dea1d9ed4335e
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
608baa78f4071409294f79b37e7ffa9ca96c4223 24-Nov-2010 John Reck <jreck@google.com> Refactor Bookmark fragment, fixes NPE

Bug: 2926451
This change refactors the BrowserBookmarkPage fragment for better
encapsulation, and updates the CombinedBookmarkHistoryView and
ShortcutActivity. ShortcutActivity now supports folder navigation
as well as toggling list or thumbnail view.

Change-Id: Ie8168467e793d60d75c15746f81318cfa7e9f003
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
8af906474c84854598da1886edacfd5f10cae70f 23-Nov-2010 John Reck <jreck@google.com> Adds a list view option for viewing bookmarks

Bug: 3166319
This adds a popup menu option to the combined view that allows a
user to switch between viewing their bookmarks as a grid of thumbnails
or as a list of bookmarks with favicons.

Change-Id: I6729d477f574a46847dff4b69c1b32d9f63fb37f
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
fa3140719411322b678f1bd998ac1bac961047e0 17-Sep-2010 Michael Kolb <kolby@google.com> added bookmarks folder icon

Change-Id: I34765961c29afa711f4d4e3f8f7fa9fca13753c6
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
f3026374dccf7b491152946c5d0e42daec08d899 19-Aug-2010 Jeff Hamilton <jham@android.com> Make the bookmark thumbnails larger.

Change-Id: I33e72e55e0cad9c73b3c50cb30277ed22eb511cb
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
8402962ef58546d3cfd48fbb211b5e36df0f118e 05-Aug-2010 Jeff Hamilton <jham@android.com> First revision of the new browser provider.

This one has support for bookmarks sync,
has the bookmarks and history in separate
tables, and supports hierarchical bookmarks.

Compatibility with the old APIs is not yet complete.

The Bookmarks UI has been switched over to the
new provider. Creating bookmarks puts them
in the UIs root folder.

Change-Id: Ib21713ddd19f43d178d49dbac977f749e7103368
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
f49ecd60e2363d414d3ff1d9d1a7d3110d741125 09-Apr-2010 Patrick Scott <phanna@android.com> Create the bookmark adapter in a background thread.

Handling it asynchronously prevented an ANR but it still took forever with large
databases.

Bug: 2581894
Change-Id: I273375e439d7e3ac048728aabb39c6920fa87e5a
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
63a45b8ff2254ca9309abd1c1880f6af5a6712ce 06-Apr-2010 Patrick Scott <phanna@android.com> Update bookmark favicons in the background.

Bug: 2573890
Change-Id: I7c9ebfd1b561c40d806988e65f7e89d5cd283f89
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
c1cf63a4c15ad81f4d19e10574e9dba91f0b83e4 09-Mar-2010 Patrick Scott <phanna@android.com> Request icons in the background.

BrowserBookmarksAdapter does not need to request bookmark icons as most of the
bookmarks have up-to-date icons. We still need to request all icons on start up
because a new icon may be loaded as a result of clicking a history items.

Move the icon request to a background thread to not block the ui thread on large
db lookups.

Remove MostVisitedActivity as it is no longer used.

Bug: 2496872
Change-Id: I378dce8fdb7e825da96594cd31b720ea24758af1
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
96afcb1a85b1d14be910bfe0a2c4104e6ec87964 10-Dec-2009 Leon Scroggins <scroggo@google.com> Add data (title, screenshot, favicon) to share intent.

Requires a change to frameworks/base

Fixes http://b/issue?id=2243246
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
193def94f541f1d0bbd3ec43f1059112993a9a95 07-Jan-2010 Patrick Scott <phanna@android.com> Use LIKE rather than GLOB since the url contains '?'.

Bug: 2271388
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
9907efcdb03d1e038b3923d6c58f907b1fda4c5e 28-Oct-2009 Ben Murdoch <benm@google.com> When displaying a bookmark item, only truncate the Strings that we display in the ListView rather than the ones used to index into the bookmarks database. This caused a crash when bookmarks had titles longer than the text view limit.

Fix for b/2219781

Change-Id: I4ea3cdfbaedce0dea6bd69f560aae9aea71ed7c1
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
1794fe252866c311f3b4700a2a1e44e843962243 29-Sep-2009 Ben Murdoch <benm@google.com> Save a new bookmark to the bookmarks DB asynchronously. Fix for bug 2151093.

Change-Id: I860482f0a0610669f87965947b0818508d8988b7
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
f85516172840450a4d1270b658905dc1649ceaf2 24-Sep-2009 Leon Scroggins <scroggo@google.com> Fix layout issues on the bookmarks screen.

Limit the title of a bookmark to stop at the right edge of screenshot.
Use the new default screenshots for bookmarks without screenshots.
Resize the bookmark screenshot to match the size of the default icon.

Fixes http://b/issue?id=2042025 and http://b/issue?id=2098770

Change-Id: I66a10671ea98007cfe5bf7502fb1e3619276ca22
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
aac7aa6fcfcb519755987ec126be066323f589c8 17-Sep-2009 Ben Murdoch <benm@google.com> In the case of a page load error, save a second screenshot in onProgressChanged(100) to ensure that we save the substituted error page rather than the previous page that loaded. Also save the thumbnail for the page if the user creates the bookmark through the add bookmark menu or clicking the add bookmark icon on the bookmarks page.

Change-Id: Ib2b7692a45290f9ce372968e05cde8f6903e4572
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
c95261955cf08f30b484b6a229c4bcff42c645ce 23-Sep-2009 Andrei Popescu <andreip@google.com> Make the deletion of bookmarks depend on both title and URL

Fixes http://b/issue?id=2134421
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
15525d48024d325c8a52766d8ca727191251a8d4 21-Sep-2009 Patrick Scott <phanna@android.com> Update the correct favicon when starting the load.

The WebView's original url and current url are incorrect during the provisional
load. Use the given url instead when updating the favicon.
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
dcc2b6f08dd5677bc6ba761a9ba6f1c655113051 21-Sep-2009 Ben Murdoch <benm@google.com> Put current screenshot under "Add" on bookmark thumbnail page.

Change-Id: Iaf52037f755fea343ef68a23d3740f0f5cdcecb7
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
8f0076b720c9ee1e9ef9d29910c261634fd5fb25 17-Sep-2009 Patrick Scott <phanna@android.com> Display favicons for history items.

Use the data from the java database before talking to the native database. The
bookmarks database may contain favicons that the native database does not have a
mapping for. Used the native icon database for recent history items since those
are not stored in the java db. Request the icons each time the activity is
created since the url->bitmap mapping is a global.
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
328ea87539544e6aff7d850347ce9b57ba4ce1ad 16-Sep-2009 Ben Murdoch <benm@google.com> Make the view mode that the user sets (either grid or list) in the bookmarks/most visited page sticky.

Change-Id: I67db0ef2997a5948491223a5ae17fd4aa0356e94
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
b40bf27e35243d85b616908acd641a223807d137 15-Sep-2009 Leon Scroggins <scroggo@google.com> Use a new resource for pages that do not have a screenshot in bookmarks.

Change-Id: Iff64adbd0549be5c182dd38a18c5fbeb5e88a1e8
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
a5d669e4c08f0e64387c2c539c41a26ac8c845ab 05-Aug-2009 Leon Scroggins <scroggo@google.com> Make the "Most visited" page have a thumbnail viewing mode.

Start capturing screenshots for all visited pages, and show them
in a grid view on the most visited page. Modify the BrowserBookmarks-
Page and Adapter so they can be used for the "Most visited" page.
Also change some of the ids for context menu items to be the same
in the browser and history context menus, for simplicity in
handling them in BrowserBookmarksPage.
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
3918d4443ff38ef1870e02aa51a8b29f8352bb1a 04-Aug-2009 Patrick Scott <phanna@android.com> Implement onReceivedTouchIconUrl.

Add DownloadTouchIcon, an AsyncTask that downloads the apple-touch-icon for urls
that are marked as bookmarks. The touch icon is stored in the bookmark database
similar to favicons and thumbnails. If a shortcut is created for a bookmark
containing a touch icon, the touch icon is used (with rounded corners).

Refactor the bookmarks query to be a static function. The function uses the
original url and new url to look for matching bookmarks. This takes care of
redirects as well as bookmarks containing queries.
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
0c7865002753aea5de117ea4c08043dca95d07b6 04-Aug-2009 Leon Scroggins <scroggo@google.com> Updates for the look of the bookmarks page.

Add new assets.

-tab_indicator.xml
State selector for the background of tabs in the CombinedHistoryActivity

-bookmark_thumnail.xml
Web page title is now above the thumb. Removed the favicon. Added a
shadow.

-tab_header.xml
Layout for the tabs in CombinedHistoryActivity

-tabs.xml
Change the height of the tabs.

-bookmarks.xml
Remove the title for the "switch" menu item, which gets set in Java,
depending on the current viewing mode.

-strings.xml
Remove the placeholder menu item text, add the actual text for
switching between modes.

-BrowserBookmarksAdapter
No longer set the favicon on top of the bookmark thumbs in grid mode.

-BrowserBookmarksPage
Implement onPrepareOptionsMenu, and set the title of a menu option,
depending on the current viewing state.

-CombinedHistoryActivity
Create a common function for setting up all the tabs. Change the
look of the tabs to match the new design.
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
89c6d36e2e6d6040540ee93ef4df29a6874a6a95 15-Jul-2009 Leon Scroggins <scroggo@google.com> Work on the Bookmark Grid, including the favicon.

Remove the file BookmarkGridPage, since a GridView will do just fine.
Now we specify a height and width for the bitmaps rather than adjusting
them for the screen size. Also add the favicon and match the design
more closely for the Add option. In BrowserActivity, match the size
of the saved screenshots to the desired size for the Bookmarks
Activity. Also move the logic into its own method so it can be
called from multiple places (still called in only one at the moment).
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
892df31fda83baeeee2d0620b622b4730c30ee87 14-Jul-2009 Leon Scroggins <scroggo@google.com> Integrate bookmark grid view mode with list view mode.

This way the two different modes can share code and have
all the same behaviors (i.e. context menu options).

AndroidManifest.xml
Remove BookmarkGridPage, which is no longer an Activity.

bookmarks.xml
Add a menu option to switch between the different viewing modes.

strings.xml
Name for that menu option.

AddNewBookmark.java
Remove copyTo, which is not necessary.

BookmarkGridPage.java
Change to just be a GridView, with our desired settings, and
overriding onSizeChanged to size the thumbs appropriately. Now its
constructor takes a BrowserBookmarksAdapter, which it uses instead
of its old private Adapter.

BrowserBookmarksAdapter.java
Now has two modes, so it can be used for both the bookmarks grid
and the list view. Removed a bunch of obsolete code, which was
used for searching/sorting the bookmarks.

BrowserBookmarksPage.java
Now switches back and forth between using a GridView and a ListView.
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
e372c02c732cf0881c21eb8423454a555e8fc75c 12-Jun-2009 Leon Scroggins <scroggo@google.com> Consolidate bookmark add/delete code in the browser.

Driven by a desire to put bookmarking functionality into the title
bar, I have consolidated the code for adding and removing bookmarks.
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
b7e86a19725f7ebf93c78d613bd610212f072779 21-May-2009 Leon Scroggins <scroggo@google.com> Remove an unnecessary field.

This string was used for logging error messages, but
it is not used.
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
e09761e605bff04ff2e0b5e1f25541988088e80d 25-Mar-2009 Patrick Scott <> Automated import from //branches/master/...@141656,141656
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
0c90888c75eed12f6e2e14a9044faf50bd4af8ed 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
8611831e36b71c844a14788998728f3cd625b833 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
ed217d91fb3f1a8f4e75ab36ef81d72ef9f4e6d6 18-Dec-2008 The Android Open Source Project <initial-contribution@android.com> Code drop from //branches/cupcake/...@124589
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java
ba6d7b853c32ad6c3be26c443daa61f322bcfdc2 21-Oct-2008 The Android Open Source Project <initial-contribution@android.com> Initial Contribution
/packages/apps/Browser/src/com/android/browser/BrowserBookmarksAdapter.java