History log of /packages/apps/Contacts/src/com/android/contacts/calllog/PhoneNumberHelper.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
e0b2f1e2d01d1ac52ba207dc7ce76971d853298e 12-Jun-2012 Chiao Cheng <chiaocheng@google.com> Global import order fix.

Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements

Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.

Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/calllog/PhoneNumberHelper.java
fadd5e1f1845b8d98e247bbd30535928dc5e0f81 02-Dec-2011 Daisuke Miyakawa <dmiyakawa@google.com> Use NEW_TASK flag for launching in-call UI

To make Intent creation consistent, prepare relevant methods in
ContactsUtils and use them everywhere.

Bug: 5691827
Change-Id: I41509bfc7d914ba87ab614450b53fc93ce0eba4b
/packages/apps/Contacts/src/com/android/contacts/calllog/PhoneNumberHelper.java
0646f2712e8b4a5ada51bd586d5f179d38a304c5 17-Oct-2011 Flavio Lerda <flerda@google.com> Use framework API to match voicemail number.

We were tracking the voicemail number within the application. This has
two shortcomings: it would not be updated automatically when its value
changes and the matching against it was only based on it being
identical, without taking into account other possible formatting
differences.

Switch to use PhoneNumberUtils.isVoiceMailNumber() instead, which is
what the Phone app is also using.

Bug: 5435925
Bug: 5416495
Change-Id: Ie56363c578cf5f6102fd6880ffce14f608ddaf0b
/packages/apps/Contacts/src/com/android/contacts/calllog/PhoneNumberHelper.java
71fc6ec6598aeb8dcad797c05816bab91762e2b3 09-Aug-2011 Flavio Lerda <flerda@google.com> Use geocoded location from call log content provider.

When showing the geocoded location in the call log, use the value from
the provider instead of querying the geocoder each time: that would be
too slow and cause a strict mode violation.

Bug: 5129581
Change-Id: Ia0eb5bdd33c5bcebcf6267ce01f7d36c53396c30
/packages/apps/Contacts/src/com/android/contacts/calllog/PhoneNumberHelper.java
f50b48738e70d901f6200356ded40cb3d7211ad4 03-Aug-2011 Flavio Lerda <flerda@google.com> Do not show geocode for voicemail and private numbers.

Bug: 5111400
Change-Id: I4f7e8f2bf8480731184578b335a7ce7fc5ef4270
/packages/apps/Contacts/src/com/android/contacts/calllog/PhoneNumberHelper.java
ebef7717c62e15d69c0965ec7a56c4f16341dff3 20-Jul-2011 Flavio Lerda <flerda@google.com> Do not expose parsePhoneNumber in PhoneNumberHelper.

Instead, do the call within getGeocodeForNumber, so that we have a
single call now that we need to make asynchronously.

Bug: 5046550
Change-Id: I54fddefa3f7c8d29bcd60b0d96162211f90520c9
/packages/apps/Contacts/src/com/android/contacts/calllog/PhoneNumberHelper.java
cb805e853dce5fc4d434f2b1916b154d80ab1744 18-Jul-2011 Flavio Lerda <flerda@google.com> Use geocoded description in the call log.

If a number is not associated with a contact, try to get the location
for that phone number and show that instead.

This is shown below the phone number, since the phone number is still
the most useful information for the user.

Bug: 4968253
Change-Id: If9c29c2e20f96f10e24fcf97ccac85eada237b71
/packages/apps/Contacts/src/com/android/contacts/calllog/PhoneNumberHelper.java
cfff16d74a5e8c6aca67462e9c76168a479273e8 13-Jul-2011 Flavio Lerda <flerda@google.com> Remove the long-press menu from the call log.

Make sure that the logic is preserved in the CallDetailsActivity where
the actions are available: we were currently not handling all the
special cases for SIP numbers and voicemail.

Change-Id: I97f6ffaeb6ee839fd1ddbd4c4c0a532457cc9d14
/packages/apps/Contacts/src/com/android/contacts/calllog/PhoneNumberHelper.java
178eeebac88b352c131bd0315a99da16162c986e 11-Jul-2011 Flavio Lerda <flerda@google.com> Open groups of calls in the CallDetailActivity.

This change allow showing the details of a group of calls in the
CallDetailActivity.

First of all, it adds a way to pass to the activity a list of calls,
namely by using an extra containing a list of ids of rows in the call
log. It preserves the existing mean to open the call details using a URI
for backward compatibility.

In turns, the activity will get the details of each call, assuming they
all come from the same number and therefore the same person, and show a
single contact header at the top, while placing the detail of each of
the calls in the list at the bottom of the activity.

With that done, we no longer allow opening up groups of calls in the
call log: they are no longer necessary, as the details of the calls
within a group are now accessible in the details page.

In the process, extract a utility class that encapsulates operations on
phone number, like whether calls can be placed to a phone number, and
how to display the number to the user. There might be a few more places
where this helper can be used, but I will look at those in a follow-up.

A few optimizations still need to be pursued, for instance the lookup of
the details of the phone calls in a group can be optimized.

Another candidate for a follow-up is using a common ContactInfo class
between the call log and the call details, maybe with shared functions
to extra the information from a cursor.

A further improvement would be to have a shared cache of the contact
info and call log details, so that looking up the information when
opening the call details can be done more efficiently (it is currently a
strict mode violation) since the call details will generally require
information which had already been looked up by the call log beforehand.

Change-Id: I408650d7485afe4c132dd9cc376e6ba0e3388c1e
/packages/apps/Contacts/src/com/android/contacts/calllog/PhoneNumberHelper.java