| 15102c1177c9cec0fce0f2d220b514fe72dcac4e |
|
23-Aug-2012 |
Daniel Lehmann <lehmannd@google.com> |
Guarded the getActivity() call
Bug:7026011
Change-Id: Ib4f4fe97023b90472586379679e0e6ab4876fd07
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 10bf684e0c9022d80b04d9cc69665c6341677bea |
|
15-Aug-2012 |
Maurice Chu <mochu@google.com> |
Enable parsing phone number in ContactLoader
A new flag has been added to the ContactLoader to compute
a formatted number based on the original phone number,
phone number in E164 format, and the default country code
iso. Only the ContactLoader for the contact detail card has
been enabled to compute this formatted number.
Bug: 6521929
Change-Id: I0a8eaaa49b7768e9ce2a177d64881562e6bec1d7
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data
This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.
ContactLoader.Result class has been pulled to the top level as
the Contact class.
The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.
Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.
The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.
Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| c4af651a470b0f92f593b77b28a828ce287c4b4a |
|
29-May-2012 |
Maurice Chu <mochu@google.com> |
Disallow creating shortcut for directory contacts
Bug: 6574684
Change-Id: I0b31da1191fdd589376edfac65ff0d4025313df0
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 45ee872fe7be69c6b3f0c59167eecd11af467812 |
|
22-May-2012 |
Makoto Onuki <omakoto@google.com> |
Don't send view notification before showing quick contact
Instead, do this in the second load. This directly affects the quick contact
startup time.
Bug 6529921
Change-Id: Ief7bda9bd32cb4be0c86c4b79efb35da812721dc
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| e1cc78a9827d95afa41fb159bc93aa18fdd2c1d5 |
|
14-May-2012 |
Makoto Onuki <omakoto@google.com> |
Fix bug 6479405 On tablet, sometimes, QC -> full contact...
card yields in an empty details screen.
In the old code, we even copied the requested URI, which caused the issue
if the URIs for the first request and the second request are different
but still point at the same contact. If we do this, the second result
will have a different requested URI than the actual requeseted URI,
which makes ContactLoaderFragment ignore the result.
This really happens because the lookup URI has variations.
Also make sure not to cache error results.
Bug 6479405
Change-Id: I71254578f0513b391804ee27a21a810bdb6881ac
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 056a8464f820acb0cdd3a7670efee3474826a06b |
|
12-Apr-2012 |
Maurice Chu <mochu@google.com> |
Added the ability to create a contact widget from the contact details view
If the contact details view is on the user profile (i.e., me), then the
menu option to create a contact widget does not show up in the menu.
Bug:5346555
Change-Id: I392ca60a53168139a30ad70d72013da28fbecf24
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 2f41fe6bcc8d055bf53ad070425552fad57dff21 |
|
29-Feb-2012 |
Daniel Lehmann <lehmannd@google.com> |
Reintroduce cross-fade on tablet when going from one contact to the next
Bug:6009407
Change-Id: I6044963d1b4737ebdd2d3b5fded71281841f0d81
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 2a45e35ab3273c8901d9df3671e51614dc0250c6 |
|
14-Feb-2012 |
Daniel Lehmann <lehmannd@google.com> |
Animate show/hide updates
Also fixes the vertical text position which was wrong due to the shadow
Bug:5268733
Bug:5204655
Change-Id: I011a482500e13b1b189c7e27dbcd40e2e1f42318
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 410d0dcd2d4119cf1c627adc68bb58775dac461a |
|
11-Oct-2011 |
Dave Santoro <dsantoro@google.com> |
Pre-authorize VCard URI when sharing profile.
Bug 5437453
Change-Id: Id91016d4b8bb174c2c29eb7e607ba72d4bc60588
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 2621c5bb7049401c8bce740005fa60bf1b304b86 |
|
03-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
ContactLoader: set requested URI to error/not found result
- Now both the "error" and "not found" results have the requested URI.
- NOT_FOUND is no longer a singleton; there's now "isNotFound()" method
in accordance with isError().
Bug 5350017
Bug 5201346
Change-Id: Icb9080d3885ea2217e73a59db3825984746c3eb3
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 685157e0635ee33350d3dd1c6551e188d3df9f22 |
|
30-Aug-2011 |
Daniel Lehmann <lehmannd@google.com> |
Fix blank screen on VIEW raw contact URIs or legacy URIs on phone
Store requested URI in ContactLoader Result. We were doing the
wrong comparison of the lookup URI. For example, we were checking
that the incoming URI from the intent (i.e. raw contact URI) was
equal to the lookup URI from the ContactLoader Result. This was
not equivalent and resulting in a blank screen for the VIEW
intent on raw contact URIs and legacy URIs.
TODO: Fix for tablet, there may be a different issue going on
there.
Bug: 5220640
Change-Id: I2d6dff8df4c9065d7d845dca5c09ba1d773770df
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| fab516143c60565b9cc0d18fbe0af33902764546 |
|
24-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix blank screen on contact card after extended screen lock
- After viewing the contact card for someone with social
updates and waiting for an extended screen lock (3+ mins),
unlocking the screen brings up a blank contact card.
- Don't set retain instance state = true for ContactLoaderFragment
so that it follows the normal Fragment lifecycle
(and we already take care of saving/restoring state
anyways in that fragment).
- Don't set the contact data to null onLoaderReset() in
COntactLoaderFragment
- Don't show the "updates" header in the updates fragment
if there are no stream items
Bug: 5141991
Change-Id: Icd8693154f756cf423b64524ffcbd850f1c55d9b
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 9e7b5da669fcf92a6a627fb720749e5cb627684a |
|
23-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
Propagate original exception when throwing load exception
Bug 5198078
Change-Id: I941dc9b96d6c58eb1912d446c3c27ec4c4c2ffef
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 3acaef02bdbc612ba7573f005168cec48aa42905 |
|
22-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Throw exception if there's a contact loader error
Bug: 5193744
Change-Id: I3a9024f090efc581dec96c7a84580eed1864de42
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 3ef27fb18a2fe075c43131b653cd2e6306e187e2 |
|
09-Aug-2011 |
Daniel Lehmann <lehmannd@google.com> |
Start service intent when contact is being displayed
Bug:5138185
Change-Id: I84dbf0f933d575b4910b220fe9743a47f46d5762
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| d510f8a8e03ed67cf5a9a686fd67ab9a19d6ab8f |
|
27-Jul-2011 |
Isaac Katzenelson <isaack@android.com> |
Merge "Options Menu layout changes"
|
| 683b57e1fbf27c81c9973de814fc8bb1852e6df8 |
|
21-Jul-2011 |
Isaac Katzenelson <isaack@android.com> |
Options Menu layout changes
Show correct buttons for each tab
Show correct buttons for contact viewer and editor
Removed ContactOptions activity and now showing ringtone picker
directly.
Removed all "contact options" from XMLs.
Bug: 5062002
Change-Id: Ic52eaacdc5d9b5aab55fde37181c6ad6d7154b74
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 3e6991e5ee91ea2cc82a02bd3ea4ed7e941b08af |
|
24-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
Add UI for the "invite"
- Add "More networks" button to the contact card networks section,
which opens the list of invitable account types in a popup.
(This "More networks" section reuses NetworkTitleViewEntry.)
- The list popup uses the same layout as the account selector
- Updated the account selector layout according to the rough visual
spec. Removed the tablet variant, as we use the same layout
on the tablet too for now.
- Sends the invite intent when a type is selected.
Bug 5061956
Change-Id: I0a62126a0cf4ffeecc1a7263b124d00201b67e21
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 69b4a886bdc8e36b7529122b5a97d9e4fd1ddf11 |
|
22-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
"Invite" part 2
- ContactLoader now loads invitable account types, which are account types
that supports the invite feature and don't contribute to the loaded
contact.
- Add AccountType.DisplayLabelComparator
Bug 5061956
Change-Id: Icadffac9e5e3b739e70f59d709cfdd67909c9a41
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 3915600d2b0ff499e0129e951dfd39bff46b2f42 |
|
19-Jul-2011 |
Dave Santoro <dsantoro@google.com> |
Stream items UI.
This is still pretty rough at this point, and does not fully implement
the UI. It handles loading in the stream items and photo metadata in
the contact loader, and displaying those items in a scrollable view
in the updates pane.
Change-Id: I3e796a6141ffa385aa2acc769cf6dd11f37aa39c
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 9c0e8ac3a90e01ebca4b83f1f8ef78e9e98a9922 |
|
14-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
2-pane: Make sure to hide "edit contact" on non "all" tabs
(also other options such as "delete conact" and "share copntact")
These menu items are actually owned by ContactLoaderFragment, so we need to
show/hide the fragment as well even though it's invisible.
Bug 5028965
Change-Id: I302ee49a2a549c0397bee6a657e04c291c3e8b3c
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 4ff31284ff6bd263621771bbfa6b24e0da5af031 |
|
11-Jul-2011 |
Daniel Lehmann <lehmannd@google.com> |
Remove restricted white-listing
Bug:4974334
Change-Id: I05736d49a72ca26902de52f967ee8028178e2366
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 58fc577bd7966e6566cdcac09589a0d3e05128e7 |
|
04-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Contact card on tablet
- Two-column layout in landscape
- ViewPager and tab carousel in portrait
- Views with and without social updates
- Use ContactDetailLayoutController which controls hiding/showing
fragments based on orietnation and contact data
- Move options menu into the loader fragment because there can
be multiple ContactDetailFragments on the screen now at one time
or it can be dynamically created by the ViewPagerAdapter and
we won't have a reference to that in the PeopleActivity
TODO: Use ContactDetailLayoutController in ContactDetailActivity
so there isn't duplicated code. But just make it work now and do
cleanup later.
Change-Id: Ibf8eb317c6e19bc3d98eb9ce46a45cccb237c631
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|
| 2eb969cc399d87b659a45568fa951d394c216917 |
|
28-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
Contact card with and without social updates
- This is for the phone (landscape and portrait)
- Some tweaks were done to the tablet to prevent regression
but it's not quite ready yet
- No social updates means a single scrolling list of details
- Having social updates means a tab carousel and ViewPager
- Add invisible contact loader fragment
- Now the loader fragment loads the contact --> passes to
ContactDetailActivity --> passes to all necessary fragments /
carousels (no matter the configuration)
- Get rid of ContactDetailAboutFragment and move those changes
into the ContactDetailFragment
Change-Id: I7be55ae7205bbcb8106bf2f2e4ae8dd6ce2c6a78
/packages/apps/Contacts/src/com/android/contacts/detail/ContactLoaderFragment.java
|