| 851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data
This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.
ContactLoader.Result class has been pulled to the top level as
the Contact class.
The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.
Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.
The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.
Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 0454960b4b9e43b75bbfd0fb296c25d59111a765 |
|
23-Nov-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Fix test breakage
- Fix broken tests
- Add one test for SIP call in PhoneNumberInteraction.
- Move some tests to the category "small test"
Bug: 5661071
Change-Id: If27295928e1af46e193a462ca4f6c3c5168f893f
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 96e87fd6e808e9d853263ffeb5104f3253a18639 |
|
21-Sep-2011 |
Daniel Lehmann <lehmannd@google.com> |
Use existence of editor as indicator whether source is editable.
Bug:3093621
Change-Id: I3ba344667ce1b0f2da6847d783c0ac90f36ebd8f
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 0556250b620ee26a490d5685b080bf4bce951e9d |
|
28-Jul-2011 |
Flavio Lerda <flerda@google.com> |
Fixes tests.
A new column was added to the queries in ContactDeletionInteration and
PhoneNumberInteraction in I88f311c64eae78c88e9999bff6f7de8538e62157.
This change adds the matching columns to the values returned by the
content provider in the tests.
Change-Id: I4a56c4819afeb2b80a2d95d877d994bf7ae3b32d
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc |
|
27-Jul-2011 |
Dave Santoro <dsantoro@google.com> |
App changes for account types with data sets.
This is primarily a replacement of the Android Account object in most
parts of the app with a new AccountWithDataSet object that extends
Account (by adding an additional attribute, the data set).
This also includes a major refactoring of the AccountTypeManager,
both to allow it to handle data sets and to allow for
non-sync-adapter packages to be referenced by the sync adapters for
an account and registered as sources of contact data. Attributes of
the sync adapter that would typically come from the authenticator
can be parsed out of the Contacts XML for these packages.
Bug 5077096
Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 149fb7fd82554d5b02c335a3f9b8c60be4d083ec |
|
21-Jul-2011 |
Hugo Hudson <hugohudson@google.com> |
Fix intermittently failing unit test.
- This test fails if you haven't switched the phone screen on, which
can be very confusing if you don't know about it.
- This cl introduces acquiring and releasing the screen wake lock to
the integration test utils, and uses it to prevent this test failure.
Change-Id: I378b6effd56e912213eb0af81f8add5c3bba39f2
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 34ce5e98f78b46b858d8afd450d1153c1d985426 |
|
06-Jun-2011 |
Flavio Lerda <flerda@google.com> |
Introduces a TestLoaderManager to test loaders.
Currently, the ContactDeletionInterationTest are flaky because waiting
for one of the loader to complete will fail if the loader was completed
before we start waiting.
Since this happens asynchronously and we do not information of which
loaders have completed, there is not an easy way to know whether the
loader already completed or never started.
This change introduces a TestLoaderManager which is an implementation of
LoaderManager which delegates to another object, but keeps track of
which loaders have completed. This allows to correctly wait for Loaders
to complete, even if they might have completed before the call to
waitForLoaders takes place.
Change-Id: I5e3795e10fc9b3424b983cdef4ac32feed7dbf74
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| c9eda37df2ff1ba2f845ae330bae364cb35fa50a |
|
23-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Close contact editor after deleting contact
Bug: 3396132
Change-Id: I1818446b8ecb6ef71d7c763d3e7ea3dc4c820b02
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 1dc28bef7d5353310359c3711b6cdac390d8a2e0 |
|
11-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Restoring full functionality of no-account contacts
Bug: 3339401
Change-Id: I2c185ee6e1189b89fce875f59b55ccd68edf6313
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 1173ae29217fc83f254404f8a5fa10419ee83c93 |
|
09-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing ContactBrowserActivityTest
Change-Id: Ie492eae15c7163d0f8a3577e73ae14b786709a35
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 6f667b55687bf9193323802e8f3234f0ab254388 |
|
09-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Turning AccountTypeManager into a "system" service.
It's really not a system service proper. It just
uses the same API and the same dependency injection
mechanism as for system services.
Change-Id: I56e24e0f16642a5ab25e809ee12906d965845379
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| a07fa5f37031e4c5cd2933de02d2db41ec153e2b |
|
09-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming AccountTypes to AccountTypeManager.
The intent is to turn it into a "system service" of sorts.
Change-Id: I047d70a2e59978c05916965ef0c0d9f18abc55e6
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 43fd1e84de5e28639062c20d35ba7bfec8a07001 |
|
09-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing ContactDeletionInteractionTest
Bug: 3330176
Change-Id: I6726e74440cd7cb8c16d169a97da5042f77c9463
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 69f9e6f0cd9b5401da55f251e9bd98e69643d7df |
|
04-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming fields and variables from "source" to "accountType"
Change-Id: Ie41036e35a45fc7d9a8c934a3cbe68399c567ad6
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 66bca8f360c9e21b6a47006f21db7b46b6b46340 |
|
25-Nov-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Turning ContactDeletionInteraction into a Fragment
Change-Id: I6edb576d0158b7082d3e2bc4d1902d34fc62cc7a
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 4597c92d655d45447780b32c7572acef110b6ed1 |
|
15-Nov-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming BaseAccountType to AccountType
Change-Id: Iff47bac0e1a118f4a5319526304df16cb89bd0cd
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 35769b804fbfd5a1fc0b2c36cd0a786d662c4334 |
|
19-Oct-2010 |
Daniel Lehmann <lehmannd@google.com> |
Renamed Sources to AccountTypes
Change-Id: I088c7d9cd66fd4d38e93bc97a6644247f72037ef
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|
| 9692f2664e678b0a264c586c70cc4a9c0ffabc21 |
|
30-Jun-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Breaking out contact deletion into a separate object.
Introducing a new type of object, Interaction,
which is neither Activity nor Fragment, but just
support for some particular function, e.g. deletion
of a contact.
Also, moving the query to the background thread.
Change-Id: I52d2607592fe3ca012284d8216003947dba5f188
/packages/apps/Contacts/tests/src/com/android/contacts/interactions/ContactDeletionInteractionTest.java
|