| bc47398187c6ffd132435e51d8d61e6ec79a79db |
|
25-Sep-2012 |
Paul Westbrook <pwestbro@google.com> |
Merge Email1 into MR1
Change-Id: I45289d46b65faffc7a3a3dd46382899162f3aaab
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 7048ceb73c0c69855706b71181488002ab624e45 |
|
19-Sep-2012 |
Marc Blank <mblank@google.com> |
am b203b2b1: Remove useless class and crazy UIDL logging
* commit 'b203b2b1196bfd5507c83a4fe81d362de840ec0a':
Remove useless class and crazy UIDL logging
|
| b203b2b1196bfd5507c83a4fe81d362de840ec0a |
|
19-Sep-2012 |
Marc Blank <mblank@google.com> |
Remove useless class and crazy UIDL logging
* The logging makes it very difficult to debug POP3 issues
Change-Id: Ic3ffb9e5b3240918dff3e713fc2a7c49976efe84
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| e41172e1974aaef40c80bfb9d3340e3e82ef067e |
|
04-Sep-2012 |
Jean-Baptiste Queru <jbq@google.com> |
resolved conflicts for merge of 68e66351 to jb-mr1-dev
Change-Id: I7c5656289aaf14bdd5381893b4bade3160aea748
|
| e714bb9d153cfe13a7f0932e7d67ea08fa5a1d98 |
|
23-Aug-2012 |
Marc Blank <mblank@google.com> |
Convert authorities, intents, and account manager types
* Tested ok on wiped Nexus
* Tested ok on S3
* Upgrade verified on Nexus
Change-Id: If5d4ce594f8a309cdb59589d10b1d33f3b79326c
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 3f645c83d4a3198d65688b39620d16e665c8847a |
|
29-Aug-2012 |
Johan Redestig <johan.redestig@sonymobile.com> |
Make Pop3Store locale safe
Using regular string concatenation instead of default String.format
since it is locale safe, and String.format was not used for anything
fancy.
Change-Id: I4995691518cc41b4751840f42808d414f0d6be3d
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 970fe5316b54cf6b60dbe9122e744eaa31772e10 |
|
04-Aug-2012 |
Marc Blank <mblank@google.com> |
Progress updates for POP3 message downloads
* Also, handle MessagingException when doing STAT
Change-Id: I5267b64f18a84fcc97fc2d003e49d4e373ea02c5
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 7f7f7e6402eec1baab6bedcb58da61369cae4097 |
|
03-Aug-2012 |
Marc Blank <mblank@google.com> |
Handle server deletion of local POP deletions
* Also avoid looping through zillions of messages when
checking uid's
* Always have 25 (or whatever the visible limit) messages
loaded
Change-Id: Ib2f02a59cc438e3fd14d7ac607fb01d9a5fa5282
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| f6db592c313c77190727c7cd72d3edda9d23a099 |
|
02-Aug-2012 |
Marc Blank <mblank@google.com> |
POP3 renovation
* Much, much faster
* Remove message length pass and lots of other useless code
* Create pseudo-attachment for long messages (click to download) that
includes size (so user can determine whether it's worth it)
* Handle download of message via pseudo-attachment; real attachments
are then created as necessary.
TODO: Add real UI with UX input (or modify existing to clean up the
loose ends)
TODO: Optimizations for loading the whole message
TODO: Get server delete working (isn't working currently anyway)
Change-Id: I31f3809fc5a2f9fd490d33cfed70d2930654e71d
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 7d5e2a7c08966ffd4a9e8c78f504cc4fd5be4216 |
|
01-Aug-2012 |
Marc Blank <mblank@google.com> |
Do "same certificate" checking when using "trust certificates"
* Refactor/simplify Transport/MailTransport
* Add serverCert column to HostAuth table in EmailProvider
* During first connection to server, save the server certificate
in the HostAuth; on subsequent connections, ensure that the
certificate presented has the same public key as the one
stored
* For now, we'll just fail to connect (with a CertificateException)
if there's a mismatch
TODO: Add some UI to handle different certificates
Bug: 6888866
Change-Id: Ia79497e89eaad8d43617b50d3771121b2ed7f687
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| a8b683cf3f2efe726220c0235368cf6ea899e3ba |
|
18-Jul-2012 |
Marc Blank <mblank@google.com> |
More work on Imap2
* Handle sending mail and moving to sent folder
* Implement picker for sent folder
* Upload sent items to server
* Add support for "automatic" sync window
* Move some files from Email -> emailcommon
* The added files are copied directly from Email (and can be
removed if/when Imap2 is merged back with Email)
Change-Id: I3a6a3d224826e547748be2f1b567b6294ad5db89
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| f419287f22ae44f25e1ba1f757ec33c7941bbfa8 |
|
28-Jun-2012 |
Marc Blank <mblank@google.com> |
DO NOT MERGE: Move emailcommon2 sources to emailcommon
Change-Id: I06df7e467cd2e0117df8b8db3ddc6ff9da13f1c7
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| e71a19a52313a0fb615700e52a336b65f3c305da |
|
15-Jul-2011 |
Ben Komalo <benkomalo@google.com> |
Build default mailboxes for POP3
Bug: 4580535
Change-Id: Ic800eed387d3e9e64e95cce691d13d98b4a48045
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 745b33b8ff55e9a9c4871f07f9d97db893f784b2 |
|
01-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
Fix all NoSuchMethodErrors
Change-Id: I05adf2b99c819d6aa2d3b52c52a8c655d9307337
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 0b8e04c84def3a06ef45126b48efc485fa0a7628 |
|
29-Jun-2011 |
Marc Blank <mblank@google.com> |
More Store cleanup
Change-Id: I8f542175b4468c7a320322a57bfdaf19a7320165
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 6fea021e3dbe71aaa93512aba699d1bfda3d520d |
|
29-Jun-2011 |
Marc Blank <mblank@google.com> |
Remove redundant and unused constants
Change-Id: Ie8658f86737880e3127a0a2c3b7f0557dde98b29
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 244d306ebb0addbc5d87008af9412b76c80e861e |
|
29-Jun-2011 |
Marc Blank <mblank@google.com> |
Remove more useless code
* Strike another blow for sanity!
Change-Id: Id95b441f9577abda66f04113793d6b1c60500ebe
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 77160c8c08df90c8e9992596197e3438e46d41e5 |
|
29-Jun-2011 |
Marc Blank <mblank@google.com> |
Merge "Don't cache ImapFolders"
|
| 2720a818d5de169734434b114adfdf824a485f55 |
|
29-Jun-2011 |
Marc Blank <mblank@google.com> |
Don't cache ImapFolders
* ImapFolder is currently very unsafe for use by multiple threads,
causing, among other things, the referenced bug
* Since ImapFolder is very lightweight, there's no particularly good
reason to be caching them anyway
* Rename isOpenForTest to isOpen
Bug: 4972084
Change-Id: I2bf17b9cfc8549a222e991f3e59abfd00a4d3afd
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 35b0e95ca795e17b6dc8dd98c7ab847d65d9aa0c |
|
29-Jun-2011 |
Marc Blank <mblank@google.com> |
Clean up Store implementation
* Remove unused argument from newInstance/constructor
* Create ServiceStore class, the superclass of ExchangeStore (and,
eventually, all Stores, until they can go away completely)
Change-Id: Ic5237236c5349ecf006538c58b63c1efe8e4ea61
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 627bc6ed57ee06cc588e64ff959bfd7870b659b6 |
|
13-Jun-2011 |
Marc Blank <mblank@google.com> |
First implementation of IMAP search
* Broke up synchronizeMailboxGeneric into three pieces; it's still
horrible, but this at least stops my eyes from bleeding
* Remove unused method/tests from Folder interface
Change-Id: Ib4d979536be657137cf70ca535cf429d707be41b
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| f5418f1f93b02e7fab9f15eb201800b65510998e |
|
14-Jun-2011 |
Marc Blank <mblank@google.com> |
Move Account into its own top-level class
Change-Id: Ide7c991b7d4d418dbe17164421425bf898ba64ee
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 12b82d9374947c9268217f45befe8a74bd9b60d7 |
|
20-May-2011 |
Ben Komalo <benkomalo@google.com> |
Move HostAuth to top level class.
No other changes made.
Change-Id: I1c6497c98abc0f99443ea42d8aed6295b263c123
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| e07ecb8864b2b77270a1fa4844d6614c93c7291b |
|
17-May-2011 |
Todd Kennedy <toddke@google.com> |
Fix display of POP3 mailbox
When legacy support for mailboxes with a parent key of '0' was removed, the
parent key for POP3 mailboxes was not updated. This forces the parent key
for all POP3 mailboxes to be "no mailbox". If we ever want to support virtual
mailboxes for POP3 accounts, this will need to be adjusted.
Change-Id: I4ae0e386db4bcdaf559b87ca17cbe0d151dea75b
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 171c3f2273223652b9999977d530a715420c0f64 |
|
16-May-2011 |
Todd Kennedy <toddke@google.com> |
Some more re-arrangement of code
No real code changes; just moving where code / constants live. Removed
one unused method of Store.
Change-Id: Ie7532381759a568cb23601e1071c8e199b6beb07
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 53ea83ebf91f820692e8fa8e781f5cc982dd94db |
|
14-May-2011 |
Ben Komalo <benkomalo@google.com> |
Move Mailbox to top level class.
No other changes made.
Change-Id: I3d8f3c521dc0d902be313b25252b4b6a4a96e7ee
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| e87ff6c3cbbfc5e3636f9827b58820652e3ea1c5 |
|
27-Apr-2011 |
Todd Kennedy <toddke@google.com> |
Opportunistic cleanup
not making any real code changes:
* removed deprecated, unused methods
* remove 'throws' clauses when that exception is never thrown
* renamed method Controller#moveMessage()-->moveMessages()
Change-Id: Ifd006f760f0c19283e94a11a45c71295c8da35f7
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 019341af98ffe2dcd484bd0468c9858d9e7cd7a3 |
|
26-Apr-2011 |
Todd Kennedy <toddke@google.com> |
Set mailbox flags for message contents
For IMAP, it's possible for a mailbox to exist on the server, but, to be
unselectable. Previously, these folders were never added to the folder list.
However, with nested folder support, we need to have these folders in the
UX so the user can get to its sub-folders (which may be selectable).
Change-Id: I11135fafbb14b40660983804fb86bd223e180d5e
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 22208771b7b39c5d131372ba6bc45ab23cc22232 |
|
23-Apr-2011 |
Todd Kennedy <toddke@google.com> |
Add hierarchical folders to IMAP
We now create folder hierarcies for IMAP. This also includes a nifty SQL
statement that will get your existing database into shape.
Change-Id: If07a0632e9b250cf0c33c3e16bfba5816beab94c
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 200c6bd9fa19b78acc2c1664f858521aa9885353 |
|
21-Apr-2011 |
Todd Kennedy <toddke@google.com> |
Simplify mailbox synchronization logic
The logic is simplified by creating database rows for new mailboxes down
in Imapstore. This means that the difference between local and remote folder
lists are mailboxes that need to be deleted.
Note -- this is still not the final CL. We probably update the database too
frequently and the column values aren't updated to support nested folders.
Change-Id: Ifbe4e0cf74ba81e5b6156b452ab72c56c35235ab
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| a50fc99b0c433f0cde31ba1c7ab87fb9ea86345d |
|
19-Apr-2011 |
Todd Kennedy <toddke@google.com> |
Use Account instead of URI to create transports
There's no need to create a URI just to rip in appart again. Additionally, to
support additional changes (i.e. to use Mailbox instead of Folder in the
MessageController), we need to store the actual Account.
NOTE -- This change only affects IMAP and POP3. SMTP will come in a follow-on CL
Change-Id: I400036a17271c99272fd9c603547dcd713b50b9d
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 7af1ad3b583b6dea84889aa74ad7c327e7ca9b36 |
|
08-Apr-2011 |
Joe Onorato <joeo@google.com> |
Remove the deprecated things from Config.java. These havent been working since before 1.0.
Change-Id: Iea671dc01ff45f1009f6fbb22cf7259e0fc1d4f1
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 31d9acbf0623872f9d4a2b3210b5970854b654c7 |
|
12-Feb-2011 |
Marc Blank <mblank@google.com> |
Email split, part huit: Refactor constants, clean emailcommon
* There are three pieces to this CL (sorry):
1) Move and/or rename some constants into emailcommon
2) Move Utility to emailcommon, moving the few UI
related utilities back into Email (FolderProperties
and UiUtilities)
3) Remove all references to resources from emailcommon
* The three pieces relate in that, between them, they allow
the emailcommon static library to compile cleanly
Bug: 3442973
Change-Id: Ic5e3abaa2a1b36999e0b6653c6c2134ea1bd544f
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 32311cce0153fbb2708d871626a0797cc93b7e4e |
|
10-Feb-2011 |
Todd Kennedy <toddke@google.com> |
Implement IMAP prefix support
We support two different ways for an IMAP prefix to be specified:
1. A text field on the IMAP configuration page. This is the most obvious to
the end user. It is also an explicit, manual configuration.
2. RFC2342 defines a NAMESPACE IMAP command to be able to query the prefix
from the IMAP server. This is an automatic configuration without any
user involvement (i.e. the UI will NOT change if a prefix is loaded in
this way)
If the user goes to the trouble of specifying a prefix, we will always honour
it instead of the namespace returned by the IMAP server -- even if the user's
configuration is wrong.
bug 1592696
Change-Id: I6b94c7aaac538f6cd9dc4694b0f1634e8c956bc1
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 2193962ca2b3157e79f731736afa2a0c972e778a |
|
10-Feb-2011 |
Marc Blank <mblank@google.com> |
Email split, part quatre: Move along, nothing to see here
* No code was harmed, er, changed in the making of this CL
* All that's happened is that code that is needed by both Email and
Exchange have been moved into emailcommon
* This required import changes to many files, which explains the
length of the CL
Change-Id: I4e12455ba057a4a8054fdbd0b578c73afa411c8a
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 0d4fc55861ed4393aa82f124f2865695ef564641 |
|
09-Feb-2011 |
Marc Blank <mblank@google.com> |
Email split, part one: EmailService
* Create emailcommon package
* Move EmailService classes to emailcommon package
* Change references to aidl's to emailcommon package
* Add getApiLevel() command to EmailService
Bug: 3442973
Change-Id: Ic7d2115363cdff6ebb86c46650b0a5b2109b1c72
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 8d8537cd2e39268e0fdcd019bc8b6c4572b7c520 |
|
02-Feb-2011 |
Todd Kennedy <toddke@google.com> |
Resolve build warnings; part 3
Fixes deprecation warnings
NOTE: This does not resolve hostauth deprecation; that will be fixed
in a separate CL.
Change-Id: I47115516da34effbf885615cb439c9d3e6f95b84
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 54ab7a27a3756a241ba06f0762969cf5a338bf60 |
|
05-Nov-2010 |
Andy Stadler <stadler@android.com> |
Fix NPE in pop3 checkcapabilities
* This happens if an open fails immediately (error message in the
initial banner) followed by a checkSettings.
* The fix is to harden checkSettings to force a clean connection
every time.
Bug: 2170147
Change-Id: If7403bf517477d2b03b21d71caab511fe45e234c
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| d6d874f8c6ce2580ef9ec2406fe411af45b2d92d |
|
02-Jun-2010 |
Marc Blank <mblank@google.com> |
Streamline security setup flow
* The setup flow is changed such that the user is asked to activate
device administration before leaving the setup flow, rather than
having to wait for the notification to appear, etc.
* Accounts requiring security are created in a security hold state
to prevent initial sync until device administration is active
Change-Id: I7e33cf98466370ae27414b99018f7aee71e9e237
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 391ae25c43a38829cc0990af18c36bdc7cc374cf |
|
05-May-2010 |
Marc Blank <mblank@google.com> |
Handle viewing of attachments that are, themselves, emails
* Add intent filter for application/eml and message/rfc822 mime types,
launching MessageView with a Uri
* Modify loadMessageTask to handle the Uri by parsing the attachment's
input stream with Pop3Message.parse(), and then creating an
EmailProvider message in a special Mailbox created to hold
"attachment" messages
* Delete all "attachment" messages after the parent message is closed
* Add unit tests
Change-Id: I20276ee006b9f05b889f3c808d3dc407cde26d49
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| dbbd2ba22c63f38c268c1c33e285cfcc50f6da27 |
|
13-May-2010 |
Makoto Onuki <omakoto@google.com> |
Simplify MessageRetrievalListener.
Main motivation: not to make the new IMAP parser too complecated.
- Removed messageRetrieved.
Motivation:
- It's not easy to call messageRetrieved() at the proper timing
from the new IMAP parser, and this method wasn't used anyway.
- Renamed messageFinished to messageRetrieved.
And removed the "number" and "ofTotal" arguments.
Motivation:
- They weren't used. Also there was inconsistency about
what to pass as "numebr". (i.e. 0-based or 1-based?) There was
even a bug that caused passing a wrong number.
Change-Id: If92dbfe681b78a0eea8125188ede63a8f00dcf49
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| b3f7dd0169a35221184b9327c8ce337b09dc6d1f |
|
10-May-2010 |
Makoto Onuki <omakoto@google.com> |
Clean up member variables.
- Fix misnomered fields. (e.g. static mMember -> static sMember)
- Reduce visibility. (e.g. mark as private)
- Mark final / static if possible.
Note it's on master.
There's a lot more cleanup oppotunities in the activities, but they're going
to go through a major overhaul, so I didn't bother.
Change-Id: I3fde73ba5f1f9ff675fff07c510e1e49521dde42
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 165e8bfe7a46564ea98bb16cb059102ba356a1b5 |
|
08-May-2010 |
Makoto Onuki <omakoto@google.com> |
Cleanup: Add @Override
(Note it's for froyo-plus-asop)
Change-Id: Ic4211c08586e33c44d5d6267c0c9d37f8c7cdc85
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 645fc2830118e19e604f24ba7ffe71c775631f64 |
|
12-Apr-2010 |
Andrew Stadler <stadler@android.com> |
Try TOP even on POP servers that fail to report CAPA
* Ignore the results of CAPA and always try TOP
* If TOP returns -ERR simply fall back to (bad old slow) RETR
* Unit tests for positive & failure cases
Bug: 2588432
Change-Id: Ife4b551217de1025e14efc46074f16ef4ae99c6f
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| e4a7cc440f081ef9c4375a2bd2f82680cc11b152 |
|
30-Sep-2009 |
Andrew Stadler <stadler@android.com> |
Re-enable modernized version of "optional" SSL/TLS
* Add "Accept all certificates" modes to incoming/outgoing secure choices
* Change URI scheme slightly to make "trust" a flag, not part of the
protocol.
* Change Stores to know about new URI scheme
* Slightly rework Transport API to make "trust" an independent flag
* Adapt HostAuth to handle new Uri scheme
* Remove the old ambiguous "optional" code, which was allowing
some unsigned certificates, but was *also* allowing TLS to
optionally start (though not SSL, despite the UI strings.)
* Add a few unit tests to EmailContent
* Add logging and a bunch of comments to TrustManagerFactory, and a bit
of simple cleanup to make it more readable.
* Add missing conversion of SSLException->CertificateValidationException
in TLS so we get the correct certificate errors from TLS too.
* Re-enable TLS for mac.com accounts (which had a certificate problem)
Fixes bug http://b/2119755, http://b/1374780, and probably a raft of
earlier and/or external bugs about certificate problems.
Change-Id: Iaf99a8da3eaadaa4cdeec224737838b5d6813e55
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| c41c47fa07a22f8a7612fb0191f152a36d95b7a5 |
|
25-Sep-2009 |
Andrew Stadler <stadler@android.com> |
Enable message upload
* Create logic to detect upsyncable messages in Sent
* Note: Drafts is now local only for IMAP - no sync, either way
* Rewrite MessageController.processPendingAppend for Provider world
* Write provider message -> legacy message converter
* Fixed bug in IMAP APPEND (it was not picking the right UID for the
uploaded message.)
* Better handling of server internaldate
* Add constants for new X-Android-Body-Quoted-Part header
* Add EmailContent routines to get each of the 5 parts of the body
* Remove "Load more" from unsynced message lists
* Add toString to MimeHeader for debug support
Bug # 2097471
TODO (next CL): Upload attachments records too
Change-Id: I209182f5adc6b6696919f559e3cbbdd58b3eed3a
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 092d35c98d00c5a8b1ba93f51f8e59220f1488cb |
|
16-Sep-2009 |
Andrew Stadler <stadler@android.com> |
Fix NumberFormatException in POP3 message sync
* Write unit test to replicate failure(s) in POP3 use of parseInt. All
calls to parseInt must be guarded by try/catch NumberFormatException.
* Fix the failures
Bug # 2115586
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 0d1078363581db8caded06cf94e729e88a88761a |
|
19-Aug-2009 |
Andrew Stadler <stadler@android.com> |
Finish loading large IMAP/POP messages
* Handle messages >25k
* When structure is available (e.g. IMAP) pull in the entire body
and the list of attachments
* When structure is not available (e.g. POP) pull in a large chunk of
the body to try and capture the message body at least.
* Implement loadAttachment for IMAP/POP to demand download large items
* Tested with IMAP & POP messages
INCOMPLETE (file bugs):
* implement logic for the old loadMessageForView calls that comes from
MessageView (when you open a message that's partially-loaded)
* Resolve handling of mimetype when attachment info is read (currently
we're assuming base64 in a couple of places)
* delete account => delete attachments
* delete attachment => delete file
* create account => clear existing attachments for acct id
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 4f23ebd3dcca596533a33e6faedb446a814d32e3 |
|
25-Jun-2009 |
Takaoka G. Tadashi <takaoka@google.com> |
Fixed Pop3Store to be able to delete message in Inbox.
When delete policy is DELETE_POLICY_ON_DELETE, PENDING_COMMAND_TRASH
will be invoked. But in POP3 account, because of 1) Inbox is
OpenMode.READ_ONLY, 2) getMessage(uid) just after open() is not work
correctly, 3) remote Inbox folder is not closed after deleting message,
PENDING_COMMAND_TRASH does not work. And also the fat that some POP3
server use UID with '-' prevents PENDING_COMMAND_TRASH to recognize
the message is remote message.
Internal Bug: 1651709
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| b011a812e05902d7e417b8c47acc90a592f4b412 |
|
22-May-2009 |
Andrew Stadler <stadler@android.com> |
Fix the java.lang.StringIndexOutOfBoundsException that occurs when an SMTP server closes the connection early or returns an empty line.
Fix the same error in the Pop3 UIDL parser.
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 5551f7feb210313aaf3e5a33cdaec5f991ba3288 |
|
24-Apr-2009 |
Andy Stadler <> |
AI 147714: New, lighter-weight version of CL 147620. Still touches as many files,
due to API change, but still has a smaller footprint. Also fixes the
bug in the original, which is that we actually needed to udpate the
local trash folder, not the remote one.
BUG=1807499
Automated import of CL 147714
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| b633efa2b7386b814ff5b9cd05af4c1c8a905fb7 |
|
24-Apr-2009 |
Andy Stadler <> |
AI 147708: Automated g4 rollback of changelist 147620.
*** Reason for rollback ***
We figured out a simpler solution affecting fewer files - we
don't actually need the new remotestore API.
*** Original change description ***
Some stores require changing the UID of a message when it is
copied to a new folder (I'm looking at you, EAS). Add a callback
to Folder.copyMessages() which allows the store to report back
such changes. Then, add a new api to record the new values:
Folder.updateMessages().
For now, the two APIs are linked by a common callsite in
MessagingController, so the existing stores can use a minimal
implementation - if they don't call the callback, nobody will
call the update.
BUG=1807499
Automated import of CL 147708
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 1df530294d37573e1b1a97bc1c01a43af3127224 |
|
24-Apr-2009 |
Andy Stadler <> |
AI 147620: Some stores require changing the UID of a message when it is
copied to a new folder (I'm looking at you, EAS). Add a callback
to Folder.copyMessages() which allows the store to report back
such changes. Then, add a new api to record the new values:
Folder.updateMessages().
For now, the two APIs are linked by a common callsite in
MessagingController, so the existing stores can use a minimal
implementation - if they don't call the callback, nobody will
call the update.
BUG=1807499
Automated import of CL 147620
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| c6039f7d17eea53ea7aa59dfade42d9546440929 |
|
14-Apr-2009 |
Andy Stadler <> |
AI 146134: Add persistence API for remote stores & folders to use while
syncing. This provides a key-value store, per folder, that
can be used by network Stores to record persistent data such
as sync status, server keys, etc.
Note that, by definition, this only applies to remote folders
(e.g. IMAP, POP3). You'll see everywhere that LocalFolder is
passed null, and this is correct - LocalFolder *is* persistent
storage and does not need external help.
Note to reviewers: The core changes are Folder.java,
LocalStore.java, and LocalStoreUnitTests.java, so please give
them the bulk of your reviewer attention. The other files
are just following along with minor API changes. Of those,
the one worth close examination is MessagingController.java,
which is the only place in the system where remote Folders
are bonded with Local Folders and thus where this new API
comes into play.
Note to jham: Can you please take a look at
LocalStore.LocalFolder.setPersistentString() and recommend
better SQL foo than my primitive test-then-update-or-insert
logic, which is not transactional or threadsafe.
BUG=1786939
Automated import of CL 146134
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| cd7e5664f9de81dbe3ba8e57941ca6aa6c1dc3d7 |
|
14-Apr-2009 |
Andy Stadler <> |
AI 146061: Add persistent storage that Store classes can access.
The current design for Store classes (e.g. IMAP) did not provide for
any persistent storage. This is the beginning of a mechanism to
provide that. It's quite simplisitic - each Store can read/write one
persistent string - but that's enough for the first simple use case
(saving some sync data for EAS).
The core changes here - suggest reviewing first - are in Account.java,
Store.java, and AccountUnitTests.java. Everything else is just
following the API change that was necessary.
Note that, by definition, this only applies to remote stores (e.g.
IMAP, POP3). You'll see everywhere that LocalStore is passed null, and
this is correct - LocalStore *is* persistent storage and does not need
access (so far, at least).
BUG=1786939
Automated import of CL 146061
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| ae8ca3fbd1545c3a94011d7d70bcadac99e7779f |
|
27-Mar-2009 |
Andy Stadler <> |
Automated import from //branches/donutburger/...@143018,143018
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 3469902379242c723b871d1dcb09b02d0998d538 |
|
19-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //branches/cupcake_rel/...@140373
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 3b85e2c2b5662c58525baa41479e42c59e292f66 |
|
13-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //branches/cupcake_rel/...@138607
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 96c5af40d639d629267794f4f0338a267ff94ce5 |
|
04-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //depot/cupcake/@135843
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 8c2158a5ebb88e226c23b66ff95910158a2727df |
|
04-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //depot/cupcake/@135843
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 687f9962d7095e18ef994cd0e64337f02ed1a5bd |
|
18-Dec-2008 |
The Android Open Source Project <initial-contribution@android.com> |
Code drop from //branches/cupcake/...@124589
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|
| 8978aac1977408b05e386ae846c30920c7faa0a6 |
|
21-Oct-2008 |
The Android Open Source Project <initial-contribution@android.com> |
Initial Contribution
/packages/apps/Email/src/com/android/email/mail/store/Pop3Store.java
|