History log of /packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
1461b5333aab31faee65272d64c2ac7f9809d4d0 05-Jun-2012 Eino-Ville Talvala <etalvala@google.com> Rename Camera to LegacyCamera for SDK inclusion.

The SDK needs a camera app that does not require GPU acceleration.
The Camera app from 4.0.4 meets these requirements.

Change-Id: Idb42d4b9e47d584ef1da10e3ba672d537c8db94b
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
90089f9eddde732725c43dcad07f4567ed8cb776 18-Nov-2011 Wu-cheng Li <wuchengli@google.com> Update camera sound API.

bug:5640219
Change-Id: Ic3af6527f3025ec04ba4be16b621b462f89953f1
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
0e3f8387302b4aa882c20891f1faba74030f1a4f 16-Nov-2011 Eino-Ville Talvala <etalvala@google.com> Fix EffectsRecorder error path handling when ending recording.

Previously, if mRunner had already been set to null, errors sent by
mediarecorder would not be propagated to VideoCamera correctly. This
resulted in crashes when putting device to sleep right after starting
timelapse recording with effects.

Bug: 5627242
Change-Id: I3ae3c713a0aaf9a4507442bbbcd3ec89971d5f95
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
a7a6a7822799f6630f127e931ac7f6e1cd3f685e 16-Nov-2011 Pannag Sanketi <psanketi@google.com> Merge "Start Effects Recording only after preview loads" into ics-mr1
87e72ba9d89f8b83b1356f17077b9652346a29d4 15-Nov-2011 Pannag Sanketi <psanketi@google.com> Start Effects Recording only after preview loads

Start Effects Recording only after we get SurfaceTexture Callback in
EffectsRecorder, and
hence preview loaded. Disable the shutter button on creation, and
re-enable it on the preview callback. Else, one could potentially start
the recording before the preview loads, leading to a wrong state
information and an eventual crash.
Related Bugs: 5605173, 5605658

Change-Id: I2ed766997294c165ce6c262cf47f124493d0c5ec
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
f30e0fcdd498713b82f8ad0922baa4a8f030dcd9 15-Nov-2011 Eino-Ville Talvala <etalvala@google.com> Merge "Switch sound playing to use Camera.playSound()" into ics-mr1
8d51fc281ca4e14c87eac278d153e162c0e1fcf2 11-Nov-2011 Pannag Sanketi <psanketi@google.com> Mirroring issue in Background Replacer

The MediaSource is set to rotate so that it adjusts to the
rotation of the device, and displays upright. The backdropper does not
have to do any rotation except for the mirroring in case of front
camera.
Bug: 5490654

Change-Id: Iaa3a82dd98f9cf428fb0d0b65e1175b31d37d2b1
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
d628e27f561c4bedf0d457f64270fc12740b5280 09-Nov-2011 Eino-Ville Talvala <etalvala@google.com> Switch sound playing to use Camera.playSound()

Instead of using a few private APIs to properly manage audio output
for panorama, effects recording, and focus notification, use the new
Camera API for sound playback.

Bug: 5447107
Change-Id: I7d5a3d9502f36c199ea75a89e2c6b878185f880f
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
a83a9a6b43682406f2332e6329ad0d90d175e7af 28-Oct-2011 Eino-Ville Talvala <etalvala@google.com> am c3a0c2d4: Update recording orientation in more states.

* commit 'c3a0c2d4b7c1ec7bd8dc6190a0a68a6ff90cb629':
Update recording orientation in more states.
c3a0c2d4b7c1ec7bd8dc6190a0a68a6ff90cb629 28-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Update recording orientation in more states.

Once effects preview was started, no changes to recording orientation
would take effect. This results in incorrectly oriented videos for the
front camera, if the device is rotated after an effect is selected and
before recording is started.

Bug: 5531485

Change-Id: I0b59d72d446275f4a3b8dc7aabc98783efdd17cb
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
14a3ffc328740e8fd4734dfa124e4682df8bdd4a 20-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Add portrait support to effects pipeline in VideoCamera.

Needed to enable app to switch to portrait for startup speed. Still
supports landscape for landscape-native devices.

Bug: 5446617
Change-Id: I9853ff50d9fcd8cf53cc6e65d6c16319c1b27f76
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
07b77037f2f5aa28d6d3188f78588dc7f2d49398 24-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Add missing state check in EffectsRecorder startup path.

When starting up, the EffectsRecorder gets a callback when the effect
filter graph provides an input SurfaceTexture. This callback was not
checking the EffectsRecorder state correctly, and if stopPreview was
called on the EffectsRecorder between startup and before the callback
fires, the callback would improperly reset the recorder state,
resulting in NPEs down the line.

Bug: 5493458
Change-Id: If552b7c0ea82e1506f0b22eb5fa0447c1ca4adf8
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
cfc9bcc6dc56135d905ffdaaf1b9838cf12a1558 21-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Fix race condition in preview startup.

A small window of time exists between starting preview and the graph
getting fully configured, in which stop preview calls would be
incorrectly ignored. Add a new state to effectsrecorder to reflect
reality a little better.

Bug: 5493458
Change-Id: I76542b6970186c288ec908f3bb558217fd7d00e8
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
58cede9e3e8004f6be9731e9cb9a135238a2efd8 20-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Effects: shut down camera preview when unexpected graph closures occur.

If the graph runner needs to shut down a graph due to an error, previously
the surface texture connecting the camera to the processing graph would get
released before camera was told to shut down preview. This led to various
abandoned surfacetexture errors in the camera HAL, sometimes including
native crashes.

Now properly uses the SurfaceTextureSource callback to detect unexpected
graph shutdown to clean up the camera before the SurfaceTexture is released.

Bug: 5451833
Change-Id: Id130c1e5deb27cffab335affaa1ed55f04c260a5
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
7b9a10fef160cd452f7905ee52f7b9ac2262faf5 20-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Merge "Fix effects orientation handling." into ics-mr0
51b06d6696a4743339d026b3b3bd282645725b27 20-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Fix effects orientation handling.

Effects orientation was incorrectly using the
CameraInfo.orientation field to adjust for true down for face
detection, background replacement, and effects recording video
orientation.

The input surfacetexture from the camera already takes
the orientation into account in its transform matrix, resulting in
incorrect rotation amounts.

Bug: 5488310
Change-Id: I4c4105c44d361ca245874a47e4ff7b93cbd3bb06
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
db1596dc704d2085a3f2f7b5652e6cb43696c265 20-Oct-2011 Pannag Sanketi <psanketi@google.com> Support for max duration recording with effect

Related to Bug: 5472397

Change-Id: I3634b1c9248da24eb82ff825fe52f4262e59d0e7
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
d979079aa0735beb302dd58797af0c6b600edfea 13-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Add timelapse recording support to effects mode.

Bug: 5452088

Change-Id: I87c69e715ccdd6c48f18ecaa1fb4f362e2a9d567
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
9c96da0c452cf980eb368cbb5a63afc4ab5f4bc4 14-Oct-2011 Pannag Sanketi <psanketi@google.com> Fixing size limit error on video capture intent with effects

There was a problem with size limit using video capture intent with the
effects on. The video would not recorded. This fixes that error, though
the limit seems to be reached very soon (~5s).
Related to bug: 5441217

Change-Id: I1ea372840831c8d0852368cb99fd2edecf1a3083
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
f3d505afe66e0961e904027e8ab98455ccd3bd2e 14-Oct-2011 Rodrigo Carceroni <carceroni@google.com> Merge "Bug 5383077: handle video thumbnail generation correctly when effects are on" into ics-mr0
caf8466dcdf6d6c496e46961bb3132126363ef83 14-Oct-2011 Rodrigo Carceroni <carceroni@google.com> Bug 5383077: handle video thumbnail generation correctly when effects are on

Change-Id: I94d63c99dd8b8a488f5c8d660c592bc34d1b7360
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
f3b7efa21a1f2b365655acd8efffbdc1b83e6b0c 14-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Disable AE/AWB locking when shutting down effects.

Bug: 5463413
Change-Id: Idcd338adc5835e5a211e977b22a090e9dd2dfe4a
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
e3fd19525c55e58025faa0508c16fd410a159a5f 14-Oct-2011 Pannag Sanketi <psanketi@google.com> Merge "Fixing crash in video capture intent with effects on" into ics-mr0
7e6b690c96b36b134d6825562b4ae66e055ba6a8 03-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Set logging in effects recorder back to normal. DO NOT MERGE.

- Cherry-pick of change in master.

Bug: 5404515
Change-Id: I3757e5ae2a032182ffe323e0cb0352b008f78181
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
dca2af0a95ccb682d57bcea43f03fb01b929edf3 14-Oct-2011 Pannag Sanketi <psanketi@google.com> Fixing crash in video capture intent with effects on

The video capture intent sends an uri and not a filename. Adding
support in the EffectsRecorder and VideoCamera for uri. The
effectsrecorder passes that on to the MediaEncoderFilter.

Related to bug: 5441217

Change-Id: I784a6c3b53a586950adcc07a6e26659838ae3cbc
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
6baaa42a5bb88fdae55efa8dc6b7805b187f1d02 13-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Merge "Play a sound when starting and stopping recording with effects." into ics-mr0
07d5f8c27d144f7e72820b48fe5cb08f691435ad 12-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Add video stabilization management to the application.

- Still image mode: Disable vstab if it is supported
- Camcorder mode: Enable vstab if it is supported
- Camcorder with effects: Disable vstab when using
background replacement, enable otherwise

Bug: 5440224
Change-Id: Ibb9744b601d9bb122618e5eeaec00f50ee54cbee
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
85a5556fb58f1cdc016f5afe5e07cbe1b419ffd8 12-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Play a sound when starting and stopping recording with effects.

Normally, CameraService takes care of this, but with the effects
recording, CameraService doesn't know when recording is toggled on and
off. Mirrors the code in CameraService.cpp in terms of enforcing audio
output.

Bug: 5383166
Change-Id: I2175c1090ff57884d17cb422532a7930f29e10de
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
2c2550bd42c614330a3c968bda005ac23d12f8d1 05-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Properly mirror video for front camera effects recording.

- Incoming transform from camera SurfaceTexture is mirrored
for front camera
- Recording preview needs to be mirrored, but the recorded
video needs to be unmirrored.

Bug: 5408479
Change-Id: I0cdb29151ae20b02f690fb976e5a29e594c094a1
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
d5ec81fea464e1f9db3cb06f7db3de3cf2e3be94 01-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Add support for rotating background video based on device orientation.

Bug: 5355973
Change-Id: I5c0145a717c22b9423341988b90c4962ad333337
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
d519d3bff76107eda37dfc81b6d1a7c6e0091e42 03-Oct-2011 Eino-Ville Talvala <etalvala@google.com> Temporarily increase logging verbosity to help track down crashes.

For bugs: 5388119, 5388011, 5397146

Change-Id: I6f7c8d526629bb63f3d026a702fc944902c35c8f
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
d97adb8f99e522a613d484d9d5725dd84921489f 29-Sep-2011 Marius Renn <renn@google.com> Initial fix for bug 5357970: Camera now handles errors during effects recording.

For now, the camera front-end deletes the recorded file and then continues
to throw the exception upwards. Recovering from this situation gracefully
will require more work and testing.

Change-Id: I98814d5143090f1bc7b92561fd7aae58b3a166a6
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
a91df49eb460aec8bcae4169e7d29ddc7f9ac3ec 28-Sep-2011 Eino-Ville Talvala <etalvala@google.com> Make sure correct GL context is active when tearing down effects.

Previously, filter graph teardown occured in the wrong GL context,
resulting in UI corruption and likely the failure to properly release
filter resources.

Bug: 5353684
Change-Id: I023c23ce7cb590bc8af5cd9b039d901a290eebc5
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
926405a84a882ab78f2f5aa1e88c4961640724f7 20-Sep-2011 Eino-Ville Talvala <etalvala@google.com> Restrict effects to 480p.

- Preview stretching still occurs after some transitions.
- Correct quality used in recording, shown in UI at all times.

Bug: 5320425
Change-Id: I63612c55d2e6e0e979208c59f2caf9a61ac1d3f8
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
1e99673af90451eaffeb100735f38e6ce0f18456 22-Sep-2011 Wu-cheng Li <wuchengli@google.com> Add clear effects button, silly faces title, and background title.

bug:5226051

Change-Id: I61609e31fb8f18041f6885cb923507aeecfd9c9f
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
a7409d87247162002fca1719c035de67fa7e7535 20-Sep-2011 Eino-Ville Talvala <etalvala@google.com> Effects: Fix SurfaceTexture abandon/disconnect errors.

- Now ensures that camera preview is stopped before starting or
stopping the effects processing, and that the previewTexture
is set to null.
- Fix a few potential race conditions relating to effect switching
- Tear down old graphs properly

This fixes errors relating to SurfaceTexture disconnect/abandon errors
when swapping between effects, and possibly some rarely-occuring race
condition crashes.

Bug: 5328760
Change-Id: I6b655f32b835e7ac65cb7c8dc533befb5177907c
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
3ac6ed3a95322fa9e29f81377e92669ebaeb77fb 14-Sep-2011 Eino-Ville Talvala <etalvala@google.com> Fix orientation handling for Effects mode.

- Did not correctly set mDisplayRotation for effects mode
This caused very slow startups for effects
- EffectsRecorder does not need camera facing adjustment
- onOrientationChange did not properly calculate orientation
for effects

Bug: 5309932
Bug: 5311545
Bug: 5280905
Change-Id: I2c5b240f42cebfaad974176f72864c61e1861042
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
2670b3d7c318604f07b680b22360d349103144be 07-Sep-2011 Wei Hua <whua@google.com> Added Orientation change support for goofy face effect.

bug: 5221073
Change-Id: Iff414f33fe389f0bac8f75920d8a14283f4a4d2e
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java
9efb0b19fa929c528253f0a9b6f5b27791e1ee52 20-Aug-2011 Eino-Ville Talvala <etalvala@google.com> Add video recording with effects into Camera.

Initial support for video recording in the Camera app, with
the goofyface and background replacement effects.

Bug: 5212166

Change-Id: I30995e305c202ba57bf76ff18c885bf16c5ea14f
/packages/apps/LegacyCamera/src/com/android/camera/EffectsRecorder.java