History log of /external/webkit/Source/WebKit/android/jni/WebHistory.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
49a105247bbbb06b1f1ec85c542d4dd5b1b019c3 05-Sep-2012 John Reck <jreck@android.com> am 43e94fa8: am 1a6030e7: Merge "Remove inconsistency between HistoryItem writing/reading"

* commit '43e94fa8daa7eaaece0da98e14809891b3fd2b4c':
Remove inconsistency between HistoryItem writing/reading
8eb920de3073bded959828bd4933affe577e7730 20-Apr-2012 Yaroslav Miroshnychenko <yaroslav.miroshnychenko@sonymobile.com> Remove inconsistency between HistoryItem writing/reading

Fixes inconsistent writing of HistoryItem formData
for the case when formData is not null,
but it gets flattened and saved as empty string.
FormData identifier also gets written in that case,
which creates problem on HistoryItem reading,
when parser does not expect to meet form identifier
after it reads zero as FormData size.

Change-Id: I77cf00b5b2a0f2a7cf4355d1bc1b8d4830ac1afb
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
8bb1e0806dfd76399d73ca2675c96abd2817ed6d 31-May-2012 Jesse Greenwald <jgreenwald@google.com> Support separation interface and implementations of WebView classes

WebBackForwardList and WebHistory item are now separated in the Java
code. This change is for the correpsonding JNI code.

Change-Id: I7358932be6cd82d8558575e953246d9d065da9c2
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
4d31493c3fa47a28b2753bc5b99e2074b6a7a4df 22-May-2012 John Reck <jreck@google.com> Handle more favicon decoding error cases

Bug: 6517530
Switch to having webcoreImageToSkBitmap return a pointer instead
as it makes dealing with error cases easier. Also add a check to
see if SkImageDecoder::DecodeMemory returned true or false, as if
it returns false we may have already allocated pixels (so isNull = false),
however it might not have valid data or any config

Also aggressively check that we have a valid bitmap with a valid config

Change-Id: I2a2e856a389d73cdda319eaeaee5d1279a9e2eb6
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
d236e597b13a93d21eafa2edeacb5092076937e1 10-May-2012 Jeff Brown <jeffbrown@google.com> Ensure getFavicon() does not return uninitialized bitmaps.

While a web page is loading, it may not have a favicon. We should
return null in this case.

Bug: 6467873
Change-Id: Id3ee882fdd59679f3cfddb739661e020a4463399
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
e38a6c283211dcfd3b1fb390e4c108a86481dd8a 07-May-2012 John Reck <jreck@google.com> Delay creating Java objects for WebHistoryItem

Bug: 6447632

Change-Id: Ib2fb66f607dd62ffa2d8acbe5882ad6219413120
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
859c01f9680c58ddff5938862087b41478acd0a0 24-Jan-2012 Russell Brenner <russellbrenner@google.com> Fix uninitialized return value for decoding

WebCore::TextEncoding::decode() has a return flag, passed by
reference, which is set only upon failure, remaining uninitialized
upon success. The flag is now initted to false by the caller. If it
then changes to true, it indicates an actual failure, so we exit
early.

Change-Id: Ie4655349b8e44d92e8d7cc7531a6bcc077efbb34
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
541839a11103a72d486edaab8a5c9e9499554511 24-Jan-2012 Russell Brenner <russellbrenner@google.com> Refine WebHistory log output

Log output is more explicit upon failure, but otherwise quiet.

Bug: 5143832
Change-Id: I8696c36277b0fac12698b4ace9cf4131344f6a0c
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
e18ec51fbe570f52876a50202d603346eb1bbd01 23-Jan-2012 Russell Brenner <russellbrenner@google.com> Revert "Enable verbose debugging for WebHistory"

This reverts commit 5c18ff59df2320908e33f4b17675650073b5d22b.
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
5c18ff59df2320908e33f4b17675650073b5d22b 13-Jan-2012 Russell Brenner <russellbrenner@google.com> Enable verbose debugging for WebHistory

Turn on logging of WebHistory read/write and activate ALOG_ASSERT.

Change-Id: Id68b9b294f826f77bbfbc6f19d1e09d23cce98a1
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
08767a79b9fae453edaed3c64afe1f52ba64b195 13-Jan-2012 Russell Brenner <russellbrenner@google.com> Refactor WebHistory

Code for reading strings and other data types has been refactored
into support routines.

Modified comparisons and pointer-based math to remove potential
overflow errors when handling corrupted data.

Remove unnecessary call to RefPtr::clear().

Bug: 5143832
Change-Id: I2f1a6b3d12cfeb2e8226e190dcd9e391609760a1
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
9cff7e8839f4cd5caf01f005647176461f329a8d 13-Jan-2012 Russell Brenner <russellbrenner@google.com> Update unitTest to match current WebHistory

New elements have been added to WebHistory over time without making
corresponding changes to the unitTest code. This brings the test code
in sync with the current WebHistory class.

Change-Id: I8cde579d2820e8f5c72cf34b264ee2e57a4acbd9
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
c8c13e36333629a06a196f84e75f2cc8ae5df24e 13-Jan-2012 Russell Brenner <russellbrenner@google.com> Basic code cleanup

Change function names for WebKit style, from this_style() to
thisStyle().

Replace terse variable names with ones that are more expressive:

l => fieldLength
v => vector
e => encoding

Move from WebKit logging (LOG_VERBOSE) to platform logging (ALOGV).

Change-Id: I303bb03cb29031ae39e79c2f722c2247dbf9f888
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
6dd76b804786ec760bb04b137a6bf017064226dc 09-Jan-2012 Steve Block <steveblock@google.com> Rename LOG_ASSERT to ALOG_ASSERT DO NOT MERGE

See https://android-git.corp.google.com/g/157519

Bug: 5449033
Change-Id: Icaed25ccf4d689b533101e966e8303810b61b0d4
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
7d99b5804f0800191b03d83fc8f8d2886271475b 06-Jan-2012 Steve Block <steveblock@google.com> Rename (IF_)LOGW(_IF) to (IF_)ALOGW(_IF) DO NOT MERGE

See https://android-git.corp.google.com/g/157065

Bug: 5449033
Change-Id: Ia6cf33690679476e7d39c63fa59505491217fdde
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
a09e7cf49f43950a799f936bf42a9912d696547b 20-Dec-2011 Steve Block <steveblock@google.com> Rename (IF_)LOGD(_IF) to (IF_)ALOGD(_IF) DO NOT MERGE

See https://android-git.corp.google.com/g/156016

Bug: 5449033
Change-Id: I35a9fa5e53a83a9c9a920333a3752dd151fbd3b8
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
45ffd2b3015a81f6287b0ec7278f30ee0fc907e0 12-Dec-2011 Steve Block <steveblock@google.com> Fix use of LOG_VERBOSE in WebHistory

This fixes the debug build.
See https://android-git.corp.google.com/g/#/c/150512

Change-Id: Id85c11788c2ad913f8826aa55f49f25401b7ee42
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
54dddd414a10f9c661f181d016b49b1803373ed3 30-Nov-2011 Russell Brenner <russellbrenner@google.com> Use unsigned length when reading data

With a signed length, invalid negative sizes can bypass data limit
checks of the type:

if (data + length < end)

With an unsigned length, absurdly large lengths will now trigger an
early exit instead of following through into the decoding routine
with a bad length.

Bug: 5143832
Change-Id: I50c636ccfbc82a297df802572cf85972dddf8213
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
3577745d3cfbfe2b7ebb3cddb1abda7026a61ac5 16-Nov-2011 Russell Brenner <russellbrenner@google.com> Use RefPtr instead of PassRefPtr for WebHistory

In read_item_recursive, there are two instances of PassRefPtr which,
according to docs at http://www.webkit.org/coding/RefPtr.html, should
rather be RefPtr.

Bug: 5143832
Change-Id: Id8315d3d67de9e0dfc24bd70fdc0b6ef4a25a8a1
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
2df3aefb377b3f3c4af3b548b1980d8c8ae56844 20-Oct-2011 Steve Block <steveblock@google.com> Rename LOGV(_IF) to ALOGV(_IF) DO NOT MERGE

See https://android-git.corp.google.com/g/#/c/143865

Bug: 5449033
Change-Id: I821098330652380686aca9e83222936bd5678970
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
d20466cbeb31c73eace8f0c4eb6c717b1e1ae540 21-Jul-2011 Shimeng (Simon) Wang <swang@google.com> Safely convert punycode IDN to Unicode for display.

Use chromium's net::IDNToUnicode to accomplish this, which adopts
safe measures for converting.

issue: 4384726
Change-Id: If265a849ff0e9d6782705fc1639391bab9e6bcab
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
2f4ef9300ef5b74c660927a63057e2fcff0e1905 03-Jun-2011 Steve Block <steveblock@google.com> Merge WebKit at r82507: IcondDatabaseBase::iconForPageURL() renamed

See http://trac.webkit.org/changeset/81484

Change-Id: I72f818d5d0075c63b658c2d8457d2182a7968c05
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
d937470c29d31833299da3bb47599e43db82852b 24-May-2011 Ben Murdoch <benm@google.com> Merge WebKit at r80534: Fix IconDatabase uses.

WebCore::iconDatabase() now returns a reference rather than a
pointer. Update our calls to reflect this.

See http://trac.webkit.org/changeset/80299

Change-Id: Iebf2f199fd8913e227572753cee2cf3a2e380985
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp
a2c606d1d8312a5d063e4a11e5911d9c8e4a3d19 13-May-2011 Ben Murdoch <benm@google.com> Merge WebKit at r75993: Move WebKit/android files to Source

Change-Id: Ifa871f8320bdb3a09fe189fffecc23f702c394b9
/external/webkit/Source/WebKit/android/jni/WebHistory.cpp