History log of /frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
76889f3482d6391b17f0961f7356c1e8169c8813 09-May-2012 Adam Powell <adamp@google.com> Forgive me monkeys, for I have sinned.

It has been several hours since my last commit.

Fix an obscure bug that could cause call ordering problems while
updating ListAdapter-based MenuPresenters. This would trigger an
inconsistent return value from the adapter's getCount method that
didn't take the expanded menu item into account, resulting in the
infamous ListView "you didn't call notifyDataSetChanged" exception.

Bug 6412318

Change-Id: I6262846d9c2acdb87ff99116ad78ca4a388efa6d
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
275702c2f47ed87ab642462530092d9777f32ecd 24-Sep-2011 Adam Powell <adamp@google.com> Fix bug 5355889 - Search action showing up in the menu dropdown in
spite of search actionview being expanded

Make sure that menu items with an expanded action view don't show up
in list menus presenting the rest of the menu.

Change-Id: I8c7b4e184a9d3ea2457543d0b8b36bc8e7068052
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
9151103ff20d28e8db2a2cc0386d57b8dad4b5d5 13-Jul-2011 Adam Powell <adamp@google.com> Preserve spacing for icons in menus

Change-Id: I3269fcffb98a84b6a5c5f9198afd2b2eae7d5f02
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
11ed1d6cae9214335c92ac38498a4e6c7d1c8324 12-Jul-2011 Adam Powell <adamp@google.com> Fix bugs around restoring submenu state after activity teardown/restore

Change-Id: I6cb5b3cad39b141dff84b8e0ca62f8f0a76a03b1
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
42b91bbcdaf64b2f19d0a9ce168964b31a5dc139 22-Jun-2011 Adam Powell <adamp@google.com> Fix bug 4818050 - Need a way to get notified when a PopupMenu gets
dismissed/canceled

Add an OnDismissListener to PopupMenu.

Change-Id: I7abe1b9c9bea5e758a9c32631185e50cd7eb1ed0
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
38639b1d75933bfb720db79fce26f09478709614 18-Jun-2011 Adam Powell <adamp@google.com> Fix bug 4689431 - PopupMenus too narrow on phones

Change-Id: I624b46d17c1d964fd6cb04abf96333c7a8474d75
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
8d02deabac62c4a68a335a7b3141795466362b89 01-Jun-2011 Adam Powell <adamp@google.com> Implement bug 4500971 - Collapsable action views

Action views may now be flagged as 'collapsable'. This means that the
action menu will always show them in the collapsed state by
default. When selected, the action view will "take over" the
navigation/view side of an action bar until dismissed via the home/up
button.

This feature allows for more long-term exclusive modes akin to
ActionModes but less intrusive. The action menu itself remains
unaffected. Collapsable action views are ideal for things such as
search or categories of tool palettes.

Change-Id: Ibafce5631befbfe67c5d834c2e2617d3d7f6da7a
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
696cba573e651b0e4f18a4718627c8ccecb3bda0 29-Mar-2011 Adam Powell <adamp@google.com> Refactor menu internals.

In the old world, MenuBuilder and MenuItemImpl were responsible for
generating views for any presentation of a menu. MenuBuilder needed to
know any types and resources involved, and the implied caching
semantics did not work well for menus presented within AdapterViews.

In the new world, the MenuPresenter interface takes over the
responsibility of generating views or adapters for menu
items. MenuBuilder/MenuItemImpl still provide extra metadata tracking
used by these presenters. Mutiple presenters may be active for a
single menu at a time. All of this remains internal framework
implementation details.

BaseMenuPresenter provides a simple base for presenters that treats
the host MenuView more like an AdapterView. This allows for less
rebuilding of views when items are added/removed.

Callbacks have been restructured. Calls that relate to the menu itself
are still handled by MenuBuilder.Callback, but calls related to a
specific presentation of a menu are handled by MenuPresenter.Callback
objects attached to a MenuPresenter.

Also add API to programmatically set divider options for LinearLayout
and hidden API so that ActionBarView can have finer-grained control
over divider placement.

Change-Id: I2265b86a084279822908021aec20dfbadc1bb56b
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
4afd62b18c52a55371ab923d54f93615ad68fd7a 19-Feb-2011 Adam Powell <adamp@google.com> Add an API to listen for window attach/detach events on a View.

Fix bug 3312949 - inconsistent state in MenuPopupHelper

Change-Id: Ie802ada3f8de4cf71c92fcc7c6abce9ba85e7b75
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
ca51e8788a58f2af3525b7214a675f2d0233e5da 15-Feb-2011 Adam Powell <adamp@google.com> Fix some bugs with MenuPopupHelper and ListPopupWindow

Clean up handling of a few conditions in MenuPopupHelper that the
monkeys manage to trigger around the use of ViewTreeObserver. (bug
3443819, bug 3312949)

Fix a bug where a stale handler message could cause a ListPopupWindow
to reopen itself after being dismissed. (bug 3453607)

Change-Id: I488014767ccee785500862a2572beb35901d173b
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
e2b03a62e5014ea60e24a989544fa549b493a520 25-Jan-2011 Adam Powell <adamp@google.com> Fix bug 3387855 - Menu flashes on left side of screen

Post popup menu click events rather than executing inline so that the
popup can close undisturbed.

Change-Id: I01481bd37d7921c10c6b8b484eab33f0d25447ff
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
f0ad6e6eaf48ac8f4007232ad0a8511a7b5cfc0e 11-Jan-2011 Adam Powell <adamp@google.com> Fix bug 3333015 - Overflow menu item submenus do not open

Submenus of action bar menus will open as new menus.

Change-Id: I924b87bbea91b0df5e3608ec894530302c0e1d8d
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
5e3f284baa271cb0fbf90e504d19fdd2e385382e 08-Jan-2011 Adam Powell <adamp@google.com> Fix bug 3200615 - "MenuPopupHelper cannot be used without an anchor"

Add protection against views disappearing before previously posted
Runnables attempt to show a menu anchored to them.

Change-Id: Ia2a322e76665e61feb5bdb92377d5066cb6d5b04
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
1700ae0aef4e6a3f412b758389955abd049060db 20-Dec-2010 Adam Powell <adamp@google.com> Fix bug 3295495 - Wrong menu item selection in PopupMenu

Change-Id: I17ec55f09dbed9797cb702a7252f6c89e861cc6a
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
50f784cf2dc2dea8061153ac3a843f60a9d88781 20-Dec-2010 Adam Powell <adamp@google.com> Measure spinner items for sizing the dropdown view.

Only a limited window of items will be measured around the currently
selected item.

Change-Id: Ie0431948fdd564fa4bbeb82dede9e2abebbaee55
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
aa0b92ce2b51987e9c864164234fe968ab5b9311 14-Dec-2010 Adam Powell <adamp@google.com> Fix bug 3210201 - Popup window wrong size/position when IME hidden

Fixes a case where ViewRoot does not recompute its size properly.
This caused various offsets to get out of sync and the window would
draw improperly.

Change-Id: Id0abb37bbf27b60de2dca4077c21040ec84ef163
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
8515ee846bd76aee86ec5ddfcc4dd1e626dd999c 30-Nov-2010 Adam Powell <adamp@google.com> Fix bug 3240444 - add OnMenuVisibilityListener for action bar.

Fix bug 3180015 - leaking window handles on configuration change for
action bar dropdown menus

Rename ActionBar.NavigationCallback to something more consistent with
the rest of the API.

Change-Id: Ic1fb4c07484c57a72649b30e27d220b18cda6cdf
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
ed8b403cc8066bf76cdf98f8d9906ff810defc5b 16-Nov-2010 Adam Powell <adamp@google.com> Fix bug 3198503 - NPE at MenuPopupHelper.dismiss

Make sure dismiss() can be called even when the popup is not currently
showing.

Change-Id: I48077d8b3bfe0df04bceeb056ed54cbd79a6e660
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
0458796f1401732b38660794148f4c5e5602f432 12-Nov-2010 Adam Powell <adamp@google.com> Fix bug 3146938 - Menus spawned by ActionBar should hide when action
bar is hidden

Any popup spawned by the private class MenuPopupHelper will be hidden
if its anchor becomes hidden. ("hidden" == !View#isShown())

Fix a bug where ActionBar subtitle views were not going away when
subtitle text was set to null.

Fix a bug when switching out of ActionBar tabbed nav mode with no
active tabs.

Change-Id: I1f30c067156221f96905ac69ab876418ad2e94f8
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
0b2d306e7000f4c0c6ad4e00d494bb401d8a9fc2 15-Sep-2010 Adam Powell <adamp@google.com> Style new popup widgets.

Change-Id: I208ed292afd9919071778baa9ea61d7ca9e7743c
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
6c6f575423d6718c3ff322224c1520901ce881e1 21-Aug-2010 Adam Powell <adamp@google.com> More ActionBar/config change tweaks. Preserve open overflow menus

Change-Id: Ic8ad2b1e3909fbf84ff4d852ae046a9f9508477c
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
3d3da27ab394108fd51771616cca3279baae99d1 12-Aug-2010 Adam Powell <adamp@google.com> Fix bug 2911529

Change-Id: I18d7f5d8a300bbc73ef721c5d4deb200d6a490b8
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
4be0d52125b88dc992a4c500edbe95bf55484e0b 04-Aug-2010 Adam Powell <adamp@google.com> Added android.widget.PopupMenu

Change-Id: Id507cf93ebd0484f141a0a44266b883c01aa10db
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
8028dd32a4a04154050220dd0693583d5b750330 15-Jul-2010 Adam Powell <adamp@google.com> Overflow menu for action bars.

The overflow menu replaces the normal options menu panel for
activities with an action bar. It always appears as the rightmost
action button and is displayed as a dropdown menu. The menu key
summons and dismisses the overflow menu instead of the options panel
where applicable.

Change-Id: I0b4fa7e36f35ab12e2f0c1d12bec79ccab8cc4b1
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java
4267534d1c42af847ed0cefd1c88c99f66b36571 10-Jul-2010 Adam Powell <adamp@google.com> Action Bar now supports submenus as popups.

Change-Id: I1691c16081b3474ed6d6e406f91f5f74a2dc8fcb
/frameworks/base/core/java/com/android/internal/view/menu/MenuPopupHelper.java