| 1dd46a5c676325d20b7a042d0d0d3c7d9365d0bd |
10-Jun-2013 |
Yorke Lee <yorkelee@google.com> |
Fix crash in Dialer in landscape mode
Bug 9369806
Change-Id: I286ebb828c0f6ce7c005c541661b9aa67284847e
ialpadFragment.java
|
| 3a18654bf87df4f17880551b6cfa45c871917960 |
07-May-2013 |
Yorke Lee <yorkelee@google.com> |
Animation for smart dialing suggestions
Suggestions now appear with a fade in and slide up animation.
Suggestions vanish with a fade out and slide down animation.
If a suggestion is moved into the middle, it slides to the left/right
as appropriate.
Change the layout containing suggestions to a LinearLayout, in order to
better support animations.
Renamed SmartDialAdapter to SmartDialController, and also refactored
it to handle entries for a LinearLayout instead of a GridView, as well
as adding animation support and view management.
Use null object pattern in SmartDialEntry to better handle null entries.
Start displaying suggestions on the first digit entered.
Bug 8840240
Change-Id: If4e16006c0b36d2244434e0b2d8f3d3b997b0ad2
ialpadFragment.java
martDialAdapter.java
martDialCache.java
martDialController.java
martDialEntry.java
martDialLoaderTask.java
martDialMatchPosition.java
martDialTextView.java
|
| dbb6c6fc024bbacf3b495a44bdddccf8502793ae |
14-May-2013 |
Yorke Lee <yorkelee@google.com> |
Fix Dialer NPE
Make sure that smart dialing state is properly set before
any digits in the dialpad EditText is populated.
Also turn smart dialing off by default even if the system
setting hasn't been previously set.
Bug 8963485
Change-Id: If556d8b1405cc9e60043774b3aafd5e111e4e7ee
ialpadFragment.java
|
| a8fd33fdb65b936bd130a6d9c6bd4b3615d24886 |
13-May-2013 |
Yorke Lee <yorkelee@google.com> |
Merge "Setting to toggle smart dialing on/off" into jb-mr2-dev
|
| 50e3bc935962ca360d7a681cd8be90b2eee77ea6 |
07-May-2013 |
Yorke Lee <yorkelee@google.com> |
Setting to toggle smart dialing on/off
Bug 8840243
Change-Id: I1d1fea4f958821f3a9273ba189e2140367049516
ialpadFragment.java
|
| f744f53ed980ba901b458b070a1b5eb4526b69f3 |
20-Nov-2012 |
Yorke Lee <yorkelee@google.com> |
Allow vanity numbers via paste/DIAL intent
https://googleplex-android-review.googlesource.com/#/c/253417/
Converts vanity numbers such as 1-800-FLOWERS to the numeric
equivalents when the number string is populated via a DIAL intent
or pasted from the clipboard. Does not remove valid formatting such
as dashes, periods, spaces, etc.
Bug: 8858358
Change-Id: I553c91628b8fd86ff38a8eeec7823ebdc96bfe6b
ialpadFragment.java
nicodeDialerKeyListener.java
|
| 006d071bd477768b4685385d15b3385f6d2e834d |
01-May-2013 |
Yorke Lee <yorkelee@google.com> |
Apply NANP logic to numbers with a +1 country code
Bug 8769688
Change-Id: I4aadd0f9e5495fb1b604910306dfd918d1540136
martDialNameMatcher.java
martDialTrie.java
|
| ec2a6103d517a1896abffc493e5f883049872ca9 |
30-Apr-2013 |
Yorke Lee <yorkelee@google.com> |
Fix Smart dialing OOM for extremely long contacts
Names with an extremely large number of name tokens were
using exponentially increasing amounts of memory since we have
to insert entries for all possible initial name combinations.
Added a check in the trie insertion algorithm to only add initial
matches for the 1st 2, and the last 2 name tokens.
This change only affects search by initial matches for names exceeding
4 name tokens. Full token search for names of all lengths should still
work. E.g. "frank", "enstein" would still match "Dr Frank En Stein DDS".
However initial matching would be limited to the first 2 and last 2 tokens.
So "dfsd" or "fsd" would work, but "fes" or "fed" would not.
Also fixes a bug caused by integer overflow when calculating thresholds
for bucketing frequently used contacts
Bug 8737986
Change-Id: I804184368b78fe2fa407667ed83874d839c28115
martDialCache.java
martDialTrie.java
|
| a539c86d015c3eb9819cf38d1ccb04edb1461fe2 |
19-Apr-2013 |
Yorke Lee <yorkelee@google.com> |
Allow name matching for contacts with numbers in their name
For SmartDialTrie, also include numbers as valid characters when
calculating indexes when generating the byte array.
For SmartDialNameMatcher, include '0'-'9' as valid latin characters,
and handle them appropriately after remapping accented characters.
Also fixed a subtle matching bug that would manifest itself when
matching against multiple tokens with similar initials - E.g.
"Dr.Dredd"
Bug 8659001
Change-Id: If461d2760a723ef7fd03dda0c1a1515cd7b44cf6
martDialNameMatcher.java
martDialTrie.java
|
| afd650b7f81f363a4bb554ff7199338aee1a49c2 |
11-Apr-2013 |
Yorke Lee <yorkelee@google.com> |
Allow smart dialing to ignore country code/area code
Add handling of country codes if the number starts with a '+' prefix
Also add special case handling for NANP numbers in SmartDialTrie
if we determine that the user is in North America.
Save user's SIM country ISO into SharedPreferences.
Add SmartDialNameMatcher methods to correctly match NANP numbers
Fix tests to use assertTrue/assertFalse instead of assertEquals
Bug 8292294
Change-Id: Ic61dac75ee3b772986d3008240bbda81322c8f31
martDialCache.java
martDialLoaderTask.java
martDialNameMatcher.java
martDialTrie.java
|
| 4334d3b852e369b591f591e66e493cc92a721233 |
09-Apr-2013 |
Yorke Lee <yorkelee@google.com> |
Merge "Fix name matching bug with non space separators" into jb-mr2-dev
|
| 69ae7985ce26709b0acd9c376c751b8fb0ba4528 |
22-Mar-2013 |
Yorke Lee <yorkelee@google.com> |
Fix name matching bug with non space separators
Bug: 8435819
Change-Id: I69c32207d123e5da4ae5421a5fe83ffeee4e5070
martDialNameMatcher.java
|
| 9eedc6d0bcf96bb888e2839fa0fa5e7959553caa |
03-Apr-2013 |
Yorke Lee <yorkelee@google.com> |
Sort by data usage for smart dialing
Bug 8281648
Change-Id: I55bfaf137f9657a47616187fe7b7999c321b21f9
martDialCache.java
|
| f43f537a0100693570606c436a81a12e21fb5b9e |
02-Apr-2013 |
Yorke Lee <yorkelee@google.com> |
Remove smart dialing content observer
The content observer doesn't help to detect changes that happen
outside the application (e.g. user modifies a contact in the People
app), and seems to be called multiple times while in the dialer for
no reason, causing multiple unnecessary recaches. Instead, just force
a recache in onResume upon startup to refresh the cache.
Bug 8527847
Change-Id: I52f5c435ad573ce8b195d7b7828f19501e068c60
ialpadFragment.java
martDialCache.java
|
| 2eb493c61878d936bed055930a921fbea7b7e2b4 |
01-Apr-2013 |
Yorke Lee <yorkelee@google.com> |
Turn smart dialing debug logging off
Bug 8518729
Change-Id: Ib6626385c3b7cd9a6c3a18335444db21b937ea02
martDialCache.java
martDialLoaderTask.java
|
| 02329d7b2efce6ef5781bf95ecdd83f08fed8b08 |
20-Mar-2013 |
Santos Cordon <santoscordon@google.com> |
Merge "Always show WAIT/PAUSE in dialer overflow menu." into jb-mr2-dev
|
| 472c2778dd4395416fe2eb9c7ffe62a0e36a101e |
19-Mar-2013 |
Santos Cordon <santoscordon@google.com> |
Always show WAIT/PAUSE in dialer overflow menu.
Used to hide menu items when not applicable. Now we show them always
and only perform the action in those cases where menu items were
previously visible.
Updated code to do zero-position checks when there is no
selection...previously missing check.
Changed code to use chars instead of Strings when dealing with single
digits.
Consolidated duplicate code with updateDialString() function.
bug: 7478840
Change-Id: I2aa5d3badd40079e9aa75abf7e4051f9dba5e667
ialpadFragment.java
|
| f547de18f8c47703d647ac1728a219fdabca76ff |
16-Mar-2013 |
Alan Viverette <alanv@google.com> |
Ensure simulated A11y clicks in Dialer correctly send click events.
Bug: 8369906
Change-Id: Ibdf8a4d43d0898429333af03e98a9aa494e5c819
ialpadImageButton.java
|
| 4a0ae0bdce4747ca497f5ce0a6120844a5d119f3 |
08-Mar-2013 |
Svetoslav Ganov <svetoslavganov@google.com> |
Merge "Fix accessibility bug where enter key adds the focused digit twice." into jb-mr2-dev
|
| 25f258fabacd275a290b6f5ca77b6056a51a5119 |
06-Mar-2013 |
Alan Viverette <alanv@google.com> |
Fix accessibility bug where enter key adds the focused digit twice.
Bug: 8328641
Change-Id: I76fda040f709a9a5c0e88e67abfa106763b75ffb
ialpadImageButton.java
|
| a717fa7aec389df650c4ab4e1c37f3dfdfb2d16f |
06-Mar-2013 |
Alan Viverette <alanv@google.com> |
Remove ICS-era accessibility workarounds from Dialer app.
Bug: 8330225
Change-Id: I0c61e12b4090ff6eeaff5ef5791ac62814d90383
igitsEditText.java
|
| 55b030a8bbb0323a4823fc34f3167a248a0ff899 |
28-Jan-2013 |
Yorke Lee <yorkelee@google.com> |
Smart Dialling v2 with phone number support
Behavior:
Use a prefix tree to cache contacts instead of an array list
Perform matches against phone numbers as well
DialpadFragment now ignores results from stale tasks where
queries no longer match
Add ability to not use default phone number for phone number
disambiguation dialog
Contacts are now ranked by the order which they were sorted
by in the ContactsProvider (affinity)
Change remapAccentedChars to always return lowercase characters to avoid
overhead of uppercase character conversion
Resource/Layout changes:
Tweak margins so that the section containing smart dial
suggestions looks cleaner
Use color resource instead of hardcoding color values
Add phone number to SmartDial items
ContentObserver:
Add a contentobserver to be notified on changes in contacts
Refactored cache to allow for forced cache refreshes
Use a single instance of SmartDialCache
Tests:
Added SmartDialTrie tests
Comments:
Comment cleanup
Change-Id: Ica2854e2845d4d75048aa1fd982f139496d21bf3
ialpadFragment.java
martDialAdapter.java
martDialCache.java
martDialEntry.java
martDialLoaderTask.java
martDialNameMatcher.java
martDialTrie.java
|
| 24506db412615a318894c2d37b8a1ca0b0152e4c |
05-Feb-2013 |
Yorke Lee <yorkelee@google.com> |
Don't show old matches if no smartdial matches found
Change-Id: If851c291273aa5296f1d59edccc83e6d4019be76
ialpadFragment.java
|
| 697fa0977ea1d4569064c434bb86e9b9fbfc4b12 |
05-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Enable initial matching for Smart Dialling
Allow the name matcher function used by smart dialling to perform
initial matches of the variety 57 - (J)ohn (S)mith
Refactor SmartDialNameMatcher testing method to allow checking multiple
match positions.
Add tests for initial matches
Change-Id: Iadc5e3e8b2f408136c704015d2297e9b520e1065
martDialNameMatcher.java
|
| 9185a786f0e1e6d87f1add958b0e115e04ff8cbe |
07-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Fixing import order.
Change-Id: Idcab1877b341b42440e336fa09ba7d631c28c7d0
ialpadFragment.java
martDialAdapter.java
martDialCache.java
martDialLoaderTask.java
martDialTextView.java
|
| 472309228c3aaef3c5010cde35965af892f4835a |
07-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Fix build
Change-Id: If60fc1d68bf7d32807f61716aecc7eb5d2ac1677
martDialAdapter.java
|
| 33dff202e94cb50c0566becdd240a015fecb4f49 |
12-Nov-2012 |
Yorke Lee <yorkelee@google.com> |
Cherrypick Arabic/Farsi pasting into dialpad fix
Bug: 6656969
Change-Id: I0bb094125eb9be2b6508e6ca658ae23da9da19d1
ialpadFragment.java
nicodeDialerKeyListener.java
|
| b9ea6cf17f0adf1deb38b95d6908a1a3621bafd7 |
15-Nov-2012 |
Yorke Lee <yorkelee@google.com> |
Use SmartDialCache object for caching
Extract caching methods from SmartDialLoaderTask
and use a standalone SmartDialCache object instead. This
cache object handles caching failures as well as concurrent
multiple cache requests.
Bug: 6977981
Change-Id: I6df9e273191c7ac434d094e567d7a91814f8c030
ialpadFragment.java
martDialCache.java
martDialLoaderTask.java
|
| 217d1edcaf8b57829207abf9901c016b1fba9005 |
14-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move dependencies of AccountTypeManager into ContactsCommon.
Moving dependencies in preparation to move AccountTypeManager.
Bug: 6993891
Change-Id: I0399fee27960d46cd5b6f629d32868ff0c2ce38e
martDialNameMatcher.java
|
| 1d3e4209933247ee697421a94fb612198b4003ce |
10-Nov-2012 |
Yorke Lee <yorkelee@google.com> |
Merge "Fix NPE if SmartDialLoaderTask has null context"
|
| 678aa6530062e4db2afc5eadea82681e4ba49a1a |
08-Nov-2012 |
Yorke Lee <yorkelee@google.com> |
Use a custom character map instead of name normalizer
Instead of normalizing names during caching, add a function that
that maps accented characters to their alphabetic equivalents
using switch statements.
This character map is used in the on-the-fly matching algorithm.
This speeds up the caching process(11k contacts) from 800-1500ms
to about 600-1000ms since we no longer perform the normalizing
step during caching.
Bug: 6977981
Change-Id: I98dfc3cba00258bb7ff03b346eab7ca7dc1065be
martDialLoaderTask.java
martDialNameMatcher.java
|
| 442756084d75d4ebd878e08617a5a4d578589734 |
09-Nov-2012 |
Yorke Lee <yorkelee@google.com> |
Fix NPE if SmartDialLoaderTask has null context
Add null check for mContext to prevent NPE if somehow
SmartDialLoaderTask receives a null context
Bug: 6977981
Change-Id: Id87b254520a48ad78dc0c579f0fd58d7f7ce270e
martDialLoaderTask.java
|
| ac834156f56a4d4edcf207865f8235647fa26980 |
08-Nov-2012 |
Yorke Lee <yorkelee@google.com> |
Merge "Add smart dialling capabilities to dialer"
|
| 1be0178a11b1cc3b06867b14446e1e041e97a82c |
08-Nov-2012 |
Yorke Lee <yorkelee@google.com> |
Add smart dialling capabilities to dialer
Layout changes to dialpad fragment to make space for smart dial suggestions.
This feature does not appear in landscape mode.
SmartDialTextView automatically resizes text to fit within the bounds of the view.
SmartDialAdapter highlights certain portions of the matching name based on match
positions provided by SmartDialNameMatcher.
SmartDialLoaderTask is an AsyncTask that caches all contacts with a phone number
into memory, or matches all contact names against a provided query to return a
list of matches (maximum of 3).
SmartDialNameMatcher contains utility functions to remove accents from accented
characters and normalize a phone number. It also contains the matching logic that
determines if a contact's display name matches a numeric query.
Added some tests for SmartDialNameMatcher
Bug: 6977981
Change-Id: I43e1a70d8d0d46e02fc67fe1caaec9a1769124f5
ialpadFragment.java
martDialAdapter.java
martDialEntry.java
martDialLoaderTask.java
martDialMatchPosition.java
martDialNameMatcher.java
martDialTextView.java
|
| 291e976e870d05ec9dd9d8286fb7291c0a76a523 |
06-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Change dial pad to show chooser onStart instead of onCreate.
This fixes the problem where the chooser is not shown when the dialpad is
started and pushed to recents before a call comes in. When the call comes
and dial pad is selected from recents, the dialpad is shown. Instead, we
should be showing the chooser so the user has the option of getting back
into the call.
Bug: 5761141
Change-Id: I315117c6607dbb71e5359cf98785591d20c21881
ialpadFragment.java
|
| fe000c2346f425fb76f14b36e5cb8360929f8a1e |
30-Oct-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move PhoneNumberFormatter to common.
Bug: 6993891
Change-Id: I21b3afb81855ae728b9e20f8af8632c9cd9f4e58
ialpadFragment.java
|
| 16c19ef7518f5d67b7970eca07f4f50baf695fc1 |
30-Oct-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move StopWatch class into common.
Bug: 6993891
Change-Id: I0137ea3a72e0ee1a75f9218fec471049abf36d97
ialpadFragment.java
|
| 35071c06d1587942f5a66c8f12e6247e8f904d26 |
16-Oct-2012 |
Chiao Cheng <chiaocheng@google.com> |
Removing contacts dependencies from CallDetailActivity.
Bug: 6993891
Change-Id: I3ef54efc0ff92367ea4f9b68c1629a99d90ff22c
ialpadFragment.java
|
| 9554500572ba82fbd7adb0a1637206ef870ef09e |
15-Oct-2012 |
Chiao Cheng <chiaocheng@google.com> |
Changing com.android.contacts.R to com.android.dialer.R.
Bug: 6993891
Change-Id: I921ec71fffbd4d4a058bab29ded8a6ac62adfb70
ialpadFragment.java
|
| bb0f91e781f23b1abe8ba005b06e5f0ae9481304 |
06-Oct-2012 |
Santos Cordon <santoscordon@google.com> |
Implement list-to-type for phone dialer accessibility
Cherry pick of I7d4a292ebc306b51666d9aa840ddcb2a7e5770fb from jb-mr1
bug: 7297096
Change-Id: I6d95d5d6e2f9ef320002b344af82c9c7a38ffde8
ialpadImageButton.java
|
| 9d4f3b20793a007b4489547aa40fc1049d0d8fef |
06-Sep-2012 |
Chiao Cheng <chiaocheng@google.com> |
Moving resources from Contacts to Dialer.
- Also moving some shared utilities.
Bug: 6993891
Change-Id: I5fa18d26e4f5423f4d3f3450b8f3e3dacbfb947a
ialpadFragment.java
|
| 91197049c458f07092b31501d2ed512180b13d58 |
24-Aug-2012 |
Chiao Cheng <chiaocheng@google.com> |
Moving more classes from contacts into dialer.
- These classes are only used by dialer code.
- Fixed import order.
Bug: 6993891
Change-Id: I7941a029989c4793b766fdc77a4666f9f99b750a
ialpadFragment.java
|
| 8a372c2c67c3cf6bd5a6d4c999d68094938e365c |
24-Aug-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move common phone classes to new location.
- removed dependency on com.android.phone.common jar (old package)
Bug: 7054788
Change-Id: I8c1f6449534a946f4660a9e8924079c08ff1786c
ialpadFragment.java
|
| 94b10b530c0fc297e2974e57e094c500d3ee6003 |
18-Aug-2012 |
Chiao Cheng <chiaocheng@google.com> |
Initial move of dialer features from contacts app.
Bug: 6993891
Change-Id: I758ce359ca7e87a1d184303822979318be171921
ialpadFragment.java
ialpadImageButton.java
igitsEditText.java
|