History log of /frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
7421a01f18f34d554ca7a9fd987c4f96da2bdf2f 20-Aug-2013 Lorenzo Colitti <lorenzo@google.com> Add a simple test for NetworkManagementService.

For now, this only tests network observers. It works by starting
NetworkManagementService with a fake netd socket, feeding it
inputs, and seeing if the appropriate observer methods are
called.

Bug: 10232006
Change-Id: I827681575642a4ee13ae48b81272521544b676bd
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
6e7affeb3d0d026db20690072d8a661847888a42 29-Jun-2013 Elliott Hughes <enh@google.com> am b8292830: resolved conflicts for merge of a920f25f to jb-mr2-dev-plus-aosp

* commit 'b8292830f79fc76ffb9a1be5cd316212ac494d03':
Switch frameworks/base over from @hidden Charsets to public StandardCharsets.
b8292830f79fc76ffb9a1be5cd316212ac494d03 29-Jun-2013 Elliott Hughes <enh@google.com> resolved conflicts for merge of a920f25f to jb-mr2-dev-plus-aosp

Change-Id: I3349f8d2e6715171e2677c1385122ceb2810c1f6
a920f25fe55fc9afc7640902a200f19ce278588b 29-Jun-2013 Elliott Hughes <enh@google.com> resolved conflicts for merge of fca0f92e to stage-aosp-master

Change-Id: I4791f0ffa324a313b8390fbde6d8f82f716ecf74
d396a448b2e36e29598c954b64bfddef73f3fae0 29-Jun-2013 Elliott Hughes <enh@google.com> Switch frameworks/base over from @hidden Charsets to public StandardCharsets.

Bug: 3484927
Change-Id: I5d136d2ee629588538602766a182ae14ce5fc63c
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
3606254a507d838dbec0da35f88c432e6eef7643 10-Jun-2013 Kenny Root <kroot@google.com> resolved conflicts for merge of e96a8207 to master

Change-Id: I90801b35ed0c00078a47faadc7fbb05d2e5fe381
56cd646abeae51e806791f82ab0995fe047b1fe4 08-Jun-2013 Jeff Sharkey <jsharkey@android.com> Avoid logging sensitive data.

When building commands to send across NativeDaemonConnector, scrub
sensitive arguments to prevent them from being logged.

Bug: 8609800
Change-Id: I84b16791749264a010f7e59f9918f68d71bac6b9
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
8d044e8bc287c1a567d82aedbe30085b011544c3 01-May-2013 Dianne Hackborn <hackbod@google.com> Start combining threads in system process.

This introduces four generic thread that services can
use in the system process:

- Background: part of the framework for all processes, for
work that is purely background (no timing constraint).
- UI: for time-critical display of UI.
- Foreground: normal foreground work.
- IO: performing IO operations.

I went through and moved services into these threads in the
places I felt relatively comfortable about understanding what
they are doing. There are still a bunch more we need to look
at -- lots of networking stuff left, 3 or so different native
daemon connectors which I didn't know how much would block,
audio stuff, etc.

Also updated Watchdog to be aware of and check these new
threads, with a new API for other threads to also participate
in this checking.

Change-Id: Ie2f11061cebde5f018d7383b3a910fbbd11d5e11
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
7b4596fd68a24643145e33f3dc4da9285d0f53aa 25-Feb-2013 Jeff Sharkey <jsharkey@android.com> Require command and argument separation, cleanup.

When invoking NativeDaemonCommands, require that base command and
arguments are separate. Clean up reverse tethering commands, and
remove deprecated throttle events.

Change-Id: I302a74130b4f7c3f3045815a56d566e89c8969f6
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
8b2c3a14603d163d7564e6f60286995079687690 12-Nov-2012 Jeff Sharkey <jsharkey@android.com> Useful annotations for code documentation.

Bug: 6537978
Change-Id: I806c3c09e3255f8789455f13bf37c1dde2a93f1f
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
ef21599b17bc081321bc49f1fb315c9e7ad31e3a 05-Jun-2012 Robert Greenwalt <rgreenwalt@google.com> Fix a sync problem in NativeDaemonConnector.

We had a gap in sync coverage between doing a check and waiting and a
matching gap between setting a condition and notifying. It was possible
to get context switched just so and have the notify hit before the waiter
had started waiting.

bug:6492166
Change-Id: Idc876cf85b35902a79fae932547957ed5ef00e4f
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
5a0c320a820a0ccaafaa87ad858a29bf5d88a8b9 23-May-2012 Robert Greenwalt <rgreenwalt@google.com> Modify logging to debug this issue

Logging exec time on startUsingNetworkFeature as we've had some reports suggesting it's
causing ANRs.
Remove some logging from NDC so it's local log is more useful.

bug:6492166
Change-Id: I258ff6c59bff2c65935242d50496d84720c5d493
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
b5aff3fde346225fab0f2751d4fb51b92bb73b32 16-May-2012 Robert Greenwalt <rgreenwalt@google.com> Add some logging to NDC.

bug:6492166
Change-Id: Ib7c7a0927d3e920f6c041f7252f3f24c8e597bc7
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
2d34b4a88531e51982b030c43d672ec2cc3d8f36 20-Apr-2012 Robert Greenwalt <rgreenwalt@google.com> Allow quoted strings from NativeDaemonConnector

Previously we'd only handled quoted strings going into NDC. This
change auto-handles quoted strings in broadcasts and allows
protocol handlers to request de-quoted elements when needed instead
of using the generic split(" ").

bug: 6353048
Change-Id: I8a07be86411063ed1b402294edc399b4cc076da5
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
d192598d3e7c6f38fc9deb573b06ababa56d741a 12-Mar-2012 Robert Greenwalt <rgreenwalt@google.com> Record the trimmed cmd string for logs

The over the wire command includes a \0 that mangles log messages.
bug:6149176

Change-Id: I77d4e443f1966bff060f1b97570851f7549fee8e
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
470007f69a258ccebb7c04927210a091dbcbe181 07-Feb-2012 Robert Greenwalt <rgreenwalt@google.com> Make NDC not block forever and handle restart.

Still possible for netd to get wedged but system won't die because of it.
Leads the way to having forking netd - then only individual commands would
wedge, promoting stability.

bug:5864209
bug:6019952
Change-Id: I43e4c5072863b8b812d4fe24d30d92eb1a11651a
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
6ffa76077ddbecb0f432a805ed9999436ac308f1 08-Feb-2012 Guang Zhu <guangzhu@google.com> Revert "Make NDC not block forever and handle restart."

Reverting because it seems to break `adb reboot`

This reverts commit 813af8d46467f41ed2d492917cbb9f9f45d2a3d7.

Change-Id: I75d827664a08799de15369c24c84cc3f49a8f297
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
813af8d46467f41ed2d492917cbb9f9f45d2a3d7 07-Feb-2012 Robert Greenwalt <rgreenwalt@google.com> Make NDC not block forever and handle restart.

Need changes in core.

Still possible for netd to get wedged but system won't die because of it.
Leads the way to having forking netd - then only individual commands would
wedge, promoting stability.

bug:5864209
Change-Id: Ifcd37511c8239fe3df7e9070869b63a9c5649bd2
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
f0be1d89bf1cf5592ea1786d837f4f2329bdf66d 21-Jan-2012 Robert Greenwalt <rgreenwalt@google.com> Add some logging to NDC.

We're getting some lockups of netd and this can help point us
in the right direction.

bug:5864209
Change-Id: Id8bdb0a758c5b161e0143de61b5f39c3a982e329
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
470fd72a06390d7a6b854583afd0ed76ce0a03ee 18-Jan-2012 Robert Greenwalt <rgreenwalt@google.com> Log netd traffic nicely.

Create a LocalLog class for logging within a service for dumping in dumps.
Use it in the NativeDaemonConnector so we can get some insight into what
is happening in these lockups.

bug:5864209
Change-Id: I68ddc58847f3c8de613be9528570f8c3157d8274
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
ba2896e939f359e5857149f1a27212db71be012b 01-Dec-2011 Jeff Sharkey <jsharkey@android.com> Move native netd calls to varargs.

Uses argument escaping inside NativeDaemonConnector, using varargs
to separate boundaries. Also introduces Command object to help build
argument lists.

Bug: 5472606
Change-Id: I357979fc19bb0171a056e690064e01b5a7119501
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
31c6e4817f6c967fc4f61c4f1d9f25743958f7de 19-Nov-2011 Jeff Sharkey <jsharkey@android.com> Move NativeDaemonConnector to varargs.

Perform uniform argument escaping inside NativeDaemonConnector, using
varargs to separate boundaries. Also move to parsed NativeDaemonEvent
instances instead of raw Strings.

Bug: 5472606
Change-Id: I1270733e2b2eeb2f6b810240df82ab24d38ebf40
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
b0aec07f7462ff7563835c3107f4b46a28eae7a4 15-Oct-2011 Jeff Sharkey <jsharkey@android.com> Validate commands and arguments.

Bug: 5465176
Change-Id: I9402054c20ea6cae42781c35bfc2ade90aac31ce
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
fa23c5ae226c1a1d39f89c5c87d4f340e91d90e0 10-Aug-2011 Jeff Sharkey <jsharkey@android.com> Add NativeDaemonConnector users to watchdog.

To catch instances where NativeDaemonConnector hangs while executing
commands, add users to system_server watchdog. Also moved qtaguid
enabler to separate thread to prevent blocking systemReady().

Bug: 5145437
Change-Id: I4c6c1dc09864a1c05f9486a31faa1b366548e911
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
e5750a344a9c1a83a63d5119d39d2ea4897bc312 03-Aug-2011 Chia-chi Yeh <chiachi@android.com> NativeDaemonConnector: offload callbacks to another thread.

Now callbacks can communicate to the same daemon without causing a
deadlock. This also improves the latency of calls because they no
longer need to wait for the callbacks for the pending events.

Change-Id: I153fcf16bd64de79ee1c1a57d3cfdb12b354cf47
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
b901c9abff6b3885e1efce2e643b1f8e5ef3fc79 07-Feb-2011 Brad Fitzpatrick <bradfitz@android.com> am 9204644d: Merge "Fix a race condition in NativeDaemonConnector"

* commit '9204644d9e8fc2a3d05ff386b14b349f7a117694':
Fix a race condition in NativeDaemonConnector
030bc88b4c09a41b0d7dbe249aec55f33d6b8b8a 01-Feb-2011 anga <anga@syntronic.com> Fix a race condition in NativeDaemonConnector

Fixes a race between the onDaemonConnected callback and setting the
mOutputStream in NativeDaemonConnector.

MountService connects to vold using the NativeDaemonConnector.
Throws a “NativeDaemonConnectorException: No output stream!”
when the onDaemonConnected callback in MountService calls the doListCommand.

Change-Id: Ib895bab37f7df680e4362df6366198c0a673c5e9
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
1cd94ef9570a1534e32b27d5b174dc690c9be6b9 16-Jan-2011 Irfan Sheriff <isheriff@google.com> Do not add unsolicited events to queue

Adding unsolicited events to response queue
results in doCommand() returning the wrong
result.

Pulling this change from master.

Bug: 3258529
Change-Id: I2a4b0bd8bb30b31682d7d61ee94a0d246bf10de2
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
e5c3afb29241fd3faae309f973645d7f6a7ed111 22-Sep-2010 Robert Greenwalt <rgreenwalt@google.com> Cleanup Netd to prevent getting hung.

If the sending of the command fails we should note it and not wait forever
for the response.

We should also not say we're ready until we actually are.

bug:2993205
Change-Id: I380f0312ac4693ad184a526b330fdfa23f6ac558
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
12da9d7472ae87b841575d5358e19f143d12f900 03-Sep-2010 Kenny Root <kroot@google.com> Fix buffer compacting in NativeDaemonConnector

The buffer was being compacted in the read loop, but the start offset on
the compacted buffer wasn't being considered after the next read.

Bug: 2501075
Change-Id: I163297d751cf800d0bbc66df66b1a0fa0785de49
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
a80ce06d4c54e43243073f8ceff024f9dda7140e 01-Jun-2010 Kenny Root <kroot@google.com> Add more error checking for ndc

In NativeDaemonConnector.doCommand() calls, there was inconsistent error
checking. This change adds error checking for every call and makes it so
that any call to .doCommand() that gets an error code won't cause the
code to hang forever.

Change-Id: I4584953a759a48ad16adfe8ee9e564b5f5796680
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
961aa8c8879e9f68c0eddcaf87565200a4347134 23-Mar-2010 Kenny Root <kroot@google.com> Compact when NativeDaemonConnector hits buffer limit

If NativeDaemonConnector hits its buffer limit, it would truncate the
data and lose some information. This change compacts the buffer and then
retries to read the rest of the data.

Change-Id: I0d5fee097bdd6808212ef3ad6fb4abbc6310fd4a
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
8a9b22056b13477f59df934928c00c58b5871c95 27-Feb-2010 Joe Onorato <joeo@android.com> Switch the services library to using the new Slog
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
4086f752e1e3f093396b4eb6c0075dccb0c65983 17-Feb-2010 San Mehat <san@google.com> NativeDaemonConnector: Improve bad list IPC diagnostics

Signed-off-by: San Mehat <san@google.com>
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
1ff4371ef2e27ff51cedd24d093b12043cb72e56 05-Feb-2010 San Mehat <san@google.com> NativeDaemonConnector: Improve error reporting and debug formatting

Updated:
NativeDaemonConnector: Put debugging behind a conditional

Signed-off-by: San Mehat <san@google.com>
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
ec4caa0f549bf9a75d20daa95b8aa8d9fab39681 03-Feb-2010 San Mehat <san@google.com> NativeDaemonConnector: Improve NativeDaemonException reporting to include the actual error response

Signed-off-by: San Mehat <san@google.com>
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
4c27e0e3bed006a9ba45c6c02be5fe49827b3fea 29-Jan-2010 San Mehat <san@google.com> NativeDaemonConnector: Cleanup socket code and use a proper exception
Signed-off-by: San Mehat <san@google.com>
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
80120b43745102b3a8c635c796698d748b329222 26-Jan-2010 San Mehat <san@google.com> NativeDaemonConnector: fix doListCommand() to return *all* list elements

Signed-off-by: San Mehat <san@google.com>
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
deba6935c6595c724416cde3368a92c32d8f8683 21-Jan-2010 San Mehat <san@google.com> NativeDaemonConnector: Add a convenience method for obtaining lists

Signed-off-by: San Mehat <san@google.com>
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java
67bd2cd75f0615c1a08a221f2114d2acda90d1ce 12-Jan-2010 San Mehat <san@google.com> services: Introduce NativeDaemonConnector class

This class provides an interface to communicate with native daemons using the
libsysutils framework communication code.

Signed-off-by: San Mehat <san@google.com>

NativeDaemonConnector: fix whitespace

Signed-off-by: San Mehat <san@google.com>

NativeDaemonConnector: Fix review comments

Signed-off-by: San Mehat <san@google.com>

NativeDaemonConnector: On an error, re-try the connection

Signed-off-by: San Mehat <san@google.com>
/frameworks/base/services/java/com/android/server/NativeDaemonConnector.java