| ed2eadb8ff3611084d48892169c80e3a189ea7b5 |
|
19-Nov-2013 |
Ihab Awad <ihab@google.com> |
Remove an extra logging call left over from development.
Change-Id: I41cda7bc38bad1acc3ad3e1270947fe77fab9416
Bug: 11748959
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 0b2b20a9dbecff3e0ac345b559caeaae779de03d |
|
14-Nov-2013 |
Santos Cordon <santoscordon@google.com> |
Add incoming-during-hold case to fullscreen Notification code.
We use fullScreen notifications to bring up the incoming call screen
when it is not already being shown. Android framework ignores
fullScreen property if the same notification ID already exists. To fix
that we cancel the notification right before setting it to full screen.
We only used to do that for the CALL_WAITING state since that when it
mattered. However, if the current call is on hold, a new call comes in
as INCOMING instead of CALL_WAITING so this change adds that condition
as well.
Also fixed two other minor pieces of code which only checked INCOMING
and not CALL_WAITING. One for an icon, the other used to acquiring
location as part of the contact info (we only do so for incoming calls).
bug:11578080
Change-Id: Id010a6848cd1ca06d68e8405041565bc008a781e
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| e6d74148bc5f9cf586933429a67da0d46bc2e7a8 |
|
08-Nov-2013 |
Ihab Awad <ihab@google.com> |
Show status bar notification on quick navigate from in-call UI
Add logic to force the status bar notification of an outgoing call
to be displayed after a reasonable if the user, e.g. by pressing
Home, navigates away from the in-call UI before it has a chance
to show up.
Bug: 11341599
Change-Id: I13f86b940cc82097596634c7634cb5a8726e7d12
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| ff40f157168bc54fec724350387670876ae382b1 |
|
15-Oct-2013 |
Christine Chen <christinech@google.com> |
Clears notification when there is no call.
Bug: 11083320
Change-Id: I05efd985114a78d87098a46b1c4c33ad5bcc5b94
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| f570d87ff0698afdc3a1c1cf9024009f4bd77a22 |
|
01-Oct-2013 |
Christine Chen <christinech@google.com> |
Scales the contact photo to fit notification icon
Bug: 11007879
Change-Id: Ide32f725bedc80095edd067ea531f0c07e18ffa3
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 672b16d0620d033e10fab30ccd70f5dd23e823b7 |
|
19-Sep-2013 |
Santos Cordon <santoscordon@google.com> |
Add "retrying" text for CDMA redial calls.
listening for new REDIALING state.
bug:10824223
Change-Id: I2b6f2f74713197902c93deca203f4f136732f7a2
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 2ce872d6f7dd8a7eb0275b4195336f779972f698 |
|
13-Sep-2013 |
Makoto Onuki <omakoto@google.com> |
b/10699042 show dialpad when connects to voice mail.
Also now "Use touch tone keypad" in the dialer works, and
it automatically un-holds if there's only once call and it's
on hold. (which was a regression too.)
Change-Id: Id8eeb2737ffa2223acfbf9a8a30d957599c9db36
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 14dbc3f0ca3a7998c9c5d28aba637487724f529f |
|
14-Sep-2013 |
Santos Cordon <santoscordon@google.com> |
Fix UI lag when calling a contact with a photo.
Related fixes unrelated to latency problem:
a. Update StatusBarNotifier with new changes to CallerInfoCache.
b. Outgoing JANK fix in notifier needed to know if the activity
was previously started, not just if it was finished. (b/10734874)
c. Consolidate places where we use the Intent.
Several improvements to speed up startUp time from most egregious to
least:
1. In InCallPresenter, statusBarNotifier wasn't unlistening to
incoming call changes which kept orphaned instances still listening and
calling into contactInfoCache. ContactInfoCache was subsequently calling
into many notifiers which did heavy image parcelling work.
- Clear incomingCallListeners on tear down.
2. StatusBarNotifier was getting called directly from InCallPresenter &
onIncomingCall() callbacks. onIncomingCall callback was unnecessary and
caused extra work.
- Fix is to stop listening to incoming calls. Status bar notifier gets
called directly by InCallPresenter in startAndFinish() so listening
to incoming was redundant.
3. Make ContactInfoCache listeners list a Set to avoid duplicate
entries and reduce callback execution.
bug:10712670
bug:10734874
Change-Id: Ic8d50b1d9ce336ffe3a5191abe1c9db32365eee6
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 0b87230c2ebe1c842313d8c159513caa5092830b |
|
14-Sep-2013 |
Jay Shrauner <shrauner@google.com> |
Merge "Fix flow of local/remote lookups" into klp-dev
|
| 101bed44998ff35c3a56f431345fac5c8229ec0e |
|
11-Sep-2013 |
Jay Shrauner <shrauner@google.com> |
Fix flow of local/remote lookups
Redo logic for looking up numbers. Push all logic into ContactInfoCache
findInfo routine.
Bug:10634005
Change-Id: I87bd987780ba744222d3adc82cf359e3c20f121f
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| b7909e721149617322fce95bf5e94ccc0e4e1813 |
|
13-Sep-2013 |
Chiao Cheng <chiaocheng@google.com> |
Fix NullPointerException.
The existing null check was being overridden by check for
incoming call. Prioritize the null check first.
Bug: 10727364
Change-Id: Id0127a6f3634876126c1f13c810f1d1e54e8d203
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 3bacc6cef96c46faa1e4c2991ffb159f4f68b17e |
|
11-Sep-2013 |
Christine Chen <christinech@google.com> |
Modifies status bar indicator for conference call.
- Changes the name from Unknown to Conference Call.
- Changes the avatar to the conference call avatar.
Bug: 10692003
Change-Id: I1c4750a70d1cb69d5499dba84a310a8167175460
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| b0d08a16da088e01f416f52a7b74ee9630c1493a |
|
05-Sep-2013 |
Santos Cordon <santoscordon@google.com> |
Improve lifecycle ordering for InCallUI
This CL rearranges startup and teardown of InCallUI to reduce the number
of race conditions resulting in runtime exceptions and app crashes.
At a high level this CL fixes the following:
- TeleService should be able to unbind and rebind at any time without
causing problems in the UI. (Fixes to InCallPresenter)
- On weird occasions we were seeing secondary UIs pop up if we
rebound while the older UI was still up and one of the UIs would be
orphaned on the foreground.
- call notifications can be sent during (1) activity startup, (2)
activity lifetime, (3) activity destruction, (4) no activity...and
nothing should crash.
- Lots of crashes when notifications came during destruction and
startup. (Fixed setup in InCallActivity + presenters, and
startup/teardown ordering in InCallPresenter)
Details:
(1) InCallPresenter handed out instances of member classes to the UI
classes, but upon unbinding and rebinding, the classes were
recreated. This meant that the activity which was potentially still up
had stale versions of AudioModeProvider and ProximitySensor.
- Classes created/used by CallHandlerService are now singletons so that
they do not change from one bind to the other. If the service tries
to initialize InCallPresenter while the activity is still up (and so
we haven't yet torn down) we reuse the reuse the previous
initialization since there is no need to recreate them, and classes
in the Activity dont ever become stale.
(2) We were recreating new copies of InCallActivity on updates that
occur while tearing down the previous activity. This caused weird
errors where second emptier activities were up after all calls ended.
- Solution to this was to ignore all updates while we are finishing the
activity. When the activity is finally finished, we check if we
should bring up a new activity in case some update came while we were
finishing.
(3) We set listeners on presenters from a parent class that wasn't aware
of UI transitions.
- All Presenters are not responsible for setting and unsetting their
listeners. This allows them to unset them before their UI goes away.
+ renamed HIDDEN to NO_CALLS as hidden was confusing to developers
which associated the term with foreground/backgroundness of the app.
+ Improved some logging
bug:10573125
Change-Id: I2d1af6a6e972b3b3bd93af839054e879f0b74b4f
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| af2589a6aa68d9906fe46b31ffaf214010632c02 |
|
04-Sep-2013 |
Chiao Cheng <chiaocheng@google.com> |
Fix incall image for local contacts.
The contact info callback was being called back at a minimum of two times. Once
for the name and text data and a second time for the photo. The results of the
first call triggers reverse lookups and was causing it to trigger twice. To fix
it for both cases, break out the callback into two separate calls to the client
can properly handle the cases differently.
Bug: 10607629
Change-Id: I2e0754d2d7c46bc2797a1a672827bd2f8d56e5d8
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 518519c83063f94fe5010ed5075b38a066e794ec |
|
30-Aug-2013 |
Santos Cordon <santoscordon@google.com> |
Merge "Allow new call waiting calls to pop up when not in foreground." into klp-dev
|
| 179bcc00d5140f577f009e296c965bdfebfb4763 |
|
29-Aug-2013 |
Santos Cordon <santoscordon@google.com> |
Allow new call waiting calls to pop up when not in foreground.
Added some additional debug logging.
Allow full-screen startup sequence to happen with any transition
to IN_CALL state, not just from a HIDDEN state.
(e.g., from IN_CALL -> INCOMING)
And for the grand finale, uncomment the code that would have made
this work from the beginning. :P
bug:10396126
Change-Id: Id34805941b75b28d4876153bb1bf0305142fc4cd
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 0d9cfa48c3bf44d800e280ec6bf1d8a226fab7ca |
|
29-Aug-2013 |
Santos Cordon <santoscordon@google.com> |
Ensure that OUTGOING calls bring up the notification dialog.
Change-Id: I32b3ed77dae7f839036ea24ae09b9a9d0e87b746
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 8b6c8d0dbfba6eabe3d835f8cdcec8a13e253d0c |
|
23-Aug-2013 |
Chiao Cheng <chiaocheng@google.com> |
Major fixes for in call to work with reverse number lookup.
- Separated caller info data into CallIdentification and switch callbacks to use
it where call state is un-necessary.
- Changed mCallList.update() method to be onIncoming().
- Catch all exceptions from service methods so errors do not vanish.
- Fixed bind failure cases which led to DeadObjectException.
- Changed local contact lookup to only occur for incoming calls.
- Fixed CallCardPresenter to start contact search upon isntantiation instead of
waiting for next call update.
- Convert ContactInfoCache to singleton to avoid race condition where it's not
initialized.
- Handle cases where primary call may be null when we find a contact.
- Fixed race conditions in CallButtonPresenter where audio mode is being set
before ui is ready.
- Fixed race condition in AnswerPresenter where state change was being called
before ui is ready.
- Changes to CallCardPresenter to support lookup for conference calls.
Bug: 10413515
Bug: 10390984
Change-Id: I9fc4f2f35e8f5aad33c301b3c5c93132634cb63c
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 1a7f2bcab2d2023f2ee4cfb0bc57bc265b5aab87 |
|
21-Aug-2013 |
Chiao Cheng <chiaocheng@google.com> |
Protect all logging statements.
- Rename global logger so it can be a drop in replacement for framework log
class.
- Remove imports of android.util.Log
Bug: 10411948
Change-Id: I377625263b16c4f9408c79d5c533a1810fa6cde7
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 88dbc6b3dbf35b322fe09c1a289c7e884e8fba22 |
|
14-Aug-2013 |
Santos Cordon <santoscordon@google.com> |
Adding duration time to calls
Adding chromometer support in the notification.
More manual update process for in-call UI (Call card).
Change-Id: I9a1598969d92296dc38b7485bd9fb872ad501e7b
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 0e27ca6253114be60b85f912a1af62dbf35c1b9e |
|
13-Aug-2013 |
Santos Cordon <santoscordon@google.com> |
Use shared contact info cache to get data for the notification.
Move around where ContactInfoCache is created so that StatusBarNotifier
and CallCardPresenter will use the same shared instance.
Change-Id: I6e0a7c48aa7a35a0f1a52b399eb127d69f41a879
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 73e8dc0225c601f7203dd4d12e4f7653a1f9a9b0 |
|
10-Aug-2013 |
Santos Cordon <santoscordon@google.com> |
Add basic call information to the notification.
Change-Id: I33bc1445e9fc515b68205a12d7297a8f3013fecd
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| de7685bd2f489bd0a7c74721f73a37c69eeba367 |
|
10-Aug-2013 |
Santos Cordon <santoscordon@google.com> |
Adding suppression behavior for in-call notification.
This suppresses the notificaiton if the call isn't active of outgoing.
We also suppress the notification if the user is currently in the
in-call screen.
...except during incoming (ringing) calls...we always show it for ringing calls.
Change-Id: Ib75545339376c62c975c390298ef9567d733b8e3
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 0866ac1055b4e505339a94b4f5177b862d6301aa |
|
09-Aug-2013 |
Santos Cordon <santoscordon@google.com> |
Adding hangup capability to in-call notification.
Change-Id: I7ba4dd0824f41d9989e36bff10fbfca68596134e
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| 91d578df9ba4fb77832cf5f20cf5143b67ff2581 |
|
09-Aug-2013 |
Christine Chen <christinech@google.com> |
Remove STARTED and START_UP states
Change-Id: I963f0ce7c695349854b738ae57b39f2c6718e570
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| e7be13fb0556e62b07bc271b130412d82d7f7521 |
|
07-Aug-2013 |
Santos Cordon <santoscordon@google.com> |
Supports for outgoing calls starting up the UI.
- Added the OUTGOING InCallState
- Added support for OUTGOING into InCallState, InCallPresenter, and
StatusBarNotifier.
Change-Id: I49d5a56a4394d05e948b16a82f23e3eb925fd0a0
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|
| efd4282ec4221ec5eefd4155a4ad915adcedca70 |
|
05-Aug-2013 |
Santos Cordon <santoscordon@google.com> |
Notifications in Phone (part 1)
- Added StatusBarNotification class to handle notifications
- StatusBarNotification has tons of copied comments from
NotificationMgr.java. Also has minimal code to make the notification
pop up (without call-specific data).
- Moved the UI start-up code from InCallPresenter to
StatusBarNotification. Incoming phone calls need to display an alert
above immersive (fullscreen) foreground activities and the way to do
that is through notifications. The old phone app did the same
thing...finally bringing over that functionality.
Change-Id: I3324503e0d7bb1de00d8e7fab72d4b40519491dd
/packages/apps/InCallUI/src/com/android/incallui/StatusBarNotifier.java
|