History log of /system/core/toolbox/mount.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
44a5fb57045709f7f3feead4c8444baa2bdfc658 25-Apr-2013 Nick Kralevich <nnk@google.com> Merge "fs_mgr: make block devices read-only"
29a5298366f0070bcc359e982eb31d49f84a92c1 25-Apr-2013 Nick Kralevich <nnk@google.com> mount: fix incorrect string length calculation

Fix bug https://code.google.com/p/android/issues/detail?id=54192
which incorrectly calculated the length of a string.

Fix compiler warning:

system/core/toolbox/mount.c:59:2: warning: initializer-string for array of chars is too long [enabled by default]
system/core/toolbox/mount.c:59:2: warning: (near initialization for 'options[16].str') [enabled by default]

Change-Id: If8663f8311c6348a730fcf731d402b57fee10cb5
/system/core/toolbox/mount.c
e18c0d508a6d8b4376c6f0b8c22600e5aca37f69 17-Apr-2013 Nick Kralevich <nnk@google.com> fs_mgr: make block devices read-only

When a filesystem is mounted read-only, make the underlying
block device read-only too. This helps prevent an attacker
who is able to change permissions on the files in /dev
(for example, symlink attack) from modifying the block device.

In particular, this change would have stopped the LG Thrill / Optimus
3D rooting exploit
(http://vulnfactory.org/blog/2012/02/26/rooting-the-lg-thrill-optimus-3d/)
as that exploit modified the raw block device corresponding to /system.

This change also makes UID=0 less powerful. Block devices cannot
be made writable again without CAP_SYS_ADMIN, so an escalation
to UID=0 by itself doesn't give full root access.

adb/mount: Prior to mounting something read-write, remove the
read-only restrictions on the underlying block device. This avoids
messing up developer workflows.

Change-Id: I135098a8fe06f327336f045aab0d48ed9de33807
/system/core/toolbox/mount.c
bfcd810b792f7ffbb2ec1360c0c2662725fd0362 22-Aug-2012 Jeff Sharkey <jsharkey@android.com> Iteration on multi-user external storage.

Define /storage as top-level concept, so that we enforce permissions
uniformly. Moves external storage paths from headers to per-device
environment variables. Added missing mount flags, and we no longer
have adb-specific external storage.

Bug: 6925012
Change-Id: Ic7ca953be2f552d3f0ec9e69f89fef751daa1b29
/system/core/toolbox/mount.c
940c81078e7291096b22f05f6b953658f1e1d730 13-Jul-2011 Ken Sumrall <ksumrall@android.com> Add -o loop= option to mount, and fix error detection in mount and umount

This fixes bug http://b.android.com/18419, which complains about a bogus
error check in the mount command (it also was wrong in the umount command)
and also asks for the mount command to support more than one loopback
device, as mentioned in the FIXME comments in mount.c. This required some
corresponding changes to umount.c

Change-Id: Ib796c70926395e61557e487bad64984d3295d5f3
/system/core/toolbox/mount.c
4e7dd3d270aaf0b43e94b2ccaf840f86e541d21b 07-May-2010 Colin Cross <ccross@android.com> mount: Add support for remounting without specifying device

Change-Id: I48c84fab3ab2a9704ec5b7bf7002b8960fa53c27
/system/core/toolbox/mount.c
2f0c41ec3c5f83a02a58242e175663bdd89a9467 01-Jul-2009 Dima Zavin <dima@android.com> am 383688b5: toolbox: Fix uninitalized stack variable in mount.

Merge commit '383688b52fb19b9c4d98bb1a660febc880d0e268'

* commit '383688b52fb19b9c4d98bb1a660febc880d0e268':
toolbox: Fix uninitalized stack variable in mount.
383688b52fb19b9c4d98bb1a660febc880d0e268 30-Jun-2009 Dima Zavin <dima@android.com> toolbox: Fix uninitalized stack variable in mount.

Signed-off-by: Dima Zavin <dima@android.com>
/system/core/toolbox/mount.c
dd7bc3319deb2b77c5d07a51b7d6cd7e11b5beb0 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/system/core/toolbox/mount.c
e54eebbf1a908d65ee8cf80bab62821c05666d70 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/system/core/toolbox/mount.c
bc7b0cbe156da639f0cbe17bf89725d87e86512a 16-Nov-2008 Jay Freeman (saurik) <saurik@saurik.com> Open file and loop device with O_RDONLY when -o loop,ro.
Otherwise: ioctl LOOP_SET_FD failed: Bad file number.
/system/core/toolbox/mount.c
4f6e8d7a00cbeda1e70cc15be9c4af1018bdad53 21-Oct-2008 The Android Open Source Project <initial-contribution@android.com> Initial Contribution
/system/core/toolbox/mount.c