History log of /libcore/luni/src/main/java/org/apache/harmony/security/x509/GeneralName.java
Revision Date Author Comments
28d504c4188a5d25a7209e4d1c131e0afffa1fcf 07-Jan-2013 Kenny Root <kroot@google.com> Harmony: fix DirName handling in X.509 certs

In SubjectAlternativeName, the directoryName (4) entry is actually a
CHOICE of a single possibility. Harmony was trying to decode it as the
single possibility itself and running into parsing issues.

Additionally, change T61String (TeletexString) handling to assume UTF8
encoding like the RI does.

Change-Id: Ic0b9541dfed21b59940fa50a27cee2e7704d8950
3b14c4bd5c7ce28ed3485bd24285c58424c074af 07-Jan-2013 Kenny Root <kroot@google.com> Harmony: ignore invalid IP in subject alt. names

The RI and other providers will ignore invalid IP lengths instead of
throwing a parsing exception. Bring Harmony in line with those other
providers.

Change-Id: I65715a58614543ab296493829338239cf402ae5d
8626012f833cada8b06c3d82860d2dbe4107ce7a 15-Nov-2011 Jesse Wilson <jessewilson@google.com> Don't fail GeneralName parsing if the DNS name contains a wildcard.

This doesn't impact host name validation, which reparses the DNS name
into component parts and uses strict wildcard matching rules against
a particular host name.

Bug: http://b/issue?id=5534658
Bug: http://code.google.com/p/android/issues/detail?id=21311
Change-Id: Iaeaf72a6f8b9ebd9ee2fe68f1bc7830f174f2310
196f44e24830d0e7fd17eba627704a162eba779e 25-Feb-2011 Elliott Hughes <enh@google.com> Fix more FindBugs warnings: DMI_INVOKING_HASHCODE_ON_ARRAY.

"The code invokes hashCode on an array."

Change-Id: Ib47f878fd42a56fdcdb46b83fd8a4f528af2a534
6ed93fa8be996378e766d3fd2586b51c6fe656b1 02-Feb-2011 Jesse Wilson <jessewilson@google.com> Don't parse or format IP addresses in cert code.

We used to include a full IP address parser and formatter. The
formatter handled one interesting case: a 2x length byte[]
containing both an IP route and mask. Although our code supported
parsing and formatting these, they do not occur in practice. The
Java APIs don't support NameConstraints, which is the only part of
the spec that uses them.

Change-Id: I7a4b22b40a37d6f26ec09fc5188ec1ba43e4d249
http://b/3385492
5c27fb80ffd335aa45dc8829ba3ecbc18c01e4e8 25-Jan-2011 Jesse Wilson <jessewilson@google.com> Use generics in Harmony's ASN.1, X.501 and X.509.

This change cleans up this code and uses modern Java idioms. It should not
change the behavior.

Change-Id: Ie869ced7c9e18634409ae194aa9a2c2a5e5ca530
4b25199bc0b7a64a6feaa60e7d5d6b0474341234 21-Jan-2011 Elliott Hughes <enh@google.com> Add an @hidden Byte.toHexString that does the right thing, and use it.

Turns out most callers don't actually give a toss about case anyway, since
they're just for debugging output.

Bug: 3371169
Change-Id: Ib8dc079be2dcbf6f2415ecb9b71d034ee71f68eb
fe921473907c2388cf13d014dd3bcf32d2b6d04a 13-Jan-2011 Brian Carlstrom <bdc@google.com> GeneralName toLowerCase should use Locale.US

Bug: 3325637
Change-Id: I8fbbb18debc3c288240d1dde12d032ed583e7cbe
fb0ec0e650bf8be35acb0d47da0311a7c446aa33 14-Jan-2011 Elliott Hughes <enh@google.com> Remove useless android-changed comments.

I've changed useful ones to regular comments or TODOs, as appropriate.

I've left ones in code like java.util.concurrent where we really are
tracking an upstream source, making the change markers useful.

I've left a handful of others where I intend to actually investigate
the implied TODOs before deciding how to resolve them.

Change-Id: Iaf71059b818596351cf8ee5a3cf3c85586051fa6
9efa300c26865520498c0ed132ff9ebe499e7d84 18-Oct-2010 Elliott Hughes <enh@google.com> Remove more tabs.

Missed these in the big cleanup because they didn't look like code we were maintaining. The
xalan/xpath/et cetera stuff is all still tab-filled, and there are a few package.html files
too (for which I've raised http://b/3107546).

Change-Id: I7ad956f3c410701fec13731c9affbcedd24a4a9a
7365de1056414750d0a7d1fdd26025fd247f0d04 12-Aug-2010 Jesse Wilson <jessewilson@google.com> Sorting imports.

Change-Id: I8347bc625480a1c37a1ed9976193ddfedeb00bbc
e810d3b49631329b11440aa5b7a54db181d42ed1 15-Jun-2010 Elliott Hughes <enh@google.com> More charset-related cleanup/optimization.

This patch adds a Charsets class that lets us avoid a hash lookup and an extra
level of method call indirection when calling String.getBytes or "new String"
for a well-known guaranteed charset. It also fixes callers to take advantage.

This also adds a special case to "new String" for the UTF-8 charset to avoid
needless duplication if we guessed the correct buffer size (which we will for
input that happens to be US-ASCII too).

The ModifiedUtf8 class gives a more meaningful name for Utils.convertUTF8WithBuf.

This also removes a dead link and un-tinyurl'ed another.

Change-Id: I02712f53dee16feb3b1db2c14536dc055126cd04
897538a36c18f4db8f9f68ee566aec0bda842e9f 29-May-2010 Elliott Hughes <enh@google.com> Remove the last exception message catalog.

Bug: 1251121
Change-Id: I45931b9ff908531bda06d6569a4e9618986f821b
f33eae7e84eb6d3b0f4e86b59605bb3de73009f3 13-May-2010 Elliott Hughes <enh@google.com> Remove all trailing whitespace from the dalvik team-maintained parts of libcore.

Gentlemen, you may now set your editors to "strip trailing whitespace"...

Change-Id: I85b2f6c80e5fbef1af6cab11789790b078c11b1b
fd6bb3510c2f94d636f3572dcf5f7f4dcd1a2726 13-May-2010 Elliott Hughes <enh@google.com> Remove //$NON-NLS-\d$ cruft.

Mostly done by perl(1), with manual cleanup of the few misspelled instances.
This makes our trailing whitespace slightly worse, but I'll fix all that with
a follow-on change.

Change-Id: I0b4ca98819be6f9519c4ba980d759bd1ee1a0303
cec4dd4b1d33f78997603d0f89c0d0e56e64dbcd 26-Apr-2010 Peter Hallam <peterhal@google.com> merge more modules into luni