History log of /packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
e0b2f1e2d01d1ac52ba207dc7ce76971d853298e 12-Jun-2012 Chiao Cheng <chiaocheng@google.com> Global import order fix.

Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements

Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.

Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
f30723782e801deaf159aea2443e9507596ef11d 23-Feb-2012 Daniel Lehmann <lehmannd@google.com> Don't re-use the SaveMode in the group editor anymore.

As we only ever use SaveMode.CLOSE, I decided to remove this entirely.
We don't support re-loading at the moment, so it seems wrong to have
code in there that pretends to be able to do it.

Also I cleaned up some Eclipse warnings, so that the side-bar has fewer
yellow lines

Change-Id: I263b716c2edc98682bd5f5d1bc2b18ede15d7ced
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
8d5abcb71ed4d9671b9066b9e3ffaf5372d2b22c 03-Sep-2011 Makoto Onuki <omakoto@google.com> Make sure only People and Dialtacts responds to search key

- Remove the default search activity meta-data from manifest, so the old-style
search dialog won't show up when the serach key is pressed. It was for
pre-HC style search UI. Now the search key only works on people and dialtacts,
which implement either startSearch or onSearchRequested.

- Removed all the startSearch/onSearchRequested methods which are now
unnecessary.

- Also removed startSearch() in some fragmets. They're not used.

- Tested some viewer/editor/picker activities, and also both dialtacts and
people, the launcher search box, and the SEARCH intent, on both the phone
and the tablet (except dialtacts on tablet). All looking good.

Bug 5230790

Change-Id: If269df74ae218707daa5b7039439c6fea2575e8d
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
94f216b210f29abe7fdb96a18a1718e91b628f54 18-Aug-2011 Makoto Onuki <omakoto@google.com> Group editor: Just close activity when there's no accounts

Rather than crashing.

Bug 5035734

Change-Id: I433049de1a254213beb83501fdae74907f11a4cf
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
0133589fec89150313918576ab5e4f569cb7de5d 10-Aug-2011 Makoto Onuki <omakoto@google.com> Merge "Makke DONE button close activity on readonly group editor"
ad8e14065996cf8c0f5e0d6bc90c7fa334fc227f 10-Aug-2011 Makoto Onuki <omakoto@google.com> Makke DONE button close activity on readonly group editor

Bug 5142181

Change-Id: I5b300b150113b77800de698dbb7bdd40c35b15f4
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
bec0e12648b7c90aab9eda5b2837faca2493e5c3 10-Aug-2011 Makoto Onuki <omakoto@google.com> Remove unused callback

Bug 5143491

Change-Id: I20b82551329f1beb05dc4039cf0d501fe9a9e676
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
f81b6d9ba129f0220de93aa9a7426547889755c3 09-Aug-2011 Makoto Onuki <omakoto@google.com> Group editor: Handle rotation correctly

- Properly save/restore fragment state
- Don't close cursors loaded by cursor loader.
They are retained through orientation changes. Closing them manually
causes accessing closed cursors after screen rotation.

Bug 5075387
Bug 5136936

Change-Id: I7722d90e5a5b52af1666a69bc56d1df27c4de2a0
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
d25d46b30ae006a17a68906e2a774a9691b5f9db 08-Aug-2011 Katherine Kuan <katherinekuan@google.com> Fix back button on group editor

Bug: 5121656
Change-Id: I78cdbf2cff82cb510539c25716767674f5bade0a
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
1390f85d3776dd9ad9d38f611f3a0d4ed59f6249 27-Jul-2011 Katherine Kuan <katherinekuan@google.com> Modify action bar for group editor and group card

- Remove home icon in group card
- Change done/cancel buttons in editor
- Remove old honeycomb style on editor activities
and have it use the new split style solid action bar one

Bug: 5081353
Change-Id: Ie39f7f1ea5bd80d5246158442325207effd6aff7
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
a615b7ac82f3512a1689bab3542bbe403ed90923 26-Jul-2011 Katherine Kuan <katherinekuan@google.com> Go to group card after group editing

- Unfortunately, since we don't have support for group URIs
(to view a group, edit a group, or view the group list), we need
to determine whether we should set an activity result or
launch the GroupDetailActivity to view the group after editing
is finished.

Bug: 5042435
Change-Id: I71357dfc44f8539273e12169aeea78d80d258a06
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
53b427b3dc6f04340133b2da135b3f5efea4de11 17-Jul-2011 Makoto Onuki <omakoto@google.com> Make search less magical

- Remove PeopleActivity.mSearchMode. Instead, always ask ActionBarAdapter
the current mode.

- Don't use the default search behavior (i.e. send a new intent) on 1-pane.
Now 1-pane and 2-pane go through the same path for the search menu item
and for the search key.
i.e. when search key is pressed, show the search view (only on 1-pane),
set focus, turn the "all" list into the search mode too.
(and the "all" list should initially show all contantacts eventually, but
it's another issue which hasn't been fixed yet.)

- Remove dead branches.

- Instead of startSearch, override onSearchRequested(), which is the preferred
way of implementing a custom search action.

Change-Id: I4fd15a7f3164a3832df21b8fa1fb215e53d1a3e1
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
43fbbc1e5bbc295d0be5033a002e9f532fdfb119 15-Jul-2011 Makoto Onuki <omakoto@google.com> Disable search key press on 1-pane detail/editor activities

These activities don't have the search menu item, so the search key shouldn't
work.
(The behavior was weird anyway... e.g. it worked differently on
ContactDetailActivity and GroupDetailActivity...)

Bug 5032530

Change-Id: If3504cbd3e5cf027d43eec68d8f89e41bd7d324c
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
2d851cc895ffc7afd322298c7d4391ca5bea1a2d 06-Jul-2011 Katherine Kuan <katherinekuan@google.com> Batch add and remove group members in group editor

- Create save intent in ContactSaveService to update
the group name, add a list of new members, and remove
a list of existing members

- Add raw contact ID column to GroupMemberLoader so that
the raw contact IDs can be used in ContactSaveService

- Remove old code that would do the database save one at a
time for each contact member when the action was taken
(and remove the step that would load the full contact because
we now only need the raw contact ID)

- TODO: General cleanup to just use raw contact IDs everywhere
and have one Member class (get rid of SuggestedMember)

- TODO: Allow users to add contacts for new groups (still
can only change the name), but this should be straightforward
after this change

Bug: 4961845
Change-Id: I8a2f1086feecbb63dc6eb3d1e985bccabe28b803
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
971116e466757434f4979a61d4f58ea0deac1ea4 05-Jul-2011 Katherine Kuan <katherinekuan@google.com> New group disambiguation dialog

- Since switching accounts in the group editor is difficult
(i.e. we need to wipe all added group members when accounts
are switched), it's easier to just have an account disambig
dialog when you first create the group
- The disambig happens as a popupwindow anchored to the
action bar "New group" button if it's a wide screen
- Otherwise the disambig is a dialog that comes from
the GroupEditorFragment

Change-Id: Ibd75607b326e600c412f4bd04eb4cc72534aed72
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java
c6b8afe730255537978f2c938cca6986cae63c34 23-Jun-2011 Katherine Kuan <katherinekuan@google.com> Group editor on tablet

- Allow autocomplete to add new members which presents
the user with suggestions from the raw_contacts table
with the same account name and type as the group
- Hook up the "new" and "edit" group buttons on the tablet
- Once the user exits the editor, update the group list
and scroll the group list to the group that was just edited
- Allow rename of groups (make the names of read-only groups
not editable)
- Allow removal of members
- Hook up the done / cancel / up / back buttons

- TODO: Be able to create a new group + add new members
in the same transaction. Then the new group editor
will allow adding members at the same time. Currently
you can only add a name to a new group. Once it's created,
then you can go and edit the membership.

- TODO: Bulk add/remove members in one transaction when the
user exits the editor. Currently it's saving the change
after you modify the membership list (even before you hit
the "Done" button in the editor).

- TODO: Add member status message and chat presence

- TODO: Add UI for non-editable groups

Change-Id: I1f32a28862c358b8bd1469666743cd240d28f80b
/packages/apps/Contacts/src/com/android/contacts/activities/GroupEditorActivity.java