History log of /packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
cd321f65f1e50409812976380ad1f0fdb3fa35cb 28-Oct-2013 Yorke Lee <yorkelee@google.com> Move ContactLoader related code to ContactsCommon

This CL simply moves classes from Contacts into ContactsCommon.

This is needed so that Dialer can use ContactLoader related code
for b/11294679. A ContactLoader will also be needed in the future
to allow InCallUI to download hi-res photos while in call.
Bug: 11294679

Change-Id: Ia033f3ea2406a907a4e71290c9ce810a5583dab8
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
7d3b91577f84a4f5092d28ed0f3cfe7e0df32696 05-Apr-2013 Fabrice Di Meglio <fdimeglio@google.com> Fix bug #7536213 UI should be mirrored for RTL languages (people, dialer, in-call)

- add start/end properties aside to left/right ones
- update Gravity to START/END
- add mirrored version of Drawables
- use android:textAlignment="viewStart" when needed on TextView
- use android:textDirection="ltr" for when needed for Phone Numbers

Change-Id: I5f5deb69e4af350b632a6592447721196bedb539
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
738ff8623dc77dd91a1b9023861e924ba5e4c27e 30-Nov-2012 Chiao Cheng <chiaocheng@google.com> Move ValuesDelta to ContactsCommon.

Bug: 6993891
Change-Id: I8b065c55100a152f72cccea5b62f10a8e30161c2
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
aa690d4949b8105e5bcf10569b7cf4fae36741de 29-Nov-2012 Chiao Cheng <chiaocheng@google.com> Prefactor RawContactDelta.ValuesDelta into top level class.

Making ValuesDelta into top level class so we do not have to move
RawContactDelta into ContactsCommon. ValuesDelta is used by
CustomContactListFilterActivity which needs to be moved.

Bug: 6993891
Change-Id: If7371cf08ac0e14218fb790c96856e971fa613ec
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
428f008513d1591cc08fcfe2cf0c9237fb313241 14-Nov-2012 Chiao Cheng <chiaocheng@google.com> Move dependencies of AccountTypeManager into ContactsCommon.

Moving dependencies in preparation to move AccountTypeManager.

Bug: 6993891
Change-Id: I804cdbe64b9b8111ed286037943d593e11dc4044
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
851222a96b5d68602fb361ea3527101e893f67e3 21-Jun-2012 Maurice Chu <mochu@google.com> Added thin object layer around contact data

This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.

ContactLoader.Result class has been pulled to the top level as
the Contact class.

The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.

Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.

The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.

Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
e0b2f1e2d01d1ac52ba207dc7ce76971d853298e 12-Jun-2012 Chiao Cheng <chiaocheng@google.com> Global import order fix.

Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements

Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.

Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
a04dc9c9ed2812af8f4466c2a5225a37d38d250e 15-Apr-2012 Daniel Lehmann <lehmannd@google.com> Tweaked the input dialogs for the group name and the type

- Tweaked padding in type editor
- Made it so that OK is disabled in group editor
- Automatically show the keyboard
- Made the implementations a little more similar to each other

Change-Id: I2c1a131a7eb7ea3e306fdaa430be8945accf915b
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
ca87e9c598929b5b6a62da9b80d2114168e24274 06-Mar-2012 Daniel Lehmann <lehmannd@google.com> Added some smoother transitions to the editor

- Transition when removing a field
- Transition when pushing the "Add organization" button
- Transition for visibility of "Add xxx" when entering text
- Added pushed state on "Add organization" button
- Increased the height of "Add xxx" to match the expanded size for simple
Editors from 40dip to 48dip

Bug:6009430
Change-Id: Ia4524006b528f49d587c6277ecc98b11f77ddc0d
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
67713b3e6e3af70020350e2650738389f19c073e 22-Feb-2012 Daniel Lehmann <lehmannd@google.com> Turn off Spinner's state management. It kicks in after our own management

Bug:6047012
Change-Id: I8019f25b194e7edf7d2cd61c679c9622d93418ff
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
e55faef88185628c842e0aa778d883f209323630 07-Dec-2011 Katherine Kuan <katherinekuan@google.com> Fix suggestions box being 1 character behind

In contact editor, the aggregation suggestions is
1 character behind because the ValuesDelta sent to
the AggergationSuggestionEngine contains a structured
name that is not fully synced with the display name.

The solution is to wait for the structured +
unstructured names to be synced before sending it
to the suggestion engine.

Bug: 5507256
Change-Id: I5f9b6da40ef7843a3b67dc9deaa2af3cbb68c477
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
eb765ac75178eccf5a44a3410e21a7f88419fd84 22-Nov-2011 Adam Powell <adamp@google.com> Fix bug 5494702 - Text editing options not visible in custom label dialog

Use the correct context for creating the EditText field for use in the
custom label dialog.

Change-Id: I8c82fe53f0813aeed118c834eb208cb338fcbabb
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
a3e69af03dd35124941a48c3bfaea87468d66863 25-Aug-2011 Katherine Kuan <katherinekuan@google.com> Contact editor assets and redlines

Change-Id: I08c11dce7f07155a919fec9989587af5f11a3220
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
37bddc2fa266fa0378fcd85ac5047b1fb0af2dc0 10-Jul-2011 Katherine Kuan <katherinekuan@google.com> Add contact detail to existing contact

- Works for phone numbers and email addresses, otherwise route
intent to full contact editor

- Contact card icon / "OK" button first saves the change and then goes
to the contact card

- Port over from GB branch, updated references to non-existent classes,
added new layout to look more like QuickContacts/contact tile,
applied to ContactSelectionActivity instead of contacts list,
added support for non-editable contacts, fix layout for phone
landscape and tablet, inflate the right editor layout based on the
DataKind instead of emedding a TextFieldEditorView
directly inside the XML, use AsyncTask instead of WeakAsyncTask

- Fixed NonPhoneActivity intent flags so that the activity results
will work correctly (will allow contact card to be launched if user
requested to do so and the cancel button in the ConfirmAddDetailActivity
returns the user to the picker)

- Fixed activity theme for NonPhoneActivity to not show a title bar

- For a contact made up of multiple raw contacts, find the first
editable contact to add it to (instead of always picking the first one
which could be non-editable).

Bug: 4295003
Change-Id: I111eaf6bbc78861c2b6a27c93086d00697869ebb
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
1ebbd5bbe71814123b80df702b474bcd7196cbb7 05-Aug-2011 Katherine Kuan <katherinekuan@google.com> Pixel perfect for tablet contact editor

- Remove a bunch of files because now the tablet should
look like the phone layout

- Fix padding / margins

- Don't allow phonetic name to be deletable (it would
just clear the field) so that the structured name
and phonetic name now line up (UX decision)

- Make text in editable fields centered by
setting a specific height on the edit text field
if it's not multi-line text

Bug: 5096927
Change-Id: If5d27752d79680cd40316428c7aa9ec30af6e320
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
fd70903236883f47b21f23b8cb49a1ccacdfcdf1 02-Aug-2011 Katherine Kuan <katherinekuan@google.com> Pixel perfect work for phone contact editor

- Always show account header for raw contacts
- Align text fields and titles along the left margin
- Align spinners
- Use "Add new" as the default text if there's no value
in Event or Groups field yet
- Restyle account header
- Use primary/secondary colors everywhere
- Non-editable contact fixes: remove "not editable on
this device" and replace it with a toast when the
user clicks on the header, restyle item_read_only_field

Bug: 5097095

Change-Id: I94a6c91b05344028b64c62735fb4559f9944529d
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
2293e55d550fbc9974d1185960715e59acb14a85 22-Jul-2011 Katherine Kuan <katherinekuan@google.com> Clear field if try to delete last field in section of contact editor

- Don't remove the field if it's the last field in the section,
just clear all EditText fields in that editor

Bug: 4382255
Change-Id: I2b436fbe895e5cc52770eefedaa2bc5f9726605f
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
a66642330b5c4a62c8b7ce438ccff57c3b017eb1 21-Jul-2011 Katherine Kuan <katherinekuan@google.com> Show more fields above the keyboard in contact editor

- For the phone
- Small visual fixes that will allow as many fields as
possible to be visible when the keyboard is up
* Smaller icons, fonts
* Change some colors
* Remove the "+" icon
* Make address field default to min height 1 line
instead of 3

Bug: 4382255

Change-Id: Icc665c866e4c1cfaa0ba8de7dae9a0c1cbd1b575
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
a94859f61c216d4e137a631995026d3ddefbbf70 20-Jul-2011 Katherine Kuan <katherinekuan@google.com> Contact editor fixes

- Bring back data kind titles
- "Delete" button should be invisible not gone
- Make field + spinner horizontally stacked instead of vertically
stacked on phone
- Don't show account header if editing an existing contact that
only consists of 1 raw contact

Change-Id: I7dd4bfdf273eeaccca8399d182c0a56a6e23a8c7
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
5e330ed98f1c2711b4cd3b375a1c0f76bedaf3e1 16-Jul-2011 Katherine Kuan <katherinekuan@google.com> Remove unnecessary delete buttons in contact editor

- Don't offer the delete button until the user has typed something
into the field

Change-Id: I37585565b77f3d6a06677341191bb0f0cc72e508
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
a2d4a9652fb4db9ee222abc7a637366c6c50427c 07-May-2011 Katherine Kuan <katherinekuan@google.com> Fix font sizing and spacing in editor

- Remove name labels
- Remove extra divideres

Bug:4382255
Change-Id: I59c5b91e699b7386690e6df58e58b247d3086c99
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
12a93637e406ba7f3da4db8d53cd035c2c1d6e6e 05-May-2011 Katherine Kuan <katherinekuan@google.com> Pressed state for buttons

- Delete button, expansion button, fix padding on messaging icon

Bug: 4382255
Change-Id: I5ef0a9ee760a095b4f9e0efda71c13c4b89328e6
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
2591436971bad3050c85929c8e0c5a8d48111f88 30-Apr-2011 Katherine Kuan <katherinekuan@google.com> Fix "add field" logic

- Only update "add field" footer when field goes empty --> non-empty
and vice versa, fix the case for 4 line addresses in Exchange contacts
- Add property in DataKind class for "add field" string
- Remove hash map of mime types --> string resource IDs in
KindSectionView
- Remove "add internet call" string

Bug: 4363151
Bug: 4371568
Change-Id: Id2fec743a7c3e68d8404591cc61de20487245b0a
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
63ffb90935d8aec295e4a8f62af6c77dafe1899f 27-Apr-2011 Katherine Kuan <katherinekuan@google.com> Refactor to inflate views from XML

- This is part 1 of getting the contact editor up to par with
the UI mocks, there are some known issues that will be fixed
in coming CLs (i.e. add button functionality)
- This way, the field editors can be vertically stacked
on the phone and horizontally stacked on the tablet.
- Get rid of duplicate labels by using the hint text in the field
or spinner as the title

Change-Id: Ia00a1a65ad0bbd7a4bc05ccb93dd1b1496bca5df
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
405671a7b42d97ebf7ae7c0eeb4721f881139673 29-Mar-2011 Daisuke Miyakawa <dmiyakawa@google.com> Move DataKind outside AccountTypes

Bug: 4184675
Change-Id: Ibb20cb8b38d0272963fc5330c738bd17c61a5542
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
60b239c24c05233bbf3f7cb45697252e15ec76cc 08-Mar-2011 Daniel Lehmann <lehmannd@google.com> Treat empty and null strings equally. Fixes a data loss on e.g. rotation

Additionally, this will prevent the editor from going into a dirty state
on open, so pressing "Done" will not cause a save anymore if nothing has
changed

Bug:4027153
Change-Id: I0f55b75356b498588a53ad0bc91afaec3ed9434c
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
11bb73bcdf4290ced99e3e06b1f76d4c37357aea 26-Feb-2011 Dmitri Plotnikov <dplotnikov@google.com> Preserving name structured on expand/collapse operations

If the user does not change components of the structured
name, the expand and collapse operations in the editor
should not reparse or re-compose the name.

Bug: 3473362

Change-Id: I4fe5f0d06757b2fe098a5bd895c84108195049e9
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
cb08f1b2a3f2e6e21aa5d993cf44d04658316ccc 04-Jan-2011 Dmitri Plotnikov <dplotnikov@google.com> Preserving custom dialog state on rotation

Bug: 3263726
Change-Id: I79ff83dfa79ad469ee6897774f1f21aebe5e0c68
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
4fa9cd0088de76d83803210b39f373cd980fd846 11-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Fixing NPE in contact editor

Bug: 3276044

Change-Id: Id66492cd0e8570bbe9333e5085d65b47f42525eb
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
91d8e892d549bbeba721cb434163a83bc99330a9 08-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Aligining fields in the editor

Change-Id: I7137055bf8ab61df33f6a87c8e6c8227dbee8a9f
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
63c311a278cd8ba28d6d8f3b49c0ccd4dffeb57d 08-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Adding "Cancel" button to contact picker

Bug: 3254117
Change-Id: Id0a40fc63f2ca094c7a1a77205ada84a58c2c457
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
7d4a8dda946f5c013573e4d6601fc14c03156ba6 08-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Preventing aggregation suggestions from showing up on rotation

Bug: 3263714
Change-Id: Ifacfb1614b609ea9768eb25c795657cd55a16cdd
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
14918c07e1cb3b5b190bec4cc9106db7adbba29f 08-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Preventing custom type dialog crash on rotation

Bug: 3263726
Change-Id: I4afd193fa97578c98785105d0465c286bd085381
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
2fcfa499dd44f62dc63636e363522354e13aa20d 08-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Changing from PopupMenu to Spinner

Change-Id: I24d3a76479b3741f5294abfc1003a8c62e56a5d9
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
02bb1252aa990813fa9e86ad75c458acc15e6801 06-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Removing progress dialog when saving a contact

Bug: 3253127
Change-Id: Ifd3b58f202fea76596880fb6de9f8acc46a32d79
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java
18ffaa2561cc7dd2e3ef81737e6537931c0a9a11 03-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Renaming a couple of packages

Change-Id: I2c0f86b51baa622df629206f8b79ef1d0df09119
/packages/apps/Contacts/src/com/android/contacts/editor/LabeledEditorView.java