| 400659f14936268515b9ad01ace2b13652817876 |
|
30-Jan-2013 |
Tom Taylor <tomtaylor@google.com> |
am 2549ff53: Merge "Fix NullPointerException in RecipientsEditor."
# By Bin Li
# Via Bin Li (1) and Gerrit Code Review (1)
* commit '2549ff535f2f79af2ee22ab9697ea726d9fe3671':
Fix NullPointerException in RecipientsEditor.
|
| 56d79f319079895a186a85d54e6afae83cbb5f81 |
|
30-Jan-2013 |
Bin Li <libin@marvell.com> |
Fix NullPointerException in RecipientsEditor.
In function PointToPosition, should check if mLayout
is NULL before call function getExtendedPaddingTop
because mLayout is refered in getExtendedPaddingTop.
Change-Id: I750313c3a4bceb7213433cf3d110ea9e87cee0b8
Signed-off-by: Bin Li <libin@marvell.com>
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 24da6ee1d535d5d7aa1d43e1a386bb37048fbbc6 |
|
27-Nov-2012 |
Tom Taylor <tomtaylor@google.com> |
Area code is not displayed in To: field, while sending SMS from call log
Bug 7614149
The extra space after the comma was screwing up the Chips parser and causing
the comma delimeter to be parsed as part of the number.
Change-Id: I6239f6b1e45075b6faf9e7f0323d00945b23ce73
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| d64419030e1fec1e751695dab3bd7236e2fb0214 |
|
02-Aug-2012 |
Roger Chen <cxr514033970@gmail.com> |
Clean and format all imported packages
Change-Id: I2e45f5ba1d56b9b17314a8b0f4c0fc1a5d8fc4d9
Signed-off-by: Roger Chen <cxr514033970@gmail.com>
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 452c9fda4e3c9ef219bca695630faa8c802fd09b |
|
26-Jun-2012 |
Tom Taylor <tomtaylor@google.com> |
Sending multiple addresses via intent will result in a single address
Bug 6728637, 6736747
We need to append the addresses one-at-a-time for them to be dealt with
by chips. Also, if you manually type in multiple numbers (vs. choosing
multiple chip suggestions), only the last number will be selected. This
is because when the user types a comma to start a new number, the chips
code asks the text editor for the last token. The mms recipient editor's
token parser looked at the position of the cursor, saw it was a comma,
and returned that position. With this change, if the cursor is sitting on
a delimiter, it will back up to find the previous token. This fix actually
fixes another odd behavior. Prior to this change, if you hit backspace on
a chip, it would turn into the number and you had to delete all the chars
of the number to delete the chip. With this change, the chip is deleted in
a single backspace. Note that this token parsing didn't change in JB, but
the interaction with Chips resulted in this bug.
Change-Id: I9de569a803ba319c5ac0576a649fcf057d94c133
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| b30a184c839d71adcc86dfd3e27a1e8bd59ff85d |
|
10-May-2012 |
Tom Taylor <tomtaylor@google.com> |
Attachment is getting discarded and unable to send message in messaging
Bug 6471138
Complicated repro steps for a relatively simple bug. When populating the
receipients editor with no recipients, the underlying chips base class
wasn't doing anything. Therefore, the ui was left in a state showing
a recipient, yet the conversation didn't think there were any recipients.
Trying to send in that situation triggered the recipients mismatched warning.
Change-Id: Ifa93e32901ddccfa5e5a7bf13b191a5b13e18368
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 8f4333b0cd6bcacfcb4ffc9f1cc188f1ceb6170e |
|
27-Apr-2012 |
Tom Taylor <tomtaylor@google.com> |
Red chip is shown for the number though the number is correct
Bugs 6391820, 6373342, 6387440, 6404611
Add a Validator to mms's recipient editor. Without a Validator, the chips
code will always construct a chip and color it red, indicating it is
invalid. Since mms has to handle email addresses, phone numbers, short codes,
and aliases, anything is valid. With this change the chips are created with
a gray background to match that of gmail (b/6391820). Also, supply a custom
chips recipient list item so when we list the phone numbers, we can display
the type as well (i.e. Mobile, Home, etc.). Also fixes coming into the
Messaging app via an intent (i.e. from Contacts) and showing the chip for
that person, instead of just the number.
Change-Id: I6826ecbfbd2e389b7d3fa5852059807db9431ac1
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| fadeebc9df5e72f52438229b98ec6c2ee1938c51 |
|
17-Apr-2012 |
Tom Taylor <tomtaylor@google.com> |
Area code getting removed
Bug 6332661, 6321866
Change-Id: Ib8a8928ff815d5137ae54ce5c1ca82d749b12f1e
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 49e599163acc3200e9bda4fb7825c041b67960f1 |
|
13-Jan-2012 |
jshin <jgsin@samsung.com> |
Fix for Arabic digit issue in MMS app.
Change Arabic and other Unicode digits to ASCII digits.
bug: 5615791
Change-Id: I22b32aabf3433df6381451bb4989812344e84d6c
Signed-off-by: Jake Hamby <jhamby@google.com>
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| cd775166502f602abfc41eee0cdc749a4b655867 |
|
12-Apr-2012 |
Tom Taylor <tomtaylor@google.com> |
Sending MMS does not show in active thread and starts in different thread without any recipient
Bug 6330102
Use an Rfc822Tokenizer to tokenize the result from the ChipsUI so the
address can easily be extracted.
Change-Id: I84d4c1470eb5c40e362c555d8f881eb7dd2d7e9c
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 2d4b986e57a67eabacc0599219c726de8600836d |
|
07-Apr-2012 |
Tom Taylor <tomtaylor@google.com> |
Support "chips" UI for choosing addresses for compose
Bug 5066294
Change-Id: I3e50b25587c15663514e20bb18c5dba22be499f8
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| ba7455b4de3c892aed830763ca80d22c8c940e78 |
|
05-Mar-2012 |
Todor Kalaydjiev <todor@google.com> |
Minor simplification in the code; no logic changes
Change-Id: Iefd4915abb32f8dbea96a7ac54bcc3dbf1fe4c24
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| c7797433b1641be0cb77e02541b8bfed94c48835 |
|
07-Feb-2012 |
Tom Taylor <tomtaylor@google.com> |
MMS appears after delay in the thread
Bug 5032682
Bug 5939766
When sending an MMS, immediately insert a placeholder pdu in the pdu table
that'll show the user that we're in the process of sending the message.
Also fix a bug where typing a single char wouldn't bring up the contacts
search results.
Change-Id: I2f6f14048a07360b69a2529e8a61c524a753485c
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 2ddc2c0585fec6fca59acc115e26dc51f69aacc5 |
|
28-Sep-2011 |
Tom Taylor <tomtaylor@google.com> |
Weird phone number stored in canonical_address table
Bug 5375782.
Very tricky bug. In the recipient editor, we always leave a trailing
comma to make it easy for users to add additional recipients. When a
user types (or chooses from the dropdown) a new contact Mms has never
seen before, the contact gets the correct trailing comma. But when the
contact gets added to the mms's contacts table, contacts sends out an
onUpdate to CMA. CMA would recompute the recipients and since the
recipient editor was still visible, call mRecipientsEditor.populate(recipients).
This would replace the recipient that had a comma with a recipient
without a comma. When a user manually added a new comma to add another
recipient, this would eliminate the span inside the text. The span contains the
number part of "Fred Flinstone <123-1231>". Hence, the whole
"Fred Flinstone <123-1231>" would be considered the number of
the first recipient and get entered into the canonical_addresses table.
The fix is very easy. All recipients have commas. There's also a change
to rebuild the contacts cache when we delete a thread. We do that because
the provider is now deleting stale contacts when threads are deleted.
Change-Id: I8fdde2ba64e934c9b539fa0fae433ef23fd254bc
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| a6dd14dc0963aa8f30e625aa88e925e3fa0744f0 |
|
25-Jan-2010 |
Bai Tao <michaelbai@google.com> |
Provides a way to let user select the recipients from a list of phone numbers.
a. Add a buttion beside to recipients box.
b. The multiple phones picker which is implemented in Contacts is launched when user touch the button. The existent recpients are selected by default.
c. The user's selection will be populated to recipient's box when being back from multiple phones picker.
Also fix the related issue that the draft message is left once the recipient is changed.
Change-Id: I036b65dd1a651aae2fbb2e58a4b2b9e126ca4e74
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| f7e8281a223af6228e6399055a6197a1edd9bc3a |
|
09-Mar-2010 |
Tom Taylor <tomtaylor@google.com> |
Remove mms-common
Get rid of the mms-common library and move the mms files back into the
framework where they originally came from.
Change-Id: I8ce2b0a2a3cfc6b7da13ce0e791173c09dd8f0f5
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| fd644551e8506266aad2b76463b51b44154ed62f |
|
29-Jan-2010 |
Tom Taylor <tomtaylor@google.com> |
Update refs now that MMS is removed
Move MMS to mms-common library. Update imports.
Change-Id: I28fa24a68c27977eba58cb62f2667596d3abe2c4
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 6be18bedb5b87dbbcdb54f37d5a0945bd0f71377 |
|
17-Dec-2009 |
Tom Taylor <tomtaylor@google.com> |
Unbundling work
This is the first step in unbundling the Mms app. Some of the changes include:
- moving some of the Mms code from the framework into the app itself.
- same with emoticons
- remove dependency on internal drawables and add local copy to mms
- some dependencies on various internal classes now moved to android-common library
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 715e32f97bd9d8ce4b5ba650b97ba4b137150456 |
|
18-Nov-2009 |
Tom Taylor <tomtaylor@google.com> |
Fix ANR from calling Contact.get()
The Contact.get() API allows the caller to specify whether the operation
can block (looking up contact info in the DB) or not. There are about 10
places where various callers were passing "true" to canBlock, all coming
from the UI thread. We've previously fixed Contact.get() to always return
a Contact, with the number filled in, even if we don't have the contact
in the cache. With this change, never block the UI thread getting a contact.
The worst side-effect should be showing a number, instead of a name.
Fixes bug 2265631.
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 49183c099b1ac79f3c2fe97368ed76caba4ca98e |
|
10-Nov-2009 |
Wei Huang <weih@google.com> |
bug 2250049: need to allow email address when sending a SMS message.
- my change Ia80a2736 added code to validate and scrub MMS address. However, as a side effect
it also disallowed email address for SMS messages. Fix that.
Change-Id: Iac3783e056c933531da73bd53eb8ea9d7c0eb154
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 78f81825431c8c52cad57bc4a363747533a701ab |
|
06-Nov-2009 |
Wei Huang <weih@google.com> |
bug 2236527: need to scrub the phone number before sending a MMS message.
- add MMS address validity checking and scrubbing. If the phone number used to send a MMS message
contains invalid characters (non digits and non-valid separators), we now warn the user when he tries
to send the message. The prior validity checking code only checks against GSM SMS address, so it
would miss all the invalid chars for MMS address.
- assuming the MMS address is ok but contains separators that are not valid MMS address chars (as
far as the network is concerned), we scrub the number when creating the SendReq data structure for
MMS message.
- flag a few places where things are still not correct, but too risky to fix for MR1.
Change-Id: Ia80a2736f955b94a8cac51ffeb06617a95580ab8
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 25b939e5a7ecb1e0879b684dc5bc55183cf468b4 |
|
04-Nov-2009 |
Wei Huang <weih@google.com> |
bug #2236535: use an initial bad address (from a merged contact) would lead to permanent failure for the messaging thread even after a good number is used.
- when the user selects/types a new number in the recipients editor, and we find a cached contact, set the contact's number to be the newly selected number. This will allow the user to correct the address, at least until the next time MMS rebuilds the contact cache with the bad number stored in the database. This will get us to par with the Cupcake behavior. Unfortunately, after MMS app is relaunched, the thread would use the bad initial adddress again (loaded from the 'canonical_address' table in the db). That's a much harder, riskier fix, so deferring to later.
Change-Id: If32958482b14848bd770cff50e4736457c47ac8a
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| b8bd3d53720ee9ebf9146a1d515a516c2068ff69 |
|
21-Sep-2009 |
Tom Taylor <tomtaylor@google.com> |
Handle contacts with commas
Treat contacts with commas as a single recipient, rather than parse the contact
into multiple recipients. Prime the recipient separator with a comma.
Change-Id: Ia4587282423ae3f318fc7db548ae694b9701be65
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 817eb982a66303a8f87fc3061e3493a232627e96 |
|
16-Sep-2009 |
Satish Roddom <satishroddom@motorola.com> |
Support sending SMS to carrier alias via sms-to-email
To support this carrier feature without breaking other checks, the following logic is used:
If the existing Email address check fails, check whether entered recipient is a valid
phone number. If not check whether it is an alias, and if it is an alias, send it to Email
gateway.
Bug: 1999421
Change-Id: I4d8184bf0911bb4426c5a73e86cd932b999c107b
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 5d31dfbc15ca3403b8c0a489256fc1e7fba38101 |
|
18-Aug-2009 |
Tom Taylor <tomtaylor@google.com> |
Don't auto pop-up completion list
Sometimes when you compose a new message, the recipient drop down pops down before
the user even types a single character. Make sure the user has typed the minimum before
popping down the list.
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 592a22133822eaa0f54a1de1d56cea14f57c2677 |
|
06-Aug-2009 |
Tom Taylor <tomtaylor@google.com> |
Allow ; between recipients
A bug requires us to accept a semicolon as a delimeter between recipients.
Fix the RecipientsEditor to handle both commas and delimeters as separators.
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 3a5d8c239410c14e993b1f4370ea304fb5719b13 |
|
31-Jul-2009 |
Amith Yamasani <yamasani@google.com> |
am 3f1a2ade: Fix #2021958: "next" doesn\'t work when composing message
Merge commit '3f1a2ade1338a719ceb0fff053951577a21ebec4'
* commit '3f1a2ade1338a719ceb0fff053951577a21ebec4':
Fix #2021958: "next" doesn't work when composing message
|
| 3f1a2ade1338a719ceb0fff053951577a21ebec4 |
|
30-Jul-2009 |
Amith Yamasani <yamasani@google.com> |
Fix #2021958: "next" doesn't work when composing message
Set the imeOptions attribute on the To field editor.
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 1d98ae0b203e01034ddead4214d1520ce863a23b |
|
22-May-2009 |
Ficus Kirkpatrick <ficus@android.com> |
New data model for contact information.
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 66dde9460badebf8e740275cabde9cca256006eb |
|
16-Apr-2009 |
Ficus Kirkpatrick <ficus@android.com> |
Stop requiring a Context to be passed in to ContactInfoCache.
It already has a perfectly good one sitting around in its instance.
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 4a289bdc49453d22851ce7a46a893604536a539d |
|
31-Mar-2009 |
Tom Taylor <> |
AI 143834: Fix bug: 1716138 - Editing recipient filed restores the old recipient number code.
Implemented a suggestion from enf:
If the user is in the middle of editing an existing recipient, don't offer the
auto-complete menu. Without this, when the user selects an auto-complete menu item,
it will get added to the list of recipients so we end up with the old before-editing
recipient and the new post-editing recipient. As a precedent, gmail does not show
the auto-complete menu when editing an existing recipient.
BUG=1716138
Automated import of CL 143834
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 3d2107af884e95720b72201e99d9ab4bce9bba3b |
|
25-Mar-2009 |
Tom Taylor <> |
Automated import from //branches/master/...@142400,142400
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 2d54f0192a7204138c0a2ca26d8f552a749a0d45 |
|
25-Mar-2009 |
Tom Taylor <> |
Automated import from //branches/donutburger/...@142393,142393
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 836945de572ac80fd6f6a7bf59036d4cce801410 |
|
11-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //branches/cupcake/...@137873
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 2f56791329cefc49ce79663b8d3aff50594cc1f3 |
|
05-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //depot/cupcake/@136594
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 72735c62aba8fd2a9420a0f9f83d22543e3c164f |
|
04-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //depot/cupcake/@135843
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 892f2c5bf965b1431ae107b602444a93f4aad4a3 |
|
04-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //depot/cupcake/@135843
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| e82e62f94d4ba4ac139faf055f40fbbc2b99b551 |
|
10-Jan-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //branches/cupcake/...@125939
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|
| 8eed706474910ccb978acda03e85d3261037da6e |
|
21-Oct-2008 |
The Android Open Source Project <initial-contribution@android.com> |
Initial Contribution
/packages/apps/Mms/src/com/android/mms/ui/RecipientsEditor.java
|