History log of /packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
0e8dc84326ad3e6d146a203538665f98dd98f688 10-Sep-2013 Scott Kennedy <skennedy@google.com> Hierarchical folders in conversation list

Use something similar to the sectioned inbox teaser.

Allow expanding/collapsing when there are too many folders.

Bug: 9604590
Change-Id: I6cc79bd7c033bbf13c750e7720fe71227b38cc85
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
440f4ba393696ebd3b5ee777d43dc6df1e6c0c42 13-Sep-2013 Alice Yang <alice@google.com> Disable attachment previews

Change-Id: Ie1b075a22b6a62f710f98aafdce4b8933fd5480e
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
3b2039afbcd8465ab829ecda8a5b207e988e773c 03-Sep-2013 Scott Kennedy <skennedy@google.com> Preserve advertiser name

We were previously parsing the name as an email address, which
caused problems with certain non-alphanumeric characters.

Bug: 10605932
Change-Id: I1ea17096950f50b68e44cc1c976b69c4060b46e4
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
a2640038ffe8a17fb435b0007ba4ca9ff14d00bd 28-Aug-2013 Scott Kennedy <skennedy@google.com> Temporarily handle a NPE

The real problem will be diagnosed for the next release.

Bug: 9527863
Change-Id: Ib38d833e6dac6702af41030d70fc3903289547c5
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
1591414ed6dc829852edd219c39ae430314ff538 22-Aug-2013 Scott Kennedy <skennedy@google.com> Add the right edge line to all teasers on tablets

Bug: 9177552
Change-Id: I5270a0ae2196e9a6f732ed6d3327ffe3d30f34be
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
68141df2d855af6520a19ff9127f69463d49c3de 20-Aug-2013 Andrew Sapperstein <asapperstein@google.com> New caret for tablet.

Not to be confused with a carrot, carat, or karat.

Change-Id: I3748d295a8599ffcb528bdfc1d376d3fc3b64396
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
8c843a7610fed6ecd8e4e6d9f43c4eea2a7ff3a1 21-Aug-2013 Scott Kennedy <skennedy@google.com> Stop animating checkboxes when we bind a new conversation

Bug: 10413176
Change-Id: I537e770fa5c920e859728778e4fd0af42c98d6c8
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
e0d01fb7379225a0f058999d9da9050f2fcc6945 20-Aug-2013 Scott Kennedy <skennedy@google.com> Show the selected state on an ad on two pane

Also show the selected caret

Bug: 10212376
Change-Id: I075b2aebfbe869c658108f7d36109ad70402b4c7
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
042a530b2296487fa5899a3e871214ac4a47e3d8 13-Aug-2013 Andy Huang <ath@google.com> more metrics

Reorg category/action/label to be more economical. This gives us an
extra slot for data vs. spending on custom dimensions in the future.

Log CAB actions, some settings state, drawer toggles, CAB mode start,
swipe dismiss, and peek.

Bug: 9861033
Change-Id: I16b30356db70f60ed87749f29ddd667790acbb07
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
f27e08e98db1496610c9f216ef6eeb26c39c2da3 09-Aug-2013 Scott Kennedy <skennedy@google.com> Show our own avatar for drafts

Bug: 9762046
Change-Id: I627b459595c3ffeed3ee7fe28b4067140b980699
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
e5707f86f340797d5ee1535bff86d331715cbce9 09-Aug-2013 Scott Kennedy <skennedy@google.com> Make some changes so the ad leave-behind can animate

First, rename INVISIBLE to something so we aren't hiding
View.INVISIBLE.

Second, create a static method for the fade-in animation of the text
so that the ad teaser can use the same code.

Third, modify CIV so that we don't need to be contained in a SCIV for
animations to work.

Change-Id: Ib89015529871bc2b7eba191dd88a4185948927ea
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
022aeeffe491ed8c3deeaf7c0fc7570d57af12bb 07-Aug-2013 Scott Kennedy <skennedy@google.com> Minor change to support swipe to dismiss of ads

Change-Id: Ibe61c6ab069553044650253e7c27b77bb741abae
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
aa76bdfae889b995395a7636742128b3585727f9 07-Aug-2013 Mark Wei <markwei@google.com> Add a setting for attachment previews.

Bug: 10131520
Change-Id: I861a3aa7a1131c1a089011aed7492a0e4ff1ebcc
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
955a766f6c9c30e06dcd504ebc4dd6db510c2fa6 07-Aug-2013 Scott Kennedy <skennedy@google.com> Fix some long-press/drag bugs related to ads

1. Do not allow dragging of an ad
2. If selection/drag mode cannot be entered, return false from
onItemLongClick(), so that we don't vibrate.

Change-Id: I8915213fa567f955268a73534fc4c5d45da1f4c4
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
152cbe4d3b6364aad92684c0c0238d1ee9320197 06-Aug-2013 Scott Kennedy <skennedy@google.com> Fix double flip while exiting CAB mode

Under certain circumstances, a checkbox might flip to a photo, then
flip again, because its animation finished while our "exiting CAB
mode" timer was running.

Bug: 10148310
Change-Id: I91695e4e6b2c3b1c2a82a7ae3ce23cb426bcc342
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
d35dcd8d74d2cc95ccaf28a5bc28344fda309fc3 02-Aug-2013 Scott Kennedy <skennedy@google.com> Support clicking on the info icon of an ad

Change-Id: I3176bcd1a1da8f915a28ccecbc0a66d0b8fb6357
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
670c280136f587688d41027ce1ff1596068a35e0 01-Aug-2013 Mark Wei <markwei@google.com> Fix nit 5. Do not decode in background thread if cache is not warm.

When the ReusableBitmap pool is initially empty, all decodes must construct new
ReusableBitmap objects, which often causes GCs that cause jank during scroll.
This prevents the jank by notifying the ReusableBitmap pool that a scroll is in
progress, which causes the pool to block on poll() if no ReusableBitmaps can be
returned.

Bug: 10083052
Change-Id: Iaf8b244617a05d4736df041e888c9140d182c3a3
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
52a61db87c487fe5bb7cc673037887a6d35b0f0f 02-Aug-2013 Mark Wei <markwei@google.com> Fix nit 9. Add setting to change parallax speed and direction.

Change default speed to 2.0 multiplier.
Change default direction to normal (new) parallax. This looks like you are
looking through a window, at the attachment previews which exist in another
pane.

Bug: 10083052
Change-Id: I91f91ae57cda2da22cc5e3330f67982df454e7bc
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
4503d8cd22fd866ba114d3f486b78bbbfa0c83dc 01-Aug-2013 Scott Kennedy <skennedy@google.com> Merge "Don't show ad image if sender images are disabled" into jb-ub-mail-ur10
2838681e487508af50e8d682728726c0722d00ec 01-Aug-2013 Scott Kennedy <skennedy@google.com> Merge "Clean up AdTeaserView" into jb-ub-mail-ur10
65b6d180f50922a3393795203cae68a5a2f6a33d 31-Jul-2013 Mark Wei <markwei@google.com> Fix attachment nit 4.

Add ContiguousFIFOAggregator to aggregate decode results and display them in the
correct order.

Bug: 10083052
Change-Id: I28b00fe44818f7882e44ef222d85d58ce111c7fe
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
cc8ed8dca4080649c4fff3f6b0e3b35dbf0145f2 01-Aug-2013 Scott Kennedy <skennedy@google.com> Don't show ad image if sender images are disabled

Change-Id: Ic3902cebe75f2076a8fe81abf4641394c91015aa
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
52b280a82df262f62632bd12bba84b4752f14634 31-Jul-2013 Scott Kennedy <skennedy@google.com> Clean up AdTeaserView

The info icon is now in the right place

Change-Id: I04d120b0940d4b92de174e9081ed24e2a9bd81a1
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
1b6fe5b1181ed3d0d0dde44baf5766db1e9c32e6 01-Aug-2013 Andy Huang <ath@google.com> fix 2x1 attachment grids not parallaxing

For 2x1 previews, make sure to pick more a appropriate aspect ratio
that's taller than for 1x1. The dimensions are based on that tile's
drawable bounds.

Because the requests are now specific to tile bounds, add the new
variable to Request objects so requests and cached data don't get mixed
up.

Change-Id: Ide447c5eb07ddd61bf85e77b235ac1c9ccd2eced
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
897d7be9941f61a2d486e7ba3d0ae99d6f0315cc 31-Jul-2013 Scott Kennedy <skennedy@google.com> Fix a NPE

This may be null for special teaser views.

Change-Id: I45a634f368b99396bdf846526275412e49fdd446
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
9ba7fba9213027c6f763001d32d4c88f0d086388 31-Jul-2013 Scott Kennedy <skennedy@google.com> Add peek support back

Bug: 9592097
Change-Id: Id3fe6746bd616ffac03da9e8385b2cc2c10ee826
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
55afb91a9794e74c2da4ca1ba1c7b3f763670d16 30-Jul-2013 Alice Yang <alice@google.com> Merge "Attachment preview parallax fixes." into jb-ub-mail-ur10
bb594cc2fcb06a9205d834cf4330959c816bd86b 30-Jul-2013 Mark Wei <markwei@google.com> Attachment preview parallax fixes.

Fix nits 1 and 3.

Bug: 10083052
Change-Id: I70285f0da1e4edb60fef576285ad6736eb0d977a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
103319aaed26bce257de55b2fe93d4f78d3c59b9 26-Jul-2013 Scott Kennedy <skennedy@google.com> Ads in conversation list

Change-Id: I3095409211d6a6bdc42212bcd6a330333a9da411
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
74db99555be46ccf44691805c359839268326d2e 30-Jul-2013 Andy Huang <ath@google.com> (re)add rendition support to attachment previews

Create new FAILURE state, which is also used when no renditions are
available. In this state, only a static placeholder appears.
Fix state transitions into failure state not clearing pulse animation.
Transitions from thumbnail->full rendition are special cased to not
cause transition effects.

Bug: 9566006
Change-Id: I0b833960a8839b1b6945c3c1fb749eedb14b6157
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
79c3e1ed9cb1e1660c5d34b7bf3f3ab5c5dd5162 22-Jul-2013 Andy Huang <ath@google.com> new allocation-minimizing bitmap decoder

Use a new image decoding and caching framework. This one maximizes
bitmap reuse by decoding into fixed-sized Bitmaps and relying on
BitmapRegionDecoder to only decode a desired region. The ultimate goal
is to allocate memory less often, as each large allocation triggers
GC jank.

The overall request/response abstraction and threading model are now
cleaner, and caching is no longer a required fixture. Multi-core
decoding is now supported, with a currently fixed thread pool size of 4.

Attachment images are the only client for now, but contact photos will
switch to this framework next.

Bug: 9566006
Change-Id: I7c437941fd984cc0038da8f0ffd1df1a9ced4dd3
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
8afccad8b03701577bb4b734a0f4fe76f6cab487 29-Jul-2013 Scott Kennedy <skennedy@google.com> Remove the eye/starflip from conversation item view

The eye is creepy, and nobody knows what it means.

Change-Id: I53a39f3e0ab39b56445eacc66130487469d912fa
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
e80a2954f3ee24f2d1fa62abf90883cdb02b9c5f 26-Jul-2013 Andy Huang <ath@google.com> fix looping draw

CIV.onDraw was indirectly triggering an invalidation.
(Animations should not be triggered by drawing to avoid this
kind of feedback loop. Will fix this soon.)

Change-Id: I45e7e2387a54bd13c6b0efd7f439c471f0ec1daf
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
1fea6a3cffcc8c4afc3d877e5dc57d29f9665942 10-Jul-2013 Scott Kennedy <skennedy@google.com> Better CAB mode

1. Flip out contact image, scale in a checkbox optionally on grey
background
2. Flip stars into peek icons
3. Only peek icon will peek

Bug: 9592097
Change-Id: Ia972132284ef62f4964c7027ab09157a525dd804
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
960ff638eff61b16a2e6a5d74c477d20bd5758ed 24-Jul-2013 Mark Wei <markwei@google.com> Tapping on attachment previews should open the email.

Don't open the photoviewer.

Bug: 9888496
Change-Id: I83d82ff444947634beac61bdf3ac850eed736b83
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
371e0ad5de82585a0a0613ac5410c9ead65613ca 18-Jul-2013 Tony Mantler <nicoya@google.com> Remove unused fields in CIV

Change-Id: Iec828bd691b401c1c71660cc9c0684dd0ad1ccce
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
e97c18f40a946cfa344b0a77e60e133cbd6ecbd3 18-Jul-2013 Tony Mantler <nicoya@google.com> Remove some unused metrics

Change-Id: I6ad749b5dc860c85bfdc7bfbd2b80e119a71ac2e
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
2229eddfba6f7517c43ef49ee67c50c24d4b961a 16-Jul-2013 Mark Wei <markwei@google.com> Add fade animations.
Fix exceptions.
New layout for previews.

Bug: 9745486
Bug: 9860384
Bug: 9885937
Change-Id: Ief210b211e87898c6516d867b59d76c72a765596
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
259df5b9e11908c8ef7c91483924891dd96b3c27 11-Jul-2013 Scott Kennedy <skennedy@google.com> Add a new FolderUri

This will allow us to add query parameters such that Uris will still
appear to be equal, regardless of differences in the parameters.

Bug: 9780067
Change-Id: Iafe39763b3ee448cf02536df89caa736500dfdaf
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
e6196842fbf33b1af33a7b67903c3dcf34d049f3 15-Jul-2013 Mark Wei <markwei@google.com> Don't show attachment previews when all images are < threshold.

Bug: 9854136
Change-Id: Ic9568d9c85f358bf0db9edce84d37cca2fcd84cc
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
dea2d17d3326a3952e7d8c323390a0661d4ccbc2 12-Jul-2013 Mark Wei <markwei@google.com> Do not show small images in attachment previews.

Bug: 9786365
Change-Id: I67b1af3c7b425cd36f911136587153acdc14839d
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
81aea35d45b3d0191ec595562a2fcf67009845d5 10-Jul-2013 Mark Wei <markwei@google.com> Final UI for Attachment Previews.

Placeholder pulsates for images not yet loaded.
One images loads at a time, that one image will display a spinning progressbar
after a delay.
Progress bar fixes to ensure it is rotates smoothly.
Clear section before drawing to it so transparent images look right.
Avoid PhotoManager load loop.

Bug: 9745486
Bug: 9816053
Change-Id: I2e65b3e3484d6da47d4e2523404dc745b99dd04c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
ba73fdddc4e85ef810a7b8d3aa6449656c44a317 09-Jul-2013 Alice Yang <alice@google.com> Fix NPE in ConversationItemView

Bug 9754211

Change-Id: I1b201103f24001be1e3ccf4b8d4791d7613e344e
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
479505d71969e26b0785d8e0e1b81108731cf827 21-Mar-2013 Mark Wei <markwei@google.com> Attachments in Conversation List: Backend changes so that the appropriate
attachments are passed to the UI. Implement PhotoManager so we can start showing
images.

Upon sync, we extract two image attachments from the first unread message, and
add them to the conversations table.

UI changes as well.

Load BEST if that is available, else load SIMPLE.
No vertical dividers in attachment previews.
Attachment previews are above labels.
Round badge appears for unread conversations when there are more images than
shown. Only appears after the previews have loaded.
Clicking on the attachment previews launches photoviewer.
Attempt to load bigger images than necessary to prevent reloading during mark
read/unread and rotate.
Show animated loading icon while previews are loading.
Previews load from top to bottom, from left to right.

Big performance improvements:
No longer decoding bitmap on UI thread. This kills most of the jank.
Only load when we are not scrolling. This kills a lot of jank.
Remaining jank will be delt with later:
DividedImageCanvas.setDimensions() creates a huge empty bitmap on the UI
thread, which causes a GC. ath will fix.

Multiple images in one line now load whatever's ready first. Added tracing.
Bitmap cache given more memory.
Following ath's advice, decode Bitmap from InputStream rather than byte[]. Don't
compress into BitmapHolder. Only use the bigger Bitmap cache.

Bug: 7481049
Change-Id: Icf823f56abc9345e6d0b800a1e6d45444d8fa028
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
3b965d78774a42358ce6bbdcc43b4c8df130a60e 25-Jun-2013 Scott Kennedy <skennedy@google.com> Clean up a bunch of warnings

Bug: 9565838
Change-Id: Ie3a380581e81c63aaa0764875c55bfdccd5f2b13
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
7fdf34185f0d41bdebf25bcf6d14927b16658136 18-Jun-2013 Andy Huang <ath@google.com> clean up 'collapsed' constants

Change-Id: I8bb38ac918f061cd9ed4ad21d9ed686672dbde15
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
da954c000080442f655ce250b3780d1bf249f024 18-Jun-2013 Andy Huang <ath@google.com> am b2354b97: Merge "Fix list caret and highlight sticking when scrolled down" into jb-ub-mail-ur9

* commit 'b2354b97887559e21938ae2e182bfd568578fc47':
Fix list caret and highlight sticking when scrolled down
f0aebd32d750d6e108c8f9b551b1760682123ebb 18-Jun-2013 Andy Huang <ath@google.com> Fix list caret and highlight sticking when scrolled down

Manually clearing list item activated state wasn't working because the
item position was mixed up with list view child offset (not the same
when you have a non-zero scroll offset).

Turns out that ListView can manage this for us more reliably if we clear
the single choice using setItemChecked() instead. Hooray.

While I was in there, I disabled list caret entirely on portrait tablet
so it doesn't appear during the animation, either. Much nicer.

Bug: 9074494
Change-Id: I1f976797a81d3a5f49dadd3b5e93bdd103c250fb
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
f82d6e7342e277f123a04fc82cc841b180655c15 13-Jun-2013 Andy Huang <ath@google.com> more systrace logging

and some small memory wins to make less garbage.

Change-Id: I09a3515ab1ab62f5282e49f161450aa93c3cbd4e
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
f69d0394f7de5c0681b8d5d5ca0c60b55c55f815 07-Jun-2013 Vikram Aggarwal <viki@google.com> Fix the folder click problem

The SwipeHandler should never act on NestedFolderView elements since
these should not be allowed to swipe. Fixes the issue where the
folders were not clickable.

Also, remove a lot of unused code in the SwipeHelper.

Change-Id: I4495a4224e28d52560ead47ee9e3f6d34c4ab916
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
07fe8df87bde8732398434e55cce366a8528c181 30-May-2013 Andy Huang <ath@google.com> try not to grab the conversation cursor mutex on the main thread

Bug: 9186894
Change-Id: I27ad96a0cdeea354bd3fc915a6072bbf79518fd0
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
dfa99af9e631d5e2f9ca91b5a03026fca1c5c193 20-May-2013 Andrew Sapperstein <asapperstein@google.com> Show non-ascii sender names properly in msg list.

Fixes b/8498763. In conversation view, we properly
decoded names. We were not running through that code
path in email in the UI layer. Refactored the decoding
work into a static method that is now called when we
get the sender text.

Change-Id: Ie8212dd20b74558626e66d2c58a39e95e39b068a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
bcab7611959549a955be8a30115d6a4c937afd24 17-May-2013 Andy Huang <ath@google.com> fix chopped senders string

The static (sigh) paint used to measure/ellipsize the senders text was
stuck in 'date' mode, which used the tiny date font to measure.

Bug: 8715214
Bug: 8972566
Change-Id: I96480b284feae6a5d69a3dd4702365c5d1da355a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
ab25d84d0f3c73b5e8c7c80e5257b2db6e7b3e25 15-May-2013 Andrew Sapperstein <asapperstein@google.com> Disable drag&drop for non-expansive tablets.

Fixes b/8983246.

Change-Id: Ic1d16835480c3d0206d491de1ddccb939c36a568
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
745bff38627bba3f0786eb1ce3a6d1a03cdb917c 15-May-2013 Mark Wei <markwei@google.com> Cap the number of labels in conversation list.

Each label must not be less than 48dp. This allows us to see 2-3 characters per
label. Phone portrait will show around 5 labels on a Nexus 4.

Bug: 8970027
Change-Id: I769f468e5e546f583f3aa0c949b62c2546b3261f
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
bbb186583f4beeec8e5eea537c73f991003be2a6 08-May-2013 Andy Huang <ath@google.com> use darker blue for 'pressed' state

But first, I had to prevent using a custom 'mSelected' state from
bypassing the usual selector. Now, the 'selected' state corresponds with
whether an item is in the selection set.

Bug: 8853914
Change-Id: I3b564c92d5e3697a10b70fe1af5e5ed9f56c3e15
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
ce2c0a15773909bfd09935673c4974b5922eba68 08-May-2013 Alice Yang <alice@google.com> Add 8dp touch slop for sender image.

Increase touch target for selecting sender image to make them easier to select.

Bug 8850526

Change-Id: I2e7114017a916b0f1014443924bf8c7c5c76bb66
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
ca9d57ed8dfc24cbab1cb1d6eb5f4780871b550f 07-May-2013 Paul Westbrook <pwestbro@google.com> Fix sender images for Email

Fixed the case where when the deprecated SENDER_INFO field
is used, we weren't pulling the email address out correctly

Bug: 8850702
Bug: 8737081
Change-Id: Idd0aec2260a1fd5845f49f0ac575814324311cec
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
2102b2c87a6cb39bc63fb7eff13dda64da56b72e 03-May-2013 Mark Wei <markwei@google.com> Add teaser for new conversation photo checkboxes.

The teaser shows up for the first time the user sees the conversation photos. If
they change to no photos, and later change back, the teaser comes back.

The teaser sits immediately in front of the first real conversation item (unless
other special views also try to have the same position behavior, in which case
the current implementation gives undefined behavior dependent upon which special
view is added to the adapter first).

Bug: 8772762
Change-Id: Ica79482f2a2eae0cf3409f6accb7ae5b0fc0fd45
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
b0be3fcbc7b9f99cc6fc0a01e517b0f83e67c1f0 03-May-2013 Andy Huang <ath@google.com> tablet visual tweaks. more caret.

bump the star up a bit on 'normal' and 'spacious' layouts.
add back the caret for tablets.
because the caret is drawn as part of a list item, move the edge effect
line into the list item as well so it draws underneath the caret.
get the divider between selected list items appearing again by using a
9-patch instead of a solid color.

Fix an issue on portrait tablet where the last opened conversation would
stay blue in the list. The activated state wasn't being cleared on view
mode change.

Change-Id: I616f5d2b9eb9506995a74a4772ab7f50f95b2a33
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
13c0535f000d0e0ce8d31066a4197a2c2a90b1e5 02-May-2013 Vikram Aggarwal <viki@google.com> Integrate the new star assets

Out with the old
In with the new

Bug: 8621556 integrate new Star assets for conversation list
Change-Id: Ie685317619b6f47b21d90fa2574666a1637f6db0
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
586f2e72bf9891974dc2bfedff61cfc58507af67 01-May-2013 Andy Huang <ath@google.com> harmonize all blues, remove impostor assets

Purge assets that are various shades of blue in favor of using colors.
Per visD, remove conversation list shadow on 2-pane. This saves the
hassle of baking in shadows into all background assets.
Remove wide-mode background assets in favor of phone versions.
New darker refresh bar assets. No more need for a white frame.
Add shadow to drawer-less folders list.

TODO: delete wide selectors and assets.
TODO: implement caret on tablet.
Change-Id: Iecec3eaaa3c37b856cbed64d2b53ddf77a00582f
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
d94312288286017a38603cb10becd2ad52580524 01-May-2013 Paul Westbrook <pwestbro@google.com> Revert "Add analytics support"

This reverts commit cebb805a486d38bca50009905777e170b375b066.

Bug: 8764535
Change-Id: I70092a456bcfeda2e60f93e747e5e9097df0b77e
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
cf2a69115565e493b9ecb885cf9e8da84b8a48ec 30-Apr-2013 Andy Huang <ath@google.com> Merge "use the drawer on small tablets. general tablet layout love." into jb-ub-mail-ur9
12b3ee458e04ac7e0b69302e671d10b24a5c98cf 25-Apr-2013 Andy Huang <ath@google.com> use the drawer on small tablets. general tablet layout love.

Added 'spacious' variant of NORMAL list item layout.
Because the determination of whether to use tight or spacious dimensions
isn't easy with resource qualifiers (think of 7" tablet, which uses
tight dimensions for 2-pane side-by-side layout, but spacious dimensions
in portrait), I just made a whole new layout for this permutation.
Please remember to maintain NORMAL, WIDE, and now NORMAL/spacious
variants!

Use WIDE mode + drawer on landscape 7" tablet.

Make 2-pane controller and layout drawer-aware. Pull up drawer code into
the common controller base class. 10" 2-pane continues to not use a
drawer.

Don't use a resource qualifier to decide between normal and wide item
layouts (same reason as spacious dimensions above). Use the actual item
width as a dimensional test (list_min_width_is_wide).

Use default drawer scrim color.

TODO:
the conversation-open animation is janky looking.
can't open the drawer in conv mode/7" landscape

Bug: 8578806
Change-Id: I1210b1d47d1756353f7c386873465751ca21f801
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
08720495e48fbe84f72efe0d914396c904fd7afe 30-Apr-2013 Alice Yang <alice@google.com> Remove touch slop for contact images

Bug 8743785

Change-Id: Iaf77d1c5357e9440e48e5f20e0fdad39e4f08cb7
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
7beb5ac59b1399c82984f25b0971e7cb8948ab5e 29-Apr-2013 Paul Westbrook <pwestbro@google.com> Added additional analytics

Change-Id: I2b953a0d4ad1682a8ebd4012682ea01d3dbc41ab
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
5952761d1916f8568a47a55c6f6a74b90aad2b83 27-Apr-2013 Mark Wei <markwei@google.com> am 6126d72a: Fix multi-selection on tablets. We invalidated our previous assumption that tablets will always have a checkbox. This fixes new issues with tablet CAB mode.

* commit '6126d72ae2769bd39451872f45781cadb5b90515':
Fix multi-selection on tablets. We invalidated our previous assumption that tablets will always have a checkbox. This fixes new issues with tablet CAB mode.
6126d72ae2769bd39451872f45781cadb5b90515 25-Apr-2013 Mark Wei <markwei@google.com> Fix multi-selection on tablets.
We invalidated our previous assumption that tablets will always have a checkbox.
This fixes new issues with tablet CAB mode.

Bug: 8698135
Change-Id: If76f0f3d07f1b515afc5d05f57f0d8cc068b3fe9
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
fd26b56dbe6bdb6ece9ec344673d01a9a891995f 26-Apr-2013 Paul Westbrook <pwestbro@google.com> Merge "Add analytics support" into jb-ub-mail-ur9
cebb805a486d38bca50009905777e170b375b066 26-Apr-2013 Paul Westbrook <pwestbro@google.com> Add analytics support

This adds support for analytics, and tracks how popluated the letter
tiles are.

Change-Id: I59e699cf455f1b80d585bf809786912a67d9aed6
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
24e4599c09eac54b11da756b9ed979b69a0d8578 26-Apr-2013 Alice Yang <alice@google.com> Show sender images in Email

Change-Id: I818ab323ac50bad11ac32b6155046b11d383cdce
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
0c436a1a4d59c8f228b16fc946f5ca2b72fa949d 26-Apr-2013 Alice Yang <alice@google.com> am 8d77f09a: Merge "Make sender image behave like checkboxes" into jb-mr2-dev

* commit '8d77f09a37cfbe24eff2f1276b3a8ca0e7fcff45':
Make sender image behave like checkboxes
4758e980c21027ef1a9cacc9847170290b2ae42e 25-Apr-2013 Alice Yang <alice@google.com> Make sender image behave like checkboxes

- Tapping on sender image selects/deselects a conversation.
- Removed the "checkbox" option from settings, but didn't change wording
yet since settings text hasn't been finalized.

Bug 8713329

Change-Id: I11afe2b2ca3191f63ae5b82228fa209fdbd9295c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
cd67ec6cb202bd3d02218e3b7f80aefeb0c34233 23-Apr-2013 Vikram Aggarwal <viki@google.com> Merge "Clean up selected set" into jb-ub-mail-ur9
b53fe05fb867685d0d3f2f37daf0f93bc6488ded 21-Apr-2013 Andy Huang <ath@google.com> misc contact photo optimizations

* Only invalidate the contact image region on async load.
* Calculate hash codes by hand to save autoboxing of ints.
* Don't parse Folder color strings at draw time.
* Switch ConcurrentHashMap to SynchronizedMap. No need for concurrent
write support, as we only have one writer thread. Write perf is much
better.

No-op stale photo requests more correctly now. Previously, a canvas that
was re-used and happened to have the same person in it would apply the
photo even if the dimensions didn't match. Now, PhotoManager makes a
record of the canvas's "generation" at request time, so the results can
later be rejected entirely if the canvas generation differs.

Bug: 8051779
Change-Id: I31c3fd0c3bcc10641f264b6e30eb133cc0bf77b3
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
cb1126a3a93696e3a3788255ad82ed72179810e6 20-Apr-2013 Andy Huang <ath@google.com> DO NOT MERGE personal indicators are dead. long live personal indicators.

cherry-pick of: https://googleplex-
android-review.googlesource.com/299929

Bug: 8635214
Change-Id: If05b2b144ad25d1d4da9692003863f07d81c52b7
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
007de15a91f85c94ea625e31e2a105d7c51e363d 15-Apr-2013 Andy Huang <ath@google.com> DO NOT MERGE clean up old layouts

cherry-pick of https://googleplex-android-review.googlesource.com/297316

Bug: 8393227
Change-Id: Ida8efbc4634f3897e4974409fce7f81d8c2bda82
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
4a85e39fbc318359e8a3cacb874df2372fe9d566 20-Apr-2013 Andy Huang <ath@google.com> personal indicators are dead. long live personal indicators.

Bug: 8635214
Change-Id: If05b2b144ad25d1d4da9692003863f07d81c52b7
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
20a97ded277fdcd3c63952a23718410c2882103f 17-Apr-2013 Vikram Aggarwal <viki@google.com> Clean up selected set

Toggling values in the selected set needed ConversationItemViews which
were passed as null under controlled circumstances. It is much
cleaner to pass Conversation objects, as all the relevant information
is contained there.

Removing the view from the toggle() call. No change in functionality.

Change-Id: I88f5a91c721ff673ae5b6efd251ebd034a8d5ffa
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
b4a222726f3f1c78b7146fa5f7d4d45974bcef47 15-Apr-2013 Andy Huang <ath@google.com> clean up old layouts

Bug: 8393227
Change-Id: Ida8efbc4634f3897e4974409fce7f81d8c2bda82
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
f7838b41daabb5c732e09ec949306ec895ac8e5e 12-Apr-2013 Andy Huang <ath@google.com> always FILL folder blocks

Bug: 8598158
Change-Id: I6445085a7b1bf385d72c3b5db8788d0881b1d66b
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
370f868c834861e7732faaa9bdd07a0fa0105596 09-Apr-2013 Andy Huang <ath@google.com> fix shorter-than-expected leave-behind view heights

Make leave-behind heights variable, dependent on the
ConversationItemView that originated it.
Make the background on a SwipeableCIV not a separate view, but a simple
background. Also simplify the conditions under which it occurs-- it just
appears whenever translateX is non-zero. This covers all swiping and
animating cases handily, without the need for extra listeners.

Remove an old workaround that gave ListView on 1-pane an opaque background-

- it was there to mask FolderListFragments that stuck around, but those
are relegated to the drawer now. This reduces list overdraw by one.

Bug: 8570880
Change-Id: I2e2ea875d4ab58b5048d41025b8a2c48a3d63536
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
0e3882b187ab8debc71fa571e8596fc3debb6123 11-Apr-2013 Alice Yang <alice@google.com> Merge "Checkbox vs. sender image setting" into jb-mr2-dev
642731419abb9037a729114d32d6ddd15af0a406 11-Apr-2013 Alice Yang <alice@google.com> Checkbox vs. sender image setting

Replace the current "Hide checkbox" setting with a tri-state setting with
choice of:
- Show checkboxes
- Show sender image
- Show neither

Bug: 8512959

Change-Id: I87f9cd373283fd600bdd23a7307d37c660f0805a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
fbc519e976de0c0debd810ed8c7f77de44d136a1 06-Apr-2013 Andy Huang <ath@google.com> spring cleaning; implement new conv list redlines

Unify all Email and Gmail list item layouts.
App-specific features are now enabled/disabled in code rather than
through XML includes and overrides. I find this easier to understand and
maintain.
Folders now bottom-aligned.
Item heights are now dynamic and variable.
There is now room to display 5+ folders - removed max of 4.
Copy more dimensions and styles from Coordinates so layout control is
more centralized and normalized.
Make Coordinates values final.
Bundle the now-numerous configuration flags into Coordinates.Config.
Remove most fixed vertical margins in favor of values from font metrics.
Static caches considered harmful - moved coordinates cache to hang off
of adapter, which fixes configuration changes not taking effect (e.g.
font size, language).
Removed overspecified styles (font sizes).

Will remove old layouts and styles in a followup set of cross-project
CLs.

TODO: fix hard-coded leave-behind height - too short.

Bug: 8393227
Change-Id: I85239cbd97c485d7f73103a80d5ab92069b550d9
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
d198fa7ddb2d0c730847af34f06aa2e940b2537d 01-Apr-2013 Mark Wei <markwei@google.com> Attachments in Conversation List: UI changes to display attachment previews
in the conversation list.

Depends on:
PhotoManager: https://googleplex-android-review.googlesource.com/#/c/285814/
Backend: https://googleplex-android-review.googlesource.com/#/c/289305/

Bug: 7481049
Change-Id: I284ec722bb0ed0ddb8b27804c0ee5591ef672032
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
47cb510ea11c8886434575118068fc91eaa25fac 19-Mar-2013 Mark Wei <markwei@google.com> Refactor ContactPhotoManager so we can reuse its preloading and caching
mechanisms for other tasks.

I've elevated all the generic preloading and caching code to an abstract
PhotoManager class. ContactPhotoManager now extends this class, and contains all
the contacts specific code. I will be creating a new AttachmentPhotoManager
subclass later, so that I can take advantage of PhotoManager.

Other refactored classes are DividedImageCanvas and PhotoLoaderThread.

Bug: 7481049
Change-Id: I2535ab33af9c1cd074ca1ee29153499383ed5389
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
7d9143a225ef095db2ee6aa2e2d8aee237af4a8f 01-Apr-2013 Alice Yang <alice@google.com> Fix view recycling with empty draft message

Bug 8363993

Change-Id: I916a28331c279815bf0e09e9377c2ae0c73c56f5
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
40ada66d5dc6a0d5ad02f4a319acc03d126e9fc9 22-Mar-2013 Scott Kennedy <skennedy@google.com> Remove a bunch of unused methods

Change-Id: I9c7fa70d42335694fc6ae9d9acc3955a922c96d7
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
9e2d407fdafeb874e640eb84017feaf784309075 22-Mar-2013 Scott Kennedy <skennedy@google.com> Clean up a bunch of warnings

Change-Id: I5c75564eeb2df9ec76d682dbe5f4465ff2a1a5d4
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
67aa9e5162a15fb8b46b4113ac627cd20668f095 20-Mar-2013 Scott Kennedy <skennedy@google.com> Exclude all inbox labels when we're viewing an inbox

Bug: 8426563
Change-Id: Ib9256fcdb658cb3df9b67485f7768f75bb8b6539
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
bcdc0f995c05ec1842a74e853a87ae5048799d0c 19-Mar-2013 Alice Yang <alice@google.com> Fix NPE

Bug 8409875

Change-Id: I296dd20feadd0b8ac38dee9228f5ccdc8ef76f6c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
b39aaf53a555c1046ef31b3fecf15d086acca013 07-Mar-2013 Scott Kennedy <skennedy@google.com> Make widgets work again

We can't send Folder parcelables to RemoteViews, so let's just send
what we need: two URIs and a String.

Bug: 8330949
Change-Id: I67bf7668d5eeef3f3b2e6225cf8697a4c5533f16
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
24ac64dab8f7ca93cde7053dc87c752c9d5b2f61 27-Feb-2013 Andy Huang <ath@google.com> am ce59fca1: optimize scroll perf

* commit 'ce59fca1cfad3489bc121e9b58a9c67e765ca35a':
optimize scroll perf
ce59fca1cfad3489bc121e9b58a9c67e765ca35a 26-Feb-2013 Andy Huang <ath@google.com> optimize scroll perf

Switch date stamp back to a simple drawText(), as we had
switched to use a TextView to use font face spans, but this was
much slower. Since we are no longer using a custom font for
date, this is safe.

Tweak call ordering of measure/layout/setText of subject and
senders to be more like it was in UR7. Calling setText last
defers text layout until draw time, which is normally bad, but
when our list is already so far behind, it turns out there are
fewer draw calls than layout passes, and this saves some time.

Switch EllipsizedMultilineTextView from using its internal
layout to using a StaticLayout to determine the chop point. I
found this slightly faster for my data. I think this was because
most of my subject+snippets require StaticLayout vs.
BoringLayout, and even checking isn't worth it.

Bug: 8236797
Change-Id: I8684ed7cd58d9dbbaff1df4721a823a59635171c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
efd4dded87a7f9b00fdb238582938096eb2506df 21-Feb-2013 Andy Huang <ath@google.com> am 5d6773c7: Fix second-line edge cases in conversation snippets

* commit '5d6773c773401a259e6b6db957c34f36c508816b':
Fix second-line edge cases in conversation snippets
5d6773c773401a259e6b6db957c34f36c508816b 21-Feb-2013 Andy Huang <ath@google.com> Fix second-line edge cases in conversation snippets

Ensure that style spans are added before ellipsizing. Adding
bold spans after ellipsizing means the original ellipsizing
no longer applies.

Switching to adding spans before ellipsizing exposed another
problem where re-assembling the ellipsized pieces would
break up spans that cross the split point. I found it easiest
to fix this by assembling just the text and adding spans back
in after assembly. This ought to be RTL-safe, but needs further
testing.

Bug: 8233608
Change-Id: I7cddd700055b019c50eadc129cc86f3d705dee63
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
337d2c1a79dee478afe7c204ef6c71bda534313f 30-Jan-2013 Vikram Aggarwal <viki@google.com> am b9d1d7c8: Merge "Improve choice mode in Conversation List" into jb-ub-mail-ur8

# Via Android (Google) Code Review (1) and Vikram Aggarwal (1)
* commit 'b9d1d7c87431829f152254f577adecb7c10fc73a':
Improve choice mode in Conversation List
b9d1d7c87431829f152254f577adecb7c10fc73a 30-Jan-2013 Vikram Aggarwal <viki@google.com> Merge "Improve choice mode in Conversation List" into jb-ub-mail-ur8
96031241ccccaf4ec7194ca96358c434d2a6c3d0 30-Jan-2013 Scott Kennedy <skennedy@google.com> am 281b299e: Merge "Conversation list item second line span was being removed" into jb-ub-mail-ur8

# Via Android (Google) Code Review (1) and Scott Kennedy (1)
* commit '281b299e0d0c211e3f0d6b83b5d1e0ae3c2acb2d':
Conversation list item second line span was being removed
0509bba9a80de474a24368e1f3baebd3cd32cd5e 30-Jan-2013 Vikram Aggarwal <viki@google.com> Improve choice mode in Conversation List

1. Set CHOICE_MODE_NONE by default on phone. We never show activated
state on phone, so this avoids a lot of existing list view choice mode
changes.

2. Set CHOICE_MODE_SINGLE only on tablet, and set it to NONE when in
list view.

3. In SEARCH_CONVERSATION viewmode, set the background drawable, just
like in CONVERSATION mode. This is the reason why the selection
sometimes continues in the search results mode, because it is not
redrawn. Changing the drawable on view mode changes forces a
refresh, which removes the selection highlights.

Bug: 8029180 Selection highlight often remains after viewing a
conversation from search results

Change-Id: I545fe1d4e330d0b3e102ff4f898a169b13733299
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
c244f29b6f9af500fedf8aad48db4c80df52c5c1 30-Jan-2013 Scott Kennedy <skennedy@google.com> Conversation list item second line span was being removed

SpannableStringBuilder removes spans if it already includes the same
span, even if the start/end are different.

Now, we won't apply the spans until we have the final
SpannableStringBuilder.

Bug: 8091758
Change-Id: I58a4d7cf55679570ac0d4df6585fa78c998ade32
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
67a8b48c3aaad10c2dc6556964c55cddf7012508 29-Jan-2013 Vikram Aggarwal <viki@google.com> am bcb16b98: Check tablet mode through resources

# Via Vikram Aggarwal
* commit 'bcb16b98140a83a4db3c51568d21c839595f73df':
Check tablet mode through resources
bcb16b98140a83a4db3c51568d21c839595f73df 29-Jan-2013 Vikram Aggarwal <viki@google.com> Check tablet mode through resources

Change-Id: I790fef6ef7ce3ca97ebba1fa220f44123c2d2e9d
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
d5fd04656f364a209703a67debc33d91dabfb83f 26-Jan-2013 Scott Kennedy <skennedy@google.com> Prevent the leaking of an IntentReceiver

Only cache resources (and setup the related IntentReceiver) upon
request, so we don't leak it if the first call to the method is from
a Service.

Bug: 8029270
Change-Id: I5a4d8825cbbc53c2b8c6cd68a4fe5cd3e5215d0c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
7127c273d1995077f9c55c8abe00af3e05baad38 15-Jan-2013 mindyp <mindyp@google.com> Hide conv list photos behind an experimental pref

Change-Id: I5c12c9794fe19c12595821425ecc6c2fb4ea534f
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
c046e4a310462aa6998a34ff50439eb5e2508d85 19-Jan-2013 mindyp <mindyp@google.com> Fix all issues related to subject text getting cut off early/ too long

Fixes b/8029665 conversation list subject/snippet sometimes too short (seems like it should be ellipsized), sometimes too long

Can't use the original plan of just concatenating the width because of
LINE BREAKS, so instead, created a special kind of textview that overrides
the usual ellipsizing behavior by allowing just the last line to be
ellipsized.

Change-Id: Ia9a3d3bf9910b7ead6cdb28275c18cfa1c04c28f
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
6fbad637da287ba8e864e5b8b4548f3e261c564a 17-Jan-2013 mindyp <mindyp@google.com> Get the associated division ids from the dividedimagecanvas; don't depend on the header

Fixes a random crash when scrolling the list

Change-Id: Ie0a923af533b2f2b6f9f9c0003006922f4114cf4
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
f832d5f8b490e184d0c9cd70bba8f32ed29ff51a 16-Jan-2013 mindyp <mindyp@google.com> Use position, item, email to make a unique request id.

Change-Id: Ie0fdf2f00905ae4ce66997064c24b60e0556ae97
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
f6e1fefe28735e7bfa04c00f813b82162e114706 16-Jan-2013 mindyp <mindyp@google.com> My change to this file was lost; we don't care about folders width for senders

Change-Id: Iffcec301e31e226d9ce11450829ba1674528b421
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
646d4fc7ba80f71feb6701b8e5ba4b24c3462f7c 16-Jan-2013 mindyp <mindyp@google.com> Make sure we don't override existing requests for the DivisionCanvasView.

Since each view could hold up to 4, this had been replacing earlier requests
with later requests for images that were intended for other positions
in the DivisionCanvasView.

Change-Id: Ica8e9d101cea0041281a155ca7ec979807559aa5
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
167bddc283a66f210e0484eeca609f4e7f35dac4 15-Jan-2013 mindyp <mindyp@google.com> Fixup the width of the subject when folders are present.

Measure at runtime based on whether folders are showing, the font size,
the font weight, and the the max width of folders being drawn inline.
This does not affect wide mode.

Change-Id: Ia0293fd5036ba93f5bfc03e1693b5f4acbf33103
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
fffbcdcd3eed1d05a39338be1c5c34019fec9a03 10-Jan-2013 mindyp <mindyp@google.com> Reset the photo BEFORE we request a layout

Avoids race between whiting out background and adding photo
Change-Id: I44ddeb5720a25c877adcc2631f5224f7863ba676
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
6a4c4f62db0ddf6660d889bf1f21e37d25a99363 09-Jan-2013 mindyp <mindyp@google.com> 10" tablet style; use old fonts and read/unread colors

Change-Id: Id82c30abaffe6fdf05579f98985d28529d74f394
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
69495b0a5551aaf4b70b6b29348946b730cfc3e8 08-Jan-2013 mindyp <mindyp@google.com> Reduce time it takes to render a conversation item

Re-use an existing folderdisplayer instead of recreating one each time
Remove unnecessary TextPaint call
Don't do html to plain text on the ui thread; its done when processing senders
Change-Id: Id1b4fa93b2b082fd9f69e473d6d3ee55bd852684
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
f0798f37b4954463eb24c1f7e54b3b5e7f570351 08-Jan-2013 mindyp <mindyp@google.com> Fix position of the senders view when showing contact photos instead of checkboxes.

The priority indicator is not inlined with the subject when in 10" landscape
Move senders view down for normal mode on tablets
Change-Id: Iabe6251e7c168fe2e31af5a45f4faf16388bddf9
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
c76ab94c69e09ade8036f47d370d56902f0e1f6e 03-Jan-2013 mindyp <mindyp@google.com> fixup algorithm for which sender photos we need to show pictures for

Algorithm:
1) show pic for first sender
2) show pic for last 3 senders, ellided or not

Also, messages from "me" should show my contact icon

Make sure we just use characters for the tiles:
fixes b/7959815 Problems with sender "letter"
Change-Id: I1b713df0cd12b3ca324fa4f6492ed337f867a434
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
6d11c8fbca5d54a013d78c85d6eb28f590093e3c 03-Jan-2013 mindyp <mindyp@google.com> Sender emails are now available. Use the senders email to lookup their contact photo.

Creates the DividedImageCanvas, a light weight way of collecting and rendering
sender images to a canvas than a standard android view.
Also, allows us to get bitmap processing off the main thread in a future perf related cl
TODO: perf pass;
implement correct visual design for letter tiles once available
Change-Id: I67b8f74f40703543609d1011098062c98e3e42cc
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
f2caf91209e4e2d4182d6b379a3cd79eed81af71 02-Jan-2013 mindyp <mindyp@google.com> Set font sizes, colors, and types for subject/senders/ snippet. Set max length for subject.

Also, a fix for:
b/7937635 Senders text displayed as "e": need to figure out why the single sender was being
marked as elided at all so leaving the issue open
Considering an option in which I divide the subject into 2 textviews and ellipsize based on
length...

Part of matching redlines.

Change-Id: I109001fb1d52c032d489bf7d3a0a6e925a9d7f1a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
006a84fe8ec32c1269c03856d7e4a471309c89a8 02-Jan-2013 mindyp <mindyp@google.com> Move the folders boxes inline with the second line of text on phones

Centers folder name as well
Next steps will be to give a character limit to the subject when
there are folders to render

Change-Id: I53ca2e71da62cc8ab7fe6c76714261a44e7feb88
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
95f9e1b167f4945adfa4ca62f4b72a102b621794 26-Dec-2012 mindyp <mindyp@google.com> Match redlines for new ur8 layout.

Change-Id: I0e23a356e366c953f1bb36a43f246ad8622a1d9a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
88acafa03a87f5c84b959697d13b81df8f11a96e 21-Dec-2012 mindyp <mindyp@google.com> Make it possible to get the emails of senders we want to display photos for.

Change-Id: I32bdf23f1fdb8b94d2f0abc4d4bb05d2e2d04648
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
418336e902eb91bd69371dbb3aebc0396a658d0f 15-Dec-2012 Mindy Pereira <mindyp@google.com> Revert "First round of visual refresh changes."

This reverts commit 0886b2910872b17f6cb6716ee4e92fba3c69d873

Change-Id: Ie8a78b30449f311925504bfa5bca584a0a7451ff
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
0886b2910872b17f6cb6716ee4e92fba3c69d873 12-Dec-2012 mindyp <mindyp@google.com> First round of visual refresh changes.

Limited to:
font face, size, and color changes
padding changes
bsckground color changes

Change-Id: I23288e20a380d74086041c3eafc098554c3377d3
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
0c02f7c0928487eb5dd58234d10817fffff9be18 27-Nov-2012 mindyp <mindyp@google.com> Fix the width of the date background

Uses static rects to avoid creating objects in onDraw

Fixes b/7340537 Background of small label/attachment indicator doesn’t extend all the way to the right edge of the screen

Change-Id: I6755d4acf9ecda24a41d29c07db668e1563c9c5b
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
8335d37d0e6b6e06ba4666223945c2a3f24103c1 12-Nov-2012 mindyp <mindyp@google.com> Remove slower ops from onDraw

Per fwk team:
most to least called: onDraw (get slow stuff out of here!)
onLayout
init

Change-Id: I79bcbb4ebfe562adcd31b536b10187585366bf78

Conflicts:

src/com/android/mail/browse/ConversationItemView.java
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
b1829d68f6e41d363f45aaaa913b1cf83c5b8e5c 13-Nov-2012 mindyp <mindyp@google.com> Make sure we don't do anything with empty subject text.

I think this fixes:
b/7489856 NullPointerException when trying to pull up draft email

Change-Id: Ie165715e215341bab010a675f573d9bf65a99d6a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
2615aea2ce57f5fa3a9cd2e672282818aee6ce94 07-Nov-2012 mindyp <mindyp@google.com> Cleanup in conversation item view

1) use a single span here to avoid creating extra spans when we don't need them
removes the need for a few variables and is generally cleaner
2) use the same caching logic for folders as we do on the gmail side for labels:
once we have the id, we can easily lookup the folder and don't have to parse the rest
of the string/ create a new folder object

Change-Id: I3cc650583ed851d2c37521ddf21f3c5af7d69bf6
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
98aeca3818c3b696f304c1bfb5657a1e1f277a04 30-Oct-2012 Paul Westbrook <pwestbro@google.com> Prevent NPE

We need to handle the case where folder is null

(we were already handling the case when mDisplayedFolder == null)

Bug: 7436193
Change-Id: I6a3e5bf813cc1f095e2eba64f246430d7dac7b87
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
5d07da885ae9d4fdd373995f9c67e2d8f6ebaab9 19-Oct-2012 Vikram Aggarwal <viki@google.com> Activated text span should be static.

The SpannableStringBuilder accepts any Object as a span; the only way
to compare objects is through pointer comparison. If the activated
text span is an instance variable, we create a new instance of it for
each ConvItemView when the activity is recreated through the normal
activity life-cycle.

Making the activated text span static avoids these problems, and
guarantees that we only create a single one per process instance.

Bug: 7316164 Shows half white color sender name in Gmail conversation

Change-Id: I4c650ecd6a396547bbd13ec4a9253433ebd493a8
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
0a135884c7452225bc0c86c5f768d581c0ce6c04 17-Oct-2012 Mark Wei <markwei@google.com> Hide Stars in Trash.

Bug: 6516160
Change-Id: I9f4fd099971c696379532f6b9654582fdeb8556a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
2598be2e9681c24fb5746f7c5efc963378dccf0a 10-Oct-2012 mindyp <mindyp@google.com> reduce allocations: reuse a textview instead of creating a new static layout each time.

Also, picks the font color at draw time which should fix activated text issues
Change-Id: Id6928616f688bf557c569d0de05df6e707b5c976
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
0d1ed12c6e70f4204ff28092ed51ce540f9f3f67 10-Oct-2012 Vikram Aggarwal <viki@google.com> Recalculate mMode if the viewmode changed

If the view mode changes, but the width stays the same, we don't
recalculate the wide/narrow mode of the conversation item view. Make
the check dependant on mode changes in addition to width changes.

Bug: 7316569 Rotating device from landscape to portrait shows janki in
2 pane window

Change-Id: I88f4732a29663a3025a4bab8efd89438f3beecea
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
ce499a669a8008397e3fd92e3b0c5e44e0ae4ab6 05-Oct-2012 mindyp <mindyp@google.com> HtmlParser not thread safe; let widget supply its own version of the parser/tree builder

Fixes b/7292288 gmail crashes on launch/loading msg

Change-Id: I2a7f3c6c8593ff5f704c9df6baec9125f9c954a6
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
9be3a97325bf7b4d17b1a1bf347bc1d89653e48d 02-Oct-2012 Vikram Aggarwal <viki@google.com> Senders String color and NPE fix

Two fixes:

1. The senders string is not available till ellipsizeStyledSenders()
runs. *After* it is run, we need to recalculate the activated span.
And we always need to call layoutSenderSpan() after every run of
ellipsizeStyledSenders.

2. If the styled senders string is not available or is empty, we need
to return from layoutSenderSpan rather than crashing.

Bug: 7268380 First message tapped in conv list does not make sender
text white

Change-Id: I820b6970094da6d81909006447c8f189091fbccd
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
eaf3080a25306ae009d9002aca4e77767763dc22 01-Oct-2012 mindyp <mindyp@google.com> Make sure we force a measure of the textview.

setWidth doesn't force a meausre
onlayout doesn't force a measure
measure is needed to properly ellipsize/ create ellipsized state

Fixes b/247249 Message count not appearing for some threaded messages in the list view

Change-Id: Idcece78555584d20e209395395e259e91412dba6
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
f8fc1125b9130f42c97d6ce233afc7751dc020d6 01-Oct-2012 mindyp <mindyp@google.com> Fix crash in on draw

We already check for the presence of a folderdisplayer in other cases,
just not this one
fixes b/7263233 Random crashes in Gmail
Change-Id: I33c8082458a898f52caf41020710d45367a43452
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
ca87de41285bde382a894b6cb2d13c112c5d7a2f 29-Sep-2012 mindyp <mindyp@google.com> only get content description when accessibility is enabled.

Getting the date is the most expensive part of the bind operation
takes ConversationItemView.bind from ~5ms to .5ms
bind is called whenever we get a list item view, so its important that its FAST

Part of b/7188066 Gmail inbox list fling is jankier comparing to previous release

Change-Id: If789382df6429f61ac80c4be08611c5391da5618
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
c03b05aa74346d10151cb8624af78e6ef0393cea 28-Sep-2012 mindyp <mindyp@google.com> added interface for toggling

Fixes b/7254474 gmail crash

Change-Id: Ic07d5951d4fbef838ddcd7e2484f094ccfd13ead
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
58c701459d308c0cc87d08f8d62322b142b22f45 28-Sep-2012 Vikram Aggarwal <viki@google.com> Fix white sender font from notification.

When selecting conversations from a single-message notification, the
sender font gets set to white. Later, it gets changed but we do not
change the styled sender string because layoutSenderSpan() is never
called if the layout is not valid.

Bug: 7254616 Conversation Items from notification retain a white
sender font

Change-Id: Ic3ef452ed6de7bc426f347e24933c5536c2297b5
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
43ac9a0d56faa5cf72a771468838b4c413c82d6f 25-Sep-2012 mindyp <mindyp@google.com> In some cases, we dont have styled senders.

Fix b/7228573 Recurring NPE scrolling around in convo list

Change-Id: If34dc73461d6a701accc7a009eaf64c19a19df54
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
6e4c01675df374929d055f3dd4bd99990d9b1612 20-Sep-2012 Yorke Lee <yorkelee@google.com> Fix NPE when archiving mails

Bug: 7170476
Change-Id: Ic835dbd841fef65076063aaefec7c5ada77dc52d
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
692e441b1d41b9a25b9823f59d0591917593e4aa 19-Sep-2012 mindyp <mindyp@google.com> Reduce time it takes to render senders by using 1 textview.

If I just render it in draw, I don't have to worry about caching.

Part of b/7188066 Gmail inbox list fling is jankier comparing to previous release
Cuts time for getSendersView from 4ms to .004ms
The combined total for onLayout/onDraw per convitem pre this change was 14ms
After this change, it is 10ms, with time added to onDraw/removed from onLayout,
but overall 4ms faster
Change-Id: I9f7357c8b7f3443c86e671aecfa3a3c3f5cb357a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
97f573d41eb1ab6e0b3683f081452391cf2a76ae 10-Sep-2012 Vikram Aggarwal <viki@google.com> Senders white only when list visible

Fixes b/7087113 White sender text after losing highlight
and its dupe
b/7137930 Sender's name shown in white for last viewed message

Change-Id: Ia64aef5053881004baed5e1bd1cdc1768342a43d
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
972f263eb00e9d19a294b0a4c512a87a10995ba4 10-Sep-2012 mindyp <mindyp@google.com> Best guess fix since exchange not working right now

Fixes b/7113982 java.lang.IllegalArgumentException in android.text.Layout

Change-Id: Ib495e064662fb677e73234ec842174bfe1d85e5a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
bc9b18ceda6603d9337e2410429ac49cd60c0345 09-Sep-2012 mindyp <mindyp@google.com> Fix possible null subject case on s3

Change-Id: I6f9218b7233b35f1eb30423272f06460429b8b4c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
cc2f9296ad63ed681c200feb118c5caace36e72e 07-Sep-2012 mindyp <mindyp@google.com> Use overridden method for finding item position

SwipeableListview already uses this
Now make sure other children do as well

Fixes b/7129005 Gmail crashed opening a message after deleting few messages

Change-Id: Ia0db43fd3ad1ac0cdf39612e2e91bae9e8a2efc3
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
a4b9f78c174238045ec51a351553b39d876fb67e 06-Sep-2012 mindyp <mindyp@google.com> Whoops. We only handle if it was ever DOWN in the checkmark.

Fixes b/7118922 JOO68 - Can't open emails in Email app inbox view

Change-Id: Idefba14efa89bb37f1b05ef5aba24df4355fd95b
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
dc0617f3478b21dd3324ab10b8c433517ae95460 31-Aug-2012 mindyp <mindyp@google.com> Update accessibility text to make more sense per user feedback.

Reset view heights that may have changed during animations
Might fix the issue where items look odd after swipe to archive
Change-Id: I1231fb98ab4ca855e8bce277e715d78472f9baa8
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
c84759cc974256b6af5545c4bd993b81a0a98f6f 29-Aug-2012 mindyp <mindyp@google.com> Dont remove selection from dragged item; defer destructive folder change

The destructive folder change shouldn't happen until the animations complete
Or it will be automatically committed at the end
But we prevent updates while that is going on
So we won't get a null conversation cursor in the interim

Change-Id: Id4ee6e1da0e8cf50f1d9ed361eb505a670371085
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
54f120f6ada40c7191811dfff99b151e9e192c78 28-Aug-2012 mindyp <mindyp@google.com> Commit leave behind items when tapping account switcher

There is no onclick listener for it
or onshow for the spinner popup window
this is my best guess as to how to tell when it got tapped
when the popup is shown, the dropdown views will be accessed/ built
Dismiss when cab mode is exited.

part of b/6864248 dismiss leave behind on next action taken

Change-Id: Ib706f61a47356412cef73822a4a40453214d22f2
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
d064972c4a032f3c5cfcb236aa470273f7ac2ce0 28-Aug-2012 mindyp <mindyp@google.com> use swipehelper to determine scroll

let swipe helper determine if the user meant to scroll
fixes b/7022556 Increase scroll threshold gets rid of leave behind
If we use the scroll listener, we don't get to use our own threshhold
We want to be careful when the user has started on the leave behind item
and make sure that we dont just detect the user playing around on the item,
maybe just a touch for "what did I do here?" and dismiss it by accident
So the threshhold for dismissing the item when the user starts on the
leavebehinditem is larger than when they start on another item.

Change-Id: I1e55e6c9be07e026b19a4ad55ad531305d3777d2
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
bad1a93d431bc599ed73fa4f42eeef313cd31626 23-Aug-2012 mindyp <mindyp@google.com> When tapping checkbox explicitly, go straight to toggling the checkbox.

Begin drag is only used if the user has performed a long press
Fixes b/7046061 Tap/Select the check box of any message in GmailEmail Inbox does not show the selection for ~ 20-30 secs

Change-Id: Ib8a2d04ff162fe509e8f38d6f61960a8d828efbe
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
ffd39aa99f185385941595c1da7e09c2a4a4c146 23-Aug-2012 mindyp <mindyp@google.com> Get the width from the parent rather than a resource.

This means we don't have to override per mode, orientation, etc.
And we don't have to wait for a layout

Change-Id: Icd914791184b03e79a92d3b321e28d973cf86992
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
5390fcabb7baf683fc14bd68d8612913dac70a81 22-Aug-2012 mindyp <mindyp@google.com> Restore drag/drop logic

fixes b/7034633 Drag functionality is missing on tablets

Change-Id: I8d0c9d4a95cf143a307fb093721f3b5f6eba872c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
850c55ee2cab6b1c224366c66502f5d5f55018eb 22-Aug-2012 mindyp <mindyp@google.com> Implement workaround for issues in staticlayout.

There is some bug that is not keeping text on 1 line
and not ellipsizing (http://b/issue?id=6954231)

Using a textview to explicitly set maxlines == 1
Fixes b/7002058 Conversation list overwriting lines when font size is "Large"
since this bug existed as of late in ICS, and we need to support all the way
back to HC, we need to use a workaround here.

Change-Id: Id3523a115f9e23ec7697fa9cc5f711cb29143942
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
ffd21a08c89f78adc2ee7a07b1afe6163c5f1607 21-Aug-2012 mindyp <mindyp@google.com> Force ellipsizing via the static layout.

No, I don't know why, working with fwk team on that
But I do know it fixes all the cases I currently know about

Fixes b/7002058 Conversation list overwriting lines when font size is "Large"

Change-Id: I84e8a9224c3ff61d7613ce080e7b8f9c206ce9ac
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
5254486a8c37cdf2b579aa7a3b9c8eb7324062bc 20-Aug-2012 mindyp <mindyp@google.com> Dismiss leave behinds when scrolling.

Also, provide a way to get to the list, since its possible this item has no
parent (related to other issues discussing with adam, but its at the framework
level so we need a way to get around it)

Part of b/6864248 dismiss leave behind on next action taken

Change-Id: I2cf483f67ede6e80a935ddd3cf203b3a4b07517f
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
a538984fcc19e7624f2650b119ede39bf1f35846 18-Aug-2012 mindyp <mindyp@google.com> Dismiss just the text from the leave behind instead of the whole item.

Leaves the BG there so the change isn't as "shocking"

Change-Id: I95b6929dadbf9b5e7c80931a3f65111fc4a695ff
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
5c16f82f9916b8d21fd36ac7c460811e59ba6614 15-Aug-2012 Mindy Pereira <mindyp@google.com> Only items that are being destroyed should be blue in color.

Create a mechanism to reset items to original state before starting
any animations.

Change-Id: I530ec7c1fd31fcd04ca215dc789fd6c5fca57da4
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
583eea0562dff158bdd3db9c2adfaec9b7ebef68 15-Aug-2012 Mindy Pereira <mindyp@google.com> Make sure we take priority into account when deciding whether or not to redraw.

Fixes b/6991264 marking important/ not important not immediately reflected in conversation list items

Change-Id: I546f7018f1f8a1055fe08245063e4e6fb5be0e84
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
d1ee8822384cdfa5001572245c72f9996a39a197 14-Aug-2012 Mindy Pereira <mindyp@google.com> Fix background color.

Fixes b/6961067 funkiness when deleting top item in list view
Change-Id: I41df55ddd309131ba80539372162bee824d2204b
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
0d8015eff2b1eba829e70750455d965eba4a8896 15-Aug-2012 Vikram Aggarwal <viki@google.com> Remove unused code

Change-Id: I9c087f2a5dc92b12b6d6831cc6634a61fb60adc6
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
960fea746ff82480cccf6a945bfaeab1689c7138 13-Aug-2012 Mindy Pereira <mindyp@google.com> Fixup touch handling.

This is a MUCH simpler version.

Change-Id: I8bfb264b0669b436394f4455e9c0624a258953f0
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
1e946db1a0e20a92361cf1c86d8b28a1f878fdbc 12-Aug-2012 Mindy Pereira <mindyp@google.com> Improve long press touch feedback

If the user moves their finger, cancel any pending long press checks
This was showing as a bug in which sometimes scrolling would "long press"
and item

Change-Id: I44059cf9d525c61569d2643dc7f24984ccf31797
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
01bb8d91c8ea039518ee07c8ac83e4e42cd81739 11-Aug-2012 Mindy Pereira <mindyp@google.com> Small tweak. Always set the message info ofset.

Change-Id: Ifee53dfb355dbbb9f3dd251ed84a0739915897b9
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
8a6eb44e688ce082597978def2042ea8376b34b2 11-Aug-2012 Mindy Pereira <mindyp@google.com> Make senders text turn to activated color when subject/ snippet does

Change-Id: I8d2c98cdd5f63384093cc3deaf540475592d4897
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
5bcd7e9f994624eea184a60ff50a3d71b5710582 10-Aug-2012 Mindy Pereira <mindyp@google.com> Fix the highlight that was hanging around in the conversation list

Change-Id: I333df599b374ca47e5e876c094983474cc43f8cd
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
34775bdefbccd07f194a7e34c2f89e434c1c1ecb 10-Aug-2012 Andy Huang <ath@google.com> handle empty snippets

avoid crashing due to span errors.

Change-Id: Ia27d3727fa4ac7896065ee5dba0acb9c98f51232
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
bf9508d3877d05742b2f5d23e1780366d3e1aa2e 10-Aug-2012 Mindy Pereira <mindyp@google.com> Dont display null text in the widget.

Takes code from the conversationitemview and shares it

Fixes b/6958924 Blank message in a widget displays text "Null"

Change-Id: Ib9a3b0b1ccabea6498d5710bbf11b7ef78d25988
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
067ef97264240a2c3f9172a9ab88ba43fef7c475 08-Aug-2012 Mindy Pereira <mindyp@google.com> Moved swipe animation into animated adapter; alternate method for finding position

Fixes b/6930375 Crash on Swiping to archive few messages in quick succession
fixes b/6933685 After swipe to archive, tapping on email to open is off by one message
fixes b/6937509 seeing duplicate messages in inbox; when clicked, they open a different message

Some small funkiness in the animations on latest build; the top most item in the list is overlapping the top of the actionbar
I'm not sure this is my fault, but filing b/6961067 funkiness when deleting top item in list view to check into it
Change-Id: Id1e392744c58d806d633ee4d84abfadf9846e4a8
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
e7d783d726236cb090bba1baed1ea44f743ad788 07-Aug-2012 Mindy Pereira <mindyp@google.com> use activated NOT pressed

Fixes b/6881969 Blue highlight appears on search result after opening in 2-pane portrait mode

Fix that states for conversation items were not getting updated.
Also, clear the state of the item
When it two pane, it wsnt getting cleared correctly
This is still highlighting the conversation in list mode, but its taken care of
about 90% of the issues we were seeing (no more duplicate highlights for instance,
correct view mode)

will fix the rest in another CL
Change-Id: I6352c33e58462cf00412cf54086f1ecc08b6a90f
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
feffa26a40e933ad0ff4700e2bf9e0555f0f8470 08-Aug-2012 Mindy Pereira <mindyp@google.com> Since its an arraylist, we need to just replace existing with nulls.

Fixes b/6949402 gmail crashes on launc

Change-Id: I7babea1f55a66940a1a8a3fee53f5a7798f97e9d
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
464275f83c1fa264e097ad222ab47b469d04464b 07-Aug-2012 Mindy Pereira <mindyp@google.com> Fix tap feedback

Fixes b/6939986 Missing/misbehaving pressed state for items in conversation list

Change-Id: I9e8f1c1221b199778f441ae61673cb6dfe32307c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
77d7f3c3c8c82048b51025428a825f6ac71e8560 03-Aug-2012 Mindy Pereira <mindyp@google.com> Make sure we update style spans for senders when there are config changes.

Need to make sure to clear these static styles out and reset them
based on new font sizes so accessiblity can enlarge the text.
Keeping them static means we can reuse them with just a wrapper, which
is a nice time saver.

Change-Id: Ibb5a4082606c5ea5f511017ef981bf7c2be812c7
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
ac9687c359d06ffd26a270906325dacef531ef53 03-Aug-2012 Vikram Aggarwal <viki@google.com> Avoid spurious tap events.

1. Send an item click irrespective of checked state.

2. When a long click event has occurred, we want to disable any short
click for the same motion event. So when a long click occurs,
disable all subsequent short clicks.

Change-Id: Id0374113d6ce3ee42976bc4e10b43242fa1cfdd0
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
b821e306583115e5fce8a8f0383019ae6268b1cc 03-Aug-2012 Mindy Pereira <mindyp@google.com> Add sending state to the end of conversation list items if its set to sending.

fixes b/6916537 messages that are sending don't show "sending" state
Change-Id: I89ada52f0480275582940266a3ce3182fe634d5b
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
9730ea0550dacabcd38f0997c02d668058520042 02-Aug-2012 Vikram Aggarwal <viki@google.com> Perform a longClick from within ConversationItemView.

This will set the stage to fix the short-click and long-click behavior
required for b/6392199

Change-Id: I425e12ea205bbc95baf387330cf83d359e6c7be7
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
84cef5e3457338d22dc3e96dc6feeaf9e50e4d57 01-Aug-2012 Mindy Pereira <mindyp@google.com> We need the styles applied to the text when its ellipsized, including the ellipsis.

Since the textutils.ellipsize method doesn't want to do this without also
padding out with empty spaces, we need to measure it ourselves.

fixes @ath's case for b/6910770 track any incorrect senders formatting bugs
crash while composing message

Change-Id: I0548a90222d394fad897a27ecd9c4823ab359c9f
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
0c2e567e792d557de1d80ef25f82aaf3c41c22b6 01-Aug-2012 Mindy Pereira <mindyp@google.com> Make sure we use the proper spacing between count, senders.

Also make sure we measure draft text with draft text styles!

Fixes part of b/6910770 track any incorrect senders formatting bugs

Change-Id: I632698a7937a8f1fd15a44e14aca4021938f5ce9
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
c1e1fbb0be9fc60a141b8a5a067f4eed035989c1 01-Aug-2012 Mindy Pereira <mindyp@google.com> More fixes for old-style senders.

Correctly differentiate between old and new styles
Make sure to clear sender fragments before remaking them
as we are caching models.
Change-Id: Iba3e5c86760744b912c5aa94131b2f5aa3feed04
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
6870ffca9ac04fee930ad56380eb1d214e5a9481 01-Aug-2012 Mindy Pereira <mindyp@google.com> make sure old style senders have their resources, too.

Change-Id: I9d09340e8780081d99bb8999f823db80d425ac2f
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
33519c002b7e4504dbf964a808cf2f7aff32d16c 01-Aug-2012 Vikram Aggarwal <viki@google.com> Priority Inbox marker support for Conv list

Change-Id: I4cc99ca5df4cdf50c997951d3d84e69d5c5ab1b0
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
fb7bace9a83abf0e8726def19e76cb03afdf5740 01-Aug-2012 Mindy Pereira <mindyp@google.com> This bitmap should be STATIC.

That way, I reuse it AND its size for ALL the views.
Fixes b/6914856 date background does not go all the way to the edge sometimes

Change-Id: I8d54135d3fb4b3ee7e4300f43217daafea157414
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
172f56a81bba3b2589026c7cded795010e7678ad 01-Aug-2012 Mindy Pereira <mindyp@google.com> Cleaner way to apply styles; make sure we know font sizes when measuring

Use TextAppearance spans to style senders, draft, message info
That way we have the sizes, font style, and colors up front

Should help with b/6910770 track any incorrect senders formatting bug

Change-Id: I4a0157e92a619c9394997fb49d5003dd8f4e1056
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
ee0c85d6d0ad72cfdf3edce935a598e2655ae65b 01-Aug-2012 Mindy Pereira <mindyp@google.com> Cleanup of fonts, colors. Fixup draft text/count styles.

Part of b/6910771 "draft" is bolded in some messages

Change-Id: Ib0d6439c73086fed745422f8754d1cf2ccc7901c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
b1cbb89f72631bb7e34822b98e8d0842ebd01b83 31-Jul-2012 Mindy Pereira <mindyp@google.com> Use priorities to decide who to elide.

Not sure its perfect, but its LOTS better
Test cases in a later CL
Fixes the subject showing in sendres in widget

Change-Id: I711ff6d8b1343aa01e5a38193a76467910425a9d
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
1152c02a415f5b93bdecc5733a7372dca7d9ecd3 31-Jul-2012 Mindy Pereira <mindyp@google.com> Make sure we take commas into account when measuring text

Fixes b/6871502 Message count number overlaps with subject

Change-Id: Iac20741db0507c64f8711b89377b74cb120bda61
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
4f2224c70d4d07df85b325fa3faf78218f92aae6 31-Jul-2012 Mindy Pereira <mindyp@google.com> Since star can change via a user action, don't cache the bitmap.

That way, when we draw the star, its always up to date with what the
conversation has.

fixes b/6897152 Changes made in message view (star/unstar, read/unread) aren't reflected in conversation list
Change-Id: Icd841b3c60d37b8a453529423f51304577691bb8
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
85c4a77abd849f5f3f0236d51554bb1bb99fe8f6 30-Jul-2012 Mindy Pereira <mindyp@google.com> Cache displayable folders.

Change-Id: Ibb2766e5a197a86adb0a456dc1fb58cdd98fd610
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
280dbf201cbc555ee59edc4dfe459aebe4ffcead 29-Jul-2012 Mindy Pereira <mindyp@google.com> Email doesn't have a folder displayer, because it has no visible folders.

Change-Id: I1475e6b53b540e094545469f3d2e3a053e10198b
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
bf19cb00a3cc0f65b6b6e5ce8553f53c03a3b717 29-Jul-2012 Mindy Pereira <mindyp@google.com> Dont allocate the src/dest rectangles at draw time.

Allocate a scaled bitmap once and reuse it
Also, applies changes recommended by marc's cl review
And makes sure that we show a date background whenever we show any labels
Use rawlabels to determine when a conversation item has changed as well, since
we update labels to render to a conversation as well as unread state all on the ui
side
Fixes b/6172805 Gmail's CanvasConversationHeaderView allocates at draw time

Change-Id: I1711929c262b7c80bf71dbfbf7e85270cc2a9e7c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
c3efca18f09904f4ce39395169559c5d82bd3d06 28-Jul-2012 Mindy Pereira <mindyp@google.com> We weren't using the cached header models correctly.

This should speed up scrolling since we allocate fewer objects.
Also, fixes the issue where we were not properly creating a new layout
when the read state of a message changed in the case where a user opened
an unread message and then went back. Now, all the senders are properly
bolded/ unbolded.

Removed the deprecated conversationInfo.sendersInfo, which was only being used
by gmail, and had been replaced by using the proper messageinfos
Also, performed some surgery on the widgetviews so that it acutally
uses the messageInfo from conversation info

Change-Id: I43fde9cd23ebc12f2de68e0d18b941304b4a2be7
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
d8e5ff44a8a7405bb8891fb46570782138babbd1 27-Jul-2012 Mindy Pereira <mindyp@google.com> De-dupe senders; show the second occurance of a sender.

Change-Id: I78b558c0084e8d5edd6ba4b1bfd4ce6c3fff9a5a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
24538e893ef2db41a4c1b341f676b64422920304 27-Jul-2012 Mindy Pereira <mindyp@google.com> Get rid of hard coded comma

Fixes b/5354473 Conversation header sender formatting should use resources

Change-Id: Iefd40ce9c4f3e8ec55bc52c8334942be19696655
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
53f262e1c93fc20c9c44d46ebb9fc1b5a44cd06b 27-Jul-2012 Mindy Pereira <mindyp@google.com> Use cached rawfolders.

Change-Id: I4b70c2761a699541b98a02a24f8cd017df13433f
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
bdb43d559dfba09752e95ca88f73ca566dcbb86f 26-Jul-2012 Mindy Pereira <mindyp@google.com> Dont show background for items that are not undoing a swipe gesture.

If undoing and it wasnt from a swipe, then have it grow back in
If it was from a swipe, have it slide back in left to right
Conflicts:

src/com/android/mail/compose/ComposeActivity.java

Change-Id: I6087128620e5db9d5eaa8995300bed8b2ff97911
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
350acdc75af67425aa3f8b6e4f889d4828ce8705 26-Jul-2012 Mindy Pereira <mindyp@google.com> Fix the text in the leavebehind; change undo animation.

We don't care about the count.
Conversations should slide in from the right as a result of undo.
Change-Id: I10d24f758a7260ff5cbb743c2d9c50445a989e6c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
1ef988f0c8be136fda75ed207c222413db1d3f0c 24-Jul-2012 Mindy Pereira <mindyp@google.com> Add a black leave behind peeking out behind a swipeable item.

Change-Id: Ib5e90fee11899710e5ce9ca547003530ee56ca1e
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
54855addd3fae6c497971d77366eac7dc00d7b42 23-Jul-2012 Mindy Pereira <mindyp@google.com> Don't show 1 for 1 message

Only show count if there are > 1 messages for a conv

Change-Id: I12003eaa643342332abaa66ea93cf309e647fba0
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
aa1f945612847bc4cf5c8909b8acfab4b5ecf54e 23-Jul-2012 Mindy Pereira <mindyp@google.com> Add snippet logic when marking read/ unread.

Change-Id: I497344c4361616c8ec293ee89ea99ce9c1a5f2fc
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
6c2663dc9cade8aff34c462d244e3d72c475c664 21-Jul-2012 Mindy Pereira <mindyp@google.com> Update conversation read state on the ui side.

Change-Id: I372464e23c39131b45c20ad8bd72ddd6207a1bb5
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
58ef69ad99623fd8795a95227aa718d3d6177c5a 20-Jul-2012 Mindy Pereira <mindyp@google.com> Render draft text, message count

Change-Id: Ib5acdc80720bc84fa5d9961cc4c4ba2b6ef979ff
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
b1207e3ec8fe3ce988996722e13b80a4dfdf1c72 20-Jul-2012 Mindy Pereira <mindyp@google.com> Use conversation info/ message info to render senders.

Change-Id: Ie1cad4451f5048846fb0d3e730bb9d2855a0c083
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
2f1f62ace49a6596e9f1eee78acfd607bbb4de87 16-Jul-2012 Vikram Aggarwal <viki@google.com> Ignore views that have not yet been measured.

Fix b/6778351

Change-Id: I4dfbaa78759822cb2574807a0eeef58bf432b862
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
a8ead90ce1e6c66e4ecacdf7cfa25c2cafc9bb3b 12-Jul-2012 Mindy Pereira <mindyp@google.com> Update interaction of selected conversations with swipe

According to new specs:
1) only the item swiped on is archived, not any other selected conversations
2) even where there is a selection set, any swipe on any item will dismiss that item

Change-Id: Id94c69a0e5b0ca03b541458b1200a56d6d16c703
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
0b686764015284889d98b8e9f1abea8b27ce26bd 29-Jun-2012 Mindy Pereira <mindyp@google.com> Fix font colors for activated conversation item view items.

By pre-creating and caching the activated and regular subject layouts,
we dont have to create these object at draw time.
Also fixes that the subject/ snippet didn't change to the activated color (white)
when the user tapped them on tablet, but the senders did
Change-Id: Idcb45b84dec5d375b0f38723251eb4d143911c59
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
35a5268f121515a6565bf006300d3a97e13f10f9 28-Jun-2012 Mindy Pereira <mindyp@google.com> FIX BUILD. Dont send a negative width to a static layout.

Its possible the coordinates aren't properly setup yet
since its possible we don't have real sizes (laid out) for the view yet

fixes b/6755337 java.lang.IllegalArgumentException: Layout: -45 < 0
also fixes build
Change-Id: I610a06eab8cb261a274d1c05117c74ea136365a1
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
b466bcf49502a1178cf7362a81470f3231d8892b 15-Jun-2012 Mindy Pereira <mindyp@google.com> Fixup behaviors for action bar when in search mode.

Now that the subject is showing in conv mode, can confirm
this all works as expected.

Change-Id: I707f3f46a2a5bdfa49e61bc1eacb217c5a1ba86c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
d7a4ad903cd77a2cd3ad44c7c456b48c7d47e599 02-Jun-2012 Andy Huang <ath@google.com> rudimentary bidi support in assembled senders string

Let the framework draw the entire assembled (possibly
heterogeneous) senders string. No need to do text layout
ourselves.

This is a manual cherry-pick of I9f4e4303.

Bug: 5058894
Change-Id: Ia28740efc8c3db506c80183f52f1c2280f732782
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
cf9fd53698e8e3db2695b0f87824f4a0042940b4 31-May-2012 Paul Westbrook <pwestbro@google.com> Cherry-pick https://android-git.corp.google.com/g/186698

Change-Id: I02c4eb2fb24ad105b0ebe0006db43b6a1d35bfbb
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
48b2a6c5fe209f0603fdf85d35cf399f7f7d462e 29-May-2012 Vikram Aggarwal <viki@google.com> Minor cleanup

1. Remove uncalled empty methods.
2. Remove methods from interface if nobody else is calling them.
3. Remove unused DragListener interface and all references.

Change-Id: Iac498336209b8e73f9a0e13dd8954652e83fd1fc
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
92939fc7b40a56e17fb0d2fde987133ca1614e29 30-Apr-2012 Marc Blank <mblank@google.com> Support color block for combined views

Change-Id: I3097cb4c37311cbe4b2b8702c26a7edf5eebdd24
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
bf232c3735f65b1a4746943e4a134e59e36f0bde 18-Apr-2012 Paul Westbrook <pwestbro@google.com> Major refactor of ConversationCursor

* ConversationCursors are now associated with a particular loader;
there are no static methods or static state fields
* ConversationCursorLoader maintains a list of current loaders
(for tracking/debugging)
* AbstractActivityController acts as a router of conversation
changes to/from fragments (currently message view -> conversation
list)
* Comment out some ConversationCursor tests for now

Change-Id: I9b8425a19c77501796b6681142e1bc0ad20b3693
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
cf164d64bcb1da92b427bda99b97f7ec310ef704 20-Apr-2012 Marc Blank <mblank@google.com> Revert "Major refactor of ConversationCursor"

This reverts commit 5150f03723af8019169aeed8e406784da9c5f8f1.
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
5150f03723af8019169aeed8e406784da9c5f8f1 18-Apr-2012 Paul Westbrook <pwestbro@google.com> Major refactor of ConversationCursor

* ConversationCursors are now associated with a particular loader;
there are no static methods or static state fields
* ConversationCursorLoader maintains a list of current loaders
(for tracking/debugging)
* AbstractActivityController acts as a router of conversation
changes to/from fragments (currently message view -> conversation
list)

Change-Id: I0eb554615b4bf93b3547ff28e2bd5913e8703a97
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
d9ef52d02fa6a7d2bf76163b6f33c2b1d122a9f1 19-Apr-2012 Mindy Pereira <mindyp@google.com> Check for list before calling click item on it.

Fixes b/6297875 Crash in Gmail > open mail

Change-Id: Ia25a450a1174789855c4e841dd098a24ba00d576
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
304a91eab01d67c8b5ef134b3bfe922fb6ab102f 17-Apr-2012 Marc Blank <mblank@google.com> Allow for null snippet in ConversationListItem

Bug: 6230264
Change-Id: I637432920eee3c34550015942d5d718871d0f338
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
6c72a787b58a0bc3afcb71093eddf8c29d1cf5ed 07-Apr-2012 Mindy Pereira <mindyp@google.com> Show leavebehind after swiping away an item.

Change-Id: I3bae79ed5bb8919985dbfa6e81416da980281cff
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
4f4334983e01c5f72ef0b14d72356a5736c82dec 13-Apr-2012 Mindy Pereira <mindyp@google.com> If there is no subject layout don't draw it.

When the layout is not yet valid because we don't have a correct
size yet or a correct mode, we don't create a subject layout.
fixes b/6316701 Gmail crashed on launch - unable to load emails
Change-Id: Ic85daf152a559c1b5914f944a30ce807f29f5b20
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
b9c036b36542924894f141e3ecd81381a12e94a9 10-Apr-2012 Mindy Pereira <mindyp@google.com> Provide formatting versions for senders.

That way, Gmail can use its formatting, email can use CSV (default)
and we can add another version when necessary.

Change-Id: I088e99376d1fba7cebb2d6a8d260dd8a80c6cbdc
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
8eb43be8074acb4e09da1385225fbb41c97b1bd5 09-Apr-2012 Mindy Pereira <mindyp@google.com> Make sure that we render conversation sender details.

Change-Id: I5fffcf1b4abf6ee565d0d1db5520fd14dd6490be
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
acf6039a23382f18c35f6b487d90d53cb67b5858 06-Apr-2012 Mindy Pereira <mindyp@google.com> Drag and drop into folders.

Change-Id: If80c43fb5643d328bf061c2bed87bd9acb6e4661
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
90fc0ffa0ad4fcde94fa9648df7f8041bfb6a943 05-Apr-2012 Mindy Pereira <mindyp@google.com> Default to showing checkboxes as we have issue around settings not being there on orientaiton changes.

This is the safer alternative while we work out those issues.
Fixes b/6297162 Check box is not displayed in the Inbox for multi-select operations

Change-Id: I587d729df987988555078ad954ec669141e4bff3
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
f07269fdfbc0ca2607dad50bfc15c2c041c1fadd 05-Apr-2012 Mindy Pereira <mindyp@google.com> When there is no swipe, use a different touch handler.

Fixes b/ 6291400 Multiple messages are selected by scrolling up and down in Inbox
Fixes b/6291013 java.lang.ClassCastException: com.android.mail.browse.ConversationListFooterView cannot be cast to com.android.mail.browse.ConversationItemView
Change-Id: I44e5a21326a620405cbdf769e736d37bbda5ceac
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
b6b174fb3a8f58a2c81e035917ebad8ab45b88ae 04-Apr-2012 Mindy Pereira <mindyp@google.com> Respect hide checkboxes; tap and hold to add to CAB group

Change-Id: Iaddd1dbbfd1a0e3c07ba1ffcd6a4e4368ad0e294
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
4022889525ce3ef25caabe4a8b50c7140a4bd9ed 03-Apr-2012 Mindy Pereira <mindyp@google.com> Use the correct item animating height depending on view, device

Fixes issues where animating items are sometimes the wrong height.

Change-Id: I407294e8fdae5cc560897368d48140d442ee5cd8
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
866d319dd23ec8b7b7d5476c65f7f83469d55d2d 26-Mar-2012 Mindy Pereira <mindyp@google.com> Re-enable swipe.

Swipes all checked items at once
Tap highlight
Properly colored background
Doesnt swipe non checked items when there are checked items
Change-Id: Id71e331d35f75ee02813dee8376d764386221868
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
c56206c07a825c786e5729b173d763747328da79 27-Mar-2012 Mindy Pereira <mindyp@google.com> Make senders in unread conversations bold.

Change-Id: Iac46000f08d1f070b20a3ec3e75e4840bf29b1c6
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
a293987a6bc4d0b1089db95555abc9ac32939882 21-Mar-2012 Mindy Pereira <mindyp@google.com> Clearing the shader does not actually seem to work.

There are def some leftover "ill effects" from setting and unsetting
the shader, so just creating it when the item is too long instead.

Change-Id: I9777e7881b5257493aa61945f012c253c3748bdc
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
3c3dba5fd3888d38f68af531e74f1132a502b5dd 21-Mar-2012 Mindy Pereira <mindyp@google.com> Turn off the handling for when a label is too long for now.

This is what is causing label text to not show somtimes.

Change-Id: Ia87d8f9a604dc21af9efeb4945f76471dcaf3cb1
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
bdcd35cc553bd6bede8277983384f5bcf83b58b2 19-Mar-2012 Mindy Pereira <mindyp@google.com> Revert "In order to use touch interceptors, we need to always return true from ontouch."

This reverts commit 64771c7ff7077efd8ce974d0095d24bd5c8ccb89
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
64771c7ff7077efd8ce974d0095d24bd5c8ccb89 19-Mar-2012 Mindy Pereira <mindyp@google.com> In order to use touch interceptors, we need to always return true from ontouch.

Otherwise, swipe doesn't get the correct events to swipe an item.
So change onTouchEvent to actually just perform the click when an
item is clicked.

Change-Id: I883f49c124737514f95efdc0fa78cf346ebb80b7
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
c03208720e5650f0acb748f82ed10ac770d6ceb4 14-Mar-2012 Andy Huang <ath@google.com> bring in classes to support conversation view's subject/labels

No functional change.

Bring in classes and refactor existing folder-display related
classes. Remove FolderValues and use plain Folder. If we need
somewhere to tuck display-only Folder properties or behavior, we
should wrap base Folders instead of duplicating fields.

Folder objects now support equality checking using the
(globally unique) URI.

Change-Id: Ic4cd9b555a6a71ed037a1e730f36f7f64c50ca36
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
d5ac9c16e8955abe8366fd1185b86d8bd7c5ac60 15-Mar-2012 Mindy Pereira <mindyp@google.com> Set correct invite asset.

Change-Id: Ib098e8aa2bb05032350ff8692d9330309987f57f
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
20403af89cf0f7b2a2291093d96619083fb965b6 15-Mar-2012 Marc Blank <mblank@google.com> Remove debug crap

Change-Id: Ic77739481bf77a9acaaed048cf0274e50d086af1
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
7bbd9438ba2e0489e6ff9e5e4f6e76e2eb2a9ee9 15-Mar-2012 Marc Blank <mblank@google.com> Allow rawFolders to be null

Change-Id: Id8d9ab76c0f0abbb1d2aeaf932b2420736d08c6e
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
3fd1f2c4cba9095ccd024ac26187cba6fdfc367b 15-Mar-2012 Mindy Pereira <mindyp@google.com> Fix alignment/ width of senders and folders in wide mode.

Change-Id: Ib256202d6b9454b698cdd834925f9e4e42b8f242
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
8d83c8a0c9c01ce5ed9381f2765b3ba59948710f 15-Mar-2012 Mindy Pereira <mindyp@google.com> Show invite icon in reply state location when applicable.

Change-Id: I851b088c766b72e6e4a9fc1e1ece2bd3b04d71e1
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
54467a21dce72130bb04eb5aa1c9813d88308a80 14-Mar-2012 Mindy Pereira <mindyp@google.com> Add reply state logic. Only show it if its defined in the layout for the item.

Change-Id: I41a58e41b76a6b3f0c2ca87f1e8336e67e71eb5d
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
7a2036b38155ff0bb2fd047e929ff1526784aec4 14-Mar-2012 Mindy Pereira <mindyp@google.com> Set show priority indicators to true by default.

Change-Id: I93c37bcc8e0efea470d51701ea929354f4e00a5f
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
3cb938f638cc3cec08c9c42d20192e65b1e7d343 14-Mar-2012 Mindy Pereira <mindyp@google.com> Dont show personal indicator by default.

Only show it if the layout file has it.

Change-Id: I6ac6c8a11fb42f0a23250dbdc613dc6865e96dbd
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
4584a0d83e160444f931cb565185a2eea39b1683 13-Mar-2012 Mindy Pereira <mindyp@google.com> Remove the folder we are in on the ui side.

Conversation needs to show it; conv list doesn't.

Change-Id: I0c26852525ca58bb71fc8a27e90ea4868487a5cd
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
b5080d5335d2aa445a660ad426ab008750be24cb 09-Mar-2012 Mindy Pereira <mindyp@google.com> ehow folders in conversation list items if they exist in the layout.

Change-Id: Iec0198f7eab014c71d66e1c026942988d985f1e9
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
276c80bb3ca7cff5f2a0511e8a9d0452ae91d858 09-Mar-2012 Vikram Aggarwal <viki@google.com> Moar cleanup

Change-Id: I2ec187ec05d14000edbfff22acf2b8ff251530fb
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
47ccb45dff1329d5ddac33fb71674048f8c7f51a 09-Mar-2012 Mindy Pereira <mindyp@google.com> Update layout so that conv items without labels dont look broken.

Change-Id: I80c387a66ff9c9050bc97bd7d9f33c486aee8424
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
30fd47bf1947da5ad813cb957b6cbe569dce563a 09-Mar-2012 Mindy Pereira <mindyp@google.com> Remove all label refrences from unified; change to folder

Remove labels text views from unified mail conversation list items.
Gmail will override with a new xml file that will provide a "folders" area
Change-Id: I443b8d73f253f046dfa8a8a68afa19e89bf7a85a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
e9a81035bcef5a372fa13a992f8553eb60e6aaf0 22-Feb-2012 Vikram Aggarwal <viki@google.com> Start showing label list on tablets

Change-Id: Ib5529ce2eca88c71979ed0bc6340cb2a752ffd25
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
d247dc966bca1ed303039c2893c54979d448a336 11-Feb-2012 Vikram Aggarwal <viki@google.com> Allow batch selection of conversations.

Change-Id: Ibaa7e96154b8c433651d9e8ef68f7973b92b7ac9
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
fa131a2ff399fd1d544f759b063268fb4e8a3e70 02-Feb-2012 Vikram Aggarwal <viki@google.com> Make ViewMode focussed and small.

1. ViewMode is no longer aware of tablet versus phone UI. This is the
responsibility of the ActivityController now.

2. onViewModeChange receives the new mode as an integer rather than
the ViewMode object.

3. Rather than a plethora of isXMode() isYMode() methods, client
classes need to manually check getMode() against ViewMode.X
ViewMode.Y constants.

Change-Id: Ib06196671ad49328c40cc9237667c0a1daf328f7
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
f892f0a57d5c24b09fdc805f0fe2007ecd0d0e91 30-Jan-2012 Marc Blank <mblank@google.com> Refactor of some ConversationCursor code

* Quickly return positions of items deleted/updated

Change-Id: Ia1cc20bfcc5ab1958ec8c514321a1cc046dd81c3
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
8d69d4e10a9a36ff790babb2f3a098a12d0dc732 25-Jan-2012 Marc Blank <mblank@google.com> Enhancements to Conversation/Cursor/Provider

* Added methods in Conversation for doing batch update
and delete (e.g. from selection screens). The batched
changes reflect immediately in the conversation provider
and are then executed in a single transaction in the underlying
provider.

NOTE: If called from the UI thread, these operations will
not block (the underlying provider is called on a new thread);
it's expected that update/delete will almost always be called
on the UI thread. Where the result of operations is needed
(i.e. a Uri return from an insert), synchronous operation is
required; this can be done by calling on a non-UI thread.

* Support for selection -> add star

* Also, quick and dirty implementation of read/unread, both
by reading mail and by using selection -> mark read

Change-Id: Ia060cdf21b2f9f3960315c746e81c04ae3afc6a1
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
d3818654c103802704fc788cf9c6775d25b65bff 25-Jan-2012 Mindy Pereira <mindyp@google.com> Clear selection after a destructive action.

Change-Id: I4e6faed97452ccb5ec0ef3d37f2c9a72b1d406fe
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
1ddcf0f2bf44d3c9db89112ef52510d9b2433ac4 13-Jan-2012 Vikram Aggarwal <viki@google.com> Adding more ActivityController dependencies

ui.ControllableActivity added from Gmail.
One pane layout files brought in.
Minor changes to make everything work with the test activity.

Change-Id: I8cacd5f36394fe4a786590e2e381369a3afb5494
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
11b0bbdf024ec1413f90b2baac2c18a8f1c01d71 24-Jan-2012 Mindy Pereira <mindyp@google.com> Add selection set delete.

Now, when the user taps the checkbox on a conversation,
they can use the conversation selection menu to delete the item.

Change-Id: I18b58f4e25ac018621c8aa3330c5717da91c8913
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
c8a994227b9c686d88ee05840544162711a85712 19-Jan-2012 Marc Blank <mblank@google.com> Prototype ConversationCursor/ConversationProvider

* Handles updates/deletes from the list instantly, then forwards the request
to the underlying provider
* Only starred/delete are implemented currently for Email types; the Gmail
provider doesn't yet support updates to UIProvider uri's
Note: Email types support read there's no read/unread support in the prototype
UI
* Updated UIProvider/MockUiProvider with latest adds to Conversation class
* Underlying provider must notify ConversationCursor of changes via newly
defined notifier URI

TODO: ConversationCursor wants unit tests

Change-Id: I91babcd5c27109acaa1f7479d584524e8a508a56
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
4401c9049f0327019b0bfed554bf8ff5cdaa20e2 18-Jan-2012 Mindy Pereira <mindyp@google.com> Parse addresses for senders display names. Move attachment joined string parsing to provider.

Change-Id: I36a5af1d3d54350ca2d9fa97666f5ceb8268a0b7
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
259e52238941db08b518154215c579fd2f57ea86 12-Jan-2012 Mindy Pereira <mindyp@google.com> Simple sender display.

Change-Id: Ieea07b676d776aa33541e22e7ea3ddd0635e7c21
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
732600e38891db139bae02dc91dd0c5b0987e8e9 11-Jan-2012 Andy Huang <ath@google.com> conversation activity plumbing

Short circuit UI usage of unnecessary ConversationColumns.URI
indirection. Conversation view can be passed a model from the
list view rather than querying again. Add Conversation
parcelable to be a model that the UI can pass around.

Fix minor misc issues.

Change-Id: Ifdbdc914d1522066bfce757e1237caa67d85fea2
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java
30e2c24b056542f3b1b438aeb798305d1226d0c8 07-Jan-2012 Andy Huang <ath@google.com> rename unified email's package name to com.android.mail

New code needs a new package name. Fixes IDE conflicts when
browsing.

Change-Id: I328484c6d6c71df077a05d2f7d6d1e85074107c2
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationItemView.java