| 3e8176df16950c067bcb1b37e62b2fc07d74065a |
|
14-Nov-2013 |
Scott Kennedy <skennedy@google.com> |
Don't show the alternates dialog for GAL contacts
There's a bug in the chips code that causes this to show either no
alternates, or a different person, which is scaring people.
The proper future fix is to store some more information about GAL
contacts so we can do a proper lookup.
Bug: 11535331
Change-Id: Id8b6fc834446afe33bd6ec4e99b3d2b75b985bde
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| dc660babb68131f3fd9c62c1c1e640869d21bd92 |
|
14-Jul-2013 |
Alon Albert <aalbert@google.com> |
Support an External Dictionary of Contacts
Allow support for an external custom source of contacts. By making
some classes & methods protected rather than private, it's possible
to allow for a derived class to extend the Chips behavior to load
contacts from an arbitrary source.
Most of the changes here are just access modifier changes but there's
one more substantial change:
Intruduced BaseRecipientAdapter#getMatchingRecipients() which matches
generated recipients with proper chips recipients from the external
sources.
Ideally RecipientAlternatesAdapter#getMatchingRecipients() should reside
in the adaper too but the goal of this CL was to do this minimal
modifications.
There's also a small change that beileve was a bug in IndividualReplacementTask:
The matchesFound() callback gets a list of matches found. It then iterates all
the original recipients and looks for those that have matches and replaces them.
So far so good but, if the original recipient doesn't have a match and is not a
phone number, the old code still replaces it with itself when it can simply skip
it I think.
Change-Id: I24e89f93ec15154ed8912664cd061fa2b5b18bd8
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 17d266469a185c44a705732310b8296393bc1668 |
|
07-Jun-2013 |
Scott Kennedy <skennedy@google.com> |
Fix a NPE
We may not get a cursor back from query(), and if that happens, we
shouldn't try to use the null cursor.
Bug: 9287151
Change-Id: Ie91d8003f51ea160e5b709a5cd6bcabefc3c687a
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| e46cb66d4265b6fb8800f9120086151b36011f0f |
|
14-Mar-2013 |
Scott Kennedy <skennedy@google.com> |
Always close this cursor
Bug: 8375851
Change-Id: I6aa528091615319722ea7b101bb1cda42c97d122
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| e5d82228c1960115e31f67eb6a3a254d6902e3c5 |
|
07-Mar-2013 |
Scott Kennedy <skennedy@google.com> |
Initial clean up of the chips code
Change-Id: I56a3dd5968a3ea435d6dcae9256021bac1f74ee6
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 42ae8ba360efc42cc03d8e754a7ddd7dbd0ae92f |
|
26-Feb-2013 |
Scott Kennedy <skennedy@google.com> |
Unit test for getBetterRecipient()
Follow-up to Ic53d290431fcabce9607685a6eca45063fea0c9a
Change-Id: I28094ce9744838a1ab859470b22714d539ee8f4c
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 211ae63525c02ec914ef020af625ea4e7d8a3b29 |
|
27-Feb-2013 |
Scott Kennedy <skennedy@google.com> |
Reduce chip jank
Put every email address in a chip, so we don't have jank as text
addresses are replaced with chips.
Bug: 8254380
Change-Id: I39d435a9e29c6d9cb2b5f5f69a103ac7a7ab4a3d
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 8c3867660cd9e2ebb34e5efc62aecdad76a65c6d |
|
25-Feb-2013 |
Scott Kennedy <skennedy@google.com> |
Use the best contact result for chips
In situations where multiple results are returned for one contact
lookup, we were taking the last result. Instead, we should determine
which result is best (based on display name and photo availability),
and use it.
Bug: 8254525
Change-Id: Ic53d290431fcabce9607685a6eca45063fea0c9a
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 2727f969d0ce46cdd16cd77e1dc21f3a636217d2 |
|
16-Feb-2013 |
Scott Kennedy <skennedy@google.com> |
Ensure all addresses turn into chips
If an address wasn't properly resolved, it was left as text. This
change processes all unresolved addresses into chips.
Bug: 8201904
Change-Id: Iae7718d97c7c1167bdc464ef372b171743524712
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 0cf347e69473d2259194257d5a4b9aa103c8e448 |
|
10-Dec-2012 |
mindyp <mindyp@google.com> |
Extend reverse lookup to also check GAL
Fixes b/7499733 gal address sometimes treated as message-only address in chips
Change-Id: I3fa79a43c672b1d2eac72dae6a9dfaf8701be977
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| fbe2d2113c0d00e7f7c7197a3727bb0728d220d8 |
|
14-Nov-2012 |
mindyp <mindyp@google.com> |
Don't validate the recipient text each time
Instead, validate once.
Saves ~10ms per chip creation
Win.
Part of b/7492291 First 2 contacts takes too long to resolve into chips when there are many contacts
and general speed improvements
Change-Id: I6f3da136da23942c8bec25cee7038d475e7005e6
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 441b417f05bf807429281e6ad7cd43c9bdba87a6 |
|
24-May-2012 |
Mindy Pereira <mindyp@google.com> |
Null check; back behavior
Since its possible there was no chip formed for an address, it is
possible there is no address in some part of the inAddresses array, so
build it up as an arraylist so we don't have null spots.
Fixes b/6555471 NPE in com.android.ex.chips.RecipientAlternatesAdapter.getMatchingRecipients
Fixes b/6556107 when contact chip is selected back button should dismiss the popup and unselct the chip
Change-Id: If74b13ccc5f51aafc3638817b5fbef54cd57548c
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 593f0b4e64753b8e8ad17fdf6dc7625819c829b8 |
|
03-May-2012 |
Mindy Pereira <mindyp@google.com> |
Fix alternate reverse lookup query.
Fixes b/6428194 Chips misbehave when re-editing a draft
Change-Id: I6589ece36aac7dcfb4ac2650d555f8ce914f337e
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| f64cbf19fb2bc09835a46472c8efd8c6c07fa5ab |
|
03-May-2012 |
Makoto Onuki <omakoto@google.com> |
Don't show duplicate destinations in alternate popup
There isn't much thing we can do from the contacts provider side, so let's just
remove duplicates manually...
Bug 6428328
Change-Id: I78e7fc7ed66d7cf977935611c8fb0318ffa7c83b
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 8f968fc75a99645b5b170c3ca0bd3aca9a207ca7 |
|
02-May-2012 |
Makoto Onuki <omakoto@google.com> |
Don't use DISPLAY_NAME for chips if name is email or phone
Don't use contact's display name, if the name source is EMAIL
or PHONE (or UNDEFINED). Just use the destination (i.e. the actual email
address or phone number) as the name.
Bug 5414496
Bug 6425953
Change-Id: Id0e7e57122a4840b075710309306b074143199bf
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 0d17760bb685bc0d4623cbc07da17415955acdab |
|
25-Apr-2012 |
Tom Taylor <tomtaylor@google.com> |
Fix alternates adapter
Make the same change for phone number chips as email chips:
tapping a chip was not showing the alternates for that contact.
Change-Id: I1fbac88a9869dbe97599e4d125709b4861f031d8
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| e71f6dbce4fb8b28c4733d9562c4cf651b23c3dd |
|
25-Apr-2012 |
Mindy Pereira <mindyp@google.com> |
Fix alternates adapter.
Tapping a chip was not showing the alternats for that contact.
Change-Id: I747ddd8a46c6e60a3068cb21d6e5ea16c2d9fd0a
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 75f1f6994f77a6538c71df720aa2250fe71fed4b |
|
06-Apr-2012 |
Tom Taylor <tomtaylor@google.com> |
Support phone numbers in Chips UI
Bug 5066294
Add Zak's work for supporting phone numbers in the Chips UI. The default
remains email-centric, but the phone number option works great for
apps like Messaging.
Change-Id: I17cd8460f1b96f28ced8bbb32e145581dae6d807
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| a11c2b0e1ea043aa4d8745285f2dcbe20448b417 |
|
15-Dec-2011 |
Mindy Pereira <mindyp@google.com> |
Update build file to allow us to have resources in static libs.
Depends on: Change Ifb4d2300: Support to build static Java library with Android resource
Change-Id: Ie1ac8c93cb3f12a7d4e9afd873a13607ed72b932
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 1e12ddb8232423b09b8df6c59f2e65189a0eea0a |
|
14-Oct-2011 |
Mindy Pereira <mindyp@google.com> |
Make sure we perform reverse lookup on pasted recips
Change-Id: Iff0d8670962f279e4fa3158a1acc3395f9e9ddc9
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 2f5589283d93933751c20791ef42dc7eab87061a |
|
29-Aug-2011 |
Mindy Pereira <mindyp@google.com> |
Dont show copy dialog when the user is editing a contact. Fix crash.
Fixes bug:5210400 Email address only chips sometimes display "Copy email adress" even on tap
Also fixed crash in the alternates adapter where it was still looking for a dest type.
Change-Id: I97b68c3f3e45f3d654551953ac4356ff76dfba26
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| c0f97e4f56bc35d99d181c5f604b26fbb89c113f |
|
25-Jul-2011 |
Mindy Pereira <mindyp@google.com> |
Make more chip, dropdown match pixel perfects.
1) the destination type should be uppercase; there is not
textview style to do this
2) fix the heights of the dropdown items to be 48dip
3) text for more says "NUMBER more..." and is styled
Change-Id: I8a391bbd3703c1ccd1415b78d5e843107b1d2095
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 9160cd5d914d6975a5e72920950bd007d05aa7ba |
|
21-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
show type correctly in alternate listing
Change-Id: I8ca30df876a33d7dde544f1f2a9f59af51cae6d0
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 8c03d35fec744db28a2a3230795f123c7afd50cc |
|
20-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show address type in auto-complete list
Also tweak layout file for better layouting.
Bug: 5028342
Change-Id: Iff81ed0c3013c65e6a293575f89c12606832838f
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 4f36b72bcfe3e9f9b9d99a5872de0522f20c7a6c |
|
11-Jul-2011 |
Mindy Pereira <mindyp@google.com> |
Print debug info for reverse lookup.
Change-Id: I8102bbe4d63e0c87e0603966b58d5773b20b4302
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 77056d7532cd26e869964a52456ef18c96f6cbd7 |
|
28-Jun-2011 |
Mindy Pereira <mindyp@google.com> |
Do reverse lookups on pre-appended recipient chips.
Change-Id: I338a07f89264606a58942520791f39908fedbedb
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 0fc929e5fb977fe028d7db04a3ad57e74f42e654 |
|
01-Jul-2011 |
Mindy Pereira <mindyp@google.com> |
Always show the more chip for a collapsed recipient view if there are too many recipients.
Previously, this would not get shrunk until the user focused/ unfocusd
the field. Now, if the field doesn't have focus, it starts out
in the shrunk mode.
Also, when appending a contact, properly tokenizes the contact
so that we show just the email address.
Change-Id: I085ed00dc94b38d22e871d7e80589e5b2d74f98f
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 3656f7e97c58dc8443132d2d8297629b6a04cce7 |
|
17-Jun-2011 |
Mindy Pereira <mindyp@google.com> |
Fix race condition.
Crash was reported where the checked item position had yet to be
set when the list tried to get it. This uses a listener to make sure
that the checked item isnt set in the list until the adapter has it.
Change-Id: I2b5170ab9440bbb0a69989657313b1a4b6d653cd
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 156467329e276c9bc90945bea916ce3ac4849574 |
|
14-Jun-2011 |
Mindy Pereira <mindyp@google.com> |
Delay closing the alternates popup when the user selects an alternate.
Per UX, this gives the user a better idea of what has just occured.
Using temporary assets.
Change-Id: Ied49f899d7999356cc01a672ecb22f492901d55c
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 55bb2833b29945c08b809408ff94ddf7703e911a |
|
02-Jun-2011 |
Mindy Pereira <mindyp@google.com> |
Fix a crash in the removeChip logic. Update alternates dropdown.
There was a crash that could happen if you deleted the first item.
The change in RecipientEditTextView to check that toDelete >= 0 fixes
this.
Also, made the icon and the recipient display name show for the topmost
entry only.
Change-Id: I56b8768c8ead282e2477f91a130bf8cc6fb72b15
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 5f2cc770801133c2db389ebe108063427d1cf6aa |
|
01-Jun-2011 |
Mindy Pereira <mindyp@google.com> |
Make RecipientEditTextViewInner package private.
Also add license and make EmailQuery values package private.
Change-Id: I366ca01ac54f04fbc999377be59dbaa139307550
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|
| 699c1e37a1bf26daab34f2117a14c6e883636077 |
|
01-Jun-2011 |
Mindy Pereira <mindyp@google.com> |
Show alternate addresses when the user taps on a contact.
Change-Id: I9a88dd1612b98587e560c1e50030e36a28e30db9
/frameworks/ex/chips/src/com/android/ex/chips/RecipientAlternatesAdapter.java
|