History log of /hardware/ti/omap4xxx/camera/CameraHal.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
a6e9160507cd4c0d276fbe45a1efb1dae28c3998 09-Mar-2012 Emilian Peev <epeev@mm-sol.com> CameraHal: Cuts down execution time of 'get-/setParameters()'

- The change utilizes two approaches:
Wrap unused parameters in 'OMAP_ENHANCEMENT' macro.
Minimize usage of CameraParameters.

bug:6136966

Change-Id: Ie4a4d2f007e6571ee9a403ed68e977d6cbf6756b
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
41a31123a0fc59b8112460285d3f1ba73c5537c0 08-Feb-2012 Emilian Peev <epeev@mm-sol.com> CameraHal: Reduces Camera logcat prints

Change-Id: Id32ad1b882a76f091866583b15ae0ca2929bacef
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
057f4fd59ec05ded909e9eb9a3363d9ea345b0ca 31-Jan-2012 Tyler Luu <tluu@ti.com> CameraHal: Implementation for CAF status callbacks

1. Remove internal handling of CAMERA_MSG_FOCUS. Before we were
enabling CAMERA_MSG_FOCUS only when application calls autoFocus().
No longer needed since the CAMERA_MSG_FOCUS can come just during
preview now.

2. Add handling of unregistered focus callbacks. Since OMXCamera
will send callbacks even when we are not waiting for one, add some
handling.

Signed-off-by: Tyler Luu <tluu@ti.com>
Change-Id: I457e67b33b2561dd0b1ce3863ce807a8c27f79f6

Conflicts:

camera/OMXCameraAdapter/OMXFocus.cpp
/hardware/ti/omap4xxx/camera/CameraHal.cpp
39371f31292f050f7fd75f7d36c7c9eeffd4ae64 10-Nov-2011 Tyler Luu <tluu@ti.com> CameraHal: Fix preview not starting after surface is abdandoned

If an application gets backgrounded (HOME key) without stopping
preview and releasing camera, preview would previously not restart
when application is resumed. ANativeWindowDisplayAdapter would
detect that the preview surface was abandoned and stop sending
buffers to CameraAdapter.

We were previously not doing anything when CameraService called
setPreviewWindow when a display adapter was already created. To
fix this issue, we need to send the preview window and restart
preview.

Change-Id: I36089b0046f9861897d32c50b52128a41e2de2a5
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
e46394481e771dbdc8683645c3740a3d262a3d0f 17-Nov-2011 Iliyan Malchev <malchev@google.com> CameraHAL: clean up logs

-- introduce CAMHAL_LOGI so that we don't have to dump informational messages
as LOGE
-- convert some verbose messages to CAMHAL_LOGDB
-- convert most frequent non-error log messages to CAMHAL_LOGI

Change-Id: I8afc24aa17da2c157b7b37300a79b4cde81f87e5
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
78dac813ae2c442dd0669db208abd3720d0ea6c4 17-Nov-2011 Iliyan Malchev <malchev@google.com> CameraHAL: Do not return error if AF fails

Fixes b/5612881

Some third-party apps do not handle errors thrown by the camera HAL when they
try to invoke autoFocus while AF is in progress.

The Barcode Scanner, in particular, will quit in this case without releasing
the Camera handle, wreaking all sorts of power-management havoc.

Even though CTS does not mandate it, previous versions of Android and other
camera HAL implementations simply return success in this case. This patch
makes this HAL conform to this behavior.

Change-Id: I758e2de7f84b61043267f052169068b64d75d0d1
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
eb1fc89d3ab1704a59861ab27f4ae0b99f3de75b 11-Nov-2011 James Dong <jdong@google.com> Revert "CameraHAL: Fix preview not starting after surface is abdandoned"

This reverts commit cbaa66464ff86bddf40e3c8de8db44473ff27de9.

we need to revert this change since this leads to a stop ship problem where
we can only take a single picture.
/hardware/ti/omap4xxx/camera/CameraHal.cpp
cbaa66464ff86bddf40e3c8de8db44473ff27de9 10-Nov-2011 Tyler Luu <tluu@ti.com> CameraHAL: Fix preview not starting after surface is abdandoned

Fix 3/3 for b/5593964.

(I'm bundling this fix with b/5573610 because it is preview-related, though
strictly speaking not part of b/b/5573610. It has been with us since the
beginning.)

If an application gets backgrounded (HOME key) without stopping
preview and releasing camera, preview would previously not restart
when application is resumed. ANativeWindowDisplayAdapter would
detect that the preview surface was abandoned and stop sending
buffers to CameraAdapter.

We were previously not doing anything when CameraService called
setPreviewWindow when a display adapter was already created. To
fix this issue, we need to send the preview window and restart
preview.

Change-Id: I36089b0046f9861897d32c50b52128a41e2de2a5
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
3ec18006399d61e97382601d14aaa43ee339c8b6 08-Nov-2011 Sundar Raman <sunds@ti.com> CameraHAL: Fixes for ANR and a setParameter issue

Fix 1/3 for b/5593964.

1. Ensure we don't race with stopImageCapture when stopPreview is called
2. Signal the shutter callback correctly
3. Do not crash the media server if focus APIs and image capture returns error
Still go ahead and perform de-init
4. Replace setParameter from CameraHAl to AppCallbackNotifier with getParameter
when needed.

Change-Id: I2b2745827d227a8d7927ce1611a84c29129e8891
Signed-off-by: Sundar Raman <sunds@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
a58c483de2c8188e41fd9635042c31820d13b845 26-Oct-2011 Tyler Luu <tluu@ti.com> CameraHal: Add function to rollback state machine

Fix 1/3 for b/5472396.

Adding a function to rollback the state machine to INTITIALIZED_STATE
from any given current state. With this function, we can better
manage the different states that CameraAdapter could be in when
stopPreview is called.

Change-Id: I0a456738e8575873b5ac6fb2a31395dab54ef6f7
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
fd705eb8b757a4f3d1d80b736cf20cade04524d7 21-Oct-2011 Tyler Luu <tluu@ti.com> CameraHal: Fixes for #testFocusDistance

1. Seperate OMXCameraAdapter cancelAutoFocus with unsetting focus
lock. Adding new internal parameter to unlock focus from the
cancelAutoFocus in CameraHal. We need to cancel auto focus during
stop preview in case it is still running. If we do the unlock in
OMXCameraAdapter then, focus distance can change after stopPreview.

2. If autoFocus or takePicture comes after startPreview but before
the first preview frame comes, then sometimes the focus distance
queried after the calls won't be correct since OMX camera might
still be transitioning.

3. Update focus distances when focus is running.

b/5473673

Change-Id: I5a27d78aef437a1601a68e8c08fa860f04fc0c55
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
3dcde7b7332edf04cd597b01d69950544dcd6589 25-Oct-2011 Akwasi Boateng <akwasi.boateng@ti.com> Fixes for MMS setparameter crashes

1. Fix native crash for set parameter when
zoom is applied in MMS mode and while
recording is in progress.
2. Don't allow restart of preview or preview
stop when recording is in progress.
3. Fix slow zoom when in MMS mode casued by
unnecessary preview restarts.
4. Fix initial jerky preview when you start
recording in MMS mode caused by having
to restart preview.

Change-Id: Ie64799974488caae5887e4c9f9072d74a12dd797
Signed-off-by: Akwasi Boateng <akwasi.boateng@ti.com>

related-to-bug: 5507018
/hardware/ti/omap4xxx/camera/CameraHal.cpp
759396a116bb2caf006405777a626fe9a8708114 20-Oct-2011 Tyler Luu <tluu@ti.com> CameraHAL: WA for #testSceneMode

testSceneMode requires parameters to be updated properly before
starting preview. OMX Camera doesn't currently support this so
we are just going to keep a hard-coded LUT for the scene modes
for now.

Change-Id: I40c4492834d43c9328c87fd7aa4ea06fb1f1d90b
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
150f3c891ce774b1546e90fab640ccb9c29ce536 20-Oct-2011 Akwasi Boateng <akwasi.boateng@ti.com> CameraHAL: allow set preview resolution when preview is enabled

Fixes b/5397081

Allow preview resolution to be changed while previewing
and also ignore stop preview while recording app should
call stop recording.

Change-Id: I85d0388f3fb2cd12593ab225389bda022cbd938b
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
fab72086a1fa5d93037ec1355bc8b01355db0f41 18-Oct-2011 Tyler Luu <tluu@ti.com> CameraHAL: Keep image port enabled if possible

Try to keep the image port enabled if possible after capturing
an image. We need to disable the image port if any settings are
changed or when stopping preview. To disable image port, buffers
also have to be freed, and to keep the image port enabled, the
same buffer needs to be used. So, we are reenabling functionality
to trigger free the image buffer from camera adapter to free the
buffer as late as possible and as required by camera adapter.
Skip image buffer allocation if it is already enabled.

Fixes issue with some jerks seen in preview during video
capture while taking snapshot.

b/5449158

Change-Id: I830cf8512fe039df10d28e1f5a22e61e30840852
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
9743353b9dd1da8d1755218a7b961400ce825bd1 18-Oct-2011 Tyler Luu <tluu@ti.com> CameraHAL: Make CAF mode APIs consistent

Make FOCUS_MODE_CONTINUOUS_VIDEO and FOCUS_MODE_CONTINUOUS_PICTURE
consistent to the user. For us, this means we need to make some
decision on which capture mode to select based on which CAF mode
is selected by the application.

b/5441086

Change-Id: I39e51ea916e1baa263b6dcc88f76a4940809ecb9
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
ceae1d5450522c01889ebc782a3b71c5d38eac07 14-Oct-2011 Tyler Luu <tluu@ti.com> CameraHal: Handle dynamic switch in setParameters

Instead of stopping preview in start preview for a dynamic
switch. Go ahead and stop preview in setParameters.

Need to force stop preview so all the buffers will be unlocked
in case application captures an image and switches to camcorder
mode before it restarts preview. Otherwise, camera service will
disconnect the window while we are still holding locks for the
buffers.

Error log:
"gralloc_unregister_buffer: Cannot unregister a locked buffer"

Change-Id: Ic252609e5fbcfde569e1dbd8614572df6392bade
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
8b0b73df9a2fe8e4fc2c36919d05321f2d96d543 13-Oct-2011 Tyler Luu <tluu@ti.com> CameraHal: Adapt to new framework vstab param

change to use the new KEY_VIDEO_STABILIZATION parameter from the framework
instead of using TICameraParameter definition.

Change-Id: Ifed4c147e6ad3c02b35772343d9d339ab1402eac
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
88006b1ebee79cb0f1a2c682258b313eb801049d 30-Sep-2011 Sundar Raman <sunds@ti.com> omap4xxx: camera: various fixes

clean up resources properly on exit:

- Frees all resources in case of error during
preview buffer allocation in ANativeDisplayAdadapter.
- Fixes a couple of typos in BaseCameraAdapter.
- Removes a possible memory leak during temporal
bracketing. 'stopBracketing()' will never get
properly executed when 'startImageCapture()'
disables 'mBracketingEnabled'.
- Stops temporal bracketing properly inside
'signalEndImageCapture()'.

Change-Id: Ic122058c835e30f12f335a288164475b8f6d1c6d
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Sundar Raman <sunds@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
2ecb39c0ca21ce9ae00c4585e3f7002e8b4e6ca7 28-Sep-2011 Tyler Luu <tluu@ti.com> omap4xxx: camera: timing issue with autoFocus/cancelAutoFocus

Fixes b/5332895

If cancelAutoFocus comes when Ducati is already sending focus
callback, CameraHal will go ahead and send focus callback to
the application. This can cause the subsequent autoFocus call
to be acked almost immediately with the previous autoFocus call's
notification. Application will think autoFocus is done while
CamearHal is still focusing, takePicture from the application
will return an error.

To fix this issue, do not always send focus notification. We are
going to internally enable/disable auto focus message. Enable focus
message when autoFocus call comes and disable focus message after
notification or if cancelAutoFocus call comes. This will prevent us
from sending notify message if application calls cancelAutoFocus.

Change-Id: I8c8892f14894e23a9d73fa1c2b058389d196eefa
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
7016577b173fc73f5b43e76cbc122bb0a9346613 30-Sep-2011 Akwasi Boateng <akwasi.boateng@ti.com> omap4xxx: camera: switch to executing state when surface is null

Partial fix for b/5422679

To enhance standby to first shot performance

Change-Id: Ib32e8120a7908419c76e8cf2f1830f0667b258c0
Signed-off-by: Akwasi Boateng <akwasi.boateng@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
c160a1f85c70e49a7613d774e2d99035f3cb4851 04-Oct-2011 Tyler Luu <tluu@ti.com> omap4xxx: camera: EXIF thumbnail for video snapshot

Fixes b/5370657

1) Extend NV12 resizer to take stride insteadof hardcoding stride
2) Change Encoder class interface to support encoding a thumbnail and main jpeg
image. Encoder will resize/encodethumbnail in parallel while encoding the
main jpeg. Only NV21/NV12 resizing is supported. Thumbnail is created
withpost view frame.
3) Add interface in Encoder class to replace thumbnail with jhead.
4) Height and width fields of EXIF are not proper. Fixed.

Change-Id: I5d0063357e4e9e327d22805c2dddf8f630d22e7b
Signed-off-by: Raji Reddy Kandi<rajireddy.k@samsung.com>
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
72b0d2814165e633385bd87a838fc9c3a8250113 15-Sep-2011 Akwasi Boateng <akwasi.boateng@ti.com> omap4xxx: camera: send different preview and video buffers for MMS mode

Fixes b/5265389 b/5156090

1. Add support to send different preview and video buffers to framework in MMS
mode.
2. For resolutions less than or equal to QVGA, preview resolution will be
changed to a bigger resolution matching the aspect ratio of the preview
resolution.
3. During record the changed resolution will be resized to the original
resolution and sent to the encoder.
4. Modified NV12 resizer routine to account for frame offset and stride to
avoid double memcpy of the buffers

Change-Id: If66aa1fd861078d0a63b4a77a1bdc20d4c6bccda
Signed-off-by: Akwasi Boateng <akwasi.boateng@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
9a412956d5327ec851ff8adc3e9804640fa30c7f 06-Oct-2011 Tyler Luu <tluu@ti.com> CameraHal: Allow only certain number of instances

1) Protect against simultaneous access to camera_device_open
2) Set a value of MAX_SIMUL_CAMERAS_SUPPORTED to dictate number
of simultaneous cameras that can be open at once. Set to 1 for
now in this patch. Return error if more is requested.
3) Change OMXCameraAdapter to allocate new instance for each
factory create call.
4) Add lock to capabalities factory function in OMXCameraAdapter
to protected against multiple OMXCamera GetHandles...

b/5401791 b/5404200 b/5405235

Change-Id: I179d493f8070d228877ebfac637047978afc7d55
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
9f3f04aef58cac9615677094e7846a8ce2a4fe57 23-Sep-2011 Tyler Luu <tluu@ti.com> CameraHal: Do not unset exposure/wb lock in stopPreview

Did not remove code that explicitly unsets white balance
and exposure lock in stopPreview after capture case.

Change-Id: I1f990eb0819223c3642205584d2124bccc47355c
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
3f94f2f7a3999272d52653cd82714b7a7d3ae9b9 22-Sep-2011 Tyler Luu <tluu@ti.com> CameraHa: Reset mDynamicPreviewSwitch after startPreview

mDynamicPreviewSwitch was not being reset after the first
startPreview() call. This is causing the preview to be
unecessarily restarted for the first capture and causing
some hit in performance time.

Change-Id: I47e8840414c6da523c40ad04eaad05e841907acb
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
08bd593a76c52f567ab844a9d92a9ffa2fe47ee9 21-Sep-2011 Sundar Raman <sunds@ti.com> CameraHAL CTS: Update the fps range passed by the app

mParameters was not updated based on the setParameter
from the app.

Change-Id: I24a4cdec9355ea677c7e09f9060989d2c6f40ac3
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
d1e16379476a175660ef8f6934c289edeed6b7fc 21-Sep-2011 Sundar Raman <sunds@ti.com> CameraHAL: Fixes an issue with constant frame rate selection

Change-Id: I2ca38e60f7a47d149aa5696ff8d8ca3246d2d479
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
d2d3968a441810c81cf9f46ff43af29cb6fdfb93 20-Sep-2011 Tyler Luu <tluu@ti.com> CameraHal: Do not restart preview if already recording

Slight fix to the KEY_RECORDING_HINT logic. If we are already
recording then we can just ignore the recording hint logic. Also,
if recording has already started then we would already be in video
mode anyways.

b/5332829

Change-Id: I372f43dd961f137c204ce60f20de3bdd793f02ed
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
7d9e44875d553c966d2e5d7b89de8ac23be1c1f2 19-Sep-2011 Tyler Luu <tluu@ti.com> CameraHal: Stop video snapshot before trying to stop recording

If stopRecording comes before OMXCameraApdater can signal for
endImageCapture...go ahead and end image capture from stopRecording

Change-Id: I7c8142ba95475d823c9569cf9e72338d2da53f14
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
524cc0cda6ed8cb07e0469fc931657ac60335aa1 15-Sep-2011 Sundar Raman <sunds@ti.com> CameraHAL: Fixes for FPS range configuration

Change-Id: Idfc506812d6e0f1d88bdc5d7d62c159f9c9ad642
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
26d9a9166b81616d205eb9ebb49c18dac1f6c044 15-Sep-2011 Tyler Luu <tluu@ti.com> CameraHal: Ensure frames are returned by AppCallbackNotifier

No bug filed for this, but it results in a crash. We can say it's a partial
fix for b/5316293

1. Clean-up notifyFrame a bit by using a common function
to send data callbacks. This ensures common functionality
for the all frame types.
2. Flush all the frames after stopping AppCallbackNotifier
to ensure notifyFrame doesn't operate on the buffers.

Change-Id: I4b0c8a595ea5474e8c8f5f98cfee16e6c1bde949
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
f4260660c494005dc6556698765fe3f3a0d97f60 14-Sep-2011 Tyler Luu <tluu@ti.com> CameraHal: Fixes for setParameter in CameraHal

1. CameraHal needs to call camera adapter setParameters when parameters
that the camera adapter will update in getParameters are changed so that the
camera adapter is properly updated before for a subsequent getParameters call.
2. Pass mParameters directly to camera adapter in getParameters call so
that it can be updated with parameters that the camera adapter modifies.

Change-Id: I26e8b6c39ff8be4af6bedb4d3eb1b81b4f3c2c17
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
0e5d32b3afece9b292864fccd4b5390b4ef57ddb 13-Sep-2011 Sundar Raman <sunds@ti.com> Camera HAL: HomeScreen fix: Check for image cap before exiting stopPreview

stopPreview was returning if just the mDisplayPaused was set. It should
go ahead and stop image capture if it is in progress. Also, the setParameter
for restoring focus locks will be done as part of stopping the image capture.

Change-Id: I1c064ca3c0906faffb507bf2e656259334272304
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
de885009bcb5e9491e6107173e0e03671267a1a9 13-Sep-2011 Sundar Raman <sunds@ti.com> CameraHAL: HomeScreen Fix: Make releaseImageBuffers a no-op

1. Make releaseImageBuffers a no-op for now because it is racing against AppCallbackNotifier
2. Move freeImageBufs during exit to be called after the AppCallbackNotifier exit.

Change-Id: Ia127f5799dadb58f75dd6b2ebe8d58aed2303d60
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
8fb9734825448eebe07b080b0c2e82565111cca2 13-Sep-2011 Sundar Raman <sunds@ti.com> CameraHAL: Checks preview buffer registration status

- This modifcation should bypass some of the software
overheads involved in notifiying the client for any
errors occuring during the preview buffer registration.

Change-Id: I403d4ce065cb6cc794ce98f7d010d3f3caeb43e4
Signed-off-by: Emilian Peev <epeev@mm-sol.com>

Change-Id: I4e017dfbb0a0101ded1c8c0b13d7f8fc5993ea05
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
6b5eaf29c3d17a24731bf9271bd0d199d433813e 09-Sep-2011 Akwasi Boateng <akwasi.boateng@ti.com> Unblock semaphores during Fatal Errors

1. Remove all pending events and unblock
all waiting semaphore during Fatal error.

2. Exit execution when in invalid state.

3. Remove error nitiifcation from
Appcallback thread

Change-Id: I1612ff75e83ebf285d4cc168a829e0f81d4968b1
Signed-off-by: Akwasi Boateng <akwasi.boateng@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
a5263e55084368d67ad6a08bae59a6d910e756e9 08-Sep-2011 Akwasi Boateng <akwasi.boateng@ti.com> FPS range and frame rate changes

Adjust framerate to match fps range
if app wants to a different fps range
other than the defualt and also adjust
fps range to match frame rate if
app wants to chnage frame rate only.

Change-Id: I1e15e4a021140f5b1cf78fcbb57c722a8e97e983
Signed-off-by: Akwasi Boateng <akwasi.boateng@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
381ec2390c3d9d6ba3b67cf53e69fec96e7a7bd1 08-Sep-2011 Akwasi Boateng <akwasi.boateng@ti.com> Set default fps range for video mode to 24<->30

Hack to allow image mode fps=15 and
vide mode fps = 24

Change-Id: Ie2a4b3d5c7e32515a1af948fa65c934baaf3e1a9
Signed-off-by: Akwasi Boateng <akwasi.boateng@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
342adfa1cc708708ddfc167d06b2345fcaa8b0e5 08-Sep-2011 Tyler Luu <tluu@ti.com> CameraHal: Handle stopPreview properly for preview in progress

During some cases like when phone orientation changes after
startPreview call but before setPreviewDisplay, stopPreview
is called by application. Before we were seeing some error
messages from camera adapter state machine because we were trying
to make some improper state transitions. This patch guards
against that. This patch also resets the mPreviewStateInProgress
flag in stopPreview

Change-Id: If5e4c235b0937b37f567d9b1ed9bd4478ace69d4
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
708ed7306c85286aa50d05ba15e0c33106e52ed0 08-Sep-2011 Iliyan Malchev <malchev@google.com> Revert "Revert "CameraHAL : Multiple focus and exposure areas support""

This reverts commit 72bac2af47f73167bd288bc7278e5496ccabe6f4.
/hardware/ti/omap4xxx/camera/CameraHal.cpp
72bac2af47f73167bd288bc7278e5496ccabe6f4 07-Sep-2011 Iliyan Malchev <malchev@google.com> Revert "CameraHAL : Multiple focus and exposure areas support"

This reverts commit bd9754a1b2c8d5e0a8788d0e42d018857bfef7a7.

Conflicts:

camera/inc/OMXCameraAdapter/OMXCameraAdapter.h

Change-Id: Iad51c457b05de9b5492061b8402e508a6c5b42bf
/hardware/ti/omap4xxx/camera/CameraHal.cpp
9919dafce4d57f0b9b9aedafc95b756464685009 02-Sep-2011 Tyler Luu <tluu@ti.com> CameraHal: Set KEY_VIDEO_SNAPSHOT_SUPPORTED default

Change-Id: I106a62bc752398f52224d1b1b7ef78a703ab1f17
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
ee6bb64f60c228d711dc1d6875d8f4b0ed88b6cf 01-Sep-2011 Tyler Luu <tluu@ti.com> CameraHal: Initial support for video snapshot

Adds support for capturing an image while
recording in video mode. Sets up Ducati to
return a YUV422I buffer and encode is performed
in AppCallbackNotifier with Encoder_libjpeg class.

Change-Id: Ia351fc99dab63a12add8c6c960b186bbe5be275a
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
bd9754a1b2c8d5e0a8788d0e42d018857bfef7a7 26-Aug-2011 Milen Mitkov <mmitkov@mm-sol.com> CameraHAL : Multiple focus and exposure areas support

Adds support for multiple focus and exposure areas and
also correctly returning the number of maximum supported
focus and exposure areas.

- Patch set 4: converting the coordinates,
which are sent to 3A in the range 0 - 255. Both Focus
and Exposure algorithms use this range

- Patch set 5: Handling special area (0, 0, 0, 0, 0),
rebasing and also memory allocation alignment to 4K chunks.

- Patch set 6: Freeing the alloc'd buffer in case of error.

Change-Id: I45bdd4309b75ac4d50deb05e97120362cdb1937b
Signed-off-by: Milen Mitkov <mmitkov@mm-sol.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
3a1541be51a8cc8dcc92a4ea1f0fa4a1c80990ce 29-Aug-2011 Tyler Luu <tluu@ti.com> CameraHal: Fixes related to CTS #testPreviewPictureSizesCombination

- This test depends on the following camera functionality.
After image capture is done, the camera client should be
able to switch the preview resolution without first
calling 'stopPreview()'. The patch adds the neccessary
logic for recognizing this particular case and accordingly
restarts the preview internally.

Change-Id: I3648ba9259d3a4720a12c7a1242d62b670e5dfdc
Original-author: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
d054c26243e4cf49e5fe04789e4437e5e0f3f574 30-Aug-2011 Sundar Raman <sunds@ti.com> CameraHAL: Enable GBCE by default

Needed to improve image quality

Change-Id: I727b8ee21a186e1616e690f85075e4e8a64617f9
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
c7a945e0434f1b99021d46fddf88bf776da6ad37 29-Aug-2011 Sundar Raman <sunds@ti.com> CameraHAL: Adds ION support to MemoryManager

MemoryManager has been updated to allocate from
ION carveout instead of 1D TILER via MemMgr.

Note:
2D TILER allocation is not supported as it is
not needed currently. We may have to add support for
it in the future.

Change-Id: I3507da9a26ef4cadfda26ee21c8e12bbce515656
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
97db71f3a06c88c16f46fea8189f542dcde28f7f 28-Aug-2011 Tyler Luu <tluu@ti.com> CameraHal: Release 3A locks for stop during paused

Release 3A locks when calling stopPreview after a capture
when the display is still paused.

Change-Id: I65a415209fcd47bc612f3b263444f865b02c2c8f
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
5950d86f5e3d119cb024ae3989a643571dd81794 29-Aug-2011 Sundar Raman <sunds@ti.com> CameraHAL: Remove black bars avoidance code

Now that there is support for recording hint and also since
there is no black filling in ducati, remove the code
that was doing aspect ratio corrections when the mode
was NULL

Change-Id: Iecda0702493ed5eb481c2c17bf41c1305294b899
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
b93aec67a3f7a66060a525a5c0d68fa0089f76c4 25-Aug-2011 Sundar Raman <sunds@ti.com> CameraHAL: Fixes related to CTS test #testFocusAreas

- The recording hint implementation was bypassing
the logic for restoring the original correct
CameraParameters, which is needed for passing the
test.

Signed-off-by: Emilian Peev <epeev@mm-sol.com>

Change-Id: I8c119153dfedab5511955bff1d4c1193014ed720
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
f5094850dd99854af026e16bd21d8555a5168afb 25-Aug-2011 Sundar Raman <sunds@ti.com> CameraHAL: Fixes a possible segfault during deinitialization

- If the client releases the camera when the
ANativeDisplayAdapter is paused, then a segfault
is possible. This is due to the deferred
deinitialization of ANativeDisplaAdapter in it's
destructor. By this time 'mPreviewWindow' in
'CameraHardwareInterface' is already NULL and
all further calls involving it will result in a
segfault.
- Contains a fix for several CTS tests including
#testJpegThumbnailSize and #testJpegExif.

Change-Id: I030e8fdccdacc6d3bf08550da562eac90b50adc3
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
e9ab1f4f653c21c2b526af02ceed12ecb935752c 24-Aug-2011 Sundar Raman <sunds@ti.com> CameraHAL: Add support for FOCUS_MODE_CONTINUOUS_PICTURE

This patch adds HAL support for FOCUS_MODE_CONTINUOUS_PICTURE
which is needed for enabling CAF in still image preview.
Although the HAL behavior is same for both VIDEO and STILL
CAF, by setting EFocusControlAuto for ducati, the ducati
distinguishes STILL and VIDEO CAF internally based on
Operating mode (pipeline that is selected - video or zsl)

Change-Id: I808d41620caacca94dd65985c467f41417dee6d8

Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
aa6e62e279cb54ae76c55ba9f8d02da230ce34e7 16-Aug-2011 Tyler Luu <tluu@ti.com> CameraHal: Adjust FD callbacks to updated javadoc

FD callback behavior is updated in latest javadoc
patch "Improve camera face detection javadoc."

Change-Id: I963628ae55eec62083c25d34bbb380ae6673e431
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
9e5cb561cc54d061fe9f3d05eae78f6efb70f2c2 17-Aug-2011 Tyler Luu <tluu@ti.com> CameraHal: Fixes related to CTS test #testFocusAreas

- Sanity checks should be performed on the individual
areas for the test to pass.
- On invalid configuration CameraParameters should
revert to the last known good configuration.

Change-Id: I9026f287e884835a98c835e8f949ad4441c030bd
Original-author: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
1521831b2b2db93a1c90dd960ca4ee56b65de03d 17-Aug-2011 Tyler Luu <tluu@ti.com> CameraHal: Fixes related to CTS test #testPreviewFpsRange

- Framerate ranges were not ordered as per CTS requirement:
( maxFps1 < maxFps2 ) || (maxFps1 == maxFps2 && minFps1 < minFps2)
- This modification also gives higher priority to framerate
ranges over the deprecated constant fps.

Change-Id: Idee8b7ae9c1a3ce1d947bc5067c2c787f30e4d39
Original-author: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
f8a04b91f608ec0edf05c34e6f105d08175218c5 17-Aug-2011 Tyler Luu <tluu@ti.com> CameraHal: Returns error for invalid parameters.

Returns error for the invalid parameters in
setparameters().
Fixes a cts test failure(#testInvalidParameters).

Change-Id: I11ae111404b64641ccc0ac89f5abe854acb18c35
Original-author: Solaiyappan Saravanan <saravanan.s@ti.com>
Signed-off-by: Solaiyappan Saravanan <saravanan.s@ti.com>
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
b4a28dec029ecbd35aa27984f8681ae98286eca0 13-Aug-2011 Kalpesh Patil <kalpeshpatil@ti.com> Camera Hal : Handle Recording Hint set by Camcorder Application

Recoding Hint is set now by Camcorder App, in order to allow CameraHal
to start preview is Recording specific mode (i.e. Video-Mode).
This patch adds support to handle Recoding Hint in order to set/reset
Recording specific parameters.

This patch also takes care of following contraints set by
Recording Hint support in framework.
1) Camera App can set/reset Recording Hint while preview is active.
2) Camera App can start recording even when the Recording Hint is false.

Change-Id: I6332c316ddc3ddda7f8c9c5739f81e6317c7deb0
Signed-Off-By: Kalpesh Patil <kalpeshpatil@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
cdeb4bffa1685907cbdd64cfbf372409c3b20b36 12-Aug-2011 Kalpesh Patil <kalpeshpatil@ti.com> Camera Hal : Enable VSTAB & VNF for Front Camera

This patch enables of VSTAB & VNF for Front Camera.
The issue with VSTAB & VNF for Front Camera for 720p resolution
has been resolved on Ducati side.
So patch-I28a81696 is being reverted by this patch.

Change-Id: Ie723b2e2a59d0dec7aefd5c9362e24b0dd2f5562
Signed-Off-By: Kalpesh Patil <kalpeshpatil@ti.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp
c322989ae6ff6769490828de1b5eda12b749cce9 08-Aug-2011 Iliyan Malchev <malchev@google.com> initial commit

Change-Id: I8f7a7eeece0e516efa486b77e9d97805c0e65d3e
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/CameraHal.cpp