History log of /frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
7a7dce808e1545e859b80b86f0279ee68ce3f0cc 07-May-2014 Marcin Kosiba <mkosiba@google.com> Sanitize selector Intent when handling intent: scheme.

Android Intents have a selector field which, if present, are used
to search for the Activity to invoke. These must also be sanitized
before handing off to the OS.

BUG:14562482
Change-Id: I30461e11be48ec623ab0f56d0d0f206dc2849c98
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
48c8233468f8c735d8504c8410b86cc373d679ed 27-Jul-2013 Jonathan Dixon <joth@google.com> Connect up the showFileChooser client callback

Bug: 6930981

Full implementation depends on the associated API landing in frameworks/base
As as stop-gap, just fallback to calling the old never-published
openFileChooser in the default case.

Change-Id: I9f44dab183aab0c3431ecc7557aea78d9e78e50d
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
fa14014161c4f0bc0e99d926cacb7071b8d903ef 27-Sep-2013 Ben Murdoch <benm@google.com> Do not assume WebView is running on the main thread.

Cherry pick of Change-Id: I981136571782352889684e4c3181d8cc22a1679d

WebView will run at most one UI thread per process, but that
thread is not necessarily the main thread.

If the first WebView that an app constructs is on the main thread,
then we will bind Chromium's notion of the UI thread to the main
thread. This mitigates the risk introduced by this refactoring for the vast
majority of apps that create their Views on the main thread.

In the case that the WebView is created on a background thread, we delay
binding of Chromium's notion of the UI thread until we get a clear
signal from the apps usage of WebView that it is intended to use that
background thread as an Android UI thread.

In the case that the app does not intend to use the thread it creates
the WebView on as an Android UI thread, we defer as long as possible
before we are required to run operations that require Chromium to be
started, at which point we bind to the main thread. This covers the case
that an app creates WebView on a background thread to read some state
from it (e.g. the user agent) and then later intends to use WebView
as a View on the main thread.

This change does not support:
- Apps that create more than one Android UI thread in the same process
and expect to use a WebView as a View on both of them.

Bug 10932261

Conflicts:
chromium/java/com/android/webview/chromium/WebViewChromium.java

Change-Id: Ief406e30d12b201b6cac2c10c73a0aa0631ca900
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
780460e70baa6eeb9dd596248384c6dd6a05673f 11-Oct-2013 Torne (Richard Coles) <torne@google.com> Provide a video poster even if the client doesn't.

To match the behaviour of the old webview, use the framework resource
ic_media_video_poster as the default video poster if the WebChromeClient
provided by the client doesn't give us one.

Bug: 11158656
Change-Id: Id8c5b4e546081ed765356c38308cf1b6f198109d
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
cd7ea20fdcedc8cf0a8beb9e3a0f3ec2e7955a29 18-Sep-2013 Kristian Monsen <kristianm@google.com> Posting additional log message if apps have a blocked URL

This is to make sure it is easy to spot even if app
intentionally override it.

Change-Id: Ic100ed110c69488a489bb303597a6cbcd852806b
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
f8f270cb5b54adc9546566b283b83df911fc516f 11-Sep-2013 Kristian Monsen <kristianm@google.com> Better onConsole tracing, add the console message to the trace

Change-Id: Ia00a9f49be3ca82afbd5189d0a2de22861b6c58c
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
a66d54c9f62ace5182635c4bf74449fb62f9d464 29-Aug-2013 Jonathan Dixon <joth@google.com> Add tracing for WebviewChromium callbacks

Bug: 10488419

Depends on I5d0d2e253499741c5f9454582988c99e42dc0a81

Change-Id: I92a6477486528b49b7786564d746d69ec4bc8666
(cherry picked from commit 081c438a8201fe2d1248f487808b3bae6706aa7e)
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
3e4e8cf37dfb631bbdf1aa5b04410bf038065fe6 14-Aug-2013 Kristian Monsen <kristianm@google.com> Follow up fix for bug 10154699

My last fix hangs the UI thread as this is different on the old
and new WebView.

Change-Id: I95675d2735f62ab06644c7d6edf1525b4266e58f
(cherry picked from commit fa824b4e111b53fb0981eb0dec3d254bf2c300ee)
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
33e0aee95766f7091948865f4753eae3ed6f6306 13-Aug-2013 Kristian Monsen <kristianm@google.com> Fix for bug 10154699, debug popups

Classic WebView had a state with a null webchromeclient, and did
not show alerts when that was the case.

Change-Id: I7f48dca440f1f6e61ad19c43e9e9d9769d30b581
(cherry picked from commit 384082f8b157276c85b658d8dc254e3489f8f944)
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
19b22dbf30aec2f35bfbdbc80f9fa01e98d563e8 06-Aug-2013 Ben Murdoch <benm@google.com> Fix up NPE in onNewPicture from onPageFinished.

Some apps are relying on a non-null Picture still. So to enable
wider dogfooding, don't crash them.

BUG=b/10141739

Change-Id: Idbd477373b81e3ece8ec3157670d76b1098adb45
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
245b3a6a2a7850a46536a423594286e04e702006 19-Jul-2013 Jonathan Dixon <joth@google.com> Add tracing for client callbacks

This should be useful for app compat and perf tracing

Change-Id: I878bee4971c8a15746f189ee5e2d922c80d268bf
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
ffa63216ba3a69255af88d436feb2f7d758cc321 01-Jul-2013 Marcin Kosiba <mkosiba@google.com> Merge "Ensure that the description in onReceivedError is not null." into master-chromium
bbfef40e5fc625f4821f012fae7f16468b7308cf 15-Jun-2013 Jonathan Dixon <joth@google.com> Fix for popup blocker

Some applications are known to send a null WebView as the child
view to block popups, so add support for this.
Depends on http://crrev.com/206516

Bug: 8267689

Change-Id: I32a97caee1a3499c08fabfca55988787c2af0fa2
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
bbe58198e8cce0c35c42809aebc965aa2b476e1c 26-Apr-2013 Tao Bai <michaelbai@google.com> Calling 2-param onShowCustomeView()

Change-Id: I2937a115c10c1b8b532b7283d566d43d0c75ee31
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
6832aa63c94ee9ea1ebbee7e7e40b7d2dda0e820 04-Apr-2013 Kristian Monsen <kristianm@google.com> Fix for bug 8322948: implement default JS dialogs

Using the new JsDialogHelper

Change-Id: I7c6be7b4e195e2cc7228706f1a7b60e1ef655c2a
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
be2a57c401cf1bb65d541b0bef30d71962d22488 03-Apr-2013 Tao Bai <michaelbai@google.com> Plumb WebChromeClient.getDefaultVideoPoster.

Change-Id: I95ae5ddc91b8f07671f95182684662e7d32c9980
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
f909ca91bfefe7344f9a0e2c684150df1376d9a4 28-Mar-2013 Jonathan Dixon <joth@google.com> Remove ContentViewClient dependency

This is in preperation for AwContentClient no longer extending
ContentViewClient. See upstream patch
https://codereview.chromium.org/13136002

Change-Id: Iee9355d18eff132dae2e353b8aaa2f02275a9a1e
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
782fea892aaa4a0867547697d49f6a1dd265d437 27-Mar-2013 Tao Bai <michaelbai@google.com> Plumb WebChromeClient.onHideCustomView().

Change-Id: If35d31865645432b6a8b4f700462c2e0a78d064e
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
7da9c0c080655cfd18bb4ab0937d89be4c2ca659 12-Mar-2013 Marcin Kosiba <mkosiba@google.com> Ensure that the description in onReceivedError is not null.

This is identical to the code in BrowserFrame.onReceivedError.

Change-Id: Ifd6c293b2c22e9e3203ed9ae0e4266bd492b74c8
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
690b7c64c2aaae62680d137fca34c7fac5176ed2 12-Mar-2013 Selim Gurun <sgurun@google.com> Implement touch icon functionality

Bug: 6295380
Change-Id: If70a5157f11158b080bbdad60d4331f9e710317d
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
2729ce59ec2479c72f2422f49c2f0f0a121ee5b4 07-Mar-2013 Tao Bai <michaelbai@google.com> Plumb WebChromeClient.getVideoLoadingProgressView

Change-Id: I2414a6e538962aee4ef272054c3f37546f946a82
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
3520eb778d668dc76ca4541c69abd568b9d02691 08-Feb-2013 Mikhail Naganov <mnaganov@google.com> Plumb WebView.setInitialScale

Also, make sure that WebView.getScale and WebViewClient.OnScaleChanged
doesn't take into account device screen density, for legacy compatibility

BUG=5012880,5012790

Change-Id: Iaaaee588728464b5a003a2292141c780a9f17577
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
62c1f9e94fbc64193ded0449b96dd2a44f810061 01-Feb-2013 Selim Gurun <sgurun@google.com> Implement onReceivedSslError

Bug: 6204287
Change-Id: I68529ceef8ec1a3e9f03ba30ffcb02a481db7fe3
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
e51e2365d481a173bd2275e2b3f8d62f0d99898d 21-Feb-2013 Ben Murdoch <benm@google.com> Fake an onNewPicture callback after onPageFinished.

The new upstream rendering path altered the timing on onNewPicture
callbacks such that some of the CTS tests became flaky, timing out
waiting for pages to load. Re-introduce a hack in the glue layer that
will fake an onNewPicture callback at the time the CTS tests expect
to deflake them.

Bug: 8208948
Change-Id: I21f20880099dd3d5f06079ba8662981764991455
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
1e2928bab700c1a4c5a99d4e8c87e259866beb1d 18-Feb-2013 Ben Murdoch <benm@google.com> Plumb WebChromeClient.onReceivedIcon.

Bug: 6295041
Change-Id: I5810b01aec831632e83f3550c2aa66007511647d
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
f7bb780599aea67773e11763850892a6de69b4f0 15-Feb-2013 Leandro Gracia Gil <leandrogracia@google.com> Merge "Enable the capturePicture API." into master-chromium
e98a8a77d3f27ef6f5d34a17c845b66b1998fc06 13-Feb-2013 Bo Liu <boliu@google.com> Plumb through onShowCustomView callback

Original patch by acleung@google.com

Change-Id: Ibac9c402600300d3f89ff6db93b31235813e6ef9
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
fd04fd7bd39559bae780324aed460f5b6685c477 06-Feb-2013 Jonathan Dixon <joth@google.com> Revert "Hookup Resources on video views"

This reverts commit 5ac5a8b4d70f29100dc140bfdcd4c3ed0c2c1a38

Change-Id: Ie0f2b6fe2cbfad2aa91d4507060352b6da62f3a7
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
5ac5a8b4d70f29100dc140bfdcd4c3ed0c2c1a38 29-Jan-2013 Alan Leung <acleung@google.com> Hookup Resources on video views

Change-Id: I53e72f695941a7f81cc39f78422fa72647ad643e
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
8979b2e6bf3b6b9236c949e0566ab710beb01b5b 28-Jan-2013 Kristian Monsen <kristianm@google.com> Merge "Wire up WebViewClient.onReceivedLoginRequest" into master-chromium
97a5fe19fb8224fd8ce867edf6692eceb5fd70d1 18-Jan-2013 Bo Liu <boliu@google.com> Wire up WebViewClient.onReceivedLoginRequest

Change-Id: I2dcf67a1f2900f817356792cad86b0a991c0926f
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
809cfd05f0ac95dda1a754b0a3b6283112f12def 16-Jan-2013 Bo Liu <boliu@google.com> Hook up getVisitedHistory updated callback

Change-Id: Ifeb861338f7f5210528b9acd7d85db667eeb9f01
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
e59502f680ec71d2df3af0bab59d4ec3778052ae 15-Jan-2013 Bo Liu <boliu@google.com> Fix build after

onEvaluateJavaScriptResult was removed from the AwContentsClient
interface in
http://src.chromium.org/viewvc/chrome?view=rev&revision=176773

Change-Id: I772b6674ed92b2e571eced59f087236d686509ec
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
9c5a40623b62737244deb2d04a98830d7ffa8404 28-Dec-2012 Leandro Gracia Gil <leandrogracia@google.com> Enable the capturePicture API.

Change-Id: I90a00045c07b5653ac868b01ce64f98e09fd42e8
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
58d5e9da9756274fa2cede82ab12723555ef0ed3 02-Jan-2013 Leandro Gracia Gil <leandrogracia@google.com> Merge "Override onNewPicture in preparation of the incoming new abstract method in AwContentsClient." into master-chromium
5ca5f5c6e538735aa0d0c840eb745cdc4e4a34bb 31-Dec-2012 Leandro Gracia Gil <leandrogracia@google.com> Override onNewPicture in preparation of the incoming new abstract method in AwContentsClient.

Change-Id: I07fd14d4c899eca370386768dbb211bcd5911519
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
151ee73066d5ae9caa8afb828befd9cfbc199b62 31-Dec-2012 Ben Murdoch <benm@google.com> Merge "Implement binding for HttpAuthHandler.useHttpAuthUsernamePassword." into master-chromium
885c764368483b3082be2eccfab3c8a9f72f95b1 27-Dec-2012 Kristian Monsen <kristianm@google.com> Implemted the frameworks/webview part of GeolocationPermissions

Change-Id: I2a1714a91e3b92e5c75100aa233d6a3763afbafb
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
d32343c77868461af07738ac7abd802000490d3d 21-Dec-2012 Ben Murdoch <benm@google.com> Implement binding for HttpAuthHandler.useHttpAuthUsernamePassword.

Query the AwHttpAuthHandler for whether this is the first
auth attempt for this request.

BUG:7034995
Change-Id: I081969d2900aeec17878fdae47a1baf22120f734
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
7f85cf77a1e97aa6816e2ae75c3a5c240050cae1 18-Dec-2012 Jonathan Dixon <joth@google.com> Merge "Hook up WebViewClient.doUpdateVisitedHistory" into master-chromium
bdc62fb18c751c2149ffa582e6568905f26d608d 18-Dec-2012 Jonathan Dixon <joth@google.com> Merge "Add workaround for http://b/7697782" into master-chromium
3c4cc4ad5269837048ffabfa3e749a30b6d17e25 28-Nov-2012 Alan Leung <acleung@google.com> Add onScaleChange to WebViewContentsClientAdapter

Change-Id: I42a7d43ba09fb8ae097904f7d606e0ed60f6868a
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
5e59ff9ab94d503528ef61ccd1c71adb887b5e01 14-Dec-2012 Bo Liu <boliu@google.com> Hook up WebViewClient.doUpdateVisitedHistory

Also update cts test expectation. testAccessLightTouchEnabled was
removed.

Change-Id: I3585aab66c47e818fd7b1db5d5970246f1f54000
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
50de8bf74a15b4db17dcc0aee998ee3e39013eae 13-Dec-2012 Ben Murdoch <benm@google.com> Merge "Wire up WebChromeClient#onRequestFocus" into master-chromium
7bc1fd3e42c1a731a7891043f0f8ee96be1b598c 13-Dec-2012 Jonathan Dixon <joth@google.com> Merge "Remove NullWebViewClient.mContext" into master-chromium
fe742c86d6f6e12bd339c9c2efd947d55c910e2d 13-Dec-2012 Bo Liu <boliu@google.com> Remove NullWebViewClient.mContext

Change-Id: I1aead0c85523130970e476d243ebb225db6c9f09
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
3e9ca893bb8fb7e0038c04bd04ae78f40233db4f 12-Dec-2012 Bo Liu <boliu@google.com> Wire up content intent

WebKitClassic behavior is if client is set, then simply call
WebViewClient.shouldOverrideUrlLoading. If client is not set,
fire the intent directly.

Change-Id: Icdb1c9faa75fd80d0cc6b4e5c724af1ed0406874
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
d7fde5118cb6e238163c9755ab581b82eea47dba 12-Dec-2012 Ben Murdoch <benm@google.com> Wire up WebChromeClient#onRequestFocus

BUG=6295042

Change-Id: I7c96be1c0ef5dbb7e561e147214b98e6b13725d1
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
b5d9eb0196b542499722ffcc8ede41c0eae53516 08-Dec-2012 Jonathan Dixon <joth@google.com> Add workaround for http://b/7697782

Always skip sending system key events to WebKit. This retains compatibility
with WebViewClassic but note this differs from the chrome app, which has a
more focused list in ContentViewClient.shouldOverrideKeyEvent.

BUG: 7697782
Change-Id: I8bcca749f11797a5dfee9132204abf64004040f4
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
4320e428efc3bf69387f3b9d5a0589b2b8746409 04-Dec-2012 Bo Liu <boliu@google.com> Re-implement setDownloadListener

Change-Id: Iffef094f82d4f586353450d3caf7322ca3c4ffba
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
d988b42ca3f28aea23dc968b2f7ed79dae868fc6 05-Nov-2012 Ben Murdoch <benm@google.com> Hook up WebChromeClient.onCloseWindow

Landing without @Override in preparation for:
https://codereview.chromium.org/11418292/

to roll downstream. Once it's rolled we can add
the Override back in.

Change-Id: Ia4eab3913334504829b3abd582fdc71063e4077f
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
1ee9dd0420198429115c3fe8cf0b0502fab9cf62 13-Nov-2012 Ben Murdoch <benm@google.com> onCreateWindow callback plumbing part 2

Support the "true case" i.e. that the user would like to display
the pop up window and has provided us with a new WebView to do so.
Change-Id: Ib6c6aa4cf88b5942feba9671c0904533cb403b67
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
9b5e2bd7d0951a560aa848ff5e74b45560fee045 08-Nov-2012 Ben Murdoch <benm@google.com> Plumb WebChromeClient.onCreateWindow callback through glue.

For now, we only allow the embedder to return false from this
callback, i.e. the popup should be blocked.

Change-Id: I513e2fee6063cbbef1ceeee448410140ac553638
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
251a1c8d0a987b0df24e19904d0c0ef492304286 25-Oct-2012 Bo Liu <boliu@google.com> onFormResubmission glue implementation

Change-Id: Ie388329c85823dc4ed573f5a1653886eb77393f1
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java
46f104289826e85ba76a1a2139d7ecc7daca07b1 23-Oct-2012 Torne (Richard Coles) <torne@google.com> Add initial version of webviewchromium glue layer.

Import the webviewchromium glue layer from the internal forked branch
where it was developed.

Change-Id: I685af58b50fc53a3e17f4506b2f8e830370c7840
/frameworks/webview/chromium/java/com/android/webview/chromium/WebViewContentsClientAdapter.java