9b9dacbbb2353f3415fb70cc1ae8b2e9152e4ecb |
|
28-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Fix potential NPE with null cursor Detect and handle null cursors returned from CP2 queries. Bug:12767708 Change-Id: I1571463b80e5b85656fe119c6bc83de36be30c7f (cherry picked from commit 13c42f4ebb1c7f31750262946ce3b390c93d5320)
/packages/apps/Contacts/src/com/android/contacts/editor/AggregationSuggestionEngine.java
|
738ff8623dc77dd91a1b9023861e924ba5e4c27e |
|
30-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move ValuesDelta to ContactsCommon. Bug: 6993891 Change-Id: I8b065c55100a152f72cccea5b62f10a8e30161c2
/packages/apps/Contacts/src/com/android/contacts/editor/AggregationSuggestionEngine.java
|
aa690d4949b8105e5bcf10569b7cf4fae36741de |
|
29-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Prefactor RawContactDelta.ValuesDelta into top level class. Making ValuesDelta into top level class so we do not have to move RawContactDelta into ContactsCommon. ValuesDelta is used by CustomContactListFilterActivity which needs to be moved. Bug: 6993891 Change-Id: If7371cf08ac0e14218fb790c96856e971fa613ec
/packages/apps/Contacts/src/com/android/contacts/editor/AggregationSuggestionEngine.java
|
851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data This refactoring abstracts out the need to directly refer to Contacts database columns throughout the code. Instead, all of this information is retained in getter/setter methods within the Contact, RawContact, and DataItem classes and sub-classes. ContactLoader.Result class has been pulled to the top level as the Contact class. The Entity class has been removed and replaced with a RawContact class, with getters/setters to raw contact information. Renamed EntityDelta to RawContactDelta for better understandability as well as adding getters/setters for specific fields in the ValuesDelta nested class within EntityDelta. EntityDeltaList and EntityModifier have been renamed to RawContactDeltaList and RawContactModifier with the methods using the RawContact class directly rather than the Entity class. Data items for a raw contact are represented by a DataItem object with specialized getters/setters for subclasses of DataItem. (e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper around ContentValues. This abstracts away the ContactsContract column fields into getters/setters. The above refactoring is accompanied with changes throughout the codebase to use the new Contact, RawContact, and DataItem classes. Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/editor/AggregationSuggestionEngine.java
|
e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix. Changed import order to be in accordance with style guide: http://source.android.com/source/code-style.html#order-import-statements Static imports will be placed at the top since most existing files used that convention. It is also a style that can be handled by both eclipse and intellij. Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/editor/AggregationSuggestionEngine.java
|
3e435f0e724cb3e88efce15f760e59b9bc08f0d3 |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Change usages of com.google.android to com.google.common. The people app contains usages of both com.google.android and com.google.common. Changing code to use the later guava library since it will be needed to unbundle the app in the future. Change-Id: I2700126e020166ea1bbbd87c40e77428efde41f3
/packages/apps/Contacts/src/com/android/contacts/editor/AggregationSuggestionEngine.java
|
2828c48cc4537fe981918f80297d5408bedc87b5 |
|
28-Apr-2012 |
Makoto Onuki <omakoto@google.com> |
Prevent passing null context to AggregationSuggestionEngine The monkey crash suggests we're creating this object when getActivity() returns null, meaning after the fragment is destroyed. I couldn't really find any path that could cause it, but let's make sure we'll never pass null. Bug 6340106 Change-Id: I38091b46a99821065e248c811ed2f974f2f47152
/packages/apps/Contacts/src/com/android/contacts/editor/AggregationSuggestionEngine.java
|
2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc |
|
27-Jul-2011 |
Dave Santoro <dsantoro@google.com> |
App changes for account types with data sets. This is primarily a replacement of the Android Account object in most parts of the app with a new AccountWithDataSet object that extends Account (by adding an additional attribute, the data set). This also includes a major refactoring of the AccountTypeManager, both to allow it to handle data sets and to allow for non-sync-adapter packages to be referenced by the sync adapters for an account and registered as sources of contact data. Attributes of the sync adapter that would typically come from the authenticator can be parsed out of the Contacts XML for these packages. Bug 5077096 Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
/packages/apps/Contacts/src/com/android/contacts/editor/AggregationSuggestionEngine.java
|
d52121b61b71230d0f695f9d3891eaf0cbb7c549 |
|
10-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Making aggregation suggestion engine listen to data changes If a sync brings up a good suggestion while we are editing the contact, it should show up. Bug: 3184559 Change-Id: I0b14dc689cba2780d1a531b53d1e545b22e5570b
/packages/apps/Contacts/src/com/android/contacts/editor/AggregationSuggestionEngine.java
|
18ffaa2561cc7dd2e3ef81737e6537931c0a9a11 |
|
03-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming a couple of packages Change-Id: I2c0f86b51baa622df629206f8b79ef1d0df09119
/packages/apps/Contacts/src/com/android/contacts/editor/AggregationSuggestionEngine.java
|