History log of /system/media/camera/src/camera_metadata.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
3064d31f5401b1727bf4c94b55d230615918ea9b 15-Jul-2013 Zhijun He <zhijunhe@google.com> Camera: Metadata: clear metadata buffer entry before values are assigned

To avoid inconsistent state of metadata buffer entry when the entry count is 0.

Bug: 9529161

Change-Id: Ic3fa4b39457142b8bec61d0625d04672b51890b7
/system/media/camera/src/camera_metadata.c
d1cecc16420d1e210b0643530e552e3427b2bab2 01-May-2013 Igor Murashkin <iam@google.com> camera_metadata: add validation function to ensure structural sanity

This is particularly useful when accepting copied metadata from another process,
since it could put whatever it want into the binder parcel.

Bug: 8713951
Change-Id: I72b25b2bf96230eb995bb32e3bbd68de16e122cd
/system/media/camera/src/camera_metadata.c
375cfd3889aa72160273af802370c8f47f5c64d1 03-Dec-2012 Igor Murashkin <iam@google.com> Camera2: Dump enum data types as strings, not integers

Change-Id: Ia225662d4ee0aad81b22b96355d7f39c4aa70d42
/system/media/camera/src/camera_metadata.c
555aac882ed63e70019c78ccc58032a5be0f58ec 15-Nov-2012 Igor Murashkin <iam@google.com> Camera2: Fix metadata alignment for double and int64 types

* camera_metadata_rational_t was only aligning to 4 bytes, we need to align to 8
* add an automated unit test to verify alignment for each type of data

Bug: 7498597
Change-Id: Ib5554d412e09b95d21933b6015db68d01a072f90
/system/media/camera/src/camera_metadata.c
b10d56ad43a91924d3666127963e5fdce725389c 13-Nov-2012 Eino-Ville Talvala <etalvala@google.com> Camera: Actually make camera_metadata memcopyable

- Use internal offsets instead of pointers for the entry and data
arrays.
- Add test to verify memcpy works and doesn't alias data.
- Remove support for forward-compatible reserved space handling, given
that it's unlikely to be useful

Bug: 7546079
Change-Id: I439aa27fed8d243b7a04155daf5e58fa1c4c730e
/system/media/camera/src/camera_metadata.c
3154036acd2cc809388d08ff856198a8512f05f0 08-Nov-2012 Eino-Ville Talvala <etalvala@google.com> Camera: Fix metadata data alignment, other minor bugs.

- When a metadata entry needs to overflow into the data buffer, make
sure the starting offset is aligned to the maximum needed by all the
metadata types.
- Bounds check the data buffer size when adding a new entry
- Add new test for the bounds check
- Print out doubles correctly.

Bug: 7498597

Change-Id: Ic8645a998c096f5b803839ee8076b97862127021
/system/media/camera/src/camera_metadata.c
94879bd88f7ac3f2f678221497b8ad50c0bb3314 02-Oct-2012 Eino-Ville Talvala <etalvala@google.com> Camera: Add scene mode override and quirks fields.

To provide scene mode override information while preview is disabled,
need more static metadata from the HAL.

In addition, add a quirks section to allow for temporary workarounds
for incomplete HAL behavior. Any quirks added will be deprecated as
soon as possible.

Bug: 7159577
Bug: 7172543
Change-Id: Icadb6baa4132bf20ad82b2c549ac2b9a0c6618de
/system/media/camera/src/camera_metadata.c
2f4aca6526bbbaa9069f2683cdc60c0453a22055 24-Aug-2012 Eino-Ville Talvala <etalvala@google.com> Camera: Add methods for read-only access to metadata.

- Define a read-only version of camera_metadata_entry_t
- Support finding with read-only output
- Add const to clone method input camera_metadata_t.

Bug: 6243944
Change-Id: I1bf37a4c8c8935711e803d7477393fe2c01f8216
/system/media/camera/src/camera_metadata.c
2cae02cd02ea0b5d04268621616d386c9d5261c6 26-Aug-2012 Eino-Ville Talvala <etalvala@google.com> Revert "Camera: Add methods for read-only access to metadata."

Needs a third change that's not yet done with review.

This reverts commit ad0c0c836d0276079bf8fe1bfb0bef25d4bce601

Change-Id: Id4325fe93b43a447eded5ae50e8f7faa70fd9140
/system/media/camera/src/camera_metadata.c
ad0c0c836d0276079bf8fe1bfb0bef25d4bce601 24-Aug-2012 Eino-Ville Talvala <etalvala@google.com> Camera: Add methods for read-only access to metadata.

- Define a read-only version of camera_metadata_entry_t
- Support finding with read-only output
- Add const to clone method input camera_metadata_t.

Bug: 6243944
Change-Id: Icd581e48f5fafaa6da22ca25e872bf3ede192222
/system/media/camera/src/camera_metadata.c
1d27e5b8a575620bb64406289c7c229662de92ca 30-Jul-2012 Eino-Ville Talvala <etalvala@google.com> Camera: Add indented metadata dump

Bug: 6243944
Change-Id: Ib769ae2d40b9c4bfa456c812fd7ee2e426fd86df
/system/media/camera/src/camera_metadata.c
fd2588282491637c61ba828eeb69c9486d8aaeab 07-Jun-2012 Eino-Ville Talvala <etalvala@google.com> Camera: Add clone buffer, make type names public

Clone metadata buffer allows for straightforward duplication of
existing buffers; type names are useful for debugging code.

Bug: 6243944
Change-Id: Ibf70f4e3bcf49d6c772bba18a577e2673f2b9213
/system/media/camera/src/camera_metadata.c
98d02fd0be8cd09479262959a542dd2620bf6074 21-May-2012 Eino-Ville Talvala <etalvala@google.com> Camera: Add opaque user pointer to camera metadata buffer

This is useful for associating a metadata buffer handed off to a third
party with its parent object, when the buffer is returned.

Change-Id: I7e19708bb3adf4da26fc6101e78c276477276608
/system/media/camera/src/camera_metadata.c
f5fb8a5516876c5a48cc44b4f1c99504e0b9f245 10-May-2012 Eino-Ville Talvala <etalvala@google.com> Improvements to camera metadata handling.

- Cleaner interface to get/find
- Adds delete entry, an expensive O(n) operation
- Adds update entry, which is O(n) sometimes
- Minor bugfixes:
- Keep sorted state when appending empty buffers
- Misspelling of camera_metadata_type_size in header
- Missing entry in type name array

Bug: 6243944
Change-Id: I316507d6adcc22aff6e7c464c6c484f31ef1510d
/system/media/camera/src/camera_metadata.c
623ff65afea34612498dcf33887ffaf8b194c281 12-Apr-2012 Eino-Ville Talvala <etalvala@google.com> Make camera metadata tag definitions more robust to mismatches.

Use array assignment-by-index syntax to make sure we match the desired
index to the entry, so it's easier to keep the metadata header and the
info structures in sync.

Change-Id: I06d1ea3d52c651b447cc167cd551e907c8e001ab
/system/media/camera/src/camera_metadata.c
94c1901a96c268f55012809f8261f2ec89c16dea 05-Apr-2012 Eino-Ville Talvala <etalvala@google.com> Improvements to the camera metadata structure

- Add vendor_tag_query_ops_t as argument to methods inside it.

- Add version and flags fields

- Add sorted flag; additions and appends are not sorted, and thus
reset the flag.

- Add sort method, which sets the sorted flag.

- Add find-by-tag method, which uses a linear search on a non-sorted
buffer, and a binary search on a sorted buffer.

- Change dump method to take in a fd, like the HAL-level dump methods
do.

- Minor revisions to tag definitions, including a few enums for
enumerated-value tags.

Change-Id: I5f37e326519bda032cb3362da4ab3bf50eb98b4e
/system/media/camera/src/camera_metadata.c
d8afb4d1a4245b2a9d722cbb358a4d6febed89cf 10-Feb-2012 Eino-Ville Talvala <etalvala@google.com> Add a camera metadata structure and utility methods

Change-Id: I320cc33f31ebd8ce183572a447df8fae691eec0d
/system/media/camera/src/camera_metadata.c