SemaChecking.cpp revision b61c294a24324ca0a403df770c01e0ba0b88770b
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 1659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 17199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 18384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 19c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 2055fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/EvaluatedExprVisitor.h" 21be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie#include "clang/AST/Expr.h" 222324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 237ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 24f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 25f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 2655fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Analysis/Analyses/FormatString.h" 273f6f51e28231f65de9c2dd150a2d757b2162cfa3Jordan Rose#include "clang/Basic/CharInfo.h" 2855fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Basic/TargetBuiltins.h" 2955fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Basic/TargetInfo.h" 3059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 3155fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Initialization.h" 3255fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Lookup.h" 3355fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/ScopeInfo.h" 3455fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Sema.h" 35f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 36f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 3755fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "llvm/ADT/SmallString.h" 38cb5620c9b213f4bd323912159fdddda35e258a14Dmitri Gribenko#include "llvm/Support/ConvertUTF.h" 393bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 40a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 4159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 42781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4460800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4608f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 474e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie PP.getLangOpts(), PP.getTargetInfo()); 4860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 508e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 518e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 528e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 538e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 588e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 70e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// Check that the first argument to __builtin_annotation is an integer 71e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// and the second argument is a non-wide string literal. 72e59392176c2369df2bdd11b7786cb38abac00198Julien Lerougestatic bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) { 73e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (checkArgCount(S, TheCall, 2)) 74e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 75e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 76e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // First argument should be an integer. 77e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *ValArg = TheCall->getArg(0); 78e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge QualType Ty = ValArg->getType(); 79e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (!Ty->isIntegerType()) { 80e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg) 81e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << ValArg->getSourceRange(); 82e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 83e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge } 84e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 85e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // Second argument should be a constant string. 86e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts(); 87e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg); 8877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (!Literal || !Literal->isAscii()) { 89e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg) 90e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << StrArg->getSourceRange(); 9177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return true; 9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge } 93e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 94e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge TheCall->setType(Ty); 9577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return false; 9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge} 9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge 985154dce6388e3aaa445467030df7a45ed1211abeRichard Smith/// Check that the argument to __builtin_addressof is a glvalue, and set the 995154dce6388e3aaa445467030df7a45ed1211abeRichard Smith/// result type to the corresponding pointer type. 1005154dce6388e3aaa445467030df7a45ed1211abeRichard Smithstatic bool SemaBuiltinAddressof(Sema &S, CallExpr *TheCall) { 1015154dce6388e3aaa445467030df7a45ed1211abeRichard Smith if (checkArgCount(S, TheCall, 1)) 1025154dce6388e3aaa445467030df7a45ed1211abeRichard Smith return true; 1035154dce6388e3aaa445467030df7a45ed1211abeRichard Smith 1045154dce6388e3aaa445467030df7a45ed1211abeRichard Smith ExprResult Arg(S.Owned(TheCall->getArg(0))); 1055154dce6388e3aaa445467030df7a45ed1211abeRichard Smith QualType ResultType = S.CheckAddressOfOperand(Arg, TheCall->getLocStart()); 1065154dce6388e3aaa445467030df7a45ed1211abeRichard Smith if (ResultType.isNull()) 1075154dce6388e3aaa445467030df7a45ed1211abeRichard Smith return true; 1085154dce6388e3aaa445467030df7a45ed1211abeRichard Smith 1095154dce6388e3aaa445467030df7a45ed1211abeRichard Smith TheCall->setArg(0, Arg.take()); 1105154dce6388e3aaa445467030df7a45ed1211abeRichard Smith TheCall->setType(ResultType); 1115154dce6388e3aaa445467030df7a45ed1211abeRichard Smith return false; 1125154dce6388e3aaa445467030df7a45ed1211abeRichard Smith} 1135154dce6388e3aaa445467030df7a45ed1211abeRichard Smith 11460d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 115d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 11660d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 1172def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 120946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 121946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 122946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 123946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 124946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 125946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 126946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 127946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 128946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 129946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 130946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 131946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 132946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 133946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 134946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 135946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 136d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 13730ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 138925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1391b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 140690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1410eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 142d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 14349ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 14430ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1450eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1460eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 147d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1481b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1491b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1501b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1511b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1521b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1531b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1540eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1550eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 156d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 157e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 158e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 159e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 160e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1619ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1629ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1639ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1649ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1659ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1663b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1679ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1689ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 169d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1700eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1710eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1720eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1734493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1740eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1750eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 176d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 177d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1780eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1790eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 180d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 181d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 182d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 183d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 184d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1858e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1868e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1878e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1888e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1898e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 19075c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1918e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1928e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 19375c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 197a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 2005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 202a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 203a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 204a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 2065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 208a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 209a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 2125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 214a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 215a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 216a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 2185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 220a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 221a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 2245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 226a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 227a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 2305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 233a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 2365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 238a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 239a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 2425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 244a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 245a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 246a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 2485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 250a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 251a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 2545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 256a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 257a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 258a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 259a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 2605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 261a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 262a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 263a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 264a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 265a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 2665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 267a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 268a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 269a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 270a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 271a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 2725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 273a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 274a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 275a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 276a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 277a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 27823aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 279a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 280a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 281a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 282a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 283a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 2843fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaBuiltinAtomicOverloaded(TheCallResult); 285ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define BUILTIN(ID, TYPE, ATTRS) 286ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \ 287ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Builtin::BI##ID: \ 2883fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID); 289ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#include "clang/Basic/Builtins.def" 29077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge case Builtin::BI__builtin_annotation: 291e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (SemaBuiltinAnnotation(*this, TheCall)) 29277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return ExprError(); 29377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge break; 2945154dce6388e3aaa445467030df7a45ed1211abeRichard Smith case Builtin::BI__builtin_addressof: 2955154dce6388e3aaa445467030df7a45ed1211abeRichard Smith if (SemaBuiltinAddressof(*this, TheCall)) 2965154dce6388e3aaa445467030df7a45ed1211abeRichard Smith return ExprError(); 2975154dce6388e3aaa445467030df7a45ed1211abeRichard Smith break; 29826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 29926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 30026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 30126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 30226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 303bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor switch (Context.getTargetInfo().getTriple().getArch()) { 30426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 30526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 30626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 30726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 30826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 309b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover case llvm::Triple::aarch64: 310b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover if (CheckAArch64BuiltinFunctionCall(BuiltinID, TheCall)) 311b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover return ExprError(); 312b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover break; 313fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips: 314fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mipsel: 315fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64: 316fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64el: 317fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall)) 318fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return ExprError(); 319fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan break; 32026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 32126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 32226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 32326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 32426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 3253fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 32626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 32726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 32861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 32961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 330da95f73b59f9af964e33725c515139d34c90c863Bob Wilson NeonTypeFlags Type(t); 331da95f73b59f9af964e33725c515139d34c90c863Bob Wilson int IsQuad = Type.isQuad(); 332da95f73b59f9af964e33725c515139d34c90c863Bob Wilson switch (Type.getEltType()) { 333da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int8: 334da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly8: 335da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 7 : (8 << IsQuad) - 1; 336da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int16: 337da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly16: 338da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 15 : (4 << IsQuad) - 1; 339da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int32: 340da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 31 : (2 << IsQuad) - 1; 341da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int64: 342da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 63 : (1 << IsQuad) - 1; 343da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float16: 344da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 345da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (4 << IsQuad) - 1; 346da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float32: 347da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 348da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (2 << IsQuad) - 1; 349b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover case NeonTypeFlags::Float64: 350b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover assert(!shift && "cannot shift float types!"); 351b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover return (1 << IsQuad) - 1; 35261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 3537530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 35461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 35561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 3566f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of 3576f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags. This is used to check 3586f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics. 3596f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) { 3606f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson switch (Flags.getEltType()) { 3616f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int8: 3626f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy; 3636f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int16: 3646f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy; 3656f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int32: 3666f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy; 3676f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int64: 3686f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy; 3696f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly8: 3706f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.SignedCharTy; 3716f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly16: 3726f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.ShortTy; 3736f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float16: 3746f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.UnsignedShortTy; 3756f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float32: 3766f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.FloatTy; 377b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover case NeonTypeFlags::Float64: 378b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover return Context.DoubleTy; 3796f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3807530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 3816f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson} 3826f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 383b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northoverbool Sema::CheckAArch64BuiltinFunctionCall(unsigned BuiltinID, 384b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover CallExpr *TheCall) { 385b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover 386b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover llvm::APSInt Result; 387b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover 388b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover uint64_t mask = 0; 389b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover unsigned TV = 0; 390b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover int PtrArgNum = -1; 391b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover bool HasConstPtr = false; 392b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover switch (BuiltinID) { 393b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover#define GET_NEON_AARCH64_OVERLOAD_CHECK 394b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover#include "clang/Basic/arm_neon.inc" 395b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover#undef GET_NEON_AARCH64_OVERLOAD_CHECK 396b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover } 397b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover 398b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover // For NEON intrinsics which are overloaded on vector element type, validate 399b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover // the immediate which specifies which variant to emit. 400b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover unsigned ImmArg = TheCall->getNumArgs() - 1; 401b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover if (mask) { 402b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 403b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover return true; 404b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover 405b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover TV = Result.getLimitedValue(64); 406b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover if ((TV > 63) || (mask & (1ULL << TV)) == 0) 407b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 408b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover << TheCall->getArg(ImmArg)->getSourceRange(); 409b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover } 410b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover 411b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover if (PtrArgNum >= 0) { 412b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover // Check that pointer arguments have the specified type. 413b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover Expr *Arg = TheCall->getArg(PtrArgNum); 414b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 415b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover Arg = ICE->getSubExpr(); 416b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 417b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover QualType RHSTy = RHS.get()->getType(); 418b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context); 419b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover if (HasConstPtr) 420b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover EltTy = EltTy.withConst(); 421b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover QualType LHSTy = Context.getPointerType(EltTy); 422b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover AssignConvertType ConvTy; 423b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 424b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover if (RHS.isInvalid()) 425b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover return true; 426b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 427b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover RHS.get(), AA_Assigning)) 428b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover return true; 429b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover } 430b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover 431b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover // For NEON intrinsics which take an immediate value as part of the 432b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover // instruction, range check them here. 433b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover unsigned i = 0, l = 0, u = 0; 434b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover switch (BuiltinID) { 435b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover default: 436b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover return false; 437b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover#define GET_NEON_AARCH64_IMMEDIATE_CHECK 438b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover#include "clang/Basic/arm_neon.inc" 439b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover#undef GET_NEON_AARCH64_IMMEDIATE_CHECK 440b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover } 441b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover ; 442b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover 443b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover // We can't check the value of a dependent argument. 444b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover if (TheCall->getArg(i)->isTypeDependent() || 445b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover TheCall->getArg(i)->isValueDependent()) 446b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover return false; 447b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover 448b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover // Check that the immediate argument is actually a constant. 449b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover if (SemaBuiltinConstantArg(TheCall, i, Result)) 450b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover return true; 451b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover 452b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover // Range check against the upper/lower values for this isntruction. 453b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover unsigned Val = Result.getZExtValue(); 454b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover if (Val < l || Val > (u + l)) 455b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 456b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover << l << u + l << TheCall->getArg(i)->getSourceRange(); 457b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover 458b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover return false; 459b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover} 460b793f0d3448a15277cd6b6cc4ba558ded39a8084Tim Northover 46109df2b066221d869f17f4b5762405f111a65f983Tim Northoverbool Sema::CheckARMBuiltinExclusiveCall(unsigned BuiltinID, CallExpr *TheCall) { 46209df2b066221d869f17f4b5762405f111a65f983Tim Northover assert((BuiltinID == ARM::BI__builtin_arm_ldrex || 46309df2b066221d869f17f4b5762405f111a65f983Tim Northover BuiltinID == ARM::BI__builtin_arm_strex) && 46409df2b066221d869f17f4b5762405f111a65f983Tim Northover "unexpected ARM builtin"); 46509df2b066221d869f17f4b5762405f111a65f983Tim Northover bool IsLdrex = BuiltinID == ARM::BI__builtin_arm_ldrex; 46609df2b066221d869f17f4b5762405f111a65f983Tim Northover 46709df2b066221d869f17f4b5762405f111a65f983Tim Northover DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 46809df2b066221d869f17f4b5762405f111a65f983Tim Northover 46909df2b066221d869f17f4b5762405f111a65f983Tim Northover // Ensure that we have the proper number of arguments. 47009df2b066221d869f17f4b5762405f111a65f983Tim Northover if (checkArgCount(*this, TheCall, IsLdrex ? 1 : 2)) 47109df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 47209df2b066221d869f17f4b5762405f111a65f983Tim Northover 47309df2b066221d869f17f4b5762405f111a65f983Tim Northover // Inspect the pointer argument of the atomic builtin. This should always be 47409df2b066221d869f17f4b5762405f111a65f983Tim Northover // a pointer type, whose element is an integral scalar or pointer type. 47509df2b066221d869f17f4b5762405f111a65f983Tim Northover // Because it is a pointer type, we don't have to worry about any implicit 47609df2b066221d869f17f4b5762405f111a65f983Tim Northover // casts here. 47709df2b066221d869f17f4b5762405f111a65f983Tim Northover Expr *PointerArg = TheCall->getArg(IsLdrex ? 0 : 1); 47809df2b066221d869f17f4b5762405f111a65f983Tim Northover ExprResult PointerArgRes = DefaultFunctionArrayLvalueConversion(PointerArg); 47909df2b066221d869f17f4b5762405f111a65f983Tim Northover if (PointerArgRes.isInvalid()) 48009df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 48109df2b066221d869f17f4b5762405f111a65f983Tim Northover PointerArg = PointerArgRes.take(); 48209df2b066221d869f17f4b5762405f111a65f983Tim Northover 48309df2b066221d869f17f4b5762405f111a65f983Tim Northover const PointerType *pointerType = PointerArg->getType()->getAs<PointerType>(); 48409df2b066221d869f17f4b5762405f111a65f983Tim Northover if (!pointerType) { 48509df2b066221d869f17f4b5762405f111a65f983Tim Northover Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 48609df2b066221d869f17f4b5762405f111a65f983Tim Northover << PointerArg->getType() << PointerArg->getSourceRange(); 48709df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 48809df2b066221d869f17f4b5762405f111a65f983Tim Northover } 48909df2b066221d869f17f4b5762405f111a65f983Tim Northover 49009df2b066221d869f17f4b5762405f111a65f983Tim Northover // ldrex takes a "const volatile T*" and strex takes a "volatile T*". Our next 49109df2b066221d869f17f4b5762405f111a65f983Tim Northover // task is to insert the appropriate casts into the AST. First work out just 49209df2b066221d869f17f4b5762405f111a65f983Tim Northover // what the appropriate type is. 49309df2b066221d869f17f4b5762405f111a65f983Tim Northover QualType ValType = pointerType->getPointeeType(); 49409df2b066221d869f17f4b5762405f111a65f983Tim Northover QualType AddrType = ValType.getUnqualifiedType().withVolatile(); 49509df2b066221d869f17f4b5762405f111a65f983Tim Northover if (IsLdrex) 49609df2b066221d869f17f4b5762405f111a65f983Tim Northover AddrType.addConst(); 49709df2b066221d869f17f4b5762405f111a65f983Tim Northover 49809df2b066221d869f17f4b5762405f111a65f983Tim Northover // Issue a warning if the cast is dodgy. 49909df2b066221d869f17f4b5762405f111a65f983Tim Northover CastKind CastNeeded = CK_NoOp; 50009df2b066221d869f17f4b5762405f111a65f983Tim Northover if (!AddrType.isAtLeastAsQualifiedAs(ValType)) { 50109df2b066221d869f17f4b5762405f111a65f983Tim Northover CastNeeded = CK_BitCast; 50209df2b066221d869f17f4b5762405f111a65f983Tim Northover Diag(DRE->getLocStart(), diag::ext_typecheck_convert_discards_qualifiers) 50309df2b066221d869f17f4b5762405f111a65f983Tim Northover << PointerArg->getType() 50409df2b066221d869f17f4b5762405f111a65f983Tim Northover << Context.getPointerType(AddrType) 50509df2b066221d869f17f4b5762405f111a65f983Tim Northover << AA_Passing << PointerArg->getSourceRange(); 50609df2b066221d869f17f4b5762405f111a65f983Tim Northover } 50709df2b066221d869f17f4b5762405f111a65f983Tim Northover 50809df2b066221d869f17f4b5762405f111a65f983Tim Northover // Finally, do the cast and replace the argument with the corrected version. 50909df2b066221d869f17f4b5762405f111a65f983Tim Northover AddrType = Context.getPointerType(AddrType); 51009df2b066221d869f17f4b5762405f111a65f983Tim Northover PointerArgRes = ImpCastExprToType(PointerArg, AddrType, CastNeeded); 51109df2b066221d869f17f4b5762405f111a65f983Tim Northover if (PointerArgRes.isInvalid()) 51209df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 51309df2b066221d869f17f4b5762405f111a65f983Tim Northover PointerArg = PointerArgRes.take(); 51409df2b066221d869f17f4b5762405f111a65f983Tim Northover 51509df2b066221d869f17f4b5762405f111a65f983Tim Northover TheCall->setArg(IsLdrex ? 0 : 1, PointerArg); 51609df2b066221d869f17f4b5762405f111a65f983Tim Northover 51709df2b066221d869f17f4b5762405f111a65f983Tim Northover // In general, we allow ints, floats and pointers to be loaded and stored. 51809df2b066221d869f17f4b5762405f111a65f983Tim Northover if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 51909df2b066221d869f17f4b5762405f111a65f983Tim Northover !ValType->isBlockPointerType() && !ValType->isFloatingType()) { 52009df2b066221d869f17f4b5762405f111a65f983Tim Northover Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intfltptr) 52109df2b066221d869f17f4b5762405f111a65f983Tim Northover << PointerArg->getType() << PointerArg->getSourceRange(); 52209df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 52309df2b066221d869f17f4b5762405f111a65f983Tim Northover } 52409df2b066221d869f17f4b5762405f111a65f983Tim Northover 52509df2b066221d869f17f4b5762405f111a65f983Tim Northover // But ARM doesn't have instructions to deal with 128-bit versions. 52609df2b066221d869f17f4b5762405f111a65f983Tim Northover if (Context.getTypeSize(ValType) > 64) { 52709df2b066221d869f17f4b5762405f111a65f983Tim Northover Diag(DRE->getLocStart(), diag::err_atomic_exclusive_builtin_pointer_size) 52809df2b066221d869f17f4b5762405f111a65f983Tim Northover << PointerArg->getType() << PointerArg->getSourceRange(); 52909df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 53009df2b066221d869f17f4b5762405f111a65f983Tim Northover } 53109df2b066221d869f17f4b5762405f111a65f983Tim Northover 53209df2b066221d869f17f4b5762405f111a65f983Tim Northover switch (ValType.getObjCLifetime()) { 53309df2b066221d869f17f4b5762405f111a65f983Tim Northover case Qualifiers::OCL_None: 53409df2b066221d869f17f4b5762405f111a65f983Tim Northover case Qualifiers::OCL_ExplicitNone: 53509df2b066221d869f17f4b5762405f111a65f983Tim Northover // okay 53609df2b066221d869f17f4b5762405f111a65f983Tim Northover break; 53709df2b066221d869f17f4b5762405f111a65f983Tim Northover 53809df2b066221d869f17f4b5762405f111a65f983Tim Northover case Qualifiers::OCL_Weak: 53909df2b066221d869f17f4b5762405f111a65f983Tim Northover case Qualifiers::OCL_Strong: 54009df2b066221d869f17f4b5762405f111a65f983Tim Northover case Qualifiers::OCL_Autoreleasing: 54109df2b066221d869f17f4b5762405f111a65f983Tim Northover Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 54209df2b066221d869f17f4b5762405f111a65f983Tim Northover << ValType << PointerArg->getSourceRange(); 54309df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 54409df2b066221d869f17f4b5762405f111a65f983Tim Northover } 54509df2b066221d869f17f4b5762405f111a65f983Tim Northover 54609df2b066221d869f17f4b5762405f111a65f983Tim Northover 54709df2b066221d869f17f4b5762405f111a65f983Tim Northover if (IsLdrex) { 54809df2b066221d869f17f4b5762405f111a65f983Tim Northover TheCall->setType(ValType); 54909df2b066221d869f17f4b5762405f111a65f983Tim Northover return false; 55009df2b066221d869f17f4b5762405f111a65f983Tim Northover } 55109df2b066221d869f17f4b5762405f111a65f983Tim Northover 55209df2b066221d869f17f4b5762405f111a65f983Tim Northover // Initialize the argument to be stored. 55309df2b066221d869f17f4b5762405f111a65f983Tim Northover ExprResult ValArg = TheCall->getArg(0); 55409df2b066221d869f17f4b5762405f111a65f983Tim Northover InitializedEntity Entity = InitializedEntity::InitializeParameter( 55509df2b066221d869f17f4b5762405f111a65f983Tim Northover Context, ValType, /*consume*/ false); 55609df2b066221d869f17f4b5762405f111a65f983Tim Northover ValArg = PerformCopyInitialization(Entity, SourceLocation(), ValArg); 55709df2b066221d869f17f4b5762405f111a65f983Tim Northover if (ValArg.isInvalid()) 55809df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 55909df2b066221d869f17f4b5762405f111a65f983Tim Northover 56009df2b066221d869f17f4b5762405f111a65f983Tim Northover TheCall->setArg(0, ValArg.get()); 56109df2b066221d869f17f4b5762405f111a65f983Tim Northover return false; 56209df2b066221d869f17f4b5762405f111a65f983Tim Northover} 56309df2b066221d869f17f4b5762405f111a65f983Tim Northover 56426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 5651c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 5661c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 56709df2b066221d869f17f4b5762405f111a65f983Tim Northover if (BuiltinID == ARM::BI__builtin_arm_ldrex || 56809df2b066221d869f17f4b5762405f111a65f983Tim Northover BuiltinID == ARM::BI__builtin_arm_strex) { 56909df2b066221d869f17f4b5762405f111a65f983Tim Northover return CheckARMBuiltinExclusiveCall(BuiltinID, TheCall); 57009df2b066221d869f17f4b5762405f111a65f983Tim Northover } 57109df2b066221d869f17f4b5762405f111a65f983Tim Northover 572f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith uint64_t mask = 0; 57361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 5744648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson int PtrArgNum = -1; 5756f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson bool HasConstPtr = false; 5761c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 577a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 578a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 579a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 5801c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 5811c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 5820d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 5830d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 5846f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson unsigned ImmArg = TheCall->getNumArgs()-1; 5850d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 5866f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 5870d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 5880d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 589da95f73b59f9af964e33725c515139d34c90c863Bob Wilson TV = Result.getLimitedValue(64); 590f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith if ((TV > 63) || (mask & (1ULL << TV)) == 0) 5910d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 5926f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson << TheCall->getArg(ImmArg)->getSourceRange(); 5936f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 5946f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 5954648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (PtrArgNum >= 0) { 5966f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson // Check that pointer arguments have the specified type. 5974648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Expr *Arg = TheCall->getArg(PtrArgNum); 5984648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 5994648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Arg = ICE->getSubExpr(); 6004648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 6014648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType RHSTy = RHS.get()->getType(); 6024648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context); 6034648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (HasConstPtr) 6044648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson EltTy = EltTy.withConst(); 6054648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType LHSTy = Context.getPointerType(EltTy); 6064648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson AssignConvertType ConvTy; 6074648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 6084648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (RHS.isInvalid()) 6094648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 6104648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 6114648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson RHS.get(), AA_Assigning)) 6124648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 6130d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 6141c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 6150d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 6160d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 61761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 6180d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 6190d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 620bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 621bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 62299c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 62399c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 624a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 625a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 626a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 6270d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 6280d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 629592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 630592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 631592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(i)->isValueDependent()) 632592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 633592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 63461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 6350d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 6360d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 6370d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 63861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 6390d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 64061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 6410d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 642476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 6430d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 64499c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 64526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 646d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 647d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 648fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyanbool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 649fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned i = 0, l = 0, u = 0; 650fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan switch (BuiltinID) { 651fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan default: return false; 652fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break; 653fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break; 654be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break; 655be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break; 656be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break; 657be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break; 658be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break; 659fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan }; 660fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 661fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // We can't check the value of a dependent argument. 662fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (TheCall->getArg(i)->isTypeDependent() || 663fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan TheCall->getArg(i)->isValueDependent()) 664fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 665fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 666fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Check that the immediate argument is actually a constant. 667fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan llvm::APSInt Result; 668fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (SemaBuiltinConstantArg(TheCall, i, Result)) 669fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return true; 670fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 671fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Range check against the upper/lower values for this instruction. 672fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned Val = Result.getZExtValue(); 673fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (Val < l || Val > u) 674fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 675fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan << l << u << TheCall->getArg(i)->getSourceRange(); 676fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 677fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 678fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan} 679fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 680831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo 681831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// parameter with the FormatAttr's correct format_idx and firstDataArg. 682831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true when the format fits the function and the FormatStringInfo has 683831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// been populated. 684831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember, 685831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo *FSI) { 686831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->HasVAListArg = Format->getFirstArg() == 0; 687831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FormatIdx = Format->getFormatIdx() - 1; 688831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1; 689de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 690831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The way the format attribute works in GCC, the implicit this argument 691831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // of member functions is counted. However, it doesn't appear in our own 692831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // lists, so decrement format_idx in that case. 693831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (IsCXXMember) { 694831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if(FSI->FormatIdx == 0) 695831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 696831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FormatIdx; 697831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (FSI->FirstDataArg != 0) 698831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FirstDataArg; 699831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 700831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 701831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 7021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 703831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Handles the checks for format strings, non-POD arguments to vararg 704831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// functions, and NULL arguments passed to non-NULL parameters. 7051c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkovoid Sema::checkCall(NamedDecl *FDecl, 7061c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 707831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs, 708831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool IsMemberFunction, 709831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc, 710831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceRange Range, 711831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType) { 71266360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose if (CurContext->isDependentContext()) 71366360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose return; 714de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 715c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 716831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool HandledFormatString = false; 7170538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu if (FDecl) 7180538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu for (specific_attr_iterator<FormatAttr> 7190538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu I = FDecl->specific_attr_begin<FormatAttr>(), 7200538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu E = FDecl->specific_attr_end<FormatAttr>(); I != E ; ++I) 7210538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu if (CheckFormatArguments(*I, Args, IsMemberFunction, CallType, Loc, 7220538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu Range)) 7230538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu HandledFormatString = true; 724831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 725831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Refuse POD arguments that weren't caught by the format string 726831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // checks above. 727831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!HandledFormatString && CallType != VariadicDoesNotApply) 7281c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko for (unsigned ArgIdx = NumProtoArgs; ArgIdx < Args.size(); ++ArgIdx) { 7290234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek // Args[ArgIdx] can be null in malformed code. 7301c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko if (const Expr *Arg = Args[ArgIdx]) 7310234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek variadicArgumentPODCheck(Arg, CallType); 7320234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek } 7331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7340538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu if (FDecl) { 7350538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu for (specific_attr_iterator<NonNullAttr> 7360538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu I = FDecl->specific_attr_begin<NonNullAttr>(), 7370538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu E = FDecl->specific_attr_end<NonNullAttr>(); I != E; ++I) 7380538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu CheckNonNullArguments(*I, Args.data(), Loc); 7390538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 7400538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu // Type safety checking. 7410538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu for (specific_attr_iterator<ArgumentWithTypeTagAttr> 7420538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu i = FDecl->specific_attr_begin<ArgumentWithTypeTagAttr>(), 7430538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu e = FDecl->specific_attr_end<ArgumentWithTypeTagAttr>(); 7440538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu i != e; ++i) { 7450538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu CheckArgumentWithTypeTag(*i, Args.data()); 7460538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu } 7470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 748831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 749831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 750831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckConstructorCall - Check a constructor call for correctness and safety 751831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// properties not enforced by the C type system. 7521c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkovoid Sema::CheckConstructorCall(FunctionDecl *FDecl, 7531c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 754831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto, 755831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc) { 756831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 757831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply; 7581c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(FDecl, Args, Proto->getNumArgs(), 759831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/true, Loc, SourceRange(), CallType); 760831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 761831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 762831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckFunctionCall - Check a direct function call for various correctness 763831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// and safety properties not strictly enforced by the C type system. 764831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall, 765831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto) { 7662edcde8747a000113b434a5c88b4648beed4197bEli Friedman bool IsMemberOperatorCall = isa<CXXOperatorCallExpr>(TheCall) && 7672edcde8747a000113b434a5c88b4648beed4197bEli Friedman isa<CXXMethodDecl>(FDecl); 7682edcde8747a000113b434a5c88b4648beed4197bEli Friedman bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall) || 7692edcde8747a000113b434a5c88b4648beed4197bEli Friedman IsMemberOperatorCall; 770831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = getVariadicCallType(FDecl, Proto, 771831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()); 772831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 7732edcde8747a000113b434a5c88b4648beed4197bEli Friedman Expr** Args = TheCall->getArgs(); 7742edcde8747a000113b434a5c88b4648beed4197bEli Friedman unsigned NumArgs = TheCall->getNumArgs(); 775df75b0c74b277c6b46af2f9e90e13160fbc14d6fEli Friedman if (IsMemberOperatorCall) { 7762edcde8747a000113b434a5c88b4648beed4197bEli Friedman // If this is a call to a member operator, hide the first argument 7772edcde8747a000113b434a5c88b4648beed4197bEli Friedman // from checkCall. 7782edcde8747a000113b434a5c88b4648beed4197bEli Friedman // FIXME: Our choice of AST representation here is less than ideal. 7792edcde8747a000113b434a5c88b4648beed4197bEli Friedman ++Args; 7802edcde8747a000113b434a5c88b4648beed4197bEli Friedman --NumArgs; 7812edcde8747a000113b434a5c88b4648beed4197bEli Friedman } 7821c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(FDecl, llvm::makeArrayRef<const Expr *>(Args, NumArgs), 7831c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko NumProtoArgs, 784831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IsMemberFunction, TheCall->getRParenLoc(), 785831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 786831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 787831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IdentifierInfo *FnInfo = FDecl->getIdentifier(); 788831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // None of the checks below are needed for functions that don't have 789831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // simple names (e.g., C++ conversion functions). 790831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!FnInfo) 791831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 7920eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 7930a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned CMId = FDecl->getMemoryFunctionKind(); 7940a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == 0) 795d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks return false; 796bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 797d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks // Handle memory setting and copying functions. 7980a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat) 799bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 800c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (CMId == Builtin::BIstrncat) 801c36bedc90c687caa71748480c60707ea4608b092Anna Zaks CheckStrncatArguments(TheCall, FnInfo); 802d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks else 8030a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks CheckMemaccessArguments(TheCall, CMId, FnInfo); 8047ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 805d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 80671993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 80771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 80829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac, 809287f24d3991994b9a263af9e2a873f4feadfb8faDmitri Gribenko ArrayRef<const Expr *> Args) { 810831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 811831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply; 81229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 813287f24d3991994b9a263af9e2a873f4feadfb8faDmitri Gribenko checkCall(Method, Args, Method->param_size(), 814831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/false, 815831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith lbrac, Method->getSourceRange(), CallType); 81629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 81729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return false; 81829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 81929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 820f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieubool Sema::CheckPointerCall(NamedDecl *NDecl, CallExpr *TheCall, 821f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu const FunctionProtoType *Proto) { 822725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 823725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 824d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 8251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 826725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 827f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu if (!Ty->isBlockPointerType() && !Ty->isFunctionPointerType()) 828d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 8291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 830f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu VariadicCallType CallType; 831a4993778f65212f01168c857cf3043e99ba85c9fRichard Trieu if (!Proto || !Proto->isVariadic()) { 832f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu CallType = VariadicDoesNotApply; 833f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu } else if (Ty->isBlockPointerType()) { 834f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu CallType = VariadicBlock; 835f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu } else { // Ty->isFunctionPointerType() 836f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu CallType = VariadicFunction; 837f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu } 838831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 839d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 8401c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(NDecl, 8411c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko llvm::makeArrayRef<const Expr *>(TheCall->getArgs(), 8421c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko TheCall->getNumArgs()), 843831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NumProtoArgs, /*IsMemberFunction=*/false, 844831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getRParenLoc(), 845831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 846831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 847d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 848725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 849725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 8500538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu/// Checks function calls when a FunctionDecl or a NamedDecl is not available, 8510538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu/// such as function pointers returned from functions. 8520538f0e9200df56974b5a71bc276dbce456e9781Richard Trieubool Sema::CheckOtherCall(CallExpr *TheCall, const FunctionProtoType *Proto) { 8530538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu VariadicCallType CallType = getVariadicCallType(/*FDecl=*/0, Proto, 8540538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getCallee()); 8550538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 8560538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 8570538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu checkCall(/*FDecl=*/0, 8580538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu llvm::makeArrayRef<const Expr *>(TheCall->getArgs(), 8590538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getNumArgs()), 8600538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu NumProtoArgs, /*IsMemberFunction=*/false, 8610538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getRParenLoc(), 8620538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getCallee()->getSourceRange(), CallType); 8630538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 8640538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu return false; 8650538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu} 8660538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 867ff34d401ff385ef7173ca612432b4ea717fff690Richard SmithExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, 868ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AtomicOp Op) { 869276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 870276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 871276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 872ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // All these operations take one of the following forms: 873ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith enum { 874ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_init(A *, C) 875ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Init, 876ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_load(A *, int) 877ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Load, 878ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_load(A *, CP, int) 879ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Copy, 880ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_add(A *, M, int) 881ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Arithmetic, 882ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __atomic_exchange_n(A *, CP, int) 883ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Xchg, 884ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_exchange(A *, C *, CP, int) 885ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUXchg, 886ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int) 887ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith C11CmpXchg, 888ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int) 889ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUCmpXchg 890ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } Form = Init; 891ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 }; 892ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 }; 893ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // where: 894ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C is an appropriate type, 895ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins, 896ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise, 897ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // M is C if C is an integer, and ptrdiff_t if C is a pointer, and 898ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the int parameters are for orderings. 899ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 900ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(AtomicExpr::AO__c11_atomic_init == 0 && 901ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load 902ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith && "need to update code for modified C11 atomics"); 903ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init && 904ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op <= AtomicExpr::AO__c11_atomic_fetch_xor; 905ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsN = Op == AtomicExpr::AO__atomic_load_n || 906ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_store_n || 907ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_exchange_n || 908ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_compare_exchange_n; 909ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsAddSub = false; 910ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 911ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Op) { 912ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_init: 913ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Init; 914ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 915ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 916ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_load: 917ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load_n: 918ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Load; 919ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 920ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 921ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_store: 922ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load: 923ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store: 924ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store_n: 925ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Copy; 926ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 927ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 928ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_add: 929ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_sub: 930ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_add: 931ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_sub: 932ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_add_fetch: 933ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_sub_fetch: 934ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith IsAddSub = true; 935ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Fall through. 936ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_and: 937ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_or: 938ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_xor: 939ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_and: 940ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_or: 941ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_xor: 94251b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_fetch_nand: 943ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_and_fetch: 944ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_or_fetch: 945ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_xor_fetch: 94651b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_nand_fetch: 947ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Arithmetic; 948ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 949ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 950ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_exchange: 951ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange_n: 952ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Xchg; 953ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 954ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 955ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange: 956ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUXchg; 957ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 958ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 959ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_strong: 960ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_weak: 961ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = C11CmpXchg; 962ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 963ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 964ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange: 965ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange_n: 966ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUCmpXchg; 967ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 968276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 969276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 970ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Check we have the right number of arguments. 971ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (TheCall->getNumArgs() < NumArgs[Form]) { 972276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 973ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 974276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 975276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 976ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (TheCall->getNumArgs() > NumArgs[Form]) { 977ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(TheCall->getArg(NumArgs[Form])->getLocStart(), 978276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman diag::err_typecheck_call_too_many_args) 979ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 980276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 981276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 982276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 983276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 984ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Inspect the first argument of the atomic operation. 985dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman Expr *Ptr = TheCall->getArg(0); 986276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get(); 987276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 988276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!pointerType) { 989ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 990276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 991276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 992276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 993276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 994ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For a __c11 builtin, this should be a pointer to an _Atomic type. 995ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType AtomTy = pointerType->getPointeeType(); // 'A' 996ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ValType = AtomTy; // 'C' 997ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsC11) { 998ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!AtomTy->isAtomicType()) { 999ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 1000ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 1001ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 1002ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 1003bc57b108b2253e26b83768dba196c28564952f18Richard Smith if (AtomTy.isConstQualified()) { 1004bc57b108b2253e26b83768dba196c28564952f18Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_atomic) 1005bc57b108b2253e26b83768dba196c28564952f18Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 1006bc57b108b2253e26b83768dba196c28564952f18Richard Smith return ExprError(); 1007bc57b108b2253e26b83768dba196c28564952f18Richard Smith } 1008ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ValType = AtomTy->getAs<AtomicType>()->getValueType(); 1009276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 1010276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 1011ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For an arithmetic operation, the implied arithmetic must be well-formed. 1012ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Arithmetic) { 1013ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // gcc does not enforce these rules for GNU atomics, but we do so for sanity. 1014ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) { 1015ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 1016ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 1017ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 1018ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 1019ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsAddSub && !ValType->isIntegerType()) { 1020ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int) 1021ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 1022ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 1023ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 1024ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) { 1025ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For __atomic_*_n operations, the value type must be a scalar integral or 1026ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // pointer type which is 1, 2, 4, 8 or 16 bytes in length. 1027276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 1028ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 1029276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 1030276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 1031276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 1032ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) { 1033ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For GNU atomics, require a trivially-copyable type. This is not part of 1034ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the GNU atomics specification, but we enforce it for sanity. 1035ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy) 1036276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 1037276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 1038276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 1039276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 1040ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: For any builtin other than a load, the ValType must not be 1041ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // const-qualified. 1042ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 1043276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman switch (ValType.getObjCLifetime()) { 1044276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_None: 1045276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_ExplicitNone: 1046276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // okay 1047276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman break; 1048276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 1049276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Weak: 1050276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Strong: 1051276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Autoreleasing: 1052ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: Can this happen? By this point, ValType should be known 1053ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // to be trivially copyable. 1054276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 1055276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << ValType << Ptr->getSourceRange(); 1056276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 1057276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 1058276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 1059276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ResultType = ValType; 1060ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Copy || Form == GNUXchg || Form == Init) 1061276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.VoidTy; 1062ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == C11CmpXchg || Form == GNUCmpXchg) 1063276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.BoolTy; 1064276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 1065ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The type of a parameter passed 'by value'. In the GNU atomics, such 1066ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // arguments are actually passed as pointers. 1067ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ByValType = ValType; // 'CP' 1068ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !IsN) 1069ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ByValType = Ptr->getType(); 1070ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 1071276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The first argument --- the pointer --- has a fixed type; we 1072276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // deduce the types of the rest of the arguments accordingly. Walk 1073276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // the remaining arguments, converting them to the deduced value type. 1074ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith for (unsigned i = 1; i != NumArgs[Form]; ++i) { 1075276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType Ty; 1076ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (i < NumVals[Form] + 1) { 1077ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (i) { 1078ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 1: 1079ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The second argument is the non-atomic operand. For arithmetic, this 1080ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // is always passed by value, and for a compare_exchange it is always 1081ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // passed by address. For the rest, GNU uses by-address and C11 uses 1082ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // by-value. 1083ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(Form != Load); 1084ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Init || (Form == Arithmetic && ValType->isIntegerType())) 1085ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ValType; 1086ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Copy || Form == Xchg) 1087ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 1088ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Arithmetic) 1089ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerDiffType(); 1090ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else 1091ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerType(ValType.getUnqualifiedType()); 1092ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1093ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 2: 1094ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The third argument to compare_exchange / GNU exchange is a 1095ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // (pointer to a) desired value. 1096ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 1097ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1098ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 3: 1099ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The fourth argument to GNU compare_exchange is a 'weak' flag. 1100ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.BoolTy; 1101ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1102ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 1103276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 1104276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The order(s) are always converted to int. 1105276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.IntTy; 1106276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 1107ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 1108276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity Entity = 1109276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity::InitializeParameter(Context, Ty, false); 1110ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ExprResult Arg = TheCall->getArg(i); 1111276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 1112276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Arg.isInvalid()) 1113276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return true; 1114276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman TheCall->setArg(i, Arg.get()); 1115276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 1116276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 1117ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Permute the arguments into a 'consistent' order. 1118dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SmallVector<Expr*, 5> SubExprs; 1119dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(Ptr); 1120ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Form) { 1121ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Init: 1122ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal1() has a special case for this atomic. 11237a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall SubExprs.push_back(TheCall->getArg(1)); // Val1 1124ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1125ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Load: 1126ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Order 1127ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1128ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Copy: 1129ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Arithmetic: 1130ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Xchg: 1131dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Order 1132dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 1133ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1134ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUXchg: 1135ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal2() has a special case for this atomic. 1136ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Order 1137ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 1138ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 1139ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1140ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case C11CmpXchg: 1141dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(3)); // Order 1142dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 1143dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(4)); // OrderFail 11442ebb98a78471f2039af4321bae657e7daacc2a62David Chisnall SubExprs.push_back(TheCall->getArg(2)); // Val2 1145ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1146ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUCmpXchg: 1147ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(4)); // Order 1148ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 1149ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(5)); // OrderFail 1150ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 1151ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Weak 1152ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1153276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 1154538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian 1155538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian AtomicExpr *AE = new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 1156538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian SubExprs, ResultType, Op, 1157538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian TheCall->getRParenLoc()); 1158538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian 1159538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian if ((Op == AtomicExpr::AO__c11_atomic_load || 1160538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian (Op == AtomicExpr::AO__c11_atomic_store)) && 1161538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian Context.AtomicUsesUnsupportedLibcall(AE)) 1162538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian Diag(AE->getLocStart(), diag::err_atomic_load_store_uses_lib) << 1163538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian ((Op == AtomicExpr::AO__c11_atomic_load) ? 0 : 1); 1164dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman 1165538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian return Owned(AE); 1166276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman} 1167276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 1168276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 11695f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform 11705f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in 11715f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place. This is useful when a builtin function requires custom 11725f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of 11735f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them. 11745f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// 11755f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error. 11765f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 11775f8d604246976a93a73549b07bbc8ee0b2061b50John McCall FunctionDecl *Fn = E->getDirectCallee(); 11785f8d604246976a93a73549b07bbc8ee0b2061b50John McCall assert(Fn && "builtin call without direct callee!"); 11795f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 11805f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 11815f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity Entity = 11825f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity::InitializeParameter(S.Context, Param); 11835f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 11845f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ExprResult Arg = E->getArg(0); 11855f8d604246976a93a73549b07bbc8ee0b2061b50John McCall Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 11865f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (Arg.isInvalid()) 11875f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 11885f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 11895f8d604246976a93a73549b07bbc8ee0b2061b50John McCall E->setArg(ArgIndex, Arg.take()); 11905f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return false; 11915f8d604246976a93a73549b07bbc8ee0b2061b50John McCall} 11925f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 11935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 11945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 11955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 11965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 11975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 11985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 11995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 12005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 120160d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 120260d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 1203d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 12045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 12055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 12065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 12075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 1208d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 1209d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 1210d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 1211d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 1212d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1213d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 12141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 12165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 12175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 12185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 1219d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 12205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 12218c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); 12228c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman if (FirstArgResult.isInvalid()) 12238c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman return ExprError(); 12248c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman FirstArg = FirstArgResult.take(); 12258c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman TheCall->setArg(0, FirstArg); 12268c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman 1227f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 1228f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 1229d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 1230d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1231d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1232d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 12331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1234f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 1235dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 1236d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 1237d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 1238d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1239d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1240d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 12415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1242f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 1243f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 1244f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 1245f85e193739c953358c865005855253af4f68a497John McCall // okay 1246f85e193739c953358c865005855253af4f68a497John McCall break; 1247f85e193739c953358c865005855253af4f68a497John McCall 1248f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 1249f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 1250f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 1251b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 1252f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 1253f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 1254f85e193739c953358c865005855253af4f68a497John McCall } 1255f85e193739c953358c865005855253af4f68a497John McCall 1256b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Strip any qualifiers off ValType. 1257b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType = ValType.getUnqualifiedType(); 1258b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall 12598d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 12608d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 12618d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 12628d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 12635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 12645caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 12655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 12665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 12675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 12685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 12691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 12715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 12725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 12735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 12745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 12755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 12761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 12785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 12795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 12805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 12815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 12821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 12845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 12855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 128623aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 128723aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 12885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 12891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 12901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 12925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 1293199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 12945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 12955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 12965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 12975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 12985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 12995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 1300d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 1301d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1302d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 13035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 13041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 13065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 13075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 13085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 13097814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 13105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 13115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 1312b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie default: llvm_unreachable("Unknown overloaded atomic builtin!"); 1313a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add: 1314a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 1315a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 1316a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 1317a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 1318a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1319a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 0; 1320a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1321a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1322a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub: 1323a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 1324a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 1325a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 1326a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 1327a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1328a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 1; 1329a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1330a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1331a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or: 1332a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 1333a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 1334a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 1335a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 1336a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 1337a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 2; 1338a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1339a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1340a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and: 1341a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 1342a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 1343a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 1344a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 1345a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 1346a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 3; 1347a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1348a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1349a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor: 1350a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 1351a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 1352a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 1353a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 1354a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 1355a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 4; 1356a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1357a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1358a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch: 1359a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 1360a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 1361a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 1362a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 1363a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 1364a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 5; 1365a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1366a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1367a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch: 1368a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 1369a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 1370a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 1371a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 1372a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 1373a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 6; 1374a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1375a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1376a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch: 1377a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 1378a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 1379a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 1380a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 1381a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 1382a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 7; 1383a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1384a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1385a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch: 1386a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 1387a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 1388a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 1389a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 1390a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 1391a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 8; 1392a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1393a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1394a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch: 1395a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 1396a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 1397a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 1398a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 1399a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 1400a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 9; 1401a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 14021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1404a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 1405a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 1406a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 1407a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 1408a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 14097eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 14105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 14115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1412a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 14135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1414a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 1415a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 1416a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 1417a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 1418a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 14197eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 14205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 14218d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 14225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1423a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1424a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set: 1425a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 1426a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 1427a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 1428a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 1429a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 1430a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 12; 1431a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1432a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 14335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 1434a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 1435a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 1436a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 1437a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 1438a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 14397eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 14405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 14418d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 14425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1443a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1444a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap: 1445a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 1446a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 1447a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 1448a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 1449a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 1450a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 14; 1451a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 14525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 14531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 14555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 1456d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 1457d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 1458d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 1459d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 1460d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1461d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 14621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1463e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 1464e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 1465e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 1466e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 14672ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara FunctionDecl *NewBuiltinDecl; 14682ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara if (NewBuiltinID == BuiltinID) 14692ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara NewBuiltinDecl = FDecl; 14702ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara else { 14712ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara // Perform builtin lookup to avoid redeclaring it. 14722ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara DeclarationName DN(&Context.Idents.get(NewBuiltinName)); 14732ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara LookupResult Res(*this, DN, DRE->getLocStart(), LookupOrdinaryName); 14742ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara LookupName(Res, TUScope, /*AllowBuiltinCreation=*/true); 14752ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara assert(Res.getFoundDecl()); 14762ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara NewBuiltinDecl = dyn_cast<FunctionDecl>(Res.getFoundDecl()); 14772ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara if (NewBuiltinDecl == 0) 14782ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara return ExprError(); 14792ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara } 1480d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 1481f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 1482f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 1483f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 14845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 1485429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 14861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 14885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 1489b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Initialize the argument. 1490b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 1491b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType, /*consume*/ false); 1492b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 1493429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 1494d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 14951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 14975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 14985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 14995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 15005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 15011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 1502b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall TheCall->setArg(i+1, Arg.take()); 15035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 15041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1505bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ASTContext& Context = this->getASTContext(); 1506bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor 1507bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor // Create a new DeclRefExpr to refer to the new decl. 1508bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DeclRefExpr* NewDRE = DeclRefExpr::Create( 1509bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor Context, 1510bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getQualifierLoc(), 1511e4b92761b43ced611c417ae478568610f1ad7b1eAbramo Bagnara SourceLocation(), 1512bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl, 1513f4b88a45902af1802a1cb42ba48b1c474474f228John McCall /*enclosing*/ false, 1514bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getLocation(), 1515a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman Context.BuiltinFnTy, 1516bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getValueKind()); 15171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 15185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 1519a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman // FIXME: This loses syntactic information. 1520a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType()); 1521a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy, 1522a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman CK_BuiltinFnToFnPtr); 1523429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 15241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1525db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 1526db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 1527db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 15288d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 1529d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 15303fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 15315caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 15325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1533690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 153471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 1535fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 1536fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 1537690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 153856f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 153971993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 154071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 15415cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 1542fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 1543fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 15449cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 154571993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 15461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 15477da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 15485f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 15497da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 15505f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 155131ba6135375433b617a8587ea6cc836a014ebd86Roman Divacky const UTF8 *FromPtr = (const UTF8 *)String.data(); 15527da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 15537da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 15547da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 15557da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 15567da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 15577da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 15587da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 15597da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 15607da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 15617da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 15629cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 156359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 156459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 1565c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 1566c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 1567925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 1568925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 1569925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 15702c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 1571fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1572ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1573ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 15741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 1575fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 157630ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 157730ce344307f8a8b00054021307015571f83c7364Chris Lattner } 157856f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 157956f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 1580d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 1581d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 1582d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 158356f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 158456f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 15855f8d604246976a93a73549b07bbc8ee0b2061b50John McCall // Type-check the first argument normally. 15865f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (checkBuiltinArgument(*this, TheCall, 0)) 15875f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 15885f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 1589c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 15909ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 1591c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 1592cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1593c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 15949498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 15959498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 15969498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 159753d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 15981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1599c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 160030ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 160130ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 160230ce344307f8a8b00054021307015571f83c7364Chris Lattner } 16031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 160430ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 160530ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 160630ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 1607e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 16081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1609b07d448a625d7399d871079d55491c6b10316e6fNico Weber // These are valid if SecondArgIsLastNamedArgument is false after the next 1610b07d448a625d7399d871079d55491c6b10316e6fNico Weber // block. 1611b07d448a625d7399d871079d55491c6b10316e6fNico Weber QualType Type; 1612b07d448a625d7399d871079d55491c6b10316e6fNico Weber SourceLocation ParamLoc; 1613b07d448a625d7399d871079d55491c6b10316e6fNico Weber 161488cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 161588cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 161630ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 161730ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 161888cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 1619cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1620cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 1621cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 1622371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 162330ce344307f8a8b00054021307015571f83c7364Chris Lattner else 162453d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 162530ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 1626b07d448a625d7399d871079d55491c6b10316e6fNico Weber 1627b07d448a625d7399d871079d55491c6b10316e6fNico Weber Type = PV->getType(); 1628b07d448a625d7399d871079d55491c6b10316e6fNico Weber ParamLoc = PV->getLocation(); 162930ce344307f8a8b00054021307015571f83c7364Chris Lattner } 163030ce344307f8a8b00054021307015571f83c7364Chris Lattner } 16311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 163230ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 16331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 163430ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 1635b07d448a625d7399d871079d55491c6b10316e6fNico Weber else if (Type->isReferenceType()) { 1636b07d448a625d7399d871079d55491c6b10316e6fNico Weber Diag(Arg->getLocStart(), 1637b07d448a625d7399d871079d55491c6b10316e6fNico Weber diag::warn_va_start_of_reference_type_is_undefined); 1638b07d448a625d7399d871079d55491c6b10316e6fNico Weber Diag(ParamLoc, diag::note_parameter_type) << Type; 1639b07d448a625d7399d871079d55491c6b10316e6fNico Weber } 1640b07d448a625d7399d871079d55491c6b10316e6fNico Weber 164130ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 16426cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 164330ce344307f8a8b00054021307015571f83c7364Chris Lattner 16441b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 16451b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 1646925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 1647925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 16482c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1649d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 1650925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 16511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 1652fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1653ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1654fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 1655fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 16561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1657429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 1658429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 1659cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 16601b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 16611b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 1662925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 1663429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 1664429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 1665403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 1666403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 1667403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 1668403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 1669429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 1670429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 16711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1672429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 1673cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1674cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 16751b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 16761b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 1677860a319e62b0e256817a458396d191aa91c0787aEli Friedman if (Res.isNull() || !Res->isRealFloatingType()) 1678429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 1679fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 1680429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 1681429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 16821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 16831b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 16841b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 16851b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 1686e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 1687e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 16883b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 16893b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 16903b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 16913b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 16929ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1693d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 16943b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 16953b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 16969ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 1697ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 16983b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 16999ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 17009ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 17013b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 17021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 17039ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 17049ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 17059ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 170681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 17079ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 17081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 17099ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 17109ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 17111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 171281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 171381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 171481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 171581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 171681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 171781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 171881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 171981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 172081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 172181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 172281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 17239ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 17249ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 17259ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 1726d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 1727d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 172860d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 172937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 17300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 1731d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 1732b44545aa3419eba3c5ad5fe5e30d534f27cfcb46Craig Topper << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1733b44545aa3419eba3c5ad5fe5e30d534f27cfcb46Craig Topper << TheCall->getSourceRange()); 1734d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 173537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 173637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 173737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 173837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 173937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 174037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 1741e3fbbe9a486c4c8709726d8c79af33140eb02e53Craig Topper 1742cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 1743cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 174437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 174537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 1746e3fbbe9a486c4c8709726d8c79af33140eb02e53Craig Topper 1747bbe759cf95a5df5497549abadb56282939868da1Craig Topper if (!LHSType->isVectorType() || !RHSType->isVectorType()) 1748bbe759cf95a5df5497549abadb56282939868da1Craig Topper return ExprError(Diag(TheCall->getLocStart(), 1749bbe759cf95a5df5497549abadb56282939868da1Craig Topper diag::err_shufflevector_non_vector) 1750bbe759cf95a5df5497549abadb56282939868da1Craig Topper << SourceRange(TheCall->getArg(0)->getLocStart(), 1751bbe759cf95a5df5497549abadb56282939868da1Craig Topper TheCall->getArg(1)->getLocEnd())); 1752e3fbbe9a486c4c8709726d8c79af33140eb02e53Craig Topper 175337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 175437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 175537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 175637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 175737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 175837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 175937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 17604cb3d909cb4af5efc073fd4122d4998c466a220eSylvestre Ledru if (!RHSType->hasIntegerRepresentation() || 176137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 1762bbe759cf95a5df5497549abadb56282939868da1Craig Topper return ExprError(Diag(TheCall->getLocStart(), 1763bbe759cf95a5df5497549abadb56282939868da1Craig Topper diag::err_shufflevector_incompatible_vector) 1764bbe759cf95a5df5497549abadb56282939868da1Craig Topper << SourceRange(TheCall->getArg(1)->getLocStart(), 1765bbe759cf95a5df5497549abadb56282939868da1Craig Topper TheCall->getArg(1)->getLocEnd())); 1766e3fbbe9a486c4c8709726d8c79af33140eb02e53Craig Topper } else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 1767bbe759cf95a5df5497549abadb56282939868da1Craig Topper return ExprError(Diag(TheCall->getLocStart(), 1768bbe759cf95a5df5497549abadb56282939868da1Craig Topper diag::err_shufflevector_incompatible_vector) 1769bbe759cf95a5df5497549abadb56282939868da1Craig Topper << SourceRange(TheCall->getArg(0)->getLocStart(), 1770bbe759cf95a5df5497549abadb56282939868da1Craig Topper TheCall->getArg(1)->getLocEnd())); 177137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 177237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 1773788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 1774e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 1775cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 1776d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1777d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1778d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 1779cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 1780cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 1781cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 1782cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 178337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 178437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 178537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 1786b44545aa3419eba3c5ad5fe5e30d534f27cfcb46Craig Topper diag::err_shufflevector_nonconstant_argument) 1787b44545aa3419eba3c5ad5fe5e30d534f27cfcb46Craig Topper << TheCall->getArg(i)->getSourceRange()); 17880eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 1789d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 17900eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 1791b44545aa3419eba3c5ad5fe5e30d534f27cfcb46Craig Topper diag::err_shufflevector_argument_too_large) 1792b44545aa3419eba3c5ad5fe5e30d534f27cfcb46Craig Topper << TheCall->getArg(i)->getSourceRange()); 1793d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1794d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 17955f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 1796d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1797d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 1798d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 1799d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 1800d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1801d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 18023b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer return Owned(new (Context) ShuffleVectorExpr(Context, exprs, resType, 18038189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 18048189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 1805d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 180630ce344307f8a8b00054021307015571f83c7364Chris Lattner 18074493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 18084493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 18094493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 18104493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 1811fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 18124493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1813fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 1814ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 1815ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 1816ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 1817ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 18184493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 18194493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 18204493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 1821fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 18224493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 1823592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1824592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1825592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (Arg->isTypeDependent() || Arg->isValueDependent()) 1826592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor continue; 1827592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 18289aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 1829691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 1830691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 18311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 18324493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 18334493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 18344493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 1835fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 18369aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 1837fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 183821fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 18394493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 18409aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 1841fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 184221fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 18434493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 18444493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 18454493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1846fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 18474493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 18484493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1849691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 1850691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 1851691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 1852691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 1853691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 1854691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1855691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1856691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1857691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 1858691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1859691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 1860691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 18615e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 1862691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 186321fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 186421fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 186521fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 1866d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 1867d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 1868d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 1869fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 1870d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 1871691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1872592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1873592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1874592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(1)->isTypeDependent() || 1875592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(1)->isValueDependent()) 1876592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 1877592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1878691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 1879691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1880691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1881d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1882691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 1883d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 1884fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1885fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1886d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 1887d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1888d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 1889d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 1890d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1891586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 1892d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 1893d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 1894d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 1895691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1896cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 1897691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 1898691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1899691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1900691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1901691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 1902d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 1903d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1904d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1905d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 1906d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 1907d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1908831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determine if an expression is a string literal or constant string. 1909831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// If this function returns false on the arguments to a function expecting a 1910831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// format string, we will usually need to emit a warning. 1911831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// True string literals are then checked by CheckFormatString. 1912831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::StringLiteralCheckType 19131c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri GribenkoSema::checkFormatStringExpr(const Expr *E, ArrayRef<const Expr *> Args, 19141c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko bool HasVAListArg, 1915831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned format_idx, unsigned firstDataArg, 1916ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose FormatStringType Type, VariadicCallType CallType, 1917ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall) { 19184fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 1919cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 1920831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1921d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 192234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas E = E->IgnoreParenCasts(); 1923f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 1924a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull)) 1925a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // Technically -Wformat-nonliteral does not warn about this case. 1926a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // The behavior of printf and friends in this case is implementation 1927a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // dependent. Ideally if the format string cannot be null then 1928a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // it should have a 'nonnull' attribute in the function prototype. 1929831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 1930a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie 1931d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 193256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 1933d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 1934831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The expression is a literal if both sub-expressions were, and it was 1935831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // completely checked only if both sub-expressions were checked. 1936831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const AbstractConditionalOperator *C = 1937831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith cast<AbstractConditionalOperator>(E); 1938831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Left = 19391c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(C->getTrueExpr(), Args, 1940831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1941ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1942831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Left == SLCT_NotALiteral) 1943831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1944831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Right = 19451c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(C->getFalseExpr(), Args, 1946831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1947ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1948831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Left < Right ? Left : Right; 1949d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1950d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1951d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 19524fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 19534fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 1954d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1955d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 195656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 195756ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 195856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 195956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 196056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 1961831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 196256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1963b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1964b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1965b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1966b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1967831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 1968b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1969082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1970082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 19711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1972082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1973082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1974082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1975082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1976082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1977082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1978082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1979082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1980ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 19811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1982082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1983e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas } else if (T->isObjCObjectPointerType()) { 1984e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // In ObjC, there is usually no "const ObjectPointer" type, 1985e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // so don't check if the pointee type is constant. 1986e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas isConstant = T.isConstant(Context); 1987082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 19881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1989082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 1990e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const Expr *Init = VD->getAnyInitializer()) { 1991e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay // Look through initializers like const char c[] = { "foo" } 1992e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) { 1993e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (InitList->isStringLiteralInit()) 1994e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay Init = InitList->getInit(0)->IgnoreParenImpCasts(); 1995e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 19961c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Init, Args, 1997831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 1998ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 1999831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*inFunctionCall*/false); 2000e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 2001082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 20021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2003d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 2004d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 2005d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 2006d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 2007d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 2008d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 2009d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 2010d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 2011d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 2012d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 2013d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 2014d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 2015d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 2016d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 2017f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (HasVAListArg) { 2018f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) { 2019f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) { 2020f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas int PVIndex = PV->getFunctionScopeIndex() + 1; 2021f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas for (specific_attr_iterator<FormatAttr> 2022f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas i = ND->specific_attr_begin<FormatAttr>(), 2023f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) { 2024f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas FormatAttr *PVFormat = *i; 2025f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // adjust for implicit parameter 2026f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 2027f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (MD->isInstance()) 2028f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas ++PVIndex; 2029f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We also check if the formats are compatible. 2030f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We can't pass a 'scanf' string to a 'printf' function. 2031f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (PVIndex == PVFormat->getFormatIdx() && 2032f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas Type == GetFormatStringType(PVFormat)) 2033831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 2034f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 2035f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 2036f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 2037f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 2038082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 20391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2040831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 2041082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 2042d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 204352aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CallExprClass: 204452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CXXMemberCallExprClass: { 20458f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 204652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) { 204752aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) { 204852aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas unsigned ArgIndex = FA->getFormatIdx(); 204952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 205052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (MD->isInstance()) 205152aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas --ArgIndex; 205252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas const Expr *Arg = CE->getArg(ArgIndex - 1); 205352aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas 20541c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Arg, Args, 2055831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 2056ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 205750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) { 205850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned BuiltinID = FD->getBuiltinID(); 205950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString || 206050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) { 206150687314f87b67073c202fe46d84d12fb55e25cfJordan Rose const Expr *Arg = CE->getArg(0); 20621c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Arg, Args, 2063831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 2064ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 2065ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall); 206650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } 20678f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 20688f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 20691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2070831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 20718f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 2072082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 2073082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 2074082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 20751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2076082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 2077d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 2078d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 2079082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 20801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2081d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 20821c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko CheckFormatString(StrE, E, Args, HasVAListArg, format_idx, 2083ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, inFunctionCall, CallType); 2084831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 2085d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 20861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2087831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 2088d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 20891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2090082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 2091831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 2092d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 2093d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 2094d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 2095e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 20961eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 2097909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 2098909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 2099cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 2100cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 2101e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 2102909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 21033edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky 21043edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky // As a special case, transparent unions initialized with zero are 21053edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky // considered null for the purposes of the nonnull attribute. 21063edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const RecordType *UT = ArgExpr->getType()->getAsUnionType()) { 21073edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (UT->getDecl()->hasAttr<TransparentUnionAttr>()) 21083edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const CompoundLiteralExpr *CLE = 21093edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky dyn_cast<CompoundLiteralExpr>(ArgExpr)) 21103edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const InitListExpr *ILE = 21113edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky dyn_cast<InitListExpr>(CLE->getInitializer())) 21123edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky ArgExpr = ILE->getInit(0); 21133edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky } 21143edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky 21153edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky bool Result; 21163edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (ArgExpr->EvaluateAsBooleanCondition(Result, Context) && !Result) 2117909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 2118e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 2119e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 2120d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 212134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel DupasSema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) { 212234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas return llvm::StringSwitch<FormatStringType>(Format->getType()) 212334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("scanf", FST_Scanf) 212434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("printf", "printf0", FST_Printf) 212534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("NSString", "CFString", FST_NSString) 212634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strftime", FST_Strftime) 212734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strfmon", FST_Strfmon) 212834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf) 212934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Default(FST_Unknown); 213034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas} 213134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas 2132ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose/// CheckFormatArguments - Check calls to printf and scanf (and similar 2133826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 2134831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true if a format string has been fully checked. 21351c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkobool Sema::CheckFormatArguments(const FormatAttr *Format, 21361c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 21371c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko bool IsCXXMember, 2138ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 213929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 2140831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo FSI; 2141831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (getFormatStringInfo(Format, IsCXXMember, &FSI)) 21421c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return CheckFormatArguments(Args, FSI.HasVAListArg, FSI.FormatIdx, 2143831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI.FirstDataArg, GetFormatStringType(Format), 2144ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose CallType, Loc, Range); 2145831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 214629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 21474a2614e94672c47395abcde60518776fbebec589Sebastian Redl 21481c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkobool Sema::CheckFormatArguments(ArrayRef<const Expr *> Args, 214934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 215034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 2151ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 215234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 2153826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 21541c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko if (format_idx >= Args.size()) { 215529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Loc, diag::warn_missing_format_string) << Range; 2156831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 215771895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 21581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 215929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts(); 21601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 216159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 21621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 216371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 216471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 216571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 216671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 216771895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 21687ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 21691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 21707ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 21711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 21727ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 2173831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType CT = 21741c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(OrigFormatExpr, Args, HasVAListArg, 2175ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose format_idx, firstDataArg, Type, CallType); 2176831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (CT != SLCT_NotALiteral) 2177831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Literal format string found, check done! 2178831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return CT == SLCT_CheckedLiteral; 21791cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 21802837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // Strftime is particular as it always uses a single 'time' argument, 21812837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // so it is safe to pass a non-literal string. 21822837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas if (Type == FST_Strftime) 2183831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 21842837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas 2185ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // Do not emit diag when the string param is a macro expansion and the 2186ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // format is either NSString or CFString. This is a hack to prevent 2187ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // diag when using the NSLocalizedString and CFCopyLocalizedString macros 2188ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // which are usually used in place of NS and CF string literals. 2189dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas if (Type == FST_NSString && 2190dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart())) 2191831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 2192ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas 2193655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 2194655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 21952243e78a6580ead4d17b76c924cd4b630b50d6aeEli Friedman if (Args.size() == firstDataArg) 219629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 2197826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 2198655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 2199655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 220029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 2201826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 2202655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 2203831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 2204d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 2205d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 2206e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 2207826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 2208826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 2209e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 2210e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 2211e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 22126ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 2213e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 2214e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 22150d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 22161c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args; 22170d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 22187f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 2219efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 2220efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 222155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool inFunctionCall; 2222ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType; 22234e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 2224826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 22256ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 222650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 22271c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 2228ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2229ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType callType) 2230e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 223150687314f87b67073c202fe46d84d12fb55e25cfJordan Rose FirstDataArg(firstDataArg), NumDataArgs(numDataArgs), 223250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose Beg(beg), HasVAListArg(hasVAListArg), 22331c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Args(Args), FormatIdx(formatIdx), 223455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu usesPositionalArgs(false), atFirstArg(true), 2235ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall(inFunctionCall), CallType(callType) { 22367f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 22377f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 22387f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 22394e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 224007d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 22414e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2242826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 2243826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 224476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2245bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose void HandleInvalidLengthModifier( 2246bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::FormatSpecifier &FS, 2247bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::ConversionSpecifier &CS, 22488be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const char *startSpecifier, unsigned specifierLen, unsigned DiagID); 2249bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 225076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardLengthModifier( 22518be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const analyze_format_string::FormatSpecifier &FS, 225276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 225376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 225476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardConversionSpecifier( 225576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 225676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 225776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2258f85626453123f9691bcef13cff963f556e209c27Hans Wennborg virtual void HandlePosition(const char *startPos, unsigned posLen); 2259f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 2260efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 2261efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 2262826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 2263efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2264efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 2265efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2266e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 22674e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 226855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 226955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall, 227055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 227155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 227255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation StringLoc, 227355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 22745543169296beeb183b9c9392debc774fcf493eebDmitri Gribenko ArrayRef<FixItHint> Fixit = None); 227555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2276826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 2277c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 2278c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 2279c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 2280c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 228155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 228255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void HandlePositionalNonpositionalArgs(SourceLocation Loc, 228355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 228455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen); 2285c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2286f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 2287826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 2288826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2289e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 22904e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 22910d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 2292666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 2293666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 2294666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 2295666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 2296666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 229755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 229855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 229955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc, 230055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 23015543169296beeb183b9c9392debc774fcf493eebDmitri Gribenko ArrayRef<FixItHint> Fixit = None); 230255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 230355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void CheckPositionalAndNonpositionalArgs( 230455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const analyze_format_string::FormatSpecifier *FS); 2305e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 2306e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2307e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2308826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 2309e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 2310e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2311e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2312826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 2313826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 231445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 231545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 231645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 231745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 2318a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis End = End.getLocWithOffset(1); 231945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 232045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 2321f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 2322f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 2323826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 23244e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 2325e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2326e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2327826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 2328826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 232955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier), 233055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startSpecifier), 233155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 233255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2333808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 2334808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 2335bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rosevoid CheckFormatHandler::HandleInvalidLengthModifier( 2336bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::FormatSpecifier &FS, 2337bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::ConversionSpecifier &CS, 23388be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const char *startSpecifier, unsigned specifierLen, unsigned DiagID) { 2339bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose using namespace analyze_format_string; 2340bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2341bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const LengthModifier &LM = FS.getLengthModifier(); 2342bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 2343bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2344bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose // See if we know how to fix this length modifier. 2345dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 2346bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (FixedLM) { 23478be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2348bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getLocationOfByte(LM.getStart()), 2349bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose /*IsStringLocation*/true, 2350bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2351bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2352bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 2353bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose << FixedLM->toString() 2354bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 2355bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2356bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose } else { 23578be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose FixItHint Hint; 23588be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose if (DiagID == diag::warn_format_nonsensical_length) 23598be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose Hint = FixItHint::CreateRemoval(LMRange); 23608be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 23618be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2362bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getLocationOfByte(LM.getStart()), 2363bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose /*IsStringLocation*/true, 2364bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getSpecifierRange(startSpecifier, specifierLen), 23658be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose Hint); 2366bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose } 2367bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose} 2368bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 236976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardLengthModifier( 23708be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const analyze_format_string::FormatSpecifier &FS, 237176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 23728be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose using namespace analyze_format_string; 23738be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 23748be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const LengthModifier &LM = FS.getLengthModifier(); 23758be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 23768be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 23778be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose // See if we know how to fix this length modifier. 2378dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 23798be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose if (FixedLM) { 23808be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 23818be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << LM.toString() << 0, 23828be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getLocationOfByte(LM.getStart()), 23838be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose /*IsStringLocation*/true, 23848be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 23858be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 23868be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 23878be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << FixedLM->toString() 23888be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 23898be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 23908be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose } else { 23918be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 23928be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << LM.toString() << 0, 23938be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getLocationOfByte(LM.getStart()), 23948be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose /*IsStringLocation*/true, 23958be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 23968be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose } 239776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 239876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 239976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecifier( 240076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 240176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 2402670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose using namespace analyze_format_string; 2403670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose 2404670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose // See if we know how to fix this conversion specifier. 2405dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<ConversionSpecifier> FixedCS = CS.getStandardSpecifier(); 2406670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose if (FixedCS) { 2407670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2408670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << CS.toString() << /*conversion specifier*/1, 2409670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getLocationOfByte(CS.getStart()), 2410670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose /*IsStringLocation*/true, 2411670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2412670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose 2413670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose CharSourceRange CSRange = getSpecifierRange(CS.getStart(), CS.getLength()); 2414670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose S.Diag(getLocationOfByte(CS.getStart()), diag::note_format_fix_specifier) 2415670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << FixedCS->toString() 2416670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << FixItHint::CreateReplacement(CSRange, FixedCS->toString()); 2417670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose } else { 2418670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2419670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << CS.toString() << /*conversion specifier*/1, 2420670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getLocationOfByte(CS.getStart()), 2421670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose /*IsStringLocation*/true, 2422670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2423670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose } 242476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 242576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2426f85626453123f9691bcef13cff963f556e209c27Hans Wennborgvoid CheckFormatHandler::HandlePosition(const char *startPos, 2427f85626453123f9691bcef13cff963f556e209c27Hans Wennborg unsigned posLen) { 2428f85626453123f9691bcef13cff963f556e209c27Hans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg), 2429f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getLocationOfByte(startPos), 2430f85626453123f9691bcef13cff963f556e209c27Hans Wennborg /*IsStringLocation*/true, 2431f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getSpecifierRange(startPos, posLen)); 2432f85626453123f9691bcef13cff963f556e209c27Hans Wennborg} 2433f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 2434efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 2435826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 2436826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 243755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier) 243855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (unsigned) p, 243955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), /*IsStringLocation*/true, 244055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2441efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2442efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2443826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 2444efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 244555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier), 244655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), 244755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 244855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2449efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2450efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2451826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 245250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!isa<ObjCStringLiteral>(OrigFormatExpr)) { 24530c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 245455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 245555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_format_string_contains_null_char), 245655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(nullCharacter), /*IsStringLocation*/true, 245755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getFormatStringRange()); 24580c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 2459826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2460826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 246148716663e421472cbd590af160a372bc490205e8Jordan Rose// Note that this may return NULL if there was an error parsing or building 246248716663e421472cbd590af160a372bc490205e8Jordan Rose// one of the argument expressions. 2463826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 246429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return Args[FirstDataArg + i]; 2465826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 24664e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2467826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 2468826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 2469826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 2470826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 2471826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 2472826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 2473826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 2474826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 2475826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 247648716663e421472cbd590af160a372bc490205e8Jordan Rose if (const Expr *E = getDataArg((unsigned) notCoveredArg)) { 247748716663e421472cbd590af160a372bc490205e8Jordan Rose SourceLocation Loc = E->getLocStart(); 247848716663e421472cbd590af160a372bc490205e8Jordan Rose if (!S.getSourceManager().isInSystemMacro(Loc)) { 247948716663e421472cbd590af160a372bc490205e8Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used), 248048716663e421472cbd590af160a372bc490205e8Jordan Rose Loc, /*IsStringLocation*/false, 248148716663e421472cbd590af160a372bc490205e8Jordan Rose getFormatStringRange()); 248248716663e421472cbd590af160a372bc490205e8Jordan Rose } 2483c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson } 2484826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2485826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2486826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2487826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2488c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 2489c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 2490c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 2491c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 2492c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 2493c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 2494c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 2495c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2496c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 2497c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 2498c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 2499c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 2500c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 2501c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2502c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 2503c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 2504c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 2505c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 2506c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 2507c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 2508c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 2509c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2510c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 251155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion) 251255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << StringRef(csStart, csLen), 251355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*IsStringLocation*/true, 251455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpec, specifierLen)); 2515c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2516c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 2517c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 2518c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 251955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid 252055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc, 252155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 252255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen) { 252355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 252455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_format_mix_positional_nonpositional_args), 252555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen)); 252655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 252755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2528666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 2529666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 2530666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 2531666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 2532666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 2533666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 2534666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 253555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag = FS.usesPositionalArg() 253655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args) 253755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (argIndex+1) << NumDataArgs) 253855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : S.PDiag(diag::warn_printf_insufficient_data_args); 253955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 254055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true, 254155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2542666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 2543666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 2544666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 2545666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 2546666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 254755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 254855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag, 254955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 255055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 255155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2552ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 255329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag, 255455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, IsStringLocation, StringRange, FixIt); 255555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 255655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 255755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note 255855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages. 255955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 256070517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param InFunctionCall if true, the format string is within the function 256155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced. Otherwise, an 256255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string. 256355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 256455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string 256555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call. Used for getting locations when two 256655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted. 256755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 256855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the 256955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message. This function only adds locations and fixits 257055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics. 257155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 257255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic. If two diagnostics are 257355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for 257455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one. 257555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 257655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be 257755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note. Otherwise, Loc points to the argument list and will 257855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag. 257955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 258055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight. This is 258155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange. 258255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 258370517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param FixIt optional fix it hint for the format string. 258455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 258555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall, 258655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 258755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 258855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 258955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 259055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2591ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 2592ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (InFunctionCall) { 2593ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag); 2594ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << StringRange; 2595ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2596ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2597ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << *I; 2598ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2599ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 260055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag) 260155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ArgumentExpr->getSourceRange(); 2602ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2603ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &Note = 2604ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose S.Diag(IsStringLocation ? Loc : StringRange.getBegin(), 2605ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose diag::note_format_string_defined); 2606ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2607ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << StringRange; 2608ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2609ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2610ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << *I; 2611ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 261255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu } 261355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 261455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2615826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 2616826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2617826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2618826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 261950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose bool ObjCContext; 2620826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2621826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 2622826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 262350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, bool isObjC, 2624826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 26251c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 2626ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2627ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 2628826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 26291c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko numDataArgs, beg, hasVAListArg, Args, 2630ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose formatIdx, inFunctionCall, CallType), ObjCContext(isObjC) 2631ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 2632ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose 2633826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2634826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 2635826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2636826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2637826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2638826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2639826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 2640826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2641826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2642831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2643831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2644831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2645831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E); 2646831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2647826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 2648826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2649826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 2650826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 2651826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 2652826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2653826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2654826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2655826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2656826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 2657826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 2658826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2659826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2660f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg bool checkForCStrMembers(const analyze_printf::ArgType &AT, 2661831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E, const CharSourceRange &CSR); 2662831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2663826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2664826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2665826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2666826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 2667826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2668826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2669826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 26706ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 2671c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2672826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2673c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2674c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2675c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2676c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 267726ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 267826ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 2679826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 2680826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 2681826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 2682826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 26830d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 26840d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 26850d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 26867f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 26877f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 268855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg) 268955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << k, 269055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 269155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 269255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 26930d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 26940d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 26950d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 26960d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 26974e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 26980d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 269931f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 270031f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 270131f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 27027f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 27037f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 270448716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 270548716663e421472cbd590af160a372bc490205e8Jordan Rose return false; 270648716663e421472cbd590af160a372bc490205e8Jordan Rose 27070d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 27084e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2709f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = Amt.getArgType(S.Context); 2710f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg assert(AT.isValid()); 27114e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2712f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg if (!AT.matchesType(S.Context, T)) { 271355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type) 2714f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg << k << AT.getRepresentativeTypeName(S.Context) 271555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << T << Arg->getSourceRange(), 271655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 271755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 271855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 27190d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 27200d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 27210d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 27220d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 27230d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 27240d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 27250d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 27260d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 27270d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2728e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 2729826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2730e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 2731e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 2732e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2733e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 27346ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 27356ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 2736e4ee9663168dfb2b4122c768091e30217328c9faTom Care 273755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint fixit = 273855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant 273955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 274055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getConstantLength())) 274155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : FixItHint(); 274255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 274355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount) 274455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << type << CS.toString(), 274555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 274655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 274755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 274855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu fixit); 2749e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2750e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2751826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2752e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2753e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2754e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2755e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 27566ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 27576ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 275855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag) 275955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << flag.toString() << CS.toString(), 276055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(flag.getPosition()), 276155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 276255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 276355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 276455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(flag.getPosition(), 1))); 2765e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2766e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2767e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 2768826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2769e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 2770e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2771e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2772e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2773e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 277455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag) 277555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ignoredFlag.toString() << flag.toString(), 277655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(ignoredFlag.getPosition()), 277755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 277855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 277955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 278055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(ignoredFlag.getPosition(), 1))); 2781e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2782e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2783831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determines if the specified is a C++ class or struct containing 2784831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// a member with the specified name and kind (e.g. a CXXMethodDecl named 2785831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// "c_str()"). 2786831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithtemplate<typename MemberKind> 2787831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithstatic llvm::SmallPtrSet<MemberKind*, 1> 2788831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) { 2789831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const RecordType *RT = Ty->getAs<RecordType>(); 2790831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith llvm::SmallPtrSet<MemberKind*, 1> Results; 2791831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2792831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RT) 2793831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2794831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl()); 2795831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RD) 2796831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2797831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2798831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith LookupResult R(S, &S.PP.getIdentifierTable().get(Name), SourceLocation(), 2799831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Sema::LookupMemberName); 2800831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2801831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // We just need to include all members of the right kind turned up by the 2802831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // filter, at this point. 2803831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (S.LookupQualifiedName(R, RT->getDecl())) 2804831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) { 2805831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NamedDecl *decl = (*I)->getUnderlyingDecl(); 2806831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (MemberKind *FK = dyn_cast<MemberKind>(decl)) 2807831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Results.insert(FK); 2808831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2809831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2810831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2811831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2812831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Check if a (w)string was passed when a (w)char* was needed, and offer a 2813f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg// better diagnostic if so. AT is assumed to be valid. 2814831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Returns true when a c_str() conversion method is found. 2815831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool CheckPrintfHandler::checkForCStrMembers( 2816f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT, const Expr *E, 2817831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CharSourceRange &CSR) { 2818831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet; 2819831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2820831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MethodSet Results = 2821831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType()); 2822831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2823831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (MethodSet::iterator MI = Results.begin(), ME = Results.end(); 2824831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MI != ME; ++MI) { 2825831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXMethodDecl *Method = *MI; 2826831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Method->getNumParams() == 0 && 2827f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg AT.matchesType(S.Context, Method->getResultType())) { 2828831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // FIXME: Suggest parens if the expression needs them. 2829831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation EndLoc = 2830831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()); 2831831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.Diag(E->getLocStart(), diag::note_printf_c_str) 2832831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << "c_str()" 2833831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << FixItHint::CreateInsertion(EndLoc, ".c_str()"); 2834831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 2835831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2836831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2837831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2838831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 2839831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2840831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2841e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 2842826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 28435c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 2844e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 2845e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 2846e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 28476ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 2848efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 28496ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 2850e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2851baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2852baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2853baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2854baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2855baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2856baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 285755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 285855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2859baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2860baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2861efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 2862efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 28630d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 28640d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 2865efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 2866efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 28670d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 28680d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 28694e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2870efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 2871efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 28720d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 28730d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 28740d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2875f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 2876f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 2877f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 28780e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 2879f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 28804e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 28817f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 28827f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2883e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 2884e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 2885e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 2886e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 2887e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 2888e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 28897f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 28907f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 28917f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 289250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!ObjCContext && CS.isObjCArg()) { 2893826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 2894826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 28957f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 28964e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2897e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 2898e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 289945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 2900e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2901e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2902e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2903e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 2904e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 2905e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 2906e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2907e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2908e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2909e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 291065197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 291165197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 2912e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 2913e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 2914e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 2915e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 291645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 291745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 2918e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 2919e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 2920e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 2921e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 2922e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2923e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 292445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 292545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 292645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 2927e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 2928e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 2929e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2930e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2931e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 2932bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 29338be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 29348be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_nonsensical_length); 2935bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthModifier()) 29368be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 2937bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthConversionCombination()) 29388be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 29398be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_non_standard_conversion_spec); 2940e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2941bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 2942bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 2943bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2944da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 2945da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 2946da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 29474e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2948666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2949da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 29504e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 295148716663e421472cbd590af160a372bc490205e8Jordan Rose const Expr *Arg = getDataArg(argIndex); 295248716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 295348716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 295448716663e421472cbd590af160a372bc490205e8Jordan Rose 295548716663e421472cbd590af160a372bc490205e8Jordan Rose return checkFormatExpr(FS, startSpecifier, specifierLen, Arg); 2956831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2957831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2958ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rosestatic bool requiresParensToAddCast(const Expr *E) { 2959ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // FIXME: We should have a general way to reason about operator 2960ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // precedence and whether parens are actually needed here. 2961ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Take care of a few common cases where they aren't. 2962ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Expr *Inside = E->IgnoreImpCasts(); 2963ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside)) 2964ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Inside = POE->getSyntacticForm()->IgnoreImpCasts(); 2965ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2966ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose switch (Inside->getStmtClass()) { 2967ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ArraySubscriptExprClass: 2968ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::CallExprClass: 296917ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::CharacterLiteralClass: 297017ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::CXXBoolLiteralExprClass: 2971ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::DeclRefExprClass: 297217ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::FloatingLiteralClass: 297317ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::IntegerLiteralClass: 2974ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::MemberExprClass: 297517ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCArrayLiteralClass: 297617ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCBoolLiteralExprClass: 297717ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCBoxedExprClass: 297817ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCDictionaryLiteralClass: 297917ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCEncodeExprClass: 2980ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCIvarRefExprClass: 2981ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCMessageExprClass: 2982ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCPropertyRefExprClass: 298317ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCStringLiteralClass: 298417ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCSubscriptRefExprClass: 2985ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ParenExprClass: 298617ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::StringLiteralClass: 2987ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::UnaryOperatorClass: 2988ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return false; 2989ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose default: 2990ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return true; 2991ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2992ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose} 2993ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2994831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool 2995831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2996831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2997831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2998831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E) { 2999831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_format_string; 3000831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_printf; 300196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 300296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 3003f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = FS.getArgType(S.Context, 3004f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg ObjCContext); 3005614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (!AT.isValid()) 3006614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 3007ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 3008448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose QualType ExprTy = E->getType(); 300902be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek while (const TypeOfExprType *TET = dyn_cast<TypeOfExprType>(ExprTy)) { 301002be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek ExprTy = TET->getUnderlyingExpr()->getType(); 301102be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek } 301202be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek 3013448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (AT.matchesType(S.Context, ExprTy)) 3014614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 3015614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 3016614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Look through argument promotions for our error message's reported type. 3017614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // This includes the integral and floating promotions, but excludes array 3018614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // and function pointer decay; seeing that an argument intended to be a 3019614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // string has type 'char [6]' is probably more confusing than 'char *'. 3020614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 3021614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getCastKind() == CK_IntegralCast || 3022614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getCastKind() == CK_FloatingCast) { 3023614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E = ICE->getSubExpr(); 3024448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose ExprTy = E->getType(); 3025614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 3026614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Check if we didn't match because of an implicit cast from a 'char' 3027614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // or 'short' to an 'int'. This is done because printf is a varargs 3028614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // function. 3029614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getType() == S.Context.IntTy || 3030614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getType() == S.Context.UnsignedIntTy) { 3031614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // All further checking is done on the subexpression. 3032448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (AT.matchesType(S.Context, ExprTy)) 3033614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 30344d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 3035ee0259d308e72141982a85b40863e760a8447edfJordan Rose } 3036448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose } else if (const CharacterLiteral *CL = dyn_cast<CharacterLiteral>(E)) { 3037448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // Special case for 'a', which has type 'int' in C. 3038448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // Note, however, that we do /not/ want to treat multibyte constants like 3039448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // 'MooV' as characters! This form is deprecated but still exists. 3040448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (ExprTy == S.Context.IntTy) 3041448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (llvm::isUIntN(S.Context.getCharWidth(), CL->getValue())) 3042448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose ExprTy = S.Context.CharTy; 3043614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } 3044614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 30452cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // %C in an Objective-C context prints a unichar, not a wchar_t. 30462cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // If the argument is an integer of some kind, believe the %C and suggest 30472cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // a cast instead of changing the conversion specifier. 3048448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose QualType IntendedTy = ExprTy; 30492cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ObjCContext && 30502cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose FS.getConversionSpecifier().getKind() == ConversionSpecifier::CArg) { 30512cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ExprTy->isIntegralOrUnscopedEnumerationType() && 30522cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose !ExprTy->isCharType()) { 30532cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // 'unichar' is defined as a typedef of unsigned short, but we should 30542cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // prefer using the typedef if it is visible. 30552cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = S.Context.UnsignedShortTy; 30562cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 30572cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose LookupResult Result(S, &S.Context.Idents.get("unichar"), E->getLocStart(), 30582cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose Sema::LookupOrdinaryName); 30592cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (S.LookupName(Result, S.getCurScope())) { 30602cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose NamedDecl *ND = Result.getFoundDecl(); 30612cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(ND)) 30622cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (TD->getUnderlyingType() == IntendedTy) 30632cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = S.Context.getTypedefType(TD); 30642cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 30652cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 30662cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 30672cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 30682cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // Special-case some of Darwin's platform-independence types by suggesting 30692cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // casts to primitive types that are known to be large enough. 30702cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose bool ShouldNotPrintDirectly = false; 3071ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (S.Context.getTargetInfo().getTriple().isOSDarwin()) { 30726edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek // Use a 'while' to peel off layers of typedefs. 30736edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek QualType TyTy = IntendedTy; 30746edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek while (const TypedefType *UserTy = TyTy->getAs<TypedefType>()) { 3075ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose StringRef Name = UserTy->getDecl()->getName(); 30762cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose QualType CastTy = llvm::StringSwitch<QualType>(Name) 3077ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSInteger", S.Context.LongTy) 3078ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSUInteger", S.Context.UnsignedLongTy) 3079ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("SInt32", S.Context.IntTy) 3080ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("UInt32", S.Context.UnsignedIntTy) 30812cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose .Default(QualType()); 30822cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 30832cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (!CastTy.isNull()) { 30842cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose ShouldNotPrintDirectly = true; 30852cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = CastTy; 30866edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek break; 30872cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 30886edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek TyTy = UserTy->desugar(); 3089ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 3090ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 3091ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 3092614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // We may be able to offer a FixItHint if it is a supported type. 3093614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose PrintfSpecifier fixedFS = FS; 3094ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose bool success = fixedFS.fixType(IntendedTy, S.getLangOpts(), 3095614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.Context, ObjCContext); 309696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 3097614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (success) { 3098614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Get the fix string from the fixed format specifier 3099614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SmallString<16> buf; 3100614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose llvm::raw_svector_ostream os(buf); 3101614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose fixedFS.toString(os); 3102614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 3103ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen); 3104ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 31052cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (IntendedTy == ExprTy) { 31062cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // In this case, the specifier is wrong and should be changed to match 31072cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // the argument. 31082cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic( 31092cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 31102cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << AT.getRepresentativeTypeName(S.Context) << IntendedTy 31112cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 31122cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), 31132cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose /*IsStringLocation*/false, 31142cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, 31152cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose FixItHint::CreateReplacement(SpecRange, os.str())); 31162cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 31172cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } else { 3118ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // The canonical type for formatting this value is different from the 3119ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // actual type of the expression. (This occurs, for example, with Darwin's 3120ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but 3121ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // should be printed as 'long' for 64-bit compatibility.) 3122ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Rather than emitting a normal format/argument mismatch, we want to 3123ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // add a cast to the recommended type (and correct the format string 3124ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // if necessary). 3125ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallString<16> CastBuf; 3126ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose llvm::raw_svector_ostream CastFix(CastBuf); 3127ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 3128ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose IntendedTy.print(CastFix, S.Context.getPrintingPolicy()); 3129ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << ")"; 3130ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 3131ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallVector<FixItHint,4> Hints; 3132ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (!AT.matchesType(S.Context, IntendedTy)) 3133ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str())); 3134ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 3135ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) { 3136ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If there's already a cast present, just replace it. 3137ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc()); 3138ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str())); 3139ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 3140ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else if (!requiresParensToAddCast(E)) { 3141ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If the expression has high enough precedence, 3142ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // just write the C-style cast. 3143ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 3144ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 3145ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 3146ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Otherwise, add parens around the expression as well as the cast. 3147ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 3148ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 3149ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 3150ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 3151ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceLocation After = S.PP.getLocForEndOfToken(E->getLocEnd()); 3152ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(After, ")")); 3153ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 3154ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 31552cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ShouldNotPrintDirectly) { 31562cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // The expression has a type that should not be printed directly. 31572cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // We extract the name from the typedef because we don't want to show 31582cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // the underlying type in the diagnostic. 31592cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose StringRef Name = cast<TypedefType>(ExprTy)->getDecl()->getName(); 31602cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 31612cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast) 31622cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << Name << IntendedTy 31632cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 31642cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), /*IsStringLocation=*/false, 31652cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, Hints); 31662cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } else { 31672cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // In this case, the expression could be printed using a different 31682cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // specifier, but we've decided that the specifier is probably correct 31692cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // and we should cast instead. Just use the normal warning message. 31702cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic( 31712cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 31722cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << AT.getRepresentativeTypeName(S.Context) << ExprTy 31732cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 31742cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), /*IsStringLocation*/false, 31752cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, Hints); 31762cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 3177ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 3178614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else { 3179614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose const CharSourceRange &CSR = getSpecifierRange(StartSpecifier, 3180614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SpecifierLen); 3181614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Since the warning for passing non-POD types to variadic functions 3182614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // was deferred until now, we emit a warning for non-POD 3183614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // arguments here. 3184448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (S.isValidVarArgType(ExprTy) == Sema::VAK_Invalid) { 3185614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose unsigned DiagKind; 3186448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (ExprTy->isObjCObjectType()) 3187614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::err_cannot_pass_objc_interface_to_vararg_format; 3188614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose else 3189614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::warn_non_pod_vararg_with_format_string; 319096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 3191614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose EmitFormatDiagnostic( 3192614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.PDiag(DiagKind) 319380ad52f327b532bded5c5b0ee38779d841c6cd35Richard Smith << S.getLangOpts().CPlusPlus11 3194448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose << ExprTy 3195614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CallType 3196614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << AT.getRepresentativeTypeName(S.Context) 3197614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 3198614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << E->getSourceRange(), 3199614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 320096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 3201614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose checkForCStrMembers(AT, E, CSR); 3202614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else 320355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 320455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 3205448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose << AT.getRepresentativeTypeName(S.Context) << ExprTy 3206614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 3207831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << E->getSourceRange(), 3208614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 320996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 321096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 3211e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 3212e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 3213e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 3214826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 3215826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3216826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 3217826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 3218826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 3219826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 3220826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 322150687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 32221c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 3223ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 3224ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 3225826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 322650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, beg, hasVAListArg, 32271c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Args, formatIdx, inFunctionCall, CallType) 3228ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 3229826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3230826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 3231826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 3232826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 3233c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 3234c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 3235c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 3236c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 3237c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 3238b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 3239b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 3240826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 3241826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 3242826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3243b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 3244b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 324555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete), 324655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(end), /*IsStringLocation*/true, 324755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(start, end - start)); 3248b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 3249b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 3250c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 3251c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 3252c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 3253c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 3254c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 32556ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 3256c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 3257c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 3258c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 3259c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 3260c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 3261c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 3262c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 3263c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 3264826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 3265826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 3266826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 3267826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 3268826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3269826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 3270826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 3271826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 32726ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 3273826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3274baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 3275baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 3276baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 3277baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 3278baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 3279baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 3280baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 3281baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 328255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 328355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 3284baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 3285baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 3286826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3287826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3288826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 3289826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 3290826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 3291826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 3292826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 3293826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 329455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width), 329555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 329655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, R, 329755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval(R)); 32987f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 32997f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 3300826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3301826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 3302826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 3303826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 3304826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 3305826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3306826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3307826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 3308826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 3309826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 3310826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 3311826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 3312826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 3313826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 3314826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3315826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 33161e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 3317bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 33188be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 33198be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_nonsensical_length); 3320bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthModifier()) 33218be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 3322bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthConversionCombination()) 33238be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 33248be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_non_standard_conversion_spec); 332576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 3326bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 3327bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 3328bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 3329826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 3330826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 3331826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 3332826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3333666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 3334826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 3335826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 33366fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Check that the argument type matches the format specifier. 33376fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg const Expr *Ex = getDataArg(argIndex); 333848716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Ex) 333948716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 334048716663e421472cbd590af160a372bc490205e8Jordan Rose 334158e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg const analyze_format_string::ArgType &AT = FS.getArgType(S.Context); 334258e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType())) { 33436fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg ScanfSpecifier fixedFS = FS; 33444e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(), 3345be6126a2a784e1446460b8d15c2b26f880c871fcHans Wennborg S.Context); 33466fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 33476fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg if (success) { 33486fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Get the fix string from the fixed format specifier. 3349f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> buf; 33506fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg llvm::raw_svector_ostream os(buf); 33516fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg fixedFS.toString(os); 33526fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 33536fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg EmitFormatDiagnostic( 33546fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 335558e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 33566fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << Ex->getSourceRange(), 3357abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 3358abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 33596fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 33606fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg FixItHint::CreateReplacement( 33616fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 33626fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg os.str())); 33636fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } else { 3364220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic( 3365220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 336658e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 3367220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << Ex->getSourceRange(), 3368abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 3369abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 3370220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getSpecifierRange(startSpecifier, specifierLen)); 33716fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 33726fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 33736fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 3374826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 337507d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 3376e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 3377826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 33780e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 33791c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 338029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 338134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 3382ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall, VariadicCallType CallType) { 3383826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3384e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 3385df9ef1bc8c3780307ab2ed81bf5e31c23310b936Richard Smith if (!FExpr->isAscii() && !FExpr->isUTF8()) { 338655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 338729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 338855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(), 338955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3390e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 3391e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 3392826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3393e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 33945f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 33952f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 33962f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 33971c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko const unsigned numDataArgs = Args.size() - firstDataArg; 3398826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3399e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 34004cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek if (StrLen == 0 && numDataArgs > 0) { 340155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 340229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 340355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_empty_format_string), FExpr->getLocStart(), 340455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3405e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 3406e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 3407826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 340834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if (Type == FST_Printf || Type == FST_NSString) { 3409826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 341050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, (Type == FST_NSString), 34111c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Str, HasVAListArg, Args, format_idx, 3412ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 3413826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3414d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen, 3415275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose getLangOpts(), 3416275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose Context.getTargetInfo())) 3417826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 341834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } else if (Type == FST_Scanf) { 341950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs, 34201c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Str, HasVAListArg, Args, format_idx, 3421ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 3422826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3423d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen, 3424275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose getLangOpts(), 3425275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose Context.getTargetInfo())) 3426826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 342734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } // TODO: handle other formats 3428ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 3429ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 34307ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 34317ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 34322a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 34332a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 34342a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 34352a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 34362a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 34372a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 34382a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 34392a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 34402a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 34412a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 34422a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 3443a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 3444000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 3445000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 3446e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 3447000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3448000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 3449000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 3450e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 3451000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 3452000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 3453000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3454a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 3455000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 3456000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 3457000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3458000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 3459000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 3460000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3461000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 3462e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 3463e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 34647ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 34657ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 3466929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 3467cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 3468cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 34697ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 34707ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 3471cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 34720a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned BId, 3473cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 34740a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks assert(BId != 0); 34750a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 34761d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 3477707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 34780a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3); 3479cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber if (Call->getNumArgs() < ExpectedNumArgs) 34801d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 34811d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 34820a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LastArg = (BId == Builtin::BImemset || 34830a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId == Builtin::BIstrndup ? 1 : 2); 34840a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2); 3485cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 3486000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3487000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 3488000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 3489000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 3490000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 3491000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 349206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 349306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 3494e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 349506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 349606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 349706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 349806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 3499f85e193739c953358c865005855253af4f68a497John McCall 3500000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 3501000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 3502000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 350306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 350406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 3505000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 3506000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 3507000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 3508000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 3509000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 3510000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 3511000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 3512000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 3513000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 3514000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 3515000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 3516000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 3517000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 3518000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 3519cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // TODO: For strncpy() and friends, this could suggest sizeof(dst) 3520cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // over sizeof(src) as well. 3521000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 35226fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks StringRef ReadableName = FnName->getName(); 35236fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 3524000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 352590c78328e70cb376754edf87708505a84c044271Anna Zaks if (UnaryOp->getOpcode() == UO_AddrOf) 3526000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 35277adf4179f827b14b025135829dadeaa2442e1d42Fariborz Jahanian if (!PointeeTy->isIncompleteType() && 35287adf4179f827b14b025135829dadeaa2442e1d42Fariborz Jahanian (Context.getTypeSize(PointeeTy) == Context.getCharWidth())) 3529000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 3530000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 35316fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 35326fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // If the function is defined as a builtin macro, do not show macro 35336fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // expansion. 35346fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceLocation SL = SizeOfArg->getExprLoc(); 35356fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange DSR = Dest->getSourceRange(); 35366fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange SSR = SizeOfArg->getSourceRange(); 35376fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceManager &SM = PP.getSourceManager(); 35386fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 35396fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks if (SM.isMacroArgExpansion(SL)) { 35406fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts); 35416fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SL = SM.getSpellingLoc(SL); 35426fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()), 35436fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(DSR.getEnd())); 35446fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()), 35456fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(SSR.getEnd())); 35466fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks } 35476fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 354890c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 3549000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 35506fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << ReadableName 355190c78328e70cb376754edf87708505a84c044271Anna Zaks << PointeeTy 355290c78328e70cb376754edf87708505a84c044271Anna Zaks << DestTy 35536fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << DSR 355490c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 355590c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 355690c78328e70cb376754edf87708505a84c044271Anna Zaks PDiag(diag::warn_sizeof_pointer_expr_memaccess_note) 355790c78328e70cb376754edf87708505a84c044271Anna Zaks << ActionIdx 355890c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 355990c78328e70cb376754edf87708505a84c044271Anna Zaks 3560000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3561000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3562000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3563000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3564000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 3565000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 3566000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 3567000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 3568000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 3569000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 3570000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 3571000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 3572000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 3573000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 3574000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 3575000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3576000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3577e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 3578e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 357906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 35800a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (isDynamicClassType(PointeeTy)) { 35810a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 35820a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned OperationType = 0; 35830a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // "overwritten" if we're warning about the destination for any call 35840a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // but memcmp; otherwise a verb appropriate to the call. 35850a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (ArgIdx != 0 || BId == Builtin::BImemcmp) { 35860a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (BId == Builtin::BImemcpy) 35870a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 1; 35880a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if(BId == Builtin::BImemmove) 35890a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 2; 35900a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if (BId == Builtin::BImemcmp) 35910a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 3; 35920a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } 35930a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 35945c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 35955c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 35965c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_dyn_class_memaccess) 35970a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx) 3598d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks << FnName << PointeeTy 35990a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << OperationType 36005c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 36010a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } else if (PointeeTy.hasNonTrivialObjCLifetime() && 36020a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId != Builtin::BImemset) 36035c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 36045c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 36055c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_arc_object_memaccess) 36065c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << ArgIdx << FnName << PointeeTy 36075c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 3608f85e193739c953358c865005855253af4f68a497John McCall else 360906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 3610f85e193739c953358c865005855253af4f68a497John McCall 3611f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 3612f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 3613929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 361406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 361506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 361606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 36177ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 36187ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 36197ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 3620bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 3621bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 3622bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 3623bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 3624bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 3625bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3626bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 3627bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 3628bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 3629bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3630bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3631bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 3632bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 3633bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3634bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 3635bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 3636bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 3637bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 3638bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 3639bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3640bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3641bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3642bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 3643bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3644bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 36450f38acee92014cb15af980808f87144e5564031dAnna Zaksstatic bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty, 36460f38acee92014cb15af980808f87144e5564031dAnna Zaks ASTContext &Context) { 36470f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only handle constant-sized or VLAs, but not flexible members. 36480f38acee92014cb15af980808f87144e5564031dAnna Zaks if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) { 36490f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only issue the FIXIT for arrays of size > 1. 36500f38acee92014cb15af980808f87144e5564031dAnna Zaks if (CAT->getSize().getSExtValue() <= 1) 36510f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 36520f38acee92014cb15af980808f87144e5564031dAnna Zaks } else if (!Ty->isVariableArrayType()) { 36530f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 36540f38acee92014cb15af980808f87144e5564031dAnna Zaks } 36550f38acee92014cb15af980808f87144e5564031dAnna Zaks return true; 36560f38acee92014cb15af980808f87144e5564031dAnna Zaks} 36570f38acee92014cb15af980808f87144e5564031dAnna Zaks 3658bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 3659bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 3660bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 3661bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 3662bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3663bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 3664bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 3665bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3666bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3667bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 3668bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 3669bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 3670bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3671bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 3672bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 3673bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 3674bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 3675bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 3676bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 3677180f47959a066795cc0f409433023af448bb0328Richard Smith if (SizeCall->isBuiltinCall() == Builtin::BIstrlen 3678bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 3679bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 3680bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3681bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3682bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3683bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 3684bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3685bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3686bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 3687bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 3688bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 3689bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 3690bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 3691bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 3692bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3693bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3694bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 3695bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 3696bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 3697bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3698bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3699bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 3700bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 3701bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 3702bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3703bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 3704bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 3705bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 3706bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 3707bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 37080f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context)) 37098f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 37108f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 3711f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 37128f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 37138f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 3714d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 37158f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 37168f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 37178f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 37188f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 37198f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 3720bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3721bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3722c36bedc90c687caa71748480c60707ea4608b092Anna Zaks/// Check if two expressions refer to the same declaration. 3723c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic bool referToTheSameDecl(const Expr *E1, const Expr *E2) { 3724c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1)) 3725c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2)) 3726c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return D1->getDecl() == D2->getDecl(); 3727c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return false; 3728c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3729c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3730c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic const Expr *getStrlenExprArg(const Expr *E) { 3731c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { 3732c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const FunctionDecl *FD = CE->getDirectCallee(); 3733c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen) 3734c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3735c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return CE->getArg(0)->IgnoreParenCasts(); 3736c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3737c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3738c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3739c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3740c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// Warn on anti-patterns as the 'size' argument to strncat. 3741c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// The correct size argument should look like following: 3742c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// strncat(dst, src, sizeof(dst) - strlen(dest) - 1); 3743c36bedc90c687caa71748480c60707ea4608b092Anna Zaksvoid Sema::CheckStrncatArguments(const CallExpr *CE, 3744c36bedc90c687caa71748480c60707ea4608b092Anna Zaks IdentifierInfo *FnName) { 3745c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Don't crash if the user has the wrong number of arguments. 3746c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (CE->getNumArgs() < 3) 3747c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3748c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts(); 3749c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts(); 3750c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts(); 3751c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3752c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Identify common expressions, which are wrongly used as the size argument 3753c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // to strncat and may lead to buffer overflows. 3754c36bedc90c687caa71748480c60707ea4608b092Anna Zaks unsigned PatternType = 0; 3755c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) { 3756c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) 3757c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(SizeOfArg, DstArg)) 3758c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3759c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) 3760c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SizeOfArg, SrcArg)) 3761c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3762c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) { 3763c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (BE->getOpcode() == BO_Sub) { 3764c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *L = BE->getLHS()->IgnoreParenCasts(); 3765c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *R = BE->getRHS()->IgnoreParenCasts(); 3766c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) - strlen(dst) 3767c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) && 3768c36bedc90c687caa71748480c60707ea4608b092Anna Zaks referToTheSameDecl(DstArg, getStrlenExprArg(R))) 3769c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3770c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) - (anything) 3771c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L))) 3772c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3773c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3774c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3775c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3776c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 0) 3777c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3778c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3779afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // Generate the diagnostic. 3780afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceLocation SL = LenArg->getLocStart(); 3781afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceRange SR = LenArg->getSourceRange(); 3782afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceManager &SM = PP.getSourceManager(); 3783afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 3784afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // If the function is defined as a builtin macro, do not show macro expansion. 3785afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks if (SM.isMacroArgExpansion(SL)) { 3786afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SL = SM.getSpellingLoc(SL); 3787afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SR = SourceRange(SM.getSpellingLoc(SR.getBegin()), 3788afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SM.getSpellingLoc(SR.getEnd())); 3789afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks } 3790afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 37910f38acee92014cb15af980808f87144e5564031dAnna Zaks // Check if the destination is an array (rather than a pointer to an array). 37920f38acee92014cb15af980808f87144e5564031dAnna Zaks QualType DstTy = DstArg->getType(); 37930f38acee92014cb15af980808f87144e5564031dAnna Zaks bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy, 37940f38acee92014cb15af980808f87144e5564031dAnna Zaks Context); 37950f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isKnownSizeArray) { 37960f38acee92014cb15af980808f87144e5564031dAnna Zaks if (PatternType == 1) 37970f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_wrong_size) << SR; 37980f38acee92014cb15af980808f87144e5564031dAnna Zaks else 37990f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 38000f38acee92014cb15af980808f87144e5564031dAnna Zaks return; 38010f38acee92014cb15af980808f87144e5564031dAnna Zaks } 38020f38acee92014cb15af980808f87144e5564031dAnna Zaks 3803c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 1) 3804afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_large_size) << SR; 3805c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else 3806afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 3807c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3808f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 3809c36bedc90c687caa71748480c60707ea4608b092Anna Zaks llvm::raw_svector_ostream OS(sizeString); 3810c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "sizeof("; 3811d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3812c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - "; 3813c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "strlen("; 3814d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3815c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - 1"; 3816c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3817afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::note_strncat_wrong_size) 3818afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks << FixItHint::CreateReplacement(SR, OS.str()); 3819c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3820c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 382106de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 382206de276fff91264437fa75111ed76de43097e089Ted Kremenek 3823e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3824e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 3825e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars, 3826e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 382706de276fff91264437fa75111ed76de43097e089Ted Kremenek 382806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 382906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 383006de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 383106de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 383206de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 38331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 383426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 38355f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 38364e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 383726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 383826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 3839f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 38404e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 3841e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0); 3842ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 3843e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0); 384426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 384526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 384626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 384726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 384826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 384926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 385026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 385126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 385226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 385326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 385426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 385526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 385626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 385726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 385826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 385926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 386026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 386126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 386226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 386326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 386426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 386526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 386626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 386726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 386826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 386926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 387026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 387126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 387226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 387326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 387426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 387526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 387626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 387726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 387826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 387926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 388026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 388126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 388226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 388326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 388426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 388526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 388626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 388726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 388806de276fff91264437fa75111ed76de43097e089Ted Kremenek } 388906de276fff91264437fa75111ed76de43097e089Ted Kremenek} 389006de276fff91264437fa75111ed76de43097e089Ted Kremenek 389106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 389206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 389326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 389426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 389506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 389626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 389726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 389826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 389926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 390026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 390126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 390226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 390306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 3904e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 3905e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 390626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 390726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 390806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 390906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 391006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 391106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 391206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 391306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 391406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 391506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 391606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 3917e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3918e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 391926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 3920b61c294a24324ca0a403df770c01e0ba0b88770bCraig Topper return NULL; 392126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 392206de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 39230f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 3924dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 3925a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 3926fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 39271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3928f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 3929f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 393006de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 393106de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 393206de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 393306de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 393426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 393526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 393626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 393726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 393826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 393926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 394026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 394126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 394226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 394326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 3944e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(V->getInit(), refVars, ParentDecl); 394526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 394626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 394726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 394826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 394906de276fff91264437fa75111ed76de43097e089Ted Kremenek 3950fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 3951fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 3952fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 3953fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 39541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 39552de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 3956e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars, ParentDecl); 3957fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 3958fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 3959fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 39601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3961fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 3962fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 3963fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 3964fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 39652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 39661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 39672de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 3968fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 39691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3970fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 39713907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 3972fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 3973fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 3974fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 39751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3976fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 3977e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(Base, refVars, ParentDecl); 3978fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 397961f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 3980fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 3981fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 3982fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 3983fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 39841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3985fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 39869ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 39879ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 39889ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 3989e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars, ParentDecl)) 39909ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 39919ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 39929ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 39939ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 39949ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 39959ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 399606de276fff91264437fa75111ed76de43097e089Ted Kremenek 3997e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars, ParentDecl); 3998fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 399926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 400026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 4001469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 400226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 400326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 400426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 400526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 400626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 40071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 400880ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 4009e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars, 4010e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis ParentDecl); 401180ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 401254b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 401354b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 401449badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 40156eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 4016f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 40178b9414e868853fc052251455674bf7512261e14aEli Friedman case Stmt::ObjCBridgedCastExprClass: 40181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 40191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 402049badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 402149badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 40228b9414e868853fc052251455674bf7512261e14aEli Friedman Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 40238b9414e868853fc052251455674bf7512261e14aEli Friedman switch (cast<CastExpr>(E)->getCastKind()) { 40248b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BitCast: 40258b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_LValueToRValue: 40268b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_NoOp: 40278b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BaseToDerived: 40288b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_DerivedToBase: 40298b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_UncheckedDerivedToBase: 40308b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_Dynamic: 40318b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_CPointerToObjCPointerCast: 40328b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BlockPointerToObjCPointerCast: 40338b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_AnyPointerToBlockPointerCast: 4034e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(SubExpr, refVars, ParentDecl); 40358b9414e868853fc052251455674bf7512261e14aEli Friedman 40368b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_ArrayToPointerDecay: 4037e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(SubExpr, refVars, ParentDecl); 40388b9414e868853fc052251455674bf7512261e14aEli Friedman 40398b9414e868853fc052251455674bf7512261e14aEli Friedman default: 40408b9414e868853fc052251455674bf7512261e14aEli Friedman return 0; 40418b9414e868853fc052251455674bf7512261e14aEli Friedman } 4042fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 40431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 404403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 404503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 404603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 4047e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 404803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 404903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 405003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 405103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 4052fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 4053fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 4054fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 405506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 405606de276fff91264437fa75111ed76de43097e089Ted Kremenek} 40571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 405806de276fff91264437fa75111ed76de43097e089Ted Kremenek 405906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 406006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 4061e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 4062e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 406368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 4064e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 4065e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 4066e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 40671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 406806de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 406906de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 407006de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 4071f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 4072f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 407306de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 407468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 407568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 40765baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 407768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 407868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 407968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 408068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 408168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 408268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 408380ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 4084e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl); 408580ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 4086a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 408726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 408826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 408926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 409006de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 40911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4092e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) { 4093e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis // Check if it refers to itself, e.g. "int& i = i;". 4094e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (V == ParentDecl) 4095e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return DR; 4096e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis 409726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 409826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 409926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 410026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 410126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 410226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 410326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 410426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 410526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 4106e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(V->getInit(), refVars, V); 410726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 410826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 4109e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis } 41101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 411106de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 411206de276fff91264437fa75111ed76de43097e089Ted Kremenek } 41131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 411406de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 411506de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 411606de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 411706de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 411806de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 41191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 41202de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 4121e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars, ParentDecl); 412206de276fff91264437fa75111ed76de43097e089Ted Kremenek 412306de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 412406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 41251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 412606de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 412706de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 412806de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 412906de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 4130e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl); 413106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 41321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 413306de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 413406de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 413526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 413606de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 413706de276fff91264437fa75111ed76de43097e089Ted Kremenek 41383907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 41393907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 4140e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars, ParentDecl)) 41413907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 41423907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 4143e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(C->getRHS(), refVars, ParentDecl); 414406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 41451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 414606de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 414783f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 414806de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 41491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 415006de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 4151a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 4152a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 4153a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 4154a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 4155a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 4156a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 415706de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 4158a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 4159e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(M->getBase(), refVars, ParentDecl); 416006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 41611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 416203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 416303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 416403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 4165e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 416603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 416703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 416803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 416903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 417006de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 417126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 417226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 417326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 417426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 417526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 417626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 417706de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 417806de276fff91264437fa75111ed76de43097e089Ted Kremenek } 417968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 418006de276fff91264437fa75111ed76de43097e089Ted Kremenek} 4181588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 4182588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 4183588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 4184588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 4185588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 4186588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 4187dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 4188dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 4189dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 4190588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 4191588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 4192588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 4193588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 4194588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 4195588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 4196980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 41971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 41981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 41991b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 42001b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 42011b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 42021b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 42031b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 4204980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 4205980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLL->isExact()) 4206980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 4207980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie } else 4208980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)) 4209980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLR->isExact()) 4210980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 42111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4212588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 4213980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 4214980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CL->isBuiltinCall()) 4215980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 42161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4217980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 4218980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CR->isBuiltinCall()) 4219980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 42201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4221588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 4222980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie Diag(Loc, diag::warn_floatingpoint_eq) 4223980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie << LHS->getSourceRange() << RHS->getSourceRange(); 4224588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 4225ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4226f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 4227f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 4228ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4229f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 4230ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4231f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 4232f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 4233f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 4234f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 4235f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 4236ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4237f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 4238f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 423951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4240f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 4241f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 4242f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 424351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 42441844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 4245f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 4246f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 4247f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 424851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 42491844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 42501844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 42511844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 42521844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 425351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 425451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 42551844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 42561844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 4257f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 425851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4259f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 4260f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 4261f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 4262f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 4263323ed74658bc8375278eabf074b4777458376540John McCall 4264f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer // For enum types, use the known bit width of the enumerators. 4265323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 4266f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer EnumDecl *Enum = ET->getDecl(); 4267f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer if (!Enum->isCompleteDefinition()) 4268f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer return IntRange(C.getIntWidth(QualType(T, 0)), false); 4269091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4270f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer unsigned NumPositive = Enum->getNumPositiveBits(); 4271f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer unsigned NumNegative = Enum->getNumNegativeBits(); 4272323ed74658bc8375278eabf074b4777458376540John McCall 4273f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer if (NumNegative == 0) 4274f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer return IntRange(NumPositive, true/*NonNegative*/); 4275f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer else 4276f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer return IntRange(std::max(NumPositive + 1, NumNegative), 4277f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer false/*NonNegative*/); 4278323ed74658bc8375278eabf074b4777458376540John McCall } 427951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4280f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 4281f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 428251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4283f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 428451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 428551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 42861844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 42871844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 42881844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 42891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 42901844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 42911844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 42921844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 42931844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 42941844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 42951844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 42961844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 42971844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 42981844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 429969ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 43001844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 43011844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 43021844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 43031844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 43041844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 43051844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 43061844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 43071844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 4308c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 4309f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 431060fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 431160fad45739b764886f707bd204eae9ecce6db1f2John McCall } 431260fad45739b764886f707bd204eae9ecce6db1f2John McCall 43131844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 4314c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 431560fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 431660fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 431751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 4318f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 431951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 43200692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, 43210692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 4322f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 4323f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 432451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4325f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 43269f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 432751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4328f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 4329f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 4330f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 433151313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 433251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 43330692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 43340692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 4335f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 4336f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 433751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4338f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 43390acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 43400acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 43410acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 43420acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 43430acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 4344f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 434551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 434651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4347f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 4348f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 4349f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 4350f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 4351f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4352f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4353f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 4354f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 43550acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 43560acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 43570acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 435865639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman assert(result.isLValue() || result.isAddrLabelDiff()); 43595e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 436051313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 436151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 436209bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedmanstatic QualType GetExprType(Expr *E) { 436309bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman QualType Ty = E->getType(); 436409bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman if (const AtomicType *AtomicRHS = Ty->getAs<AtomicType>()) 436509bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman Ty = AtomicRHS->getValueType(); 436609bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return Ty; 436709bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman} 436809bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman 4369f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 4370f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 4371f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 4372f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 43730692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 437451313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 437551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4376f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 4377f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 437851f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, C)) 437909bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return GetValueRange(C, result.Val, GetExprType(E), MaxWidth); 438051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4381f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 4382f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 4383f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 4384f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 4385b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue) 4386f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 438751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 438809bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman IntRange OutputTypeRange = IntRange::forValueOfType(C, GetExprType(CE)); 438951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 43902de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 439160fad45739b764886f707bd204eae9ecce6db1f2John McCall 4392f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 439360fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 4394f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 439551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4396f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 4397f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 4398f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 439951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4400f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 4401f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 4402f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 440351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4404f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 4405f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 4406f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 4407f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 4408f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4409f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4410f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 4411f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 4412f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 4413f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 4414f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 4415f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 4416f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 4417f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4418f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 4419f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 4420f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 4421f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 442251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 442351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 442451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 442551313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 442651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4427f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 44282de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 44292de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 44302de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 44312de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 44322de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 44332de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 44342de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 44352de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 4436f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 443751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4438862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 4439862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 44402de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 44412de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 44422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 44432de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 44442de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 4445862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 4446862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 4447862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 444809bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 4449c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 4450862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 4451862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 4452862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 4453862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 4454862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4455862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 445651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 44572de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 44582de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 445909bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 446051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 446160fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 44622de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 44632de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 446460fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 446560fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 446660fad45739b764886f707bd204eae9ecce6db1f2John McCall 446751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 44682de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 44693aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 44703aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 44713aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 44723aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 44733aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 447409bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman IntRange R = IntRange::forValueOfType(C, GetExprType(E)); 44753aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 44763aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 44773aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 44783aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 44793aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 44802de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 448109bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 448251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 448360fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 44842de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 44852de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 448660fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 448760fad45739b764886f707bd204eae9ecce6db1f2John McCall 448860fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 448960fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 449060fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 449160fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 449260fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 449360fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 449460fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 449560fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 449660fad45739b764886f707bd204eae9ecce6db1f2John McCall else 449760fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 449860fad45739b764886f707bd204eae9ecce6db1f2John McCall } 449960fad45739b764886f707bd204eae9ecce6db1f2John McCall 450060fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 450160fad45739b764886f707bd204eae9ecce6db1f2John McCall } 450260fad45739b764886f707bd204eae9ecce6db1f2John McCall 450360fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 45042de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 4505f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4506f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 450760fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 45082de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 450951313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 451009bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 451100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 451200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 451300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 451400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 451500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 451600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 451709bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman unsigned opWidth = C.getIntWidth(GetExprType(E)); 451800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 451900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 452000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 452100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 452200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 452300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 452400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 452500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 452600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 452700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 452800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 452900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 453000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 453100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 453200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 453300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 453400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 453500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 453600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 453700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 453800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 453900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 454009bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman unsigned opWidth = C.getIntWidth(GetExprType(E)); 454100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 454200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 454300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 454400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 454500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 454600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 454700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 45484e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 454900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 455000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 455100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 455200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 455300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 4554f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 455551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 4556f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 455700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 455800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 4559f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 4560f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 4561f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 456251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 456351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 456451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 456551313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 456651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 45672de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 4568f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 456951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 457051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 45712de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 45722de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 457309bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 457451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 457551313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 4576f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 457751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 457851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 457951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4580993f43f24d7a45a5cd4678a3316b0852261fc5d4John McCall if (FieldDecl *BitField = E->getSourceBitField()) 4581a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith return IntRange(BitField->getBitWidthValue(C), 45825e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 4583f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 458409bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 4585f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4586f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 45870692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E) { 458809bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return GetExprRange(C, E, C.getIntWidth(GetExprType(E))); 4589323ed74658bc8375278eabf074b4777458376540John McCall} 4590323ed74658bc8375278eabf074b4777458376540John McCall 4591f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4592f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4593f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 45940692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const llvm::APFloat &value, 45950692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 45960692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4597f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 4598f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4599f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 4600f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 4601f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 4602f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4603f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 460451313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 460551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4606f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4607f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4608f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 4609f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 4610f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 46110692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const APValue &value, 46120692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 46130692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4614f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 4615f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 4616f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4617f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 4618f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 4619f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 4620f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 4621f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 4622f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4623f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4624f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 4625f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 4626f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 4627f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4628f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 46290692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 4630323ed74658bc8375278eabf074b4777458376540John McCall 4631e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 4632e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 4633e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 4634e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 4635e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 4636e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4637e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4638e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 4639e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 4640e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4641e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4642323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 4643323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 4644323ed74658bc8375278eabf074b4777458376540John McCall} 4645323ed74658bc8375278eabf074b4777458376540John McCall 4646372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 4647372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 4648372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 464963b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 465063b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 4651372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 465263b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 4653372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 4654372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 4655372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 4656372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 4657372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 46580692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 46592de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 466014af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 466114af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 466214af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 46632de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 4664323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4665372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 4666323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 46672de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 4668323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4669372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 4670323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 46712de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 4672323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4673372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 4674323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 46752de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 4676323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4677372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 4678323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 4679323ed74658bc8375278eabf074b4777458376540John McCall } 4680323ed74658bc8375278eabf074b4777458376540John McCall} 4681323ed74658bc8375278eabf074b4777458376540John McCall 468215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanianstatic void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E, 4683a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian Expr *Constant, Expr *Other, 468415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt Value, 4685a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian bool RhsConstant) { 4686526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // 0 values are handled later by CheckTrivialUnsignedComparison(). 4687526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (Value == 0) 4688526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4689526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 469015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian BinaryOperatorKind op = E->getOpcode(); 4691a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian QualType OtherT = Other->getType(); 4692a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian QualType ConstantT = Constant->getType(); 4693526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu QualType CommonT = E->getLHS()->getType(); 4694a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian if (S.Context.hasSameUnqualifiedType(OtherT, ConstantT)) 469515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian return; 4696a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian assert((OtherT->isIntegerType() && ConstantT->isIntegerType()) 469715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian && "comparison with non-integer type"); 4698526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4699526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool ConstantSigned = ConstantT->isSignedIntegerType(); 4700526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool CommonSigned = CommonT->isSignedIntegerType(); 4701526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4702526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool EqualityOnly = false; 4703526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4704526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // TODO: Investigate using GetExprRange() to get tighter bounds on 4705526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // on the bit ranges. 470615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT); 4707526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu unsigned OtherWidth = OtherRange.Width; 4708526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4709526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (CommonSigned) { 4710526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // The common type is signed, therefore no signed to unsigned conversion. 4711d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman if (!OtherRange.NonNegative) { 4712526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check that the constant is representable in type OtherT. 4713526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (ConstantSigned) { 4714526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getMinSignedBits()) 4715526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4716526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !ConstantSigned 4717526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits() + 1) 4718526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4719526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4720526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !OtherSigned 4721526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check that the constant is representable in type OtherT. 4722526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Negative values are out of range. 4723526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (ConstantSigned) { 4724526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (Value.isNonNegative() && OtherWidth >= Value.getActiveBits()) 4725526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4726526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !ConstantSigned 4727526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits()) 4728526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4729526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4730526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4731526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !CommonSigned 4732d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman if (OtherRange.NonNegative) { 4733526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits()) 4734526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4735d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman } else if (!OtherRange.NonNegative && !ConstantSigned) { 4736526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check to see if the constant is representable in OtherT. 4737526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth > Value.getActiveBits()) 4738526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4739526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check to see if the constant is equivalent to a negative value 4740526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // cast to CommonT. 4741526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (S.Context.getIntWidth(ConstantT) == S.Context.getIntWidth(CommonT) && 47425d1cf4f292cb060b1973eb197607fc6d5716bd12Richard Trieu Value.isNegative() && Value.getMinSignedBits() <= OtherWidth) 4743526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4744526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // The constant value rests between values that OtherT can represent after 4745526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // conversion. Relational comparison still works, but equality 4746526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // comparisons will be tautological. 4747526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu EqualityOnly = true; 4748526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // OtherSigned && ConstantSigned 4749526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu assert(0 && "Two signed types converted to unsigned types."); 4750526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4751526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4752526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4753526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool PositiveConstant = !ConstantSigned || Value.isNonNegative(); 4754526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 475515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsTrue = true; 4756526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (op == BO_EQ || op == BO_NE) { 4757526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = op == BO_NE; 4758526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else if (EqualityOnly) { 4759526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4760526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else if (RhsConstant) { 476115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (op == BO_GT || op == BO_GE) 4762526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = !PositiveConstant; 476315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else // op == BO_LT || op == BO_LE 4764526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = PositiveConstant; 4765a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian } else { 476615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (op == BO_LT || op == BO_LE) 4767526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = !PositiveConstant; 476815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else // op == BO_GT || op == BO_GE 4769526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = PositiveConstant; 477015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian } 47717adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 47727adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek // If this is a comparison to an enum constant, include that 47737adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek // constant in the diagnostic. 47747adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek const EnumConstantDecl *ED = 0; 47757adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Constant)) 47767adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek ED = dyn_cast<EnumConstantDecl>(DR->getDecl()); 47777adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 47787adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek SmallString<64> PrettySourceValue; 47797adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek llvm::raw_svector_ostream OS(PrettySourceValue); 47807adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek if (ED) 47819de50947ba381561a5236b3c878c83e4bb8c1088Ted Kremenek OS << '\'' << *ED << "' (" << Value << ")"; 47827adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek else 47837adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek OS << Value; 47847adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 4785a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian S.Diag(E->getOperatorLoc(), diag::warn_out_of_range_compare) 47867adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek << OS.str() << OtherT << IsTrue 4787526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 478815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian} 478915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4790323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 4791323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 47920692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 4793b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4794b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4795323ed74658bc8375278eabf074b4777458376540John McCall} 4796f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4797ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 4798ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 4799dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings 48000692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeComparison(Sema &S, BinaryOperator *E) { 4801323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 4802323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 4803323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 4804323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 4805ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian if (E->isValueDependent()) 4806ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian return AnalyzeImpConvsInComparison(S, E); 4807323ed74658bc8375278eabf074b4777458376540John McCall 480815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 480915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 481015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 481115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsComparisonConstant = false; 481215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4813a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian // Check whether an integer constant comparison results in a value 481415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian // of 'true' or 'false'. 481515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (T->isIntegralType(S.Context)) { 481615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt RHSValue; 481715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsRHSIntegralLiteral = 481815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian RHS->isIntegerConstantExpr(RHSValue, S.Context); 481915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt LHSValue; 482015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsLHSIntegralLiteral = 482115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian LHS->isIntegerConstantExpr(LHSValue, S.Context); 482215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (IsRHSIntegralLiteral && !IsLHSIntegralLiteral) 482315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian DiagnoseOutOfRangeComparison(S, E, RHS, LHS, RHSValue, true); 482415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else if (!IsRHSIntegralLiteral && IsLHSIntegralLiteral) 482515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian DiagnoseOutOfRangeComparison(S, E, LHS, RHS, LHSValue, false); 482615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else 482715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IsComparisonConstant = 482815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian (IsRHSIntegralLiteral && IsLHSIntegralLiteral); 4829a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian } else if (!T->hasUnsignedIntegerRepresentation()) 4830a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian IsComparisonConstant = E->isIntegerConstantExpr(S.Context); 483115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4832323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 4833323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 4834323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 48353e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 48363e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 48373e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 483815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (!T->hasUnsignedIntegerRepresentation() || IsComparisonConstant) 4839323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 484015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4841323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 4842323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 4843323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 4844dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu if (LHS->getType()->hasSignedIntegerRepresentation()) { 4845dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu assert(!RHS->getType()->hasSignedIntegerRepresentation() && 4846323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 4847dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = LHS; 4848dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = RHS; 4849dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 4850dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = RHS; 4851dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = LHS; 4852ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 4853323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 4854323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 4855ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 4856ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4857323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 4858323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 4859f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4860323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 4861323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 4862dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 4863dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 4864ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4865323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 4866323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 4867323ed74658bc8375278eabf074b4777458376540John McCall // or false. 4868323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 4869323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 4870ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4871ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 4872ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 4873ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 4874ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 4875323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 4876323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 4877323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 4878323ed74658bc8375278eabf074b4777458376540John McCall 4879323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 4880323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 4881323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 4882ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4883323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 4884323ed74658bc8375278eabf074b4777458376540John McCall return; 4885323ed74658bc8375278eabf074b4777458376540John McCall } 4886323ed74658bc8375278eabf074b4777458376540John McCall 48876d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.DiagRuntimeBehavior(E->getOperatorLoc(), E, 48886d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.PDiag(diag::warn_mixed_sign_comparison) 48896d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getType() << RHS->getType() 48906d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getSourceRange() << RHS->getSourceRange()); 4891ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 4892ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 489315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 489415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 489515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 48960692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 48970692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek SourceLocation InitLoc) { 489815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 489915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 490015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 490115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 490291b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 490391b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 490491b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 490591b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 490646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 490746ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 490846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 490946ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 491046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 491146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 491246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 491315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 491415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 491580d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith llvm::APSInt Value; 491680d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects)) 491715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 491815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 491915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 4920a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 492115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 492215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 492315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 492415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 49253a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Compute the value which the bitfield will contain. 49269f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 49273a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType()); 492815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 49293a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Check whether the stored value is equal to the original value. 49303a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue = TruncatedValue.extend(OriginalWidth); 4931e1ecdc168175719d74e112bcacd4aae5e12d4631Richard Trieu if (llvm::APSInt::isSameValue(Value, TruncatedValue)) 493215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 493315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 49343a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Special-case bitfields of width 1: booleans are naturally 0/1, and 493534ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman // therefore don't strictly fit into a signed bitfield of width 1. 493634ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman if (FieldWidth == 1 && Value == 1) 49373a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman return false; 49383a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman 493915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 494015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 494115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 494215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 494315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 494415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 494515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 494615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 494715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 494815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 4949beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 4950beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 49510692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeAssignment(Sema &S, BinaryOperator *E) { 4952beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 4953beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4954beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4955beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 4956beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 4957993f43f24d7a45a5cd4678a3316b0852261fc5d4John McCall if (FieldDecl *Bitfield = E->getLHS()->getSourceBitField()) { 4958dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 495915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 496015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 496115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 496215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 4963beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4964beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4965beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4966beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4967beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 4968beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 496951313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 49700692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 4971c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4972c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4973c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (pruneControlFlow) { 4974c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.DiagRuntimeBehavior(E->getExprLoc(), E, 4975c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.PDiag(diag) 4976c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceType << T << E->getSourceRange() 4977c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceRange(CContext)); 4978c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 4979c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 49805a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 49815a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 49825a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 49835a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 4984e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 49850692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType T, 4986c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4987c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4988c36bedc90c687caa71748480c60707ea4608b092Anna Zaks DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow); 4989e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 4990e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 49919ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the 49929ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information. 4993f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 4994f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 49959ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay // Try to convert the literal exactly to an integer. If we can, don't warn. 4996f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 49979ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay const llvm::APFloat &Value = FL->getValue(); 49983e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 49993e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 50003e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 5001f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 50029ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay == llvm::APFloat::opOK && isExact) 5003f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 5004f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 5005be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie SmallString<16> PrettySourceValue; 5006be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie Value.toString(PrettySourceValue); 5007de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie SmallString<16> PrettyTargetValue; 5008be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (T->isSpecificBuiltinType(BuiltinType::Bool)) 5009be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie PrettyTargetValue = IntegerValue == 0 ? "false" : "true"; 5010be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie else 5011de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie IntegerValue.toString(PrettyTargetValue); 5012be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 50139ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 5014be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << FL->getType() << T.getUnqualifiedType() << PrettySourceValue 5015be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext); 5016f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 5017f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 5018091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 5019091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 5020091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 5021091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 5022091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 50239f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 5024091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 5025091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 5026091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 502788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgstatic bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) { 502888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!isa<ImplicitCastExpr>(Ex)) 502988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 503088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 503188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = Ex->IgnoreParenImpCasts(); 503288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr(); 503388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Source = 503488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 503588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isDependentType()) 503688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 503788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 503888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const BuiltinType *FloatCandidateBT = 503988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg dyn_cast<BuiltinType>(ToBool ? Source : Target); 504088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *BoolCandidateType = ToBool ? Target : Source; 504188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 504288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) && 504388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg FloatCandidateBT && (FloatCandidateBT->isFloatingPoint())); 504488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 504588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 504688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgvoid CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall, 504788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg SourceLocation CC) { 504888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = TheCall->getNumArgs(); 504988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg for (unsigned i = 0; i < NumArgs; ++i) { 505088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *CurrA = TheCall->getArg(i); 505188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!IsImplicitBoolFloatConversion(S, CurrA, true)) 505288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg continue; 505388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 505488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg bool IsSwapped = ((i > 0) && 505588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false)); 505688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsSwapped |= ((i < (NumArgs - 1)) && 505788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false)); 505888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (IsSwapped) { 505988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion. 506088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(), 506188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CurrA->getType(), CC, 506288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 506388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 506488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 506588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 506688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 5067323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 5068dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov SourceLocation CC, bool *ICContext = 0) { 5069323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 507051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5071323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 5072323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 5073323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 5074323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 507551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5076108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 5077108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 5078108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 5079108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 5080108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 5081ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 5082b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 5083b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 5084f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Diagnose implicit casts to bool. 5085f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 5086f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (isa<StringLiteral>(E)) 5087f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Warn on string literal to bool. Checks for string literals in logical 5088f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // expressions, for instances, assert(0 && "error here"), is prevented 5089f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // by a check in AnalyzeImplicitConversions(). 5090f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu return DiagnoseImpCast(S, E, T, CC, 5091f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu diag::warn_impcast_string_literal_to_bool); 5092e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (Source->isFunctionType()) { 5093e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // Warn on function to bool. Checks free functions and static member 5094e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // functions. Weakly imported functions are excluded from the check, 5095e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // since it's common to test their value to check whether the linker 5096e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // found a definition for them. 5097e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames ValueDecl *D = 0; 5098e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) { 5099e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = R->getDecl(); 5100e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) { 5101e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = M->getMemberDecl(); 5102e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 5103e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames 5104e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (D && !D->isWeak()) { 510526b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) { 510626b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool) 510726b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu << F << E->getSourceRange() << SourceRange(CC); 51082def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence) 51092def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion(E->getExprLoc(), "&"); 51102def77399ab3088106a2d61372344f5b7104e1a2David Blaikie QualType ReturnType; 51112def77399ab3088106a2d61372344f5b7104e1a2David Blaikie UnresolvedSet<4> NonTemplateOverloads; 5112c8fa525b5b81eeb7a62294dd3218ca2a6ccf0a6aDavid Blaikie S.tryExprAsCall(*E, ReturnType, NonTemplateOverloads); 51132def77399ab3088106a2d61372344f5b7104e1a2David Blaikie if (!ReturnType.isNull() 51142def77399ab3088106a2d61372344f5b7104e1a2David Blaikie && ReturnType->isSpecificBuiltinType(BuiltinType::Bool)) 51152def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_call) 51162def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion( 51172def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()"); 511826b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu return; 511926b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu } 5120e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 5121e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 5122f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 512351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 512451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 512551313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 5126ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 5127d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5128ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5129b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 5130ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 5131b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 5132b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 5133b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 5134b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 5135b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 513651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 513751313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 513851313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 513951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 514051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 514151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 514251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 5143ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 5144d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5145ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5146ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5147b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 5148ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 514951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 515051313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 515151313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 515251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 515351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 515451313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 515551313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 515651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 515751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 515851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 515951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 516051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 516151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 516251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 516351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 516451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 516551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 516651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 516751313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 516851f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, S.Context)) { 516951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 517051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 5171323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 5172323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 517351313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 517451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 517551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5176d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5177ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5178ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5179b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 518051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 518151313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 518251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 518351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5184ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 5185be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (TargetBT && TargetBT->isInteger()) { 5186d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5187ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5188ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5189a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 5190634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay // We also want to warn on, e.g., "int i = -1.234" 5191634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 5192634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 5193634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 5194634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay 5195f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 5196f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 5197a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 5198a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 5199a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 5200a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 520151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 520288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // If the target is bool, warn if expr is a function or method call. 520388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isSpecificBuiltinType(BuiltinType::Bool) && 520488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg isa<CallExpr>(E)) { 520588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check last argument of function call to see if it is an 520688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // implicit cast from a type matching the type the result 520788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // is being cast to. 520888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CallExpr *CEx = cast<CallExpr>(E); 520988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = CEx->getNumArgs(); 521088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (NumArgs > 0) { 521188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *LastA = CEx->getArg(NumArgs - 1); 521288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = LastA->IgnoreParenImpCasts(); 521388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *InnerType = 521488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 521588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (isa<ImplicitCastExpr>(LastA) && (InnerType == Target)) { 521688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion 521788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, E, T, CC, 521888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 521988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 522088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 522188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 522251313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 522351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 522451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 52251838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 5226b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie == Expr::NPCK_GNUNull) && !Target->isAnyPointerType() 5227e81b43bc306d361fcf4d411aeb14b43f8464bf4aDavid Blaikie && !Target->isBlockPointerType() && !Target->isMemberPointerType() 5228896c7dd62801c0aacf14b05183c3c471c1fe9f7aDavid Blaikie && Target->isScalarType() && !Target->isNullPtrType()) { 5229b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie SourceLocation Loc = E->getSourceRange().getBegin(); 5230b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie if (Loc.isMacroID()) 5231b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first; 52329fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie if (!Loc.isMacroID() || CC.isMacroID()) 52339fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer) 52349fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << T << clang::SourceRange(CC) 52359fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << FixItHint::CreateReplacement(Loc, S.getFixItZeroLiteralForType(T)); 52361838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 52371838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 5238b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie if (!Source->isIntegerType() || !Target->isIntegerType()) 5239b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie return; 5240b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie 5241be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // TODO: remove this early return once the false positives for constant->bool 5242be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // in templates, macros, etc, are reduced or removed. 5243be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 5244be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie return; 5245be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 5246323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 52471844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 524851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5249dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (SourceRange.Width > TargetRange.Width) { 525025ffbef84450f0c666957a2d00cdf928c61b44d7Sam Panzer // If the source is a constant, use a default-on diagnostic. 5251dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // TODO: this should happen for bitfield stores, too. 5252dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov llvm::APSInt Value(32); 5253dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (E->isIntegerConstantExpr(Value, S.Context)) { 5254dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (S.SourceMgr.isInSystemMacro(CC)) 5255dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov return; 5256dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 5257091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 5258091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 5259dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 52605e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.DiagRuntimeBehavior(E->getExprLoc(), E, 52615e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.PDiag(diag::warn_impcast_integer_precision_constant) 52625e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << PrettySourceValue << PrettyTargetValue 52635e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << E->getType() << T << E->getSourceRange() 52645e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << clang::SourceRange(CC)); 5265091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 5266091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 5267091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 5268dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // People want to build with -Wshorten-64-to-32 and not -Wconversion. 5269dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (S.SourceMgr.isInSystemMacro(CC)) 5270dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov return; 5271dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 527237050841d7b852497b85d5275d9ea92c07ddf059David Blaikie if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64) 5273c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32, 5274c36bedc90c687caa71748480c60707ea4608b092Anna Zaks /* pruneControlFlow */ true); 5275b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 5276323ed74658bc8375278eabf074b4777458376540John McCall } 5277323ed74658bc8375278eabf074b4777458376540John McCall 5278323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 5279323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 5280323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 5281ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5282d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5283ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5284ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5285323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 5286323ed74658bc8375278eabf074b4777458376540John McCall 5287323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 5288323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 5289323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 5290323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 5291323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 5292323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 5293323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 5294323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 5295323ed74658bc8375278eabf074b4777458376540John McCall } 5296323ed74658bc8375278eabf074b4777458376540John McCall 5297b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 529851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 529951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5300284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 53015a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 53025a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 53035a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 53044e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (!S.getLangOpts().CPlusPlus) { 53055a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 53065a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 53075a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 53085a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 53095a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 53105a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 53115a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 53125a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 5313284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 5314284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 531583972f128e9218c051692bf96361327a701aeb79John McCall if (SourceEnum->getDecl()->hasNameForLinkage() && 531683972f128e9218c051692bf96361327a701aeb79John McCall TargetEnum->getDecl()->hasNameForLinkage() && 5317ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 5318d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5319ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5320ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 53215a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 5322284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 5323ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 5324284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 532551313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 532651313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 532751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 53289fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 53299fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T); 5330323ed74658bc8375278eabf074b4777458376540John McCall 5331323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 5332b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 5333323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 5334323ed74658bc8375278eabf074b4777458376540John McCall 5335323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 53369fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T); 5337323ed74658bc8375278eabf074b4777458376540John McCall 5338b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 5339323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 5340b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 5341323ed74658bc8375278eabf074b4777458376540John McCall return; 5342323ed74658bc8375278eabf074b4777458376540John McCall} 5343323ed74658bc8375278eabf074b4777458376540John McCall 53449fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 53459fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T) { 5346b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 5347323ed74658bc8375278eabf074b4777458376540John McCall 5348323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 5349b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 5350b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 5351323ed74658bc8375278eabf074b4777458376540John McCall 5352323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 5353323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 5354323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 5355323ed74658bc8375278eabf074b4777458376540John McCall 5356323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 53570827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 53580827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 5359323ed74658bc8375278eabf074b4777458376540John McCall return; 5360323ed74658bc8375278eabf074b4777458376540John McCall 5361323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 5362323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 53635254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 53645254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 53655254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 53665254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 53675254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 53685254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 53695254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 5370b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 5371323ed74658bc8375278eabf074b4777458376540John McCall} 5372323ed74658bc8375278eabf074b4777458376540John McCall 5373323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 5374323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 5375323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 5376b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 5377323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 5378323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 5379323ed74658bc8375278eabf074b4777458376540John McCall 5380f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 5381f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor return; 5382f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor 5383323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 5384323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 5385323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 5386323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 53879fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie CheckConditionalOperator(S, CO, CC, T); 5388323ed74658bc8375278eabf074b4777458376540John McCall return; 5389323ed74658bc8375278eabf074b4777458376540John McCall } 5390323ed74658bc8375278eabf074b4777458376540John McCall 539188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check implicit argument conversions for function calls. 539288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (CallExpr *Call = dyn_cast<CallExpr>(E)) 539388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CheckImplicitArgumentConversions(S, Call, CC); 539488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 5395323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 5396323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 5397323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 5398323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 5399b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 5400323ed74658bc8375278eabf074b4777458376540John McCall 5401323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 54026f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian 54036f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian if (PseudoObjectExpr * POE = dyn_cast<PseudoObjectExpr>(E)) { 5404a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian if (POE->getResultExpr()) 5405a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian E = POE->getResultExpr(); 54066f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian } 54076f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian 5408a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian if (const OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(E)) 5409a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian return AnalyzeImplicitConversions(S, OVE->getSourceExpr(), CC); 5410a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian 5411323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 5412323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 5413323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 5414b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 5415323ed74658bc8375278eabf074b4777458376540John McCall } 5416323ed74658bc8375278eabf074b4777458376540John McCall 5417beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 5418beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 5419beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 5420beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 5421beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 5422dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // And with simple assignments. 5423dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (BO->getOpcode() == BO_Assign) 5424beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 5425beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 5426323ed74658bc8375278eabf074b4777458376540John McCall 5427323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 5428323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 5429323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 5430323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 5431323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 5432323ed74658bc8375278eabf074b4777458376540John McCall 5433323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 5434f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 5435323ed74658bc8375278eabf074b4777458376540John McCall 5436323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 5437b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 5438f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 5439f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu bool IsLogicalOperator = BO && BO->isLogicalOp(); 5440f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu for (Stmt::child_range I = E->children(); I; ++I) { 544154042f1bd78f1f1ea86be7d4af541462e127d2edDouglas Gregor Expr *ChildExpr = dyn_cast_or_null<Expr>(*I); 5442503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor if (!ChildExpr) 5443503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor continue; 5444503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor 5445f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (IsLogicalOperator && 5446f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 5447f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Ignore checking string literals that are in logical operators. 5448f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu continue; 5449f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu AnalyzeImplicitConversions(S, ChildExpr, CC); 5450f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 5451323ed74658bc8375278eabf074b4777458376540John McCall} 5452323ed74658bc8375278eabf074b4777458376540John McCall 5453323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 5454323ed74658bc8375278eabf074b4777458376540John McCall 5455323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 5456323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 5457323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 5458b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 5459b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 5460b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 5461b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 5462b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 5463323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 546471f55f771794674a410171dbf3cb5dbedf95d033David Blaikie if (isUnevaluatedContext()) 5465323ed74658bc8375278eabf074b4777458376540John McCall return; 5466323ed74658bc8375278eabf074b4777458376540John McCall 5467323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 5468323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 5469323ed74658bc8375278eabf074b4777458376540John McCall return; 5470323ed74658bc8375278eabf074b4777458376540John McCall 5471d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 5472d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 5473d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 5474d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 5475d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5476b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 5477b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 5478323ed74658bc8375278eabf074b4777458376540John McCall} 5479323ed74658bc8375278eabf074b4777458376540John McCall 5480ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian/// Diagnose when expression is an integer constant expression and its evaluation 5481ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian/// results in integer overflow 5482ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanianvoid Sema::CheckForIntOverflow (Expr *E) { 54831fd8d46d222fab7f17b91846e2c50bef640a60a0Fariborz Jahanian if (isa<BinaryOperator>(E->IgnoreParens())) { 5484ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian llvm::SmallVector<PartialDiagnosticAt, 4> Diags; 5485ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian E->EvaluateForOverflow(Context, &Diags); 5486ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian } 5487ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian} 5488ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian 54896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithnamespace { 54906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith/// \brief Visitor for expressions which looks for unsequenced operations on the 54916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith/// same object. 54926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithclass SequenceChecker : public EvaluatedExprVisitor<SequenceChecker> { 54930c0b3909d11de7440d77556089516918b9c04cefRichard Smith typedef EvaluatedExprVisitor<SequenceChecker> Base; 54940c0b3909d11de7440d77556089516918b9c04cefRichard Smith 54956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief A tree of sequenced regions within an expression. Two regions are 54966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// unsequenced if one is an ancestor or a descendent of the other. When we 54976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// finish processing an expression with sequencing, such as a comma 54986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// expression, we fold its tree nodes into its parent, since they are 54996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// unsequenced with respect to nodes we will visit later. 55006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith class SequenceTree { 55016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct Value { 55026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith explicit Value(unsigned Parent) : Parent(Parent), Merged(false) {} 55036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Parent : 31; 55046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Merged : 1; 55056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 55066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<Value, 8> Values; 55076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith public: 55096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief A region within an expression which may be sequenced with respect 55106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// to some other region. 55116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith class Seq { 55126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith explicit Seq(unsigned N) : Index(N) {} 55136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Index; 55146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith friend class SequenceTree; 55156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith public: 55166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq() : Index(0) {} 55176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 55186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree() { Values.push_back(Value(0)); } 55206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq root() const { return Seq(0); } 55216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Create a new sequence of operations, which is an unsequenced 55236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// subset of \p Parent. This sequence of operations is sequenced with 55246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// respect to other children of \p Parent. 55256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq allocate(Seq Parent) { 55266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Values.push_back(Value(Parent.Index)); 55276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return Seq(Values.size() - 1); 55286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Merge a sequence of operations into its parent. 55316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void merge(Seq S) { 55326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Values[S.Index].Merged = true; 55336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Determine whether two operations are unsequenced. This operation 55366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// is asymmetric: \p Cur should be the more recent sequence, and \p Old 55376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// should have been merged into its parent as appropriate. 55386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool isUnsequenced(Seq Cur, Seq Old) { 55396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned C = representative(Cur.Index); 55406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Target = representative(Old.Index); 55416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith while (C >= Target) { 55426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (C == Target) 55436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return true; 55446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith C = Values[C].Parent; 55456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return false; 55476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith private: 55506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Pick a representative for a sequence. 55516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned representative(unsigned K) { 55526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Values[K].Merged) 55536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Perform path compression as we go. 55546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return Values[K].Parent = representative(Values[K].Parent); 55556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return K; 55566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 55586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// An object for which we can track unsequenced uses. 55606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith typedef NamedDecl *Object; 55616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Different flavors of object usage which we track. We only track the 55636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// least-sequenced usage of each kind. 55646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith enum UsageKind { 55656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A read of an object. Multiple unsequenced reads are OK. 55666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_Use, 55676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A modification of an object which is sequenced before the value 5568418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith /// computation of the expression, such as ++n in C++. 55696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_ModAsValue, 55706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A modification of an object which is not sequenced before the value 55716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// computation of the expression, such as n++. 55726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_ModAsSideEffect, 55736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_Count = UK_ModAsSideEffect + 1 55756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 55766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct Usage { 55786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage() : Use(0), Seq() {} 55796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *Use; 55806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Seq; 55816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 55826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct UsageInfo { 55846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo() : Diagnosed(false) {} 55856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage Uses[UK_Count]; 55866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Have we issued a diagnostic for this variable already? 55876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Diagnosed; 55886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 55896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith typedef llvm::SmallDenseMap<Object, UsageInfo, 16> UsageInfoMap; 55906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Sema &SemaRef; 55926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Sequenced regions within the expression. 55936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree Tree; 55946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Declaration modifications and references which we have seen. 55956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfoMap UsageMap; 55966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// The region we are currently within. 55976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Region; 55986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Filled in with declarations which were modified as a side-effect 55996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// (that is, post-increment operations). 56006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVectorImpl<std::pair<Object, Usage> > *ModAsSideEffect; 56011a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith /// Expressions to check later. We defer checking these to reduce 56021a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith /// stack usage. 56031a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVectorImpl<Expr*> &WorkList; 56046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// RAII object wrapping the visitation of a sequenced subexpression of an 56066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// expression. At the end of this process, the side-effects of the evaluation 56076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// become sequenced with respect to the value computation of the result, so 56086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// we downgrade any UK_ModAsSideEffect within the evaluation to 56096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// UK_ModAsValue. 56106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct SequencedSubexpression { 56116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression(SequenceChecker &Self) 56126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith : Self(Self), OldModAsSideEffect(Self.ModAsSideEffect) { 56136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.ModAsSideEffect = &ModAsSideEffect; 56146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ~SequencedSubexpression() { 56166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0, E = ModAsSideEffect.size(); I != E; ++I) { 56176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = Self.UsageMap[ModAsSideEffect[I].first]; 56186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Uses[UK_ModAsSideEffect] = ModAsSideEffect[I].second; 56196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.addUsage(U, ModAsSideEffect[I].first, 56206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ModAsSideEffect[I].second.Use, UK_ModAsValue); 56216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.ModAsSideEffect = OldModAsSideEffect; 56236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceChecker &Self; 56266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<std::pair<Object, Usage>, 4> ModAsSideEffect; 56276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVectorImpl<std::pair<Object, Usage> > *OldModAsSideEffect; 56286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 56296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 5630674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// RAII object wrapping the visitation of a subexpression which we might 5631674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// choose to evaluate as a constant. If any subexpression is evaluated and 5632674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// found to be non-constant, this allows us to suppress the evaluation of 5633674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// the outer expression. 5634674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith class EvaluationTracker { 5635674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith public: 5636674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker(SequenceChecker &Self) 5637674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith : Self(Self), Prev(Self.EvalTracker), EvalOK(true) { 5638674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith Self.EvalTracker = this; 5639674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } 5640674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith ~EvaluationTracker() { 5641674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith Self.EvalTracker = Prev; 5642674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Prev) 5643674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith Prev->EvalOK &= EvalOK; 5644674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } 5645674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith 5646674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith bool evaluate(const Expr *E, bool &Result) { 5647674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (!EvalOK || E->isValueDependent()) 5648674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith return false; 5649674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvalOK = E->EvaluateAsBooleanCondition(Result, Self.SemaRef.Context); 5650674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith return EvalOK; 5651674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } 5652674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith 5653674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith private: 5654674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith SequenceChecker &Self; 5655674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker *Prev; 5656674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith bool EvalOK; 5657674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } *EvalTracker; 5658674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith 56596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Find the object which is produced by the specified expression, 56606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// if any. 56616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object getObject(Expr *E, bool Mod) const { 56626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith E = E->IgnoreParenCasts(); 56636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 56646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Mod && (UO->getOpcode() == UO_PreInc || UO->getOpcode() == UO_PreDec)) 56656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(UO->getSubExpr(), Mod); 56666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 56676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (BO->getOpcode() == BO_Comma) 56686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(BO->getRHS(), Mod); 56696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Mod && BO->isAssignmentOp()) 56706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(BO->getLHS(), Mod); 56716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (MemberExpr *ME = dyn_cast<MemberExpr>(E)) { 56726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // FIXME: Check for more interesting cases, like "x.n = ++x.n". 56736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CXXThisExpr>(ME->getBase()->IgnoreParenCasts())) 56746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return ME->getMemberDecl(); 56756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 56766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // FIXME: If this is a reference, map through to its value. 56776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return DRE->getDecl(); 56786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return 0; 56796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Note that an object was modified or used by an expression. 56826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void addUsage(UsageInfo &UI, Object O, Expr *Ref, UsageKind UK) { 56836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage &U = UI.Uses[UK]; 56846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) { 56856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UK == UK_ModAsSideEffect && ModAsSideEffect) 56866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ModAsSideEffect->push_back(std::make_pair(O, U)); 56876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Use = Ref; 56886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Seq = Region; 56896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Check whether a modification or use conflicts with a prior usage. 56926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void checkUsage(Object O, UsageInfo &UI, Expr *Ref, UsageKind OtherKind, 56936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool IsModMod) { 56946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UI.Diagnosed) 56956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return; 56966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith const Usage &U = UI.Uses[OtherKind]; 56986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) 56996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return; 57006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *Mod = U.Use; 57026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *ModOrUse = Ref; 57036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (OtherKind == UK_Use) 57046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith std::swap(Mod, ModOrUse); 57056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SemaRef.Diag(Mod->getExprLoc(), 57076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith IsModMod ? diag::warn_unsequenced_mod_mod 57086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith : diag::warn_unsequenced_mod_use) 57096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith << O << SourceRange(ModOrUse->getExprLoc()); 57106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UI.Diagnosed = true; 57116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePreUse(Object O, Expr *Use) { 57146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 57156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Uses conflict with other modifications. 57166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsValue, false); 57176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePostUse(Object O, Expr *Use) { 57196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 57206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsSideEffect, false); 57216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith addUsage(U, O, Use, UK_Use); 57226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePreMod(Object O, Expr *Mod) { 57256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 57266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Modifications conflict with other modifications and with uses. 57276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Mod, UK_ModAsValue, true); 57286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Mod, UK_Use, false); 57296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePostMod(Object O, Expr *Use, UsageKind UK) { 57316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 57326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsSideEffect, true); 57336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith addUsage(U, O, Use, UK); 57346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithpublic: 57371a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith SequenceChecker(Sema &S, Expr *E, 57381a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVectorImpl<Expr*> &WorkList) 57390c0b3909d11de7440d77556089516918b9c04cefRichard Smith : Base(S.Context), SemaRef(S), Region(Tree.root()), 57400c0b3909d11de7440d77556089516918b9c04cefRichard Smith ModAsSideEffect(0), WorkList(WorkList), EvalTracker(0) { 57416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(E); 57426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitStmt(Stmt *S) { 57456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Skip all statements which aren't expressions for now. 57466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitExpr(Expr *E) { 57496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // By default, just recurse to evaluated subexpressions. 57500c0b3909d11de7440d77556089516918b9c04cefRichard Smith Base::VisitStmt(E); 57516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCastExpr(CastExpr *E) { 57546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = Object(); 57556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (E->getCastKind() == CK_LValueToRValue) 57566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith O = getObject(E->getSubExpr(), false); 57576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (O) 57596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreUse(O, E); 57606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith VisitExpr(E); 57616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (O) 57626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostUse(O, E); 57636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinComma(BinaryOperator *BO) { 57666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // C++11 [expr.comma]p1: 57676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Every value computation and side effect associated with the left 57686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // expression is sequenced before every value computation and side 57696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // effect associated with the right expression. 57706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq LHS = Tree.allocate(Region); 57716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq RHS = Tree.allocate(Region); 57726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq OldRegion = Region; 57736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 57756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression SeqLHS(*this); 57766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = LHS; 57776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 57786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = RHS; 57816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getRHS()); 57826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = OldRegion; 57846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that LHS and RHS are sequenced. They are both unsequenced 57866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // with respect to other stuff. 57876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(LHS); 57886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(RHS); 57896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinAssign(BinaryOperator *BO) { 57926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // The modification is sequenced after the value computation of the LHS 57936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // and RHS, so check it before inspecting the operands and update the 57946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // map afterwards. 57956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(BO->getLHS(), true); 57966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 57976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(BO); 57986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, BO); 58006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // C++11 [expr.ass]p7: 58026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // E1 op= E2 is equivalent to E1 = E1 op E2, except that E1 is evaluated 58036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // only once. 58046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // 58056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Therefore, for a compound assignment operator, O is considered used 58066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // everywhere except within the evaluation of E1 itself. 58076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CompoundAssignOperator>(BO)) 58086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreUse(O, BO); 58096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 58116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CompoundAssignOperator>(BO)) 58136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostUse(O, BO); 58146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getRHS()); 58166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 5817418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // C++11 [expr.ass]p1: 5818418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // the assignment is sequenced [...] before the value computation of the 5819418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // assignment expression. 5820418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // C11 6.5.16/3 has no such rule. 5821418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith notePostMod(O, BO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue 5822418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith : UK_ModAsSideEffect); 58236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCompoundAssignOperator(CompoundAssignOperator *CAO) { 58256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith VisitBinAssign(CAO); 58266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreInc(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 58296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreDec(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 58306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreIncDec(UnaryOperator *UO) { 58316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(UO->getSubExpr(), true); 58326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 58336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(UO); 58346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, UO); 58366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(UO->getSubExpr()); 5837418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // C++11 [expr.pre.incr]p1: 5838418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // the expression ++x is equivalent to x+=1 5839418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith notePostMod(O, UO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue 5840418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith : UK_ModAsSideEffect); 58416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostInc(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 58446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostDec(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 58456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostIncDec(UnaryOperator *UO) { 58466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(UO->getSubExpr(), true); 58476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 58486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(UO); 58496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, UO); 58516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(UO->getSubExpr()); 58526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostMod(O, UO, UK_ModAsSideEffect); 58536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Don't visit the RHS of '&&' or '||' if it might not be evaluated. 58566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinLOr(BinaryOperator *BO) { 58576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // The side-effects of the LHS of an '&&' are sequenced before the 58586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // value computation of the RHS, and hence before the value computation 58596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // of the '&&' itself, unless the LHS evaluates to zero. We treat them 58606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // as if they were unconditionally sequenced. 5861674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker Eval(*this); 58626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 58636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression Sequenced(*this); 58646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 58656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 5868674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Eval.evaluate(BO->getLHS(), Result)) { 5869995e4a7530d705147c875b63608532c483c011a8Richard Smith if (!Result) 5870995e4a7530d705147c875b63608532c483c011a8Richard Smith Visit(BO->getRHS()); 5871995e4a7530d705147c875b63608532c483c011a8Richard Smith } else { 5872995e4a7530d705147c875b63608532c483c011a8Richard Smith // Check for unsequenced operations in the RHS, treating it as an 5873995e4a7530d705147c875b63608532c483c011a8Richard Smith // entirely separate evaluation. 5874995e4a7530d705147c875b63608532c483c011a8Richard Smith // 5875995e4a7530d705147c875b63608532c483c011a8Richard Smith // FIXME: If there are operations in the RHS which are unsequenced 5876995e4a7530d705147c875b63608532c483c011a8Richard Smith // with respect to operations outside the RHS, and those operations 5877995e4a7530d705147c875b63608532c483c011a8Richard Smith // are unconditionally evaluated, diagnose them. 58781a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(BO->getRHS()); 5879995e4a7530d705147c875b63608532c483c011a8Richard Smith } 58806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinLAnd(BinaryOperator *BO) { 5882674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker Eval(*this); 58836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 58846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression Sequenced(*this); 58856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 58866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 5889674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Eval.evaluate(BO->getLHS(), Result)) { 5890995e4a7530d705147c875b63608532c483c011a8Richard Smith if (Result) 5891995e4a7530d705147c875b63608532c483c011a8Richard Smith Visit(BO->getRHS()); 5892995e4a7530d705147c875b63608532c483c011a8Richard Smith } else { 58931a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(BO->getRHS()); 5894995e4a7530d705147c875b63608532c483c011a8Richard Smith } 58956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Only visit the condition, unless we can be sure which subexpression will 58986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // be chosen. 58996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitAbstractConditionalOperator(AbstractConditionalOperator *CO) { 5900674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker Eval(*this); 5901418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith { 5902418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith SequencedSubexpression Sequenced(*this); 5903418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith Visit(CO->getCond()); 5904418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith } 59056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 59066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 5907674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Eval.evaluate(CO->getCond(), Result)) 59086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(Result ? CO->getTrueExpr() : CO->getFalseExpr()); 5909995e4a7530d705147c875b63608532c483c011a8Richard Smith else { 59101a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(CO->getTrueExpr()); 59111a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(CO->getFalseExpr()); 5912995e4a7530d705147c875b63608532c483c011a8Richard Smith } 59136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 59146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 59150c0b3909d11de7440d77556089516918b9c04cefRichard Smith void VisitCallExpr(CallExpr *CE) { 59160c0b3909d11de7440d77556089516918b9c04cefRichard Smith // C++11 [intro.execution]p15: 59170c0b3909d11de7440d77556089516918b9c04cefRichard Smith // When calling a function [...], every value computation and side effect 59180c0b3909d11de7440d77556089516918b9c04cefRichard Smith // associated with any argument expression, or with the postfix expression 59190c0b3909d11de7440d77556089516918b9c04cefRichard Smith // designating the called function, is sequenced before execution of every 59200c0b3909d11de7440d77556089516918b9c04cefRichard Smith // expression or statement in the body of the function [and thus before 59210c0b3909d11de7440d77556089516918b9c04cefRichard Smith // the value computation of its result]. 59220c0b3909d11de7440d77556089516918b9c04cefRichard Smith SequencedSubexpression Sequenced(*this); 59230c0b3909d11de7440d77556089516918b9c04cefRichard Smith Base::VisitCallExpr(CE); 59240c0b3909d11de7440d77556089516918b9c04cefRichard Smith 59250c0b3909d11de7440d77556089516918b9c04cefRichard Smith // FIXME: CXXNewExpr and CXXDeleteExpr implicitly call functions. 59260c0b3909d11de7440d77556089516918b9c04cefRichard Smith } 59270c0b3909d11de7440d77556089516918b9c04cefRichard Smith 59286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCXXConstructExpr(CXXConstructExpr *CCE) { 59290c0b3909d11de7440d77556089516918b9c04cefRichard Smith // This is a call, so all subexpressions are sequenced before the result. 59300c0b3909d11de7440d77556089516918b9c04cefRichard Smith SequencedSubexpression Sequenced(*this); 59310c0b3909d11de7440d77556089516918b9c04cefRichard Smith 59326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!CCE->isListInitialization()) 59336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(CCE); 59346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 59356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // In C++11, list initializations are sequenced. 59366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<SequenceTree::Seq, 32> Elts; 59376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Parent = Region; 59386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (CXXConstructExpr::arg_iterator I = CCE->arg_begin(), 59396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith E = CCE->arg_end(); 59406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith I != E; ++I) { 59416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Tree.allocate(Parent); 59426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Elts.push_back(Region); 59436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(*I); 59446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 59456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 59466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that the initializers are sequenced. 59476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Parent; 59486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < Elts.size(); ++I) 59496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(Elts[I]); 59506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 59516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 59526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitInitListExpr(InitListExpr *ILE) { 59536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!SemaRef.getLangOpts().CPlusPlus11) 59546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(ILE); 59556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 59566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // In C++11, list initializations are sequenced. 59576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<SequenceTree::Seq, 32> Elts; 59586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Parent = Region; 59596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < ILE->getNumInits(); ++I) { 59606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *E = ILE->getInit(I); 59616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!E) continue; 59626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Tree.allocate(Parent); 59636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Elts.push_back(Region); 59646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(E); 59656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 59666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 59676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that the initializers are sequenced. 59686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Parent; 59696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < Elts.size(); ++I) 59706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(Elts[I]); 59716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 59726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith}; 59736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 59746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 59756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithvoid Sema::CheckUnsequencedOperations(Expr *E) { 59761a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVector<Expr*, 8> WorkList; 59771a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(E); 59781a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith while (!WorkList.empty()) { 59791a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith Expr *Item = WorkList.back(); 59801a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.pop_back(); 59811a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith SequenceChecker(*this, Item, WorkList); 59821a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith } 59836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 59846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 5985ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanianvoid Sema::CheckCompletedExpr(Expr *E, SourceLocation CheckLoc, 5986ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian bool IsConstexpr) { 59876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith CheckImplicitConversions(E, CheckLoc); 59886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith CheckUnsequencedOperations(E); 5989ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian if (!IsConstexpr && !E->isValueDependent()) 5990ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian CheckForIntOverflow(E); 59916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 59926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 599315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 599415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 599515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 599615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 599715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 599815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 5999f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 6000f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 6001f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 6002f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 6003f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 60048c0501c7370d894a735692b92fab62bbb05d86bdReid Klecknerbool Sema::CheckParmsForFunctionDef(ParmVarDecl *const *P, 60058c0501c7370d894a735692b92fab62bbb05d86bdReid Kleckner ParmVarDecl *const *PEnd, 600682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 6007f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 600882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 600982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 601082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 6011f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 6012f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 6013f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 6014f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 6015f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 6016f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 6017f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 6018d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor diag::err_typecheck_decl_incomplete_type)) { 6019f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 6020f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 6021f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 6022f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 6023f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 6024f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 602582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 602682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 6027f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 60284e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie !getLangOpts().CPlusPlus) 6029f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 6030d17e340e2d516139931768697bf080f60920ba9dSam Weinig 6031d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 6032d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 6033d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 6034d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 6035d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 6036d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 6037d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian while (const ArrayType *AT = Context.getAsArrayType(PType)) { 6038d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 6039fc09336a5965040736f9bc63a70416003972364eStefanus Du Toit // FIXME: This diagnostic should point the '[*]' if source-location 6040d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 6041d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 6042d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian break; 6043d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 6044d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian PType= AT->getElementType(); 6045d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 60469b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner 60479b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner // MSVC destroys objects passed by value in the callee. Therefore a 60489b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner // function definition which takes such a parameter must be able to call the 60499b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner // object's destructor. 60509b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner if (getLangOpts().CPlusPlus && 60519b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner Context.getTargetInfo().getCXXABI().isArgumentDestroyedByCallee()) { 60529b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner if (const RecordType *RT = Param->getType()->getAs<RecordType>()) 60539b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner FinalizeVarWithDestructor(Param, RT); 60549b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner } 6055f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 6056f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 6057f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 6058f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 6059b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 6060b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 6061b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 6062b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 6063b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 6064b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 60650827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 60660827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 6067d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie == DiagnosticsEngine::Ignored) 6068b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 6069b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 6070b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 6071b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 6072b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 6073b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 6074b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 6075b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 6076b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 6077b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 6078b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 6079b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 6080b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 6081b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 6082b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 6083b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 6084b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 6085b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 6086b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 6087b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 6088b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 6089b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 6090b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 6091b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 6092b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 6093b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 6094b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 6095b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 6096b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 6097b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 6098b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 6099b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 6100b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 6101b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 6102b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 6103b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 6104b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 6105d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 6106d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 6107d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 6108d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 6109d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 6110d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 6111d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 6112d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 6113d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 6114c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 6115c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 6116c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 6117c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 6118c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 6119c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 6120c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 6121c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 6122c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 6123c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 6124c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 6125c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 6126c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 6127c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 6128d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan 6129d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan TypeSourceInfo *TInfo = FD->getTypeSourceInfo(); 613000e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek while (TInfo) { 613100e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TypeLoc TL = TInfo->getTypeLoc(); 613200e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek // Look through typedefs. 613339e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie if (TypedefTypeLoc TTL = TL.getAs<TypedefTypeLoc>()) { 613439e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie const TypedefNameDecl *TDL = TTL.getTypedefNameDecl(); 613500e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TInfo = TDL->getTypeSourceInfo(); 613600e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek continue; 613700e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek } 613839e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie if (ConstantArrayTypeLoc CTL = TL.getAs<ConstantArrayTypeLoc>()) { 613939e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr()); 61405e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 61415e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier return false; 61425e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier } 614300e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek break; 6144d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan } 6145c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 6146c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 6147381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!RD) return false; 6148381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (RD->isUnion()) return false; 6149381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) { 6150381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!CRD->isStandardLayout()) return false; 6151381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay } 6152c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 615322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 615422d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 615522d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 615622d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 615722d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 615822d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 6159c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 6160c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 6161d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 616280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const ArraySubscriptExpr *ASE, 616325b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith bool AllowOnePastEnd, bool IndexNegated) { 616492b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman IndexExpr = IndexExpr->IgnoreParenImpCasts(); 616580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (IndexExpr->isValueDependent()) 616680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 6167d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 616880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const Type *EffectiveType = getElementType(BaseExpr); 616980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay BaseExpr = BaseExpr->IgnoreParenCasts(); 61703406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 6171d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 61723406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 6173a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 617435001ca261f895817916b468379b696d6d45959dChandler Carruth 61753406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 617680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!IndexExpr->EvaluateAsInt(index, Context)) 6177a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 617825b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith if (IndexNegated) 617925b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith index = -index; 61808fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 6181ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 6182ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 6183ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 6184c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 6185ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 6186ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 61879e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 618825b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 618935001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 619035001ca261f895817916b468379b696d6d45959dChandler Carruth return; 6191d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 6192d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 6193de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber if (BaseType != EffectiveType) { 6194d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 6195d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 6196d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 6197d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 619818f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 6199d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 6200d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 6201d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 6202d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 6203d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 6204d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 6205d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 6206d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6207d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6208d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 62093406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 621092b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman index = index.zext(size.getBitWidth()); 621125b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 621292b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman size = size.zext(index.getBitWidth()); 621325b3b849e3ad340b04442707038c86980035765bTed Kremenek 6214d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 6215d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 6216d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 6217d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 621892b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman if (AllowOnePastEnd ? index.ule(size) : index.ult(size)) 6219ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 6220ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 6221ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 6222ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 6223ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 6224d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 62258fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 62263406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 622780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // Suppress the warning if the subscript expression (as identified by the 622880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // ']' location) and the index expression are both from macro expansions 622980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // within a system header. 623080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) { 623180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation RBracketLoc = SourceMgr.getSpellingLoc( 623280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay ASE->getRBracketLoc()); 623380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isInSystemHeader(RBracketLoc)) { 623480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation IndexLoc = SourceMgr.getSpellingLoc( 623580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay IndexExpr->getLocStart()); 623680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc)) 623780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 623880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 623980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 624080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay 6241d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 624280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) 6243d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 6244d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 6245d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 6246d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 6247d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 6248d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 6249d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 62503406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 6251d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 625280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!ASE) { 6253d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 6254d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 6255d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6256d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 6257d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 6258d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 6259d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 6260a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 626135001ca261f895817916b468379b696d6d45959dChandler Carruth 6262cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (!ND) { 6263cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay // Try harder to find a NamedDecl to point at in the note. 6264cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay while (const ArraySubscriptExpr *ASE = 6265cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay dyn_cast<ArraySubscriptExpr>(BaseExpr)) 6266cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay BaseExpr = ASE->getBase()->IgnoreParenCasts(); 6267cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 6268cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(DRE->getDecl()); 6269cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 6270cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 6271cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay } 6272cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay 627335001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 6274d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 6275d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 6276d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 62773aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 62783aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 62793aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 6280d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 6281d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 6282d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 62833aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 6284d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 6285d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 628680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE, 6287d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 62883aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 6289d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6290d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 6291d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 6292d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 6293d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 6294d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 6295d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 6296d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 6297d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 6298d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 6299d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 6300d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 6301d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 6302d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 6303d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6304d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 6305d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 63063aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 63073aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 63083aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 63093aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 63103aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 63113aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 63123aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 63133aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 63143aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 63153aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 63163aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 6317f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 6318a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 6319f85e193739c953358c865005855253af4f68a497John McCall 6320f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 6321f85e193739c953358c865005855253af4f68a497John McCall 6322f85e193739c953358c865005855253af4f68a497John McCallnamespace { 6323f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 6324f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 6325f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 6326f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 6327f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 6328f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 6329f85e193739c953358c865005855253af4f68a497John McCall 6330f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 6331f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 6332f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 6333f85e193739c953358c865005855253af4f68a497John McCall } 6334f85e193739c953358c865005855253af4f68a497John McCall }; 6335f85e193739c953358c865005855253af4f68a497John McCall} 6336f85e193739c953358c865005855253af4f68a497John McCall 6337f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 6338f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 6339f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 6340f3477c13eeaf11b32a41f181398fb5deffd0dd73Sylvestre Ledru // In ARC, it's captured strongly iff the variable has __strong 6341f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 6342f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 6343f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 6344f85e193739c953358c865005855253af4f68a497John McCall return false; 6345f85e193739c953358c865005855253af4f68a497John McCall 6346f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 6347e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (ref) 6348e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose owner.setLocsFrom(ref); 6349f85e193739c953358c865005855253af4f68a497John McCall return true; 6350f85e193739c953358c865005855253af4f68a497John McCall} 6351f85e193739c953358c865005855253af4f68a497John McCall 63526e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) { 6353f85e193739c953358c865005855253af4f68a497John McCall while (true) { 6354f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 6355f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 6356f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 6357f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 6358f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 6359f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 636033e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall case CK_ARCReclaimReturnedObject: 6361f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 6362f85e193739c953358c865005855253af4f68a497John McCall continue; 6363f85e193739c953358c865005855253af4f68a497John McCall 6364f85e193739c953358c865005855253af4f68a497John McCall default: 6365f85e193739c953358c865005855253af4f68a497John McCall return false; 6366f85e193739c953358c865005855253af4f68a497John McCall } 6367f85e193739c953358c865005855253af4f68a497John McCall } 6368f85e193739c953358c865005855253af4f68a497John McCall 6369f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 6370f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 6371f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 6372f85e193739c953358c865005855253af4f68a497John McCall return false; 6373f85e193739c953358c865005855253af4f68a497John McCall 6374f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 63756e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(S, ref->getBase(), owner)) 6376f85e193739c953358c865005855253af4f68a497John McCall return false; 6377f85e193739c953358c865005855253af4f68a497John McCall 6378f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 6379f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 6380f85e193739c953358c865005855253af4f68a497John McCall return true; 6381f85e193739c953358c865005855253af4f68a497John McCall } 6382f85e193739c953358c865005855253af4f68a497John McCall 6383f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 6384f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 6385f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 6386f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 6387f85e193739c953358c865005855253af4f68a497John McCall } 6388f85e193739c953358c865005855253af4f68a497John McCall 6389f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 6390f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 6391f85e193739c953358c865005855253af4f68a497John McCall 6392f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 6393f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 6394f85e193739c953358c865005855253af4f68a497John McCall continue; 6395f85e193739c953358c865005855253af4f68a497John McCall } 6396f85e193739c953358c865005855253af4f68a497John McCall 63974b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) { 63984b9c2d235fb9449e249d74f48ecfec601650de93John McCall // Only pay attention to pseudo-objects on property references. 63994b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyRefExpr *pre 64004b9c2d235fb9449e249d74f48ecfec601650de93John McCall = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm() 64014b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->IgnoreParens()); 64024b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!pre) return false; 64034b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (pre->isImplicitProperty()) return false; 64044b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 64054b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!property->isRetaining() && 64064b9c2d235fb9449e249d74f48ecfec601650de93John McCall !(property->getPropertyIvarDecl() && 64074b9c2d235fb9449e249d74f48ecfec601650de93John McCall property->getPropertyIvarDecl()->getType() 64084b9c2d235fb9449e249d74f48ecfec601650de93John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 64094b9c2d235fb9449e249d74f48ecfec601650de93John McCall return false; 64104b9c2d235fb9449e249d74f48ecfec601650de93John McCall 64114b9c2d235fb9449e249d74f48ecfec601650de93John McCall owner.Indirect = true; 64126e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (pre->isSuperReceiver()) { 64136e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Variable = S.getCurMethodDecl()->getSelfDecl(); 64146e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!owner.Variable) 64156e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return false; 64166e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Loc = pre->getLocation(); 64176e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Range = pre->getSourceRange(); 64186e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return true; 64196e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian } 64204b9c2d235fb9449e249d74f48ecfec601650de93John McCall e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase()) 64214b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->getSourceExpr()); 64224b9c2d235fb9449e249d74f48ecfec601650de93John McCall continue; 64234b9c2d235fb9449e249d74f48ecfec601650de93John McCall } 64244b9c2d235fb9449e249d74f48ecfec601650de93John McCall 6425f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 6426f85e193739c953358c865005855253af4f68a497John McCall 6427f85e193739c953358c865005855253af4f68a497John McCall return false; 6428f85e193739c953358c865005855253af4f68a497John McCall } 6429f85e193739c953358c865005855253af4f68a497John McCall} 6430f85e193739c953358c865005855253af4f68a497John McCall 6431f85e193739c953358c865005855253af4f68a497John McCallnamespace { 6432f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 6433f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 6434f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 6435f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 6436f85e193739c953358c865005855253af4f68a497John McCall 6437f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 6438f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 6439f85e193739c953358c865005855253af4f68a497John McCall 6440f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 6441f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 6442f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 6443f85e193739c953358c865005855253af4f68a497John McCall } 6444f85e193739c953358c865005855253af4f68a497John McCall 6445f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 6446f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 6447f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 6448f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 6449f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 6450f85e193739c953358c865005855253af4f68a497John McCall } 6451f85e193739c953358c865005855253af4f68a497John McCall 6452f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 6453f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 6454f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 6455f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 6456f85e193739c953358c865005855253af4f68a497John McCall } 64577e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian 64587e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) { 64597e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (Capturer) return; 64607e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (OVE->getSourceExpr()) 64617e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian Visit(OVE->getSourceExpr()); 64627e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian } 6463f85e193739c953358c865005855253af4f68a497John McCall }; 6464f85e193739c953358c865005855253af4f68a497John McCall} 6465f85e193739c953358c865005855253af4f68a497John McCall 6466f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 6467f85e193739c953358c865005855253af4f68a497John McCall/// variable. 6468f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 6469f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 6470f85e193739c953358c865005855253af4f68a497John McCall 6471f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 64721fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose 64731fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose // Look through [^{...} copy] and Block_copy(^{...}). 64741fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(e)) { 64751fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose Selector Cmd = ME->getSelector(); 64761fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (Cmd.isUnarySelector() && Cmd.getNameForSlot(0) == "copy") { 64771fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose e = ME->getInstanceReceiver(); 64781fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (!e) 64791fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose return 0; 64801fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose e = e->IgnoreParenCasts(); 64811fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 64821fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } else if (CallExpr *CE = dyn_cast<CallExpr>(e)) { 64831fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (CE->getNumArgs() == 1) { 64841fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose FunctionDecl *Fn = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl()); 6485d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek if (Fn) { 6486d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek const IdentifierInfo *FnI = Fn->getIdentifier(); 6487d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek if (FnI && FnI->isStr("_Block_copy")) { 6488d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek e = CE->getArg(0)->IgnoreParenCasts(); 6489d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek } 6490d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek } 64911fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 64921fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 64931fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose 6494f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 6495f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 6496f85e193739c953358c865005855253af4f68a497John McCall return 0; 6497f85e193739c953358c865005855253af4f68a497John McCall 6498f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 6499f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 6500f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 6501f85e193739c953358c865005855253af4f68a497John McCall} 6502f85e193739c953358c865005855253af4f68a497John McCall 6503f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 6504f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 6505f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 6506f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 6507f85e193739c953358c865005855253af4f68a497John McCall 6508f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 6509f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 6510f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 6511f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 6512f85e193739c953358c865005855253af4f68a497John McCall} 6513f85e193739c953358c865005855253af4f68a497John McCall 6514f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 6515f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 6516f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 6517f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 6518f85e193739c953358c865005855253af4f68a497John McCall 65195f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 6520f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 6521968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (str.startswith("set")) 6522f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 6523968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek else if (str.startswith("add")) { 6524968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek // Specially whitelist 'addOperationWithBlock:'. 6525968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock")) 6526968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek return false; 6527968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek str = str.substr(3); 6528968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek } 6529f85e193739c953358c865005855253af4f68a497John McCall else 6530f85e193739c953358c865005855253af4f68a497John McCall return false; 6531f85e193739c953358c865005855253af4f68a497John McCall 6532f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 65333f6f51e28231f65de9c2dd150a2d757b2162cfa3Jordan Rose return !isLowercase(str.front()); 6534f85e193739c953358c865005855253af4f68a497John McCall} 6535f85e193739c953358c865005855253af4f68a497John McCall 6536f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 6537f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 6538f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 6539f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 6540f85e193739c953358c865005855253af4f68a497John McCall return; 6541f85e193739c953358c865005855253af4f68a497John McCall 6542f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 6543f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 6544f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 65456e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner)) 6546f85e193739c953358c865005855253af4f68a497John McCall return; 6547f85e193739c953358c865005855253af4f68a497John McCall } else { 6548f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 6549f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 6550f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 6551f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 6552f85e193739c953358c865005855253af4f68a497John McCall } 6553f85e193739c953358c865005855253af4f68a497John McCall 6554f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 6555f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 6556f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 6557f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 6558f85e193739c953358c865005855253af4f68a497John McCall} 6559f85e193739c953358c865005855253af4f68a497John McCall 6560f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 6561f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 6562f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 65636e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, receiver, owner)) 6564f85e193739c953358c865005855253af4f68a497John McCall return; 6565f85e193739c953358c865005855253af4f68a497John McCall 6566f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 6567f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 6568f85e193739c953358c865005855253af4f68a497John McCall} 6569f85e193739c953358c865005855253af4f68a497John McCall 6570e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rosevoid Sema::checkRetainCycles(VarDecl *Var, Expr *Init) { 6571e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose RetainCycleOwner Owner; 6572e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (!considerVariable(Var, /*DeclRefExpr=*/0, Owner)) 6573e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose return; 6574e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 6575e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose // Because we don't have an expression for the variable, we have to set the 6576e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose // location explicitly here. 6577e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose Owner.Loc = Var->getLocation(); 6578e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose Owner.Range = Var->getSourceRange(); 6579e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 6580e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (Expr *Capturer = findCapturingExpr(*this, Init, Owner)) 6581e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose diagnoseRetainCycle(*this, Capturer, Owner); 6582e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose} 6583e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 65849d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenekstatic bool checkUnsafeAssignLiteral(Sema &S, SourceLocation Loc, 65859d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek Expr *RHS, bool isProperty) { 65869d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // Check if RHS is an Objective-C object literal, which also can get 65879d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // immediately zapped in a weak reference. Note that we explicitly 65889d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // allow ObjCStringLiterals, since those are designed to never really die. 65899d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek RHS = RHS->IgnoreParenImpCasts(); 6590f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6591d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek // This enum needs to match with the 'select' in 6592d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek // warn_objc_arc_literal_assign (off-by-1). 6593d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek Sema::ObjCLiteralKind Kind = S.CheckLiteralKind(RHS); 6594d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek if (Kind == Sema::LK_String || Kind == Sema::LK_None) 6595d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek return false; 6596f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6597f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek S.Diag(Loc, diag::warn_arc_literal_assign) 6598d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek << (unsigned) Kind 65999d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek << (isProperty ? 0 : 1) 66009d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek << RHS->getSourceRange(); 6601f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6602f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek return true; 66039d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek} 66049d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek 6605b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenekstatic bool checkUnsafeAssignObject(Sema &S, SourceLocation Loc, 6606b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek Qualifiers::ObjCLifetime LT, 6607b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek Expr *RHS, bool isProperty) { 6608b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek // Strip off any implicit cast added to get to the one ARC-specific. 6609b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 6610b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek if (cast->getCastKind() == CK_ARCConsumeObject) { 6611b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek S.Diag(Loc, diag::warn_arc_retained_assign) 6612b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << (LT == Qualifiers::OCL_ExplicitNone) 6613b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << (isProperty ? 0 : 1) 6614b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << RHS->getSourceRange(); 6615b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return true; 6616b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek } 6617b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek RHS = cast->getSubExpr(); 6618b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek } 6619b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6620b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek if (LT == Qualifiers::OCL_Weak && 6621b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek checkUnsafeAssignLiteral(S, Loc, RHS, isProperty)) 6622b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return true; 6623b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6624b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return false; 6625b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek} 6626b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6627b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenekbool Sema::checkUnsafeAssigns(SourceLocation Loc, 6628b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek QualType LHS, Expr *RHS) { 6629b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 6630b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6631b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 6632b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return false; 6633b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6634b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (checkUnsafeAssignObject(*this, Loc, LT, RHS, false)) 6635b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return true; 6636b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6637b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return false; 6638b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek} 6639b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6640921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 6641921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 664287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian QualType LHSType; 664387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // PropertyRef on LHS type need be directly obtained from 664487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // its declaration as it has a PsuedoType. 664587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian ObjCPropertyRefExpr *PRE 664687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens()); 664787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE && !PRE->isImplicitProperty()) { 664887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 664987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PD) 665087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = PD->getType(); 665187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 665287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 665387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (LHSType.isNull()) 665487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = LHS->getType(); 66557a2704800943fbb69207e125d28186278712af36Jordan Rose 66567a2704800943fbb69207e125d28186278712af36Jordan Rose Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 66577a2704800943fbb69207e125d28186278712af36Jordan Rose 66587a2704800943fbb69207e125d28186278712af36Jordan Rose if (LT == Qualifiers::OCL_Weak) { 66597a2704800943fbb69207e125d28186278712af36Jordan Rose DiagnosticsEngine::Level Level = 66607a2704800943fbb69207e125d28186278712af36Jordan Rose Diags.getDiagnosticLevel(diag::warn_arc_repeated_use_of_weak, Loc); 66617a2704800943fbb69207e125d28186278712af36Jordan Rose if (Level != DiagnosticsEngine::Ignored) 66627a2704800943fbb69207e125d28186278712af36Jordan Rose getCurFunction()->markSafeWeakUse(LHS); 66637a2704800943fbb69207e125d28186278712af36Jordan Rose } 66647a2704800943fbb69207e125d28186278712af36Jordan Rose 6665921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 6666921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 66677a2704800943fbb69207e125d28186278712af36Jordan Rose 6668921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 6669921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 6670921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6671921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 667287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE) { 6673921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 6674921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6675921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 6676921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 6677921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6678921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 6679ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = PD->getPropertyAttributes(); 6680ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) { 668187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // when 'assign' attribute was not explicitly specified 668287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // by user, ignore it and rely on property type itself 668387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // for lifetime info. 668487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten(); 668587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) && 668687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType->isObjCRetainableType()) 668787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian return; 668887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 6689921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 669033e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 6691921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 6692921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 6693921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6694921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 6695921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 6696921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 669787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 6698ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) { 6699b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (checkUnsafeAssignObject(*this, Loc, Qualifiers::OCL_Weak, RHS, true)) 6700b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return; 6701bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian } 6702921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 6703921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 6704625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6705625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===// 6706625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6707625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkonamespace { 6708625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkobool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr, 6709625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc, 6710625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *Body) { 6711625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do not warn if the body is a macro that expands to nothing, e.g: 6712625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 6713625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // #define CALL(x) 6714625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // if (condition) 6715625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CALL(0); 6716625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 6717625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Body->hasLeadingEmptyMacro()) 6718625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6719625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6720625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Get line numbers of statement and body. 6721625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtLineInvalid; 6722625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc, 6723625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtLineInvalid); 6724625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLineInvalid) 6725625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6726625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6727625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyLineInvalid; 6728625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(), 6729625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyLineInvalid); 6730625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyLineInvalid) 6731625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6732625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6733625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Warn if null statement and body are on the same line. 6734625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLine != BodyLine) 6735625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6736625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6737625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return true; 6738625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 6739625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} // Unnamed namespace 6740625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6741625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc, 6742625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body, 6743625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID) { 6744625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Since this is a syntactic check, don't emit diagnostic for template 6745625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // instantiations, this just adds noise. 6746625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (CurrentInstantiationScope) 6747625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6748625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6749625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 6750625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 6751625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 6752625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6753625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6754625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 6755625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 6756625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6757625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6758625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 6759625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 6760625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 6761625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6762625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyLoopBody(const Stmt *S, 6763625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *PossibleBody) { 6764625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko assert(!CurrentInstantiationScope); // Ensured by caller 6765625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6766625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc; 6767625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body; 6768625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID; 6769625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (const ForStmt *FS = dyn_cast<ForStmt>(S)) { 6770625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = FS->getRParenLoc(); 6771625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = FS->getBody(); 6772625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_for_body; 6773625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) { 6774625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = WS->getCond()->getSourceRange().getEnd(); 6775625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = WS->getBody(); 6776625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_while_body; 6777625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else 6778625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; // Neither `for' nor `while'. 6779625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6780625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 6781625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 6782625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 6783625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6784625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6785625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Skip expensive checks if diagnostic is disabled. 6786625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) == 6787625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagnosticsEngine::Ignored) 6788625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6789625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6790625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 6791625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 6792625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6793625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6794625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // `for(...);' and `while(...);' are popular idioms, so in order to keep 6795625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // noise level low, emit diagnostics only if for/while is followed by a 6796625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CompoundStmt, e.g.: 6797625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 6798625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // { 6799625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 6800625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // } 6801625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // or if for/while is followed by a statement with more indentation 6802625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // than for/while itself: 6803625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 6804625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 6805625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool ProbableTypo = isa<CompoundStmt>(PossibleBody); 6806625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ProbableTypo) { 6807625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyColInvalid; 6808625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyCol = SourceMgr.getPresumedColumnNumber( 6809625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko PossibleBody->getLocStart(), 6810625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyColInvalid); 6811625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyColInvalid) 6812625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6813625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6814625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtColInvalid; 6815625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtCol = SourceMgr.getPresumedColumnNumber( 6816625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko S->getLocStart(), 6817625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtColInvalid); 6818625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtColInvalid) 6819625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6820625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6821625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyCol > StmtCol) 6822625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko ProbableTypo = true; 6823625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 6824625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6825625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (ProbableTypo) { 6826625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 6827625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 6828625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 6829625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 68300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- Layout compatibility ----------------------------------------------// 68320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 68340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2); 68360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two enumeration types are layout-compatible. 68380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) { 68390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [dcl.enum] p8: 68400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Two enumeration types are layout-compatible if they have the same 68410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // underlying type. 68420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return ED1->isComplete() && ED2->isComplete() && 68430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType()); 68440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 68450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two fields are layout-compatible. 68470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) { 68480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Field1->getType(), Field2->getType())) 68490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField() != Field2->isBitField()) 68520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField()) { 68550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Make sure that the bit-fields are the same length. 68560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits1 = Field1->getBitWidthValue(C); 68570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits2 = Field2->getBitWidthValue(C); 68580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Bits1 != Bits2) 68600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 68640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 68650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout structs are layout-compatible. 68670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p17) 68680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleStruct(ASTContext &C, 68690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 68700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 68710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If both records are C++ classes, check that base classes match. 68720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) { 68730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If one of records is a CXXRecordDecl we are in C++ mode, 68740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // thus the other one is a CXXRecordDecl, too. 68750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2); 68760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check number of base classes. 68770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D1CXX->getNumBases() != D2CXX->getNumBases()) 68780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the base classes. 68810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (CXXRecordDecl::base_class_const_iterator 68820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 = D1CXX->bases_begin(), 68830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BaseEnd1 = D1CXX->bases_end(), 68840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base2 = D2CXX->bases_begin(); 68850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 != BaseEnd1; 68860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ++Base1, ++Base2) { 68870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Base1->getType(), Base2->getType())) 68880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) { 68910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If only RD2 is a C++ class, it should have zero base classes. 68920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D2CXX->getNumBases() > 0) 68930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the fields. 68970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl::field_iterator Field2 = RD2->field_begin(), 68980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(), 68990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 = RD1->field_begin(), 69000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 69010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) { 69020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, *Field1, *Field2)) 69030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1 != Field1End || Field2 != Field2End) 69060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 69090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout unions are layout-compatible. 69120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p18) 69130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleUnion(ASTContext &C, 69140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 69150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 69160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields; 69170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field2 = RD2->field_begin(), 69180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(); 69190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2 != Field2End; ++Field2) { 69200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko UnmatchedFields.insert(*Field2); 69210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field1 = RD1->field_begin(), 69240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 69250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 != Field1End; ++Field1) { 69260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8>::iterator 69270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = UnmatchedFields.begin(), 69280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = UnmatchedFields.end(); 69290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; I != E; ++I) { 69310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (isLayoutCompatible(C, *Field1, *I)) { 69320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result = UnmatchedFields.erase(*I); 69330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (void) Result; 69340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko assert(Result); 69350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko break; 69360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == E) 69390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return UnmatchedFields.empty(); 69430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) { 69460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion() != RD2->isUnion()) 69470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion()) 69500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleUnion(C, RD1, RD2); 69510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 69520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleStruct(C, RD1, RD2); 69530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two types are layout-compatible in C++11 sense. 69560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) { 69570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (T1.isNull() || T2.isNull()) 69580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.types] p11: 69610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If two types T1 and T2 are the same type, then T1 and T2 are 69620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // layout-compatible types. 69630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (C.hasSameType(T1, T2)) 69640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 69650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T1 = T1.getCanonicalType().getUnqualifiedType(); 69670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T2 = T2.getCanonicalType().getUnqualifiedType(); 69680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC1 = T1->getTypeClass(); 69700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC2 = T2->getTypeClass(); 69710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 != TC2) 69730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 == Type::Enum) { 69760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 69770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T1)->getDecl(), 69780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T2)->getDecl()); 69790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (TC1 == Type::Record) { 69800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType()) 69810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 69840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T1)->getDecl(), 69850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T2)->getDecl()); 69860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----// 69930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 69950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Given a type tag expression find the type tag itself. 69960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 69970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Type tag expression, as it appears in user's code. 69980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 69990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param VD Declaration of an identifier that appears in a type tag. 70000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 70010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValue Type tag magic value. 70020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx, 70030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl **VD, uint64_t *MagicValue) { 70040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko while(true) { 70050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeExpr) 70060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts(); 70090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko switch (TypeExpr->getStmtClass()) { 70110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::UnaryOperatorClass: { 70120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr); 70130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) { 70140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = UO->getSubExpr(); 70150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 70160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::DeclRefExprClass: { 70210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr); 70220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *VD = DRE->getDecl(); 70230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 70240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::IntegerLiteralClass: { 70270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr); 70280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::APInt MagicValueAPInt = IL->getValue(); 70290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (MagicValueAPInt.getActiveBits() <= 64) { 70300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *MagicValue = MagicValueAPInt.getZExtValue(); 70310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 70320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 70330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryConditionalOperatorClass: 70370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::ConditionalOperatorClass: { 70380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const AbstractConditionalOperator *ACO = 70390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<AbstractConditionalOperator>(TypeExpr); 70400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result; 70410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) { 70420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Result) 70430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getTrueExpr(); 70440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 70450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getFalseExpr(); 70460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 70470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryOperatorClass: { 70520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr); 70530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (BO->getOpcode() == BO_Comma) { 70540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = BO->getRHS(); 70550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 70560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko default: 70610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 70650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Retrieve the C type corresponding to type tag TypeExpr. 70670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 70680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Expression that specifies a type tag. 70690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 70700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValues Registered magic values. 70710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 70720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param FoundWrongKind Set to true if a type tag was found, but of a wrong 70730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// kind. 70740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 70750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeInfo Information about the corresponding C type. 70760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 70770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \returns true if the corresponding C type was found. 70780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool GetMatchingCType( 70790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind, 70800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeExpr, const ASTContext &Ctx, 70810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const llvm::DenseMap<Sema::TypeTagMagicValue, 70820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData> *MagicValues, 70830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool &FoundWrongKind, 70840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData &TypeInfo) { 70850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = false; 70860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Variable declaration that has type_tag_for_datatype attribute. 70880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl *VD = NULL; 70890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue; 70910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue)) 70930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (VD) { 70960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (specific_attr_iterator<TypeTagForDatatypeAttr> 70970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = VD->specific_attr_begin<TypeTagForDatatypeAttr>(), 70980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = VD->specific_attr_end<TypeTagForDatatypeAttr>(); 70990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I != E; ++I) { 71000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I->getArgumentKind() != ArgumentKind) { 71010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = true; 71020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 71030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 71040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.Type = I->getMatchingCType(); 71050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.LayoutCompatible = I->getLayoutCompatible(); 71060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.MustBeNull = I->getMustBeNull(); 71070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 71080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 71090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 71100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 71110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!MagicValues) 71130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 71140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::DenseMap<Sema::TypeTagMagicValue, 71160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData>::const_iterator I = 71170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko MagicValues->find(std::make_pair(ArgumentKind, MagicValue)); 71180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == MagicValues->end()) 71190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 71200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo = I->second; 71220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 71230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 71240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 71250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind, 71270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue, QualType Type, 71280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool LayoutCompatible, 71290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool MustBeNull) { 71300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeTagForDatatypeMagicValues) 71310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.reset( 71320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko new llvm::DenseMap<TypeTagMagicValue, TypeTagData>); 71330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagMagicValue Magic(ArgumentKind, MagicValue); 71350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (*TypeTagForDatatypeMagicValues)[Magic] = 71360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData(Type, LayoutCompatible, MustBeNull); 71370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 71380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 71400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool IsSameCharType(QualType T1, QualType T2) { 71410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT1 = T1->getAs<BuiltinType>(); 71420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT1) 71430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 71440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT2 = T2->getAs<BuiltinType>(); 71460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT2) 71470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 71480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T1Kind = BT1->getKind(); 71500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T2Kind = BT2->getKind(); 71510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return (T1Kind == BuiltinType::SChar && T2Kind == BuiltinType::Char_S) || 71530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::UChar && T2Kind == BuiltinType::Char_U) || 71540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) || 71550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar); 71560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 71570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 71580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr, 71600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr * const *ExprArgs) { 71610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind = Attr->getArgumentKind(); 71620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool IsPointerAttr = Attr->getIsPointer(); 71630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()]; 71650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool FoundWrongKind; 71660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData TypeInfo; 71670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context, 71680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.get(), 71690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind, TypeInfo)) { 71700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (FoundWrongKind) 71710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(TypeTagExpr->getExprLoc(), 71720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_tag_for_datatype_wrong_kind) 71730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 71740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 71750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 71760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()]; 71780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) { 71790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Skip implicit cast of pointer to `void *' (as a function argument). 71800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr)) 71815a24980d059cd9fbe8375a4c549313101ad20698Dmitri Gribenko if (ICE->getType()->isVoidPointerType() && 7182b57ce4e8918656f5f4070f59d74354fcefbbb6f8Dmitri Gribenko ICE->getCastKind() == CK_BitCast) 71830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentExpr = ICE->getSubExpr(); 71840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 71850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType ArgumentType = ArgumentExpr->getType(); 71860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Passing a `void*' pointer shouldn't trigger a warning. 71880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr && ArgumentType->isVoidPointerType()) 71890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 71900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TypeInfo.MustBeNull) { 71920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Type tag with matching void type requires a null pointer. 71930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!ArgumentExpr->isNullPointerConstant(Context, 71940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Expr::NPC_ValueDependentIsNotNull)) { 71950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), 71960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_safety_null_pointer_required) 71970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentKind->getName() 71980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 71990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 72000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 72010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 72020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 72030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 72040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType RequiredType = TypeInfo.Type; 72050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 72060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType = Context.getPointerType(RequiredType); 72070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 72080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool mismatch = false; 72090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeInfo.LayoutCompatible) { 72100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !Context.hasSameType(ArgumentType, RequiredType); 72110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 72120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.fundamental] p1: 72130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Plain char, signed char, and unsigned char are three distinct types. 72140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // 72150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // But we treat plain `char' as equivalent to `signed char' or `unsigned 72160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // char' depending on the current char signedness mode. 72170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 72180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(), 72190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType())) || 72200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType))) 72210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = false; 72220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 72230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 72240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, 72250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentType->getPointeeType(), 72260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType()); 72270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 72280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType); 72290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 72300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 72310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch) 72320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentType << ArgumentKind->getName() 72330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeInfo.LayoutCompatible << RequiredType 72340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 72350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 72360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 7237