| a095041f5148dd1e71f38d0546335ed94199104b |
|
29-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove SkRecorder's kWriteOnly mode.
I'm soon going to have SkRecorder start calling getTotalMatrix(), which
would be broken in write-only mode. That change is big and nebulous,
but it's clear kWriteOnly needs to go, so we might as well kill it now.
My notes in bench_playback about kWriteOnly mode being important were
probably overly cautious. I now think this is a fair enough comparison
even re-recording into a read-write canvas.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/290653004
git-svn-id: http://skia.googlecode.com/svn/trunk@14963 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/dump_record.cpp
|
| 85fd1932231e21703fc4e1846a3769b5a5119c77 |
|
15-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Factor out DumpRecord method from dump_record tool for later use
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/282233003
git-svn-id: http://skia.googlecode.com/svn/trunk@14751 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/dump_record.cpp
|
| 27f6b0d013572184dc980462cce8d0f3caec1c8e |
|
09-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add timing to dump_record.
Prints microsecond timing for each command in the left-hand column:
optimized flat/http___mobile_news_sandbox_google_com_news_pt0_scroll_layer_7.skp
4.0 1 Save
2075.0 2 DrawRect
104.0 3 BoundedDrawPosTextH
135.4 4 DrawRect
9.4 5 DrawRect
5.6 6 DrawRect
8.2 7 DrawRect
6.8 8 DrawRect
...
(I'm sure Rietveld will just mangle the crap out of that. It's helpfully right-aligned.)
To do this, I made Draw from SkRecordDraw Skia-public as SkRecords::Draw,
and time it command-by-command.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/272723007
git-svn-id: http://skia.googlecode.com/svn/trunk@14672 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/dump_record.cpp
|
| c71da1f6ed3a5e1a3eb2dd860b8129e1b423f9f4 |
|
07-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Convert all SkRecordPattern matchers into SkRecord mutators.
- Allow any return type from SkRecord mutators and visitors;
- update existing calls to mutate and visit;
- convert match to operator() in SkRecordPattern;
- tidy up a few inelegant bits of old code in tests.
The net result is that the generated code is much clearer. All the mutate() calls
inline as you'd hope, and you can now actually follow along with the disassembly.
BUG=skia:2378
R=fmalita@chromium.org, bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/273643007
git-svn-id: http://skia.googlecode.com/svn/trunk@14631 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/dump_record.cpp
|
| bf07d2e17d1b9bc5c40b4d05ff97a51a246c95d6 |
|
06-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add dump_record to make inspecting before/after SkRecordOptimize easy.
E.g.
dump_record -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp
0 Save
1 DrawRect
2 DrawRect
3 DrawRect
4 DrawRect
5 Save
6 ClipRect
7 Restore
8 Save
9 ClipRect
10 Restore
11 Restore
dump_record -O -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp
0 Save
1 DrawRect
2 DrawRect
3 DrawRect
4 DrawRect
5 NoOp
6 NoOp
7 NoOp
8 NoOp
9 NoOp
10 NoOp
11 Restore
(Reitveld sadly eats my kickass indentation.)
BUG=skia:2378
Committed: http://code.google.com/p/skia/source/detail?r=14596
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/265983007
git-svn-id: http://skia.googlecode.com/svn/trunk@14600 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/dump_record.cpp
|
| 545a21a71419edcee015fbf7fecaded6bd1477c1 |
|
06-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add dump_record to make inspecting before/after SkRecordOptimize easy.
E.g.
dump_record -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp
0 Save
1 DrawRect
2 DrawRect
3 DrawRect
4 DrawRect
5 Save
6 ClipRect
7 Restore
8 Save
9 ClipRect
10 Restore
11 Restore
dump_record -O -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp
0 Save
1 DrawRect
2 DrawRect
3 DrawRect
4 DrawRect
5 NoOp
6 NoOp
7 NoOp
8 NoOp
9 NoOp
10 NoOp
11 Restore
(Reitveld sadly eats my kickass indentation.)
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/265983007
git-svn-id: http://skia.googlecode.com/svn/trunk@14596 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/dump_record.cpp
|