| 53c7dc1e9691b5b427395642a4274d37a1a15bb4 |
|
31-Jul-2014 |
Yorke Lee <yorkelee@google.com> |
Correctly setGravity for RTL mode
Ensure that by the time setGravity is called for RTL-related aligning,
that getLayoutDirection() returns the correct values. This value is not
usually correct in the constructor, because the view does not have a parent
to resolve it from yet.
Bug: 16162786
Change-Id: Iea6cbcd05e39a5c45641dbb1230d4be85b45ff15
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| f7a205fdcb17161c454bee673cc2fce5b23d0760 |
|
30-Jun-2014 |
Sai Cheemalapati <saicheems@google.com> |
Fix PinnedHeaderListView behavior with padding.
PinnedHeaderListView now behaves as expected if left/
right padding is specified.
Change-Id: Idc5e3b6b90ab73cfe5f7e0d60ca16067e650c9a7
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| d2777cefe658ceccafa853c7c3ae9a4fd5d9898c |
|
11-Jun-2014 |
Andrew Lee <anwlee@google.com> |
am 84f6ef0c: Merge "Add support for full-bleed selection of contact list items." into lmp-preview-dev
* commit '84f6ef0cfd5ef768b14119952df7b8f2fa0a02ee':
Add support for full-bleed selection of contact list items.
|
| fc9221ef57bfb9311dda798f67030d40215be859 |
|
10-Jun-2014 |
Andrew Lee <anwlee@google.com> |
Add support for full-bleed selection of contact list items.
- Adding the concept of "adjustSelectionBoundsEnabled", which allows
us to control whether the headerWithoutBounds is used to override the
selection list items bounds. We want to be able to do this in some
cases (eg. in the contacts list when there is a header on the left)
but in others (eg. a search list), we want the ripple to fill out the
entire bounds of the list item.
- Allow for this to be set by the ContactEntryListFragment, and then
passed through the ContactEntryListAdapter to the ContactListItemView.
- No longer apply scrollbar padding to the list view regardless of
whether the scrollbar is present, because this messes with the ripple
propagation.
Bug: 15517457
Change-Id: I174a462ac1e45b987ac0ee70de318ed037d91762
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 3264237b4db5af21d8e33f6818ff0f3d9938e416 |
|
30-May-2014 |
Andrew Lee <anwlee@google.com> |
am 8668f83e: Merge "Match contact list items to redlines for Dialer." into lmp-preview-dev
* commit '8668f83e7c37027870ffe2ea5c72d9977f9fc0e1':
Match contact list items to redlines for Dialer.
|
| 6fdf16941587a222f554482fb72531783a924b6e |
|
30-May-2014 |
Andrew Lee <anwlee@google.com> |
Match contact list items to redlines for Dialer.
- Add text offset top functionality in the pinned header and
headers. In the pinned header this was done with padding, because
the pinned header is a (assumeedly vertically centered) child and
then the parent doesn't need to be privy to these details.
- Update width and font size. I imagine we want these changes to
be consistent between Dialer and Contacts, which is why this was
done here instead of in Dialer.
Bug: 15332945
Change-Id: If2ebf8117f528316b256a86ed9922f917e9c75ae
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 62ad29abe26021ef82243289b8e140f5814645e7 |
|
30-May-2014 |
Andrew Lee <anwlee@google.com> |
am f6141bd8: Merge "Updating contact list item for Dialer search redlines." into lmp-preview-dev
* commit 'f6141bd806446928038f97bedcbdc3b69b5f1e15':
Updating contact list item for Dialer search redlines.
|
| 7961175eb7b8b8d6f990bd8e510f59fe48c5ef4b |
|
30-May-2014 |
Andrew Lee <anwlee@google.com> |
Updating contact list item for Dialer search redlines.
- Add text offset field so that the text can be properly aligned
after taking into account inherent padding.
- Set elegant text height to false on name/data TextViews.
- Increase small text size.
Bug: 15328499
Change-Id: Ib86ab2a3f1bde676f0950453653a90d51b26fb0b
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| ce892f584711dc1445666c48bcefd4949a8486b0 |
|
28-May-2014 |
Sai Cheemalapati <saicheems@google.com> |
DO NOT MERGE Changed margins of Dialer and Contact list items to match redline spec.
Changed text color of items to match spec (#4d4d4d).
Fixed text size issue in People app.
Bug: 15165159
Change-Id: Ib07111d6d829363f5258fbe6475dd8d1918b8ec7
(cherry picked from commit 3bc19a3bb1ed23b03352fff6de69a89e763a315e)
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 3bc19a3bb1ed23b03352fff6de69a89e763a315e |
|
28-May-2014 |
Sai Cheemalapati <saicheems@google.com> |
Changed margins of Dialer and Contact list items to match redline spec.
Changed text color of items to match spec (#4d4d4d).
Fixed text size issue in People app.
Bug: 15165159
Change-Id: Ib07111d6d829363f5258fbe6475dd8d1918b8ec7
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| c2a910a18d5d29442755c6193cd31b38ba834f34 |
|
28-May-2014 |
Andrew Lee <anwlee@google.com> |
am 58a793ee: Provide Color.BLACK as default name text color.
* commit '58a793ee1253f8f46dd7f754a51f61a6bbcdce60':
Provide Color.BLACK as default name text color.
|
| 58a793ee1253f8f46dd7f754a51f61a6bbcdce60 |
|
28-May-2014 |
Andrew Lee <anwlee@google.com> |
Provide Color.BLACK as default name text color.
Bug: 15248629
Change-Id: I722fef6cd23b10bdbebbe8d3d04c3923376301cf
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 90fbbae42d4628b18e78434e7de13254099b229e |
|
27-May-2014 |
Paul Soulos <psoulos@google.com> |
Fixes comment typo in ContactListItemView
Change-Id: I961c4fa58c060d05a30acf11e88116dd6daf23c4
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| b478fa93247b26b8797128563c089da3db542f55 |
|
23-May-2014 |
Nancy Chen <nancychen@google.com> |
[DO NOT MERGE] Add attibute for color on contacts list search items
Adding the ability to change the color on the contacts list
search items. The actual colors are defined in Dialer.
Bug: 15118603
Change-Id: I8e332e9c448cbcc4e4f64349d9ff5474bb06eb2f
(cherry picked from commit f88b7b9d1a07414053a4a90d13d453a02bd58ac7)
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| f88b7b9d1a07414053a4a90d13d453a02bd58ac7 |
|
23-May-2014 |
Nancy Chen <nancychen@google.com> |
Add attibute for color on contacts list search items
Adding the ability to change the color on the contacts list
search items. The actual colors are defined in Dialer.
Bug: 15118603
Change-Id: I8e332e9c448cbcc4e4f64349d9ff5474bb06eb2f
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 0b332d732b39f71206a953b4475fbc3108263690 |
|
01-May-2014 |
Yorke Lee <yorkelee@google.com> |
Merge "Add circular photo support to ContactPhotoManager"
|
| 3f9c2f426058413055fa54c08c69ad9461717658 |
|
29-Apr-2014 |
Yorke Lee <yorkelee@google.com> |
Add circular photo support to ContactPhotoManager
* Use RoundedBitmapDrawable to draw circular bitmaps
* Add isCircular to DefaultImageRequest, and add circular
support to LetterTileDrawable
* Temporarily disable fading in contact photos using
TransitionImageDrawable
Bug: 13747208
Change-Id: I4d087b2dab701014297912ccb6cfac36ecffc673
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| ceb851d9c2d5c73bdd9c60ca47be0902516636aa |
|
29-Apr-2014 |
Andrew Lee <anwlee@google.com> |
Polishing text style and measuring for section headers.
- Added section header text color.
- Updated section headert style.
- Fixed selection bounds measurement in ContactListItemView.
- Deleted unused methods and imports in ContactListItemView.
Bug: 13956531
Change-Id: I1dea8691bb77fae90847474414ff6143c8fea5f5
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 8ec561aa133b753f896ab2044fac2118bcadb305 |
|
28-Apr-2014 |
Andrew Lee <anwlee@google.com> |
Merge "Moves section header in contacts list to the left side."
Change-Id: I59a2050e67cc0290df5fb28f7e5b8dcb844d2cf8
|
| 807d572391dd062c25e00a956a02412ce07cdfd7 |
|
28-Apr-2014 |
Andrew Lee <anwlee@google.com> |
Merge "Moves section header in contacts list to the left side."
|
| 1f1e90d36fe914a7ce51e6f9884199580115d891 |
|
26-Apr-2014 |
Andrew Lee <anwlee@google.com> |
Moves section header in contacts list to the left side.
- Changed ContactListItemView to render section headers on the
left. This includes support for RTL layouts.
- Added setSectionHeaderEnabled to ContactListItemView so that
left padding can be rendered if there is a section header.
- Add newView() implementation in the ContactEntryListAdapter which
sets setSectionHeaderEnabled on new contacts list view instance.
- Changed the PinnedHeaderView to extend a TextView and gutted a
lot of unneeded logic and styling (including the Counts view).
- Add list_item_background_color to attributes, which is used to
specify the background color for the pinned header, so that when
it moves the underlying section header is not visible.
- Change layout and canvas logic in PinnedHeaderListview, so that
the pinned header is placed to match the new position.
- Add logic to the IndexerListAdapter to match the pinned header's
height to the height of the first list item in view.
Bug: 13956531
Change-Id: I78a0b505833e9ce1c889904ff51c17f6c1653de1
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| a9950433dc469d24b314204075a6250d2410e01b |
|
25-Apr-2014 |
Andrew Lee <anwlee@google.com> |
Change default photo position from right to left.
Bug: 13956531
Change-Id: I7ce2991394f7465eced2889c89b9b54887aaae2b
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 9779f462bd7213e8e0d2aeeadcef84d8182f7594 |
|
25-Apr-2014 |
Andrew Lee <anwlee@google.com> |
Delete functionality to set count in the pinned header views.
Bug: 13956531
Change-Id: Iad1ab60ae486bfa059ad14a856eb6f3aa6637bdc
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| f4fcd3def28e5b1168f5160e476c05ad69339adc |
|
23-Apr-2014 |
Andrew Lee <anwlee@google.com> |
Delete contacts list item dividers.
- Delete setDivider method, and associated layout logic.
- Delete unneeded list_item_divider attribute.
Bug: 13956531
Change-Id: I56d471ae637346cb6a1b9a56c6c43de2da603256
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| eabf27292960173c0600e022c64919453741c93f |
|
09-Apr-2014 |
Yorke Lee <yorkelee@google.com> |
Temporarily disable phone number formatting in search
Formatting the phone numbers after highlighting sequences had been
assigned was causing possible IndexOutOfBoundsExceptions when
applying the highlights. Temporarily disable formatting until
highlighting logic is better refactored between the various
PhoneNumberListAdapters and ContactListItemView.
Bug: 13906816
Change-Id: I9082a68ee7c2aaa376da203a98a534098bb43e14
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| d632975fd69f4e0994d6fe66f099ab714ed709b1 |
|
01-Apr-2014 |
Andrew Lee <anwlee@google.com> |
Don't replace phone number text if formatted number is null.
Bug: 11734577
Change-Id: I21e11b9aed0dde06f96fcbdcc605cef0f2c4120f
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 62dbbf2f10e0e3bcb4d699d859a71a68c896f4a7 |
|
31-Mar-2014 |
Andrew Lee <anwlee@google.com> |
Format phone number before setting it on ContactListItemView.
Get the country ISO from the context in the PhoneNumberListAdapter.
Then, in ContactListItemView, use PhoneNumberUtils to format the
given phone number before setting it. Also, deprecates/deletes
showPhoneNumber() method.
Bug: 11734577
Change-Id: I890f1b090acb1814814396da654f75b23d9ef8de
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| bb67024ef64a7853f5ec320652d80f0cdf7b660f |
|
18-Mar-2014 |
Yorke Lee <yorkelee@google.com> |
Fix ContactsCommon tests
Remove stale testSetMask_LengthMismatch test
Update SpannedTestUtils to check for StyleSpan instead of ForegroundColorSpan
Add READ_CONTACTS permission
Bug: 13516535
Change-Id: Ibe10ca6cde42277697dc185e4cab35238d190023
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 3d7e2893cb55dc0f1bc4f7e731322973ee09bc1f |
|
07-Mar-2014 |
Yorke Lee <yorkelee@google.com> |
Remove references to private view properties
Switch usages of mTop, mBottom, mRight and mLeft which are hidden
View properties to their non-hidden getter functions instead.
Bug: 6948882
Change-Id: I528ab18bc91eaacc784c1e79a9a417421e14e0cd
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| bded9d078784569efef4aec2d636ce3f733601d7 |
|
03-Dec-2013 |
Yorke Lee <yorkelee@google.com> |
Copy private pointInView method to ContactListItemView
Bug: 6948882
Change-Id: Ieef3d4c8933eacea59fe5a5398edc5ba0141fd2c
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 90a368279bb3e94291e12fc0c7dc8676f194c33d |
|
03-Dec-2013 |
Yorke Lee <yorkelee@google.com> |
Replace usages of mContext with getContext
Bug: 6948882
Change-Id: I730f690f36e9541dd6945abe6df9890c96d72676
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 3aa2cb56ece8461f2df69d9300c9a1abf03f6989 |
|
26-Nov-2013 |
Yorke Lee <yorkelee@google.com> |
Remove private references to android.R.styleable
Define these framework attributes in our own attr.xml and use as
necessary
Bug: 6948882
Change-Id: I6862451133844251315dafeffd1921720eeb4964
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| a350efe79dd18df1d6e31694d68094ad99736a11 |
|
14-Nov-2013 |
Chiao Cheng <chiaocheng@google.com> |
Fix auto-merge conflict.
Merge commit 'd6714041' into manualmerge
Conflicts:
src/com/android/contacts/common/list/ContactListItemView.java
Change-Id: Icade3af50d0c509b17341d6bcb15d5ed0419109f
|
| 9552192be3977ce2a7fd21b091dffa38808df73e |
|
14-Nov-2013 |
Yorke Lee <yorkelee@google.com> |
am 02de5655: am dfd7e86b: am 538e05b3: Fix a bug with pressed state in ContactListItemView
* commit '02de5655eef21607f2d20a1e643e230ce05669d6':
Fix a bug with pressed state in ContactListItemView
|
| ab8ca3ff940c4e0941d90935229ae03a50be2bac |
|
14-Nov-2013 |
Chiao Cheng <chiaocheng@google.com> |
Merge "Make fonts consistent in contact list." into klp-dev
|
| d396439cb61b5470363fda394137f706b792f29a |
|
14-Nov-2013 |
Chiao Cheng <chiaocheng@google.com> |
Make fonts consistent in contact list.
Bug: 11674807
Change-Id: I86e08025085e140ecee7cfa796aff006ea3e270b
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 538e05b3bbde399f25ccf1aad251fca6d7f4d6b3 |
|
13-Nov-2013 |
Yorke Lee <yorkelee@google.com> |
Fix a bug with pressed state in ContactListItemView
ContactListItemView was incorrectly maintaining its pressed state
even when touch events were moved outside its bounds.
Bug: 11668831
Change-Id: I36b596d33be4e44f78990a9fa8e5fd05d3388037
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| a8ee5ec28c654866d49c7ea874cdd90b073a42cc |
|
05-Nov-2013 |
Yorke Lee <yorkelee@google.com> |
Merge "Remove use of isLayoutRtl and move to utility method"
|
| 864c67691b5a0169b5cbb91469d67d93e24ad9eb |
|
04-Nov-2013 |
Yorke Lee <yorkelee@google.com> |
Remove use of isLayoutRtl and move to utility method
isLayoutRtl is a hidden API and this CL moves the code into
an internal utility method.
Bug: 6948882
Change-Id: I20604b4233e0ce659e033133539662d9e3b558b3
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 04d13ead6584fa73223c900dedad2279b193313f |
|
01-Nov-2013 |
Yorke Lee <yorkelee@google.com> |
Cherrypick search highlighting fix
Manual cherry-pick of https://googleplex-android-review.git.corp.google.com/#/c/383300/
to master
Change-Id: Ib49499c520fb3aecf92d8fd2e8a3ba7b1a56489a
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 2ae78772bd8d55a2b90882b532a90a6fe1c23228 |
|
31-Oct-2013 |
Yorke Lee <yorkelee@google.com> |
Fix searchsnippet highlighting in People
Bug: 11451572
Change-Id: Id1490940488726f8e7573068dc8440acb7370170
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| e9736747aa45ed6091a5479b38e3311823675853 |
|
22-Oct-2013 |
Yorke Lee <yorkelee@google.com> |
Remove private references from ContactsCommon
Cleanup mContext references
Substitute Guava methods for internal Android dependencies
Change-Id: Ibc36b25839d40fd36b32ded3c337ae32a7447f2b
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 0e199e0da07392d08f76274e131fab6af9dbad9e |
|
14-Oct-2013 |
Yorke Lee <yorkelee@google.com> |
Section/directory font and size changes for ContactsCommon
Bug: 10861682
Change-Id: Ic34a46de80da691dfba1506b769df6b98a9fa9a3
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| b02b63804b1f6ebe060ff25d9b0c5f62afd5e013 |
|
13-Sep-2013 |
Yorke Lee <yorkelee@google.com> |
Merge "UI Polish for list section headers in ContactsCommon" into klp-dev
|
| 42210256d3d584783ac2fb2742088ce57d9da766 |
|
12-Sep-2013 |
Yorke Lee <yorkelee@google.com> |
Fix search highlighting
Bug: 10713067
Change-Id: I6fd3e6018619d61f7c69bbcaf2ad7475b20499a6
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| b23d36979bad7dbdb0b2f6318fce7573f01fa6b4 |
|
11-Sep-2013 |
Yorke Lee <yorkelee@google.com> |
UI Polish for list section headers in ContactsCommon
Bug: 10671447
Change-Id: I72927f64a0bbbef1252e6d065546d6186622c96d
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 10349f190691f802b8935175dbf38bff74a8a703 |
|
06-Sep-2013 |
Yorke Lee <yorkelee@google.com> |
Fix ContactListItemView selection bounds
Don't select the first item in a bucket if the header of the bucket
is clicked.
Bug: 10513708
Change-Id: I9b7eaef92088f46680fa59976424e88b3c31a23e
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 27330d80bb6575df2964112d34143125c8af9b78 |
|
28-Aug-2013 |
Yorke Lee <yorkelee@google.com> |
Add shortcut support into contacts common
Add setDisplayName(CharSequence name) and setDrawableResources methods
to ContactListItemView so that we can add custom shortcuts into
PhoneNumberListAdapter
Bug: 10339630
Change-Id: I3e8a294dd9d47f034e6244929bdb61d834777974
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| ad21d11eed06b39ede8f171da0faf119b7b6c4b2 |
|
05-Sep-2013 |
Paul Sliwowski <psliwowski@google.com> |
Update people app colors in ContactsCommon.
Change-Id: I48916187b804f98c906a2cc7b0de0b321b8dc851
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 7a160466a38bb631da02b7e93ab907eb2b3a2558 |
|
26-Jul-2013 |
Jay Shrauner <shrauner@google.com> |
Add GAL search support to Dialer
Enable GAL search in Dialer.
Bug:
Change-Id: If03dcbb570aebd5ba31c5d419e76b33b91be6eee
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| f99a990be713ed35afe64ba8133c5428816390c6 |
|
12-Jul-2013 |
Christine Chen <christinech@google.com> |
Changes ContactListItemView highlighting scheme.
- Re-match smart dial query every time in BindView.
Change-Id: I42a54948481fead693db5a2db188bcc31202d6ee
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| a81953a2b1818066ef5e44817f374ac288bab343 |
|
09-Jul-2013 |
Christine Chen <christinech@google.com> |
Changes to support smart dial in search.
- Extends functionalities in text highligher.
- Changes pemissions in parent classes.
Change-Id: Ib5717fe00760b5a88c747e1ff8fda598d987fa98
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 9f0c1621718b382531cbebfe38907e6d3db6ceae |
|
04-Apr-2013 |
Fabrice Di Meglio <fdimeglio@google.com> |
Fix for bug #8146846 Phone App should be mirrored for RTL languages
- add start/end aside left/right properties
- make default PhotoPosition depends on Locale layout direction
- add mirrored version of Drawables
- use android:textAlignment="viewStart" when needed on TextView
Change-Id: I0bf2fb83d94a3748d26d1825387b9b16830830a5
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 09f15e70e86d92ae0f4c15a726b777f170845a3c |
|
06-Feb-2013 |
Yorke Lee <yorkelee@google.com> |
Fix photo alignment in RTL locales in ContactEntryListAdapter
Bug: 5590280
Change-Id: I17caf1d17b9b5ccac177e66d8b4e5605e0ac6be1
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| cae605bed4d43e1925fc8c1803def0ef1d0924a5 |
|
28-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Find proper snippet in multi-line and large result.
Previous CL removed the use ContactsContract.snippetize(). This method
found the proper line in a multi-line results and then snippetized the
line if it was too long.
This CL adds that functionality back without using snippetize(). This
new code is faster because it only does text intensive processing when
the text is long. The previous snippetize method did processing for all
strings. In addition, the old method iterated over the snippet multiple
times (i.e. first with contains, then subsequently tokenizes, etc). This
change re-uses the initial search results and remembers the search
information so multiple iterations are not necessary. In addition,
tokenizing has been optimized based on the match. We only need to
chop off excess content rather than tokenizing the whole string.
This CL also makes snippet more friend to landscape mode. Previously,
the number of snippet tokens shown was hard-coded to 2 on each side.
Furthermore, this caused longer tokens to exceed screen real estate. Now
the number of tokens shown are determined more accurately by character
count versus real estate. In landscape mode, this allows us to show
much more of the search result.
Finally, fixed a highlight problem when the search query contained
punctuation. For example, a search for {.ben.} would not match {ben}.
This Cl resolves that issue by cleaning the search query.
Bug: 5929143
Change-Id: I5c368e6de8b34ca912f86926f862a02f95199fa7
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| bd80fd64b9ff94c9ffbdb843beb4b363bb209463 |
|
22-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Fixing missing punctuation for punctuation search case.
Previous CL I9cbdf10d21c79f53bc621bacb7eeeb95a6a2435f fixed missing
punctuation at the start when searching without punctuation. (e.g.
{hello})
This CL fixes the case where leading punctuation is missing if you searched
with a leading punctuation. (e.g. {'hello}). The content provider
uses a different code path when it detects multi-words and snippeting
is actually done in sqlite using the FTS snippet method. The check for
multi-word was treating {'hello} as two words.
This means that multi-word searches will still have this issue as it still
uses the sqlite snippet method. Leaving this to a separate CL since it's
a riskier change.
Bug: 5929143
Change-Id: I1883621bb64452726cd92035d30001c29b478574
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| 05897c8e016942e10f0ef6f0da02d339480d4748 |
|
20-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Include starting and ending punctuation.
The snippetize method was leaving out the delimiters at the start and end of
the snippetized string. Upon further investigation, the snippetize method is
not needed because showSnippet() always puts the string back into it's original
form (i.e. it was undoing the work of snippetize) at the end of the method.
The solution is to pass the original form into setSnippet() when
deferred snippeting is requested. This eliminates a lot of unnecessary
processing.
Bug: 5929143
Change-Id: I9cbdf10d21c79f53bc621bacb7eeeb95a6a2435f
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|
| d6bba124836ec2f528b329759e38fda6297fec49 |
|
01-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Moving ContactListItemView and dependent classes.
Further clean-up of PhoneFavoriteFragment in Dialer app to move all necessary
dependencies into Contacts Common package.
Bug: 6993891
Change-Id: Ie310707da47d5e5c91e281d140f11e1eb47a5118
/packages/apps/ContactsCommon/src/com/android/contacts/common/list/ContactListItemView.java
|