History log of /packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
bb391e8018a56f27bb2025accf5171491e4b2a14 14-Jul-2014 Martin Hibdon <mhibdon@google.com> Merge "Update IEmailService" into ub-mail-master
7afbeee47e1a82680c815f2fb8cfdba32d6b0b84 11-Jul-2014 Martin Hibdon <mhibdon@google.com> Update IEmailService

Add version support
Change deleteAccountPIMData to deleteExternalAccountPIMData.
Data kept inside the EmailProvider can be deleted from within
the Email app. Only external data (e.g. contacts and calendar)
need to be deleted by the service which has protocol specific
knowlege.

Change-Id: I875d3051d0cfdbaf52775ec20eb114a345894a93
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
8c03e2af9f439c6e0c6abb38b0c371da7ccdb72a 11-Jul-2014 Tony Mantler <nicoya@google.com> Remove direct entry points to AccountSettings

b/16240332

Change-Id: I9bc3f9a2e0b7faa4d8875a9ac7d6d585a65d9733
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
1d8fd9c05449863ac6a151a6db87c267c4f55ac2 02-Jul-2014 Martin Hibdon <mhibdon@google.com> Add communication class for HostAuth

We want a separate class for communicating HostAuth objects
to and from IEmailService. The issue is that the HostAuth object
was being used for both to and from the database, and to and from
IEmailService. This is dangerous because The Email app may change
out of band with the Exchange app, and may need to change the
format of HostAuth. This bit us before when adding OAuth.
Now communication to IEmailService is done using HostAuthCompat.

Change-Id: I2fb8c2bd8158f58a7bb9bc3dc83a7936948c718c
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
3d16e5d4b994d92db51962c8c461c53bee04309f 25-Jun-2014 Anthony Lee <anthonylee@google.com> Move over to the new AttachmentService.

Change-Id: I4a687b003884ea6a92a755fcbf394001bfc96a38
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
fb2a3a2f77f954265beaa92b87774006e2d7c185 12-Jun-2014 Martin Hibdon <mhibdon@google.com> Update IEmailService

This is not yet finalized, but it's needed to fix push syncs
on exchange.

Change-Id: Iaff20aa0bdea9685ef6603de1f861d58fbab6ff1
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
163323294e20f620931ae531cc927ae3932cb368 22-May-2014 Martin Hibdon <mhibdon@google.com> Change IEmailService.sync to have two different forms

Change-Id: Id8e770154d6116b02746cbdfb8c7cdc9358398de
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
c5f5a14ae9095f76d8e8c411cfd8f8e0e8970aa2 21-May-2014 Martin Hibdon <mhibdon@google.com> Revert "Get rid of deleteAccountPIMData from IEmailService"

This reverts commit cf2178c4fa61538f5a2f862fe3f9bc16b9f06ebb.

Change-Id: I9b05dd7a29a2d2edf64529ca28e2305737a43115
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
cf2178c4fa61538f5a2f862fe3f9bc16b9f06ebb 21-May-2014 Martin Hibdon <mhibdon@google.com> Get rid of deleteAccountPIMData from IEmailService

This doesn't need to be part of the service because the
implementation doesn't need to be different between any
of the different protocols.

Change-Id: Ifddf16dd3ccaf397029f08f6d4283d9a5630f717
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
3dd85723a1af5537e23e4b05bdc361cce9cd42be 11-Apr-2014 Tony Mantler <nicoya@google.com> Cleanup in EmailContent

Change-Id: Ifa251eb206779f59ea003f99395d454c7e407bc2
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
64b4f7dcffb80b3eaa3269fc4264dbd2cf950ce3 26-Mar-2014 Martin Hibdon <mhibdon@google.com> Minor formatting change

b/13642247

Change-Id: I02e495142d8043c8749ab0bce21f4c7c1cea7a5f
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
adabb4285b81663da718a1e756fd849a1afdb520 26-Mar-2014 Martin Hibdon <mhibdon@google.com> Fix a NPE trying to download an attachment

b/13642247

Change-Id: I4cfb7e4a3be12fdc8b8c345c1aeabd85a729d16a
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
8103f960d0c0469d67652afd616e9924687aa139 26-Feb-2014 Yu Ping Hu <yph@google.com> Add sync to IEmailService.

This supports the EasService design.

Yes, I just removed a startSync function from this interface last month. No,
I didn't quite know at the time that I'd be adding one back. :)

Change-Id: I19d9c7838473d8982560764fdba0056cba03d132
(cherry picked from commit 4a5b11d650ff6bd79da1dfecc137af3433ce6ca8)
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
70cb2878d72ce1c1775ac0426ff82698a5e59377 26-Feb-2014 Anthony Lee <anthonylee@google.com> Changed the IEmailService interface to accept and accountId in
the loadAttachment() call. This work was necessary to support
the new EasService & EasOperation infrastructure.

Change-Id: Idd507aec999596ccd4afa5f03ff2b3c2e38a9029
(cherry picked from commit efac8255ed75d22e60036e19e7a95f8407d18ad3)
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
701134953e4591bf2cca020838558a97eab570a1 25-Feb-2014 Yu Ping Hu <yph@google.com> Add pushModify to IEmailService.

This call lets the service know that the push settings for an
account have changed.

Change-Id: I7ed41853df6af6762c80283a2a3510ce41551657
(cherry picked from commit 446136a2278652c627068ecddff534de1ad431ab)
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
f679cd08d179645b5131d2cfdaa70fa42bb778c0 30-Jan-2014 Yu Ping Hu <yph@google.com> Delete unused functions from IEmailService.aidl.

Change-Id: I131d2d3436a50c94d664fc57c6514481d9afbc97
(cherry picked from commit 8ff6c107867bc2044ba50cad010dbf4a2e93436e)
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
9fe8131c3f93db8d72cc43ec70a91432b4bab1d0 03-Jan-2014 Martin Hibdon <mhibdon@google.com> Fix a case that would leak connections if an exception happens

Change-Id: I9f50911344e04f22e15bf9ba0c95f4e1b1422923
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
ff1ee36cb5f767804fdb62e1f1c6c724bac72e12 03-Jan-2014 Martin Hibdon <mhibdon@google.com> Close Imap connections when we are done using them

Also, clean up when we create and lose track of ImapStores.
Prior to this we were creating them often, and losing track of them,
which renders useless a lot of the complex logic in ImapStore devoted
to reusing connections.

Change-Id: I771d4e46d0c1cb9b605c43d9cbae6e52f5894745
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
c86fbb5bcbff72102f87747d94948f0749402229 23-Oct-2013 Martin Hibdon <mhibdon@google.com> Add an additional mailbox key column to message table

b/11294681
The problem is that when we try to open an attachment for a
message in search results, it fails. The reason is that part of
loading the attachment, we need to open the remote folder the
message is in. For search results, the message's mailboxKey is
the special fake "search_results" folder, which doesn't actually
exist on the server.
For this change, I've added a new column called "mainMailboxKey".
For search results, this column will be populated with the real
mailbox the message is in. It will be blank for other messages.

This is a quick and low risk fix for this bug, but it's kind
of awkward. We would prefer to do one or both of the following
some time after MR1.

1. Make the "search_results" folder be a virtual folder, the same
way that unread, starred, and other virtual folders are. For these,
there is actually no mailbox row in the database, just some
queries that check various flags in the messages and behave
like folders in the UI. The messages actually still reside in the
real folders.
2. Remove the requirement to open the folder at all to load the
attachment.

Change-Id: I825ab846f78bf8b041a5d1d579260dc5d7b4c522
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
85d2190552d05dbc06518bdc21674c6aabeb583b 15-Oct-2013 Martin Hibdon <mhibdon@google.com> Clear all "drafts" related flags from email when sending

b/11224331

Change-Id: I1df8ea3e0e24b050cd391dea454124e06988bf7d
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
56aba8d8436b083bfc1169dd8b988161d537f7e5 09-Oct-2013 Martin Hibdon <mhibdon@google.com> Allow multiple mailboxes to be synced in a single request

b/11103878

Change-Id: Ic6abf51457fe94e89fe51b461da4371f50e0fe86
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
7c03217316b21d59a00cf1abed093470e8004144 09-Oct-2013 Martin Hibdon <mhibdon@google.com> Add a retry backoff/limit policy to attachment download

b/11081672

Prior to this, any time the AttachmentDownloadService
got a CONNECTION_ERROR, it would just instantly retry,
without any limit on the number of tries. This is bad
if the server is in a funny state, we'll just keep spamming
it with multiple connection attempts per second. Also,
this kills the client device's battery and responsiveness.

Now, it will retry instantly five times, and then retry on a
10 second delay 5 more times. After that it will give up.

Even if it gives up, if the user visits an email with an
attachment, or taps on an attachment to expand it, we'll
start the process over. So we shouldn't have permanent
apparently data loss, even if we fail on the first 10 tries.

I'm not certain that this is the best backoff/limit policy,
maybe we should add a delay after even the first connection
error. But I'm hesitant to change this at this point, it's
possible that something is relying on this behavior and
we don't have a lot of soak time left.

Change-Id: I53d75d5d214ccca887a89cf65b799fe640cc9bc5
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
529bdeaec1d19b035dddde204c0c7074ba8ea80f 09-Oct-2013 Martin Hibdon <mhibdon@google.com> Always close the connection after trying to load attachments

b/11081672

Change-Id: Ibe804713492b37f5579fb20a0da7292e82cb5341
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
921c04d2ac5df091fb3c5cfa823e6dc2fc6cdf5a 02-Oct-2013 Martin Hibdon <mhibdon@google.com> Add some logging

Change-Id: Ib26ffad0bb6841361b8ee7be4ee2a6255d509ae2
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
da42d856b8940f58c0431dd2f0fb7e8c8f8c0644 12-Sep-2013 Tony Mantler <nicoya@google.com> Don't skip attachment saving if the attachment is not yet saved.

Also tidy up warnings

b/10461356

Change-Id: I65ac4c5b512cd67a39c81606391a2b044213f269
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
eb4ee8a7aa540e77c57af1635ede7f89124f1259 02-Aug-2013 Yu Ping Hu <yph@google.com> Move required system folder types to Mailbox.

I'm formalizing the concept of folders that must exist,
and the list of such folders should be accessible to all
sync adapters.

Change-Id: I9e4d2d51aa495d211eab2d1e36c3fa197a1ac00d
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
2075c97f608a853923980865b72147a5c8ef71f0 30-Jul-2013 Yu Ping Hu <yph@google.com> Delete most of IEmailServiceCallback.

The old callback mechanism is deprecated, in favor of making
calls on the ContentProvider.

Bug: 9842867

Change-Id: I65f559e593cda24456c4ffb96f785e054626dd0b
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
afe097f318a7eeac9d240d2bedbc5caba7640ea8 26-Jul-2013 Yu Ping Hu <yph@google.com> Simplify account reconciliation.

- Rather than handle by type, do them all at once.
- Simplify when reconciliation happens.

Bug: 9056861

Change-Id: If264678c82c63090246ef8ff857c8e46f6672c85
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
9a1f00bee4c50c128df320a3795cfc8295d5e011 20-Jul-2013 Yu Ping Hu <yph@google.com> Change deleteAccountPIMData to take emailAddress, not id.

By the time the remote call actually runs, the account
may be deleted from the DB, so the account id is likely
useless.

Bug: 9021105
Change-Id: If28b4b8c4b5c52be35c6ff68b326c4ea28d7f7b4
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
d5acf0bbc00cbe9a2c075e1bd4825ccbd9851d8d 15-Jul-2013 Yu Ping Hu <yph@google.com> Explicitly pass a callback when loading attachments.

This is part of moving away from the explicit setCallback,
which either has race conditions or is very noisy, or both.
(Each IEmailService call that wants callbacks should just
pass the callback explicitly.)

I'm not yet changing how the services actually handle the
call. Each protocol will need to fix this on their own.

Bug: 9735207
Bug: 9842867
Change-Id: If8cf69ffe82f3544ace9e58b1db5a183f38d038a
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
560bfadc3151f7a06f3b06e9a6c92cfa534c63ec 26-May-2013 Scott Kennedy <skennedy@google.com> Unify LogTag

There is now only one LogTag class. The static initializer of
GmailApplication (existing) and EmailApplication (new) will now set
the log tag to "Gmail" and "Email", respectively. Up until that code
is run, it will be "UnifiedEmail".

"setprop log.tag.Gmail VERBOSE" (or .Email) will trigger all logs to
be printed as long as they go through LogUtils, regardless of what tag
is used by that individual log. This lets us still turn on logging
everywhere in one command, but also lets us use more descriptive tags
(like the class name).

And since we no longer have three com.android.mail.utils.LogTag
classes, builds will be much easier.

Also, we now use LogUtils everywhere.

Change-Id: I55f1c7a66ce50ead54877a13e40256422a56dc39
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
9e7f5a2a33a31ff392d3116f6432b2f93ffe8e71 25-Apr-2013 Yu Ping Hu <yph@google.com> Use system SyncManager for Exchange.

Change-Id: I77e4e75c94c532d22a28cf97e6f55f1259b8bdde
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
17d5bbf768c27ac7782b155e2ab25bcd480f5dcf 05-Apr-2013 Yu Ping Hu <yph@google.com> Improve mailbox sync and load more.

- Update syncTime for IMAP and POP whenever we sync.
- Change load more to simply include the delta in the RPC
rather than using the visibleLimit column.
- Add a query to get the message count for a Mailbox.
- Refactor code for updating totalCount and determining
the new message count when syncing.
- Remove dead code from Mailbox.
- Remove uses of visibleLimit from code.

Note that visibleLimit and messageCount in Mailbox table are
no longer useful and will be removed in a later change.

Bug: 8579767
Bug: 8523146
Change-Id: Ieb67e3b6f1c82c3b21b972c5a1e557cd75dc21db
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
861c5c8c9e054a4562af44805c57f39e7121ca43 22-Mar-2013 Yu Ping Hu <yph@google.com> Guard against potential NPE.

Change-Id: I379da1f478b1b1fd1e488dbeff249cc10e3d48d5
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
2192bf01e0df1285718b53f6b77d635f4e8c65ca 20-Mar-2013 Yu Ping Hu <yph@google.com> Always create system folders during sync.

Change-Id: I8ff6eb4f65d4207d7a2768c5fd837fad8cd47269
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
9d91dd8023b31f37c0aade7bf6d9910908204a94 12-Mar-2013 Yu Ping Hu <yph@google.com> Specify correct sync extras for user-requested syncs.

BUG: 8364227
Change-Id: Icfc97c92e5ecc9c2abd83b73cf67a5e10408cede
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
9a95253846ccc7a94dd7d4c618ec2d808e2a4000 23-Feb-2013 Paul Westbrook <pwestbro@google.com> Cache attachments on send

Cache attachments in a email directory when sending to allow sending
to succeed when the content provider has a permission

Bug: 7381557
Change-Id: Icf9faead2048de237228625f998b42feade48978
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
54347010fbbdd3ae1dea5b0e282514c640e16a5f 22-Sep-2012 Marc Blank <mblank@google.com> Allow legacy imap to sync

* Remove old (and dangerous) constants

Bug: 7210754
Bug: 7212263

Change-Id: I6a1463a653c5c4823a96c9fbb9ca37e53a45b48a
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
f53490dc86f5a61ab09024dc4938ce8419c61fc5 03-Sep-2012 Marc Blank <mblank@google.com> Reconcile all types of local accounts in MailService

Bug: 7078247

Change-Id: I43eb5b8a85e40217893bdc08cd839450358d07ea
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
e714bb9d153cfe13a7f0932e7d67ea08fa5a1d98 23-Aug-2012 Marc Blank <mblank@google.com> Convert authorities, intents, and account manager types

* Tested ok on wiped Nexus
* Tested ok on S3
* Upgrade verified on Nexus

Change-Id: If5d4ce594f8a309cdb59589d10b1d33f3b79326c
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
f6db592c313c77190727c7cd72d3edda9d23a099 02-Aug-2012 Marc Blank <mblank@google.com> POP3 renovation

* Much, much faster
* Remove message length pass and lots of other useless code
* Create pseudo-attachment for long messages (click to download) that
includes size (so user can determine whether it's worth it)
* Handle download of message via pseudo-attachment; real attachments
are then created as necessary.

TODO: Add real UI with UX input (or modify existing to clean up the
loose ends)
TODO: Optimizations for loading the whole message
TODO: Get server delete working (isn't working currently anyway)

Change-Id: I31f3809fc5a2f9fd490d33cfed70d2930654e71d
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
c5afb16430a145f20d7c887e45f47b38687054da 28-Jun-2012 Marc Blank <mblank@google.com> Add a bunch of stuff missed earlier

Change-Id: I7f707446a963912fe5786dacb5569e68db572d1c
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
03cd72805dab0379ed255d151f1c17cc60655fc3 25-Apr-2012 Marc Blank <mblank@google.com> Revert to old Email app

* These are the last sources in the ICS-MR1 tree

Change-Id: Ida4651bddd92a06a518d00f3e1f275ab3a80c8ae
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
824f7763653cd9c15f400301de53f5023ae37762 12-Mar-2012 Marc Blank <mblank@google.com> Fix up load of IMAP attachments

Change-Id: I2f55fc2c3d92eff72ebfd50ff3f782928f3a85a2
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
ab6321e2c470596b9d8e4f97a23160788d917590 09-Mar-2012 Marc Blank <mblank@google.com> Fix SMTP sending

Bug: 6134036
Change-Id: Id48e4bd17e7493d873d888027e68c7eb86d23198
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
af8f8a48ee8a974862802a39a001390937a3cfb7 07-Mar-2012 Marc Blank <mblank@google.com> Reconcile accounts in deleteAccountPIMData

Change-Id: Ifd17ef76e13ddcfa07c84429dca7bf19e6cbcfab
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
87c84a6d96a360b2310f44ff4ae2e181c7a4479a 23-Feb-2012 Marc Blank <mblank@google.com> Send sync status updates from POP3/IMAP

Change-Id: Ia1bb5d1a302d6dde8b8979e03a762d6d45ee8cd3
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
9227dbbf0f1c467762c44119d7cb1140c7191a88 19-Feb-2012 Marc Blank <mblank@google.com> Add back attachment loading callbacks for IMAP

* Remove newly unused code

Change-Id: Ifea2193deaf35734a031500c807ce9e3abd88fb1
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java
4f813fb12937de74d3ccec730b8de0c9de7a87e0 14-Feb-2012 Marc Blank <mblank@google.com> Convert POP3 to service

* Remove MessagingController and (almost all of) MailService

Change-Id: I8953b58b237de6a71fda770f1727bd94081fec55
/packages/apps/Email/src/com/android/email/service/EmailServiceStub.java