History log of /packages/apps/Mms/src/com/android/mms/ui/UriImage.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
ab845dee6565a8dfc384186bc8f2e801a2b087e1 07-Jun-2014 Ye Wen <ywen@google.com> Use unified log tag for Mms app

Change-Id: Icec182674c008c2b9d01a6010a2aafc8111b2b7e
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
ec4bb6f515828078ab9eed2fb065eeec328f0c63 31-Jul-2013 Tom Taylor <tomtaylor@google.com> am 6cd6d60c: Merge "Mms: Fix javacrash in com.android.mms due to memory leak"

* commit '6cd6d60c21abbc572176e1b0a2869d2eabf4967e':
Mms: Fix javacrash in com.android.mms due to memory leak
e8a0d786fba1960818cb3da938cdbf2b2b11b340 11-Jul-2013 Tom Taylor <tomtaylor@google.com> When picture is attached in the Messaging app, the attached picture is rotated 90 degrees

Bug 9300964

Look at an image's exif data to rotate the image to the correct orientation.

Change-Id: I1fc51467b28cdf3594955e2ddedb28abd1456671
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
b11ba2319f4c6dea364a9682b9566f24d3cb30bf 31-Jul-2012 Frederic Predon <frederic.predon@intel.com> Mms: Fix javacrash in com.android.mms due to memory leak

when the UriImage resize the picture. It will not close the
InputStream and OutputStream.

Change-Id: I80fa1eb3726308fe75d74357e0b9782759de3393
Author: Jianping Li <jianpingx.li@intel.com>
Signed-off-by: Jianping Li <jianpingx.li@intel.com>
Signed-off-by: Hongyu Zhang <hongyu.zhang@intel.com>
Signed-off-by: Frederic Predon <frederic.predon@intel.com>
Signed-off-by: Shuo Gao <shuo.gao@intel.com>
Signed-off-by: Bruce Beare <bruce.j.beare@intel.com>
Signed-off-by: Jack Ren <jack.ren@intel.com>
Author-tracking-BZ: 28037
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
95e0a156327c18f2e9afc72a45a5985ad6ae7abb 09-Sep-2012 Wei Huang <weih@google.com> bug #7128602: Messaging app crash on choosing to share all the picture attachment received on Gmail

- if we cannot get the mime_type from the "mime_type" column, then try getting it by calling
ContentResolver.getType(uri);

Change-Id: I510ab2444eaa3bc96e2551cfb659d4afb77d3af6
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
d64419030e1fec1e751695dab3bd7236e2fb0214 02-Aug-2012 Roger Chen <cxr514033970@gmail.com> Clean and format all imported packages

Change-Id: I2e45f5ba1d56b9b17314a8b0f4c0fc1a5d8fc4d9
Signed-off-by: Roger Chen <cxr514033970@gmail.com>
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
2c48c7894f1c4d4265bfe499e596fdd6fd3e9484 17-May-2012 Tom Taylor <tomtaylor@google.com> Crash on choosing to share a saved image via Messaging app

Bug 6507437

Images downloaded from the web have a column "mimetype", whereas images
from the gallery have a column "mime_type". With this change the code
handles both.

Change-Id: I01ab19ec46ef43b51d6bfd6beac96535bbc7ae35
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
852b629e3be73f8eb01651f1868f3ed1857df815 05-May-2012 Tom Taylor <tomtaylor@google.com> NPE on orientation change while in Edit slide show page

Bug 6445435

A debug line was causing the crash. Consolidated the test.

Change-Id: I571879a07ce4f0aee8596bd81618ac822b058833
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
f5b73486499febb57260bd63f694c47b07e240fa 09-Mar-2012 Tom Taylor <tomtaylor@google.com> [VzW Issue] MMS picture file attachments disappeared when sent to an exchange email account (Sam_Int_36081)

Bug 6116662

Use the original filename if available as the name of the attachment.
Prior to this change, the code was using the leaf name of the uri
handed to the app from the gallery. This was typically a timestamp.
This was never a problem, but apparently MMSs mailed to Exchange
is a problem because it can't deal with images without extensions.

Change-Id: I17cac0113439fece6986459925d72dfddf41528f
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
721ad07121cb9b0cd76bdbbc88494aa8f4d45a6d 06-Mar-2012 Tom Taylor <tomtaylor@google.com> Increase cache size and put downsized thumbnail images on disk

Bug 6093907

Use Gallery code to compress thumbnails and store them in the
app's cache dir (not on the sd card). Increase the size of the
in-memory thumbnail cache to 16 images. Set the pdu and image
loader threads to a lower priority than the UI thread. Don't
extract the empty image bitmap on the UI thread. In fact, don't
show the empty image bitmap until we're sure the image can't
be decoded. Don't set the image bitmap multiple times. Remove
excess color list background that slows things down. Clean up
the thumbnail loader and get rid of the width, height params.
Lower the pdu cache to 16 items to match the thumbnail cache limit.
Modify SimpleCache to support both hard and soft references and
use hard refs for the small pdu and thumbnail caches. The result
is much faster and less janky scrolling.

Change-Id: Ifc0d590d4ab27bb66d306b681082b4e95cf3d64d
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
51e4621fa12400b1e79cc18b7bb0f9a83af6b622 27-Feb-2012 Tom Taylor <tomtaylor@google.com> Scroll jank when scrolling MMS images

Bug 5919625

Load PDU, slideshow, and images in the background.

Change-Id: I456ba8e0044a902af7310427f3172441f40cf215
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
37880013315d8b7abefd9081b2c36b060083d6fa 27-Jan-2012 Tom Taylor <tomtaylor@google.com> The pictures shown while playing a slide-show are very small

Bug 5180652
The slideshow pictures were showing thumbnails. Now show larger images.
Not perfect, but better than before.

Change-Id: I38222676e50923a8c69ffea2b323725e384d490d
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
3d8877fa3e07c019d1779793ca0081beca177b6a 24-Jan-2012 Tom Taylor <tomtaylor@google.com> Crash in MMS on discarding a Message

Bug 5899557

There are two serious bugs here.
The first bug is that UriImage.getResizedImageData would get stuck in an
infinite loop when the picture data couldn't be decoded. Normally this loop
handles the case where an exception is thrown because the image is too big,
but in the case where the data is empty or perhaps corrupted, BitmapFactory.decodeStream
will return null and the code will end up in an infinite loop. This is done
in MmsSender in a background thread, so it doesn't affect the UI, but the
user sees that the sent message isn't showing up in the message list.
The second bug is when an exception is thrown, CMA puts up a dialog.
In the repro steps of this bug, backing out and the coming back in caused
this exception to be handled after (or during) the activity was finished.
I was easily able to repro this by hitting send and back quickly.

Change-Id: I3fe780119f15ef7d99dae45a3ebd2b4b56688e85
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
6798ba71f8b01d382bdc83b7f40757aa89c280cd 21-Oct-2011 Todor Kalaydjiev <todor@google.com> Make sure future changes to this math don't accidentally use int division
and end up with a result of 0 to represent the fraction.
Also, remove an obsolete part of the comment.

Change-Id: Ib2ad2d9c138979b6695f09428c6549a8408e3844
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
1c4ee29d168bf380054499201e6e7c262d53e4a7 20-Oct-2011 Todor Kalaydjiev <todor@google.com> Fix resizing images when byte size is >2x the allowed limit.

b/5486816 - basically we were unable to attach more than 1 image to
an MMS in most cases. Pretty bad.

Change-Id: Ic42d267258614784042e506818a7fb4ff3a3fd99
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
bbc5b8d0076b0cdae851bfec636a854ef77bd6ce 13-Oct-2011 Todor Kalaydjiev <todor@google.com> Fix sending non-JPEG image attachments in MMS

b/5407752

Change-Id: If3b9581e825ec9e6d684787cef213b898a8de7c7
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
fa9be169b5a572e0e143e582079259ee074d9d5a 10-Oct-2011 Tom Taylor <tomtaylor@google.com> Crash while sending multiple picture attachments

Bug 5434302
The bitmap used during the picture resize/compression loop was getting
recycled in the middle of the loop. Recycle the bitmap as we exit.

Change-Id: I8e8a60d820e9a8c2ca7414346736a8a064fe57d3
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
62723bac2451cee231087bd10aa5ad4682b84760 04-Oct-2011 Todor Kalaydjiev <todor@google.com> Merge "On resizing image, retry with smaller sampling if decoding fails due to an out-of-memory error."
946c8e09668d50bd1657a253a0220b807a4d1f28 04-Oct-2011 Todor Kalaydjiev <todor@google.com> On resizing image, retry with smaller sampling if decoding fails due
to an out-of-memory error.

Change-Id: Ibf3fefd002a0cf805abd86edd07e4a6db2f22073
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
1009d4bf5ee9fd1f2523e530828de5babb78eb19 04-Oct-2011 Todor Kalaydjiev <todor@google.com> Don't resize images for MMS unless it's necessary.

This saves the decode/compress/save-to-file steps.

Change-Id: I702f71ce9f613118ec7ae1e69418d8df2fd10f35
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
9aeb4e9e6aebe9d99cf817cedbdeb0bb0ae5a024 29-Sep-2011 Mark Wagner <mxw@google.com> bugfix 5381702 MMS app puts temporary files on sdcard in wrong location

Part B of a two part checkin to fix this to use the system provided location
for temp/cache files.

Change-Id: I03764c25d5d1f8bbdc1b30ef5168128922bf0792
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
8c86a52a2c13083a25761256ab0dfc416260c162 29-Sep-2011 Tom Taylor <tomtaylor@google.com> Handset resizes image to a small size

Handle portrait images better. Don't resize so aggressively. Resize
by 75% at a time, rather than by half. Bug 5249464

Change-Id: Icc4bc30a56f15de635ba0386c454c49924470eb1
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
b0664c5822ee07642617a73c932b02a2636a2223 15-Sep-2011 Tom Taylor <tomtaylor@google.com> Handset resizes image to a small size

Capturing pictures in a slideshow is different than capturing in
ComposeMessageActivity. We need to pass a temp file uri to the camera
to store the image, otherwise the camera will return a thumbnail size
image. Keep a temp file for each slide. Bug 5249464

Change-Id: Ic6987781fe4a318c00b89f76c1b3e8722ed855c6
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
e7cee115c2e0deada90627fd265139c22fdc32d4 27-Aug-2011 Tom Taylor <tomtaylor@google.com> Crash in MMS while attaching a picture from Picasa

Tested with local pictures, pictures from picasa, and captured pictures
from camera. Bug 5027908

Change-Id: Ieff7a876c8d48d800b74de893e6cac47f6bddd24
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
150c4179995cc0a75f934ef194372f9295957ca2 08-Apr-2011 Joe Onorato <joeo@google.com> Remove the deprecated things from Config.java. These havent been working since before 1.0.

Change-Id: I7b60931012a68116b516acc8af8a7a8fdeab97c3
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
b48902c3b2bd35c189f50ea44a61718c2d3c5d80 02-Feb-2011 Jean-Baptiste Queru <jbq@google.com> Merge from open-source gingerbread

Change-Id: Ia574c3da7273fea835eadfa0f48cde5392ab10e7
b02d890bd31dbf4c91390652a35282babec3b889 31-Jan-2011 Sang-Jun Park <sj2202.park@samsung.com> The problem is that attached files(ex. Image, Movie) on MMS are not displayed among other devices.

- Symptom
1. Attached Movie, Image files are not displayed
2. Attached MP4 file is not displayed : NexusS to NexusOne
3. Attached 3GP files can't be played : NexusS to A877/A797
4. Attached JPG file is not shown : NexusS to A877
5. Attached JPG file is not shown : Iphone to NexusS

Change-Id: I443bbcca6b6a678cd816a3d0c2bf72f544d8fd56
Signed-off-by: Sang-Jun Park <sj2202.park@samsung.com>
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
0ca1428f36dce56a402e19d6b6c04c4c1cc1e69a 06-Jan-2011 Tom Taylor <tomtaylor@google.com> OOM at com.android.mms.ui.UriImage.getResizedImageData

Recycle the bitmap each time through the loop and catch OOM when we
try and convert the bitmap to a byte array. Bug 3263587

Change-Id: I83dde7ed10f18ad6a6f81ca34babe4e455a5ec42
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
5a3151adedd991252dd529c75e85a3374970dfb0 16-Sep-2010 Tom Taylor <tomtaylor@google.com> Handle OutOfMemory when decoding images

Decoding images and videos in the messaging app appears to be a
vulnerable point for running out of memory. Catch those exceptions,
log an error, and continue on without loading the image. Most of these
"catches" are around situations where there's been a problem decoding
the original image in the first place, and now we're simply trying
to decode a small missing stand-in image. However, since BitmapFactory.decodeResource
seems to be in an inordinate number of bug reports, I want to log every
use in the code in case of failure.
Handles the 2nd part of bug 2994057.

Change-Id: Iaa8035f6ef28385b353d31507b9753934881d3e8
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
f7e8281a223af6228e6399055a6197a1edd9bc3a 09-Mar-2010 Tom Taylor <tomtaylor@google.com> Remove mms-common

Get rid of the mms-common library and move the mms files back into the
framework where they originally came from.

Change-Id: I8ce2b0a2a3cfc6b7da13ce0e791173c09dd8f0f5
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
fd644551e8506266aad2b76463b51b44154ed62f 29-Jan-2010 Tom Taylor <tomtaylor@google.com> Update refs now that MMS is removed

Move MMS to mms-common library. Update imports.

Change-Id: I28fa24a68c27977eba58cb62f2667596d3abe2c4
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
6be18bedb5b87dbbcdb54f37d5a0945bd0f71377 17-Dec-2009 Tom Taylor <tomtaylor@google.com> Unbundling work

This is the first step in unbundling the Mms app. Some of the changes include:
- moving some of the Mms code from the framework into the app itself.
- same with emoticons
- remove dependency on internal drawables and add local copy to mms
- some dependencies on various internal classes now moved to android-common library
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
10eed0e3020e3eb0612747fe39e0f6117222dd95 09-Dec-2009 Tom Taylor <tomtaylor@google.com> Resize pictures at send time

Before this change, picture attachments would get resized as they
were added to a message. This means the first picture could take up
to the whole message space, the second picture any remaining space, etc.
With this change, pictures aren't resized until after the user hits
send. The remaining space in a message is divided equally among all
the picture attachments and they're resized to fit within that space.
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
cb0668e2c6541737c785af8641efad4be53a9056 22-Oct-2009 Tom Taylor <tomtaylor@google.com> Fix null ref

When getResizedImageData fails to scale down an image to a size that'll fit in
the remaining available message space, return null rather than trying to
dereference the null byte array.

Change-Id: Ibb1f5ddd935f952e5f90d8835947cc46bc138aa2
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
1cf7f03f05cf0a1172f027f75f67a6fff336c79b 30-Sep-2009 Tom Taylor <tomtaylor@google.com> Handle out-of-memory while decoding image

When adding images to a mms message we attempt to resize an image, if
necessary, to keep the message within its maximum message length. In
some cases, the first crack at decoding the image can throw an
out-of-memory exception. With this change, we catch that exception and
try decoding again at a smaller scale.

Change-Id: Id8ebcab4c407f316dd850640ab8f058845fb7054
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
9242286c35743422051d439d7460cd0a1426899c 16-Sep-2009 Wei Huang <weih@google.com> add more logging in MMS. Try to catch an OOM error, and dump hprof data when it occurs.
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
325a37787f144421f995eeb385f67a5d255d7820 11-Sep-2009 Tom Taylor <tomtaylor@google.com> Better handle filenames

When getting an image uri that pointed to a file, the code didn't
handle filenames with spaces very well. Furthermore, if the code couldn't
parse the filename extension, it would throw an exception and crash.
Give another shot at finding the extension and if that fails, don't crash,
but show a "picture couldn't be attached" toast.

Change-Id: I5a2fcf6cc16984d81a3b8d5a7ef19367e16dd839
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
f79b803adc0cee3778cf6aac52d203896cde5d95 04-Sep-2009 Christian Gustafsson <christian.gustafsson@motorola.com> Resize images when they exceed the MMS payload size

Code was in place to resize images when they exceeded the maximum
MMS dimensions. But the case where the byte size of an image was exceeding the
MMS payload just resulted in an error message to the user. This is a problem
with high resolution images taken by the devices camera. These images fit the
MMS dimensions but routinely exceed the MMS byte size.

Extra fix for GIF images. The GIF decoder does not honor the scaled decode
parameter. Code now calls the Bitmap scale function when this happens.

1. Change the getResizedImageData function in UriImage.java to account for
byte size as well. If the resulting jpg exceeds the byte size attempt to
reduce the quality on the compressor first. But not below 50%. Should
this step not work then rescale the image to a lower resolution and try
again. Do this up to 4 times.
2. Change resizeImageAsync in MessageUtil.java to pass a maximum bytes size.
Account for a MMS overhead of 5000 bytes in this case. So the maximum
image size will be msConfig.getMaxMessageSize() ? 5000.
3. Update 3 places to call resizeImageAsync instead of showing an error
message to the user.

Change-Id: I33427fe79c42677e24acf0390ae834d58205c8f1
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
72b7fda4ff5e94ba1a13c41601ac1cd61c0d6663 09-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //branches/cupcake/...@137197
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
bd09a4b8c2d1f922f1459c4d7b61e7e87ed4ddf3 06-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@136745
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
72735c62aba8fd2a9420a0f9f83d22543e3c164f 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
892f2c5bf965b1431ae107b602444a93f4aad4a3 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
153ae99e0a7d626a24d61475eeb133249deb448c 03-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@132589
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
abd7b2d90f7491075f1daba4b4cccdfc82f8ddd1 03-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@137055
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
0f236f55349f070ac94e12cca963847173393da8 18-Dec-2008 The Android Open Source Project <initial-contribution@android.com> Code drop from //branches/cupcake/...@124589
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java
8eed706474910ccb978acda03e85d3261037da6e 21-Oct-2008 The Android Open Source Project <initial-contribution@android.com> Initial Contribution
/packages/apps/Mms/src/com/android/mms/ui/UriImage.java