History log of /packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
1b8d42f7d1711664a0bb0de0a8585ada6c24ffad 18-Aug-2014 Ray Chen <raychen@google.com> Allows subclassing showHelp from EmlViewerActivity

b/17035955

Change-Id: Id11ff4190c6cf865b139016c938a1eac26d423e5
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
afaab1752ab5b507cdaad7b3619ffc1c9728368f 08-Aug-2014 Andrew Sapperstein <asapperstein@google.com> Remove above attachment promo. b/16138036.

Change-Id: I611f0f7e6eeea0247956e0f1a9f2ec3ec51c9eef
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
aa4c9941269cc7815dd80e649e24d0257f83d5d5 29-May-2014 Alex Gawley <alexg@google.com> Update Attachment Handlers.

Change-Id: Iddd3c6e6ae7ef152db8143acfe9dfcc0ab6ec7af
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
a2519e3a1444b8421261348279883108ad1d00be 02-May-2014 Greg Bullock <gregbullock@google.com> Perform a null check on mAccount before it is dereferenced.

http://b/14385033.

Change-Id: I5344302b933c902ec8a05e0d49314e37917f6344
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
833123d9c31b0b2dd23f7f74738c5bccf8a546d3 24-Apr-2014 Andrew Sapperstein <asapperstein@google.com> Hide Save to drive in EML view. b/14277510.

Change-Id: Ia75fb95536517df576ef3c39072a423e3e244b6a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
381c322eb30c39f63a2bb82812d63262eb3c1c1c 20-Apr-2014 Andrew Sapperstein <asapperstein@google.com> Save to drive promo. b/7659807.

Provides a space above the attachment bars to show
some additional content. Default behavior does nothing.
Hooks have been added to allow resizing of the message
footer.

Change-Id: Ib950091d176311bdb06c7c7a466223beb997a7b5
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
023f8bd83674dcb780656159aab8767c158a49cd 27-Mar-2014 Andy Huang <ath@google.com> ensure account is passed to attachment option1

whoopsie!

Bug: 13654223
Change-Id: Idc82aa2fe2982dfa84fe6af4cc8bf8c2da334961
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
4f347e811052f446c3958c76db278bcd7b39a44f 26-Feb-2014 Andy Huang <ath@google.com> allow an extra option on attachments (in bar and tile UI)

Bug: 7659807

Change-Id: I4c1294d2ba772a70139e0b37429b17bc6096cafd
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
f59d01c3116dc2adde97a5b52aa6094144c2d315 20-Feb-2014 Andrew Sapperstein <asapperstein@google.com> View entire message UI.

We need the per-message plid server support,
but we are forwarding the clipped bit to
the UI and showing a button based on that
bit. Clicking that bit will open the
plid viewer for gmail. Email should be
unaffected as it does not ever return clipped as true.

b/2887917.

Change-Id: Iddb54e37cf650ca16a75fcbe69f1861becdd81b9
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
7348cf23d9df1ea3c58674b2c67d8219a6094fcf 20-Feb-2014 Andrew Sapperstein <asapperstein@google.com> Fix yet another unicodeWrap NPE. b/13108784.

Change-Id: I5d1df39b8f49641a3a9a8fe9187049a590d820ed
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
2fd167d6131482da984768b5ee75cefa32ed3e32 28-Jan-2014 Andrew Sapperstein <asapperstein@google.com> RTL - conversation view fixes.

b/12681840 - Properly align attachment details.
b/12681242 - Message header expanded details are locale aligned.
b/12681528 - Message header title and snippet are locale aligned.
b/11989230 - Set each overlay view's layout direction.

The first three bugs were fixed by adding unicode wrapping
to a bunch of fields.

The final bug was slightly more complex. In some scenarios,
the overlay views's layout direction was not properly resolved.
But it should always be the same as its parent so we forcibly
do it now when adding new views.

Change-Id: I9e065e0deaf1958ee87d098231238f6d976e9e68
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
07005a9831a20d28ce23417803689ab8c157ed67 01-Oct-2013 Andrew Sapperstein <asapperstein@google.com> Removed Mimetype.isBlocked and all usages.

Fixes b/11016967.

Change-Id: Ic85b89c3c82a39c511cedb0f938ed9286a1470af
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
519c218db6109003ca72a35ffe276ed69b0230a4 21-Sep-2013 Martin Hibdon <mhibdon@google.com> Improve display of attachments in pop

b/10714298
Prior to this CL, attachments that had not yet
been downloaded for POP would appear as "text/plain",
regardless of what type they really were. Also, the
filename displayed about always be a non localized
string like "click here to download".
Now, attachments in this state are flagged as dummy
attachments, so when we display them, we display a
localized instruction for how to download, and hide
the mime type (because we don't yet know it.)
Also, when we download, we will not automatically
try to launch a viewer for these kinds of attachments.
We'll just download them, and replace the old dummy
attachment with a valid one.
There is still a bug that even though the dummy
attachment has been removed from the database, we
still display that tile until the user leaves and
reenters the screen. That's ugly but not so broken
as it was before.

Change-Id: I1021baae659ca2d9ee2909f78b414c271d8ca90b
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
e003b4cc4a23e6d394998bebe26430a361c5ac29 16-Aug-2013 Andy Huang <ath@google.com> metrics for attachments

Improve folder-switch logging with detailed data for system folders.
Also prevent exits from a blank compose from triggering a log event.

Bug: 9861033
Change-Id: Ie75323fe3704d3010acd864c6d7c646ebd7708b5
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
ce9db80cf997f99b8c5d0ef8d22b074555aaf795 08-Aug-2013 Mark Wei <markwei@google.com> Fix attachments not downloading on 3g.

Add redownload menu item for photos so they can be retried if they ever get
stuck.

Change-Id: I0e3bd8014f81cf7e230e055f92d1442280307657
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
2b9d80eb16156173f11a02eae4f770d8c975927c 31-Jul-2013 Scott Kennedy <skennedy@google.com> Change all resid switches to if-elseif-else

I really want to get this building in an IDE.

As per http://tools.android.com/tips/non-constant-fields, library
projects (like UnifiedEmail will be) have non-final R constants. They
are not final until packaged into the main application project's
(Gmail/Email)'s R.java.

As such, they cannot be used in switch case statements, and we must
use if-elseif-elseif-elseif-...-else instead.

"This is typically in UI code and the performance impact is
negligible."

Change-Id: Ie699c13e1becd51c59c1b2ea81bc902d4f2e28d9
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
25b8013b8b6bc6e3315f3b21323642705babb6ed 26-Jun-2013 Scott Kennedy <skennedy@google.com> Merge "Clean up a bunch of warnings" into jb-ub-mail-ur10
3b965d78774a42358ce6bbdcc43b4c8df130a60e 25-Jun-2013 Scott Kennedy <skennedy@google.com> Clean up a bunch of warnings

Bug: 9565838
Change-Id: Ie3a380581e81c63aaa0764875c55bfdccd5f2b13
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
7638a1004e7c8ed7a85620243da3b051b60217e8 25-Jun-2013 Andrew Sapperstein <asapperstein@google.com> Final eml viewer cleanup.

Fixes b/9560839. Now we show the title of
the eml file and we also show an overflow
button with settings/send feedback/help.

Change-Id: I5eab245d9fd47e37b83eadcb419255939117ab39
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
7434e800d4313a227120ca36bd95683752a7879f 21-Jun-2013 Andrew Sapperstein <asapperstein@google.com> Attachments in eml files.

It's kinda slow for large eml files
(because we have to parse the entire
file) but it works. Hooray.

Fixes b/6393073.

Change-Id: I2d7a87a484cd282a000a0905fe069f3ab45e2061
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
8d4791ce70b3f71cc90256bc4b5b236379b56331 12-Jun-2013 Andrew Sapperstein <asapperstein@google.com> Export Eml viewer.

There's really no reason why it shouldn't be
and having it exported prevents b/9334785 from occurring.
Additionally, so that we only use the app's eml viewer,
we check if the attachment is an eml file, and if so,
just open the viewer directly rather than letting the
framework disambiguate (which causes an activity chooser
to show when we have multiple activities that can accept
eml files).

Change-Id: I98e13f894c9218d62049b16e0f4c20c77501fcc5
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
c30808f28ba0a85ed8495a5e840e137306d2a0f0 06-Apr-2013 Mark Wei <markwei@google.com> Don't allow save for blocked mime types.

Bug: 8488318
Change-Id: I477b05d53aede0af988d42d154952e8b256e2c32
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
381c6b390dfbfdf7040dcc2193438c70c6f66b9f 22-Feb-2013 Mark Wei <markwei@google.com> Fix line width nits.

Change-Id: Ic8d33ce3d0c8c78eb461ef056f0b625d68a510b4
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
8750066b10f80e2a8080016973b3296d76d18266 20-Feb-2013 Mark Wei <markwei@google.com> Set MIME type correctly on drafts when content provider does not provide it.

Bug: 8235172
Change-Id: I7bbccbecb7d038f3add4503be0dcf460a4864b2e
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
1867a56f7b9b3146829752b942285ffdc9b3f3de 20-Feb-2013 Mark Wei <markwei@google.com> When normalizing MIME type, also infer it from filename in case it is generic.

Bug: 8223790
Change-Id: Ie093eea2fb1710bfe66472e92e4f5db2b4247f53
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
bf3a5c5aa46759a238b3ca197b97bc4182cba8b6 15-Feb-2013 Mark Wei <markwei@google.com> Fix cannot install APKs in Gmail. Workaround puts file:// uri into contentUri so
the package manager can read the file.

Bug: 8194270
Change-Id: I7fc55dff0218f7686abdeeddccd0b963e224a63d
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
b5ef9a9497aeef6ccff95ce4f1e2e43912e3fcc4 31-Jan-2013 Mark Wei <markwei@google.com> Show retry text and Download Again overflow item when download fails.

Bug: 8090383
Change-Id: I353688be4e54fde8439104a8639bf6b7d573ecce
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
267453587f13986acc7de3d52de95184c38fb4e1 18-Jan-2013 Mark Wei <markwei@google.com> When clicking on a MessageAttachmentTile, the images download with varying
priority.

The clicked image should have highest priority, and images further to the left
and right should have consecutively less priority.

Bug: 8023818
Change-Id: I5531971f00db68e4b99bb210c757db53fc2a936c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
bbe74aee04f669990e888095b0d6858dc1e17ce1 19-Nov-2012 Mark Wei <markwei@google.com> Refactor Attachment code. Combined AttachmentStatusLoader.Result and
Gmail.Attachment into GmailAttachment.

Renamed UIAttachment to Attachment, which still follows the UIProvider contract.
GmailAttachment extends Attachment, and contains Gmail provider specific data.

The DownloadListener in AttachmentStatusLoader will modify the cached
GmailAttachments directly, where previously we would create new Results to give
to the ConversationState.

Cancelling an Attachment download will cancel both cache and external db
entries.

Attachment download dialog will close only if state is SAVED or FAILED. This
prevents a NOT_SAVED state update from closing the dialog prematurely.

Simplify AttachmentRequest. Simplify AttachmentStatusLoader to a listener.

Bug: 7538447
Bug: 7538152
Change-Id: If6362473697e6735f1858619c7af83238d75469e
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
c40e5e818876db551e8f7c6f506ebaf38f73ac7a 09-Jan-2013 Mark Wei <markwei@google.com> Fix string formatting issues.

For subtitle and actionbar text.

Bug: 7919558
Change-Id: Ie47a6a42df1c3161aed64dbfc8159d9686cb157c
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
856200a2abc6a90711f6eb99fc0340dd75ef6e9b 10-Nov-2012 Mark Wei <markwei@google.com> Prevent message attachment bar's Overflow from disappearing when certain
conditions are met. Now the Overflow will appear as long as at least one action
is available.

Refactored Overflow code.

Bug: 7488930
Change-Id: I198211cfaa535861f53f52d04b0391968d6004da
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
74313d9a9ea22d21658e805600f114a78a2fb935 18-Oct-2012 Mark Wei <markwei@google.com> Avoid weird race condition that prevented the overflow from showing up.

Sometimes it is updated to GONE and then immediately to VISIBLE, but in the end
it would not show up.

Bug: 7166903
Change-Id: I80c78fd4d2e6b439bacb87963cf80fc7777ffa55
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
47ca4e2a4c2d7387a7dd8d1925e2512acc553eab 18-Oct-2012 Mark Wei <markwei@google.com> Allow redownloading attachments.

Add Download again button to attachment overflow menu.

Bug: 7362656
Change-Id: I3bd61403205ec2c74f658f6f7f02385f72dd7aa5
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
e18f42d652e171cd4e4bb193482d2e131d91f26e 18-Oct-2012 Mark Wei <markwei@google.com> Fix attachment Overflow and Cancel buttons pushed off-screen

Bug: 7368233
Change-Id: I78c26cd507626fd2c9de15cb14cdacadc7971650
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
4dabcc9f74ea5f75467f6f581d8ef7cd65c2f06e 20-Sep-2012 Paul Westbrook <pwestbro@google.com> Show progress attachment bar

Show download progress in the MessageAttachmentBar

Bug: 7194891
Change-Id: I847cfa562d5ecb48a953a7a23f8b3eed7d442251
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
8081df46ef5a7794374e41cd1836e778a2da9b31 11-Sep-2012 Paul Westbrook <pwestbro@google.com> Restore download progress dialog

Now the attachment download progress is using an DialogFragment
so the dialog correctly gets restored on orientation change

Bug: 7137689
Change-Id: I90a225f423bf75fd4dbeb464051374919a3cff62
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
d6318e56adadeff4106e9696b5330239175487b1 06-Aug-2012 Andrew Sapperstein <asapperstein@google.com> Refactored some of the preview code.

We now have a canPreview method in Attachment
that performs the PreviewIntentUri != null
action. Seeing it in multiple places was bothering me.

Change-Id: I3eedcffb8b5063985cf93ab86876e5170a99fbe0
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
d49db8e3c4fff459f4ae3869ea80d083461eda2c 04-Aug-2012 Paul Westbrook <pwestbro@google.com> Fix preview for attachments

Bug: 6917483
Change-Id: Ie6f8c5b93c8f2046e71700435e69da6b241185b6
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
6b8e4198e622d9eedefdf5fb86c919926ce172e6 04-Aug-2012 Andrew Sapperstein <asapperstein@google.com> Fix b/6931474.

Previously, I was setting the overflow to be open
based upon whether we could save or preview. That was not
correct. The overflow should be visible if you can view
and can save or preview. This now works correctly.

Change-Id: I965e5ce48c29d0c889d76bd62128c72df7247f7d
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
c445aba31c5cc6add9d51296b2c6f5cf89a1e584 02-Aug-2012 Andrew Sapperstein <asapperstein@google.com> Made progress not show when pre-caching.

It seems to work, but there's a lot of bugginess
in attachment downloads so I can't really tell for certain.

Finishes b/6899989.

Change-Id: I88334e5a39df7f850f9d232d804d53ec49a5a875
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
a95161cf364baeea1a9bb098b4f6db961ec8705b 01-Aug-2012 Andrew Sapperstein <asapperstein@google.com> Fix b/6899989.

Now, we block any updates to MessageAttachmentBar's
buttons when the progress dialog is visible. Additionally,
we also block the first update after closing the progress
dialog to prevent a quick update that is then reverted
once the attachment data has been updated.

Change-Id: I4a5ba0720e257c6d9ef09f93a5ac7e7a6b8c6370
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
dc783fbaf21e7a12d449d42407e07577cb937cba 31-Jul-2012 Andrew Sapperstein <asapperstein@google.com> Applied redlines for some of the attachment views.

Fixes to non-image attachments in compose and
viewing mode.

Change-Id: I0e178b0d7aaadac6952ffb8e10d389d68f4524fe
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
591eb37fb6db41f014626d0df51e7dc055d07af0 25-Jul-2012 Paul Westbrook <pwestbro@google.com> Prevent NPE with bad data to viewAttachment

Bug: 6879711
Change-Id: I8ef54fe90b234a13a0a8d2af3dde7f4032074fbe
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
4cb51dbce9635f4bf68a6de88f759e2f86d20325 21-Jul-2012 Andrew Sapperstein <asapperstein@google.com> Image attachments open photo viewer immediately.

Instead of downloading the first image and waiting for
that operation to complete before entering the photo viewer,
we now kick off the downloads for all photos that are not
currently on device. The photo viewer shows download progress
and also shows the photos once the download has completed.

Change-Id: Ib9561b45020bbab1ffbcec9e88aab9604036fd5a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
80ae641cb3ce5199491123dee8f61bf56111d7c2 17-Jul-2012 Andrew Sapperstein <asapperstein@google.com> No longer showing overflow for APKs.

Change-Id: Ib520fc7d87ee666df1877b7a6621c4b4f9626574
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
b5d3874d41da961fa58adbeb9e6ba171261472ce 17-Jul-2012 Paul Westbrook <pwestbro@google.com> Fix viewing html attachments

Bug: 6804149
Change-Id: I8f10de273db7d795779c7fd0bf21e805948e6e75
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
b334c9035e9b7a38766bb66c29da2208525d1e11 25-Jun-2012 Paul Westbrook <pwestbro@google.com> Changes to support different Log tags

Change-Id: I7121fbf7132444fc0f5c0c130373e3f2d1a3cf7a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
532f48253d23ffcb974ab61856df131021dde02a 14-Jun-2012 Andrew Sapperstein <asapperstein@google.com> Enabled actions in the photo viewer.

All four actions (save, save all, share, share all)
are working properly. However, other apps do not
implement receiving the ACTION_SEND and ACTION_SEND_MULTIPLE
so the share and share all actions are a bit janky.

Change-Id: Ifcd3ed36c6bfce4a023b54a61f77e8ae4fd8f3b8
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
4c7d8b5f38bfa80192d457025b834c975d7d38a3 12-Jun-2012 Andrew Sapperstein <asapperstein@google.com> UI improvements to photo viewer.

Photo viewer now shows the display name of the
image. Additionally, it now has a subtitle that
contains the current number of that attachment.

Additionally, the implementation in Unified utilizes
a derived class of PhotoViewActivity that tweaks
the subtitle to display image size and adds action
items. Currently the items are visible but do not do
anything. Next commit will wire these up.

As part of refactoring to make the derived classing work
properly, a bunch of legacy code was deleted including
all of BaseFragmentActivity as its sole reason remaining
was for spoofing the ActionBar.

Finally, a small change to the cancel attachment button
was made so that it was appropriately selectable and
48dip by 48dip.

Change-Id: I5a50bd420fa23a3e7d8734b5a46a6f28198ccef4
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java
4aa1c1340556c646175c3d0b193be05876ad95a0 09-Jun-2012 Andrew Sapperstein <asapperstein@google.com> Non-image attachments now display as a list.

There are now two separate attachment areas in
the MessageFooterView. The AttachmentTileGrid
contains all images in the gridded tile look.
Additionally, there is a LinearLayout that contains
0 or more MessageAttachmentBars. These bars contain
a small icon, info about each attachment, and
an overflow button that contains additional options
other than the default for that attachment type.

In addition, there is now AttachmentActionHandler
that performs a lot of the interaction that both
attachment views share.

Change-Id: I60d297b7514e6ee35d23a9ec250833e886328d4d
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageAttachmentBar.java