History log of /packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
0b69338a45faa422ccba8faf64c9816c55d33e4a 11-Aug-2014 Jin Cao <jinyan@google.com> [KBNav] two-pane landscape navigation polish

The system default navigation doesn't work quite as well
in landscape mode (e.g. focus on conversation view's reply,
hitting up goes to the mini-drawer instead of the message
header). This is partly because our overlay views are not
in a real list, thus we can't take advantage of the framework's
navigation support for listviews.

I decided to roll my own navigation entirely for
conversation view and manually focus/scroll.

This CL also includes some polishes for interactions in landscape
mode between drawer, TL, and CV panes.

b/16636060

Change-Id: Id1de01439a118702756d52f6a8b3f02395a0f932
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
53de448d6c67e56df4e3bcefb3e2d84c810e2e89 29-Jul-2014 Andrew Sapperstein <asapperstein@google.com> Revert "Revert "Megadrawer" until b/16637856 is fixed."

Want this to be ready when the bug is fixed.

This reverts commit c53c887101aa90b5024af635823023aa801e075f.

Change-Id: Ice73a0f48cbe1e949fde3db3719ee86995778ebb
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
c53c887101aa90b5024af635823023aa801e075f 29-Jul-2014 Andrew Sapperstein <asapperstein@google.com> Revert "Megadrawer" until b/16637856 is fixed.

This reverts commit d4bb2af4a545493b88e900be5262329c715dd38a.

Change-Id: I3c8860d30cde8b70c135c2ef457f5f601b45b8b5
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
d4bb2af4a545493b88e900be5262329c715dd38a 28-Jul-2014 Tony Mantler <nicoya@google.com> Megadrawer

b/16458862

Change-Id: I476ee21209e8108fc77e3d265326347a53f13ef5
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
74470048daf58bc4e14130e9c8adec2db78c8163 22-Jul-2014 Tony Mantler <nicoya@google.com> Rearrange MailActivity layout loading

Need to load the layout earlier so that we can access a
Toolbar instance within the layout itself as the action bar

b/16458862

Change-Id: Iba187bb1495fe343a78598355586e1b5253452a2
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
a57da3c151ae174bc8621af79f3f09392ed90953 10-Jun-2014 Ray Chen <raychen@google.com> Implement support for help library
b/12068507

Primary changes:

* Merge help and feedback as requested by the new guideline
* Determine help context by the view mode (list or conversation)

Change-Id: I6d9d7cc56063e7eedfe6db18c2c363e9b4d07cef
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
61f26c2d1c1d3735cf883b58fe7e45550bb1a54c 14-Mar-2014 Andy Huang <ath@google.com> add floaty footer to the drawer

* settings now moved to drawer
* swapped out footer assets to match sectioned inbox icons
(TODO: even newer assets)
* tweaked footer misc to match mocks
* split out the drawer list's scrollbars a la conversation view
* disable floaty footer on short screens (e.g. landscape phone)
* move AAC's drawer-related APIs from Account Controller into
DrawerController and expose more, like raw access to drawer state
* drawer is now white, footer is gray (expansive tablet unchanged)
* align footer items with sectioned inbox items
* only activate the footer items after closing the drawer (smoother,
better fit for Feedback)

TODO: tweak animations, especially when scrolled near the bottom

Bug: 11061485
Change-Id: I3e70d994934c846061efbfb8d118604a965d344f
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
103319aaed26bce257de55b2fe93d4f78d3c59b9 26-Jul-2013 Scott Kennedy <skennedy@google.com> Ads in conversation list

Change-Id: I3095409211d6a6bdc42212bcd6a330333a9da411
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
37a20ca39be842b4b4cb54d5b5ed418d49d950cf 06-Jun-2013 Vikram Aggarwal <viki@google.com> Fist cut of nested folders

1. Rename FolderListFragment.FolderListSelectionListener to
FolderSelector.

2. Allow special views to be tapped; all existing special views
disallow taps.

3. Allow nested folders in ConversationListFragment. The adapter is
responsible for populating the nested folders above the
conversations.

4. Add a nested folder special item for the conversation list. This
reuses current resources and is particularly ugly. The ugliness
will be fixed once we have a UX spec and real assets.

5. The child folders are loaded through an ObjectCursorLoader in the
ConversationListFragment.

Change-Id: I5eb566d7a1f87c1a11fc6961378d00650a27007d
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
aa941d7e107f7ce09838bd4daf295259d126dfa2 05-Jun-2013 Vikram Aggarwal <viki@google.com> Copious documentation

Documentation on usage of loaders close to the source of the action.

Change-Id: I6562950d781dbab3ba00f7d921eeae88ed64f610
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
5747e152fa606c20261b18431f4a9f0ff3be7b5a 13-May-2013 Andrew Sapperstein <asapperstein@google.com> Show/hide menu items based on drawer open/close.

Fixes b/8905351. Currently, when the drawer is
fully opened, we hide the action items except
send feedback, settings, and help. We only
show the other action items when the drawer is
fully closed.

Change-Id: Ifdded1ccd20f012fb6b69089ee3914a399ea8235
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
8c887ef97607ad5c2c94d1d3b902afe6d5ef95a0 24-Apr-2013 Paul Westbrook <pwestbro@google.com> Support pressing title to toggle drawer

Bug: 8521542
Change-Id: I920a54f5ea69a8f839c0134a6fc274b0645e157c
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
57246a4bf94e8b440c0597fa4a8e4f4e8a46532a 21-Apr-2013 Paul Westbrook <pwestbro@google.com> Use the ActionBarDrawerToggle

Bug: 8668887
Change-Id: I1efbee696aa46fa6d1226f7e23793dbfdbcbdddb
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
30b17e3a157dcfd65cf51ebb788283efa79df268 08-Apr-2013 Vikram Aggarwal <viki@google.com> Remove the subject from the actionbar

Following the new UX guidelines: no subject in actionbar anymore.

Bug: 8438223 Subject of the mail disappears from the action bar on
orientation change to landscape mode

Bug: 8492928 Action bar title switches between subject and the
folder+account name

Bug: 8529168 Remove search_actionbar_view

Change-Id: I8551fdacd7843ca0b2ba0bf1025483eee2587638
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
ff8553f20964f4c31b0c503a9e1daff6ae08a9c7 06-Apr-2013 Scott Kennedy <skennedy@google.com> Cleanup

Change-Id: Iee8abf75639450d469632e43fe0e102b687558db
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
c82a0322ef0c2eb35bf0ae8deb2e9292060ca946 25-Mar-2013 Vikram Aggarwal <viki@google.com> Reset the FLF arguments when the account changes.

Earlier we were creating a new FLF every time an account changes. We
aren't doing that anymore so we need to change the arguments when the
account changes.

Changes:

1. Decouple the folder list URI from fragment creation.

2. Instead, always read the folder list URI from the current account.

3. No point saving it or restoring it from bundles.

4. Implement AccountController in the FolderSelectionActivity to pass
the current account when creating widgets/shortcuts.

...and minor changes:

1. controller.loadFolderList() is only called from OnePane, so making
that private

2. Removing the folder list URI as an instance variable since that is
now unrelated to the creation of the account.

Bug: 8437457 Mismatch of personal/corp account
Change-Id: I81170ee80b5f9e064fd13edbc23981171740d814
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
5fd8afd5c1b40580c069a5a97039ca0601208216 13-Mar-2013 Vikram Aggarwal <viki@google.com> Remove unused interface and rename method

changeAccount(account) is more indicative of its purpose than
onAccountChanged(account) which suggests that the account has
*already* been changed.

Change-Id: I7dd780e16b6a238814748bb429113dfe1069d9aa
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
177097fad8fc26b8a215f9f1af6dd5fd2c8eb06c 08-Mar-2013 Vikram Aggarwal <viki@google.com> Loaders that create objects in the background

Create Folder objects in the background. This frees the UI thread
after onLoadFinished is called, since the object has already been
created.

Bug: 8315641 optimize AbstractActivityController's loaders

Change-Id: I1f4b2f679cf99a9193d88cb6b9a5aa77b33d6ea9
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
8e65c6d2527c7539b689e0e8548c84f690badca5 08-Mar-2013 Rohan Shah <shahrk@google.com> Drawer support prototype

Added drawer in the stead of the folder list selection.
Drawer works as expected, by swiping from the left and
following up with the drag. The show labels item has
changed functionality - toggling drawer state.

Change-Id: I34efc865c95696911d8cdf96e83a4334816378a0
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
313ac13095a386be366bd25f8106fbb34b4a7098 05-Mar-2013 Andy Huang <ath@google.com> fix search hard key handling

onSearchRequested(String) -> executeSearch(String)
No sense getting this confused with the very-different
Activity.onSearchRequested().

Bug: 8309831
Change-Id: I20dfaa854d6dfb1b8a774337ae2ae1b0db17abce
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
c1fb9a9c2730178105977fca629e80951bfc3cdc 11-Feb-2013 Andy Huang <ath@google.com> Single-message zoom using a floating WebView

Protected by an experimental pref for now
Restores scroll position
Preserves 'show pics' state
Speedy animation
Fade-in animation begins right after onNewPicture (ICS compatible!)
add UpOrBackController role for fragments to get a whack at back/up

And because this approach avoids using the CSS 'zoom' attribute
within single-message mode, double-tap works well and there are no
line-height issues.

Bug: 7400516
Change-Id: Idedfa6e35edc291c9169fbd9b1315b39b4253f60
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
2fbf37473bcd850fe38591a32cb29d042a7211d8 17-Jan-2013 Vikram Aggarwal <viki@google.com> No need to override method

ConversationListCallbacks.isAnimating has the exact same signature.

Change-Id: I0613b3f9ff5ced9d73af2292282cc239853a143d
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
93dc202420c3bf8adf4d9e8ae18c8e30e3cb1959 05-Nov-2012 Vikram Aggarwal <viki@google.com> Make up icon work consistently for recent & label list

Fixed two problems with the up icon. Removed the visibility of the
resetActionBar() method and removed code duplication.

Bug: 7419208 Up arrow next to app icon isn't updated in two cases
Change-Id: I0b166bfe9984eb4f5ce0370d1c0abbb036fab93d
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
dd6a7ce32c4003bd0941e2f18fcf5b80b5cd43c5 23-Oct-2012 Vikram Aggarwal <viki@google.com> Reduce visibility of methods

Change-Id: Icb0d2698debfcecb440477a6125d8981b8e68bfb
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
d0c7a3c40fdc2d1c8abad74b76730a14951a4c74 09-Oct-2012 mindyp <mindyp@google.com> Add comment to isAnimating api.

Change-Id: I00002fd9aba0fb7bc76a83b7cb3cd22c960c76ea
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
6f54e1b0e8beae2e624852f9f2f2b1b38745e3be 09-Oct-2012 mindyp <mindyp@google.com> Defer folderlistfragment updates while we are animating.

Part of b/7301434 gmail extremely janky on manta

this will have no effect on phones as we never show
folderlistfragment at the same time as convlistfragment,
so we can never be animating!
this will also never trigger unless the user causes an explicit
delete of an item, since only that triggers animations.

Change-Id: I27cf0542897e364212ea687e2eef9a424a2090a5
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
ca87de41285bde382a894b6cb2d13c112c5d7a2f 29-Sep-2012 mindyp <mindyp@google.com> only get content description when accessibility is enabled.

Getting the date is the most expensive part of the bind operation
takes ConversationItemView.bind from ~5ms to .5ms
bind is called whenever we get a list item view, so its important that its FAST

Part of b/7188066 Gmail inbox list fling is jankier comparing to previous release

Change-Id: If789382df6429f61ac80c4be08611c5391da5618
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
9d3fd92ed6091dbd0d38799222a1cf841f1c3f29 27-Sep-2012 Andy Huang <ath@google.com> Wait for visible conversation to load before loading others

add conversation load observation APIs to CLC interface
save/restore CVF user-visible flag
move CVF state restore to ACVF's onCreate
start using FragmentRunnable to avoid doing work too early
(before ViewPager settles)
clean up unused onConversationLoadError codepath

fixes undefined conversation load order on rotate
improves conversation load speed a (tiny) bit

Bug: 6268986
Change-Id: I4670d0c04cb1a36d5aa2c5355e2a79de17d042dd
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
3bcf180f8104bc27319086a9a6ece5a3c2917c37 09-Sep-2012 mindyp <mindyp@google.com> Add loading animations to conversation view

fixes b/6272925 jank - conversation loading isn't animated
fixes b/7131797 Blank scren shown for live conversation, when in airplane mode
Note: need to do a next cl that puts off showing the spinner
until at least XXX ms have passed
Also, we cant use the software layer for rendering like we did
in gmail1
it looks like there is a skia crash that triggers when we try
to use software / switch to hardware rendering for the browser
need to investigate that more

Change-Id: I96a30b700c3e88d52e603fe2f11b44d113e013d2
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
58cad2eea744d41a11c0124e91308e38108d242e 29-Aug-2012 Vikram Aggarwal <viki@google.com> Folder list fragment by sections.

Known issue: the recent folder *and* the user folder is highlighted
when selecting a recent folder. A change is being prepared to fix
this.

Fix b/7074104

Change-Id: I82733bc6be105c6270d17f3c1a281fd4ec15a48a
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
6a147adc153c52fc4d5320e6e87b8fc366a17d09 30-Aug-2012 Vikram Aggarwal <viki@google.com> Less invalidateOptionsMenu()

1. setAccount() and switchAccount() already call invalidation, so
remove calls just after those two.

2. Settings changes do not change the back button, so don't reset the
action bar button when settings change.

Discussed in b/6946182

Change-Id: I1b8e8d0caf1b20f33ee33c2dd59114597e767de8
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
3825f3d2284b2b57fadcfe6a4ebd9992f3c5c7bb 30-Aug-2012 Andy Huang <ath@google.com> fix spurious stopListening on the pager when loading from widget

When loading from a VIEW intent, the pager was sometimes
disconnected from its data source before the data was loaded,
which caused it to stay in singleton mode forever.

The original code to disconnect the pager was intended to
disable pager updates when jumping back from conversation mode
in 2-pane (via account spinner), so move that call to the
beginning of 2-pane's mode change animation.

Also do a bit of misc API cleanup.

Bug: 7076780
Change-Id: I508b59816f4f537276aa103b9dcae51972389eb0
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
1ee96b2b100546b5b69ad42c5bc3755a4293d1a3 25-Aug-2012 Andy Huang <ath@google.com> handle missing messages every which way

Entire conversations can disappear upon sync (should pop back)
Or just single messages can disappear (should keep conv in view)

Handle these specially in conversation view. Stay on the current
conversation when possible, except if no messages remain, we
should pop back to list view.

When single messages disappear, make sure we don't treat all
the rest as super-collapsed, or else the conv will render empty.

When popping back to list view, we can't call popBackStack()
from onLoadFinished(). Since we only need to do this in 1-pane,
add logic to 1-pane's showConversation() to handle cases where
the caller is in onLoadFinished. In that case, we need to defer
the work slightly, but still be aware of other FragmentManager
constraints when later handling the deferred job.

Bug: 6889742
Bug: 7005366
Change-Id: Id37f878e82523837b7f105d49fb736f774bad224
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
5390fcabb7baf683fc14bd68d8612913dac70a81 22-Aug-2012 mindyp <mindyp@google.com> Restore drag/drop logic

fixes b/7034633 Drag functionality is missing on tablets

Change-Id: I8d0c9d4a95cf143a307fb093721f3b5f6eba872c
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
4969e0c5f8ab837e1b0d29ea56d220e6404e9250 20-Aug-2012 Paul Westbrook <pwestbro@google.com> Move ConversationListFooterView click handling

Since the click handling for the ConversationListFooterView is
essentially the same as that of the ToastBar, move click handling
into the Activity Controller

Change-Id: I14b8ef6788b929e82d61b8393195b703c210021d
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
937c94f025ed55c19bd46c7c077fa3575ab6be52 16-Aug-2012 Paul Westbrook <pwestbro@google.com> Prevent use of disabled ConversationCursors

1) Change ConversationPositionTracker to get the ref to the
ConversationCursor from the AbstractActivityController
2) Make sure to notify the position tracker about changes to the cursor
in onLoadFinished

Bug: 6994143
Change-Id: I1d1e38852bb6cec1bc254b099c52f04bbe3af99d
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
7c401b7896910c00e6234e8774aab0be45740d32 14-Aug-2012 Vikram Aggarwal <viki@google.com> Get the Account through a listener

Every object that needs an account gets it from the ActivityController
by registering for future updates. This should reduce some of the
headaches with account objects going out of sync.

Fix b/6969950

Change-Id: I0449b482ecd84bdb947304db5f0504c77dd1dc7a
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
cff1aeaff92efb9f7a03203d9f757a2820b87686 10-Aug-2012 Paul Westbrook <pwestbro@google.com> Refresh cursor even when scrolling

This allows the "Loading..." item to appear before the
user stops scrolling the list. If the the live data is
populated before the user hits the end of the list the user will
not see the "Loading..." item

Bug: 6966755

Change-Id: I902eb442e47a6efb99b850a559106c81acac19c0
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
00179f19e413461498599ab7e6eb6914cc5c3671 10-Aug-2012 Andrew Sapperstein <asapperstein@google.com> Added the visuals for the new error styles.

The visuals are done (minus some string changes).
However, two of the buttons need to be implemented
(the sign in button and the report feedback button).

All of this work occurs in both the ActionableToastBar
and the ConversationListFooterView.

Change-Id: Ifa67a0f72d100191c2cdb47f601e6ff04a765e02
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
090db1ec6fef366ab9e319040a00eca078ed41c3 25-Jul-2012 Andy Huang <ath@google.com> fix total count in pager title strip

Add an interface for AAC to allow other components (like the
pager adapter) to keep track of the current Folder as it
changes.

Bug: 6877338
Change-Id: I8c0bae0f6ef3bc6fc7b115b013816a458bc95226
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
c975e8416b64a1ebdec6adee7e65dd1d0928e8d4 16-Jul-2012 Mindy Pereira <mindyp@google.com> Re-connect to an existing loader on orientation changed.

That way, we can keep the existing conversationcursor over orienation changes
and retain the undo state.
Find another way to make sure there is no selected item when we open the
folder list. Setting the folder to null means we don't know that
we are switching folders later.
Change-Id: I720f2a1fc1dba6e9e25ac0512894273f758499d5
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
c2c9dc14aa184db1f05b8c060b27d97dda5a3ca4 03-Jul-2012 Andrew Sapperstein <asapperstein@google.com> Refactored UndoBarView into ActionableToastBar.

This step was mostly renaming. Deleted some unused
stuff. Made the show() method far more
general. Now showing sync errors as a toast.

Still requires some tweaking for the different error
types.

Change-Id: I476e107ed89ed492b44b081d32e4216504626c13
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
5895f7b0e5fa921f6d46bbaf6d8c7b1a8ebc7804 02-Jun-2012 Andy Huang <ath@google.com> subject in actionbar

Mostly a port of Gmail1 code. New and noteworthy:
* when switching between ActionBar list nav vs. custom display,
toggle ActionBar.DISPLAY_SHOW_CUSTOM rather than messing with
custom view visibility
* This exposes something of a framework bug where collapsing
an action view will leave views for all inactive navigation
modes GONE, which I work around for now (b/6664203).
* ActionBar views were being inflated with system default Holo
theme due to application vs. ActionBar context (wrong theme on
the application context). Fixed that and un-inverted some
existing styles.
* SnippetTextView: save off the last measurespec rather than
inventing one as before.
* bring back an existing excellent behavior: since
PagerAdapter.setPrimaryItem reacts too slowly to nicely
change the action bar subject when paging, listen for
OnPageChangeListener.onPageSelected in addition.

Bug: 6384157
Change-Id: I45d995a472d4b3c71f1371dc7b993923423b7cf7
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
531488ed848766708252a5fdc01c4ecf0fd167d1 30-May-2012 Vikram Aggarwal <viki@google.com> Remove all bad ideas from SelectedConversations

1. Remove references to AbstractActivityController and
ConversationCursor (yikes!) from the selected conversation set.
2. Create a new interface for delegating all changes to conversation
state.
3. Consolidate FolderChangesCommitListener with interface created above.

Change-Id: Id1d982a19eb2d26c51aec661cee5dc23ef98c110
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
48b2a6c5fe209f0603fdf85d35cf399f7f7d462e 29-May-2012 Vikram Aggarwal <viki@google.com> Minor cleanup

1. Remove uncalled empty methods.
2. Remove methods from interface if nobody else is calling them.
3. Remove unused DragListener interface and all references.

Change-Id: Iac498336209b8e73f9a0e13dd8954652e83fd1fc
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
23aadfd1c83e08b6723d4cb9357b2908cc464a86 25-May-2012 Mindy Pereira <mindyp@google.com> set folder selection on activity attached

since attaching a fragment to the activity is async, we may not
have the fragment by the time the folder is selected
let the folderlistfragment set the selection once the activity is attached

Change-Id: I10aad32af1982a4b349492fd449c42a58c37bc4f
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
3d7ca9d2aefd20dc115f20532c1e19fdb60f7d68 11-May-2012 Vikram Aggarwal <viki@google.com> Consolidate OnePane, TwoPane, and Conversation Destructive actions.

Change-Id: Ieccc3fc1962572fec78dfb1ea91557e56f931a48
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
d503df4f0c31bbf842c6a1d3cba18df8c074bf67 11-May-2012 Vikram Aggarwal <viki@google.com> ActivityController commits folders, nobody else

Change-Id: I3ff870f275821ebc3cd08cfad0875eb229094f2e
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
7f602f7a64f176894ccb7942a6642f22584c3894 01-May-2012 Vikram Aggarwal <viki@google.com> Synchronize destruction and remove dead/deprecated code

Change-Id: Ia86449494cca7d4ed5e2d9d515d8afa3dd94b68d
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
e8a85328eadff76fcd78141f1343bde0a1cd27e7 24-Apr-2012 Vikram Aggarwal <viki@google.com> Register SelectedConversationActions with Controller

The selected conversations action menu gets a destructive action from
the controller. The controller takes care to perform the destructive
action before swapping a conversation cursor.

Change-Id: Ibc98ef92b60d5782103b8a18aa39fe2b82a5814b
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
eb7d329e448eb42195f7c35b978035766b6f46e1 21-Apr-2012 Vikram Aggarwal <viki@google.com> Switch to default inbox on Action Bar taps.

The Actionbar now calls onAccountChanged() only when the account is
different from the current account. If the accounts are the same, it
loads the default inbox for the account.

Also, onActivityChanged calls switchAccounts() when switching
accounts, and onSettingsChanged() when only the settings have changed.

Fixes b/6366965

Change-Id: I417d34ecafe499a2df5de81ba7c3f83266e7973b
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
09a4bfe3f81ee216b5c4a4e2d083432a4e387abd 23-Apr-2012 Vikram Aggarwal <viki@google.com> Destructive Actions. Part 1

1. Change ActionCompleteListener to DestructiveAction.
2. Call OnePane and TwoPane objects DestructiveActions instead.

No functionality change.

Change-Id: I492de83bc9e49948a4dabcfc5e8438220339fc46
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
bf232c3735f65b1a4746943e4a134e59e36f0bde 18-Apr-2012 Paul Westbrook <pwestbro@google.com> Major refactor of ConversationCursor

* ConversationCursors are now associated with a particular loader;
there are no static methods or static state fields
* ConversationCursorLoader maintains a list of current loaders
(for tracking/debugging)
* AbstractActivityController acts as a router of conversation
changes to/from fragments (currently message view -> conversation
list)
* Comment out some ConversationCursor tests for now

Change-Id: I9b8425a19c77501796b6681142e1bc0ad20b3693
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
cf164d64bcb1da92b427bda99b97f7ec310ef704 20-Apr-2012 Marc Blank <mblank@google.com> Revert "Major refactor of ConversationCursor"

This reverts commit 5150f03723af8019169aeed8e406784da9c5f8f1.
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
5150f03723af8019169aeed8e406784da9c5f8f1 18-Apr-2012 Paul Westbrook <pwestbro@google.com> Major refactor of ConversationCursor

* ConversationCursors are now associated with a particular loader;
there are no static methods or static state fields
* ConversationCursorLoader maintains a list of current loaders
(for tracking/debugging)
* AbstractActivityController acts as a router of conversation
changes to/from fragments (currently message view -> conversation
list)

Change-Id: I0eb554615b4bf93b3547ff28e2bd5913e8703a97
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
632721e6b3a9ba8c476456f2e0fb1b564561e0b5 12-Apr-2012 Andy Huang <ath@google.com> conversation paging

This CL takes the approach of using a permanent ViewPager that
pages through conversation fragments. Its adapter is only
set and populated when the conversation view is shown. In all
other cases, it is an inert empty layer.

One risk with this approach is that it breaks with the typical
fragment transitions that all other content panes use.

On the other hand: conversation fragments are full-on fragments
and benefit from loader separation, and the FragmentManager
takes care of save/restore of state.

Change-Id: Ic17d1ae3f35a0cb1119967f2d34433ad27fa307c
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
b1c34dc418e31ae0bfe1b73b6642ed42f5dad67b 18-Apr-2012 Andy Huang <ath@google.com> avoid restartLoader in configuration change sitations

The ConversationCursor and its loader were being unnecessarily
re-initialized on rotation. Only use restartLoader when the
folder changes from an existing previous folder, like when you
switch folders.

Also begin to add an onRestoreInstanceState step, which is very
handy for last-second initialization, after initLoader results
are re-delivered in the rotation case.

Change-Id: Idb39f24cb31f0ccc41379947b047e0af0e615551
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
6902dcf8688d7d0691639f49365a78a3a78fe9e3 11-Apr-2012 Vikram Aggarwal <viki@google.com> Controller gets fragments from FragmentManager

Change-Id: I1d9906ba5d70ed5580e35a53b34797cd5f1e0ad7
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
2d50bcdca57756ecad20d21da0d936243215b79c 10-Apr-2012 Paul Westbrook <pwestbro@google.com> Support for unintialized accounts

This is the initial CL for support for a "wait fragment"

A subsequent CL will make clicking on the buttons in the
Manual sync case work

Change-Id: I7f1ca27eb8792aaa94d354b2753d37783a72b309
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
0dda573e51786dd907b2674baddbca20ffa5c725 06-Apr-2012 Vikram Aggarwal <viki@google.com> Fix search back behavior.

This is the final issue: we remove the intermediate activity when
searching. After this, back at search results goes directly to the Inbox.

Change-Id: I437d7bd7b08da1d7befdd873b43edaeee6ac99ee
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
0963ef8394e1f0bca3f931f930b127b00790361a 10-Apr-2012 Mindy Pereira <mindyp@google.com> Move undo up to the controller level.

Change-Id: I1fa2d921132c0d66c677b428f570c60672471ad9
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
acf6039a23382f18c35f6b487d90d53cb67b5858 06-Apr-2012 Mindy Pereira <mindyp@google.com> Drag and drop into folders.

Change-Id: If80c43fb5643d328bf061c2bed87bd9acb6e4661
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
a76e5aeff4a54ec70661de35be4f3ecb9d1d2fe2 29-Mar-2012 Mindy Pereira <mindyp@google.com> Add no args constructor for FolderListFragment.

Fixes b/6251677 FolderListFragment needs a public no-args constructor

Change-Id: I1f87b5ed105a3b2598da5507eedb0f439aad087c
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
fd0c2974af56ad244006faab2651e054974a4b7b 27-Mar-2012 Mindy Pereira <mindyp@google.com> Handle search hard key.

Change-Id: I0d0063f37d26040234dda36fdf5146e6237b9640
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
c9d59184da271d5a6974edb709e3b39a5a970fa7 23-Mar-2012 Mindy Pereira <mindyp@google.com> Fix up conversation menu items.

Make sure the correct conversation items are shown/hidden
Fix mark unread.
Fix mark important.
Change-Id: I7e5fa60d9501bb123cdd2276afd68c26e300dc3d
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
967ede63e059810d9d4d425c50111d606014c893 22-Mar-2012 Mindy Pereira <mindyp@google.com> Move ownership of the conversationlistcursor to the controller.

That way, conversation fragment, conversationlistfragment, and
all the controllers can get to it for positioning, getting next/prev
conversations, etc.

Also removes need to keep conversationlistfragment from being
destroyed/ nulled out.
todo: should the controller own the list adapter as well so
that is can make changes? unclear.
Change-Id: I2388b8403c4253f6075c03f613ca73c2cfa81422
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
6fbc87affe46f6d49c584a307ec836e68163c182 15-Mar-2012 Vikram Aggarwal <viki@google.com> Folder selection, muting, and reporting spam

Change-Id: I5266914bc769ff59cfebb9782c2aeac3b9faf859
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
276c80bb3ca7cff5f2a0511e8a9d0452ae91d858 09-Mar-2012 Vikram Aggarwal <viki@google.com> Moar cleanup

Change-Id: I2ec187ec05d14000edbfff22acf2b8ff251530fb
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
a799795e91b2a8049914c4559fa2a89fc0133faa 09-Mar-2012 Vikram Aggarwal <viki@google.com> I can haz cleanup?

Remove unused callback interface, folding the useful methods directly
into ActivityController.

Change-Id: Iececa4fbfbcfa0720d49352e775f22e559afa419
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
b849dfbda3c917f078a5c09f03906886c27ecbec 08-Mar-2012 Mindy Pereira <mindyp@google.com> Make tablet search work correctly.

Change-Id: Ib19dcc590fd80aa134aa3afab9989eeac2aec224
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
68f2e222b4ffccd9f67f02b3a9cfdb3841a7eb43 07-Mar-2012 Mindy Pereira <mindyp@google.com> Hookup search in the UI.

Remove ActionBarView interface and rename MailActionBar
to actionbarview. We needed this for pre v-14 support, but no longer.
Change-Id: I539b6751313e561311921010b03250df632260bc
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
dc9d365451ff93f9f0b6f800dc53d036604fb38f 05-Mar-2012 Vikram Aggarwal <viki@google.com> Remove legacy methods from interface

Change-Id: I9bd3e3589abdc52b067315d150a9a1edf9e60661
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
1f93668e1186d48b507207841c1ca0529c3de292 02-Mar-2012 Mindy Pereira <mindyp@google.com> Add missing tablet resources; get compose working correctly/ cleanly.

Change-Id: I484a1880009e557fc660d56cda83313efc13825a
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
efe3d25aa19da172fd5c3ec39539cdd91f29e927 01-Mar-2012 Mindy Pereira <mindyp@google.com> Destructive action dialogs.

Use delete/ archive settings to determine if we should show a confirmation dialog.
Show confirm discard dialog in Compose and actually discard.

Change-Id: I992bdf598af72a62deadfdfe695a64b89fad5c24
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
a9b93f35035dc4badd0ac40f4016e1ff809b26b0 23-Feb-2012 Vikram Aggarwal <viki@google.com> Load the ActionBar correctly on Account changes

Change-Id: I1a7fa6476fad7f5c1c01119fc72908b91c930138
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
5cb0c3e684150d6d8ed4d9df4fb73a7606086aaa 23-Feb-2012 Mindy Pereira <mindyp@google.com> Always watch folder for status updates.

That way, can show the user about background syncs
and requested refreshes in the ui.

Change-Id: Ie070a465f6231b3e81aee58350783c213b6073f6
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
363451a4e8520cfa7f4abd34f073a75984bb01cd 22-Feb-2012 Mindy Pereira <mindyp@google.com> Show spinning when the user is refreshing content.

Change-Id: I5b5829c63e8fa47b565314b0734da46141b4f784
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
2861b6a649090ce1401b4bb04dd87df5bb26472b 16-Feb-2012 Paul Westbrook <pwestbro@google.com> Settings uri

Support for the UI provider to specify the uri for the
intent that should be used for launching settings

Change-Id: Ibcaf35b15774d87436f83475a3971ceae0ede6fd
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
28e0c34ad35925fc74633bec66344911f2de6a22 18-Feb-2012 Mindy Pereira <mindyp@google.com> Hookup refresh button.

Change-Id: I79be2fb42ed6902129b65f56b4ef70de5d4c1d90
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
674afa42682908640167fc6109b76f6f843e6fbe 17-Feb-2012 Mindy Pereira <mindyp@google.com> clear undo when tap outside of it in any screen.

Some funny business with relative layouts and z-order
and the undo bar. will fix that in a second cl so i can
animate in/out undo bar.
Change-Id: Ia4d3684ff26563e56b09cafb9ee25980162d1168
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
7dedb952c8bb9c7b50f25444a42047d903e5121b 17-Feb-2012 Vikram Aggarwal <viki@google.com> Use LoaderManager for account changes

Change-Id: I244ed7b48453050bf4fe82dc7eea22a37d9cc4a2
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
f5acda4a4b7c9e8ecacb41cb7d570ef426b6d4fc 16-Feb-2012 Mindy Pereira <mindyp@google.com> Make MailActionBar use viewmodes; make sure it gets updated when view mode changes.

TODO: would it be better to make it an on view made changed listener?
Also, fixes up behavior.

Change-Id: Ib48d54b4cefc39629182d0df942b0f19fa77361e
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
9b87568c9e9f1c32a9672b315229866a58a1e757 16-Feb-2012 Mindy Pereira <mindyp@google.com> Add conversation view fragment.

This pulls over the logic that had been in ConversationViewActivity.

Change-Id: Ib617d3c1cb43265a559a18e05842ca186188b3d3
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
0825efd09986173b90d7c7d45617fb22d18b1b96 16-Feb-2012 Mindy Pereira <mindyp@google.com> Fix up conversation label change logic.

This wasn't working correctly in the test app, and that is what
I think we should be maintaining from now on.
This handles crashes, passing around account, selected conversations.

Change-Id: I86242c980945771c73ce57c642e3f70fece4e3a9
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
555140c7b7d5129fb2b17df66106cbd6eeef37a0 15-Feb-2012 Mindy Pereira <mindyp@google.com> Make it possible to drill into folders and see conversations.

A little shaky to start.

Change-Id: Ica1a4aac15cec18143b666b9e06593db3d550f5c
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
28d5f72e0ad0db75b6243ee8125bfe3aadbdcb85 15-Feb-2012 Mindy Pereira <mindyp@google.com> Make a folder list fragment. Hook into Viki's app.

Also, hook up listeners for changing account in the
account spinner dropdown.
Change-Id: I0e6bbabc525c141fa581f49e6265c26bc767b8cf
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
d247dc966bca1ed303039c2893c54979d448a336 11-Feb-2012 Vikram Aggarwal <viki@google.com> Allow batch selection of conversations.

Change-Id: Ibaa7e96154b8c433651d9e8ef68f7973b92b7ac9
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
7d602884ed70d07a42f1adf999fdf51b258f23f9 08-Feb-2012 Vikram Aggarwal <viki@google.com> Return ActivityController object from MailActivity.

Instead of delegating individual methods, we return the controller
object as the appropriate interface.

Change-Id: I7122a921037c83dc63e9f0987d0f95171061cdf9
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
d7a12cd5b5c2639b653d8c671b04844ef02ee01d 03-Feb-2012 Vikram Aggarwal <viki@google.com> Create TwoPaneLayout from TriStateSplitLayout

Minor changes to the OnePane and TwoPane Controllers to hook in the layout.

Change-Id: Ie3fc73ed3fb63441d7ed9b79ce02c2f1e9f51e36
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
fa131a2ff399fd1d544f759b063268fb4e8a3e70 02-Feb-2012 Vikram Aggarwal <viki@google.com> Make ViewMode focussed and small.

1. ViewMode is no longer aware of tablet versus phone UI. This is the
responsibility of the ActivityController now.

2. onViewModeChange receives the new mode as an integer rather than
the ViewMode object.

3. Rather than a plethora of isXMode() isYMode() methods, client
classes need to manually check getMode() against ViewMode.X
ViewMode.Y constants.

Change-Id: Ib06196671ad49328c40cc9237667c0a1daf328f7
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
b9e1a353c6a173a2885642dbcc1939f3281f29f7 25-Jan-2012 Vikram Aggarwal <viki@google.com> Create ConversationListFragment

The ConversationListFragment does not do much right now, but the
framework is in place. Next steps will include showing the
conversation list and allowing for conversation selection and the
Contextual Action Bar.

Change-Id: I130bb77a93bd4f58b189cb6ce47adc9e09f8e6ae
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
1ddcf0f2bf44d3c9db89112ef52510d9b2433ac4 13-Jan-2012 Vikram Aggarwal <viki@google.com> Adding more ActivityController dependencies

ui.ControllableActivity added from Gmail.
One pane layout files brought in.
Minor changes to make everything work with the test activity.

Change-Id: I8cacd5f36394fe4a786590e2e381369a3afb5494
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java
a55b36cb6b75ce8096812183651e89115300975a 13-Jan-2012 Vikram Aggarwal <viki@google.com> Bring more classes into Unified Mail

Bringing in
SubjectDisplayChanger: (was called ConversationSubjectDisplayer in Gmail)
AbstractMailActivity: (was called GmailBaseActivity in Gmail)
MailActivity: (was called GmailActivity in Gmail)

These are called the same things they were in Gmail:
ActivityController
ControllerFactory
OnePaneController
TwoPaneController

Change-Id: Ie761407cad891b669172acc729950f9d358f5c34
/packages/apps/UnifiedEmail/src/com/android/mail/ui/ActivityController.java