History log of /packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
042a530b2296487fa5899a3e871214ac4a47e3d8 13-Aug-2013 Andy Huang <ath@google.com> more metrics

Reorg category/action/label to be more economical. This gives us an
extra slot for data vs. spending on custom dimensions in the future.

Log CAB actions, some settings state, drawer toggles, CAB mode start,
swipe dismiss, and peek.

Bug: 9861033
Change-Id: I16b30356db70f60ed87749f29ddd667790acbb07
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
e5707f86f340797d5ee1535bff86d331715cbce9 09-Aug-2013 Scott Kennedy <skennedy@google.com> Make some changes so the ad leave-behind can animate

First, rename INVISIBLE to something so we aren't hiding
View.INVISIBLE.

Second, create a static method for the fade-in animation of the text
so that the ad teaser can use the same code.

Third, modify CIV so that we don't need to be contained in a SCIV for
animations to work.

Change-Id: Ib89015529871bc2b7eba191dd88a4185948927ea
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
2b9d80eb16156173f11a02eae4f770d8c975927c 31-Jul-2013 Scott Kennedy <skennedy@google.com> Change all resid switches to if-elseif-else

I really want to get this building in an IDE.

As per http://tools.android.com/tips/non-constant-fields, library
projects (like UnifiedEmail will be) have non-final R constants. They
are not final until packaged into the main application project's
(Gmail/Email)'s R.java.

As such, they cannot be used in switch case statements, and we must
use if-elseif-elseif-elseif-...-else instead.

"This is typically in UI code and the performance impact is
negligible."

Change-Id: Ie699c13e1becd51c59c1b2ea81bc902d4f2e28d9
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
3b965d78774a42358ce6bbdcc43b4c8df130a60e 25-Jun-2013 Scott Kennedy <skennedy@google.com> Clean up a bunch of warnings

Bug: 9565838
Change-Id: Ie3a380581e81c63aaa0764875c55bfdccd5f2b13
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
2102b2c87a6cb39bc63fb7eff13dda64da56b72e 03-May-2013 Mark Wei <markwei@google.com> Add teaser for new conversation photo checkboxes.

The teaser shows up for the first time the user sees the conversation photos. If
they change to no photos, and later change back, the teaser comes back.

The teaser sits immediately in front of the first real conversation item (unless
other special views also try to have the same position behavior, in which case
the current implementation gives undefined behavior dependent upon which special
view is added to the adapter first).

Bug: 8772762
Change-Id: Ica79482f2a2eae0cf3409f6accb7ae5b0fc0fd45
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
370f868c834861e7732faaa9bdd07a0fa0105596 09-Apr-2013 Andy Huang <ath@google.com> fix shorter-than-expected leave-behind view heights

Make leave-behind heights variable, dependent on the
ConversationItemView that originated it.
Make the background on a SwipeableCIV not a separate view, but a simple
background. Also simplify the conditions under which it occurs-- it just
appears whenever translateX is non-zero. This covers all swiping and
animating cases handily, without the need for extra listeners.

Remove an old workaround that gave ListView on 1-pane an opaque background-

- it was there to mask FolderListFragments that stuck around, but those
are relegated to the drawer now. This reduces list overdraw by one.

Bug: 8570880
Change-Id: I2e2ea875d4ab58b5048d41025b8a2c48a3d63536
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
9e2d407fdafeb874e640eb84017feaf784309075 22-Mar-2013 Scott Kennedy <skennedy@google.com> Clean up a bunch of warnings

Change-Id: I5c75564eeb2df9ec76d682dbe5f4465ff2a1a5d4
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
a44babdac4e070034f35d984d06c675af8fee81f 17-Jan-2013 mindyp <mindyp@google.com> Swipe animation polish

The cinch delay should start on the short side, but then we extend it if we notice that you're in multi-swiping mode,
where multi swiping mode is defined as > 2 active shrinking items

Change-Id: I7a6cafa44954ab2904bf14fd8e24a045b80539ff
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
ac2ef8104955233d0f2854fa20bc285ba1ea1043 17-Jan-2013 mindyp <mindyp@google.com> Fading in of text should start immediately after cinching of items has completed.

Also, give the user enough time to start touching another item
275ms is too short
300ms is min time to react
Change-Id: I73765795ad540db8b28b5fcaf3589753980e89b1
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
4d4531a63cff536d2ee1a2929d0820981df8516a 17-Jan-2013 mindyp <mindyp@google.com> Updates to swipe interaction

When swiping away items, wait to fade in action text such as "archive | undo"
until:
1) all items that are being collapsed have collapsed
2) we are no longer waiting for the user to try to start swiping another item

Change-Id: Iaec75fb6a3a144e8b4c469f6e48f4354ec4aff8d
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
7af43c93d4ca90bb0a43ec790a434c95128cc99f 19-Dec-2012 mindyp <mindyp@google.com> Fade out other leave behind when user starts new swipe

Change-Id: Icdd1b7d65715852d5fd976e7fccaf5790f940892

Conflicts:

src/com/android/mail/ui/SwipeHelper.java
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
a80e6c0abe197e6e629f2d7cde03fb9c130d20a6 19-Dec-2012 mindyp <mindyp@google.com> Make sure we properly clean leave behinds after undo is tapped.

Change-Id: Ifd073c14def7cd4448406f7731ab57855c58a6c8
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
3b5e82b06a0af3f5ddf3667de9a2aa26eeb5f24b 18-Dec-2012 mindyp <mindyp@google.com> swipe tweaks

Change-Id: I5011f11989056376be748161fdb3f0e699366454
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
6a6deb20dbbea543ccf093487d26dea4ac4f9cd4 26-Nov-2012 mindyp <mindyp@google.com> Don't dismiss other existing leave behind items right away.

Pause so that if the user is doing a lot of swipes in a row, the spacing
remains the same

Fixes b/7171804 Polish: after archiving a conversation from the list, scrolling feels a little out of control

Change-Id: I16fa29d6507c158c9c9abe1c5ec99c7577a57d92
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
e358ed5c4ed1b172f5eae98f97919a8e471c98dc 26-Nov-2012 mindyp <mindyp@google.com> Correct issues with fading in text when there are other leave behind items.

1) delays the start of the fade in animation for the text of the new
item until the previous leave behind item has shrunk away
2) corrects bug where the opacity of the text of the leave behind item
was not being reset
3) corrects bug where the variable tracking if an item had completed fading
in text was not being correctly reset

Fixes b/7172273 [polish] "Archived... Undo" UI jumps around when archiving multiple messages in sequence

Change-Id: Id911fdacd41892d9c0a8377c775ef7ba5d79703e
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
c59dd8270215f97d39697dae9e69976bcfe3642b 13-Nov-2012 mindyp <mindyp@google.com> Make sure we use our version of converting from html to plain text.

Fixes b/7532730 audit UnifiedEmail and replace all Html.to / Html.from with our HTML tree parser

Change-Id: Iad23b688175b20db698fce5efccbe869c12d0b5c
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
e949616a8516115a544e1a8fca42d8d9e2817419 31-Oct-2012 mindyp <mindyp@google.com> Make CREATOR static for LeaveBehindItemData

Fixes b/7438519 gmail crashed on launch: expected receiver of type com.android.mail.ui.LeaveBehindItem$LeaveBehindData, but got null

Change-Id: I2a2622c2b96966f3a21d0f2a731e87a22caaebbc
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
eb88ececd0a53c4e956240b7b619da6410e2d356 09-Oct-2012 mindyp <mindyp@google.com> Don't reuse the leavebehinditem.

This item should be recreated if its of the wrong type rather than
getting nulled out and reused. It would appear that the recycler
was returning views that were still in use.

Need to determine root cause but this certainly masks the issue.

Fixes b/7305963 Undo archiving is very slow in Gmail

Change-Id: I4481a27bbc02dd9419d21a77268a8c08d0059b3c
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
d064972c4a032f3c5cfcb236aa470273f7ac2ce0 28-Aug-2012 mindyp <mindyp@google.com> use swipehelper to determine scroll

let swipe helper determine if the user meant to scroll
fixes b/7022556 Increase scroll threshold gets rid of leave behind
If we use the scroll listener, we don't get to use our own threshhold
We want to be careful when the user has started on the leave behind item
and make sure that we dont just detect the user playing around on the item,
maybe just a touch for "what did I do here?" and dismiss it by accident
So the threshhold for dismissing the item when the user starts on the
leavebehinditem is larger than when they start on another item.

Change-Id: I1e55e6c9be07e026b19a4ad55ad531305d3777d2
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
215d2a465dd17139d4c8cce426ae8c8ff556746e 28-Aug-2012 mindyp <mindyp@google.com> Get conversationcursor from adapter

get the convcursor from the adapter
fixes b/7065755 Crash in Gmail2

Change-Id: I8156adbe2cfdd05563bd25be366c7bdc2df39580
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
b66c010296d35e111f4c5952ff826ddcf1cbe444 24-Aug-2012 mindyp <mindyp@google.com> Make animations smoother.

when we are shrinking existing leave behind items, don't also
try to fade in the text for the new leave behind item
too much at once
Makes it smoother

Change-Id: Iabd026b8389c67ec8b7a840d7c2c00af0a6eed34
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
20e75dc2738ef22bda10e50df265fd5526a82676 24-Aug-2012 mindyp <mindyp@google.com> Simplify the hierarchy for the leave behind.

Managed to play a few tricks to get the highlight when tapping
undo/undo icon without having an asset.
Change-Id: I4c7e2b5d248e5bcf3a648f86035f9221efe4d65e
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
33f96428528c4905d3ea81f8460def4d7a5d6a10 23-Aug-2012 mindyp <mindyp@google.com> Remove shadow from leave behind item.

Change-Id: I80509c27a923db91e9c24412fe69e6a0fdce57a9
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
28777df4ea30fff6fda4d714d8e9b1f89bd09064 21-Aug-2012 mindyp <mindyp@google.com> Add touch feedback to undo area of leave behind.

Change-Id: Idaa2bbfaf44f5ffc3bc38a898f989da087fbe50c
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
a538984fcc19e7624f2650b119ede39bf1f35846 18-Aug-2012 mindyp <mindyp@google.com> Dismiss just the text from the leave behind instead of the whole item.

Leaves the BG there so the change isn't as "shocking"

Change-Id: I95b6929dadbf9b5e7c80931a3f65111fc4a695ff
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
0e3348e2f7e063e7864e264adc2731368aaa7ed7 18-Aug-2012 mindyp <mindyp@google.com> Try to make dividers stand out less as items shrink.

Use a color when shrinking leave behind items so we dont
get weird artifacts from the 9tile.
Change-Id: I4c3765a2f04eabaa2d358cf5e7d6f2523f672da0
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
0b96043f9f2f740ce4d81dd5036e076e9704aa3b 16-Aug-2012 Mindy Pereira <mindyp@google.com> New content description string.

fixes b/5196381 read the date and from as part of accessibility
round 1
Change-Id: Ia091a5dc8f9d8f9c5dc33b55e326dddd8a5d4ed2
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
84f9b5c60dc023570202859ba1d30cf9cb5e6e7a 16-Aug-2012 Mindy Pereira <mindyp@google.com> Don't show the action as we are swiping, just on the leavebehind.

Fixes part of b/6926116 need visual design for swipe

Change-Id: I2f53e5b652ee687f7046306064917e55b7ea005e
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
2191b188f1b7840f7adc3c12eef6115eeee6435c 12-Aug-2012 Mindy Pereira <mindyp@google.com> Animate out the existing leave behind when we commit it by touching another item.

Change-Id: I065727197d42a73ca63d387224b1c876318104b0
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
8f39702ca9f9bea23d27a46a288cd6f6660de447 12-Aug-2012 Mindy Pereira <mindyp@google.com> Make sure we can have > 1 fading out leave behind items

A user could swipe a conversation away, and then just keep swiping
We need to make sure that as they do that, we have the old
fading leave behind items keep fading out and just add new ones to the list.

Removes a few unnecessary styles.

Makes sure we don't restart animations on fading leave behinds.
Change-Id: I8927339a9c4d78304b98f2322fdd7c5dab484cdb
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
799277078f6a2ccdf52da2294c102bb9249803dd 11-Aug-2012 Mindy Pereira <mindyp@google.com> Simplify leavebehind tree.

Simpiler tree == smoother animations

Change-Id: Ic424adb64f1a6a153e47357b44332a32c2955ef3
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
db58fcbfb9ddba5cc85b5af20b490bfe7ad028d5 11-Aug-2012 Mindy Pereira <mindyp@google.com> Spend less time measuring == smoother animation

The width of a leavebehind will never change...
Change-Id: I6125cc677dfeccbd02907ce102523e2eab11b865
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
bcd784c09f649785a3dda1d6d9a6d5f58ba41770 10-Aug-2012 Mindy Pereira <mindyp@google.com> Explicitly call out the name of the folder/label being removed.

Fixes b/On swipe change copy for Remove from label to Remove from [labelname]

Also, that's not a not =P if it is animating, skip, otherwise, refresh
Change-Id: I450033cac8adf2b95e9ed101e1a4651f708e5ac0
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
9a604d0a4bbf41e9c287c5138b3f10db4b60f6c2 09-Aug-2012 Mindy Pereira <mindyp@google.com> Animate away the space when dismissing a leave behind.

Will likely use thsi method when dismissing by tapping another item
when still in conversation list.
Fixes b/6948666 animation for dismissal of archived "stub"

Change-Id: Idcb13d8e3fbebccd4a01b54513e251d00fd1076c
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
067ef97264240a2c3f9172a9ab88ba43fef7c475 08-Aug-2012 Mindy Pereira <mindyp@google.com> Moved swipe animation into animated adapter; alternate method for finding position

Fixes b/6930375 Crash on Swiping to archive few messages in quick succession
fixes b/6933685 After swipe to archive, tapping on email to open is off by one message
fixes b/6937509 seeing duplicate messages in inbox; when clicked, they open a different message

Some small funkiness in the animations on latest build; the top most item in the list is overlapping the top of the actionbar
I'm not sure this is my fault, but filing b/6961067 funkiness when deleting top item in list view to check into it
Change-Id: Id1e392744c58d806d633ee4d84abfadf9846e4a8
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
c3180e021cdf6aa13545682b7eda4f38a6baf51a 29-Jul-2012 Mindy Pereira <mindyp@google.com> The leavebehinditem is the view.

Fixes b/6893488 opened gmail,switched account and app crashed

Change-Id: Icfb30a99cd9cbe6e2e6084c73f95298a231bb291
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
bdb43d559dfba09752e95ca88f73ca566dcbb86f 26-Jul-2012 Mindy Pereira <mindyp@google.com> Dont show background for items that are not undoing a swipe gesture.

If undoing and it wasnt from a swipe, then have it grow back in
If it was from a swipe, have it slide back in left to right
Conflicts:

src/com/android/mail/compose/ComposeActivity.java

Change-Id: I6087128620e5db9d5eaa8995300bed8b2ff97911
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
350acdc75af67425aa3f8b6e4f889d4828ce8705 26-Jul-2012 Mindy Pereira <mindyp@google.com> Fix the text in the leavebehind; change undo animation.

We don't care about the count.
Conversations should slide in from the right as a result of undo.
Change-Id: I10d24f758a7260ff5cbb743c2d9c50445a989e6c
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
79e6a0830cc23deb9ba7be07d4ec5b5235a3398b 25-Jul-2012 Mindy Pereira <mindyp@google.com> Restore leave behind items on orientation change; only 1 leave behind.

Since there is only 1 leave behind at a time (2 leavebehind types,
1 that is fading away, one that is not), get rid of the complex
hash maps and just use single variables.
Change-Id: I67611dadd709a484239a2041c2df3f8797dc9170
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
62d7962b2b4d73f8414bbab1f42952442ac25be0 25-Jul-2012 Andy Huang <ath@google.com> Animate out existing leave behinds.

When the user swipes away a new item and there is a leave behind showing,
shrink away the existing leave behind so that we maintain some reasonable positioning.

Change-Id: I7318cc6ad1a7c0c8ed3420374680bac549c2e458
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
d3367499e56116854ed637b1036fd71057ac0f49 26-Jun-2012 Mindy Pereira <mindyp@google.com> Make it possible to restore undo operations.

Conflicts:

src/com/android/mail/ui/AbstractActivityController.java
src/com/android/mail/ui/SwipeableListView.java
src/com/android/mail/ui/UndoBarView.java

Change-Id: I42441c60e9ab7aff8f4c07dd21d03d2e419b2d0b
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
a8ead90ce1e6c66e4ecacdf7cfa25c2cafc9bb3b 12-Jul-2012 Mindy Pereira <mindyp@google.com> Update interaction of selected conversations with swipe

According to new specs:
1) only the item swiped on is archived, not any other selected conversations
2) even where there is a selection set, any swipe on any item will dismiss that item

Change-Id: Id94c69a0e5b0ca03b541458b1200a56d6d16c703
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
bf232c3735f65b1a4746943e4a134e59e36f0bde 18-Apr-2012 Paul Westbrook <pwestbro@google.com> Major refactor of ConversationCursor

* ConversationCursors are now associated with a particular loader;
there are no static methods or static state fields
* ConversationCursorLoader maintains a list of current loaders
(for tracking/debugging)
* AbstractActivityController acts as a router of conversation
changes to/from fragments (currently message view -> conversation
list)
* Comment out some ConversationCursor tests for now

Change-Id: I9b8425a19c77501796b6681142e1bc0ad20b3693
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
cf164d64bcb1da92b427bda99b97f7ec310ef704 20-Apr-2012 Marc Blank <mblank@google.com> Revert "Major refactor of ConversationCursor"

This reverts commit 5150f03723af8019169aeed8e406784da9c5f8f1.
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
5150f03723af8019169aeed8e406784da9c5f8f1 18-Apr-2012 Paul Westbrook <pwestbro@google.com> Major refactor of ConversationCursor

* ConversationCursors are now associated with a particular loader;
there are no static methods or static state fields
* ConversationCursorLoader maintains a list of current loaders
(for tracking/debugging)
* AbstractActivityController acts as a router of conversation
changes to/from fragments (currently message view -> conversation
list)

Change-Id: I0eb554615b4bf93b3547ff28e2bd5913e8703a97
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
07b8b1b3c93743690b05bbf79772f24d3bed5a7a 18-Apr-2012 Mindy Pereira <mindyp@google.com> Temporarily style the leave behind to look like the undo bar.

Change-Id: If1d26f9431fe6ed676114e6345f12fabd940d165
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java
6c72a787b58a0bc3afcb71093eddf8c29d1cf5ed 07-Apr-2012 Mindy Pereira <mindyp@google.com> Show leavebehind after swiping away an item.

Change-Id: I3bae79ed5bb8919985dbfa6e81416da980281cff
/packages/apps/UnifiedEmail/src/com/android/mail/ui/LeaveBehindItem.java