| 86f97eda524568f2d264186844450db5e56dac36 |
|
10-Nov-2014 |
Matthew Xie <mattx@google.com> |
Use the device type from saved properties instead of assuming default
DUMO device can do both BLE and BREDR operations. It was wrong
to assign BLE or BREDR type to it.
Bug: 18275230
Change-Id: I8d6c17e5157ba29a1af459629de9e2d6f6dc5e99
/external/bluetooth/bluedroid/btif/src/btif_config.c
|
| 335aa36bca8532874c23c1afe5bfc2aff7fc01a5 |
|
01-Jul-2014 |
Mike J. Chen <mjchen@google.com> |
Fix deadlock and non-working socket msg throttling
Two major bugs in btif_config.c. One is that due to improper
locking order, a deadlock could occur (symptom is generally
out of GKI buffers because BTIF thread stops processing it's
mailbox because it is blocked sending a msg to the socket
thread, which in turn is blocked because BTIF is holding
the lock it needs to do the config save that BTIF requested
in the first place).
The other is also lock related. The mechanism to throttle
socket messages based on whether there was one already
in flight wasn't working because there wasn't locking
when that variable was being used. The compiler would be
free to cache it in a register on SMP machines, so it would
never look like there as a value in flight. This would
cause a bunch of messages to be queued up, and then the
way the handling worked in cfg_cmd_callback(), every
cmd would cause a 3 second sleep, even if there was nothing
to do. Modified the loop to check if there was nothing
to do before sleeping.
I was running into both bugs when repeatedly pairing and
unpairing a BLE device. The deadlock would hit first, causing
out of GKI buffers. Once I fixed the deadlock, I would still
run out of GKI buffers because the socket thread wasn't working
fast enough to clear the backlog of socket messages it had
received.
Also optimized some string termination code which was using
a memset of the full buffer before and then copying over
every entry except the last. Now we do the copy and just
set the last buffer entry to null.
Change-Id: Ic06ef0b8e15d8f1fe669fb88439851ffbad560de
Signed-off-by: Mike J. Chen <mjchen@google.com>
/external/bluetooth/bluedroid/btif/src/btif_config.c
|
| 831423ea1879244e746f39d7696ad4a66681f306 |
|
07-Jan-2014 |
Hemant Gupta <hemantg@codeaurora.org> |
Bluetooth: Fix to avoid NULL pointer dereferences
This fix for avoiding NULL pointer dereferences:
- Added check for state checking in btm_remove_acl function
to avoid sending disconnect command if already in Disconnecting
state.
- Added NULL check for 'pin_code' in btif_dm_pin_reply function
- Null check before accessing in BD interface layer configuration
node variables.
- Add NULL check before accessing p_bd_addr variable to avoid null
pointer exception while referring to invalid memory.
Change-Id: Ib7ed45b6a1692785a45224d739a564f767e5b10f
/external/bluetooth/bluedroid/btif/src/btif_config.c
|
| 740def526e757f5ea8f30d9d28d1e7a668dadc42 |
|
04-May-2014 |
Sharvil Nanavati <sharvil@google.com> |
Eliminate dead code (helped by compiler warnings).
I've removed all functions that the compiler decided were unused.
Change-Id: I0cbddf874ebd1586abe29b80e8d6390680679542
/external/bluetooth/bluedroid/btif/src/btif_config.c
|
| 5cd8bff2dd0337cb52bf48f312e3d2d55a8882fb |
|
01-Feb-2014 |
Mike J. Chen <mjchen@google.com> |
Major warnings cleanup
Mostly fixing unused parameter warnings.
A few other warnings also fixed like possible use of
unitialized variables (no real issue found, just compiler couldn't
follow the path), signed vs unsigned warning.
Also fixed some typos, indent issues, removal of dead code, etc.
Change-Id: I95eb887aefc4d559d7921f71a0af5f3bfb01ac01
Signed-off-by: Mike J. Chen <mjchen@google.com>
/external/bluetooth/bluedroid/btif/src/btif_config.c
|
| 7939ed0c9a50c769e9e648a2d7751e0894b485ed |
|
28-Sep-2013 |
zzy <zhenye@broadcom.com> |
added filter remove api to control the # of child node for bt_config.xml
Bug 10949832
Change-Id: I10589b9d0a0b4b8d7cbf66122c66bb2e99be04a1
/external/bluetooth/bluedroid/btif/src/btif_config.c
|
| 689d66b6559dcb3a0ad7f6cc33b6129e50910253 |
|
13-Dec-2012 |
The Android Open Source Project <initial-contribution@android.com> |
Snapshot 9fd57cbacd95e89602f430244c35bbc67f08b6d2
Change-Id: Ibc3a4bf4161d286c7cfab89a19c676eb5cc9224f
/external/bluetooth/bluedroid/btif/src/btif_config.c
|
| 5738f83aeb59361a0a2eda2460113f6dc9194271 |
|
13-Dec-2012 |
The Android Open Source Project <initial-contribution@android.com> |
Snapshot cdeccf6fdd8c2d494ea2867cb37a025bf8879baf
Change-Id: Ia2de32ccb97a9641462c72363b0a8c4288f4f36d
/external/bluetooth/bluedroid/btif/src/btif_config.c
|