History log of /external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
7cd33f230441093dbfb1fec48f8c580ee8d9ef71 17-Jul-2014 Behdad Esfahbod <behdad@behdad.org> Micro optimization
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
7627100f428ac0ec8509d961d368d2d25d8f0b6e 11-Jul-2014 Behdad Esfahbod <behdad@behdad.org> Mark unsigned integer literals with the u suffix

Simplifies hb_in_range() calls as the type can be inferred.
The rest is obsessiveness, I admit.
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
3d6ca0d32e5c6597acfcf59301cb1905586ddb52 31-Dec-2013 Behdad Esfahbod <behdad@behdad.org> [ot] Simplify normalization_preference again

No shaper has more than one behavior re this, so no need for a callback.
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
71b4c999a511bf018acaf48a45e070470c0daf12 28-Oct-2013 Behdad Esfahbod <behdad@behdad.org> Revert "Zero marks by GDEF for Tibetan"

This reverts commit d5bd0590ae2fbc7b0dee86385a565aef00ffb835.

The reasoning behind that logic was flawed and made under
a misunderstanding of the original problem, and caused
regressions as reported by Jonathan Kew in thread titled
"tibetan marks" in Oct 2013. Apparently I have had fixed
the original problem with this commit:

7e08f1258da229dfaf7e1c4b5c41e5bb83906cb0

So, revert the faulty commit and everything seems to be in good
shape.
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
d5bd0590ae2fbc7b0dee86385a565aef00ffb835 18-Oct-2013 Behdad Esfahbod <behdad@behdad.org> Zero marks by GDEF for Tibetan

See:
http://lists.freedesktop.org/archives/harfbuzz/2013-April/003101.html
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
efed40b975110d78c9c505441e7e17a8c13e85c8 17-Oct-2013 Behdad Esfahbod <behdad@behdad.org> [indic] Minor refactoring of reph handling
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
a8cf7b43fa795150ae3d42d64424bb6e0373d0b2 19-Mar-2013 Behdad Esfahbod <behdad@behdad.org> [Indic] Futher adjust ZWJ handling in Indic-like shapers

After the Ngapi hackfest work, we were assuming that fonts
won't use presentation features to choose specific forms
(eg. conjuncts). As such, we were using auto-joiner behavior
for such features. It proved to be troublesome as many fonts
used presentation forms ('pres') for example to form conjuncts,
which need to be disabled when a ZWJ is inserted.

Two examples:

U+0D2F,U+200D,U+0D4D,U+0D2F with kartika.ttf
U+0995,U+09CD,U+200D,U+09B7 with vrinda.ttf

What we do now is to never do magic to ZWJ during GSUB's main input
match for Indic-style shapers. Note that backtrack/lookahead are still
matched liberally, as is GPOS. This seems to be an acceptable
compromise.

As to the bug that initially started this work, that one needs to
be fixed differently:

Bug 58714 - Kannada u+0cb0 u+200d u+0ccd u+0c95 u+0cbe does not
provide same results as Windows8
https://bugs.freedesktop.org/show_bug.cgi?id=58714

New numbers:

BENGALI: 353689 out of 354188 tests passed. 499 failed (0.140886%)
DEVANAGARI: 707305 out of 707394 tests passed. 89 failed (0.0125814%)
GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%)
GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%)
KANNADA: 951030 out of 951913 tests passed. 883 failed (0.0927606%)
KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%)
LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%)
MALAYALAM: 1048102 out of 1048334 tests passed. 232 failed (0.0221304%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
b1f440759161cb5a54e1b1b910f3a8383b8e8472 17-Feb-2013 Behdad Esfahbod <behdad@behdad.org> [SEA] Fix order of pre-base reordering Ra and left matras

The code was confused because it was expecting left matra to have
POS_PRE_M, like we do in the Myanmar shaper, but that is not what
we were doing in this shaper. Rewrite to rely on category only.

Test case: U+AA06,U+AA34,U+AA2F
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
ee9c3a17d0bf263c5eee479fd778db97cff8e189 15-Feb-2013 Behdad Esfahbod <behdad@behdad.org> Minor refactoring
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
cfc507c5432e6327e8484b07b9e091212653bc92 14-Feb-2013 Behdad Esfahbod <behdad@behdad.org> [Indic-like] Disable automatic joiner handling for basic shaping features

Not for Arabic, but for Indic-like scripts. ZWJ/ZWNJ have special
meanings in those scripts, so let font lookups take full control.

This undoes the regression caused by automatic-joiners handling
introduced two commits ago.

We only disable automatic joiner handling for the "basic shaping
features" of Indic, Myanmar, and SEAsian shapers. The "presentation
forms" and other features are still applied with automatic-joiner
handling.

This change also changes the test suite failure statistics, such that
a few scripts show more "failures". The most affected is Kannada.
However, upon inspection, we believe that in most, if not all, of the
new failures, we are producing results superior to Uniscribe. Hard to
count those!

Here's an example of what is fixed by the recent joiner-handling
changes:

https://bugs.freedesktop.org/show_bug.cgi?id=58714

New numbers, for future reference:

BENGALI: 353892 out of 354188 tests passed. 296 failed (0.0835714%)
DEVANAGARI: 707336 out of 707394 tests passed. 58 failed (0.00819911%)
GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%)
GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%)
KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%)
KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%)
LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%)
MALAYALAM: 1047983 out of 1048334 tests passed. 351 failed (0.0334817%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
ec5448667b30ad662401c2b4f5fc0da524c013fd 14-Feb-2013 Behdad Esfahbod <behdad@behdad.org> Add hb_ot_map_feature_flags_t

Code cleanup. No (intended) functional change.
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
e7ffcfafb1108801ac504f18f820e497226bf07f 14-Feb-2013 Behdad Esfahbod <behdad@behdad.org> Clean-up add_bool_feature
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
bc11de144c0a7a95fa0945aa7f053d8117af282a 13-Feb-2013 Behdad Esfahbod <behdad@behdad.org> [SEA] Don't zero any mark advances

Keep the logic simple, easier to explain to font developers.
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc
3a83d33ec0b1be6f5992816ff5ebb0f43c8dff00 12-Feb-2013 Behdad Esfahbod <behdad@behdad.org> Add South-East Asian shaper

Handles Tai Tham, Cham, and New Tai Lue for now.
/external/harfbuzz_ng/src/hb-ot-shape-complex-sea.cc