| 77a83962acf9211637d5ed0c81e1141a1ede05e1 |
|
20-Jun-2014 |
mtklein <mtklein@chromium.org> |
undefok -> bool
BUG=skia:
not waiting for (dead?) win builder
NOTRY=True
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/348063002
/external/skia/tools/flags/SkCommandLineFlags.cpp
|
| ffc224f802d0ce6d8606c4cfe59bc0238a3d2a5b |
|
25-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add a minimal --undefok to SkCommandLineFlags.
Similar in spirit to gflags' undefok, I'd like to be able to ignore
specific unknown flags. This lets me run the same command line on, say,
a branch that's got a new flag and on a clean branch tracking
origin/master. This is handy for performance comparison, etc.
It's not essential, and if you hate this I can find another way.
As an example, I want to compare the runtime of SKP recording with my new code. I've added a flag --skr to bench_record to help this. So I want to compare
origin/master: out/Release/bench_record
my patch: out/Release/bench_record --skr
This lets me run both as out/Release/bench_record --undefok skr --skr, which is handy for scripts and things.
BUG=skia:
R=scroggo@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/209393015
git-svn-id: http://skia.googlecode.com/svn/trunk@13945 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/flags/SkCommandLineFlags.cpp
|
| a6f37e77c1c95f0a06ac55ff659cb7b8dfabefcf |
|
30-Aug-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add ShouldSkip variant that can read a --match flag directly.
Just seemed like we were going through lots of hoops for this common case.
BUG=
R=scroggo@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/23708009
git-svn-id: http://skia.googlecode.com/svn/trunk@11034 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/flags/SkCommandLineFlags.cpp
|
| 330313a8a8343876ee596da39da06a5d69badd9c |
|
22-Aug-2013 |
mtklein@google.com <mtklein@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
My clang now doesn't complain about !"foo".
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/22875037
git-svn-id: http://skia.googlecode.com/svn/trunk@10874 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/flags/SkCommandLineFlags.cpp
|
| 586db93c447b753364d50fadc5426de4fef9a759 |
|
24-Jul-2013 |
sglez@google.com <sglez@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
refactor duplication (shouldSkip and skip_name) into a utility function
R=caryclark@google.com, reed@google.com
Committed: https://code.google.com/p/skia/source/detail?r=10280
Review URL: https://codereview.chromium.org/19807005
git-svn-id: http://skia.googlecode.com/svn/trunk@10317 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/flags/SkCommandLineFlags.cpp
|
| ed5eb4ef2aa1d6c705bc3ed466f9caba2a230a2b |
|
23-Jul-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert r10280, which caused https://code.google.com/p/skia/issues/detail?id=1441
Review URL: https://codereview.chromium.org/19537005
git-svn-id: http://skia.googlecode.com/svn/trunk@10284 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/flags/SkCommandLineFlags.cpp
|
| 434251f87292808c1c461e48dba5d22735e74f97 |
|
23-Jul-2013 |
sglez@google.com <sglez@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
refactor duplication (shouldSkip and skip_name) into a utility function
R=caryclark@google.com, reed@google.com
Review URL: https://codereview.chromium.org/19807005
git-svn-id: http://skia.googlecode.com/svn/trunk@10280 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/flags/SkCommandLineFlags.cpp
|
| d0419019de2a15a87d390fb0eed929acf9029d75 |
|
24-Apr-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix the build.
Allow NULL for defaultValue in SkCommandLineFlags.
unreviewed.
Review URL: https://codereview.chromium.org/14472017
git-svn-id: http://skia.googlecode.com/svn/trunk@8847 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/flags/SkCommandLineFlags.cpp
|
| 58104a9c2517b25355d6838844ace2ea876f3a1c |
|
24-Apr-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Treat default command line argument properly.
In SkCommandLineFlags, if the client sets a default value
of multiple arguments (e.g. "arg0 arg1 ..."), set
the actual defaults to all of those arguments separately
(i.e. an array with [0] == "arg0", [1] == "arg1", ...),
rather than as one string (i.e. [0] == "arg0 arg1 ...").
Remove the hack that worked around this bug.
Also move the increasingly complicated implementation of
SkFlagInfo::CreateStringFlag into the cpp file.
BUG=https://code.google.com/p/skia/issues/detail?id=1237
Review URL: https://codereview.chromium.org/14366034
git-svn-id: http://skia.googlecode.com/svn/trunk@8845 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/flags/SkCommandLineFlags.cpp
|
| b7dbf633a69408fef33105e39b60c442771dba07 |
|
23-Apr-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix an SkCommandLineFlags bug.
Previously I was storing an SkTDArray of const char*,
which fails if the strings go out of scope.
Instead, store an SkTArray of SkString, and copy the
strings, so we do not depend on the strings sticking
around. Using an SkTArray because it is smart enough
to call the destructors, so the copies can be destroyed
on program exit.
BUG=https://code.google.com/p/skia/issues/detail?id=1237
Review URL: https://codereview.chromium.org/14414008
git-svn-id: http://skia.googlecode.com/svn/trunk@8829 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/flags/SkCommandLineFlags.cpp
|
| 604e0c249ef0e11a1b8bc41195081363fd86d892 |
|
09-Apr-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
SkFlags now follows proper dashing convention.
Two dashes are used for flags with multiple characters, and one
dash is used for flags with single characters.
In GM, changed '-wp' to '-p' (the command to choose a directory
for writing SKPs) to fit with the convention.
In render_pictures and bench_pictures, changed the flag for
read and write path to have full names (which are consistent)
and use the old single character names as their shortcuts.
SkCommandLineFlags: Updated the documentation, and only allow
-h or --help for help (again, to match the convention).
Also enforce the single character limit for the short name, and
require the full name to be at least two characters.
Provide full names for skhello.
BUG=https://code.google.com/p/skia/issues/detail?id=1174
Review URL: https://codereview.chromium.org/12521019
git-svn-id: http://skia.googlecode.com/svn/trunk@8582 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/flags/SkCommandLineFlags.cpp
|
| d9ba9a05d6f5766fdb1378b6ed84c0659009a8da |
|
21-Mar-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Change the name of SkFlags to SkCommandLineFlags.
This name is more specific to what it actually does.
Also move the code into tools/flags, to (slightly) better organize
the massive tools folder.
Update the programs that use it to use the new names.
No functionality changes.
BUG=https://code.google.com/p/skia/issues/detail?id=1173
Review URL: https://codereview.chromium.org/12440067
git-svn-id: http://skia.googlecode.com/svn/trunk@8304 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/tools/flags/SkCommandLineFlags.cpp
|