| c78626b15e9f29a5bcf85447ceafb17dcbf58b69 |
|
20-May-2012 |
Emilian Peev <epeev@mm-sol.com> |
CameraHal: Avoids possible race conditions while accessing 'mParams'
- Direct access of 'mParams' outside of 'get-/setParameters()' should
be avoided. The underlying strings can get invalidated with each
call to 'setParameters()', which can lead to instabilities.
- This change also removes legacy stereo code, which is not used
any more.
Bug: 6509329
Change-Id: Ief6df206c33fbdc666644cea8630e0bce6a36c00
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| a6e9160507cd4c0d276fbe45a1efb1dae28c3998 |
|
09-Mar-2012 |
Emilian Peev <epeev@mm-sol.com> |
CameraHal: Cuts down execution time of 'get-/setParameters()'
- The change utilizes two approaches:
Wrap unused parameters in 'OMAP_ENHANCEMENT' macro.
Minimize usage of CameraParameters.
bug:6136966
Change-Id: Ie4a4d2f007e6571ee9a403ed68e977d6cbf6756b
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| 7a1746145a89cca0dafe26478a7675c15d5623a3 |
|
23-Nov-2011 |
Akwasi Boateng <akwasi.boateng@ti.com> |
CameraHAL: Fixes a couple of corner cases with AF and capture
- On some occasions during monkey tests, both the AF callback
and the shutter callback can be delayed just enough to
encounter the OMX component in loaded state. Usually this happens
when the camera is getting closed and this scenario should be
properly handled by exiting immediately without trying to trigger
any callbacks to the client.
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Akwasi Boateng <akwasi.boateng@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
Change-Id: Ia18faf471a8e10579b09973178d73e69e782c63c
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| 7ce015866d4be66a147e9cacbe70a376dd1e6360 |
|
30-Nov-2011 |
Iliyan Malchev <malchev@google.com> |
am 67496a60: am 3ffd5d43: Merge changes I0878a9f8,I1011252e into ics-mr1
* commit '67496a60c60076166f6856431f68024a9412c067':
CameraHAL: Perform focus even if CAF has failed
CameraHAL: Enable LDCNSF for Video snapshot
|
| d9520b9de06f01b9411307040cf245e6fc7fe361 |
|
12-Oct-2011 |
Milen Mitkov <mmitkov@mm-sol.com> |
CameraHAL: Enable LDCNSF for Video snapshot
Enables LDCNSF for Video snapshot, also adds start_offset and right_crop fields
to the JPEG encoder wrapper, because the image with LDCNSF has artifacts on top
and right.
Change-Id: I1011252e3f8068083f9d057b7763b7f79c59a75d
Signed-off-by: Milen Mitkov <mmitkov@mm-sol.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| ef73bec8a83a2fd7fbb072d009382c64eb2da0ee |
|
19-Oct-2011 |
Tyler Luu <tluu@ti.com> |
CameraHal: Add more Exif data for video snapshot
Fixes b/5582076. Requires changes to Ducati and external/jhead.
1. Add API to get and set ancillary data metadata so
we can use the values to fill in Exif data.
2. Add support for additional tags.
Change-Id: I537e683839c59e92a4a20ff62653b6d46e303f53
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| 3ec18006399d61e97382601d14aaa43ee339c8b6 |
|
08-Nov-2011 |
Sundar Raman <sunds@ti.com> |
CameraHAL: Fixes for ANR and a setParameter issue
Fix 1/3 for b/5593964.
1. Ensure we don't race with stopImageCapture when stopPreview is called
2. Signal the shutter callback correctly
3. Do not crash the media server if focus APIs and image capture returns error
Still go ahead and perform de-init
4. Replace setParameter from CameraHAl to AppCallbackNotifier with getParameter
when needed.
Change-Id: I2b2745827d227a8d7927ce1611a84c29129e8891
Signed-off-by: Sundar Raman <sunds@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| fc8ab094473901857ee382396eebc5d52ac4c6c6 |
|
26-Oct-2011 |
Tyler Luu <tluu@ti.com> |
CameraHal: Clean-up if mCaptureSem times out
Fix 2/3 for b/5472396.
In stopImageCapture, continue cleaning up even if mCaptureSem
times out.
Change-Id: Idf65a488b2ce55a9d451a899df0bc76f6480647b
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| fd705eb8b757a4f3d1d80b736cf20cade04524d7 |
|
21-Oct-2011 |
Tyler Luu <tluu@ti.com> |
CameraHal: Fixes for #testFocusDistance
1. Seperate OMXCameraAdapter cancelAutoFocus with unsetting focus
lock. Adding new internal parameter to unlock focus from the
cancelAutoFocus in CameraHal. We need to cancel auto focus during
stop preview in case it is still running. If we do the unlock in
OMXCameraAdapter then, focus distance can change after stopPreview.
2. If autoFocus or takePicture comes after startPreview but before
the first preview frame comes, then sometimes the focus distance
queried after the calls won't be correct since OMX camera might
still be transitioning.
3. Update focus distances when focus is running.
b/5473673
Change-Id: I5a27d78aef437a1601a68e8c08fa860f04fc0c55
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| 14b70386c375a24a2ec0ff627efa9bb90b00ecfe |
|
21-Oct-2011 |
Tyler Luu <tluu@ti.com> |
CameraHal: Fix for #testJpegThumbnailSize
Fixes b/5492679
If an image capture is taken before running this test, the test will
fail because the image capture settings were not being re-applied
to the image port. This patch updates all the capture settings
on first time init.
Change-Id: Iac8ace02b271b431a55736fbbeee29fadc4393bd
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| d16343600a83478ed6223e51aa41f717f28b6351 |
|
20-Oct-2011 |
Sundar Raman <sunds@ti.com> |
CameraHAL: Fix for #testJpegExif
Set the focal length to correct defaults for primary and secondary
for the sensors on the phone. Previous camerahal value was wrong.
Call setupEXIF even in the case where we return from
useBufferCapture when the port is already enabled.
Change-Id: I224ec2f19af11de525455015c1822ba6a13c4d17
Signed-off-by: Sundar Raman <sunds@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| fab72086a1fa5d93037ec1355bc8b01355db0f41 |
|
18-Oct-2011 |
Tyler Luu <tluu@ti.com> |
CameraHAL: Keep image port enabled if possible
Try to keep the image port enabled if possible after capturing
an image. We need to disable the image port if any settings are
changed or when stopping preview. To disable image port, buffers
also have to be freed, and to keep the image port enabled, the
same buffer needs to be used. So, we are reenabling functionality
to trigger free the image buffer from camera adapter to free the
buffer as late as possible and as required by camera adapter.
Skip image buffer allocation if it is already enabled.
Fixes issue with some jerks seen in preview during video
capture while taking snapshot.
b/5449158
Change-Id: I830cf8512fe039df10d28e1f5a22e61e30840852
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| 88006b1ebee79cb0f1a2c682258b313eb801049d |
|
30-Sep-2011 |
Sundar Raman <sunds@ti.com> |
omap4xxx: camera: various fixes
clean up resources properly on exit:
- Frees all resources in case of error during
preview buffer allocation in ANativeDisplayAdadapter.
- Fixes a couple of typos in BaseCameraAdapter.
- Removes a possible memory leak during temporal
bracketing. 'stopBracketing()' will never get
properly executed when 'startImageCapture()'
disables 'mBracketingEnabled'.
- Stops temporal bracketing properly inside
'signalEndImageCapture()'.
Change-Id: Ic122058c835e30f12f335a288164475b8f6d1c6d
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Sundar Raman <sunds@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| b5abb7cbdf48ecccbf0e6d5e61a1846c0c4b28a5 |
|
01-Oct-2011 |
Tyler Luu <tluu@ti.com> |
omap4xxx: camera: set capture settings only if changed
Partial fix for b/5371242
Only set capture configs when they have changed from our current setting to
save some SetConfig time.
Change-Id: I68d7b7ebd4be3273abd534ce8e939da62d38d481
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| b3fb1a45ce906ab0365f247caf596665ea0c9f39 |
|
26-Sep-2011 |
Sundar Raman <sunds@ti.com> |
CameraHAL: Improved error handling inside the adapters
1. unlock and cancel buffers to ANativeWindow when freeBuffers is called
2. Free the omx handle and deinitialize DOMX when errors occur while
calling critical OMXCamera apis
3. Retry OMX_GetHandle if it fails to take care of error recovery
scenarios.
"Fixes b/5379663"
Change-Id: I4729fab40e6104dfa6660ba6f6b1a90f805c2f59
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| 2bc5d70a6c9ca52c7d2fbafdf545b42aef08215a |
|
23-Sep-2011 |
Tyler Luu <tluu@ti.com> |
CameraHal: Changes to releasing of focus lock
Do not release focus lock during stopPreview and after
takePicture.
bug:5356404
Change-Id: Ib7078f5261ee21579143c4519896d1b13874697b
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| 0e2a9f1fabc12a1a1123f8374d0e4d6faf5a2d62 |
|
20-Sep-2011 |
Tyler Luu <tluu@ti.com> |
CameraHal: Changes to 3A lock implementation
1) Only take user set values for AE and AWB locks. Decouple
interaction between AE/AWB locks and AF/takePicture/stopPreview
2) When in CAF mode, if we query AF and see that focus is already
locked, we do not have to call SetConfig for OMX_IndexConfigFocusControl.
Just return the status to upper layers instead.
3) If user doesn't call cancelAutoFocus after a doAutoFocus call, we
need to forcefully unlock AF to ensure we do a scan. This would also
essentially render CAF as normal auto AF.
bug:5356404
Change-Id: I5bb840ca0122d8a9387f72290d2b421703dba23d
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| 9dc08c5fb736308cfca6659f66b14165b265baeb |
|
19-Sep-2011 |
Tyler Luu <tluu@ti.com> |
CameraHal: Lock focus after AF completion
1) Add API to use OMX_IndexConfigImageFocusLock to lock autofocus
2) Remove FIXME to always return true status when CAF is set
Change-Id: Ie195206243bc1f750954def5f4f9f4466295bc7c
b/5338488
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| 6b5eaf29c3d17a24731bf9271bd0d199d433813e |
|
09-Sep-2011 |
Akwasi Boateng <akwasi.boateng@ti.com> |
Unblock semaphores during Fatal Errors
1. Remove all pending events and unblock
all waiting semaphore during Fatal error.
2. Exit execution when in invalid state.
3. Remove error nitiifcation from
Appcallback thread
Change-Id: I1612ff75e83ebf285d4cc168a829e0f81d4968b1
Signed-off-by: Akwasi Boateng <akwasi.boateng@ti.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| 470b7353f563741371ebd464f6c4a662f45e65c4 |
|
09-Sep-2011 |
Tyler Luu <tluu@ti.com> |
CameraHal: Handle a few corner cases with capture
1. Do not apply 3A settings in the middle of a capture.
Causing an issue with the capture pipe
2. If we happen to unregister shutter callback while
somebody is still waiting for it, go ahead and
signal them.
Change-Id: I961571a1feeec5349b9888748cf002e1e30cea4e
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| ba027fc89ec3950e1ac2f95fcc3f1002442ddabb |
|
12-Sep-2011 |
Sundar Raman <sunds@ti.com> |
CameraHAL CTS: Fix for #testAutoExposureLock, #testAutoWhiteBalanceLock
Locks were not retained if the user forces the lock to true
before calling autoFocus. This patch addresses this scenario.
Change-Id: I2b5161806f8123b3042d46bc856773f0d4701458
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| 9b981b1785b6758b2dc8b147587188e5cf0d893d |
|
09-Sep-2011 |
Akwasi Boateng <akwasi.boateng@ti.com> |
Destroy and recreate semaphore in case of timeout
Destroy and recreate semaphor during timeout
and remove event from event queue.
Change-Id: Id9428ff58a55f90a6807776327bfba1961d9089d
Signed-off-by: Akwasi Boateng <akwasi.boateng@ti.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| ee6bb64f60c228d711dc1d6875d8f4b0ed88b6cf |
|
01-Sep-2011 |
Tyler Luu <tluu@ti.com> |
CameraHal: Initial support for video snapshot
Adds support for capturing an image while
recording in video mode. Sets up Ducati to
return a YUV422I buffer and encode is performed
in AppCallbackNotifier with Encoder_libjpeg class.
Change-Id: Ia351fc99dab63a12add8c6c960b186bbe5be275a
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| aa6e62e279cb54ae76c55ba9f8d02da230ce34e7 |
|
16-Aug-2011 |
Tyler Luu <tluu@ti.com> |
CameraHal: Adjust FD callbacks to updated javadoc
FD callback behavior is updated in latest javadoc
patch "Improve camera face detection javadoc."
Change-Id: I963628ae55eec62083c25d34bbb380ae6673e431
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| 80c50ac56bfa97be0cf04332ec1d314637c8770f |
|
09-Aug-2011 |
Sundar Raman <sunds@ti.com> |
Lock AE and AWB after AF
Change-Id: I12f1037be3d890b50c5413925d3084a2cf5256aa
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|
| c322989ae6ff6769490828de1b5eda12b749cce9 |
|
08-Aug-2011 |
Iliyan Malchev <malchev@google.com> |
initial commit
Change-Id: I8f7a7eeece0e516efa486b77e9d97805c0e65d3e
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/OMXCameraAdapter/OMXCapture.cpp
|