| 8fcb631389123ab7f5d795ae3a36a67842b3028c |
|
06-Jun-2014 |
Nick Kralevich <nnk@google.com> |
adb: avoid leaking file descriptors
If an adb shell connection comes in while taking a screenshot,
an open pipe file descriptor will be leaked to the shell process.
This causes SELinux denials of the form:
avc: denied { read } for path="pipe:[21838]" dev="pipefs" ino=21838 scontext=u:r:shell:s0 tcontext=u:r:adbd:s0 tclass=fifo_file permissive=0
avc: denied { write } for path="pipe:[21838]" dev="pipefs" ino=21838 scontext=u:r:shell:s0 tcontext=u:r:adbd:s0 tclass=fifo_file permissive=0
Set O_CLOEXEC on the pipe connections, to avoid leaking them
across an exec boundary.
Bug: 15437785
Change-Id: Id2304b316bd7082d8baac246dce1f0e0e26e9197
/system/core/adb/framebuffer_service.c
|
| 85373f42803f86e3295afd5031a0e42e0b3bef33 |
|
25-Sep-2013 |
Chris Dearman <chris.dearman@imgtec.com> |
Handle screendumps for all framebuffer sizes
readx() treats a partial read as an error but also consumes the data,
Now exactly the amount of data needed for the screendump is requested.
This bug showed up for framebuffers that were not a multiple of 640
bytes.
Also fix a compiler warning related to handing pipe() failure.
Change-Id: I8b1713923e156d4e3424784152e5dc5cbc7d478d
/system/core/adb/framebuffer_service.c
|
| 5a536efa5b5f5d973232846d5fe6818df84ab5dc |
|
17-Jul-2012 |
Yuriy Zabroda <yuriy.zabroda@ti.com> |
Avoid zombies on androidscreencast
When using a third party screen capture program called androidscreencast
(http://code.google.com/p/androidscreencast/) to get the framebuffer of
the device, there are tons of screencap zombie processes got left behind.
The issue is also mentioned here: http://code.google.com/p/android/issues/detail?id=22836.
The cause of the issue is that adbd spawns off screencap processes,
and these child processes were not waited to be finished.
This change fixes the issue.
Change-Id: Ife928d65ecf6a2ff39b8b72ddba930fda6733a00
Signed-off-by: Yuriy Zabroda <yuriy.zabroda@ti.com>
/system/core/adb/framebuffer_service.c
|
| c1fbf7c1638cb4f1f139edf74562fcfbaa6f3435 |
|
09-Feb-2011 |
Mathias Agopian <mathias@google.com> |
fix [3374821] Cannot take screenshot of HC preview
don't hardcode the pixelformat to RGBA_8888 when taking
screenshots.
Change-Id: I3a76b49275acfce9a2994436f521b76310cd8fb2
/system/core/adb/framebuffer_service.c
|
| 0715f91223b2f7a91ea08bfa95998d846e7977cf |
|
27-Sep-2010 |
Mathias Agopian <mathias@google.com> |
update adbd to use the new screencap command for taking screenshots.
Change-Id: I02c49240f9db9258824020f3f5f04463e17a537a
/system/core/adb/framebuffer_service.c
|
| 154b7d7de4071ed73cde81eef3af47d1a24d7c6b |
|
16-Sep-2009 |
Rebecca Schultz Zavin <rebecca@android.com> |
Add bitfields to header for screen shots. This will allow ddms to distinguish
between various 32 bit pixel formats. Also adds new version number for
future expansion.
Change-Id: Ia1d7d7485614e961a47ebb65493b19f4a16ded05
Signed-off-by: Rebecca Schultz Zavin <rebecca@android.com>
/system/core/adb/framebuffer_service.c
|
| 04bee29ad979ca770677338e343869a0d5662cfb |
|
10-Sep-2009 |
Rebecca Schultz Zavin <rebecca@android.com> |
Fix several issues in framebuffer_service
-supports fb's with x and y offsets
-dumps the front buffer (instead of just the low end of the buffer)
-switch from mmap to read/write, for fb's with very large offsets
Change-Id: Id560790c9661f7cc3b4350a44cc29f0104831e85
Signed-off-by: Rebecca Schultz Zavin <rebecca@android.com>
/system/core/adb/framebuffer_service.c
|
| 414ff7d98ac8d7610a26206335954ad15f43f3ac |
|
18-May-2009 |
David 'Digit' Turner <digit@google.com> |
Move fdevent from libcutils into adb directory. ADB is the only client of this API, and I intend to modify it extensively to clean its codebase soon.
/system/core/adb/framebuffer_service.c
|
| dd7bc3319deb2b77c5d07a51b7d6cd7e11b5beb0 |
|
04-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //depot/cupcake/@135843
/system/core/adb/framebuffer_service.c
|
| e54eebbf1a908d65ee8cf80bab62821c05666d70 |
|
04-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //depot/cupcake/@135843
/system/core/adb/framebuffer_service.c
|
| 35237d135807af84bf9b0e5b8d7f8633e58db6f5 |
|
18-Dec-2008 |
The Android Open Source Project <initial-contribution@android.com> |
Code drop from //branches/cupcake/...@124589
/system/core/adb/framebuffer_service.c
|
| 4f6e8d7a00cbeda1e70cc15be9c4af1018bdad53 |
|
21-Oct-2008 |
The Android Open Source Project <initial-contribution@android.com> |
Initial Contribution
/system/core/adb/framebuffer_service.c
|