SemaDeclObjC.cpp revision 25cf760b54d3b88633827501013bc51a29b28aba
1//===--- SemaDeclObjC.cpp - Semantic Analysis for ObjC Declarations -------===// 2// 3// The LLVM Compiler Infrastructure 4// 5// This file is distributed under the University of Illinois Open Source 6// License. See LICENSE.TXT for details. 7// 8//===----------------------------------------------------------------------===// 9// 10// This file implements semantic analysis for Objective C declarations. 11// 12//===----------------------------------------------------------------------===// 13 14#include "Sema.h" 15#include "clang/Sema/ExternalSemaSource.h" 16#include "clang/AST/Expr.h" 17#include "clang/AST/ASTContext.h" 18#include "clang/AST/DeclObjC.h" 19#include "clang/Parse/DeclSpec.h" 20using namespace clang; 21 22bool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 23 ObjCMethodDecl *GetterMethod, 24 SourceLocation Loc) { 25 if (GetterMethod && 26 GetterMethod->getResultType() != property->getType()) { 27 AssignConvertType result = Incompatible; 28 if (property->getType()->isObjCObjectPointerType()) 29 result = CheckAssignmentConstraints(GetterMethod->getResultType(), property->getType()); 30 if (result != Compatible) { 31 Diag(Loc, diag::warn_accessor_property_type_mismatch) 32 << property->getDeclName() 33 << GetterMethod->getSelector(); 34 Diag(GetterMethod->getLocation(), diag::note_declared_at); 35 return true; 36 } 37 } 38 return false; 39} 40 41/// ActOnStartOfObjCMethodDef - This routine sets up parameters; invisible 42/// and user declared, in the method definition's AST. 43void Sema::ActOnStartOfObjCMethodDef(Scope *FnBodyScope, DeclPtrTy D) { 44 assert(getCurMethodDecl() == 0 && "Method parsing confused"); 45 ObjCMethodDecl *MDecl = dyn_cast_or_null<ObjCMethodDecl>(D.getAs<Decl>()); 46 47 // If we don't have a valid method decl, simply return. 48 if (!MDecl) 49 return; 50 51 CurFunctionNeedsScopeChecking = false; 52 53 // Allow the rest of sema to find private method decl implementations. 54 if (MDecl->isInstanceMethod()) 55 AddInstanceMethodToGlobalPool(MDecl); 56 else 57 AddFactoryMethodToGlobalPool(MDecl); 58 59 // Allow all of Sema to see that we are entering a method definition. 60 PushDeclContext(FnBodyScope, MDecl); 61 62 // Create Decl objects for each parameter, entrring them in the scope for 63 // binding to their use. 64 65 // Insert the invisible arguments, self and _cmd! 66 MDecl->createImplicitParams(Context, MDecl->getClassInterface()); 67 68 PushOnScopeChains(MDecl->getSelfDecl(), FnBodyScope); 69 PushOnScopeChains(MDecl->getCmdDecl(), FnBodyScope); 70 71 // Introduce all of the other parameters into this scope. 72 for (ObjCMethodDecl::param_iterator PI = MDecl->param_begin(), 73 E = MDecl->param_end(); PI != E; ++PI) 74 if ((*PI)->getIdentifier()) 75 PushOnScopeChains(*PI, FnBodyScope); 76} 77 78Sema::DeclPtrTy Sema:: 79ActOnStartClassInterface(SourceLocation AtInterfaceLoc, 80 IdentifierInfo *ClassName, SourceLocation ClassLoc, 81 IdentifierInfo *SuperName, SourceLocation SuperLoc, 82 const DeclPtrTy *ProtoRefs, unsigned NumProtoRefs, 83 SourceLocation EndProtoLoc, AttributeList *AttrList) { 84 assert(ClassName && "Missing class identifier"); 85 86 // Check for another declaration kind with the same name. 87 NamedDecl *PrevDecl = LookupName(TUScope, ClassName, LookupOrdinaryName); 88 if (PrevDecl && PrevDecl->isTemplateParameter()) { 89 // Maybe we will complain about the shadowed template parameter. 90 DiagnoseTemplateParameterShadow(ClassLoc, PrevDecl); 91 // Just pretend that we didn't see the previous declaration. 92 PrevDecl = 0; 93 } 94 95 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 96 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName; 97 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 98 } 99 100 ObjCInterfaceDecl* IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 101 if (IDecl) { 102 // Class already seen. Is it a forward declaration? 103 if (!IDecl->isForwardDecl()) { 104 IDecl->setInvalidDecl(); 105 Diag(AtInterfaceLoc, diag::err_duplicate_class_def)<<IDecl->getDeclName(); 106 Diag(IDecl->getLocation(), diag::note_previous_definition); 107 108 // Return the previous class interface. 109 // FIXME: don't leak the objects passed in! 110 return DeclPtrTy::make(IDecl); 111 } else { 112 IDecl->setLocation(AtInterfaceLoc); 113 IDecl->setForwardDecl(false); 114 } 115 } else { 116 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtInterfaceLoc, 117 ClassName, ClassLoc); 118 if (AttrList) 119 ProcessDeclAttributeList(TUScope, IDecl, AttrList); 120 121 PushOnScopeChains(IDecl, TUScope); 122 } 123 124 if (SuperName) { 125 // Check if a different kind of symbol declared in this scope. 126 PrevDecl = LookupName(TUScope, SuperName, LookupOrdinaryName); 127 if (PrevDecl == IDecl) { 128 Diag(SuperLoc, diag::err_recursive_superclass) 129 << SuperName << ClassName << SourceRange(AtInterfaceLoc, ClassLoc); 130 IDecl->setLocEnd(ClassLoc); 131 } else { 132 ObjCInterfaceDecl *SuperClassDecl = 133 dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 134 135 // Diagnose classes that inherit from deprecated classes. 136 if (SuperClassDecl) 137 (void)DiagnoseUseOfDecl(SuperClassDecl, SuperLoc); 138 139 if (PrevDecl && SuperClassDecl == 0) { 140 // The previous declaration was not a class decl. Check if we have a 141 // typedef. If we do, get the underlying class type. 142 if (const TypedefDecl *TDecl = dyn_cast_or_null<TypedefDecl>(PrevDecl)) { 143 QualType T = TDecl->getUnderlyingType(); 144 if (T->isObjCInterfaceType()) { 145 if (NamedDecl *IDecl = T->getAsObjCInterfaceType()->getDecl()) 146 SuperClassDecl = dyn_cast<ObjCInterfaceDecl>(IDecl); 147 } 148 } 149 150 // This handles the following case: 151 // 152 // typedef int SuperClass; 153 // @interface MyClass : SuperClass {} @end 154 // 155 if (!SuperClassDecl) { 156 Diag(SuperLoc, diag::err_redefinition_different_kind) << SuperName; 157 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 158 } 159 } 160 161 if (!dyn_cast_or_null<TypedefDecl>(PrevDecl)) { 162 if (!SuperClassDecl) 163 Diag(SuperLoc, diag::err_undef_superclass) 164 << SuperName << ClassName << SourceRange(AtInterfaceLoc, ClassLoc); 165 else if (SuperClassDecl->isForwardDecl()) 166 Diag(SuperLoc, diag::err_undef_superclass) 167 << SuperClassDecl->getDeclName() << ClassName 168 << SourceRange(AtInterfaceLoc, ClassLoc); 169 } 170 IDecl->setSuperClass(SuperClassDecl); 171 IDecl->setSuperClassLoc(SuperLoc); 172 IDecl->setLocEnd(SuperLoc); 173 } 174 } else { // we have a root class. 175 IDecl->setLocEnd(ClassLoc); 176 } 177 178 /// Check then save referenced protocols. 179 if (NumProtoRefs) { 180 IDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs, 181 Context); 182 IDecl->setLocEnd(EndProtoLoc); 183 } 184 185 CheckObjCDeclScope(IDecl); 186 return DeclPtrTy::make(IDecl); 187} 188 189/// ActOnCompatiblityAlias - this action is called after complete parsing of 190/// @compatibility_alias declaration. It sets up the alias relationships. 191Sema::DeclPtrTy Sema::ActOnCompatiblityAlias(SourceLocation AtLoc, 192 IdentifierInfo *AliasName, 193 SourceLocation AliasLocation, 194 IdentifierInfo *ClassName, 195 SourceLocation ClassLocation) { 196 // Look for previous declaration of alias name 197 NamedDecl *ADecl = LookupName(TUScope, AliasName, LookupOrdinaryName); 198 if (ADecl) { 199 if (isa<ObjCCompatibleAliasDecl>(ADecl)) 200 Diag(AliasLocation, diag::warn_previous_alias_decl); 201 else 202 Diag(AliasLocation, diag::err_conflicting_aliasing_type) << AliasName; 203 Diag(ADecl->getLocation(), diag::note_previous_declaration); 204 return DeclPtrTy(); 205 } 206 // Check for class declaration 207 NamedDecl *CDeclU = LookupName(TUScope, ClassName, LookupOrdinaryName); 208 if (const TypedefDecl *TDecl = dyn_cast_or_null<TypedefDecl>(CDeclU)) { 209 QualType T = TDecl->getUnderlyingType(); 210 if (T->isObjCInterfaceType()) { 211 if (NamedDecl *IDecl = T->getAsObjCInterfaceType()->getDecl()) { 212 ClassName = IDecl->getIdentifier(); 213 CDeclU = LookupName(TUScope, ClassName, LookupOrdinaryName); 214 } 215 } 216 } 217 ObjCInterfaceDecl *CDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDeclU); 218 if (CDecl == 0) { 219 Diag(ClassLocation, diag::warn_undef_interface) << ClassName; 220 if (CDeclU) 221 Diag(CDeclU->getLocation(), diag::note_previous_declaration); 222 return DeclPtrTy(); 223 } 224 225 // Everything checked out, instantiate a new alias declaration AST. 226 ObjCCompatibleAliasDecl *AliasDecl = 227 ObjCCompatibleAliasDecl::Create(Context, CurContext, AtLoc, AliasName, CDecl); 228 229 if (!CheckObjCDeclScope(AliasDecl)) 230 PushOnScopeChains(AliasDecl, TUScope); 231 232 return DeclPtrTy::make(AliasDecl); 233} 234 235void Sema::CheckForwardProtocolDeclarationForCircularDependency( 236 IdentifierInfo *PName, 237 SourceLocation &Ploc, SourceLocation PrevLoc, 238 const ObjCList<ObjCProtocolDecl> &PList) { 239 for (ObjCList<ObjCProtocolDecl>::iterator I = PList.begin(), 240 E = PList.end(); I != E; ++I) { 241 242 if (ObjCProtocolDecl *PDecl = LookupProtocol((*I)->getIdentifier())) { 243 if (PDecl->getIdentifier() == PName) { 244 Diag(Ploc, diag::err_protocol_has_circular_dependency); 245 Diag(PrevLoc, diag::note_previous_definition); 246 } 247 CheckForwardProtocolDeclarationForCircularDependency(PName, Ploc, 248 PDecl->getLocation(), PDecl->getReferencedProtocols()); 249 } 250 } 251} 252 253Sema::DeclPtrTy 254Sema::ActOnStartProtocolInterface(SourceLocation AtProtoInterfaceLoc, 255 IdentifierInfo *ProtocolName, 256 SourceLocation ProtocolLoc, 257 const DeclPtrTy *ProtoRefs, 258 unsigned NumProtoRefs, 259 SourceLocation EndProtoLoc, 260 AttributeList *AttrList) { 261 // FIXME: Deal with AttrList. 262 assert(ProtocolName && "Missing protocol identifier"); 263 ObjCProtocolDecl *PDecl = LookupProtocol(ProtocolName); 264 if (PDecl) { 265 // Protocol already seen. Better be a forward protocol declaration 266 if (!PDecl->isForwardDecl()) { 267 Diag(ProtocolLoc, diag::warn_duplicate_protocol_def) << ProtocolName; 268 Diag(PDecl->getLocation(), diag::note_previous_definition); 269 // Just return the protocol we already had. 270 // FIXME: don't leak the objects passed in! 271 return DeclPtrTy::make(PDecl); 272 } 273 ObjCList<ObjCProtocolDecl> PList; 274 PList.set((ObjCProtocolDecl *const*)ProtoRefs, NumProtoRefs, Context); 275 CheckForwardProtocolDeclarationForCircularDependency( 276 ProtocolName, ProtocolLoc, PDecl->getLocation(), PList); 277 PList.Destroy(Context); 278 279 // Make sure the cached decl gets a valid start location. 280 PDecl->setLocation(AtProtoInterfaceLoc); 281 PDecl->setForwardDecl(false); 282 } else { 283 PDecl = ObjCProtocolDecl::Create(Context, CurContext, 284 AtProtoInterfaceLoc,ProtocolName); 285 PushOnScopeChains(PDecl, TUScope); 286 PDecl->setForwardDecl(false); 287 } 288 if (AttrList) 289 ProcessDeclAttributeList(TUScope, PDecl, AttrList); 290 if (NumProtoRefs) { 291 /// Check then save referenced protocols. 292 PDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs,Context); 293 PDecl->setLocEnd(EndProtoLoc); 294 } 295 296 CheckObjCDeclScope(PDecl); 297 return DeclPtrTy::make(PDecl); 298} 299 300/// FindProtocolDeclaration - This routine looks up protocols and 301/// issues an error if they are not declared. It returns list of 302/// protocol declarations in its 'Protocols' argument. 303void 304Sema::FindProtocolDeclaration(bool WarnOnDeclarations, 305 const IdentifierLocPair *ProtocolId, 306 unsigned NumProtocols, 307 llvm::SmallVectorImpl<DeclPtrTy> &Protocols) { 308 for (unsigned i = 0; i != NumProtocols; ++i) { 309 ObjCProtocolDecl *PDecl = LookupProtocol(ProtocolId[i].first); 310 if (!PDecl) { 311 Diag(ProtocolId[i].second, diag::err_undeclared_protocol) 312 << ProtocolId[i].first; 313 continue; 314 } 315 316 (void)DiagnoseUseOfDecl(PDecl, ProtocolId[i].second); 317 318 // If this is a forward declaration and we are supposed to warn in this 319 // case, do it. 320 if (WarnOnDeclarations && PDecl->isForwardDecl()) 321 Diag(ProtocolId[i].second, diag::warn_undef_protocolref) 322 << ProtocolId[i].first; 323 Protocols.push_back(DeclPtrTy::make(PDecl)); 324 } 325} 326 327/// DiagnosePropertyMismatch - Compares two properties for their 328/// attributes and types and warns on a variety of inconsistencies. 329/// 330void 331Sema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 332 ObjCPropertyDecl *SuperProperty, 333 const IdentifierInfo *inheritedName) { 334 ObjCPropertyDecl::PropertyAttributeKind CAttr = 335 Property->getPropertyAttributes(); 336 ObjCPropertyDecl::PropertyAttributeKind SAttr = 337 SuperProperty->getPropertyAttributes(); 338 if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 339 && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 340 Diag(Property->getLocation(), diag::warn_readonly_property) 341 << Property->getDeclName() << inheritedName; 342 if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 343 != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 344 Diag(Property->getLocation(), diag::warn_property_attribute) 345 << Property->getDeclName() << "copy" << inheritedName; 346 else if ((CAttr & ObjCPropertyDecl::OBJC_PR_retain) 347 != (SAttr & ObjCPropertyDecl::OBJC_PR_retain)) 348 Diag(Property->getLocation(), diag::warn_property_attribute) 349 << Property->getDeclName() << "retain" << inheritedName; 350 351 if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 352 != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 353 Diag(Property->getLocation(), diag::warn_property_attribute) 354 << Property->getDeclName() << "atomic" << inheritedName; 355 if (Property->getSetterName() != SuperProperty->getSetterName()) 356 Diag(Property->getLocation(), diag::warn_property_attribute) 357 << Property->getDeclName() << "setter" << inheritedName; 358 if (Property->getGetterName() != SuperProperty->getGetterName()) 359 Diag(Property->getLocation(), diag::warn_property_attribute) 360 << Property->getDeclName() << "getter" << inheritedName; 361 362 QualType LHSType = 363 Context.getCanonicalType(SuperProperty->getType()); 364 QualType RHSType = 365 Context.getCanonicalType(Property->getType()); 366 367 if (!Context.typesAreCompatible(LHSType, RHSType)) { 368 // FIXME: Incorporate this test with typesAreCompatible. 369 if (LHSType->isObjCQualifiedIdType() && RHSType->isObjCQualifiedIdType()) 370 if (Context.ObjCQualifiedIdTypesAreCompatible(LHSType, RHSType, false)) 371 return; 372 Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 373 << Property->getType() << SuperProperty->getType() << inheritedName; 374 } 375} 376 377/// ComparePropertiesInBaseAndSuper - This routine compares property 378/// declarations in base and its super class, if any, and issues 379/// diagnostics in a variety of inconsistant situations. 380/// 381void Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 382 ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 383 if (!SDecl) 384 return; 385 // FIXME: O(N^2) 386 for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 387 E = SDecl->prop_end(); S != E; ++S) { 388 ObjCPropertyDecl *SuperPDecl = (*S); 389 // Does property in super class has declaration in current class? 390 for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 391 E = IDecl->prop_end(); I != E; ++I) { 392 ObjCPropertyDecl *PDecl = (*I); 393 if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 394 DiagnosePropertyMismatch(PDecl, SuperPDecl, 395 SDecl->getIdentifier()); 396 } 397 } 398} 399 400/// MergeOneProtocolPropertiesIntoClass - This routine goes thru the list 401/// of properties declared in a protocol and adds them to the list 402/// of properties for current class/category if it is not there already. 403void 404Sema::MergeOneProtocolPropertiesIntoClass(Decl *CDecl, 405 ObjCProtocolDecl *PDecl) { 406 ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 407 if (!IDecl) { 408 // Category 409 ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 410 assert (CatDecl && "MergeOneProtocolPropertiesIntoClass"); 411 for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 412 E = PDecl->prop_end(); P != E; ++P) { 413 ObjCPropertyDecl *Pr = (*P); 414 ObjCCategoryDecl::prop_iterator CP, CE; 415 // Is this property already in category's list of properties? 416 for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP != CE; ++CP) 417 if ((*CP)->getIdentifier() == Pr->getIdentifier()) 418 break; 419 if (CP != CE) 420 // Property protocol already exist in class. Diagnose any mismatch. 421 DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 422 } 423 return; 424 } 425 for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 426 E = PDecl->prop_end(); P != E; ++P) { 427 ObjCPropertyDecl *Pr = (*P); 428 ObjCInterfaceDecl::prop_iterator CP, CE; 429 // Is this property already in class's list of properties? 430 for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 431 if ((*CP)->getIdentifier() == Pr->getIdentifier()) 432 break; 433 if (CP != CE) 434 // Property protocol already exist in class. Diagnose any mismatch. 435 DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 436 } 437} 438 439/// MergeProtocolPropertiesIntoClass - This routine merges properties 440/// declared in 'MergeItsProtocols' objects (which can be a class or an 441/// inherited protocol into the list of properties for class/category 'CDecl' 442/// 443void Sema::MergeProtocolPropertiesIntoClass(Decl *CDecl, 444 DeclPtrTy MergeItsProtocols) { 445 Decl *ClassDecl = MergeItsProtocols.getAs<Decl>(); 446 ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 447 448 if (!IDecl) { 449 // Category 450 ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 451 assert (CatDecl && "MergeProtocolPropertiesIntoClass"); 452 if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 453 for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 454 E = MDecl->protocol_end(); P != E; ++P) 455 // Merge properties of category (*P) into IDECL's 456 MergeOneProtocolPropertiesIntoClass(CatDecl, *P); 457 458 // Go thru the list of protocols for this category and recursively merge 459 // their properties into this class as well. 460 for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 461 E = CatDecl->protocol_end(); P != E; ++P) 462 MergeProtocolPropertiesIntoClass(CatDecl, DeclPtrTy::make(*P)); 463 } else { 464 ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 465 for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 466 E = MD->protocol_end(); P != E; ++P) 467 MergeOneProtocolPropertiesIntoClass(CatDecl, *P); 468 } 469 return; 470 } 471 472 if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 473 for (ObjCInterfaceDecl::protocol_iterator P = MDecl->protocol_begin(), 474 E = MDecl->protocol_end(); P != E; ++P) 475 // Merge properties of class (*P) into IDECL's 476 MergeOneProtocolPropertiesIntoClass(IDecl, *P); 477 478 // Go thru the list of protocols for this class and recursively merge 479 // their properties into this class as well. 480 for (ObjCInterfaceDecl::protocol_iterator P = IDecl->protocol_begin(), 481 E = IDecl->protocol_end(); P != E; ++P) 482 MergeProtocolPropertiesIntoClass(IDecl, DeclPtrTy::make(*P)); 483 } else { 484 ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 485 for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 486 E = MD->protocol_end(); P != E; ++P) 487 MergeOneProtocolPropertiesIntoClass(IDecl, *P); 488 } 489} 490 491/// DiagnoseClassExtensionDupMethods - Check for duplicate declaration of 492/// a class method in its extension. 493/// 494void Sema::DiagnoseClassExtensionDupMethods(ObjCCategoryDecl *CAT, 495 ObjCInterfaceDecl *ID) { 496 if (!ID) 497 return; // Possibly due to previous error 498 499 llvm::DenseMap<Selector, const ObjCMethodDecl*> MethodMap; 500 for (ObjCInterfaceDecl::method_iterator i = ID->meth_begin(), 501 e = ID->meth_end(); i != e; ++i) { 502 ObjCMethodDecl *MD = *i; 503 MethodMap[MD->getSelector()] = MD; 504 } 505 506 if (MethodMap.empty()) 507 return; 508 for (ObjCCategoryDecl::method_iterator i = CAT->meth_begin(), 509 e = CAT->meth_end(); i != e; ++i) { 510 ObjCMethodDecl *Method = *i; 511 const ObjCMethodDecl *&PrevMethod = MethodMap[Method->getSelector()]; 512 if (PrevMethod && !MatchTwoMethodDeclarations(Method, PrevMethod)) { 513 Diag(Method->getLocation(), diag::err_duplicate_method_decl) 514 << Method->getDeclName(); 515 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 516 } 517 } 518} 519 520/// ActOnForwardProtocolDeclaration - Handle @protocol foo; 521Action::DeclPtrTy 522Sema::ActOnForwardProtocolDeclaration(SourceLocation AtProtocolLoc, 523 const IdentifierLocPair *IdentList, 524 unsigned NumElts, 525 AttributeList *attrList) { 526 llvm::SmallVector<ObjCProtocolDecl*, 32> Protocols; 527 528 for (unsigned i = 0; i != NumElts; ++i) { 529 IdentifierInfo *Ident = IdentList[i].first; 530 ObjCProtocolDecl *PDecl = LookupProtocol(Ident); 531 if (PDecl == 0) { // Not already seen? 532 PDecl = ObjCProtocolDecl::Create(Context, CurContext, 533 IdentList[i].second, Ident); 534 PushOnScopeChains(PDecl, TUScope); 535 } 536 if (attrList) 537 ProcessDeclAttributeList(TUScope, PDecl, attrList); 538 Protocols.push_back(PDecl); 539 } 540 541 ObjCForwardProtocolDecl *PDecl = 542 ObjCForwardProtocolDecl::Create(Context, CurContext, AtProtocolLoc, 543 &Protocols[0], Protocols.size()); 544 CurContext->addDecl(PDecl); 545 CheckObjCDeclScope(PDecl); 546 return DeclPtrTy::make(PDecl); 547} 548 549Sema::DeclPtrTy Sema:: 550ActOnStartCategoryInterface(SourceLocation AtInterfaceLoc, 551 IdentifierInfo *ClassName, SourceLocation ClassLoc, 552 IdentifierInfo *CategoryName, 553 SourceLocation CategoryLoc, 554 const DeclPtrTy *ProtoRefs, 555 unsigned NumProtoRefs, 556 SourceLocation EndProtoLoc) { 557 ObjCCategoryDecl *CDecl = 558 ObjCCategoryDecl::Create(Context, CurContext, AtInterfaceLoc, CategoryName); 559 // FIXME: PushOnScopeChains? 560 CurContext->addDecl(CDecl); 561 562 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName); 563 /// Check that class of this category is already completely declared. 564 if (!IDecl || IDecl->isForwardDecl()) { 565 CDecl->setInvalidDecl(); 566 Diag(ClassLoc, diag::err_undef_interface) << ClassName; 567 return DeclPtrTy::make(CDecl); 568 } 569 570 CDecl->setClassInterface(IDecl); 571 572 // If the interface is deprecated, warn about it. 573 (void)DiagnoseUseOfDecl(IDecl, ClassLoc); 574 575 /// Check for duplicate interface declaration for this category 576 ObjCCategoryDecl *CDeclChain; 577 for (CDeclChain = IDecl->getCategoryList(); CDeclChain; 578 CDeclChain = CDeclChain->getNextClassCategory()) { 579 if (CategoryName && CDeclChain->getIdentifier() == CategoryName) { 580 Diag(CategoryLoc, diag::warn_dup_category_def) 581 << ClassName << CategoryName; 582 Diag(CDeclChain->getLocation(), diag::note_previous_definition); 583 break; 584 } 585 } 586 if (!CDeclChain) 587 CDecl->insertNextClassCategory(); 588 589 if (NumProtoRefs) { 590 CDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs,Context); 591 CDecl->setLocEnd(EndProtoLoc); 592 } 593 594 CheckObjCDeclScope(CDecl); 595 return DeclPtrTy::make(CDecl); 596} 597 598/// ActOnStartCategoryImplementation - Perform semantic checks on the 599/// category implementation declaration and build an ObjCCategoryImplDecl 600/// object. 601Sema::DeclPtrTy Sema::ActOnStartCategoryImplementation( 602 SourceLocation AtCatImplLoc, 603 IdentifierInfo *ClassName, SourceLocation ClassLoc, 604 IdentifierInfo *CatName, SourceLocation CatLoc) { 605 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName); 606 ObjCCategoryDecl *CatIDecl = 0; 607 if (IDecl) { 608 CatIDecl = IDecl->FindCategoryDeclaration(CatName); 609 if (!CatIDecl) { 610 // Category @implementation with no corresponding @interface. 611 // Create and install one. 612 CatIDecl = ObjCCategoryDecl::Create(Context, CurContext, SourceLocation(), 613 CatName); 614 CatIDecl->setClassInterface(IDecl); 615 CatIDecl->insertNextClassCategory(); 616 } 617 } 618 619 ObjCCategoryImplDecl *CDecl = 620 ObjCCategoryImplDecl::Create(Context, CurContext, AtCatImplLoc, CatName, 621 IDecl); 622 /// Check that class of this category is already completely declared. 623 if (!IDecl || IDecl->isForwardDecl()) 624 Diag(ClassLoc, diag::err_undef_interface) << ClassName; 625 626 // FIXME: PushOnScopeChains? 627 CurContext->addDecl(CDecl); 628 629 /// Check that CatName, category name, is not used in another implementation. 630 if (CatIDecl) { 631 if (CatIDecl->getImplementation()) { 632 Diag(ClassLoc, diag::err_dup_implementation_category) << ClassName 633 << CatName; 634 Diag(CatIDecl->getImplementation()->getLocation(), 635 diag::note_previous_definition); 636 } else 637 CatIDecl->setImplementation(CDecl); 638 } 639 640 CheckObjCDeclScope(CDecl); 641 return DeclPtrTy::make(CDecl); 642} 643 644Sema::DeclPtrTy Sema::ActOnStartClassImplementation( 645 SourceLocation AtClassImplLoc, 646 IdentifierInfo *ClassName, SourceLocation ClassLoc, 647 IdentifierInfo *SuperClassname, 648 SourceLocation SuperClassLoc) { 649 ObjCInterfaceDecl* IDecl = 0; 650 // Check for another declaration kind with the same name. 651 NamedDecl *PrevDecl = LookupName(TUScope, ClassName, LookupOrdinaryName); 652 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 653 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName; 654 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 655 } else { 656 // Is there an interface declaration of this class; if not, warn! 657 IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 658 if (!IDecl || IDecl->isForwardDecl()) { 659 Diag(ClassLoc, diag::warn_undef_interface) << ClassName; 660 IDecl = 0; 661 } 662 } 663 664 // Check that super class name is valid class name 665 ObjCInterfaceDecl* SDecl = 0; 666 if (SuperClassname) { 667 // Check if a different kind of symbol declared in this scope. 668 PrevDecl = LookupName(TUScope, SuperClassname, LookupOrdinaryName); 669 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 670 Diag(SuperClassLoc, diag::err_redefinition_different_kind) 671 << SuperClassname; 672 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 673 } else { 674 SDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 675 if (!SDecl) 676 Diag(SuperClassLoc, diag::err_undef_superclass) 677 << SuperClassname << ClassName; 678 else if (IDecl && IDecl->getSuperClass() != SDecl) { 679 // This implementation and its interface do not have the same 680 // super class. 681 Diag(SuperClassLoc, diag::err_conflicting_super_class) 682 << SDecl->getDeclName(); 683 Diag(SDecl->getLocation(), diag::note_previous_definition); 684 } 685 } 686 } 687 688 if (!IDecl) { 689 // Legacy case of @implementation with no corresponding @interface. 690 // Build, chain & install the interface decl into the identifier. 691 692 // FIXME: Do we support attributes on the @implementation? If so we should 693 // copy them over. 694 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtClassImplLoc, 695 ClassName, ClassLoc, false, true); 696 IDecl->setSuperClass(SDecl); 697 IDecl->setLocEnd(ClassLoc); 698 699 PushOnScopeChains(IDecl, TUScope); 700 } else { 701 // Mark the interface as being completed, even if it was just as 702 // @class ....; 703 // declaration; the user cannot reopen it. 704 IDecl->setForwardDecl(false); 705 } 706 707 ObjCImplementationDecl* IMPDecl = 708 ObjCImplementationDecl::Create(Context, CurContext, AtClassImplLoc, 709 IDecl, SDecl); 710 711 if (CheckObjCDeclScope(IMPDecl)) 712 return DeclPtrTy::make(IMPDecl); 713 714 // Check that there is no duplicate implementation of this class. 715 if (IDecl->getImplementation()) { 716 // FIXME: Don't leak everything! 717 Diag(ClassLoc, diag::err_dup_implementation_class) << ClassName; 718 Diag(IDecl->getImplementation()->getLocation(), 719 diag::note_previous_definition); 720 } else { // add it to the list. 721 IDecl->setImplementation(IMPDecl); 722 PushOnScopeChains(IMPDecl, TUScope); 723 } 724 return DeclPtrTy::make(IMPDecl); 725} 726 727void Sema::CheckImplementationIvars(ObjCImplementationDecl *ImpDecl, 728 ObjCIvarDecl **ivars, unsigned numIvars, 729 SourceLocation RBrace) { 730 assert(ImpDecl && "missing implementation decl"); 731 ObjCInterfaceDecl* IDecl = ImpDecl->getClassInterface(); 732 if (!IDecl) 733 return; 734 /// Check case of non-existing @interface decl. 735 /// (legacy objective-c @implementation decl without an @interface decl). 736 /// Add implementations's ivar to the synthesize class's ivar list. 737 if (IDecl->isImplicitInterfaceDecl()) { 738 IDecl->setIVarList(ivars, numIvars, Context); 739 IDecl->setLocEnd(RBrace); 740 return; 741 } 742 // If implementation has empty ivar list, just return. 743 if (numIvars == 0) 744 return; 745 746 assert(ivars && "missing @implementation ivars"); 747 748 // Check interface's Ivar list against those in the implementation. 749 // names and types must match. 750 // 751 unsigned j = 0; 752 ObjCInterfaceDecl::ivar_iterator 753 IVI = IDecl->ivar_begin(), IVE = IDecl->ivar_end(); 754 for (; numIvars > 0 && IVI != IVE; ++IVI) { 755 ObjCIvarDecl* ImplIvar = ivars[j++]; 756 ObjCIvarDecl* ClsIvar = *IVI; 757 assert (ImplIvar && "missing implementation ivar"); 758 assert (ClsIvar && "missing class ivar"); 759 760 // First, make sure the types match. 761 if (Context.getCanonicalType(ImplIvar->getType()) != 762 Context.getCanonicalType(ClsIvar->getType())) { 763 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_type) 764 << ImplIvar->getIdentifier() 765 << ImplIvar->getType() << ClsIvar->getType(); 766 Diag(ClsIvar->getLocation(), diag::note_previous_definition); 767 } else if (ImplIvar->isBitField() && ClsIvar->isBitField()) { 768 Expr *ImplBitWidth = ImplIvar->getBitWidth(); 769 Expr *ClsBitWidth = ClsIvar->getBitWidth(); 770 if (ImplBitWidth->EvaluateAsInt(Context).getZExtValue() != 771 ClsBitWidth->EvaluateAsInt(Context).getZExtValue()) { 772 Diag(ImplBitWidth->getLocStart(), diag::err_conflicting_ivar_bitwidth) 773 << ImplIvar->getIdentifier(); 774 Diag(ClsBitWidth->getLocStart(), diag::note_previous_definition); 775 } 776 } 777 // Make sure the names are identical. 778 if (ImplIvar->getIdentifier() != ClsIvar->getIdentifier()) { 779 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_name) 780 << ImplIvar->getIdentifier() << ClsIvar->getIdentifier(); 781 Diag(ClsIvar->getLocation(), diag::note_previous_definition); 782 } 783 --numIvars; 784 } 785 786 if (numIvars > 0) 787 Diag(ivars[j]->getLocation(), diag::err_inconsistant_ivar_count); 788 else if (IVI != IVE) 789 Diag((*IVI)->getLocation(), diag::err_inconsistant_ivar_count); 790} 791 792void Sema::WarnUndefinedMethod(SourceLocation ImpLoc, ObjCMethodDecl *method, 793 bool &IncompleteImpl) { 794 if (!IncompleteImpl) { 795 Diag(ImpLoc, diag::warn_incomplete_impl); 796 IncompleteImpl = true; 797 } 798 Diag(ImpLoc, diag::warn_undef_method_impl) << method->getDeclName(); 799} 800 801void Sema::WarnConflictingTypedMethods(ObjCMethodDecl *ImpMethodDecl, 802 ObjCMethodDecl *IntfMethodDecl) { 803 if (!Context.typesAreCompatible(IntfMethodDecl->getResultType(), 804 ImpMethodDecl->getResultType()) && 805 !Context.QualifiedIdConformsQualifiedId(IntfMethodDecl->getResultType(), 806 ImpMethodDecl->getResultType())) { 807 Diag(ImpMethodDecl->getLocation(), diag::warn_conflicting_ret_types) 808 << ImpMethodDecl->getDeclName() << IntfMethodDecl->getResultType() 809 << ImpMethodDecl->getResultType(); 810 Diag(IntfMethodDecl->getLocation(), diag::note_previous_definition); 811 } 812 813 for (ObjCMethodDecl::param_iterator IM = ImpMethodDecl->param_begin(), 814 IF = IntfMethodDecl->param_begin(), EM = ImpMethodDecl->param_end(); 815 IM != EM; ++IM, ++IF) { 816 if (Context.typesAreCompatible((*IF)->getType(), (*IM)->getType()) || 817 Context.QualifiedIdConformsQualifiedId((*IF)->getType(), 818 (*IM)->getType())) 819 continue; 820 821 Diag((*IM)->getLocation(), diag::warn_conflicting_param_types) 822 << ImpMethodDecl->getDeclName() << (*IF)->getType() 823 << (*IM)->getType(); 824 Diag((*IF)->getLocation(), diag::note_previous_definition); 825 } 826} 827 828/// isPropertyReadonly - Return true if property is readonly, by searching 829/// for the property in the class and in its categories and implementations 830/// 831bool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 832 ObjCInterfaceDecl *IDecl) { 833 // by far the most common case. 834 if (!PDecl->isReadOnly()) 835 return false; 836 // Even if property is ready only, if interface has a user defined setter, 837 // it is not considered read only. 838 if (IDecl->getInstanceMethod(PDecl->getSetterName())) 839 return false; 840 841 // Main class has the property as 'readonly'. Must search 842 // through the category list to see if the property's 843 // attribute has been over-ridden to 'readwrite'. 844 for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 845 Category; Category = Category->getNextClassCategory()) { 846 // Even if property is ready only, if a category has a user defined setter, 847 // it is not considered read only. 848 if (Category->getInstanceMethod(PDecl->getSetterName())) 849 return false; 850 ObjCPropertyDecl *P = 851 Category->FindPropertyDeclaration(PDecl->getIdentifier()); 852 if (P && !P->isReadOnly()) 853 return false; 854 } 855 856 // Also, check for definition of a setter method in the implementation if 857 // all else failed. 858 if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 859 if (ObjCImplementationDecl *IMD = 860 dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 861 if (IMD->getInstanceMethod(PDecl->getSetterName())) 862 return false; 863 } else if (ObjCCategoryImplDecl *CIMD = 864 dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 865 if (CIMD->getInstanceMethod(PDecl->getSetterName())) 866 return false; 867 } 868 } 869 // Lastly, look through the implementation (if one is in scope). 870 if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 871 if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 872 return false; 873 // If all fails, look at the super class. 874 if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 875 return isPropertyReadonly(PDecl, SIDecl); 876 return true; 877} 878 879/// FIXME: Type hierarchies in Objective-C can be deep. We could most likely 880/// improve the efficiency of selector lookups and type checking by associating 881/// with each protocol / interface / category the flattened instance tables. If 882/// we used an immutable set to keep the table then it wouldn't add significant 883/// memory cost and it would be handy for lookups. 884 885/// CheckProtocolMethodDefs - This routine checks unimplemented methods 886/// Declared in protocol, and those referenced by it. 887void Sema::CheckProtocolMethodDefs(SourceLocation ImpLoc, 888 ObjCProtocolDecl *PDecl, 889 bool& IncompleteImpl, 890 const llvm::DenseSet<Selector> &InsMap, 891 const llvm::DenseSet<Selector> &ClsMap, 892 ObjCInterfaceDecl *IDecl) { 893 ObjCInterfaceDecl *Super = IDecl->getSuperClass(); 894 ObjCInterfaceDecl *NSIDecl = 0; 895 if (getLangOptions().NeXTRuntime) { 896 // check to see if class implements forwardInvocation method and objects 897 // of this class are derived from 'NSProxy' so that to forward requests 898 // from one object to another. 899 // Under such conditions, which means that every method possible is 900 // implemented in the class, we should not issue "Method definition not 901 // found" warnings. 902 // FIXME: Use a general GetUnarySelector method for this. 903 IdentifierInfo* II = &Context.Idents.get("forwardInvocation"); 904 Selector fISelector = Context.Selectors.getSelector(1, &II); 905 if (InsMap.count(fISelector)) 906 // Is IDecl derived from 'NSProxy'? If so, no instance methods 907 // need be implemented in the implementation. 908 NSIDecl = IDecl->lookupInheritedClass(&Context.Idents.get("NSProxy")); 909 } 910 911 // If a method lookup fails locally we still need to look and see if 912 // the method was implemented by a base class or an inherited 913 // protocol. This lookup is slow, but occurs rarely in correct code 914 // and otherwise would terminate in a warning. 915 916 // check unimplemented instance methods. 917 if (!NSIDecl) 918 for (ObjCProtocolDecl::instmeth_iterator I = PDecl->instmeth_begin(), 919 E = PDecl->instmeth_end(); I != E; ++I) { 920 ObjCMethodDecl *method = *I; 921 if (method->getImplementationControl() != ObjCMethodDecl::Optional && 922 !method->isSynthesized() && !InsMap.count(method->getSelector()) && 923 (!Super || 924 !Super->lookupInstanceMethod(method->getSelector()))) { 925 // Ugly, but necessary. Method declared in protcol might have 926 // have been synthesized due to a property declared in the class which 927 // uses the protocol. 928 ObjCMethodDecl *MethodInClass = 929 IDecl->lookupInstanceMethod(method->getSelector()); 930 if (!MethodInClass || !MethodInClass->isSynthesized()) 931 WarnUndefinedMethod(ImpLoc, method, IncompleteImpl); 932 } 933 } 934 // check unimplemented class methods 935 for (ObjCProtocolDecl::classmeth_iterator 936 I = PDecl->classmeth_begin(), E = PDecl->classmeth_end(); 937 I != E; ++I) { 938 ObjCMethodDecl *method = *I; 939 if (method->getImplementationControl() != ObjCMethodDecl::Optional && 940 !ClsMap.count(method->getSelector()) && 941 (!Super || !Super->lookupClassMethod(method->getSelector()))) 942 WarnUndefinedMethod(ImpLoc, method, IncompleteImpl); 943 } 944 // Check on this protocols's referenced protocols, recursively. 945 for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 946 E = PDecl->protocol_end(); PI != E; ++PI) 947 CheckProtocolMethodDefs(ImpLoc, *PI, IncompleteImpl, InsMap, ClsMap, IDecl); 948} 949 950/// MatchAllMethodDeclarations - Check methods declaraed in interface or 951/// or protocol against those declared in their implementations. 952/// 953void Sema::MatchAllMethodDeclarations(const llvm::DenseSet<Selector> &InsMap, 954 const llvm::DenseSet<Selector> &ClsMap, 955 llvm::DenseSet<Selector> &InsMapSeen, 956 llvm::DenseSet<Selector> &ClsMapSeen, 957 ObjCImplDecl* IMPDecl, 958 ObjCContainerDecl* CDecl, 959 bool &IncompleteImpl, 960 bool ImmediateClass) { 961 // Check and see if instance methods in class interface have been 962 // implemented in the implementation class. If so, their types match. 963 for (ObjCInterfaceDecl::instmeth_iterator I = CDecl->instmeth_begin(), 964 E = CDecl->instmeth_end(); I != E; ++I) { 965 if (InsMapSeen.count((*I)->getSelector())) 966 continue; 967 InsMapSeen.insert((*I)->getSelector()); 968 if (!(*I)->isSynthesized() && 969 !InsMap.count((*I)->getSelector())) { 970 if (ImmediateClass) 971 WarnUndefinedMethod(IMPDecl->getLocation(), *I, IncompleteImpl); 972 continue; 973 } else { 974 ObjCMethodDecl *ImpMethodDecl = 975 IMPDecl->getInstanceMethod((*I)->getSelector()); 976 ObjCMethodDecl *IntfMethodDecl = 977 CDecl->getInstanceMethod((*I)->getSelector()); 978 assert(IntfMethodDecl && 979 "IntfMethodDecl is null in ImplMethodsVsClassMethods"); 980 // ImpMethodDecl may be null as in a @dynamic property. 981 if (ImpMethodDecl) 982 WarnConflictingTypedMethods(ImpMethodDecl, IntfMethodDecl); 983 } 984 } 985 986 // Check and see if class methods in class interface have been 987 // implemented in the implementation class. If so, their types match. 988 for (ObjCInterfaceDecl::classmeth_iterator 989 I = CDecl->classmeth_begin(), E = CDecl->classmeth_end(); I != E; ++I) { 990 if (ClsMapSeen.count((*I)->getSelector())) 991 continue; 992 ClsMapSeen.insert((*I)->getSelector()); 993 if (!ClsMap.count((*I)->getSelector())) { 994 if (ImmediateClass) 995 WarnUndefinedMethod(IMPDecl->getLocation(), *I, IncompleteImpl); 996 } else { 997 ObjCMethodDecl *ImpMethodDecl = 998 IMPDecl->getClassMethod((*I)->getSelector()); 999 ObjCMethodDecl *IntfMethodDecl = 1000 CDecl->getClassMethod((*I)->getSelector()); 1001 WarnConflictingTypedMethods(ImpMethodDecl, IntfMethodDecl); 1002 } 1003 } 1004 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) { 1005 // Check for any implementation of a methods declared in protocol. 1006 for (ObjCInterfaceDecl::protocol_iterator PI = I->protocol_begin(), 1007 E = I->protocol_end(); PI != E; ++PI) 1008 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 1009 IMPDecl, 1010 (*PI), IncompleteImpl, false); 1011 if (I->getSuperClass()) 1012 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 1013 IMPDecl, 1014 I->getSuperClass(), IncompleteImpl, false); 1015 } 1016} 1017 1018void Sema::ImplMethodsVsClassMethods(ObjCImplDecl* IMPDecl, 1019 ObjCContainerDecl* CDecl, 1020 bool IncompleteImpl) { 1021 llvm::DenseSet<Selector> InsMap; 1022 // Check and see if instance methods in class interface have been 1023 // implemented in the implementation class. 1024 for (ObjCImplementationDecl::instmeth_iterator 1025 I = IMPDecl->instmeth_begin(), E = IMPDecl->instmeth_end(); I!=E; ++I) 1026 InsMap.insert((*I)->getSelector()); 1027 1028 // Check and see if properties declared in the interface have either 1) 1029 // an implementation or 2) there is a @synthesize/@dynamic implementation 1030 // of the property in the @implementation. 1031 if (isa<ObjCInterfaceDecl>(CDecl)) 1032 for (ObjCContainerDecl::prop_iterator P = CDecl->prop_begin(), 1033 E = CDecl->prop_end(); P != E; ++P) { 1034 ObjCPropertyDecl *Prop = (*P); 1035 if (Prop->isInvalidDecl()) 1036 continue; 1037 ObjCPropertyImplDecl *PI = 0; 1038 // Is there a matching propery synthesize/dynamic? 1039 for (ObjCImplDecl::propimpl_iterator 1040 I = IMPDecl->propimpl_begin(), 1041 EI = IMPDecl->propimpl_end(); I != EI; ++I) 1042 if ((*I)->getPropertyDecl() == Prop) { 1043 PI = (*I); 1044 break; 1045 } 1046 if (PI) 1047 continue; 1048 if (!InsMap.count(Prop->getGetterName())) { 1049 Diag(Prop->getLocation(), 1050 diag::warn_setter_getter_impl_required) 1051 << Prop->getDeclName() << Prop->getGetterName(); 1052 Diag(IMPDecl->getLocation(), 1053 diag::note_property_impl_required); 1054 } 1055 1056 if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 1057 Diag(Prop->getLocation(), 1058 diag::warn_setter_getter_impl_required) 1059 << Prop->getDeclName() << Prop->getSetterName(); 1060 Diag(IMPDecl->getLocation(), 1061 diag::note_property_impl_required); 1062 } 1063 } 1064 1065 llvm::DenseSet<Selector> ClsMap; 1066 for (ObjCImplementationDecl::classmeth_iterator 1067 I = IMPDecl->classmeth_begin(), 1068 E = IMPDecl->classmeth_end(); I != E; ++I) 1069 ClsMap.insert((*I)->getSelector()); 1070 1071 // Check for type conflict of methods declared in a class/protocol and 1072 // its implementation; if any. 1073 llvm::DenseSet<Selector> InsMapSeen, ClsMapSeen; 1074 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 1075 IMPDecl, CDecl, 1076 IncompleteImpl, true); 1077 1078 // Check the protocol list for unimplemented methods in the @implementation 1079 // class. 1080 // Check and see if class methods in class interface have been 1081 // implemented in the implementation class. 1082 1083 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) { 1084 for (ObjCInterfaceDecl::protocol_iterator PI = I->protocol_begin(), 1085 E = I->protocol_end(); PI != E; ++PI) 1086 CheckProtocolMethodDefs(IMPDecl->getLocation(), *PI, IncompleteImpl, 1087 InsMap, ClsMap, I); 1088 // Check class extensions (unnamed categories) 1089 for (ObjCCategoryDecl *Categories = I->getCategoryList(); 1090 Categories; Categories = Categories->getNextClassCategory()) { 1091 if (!Categories->getIdentifier()) { 1092 ImplMethodsVsClassMethods(IMPDecl, Categories, IncompleteImpl); 1093 break; 1094 } 1095 } 1096 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl)) { 1097 for (ObjCCategoryDecl::protocol_iterator PI = C->protocol_begin(), 1098 E = C->protocol_end(); PI != E; ++PI) 1099 CheckProtocolMethodDefs(IMPDecl->getLocation(), *PI, IncompleteImpl, 1100 InsMap, ClsMap, C->getClassInterface()); 1101 } else 1102 assert(false && "invalid ObjCContainerDecl type."); 1103} 1104 1105/// ActOnForwardClassDeclaration - 1106Action::DeclPtrTy 1107Sema::ActOnForwardClassDeclaration(SourceLocation AtClassLoc, 1108 IdentifierInfo **IdentList, 1109 unsigned NumElts) { 1110 llvm::SmallVector<ObjCInterfaceDecl*, 32> Interfaces; 1111 1112 for (unsigned i = 0; i != NumElts; ++i) { 1113 // Check for another declaration kind with the same name. 1114 NamedDecl *PrevDecl = LookupName(TUScope, IdentList[i], LookupOrdinaryName); 1115 if (PrevDecl && PrevDecl->isTemplateParameter()) { 1116 // Maybe we will complain about the shadowed template parameter. 1117 DiagnoseTemplateParameterShadow(AtClassLoc, PrevDecl); 1118 // Just pretend that we didn't see the previous declaration. 1119 PrevDecl = 0; 1120 } 1121 1122 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 1123 // GCC apparently allows the following idiom: 1124 // 1125 // typedef NSObject < XCElementTogglerP > XCElementToggler; 1126 // @class XCElementToggler; 1127 // 1128 // FIXME: Make an extension? 1129 TypedefDecl *TDD = dyn_cast<TypedefDecl>(PrevDecl); 1130 if (!TDD || !isa<ObjCInterfaceType>(TDD->getUnderlyingType())) { 1131 Diag(AtClassLoc, diag::err_redefinition_different_kind) << IdentList[i]; 1132 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 1133 } else if (TDD) { 1134 // a forward class declaration matching a typedef name of a class refers 1135 // to the underlying class. 1136 if (ObjCInterfaceType * OI = 1137 dyn_cast<ObjCInterfaceType>(TDD->getUnderlyingType())) 1138 PrevDecl = OI->getDecl(); 1139 } 1140 } 1141 ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 1142 if (!IDecl) { // Not already seen? Make a forward decl. 1143 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtClassLoc, 1144 IdentList[i], SourceLocation(), true); 1145 PushOnScopeChains(IDecl, TUScope); 1146 } 1147 1148 Interfaces.push_back(IDecl); 1149 } 1150 1151 ObjCClassDecl *CDecl = ObjCClassDecl::Create(Context, CurContext, AtClassLoc, 1152 &Interfaces[0], 1153 Interfaces.size()); 1154 CurContext->addDecl(CDecl); 1155 CheckObjCDeclScope(CDecl); 1156 return DeclPtrTy::make(CDecl); 1157} 1158 1159 1160/// MatchTwoMethodDeclarations - Checks that two methods have matching type and 1161/// returns true, or false, accordingly. 1162/// TODO: Handle protocol list; such as id<p1,p2> in type comparisons 1163bool Sema::MatchTwoMethodDeclarations(const ObjCMethodDecl *Method, 1164 const ObjCMethodDecl *PrevMethod, 1165 bool matchBasedOnSizeAndAlignment) { 1166 QualType T1 = Context.getCanonicalType(Method->getResultType()); 1167 QualType T2 = Context.getCanonicalType(PrevMethod->getResultType()); 1168 1169 if (T1 != T2) { 1170 // The result types are different. 1171 if (!matchBasedOnSizeAndAlignment) 1172 return false; 1173 // Incomplete types don't have a size and alignment. 1174 if (T1->isIncompleteType() || T2->isIncompleteType()) 1175 return false; 1176 // Check is based on size and alignment. 1177 if (Context.getTypeInfo(T1) != Context.getTypeInfo(T2)) 1178 return false; 1179 } 1180 1181 ObjCMethodDecl::param_iterator ParamI = Method->param_begin(), 1182 E = Method->param_end(); 1183 ObjCMethodDecl::param_iterator PrevI = PrevMethod->param_begin(); 1184 1185 for (; ParamI != E; ++ParamI, ++PrevI) { 1186 assert(PrevI != PrevMethod->param_end() && "Param mismatch"); 1187 T1 = Context.getCanonicalType((*ParamI)->getType()); 1188 T2 = Context.getCanonicalType((*PrevI)->getType()); 1189 if (T1 != T2) { 1190 // The result types are different. 1191 if (!matchBasedOnSizeAndAlignment) 1192 return false; 1193 // Incomplete types don't have a size and alignment. 1194 if (T1->isIncompleteType() || T2->isIncompleteType()) 1195 return false; 1196 // Check is based on size and alignment. 1197 if (Context.getTypeInfo(T1) != Context.getTypeInfo(T2)) 1198 return false; 1199 } 1200 } 1201 return true; 1202} 1203 1204/// \brief Read the contents of the instance and factory method pools 1205/// for a given selector from external storage. 1206/// 1207/// This routine should only be called once, when neither the instance 1208/// nor the factory method pool has an entry for this selector. 1209Sema::MethodPool::iterator Sema::ReadMethodPool(Selector Sel, 1210 bool isInstance) { 1211 assert(ExternalSource && "We need an external AST source"); 1212 assert(InstanceMethodPool.find(Sel) == InstanceMethodPool.end() && 1213 "Selector data already loaded into the instance method pool"); 1214 assert(FactoryMethodPool.find(Sel) == FactoryMethodPool.end() && 1215 "Selector data already loaded into the factory method pool"); 1216 1217 // Read the method list from the external source. 1218 std::pair<ObjCMethodList, ObjCMethodList> Methods 1219 = ExternalSource->ReadMethodPool(Sel); 1220 1221 if (isInstance) { 1222 if (Methods.second.Method) 1223 FactoryMethodPool[Sel] = Methods.second; 1224 return InstanceMethodPool.insert(std::make_pair(Sel, Methods.first)).first; 1225 } 1226 1227 if (Methods.first.Method) 1228 InstanceMethodPool[Sel] = Methods.first; 1229 1230 return FactoryMethodPool.insert(std::make_pair(Sel, Methods.second)).first; 1231} 1232 1233void Sema::AddInstanceMethodToGlobalPool(ObjCMethodDecl *Method) { 1234 llvm::DenseMap<Selector, ObjCMethodList>::iterator Pos 1235 = InstanceMethodPool.find(Method->getSelector()); 1236 if (Pos == InstanceMethodPool.end()) { 1237 if (ExternalSource && !FactoryMethodPool.count(Method->getSelector())) 1238 Pos = ReadMethodPool(Method->getSelector(), /*isInstance=*/true); 1239 else 1240 Pos = InstanceMethodPool.insert(std::make_pair(Method->getSelector(), 1241 ObjCMethodList())).first; 1242 } 1243 1244 ObjCMethodList &Entry = Pos->second; 1245 if (Entry.Method == 0) { 1246 // Haven't seen a method with this selector name yet - add it. 1247 Entry.Method = Method; 1248 Entry.Next = 0; 1249 return; 1250 } 1251 1252 // We've seen a method with this name, see if we have already seen this type 1253 // signature. 1254 for (ObjCMethodList *List = &Entry; List; List = List->Next) 1255 if (MatchTwoMethodDeclarations(Method, List->Method)) 1256 return; 1257 1258 // We have a new signature for an existing method - add it. 1259 // This is extremely rare. Only 1% of Cocoa selectors are "overloaded". 1260 Entry.Next = new ObjCMethodList(Method, Entry.Next); 1261} 1262 1263// FIXME: Finish implementing -Wno-strict-selector-match. 1264ObjCMethodDecl *Sema::LookupInstanceMethodInGlobalPool(Selector Sel, 1265 SourceRange R, 1266 bool warn) { 1267 llvm::DenseMap<Selector, ObjCMethodList>::iterator Pos 1268 = InstanceMethodPool.find(Sel); 1269 if (Pos == InstanceMethodPool.end()) { 1270 if (ExternalSource && !FactoryMethodPool.count(Sel)) 1271 Pos = ReadMethodPool(Sel, /*isInstance=*/true); 1272 else 1273 return 0; 1274 } 1275 1276 ObjCMethodList &MethList = Pos->second; 1277 bool issueWarning = false; 1278 1279 if (MethList.Method && MethList.Next) { 1280 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) 1281 // This checks if the methods differ by size & alignment. 1282 if (!MatchTwoMethodDeclarations(MethList.Method, Next->Method, true)) 1283 issueWarning = warn; 1284 } 1285 if (issueWarning && (MethList.Method && MethList.Next)) { 1286 Diag(R.getBegin(), diag::warn_multiple_method_decl) << Sel << R; 1287 Diag(MethList.Method->getLocStart(), diag::note_using_decl) 1288 << MethList.Method->getSourceRange(); 1289 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) 1290 Diag(Next->Method->getLocStart(), diag::note_also_found_decl) 1291 << Next->Method->getSourceRange(); 1292 } 1293 return MethList.Method; 1294} 1295 1296void Sema::AddFactoryMethodToGlobalPool(ObjCMethodDecl *Method) { 1297 llvm::DenseMap<Selector, ObjCMethodList>::iterator Pos 1298 = FactoryMethodPool.find(Method->getSelector()); 1299 if (Pos == FactoryMethodPool.end()) { 1300 if (ExternalSource && !InstanceMethodPool.count(Method->getSelector())) 1301 Pos = ReadMethodPool(Method->getSelector(), /*isInstance=*/false); 1302 else 1303 Pos = FactoryMethodPool.insert(std::make_pair(Method->getSelector(), 1304 ObjCMethodList())).first; 1305 } 1306 1307 ObjCMethodList &FirstMethod = Pos->second; 1308 if (!FirstMethod.Method) { 1309 // Haven't seen a method with this selector name yet - add it. 1310 FirstMethod.Method = Method; 1311 FirstMethod.Next = 0; 1312 } else { 1313 // We've seen a method with this name, now check the type signature(s). 1314 bool match = MatchTwoMethodDeclarations(Method, FirstMethod.Method); 1315 1316 for (ObjCMethodList *Next = FirstMethod.Next; !match && Next; 1317 Next = Next->Next) 1318 match = MatchTwoMethodDeclarations(Method, Next->Method); 1319 1320 if (!match) { 1321 // We have a new signature for an existing method - add it. 1322 // This is extremely rare. Only 1% of Cocoa selectors are "overloaded". 1323 struct ObjCMethodList *OMI = new ObjCMethodList(Method, FirstMethod.Next); 1324 FirstMethod.Next = OMI; 1325 } 1326 } 1327} 1328 1329ObjCMethodDecl *Sema::LookupFactoryMethodInGlobalPool(Selector Sel, 1330 SourceRange R) { 1331 llvm::DenseMap<Selector, ObjCMethodList>::iterator Pos 1332 = FactoryMethodPool.find(Sel); 1333 if (Pos == FactoryMethodPool.end()) { 1334 if (ExternalSource && !InstanceMethodPool.count(Sel)) 1335 Pos = ReadMethodPool(Sel, /*isInstance=*/false); 1336 else 1337 return 0; 1338 } 1339 1340 ObjCMethodList &MethList = Pos->second; 1341 bool issueWarning = false; 1342 1343 if (MethList.Method && MethList.Next) { 1344 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) 1345 // This checks if the methods differ by size & alignment. 1346 if (!MatchTwoMethodDeclarations(MethList.Method, Next->Method, true)) 1347 issueWarning = true; 1348 } 1349 if (issueWarning && (MethList.Method && MethList.Next)) { 1350 Diag(R.getBegin(), diag::warn_multiple_method_decl) << Sel << R; 1351 Diag(MethList.Method->getLocStart(), diag::note_using_decl) 1352 << MethList.Method->getSourceRange(); 1353 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) 1354 Diag(Next->Method->getLocStart(), diag::note_also_found_decl) 1355 << Next->Method->getSourceRange(); 1356 } 1357 return MethList.Method; 1358} 1359 1360/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 1361/// have the property type and issue diagnostics if they don't. 1362/// Also synthesize a getter/setter method if none exist (and update the 1363/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 1364/// methods is the "right" thing to do. 1365void Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 1366 ObjCContainerDecl *CD) { 1367 ObjCMethodDecl *GetterMethod, *SetterMethod; 1368 1369 GetterMethod = CD->getInstanceMethod(property->getGetterName()); 1370 SetterMethod = CD->getInstanceMethod(property->getSetterName()); 1371 DiagnosePropertyAccessorMismatch(property, GetterMethod, 1372 property->getLocation()); 1373 1374 if (SetterMethod) { 1375 if (Context.getCanonicalType(SetterMethod->getResultType()) 1376 != Context.VoidTy) 1377 Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 1378 if (SetterMethod->param_size() != 1 || 1379 ((*SetterMethod->param_begin())->getType() != property->getType())) { 1380 Diag(property->getLocation(), 1381 diag::warn_accessor_property_type_mismatch) 1382 << property->getDeclName() 1383 << SetterMethod->getSelector(); 1384 Diag(SetterMethod->getLocation(), diag::note_declared_at); 1385 } 1386 } 1387 1388 // Synthesize getter/setter methods if none exist. 1389 // Find the default getter and if one not found, add one. 1390 // FIXME: The synthesized property we set here is misleading. We almost always 1391 // synthesize these methods unless the user explicitly provided prototypes 1392 // (which is odd, but allowed). Sema should be typechecking that the 1393 // declarations jive in that situation (which it is not currently). 1394 if (!GetterMethod) { 1395 // No instance method of same name as property getter name was found. 1396 // Declare a getter method and add it to the list of methods 1397 // for this class. 1398 GetterMethod = ObjCMethodDecl::Create(Context, property->getLocation(), 1399 property->getLocation(), property->getGetterName(), 1400 property->getType(), CD, true, false, true, 1401 (property->getPropertyImplementation() == 1402 ObjCPropertyDecl::Optional) ? 1403 ObjCMethodDecl::Optional : 1404 ObjCMethodDecl::Required); 1405 CD->addDecl(GetterMethod); 1406 } else 1407 // A user declared getter will be synthesize when @synthesize of 1408 // the property with the same name is seen in the @implementation 1409 GetterMethod->setSynthesized(true); 1410 property->setGetterMethodDecl(GetterMethod); 1411 1412 // Skip setter if property is read-only. 1413 if (!property->isReadOnly()) { 1414 // Find the default setter and if one not found, add one. 1415 if (!SetterMethod) { 1416 // No instance method of same name as property setter name was found. 1417 // Declare a setter method and add it to the list of methods 1418 // for this class. 1419 SetterMethod = ObjCMethodDecl::Create(Context, property->getLocation(), 1420 property->getLocation(), 1421 property->getSetterName(), 1422 Context.VoidTy, CD, true, false, true, 1423 (property->getPropertyImplementation() == 1424 ObjCPropertyDecl::Optional) ? 1425 ObjCMethodDecl::Optional : 1426 ObjCMethodDecl::Required); 1427 // Invent the arguments for the setter. We don't bother making a 1428 // nice name for the argument. 1429 ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 1430 property->getLocation(), 1431 property->getIdentifier(), 1432 property->getType(), 1433 /*DInfo=*/0, 1434 VarDecl::None, 1435 0); 1436 SetterMethod->setMethodParams(Context, &Argument, 1); 1437 CD->addDecl(SetterMethod); 1438 } else 1439 // A user declared setter will be synthesize when @synthesize of 1440 // the property with the same name is seen in the @implementation 1441 SetterMethod->setSynthesized(true); 1442 property->setSetterMethodDecl(SetterMethod); 1443 } 1444 // Add any synthesized methods to the global pool. This allows us to 1445 // handle the following, which is supported by GCC (and part of the design). 1446 // 1447 // @interface Foo 1448 // @property double bar; 1449 // @end 1450 // 1451 // void thisIsUnfortunate() { 1452 // id foo; 1453 // double bar = [foo bar]; 1454 // } 1455 // 1456 if (GetterMethod) 1457 AddInstanceMethodToGlobalPool(GetterMethod); 1458 if (SetterMethod) 1459 AddInstanceMethodToGlobalPool(SetterMethod); 1460} 1461 1462/// CompareMethodParamsInBaseAndSuper - This routine compares methods with 1463/// identical selector names in current and its super classes and issues 1464/// a warning if any of their argument types are incompatible. 1465void Sema::CompareMethodParamsInBaseAndSuper(Decl *ClassDecl, 1466 ObjCMethodDecl *Method, 1467 bool IsInstance) { 1468 ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(ClassDecl); 1469 if (ID == 0) return; 1470 1471 while (ObjCInterfaceDecl *SD = ID->getSuperClass()) { 1472 ObjCMethodDecl *SuperMethodDecl = 1473 SD->lookupMethod(Method->getSelector(), IsInstance); 1474 if (SuperMethodDecl == 0) { 1475 ID = SD; 1476 continue; 1477 } 1478 ObjCMethodDecl::param_iterator ParamI = Method->param_begin(), 1479 E = Method->param_end(); 1480 ObjCMethodDecl::param_iterator PrevI = SuperMethodDecl->param_begin(); 1481 for (; ParamI != E; ++ParamI, ++PrevI) { 1482 // Number of parameters are the same and is guaranteed by selector match. 1483 assert(PrevI != SuperMethodDecl->param_end() && "Param mismatch"); 1484 QualType T1 = Context.getCanonicalType((*ParamI)->getType()); 1485 QualType T2 = Context.getCanonicalType((*PrevI)->getType()); 1486 // If type of arguement of method in this class does not match its 1487 // respective argument type in the super class method, issue warning; 1488 if (!Context.typesAreCompatible(T1, T2)) { 1489 Diag((*ParamI)->getLocation(), diag::ext_typecheck_base_super) 1490 << T1 << T2; 1491 Diag(SuperMethodDecl->getLocation(), diag::note_previous_declaration); 1492 return; 1493 } 1494 } 1495 ID = SD; 1496 } 1497} 1498 1499// Note: For class/category implemenations, allMethods/allProperties is 1500// always null. 1501void Sema::ActOnAtEnd(SourceLocation AtEndLoc, DeclPtrTy classDecl, 1502 DeclPtrTy *allMethods, unsigned allNum, 1503 DeclPtrTy *allProperties, unsigned pNum, 1504 DeclGroupPtrTy *allTUVars, unsigned tuvNum) { 1505 Decl *ClassDecl = classDecl.getAs<Decl>(); 1506 1507 // FIXME: If we don't have a ClassDecl, we have an error. We should consider 1508 // always passing in a decl. If the decl has an error, isInvalidDecl() 1509 // should be true. 1510 if (!ClassDecl) 1511 return; 1512 1513 bool isInterfaceDeclKind = 1514 isa<ObjCInterfaceDecl>(ClassDecl) || isa<ObjCCategoryDecl>(ClassDecl) 1515 || isa<ObjCProtocolDecl>(ClassDecl); 1516 bool checkIdenticalMethods = isa<ObjCImplementationDecl>(ClassDecl); 1517 1518 DeclContext *DC = dyn_cast<DeclContext>(ClassDecl); 1519 1520 // FIXME: Remove these and use the ObjCContainerDecl/DeclContext. 1521 llvm::DenseMap<Selector, const ObjCMethodDecl*> InsMap; 1522 llvm::DenseMap<Selector, const ObjCMethodDecl*> ClsMap; 1523 1524 for (unsigned i = 0; i < allNum; i++ ) { 1525 ObjCMethodDecl *Method = 1526 cast_or_null<ObjCMethodDecl>(allMethods[i].getAs<Decl>()); 1527 1528 if (!Method) continue; // Already issued a diagnostic. 1529 if (Method->isInstanceMethod()) { 1530 /// Check for instance method of the same name with incompatible types 1531 const ObjCMethodDecl *&PrevMethod = InsMap[Method->getSelector()]; 1532 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod) 1533 : false; 1534 if ((isInterfaceDeclKind && PrevMethod && !match) 1535 || (checkIdenticalMethods && match)) { 1536 Diag(Method->getLocation(), diag::err_duplicate_method_decl) 1537 << Method->getDeclName(); 1538 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 1539 } else { 1540 DC->addDecl(Method); 1541 InsMap[Method->getSelector()] = Method; 1542 /// The following allows us to typecheck messages to "id". 1543 AddInstanceMethodToGlobalPool(Method); 1544 // verify that the instance method conforms to the same definition of 1545 // parent methods if it shadows one. 1546 CompareMethodParamsInBaseAndSuper(ClassDecl, Method, true); 1547 } 1548 } else { 1549 /// Check for class method of the same name with incompatible types 1550 const ObjCMethodDecl *&PrevMethod = ClsMap[Method->getSelector()]; 1551 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod) 1552 : false; 1553 if ((isInterfaceDeclKind && PrevMethod && !match) 1554 || (checkIdenticalMethods && match)) { 1555 Diag(Method->getLocation(), diag::err_duplicate_method_decl) 1556 << Method->getDeclName(); 1557 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 1558 } else { 1559 DC->addDecl(Method); 1560 ClsMap[Method->getSelector()] = Method; 1561 /// The following allows us to typecheck messages to "Class". 1562 AddFactoryMethodToGlobalPool(Method); 1563 // verify that the class method conforms to the same definition of 1564 // parent methods if it shadows one. 1565 CompareMethodParamsInBaseAndSuper(ClassDecl, Method, false); 1566 } 1567 } 1568 } 1569 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 1570 // Compares properties declared in this class to those of its 1571 // super class. 1572 ComparePropertiesInBaseAndSuper(I); 1573 MergeProtocolPropertiesIntoClass(I, DeclPtrTy::make(I)); 1574 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 1575 // Categories are used to extend the class by declaring new methods. 1576 // By the same token, they are also used to add new properties. No 1577 // need to compare the added property to those in the class. 1578 1579 // Merge protocol properties into category 1580 MergeProtocolPropertiesIntoClass(C, DeclPtrTy::make(C)); 1581 if (C->getIdentifier() == 0) 1582 DiagnoseClassExtensionDupMethods(C, C->getClassInterface()); 1583 } 1584 if (ObjCContainerDecl *CDecl = dyn_cast<ObjCContainerDecl>(ClassDecl)) { 1585 // ProcessPropertyDecl is responsible for diagnosing conflicts with any 1586 // user-defined setter/getter. It also synthesizes setter/getter methods 1587 // and adds them to the DeclContext and global method pools. 1588 for (ObjCContainerDecl::prop_iterator I = CDecl->prop_begin(), 1589 E = CDecl->prop_end(); 1590 I != E; ++I) 1591 ProcessPropertyDecl(*I, CDecl); 1592 CDecl->setAtEndLoc(AtEndLoc); 1593 } 1594 if (ObjCImplementationDecl *IC=dyn_cast<ObjCImplementationDecl>(ClassDecl)) { 1595 IC->setAtEndLoc(AtEndLoc); 1596 if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) 1597 ImplMethodsVsClassMethods(IC, IDecl); 1598 } else if (ObjCCategoryImplDecl* CatImplClass = 1599 dyn_cast<ObjCCategoryImplDecl>(ClassDecl)) { 1600 CatImplClass->setAtEndLoc(AtEndLoc); 1601 1602 // Find category interface decl and then check that all methods declared 1603 // in this interface are implemented in the category @implementation. 1604 if (ObjCInterfaceDecl* IDecl = CatImplClass->getClassInterface()) { 1605 for (ObjCCategoryDecl *Categories = IDecl->getCategoryList(); 1606 Categories; Categories = Categories->getNextClassCategory()) { 1607 if (Categories->getIdentifier() == CatImplClass->getIdentifier()) { 1608 ImplMethodsVsClassMethods(CatImplClass, Categories); 1609 break; 1610 } 1611 } 1612 } 1613 } 1614 if (isInterfaceDeclKind) { 1615 // Reject invalid vardecls. 1616 for (unsigned i = 0; i != tuvNum; i++) { 1617 DeclGroupRef DG = allTUVars[i].getAsVal<DeclGroupRef>(); 1618 for (DeclGroupRef::iterator I = DG.begin(), E = DG.end(); I != E; ++I) 1619 if (VarDecl *VDecl = dyn_cast<VarDecl>(*I)) { 1620 if (!VDecl->hasExternalStorage()) 1621 Diag(VDecl->getLocation(), diag::err_objc_var_decl_inclass); 1622 } 1623 } 1624 } 1625} 1626 1627 1628/// CvtQTToAstBitMask - utility routine to produce an AST bitmask for 1629/// objective-c's type qualifier from the parser version of the same info. 1630static Decl::ObjCDeclQualifier 1631CvtQTToAstBitMask(ObjCDeclSpec::ObjCDeclQualifier PQTVal) { 1632 Decl::ObjCDeclQualifier ret = Decl::OBJC_TQ_None; 1633 if (PQTVal & ObjCDeclSpec::DQ_In) 1634 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_In); 1635 if (PQTVal & ObjCDeclSpec::DQ_Inout) 1636 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Inout); 1637 if (PQTVal & ObjCDeclSpec::DQ_Out) 1638 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Out); 1639 if (PQTVal & ObjCDeclSpec::DQ_Bycopy) 1640 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Bycopy); 1641 if (PQTVal & ObjCDeclSpec::DQ_Byref) 1642 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Byref); 1643 if (PQTVal & ObjCDeclSpec::DQ_Oneway) 1644 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Oneway); 1645 1646 return ret; 1647} 1648 1649Sema::DeclPtrTy Sema::ActOnMethodDeclaration( 1650 SourceLocation MethodLoc, SourceLocation EndLoc, 1651 tok::TokenKind MethodType, DeclPtrTy classDecl, 1652 ObjCDeclSpec &ReturnQT, TypeTy *ReturnType, 1653 Selector Sel, 1654 // optional arguments. The number of types/arguments is obtained 1655 // from the Sel.getNumArgs(). 1656 ObjCArgInfo *ArgInfo, 1657 llvm::SmallVectorImpl<Declarator> &Cdecls, 1658 AttributeList *AttrList, tok::ObjCKeywordKind MethodDeclKind, 1659 bool isVariadic) { 1660 Decl *ClassDecl = classDecl.getAs<Decl>(); 1661 1662 // Make sure we can establish a context for the method. 1663 if (!ClassDecl) { 1664 Diag(MethodLoc, diag::error_missing_method_context); 1665 FunctionLabelMap.clear(); 1666 return DeclPtrTy(); 1667 } 1668 QualType resultDeclType; 1669 1670 if (ReturnType) { 1671 resultDeclType = GetTypeFromParser(ReturnType); 1672 1673 // Methods cannot return interface types. All ObjC objects are 1674 // passed by reference. 1675 if (resultDeclType->isObjCInterfaceType()) { 1676 Diag(MethodLoc, diag::err_object_cannot_be_passed_returned_by_value) 1677 << 0 << resultDeclType; 1678 return DeclPtrTy(); 1679 } 1680 } else // get the type for "id". 1681 resultDeclType = Context.getObjCIdType(); 1682 1683 ObjCMethodDecl* ObjCMethod = 1684 ObjCMethodDecl::Create(Context, MethodLoc, EndLoc, Sel, resultDeclType, 1685 cast<DeclContext>(ClassDecl), 1686 MethodType == tok::minus, isVariadic, 1687 false, 1688 MethodDeclKind == tok::objc_optional ? 1689 ObjCMethodDecl::Optional : 1690 ObjCMethodDecl::Required); 1691 1692 llvm::SmallVector<ParmVarDecl*, 16> Params; 1693 1694 for (unsigned i = 0, e = Sel.getNumArgs(); i != e; ++i) { 1695 QualType ArgType, UnpromotedArgType; 1696 1697 if (ArgInfo[i].Type == 0) { 1698 UnpromotedArgType = ArgType = Context.getObjCIdType(); 1699 } else { 1700 UnpromotedArgType = ArgType = GetTypeFromParser(ArgInfo[i].Type); 1701 // Perform the default array/function conversions (C99 6.7.5.3p[7,8]). 1702 ArgType = adjustParameterType(ArgType); 1703 } 1704 1705 ParmVarDecl* Param; 1706 if (ArgType == UnpromotedArgType) 1707 Param = ParmVarDecl::Create(Context, ObjCMethod, ArgInfo[i].NameLoc, 1708 ArgInfo[i].Name, ArgType, 1709 /*DInfo=*/0, //FIXME: Pass info here. 1710 VarDecl::None, 0); 1711 else 1712 Param = OriginalParmVarDecl::Create(Context, ObjCMethod, 1713 ArgInfo[i].NameLoc, 1714 ArgInfo[i].Name, ArgType, 1715 /*DInfo=*/0, //FIXME: Pass info here. 1716 UnpromotedArgType, 1717 VarDecl::None, 0); 1718 1719 if (ArgType->isObjCInterfaceType()) { 1720 Diag(ArgInfo[i].NameLoc, 1721 diag::err_object_cannot_be_passed_returned_by_value) 1722 << 1 << ArgType; 1723 Param->setInvalidDecl(); 1724 } 1725 1726 Param->setObjCDeclQualifier( 1727 CvtQTToAstBitMask(ArgInfo[i].DeclSpec.getObjCDeclQualifier())); 1728 1729 // Apply the attributes to the parameter. 1730 ProcessDeclAttributeList(TUScope, Param, ArgInfo[i].ArgAttrs); 1731 1732 Params.push_back(Param); 1733 } 1734 1735 ObjCMethod->setMethodParams(Context, Params.data(), Sel.getNumArgs()); 1736 ObjCMethod->setObjCDeclQualifier( 1737 CvtQTToAstBitMask(ReturnQT.getObjCDeclQualifier())); 1738 const ObjCMethodDecl *PrevMethod = 0; 1739 1740 if (AttrList) 1741 ProcessDeclAttributeList(TUScope, ObjCMethod, AttrList); 1742 1743 // For implementations (which can be very "coarse grain"), we add the 1744 // method now. This allows the AST to implement lookup methods that work 1745 // incrementally (without waiting until we parse the @end). It also allows 1746 // us to flag multiple declaration errors as they occur. 1747 if (ObjCImplementationDecl *ImpDecl = 1748 dyn_cast<ObjCImplementationDecl>(ClassDecl)) { 1749 if (MethodType == tok::minus) { 1750 PrevMethod = ImpDecl->getInstanceMethod(Sel); 1751 ImpDecl->addInstanceMethod(ObjCMethod); 1752 } else { 1753 PrevMethod = ImpDecl->getClassMethod(Sel); 1754 ImpDecl->addClassMethod(ObjCMethod); 1755 } 1756 if (AttrList) 1757 Diag(EndLoc, diag::warn_attribute_method_def); 1758 } else if (ObjCCategoryImplDecl *CatImpDecl = 1759 dyn_cast<ObjCCategoryImplDecl>(ClassDecl)) { 1760 if (MethodType == tok::minus) { 1761 PrevMethod = CatImpDecl->getInstanceMethod(Sel); 1762 CatImpDecl->addInstanceMethod(ObjCMethod); 1763 } else { 1764 PrevMethod = CatImpDecl->getClassMethod(Sel); 1765 CatImpDecl->addClassMethod(ObjCMethod); 1766 } 1767 if (AttrList) 1768 Diag(EndLoc, diag::warn_attribute_method_def); 1769 } 1770 if (PrevMethod) { 1771 // You can never have two method definitions with the same name. 1772 Diag(ObjCMethod->getLocation(), diag::err_duplicate_method_decl) 1773 << ObjCMethod->getDeclName(); 1774 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 1775 } 1776 return DeclPtrTy::make(ObjCMethod); 1777} 1778 1779void Sema::CheckObjCPropertyAttributes(QualType PropertyTy, 1780 SourceLocation Loc, 1781 unsigned &Attributes) { 1782 // FIXME: Improve the reported location. 1783 1784 // readonly and readwrite/assign/retain/copy conflict. 1785 if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 1786 (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 1787 ObjCDeclSpec::DQ_PR_assign | 1788 ObjCDeclSpec::DQ_PR_copy | 1789 ObjCDeclSpec::DQ_PR_retain))) { 1790 const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 1791 "readwrite" : 1792 (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 1793 "assign" : 1794 (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 1795 "copy" : "retain"; 1796 1797 Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 1798 diag::err_objc_property_attr_mutually_exclusive : 1799 diag::warn_objc_property_attr_mutually_exclusive) 1800 << "readonly" << which; 1801 } 1802 1803 // Check for copy or retain on non-object types. 1804 if ((Attributes & (ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain)) && 1805 !PropertyTy->isObjCObjectPointerType() && 1806 !PropertyTy->isBlockPointerType() && 1807 !Context.isObjCNSObjectType(PropertyTy)) { 1808 Diag(Loc, diag::err_objc_property_requires_object) 1809 << (Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain"); 1810 Attributes &= ~(ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain); 1811 } 1812 1813 // Check for more than one of { assign, copy, retain }. 1814 if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 1815 if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 1816 Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1817 << "assign" << "copy"; 1818 Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 1819 } 1820 if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 1821 Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1822 << "assign" << "retain"; 1823 Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 1824 } 1825 } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 1826 if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 1827 Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1828 << "copy" << "retain"; 1829 Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 1830 } 1831 } 1832 1833 // Warn if user supplied no assignment attribute, property is 1834 // readwrite, and this is an object type. 1835 if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 1836 ObjCDeclSpec::DQ_PR_retain)) && 1837 !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 1838 PropertyTy->isObjCObjectPointerType()) { 1839 // Skip this warning in gc-only mode. 1840 if (getLangOptions().getGCMode() != LangOptions::GCOnly) 1841 Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 1842 1843 // If non-gc code warn that this is likely inappropriate. 1844 if (getLangOptions().getGCMode() == LangOptions::NonGC) 1845 Diag(Loc, diag::warn_objc_property_default_assign_on_object); 1846 1847 // FIXME: Implement warning dependent on NSCopying being 1848 // implemented. See also: 1849 // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 1850 // (please trim this list while you are at it). 1851 } 1852 1853 if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 1854 && getLangOptions().getGCMode() == LangOptions::GCOnly 1855 && PropertyTy->isBlockPointerType()) 1856 Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 1857} 1858 1859Sema::DeclPtrTy Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 1860 FieldDeclarator &FD, 1861 ObjCDeclSpec &ODS, 1862 Selector GetterSel, 1863 Selector SetterSel, 1864 DeclPtrTy ClassCategory, 1865 bool *isOverridingProperty, 1866 tok::ObjCKeywordKind MethodImplKind) { 1867 unsigned Attributes = ODS.getPropertyAttributes(); 1868 bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 1869 // default is readwrite! 1870 !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 1871 // property is defaulted to 'assign' if it is readwrite and is 1872 // not retain or copy 1873 bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 1874 (isReadWrite && 1875 !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 1876 !(Attributes & ObjCDeclSpec::DQ_PR_copy))); 1877 QualType T = GetTypeForDeclarator(FD.D, S); 1878 Decl *ClassDecl = ClassCategory.getAs<Decl>(); 1879 ObjCInterfaceDecl *CCPrimary = 0; // continuation class's primary class 1880 // May modify Attributes. 1881 CheckObjCPropertyAttributes(T, AtLoc, Attributes); 1882 if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 1883 if (!CDecl->getIdentifier()) { 1884 // This is a continuation class. property requires special 1885 // handling. 1886 if ((CCPrimary = CDecl->getClassInterface())) { 1887 // Find the property in continuation class's primary class only. 1888 ObjCPropertyDecl *PIDecl = 0; 1889 IdentifierInfo *PropertyId = FD.D.getIdentifier(); 1890 for (ObjCInterfaceDecl::prop_iterator 1891 I = CCPrimary->prop_begin(), E = CCPrimary->prop_end(); 1892 I != E; ++I) 1893 if ((*I)->getIdentifier() == PropertyId) { 1894 PIDecl = *I; 1895 break; 1896 } 1897 1898 if (PIDecl) { 1899 // property 'PIDecl's readonly attribute will be over-ridden 1900 // with continuation class's readwrite property attribute! 1901 unsigned PIkind = PIDecl->getPropertyAttributes(); 1902 if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 1903 if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) != 1904 (PIkind & ObjCPropertyDecl::OBJC_PR_nonatomic)) 1905 Diag(AtLoc, diag::warn_property_attr_mismatch); 1906 PIDecl->makeitReadWriteAttribute(); 1907 if (Attributes & ObjCDeclSpec::DQ_PR_retain) 1908 PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 1909 if (Attributes & ObjCDeclSpec::DQ_PR_copy) 1910 PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 1911 PIDecl->setSetterName(SetterSel); 1912 } else 1913 Diag(AtLoc, diag::err_use_continuation_class) 1914 << CCPrimary->getDeclName(); 1915 *isOverridingProperty = true; 1916 // Make sure setter decl is synthesized, and added to primary 1917 // class's list. 1918 ProcessPropertyDecl(PIDecl, CCPrimary); 1919 return DeclPtrTy(); 1920 } 1921 // No matching property found in the primary class. Just fall thru 1922 // and add property to continuation class's primary class. 1923 ClassDecl = CCPrimary; 1924 } else { 1925 Diag(CDecl->getLocation(), diag::err_continuation_class); 1926 *isOverridingProperty = true; 1927 return DeclPtrTy(); 1928 } 1929 } 1930 1931 // Issue a warning if property is 'assign' as default and its object, which is 1932 // gc'able conforms to NSCopying protocol 1933 if (getLangOptions().getGCMode() != LangOptions::NonGC && 1934 isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 1935 if (T->isObjCObjectPointerType()) { 1936 QualType InterfaceTy = T->getPointeeType(); 1937 if (const ObjCInterfaceType *OIT = 1938 InterfaceTy->getAsObjCInterfaceType()) { 1939 ObjCInterfaceDecl *IDecl = OIT->getDecl(); 1940 if (IDecl) 1941 if (ObjCProtocolDecl* PNSCopying = 1942 LookupProtocol(&Context.Idents.get("NSCopying"))) 1943 if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 1944 Diag(AtLoc, diag::warn_implements_nscopying) 1945 << FD.D.getIdentifier(); 1946 } 1947 } 1948 if (T->isObjCInterfaceType()) 1949 Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 1950 1951 DeclContext *DC = dyn_cast<DeclContext>(ClassDecl); 1952 assert(DC && "ClassDecl is not a DeclContext"); 1953 ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 1954 FD.D.getIdentifierLoc(), 1955 FD.D.getIdentifier(), T); 1956 DC->addDecl(PDecl); 1957 1958 if (T->isArrayType() || T->isFunctionType()) { 1959 Diag(AtLoc, diag::err_property_type) << T; 1960 PDecl->setInvalidDecl(); 1961 } 1962 1963 ProcessDeclAttributes(S, PDecl, FD.D); 1964 1965 // Regardless of setter/getter attribute, we save the default getter/setter 1966 // selector names in anticipation of declaration of setter/getter methods. 1967 PDecl->setGetterName(GetterSel); 1968 PDecl->setSetterName(SetterSel); 1969 1970 if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 1971 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 1972 1973 if (Attributes & ObjCDeclSpec::DQ_PR_getter) 1974 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 1975 1976 if (Attributes & ObjCDeclSpec::DQ_PR_setter) 1977 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 1978 1979 if (isReadWrite) 1980 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 1981 1982 if (Attributes & ObjCDeclSpec::DQ_PR_retain) 1983 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 1984 1985 if (Attributes & ObjCDeclSpec::DQ_PR_copy) 1986 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 1987 1988 if (isAssign) 1989 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 1990 1991 if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 1992 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 1993 1994 if (MethodImplKind == tok::objc_required) 1995 PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 1996 else if (MethodImplKind == tok::objc_optional) 1997 PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 1998 // A case of continuation class adding a new property in the class. This 1999 // is not what it was meant for. However, gcc supports it and so should we. 2000 // Make sure setter/getters are declared here. 2001 if (CCPrimary) 2002 ProcessPropertyDecl(PDecl, CCPrimary); 2003 2004 return DeclPtrTy::make(PDecl); 2005} 2006 2007/// ActOnPropertyImplDecl - This routine performs semantic checks and 2008/// builds the AST node for a property implementation declaration; declared 2009/// as @synthesize or @dynamic. 2010/// 2011Sema::DeclPtrTy Sema::ActOnPropertyImplDecl(SourceLocation AtLoc, 2012 SourceLocation PropertyLoc, 2013 bool Synthesize, 2014 DeclPtrTy ClassCatImpDecl, 2015 IdentifierInfo *PropertyId, 2016 IdentifierInfo *PropertyIvar) { 2017 Decl *ClassImpDecl = ClassCatImpDecl.getAs<Decl>(); 2018 // Make sure we have a context for the property implementation declaration. 2019 if (!ClassImpDecl) { 2020 Diag(AtLoc, diag::error_missing_property_context); 2021 return DeclPtrTy(); 2022 } 2023 ObjCPropertyDecl *property = 0; 2024 ObjCInterfaceDecl* IDecl = 0; 2025 // Find the class or category class where this property must have 2026 // a declaration. 2027 ObjCImplementationDecl *IC = 0; 2028 ObjCCategoryImplDecl* CatImplClass = 0; 2029 if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 2030 IDecl = IC->getClassInterface(); 2031 // We always synthesize an interface for an implementation 2032 // without an interface decl. So, IDecl is always non-zero. 2033 assert(IDecl && 2034 "ActOnPropertyImplDecl - @implementation without @interface"); 2035 2036 // Look for this property declaration in the @implementation's @interface 2037 property = IDecl->FindPropertyDeclaration(PropertyId); 2038 if (!property) { 2039 Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 2040 return DeclPtrTy(); 2041 } 2042 } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 2043 if (Synthesize) { 2044 Diag(AtLoc, diag::error_synthesize_category_decl); 2045 return DeclPtrTy(); 2046 } 2047 IDecl = CatImplClass->getClassInterface(); 2048 if (!IDecl) { 2049 Diag(AtLoc, diag::error_missing_property_interface); 2050 return DeclPtrTy(); 2051 } 2052 ObjCCategoryDecl *Category = 2053 IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 2054 2055 // If category for this implementation not found, it is an error which 2056 // has already been reported eralier. 2057 if (!Category) 2058 return DeclPtrTy(); 2059 // Look for this property declaration in @implementation's category 2060 property = Category->FindPropertyDeclaration(PropertyId); 2061 if (!property) { 2062 Diag(PropertyLoc, diag::error_bad_category_property_decl) 2063 << Category->getDeclName(); 2064 return DeclPtrTy(); 2065 } 2066 } else { 2067 Diag(AtLoc, diag::error_bad_property_context); 2068 return DeclPtrTy(); 2069 } 2070 ObjCIvarDecl *Ivar = 0; 2071 // Check that we have a valid, previously declared ivar for @synthesize 2072 if (Synthesize) { 2073 // @synthesize 2074 if (!PropertyIvar) 2075 PropertyIvar = PropertyId; 2076 QualType PropType = Context.getCanonicalType(property->getType()); 2077 // Check that this is a previously declared 'ivar' in 'IDecl' interface 2078 ObjCInterfaceDecl *ClassDeclared; 2079 Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 2080 if (!Ivar) { 2081 DeclContext *EnclosingContext = cast_or_null<DeclContext>(IDecl); 2082 assert(EnclosingContext && 2083 "null DeclContext for synthesized ivar - ActOnPropertyImplDecl"); 2084 Ivar = ObjCIvarDecl::Create(Context, EnclosingContext, PropertyLoc, 2085 PropertyIvar, PropType, /*Dinfo=*/0, 2086 ObjCIvarDecl::Public, 2087 (Expr *)0); 2088 Ivar->setLexicalDeclContext(IDecl); 2089 IDecl->addDecl(Ivar); 2090 property->setPropertyIvarDecl(Ivar); 2091 if (!getLangOptions().ObjCNonFragileABI) 2092 Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId; 2093 // Note! I deliberately want it to fall thru so, we have a 2094 // a property implementation and to avoid future warnings. 2095 } else if (getLangOptions().ObjCNonFragileABI && 2096 ClassDeclared != IDecl) { 2097 Diag(PropertyLoc, diag::error_ivar_in_superclass_use) 2098 << property->getDeclName() << Ivar->getDeclName() 2099 << ClassDeclared->getDeclName(); 2100 Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 2101 << Ivar << Ivar->getNameAsCString(); 2102 // Note! I deliberately want it to fall thru so more errors are caught. 2103 } 2104 QualType IvarType = Context.getCanonicalType(Ivar->getType()); 2105 2106 // Check that type of property and its ivar are type compatible. 2107 if (PropType != IvarType) { 2108 if (CheckAssignmentConstraints(PropType, IvarType) != Compatible) { 2109 Diag(PropertyLoc, diag::error_property_ivar_type) 2110 << property->getDeclName() << Ivar->getDeclName(); 2111 // Note! I deliberately want it to fall thru so, we have a 2112 // a property implementation and to avoid future warnings. 2113 } 2114 2115 // FIXME! Rules for properties are somewhat different that those 2116 // for assignments. Use a new routine to consolidate all cases; 2117 // specifically for property redeclarations as well as for ivars. 2118 QualType lhsType =Context.getCanonicalType(PropType).getUnqualifiedType(); 2119 QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 2120 if (lhsType != rhsType && 2121 lhsType->isArithmeticType()) { 2122 Diag(PropertyLoc, diag::error_property_ivar_type) 2123 << property->getDeclName() << Ivar->getDeclName(); 2124 // Fall thru - see previous comment 2125 } 2126 // __weak is explicit. So it works on Canonical type. 2127 if (PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 2128 getLangOptions().getGCMode() != LangOptions::NonGC) { 2129 Diag(PropertyLoc, diag::error_weak_property) 2130 << property->getDeclName() << Ivar->getDeclName(); 2131 // Fall thru - see previous comment 2132 } 2133 if ((property->getType()->isObjCObjectPointerType() || 2134 PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 2135 getLangOptions().getGCMode() != LangOptions::NonGC) { 2136 Diag(PropertyLoc, diag::error_strong_property) 2137 << property->getDeclName() << Ivar->getDeclName(); 2138 // Fall thru - see previous comment 2139 } 2140 } 2141 } else if (PropertyIvar) 2142 // @dynamic 2143 Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl); 2144 assert (property && "ActOnPropertyImplDecl - property declaration missing"); 2145 ObjCPropertyImplDecl *PIDecl = 2146 ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 2147 property, 2148 (Synthesize ? 2149 ObjCPropertyImplDecl::Synthesize 2150 : ObjCPropertyImplDecl::Dynamic), 2151 Ivar); 2152 if (IC) { 2153 if (Synthesize) 2154 if (ObjCPropertyImplDecl *PPIDecl = 2155 IC->FindPropertyImplIvarDecl(PropertyIvar)) { 2156 Diag(PropertyLoc, diag::error_duplicate_ivar_use) 2157 << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 2158 << PropertyIvar; 2159 Diag(PPIDecl->getLocation(), diag::note_previous_use); 2160 } 2161 2162 if (ObjCPropertyImplDecl *PPIDecl 2163 = IC->FindPropertyImplDecl(PropertyId)) { 2164 Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 2165 Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 2166 return DeclPtrTy(); 2167 } 2168 IC->addPropertyImplementation(PIDecl); 2169 } else { 2170 if (Synthesize) 2171 if (ObjCPropertyImplDecl *PPIDecl = 2172 CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 2173 Diag(PropertyLoc, diag::error_duplicate_ivar_use) 2174 << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 2175 << PropertyIvar; 2176 Diag(PPIDecl->getLocation(), diag::note_previous_use); 2177 } 2178 2179 if (ObjCPropertyImplDecl *PPIDecl = 2180 CatImplClass->FindPropertyImplDecl(PropertyId)) { 2181 Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 2182 Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 2183 return DeclPtrTy(); 2184 } 2185 CatImplClass->addPropertyImplementation(PIDecl); 2186 } 2187 2188 return DeclPtrTy::make(PIDecl); 2189} 2190 2191bool Sema::CheckObjCDeclScope(Decl *D) { 2192 if (isa<TranslationUnitDecl>(CurContext->getLookupContext())) 2193 return false; 2194 2195 Diag(D->getLocation(), diag::err_objc_decls_may_only_appear_in_global_scope); 2196 D->setInvalidDecl(); 2197 2198 return true; 2199} 2200 2201/// Called whenever @defs(ClassName) is encountered in the source. Inserts the 2202/// instance variables of ClassName into Decls. 2203void Sema::ActOnDefs(Scope *S, DeclPtrTy TagD, SourceLocation DeclStart, 2204 IdentifierInfo *ClassName, 2205 llvm::SmallVectorImpl<DeclPtrTy> &Decls) { 2206 // Check that ClassName is a valid class 2207 ObjCInterfaceDecl *Class = getObjCInterfaceDecl(ClassName); 2208 if (!Class) { 2209 Diag(DeclStart, diag::err_undef_interface) << ClassName; 2210 return; 2211 } 2212 if (LangOpts.ObjCNonFragileABI) { 2213 Diag(DeclStart, diag::err_atdef_nonfragile_interface); 2214 return; 2215 } 2216 2217 // Collect the instance variables 2218 llvm::SmallVector<FieldDecl*, 32> RecFields; 2219 Context.CollectObjCIvars(Class, RecFields); 2220 // For each ivar, create a fresh ObjCAtDefsFieldDecl. 2221 for (unsigned i = 0; i < RecFields.size(); i++) { 2222 FieldDecl* ID = RecFields[i]; 2223 RecordDecl *Record = dyn_cast<RecordDecl>(TagD.getAs<Decl>()); 2224 Decl *FD = ObjCAtDefsFieldDecl::Create(Context, Record, ID->getLocation(), 2225 ID->getIdentifier(), ID->getType(), 2226 ID->getBitWidth()); 2227 Decls.push_back(Sema::DeclPtrTy::make(FD)); 2228 } 2229 2230 // Introduce all of these fields into the appropriate scope. 2231 for (llvm::SmallVectorImpl<DeclPtrTy>::iterator D = Decls.begin(); 2232 D != Decls.end(); ++D) { 2233 FieldDecl *FD = cast<FieldDecl>(D->getAs<Decl>()); 2234 if (getLangOptions().CPlusPlus) 2235 PushOnScopeChains(cast<FieldDecl>(FD), S); 2236 else if (RecordDecl *Record = dyn_cast<RecordDecl>(TagD.getAs<Decl>())) 2237 Record->addDecl(FD); 2238 } 2239} 2240 2241