SemaDeclObjC.cpp revision f29f9cddd965d4a78164fa569ea49a7d2ce71f70
1//===--- SemaDeclObjC.cpp - Semantic Analysis for ObjC Declarations -------===// 2// 3// The LLVM Compiler Infrastructure 4// 5// This file is distributed under the University of Illinois Open Source 6// License. See LICENSE.TXT for details. 7// 8//===----------------------------------------------------------------------===// 9// 10// This file implements semantic analysis for Objective C declarations. 11// 12//===----------------------------------------------------------------------===// 13 14#include "Sema.h" 15#include "Lookup.h" 16#include "clang/Sema/ExternalSemaSource.h" 17#include "clang/AST/Expr.h" 18#include "clang/AST/ASTContext.h" 19#include "clang/AST/DeclObjC.h" 20#include "clang/Parse/DeclSpec.h" 21using namespace clang; 22 23bool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 24 ObjCMethodDecl *GetterMethod, 25 SourceLocation Loc) { 26 if (GetterMethod && 27 GetterMethod->getResultType() != property->getType()) { 28 AssignConvertType result = Incompatible; 29 if (property->getType()->isObjCObjectPointerType()) 30 result = CheckAssignmentConstraints(GetterMethod->getResultType(), property->getType()); 31 if (result != Compatible) { 32 Diag(Loc, diag::warn_accessor_property_type_mismatch) 33 << property->getDeclName() 34 << GetterMethod->getSelector(); 35 Diag(GetterMethod->getLocation(), diag::note_declared_at); 36 return true; 37 } 38 } 39 return false; 40} 41 42/// ActOnStartOfObjCMethodDef - This routine sets up parameters; invisible 43/// and user declared, in the method definition's AST. 44void Sema::ActOnStartOfObjCMethodDef(Scope *FnBodyScope, DeclPtrTy D) { 45 assert(getCurMethodDecl() == 0 && "Method parsing confused"); 46 ObjCMethodDecl *MDecl = dyn_cast_or_null<ObjCMethodDecl>(D.getAs<Decl>()); 47 48 // If we don't have a valid method decl, simply return. 49 if (!MDecl) 50 return; 51 52 CurFunctionNeedsScopeChecking = false; 53 54 // Allow the rest of sema to find private method decl implementations. 55 if (MDecl->isInstanceMethod()) 56 AddInstanceMethodToGlobalPool(MDecl); 57 else 58 AddFactoryMethodToGlobalPool(MDecl); 59 60 // Allow all of Sema to see that we are entering a method definition. 61 PushDeclContext(FnBodyScope, MDecl); 62 63 // Create Decl objects for each parameter, entrring them in the scope for 64 // binding to their use. 65 66 // Insert the invisible arguments, self and _cmd! 67 MDecl->createImplicitParams(Context, MDecl->getClassInterface()); 68 69 PushOnScopeChains(MDecl->getSelfDecl(), FnBodyScope); 70 PushOnScopeChains(MDecl->getCmdDecl(), FnBodyScope); 71 72 // Introduce all of the other parameters into this scope. 73 for (ObjCMethodDecl::param_iterator PI = MDecl->param_begin(), 74 E = MDecl->param_end(); PI != E; ++PI) 75 if ((*PI)->getIdentifier()) 76 PushOnScopeChains(*PI, FnBodyScope); 77} 78 79Sema::DeclPtrTy Sema:: 80ActOnStartClassInterface(SourceLocation AtInterfaceLoc, 81 IdentifierInfo *ClassName, SourceLocation ClassLoc, 82 IdentifierInfo *SuperName, SourceLocation SuperLoc, 83 const DeclPtrTy *ProtoRefs, unsigned NumProtoRefs, 84 const SourceLocation *ProtoLocs, 85 SourceLocation EndProtoLoc, AttributeList *AttrList) { 86 assert(ClassName && "Missing class identifier"); 87 88 // Check for another declaration kind with the same name. 89 NamedDecl *PrevDecl = LookupSingleName(TUScope, ClassName, LookupOrdinaryName); 90 if (PrevDecl && PrevDecl->isTemplateParameter()) { 91 // Maybe we will complain about the shadowed template parameter. 92 DiagnoseTemplateParameterShadow(ClassLoc, PrevDecl); 93 // Just pretend that we didn't see the previous declaration. 94 PrevDecl = 0; 95 } 96 97 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 98 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName; 99 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 100 } 101 102 ObjCInterfaceDecl* IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 103 if (IDecl) { 104 // Class already seen. Is it a forward declaration? 105 if (!IDecl->isForwardDecl()) { 106 IDecl->setInvalidDecl(); 107 Diag(AtInterfaceLoc, diag::err_duplicate_class_def)<<IDecl->getDeclName(); 108 Diag(IDecl->getLocation(), diag::note_previous_definition); 109 110 // Return the previous class interface. 111 // FIXME: don't leak the objects passed in! 112 return DeclPtrTy::make(IDecl); 113 } else { 114 IDecl->setLocation(AtInterfaceLoc); 115 IDecl->setForwardDecl(false); 116 IDecl->setClassLoc(ClassLoc); 117 118 // Since this ObjCInterfaceDecl was created by a forward declaration, 119 // we now add it to the DeclContext since it wasn't added before 120 // (see ActOnForwardClassDeclaration). 121 CurContext->addDecl(IDecl); 122 123 if (AttrList) 124 ProcessDeclAttributeList(TUScope, IDecl, AttrList); 125 } 126 } else { 127 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtInterfaceLoc, 128 ClassName, ClassLoc); 129 if (AttrList) 130 ProcessDeclAttributeList(TUScope, IDecl, AttrList); 131 132 PushOnScopeChains(IDecl, TUScope); 133 } 134 135 if (SuperName) { 136 // Check if a different kind of symbol declared in this scope. 137 PrevDecl = LookupSingleName(TUScope, SuperName, LookupOrdinaryName); 138 139 if (!PrevDecl) { 140 // Try to correct for a typo in the superclass name. 141 LookupResult R(*this, SuperName, SuperLoc, LookupOrdinaryName); 142 if (CorrectTypo(R, TUScope, 0) && 143 (PrevDecl = R.getAsSingle<ObjCInterfaceDecl>())) { 144 Diag(SuperLoc, diag::err_undef_superclass_suggest) 145 << SuperName << ClassName << PrevDecl->getDeclName(); 146 Diag(PrevDecl->getLocation(), diag::note_previous_decl) 147 << PrevDecl->getDeclName(); 148 } 149 } 150 151 if (PrevDecl == IDecl) { 152 Diag(SuperLoc, diag::err_recursive_superclass) 153 << SuperName << ClassName << SourceRange(AtInterfaceLoc, ClassLoc); 154 IDecl->setLocEnd(ClassLoc); 155 } else { 156 ObjCInterfaceDecl *SuperClassDecl = 157 dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 158 159 // Diagnose classes that inherit from deprecated classes. 160 if (SuperClassDecl) 161 (void)DiagnoseUseOfDecl(SuperClassDecl, SuperLoc); 162 163 if (PrevDecl && SuperClassDecl == 0) { 164 // The previous declaration was not a class decl. Check if we have a 165 // typedef. If we do, get the underlying class type. 166 if (const TypedefDecl *TDecl = dyn_cast_or_null<TypedefDecl>(PrevDecl)) { 167 QualType T = TDecl->getUnderlyingType(); 168 if (T->isObjCInterfaceType()) { 169 if (NamedDecl *IDecl = T->getAs<ObjCInterfaceType>()->getDecl()) 170 SuperClassDecl = dyn_cast<ObjCInterfaceDecl>(IDecl); 171 } 172 } 173 174 // This handles the following case: 175 // 176 // typedef int SuperClass; 177 // @interface MyClass : SuperClass {} @end 178 // 179 if (!SuperClassDecl) { 180 Diag(SuperLoc, diag::err_redefinition_different_kind) << SuperName; 181 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 182 } 183 } 184 185 if (!dyn_cast_or_null<TypedefDecl>(PrevDecl)) { 186 if (!SuperClassDecl) 187 Diag(SuperLoc, diag::err_undef_superclass) 188 << SuperName << ClassName << SourceRange(AtInterfaceLoc, ClassLoc); 189 else if (SuperClassDecl->isForwardDecl()) 190 Diag(SuperLoc, diag::err_undef_superclass) 191 << SuperClassDecl->getDeclName() << ClassName 192 << SourceRange(AtInterfaceLoc, ClassLoc); 193 } 194 IDecl->setSuperClass(SuperClassDecl); 195 IDecl->setSuperClassLoc(SuperLoc); 196 IDecl->setLocEnd(SuperLoc); 197 } 198 } else { // we have a root class. 199 IDecl->setLocEnd(ClassLoc); 200 } 201 202 /// Check then save referenced protocols. 203 if (NumProtoRefs) { 204 IDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs, 205 ProtoLocs, Context); 206 IDecl->setLocEnd(EndProtoLoc); 207 } 208 209 CheckObjCDeclScope(IDecl); 210 return DeclPtrTy::make(IDecl); 211} 212 213/// ActOnCompatiblityAlias - this action is called after complete parsing of 214/// @compatibility_alias declaration. It sets up the alias relationships. 215Sema::DeclPtrTy Sema::ActOnCompatiblityAlias(SourceLocation AtLoc, 216 IdentifierInfo *AliasName, 217 SourceLocation AliasLocation, 218 IdentifierInfo *ClassName, 219 SourceLocation ClassLocation) { 220 // Look for previous declaration of alias name 221 NamedDecl *ADecl = LookupSingleName(TUScope, AliasName, LookupOrdinaryName); 222 if (ADecl) { 223 if (isa<ObjCCompatibleAliasDecl>(ADecl)) 224 Diag(AliasLocation, diag::warn_previous_alias_decl); 225 else 226 Diag(AliasLocation, diag::err_conflicting_aliasing_type) << AliasName; 227 Diag(ADecl->getLocation(), diag::note_previous_declaration); 228 return DeclPtrTy(); 229 } 230 // Check for class declaration 231 NamedDecl *CDeclU = LookupSingleName(TUScope, ClassName, LookupOrdinaryName); 232 if (const TypedefDecl *TDecl = dyn_cast_or_null<TypedefDecl>(CDeclU)) { 233 QualType T = TDecl->getUnderlyingType(); 234 if (T->isObjCInterfaceType()) { 235 if (NamedDecl *IDecl = T->getAs<ObjCInterfaceType>()->getDecl()) { 236 ClassName = IDecl->getIdentifier(); 237 CDeclU = LookupSingleName(TUScope, ClassName, LookupOrdinaryName); 238 } 239 } 240 } 241 ObjCInterfaceDecl *CDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDeclU); 242 if (CDecl == 0) { 243 Diag(ClassLocation, diag::warn_undef_interface) << ClassName; 244 if (CDeclU) 245 Diag(CDeclU->getLocation(), diag::note_previous_declaration); 246 return DeclPtrTy(); 247 } 248 249 // Everything checked out, instantiate a new alias declaration AST. 250 ObjCCompatibleAliasDecl *AliasDecl = 251 ObjCCompatibleAliasDecl::Create(Context, CurContext, AtLoc, AliasName, CDecl); 252 253 if (!CheckObjCDeclScope(AliasDecl)) 254 PushOnScopeChains(AliasDecl, TUScope); 255 256 return DeclPtrTy::make(AliasDecl); 257} 258 259void Sema::CheckForwardProtocolDeclarationForCircularDependency( 260 IdentifierInfo *PName, 261 SourceLocation &Ploc, SourceLocation PrevLoc, 262 const ObjCList<ObjCProtocolDecl> &PList) { 263 for (ObjCList<ObjCProtocolDecl>::iterator I = PList.begin(), 264 E = PList.end(); I != E; ++I) { 265 266 if (ObjCProtocolDecl *PDecl = LookupProtocol((*I)->getIdentifier())) { 267 if (PDecl->getIdentifier() == PName) { 268 Diag(Ploc, diag::err_protocol_has_circular_dependency); 269 Diag(PrevLoc, diag::note_previous_definition); 270 } 271 CheckForwardProtocolDeclarationForCircularDependency(PName, Ploc, 272 PDecl->getLocation(), PDecl->getReferencedProtocols()); 273 } 274 } 275} 276 277Sema::DeclPtrTy 278Sema::ActOnStartProtocolInterface(SourceLocation AtProtoInterfaceLoc, 279 IdentifierInfo *ProtocolName, 280 SourceLocation ProtocolLoc, 281 const DeclPtrTy *ProtoRefs, 282 unsigned NumProtoRefs, 283 const SourceLocation *ProtoLocs, 284 SourceLocation EndProtoLoc, 285 AttributeList *AttrList) { 286 // FIXME: Deal with AttrList. 287 assert(ProtocolName && "Missing protocol identifier"); 288 ObjCProtocolDecl *PDecl = LookupProtocol(ProtocolName); 289 if (PDecl) { 290 // Protocol already seen. Better be a forward protocol declaration 291 if (!PDecl->isForwardDecl()) { 292 Diag(ProtocolLoc, diag::warn_duplicate_protocol_def) << ProtocolName; 293 Diag(PDecl->getLocation(), diag::note_previous_definition); 294 // Just return the protocol we already had. 295 // FIXME: don't leak the objects passed in! 296 return DeclPtrTy::make(PDecl); 297 } 298 ObjCList<ObjCProtocolDecl> PList; 299 PList.set((ObjCProtocolDecl *const*)ProtoRefs, NumProtoRefs, Context); 300 CheckForwardProtocolDeclarationForCircularDependency( 301 ProtocolName, ProtocolLoc, PDecl->getLocation(), PList); 302 PList.Destroy(Context); 303 304 // Make sure the cached decl gets a valid start location. 305 PDecl->setLocation(AtProtoInterfaceLoc); 306 PDecl->setForwardDecl(false); 307 } else { 308 PDecl = ObjCProtocolDecl::Create(Context, CurContext, 309 AtProtoInterfaceLoc,ProtocolName); 310 PushOnScopeChains(PDecl, TUScope); 311 PDecl->setForwardDecl(false); 312 } 313 if (AttrList) 314 ProcessDeclAttributeList(TUScope, PDecl, AttrList); 315 if (NumProtoRefs) { 316 /// Check then save referenced protocols. 317 PDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs, 318 ProtoLocs, Context); 319 PDecl->setLocEnd(EndProtoLoc); 320 } 321 322 CheckObjCDeclScope(PDecl); 323 return DeclPtrTy::make(PDecl); 324} 325 326/// FindProtocolDeclaration - This routine looks up protocols and 327/// issues an error if they are not declared. It returns list of 328/// protocol declarations in its 'Protocols' argument. 329void 330Sema::FindProtocolDeclaration(bool WarnOnDeclarations, 331 const IdentifierLocPair *ProtocolId, 332 unsigned NumProtocols, 333 llvm::SmallVectorImpl<DeclPtrTy> &Protocols) { 334 for (unsigned i = 0; i != NumProtocols; ++i) { 335 ObjCProtocolDecl *PDecl = LookupProtocol(ProtocolId[i].first); 336 if (!PDecl) { 337 LookupResult R(*this, ProtocolId[i].first, ProtocolId[i].second, 338 LookupObjCProtocolName); 339 if (CorrectTypo(R, TUScope, 0) && 340 (PDecl = R.getAsSingle<ObjCProtocolDecl>())) { 341 Diag(ProtocolId[i].second, diag::err_undeclared_protocol_suggest) 342 << ProtocolId[i].first << R.getLookupName(); 343 Diag(PDecl->getLocation(), diag::note_previous_decl) 344 << PDecl->getDeclName(); 345 } 346 } 347 348 if (!PDecl) { 349 Diag(ProtocolId[i].second, diag::err_undeclared_protocol) 350 << ProtocolId[i].first; 351 continue; 352 } 353 354 (void)DiagnoseUseOfDecl(PDecl, ProtocolId[i].second); 355 356 // If this is a forward declaration and we are supposed to warn in this 357 // case, do it. 358 if (WarnOnDeclarations && PDecl->isForwardDecl()) 359 Diag(ProtocolId[i].second, diag::warn_undef_protocolref) 360 << ProtocolId[i].first; 361 Protocols.push_back(DeclPtrTy::make(PDecl)); 362 } 363} 364 365/// DiagnosePropertyMismatch - Compares two properties for their 366/// attributes and types and warns on a variety of inconsistencies. 367/// 368void 369Sema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 370 ObjCPropertyDecl *SuperProperty, 371 const IdentifierInfo *inheritedName) { 372 ObjCPropertyDecl::PropertyAttributeKind CAttr = 373 Property->getPropertyAttributes(); 374 ObjCPropertyDecl::PropertyAttributeKind SAttr = 375 SuperProperty->getPropertyAttributes(); 376 if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 377 && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 378 Diag(Property->getLocation(), diag::warn_readonly_property) 379 << Property->getDeclName() << inheritedName; 380 if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 381 != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 382 Diag(Property->getLocation(), diag::warn_property_attribute) 383 << Property->getDeclName() << "copy" << inheritedName; 384 else if ((CAttr & ObjCPropertyDecl::OBJC_PR_retain) 385 != (SAttr & ObjCPropertyDecl::OBJC_PR_retain)) 386 Diag(Property->getLocation(), diag::warn_property_attribute) 387 << Property->getDeclName() << "retain" << inheritedName; 388 389 if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 390 != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 391 Diag(Property->getLocation(), diag::warn_property_attribute) 392 << Property->getDeclName() << "atomic" << inheritedName; 393 if (Property->getSetterName() != SuperProperty->getSetterName()) 394 Diag(Property->getLocation(), diag::warn_property_attribute) 395 << Property->getDeclName() << "setter" << inheritedName; 396 if (Property->getGetterName() != SuperProperty->getGetterName()) 397 Diag(Property->getLocation(), diag::warn_property_attribute) 398 << Property->getDeclName() << "getter" << inheritedName; 399 400 QualType LHSType = 401 Context.getCanonicalType(SuperProperty->getType()); 402 QualType RHSType = 403 Context.getCanonicalType(Property->getType()); 404 405 if (!Context.typesAreCompatible(LHSType, RHSType)) { 406 // FIXME: Incorporate this test with typesAreCompatible. 407 if (LHSType->isObjCQualifiedIdType() && RHSType->isObjCQualifiedIdType()) 408 if (Context.ObjCQualifiedIdTypesAreCompatible(LHSType, RHSType, false)) 409 return; 410 Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 411 << Property->getType() << SuperProperty->getType() << inheritedName; 412 } 413} 414 415/// ComparePropertiesInBaseAndSuper - This routine compares property 416/// declarations in base and its super class, if any, and issues 417/// diagnostics in a variety of inconsistant situations. 418/// 419void Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 420 ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 421 if (!SDecl) 422 return; 423 // FIXME: O(N^2) 424 for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 425 E = SDecl->prop_end(); S != E; ++S) { 426 ObjCPropertyDecl *SuperPDecl = (*S); 427 // Does property in super class has declaration in current class? 428 for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 429 E = IDecl->prop_end(); I != E; ++I) { 430 ObjCPropertyDecl *PDecl = (*I); 431 if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 432 DiagnosePropertyMismatch(PDecl, SuperPDecl, 433 SDecl->getIdentifier()); 434 } 435 } 436} 437 438/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 439/// of properties declared in a protocol and compares their attribute against 440/// the same property declared in the class or category. 441void 442Sema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 443 ObjCProtocolDecl *PDecl) { 444 ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 445 if (!IDecl) { 446 // Category 447 ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 448 assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 449 if (!CatDecl->IsClassExtension()) 450 for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 451 E = PDecl->prop_end(); P != E; ++P) { 452 ObjCPropertyDecl *Pr = (*P); 453 ObjCCategoryDecl::prop_iterator CP, CE; 454 // Is this property already in category's list of properties? 455 for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP != CE; ++CP) 456 if ((*CP)->getIdentifier() == Pr->getIdentifier()) 457 break; 458 if (CP != CE) 459 // Property protocol already exist in class. Diagnose any mismatch. 460 DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 461 } 462 return; 463 } 464 for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 465 E = PDecl->prop_end(); P != E; ++P) { 466 ObjCPropertyDecl *Pr = (*P); 467 ObjCInterfaceDecl::prop_iterator CP, CE; 468 // Is this property already in class's list of properties? 469 for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 470 if ((*CP)->getIdentifier() == Pr->getIdentifier()) 471 break; 472 if (CP != CE) 473 // Property protocol already exist in class. Diagnose any mismatch. 474 DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 475 } 476} 477 478/// CompareProperties - This routine compares properties 479/// declared in 'ClassOrProtocol' objects (which can be a class or an 480/// inherited protocol with the list of properties for class/category 'CDecl' 481/// 482void Sema::CompareProperties(Decl *CDecl, 483 DeclPtrTy ClassOrProtocol) { 484 Decl *ClassDecl = ClassOrProtocol.getAs<Decl>(); 485 ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 486 487 if (!IDecl) { 488 // Category 489 ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 490 assert (CatDecl && "CompareProperties"); 491 if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 492 for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 493 E = MDecl->protocol_end(); P != E; ++P) 494 // Match properties of category with those of protocol (*P) 495 MatchOneProtocolPropertiesInClass(CatDecl, *P); 496 497 // Go thru the list of protocols for this category and recursively match 498 // their properties with those in the category. 499 for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 500 E = CatDecl->protocol_end(); P != E; ++P) 501 CompareProperties(CatDecl, DeclPtrTy::make(*P)); 502 } else { 503 ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 504 for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 505 E = MD->protocol_end(); P != E; ++P) 506 MatchOneProtocolPropertiesInClass(CatDecl, *P); 507 } 508 return; 509 } 510 511 if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 512 for (ObjCInterfaceDecl::protocol_iterator P = MDecl->protocol_begin(), 513 E = MDecl->protocol_end(); P != E; ++P) 514 // Match properties of class IDecl with those of protocol (*P). 515 MatchOneProtocolPropertiesInClass(IDecl, *P); 516 517 // Go thru the list of protocols for this class and recursively match 518 // their properties with those declared in the class. 519 for (ObjCInterfaceDecl::protocol_iterator P = IDecl->protocol_begin(), 520 E = IDecl->protocol_end(); P != E; ++P) 521 CompareProperties(IDecl, DeclPtrTy::make(*P)); 522 } else { 523 ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 524 for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 525 E = MD->protocol_end(); P != E; ++P) 526 MatchOneProtocolPropertiesInClass(IDecl, *P); 527 } 528} 529 530/// DiagnoseClassExtensionDupMethods - Check for duplicate declaration of 531/// a class method in its extension. 532/// 533void Sema::DiagnoseClassExtensionDupMethods(ObjCCategoryDecl *CAT, 534 ObjCInterfaceDecl *ID) { 535 if (!ID) 536 return; // Possibly due to previous error 537 538 llvm::DenseMap<Selector, const ObjCMethodDecl*> MethodMap; 539 for (ObjCInterfaceDecl::method_iterator i = ID->meth_begin(), 540 e = ID->meth_end(); i != e; ++i) { 541 ObjCMethodDecl *MD = *i; 542 MethodMap[MD->getSelector()] = MD; 543 } 544 545 if (MethodMap.empty()) 546 return; 547 for (ObjCCategoryDecl::method_iterator i = CAT->meth_begin(), 548 e = CAT->meth_end(); i != e; ++i) { 549 ObjCMethodDecl *Method = *i; 550 const ObjCMethodDecl *&PrevMethod = MethodMap[Method->getSelector()]; 551 if (PrevMethod && !MatchTwoMethodDeclarations(Method, PrevMethod)) { 552 Diag(Method->getLocation(), diag::err_duplicate_method_decl) 553 << Method->getDeclName(); 554 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 555 } 556 } 557} 558 559/// ActOnForwardProtocolDeclaration - Handle @protocol foo; 560Action::DeclPtrTy 561Sema::ActOnForwardProtocolDeclaration(SourceLocation AtProtocolLoc, 562 const IdentifierLocPair *IdentList, 563 unsigned NumElts, 564 AttributeList *attrList) { 565 llvm::SmallVector<ObjCProtocolDecl*, 32> Protocols; 566 llvm::SmallVector<SourceLocation, 8> ProtoLocs; 567 568 for (unsigned i = 0; i != NumElts; ++i) { 569 IdentifierInfo *Ident = IdentList[i].first; 570 ObjCProtocolDecl *PDecl = LookupProtocol(Ident); 571 if (PDecl == 0) { // Not already seen? 572 PDecl = ObjCProtocolDecl::Create(Context, CurContext, 573 IdentList[i].second, Ident); 574 PushOnScopeChains(PDecl, TUScope); 575 } 576 if (attrList) 577 ProcessDeclAttributeList(TUScope, PDecl, attrList); 578 Protocols.push_back(PDecl); 579 ProtoLocs.push_back(IdentList[i].second); 580 } 581 582 ObjCForwardProtocolDecl *PDecl = 583 ObjCForwardProtocolDecl::Create(Context, CurContext, AtProtocolLoc, 584 Protocols.data(), Protocols.size(), 585 ProtoLocs.data()); 586 CurContext->addDecl(PDecl); 587 CheckObjCDeclScope(PDecl); 588 return DeclPtrTy::make(PDecl); 589} 590 591Sema::DeclPtrTy Sema:: 592ActOnStartCategoryInterface(SourceLocation AtInterfaceLoc, 593 IdentifierInfo *ClassName, SourceLocation ClassLoc, 594 IdentifierInfo *CategoryName, 595 SourceLocation CategoryLoc, 596 const DeclPtrTy *ProtoRefs, 597 unsigned NumProtoRefs, 598 const SourceLocation *ProtoLocs, 599 SourceLocation EndProtoLoc) { 600 ObjCCategoryDecl *CDecl = 0; 601 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName, ClassLoc); 602 if (!CategoryName) { 603 // Class extensions require a special treatment. Use an existing one. 604 for (CDecl = IDecl->getCategoryList(); CDecl; 605 CDecl = CDecl->getNextClassCategory()) 606 if (CDecl->IsClassExtension()) 607 break; 608 } 609 if (!CDecl) { 610 CDecl = ObjCCategoryDecl::Create(Context, CurContext, AtInterfaceLoc, ClassLoc, 611 CategoryLoc, CategoryName); 612 // FIXME: PushOnScopeChains? 613 CurContext->addDecl(CDecl); 614 615 /// Check that class of this category is already completely declared. 616 if (!IDecl || IDecl->isForwardDecl()) { 617 CDecl->setInvalidDecl(); 618 Diag(ClassLoc, diag::err_undef_interface) << ClassName; 619 return DeclPtrTy::make(CDecl); 620 } 621 622 CDecl->setClassInterface(IDecl); 623 // Insert first use of class extension to the list of class's categories. 624 if (!CategoryName) 625 CDecl->insertNextClassCategory(); 626 } 627 628 // If the interface is deprecated, warn about it. 629 (void)DiagnoseUseOfDecl(IDecl, ClassLoc); 630 631 if (CategoryName) { 632 /// Check for duplicate interface declaration for this category 633 ObjCCategoryDecl *CDeclChain; 634 for (CDeclChain = IDecl->getCategoryList(); CDeclChain; 635 CDeclChain = CDeclChain->getNextClassCategory()) { 636 if (CDeclChain->getIdentifier() == CategoryName) { 637 // Class extensions can be declared multiple times. 638 Diag(CategoryLoc, diag::warn_dup_category_def) 639 << ClassName << CategoryName; 640 Diag(CDeclChain->getLocation(), diag::note_previous_definition); 641 break; 642 } 643 } 644 if (!CDeclChain) 645 CDecl->insertNextClassCategory(); 646 } 647 648 if (NumProtoRefs) { 649 CDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs, 650 ProtoLocs, Context); 651 // Protocols in the class extension belong to the class. 652 if (CDecl->IsClassExtension()) 653 IDecl->mergeClassExtensionProtocolList((ObjCProtocolDecl**)ProtoRefs, 654 NumProtoRefs, ProtoLocs, 655 Context); 656 } 657 658 CheckObjCDeclScope(CDecl); 659 return DeclPtrTy::make(CDecl); 660} 661 662/// ActOnStartCategoryImplementation - Perform semantic checks on the 663/// category implementation declaration and build an ObjCCategoryImplDecl 664/// object. 665Sema::DeclPtrTy Sema::ActOnStartCategoryImplementation( 666 SourceLocation AtCatImplLoc, 667 IdentifierInfo *ClassName, SourceLocation ClassLoc, 668 IdentifierInfo *CatName, SourceLocation CatLoc) { 669 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName, ClassLoc); 670 ObjCCategoryDecl *CatIDecl = 0; 671 if (IDecl) { 672 CatIDecl = IDecl->FindCategoryDeclaration(CatName); 673 if (!CatIDecl) { 674 // Category @implementation with no corresponding @interface. 675 // Create and install one. 676 CatIDecl = ObjCCategoryDecl::Create(Context, CurContext, SourceLocation(), 677 SourceLocation(), SourceLocation(), 678 CatName); 679 CatIDecl->setClassInterface(IDecl); 680 CatIDecl->insertNextClassCategory(); 681 } 682 } 683 684 ObjCCategoryImplDecl *CDecl = 685 ObjCCategoryImplDecl::Create(Context, CurContext, AtCatImplLoc, CatName, 686 IDecl); 687 /// Check that class of this category is already completely declared. 688 if (!IDecl || IDecl->isForwardDecl()) 689 Diag(ClassLoc, diag::err_undef_interface) << ClassName; 690 691 // FIXME: PushOnScopeChains? 692 CurContext->addDecl(CDecl); 693 694 /// Check that CatName, category name, is not used in another implementation. 695 if (CatIDecl) { 696 if (CatIDecl->getImplementation()) { 697 Diag(ClassLoc, diag::err_dup_implementation_category) << ClassName 698 << CatName; 699 Diag(CatIDecl->getImplementation()->getLocation(), 700 diag::note_previous_definition); 701 } else 702 CatIDecl->setImplementation(CDecl); 703 } 704 705 CheckObjCDeclScope(CDecl); 706 return DeclPtrTy::make(CDecl); 707} 708 709Sema::DeclPtrTy Sema::ActOnStartClassImplementation( 710 SourceLocation AtClassImplLoc, 711 IdentifierInfo *ClassName, SourceLocation ClassLoc, 712 IdentifierInfo *SuperClassname, 713 SourceLocation SuperClassLoc) { 714 ObjCInterfaceDecl* IDecl = 0; 715 // Check for another declaration kind with the same name. 716 NamedDecl *PrevDecl 717 = LookupSingleName(TUScope, ClassName, LookupOrdinaryName); 718 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 719 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName; 720 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 721 } else if ((IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl))) { 722 // If this is a forward declaration of an interface, warn. 723 if (IDecl->isForwardDecl()) { 724 Diag(ClassLoc, diag::warn_undef_interface) << ClassName; 725 IDecl = 0; 726 } 727 } else { 728 // We did not find anything with the name ClassName; try to correct for 729 // typos in the class name. 730 LookupResult R(*this, ClassName, ClassLoc, LookupOrdinaryName); 731 if (CorrectTypo(R, TUScope, 0) && 732 (IDecl = R.getAsSingle<ObjCInterfaceDecl>())) { 733 // Suggest the (potentially) correct interface name. However, put the 734 // fix-it hint itself in a separate note, since changing the name in 735 // the warning would make the fix-it change semantics.However, don't 736 // provide a code-modification hint or use the typo name for recovery, 737 // because this is just a warning. The program may actually be correct. 738 Diag(ClassLoc, diag::warn_undef_interface_suggest) 739 << ClassName << R.getLookupName(); 740 Diag(IDecl->getLocation(), diag::note_previous_decl) 741 << R.getLookupName() 742 << CodeModificationHint::CreateReplacement(ClassLoc, 743 R.getLookupName().getAsString()); 744 IDecl = 0; 745 } else { 746 Diag(ClassLoc, diag::warn_undef_interface) << ClassName; 747 } 748 } 749 750 // Check that super class name is valid class name 751 ObjCInterfaceDecl* SDecl = 0; 752 if (SuperClassname) { 753 // Check if a different kind of symbol declared in this scope. 754 PrevDecl = LookupSingleName(TUScope, SuperClassname, LookupOrdinaryName); 755 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 756 Diag(SuperClassLoc, diag::err_redefinition_different_kind) 757 << SuperClassname; 758 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 759 } else { 760 SDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 761 if (!SDecl) 762 Diag(SuperClassLoc, diag::err_undef_superclass) 763 << SuperClassname << ClassName; 764 else if (IDecl && IDecl->getSuperClass() != SDecl) { 765 // This implementation and its interface do not have the same 766 // super class. 767 Diag(SuperClassLoc, diag::err_conflicting_super_class) 768 << SDecl->getDeclName(); 769 Diag(SDecl->getLocation(), diag::note_previous_definition); 770 } 771 } 772 } 773 774 if (!IDecl) { 775 // Legacy case of @implementation with no corresponding @interface. 776 // Build, chain & install the interface decl into the identifier. 777 778 // FIXME: Do we support attributes on the @implementation? If so we should 779 // copy them over. 780 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtClassImplLoc, 781 ClassName, ClassLoc, false, true); 782 IDecl->setSuperClass(SDecl); 783 IDecl->setLocEnd(ClassLoc); 784 785 PushOnScopeChains(IDecl, TUScope); 786 } else { 787 // Mark the interface as being completed, even if it was just as 788 // @class ....; 789 // declaration; the user cannot reopen it. 790 IDecl->setForwardDecl(false); 791 } 792 793 ObjCImplementationDecl* IMPDecl = 794 ObjCImplementationDecl::Create(Context, CurContext, AtClassImplLoc, 795 IDecl, SDecl); 796 797 if (CheckObjCDeclScope(IMPDecl)) 798 return DeclPtrTy::make(IMPDecl); 799 800 // Check that there is no duplicate implementation of this class. 801 if (IDecl->getImplementation()) { 802 // FIXME: Don't leak everything! 803 Diag(ClassLoc, diag::err_dup_implementation_class) << ClassName; 804 Diag(IDecl->getImplementation()->getLocation(), 805 diag::note_previous_definition); 806 } else { // add it to the list. 807 IDecl->setImplementation(IMPDecl); 808 PushOnScopeChains(IMPDecl, TUScope); 809 } 810 return DeclPtrTy::make(IMPDecl); 811} 812 813void Sema::CheckImplementationIvars(ObjCImplementationDecl *ImpDecl, 814 ObjCIvarDecl **ivars, unsigned numIvars, 815 SourceLocation RBrace) { 816 assert(ImpDecl && "missing implementation decl"); 817 ObjCInterfaceDecl* IDecl = ImpDecl->getClassInterface(); 818 if (!IDecl) 819 return; 820 /// Check case of non-existing @interface decl. 821 /// (legacy objective-c @implementation decl without an @interface decl). 822 /// Add implementations's ivar to the synthesize class's ivar list. 823 if (IDecl->isImplicitInterfaceDecl()) { 824 IDecl->setIVarList(ivars, numIvars, Context); 825 IDecl->setLocEnd(RBrace); 826 // Add ivar's to class's DeclContext. 827 for (unsigned i = 0, e = numIvars; i != e; ++i) { 828 ivars[i]->setLexicalDeclContext(ImpDecl); 829 IDecl->makeDeclVisibleInContext(ivars[i], false); 830 } 831 832 return; 833 } 834 // If implementation has empty ivar list, just return. 835 if (numIvars == 0) 836 return; 837 838 assert(ivars && "missing @implementation ivars"); 839 840 // Check interface's Ivar list against those in the implementation. 841 // names and types must match. 842 // 843 unsigned j = 0; 844 ObjCInterfaceDecl::ivar_iterator 845 IVI = IDecl->ivar_begin(), IVE = IDecl->ivar_end(); 846 for (; numIvars > 0 && IVI != IVE; ++IVI) { 847 ObjCIvarDecl* ImplIvar = ivars[j++]; 848 ObjCIvarDecl* ClsIvar = *IVI; 849 assert (ImplIvar && "missing implementation ivar"); 850 assert (ClsIvar && "missing class ivar"); 851 852 // First, make sure the types match. 853 if (Context.getCanonicalType(ImplIvar->getType()) != 854 Context.getCanonicalType(ClsIvar->getType())) { 855 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_type) 856 << ImplIvar->getIdentifier() 857 << ImplIvar->getType() << ClsIvar->getType(); 858 Diag(ClsIvar->getLocation(), diag::note_previous_definition); 859 } else if (ImplIvar->isBitField() && ClsIvar->isBitField()) { 860 Expr *ImplBitWidth = ImplIvar->getBitWidth(); 861 Expr *ClsBitWidth = ClsIvar->getBitWidth(); 862 if (ImplBitWidth->EvaluateAsInt(Context).getZExtValue() != 863 ClsBitWidth->EvaluateAsInt(Context).getZExtValue()) { 864 Diag(ImplBitWidth->getLocStart(), diag::err_conflicting_ivar_bitwidth) 865 << ImplIvar->getIdentifier(); 866 Diag(ClsBitWidth->getLocStart(), diag::note_previous_definition); 867 } 868 } 869 // Make sure the names are identical. 870 if (ImplIvar->getIdentifier() != ClsIvar->getIdentifier()) { 871 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_name) 872 << ImplIvar->getIdentifier() << ClsIvar->getIdentifier(); 873 Diag(ClsIvar->getLocation(), diag::note_previous_definition); 874 } 875 --numIvars; 876 } 877 878 if (numIvars > 0) 879 Diag(ivars[j]->getLocation(), diag::err_inconsistant_ivar_count); 880 else if (IVI != IVE) 881 Diag((*IVI)->getLocation(), diag::err_inconsistant_ivar_count); 882} 883 884void Sema::WarnUndefinedMethod(SourceLocation ImpLoc, ObjCMethodDecl *method, 885 bool &IncompleteImpl) { 886 if (!IncompleteImpl) { 887 Diag(ImpLoc, diag::warn_incomplete_impl); 888 IncompleteImpl = true; 889 } 890 Diag(ImpLoc, diag::warn_undef_method_impl) << method->getDeclName(); 891} 892 893void Sema::WarnConflictingTypedMethods(ObjCMethodDecl *ImpMethodDecl, 894 ObjCMethodDecl *IntfMethodDecl) { 895 if (!Context.typesAreCompatible(IntfMethodDecl->getResultType(), 896 ImpMethodDecl->getResultType()) && 897 !Context.QualifiedIdConformsQualifiedId(IntfMethodDecl->getResultType(), 898 ImpMethodDecl->getResultType())) { 899 Diag(ImpMethodDecl->getLocation(), diag::warn_conflicting_ret_types) 900 << ImpMethodDecl->getDeclName() << IntfMethodDecl->getResultType() 901 << ImpMethodDecl->getResultType(); 902 Diag(IntfMethodDecl->getLocation(), diag::note_previous_definition); 903 } 904 905 for (ObjCMethodDecl::param_iterator IM = ImpMethodDecl->param_begin(), 906 IF = IntfMethodDecl->param_begin(), EM = ImpMethodDecl->param_end(); 907 IM != EM; ++IM, ++IF) { 908 QualType ParmDeclTy = (*IF)->getType().getUnqualifiedType(); 909 QualType ParmImpTy = (*IM)->getType().getUnqualifiedType(); 910 if (Context.typesAreCompatible(ParmDeclTy, ParmImpTy) || 911 Context.QualifiedIdConformsQualifiedId(ParmDeclTy, ParmImpTy)) 912 continue; 913 914 Diag((*IM)->getLocation(), diag::warn_conflicting_param_types) 915 << ImpMethodDecl->getDeclName() << (*IF)->getType() 916 << (*IM)->getType(); 917 Diag((*IF)->getLocation(), diag::note_previous_definition); 918 } 919} 920 921/// isPropertyReadonly - Return true if property is readonly, by searching 922/// for the property in the class and in its categories and implementations 923/// 924bool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 925 ObjCInterfaceDecl *IDecl) { 926 // by far the most common case. 927 if (!PDecl->isReadOnly()) 928 return false; 929 // Even if property is ready only, if interface has a user defined setter, 930 // it is not considered read only. 931 if (IDecl->getInstanceMethod(PDecl->getSetterName())) 932 return false; 933 934 // Main class has the property as 'readonly'. Must search 935 // through the category list to see if the property's 936 // attribute has been over-ridden to 'readwrite'. 937 for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 938 Category; Category = Category->getNextClassCategory()) { 939 // Even if property is ready only, if a category has a user defined setter, 940 // it is not considered read only. 941 if (Category->getInstanceMethod(PDecl->getSetterName())) 942 return false; 943 ObjCPropertyDecl *P = 944 Category->FindPropertyDeclaration(PDecl->getIdentifier()); 945 if (P && !P->isReadOnly()) 946 return false; 947 } 948 949 // Also, check for definition of a setter method in the implementation if 950 // all else failed. 951 if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 952 if (ObjCImplementationDecl *IMD = 953 dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 954 if (IMD->getInstanceMethod(PDecl->getSetterName())) 955 return false; 956 } else if (ObjCCategoryImplDecl *CIMD = 957 dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 958 if (CIMD->getInstanceMethod(PDecl->getSetterName())) 959 return false; 960 } 961 } 962 // Lastly, look through the implementation (if one is in scope). 963 if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 964 if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 965 return false; 966 // If all fails, look at the super class. 967 if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 968 return isPropertyReadonly(PDecl, SIDecl); 969 return true; 970} 971 972/// FIXME: Type hierarchies in Objective-C can be deep. We could most likely 973/// improve the efficiency of selector lookups and type checking by associating 974/// with each protocol / interface / category the flattened instance tables. If 975/// we used an immutable set to keep the table then it wouldn't add significant 976/// memory cost and it would be handy for lookups. 977 978/// CheckProtocolMethodDefs - This routine checks unimplemented methods 979/// Declared in protocol, and those referenced by it. 980void Sema::CheckProtocolMethodDefs(SourceLocation ImpLoc, 981 ObjCProtocolDecl *PDecl, 982 bool& IncompleteImpl, 983 const llvm::DenseSet<Selector> &InsMap, 984 const llvm::DenseSet<Selector> &ClsMap, 985 ObjCInterfaceDecl *IDecl) { 986 ObjCInterfaceDecl *Super = IDecl->getSuperClass(); 987 ObjCInterfaceDecl *NSIDecl = 0; 988 if (getLangOptions().NeXTRuntime) { 989 // check to see if class implements forwardInvocation method and objects 990 // of this class are derived from 'NSProxy' so that to forward requests 991 // from one object to another. 992 // Under such conditions, which means that every method possible is 993 // implemented in the class, we should not issue "Method definition not 994 // found" warnings. 995 // FIXME: Use a general GetUnarySelector method for this. 996 IdentifierInfo* II = &Context.Idents.get("forwardInvocation"); 997 Selector fISelector = Context.Selectors.getSelector(1, &II); 998 if (InsMap.count(fISelector)) 999 // Is IDecl derived from 'NSProxy'? If so, no instance methods 1000 // need be implemented in the implementation. 1001 NSIDecl = IDecl->lookupInheritedClass(&Context.Idents.get("NSProxy")); 1002 } 1003 1004 // If a method lookup fails locally we still need to look and see if 1005 // the method was implemented by a base class or an inherited 1006 // protocol. This lookup is slow, but occurs rarely in correct code 1007 // and otherwise would terminate in a warning. 1008 1009 // check unimplemented instance methods. 1010 if (!NSIDecl) 1011 for (ObjCProtocolDecl::instmeth_iterator I = PDecl->instmeth_begin(), 1012 E = PDecl->instmeth_end(); I != E; ++I) { 1013 ObjCMethodDecl *method = *I; 1014 if (method->getImplementationControl() != ObjCMethodDecl::Optional && 1015 !method->isSynthesized() && !InsMap.count(method->getSelector()) && 1016 (!Super || 1017 !Super->lookupInstanceMethod(method->getSelector()))) { 1018 // Ugly, but necessary. Method declared in protcol might have 1019 // have been synthesized due to a property declared in the class which 1020 // uses the protocol. 1021 ObjCMethodDecl *MethodInClass = 1022 IDecl->lookupInstanceMethod(method->getSelector()); 1023 if (!MethodInClass || !MethodInClass->isSynthesized()) 1024 WarnUndefinedMethod(ImpLoc, method, IncompleteImpl); 1025 } 1026 } 1027 // check unimplemented class methods 1028 for (ObjCProtocolDecl::classmeth_iterator 1029 I = PDecl->classmeth_begin(), E = PDecl->classmeth_end(); 1030 I != E; ++I) { 1031 ObjCMethodDecl *method = *I; 1032 if (method->getImplementationControl() != ObjCMethodDecl::Optional && 1033 !ClsMap.count(method->getSelector()) && 1034 (!Super || !Super->lookupClassMethod(method->getSelector()))) 1035 WarnUndefinedMethod(ImpLoc, method, IncompleteImpl); 1036 } 1037 // Check on this protocols's referenced protocols, recursively. 1038 for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 1039 E = PDecl->protocol_end(); PI != E; ++PI) 1040 CheckProtocolMethodDefs(ImpLoc, *PI, IncompleteImpl, InsMap, ClsMap, IDecl); 1041} 1042 1043/// MatchAllMethodDeclarations - Check methods declaraed in interface or 1044/// or protocol against those declared in their implementations. 1045/// 1046void Sema::MatchAllMethodDeclarations(const llvm::DenseSet<Selector> &InsMap, 1047 const llvm::DenseSet<Selector> &ClsMap, 1048 llvm::DenseSet<Selector> &InsMapSeen, 1049 llvm::DenseSet<Selector> &ClsMapSeen, 1050 ObjCImplDecl* IMPDecl, 1051 ObjCContainerDecl* CDecl, 1052 bool &IncompleteImpl, 1053 bool ImmediateClass) { 1054 // Check and see if instance methods in class interface have been 1055 // implemented in the implementation class. If so, their types match. 1056 for (ObjCInterfaceDecl::instmeth_iterator I = CDecl->instmeth_begin(), 1057 E = CDecl->instmeth_end(); I != E; ++I) { 1058 if (InsMapSeen.count((*I)->getSelector())) 1059 continue; 1060 InsMapSeen.insert((*I)->getSelector()); 1061 if (!(*I)->isSynthesized() && 1062 !InsMap.count((*I)->getSelector())) { 1063 if (ImmediateClass) 1064 WarnUndefinedMethod(IMPDecl->getLocation(), *I, IncompleteImpl); 1065 continue; 1066 } else { 1067 ObjCMethodDecl *ImpMethodDecl = 1068 IMPDecl->getInstanceMethod((*I)->getSelector()); 1069 ObjCMethodDecl *IntfMethodDecl = 1070 CDecl->getInstanceMethod((*I)->getSelector()); 1071 assert(IntfMethodDecl && 1072 "IntfMethodDecl is null in ImplMethodsVsClassMethods"); 1073 // ImpMethodDecl may be null as in a @dynamic property. 1074 if (ImpMethodDecl) 1075 WarnConflictingTypedMethods(ImpMethodDecl, IntfMethodDecl); 1076 } 1077 } 1078 1079 // Check and see if class methods in class interface have been 1080 // implemented in the implementation class. If so, their types match. 1081 for (ObjCInterfaceDecl::classmeth_iterator 1082 I = CDecl->classmeth_begin(), E = CDecl->classmeth_end(); I != E; ++I) { 1083 if (ClsMapSeen.count((*I)->getSelector())) 1084 continue; 1085 ClsMapSeen.insert((*I)->getSelector()); 1086 if (!ClsMap.count((*I)->getSelector())) { 1087 if (ImmediateClass) 1088 WarnUndefinedMethod(IMPDecl->getLocation(), *I, IncompleteImpl); 1089 } else { 1090 ObjCMethodDecl *ImpMethodDecl = 1091 IMPDecl->getClassMethod((*I)->getSelector()); 1092 ObjCMethodDecl *IntfMethodDecl = 1093 CDecl->getClassMethod((*I)->getSelector()); 1094 WarnConflictingTypedMethods(ImpMethodDecl, IntfMethodDecl); 1095 } 1096 } 1097 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) { 1098 // Check for any implementation of a methods declared in protocol. 1099 for (ObjCInterfaceDecl::protocol_iterator PI = I->protocol_begin(), 1100 E = I->protocol_end(); PI != E; ++PI) 1101 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 1102 IMPDecl, 1103 (*PI), IncompleteImpl, false); 1104 if (I->getSuperClass()) 1105 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 1106 IMPDecl, 1107 I->getSuperClass(), IncompleteImpl, false); 1108 } 1109} 1110 1111/// CollectImmediateProperties - This routine collects all properties in 1112/// the class and its conforming protocols; but not those it its super class. 1113void Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 1114 llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1115 if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 1116 for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 1117 E = IDecl->prop_end(); P != E; ++P) { 1118 ObjCPropertyDecl *Prop = (*P); 1119 PropMap[Prop->getIdentifier()] = Prop; 1120 } 1121 // scan through class's protocols. 1122 for (ObjCInterfaceDecl::protocol_iterator PI = IDecl->protocol_begin(), 1123 E = IDecl->protocol_end(); PI != E; ++PI) 1124 CollectImmediateProperties((*PI), PropMap); 1125 } 1126 if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 1127 if (!CATDecl->IsClassExtension()) 1128 for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 1129 E = CATDecl->prop_end(); P != E; ++P) { 1130 ObjCPropertyDecl *Prop = (*P); 1131 PropMap[Prop->getIdentifier()] = Prop; 1132 } 1133 // scan through class's protocols. 1134 for (ObjCInterfaceDecl::protocol_iterator PI = CATDecl->protocol_begin(), 1135 E = CATDecl->protocol_end(); PI != E; ++PI) 1136 CollectImmediateProperties((*PI), PropMap); 1137 } 1138 else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 1139 for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 1140 E = PDecl->prop_end(); P != E; ++P) { 1141 ObjCPropertyDecl *Prop = (*P); 1142 ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 1143 if (!PropEntry) 1144 PropEntry = Prop; 1145 } 1146 // scan through protocol's protocols. 1147 for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 1148 E = PDecl->protocol_end(); PI != E; ++PI) 1149 CollectImmediateProperties((*PI), PropMap); 1150 } 1151} 1152 1153/// LookupPropertyDecl - Looks up a property in the current class and all 1154/// its protocols. 1155ObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl, 1156 IdentifierInfo *II) { 1157 if (const ObjCInterfaceDecl *IDecl = 1158 dyn_cast<ObjCInterfaceDecl>(CDecl)) { 1159 for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 1160 E = IDecl->prop_end(); P != E; ++P) { 1161 ObjCPropertyDecl *Prop = (*P); 1162 if (Prop->getIdentifier() == II) 1163 return Prop; 1164 } 1165 // scan through class's protocols. 1166 for (ObjCInterfaceDecl::protocol_iterator PI = IDecl->protocol_begin(), 1167 E = IDecl->protocol_end(); PI != E; ++PI) { 1168 ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 1169 if (Prop) 1170 return Prop; 1171 } 1172 } 1173 else if (const ObjCProtocolDecl *PDecl = 1174 dyn_cast<ObjCProtocolDecl>(CDecl)) { 1175 for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 1176 E = PDecl->prop_end(); P != E; ++P) { 1177 ObjCPropertyDecl *Prop = (*P); 1178 if (Prop->getIdentifier() == II) 1179 return Prop; 1180 } 1181 // scan through protocol's protocols. 1182 for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 1183 E = PDecl->protocol_end(); PI != E; ++PI) { 1184 ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 1185 if (Prop) 1186 return Prop; 1187 } 1188 } 1189 return 0; 1190} 1191 1192 1193void Sema::DiagnoseUnimplementedProperties(ObjCImplDecl* IMPDecl, 1194 ObjCContainerDecl *CDecl, 1195 const llvm::DenseSet<Selector>& InsMap) { 1196 llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1197 CollectImmediateProperties(CDecl, PropMap); 1198 if (PropMap.empty()) 1199 return; 1200 1201 llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 1202 for (ObjCImplDecl::propimpl_iterator 1203 I = IMPDecl->propimpl_begin(), 1204 EI = IMPDecl->propimpl_end(); I != EI; ++I) 1205 PropImplMap.insert((*I)->getPropertyDecl()); 1206 1207 for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 1208 P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 1209 ObjCPropertyDecl *Prop = P->second; 1210 // Is there a matching propery synthesize/dynamic? 1211 if (Prop->isInvalidDecl() || 1212 Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1213 PropImplMap.count(Prop)) 1214 continue; 1215 if (LangOpts.ObjCNonFragileABI2) { 1216 ActOnPropertyImplDecl(IMPDecl->getLocation(), 1217 SourceLocation(), 1218 true, DeclPtrTy::make(IMPDecl), 1219 Prop->getIdentifier(), 1220 Prop->getIdentifier()); 1221 continue; 1222 } 1223 if (!InsMap.count(Prop->getGetterName())) { 1224 Diag(Prop->getLocation(), 1225 isa<ObjCCategoryDecl>(CDecl) ? 1226 diag::warn_setter_getter_impl_required_in_category : 1227 diag::warn_setter_getter_impl_required) 1228 << Prop->getDeclName() << Prop->getGetterName(); 1229 Diag(IMPDecl->getLocation(), 1230 diag::note_property_impl_required); 1231 } 1232 1233 if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 1234 Diag(Prop->getLocation(), 1235 isa<ObjCCategoryDecl>(CDecl) ? 1236 diag::warn_setter_getter_impl_required_in_category : 1237 diag::warn_setter_getter_impl_required) 1238 << Prop->getDeclName() << Prop->getSetterName(); 1239 Diag(IMPDecl->getLocation(), 1240 diag::note_property_impl_required); 1241 } 1242 } 1243} 1244 1245void Sema::ImplMethodsVsClassMethods(ObjCImplDecl* IMPDecl, 1246 ObjCContainerDecl* CDecl, 1247 bool IncompleteImpl) { 1248 llvm::DenseSet<Selector> InsMap; 1249 // Check and see if instance methods in class interface have been 1250 // implemented in the implementation class. 1251 for (ObjCImplementationDecl::instmeth_iterator 1252 I = IMPDecl->instmeth_begin(), E = IMPDecl->instmeth_end(); I!=E; ++I) 1253 InsMap.insert((*I)->getSelector()); 1254 1255 // Check and see if properties declared in the interface have either 1) 1256 // an implementation or 2) there is a @synthesize/@dynamic implementation 1257 // of the property in the @implementation. 1258 if (isa<ObjCInterfaceDecl>(CDecl)) 1259 DiagnoseUnimplementedProperties(IMPDecl, CDecl, InsMap); 1260 1261 llvm::DenseSet<Selector> ClsMap; 1262 for (ObjCImplementationDecl::classmeth_iterator 1263 I = IMPDecl->classmeth_begin(), 1264 E = IMPDecl->classmeth_end(); I != E; ++I) 1265 ClsMap.insert((*I)->getSelector()); 1266 1267 // Check for type conflict of methods declared in a class/protocol and 1268 // its implementation; if any. 1269 llvm::DenseSet<Selector> InsMapSeen, ClsMapSeen; 1270 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 1271 IMPDecl, CDecl, 1272 IncompleteImpl, true); 1273 1274 // Check the protocol list for unimplemented methods in the @implementation 1275 // class. 1276 // Check and see if class methods in class interface have been 1277 // implemented in the implementation class. 1278 1279 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) { 1280 for (ObjCInterfaceDecl::protocol_iterator PI = I->protocol_begin(), 1281 E = I->protocol_end(); PI != E; ++PI) 1282 CheckProtocolMethodDefs(IMPDecl->getLocation(), *PI, IncompleteImpl, 1283 InsMap, ClsMap, I); 1284 // Check class extensions (unnamed categories) 1285 for (ObjCCategoryDecl *Categories = I->getCategoryList(); 1286 Categories; Categories = Categories->getNextClassCategory()) { 1287 if (Categories->IsClassExtension()) { 1288 ImplMethodsVsClassMethods(IMPDecl, Categories, IncompleteImpl); 1289 break; 1290 } 1291 } 1292 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl)) { 1293 // For extended class, unimplemented methods in its protocols will 1294 // be reported in the primary class. 1295 if (!C->IsClassExtension()) { 1296 for (ObjCCategoryDecl::protocol_iterator PI = C->protocol_begin(), 1297 E = C->protocol_end(); PI != E; ++PI) 1298 CheckProtocolMethodDefs(IMPDecl->getLocation(), *PI, IncompleteImpl, 1299 InsMap, ClsMap, C->getClassInterface()); 1300 // Report unimplemented properties in the category as well. 1301 // When reporting on missing setter/getters, do not report when 1302 // setter/getter is implemented in category's primary class 1303 // implementation. 1304 if (ObjCInterfaceDecl *ID = C->getClassInterface()) 1305 if (ObjCImplDecl *IMP = ID->getImplementation()) { 1306 for (ObjCImplementationDecl::instmeth_iterator 1307 I = IMP->instmeth_begin(), E = IMP->instmeth_end(); I!=E; ++I) 1308 InsMap.insert((*I)->getSelector()); 1309 } 1310 DiagnoseUnimplementedProperties(IMPDecl, CDecl, InsMap); 1311 } 1312 } else 1313 assert(false && "invalid ObjCContainerDecl type."); 1314} 1315 1316void 1317Sema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 1318 ObjCContainerDecl* IDecl) { 1319 // Rules apply in non-GC mode only 1320 if (getLangOptions().getGCMode() != LangOptions::NonGC) 1321 return; 1322 for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 1323 E = IDecl->prop_end(); 1324 I != E; ++I) { 1325 ObjCPropertyDecl *Property = (*I); 1326 unsigned Attributes = Property->getPropertyAttributes(); 1327 // We only care about readwrite atomic property. 1328 if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 1329 !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 1330 continue; 1331 if (const ObjCPropertyImplDecl *PIDecl 1332 = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 1333 if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 1334 continue; 1335 ObjCMethodDecl *GetterMethod = 1336 IMPDecl->getInstanceMethod(Property->getGetterName()); 1337 ObjCMethodDecl *SetterMethod = 1338 IMPDecl->getInstanceMethod(Property->getSetterName()); 1339 if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 1340 SourceLocation MethodLoc = 1341 (GetterMethod ? GetterMethod->getLocation() 1342 : SetterMethod->getLocation()); 1343 Diag(MethodLoc, diag::warn_atomic_property_rule) 1344 << Property->getIdentifier(); 1345 Diag(Property->getLocation(), diag::note_property_declare); 1346 } 1347 } 1348 } 1349} 1350 1351/// ActOnForwardClassDeclaration - 1352Action::DeclPtrTy 1353Sema::ActOnForwardClassDeclaration(SourceLocation AtClassLoc, 1354 IdentifierInfo **IdentList, 1355 SourceLocation *IdentLocs, 1356 unsigned NumElts) { 1357 llvm::SmallVector<ObjCInterfaceDecl*, 32> Interfaces; 1358 1359 for (unsigned i = 0; i != NumElts; ++i) { 1360 // Check for another declaration kind with the same name. 1361 NamedDecl *PrevDecl 1362 = LookupSingleName(TUScope, IdentList[i], LookupOrdinaryName); 1363 if (PrevDecl && PrevDecl->isTemplateParameter()) { 1364 // Maybe we will complain about the shadowed template parameter. 1365 DiagnoseTemplateParameterShadow(AtClassLoc, PrevDecl); 1366 // Just pretend that we didn't see the previous declaration. 1367 PrevDecl = 0; 1368 } 1369 1370 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 1371 // GCC apparently allows the following idiom: 1372 // 1373 // typedef NSObject < XCElementTogglerP > XCElementToggler; 1374 // @class XCElementToggler; 1375 // 1376 // FIXME: Make an extension? 1377 TypedefDecl *TDD = dyn_cast<TypedefDecl>(PrevDecl); 1378 if (!TDD || !isa<ObjCInterfaceType>(TDD->getUnderlyingType())) { 1379 Diag(AtClassLoc, diag::err_redefinition_different_kind) << IdentList[i]; 1380 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 1381 } else if (TDD) { 1382 // a forward class declaration matching a typedef name of a class refers 1383 // to the underlying class. 1384 if (ObjCInterfaceType * OI = 1385 dyn_cast<ObjCInterfaceType>(TDD->getUnderlyingType())) 1386 PrevDecl = OI->getDecl(); 1387 } 1388 } 1389 ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 1390 if (!IDecl) { // Not already seen? Make a forward decl. 1391 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtClassLoc, 1392 IdentList[i], IdentLocs[i], true); 1393 1394 // Push the ObjCInterfaceDecl on the scope chain but do *not* add it to 1395 // the current DeclContext. This prevents clients that walk DeclContext 1396 // from seeing the imaginary ObjCInterfaceDecl until it is actually 1397 // declared later (if at all). We also take care to explicitly make 1398 // sure this declaration is visible for name lookup. 1399 PushOnScopeChains(IDecl, TUScope, false); 1400 CurContext->makeDeclVisibleInContext(IDecl, true); 1401 } 1402 1403 Interfaces.push_back(IDecl); 1404 } 1405 1406 assert(Interfaces.size() == NumElts); 1407 ObjCClassDecl *CDecl = ObjCClassDecl::Create(Context, CurContext, AtClassLoc, 1408 Interfaces.data(), IdentLocs, 1409 Interfaces.size()); 1410 CurContext->addDecl(CDecl); 1411 CheckObjCDeclScope(CDecl); 1412 return DeclPtrTy::make(CDecl); 1413} 1414 1415 1416/// MatchTwoMethodDeclarations - Checks that two methods have matching type and 1417/// returns true, or false, accordingly. 1418/// TODO: Handle protocol list; such as id<p1,p2> in type comparisons 1419bool Sema::MatchTwoMethodDeclarations(const ObjCMethodDecl *Method, 1420 const ObjCMethodDecl *PrevMethod, 1421 bool matchBasedOnSizeAndAlignment) { 1422 QualType T1 = Context.getCanonicalType(Method->getResultType()); 1423 QualType T2 = Context.getCanonicalType(PrevMethod->getResultType()); 1424 1425 if (T1 != T2) { 1426 // The result types are different. 1427 if (!matchBasedOnSizeAndAlignment) 1428 return false; 1429 // Incomplete types don't have a size and alignment. 1430 if (T1->isIncompleteType() || T2->isIncompleteType()) 1431 return false; 1432 // Check is based on size and alignment. 1433 if (Context.getTypeInfo(T1) != Context.getTypeInfo(T2)) 1434 return false; 1435 } 1436 1437 ObjCMethodDecl::param_iterator ParamI = Method->param_begin(), 1438 E = Method->param_end(); 1439 ObjCMethodDecl::param_iterator PrevI = PrevMethod->param_begin(); 1440 1441 for (; ParamI != E; ++ParamI, ++PrevI) { 1442 assert(PrevI != PrevMethod->param_end() && "Param mismatch"); 1443 T1 = Context.getCanonicalType((*ParamI)->getType()); 1444 T2 = Context.getCanonicalType((*PrevI)->getType()); 1445 if (T1 != T2) { 1446 // The result types are different. 1447 if (!matchBasedOnSizeAndAlignment) 1448 return false; 1449 // Incomplete types don't have a size and alignment. 1450 if (T1->isIncompleteType() || T2->isIncompleteType()) 1451 return false; 1452 // Check is based on size and alignment. 1453 if (Context.getTypeInfo(T1) != Context.getTypeInfo(T2)) 1454 return false; 1455 } 1456 } 1457 return true; 1458} 1459 1460/// \brief Read the contents of the instance and factory method pools 1461/// for a given selector from external storage. 1462/// 1463/// This routine should only be called once, when neither the instance 1464/// nor the factory method pool has an entry for this selector. 1465Sema::MethodPool::iterator Sema::ReadMethodPool(Selector Sel, 1466 bool isInstance) { 1467 assert(ExternalSource && "We need an external AST source"); 1468 assert(InstanceMethodPool.find(Sel) == InstanceMethodPool.end() && 1469 "Selector data already loaded into the instance method pool"); 1470 assert(FactoryMethodPool.find(Sel) == FactoryMethodPool.end() && 1471 "Selector data already loaded into the factory method pool"); 1472 1473 // Read the method list from the external source. 1474 std::pair<ObjCMethodList, ObjCMethodList> Methods 1475 = ExternalSource->ReadMethodPool(Sel); 1476 1477 if (isInstance) { 1478 if (Methods.second.Method) 1479 FactoryMethodPool[Sel] = Methods.second; 1480 return InstanceMethodPool.insert(std::make_pair(Sel, Methods.first)).first; 1481 } 1482 1483 if (Methods.first.Method) 1484 InstanceMethodPool[Sel] = Methods.first; 1485 1486 return FactoryMethodPool.insert(std::make_pair(Sel, Methods.second)).first; 1487} 1488 1489void Sema::AddInstanceMethodToGlobalPool(ObjCMethodDecl *Method) { 1490 llvm::DenseMap<Selector, ObjCMethodList>::iterator Pos 1491 = InstanceMethodPool.find(Method->getSelector()); 1492 if (Pos == InstanceMethodPool.end()) { 1493 if (ExternalSource && !FactoryMethodPool.count(Method->getSelector())) 1494 Pos = ReadMethodPool(Method->getSelector(), /*isInstance=*/true); 1495 else 1496 Pos = InstanceMethodPool.insert(std::make_pair(Method->getSelector(), 1497 ObjCMethodList())).first; 1498 } 1499 1500 ObjCMethodList &Entry = Pos->second; 1501 if (Entry.Method == 0) { 1502 // Haven't seen a method with this selector name yet - add it. 1503 Entry.Method = Method; 1504 Entry.Next = 0; 1505 return; 1506 } 1507 1508 // We've seen a method with this name, see if we have already seen this type 1509 // signature. 1510 for (ObjCMethodList *List = &Entry; List; List = List->Next) 1511 if (MatchTwoMethodDeclarations(Method, List->Method)) 1512 return; 1513 1514 // We have a new signature for an existing method - add it. 1515 // This is extremely rare. Only 1% of Cocoa selectors are "overloaded". 1516 ObjCMethodList *Mem = BumpAlloc.Allocate<ObjCMethodList>(); 1517 Entry.Next = new (Mem) ObjCMethodList(Method, Entry.Next); 1518} 1519 1520// FIXME: Finish implementing -Wno-strict-selector-match. 1521ObjCMethodDecl *Sema::LookupInstanceMethodInGlobalPool(Selector Sel, 1522 SourceRange R, 1523 bool warn) { 1524 llvm::DenseMap<Selector, ObjCMethodList>::iterator Pos 1525 = InstanceMethodPool.find(Sel); 1526 if (Pos == InstanceMethodPool.end()) { 1527 if (ExternalSource && !FactoryMethodPool.count(Sel)) 1528 Pos = ReadMethodPool(Sel, /*isInstance=*/true); 1529 else 1530 return 0; 1531 } 1532 1533 ObjCMethodList &MethList = Pos->second; 1534 bool issueWarning = false; 1535 1536 if (MethList.Method && MethList.Next) { 1537 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) 1538 // This checks if the methods differ by size & alignment. 1539 if (!MatchTwoMethodDeclarations(MethList.Method, Next->Method, true)) 1540 issueWarning = warn; 1541 } 1542 if (issueWarning && (MethList.Method && MethList.Next)) { 1543 Diag(R.getBegin(), diag::warn_multiple_method_decl) << Sel << R; 1544 Diag(MethList.Method->getLocStart(), diag::note_using) 1545 << MethList.Method->getSourceRange(); 1546 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) 1547 Diag(Next->Method->getLocStart(), diag::note_also_found) 1548 << Next->Method->getSourceRange(); 1549 } 1550 return MethList.Method; 1551} 1552 1553void Sema::AddFactoryMethodToGlobalPool(ObjCMethodDecl *Method) { 1554 llvm::DenseMap<Selector, ObjCMethodList>::iterator Pos 1555 = FactoryMethodPool.find(Method->getSelector()); 1556 if (Pos == FactoryMethodPool.end()) { 1557 if (ExternalSource && !InstanceMethodPool.count(Method->getSelector())) 1558 Pos = ReadMethodPool(Method->getSelector(), /*isInstance=*/false); 1559 else 1560 Pos = FactoryMethodPool.insert(std::make_pair(Method->getSelector(), 1561 ObjCMethodList())).first; 1562 } 1563 1564 ObjCMethodList &FirstMethod = Pos->second; 1565 if (!FirstMethod.Method) { 1566 // Haven't seen a method with this selector name yet - add it. 1567 FirstMethod.Method = Method; 1568 FirstMethod.Next = 0; 1569 } else { 1570 // We've seen a method with this name, now check the type signature(s). 1571 bool match = MatchTwoMethodDeclarations(Method, FirstMethod.Method); 1572 1573 for (ObjCMethodList *Next = FirstMethod.Next; !match && Next; 1574 Next = Next->Next) 1575 match = MatchTwoMethodDeclarations(Method, Next->Method); 1576 1577 if (!match) { 1578 // We have a new signature for an existing method - add it. 1579 // This is extremely rare. Only 1% of Cocoa selectors are "overloaded". 1580 ObjCMethodList *Mem = BumpAlloc.Allocate<ObjCMethodList>(); 1581 ObjCMethodList *OMI = new (Mem) ObjCMethodList(Method, FirstMethod.Next); 1582 FirstMethod.Next = OMI; 1583 } 1584 } 1585} 1586 1587ObjCMethodDecl *Sema::LookupFactoryMethodInGlobalPool(Selector Sel, 1588 SourceRange R) { 1589 llvm::DenseMap<Selector, ObjCMethodList>::iterator Pos 1590 = FactoryMethodPool.find(Sel); 1591 if (Pos == FactoryMethodPool.end()) { 1592 if (ExternalSource && !InstanceMethodPool.count(Sel)) 1593 Pos = ReadMethodPool(Sel, /*isInstance=*/false); 1594 else 1595 return 0; 1596 } 1597 1598 ObjCMethodList &MethList = Pos->second; 1599 bool issueWarning = false; 1600 1601 if (MethList.Method && MethList.Next) { 1602 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) 1603 // This checks if the methods differ by size & alignment. 1604 if (!MatchTwoMethodDeclarations(MethList.Method, Next->Method, true)) 1605 issueWarning = true; 1606 } 1607 if (issueWarning && (MethList.Method && MethList.Next)) { 1608 Diag(R.getBegin(), diag::warn_multiple_method_decl) << Sel << R; 1609 Diag(MethList.Method->getLocStart(), diag::note_using) 1610 << MethList.Method->getSourceRange(); 1611 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) 1612 Diag(Next->Method->getLocStart(), diag::note_also_found) 1613 << Next->Method->getSourceRange(); 1614 } 1615 return MethList.Method; 1616} 1617 1618/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 1619/// have the property type and issue diagnostics if they don't. 1620/// Also synthesize a getter/setter method if none exist (and update the 1621/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 1622/// methods is the "right" thing to do. 1623void Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 1624 ObjCContainerDecl *CD) { 1625 ObjCMethodDecl *GetterMethod, *SetterMethod; 1626 1627 GetterMethod = CD->getInstanceMethod(property->getGetterName()); 1628 SetterMethod = CD->getInstanceMethod(property->getSetterName()); 1629 DiagnosePropertyAccessorMismatch(property, GetterMethod, 1630 property->getLocation()); 1631 1632 if (SetterMethod) { 1633 ObjCPropertyDecl::PropertyAttributeKind CAttr = 1634 property->getPropertyAttributes(); 1635 if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 1636 Context.getCanonicalType(SetterMethod->getResultType()) != 1637 Context.VoidTy) 1638 Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 1639 if (SetterMethod->param_size() != 1 || 1640 ((*SetterMethod->param_begin())->getType() != property->getType())) { 1641 Diag(property->getLocation(), 1642 diag::warn_accessor_property_type_mismatch) 1643 << property->getDeclName() 1644 << SetterMethod->getSelector(); 1645 Diag(SetterMethod->getLocation(), diag::note_declared_at); 1646 } 1647 } 1648 1649 // Synthesize getter/setter methods if none exist. 1650 // Find the default getter and if one not found, add one. 1651 // FIXME: The synthesized property we set here is misleading. We almost always 1652 // synthesize these methods unless the user explicitly provided prototypes 1653 // (which is odd, but allowed). Sema should be typechecking that the 1654 // declarations jive in that situation (which it is not currently). 1655 if (!GetterMethod) { 1656 // No instance method of same name as property getter name was found. 1657 // Declare a getter method and add it to the list of methods 1658 // for this class. 1659 GetterMethod = ObjCMethodDecl::Create(Context, property->getLocation(), 1660 property->getLocation(), property->getGetterName(), 1661 property->getType(), CD, true, false, true, 1662 (property->getPropertyImplementation() == 1663 ObjCPropertyDecl::Optional) ? 1664 ObjCMethodDecl::Optional : 1665 ObjCMethodDecl::Required); 1666 CD->addDecl(GetterMethod); 1667 } else 1668 // A user declared getter will be synthesize when @synthesize of 1669 // the property with the same name is seen in the @implementation 1670 GetterMethod->setSynthesized(true); 1671 property->setGetterMethodDecl(GetterMethod); 1672 1673 // Skip setter if property is read-only. 1674 if (!property->isReadOnly()) { 1675 // Find the default setter and if one not found, add one. 1676 if (!SetterMethod) { 1677 // No instance method of same name as property setter name was found. 1678 // Declare a setter method and add it to the list of methods 1679 // for this class. 1680 SetterMethod = ObjCMethodDecl::Create(Context, property->getLocation(), 1681 property->getLocation(), 1682 property->getSetterName(), 1683 Context.VoidTy, CD, true, false, true, 1684 (property->getPropertyImplementation() == 1685 ObjCPropertyDecl::Optional) ? 1686 ObjCMethodDecl::Optional : 1687 ObjCMethodDecl::Required); 1688 // Invent the arguments for the setter. We don't bother making a 1689 // nice name for the argument. 1690 ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 1691 property->getLocation(), 1692 property->getIdentifier(), 1693 property->getType(), 1694 /*TInfo=*/0, 1695 VarDecl::None, 1696 0); 1697 SetterMethod->setMethodParams(Context, &Argument, 1); 1698 CD->addDecl(SetterMethod); 1699 } else 1700 // A user declared setter will be synthesize when @synthesize of 1701 // the property with the same name is seen in the @implementation 1702 SetterMethod->setSynthesized(true); 1703 property->setSetterMethodDecl(SetterMethod); 1704 } 1705 // Add any synthesized methods to the global pool. This allows us to 1706 // handle the following, which is supported by GCC (and part of the design). 1707 // 1708 // @interface Foo 1709 // @property double bar; 1710 // @end 1711 // 1712 // void thisIsUnfortunate() { 1713 // id foo; 1714 // double bar = [foo bar]; 1715 // } 1716 // 1717 if (GetterMethod) 1718 AddInstanceMethodToGlobalPool(GetterMethod); 1719 if (SetterMethod) 1720 AddInstanceMethodToGlobalPool(SetterMethod); 1721} 1722 1723/// CompareMethodParamsInBaseAndSuper - This routine compares methods with 1724/// identical selector names in current and its super classes and issues 1725/// a warning if any of their argument types are incompatible. 1726void Sema::CompareMethodParamsInBaseAndSuper(Decl *ClassDecl, 1727 ObjCMethodDecl *Method, 1728 bool IsInstance) { 1729 ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(ClassDecl); 1730 if (ID == 0) return; 1731 1732 while (ObjCInterfaceDecl *SD = ID->getSuperClass()) { 1733 ObjCMethodDecl *SuperMethodDecl = 1734 SD->lookupMethod(Method->getSelector(), IsInstance); 1735 if (SuperMethodDecl == 0) { 1736 ID = SD; 1737 continue; 1738 } 1739 ObjCMethodDecl::param_iterator ParamI = Method->param_begin(), 1740 E = Method->param_end(); 1741 ObjCMethodDecl::param_iterator PrevI = SuperMethodDecl->param_begin(); 1742 for (; ParamI != E; ++ParamI, ++PrevI) { 1743 // Number of parameters are the same and is guaranteed by selector match. 1744 assert(PrevI != SuperMethodDecl->param_end() && "Param mismatch"); 1745 QualType T1 = Context.getCanonicalType((*ParamI)->getType()); 1746 QualType T2 = Context.getCanonicalType((*PrevI)->getType()); 1747 // If type of arguement of method in this class does not match its 1748 // respective argument type in the super class method, issue warning; 1749 if (!Context.typesAreCompatible(T1, T2)) { 1750 Diag((*ParamI)->getLocation(), diag::ext_typecheck_base_super) 1751 << T1 << T2; 1752 Diag(SuperMethodDecl->getLocation(), diag::note_previous_declaration); 1753 return; 1754 } 1755 } 1756 ID = SD; 1757 } 1758} 1759 1760// Note: For class/category implemenations, allMethods/allProperties is 1761// always null. 1762void Sema::ActOnAtEnd(SourceRange AtEnd, 1763 DeclPtrTy classDecl, 1764 DeclPtrTy *allMethods, unsigned allNum, 1765 DeclPtrTy *allProperties, unsigned pNum, 1766 DeclGroupPtrTy *allTUVars, unsigned tuvNum) { 1767 Decl *ClassDecl = classDecl.getAs<Decl>(); 1768 1769 // FIXME: If we don't have a ClassDecl, we have an error. We should consider 1770 // always passing in a decl. If the decl has an error, isInvalidDecl() 1771 // should be true. 1772 if (!ClassDecl) 1773 return; 1774 1775 bool isInterfaceDeclKind = 1776 isa<ObjCInterfaceDecl>(ClassDecl) || isa<ObjCCategoryDecl>(ClassDecl) 1777 || isa<ObjCProtocolDecl>(ClassDecl); 1778 bool checkIdenticalMethods = isa<ObjCImplementationDecl>(ClassDecl); 1779 1780 if (!isInterfaceDeclKind && AtEnd.isInvalid()) { 1781 // FIXME: This is wrong. We shouldn't be pretending that there is 1782 // an '@end' in the declaration. 1783 SourceLocation L = ClassDecl->getLocation(); 1784 AtEnd.setBegin(L); 1785 AtEnd.setEnd(L); 1786 Diag(L, diag::warn_missing_atend); 1787 } 1788 1789 DeclContext *DC = dyn_cast<DeclContext>(ClassDecl); 1790 1791 // FIXME: Remove these and use the ObjCContainerDecl/DeclContext. 1792 llvm::DenseMap<Selector, const ObjCMethodDecl*> InsMap; 1793 llvm::DenseMap<Selector, const ObjCMethodDecl*> ClsMap; 1794 1795 for (unsigned i = 0; i < allNum; i++ ) { 1796 ObjCMethodDecl *Method = 1797 cast_or_null<ObjCMethodDecl>(allMethods[i].getAs<Decl>()); 1798 1799 if (!Method) continue; // Already issued a diagnostic. 1800 if (Method->isInstanceMethod()) { 1801 /// Check for instance method of the same name with incompatible types 1802 const ObjCMethodDecl *&PrevMethod = InsMap[Method->getSelector()]; 1803 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod) 1804 : false; 1805 if ((isInterfaceDeclKind && PrevMethod && !match) 1806 || (checkIdenticalMethods && match)) { 1807 Diag(Method->getLocation(), diag::err_duplicate_method_decl) 1808 << Method->getDeclName(); 1809 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 1810 } else { 1811 DC->addDecl(Method); 1812 InsMap[Method->getSelector()] = Method; 1813 /// The following allows us to typecheck messages to "id". 1814 AddInstanceMethodToGlobalPool(Method); 1815 // verify that the instance method conforms to the same definition of 1816 // parent methods if it shadows one. 1817 CompareMethodParamsInBaseAndSuper(ClassDecl, Method, true); 1818 } 1819 } else { 1820 /// Check for class method of the same name with incompatible types 1821 const ObjCMethodDecl *&PrevMethod = ClsMap[Method->getSelector()]; 1822 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod) 1823 : false; 1824 if ((isInterfaceDeclKind && PrevMethod && !match) 1825 || (checkIdenticalMethods && match)) { 1826 Diag(Method->getLocation(), diag::err_duplicate_method_decl) 1827 << Method->getDeclName(); 1828 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 1829 } else { 1830 DC->addDecl(Method); 1831 ClsMap[Method->getSelector()] = Method; 1832 /// The following allows us to typecheck messages to "Class". 1833 AddFactoryMethodToGlobalPool(Method); 1834 // verify that the class method conforms to the same definition of 1835 // parent methods if it shadows one. 1836 CompareMethodParamsInBaseAndSuper(ClassDecl, Method, false); 1837 } 1838 } 1839 } 1840 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 1841 // Compares properties declared in this class to those of its 1842 // super class. 1843 ComparePropertiesInBaseAndSuper(I); 1844 CompareProperties(I, DeclPtrTy::make(I)); 1845 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 1846 // Categories are used to extend the class by declaring new methods. 1847 // By the same token, they are also used to add new properties. No 1848 // need to compare the added property to those in the class. 1849 1850 // Compare protocol properties with those in category 1851 CompareProperties(C, DeclPtrTy::make(C)); 1852 if (C->IsClassExtension()) 1853 DiagnoseClassExtensionDupMethods(C, C->getClassInterface()); 1854 } 1855 if (ObjCContainerDecl *CDecl = dyn_cast<ObjCContainerDecl>(ClassDecl)) { 1856 if (CDecl->getIdentifier()) 1857 // ProcessPropertyDecl is responsible for diagnosing conflicts with any 1858 // user-defined setter/getter. It also synthesizes setter/getter methods 1859 // and adds them to the DeclContext and global method pools. 1860 for (ObjCContainerDecl::prop_iterator I = CDecl->prop_begin(), 1861 E = CDecl->prop_end(); 1862 I != E; ++I) 1863 ProcessPropertyDecl(*I, CDecl); 1864 CDecl->setAtEndRange(AtEnd); 1865 } 1866 if (ObjCImplementationDecl *IC=dyn_cast<ObjCImplementationDecl>(ClassDecl)) { 1867 IC->setAtEndRange(AtEnd); 1868 if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) { 1869 ImplMethodsVsClassMethods(IC, IDecl); 1870 AtomicPropertySetterGetterRules(IC, IDecl); 1871 } 1872 } else if (ObjCCategoryImplDecl* CatImplClass = 1873 dyn_cast<ObjCCategoryImplDecl>(ClassDecl)) { 1874 CatImplClass->setAtEndRange(AtEnd); 1875 1876 // Find category interface decl and then check that all methods declared 1877 // in this interface are implemented in the category @implementation. 1878 if (ObjCInterfaceDecl* IDecl = CatImplClass->getClassInterface()) { 1879 for (ObjCCategoryDecl *Categories = IDecl->getCategoryList(); 1880 Categories; Categories = Categories->getNextClassCategory()) { 1881 if (Categories->getIdentifier() == CatImplClass->getIdentifier()) { 1882 ImplMethodsVsClassMethods(CatImplClass, Categories); 1883 break; 1884 } 1885 } 1886 } 1887 } 1888 if (isInterfaceDeclKind) { 1889 // Reject invalid vardecls. 1890 for (unsigned i = 0; i != tuvNum; i++) { 1891 DeclGroupRef DG = allTUVars[i].getAsVal<DeclGroupRef>(); 1892 for (DeclGroupRef::iterator I = DG.begin(), E = DG.end(); I != E; ++I) 1893 if (VarDecl *VDecl = dyn_cast<VarDecl>(*I)) { 1894 if (!VDecl->hasExternalStorage()) 1895 Diag(VDecl->getLocation(), diag::err_objc_var_decl_inclass); 1896 } 1897 } 1898 } 1899} 1900 1901 1902/// CvtQTToAstBitMask - utility routine to produce an AST bitmask for 1903/// objective-c's type qualifier from the parser version of the same info. 1904static Decl::ObjCDeclQualifier 1905CvtQTToAstBitMask(ObjCDeclSpec::ObjCDeclQualifier PQTVal) { 1906 Decl::ObjCDeclQualifier ret = Decl::OBJC_TQ_None; 1907 if (PQTVal & ObjCDeclSpec::DQ_In) 1908 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_In); 1909 if (PQTVal & ObjCDeclSpec::DQ_Inout) 1910 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Inout); 1911 if (PQTVal & ObjCDeclSpec::DQ_Out) 1912 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Out); 1913 if (PQTVal & ObjCDeclSpec::DQ_Bycopy) 1914 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Bycopy); 1915 if (PQTVal & ObjCDeclSpec::DQ_Byref) 1916 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Byref); 1917 if (PQTVal & ObjCDeclSpec::DQ_Oneway) 1918 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Oneway); 1919 1920 return ret; 1921} 1922 1923Sema::DeclPtrTy Sema::ActOnMethodDeclaration( 1924 SourceLocation MethodLoc, SourceLocation EndLoc, 1925 tok::TokenKind MethodType, DeclPtrTy classDecl, 1926 ObjCDeclSpec &ReturnQT, TypeTy *ReturnType, 1927 Selector Sel, 1928 // optional arguments. The number of types/arguments is obtained 1929 // from the Sel.getNumArgs(). 1930 ObjCArgInfo *ArgInfo, 1931 llvm::SmallVectorImpl<Declarator> &Cdecls, 1932 AttributeList *AttrList, tok::ObjCKeywordKind MethodDeclKind, 1933 bool isVariadic) { 1934 Decl *ClassDecl = classDecl.getAs<Decl>(); 1935 1936 // Make sure we can establish a context for the method. 1937 if (!ClassDecl) { 1938 Diag(MethodLoc, diag::error_missing_method_context); 1939 FunctionLabelMap.clear(); 1940 return DeclPtrTy(); 1941 } 1942 QualType resultDeclType; 1943 1944 if (ReturnType) { 1945 resultDeclType = GetTypeFromParser(ReturnType); 1946 1947 // Methods cannot return interface types. All ObjC objects are 1948 // passed by reference. 1949 if (resultDeclType->isObjCInterfaceType()) { 1950 Diag(MethodLoc, diag::err_object_cannot_be_passed_returned_by_value) 1951 << 0 << resultDeclType; 1952 return DeclPtrTy(); 1953 } 1954 } else // get the type for "id". 1955 resultDeclType = Context.getObjCIdType(); 1956 1957 ObjCMethodDecl* ObjCMethod = 1958 ObjCMethodDecl::Create(Context, MethodLoc, EndLoc, Sel, resultDeclType, 1959 cast<DeclContext>(ClassDecl), 1960 MethodType == tok::minus, isVariadic, 1961 false, 1962 MethodDeclKind == tok::objc_optional ? 1963 ObjCMethodDecl::Optional : 1964 ObjCMethodDecl::Required); 1965 1966 llvm::SmallVector<ParmVarDecl*, 16> Params; 1967 1968 for (unsigned i = 0, e = Sel.getNumArgs(); i != e; ++i) { 1969 QualType ArgType; 1970 TypeSourceInfo *DI; 1971 1972 if (ArgInfo[i].Type == 0) { 1973 ArgType = Context.getObjCIdType(); 1974 DI = 0; 1975 } else { 1976 ArgType = GetTypeFromParser(ArgInfo[i].Type, &DI); 1977 // Perform the default array/function conversions (C99 6.7.5.3p[7,8]). 1978 ArgType = adjustParameterType(ArgType); 1979 } 1980 1981 ParmVarDecl* Param 1982 = ParmVarDecl::Create(Context, ObjCMethod, ArgInfo[i].NameLoc, 1983 ArgInfo[i].Name, ArgType, DI, 1984 VarDecl::None, 0); 1985 1986 if (ArgType->isObjCInterfaceType()) { 1987 Diag(ArgInfo[i].NameLoc, 1988 diag::err_object_cannot_be_passed_returned_by_value) 1989 << 1 << ArgType; 1990 Param->setInvalidDecl(); 1991 } 1992 1993 Param->setObjCDeclQualifier( 1994 CvtQTToAstBitMask(ArgInfo[i].DeclSpec.getObjCDeclQualifier())); 1995 1996 // Apply the attributes to the parameter. 1997 ProcessDeclAttributeList(TUScope, Param, ArgInfo[i].ArgAttrs); 1998 1999 Params.push_back(Param); 2000 } 2001 2002 ObjCMethod->setMethodParams(Context, Params.data(), Sel.getNumArgs()); 2003 ObjCMethod->setObjCDeclQualifier( 2004 CvtQTToAstBitMask(ReturnQT.getObjCDeclQualifier())); 2005 const ObjCMethodDecl *PrevMethod = 0; 2006 2007 if (AttrList) 2008 ProcessDeclAttributeList(TUScope, ObjCMethod, AttrList); 2009 2010 const ObjCMethodDecl *InterfaceMD = 0; 2011 2012 // For implementations (which can be very "coarse grain"), we add the 2013 // method now. This allows the AST to implement lookup methods that work 2014 // incrementally (without waiting until we parse the @end). It also allows 2015 // us to flag multiple declaration errors as they occur. 2016 if (ObjCImplementationDecl *ImpDecl = 2017 dyn_cast<ObjCImplementationDecl>(ClassDecl)) { 2018 if (MethodType == tok::minus) { 2019 PrevMethod = ImpDecl->getInstanceMethod(Sel); 2020 ImpDecl->addInstanceMethod(ObjCMethod); 2021 } else { 2022 PrevMethod = ImpDecl->getClassMethod(Sel); 2023 ImpDecl->addClassMethod(ObjCMethod); 2024 } 2025 InterfaceMD = ImpDecl->getClassInterface()->getMethod(Sel, 2026 MethodType == tok::minus); 2027 if (AttrList) 2028 Diag(EndLoc, diag::warn_attribute_method_def); 2029 } else if (ObjCCategoryImplDecl *CatImpDecl = 2030 dyn_cast<ObjCCategoryImplDecl>(ClassDecl)) { 2031 if (MethodType == tok::minus) { 2032 PrevMethod = CatImpDecl->getInstanceMethod(Sel); 2033 CatImpDecl->addInstanceMethod(ObjCMethod); 2034 } else { 2035 PrevMethod = CatImpDecl->getClassMethod(Sel); 2036 CatImpDecl->addClassMethod(ObjCMethod); 2037 } 2038 if (AttrList) 2039 Diag(EndLoc, diag::warn_attribute_method_def); 2040 } 2041 if (PrevMethod) { 2042 // You can never have two method definitions with the same name. 2043 Diag(ObjCMethod->getLocation(), diag::err_duplicate_method_decl) 2044 << ObjCMethod->getDeclName(); 2045 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 2046 } 2047 2048 // If the interface declared this method, and it was deprecated there, 2049 // mark it deprecated here. 2050 if (InterfaceMD && InterfaceMD->hasAttr<DeprecatedAttr>()) 2051 ObjCMethod->addAttr(::new (Context) DeprecatedAttr()); 2052 2053 return DeclPtrTy::make(ObjCMethod); 2054} 2055 2056void Sema::CheckObjCPropertyAttributes(QualType PropertyTy, 2057 SourceLocation Loc, 2058 unsigned &Attributes) { 2059 // FIXME: Improve the reported location. 2060 2061 // readonly and readwrite/assign/retain/copy conflict. 2062 if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2063 (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 2064 ObjCDeclSpec::DQ_PR_assign | 2065 ObjCDeclSpec::DQ_PR_copy | 2066 ObjCDeclSpec::DQ_PR_retain))) { 2067 const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 2068 "readwrite" : 2069 (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 2070 "assign" : 2071 (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 2072 "copy" : "retain"; 2073 2074 Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 2075 diag::err_objc_property_attr_mutually_exclusive : 2076 diag::warn_objc_property_attr_mutually_exclusive) 2077 << "readonly" << which; 2078 } 2079 2080 // Check for copy or retain on non-object types. 2081 if ((Attributes & (ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain)) && 2082 !PropertyTy->isObjCObjectPointerType() && 2083 !PropertyTy->isBlockPointerType() && 2084 !Context.isObjCNSObjectType(PropertyTy)) { 2085 Diag(Loc, diag::err_objc_property_requires_object) 2086 << (Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain"); 2087 Attributes &= ~(ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain); 2088 } 2089 2090 // Check for more than one of { assign, copy, retain }. 2091 if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 2092 if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 2093 Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2094 << "assign" << "copy"; 2095 Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 2096 } 2097 if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 2098 Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2099 << "assign" << "retain"; 2100 Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 2101 } 2102 } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 2103 if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 2104 Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2105 << "copy" << "retain"; 2106 Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 2107 } 2108 } 2109 2110 // Warn if user supplied no assignment attribute, property is 2111 // readwrite, and this is an object type. 2112 if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 2113 ObjCDeclSpec::DQ_PR_retain)) && 2114 !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2115 PropertyTy->isObjCObjectPointerType()) { 2116 // Skip this warning in gc-only mode. 2117 if (getLangOptions().getGCMode() != LangOptions::GCOnly) 2118 Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 2119 2120 // If non-gc code warn that this is likely inappropriate. 2121 if (getLangOptions().getGCMode() == LangOptions::NonGC) 2122 Diag(Loc, diag::warn_objc_property_default_assign_on_object); 2123 2124 // FIXME: Implement warning dependent on NSCopying being 2125 // implemented. See also: 2126 // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 2127 // (please trim this list while you are at it). 2128 } 2129 2130 if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 2131 && getLangOptions().getGCMode() == LangOptions::GCOnly 2132 && PropertyTy->isBlockPointerType()) 2133 Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 2134} 2135 2136Sema::DeclPtrTy Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 2137 FieldDeclarator &FD, 2138 ObjCDeclSpec &ODS, 2139 Selector GetterSel, 2140 Selector SetterSel, 2141 DeclPtrTy ClassCategory, 2142 bool *isOverridingProperty, 2143 tok::ObjCKeywordKind MethodImplKind) { 2144 unsigned Attributes = ODS.getPropertyAttributes(); 2145 bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 2146 // default is readwrite! 2147 !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 2148 // property is defaulted to 'assign' if it is readwrite and is 2149 // not retain or copy 2150 bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 2151 (isReadWrite && 2152 !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 2153 !(Attributes & ObjCDeclSpec::DQ_PR_copy))); 2154 QualType T = GetTypeForDeclarator(FD.D, S); 2155 if (T->isReferenceType()) { 2156 Diag(AtLoc, diag::error_reference_property); 2157 return DeclPtrTy(); 2158 } 2159 Decl *ClassDecl = ClassCategory.getAs<Decl>(); 2160 ObjCInterfaceDecl *CCPrimary = 0; // continuation class's primary class 2161 // May modify Attributes. 2162 CheckObjCPropertyAttributes(T, AtLoc, Attributes); 2163 if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 2164 if (CDecl->IsClassExtension()) { 2165 // Diagnose if this property is already in continuation class. 2166 DeclContext *DC = dyn_cast<DeclContext>(ClassDecl); 2167 assert(DC && "ClassDecl is not a DeclContext"); 2168 DeclContext::lookup_result Found = DC->lookup(FD.D.getIdentifier()); 2169 if (Found.first != Found.second && isa<ObjCPropertyDecl>(*Found.first)) { 2170 Diag(AtLoc, diag::err_duplicate_property); 2171 Diag((*Found.first)->getLocation(), diag::note_property_declare); 2172 return DeclPtrTy(); 2173 } 2174 ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 2175 FD.D.getIdentifierLoc(), 2176 FD.D.getIdentifier(), 2177 AtLoc, T); 2178 DC->addDecl(PDecl); 2179 2180 // This is a continuation class. property requires special 2181 // handling. 2182 if ((CCPrimary = CDecl->getClassInterface())) { 2183 // Find the property in continuation class's primary class only. 2184 IdentifierInfo *PropertyId = FD.D.getIdentifier(); 2185 if (ObjCPropertyDecl *PIDecl = 2186 CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId)) { 2187 // property 'PIDecl's readonly attribute will be over-ridden 2188 // with continuation class's readwrite property attribute! 2189 unsigned PIkind = PIDecl->getPropertyAttributes(); 2190 if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 2191 unsigned retainCopyNonatomic = 2192 (ObjCPropertyDecl::OBJC_PR_retain | 2193 ObjCPropertyDecl::OBJC_PR_copy | 2194 ObjCPropertyDecl::OBJC_PR_nonatomic); 2195 if ((Attributes & retainCopyNonatomic) != 2196 (PIkind & retainCopyNonatomic)) { 2197 Diag(AtLoc, diag::warn_property_attr_mismatch); 2198 Diag(PIDecl->getLocation(), diag::note_property_declare); 2199 } 2200 DeclContext *DC = dyn_cast<DeclContext>(CCPrimary); 2201 assert(DC && "ClassDecl is not a DeclContext"); 2202 DeclContext::lookup_result Found = 2203 DC->lookup(PIDecl->getDeclName()); 2204 bool PropertyInPrimaryClass = false; 2205 for (; Found.first != Found.second; ++Found.first) 2206 if (isa<ObjCPropertyDecl>(*Found.first)) { 2207 PropertyInPrimaryClass = true; 2208 break; 2209 } 2210 if (!PropertyInPrimaryClass) { 2211 // Protocol is not in the primary class. Must build one for it. 2212 ObjCDeclSpec ProtocolPropertyODS; 2213 // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind and 2214 // ObjCPropertyDecl::PropertyAttributeKind have identical values. 2215 // Should consolidate both into one enum type. 2216 ProtocolPropertyODS.setPropertyAttributes( 2217 (ObjCDeclSpec::ObjCPropertyAttributeKind)PIkind); 2218 DeclPtrTy ProtocolPtrTy = 2219 ActOnProperty(S, AtLoc, FD, ProtocolPropertyODS, 2220 PIDecl->getGetterName(), 2221 PIDecl->getSetterName(), 2222 DeclPtrTy::make(CCPrimary), isOverridingProperty, 2223 MethodImplKind); 2224 PIDecl = ProtocolPtrTy.getAs<ObjCPropertyDecl>(); 2225 } 2226 PIDecl->makeitReadWriteAttribute(); 2227 if (Attributes & ObjCDeclSpec::DQ_PR_retain) 2228 PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 2229 if (Attributes & ObjCDeclSpec::DQ_PR_copy) 2230 PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 2231 PIDecl->setSetterName(SetterSel); 2232 } else { 2233 Diag(AtLoc, diag::err_use_continuation_class) 2234 << CCPrimary->getDeclName(); 2235 Diag(PIDecl->getLocation(), diag::note_property_declare); 2236 } 2237 *isOverridingProperty = true; 2238 // Make sure setter decl is synthesized, and added to primary 2239 // class's list. 2240 ProcessPropertyDecl(PIDecl, CCPrimary); 2241 return DeclPtrTy(); 2242 } 2243 2244 // No matching property found in the primary class. Just fall thru 2245 // and add property to continuation class's primary class. 2246 ClassDecl = CCPrimary; 2247 } else { 2248 Diag(CDecl->getLocation(), diag::err_continuation_class); 2249 *isOverridingProperty = true; 2250 return DeclPtrTy(); 2251 } 2252 } 2253 2254 // Issue a warning if property is 'assign' as default and its object, which is 2255 // gc'able conforms to NSCopying protocol 2256 if (getLangOptions().getGCMode() != LangOptions::NonGC && 2257 isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 2258 if (T->isObjCObjectPointerType()) { 2259 QualType InterfaceTy = T->getPointeeType(); 2260 if (const ObjCInterfaceType *OIT = 2261 InterfaceTy->getAs<ObjCInterfaceType>()) { 2262 ObjCInterfaceDecl *IDecl = OIT->getDecl(); 2263 if (IDecl) 2264 if (ObjCProtocolDecl* PNSCopying = 2265 LookupProtocol(&Context.Idents.get("NSCopying"))) 2266 if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 2267 Diag(AtLoc, diag::warn_implements_nscopying) 2268 << FD.D.getIdentifier(); 2269 } 2270 } 2271 if (T->isObjCInterfaceType()) 2272 Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 2273 2274 DeclContext *DC = dyn_cast<DeclContext>(ClassDecl); 2275 assert(DC && "ClassDecl is not a DeclContext"); 2276 ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 2277 FD.D.getIdentifierLoc(), 2278 FD.D.getIdentifier(), 2279 AtLoc, T); 2280 DeclContext::lookup_result Found = DC->lookup(PDecl->getDeclName()); 2281 if (Found.first != Found.second && isa<ObjCPropertyDecl>(*Found.first)) { 2282 Diag(PDecl->getLocation(), diag::err_duplicate_property); 2283 Diag((*Found.first)->getLocation(), diag::note_property_declare); 2284 PDecl->setInvalidDecl(); 2285 } 2286 else 2287 DC->addDecl(PDecl); 2288 2289 if (T->isArrayType() || T->isFunctionType()) { 2290 Diag(AtLoc, diag::err_property_type) << T; 2291 PDecl->setInvalidDecl(); 2292 } 2293 2294 ProcessDeclAttributes(S, PDecl, FD.D); 2295 2296 // Regardless of setter/getter attribute, we save the default getter/setter 2297 // selector names in anticipation of declaration of setter/getter methods. 2298 PDecl->setGetterName(GetterSel); 2299 PDecl->setSetterName(SetterSel); 2300 2301 if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 2302 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 2303 2304 if (Attributes & ObjCDeclSpec::DQ_PR_getter) 2305 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 2306 2307 if (Attributes & ObjCDeclSpec::DQ_PR_setter) 2308 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 2309 2310 if (isReadWrite) 2311 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 2312 2313 if (Attributes & ObjCDeclSpec::DQ_PR_retain) 2314 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 2315 2316 if (Attributes & ObjCDeclSpec::DQ_PR_copy) 2317 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 2318 2319 if (isAssign) 2320 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 2321 2322 if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 2323 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 2324 2325 if (MethodImplKind == tok::objc_required) 2326 PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 2327 else if (MethodImplKind == tok::objc_optional) 2328 PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 2329 // A case of continuation class adding a new property in the class. This 2330 // is not what it was meant for. However, gcc supports it and so should we. 2331 // Make sure setter/getters are declared here. 2332 if (CCPrimary) 2333 ProcessPropertyDecl(PDecl, CCPrimary); 2334 2335 return DeclPtrTy::make(PDecl); 2336} 2337 2338ObjCIvarDecl* 2339Sema::SynthesizeNewPropertyIvar(ObjCInterfaceDecl *IDecl, 2340 IdentifierInfo *NameII) { 2341 ObjCIvarDecl *Ivar = 0; 2342 ObjCPropertyDecl *Prop = LookupPropertyDecl(IDecl, NameII); 2343 if (Prop && !Prop->isInvalidDecl()) { 2344 DeclContext *EnclosingContext = cast_or_null<DeclContext>(IDecl); 2345 QualType PropType = Context.getCanonicalType(Prop->getType()); 2346 assert(EnclosingContext && 2347 "null DeclContext for synthesized ivar - SynthesizeNewPropertyIvar"); 2348 Ivar = ObjCIvarDecl::Create(Context, EnclosingContext, 2349 Prop->getLocation(), 2350 NameII, PropType, /*Dinfo=*/0, 2351 ObjCIvarDecl::Public, 2352 (Expr *)0); 2353 Ivar->setLexicalDeclContext(IDecl); 2354 IDecl->addDecl(Ivar); 2355 Prop->setPropertyIvarDecl(Ivar); 2356 } 2357 return Ivar; 2358} 2359 2360/// ActOnPropertyImplDecl - This routine performs semantic checks and 2361/// builds the AST node for a property implementation declaration; declared 2362/// as @synthesize or @dynamic. 2363/// 2364Sema::DeclPtrTy Sema::ActOnPropertyImplDecl(SourceLocation AtLoc, 2365 SourceLocation PropertyLoc, 2366 bool Synthesize, 2367 DeclPtrTy ClassCatImpDecl, 2368 IdentifierInfo *PropertyId, 2369 IdentifierInfo *PropertyIvar) { 2370 Decl *ClassImpDecl = ClassCatImpDecl.getAs<Decl>(); 2371 // Make sure we have a context for the property implementation declaration. 2372 if (!ClassImpDecl) { 2373 Diag(AtLoc, diag::error_missing_property_context); 2374 return DeclPtrTy(); 2375 } 2376 ObjCPropertyDecl *property = 0; 2377 ObjCInterfaceDecl* IDecl = 0; 2378 // Find the class or category class where this property must have 2379 // a declaration. 2380 ObjCImplementationDecl *IC = 0; 2381 ObjCCategoryImplDecl* CatImplClass = 0; 2382 if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 2383 IDecl = IC->getClassInterface(); 2384 // We always synthesize an interface for an implementation 2385 // without an interface decl. So, IDecl is always non-zero. 2386 assert(IDecl && 2387 "ActOnPropertyImplDecl - @implementation without @interface"); 2388 2389 // Look for this property declaration in the @implementation's @interface 2390 property = IDecl->FindPropertyDeclaration(PropertyId); 2391 if (!property) { 2392 Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 2393 return DeclPtrTy(); 2394 } 2395 if (const ObjCCategoryDecl *CD = 2396 dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 2397 if (!CD->IsClassExtension()) { 2398 Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 2399 Diag(property->getLocation(), diag::note_property_declare); 2400 return DeclPtrTy(); 2401 } 2402 } 2403 } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 2404 if (Synthesize) { 2405 Diag(AtLoc, diag::error_synthesize_category_decl); 2406 return DeclPtrTy(); 2407 } 2408 IDecl = CatImplClass->getClassInterface(); 2409 if (!IDecl) { 2410 Diag(AtLoc, diag::error_missing_property_interface); 2411 return DeclPtrTy(); 2412 } 2413 ObjCCategoryDecl *Category = 2414 IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 2415 2416 // If category for this implementation not found, it is an error which 2417 // has already been reported eralier. 2418 if (!Category) 2419 return DeclPtrTy(); 2420 // Look for this property declaration in @implementation's category 2421 property = Category->FindPropertyDeclaration(PropertyId); 2422 if (!property) { 2423 Diag(PropertyLoc, diag::error_bad_category_property_decl) 2424 << Category->getDeclName(); 2425 return DeclPtrTy(); 2426 } 2427 } else { 2428 Diag(AtLoc, diag::error_bad_property_context); 2429 return DeclPtrTy(); 2430 } 2431 ObjCIvarDecl *Ivar = 0; 2432 // Check that we have a valid, previously declared ivar for @synthesize 2433 if (Synthesize) { 2434 // @synthesize 2435 if (!PropertyIvar) 2436 PropertyIvar = PropertyId; 2437 QualType PropType = Context.getCanonicalType(property->getType()); 2438 // Check that this is a previously declared 'ivar' in 'IDecl' interface 2439 ObjCInterfaceDecl *ClassDeclared; 2440 Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 2441 if (!Ivar) { 2442 DeclContext *EnclosingContext = cast_or_null<DeclContext>(IDecl); 2443 assert(EnclosingContext && 2444 "null DeclContext for synthesized ivar - ActOnPropertyImplDecl"); 2445 Ivar = ObjCIvarDecl::Create(Context, EnclosingContext, PropertyLoc, 2446 PropertyIvar, PropType, /*Dinfo=*/0, 2447 ObjCIvarDecl::Public, 2448 (Expr *)0); 2449 Ivar->setLexicalDeclContext(IDecl); 2450 IDecl->addDecl(Ivar); 2451 property->setPropertyIvarDecl(Ivar); 2452 if (!getLangOptions().ObjCNonFragileABI) 2453 Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId; 2454 // Note! I deliberately want it to fall thru so, we have a 2455 // a property implementation and to avoid future warnings. 2456 } else if (getLangOptions().ObjCNonFragileABI && 2457 ClassDeclared != IDecl) { 2458 Diag(PropertyLoc, diag::error_ivar_in_superclass_use) 2459 << property->getDeclName() << Ivar->getDeclName() 2460 << ClassDeclared->getDeclName(); 2461 Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 2462 << Ivar << Ivar->getNameAsCString(); 2463 // Note! I deliberately want it to fall thru so more errors are caught. 2464 } 2465 QualType IvarType = Context.getCanonicalType(Ivar->getType()); 2466 2467 // Check that type of property and its ivar are type compatible. 2468 if (PropType != IvarType) { 2469 if (CheckAssignmentConstraints(PropType, IvarType) != Compatible) { 2470 Diag(PropertyLoc, diag::error_property_ivar_type) 2471 << property->getDeclName() << Ivar->getDeclName(); 2472 // Note! I deliberately want it to fall thru so, we have a 2473 // a property implementation and to avoid future warnings. 2474 } 2475 2476 // FIXME! Rules for properties are somewhat different that those 2477 // for assignments. Use a new routine to consolidate all cases; 2478 // specifically for property redeclarations as well as for ivars. 2479 QualType lhsType =Context.getCanonicalType(PropType).getUnqualifiedType(); 2480 QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 2481 if (lhsType != rhsType && 2482 lhsType->isArithmeticType()) { 2483 Diag(PropertyLoc, diag::error_property_ivar_type) 2484 << property->getDeclName() << Ivar->getDeclName(); 2485 // Fall thru - see previous comment 2486 } 2487 // __weak is explicit. So it works on Canonical type. 2488 if (PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 2489 getLangOptions().getGCMode() != LangOptions::NonGC) { 2490 Diag(PropertyLoc, diag::error_weak_property) 2491 << property->getDeclName() << Ivar->getDeclName(); 2492 // Fall thru - see previous comment 2493 } 2494 if ((property->getType()->isObjCObjectPointerType() || 2495 PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 2496 getLangOptions().getGCMode() != LangOptions::NonGC) { 2497 Diag(PropertyLoc, diag::error_strong_property) 2498 << property->getDeclName() << Ivar->getDeclName(); 2499 // Fall thru - see previous comment 2500 } 2501 } 2502 } else if (PropertyIvar) 2503 // @dynamic 2504 Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl); 2505 assert (property && "ActOnPropertyImplDecl - property declaration missing"); 2506 ObjCPropertyImplDecl *PIDecl = 2507 ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 2508 property, 2509 (Synthesize ? 2510 ObjCPropertyImplDecl::Synthesize 2511 : ObjCPropertyImplDecl::Dynamic), 2512 Ivar); 2513 if (IC) { 2514 if (Synthesize) 2515 if (ObjCPropertyImplDecl *PPIDecl = 2516 IC->FindPropertyImplIvarDecl(PropertyIvar)) { 2517 Diag(PropertyLoc, diag::error_duplicate_ivar_use) 2518 << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 2519 << PropertyIvar; 2520 Diag(PPIDecl->getLocation(), diag::note_previous_use); 2521 } 2522 2523 if (ObjCPropertyImplDecl *PPIDecl 2524 = IC->FindPropertyImplDecl(PropertyId)) { 2525 Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 2526 Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 2527 return DeclPtrTy(); 2528 } 2529 IC->addPropertyImplementation(PIDecl); 2530 } else { 2531 if (Synthesize) 2532 if (ObjCPropertyImplDecl *PPIDecl = 2533 CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 2534 Diag(PropertyLoc, diag::error_duplicate_ivar_use) 2535 << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 2536 << PropertyIvar; 2537 Diag(PPIDecl->getLocation(), diag::note_previous_use); 2538 } 2539 2540 if (ObjCPropertyImplDecl *PPIDecl = 2541 CatImplClass->FindPropertyImplDecl(PropertyId)) { 2542 Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 2543 Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 2544 return DeclPtrTy(); 2545 } 2546 CatImplClass->addPropertyImplementation(PIDecl); 2547 } 2548 2549 return DeclPtrTy::make(PIDecl); 2550} 2551 2552bool Sema::CheckObjCDeclScope(Decl *D) { 2553 if (isa<TranslationUnitDecl>(CurContext->getLookupContext())) 2554 return false; 2555 2556 Diag(D->getLocation(), diag::err_objc_decls_may_only_appear_in_global_scope); 2557 D->setInvalidDecl(); 2558 2559 return true; 2560} 2561 2562/// Called whenever @defs(ClassName) is encountered in the source. Inserts the 2563/// instance variables of ClassName into Decls. 2564void Sema::ActOnDefs(Scope *S, DeclPtrTy TagD, SourceLocation DeclStart, 2565 IdentifierInfo *ClassName, 2566 llvm::SmallVectorImpl<DeclPtrTy> &Decls) { 2567 // Check that ClassName is a valid class 2568 ObjCInterfaceDecl *Class = getObjCInterfaceDecl(ClassName); 2569 if (!Class) { 2570 Diag(DeclStart, diag::err_undef_interface) << ClassName; 2571 return; 2572 } 2573 if (LangOpts.ObjCNonFragileABI) { 2574 Diag(DeclStart, diag::err_atdef_nonfragile_interface); 2575 return; 2576 } 2577 2578 // Collect the instance variables 2579 llvm::SmallVector<FieldDecl*, 32> RecFields; 2580 Context.CollectObjCIvars(Class, RecFields); 2581 // For each ivar, create a fresh ObjCAtDefsFieldDecl. 2582 for (unsigned i = 0; i < RecFields.size(); i++) { 2583 FieldDecl* ID = RecFields[i]; 2584 RecordDecl *Record = dyn_cast<RecordDecl>(TagD.getAs<Decl>()); 2585 Decl *FD = ObjCAtDefsFieldDecl::Create(Context, Record, ID->getLocation(), 2586 ID->getIdentifier(), ID->getType(), 2587 ID->getBitWidth()); 2588 Decls.push_back(Sema::DeclPtrTy::make(FD)); 2589 } 2590 2591 // Introduce all of these fields into the appropriate scope. 2592 for (llvm::SmallVectorImpl<DeclPtrTy>::iterator D = Decls.begin(); 2593 D != Decls.end(); ++D) { 2594 FieldDecl *FD = cast<FieldDecl>(D->getAs<Decl>()); 2595 if (getLangOptions().CPlusPlus) 2596 PushOnScopeChains(cast<FieldDecl>(FD), S); 2597 else if (RecordDecl *Record = dyn_cast<RecordDecl>(TagD.getAs<Decl>())) 2598 Record->addDecl(FD); 2599 } 2600} 2601 2602