History log of /hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
a0a88cf291e156344d5346c29824d996d1d81fab 08-Jan-2012 Steve Block <steveblock@google.com> Rename (IF_)LOGE(_IF) to (IF_)ALOGE(_IF) DO NOT MERGE

See https://android-git.corp.google.com/g/#/c/157220

Bug: 5449033
Change-Id: Iad3389731482399f1148ae9a19248e3eea55d9fd
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
85e28eec8163c776f2f3a093f4053a96ed2d6f98 04-Jan-2012 Steve Block <steveblock@google.com> Rename (IF_)LOGI(_IF) to (IF_)ALOGI(_IF) DO NOT MERGE

See https://android-git.corp.google.com/g/156801

Bug: 5449033
Change-Id: I4bfd860b833aacee06a60fa7648de2377aefafa6
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
dbcc6073c88ced818ea3e742f36191088222ca26 20-Dec-2011 Steve Block <steveblock@google.com> Rename (IF_)LOGD(_IF) to (IF_)ALOGD(_IF) DO NOT MERGE

See https://android-git.corp.google.com/g/156016

Bug: 5449033
Change-Id: I6bb39eabeda44ddbe59f396f1c6276b8d1aeb8c6
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
5e41d631147aa1fc9f4b52dc34941dde69f02a9a 26-Mar-2010 James Dong <jdong@google.com> Fix another EOS lost bug

TI's DSP has a special requirement for the second input buffer and assumes that
it contains valid data.

This patch contains a workaround to address the case where the assumption does
not hold and deal with it accordingly.

bug - 2338792

Change-Id: Iaa5382af557fe32891c5387b62c6c0c03b61f7a2
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
43a7253b0439ca1a6f69496e23343164735a6b12 17-Mar-2010 James Dong <jdong@google.com> Fix comparisons: unsigned values < 0

This patch was originally from MOT/TI
Modified to fix a small bug in the original patch.

bug - 2152611

Change-Id: Iee30350a6772389561826e63ad209e8143f71a13
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
08cf2e801dc7ec4f950a3f1245b21ff2b23d6b79 10-Mar-2010 James Dong <jdong@google.com> Fix a EOS problem which can potentially lead to hang during video playback
- The root cause was because cache coherence was not ensured
- It also fixed a bug where duplicate EOS may be returned

The solution was originally from TI.

bug - 2127793

Change-Id: Idd66e7bb110bf419230012d128c9bf104493fa2d
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
4aeb9f6cced922a2d338ed2f977cbfd0055eb674 08-Mar-2010 James Dong <jdong@google.com> Add some logging for potential reset problem in the decoder

bug - 2414536

Change-Id: Id46c4411470519a3d1b0ffb3c65340a56e4b0655
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
e0eb7d4e75801c01b26b1e6fc3670cd195f48591 15-Feb-2010 James Dong <jdong@google.com> First attempt to remove redundant consecutive calls to VIDDEC_Return
-rebased

bug - 2120211
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
a7d8550490e7973b12ab6aed936182ce30f882a1 18-Feb-2010 James Dong <jdong@google.com> Fix buffer ownership and buffer count when write fails

Originally from MOT/TI
Modified to add fix for the buffer count as well
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
81080e8c6e5fbb1d3bb01d707d832a2f348c7268 14-Feb-2010 James Dong <jdong@google.com> Fixed three issues
1. don't return INPUT buffers (OUTPUT part was fixed last week) back to omx client without
making sure flush is completed while handling do flush request from omx client

2. don't send premature flush completion notification from omx component to omx client.
We need to check whether all pending buffers (seaprately on INPUT and OUTPUT buffers)
before the flush completion notification/event is sent out to omx client.

3. counter mis-calculation for the number of outstanding input buffers hold by the dsp.

bug - 2442379
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
6b13c05d9a88b7aede72519187315b0f6d53f669 17-Feb-2010 James Dong <jdong@google.com> Fix the 0-timestamp issue
Don't return an output buffer back to the omx client if the input buffer(s) processed
are only meant for setting the configuration

bug - 2374898
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
ec79ebc8edd717cba60967d6da1e13915d6a4a34 12-Feb-2010 James Dong <jdong@google.com> Only return buffers back to OMX client after DSP processed them; don't return them prematurely in flush call.

Internally, before receiving the flush request, TI's omx component already sends the received buffers to the dsp.
DSP will return those buffers after processing them.
If we return the buffer within the flush completion handling, then we may return the buffers twice to the
OMX client. Since the buffers are returned, the OMX client owns the buffers and can do anything with them
(including freeing them), which can cause potential memory corruption bugs that are very difficult to
track down.

TI is still in a process of coming up with a better/cleaner solution by considering all the corner cases;
but lets have this workaround in first to unblock the tests.

bug - 2375037
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
b65f253fdc60f6208a54911bee793d225f23cdf8 04-Feb-2010 James Dong <jdong@google.com> Revert "Revert "Omx component change due to TI's socket node update from 25.9 to 25.14""

This reverts commit eaaadaf5ebb5e352e2ed4a12714f5d2363da0dcd.
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
eaaadaf5ebb5e352e2ed4a12714f5d2363da0dcd 02-Feb-2010 James Dong <jdong@google.com> Revert "Omx component change due to TI's socket node update from 25.9 to 25.14"

This reverts commit 36733d62c0d4c565da10b34978e587d0fda0f1ad.
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
36733d62c0d4c565da10b34978e587d0fda0f1ad 28-Jan-2010 James Dong <jdong@google.com> Omx component change due to TI's socket node update from 25.9 to 25.14
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
e074e61deca17dd3ffc4e431f30464943d225fe0 20-Nov-2009 Benny Wong <Benny.Wong@motorola.com> WMV Video decoder byte alignment fix
- rebased ...

Originally from: https://partner.source.android.com/g/#change,1497
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
c5b21bfb410626a503e479a5afa2095902783427 20-Nov-2009 Benny Wong <Benny.Wong@motorola.com> WMV/WMA seek fix

Originally from: https://partner.source.android.com/g/#change,1498
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
17e995d39771569792c528f3dea559c83f0fc238 04-Dec-2009 Andreas Huber <andih@google.com> Make it possible to build the TI device without opencore, fix a few abuses of dlerror()
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
3000a016292019e74a9afbd65aa95c669c1c4b94 30-Nov-2009 James Dong <jdong@google.com> Fix race conditions where modification of some shared counters between threads was not atomic.
Also, Log error condition from LCML_Callback.
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
75654962d82cc9054c198ce88fc2db0c56b16232 26-Nov-2009 James Dong <jdong@google.com> Clean up OMX_EmptyBufferDone() and OMX_FillBufferDone()
1. Remove duplicated code for handling buffer ownership
2. Send OMX_EventBufferFlag event for output port only according to OpenMAX-IL standard
3. Fix a bug where the nData2 field of the EventHandler for OMX_EventBufferFlag was using OMX_BUFFERFLAG_EOS.
Instead, nFlags field containing the EOS flag should be used.
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
d5cf09fb6e53cda5ce8796eb01230bfecdb917ff 02-Nov-2009 Masaki Sato <masaki.sato@motorola.com> Video decode memory leak fixes
bug 2100370

Originally from: https://partner.source.android.com/g/#change,1410
rebased...
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
226b319400d0f1985e6d83c81c509dd379788018 04-Nov-2009 Masaki Sato <masaki.sato@motorola.com> 1. Error handling for unsupported video resolution for m4v video decoder
2. Modified the original patch to add error handling for DSP Initialization failure
to prevent OMX client hang

Originally from: https://partner.source.android.com/g/#change,1411
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
1348a0db59d75e00b3e0f33678d06f6671a6d4d6 30-Sep-2009 Benny Wong <Benny.Wong@motorola.com> To get GetState to block for pending state transitions to complete for video decode

Originally from: https://partner.source.android.com/g/#change,1201
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
2acd4700b78e88cf0f8d52bb14fd9deb99d9f9bf 29-Sep-2009 Benny Wong <Benny.Wong@motorola.com> Fixed issues in querying & setting video decoder profiles & levels

Originally from: https://partner.source.android.com/g/#change,1149
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
22c239812ee8fc2e69d7da5f0f3e0df599bc7806 18-Sep-2009 Benny Wong <Benny.Wong@motorola.com> Adjust the width and height of the output buffer to a multiple of 16
because the TI decoder has a requirement that the max dimensions
be multiples of 16

Originally from: https://partner.source.android.com/g/#change,1107
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
4e501478686a1b42da255e58d95494710f9d5c9c 17-Sep-2009 Benny Wong <Benny.Wong@motorola.com> Fixes a hang video decoder OMX component during mediaframeworktest.
The hang happens when a reset command (state transiton from executing
-> idle) is issue while a port reconfiguration is going on.

Originally from: https://partner.source.android.com/g/#change,1073
Fixed a missing open brace and coding style.
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
b44cdb1b44b144d09e8ec950d1e8e4c280064056 30-Jul-2009 Rebecca Schultz Zavin <rebecca@android.com> New version of ti OMX code to support ti mm release 25.9

Signed-off-by: Rebecca Schultz Zavin <rebecca@android.com>
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c
fb3766f18a2c18b6f4798a6a631fdb88fcacd1dc 17-Jul-2009 Rebecca Schultz Zavin <rebecca@android.com> Adding omap3 omx code

Signed-off-by: Rebecca Schultz Zavin <rebecca@android.com>
/hardware/ti/omap3/omx/video/src/openmax_il/video_decode/src/OMX_VideoDec_Utils.c