History log of /hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
46de639b23db99d7b99ff1c676ac98b84b6336c6 08-Jan-2012 Steve Block <steveblock@google.com> Rename (IF_)LOGE(_IF) to (IF_)ALOGE(_IF) DO NOT MERGE

See https://android-git.corp.google.com/g/#/c/157220

Bug: 5449033
Change-Id: I7d131473964d92c62a495d082a1207867f435885
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
39371f31292f050f7fd75f7d36c7c9eeffd4ae64 10-Nov-2011 Tyler Luu <tluu@ti.com> CameraHal: Fix preview not starting after surface is abdandoned

If an application gets backgrounded (HOME key) without stopping
preview and releasing camera, preview would previously not restart
when application is resumed. ANativeWindowDisplayAdapter would
detect that the preview surface was abandoned and stop sending
buffers to CameraAdapter.

We were previously not doing anything when CameraService called
setPreviewWindow when a display adapter was already created. To
fix this issue, we need to send the preview window and restart
preview.

Change-Id: I36089b0046f9861897d32c50b52128a41e2de2a5
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
130ed815e4cea7c2906a1e1f0d665c2f94b690f5 06-Oct-2011 Akwasi Boateng <akwasi.boateng@ti.com> CameraHAL: Fixes a small crop issue

- The offset variables 'mXOff' and 'mYOff' in
ANativeDisplayAdapter are always initialized to
zero. If the offset of the incoming preview buffer
is zero and the viewable preview resolution is
smaller than the actual preview buffer resolution,
then the crop will not get configured properly.

Signed-off-by: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Vicky Martinez-DeFrain <a0869710@ti.com>
Signed-off-by: Akwasi Boateng <akwasi.boateng@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>

Change-Id: Ib321f17566d253dd65dc4c6d20bf748a9a4c614b
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
88006b1ebee79cb0f1a2c682258b313eb801049d 30-Sep-2011 Sundar Raman <sunds@ti.com> omap4xxx: camera: various fixes

clean up resources properly on exit:

- Frees all resources in case of error during
preview buffer allocation in ANativeDisplayAdadapter.
- Fixes a couple of typos in BaseCameraAdapter.
- Removes a possible memory leak during temporal
bracketing. 'stopBracketing()' will never get
properly executed when 'startImageCapture()'
disables 'mBracketingEnabled'.
- Stops temporal bracketing properly inside
'signalEndImageCapture()'.

Change-Id: Ic122058c835e30f12f335a288164475b8f6d1c6d
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Sundar Raman <sunds@ti.com>
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
b3fb1a45ce906ab0365f247caf596665ea0c9f39 26-Sep-2011 Sundar Raman <sunds@ti.com> CameraHAL: Improved error handling inside the adapters

1. unlock and cancel buffers to ANativeWindow when freeBuffers is called
2. Free the omx handle and deinitialize DOMX when errors occur while
calling critical OMXCamera apis
3. Retry OMX_GetHandle if it fails to take care of error recovery
scenarios.

"Fixes b/5379663"

Change-Id: I4729fab40e6104dfa6660ba6f6b1a90f805c2f59
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
8e88af31129b8cc09675279ca2eac88256d8526b 16-Sep-2011 Akwasi Boateng <akwasi.boateng@ti.com> Grallock lock and unlock fixes

1. Get and store Y and UV pointers from
all gralloc handles to be used for
preview callback and video frames.
2. Ensure gralloc lock is successfull
before frame return to OMXCameraAdapter

Change-Id: Ibeea6d00f2c1a1c45bcd2eafb22b90a795516e5c
Signed-off-by: Akwasi Boateng <akwasi.boateng@ti.com>
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
c493114006e0e136c8c88c2fc9865994054959bf 16-Sep-2011 Sundar Raman <sunds@ti.com> CameraHAL: Adds some useful debug logs on frame counts

Change-Id: Ifb1434f9fd1c85f040d67f3df6fb7c4a86e135db
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
348e4eaaf2f88810f2a3c55fd1b0df540a5104ed 17-Sep-2011 Tyler Luu <tluu@ti.com> CameraHal: Error handling before sending frames

Adding a few error checks before sending frames to make
sure we have the proper conditions to send a frame.

Fixes a bug where FillBufferDone gets preempted by the stop
path and by the time it returns the buffers and subscribers
are freed. Adding checks in send frame context since it is
protected by a Mutex.

Change-Id: I860bee796669606e1ec3e26e19916f386fc3e9aa
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
941b79b3815eb5f41e0d194d6f65161d1e4a86d0 08-Sep-2011 Tyler Luu <tluu@ti.com> CameraHal: Use the same gralloc usage bits for alloc and write

Change-Id: I013fd9ff40efb0ceaa1575a5af1c077d72e7921d
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
97e6bcc45eb2161c10761abc4fbf12ce3e1d52c8 31-Aug-2011 Tyler Luu <tluu@ti.com> CameraHAL: Fixes memory leaks inside ANativeWindowDisplayAdapter

- Every call to 'allocateBuffer()' is allocating a
'buffers' array on the heap, which is never used
and never released.
- Every call to 'setFrameProvider()' is instantiating a
new FrameProvider instance, which is never released.

Change-Id: I73ee9d35d9cb32709078334d199932fe78c2b7bb
Original-author: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
6c73fda9fdca5431e4e7911bb3171e36088a861e 27-Aug-2011 Tyler Luu <tluu@ti.com> CameraHal: Lock buffers sent to FrameProvider

Use GraphicBufferMapper API to lock buffer
before sending to FrameProvider to ensure
there isn't simultaneous accesses to bufffer
by SGX

Change-Id: Ifbb5c88bac49b1b494bd984137b523d35f4a6f57
Signed-off-by: Tyler Luu <tluu@ti.com>
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
816f63fd6a78b45e18819d9967d409c212c88eae 26-Aug-2011 Sundar Raman <sunds@ti.com> Camera HAL: Do not call cancelBuffer when destroying the display adapter

When a NULL window is passed in setPreviewDisplay, we try to do cancelBuffer
to return the buffers to the ANativeWindow if there is a valid reference
to DisplayAdapter. However, the CameraService already sets the ANativeWindow
reference to NULL before calling setPreviewWindow method of the Camera HAL
so the cancel_buffer crashes. So, we do not call cancel_buffer as the
preview window is destroyed anyway by Camera Service.

Change-Id: Ie07f5fd3ca5bb5a31cb25a174ee1acc2988628af
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
7702898343dbb27a4543c642d189cff5de7046c9 25-Aug-2011 Sundar Raman <sunds@ti.com> CameraHAL: Handles "abandoned" preview SurfaceTexture

- It's possible for the camera client to "abandon" the
preview surface at any time. In this case the SurfaceTexture
will start returning ENODEV error codes on every call.
ANativeWindowDisplayAdapter should handle this case and
not try to call the SurfaceTexture any more. If this is
not the case, then there is a chance of a segfault in
MediaServer.

Signed-off-by: Emilian Peev <epeev@mm-sol.com>

Change-Id: Ic529cffae5315cbe6316e583b399d3bd7a44b75c
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
2e986e5e29b391b070f608d641538c14b778d4ba 23-Aug-2011 Iliyan Malchev <malchev@google.com> omap4xxx: camera: lock gralloc buffers read-rarely/write-never

Change-Id: Iacf80f7485e78d20000df27bca9e57caafcea111
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
f25174be9c406898eb5197e2b57314d762960228 21-Aug-2011 Sundar Raman <sunds@ti.com> CameraHal: Remove the SW usage flags set in CameraHAL

With the SW usage flags gralloc is enabling caching for TILER buffers
and using wrong memsets in the code which is causing DMM errors and results in
reboots in es1.1 silicon.

Change-Id: I819b40fee0521bafadff1d72c74a7b30d1de9a8e
Signed-off-by: Sundar Raman <sunds@ti.com>
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp
c322989ae6ff6769490828de1b5eda12b749cce9 08-Aug-2011 Iliyan Malchev <malchev@google.com> initial commit

Change-Id: I8f7a7eeece0e516efa486b77e9d97805c0e65d3e
Signed-off-by: Iliyan Malchev <malchev@google.com>
/hardware/ti/omap4xxx/camera/ANativeWindowDisplayAdapter.cpp