History log of /external/google-breakpad/src/common/dwarf_cu_to_module.cc
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
7b127284ccc6d8dfa2d998d2ffea0ced9ff48a86 03-Feb-2015 hashimoto@chromium.org <hashimoto@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> Demangle symbol name

The spec says it should be demangled.
https://code.google.com/p/google-breakpad/wiki/SymbolFiles

BUG=chromium:453498
R=mark@chromium.org

Review URL: https://breakpad.appspot.com/2854002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1421 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
6105ae42dc0a63fe651b050244c9bbc6a549bfc5 27-Jan-2015 erikchen@chromium.org <erikchen@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> Fix some fragile code that is likely to cause future memory corruption
problems.

- The ordering of keys in stl containers cannot change. Make the relevant
members const to guarantee this assumption.
- Add handling and logging for demangle errors.
- Fix a potential double-delete bug if a function passed to AddFunction() is
already present.

BUG=chromium:449214
R=mark@chromium.org

Review URL: https://breakpad.appspot.com/10704002/


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1415 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
f1ecc41ff43ebd44ddac195bcdace03f421eb852 27-Jan-2015 erikchen@chromium.org <erikchen@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> Fix a source of memory corruption.

This error was causing crashes in official Chrome Mac builds on 10.8.5
machines.

BUG=chromium:449214
R=mark@chromium.org


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1414 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
467db189796399215568d59e2b936f3388a6081a 21-Jul-2014 ivanpe@chromium.org <ivanpe@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> Both std::tr1::unordered_set and std::unordered_set are not allowed in
Google at this moment. This change is implementing a workaround that
allows switching to hash_set and hash_map.

R=mark@chromium.org

Review URL: https://breakpad.appspot.com/6694002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1354 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
6f81e6427bddcffe7e43f62a9042f151f6f987e3 07-Jul-2014 mark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> Fix compilation error in Linux libc++ builds due to use of tr1/.

Patch by Sergey Matveev <earthdok@chromium.org>

BUG=chromium:391792

Review URL: https://breakpad.appspot.com/7674002/


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1345 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
35c3e843ad4d19aae8c5a7508503a23e38d29772 26-Jun-2014 mark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> dump_syms: use unordered_set<> instead of set<> for speed.

dump_syms spends a lot of time trying to compare strings.
This change speeds up processing of libwebviewchromium.so by 30% on my linux
machine.

Patch by Junichi Uekawa <uekawa@chromium.org>

Review URL: https://breakpad.appspot.com/2714002/


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1341 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
cd549d40fe428eee93dd3ead2a817fd68a0f5b25 28-May-2014 thestig@chromium.org <thestig@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> Fix a memory leak in DwarfCUToModule::FuncHandler::Finish().

BUG=591
R=mark@chromium.org

Review URL: https://breakpad.appspot.com/2704002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1333 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
b9d6ed468efaa4b65d42c4c5379fde15dcce14c5 24-Apr-2013 thestig@chromium.org <thestig@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> Cleanup: Use scoped_ptr where appropriate in DwarfCUToModule.

Review URL: https://breakpad.appspot.com/572002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1164 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
52dc308f4271478a77415f6b71b7e1c96fe56e5a 24-Apr-2013 thestig@chromium.org <thestig@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> Add an option to not handle DWARF inter-compilation unit references in Linux dump_syms.

This saves a lot of memory for dump_syms.

Review URL: https://breakpad.appspot.com/565002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1163 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
f9ba50d41d6fe2fc3fa29fe8db547e418edc460a 06-Mar-2013 ted.mielczarek@gmail.com <ted.mielczarek@gmail.com@4c0a9323-5329-0410-9bdc-e9ce6186880e> Minor Android fixup for symbol dumping code
Patch by Julian Seward <jseward@acm.org>
R=digit at https://breakpad.appspot.com/521002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1123 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
5454576276fa6932bdfcddc959c785ebd601d273 28-Feb-2013 ted.mielczarek@gmail.com <ted.mielczarek@gmail.com@4c0a9323-5329-0410-9bdc-e9ce6186880e> Add missing "using std::sort" to dwarf_cu_to_module.cc.
Patch by Julian Seward <jseward@acm.org>, R=ted

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1117 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
248c84d2006fcde85b098066866aebec72b76125 23-Jan-2013 ted.mielczarek@gmail.com <ted.mielczarek@gmail.com@4c0a9323-5329-0410-9bdc-e9ce6186880e> Include the compilation directory for FILE entries, making them absolute instead of relative
A=Ryan Sleevi <rsleevi@chromium.org> R=mark,ted at https://breakpad.appspot.com/385001/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1106 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
ee2531873f38ecb81e45f9f80bdf0ada4a881e3b 08-Jan-2013 jimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e> DWARF can store DW_AT_high_pc as either an address or a constant. In the latter
case it's the length of the function. breakpad always treats it as an address.

a=mattdr, r=jimb


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1094 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
7c2350868e7f53728866d304bc6a7ce8ba3b5d05 12-Dec-2012 mark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> Remove dead code.

Patch by Rafael Espindola <rafael.espindola@gmail.com>

Review URL: http://breakpad.appspot.com/502003/


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1091 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
5fbfadc219dc5b0fc962bef8fd60357d2a6e044a 06-Oct-2012 jimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e> Comment out unused arguments in definitions, as required by the Google C++ Style Guide.

A=Rafael Ávila de Espíndola <respindola@mozilla.com> R=jimb at https://breakpad.appspot.
com/479003


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1064 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
ec0d980602262e4543143c0222eceddd993f6a61 05-Oct-2012 jimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e> Fix out-of-date comment for DwarfCUToModule::FilePrivate::common_strings.

No review.


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1063 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
acf56d00ae530b653c23cf2ed71c4c434c81b154 05-Oct-2012 jimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e> If a specification DIE has a DW_AT_MIPS_linkage_name attribute, don't fail
to add it to the specifications table. Record the fully-qualified name
provided by the demangler in the table.

A=Rafael Ávila de Espíndola <respindola@mozilla.com> R=jimb at https://breakpad.appspot.
com/478004/


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1062 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
1277babefa9180dc4bc83c9f70afb0014df82d0f 04-Oct-2012 ted.mielczarek@gmail.com <ted.mielczarek@gmail.com@4c0a9323-5329-0410-9bdc-e9ce6186880e> Use DW_AT_MIPS_linkage_name if it is available to get names of functions with arguments during symbol dumping.
A=Rafael Ávila de Espíndola <respindola@mozilla.com> R=ted at https://breakpad.appspot.com/457002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1059 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
e40dd59ad4dbfaaba07a09c401fe5966d6130e26 25-Apr-2012 ted.mielczarek <ted.mielczarek@4c0a9323-5329-0410-9bdc-e9ce6186880e> Fix compiler warning from format string
Patch by Chris Dearman <chris@mips.com>
R=ted at http://breakpad.appspot.com/369002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@958 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
aa52a01f8a977bdb8a1f79ccabab963131574301 03-Apr-2012 mark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> Changes to get the breakpad client compiling and running on Android using
ndk-7b.

Patch by Carlos Valdivia <carlosvaldivia@google.com>

Review URL: https://breakpad.appspot.com/363001/


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@945 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
3ca4a120de8ec3f35e972e4b23f527bb8f65c479 06-Jul-2011 ted.mielczarek <ted.mielczarek@4c0a9323-5329-0410-9bdc-e9ce6186880e> Add some unit tests for Linux WriteSymbolFile

This patch adds synth_elf::{StringTable,SymbolTable,ELF} classes to
produce in-memory ELF files to properly test the Linux symbol dumping
code. It also uses those classes to add some basic tests for
the WriteSymbolFile function.

R=jimb at http://breakpad.appspot.com/277001/show

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@794 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
fd18beeb5c817aa3ecdb21caceee8e6ce08c6ab3 11-Mar-2011 jimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e> Google Breakpad Issue 417: Handle DWARF that omits function names.

This patch makes sure dump_syms behaves properly when presented with
malformed DWARF data that provides no name for a function. We print a
warning message to stderr, and subsitute "<name omitted>" for the empty
string, so that the "FUNC" record written to the symbol file for the
function is still well-formed. (We may have line number data covering the
function, so it would be a shame to omit the function altogether.)

Unit tests included.
a=jimblandy, r=ted.mielczarek


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@779 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
916a34a98293fd0d96f909a7c450a938d14361ce 08-Nov-2010 thestig@chromium.org <thestig@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> Fix assert failure in dump_syms caused by binary linked with gold.

Original review: http://breakpad.appspot.com/224001
A=raymes
R=ccoutant
Review URL: http://breakpad.appspot.com/227001

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@729 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
8ca54e486c2b1df72a6eebc0dcb43ef7847cd428 27-Aug-2010 mark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> Use <inttypes.h> macros for formatting fixed-width types.
Review URL: http://breakpad.appspot.com/162002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@676 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
786275e7195761228374d7c0f5ff02403c7e1ef8 17-Jul-2010 jimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e> Breakpad Linux/Mac symbol dumper: Share duplicate strings that arise in DWARF data.

This patch avoids allocating many copies of identical strings appearing in
debugging information. Without this patch, running dump_syms on Mozilla's
libxul.so (with 173MiB of debugging information) has a peak resident set of
around 450MiB. With this patch, the peak is around 365MiB.

a=jimblandy, r=mark


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@626 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
801407144050d86fb22364eb6b8f11873ea7bc1f 08-Jul-2010 ted.mielczarek@gmail.com <ted.mielczarek@gmail.com@4c0a9323-5329-0410-9bdc-e9ce6186880e> Fix a couple of tiny things for GCC pedantry

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@622 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
e1930985430ce289f4fe8525f51050e5d78cc44e 25-Jun-2010 ted.mielczarek <ted.mielczarek@4c0a9323-5329-0410-9bdc-e9ce6186880e> Breakpad: Avoid using the C++ <cfoo> headers.

This patch avoids unnecessary use of the <cfoo> headers in files that don't
actually use the identifiers they declare in the std:: namespace.

It also changes some files to better conform with the "Names and Order of
Includes" rules in the Google C++ Style Guide.

A=jimb R=mark

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@619 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
bd0a7f9da10909927dfe91c9f1010d03d07f3b7b 25-Jun-2010 ted.mielczarek <ted.mielczarek@4c0a9323-5329-0410-9bdc-e9ce6186880e> Breakpad DWARF support: Check for DWARF line info under Mac OS X section names.

For some reason, Mac OS X places DWARF debugging information in sections
whose names begin with "__", rather than the names beginning with "." given
in the DWARF spec. This patch changes google_breakpad::DwarfCUToModule to
look for line number information under both names.
A=jimb R=mark

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@612 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc
87855248f1fab83caf002418196a34051d359f2c 05-Apr-2010 jimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e> Breakpad symbol dumper: Move Linux dumping classes into src/common.

The Linux symbol dumper's classes are reasonably portable, and should be
usable for the Mac dumper as well. Move them to src/common, along with
their unit tests. Update #include directives and Makefile.

a=jimblandy, r=nealsid


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@567 4c0a9323-5329-0410-9bdc-e9ce6186880e
/external/google-breakpad/src/common/dwarf_cu_to_module.cc