History log of /external/libpng/pngrutil.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
62fc3c2adc07fcc6adaa3d407b2c9e837091609e 16-Jun-2015 emmaleer <emmaleer@google.com> Fixing bug causing crc error in region decoder

The error was caused by an incorrect crc value being calculated.
A crc value is calculated based on an images IDAT chunks
(png blocks of image data).
Since region decoder skips part of the data to decode a partial image,
the crc value will only be calculated with the partial data read,
not the entire data, resulting in an incorrect crc value.
The solution is to call png_opt_crc_finish() when checking the crc value
instead of png_crc_finish().
png_opt_crc_finish() treats the png_crc_error as a warning,
instead of an error, as png_crc_finish() does.
The case where there are multiple IDAT chunks was already handled
in png_read_IDAT_data() line 3994 in pngrutil.c.
When moving on to the next IDAT chunk it calls png_opt_crc_finish(),
as we may not have decoded the entire previous IDAT chunk
and there could be a crc error.
Since this particular image only has one IDAT chunk,
the first IDAT chunk's crc was being verified in png_read_finish_IDAT(),
which is called when we are done reading the image.
In this function I added a call to png_opt_crc_finish(), if png indexing
is supported, in opposed to png_crc_finish(), which fixed the error.

BUG:20224409

Change-Id: I97727f93f091f34700cea772bf796f168e85fc8f
/external/libpng/pngrutil.c
3ae1ad1c8460c90ae2d2028edde0c4d92316e71d 20-Feb-2015 Henrik Smiding <henrik.smiding@intel.com> Fix buffer overflow security vulnerability (CVE-2014-9495)

Fixes the heap-based buffer overflow in the png_combine_row
function, when running on 64-bit systems. Might allow context-
dependent attackers to execute arbitrary code via a
"very wide interlaced" PNG image.

This is a cherry-pick of commit dc294204b641373bc6eb603075a8b98f51a75dd8
from upstream branch libpng16

bug: 19474828

Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
Change-Id: If8708a8e48afd61de36bb897d222972979a4e892
/external/libpng/pngrutil.c
b0277d0706e596e9a1dd889903f8ceb2680bcadb 09-May-2014 Sireesh Tripurari <sireesh.tripurari@linaro.org> libpng 1.6.10 - Merge seekable png patch

Change-Id: I3aa6d8775b884f719375c5aaa458a5c27c120b38
/external/libpng/pngrutil.c
b478e66e7c2621eef5f465e4629ce642db00716b 09-May-2014 Sireesh Tripurari <sireesh.tripurari@linaro.org> Update libpng from 1.6.3 to 1.6.10

Change-Id: I76e81e7fd267d15991cd342c5caeb2fe77964ebf
/external/libpng/pngrutil.c
90bf0d236a939f07b1635ffee4ef4268181c904c 14-Aug-2013 John Reck <jreck@google.com> Merge seek support from 1.2 to 1.6

(cherry picked from commit 92c8c3c9f6d5318f07cb76d934c20ba1592a5581)

Change-Id: I340deefa71ec480327344c9dabe4c1e93f03e59a
/external/libpng/pngrutil.c
b50c217251b086440efcdb273c22f86a06c80cba 30-Jul-2013 Chris Craik <ccraik@google.com> Update libpng to version 1.6.3

(cherry picked from commit ca2bf81b02c99afa2e76b3b2c6eb232c239221e0)

Change-Id: I313493fa630be9812e503ae24820b2923ed717f3
/external/libpng/pngrutil.c
54d908dc93dbbaacd15b8a53b29a8fb88b6c472c 29-Mar-2012 Geremy Condra <gcondra@google.com> Fix for CVE-2011-3045

Change-Id: Ia46a262f8c73ec8ad6634c5de5f776373c330061
/external/libpng/pngrutil.c
ccee121fae4c60a5dee6fce51195185694c376c3 06-Mar-2012 Dave Burke <daveburke@google.com> Fix for CVE-2011-3026

Note that this fix was borrowed from chromium and that the
issue was fixed in 1.2.47 of libpng (using a different approach).
Change-Id: I9aef05b1b0efd48de8f8121d206257b3c7efb522
/external/libpng/pngrutil.c
66dce0da6a5db51ee0c2875517d3a6ca6cbbe53d 21-Jul-2011 Eric Vannier <evannier@google.com> Upgrading libpng to 1.2.46 to fix a few vulnerabilities.

Bug: 5057432
Bug: 5055636
Change-Id: I9e1b51881386aa9f574a38abc844e036baef9091
/external/libpng/pngrutil.c
4ce0ee15f268e0161438b4133936cb2826f7fd50 20-Aug-2010 Joseph Wen <josephwen@google.com> Add the feature of tile-based decoding to PNG.

There is a relevant patch to the change in zlib:
https://android-git.corp.google.com/g/#change,63173

Change-Id: I617b8740a50af0d75df9f49fa6b88dd2decb36dd
/external/libpng/pngrutil.c
5f6bd84e375226bf228fc8ac90318957ec9e1e7f 28-Jun-2010 Patrick Scott <phanna@android.com> Upgrade libpng to 1.2.44 for security fixes.

Change-Id: Iae257ca6ea7031a99f38e9de196d71ef8b94f9aa
/external/libpng/pngrutil.c
a0bb96c34e65378853ee518bac502842d26c2d1a 22-Jul-2009 Patrick Scott <phanna@android.com> Update libpng to 1.2.38 to patch a minor security issue.
/external/libpng/pngrutil.c
4215dd1533c56e1a89ae6f1d6ea68677fac27fda 09-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //branches/cupcake/...@137197
/external/libpng/pngrutil.c
893912bfc2683463dc3e2c445336752d012563d3 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/external/libpng/pngrutil.c
0d889b4fd2c96153983a28cc5757c0172d9eb78b 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/external/libpng/pngrutil.c
0640679f04398a7d06319d5c47b0f71bf82854a0 12-Jan-1970 Upstream <upstream-import@none> external/libpng 1.2.29
/external/libpng/pngrutil.c