History log of /external/skia/bench/SKPBench.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
261c3ad7fde95748da92550735decc949dc73bf2 27-Apr-2015 joshualitt <joshualitt@chromium.org> Change to add zoom animations to nanobench

BUG=skia:

Review URL: https://codereview.chromium.org/1061323003
/external/skia/bench/SKPBench.cpp
1d24b8dfe9aac9cadaf3914b8574a4ff6e9bc19d 27-Mar-2015 robertphillips <robertphillips@google.com> Add matrix constructing helpers to SkMatrix

Review URL: https://codereview.chromium.org/1034273002
/external/skia/bench/SKPBench.cpp
9a0f629973ee97ea10f5e3c36a802eca4270d7e0 20-Mar-2015 egdaniel <egdaniel@google.com> Only use 256x256 tiles on hd2000 nanobench bots

Initial experiments did show that the 256 tile size fixed the hd2000 win7
nanobot failures. However it did not have any effect on other bots, so this
change is to move back to the larger tile size on all bots expect for the
hd2000.

BUG=skia:

Review URL: https://codereview.chromium.org/1022083002
/external/skia/bench/SKPBench.cpp
5d09568a0c67bc54dfb38552d0136b06d3ebf018 19-Mar-2015 egdaniel <egdaniel@google.com> Move skp nanobench tile size back to 256x256 to see if it fixes nanobench crashes

Going back to old nanobench tile size to see if the increase to tile is what has been
causing recent nanobench crashes. The crashes seem very nondeterministic and hard to
debug manually.

256x256 is too small of a tile to give accurate gpu results but if this fixes we can try some compromise in the middle

BUG=skia:

Review URL: https://codereview.chromium.org/1022823003
/external/skia/bench/SKPBench.cpp
cc4d6673a942db11a678b572cf0dc5fca2b97f8a 05-Mar-2015 bsalomon <bsalomon@google.com> Increase default tile sizes in nanobench

R=mtklein@google.com

Review URL: https://codereview.chromium.org/982863003
/external/skia/bench/SKPBench.cpp
0004e7db42713592fa16a0e6481c95fcf8b398c3 26-Jan-2015 tfarina <tfarina@chromium.org> Update references to skiaperf.com.

The new server is being run in perf.skia.org.

BUG=None
R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/866943003
/external/skia/bench/SKPBench.cpp
a3e52724ac8b9fa7b48507bff4fa8e558a213e49 09-Dec-2014 robertphillips <robertphillips@google.com> Switch non-MPD nanobench path to use a separate canvas per tile

It is desirable that, when layer hoisting is disabled, the MPD and non-MPD timings be
roughly the same. Unfortunately, using a separate canvas for each tile (a requirement
for MPD) introduces its own discrepancy into the timing. Using a separate canvas for
each tile doesn't seem to make a difference for 8888 (see the non-MPD 8888 column below)
but slows down GPU rendering (see the non-MPD GPU column below). Since this is how
Chromium renders I propose switching to this regimen (even though it is "slowing down"
GPU rendering).

nanobench mean times (ms) with layer hoisting disabled (for desk_amazon.skp)

8888
MPD non-MPD
1 canvas (old-style) 0.628 1.71
separate (new-style) 0.795 1.63

GPU
MPD non-MPD
1 canvas (old-style) 2.34 1.69
separate (new-style) 2.32 2.66

Review URL: https://codereview.chromium.org/779643002
/external/skia/bench/SKPBench.cpp
63242d7d24917f836eace34ee20faeb49def5e67 04-Dec-2014 robertphillips <robertphillips@google.com> Fix SKPBench tiling so MPD and non-MPD match

Two issues with the SKPBench tile computation were causing the MPD path to do more work:

The clip from the parent canvas wasn't being used to trim content off the edges of the MPD tiles

The non-MPD path was not taking the scale into account in its tile placement (resulting in it having fewer, larger active tiles when scaling).

Review URL: https://codereview.chromium.org/776273002
/external/skia/bench/SKPBench.cpp
186a08ed72749976b533efe7abec062e20c48bda 21-Nov-2014 robertphillips <robertphillips@google.com> Fix memory leak in nanobench

This is cleanup for (Add MultiPictureDraw to nanobench - https://codereview.chromium.org/731973005/)

Review URL: https://codereview.chromium.org/730343003
/external/skia/bench/SKPBench.cpp
5b69377507478623dcf5b11f3ecb010f87c4794f 21-Nov-2014 robertphillips <robertphillips@google.com> Add MultiPictureDraw to nanobench

I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium.

TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/0ddad31012dabfc1267effc8071d37f7d606efbe

Review URL: https://codereview.chromium.org/731973005
/external/skia/bench/SKPBench.cpp
e77dadd91ae6f4319c2c047e7e36cc79bb4d1eff 21-Nov-2014 robertphillips <robertphillips@google.com> Revert of Add MultiPictureDraw to nanobench (patchset #7 id:120001 of https://codereview.chromium.org/731973005/)

Reason for revert:
Needs more work

Original issue's description:
> Add MultiPictureDraw to nanobench
>
> I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium.
>
> TBR=bsalomon@google.com
>
> Committed: https://skia.googlesource.com/skia/+/0ddad31012dabfc1267effc8071d37f7d606efbe

TBR=mtklein@google.com,bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/750583002
/external/skia/bench/SKPBench.cpp
0ddad31012dabfc1267effc8071d37f7d606efbe 21-Nov-2014 robertphillips <robertphillips@google.com> Add MultiPictureDraw to nanobench

I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium.

TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/731973005
/external/skia/bench/SKPBench.cpp
6838d854a87e79f1fbb7b89b9f395155ad44dc0a 29-Oct-2014 mtklein <mtklein@chromium.org> Try out SkTree in nanobench.

Looks like a fairly large recording speed win with no playback cost.

BUG=skia:

Review URL: https://codereview.chromium.org/653023003
/external/skia/bench/SKPBench.cpp
c7f7f467df07be73b22dbee38a59762997eb19bc 21-Oct-2014 mtklein <mtklein@chromium.org> Draw SKPs in 256x256 tiles in nanobench.

(This CL will certainly trigger performance regression alerts. Tiled drawing is slower than non-tiled drawing.)

BUG=skia:

Review URL: https://codereview.chromium.org/669983002
/external/skia/bench/SKPBench.cpp
962890568ddac03d8eb8467a2e81b6f2b7f046f0 10-Sep-2014 mtklein <mtklein@chromium.org> Distinguish common and unique names for skiaperf.com.

Turns out we tack on the size post-facto in ResultsWriter::bench(), so the only
place we need getUniqueName() to differ from getName() is SKPBench.

BUG=skia:
R=jcgregorio@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/552303004
/external/skia/bench/SKPBench.cpp
c5ba71d2e5cd426def66fa49dcf003e5b2c98dc7 04-Sep-2014 robertphillips <robertphillips@google.com> Change SkPicture::draw to playback

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/540963002
/external/skia/bench/SKPBench.cpp
92007583e43115998412ac8b0a06cc2780eb025c 01-Aug-2014 mtklein <mtklein@chromium.org> SKPs-as-benches in nanobench

This is meant to replace bench_pictures.

CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Release-iOS-Trybot

BUG=skia:
R=bsalomon@google.com, jcgregorio@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/425393004
/external/skia/bench/SKPBench.cpp