7d8013f3064cd202f5a2344a1ab1860fd7511bb3 |
|
20-Nov-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Changes to SkTDStackNester. SkTDStackNester is a class used by PdfViewer to assist in saving and restoring the PDF state. Clean up and test this class. Add some documentation. Add FIXME's where I have questions to resolve. Fix a bug where fNestingLevel was not initialized. Remove a commented out line of code copied over from SkTDStack. Rename SkTDStackNester::nests() to nestingLevel() and make it const. Remove unnecessary predeclaration and friend declaration. Remove index() (both const and non-const versions). They were unused, return something that may not be expected (index from the top, rather than from the bottom), and don't work to get any elements in earlier Recs once the first one is full. Report a warning if the nesting level goes above the maximum level, or if we attempt to bring it below zero. Prevent fNestingLevel from dropping below zero. Add kUnusedObject_SkPdfIssue, and use it where appropriate. Depends on https://codereview.chromium.org/64093009/ R=mtklein@google.com Review URL: https://codereview.chromium.org/68843006 git-svn-id: http://skia.googlecode.com/svn/trunk@12328 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/experimental/PdfViewer/SkPdfReporter.h
|
d03c2c732e2e914f8429cfc8b077a7b9b853dd8e |
|
11-Oct-2013 |
edisonn@google.com <edisonn@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
pdfviewer: more code comments + concat the pdf matrix with the existing matrix in canvas, instead of reseting it. Review URL: https://codereview.chromium.org/27057003 git-svn-id: http://skia.googlecode.com/svn/trunk@11735 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/experimental/PdfViewer/SkPdfReporter.h
|
e50d9a1fcd9c4298079ff54f9a40c9708d30f8c6 |
|
10-Oct-2013 |
edisonn@google.com <edisonn@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
mode code cleanup (100c / l, comments) Review URL: https://codereview.chromium.org/26912005 git-svn-id: http://skia.googlecode.com/svn/trunk@11716 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/experimental/PdfViewer/SkPdfReporter.h
|
67d7fb4e89d91a63d54426ac63d8e5c253521a59 |
|
07-Oct-2013 |
edisonn@google.com <edisonn@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
pdf report files Review URL: https://codereview.chromium.org/26271002 git-svn-id: http://skia.googlecode.com/svn/trunk@11629 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/experimental/PdfViewer/SkPdfReporter.h
|