| 9e43cabaa1ff26167e990f0bcb9a5c20d662d52c |
|
29-Apr-2015 |
msarett <msarett@google.com> |
Requires a minor API change to pass the color table to getScanlineDecoder, as we do with getPixels().
BUG=skia:3722
Review URL: https://codereview.chromium.org/1061713007
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| 4b17fa353e777de309ca8b0706f1d3e326b59822 |
|
23-Apr-2015 |
msarett <msarett@google.com> |
Ensure that we create a NULL codec for images with zero dimensions
BUG=skia:3534
BUG=skia:3257
Review URL: https://codereview.chromium.org/1091043003
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| e16b04aa6041efb6507546547737e9603fa1606e |
|
15-Apr-2015 |
msarett <msarett@google.com> |
SkJpegCodec
Enables basic decoding for jpegs
Includes rewinding
565, YUV, and Jpeg encoding are not yet implemented
BUG=skia:3257
Review URL: https://codereview.chromium.org/1076923002
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| 3c309db75bb8c4c2b58724a0e2f6f3b387ca842c |
|
10-Apr-2015 |
msarett <msarett@google.com> |
Implementing filling for SkBmpCodec
The bmp codec currently returns kIncompleteInput
when the stream is truncated, which we treat as a
partial success. However, we neglect the fill the
remaining pixels in the image, leaving these
uninitialized.
This CL addresses this problem by initializing the
remaining pixels in the image to default values.
BUG=skia:3257
Review URL: https://codereview.chromium.org/1075243003
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| 438b2adefb9e9213e0ddaf0609405d3087a1cf0a |
|
09-Apr-2015 |
msarett <msarett@google.com> |
***Disables swizzles to 565.
We may want to enable swizzles to 565
for images that are encoded in a format
similar to 565, however, we do not want
to take images that decode naturally to
kN32 and then convert them to 565.
***Enable swizzles to kIndex_8. For images
encoded in a color table format, we suggest
that they be decoded to kIndex_8. When we
decode, we only allow conversion to kIndex_8
if it matches the suggested color type (except
wbmp which seems good as is).
***Modify dm to test images that decode to
kIndex_8.
BUG=skia:3257
BUG=skia:3440
Review URL: https://codereview.chromium.org/1055743003
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| 0a7e69cb9b4e3929d659891d152a2c0b59bff4e0 |
|
03-Apr-2015 |
scroggo <scroggo@google.com> |
Get rid of leaks in SkCodec::NewFromStream.
SkCodec::NewFromStream claims to delete the passed in SkStream on
failure. This allows the caller to pass an SkStream to the function
and not worry about deleting it depending on the return value.
Most of our SkCodecs did not honor this contract though. Update them
to delete the stream on failure. Further, update SkCodec::NewFromStream
to delete the stream if it did not match any subclass, and delete the
SkCodec if we decided to return NULL because it was too big.
Add a test which tests streams which represent the beginnings of
supported format types but do not contain enough data to create an
SkCodec. The interesting part of the test is when we run it on ASAN,
which will report that we leaked something without the other changes.
BUG=skia:3257
Review URL: https://codereview.chromium.org/1058873006
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| 79e378d9b78c3db28eb97ab9adecb5bfddbf52d8 |
|
01-Apr-2015 |
scroggo <scroggo@google.com> |
Handle rewinds in SkBmpCodec.
Factor our BMP code for reading the header, and call it after a rewind.
BUG=skia:3257
Review URL: https://codereview.chromium.org/1057483003
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| a096d7a6d03662073f4cd46f7db5fe2cf5495c36 |
|
27-Mar-2015 |
halcanary <halcanary@google.com> |
SkCodec: add wbmp class
Review URL: https://codereview.chromium.org/1006583005
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| 230d4ac7013f79a3e79efd4452d7fa5c3f508660 |
|
26-Mar-2015 |
scroggo <scroggo@google.com> |
Use a wrapper for SkDebugf in SkCodec.
It can be silenced or not with one flag.
Always print when building for the android framework.
Also remove the meaningless define of override to override.
BUG=skia:3257
Review URL: https://codereview.chromium.org/1032093004
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| 9bde918754bc292469d801f156f3b626eb3db780 |
|
25-Mar-2015 |
msarett <msarett@google.com> |
Enabling ico decoding with use of png and bmp decoders
BUG=skia:3257
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1011343003
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| 7aa846c6837f527067e7ab5fdeacdbd502696382 |
|
24-Mar-2015 |
tomhudson <tomhudson@google.com> |
Revert of Enabling ico decoding with use of png and bmp decoders (patchset #10 id:280001 of https://codereview.chromium.org/1011343003/)
Reason for revert:
Reverting on suspicion of massive bot failures - possible command line too long?
Original issue's description:
> Enabling ico decoding with use of png and bmp decoders
>
> BUG=skia:3257
>
> Committed: https://skia.googlesource.com/skia/+/15bfd075d38e4422a477e22940d06a137f66cc97
TBR=scroggo@google.com,reed@google.com,djsollen@google.com,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3257
Review URL: https://codereview.chromium.org/1022843005
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| 15bfd075d38e4422a477e22940d06a137f66cc97 |
|
24-Mar-2015 |
msarett <msarett@google.com> |
Enabling ico decoding with use of png and bmp decoders
BUG=skia:3257
Review URL: https://codereview.chromium.org/1011343003
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| f21ef2776b4a40a4e5dea677d93069698c7115ad |
|
18-Mar-2015 |
msarett <msarett@google.com> |
Do not create empty color table if it does not exist
BUG=skia:
Review URL: https://codereview.chromium.org/1019543003
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| eed039b5ffbdff958053ac80b09451ad6caa1787 |
|
18-Mar-2015 |
msarett <msarett@google.com> |
Adding swizzles for bmp:
We now support kN32 and kRGB_565 color types.
Additionally, we support premul, unpremul, and opaque alpha types.
Unpremul is currently untested as we cannot currently draw to unpremul.
BUG=skia:
Review URL: https://codereview.chromium.org/1013743003
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| 9552662e9fee5eb0ef435e52ab9db505d7ebe4ad |
|
17-Mar-2015 |
scroggo <scroggo@google.com> |
Option for SkCodec to treat dst as all zeroes.
This recreates SkImageDecoder's feature to skip writing zeroes for
SkCodec.
Review URL: https://codereview.chromium.org/980903002
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| 741143878b23d22cd9cb7b9cba8055179115ce17 |
|
16-Mar-2015 |
msarett <msarett@google.com> |
Revert "Revert of fix for invalid for loop syntax broke build (patchset #1 id:1 of https://codereview.chromium.org/1007373003/)"
This reverts commit d18475854ce232de71c5463e0654f459d4abfd43.
Revert "Revert "Implementation of image decoding for bmp files, in accordance with the new API.""
This reverts commit dfdec78a5d02e8690998741a9fe5b71a08ca3232.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1016443003
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| dfdec78a5d02e8690998741a9fe5b71a08ca3232 |
|
16-Mar-2015 |
msarett <msarett@google.com> |
Revert "Implementation of image decoding for bmp files, in accordance with the new API."
This reverts commit 3675874468de7228944ce21922e6ec863f5f2310.
BUG=skia:
NOTREECHECKS=true
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1012873002
/external/skia/src/codec/SkCodec_libbmp.cpp
|
| 3675874468de7228944ce21922e6ec863f5f2310 |
|
16-Mar-2015 |
msarett <msarett@google.com> |
Implementation of image decoding for bmp files, in accordance with the new API.
Currently decodes to opaque and unpremul.
Tested on local test suite.
BUG=skia:3257
Review URL: https://codereview.chromium.org/947283002
/external/skia/src/codec/SkCodec_libbmp.cpp
|