History log of /external/skia/src/core/SkBitmapCache.h
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
83787d0ff0a2b2f839a4a3ce6dadd033f83fe643 25-Feb-2015 reed <reed@google.com> only notify bitmaps that have been added to the cache

old code:
- calls=2677 hit-rate=3.51139%

new code:
- calls=94 hit-rate=97.8723%

BUG=skia:

Review URL: https://codereview.chromium.org/960563002
/external/skia/src/core/SkBitmapCache.h
7eeba2587760a0802fd2b90765b4fd0e5e895375 24-Feb-2015 reed <reed@chromium.org> Notify resource caches when pixelref genID goes stale

patch from issue 954443002 at patchset 40001 (http://crrev.com/954443002#ps40001)

BUG=skia:

Review URL: https://codereview.chromium.org/950363002
/external/skia/src/core/SkBitmapCache.h
90c6bc4e85df2da37f436ea1da203e194c4740e2 19-Feb-2015 mtklein <mtklein@google.com> Revert of notify resource caches when pixelref genID goes stale (patchset #4 id:60001 of https://codereview.chromium.org/825263005/)

Reason for revert:
Crazy failures.

http://build.chromium.org/p/client.skia/builders/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/builds/1428/steps/dm/logs/stdio

Original issue's description:
> notify resource caches when pixelref genID goes stale
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4675819b9dbb3ad71ec851776e5de26d342f29fe

TBR=bsalomon@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/936423002
/external/skia/src/core/SkBitmapCache.h
4675819b9dbb3ad71ec851776e5de26d342f29fe 19-Feb-2015 reed <reed@google.com> notify resource caches when pixelref genID goes stale

BUG=skia:

Review URL: https://codereview.chromium.org/825263005
/external/skia/src/core/SkBitmapCache.h
9d93c2ebb31bf996905532446644f242339a774e 08-Oct-2014 reed <reed@google.com> Add SkCachedData and use it for SkMipMap

This reverts commit 37c5a815d8ea33247968212ef4cc83394ceee1bc.

TBR=mtklein

Review URL: https://codereview.chromium.org/635333002
/external/skia/src/core/SkBitmapCache.h
37c5a815d8ea33247968212ef4cc83394ceee1bc 03-Oct-2014 reed <reed@google.com> Speculative revert to diagnose crash in chrome. Revert "Add SkCachedData and use it for SkMipMap"

This reverts commit 92561a0b99ad6c08ab7a11dd1872f028199392e9.

crasher in question:
https://code.google.com/p/chromium/issues/detail?id=420178

Review URL: https://codereview.chromium.org/617613003
/external/skia/src/core/SkBitmapCache.h
92561a0b99ad6c08ab7a11dd1872f028199392e9 02-Oct-2014 reed <reed@google.com> Add SkCachedData and use it for SkMipMap

Review URL: https://codereview.chromium.org/592843003
/external/skia/src/core/SkBitmapCache.h
30ad5306be25565484a3dd76237984e071b7c4b3 16-Sep-2014 reed <reed@google.com> allow SkBitmapCache to operate on a local instance, for testability

BUG=skia:
R=mtklein@google.com, danakj@chromium.org, piotaixr@chromium.org, junov@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/576763002
/external/skia/src/core/SkBitmapCache.h
91cab830c81025e0af800b528bed582ea6e4d3d7 03-Sep-2014 piotaixr <piotaixr@chromium.org> Remove SkBitmapCache::Find/Add(_,width,height,_)
in favor of the versions having a SkIRect as input parameter

BUG=skia:2909
R=reed@google.com, junov@chromium.org

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/539643002
/external/skia/src/core/SkBitmapCache.h
42b0dfeb29e993b7fd247dcecff705d3dd4cf191 03-Sep-2014 piotaixr <piotaixr@chromium.org> The key for SkBitmapCache can now be genID+SkIRect

BUG=skia:2894
R=junov@chromium.org, reed@google.com

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/518983002
/external/skia/src/core/SkBitmapCache.h
8159146699f691b88f60564fc0811a6da3e8693f 02-Sep-2014 piotaixr <piotaixr@chromium.org> Added Doc for GetAllocator in SkResourceCache and SkBitmapCache

BUG=skia:2896
R=junov@chromium.org, reed@google.com

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/533713003
/external/skia/src/core/SkBitmapCache.h
14b6aba0997a8b463eae824d770fc5ad1ab89617 29-Aug-2014 reed <reed@google.com> harden requirements on SkBitmapCache

BUG=skia:
R=humper@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/521433002
/external/skia/src/core/SkBitmapCache.h
680fb9e8f10d24b5fe35c90338de37c57392f1aa 26-Aug-2014 reed <reed@google.com> retool image cache to be generic cache, allowing the client to subclass "Rec", so they can provide a custom Key and arbitrary Value.

Follow-on CLs

- rename ScaledimageCache to something like GeneralCache
- explore if we can use call-backs or some mechanism to completely hide "lock/unlock", by forcing all clients to support "copying" their value out of the cache as the result of a Find.

R=mtklein@google.com, senorblanco@google.com, bsalomon@google.com, qiankun.miao@intel.com, senorblanco@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/507483002
/external/skia/src/core/SkBitmapCache.h
04617139f7f715bdc05a32a58e65e3c208bccff4 21-Aug-2014 reed <reed@google.com> expose generalized imagecache key

BUG=skia:
R=mtklein@google.com, halcanary@google.com, qiankun.miao@intel.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/483493003
/external/skia/src/core/SkBitmapCache.h