80ea19ca4bdd68c1493666a5fe7e4ce9d43ded8b |
|
12-May-2015 |
reed <reed@google.com> |
Revert of Revert of stop calling SkScalarDiv (patchset #1 id:1 of https://codereview.chromium.org/1138263002/) Reason for revert: android patched, blink has rolled Original issue's description: > Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/) > > Reason for revert: > need to wait for Blink roll (and patch android) > > Original issue's description: > > stop calling SkScalarDiv > > > > BUG=skia: > > TBR= > > > > Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a > > TBR= > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/2629697933b5cc975e45d2a45c48f803fc6cbcec TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1135693003
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
2629697933b5cc975e45d2a45c48f803fc6cbcec |
|
12-May-2015 |
reed <reed@google.com> |
Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/) Reason for revert: need to wait for Blink roll (and patch android) Original issue's description: > stop calling SkScalarDiv > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1138263002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
67d71c898249a7af3523b16c6a69895a63bfae0a |
|
12-May-2015 |
reed <reed@google.com> |
stop calling SkScalarDiv BUG=skia: TBR= Review URL: https://codereview.chromium.org/1135053002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
d309e7aa0efa2d5dd7e7b1af97026fcd3a047e98 |
|
30-Apr-2015 |
bsalomon <bsalomon@google.com> |
This replaces the texture creation/caching functions on GrContext with a GrTextureProvider interface. The goal is to pass this narrowly focused object in places that currently take a GrContext but don't need and shouldn't use its other methods. It also has an extended private interface for interacting with non-texture resource types. Review URL: https://codereview.chromium.org/1107973004
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
29bee0fe657fabf7c396502b69c9167fba13eaaa |
|
29-Apr-2015 |
egdaniel <egdaniel@google.com> |
Make XPFragmentBuilder only Builder with access to DstCopy. Plus a bunch of renaming. BUG=skia: Review URL: https://codereview.chromium.org/1110033004
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
cfc18867d982119d9dc2888bf09f1093012daadd |
|
28-Apr-2015 |
jvanverth <jvanverth@google.com> |
Use GLSLCaps for creating processor keys and GLSL-specific programs Effectively all this does is future-proof any GLSL-specific code, as GLSLCaps is just a typedef of GLCaps. BUG=skia: Review URL: https://codereview.chromium.org/1109863004
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
d762ca2586707cb808342b11832073e8b3df33ad |
|
07-Apr-2015 |
senorblanco <senorblanco@chromium.org> |
Switch textures created by DeviceImageFilterProxy to approx-match. This revealed some further 0..1 texture coordinate depedencies,specifically in SkDisplacementMapEffect and SkXfermodeImageFilter, fixed through use of GrTextureDomain. Note: causes minor pixel diffs in pictureimagefilter, testimagefilters GMs. Also causes minor pixel diffs in some Blink layout tests, suppressed here: https://codereview.chromium.org/1064943002 BUG=skia:3532 Review URL: https://codereview.chromium.org/1065683002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
36352bf5e38f45a70ee4f4fc132a38048d38206d |
|
26-Mar-2015 |
mtklein <mtklein@chromium.org> |
C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} NOPRESUBMIT=true BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1037793002 Review URL: https://codereview.chromium.org/1037793002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
24e06d5244ae96e440410e1d76e039983b2efac9 |
|
18-Mar-2015 |
senorblanco <senorblanco@chromium.org> |
Remove uniqueID from all filter serialization. (This is essentially a revert of https://codereview.chromium.org/503833002/.) This was necessary back when SkPaint was flattened even for in-process use. Now that we only flatten SkPaint for cross-process use, there's no need to serialize UniqueIDs. Note: SkDropShadowImageFilter is being constructed with a croprect and UniqueID (of 0) in Blink. I've made the uniqueID param default to 0 temporarily, until this rolls in and Blink can be changed. (Blink can't be changed first, since unlike the other filters, there's no constructor that takes a cropRect but not a uniqueID.) BUG=skia: Review URL: https://codereview.chromium.org/1019493002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
570d2f81a65fc868d6300a7edf34c0d5d048c5d6 |
|
25-Feb-2015 |
joshualitt <joshualitt@chromium.org> |
I'd really like to land this before the branch so speedy reviews are appreciated. BUG=skia: Committed: https://skia.googlesource.com/skia/+/586d5d640b19860dfbbd903a5188da1bbbe87336 Review URL: https://codereview.chromium.org/936943002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
2907059d0eb1972a300ea1bf0cd4e4febabb9784 |
|
25-Feb-2015 |
joshualitt <joshualitt@google.com> |
Revert of Pass clip to context (patchset #8 id:180001 of https://codereview.chromium.org/936943002/) Reason for revert: Strange blur problems on nexus 5 Original issue's description: > I'd really like to land this before the branch so speedy reviews are appreciated. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/586d5d640b19860dfbbd903a5188da1bbbe87336 TBR=jvanverth@google.com,senorblanco@google.com,bsalomon@google.com,senorblanco@chromium.org,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/956083002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
586d5d640b19860dfbbd903a5188da1bbbe87336 |
|
25-Feb-2015 |
joshualitt <joshualitt@chromium.org> |
I'd really like to land this before the branch so speedy reviews are appreciated. BUG=skia: Review URL: https://codereview.chromium.org/936943002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
6bc1b5fab8554a9cb643277b4867965dd4535cd6 |
|
23-Feb-2015 |
bsalomon <bsalomon@google.com> |
Dynamically create stencil buffer when needed. Review URL: https://codereview.chromium.org/938383004
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
25d9c154087d2132a51d1ca74a104726f60ef380 |
|
18-Feb-2015 |
joshualitt <joshualitt@chromium.org> |
Pass Rendertarget into context. Adding Jim for text context stuff, and Steven for image blur stuff. BUG=skia: Review URL: https://codereview.chromium.org/939623005
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
72c9faab45124e08c85f70ca38536914862d947c |
|
09-Jan-2015 |
mtklein <mtklein@chromium.org> |
Fix up all the easy virtual ... SK_OVERRIDE cases. This fixes every case where virtual and SK_OVERRIDE were on the same line, which should be the bulk of cases. We'll have to manually clean up the rest over time unless I level up in regexes. for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end BUG=skia: Review URL: https://codereview.chromium.org/806653007
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
8fc6c2d82c1f30ff82274334c01f0799def6a609 |
|
23-Dec-2014 |
joshualitt <joshualitt@chromium.org> |
This CL cleans up the last remaining users of localCoordChange on paint NOTREECHECKS=True BUG=skia: Review URL: https://codereview.chromium.org/817853002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
f3f5bad7ded35265c0b5d042cc4174386b197a33 |
|
19-Dec-2014 |
robertphillips <robertphillips@google.com> |
Add toString methods to SkImageFilter-derived classes This isn't definitive but at least makes something show up in the debugger. Review URL: https://codereview.chromium.org/789163006
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
5531d51ce7426bdae7563547326fcf0bf926a083 |
|
18-Dec-2014 |
joshualitt <joshualitt@chromium.org> |
remove view matrix from context BUG=skia: Review URL: https://codereview.chromium.org/808703006
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
9f876a37d8b80ef04ccbc7755cf4572aecc33981 |
|
09-Dec-2014 |
bsalomon <bsalomon@google.com> |
Use threshold of 1 texture coord value per pixel w/ nearest neighbor. Review URL: https://codereview.chromium.org/787873002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
422f56f6e51c2f6a6ab425573b4d790f0157f883 |
|
09-Dec-2014 |
bsalomon <bsalomon@google.com> |
Make addUniform take a precision Review URL: https://codereview.chromium.org/788733003
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
eb2a6761654307e8aeeeaabdd63c6bf9ab0411e9 |
|
04-Dec-2014 |
joshualitt <joshualitt@chromium.org> |
Remove backend factories BUG=skia: Review URL: https://codereview.chromium.org/778453002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
3f3b3d003527861dc0bd89733857576408906431 |
|
01-Dec-2014 |
mtklein <mtklein@chromium.org> |
Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. This was needed for pictures before v33, and we're now requiring v35+. Will follow up with the same for skia/ext/pixel_ref_utils_unittest.cc BUG=skia: Committed: https://skia.googlesource.com/skia/+/52c293547b973f7fb5de3c83f5062b07d759ab88 Review URL: https://codereview.chromium.org/769953002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
6e78293ee896020104ffc4c23b565073e9a49893 |
|
01-Dec-2014 |
mtklein <mtklein@google.com> |
Revert of Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. (patchset #1 id:1 of https://codereview.chromium.org/769953002/) Reason for revert: Breaks canary builds. Will reland after the Chromium change lands. Original issue's description: > Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. > > This was needed for pictures before v33, and we're now requiring v35+. > > Will follow up with the same for skia/ext/pixel_ref_utils_unittest.cc > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/52c293547b973f7fb5de3c83f5062b07d759ab88 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/768183002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
52c293547b973f7fb5de3c83f5062b07d759ab88 |
|
01-Dec-2014 |
mtklein <mtklein@chromium.org> |
Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. This was needed for pictures before v33, and we're now requiring v35+. Will follow up with the same for skia/ext/pixel_ref_utils_unittest.cc BUG=skia: Review URL: https://codereview.chromium.org/769953002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
267ce482b54f46097584e0f9350ec74aa6a2cd44 |
|
25-Nov-2014 |
joshualitt <joshualitt@chromium.org> |
remove proc key BUG=skia: Review URL: https://codereview.chromium.org/755363002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
605dd0fbce9dbb2a0d3313e13e161f2bd54870d7 |
|
12-Nov-2014 |
egdaniel <egdaniel@google.com> |
Move GrInvariantOutput out of GrProcessor and into its own class. This will help with the ability to subclass, add to, etc. GrInvariantOutput. Also it was simply getting a little too big to be a "supporting" subclass BUG=skia: Review URL: https://codereview.chromium.org/699943003
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
f2703d83da3ab2ae18b45231fd4f11e16cce3184 |
|
28-Oct-2014 |
bsalomon <bsalomon@google.com> |
rename GrTextureDesc->GrSurfaceDesc, GrTextureFlags->GrSurfaceFlags Review URL: https://codereview.chromium.org/682223002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
420d7e9a79358908850c74192b4949375563449a |
|
16-Oct-2014 |
bsalomon <bsalomon@google.com> |
Auto-compare GrProcessors' texture accesses in isEqual(). R=joshualitt@google.com Review URL: https://codereview.chromium.org/654313002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
9e4d6d180fcfbbe2ea242196cc0affd45b7ed7ae |
|
15-Oct-2014 |
egdaniel <egdaniel@google.com> |
Move willUseInputColor check to computeInvariantOutput BUG=skia: Review URL: https://codereview.chromium.org/656503002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
0e08fc17e4718f7ce4e38f793695896473e96948 |
|
15-Oct-2014 |
bsalomon <bsalomon@google.com> |
Push isEqual/onIsEqual down from GrProcessor to subclasses. R=joshualitt@google.com Review URL: https://codereview.chromium.org/654273002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
e30597375c19dfb5197fd065a3d1768401eb00fa |
|
14-Oct-2014 |
bsalomon <bsalomon@google.com> |
Remove uses of GrAutoScratchTexture. Rename GrContext::lockAndRefScratchTexture to refScratchTexture. GrSurface::writePixels returns bool instead of void. BUG=skia:2889 Review URL: https://codereview.chromium.org/638403003
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
ccb2e384a036f29d989d3c1468f879324e81a678 |
|
13-Oct-2014 |
egdaniel <egdaniel@google.com> |
Create helper functions to use in computeInvariantOutput calls BUG=skia: Review URL: https://codereview.chromium.org/643743003
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
1598899975ecc85b003a59740b588d1ddbcedb09 |
|
10-Oct-2014 |
joshualitt <joshualitt@chromium.org> |
FPs now use the correct builder types(just a rename) BUG=skia: Review URL: https://codereview.chromium.org/648463003
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
1a8ecdfb73a15de600d5779b75d7c4b61863c50b |
|
03-Oct-2014 |
egdaniel <egdaniel@google.com> |
Add isSingleComponent bool to getConstantColorComponent Initial step to allowing effects to use/output 1 or 4 color/coverage components. This cl doesn't change any current logic and all effects still assume they are working with 4 components. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3b8af078281a5a20f951b9fd84f38d92b8f6217b Review URL: https://codereview.chromium.org/608253002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
b4b7a4c9ea2e399db550f93e3754c351e5b2079a |
|
02-Oct-2014 |
robertphillips <robertphillips@google.com> |
Revert of Add isSingleComponent bool to getConstantColorComponent (patchset #6 id:100001 of https://codereview.chromium.org/608253002/) Reason for revert: Changing some GMs Original issue's description: > Add isSingleComponent bool to getConstantColorComponent > > Initial step to allowing effects to use/output 1 or 4 color/coverage components. This cl doesn't change any current logic and all effects still assume they are working with 4 components. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/3b8af078281a5a20f951b9fd84f38d92b8f6217b TBR=joshualitt@chromium.org,bsalomon@google.com,reed@google.com,egdaniel@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/617853003
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
3b8af078281a5a20f951b9fd84f38d92b8f6217b |
|
02-Oct-2014 |
egdaniel <egdaniel@google.com> |
Add isSingleComponent bool to getConstantColorComponent Initial step to allowing effects to use/output 1 or 4 color/coverage components. This cl doesn't change any current logic and all effects still assume they are working with 4 components. BUG=skia: Review URL: https://codereview.chromium.org/608253002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
b0a8a377f832c59cee939ad721e1f87d378b7142 |
|
23-Sep-2014 |
joshualitt <joshualitt@chromium.org> |
Patch to create a distinct geometry processor. The vast majority of this patch is just a rename. The meat is in GrGeometryProcessor, GrProcessor, GrGL*Processor, GrProcessorStage, Gr*BackendProcessorFactory, GrProcessUnitTestFactory, and the builders BUG=skia: R=bsalomon@google.com Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/582963002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
23e280d1f227d94f6b3dfd0b47359cca1569e1b4 |
|
18-Sep-2014 |
joshualitt <joshualitt@chromium.org> |
Changes to remove program effects builder BUG=skia: R=bsalomon@google.com Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/551253004
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
49586bec7383d4ccb81f85f8e2dc4162e2d4f6a8 |
|
16-Sep-2014 |
joshualitt <joshualitt@chromium.org> |
removing GrDrawEffect BUG=skia: Committed: https://skia.googlesource.com/skia/+/8ddbe8b9366c8c59c4fb55f01f253de8a0b37d6e R=bsalomon@google.com Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/571163002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
08da4f22d790cfc51bbeb10b4b84dab49cf0eaec |
|
16-Sep-2014 |
joshualitt <joshualitt@chromium.org> |
Revert of removing GrDrawEffect (patchset #4 id:60001 of https://codereview.chromium.org/571163002/) Reason for revert: reverting to unblock another revert Original issue's description: > removing GrDrawEffect > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/8ddbe8b9366c8c59c4fb55f01f253de8a0b37d6e R=bsalomon@google.com TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/577593003
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
8ddbe8b9366c8c59c4fb55f01f253de8a0b37d6e |
|
16-Sep-2014 |
joshualitt <joshualitt@chromium.org> |
removing GrDrawEffect BUG=skia: R=bsalomon@google.com Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/571163002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
848250415eddc54075f7eb8795e8db79e749c6ab |
|
02-Sep-2014 |
reed <reed@google.com> |
make allocPixels throw on failure BUG=skia: R=mtklein@google.com, fmalita@google.com, fmalita@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/510423005
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
6267f81f3d60ce144ab2b09ea369420984d5c9d9 |
|
30-Aug-2014 |
bsalomon <bsalomon@google.com> |
Move MakeDivByTextureWHMatrix to GrCoordTransform R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/522873005
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
5e5f948b6b363dbfc8c076d8ff0c6b8e9ea99958 |
|
26-Aug-2014 |
senorblanco <senorblanco@chromium.org> |
Reimplement deserialization of SkImageFilter's uniqueID. 9fa60d ("Simplify flattening to just write enough ... ") simplified just a tad too much. In particular, it disabled deserialization of SkImageFilter's uniqueID, which in turn caused the failure of SkImageFilter's cache, which caused a large regression in Chrome's SVG filter performance. The medium-term fix is to switch to the new SkRecordDraw SkPicture backend, which will make the unique IDs unnecessary. This change is an "in case of emergecy" CL, in the event that there are problems switching on the new backend in Chrome. For that reason, it's minimalist: only the filters used by Chrome are modified, and whitespace changes are kept to a minimum. In this way, it should be easy to revert once the new backend goes in. R=reed@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/503833002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
30ba436f04e61d4505fb854d5fc56079636e0788 |
|
22-Aug-2014 |
joshualitt <joshualitt@chromium.org> |
Initial refactor of shaderbuilder to prepare for geometry shaders gitignore for eclipse BUG=skia: R=bsalomon@google.com, bsalomon@chromium.org Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/491673002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
9fa60daad4d5f54c0dbe3dbcc7608a8f6d721187 |
|
21-Aug-2014 |
reed <reed@google.com> |
Simplify flattening to just write enough to call the factory/public-constructor for the class. We want to *not* rely on private constructors, and not rely on calling through the inheritance hierarchy for either flattening or unflattening(CreateProc). Refactoring pattern: 1. guard the existing constructor(readbuffer) with the legacy build-flag 2. If you are a instancable subclass, implement CreateProc(readbuffer) to create a new instances from the buffer params (or return NULL). If you're a shader subclass 1. You must read/write the local matrix if your class accepts that in its factory/constructor, else ignore it. R=robertphillips@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org, sugoi@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/395603002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
673d9732bf37df724500e04afcdf27d5c711ef60 |
|
15-Aug-2014 |
senorblanco <senorblanco@chromium.org> |
Check all scratch texture allocations for image filters. BUG=403677 R=bsalomon@google.com NOTREECHECKS=true Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/473283002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
7510b224e52b9518a8ddf7418db0e9c258f79539 |
|
30-Jul-2014 |
kkinnunen <kkinnunen@nvidia.com> |
Rename GrGLUniformManager to GrGLProgramDataManager Rename GrGLUniformManager to GrGLProgramDataManager in anticipation that the class would be used to manage shader resources that are not uniforms. This is needed in order to implement NVPR on GLES. R=bsalomon@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/365853002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
63e99f7a03b2ac90ae7a00232674fd39c0bdcc68 |
|
21-Jul-2014 |
bsalomon <bsalomon@google.com> |
Allow GrGLEffects to produce variable length keys. R=robertphillips@google.com, jvanverth@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/385713005
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
848faf00ec33d39ab3e31e9a11d805cae6ac6562 |
|
11-Jul-2014 |
bsalomon <bsalomon@google.com> |
This moves us towards variable length effect keys. The overall program key now allows for it. After the header it stores an array of offsets to effect keys. This allows us to grab the effect keys to pass to effects when they generate code. It also ensures that we can't get a collision by sets of keys that are different lengths but are the same when appended together. R=robertphillips@google.com, jvanverth@google.com, egdaniel@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/356513003
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
83d081ae1d731b5039e99823620f5e287542ee39 |
|
08-Jul-2014 |
bsalomon <bsalomon@google.com> |
Goodbye GrEffectRef. Also, reworked some var names and comments around SkShader::asNewEffect. R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/374923002
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
9ea3d57fde28a5fe4487a111dc3dd49418235e5e |
|
08-Jul-2014 |
senorblanco <senorblanco@chromium.org> |
Clean up SkImageFilter constructors. Now that all creation of SkImageFilters goes through factory Create() methods, there's no real reason for the convenience constructors. Some SkImageFilter subclasses which actually have zero DAG-able inputs were passing NULL to the superclass constructor. This actually means 1 input, with a NULL value, not zero inputs. This becomes more relevant for the upcoming cache infrastructure, where this indicates that the filter will use its src input, where in fact some of these filters do not (they are image generators only). Limiting SkImageFilter to a single constructor resolves this ambiguity. Along the way, I removed all of the default parameters to the constructors, since the Create methods always call them with the full argument list. BUG=skia: R=reed@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/376953003
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
55fad7af61c21d502acb9891d631e8aa29e3628c |
|
08-Jul-2014 |
bsalomon <bsalomon@google.com> |
Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef. R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/371103003
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
c77392ed58ec78ab19fa0e3ff99fb8110854fba2 |
|
02-Jun-2014 |
reed <reed@google.com> |
use colortype instead of config clone of https://codereview.chromium.org/305133006/ TBR= BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/301233011
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
d4db657bf54ae5346cb142fed2f83ea88544a733 |
|
07-May-2014 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix for SkDisplacementMap::onFilterBounds(). Two problems: we were not applying the CTM to the scale parameter when modifying clip bounds, and the recursion for onFilterBounds() must be done in the reverse order. BUG=370914 R=junov@chromium.org Review URL: https://codereview.chromium.org/272643003 git-svn-id: http://skia.googlecode.com/svn/trunk@14627 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
28fcae2ec77eb16a79e155f8d788b20457f1c951 |
|
11-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/) Reason for revert: Want to reland the original CL. Original issue's description: > Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) > > Reason for revert: > breaking the Chrome deps roll. > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio > > Original issue's description: > > Rename kPMColor_SkColorType to kN32_SkColorType. > > > > The new name better represents what this flag means. > > > > BUG=skia:2384 > > > > Committed: http://code.google.com/p/skia/source/detail?r=14117 > > TBR=reed@google.com,scroggo@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14144 R=reed@google.com, bensong@google.com TBR=bensong@google.com, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: scroggo@google.com Review URL: https://codereview.chromium.org/235523003 git-svn-id: http://skia.googlecode.com/svn/trunk@14156 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
96edc2459820f0f60ea9b57959c1e5018ef95e28 |
|
11-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) Reason for revert: Chrome's side of define changes not easy to figure out quickly. Reverting this for DEPS roll for now. Original issue's description: > Rename kPMColor_SkColorType to kN32_SkColorType. > > The new name better represents what this flag means. > > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14117 R=reed@google.com, scroggo@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: bensong@google.com Review URL: https://codereview.chromium.org/234833003 git-svn-id: http://skia.googlecode.com/svn/trunk@14149 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
d923288e50b5a69afb0bdd5c161191b24cab8345 |
|
11-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/) Reason for revert: fixes on the chrome side are landing (brettw), keep fingers crossed. Original issue's description: > Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) > > Reason for revert: > breaking the Chrome deps roll. > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio > > Original issue's description: > > Rename kPMColor_SkColorType to kN32_SkColorType. > > > > The new name better represents what this flag means. > > > > BUG=skia:2384 > > > > Committed: http://code.google.com/p/skia/source/detail?r=14117 > > TBR=reed@google.com,scroggo@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14144 R=reed@google.com, scroggo@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: bensong@google.com Review URL: https://codereview.chromium.org/233813004 git-svn-id: http://skia.googlecode.com/svn/trunk@14145 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
757ebd20ef284b6428eb9f4b9b69826cc3640a82 |
|
11-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) Reason for revert: breaking the Chrome deps roll. http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio Original issue's description: > Rename kPMColor_SkColorType to kN32_SkColorType. > > The new name better represents what this flag means. > > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14117 R=reed@google.com, scroggo@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: bensong@google.com Review URL: https://codereview.chromium.org/234243002 git-svn-id: http://skia.googlecode.com/svn/trunk@14144 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
149e9a107c356b0151433fb23c2b1c8d0634947c |
|
09-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Rename kPMColor_SkColorType to kN32_SkColorType. The new name better represents what this flag means. BUG=skia:2384 R=reed@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/227433009 git-svn-id: http://skia.googlecode.com/svn/trunk@14117 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
d9cdff67a40e21cf45d3e07b483b9c745bd4481f |
|
18-Mar-2014 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix GPU displacement with expanding crop rects. Fix GPU displacement with expanding crop rects, and re-enable the imagefilterscropexpand GM. There were two bugs: the result texture was being created at input color bitmap size, not the cropped bounds size, and the matrix in GrContext was not being set to identity before draw. R=junov@chromium.org Review URL: https://codereview.chromium.org/195973007 git-svn-id: http://skia.googlecode.com/svn/trunk@13844 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
118252962f89a80db661a0544f1bd61cbaab6321 |
|
14-Mar-2014 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implement support for expanding crop rects in image filters NOTE: this patch set is based on https://codereview.chromium.org/189913021/, and needs that patch to land first. Until now, crop rects in Skia have only been able to reduce the size of the destination bounds, but not expand them. SVG semantics require the latter as well. The heart of the change is in applyCropRect(), which now assigns each edge, instead of doing an intersection with the crop rect. In order to support this (and still work well with tiled drawing) we need to clip the resulting crop rect to the clipping region of the filters. This uses the Context struct previously landed from https://codereview.chromium.org/189913021/. Many of the pixel loops are not yet ready to handle a destination rect larger than the source rect. So we provide a convenience version of applyCropRect() which creates an offscreen and pads it out with transparent black. Once the pixel loops and shaders have been fixed to support larger destination bounds, they should be switched back to the non-drawing version of applyCropRect(). BUG=skia: R=bsalomon@google.com, reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=13805 Review URL: https://codereview.chromium.org/198003008 git-svn-id: http://skia.googlecode.com/svn/trunk@13809 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
29089179a66c06ef70da387111af75970f04ed53 |
|
14-Mar-2014 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Implement support for expanding crop rects in image filters" Breaking ImageFilterTests unit test. TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/196353021 git-svn-id: http://skia.googlecode.com/svn/trunk@13806 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
0ef0501baf615149d6d84398d7594cd89f6e928d |
|
14-Mar-2014 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implement support for expanding crop rects in image filters NOTE: this patch set is based on https://codereview.chromium.org/189913021/, and needs that patch to land first. Until now, crop rects in Skia have only been able to reduce the size of the destination bounds, but not expand them. SVG semantics require the latter as well. The heart of the change is in applyCropRect(), which now assigns each edge, instead of doing an intersection with the crop rect. In order to support this (and still work well with tiled drawing) we need to clip the resulting crop rect to the clipping region of the filters. This uses the Context struct previously landed from https://codereview.chromium.org/189913021/. Many of the pixel loops are not yet ready to handle a destination rect larger than the source rect. So we provide a convenience version of applyCropRect() which creates an offscreen and pads it out with transparent black. Once the pixel loops and shaders have been fixed to support larger destination bounds, they should be switched back to the non-drawing version of applyCropRect(). BUG=skia: R=bsalomon@google.com, reed@google.com Review URL: https://codereview.chromium.org/198003008 git-svn-id: http://skia.googlecode.com/svn/trunk@13805 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
4cb543d6057b692e1099e9f115155f0bf323a0c8 |
|
14-Mar-2014 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implement support for a Context parameter in image filters Some upcoming work (support for expanding crop rects) requires the clip bounds to be available during filter traversal. This change replaces the SkMatrix parameter in the onFilterImage() traversals with a Context parameter. It contains the CTM, as well as the clip bounds. BUG=skia: R=reed@google.com Review URL: https://codereview.chromium.org/189913021 git-svn-id: http://skia.googlecode.com/svn/trunk@13803 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
cac5fd597f6e2495f50aaa6bcbe3dadc56f0b977 |
|
10-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Factory methods for heap-allocated SkImageFilter objects. This is part of an effort to ensure that all SkPaint effects can only be allocated on the heap. This patch makes the constructors of SkImageFilter and its subclasses non-public and instead provides factory methods for creating these objects on the heap. We temporarily keep constructor of publicly visible classes public behind a flag. BUG=skia:2187 R=scroggo@google.com, mtklein@chromium.org, reed@google.com, senorblanco@google.com, senorblanco@chromium.org, bsalomon@google.com, sugoi@chromium.org, zork@chromium.org Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/182983003 git-svn-id: http://skia.googlecode.com/svn/trunk@13718 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
6aa6fec0e332c9246958245bad5fc881fefee68f |
|
03-Mar-2014 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Cleanup patch to move all of SkImageFilterUtils into SkImageFilter. This was a utility class that dates from before GPU code was allowed in core. Now that it is, there's no reason not to have this functionality in SkImageFilter. Covered by existing tests. R=reed@google.com Review URL: https://codereview.chromium.org/185973003 git-svn-id: http://skia.googlecode.com/svn/trunk@13646 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
e24ad23ae67ffcb0dc545b7e426cf08d102e0868 |
|
16-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
use SkColorType instead of SkBitmap::Config in views/effects R=scroggo@google.com, reed@google.com TBR=scroggo Author: reed@chromium.org Review URL: https://codereview.chromium.org/168843002 git-svn-id: http://skia.googlecode.com/svn/trunk@13469 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
ae761f7545d8ebf181d220169afac2056b057b8c |
|
05-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make SkImageFilter methods const. SkImageFilter had some non-const methods that could all be made const. This is a first step towards making SkImageFilter immutable. BUG=skia:2097 R=mtklein@google.com, reed@google.com, robertphillips@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/148883011 git-svn-id: http://skia.googlecode.com/svn/trunk@13330 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
c4b12f19a46946e1c02f3525e0ea4902b09feac5 |
|
05-Feb-2014 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implement correct clipping for image filters. Image filters in Skia currently clip the size of the the offscreen bitmap used for filtering to the device clip bounds. This means that any pixel-moving filter (e.g., blur) has edge artifacts at the clip boundaries. This is problematic for tiling, where a single SkPicture is played back with a clip set to the tile boundaries. By implementing the onFilterBounds() traversal, and using it in saveLayer() when a filter is present, we can clip the layer to the expanded clip rect. Note that this requires that the traversal be performed in reverse as compared to computeFastBounds(). (It's also done in device space, unlike computeFastBounds()). New test imagefiltersclipped tests pixel-moving filters when clipped by various clip rects. New test imageblurtiled tests tiled (compositor-style) rendering of blurred text. There should be no artifacts at the tile boundaries. BUG=337831 R=reed@google.com Review URL: https://codereview.chromium.org/23011012 git-svn-id: http://skia.googlecode.com/svn/trunk@13323 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
8b0e8ac5f582de80356019406e2975079bf0829d |
|
30-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Refactor read and write buffers. Eliminates SkFlattenable{Read,Write}Buffer, promoting SkOrdered{Read,Write}Buffer a step each in the hierarchy. What used to be this: SkFlattenableWriteBuffer -> SkOrderedWriteBuffer SkFlattenableReadBuffer -> SkOrderedReadBuffer SkFlattenableReadBuffer -> SkValidatingReadBuffer is now SkWriteBuffer SkReadBuffer -> SkValidatingReadBuffer Benefits: - code is simpler, names are less wordy - the generic SkFlattenableFooBuffer code in SkPaint was incorrect; removed - write buffers are completely devirtualized, important for record speed This refactoring was mostly mechanical. You aren't going to find anything interesting in files with less than 10 lines changed. BUG=skia: R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/134163010 git-svn-id: http://skia.googlecode.com/svn/trunk@13245 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
336d1d759590d9bedcbc5a96d0fff79861cf8f7a |
|
27-Jan-2014 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implement a computeFastBounds() traversal for SkImageFilter. This allows for correct culling of primitives which have image filters applied. R=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/137423005 git-svn-id: http://skia.googlecode.com/svn/trunk@13207 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
9ebcac54635cde63110d73ad7c43d70772e7872f |
|
24-Jan-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add installPixels BUG=skia: R=halcanary@google.com Review URL: https://codereview.chromium.org/143073008 git-svn-id: http://skia.googlecode.com/svn/trunk@13174 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
2bfe36b68d11d05c114a33d62f9f45427e316916 |
|
20-Jan-2014 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Apply the CTM to filter parameters for SkBlurImageFilter, SkDropShadowImageFilter, SkDisplacementMapEffect and SkMorphologyImageFilter. I had resisted this (and may later put in an assert that the CTM contains no rotation, skew or perspective), but it just makes the filters play better with Skia generally. This revealed that the displacement map was not handling clipping or upstream cropping at all well (the color would "swim" through the displacement at the edge of the clip rect). Fixed by passing through the correct offsets to the bitmap accesses in both raster and GPU paths. Same for morphology. R=sugoi@google.com Review URL: https://codereview.chromium.org/137053003 git-svn-id: http://skia.googlecode.com/svn/trunk@13127 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
6776b82d466fa93ccffd251fdf556fe058395444 |
|
03-Jan-2014 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make SkImageFilter crop rects relative to the primitive origin, instead of relative to their parent's crop rect. This is required by SVG semantics, and is more sane anyway. To do this, this patch changes the "offset/loc" parameter in filterImage() / onFilterImage() from an inout-param to an out-param only, so that the calling filter can know how much the input filter wants its result offset (and doesn't include the original primitive position). This offset can then be applied to the current filter's crop rect. (I've renamed the parameter "offset" in all cases to make this clear.) This makes the call sites in SkCanvas/SkGpuDevice responsible for applying the resulting offset to the primitive's position, which is actually a fairly small change. This change also fixes SkTileImageFilter and SkOffsetImageFilter to correctly handle an input offset, which they weren't before. This required modifying the GM's, since they assumed the broken behaviour. NOTE: this will require rebaselining the imagefiltersgraph test, since it has a new test case. NOTE: this will "break" the Blink layout tests css3/filters/effect-reference-subregion-chained-hw.html and css3/filters/effect-reference-subregion-hw.html, but it actually makes them give correct results. It should be suppressed on the skia roll, and I'll rebaseline it. R=reed@google.com Review URL: https://codereview.chromium.org/112803004 git-svn-id: http://skia.googlecode.com/svn/trunk@12895 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
6d7296aaa0ec8be655cdf1ef5b53c27bc0843670 |
|
19-Dec-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Accept displacement with no displacement input BUG= R=senorblanco@google.com, senorblanco@chromium.org, sugoi@google.com, bsalomon@google.com, bsalomon@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/104853005 git-svn-id: http://skia.googlecode.com/svn/trunk@12773 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
ef74fa189b738e13295d6a96f86a6e10223505a8 |
|
17-Dec-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixed more fuzzer issues - Added the "isAvailable" function to check how much bytes are remaining in the stream before doing potentially large mallocs. That way, we can signal a bad stream instead of crashing. - Added data validation in SkImageInfo.cpp - Added NULL pointer check in displacement - Modified the fuzzer for randomized bitmap types BUG=328934,329254 R=senorblanco@google.com, senorblanco@chromium.org, reed@google.com, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/116773002 git-svn-id: http://skia.googlecode.com/svn/trunk@12723 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
5e79c2b707eff50405fb247debfdfdac699f7398 |
|
12-Dec-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixed a displacement issue The displacement filter was assuming that both inputs were of the same size, which is true in blink, but not necessarily in a compromised stream. BUG=327372 R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, fmalita@chromium.org, fmalita@google.com, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/101623007 git-svn-id: http://skia.googlecode.com/svn/trunk@12655 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
ce33d60187718e7bb01944ee130c9f5d9fb335ec |
|
25-Nov-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Adding more validation - Added a way to check that the number of inputs of a filter is not more than a filter expects - Added validation of reftype in SkBitmap::unflatten() - Added validation on fKD (diffuse lighting constant) and fKS (specular lighting constant) to make sure that they are always non-negative numbers - Added validation of SkPerlinNoiseShader::fType and SkPerlinNoiseShader::fNumOctaves BUG= R=reed@google.com, senorblanco@google.com, mtklein@google.com, senorblanco@chromium.org, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/83343003 git-svn-id: http://skia.googlecode.com/svn/trunk@12388 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
4b413c8bb123e42ca4b9c7bfa6bc2167283cb84c |
|
25-Nov-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove SkFloatToScalar macro BUG= R=reed@google.com, djsollen@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/85463005 git-svn-id: http://skia.googlecode.com/svn/trunk@12385 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
c0b7e10c6a68f59e1653e6c18e6bc954b3c3f0cf |
|
23-Oct-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Initial error handling code I made it as simple as possible. The impact seems minimal and it should do what's necessary to make this code secure. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11247 R=reed@google.com, scroggo@google.com, djsollen@google.com, sugoi@google.com, bsalomon@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/23021015 git-svn-id: http://skia.googlecode.com/svn/trunk@11922 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
a34995e18b1f0a7d8c9f23451718bb30ff0105b0 |
|
23-Oct-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implement SkColorFilter as a GrGLEffect Adds GrEffect::willUseInputColor() which indicates whether or not the input color affects the output of the effect. This is needed for certain Xfermodes, such as kSrc_Mode. For these modes the color filter will not use the input color. An effect with GrEffect::willUseInputColor() true will cause all color or coverage effects before it to be discarded, as their computations cannot affect the output. In these cases program is marked as having white input color. This fixes an assert when Skia is compiled in a mode that prefers using uniforms instead of attributes for constants. (Flags GR_GL_USE_NV_PATH_RENDERING or GR_GL_NO_CONSTANT_ATTRIBUTES). Using attributes hides the problem where the fragment shader does not need input color for color filters that ignore DST part of the filter. The assert would be hit when uniform manager tries to bind an uniform which has been optimized away by the shader compiler. Adds specific GrGLSLExpr4 and GrGLSLExpr1 classes. This way the GLSL expressions like "(v - src.a)" can remain somewhat readable in form of "(v - src.a())". The GrGLSLExpr<typename> template implements the generic functionality, GrGLSLExprX is the specialization that exposes the type-safe interface to this functionality. Also adds operators so that GLSL binary operators of the form "(float * vecX)" can be expressed in C++. Before only the equivalent "(vecX * float)" was possible. This reverts the common blending calculations to more conventional order, such as "(1-a) * c" instead of "c * (1-a)". Changes GrGLSLExpr1::OnesStr from 1 to 1.0 in order to preserve the color filter blending formula string the same (with the exception of variable name change). Shaders change in case of input color being needed: - vec4 filteredColor; - filteredColor = (((1.0 - uFilterColor.a) * output_Stage0) + uFilterColor); - fsColorOut = filteredColor; + vec4 output_Stage1; + { // Stage 1: ModeColorFilterEffect + output_Stage1 = (((1.0 - uFilterColor_Stage1.a) * output_Stage0) + uFilterColor_Stage1); + } + fsColorOut = output_Stage1; Shaders change in case of input color being not needed: -uniform vec4 uFilterColor; -in vec4 vColor; +uniform vec4 uFilterColor_Stage0; out vec4 fsColorOut; void main() { - vec4 filteredColor; - filteredColor = uFilterColor; - fsColorOut = filteredColor; + vec4 output_Stage0; + { // Stage 0: ModeColorFilterEffect + output_Stage0 = uFilterColor_Stage0; + } + fsColorOut = output_Stage0; } R=bsalomon@google.com, robertphillips@google.com, jvanverth@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/25023003 git-svn-id: http://skia.googlecode.com/svn/trunk@11912 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
01bdf3c568f9df2df4a787197caeba736b23fe73 |
|
15-Oct-2013 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add crop rect support for SkDisplacementMapEffect (raster and GPU paths). Covered by new test cases added to displacement GM (will require rebaseline). R=bsalomon@google.com Review URL: https://codereview.chromium.org/26531002 git-svn-id: http://skia.googlecode.com/svn/trunk@11782 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
77af6805e5faea1e2a5c0220098aec9082f3a6e5 |
|
02-Oct-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make GPU coord transforms automatic Adds a GrCoordTransform class and updates the framework to handle coord transforms similar to how it handles textures with GrTextureAccess. Renames GrGLEffectMatrix to GrGLCoordTransform and slightly repurposes it to be used by the framework instead of effects. R=bsalomon@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/24853002 git-svn-id: http://skia.googlecode.com/svn/trunk@11569 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
24ddde97581624777feebc9e95ae558282f95d4c |
|
16-Sep-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert 11247, 11250, 11251, 11257, and 11279 to unblock DEPS roll (https://codereview.chromium.org/24159002/) 11279 Sanitizing source files in Housekeeper-Nightly - https://code.google.com/p/skia/source/detail?r=11279 11257 Canary build fix - https://codereview.chromium.org/23532068 11251 More warnings as errors fixes - https://code.google.com/p/skia/source/detail?r=11251 11250 Warnings as errors fix - https://code.google.com/p/skia/source/detail?r=11250 11247 Initial error handling code - https://chromiumcodereview.appspot.com/23021015 git-svn-id: http://skia.googlecode.com/svn/trunk@11288 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
ba6e954140e45e251d67934ed6ad752149fcf72f |
|
16-Sep-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert the revert of 11247, 11250, 11251 and 11279 (Chrome already relies on changes in r11247) git-svn-id: http://skia.googlecode.com/svn/trunk@11287 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
478884f7d3b8c7be8b62f3fa2b79192f411c3fec |
|
16-Sep-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert 11247, 11250, 11251 and 11279 to unblock DEPS roll (https://codereview.chromium.org/24159002/) 11279 Sanitizing source files in Housekeeper-Nightly - https://code.google.com/p/skia/source/detail?r=11279 11251 More warnings as errors fixes - https://code.google.com/p/skia/source/detail?r=11251 11250 Warnings as errors fix - https://code.google.com/p/skia/source/detail?r=11250 11247 Initial error handling code - https://chromiumcodereview.appspot.com/23021015 git-svn-id: http://skia.googlecode.com/svn/trunk@11285 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
5792cded61a7302f32bd0f4aeda51a9b2f1d00f6 |
|
13-Sep-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Initial error handling code I made it as simple as possible. The impact seems minimal and it should do what's necessary to make this code secure. BUG= R=reed@google.com, scroggo@google.com, djsollen@google.com, sugoi@google.com, bsalomon@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://chromiumcodereview.appspot.com/23021015 git-svn-id: http://skia.googlecode.com/svn/trunk@11247 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
e0e7cfe44bb9d66d76120a79e5275c294bacaa22 |
|
09-Sep-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Change old PRG to be SkLCGRandom; change new one to SkRandom The goal here is to get people to start using the new random number generator, while leaving the old one in place so we don't have to rebaseline GMs. R=reed@google.com, bsalomon@google.com Author: jvanverth@google.com Review URL: https://chromiumcodereview.appspot.com/23576015 git-svn-id: http://skia.googlecode.com/svn/trunk@11169 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
74a3a2135ca82ab9324b7e499caa3280348a4fda |
|
30-Aug-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Rename ShaderType enum to ShaderVisibility Renames ShaderType in GrGLShaderBuilder to ShaderVisibility. It is now used solely as a bitfield. Methods that previously accepted a single ShaderType value are split into separate calls: - getShader -> vsGetShader, gsGetShader, fsGetShader - emiitFunction -> fsEmitFunction - appendTextureLookup -> fsAppendTextureLookup No change in functionality. This is a refactoring to allow us to separate the vertex/geometry and fragment parts of GrGLShaderBuilder. R=bsalomon@google.com Author: cdalton@nvidia.com Review URL: https://chromiumcodereview.appspot.com/23826002 git-svn-id: http://skia.googlecode.com/svn/trunk@11044 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
7ab7ca4199e97126de01d507d34f60a07843937f |
|
28-Aug-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix case where GrGLEffectMatrix gives back a dangling ptr for the coords var name. R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://chromiumcodereview.appspot.com/23706003 git-svn-id: http://skia.googlecode.com/svn/trunk@10982 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
330313a8a8343876ee596da39da06a5d69badd9c |
|
22-Aug-2013 |
mtklein@google.com <mtklein@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
My clang now doesn't complain about !"foo". BUG= R=robertphillips@google.com Review URL: https://codereview.chromium.org/22875037 git-svn-id: http://skia.googlecode.com/svn/trunk@10874 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
1aa54bf6696afc7d06fc8ecc63dad2840a4d6179 |
|
05-Aug-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added ctm matrix to GPU path There should be no changes in behavior caused by this cl, it just adds the ctm matrix to filterImageGPU so that it may be used for scaling on all platforms when it is implemented on the blink side. BUG= R=senorblanco@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://chromiumcodereview.appspot.com/22209002 git-svn-id: http://skia.googlecode.com/svn/trunk@10536 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
42dacab4e7366d9f53989558cc8d045c3d065bcd |
|
13-Jul-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make GrPaint have a variable sized array of color and coverage stages rather than a fixed size. R=robertphillips@google.com, jvanverth@google.com Author: bsalomon@google.com Review URL: https://chromiumcodereview.appspot.com/18686007 git-svn-id: http://skia.googlecode.com/svn/trunk@10062 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
7b320703d47ff2b242ae74faba5e4b0af3560d71 |
|
10-Jul-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implement offset for GPU filter path. Although we can't yet use this in Blink for FEOffset, due to SVG semantics, we can use it to support crop rect (upcoming patch). This patch adds the parameter to the filterImageGPU() signature, plumbs through the code on the GPU side, and implements support for it in SkXfermodeImageFilter for both raster and GPU. Of the remaining filters with GPU implementations, Blur, Morphology, Bicubic and Displacement work fine; they're commutative wrt offset and can simply pass it up the chain. Blend is not, but will be removed shortly anyway (has been replaced with SkXfermodeImageFilter in Blink). R=reed@google.com, bsalomon@google.com Author: senorblanco@chromium.org Review URL: https://chromiumcodereview.appspot.com/15995026 git-svn-id: http://skia.googlecode.com/svn/trunk@9977 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
b8d00db075b5ea09e353508a26ef5ced50722a6c |
|
26-Jun-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Change undefined SkGpuRenderTarget and SkGpuTexture forward declares to GrRenderTarget and GrTexture. R=robertphillips@google.com, reed@google.com Author: bsalomon@google.com Review URL: https://chromiumcodereview.appspot.com/17269003 git-svn-id: http://skia.googlecode.com/svn/trunk@9775 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
48552314f6d101f3fd094d5f2fd6f70fe9aad841 |
|
26-Mar-2013 |
tfarina@chromium.org <tfarina@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix a few clang errors while trying to build tools target. Most of the errors were like: ../../src/gpu/gl/GrGLEffectMatrix.cpp:74:9: error: variable 'varyingType' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized] ../../src/gpu/gl/debug/GrDebugGL.h:125:21: error: private field 'fMaxTextureUnits' is not used [-Werror,-Wunused-private-field] ../../src/core/SkBitmapSampler.cpp:312:25: error: private field 'fProcTable' is not used [-Werror,-Wunused-private-field] R=bsalomon@google.com,scroggo@google.com Review URL: https://codereview.chromium.org/12915007 git-svn-id: http://skia.googlecode.com/svn/trunk@8403 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
c26d94fd7dc0b00cd6d0e42d28285f4a38aff021 |
|
25-Mar-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Move nested class GrDrawTarget::Caps out as GrDrawTargetCaps. Pass caps to GrEffect::TestCreate() functions so that they can return effects that will work with the capabilities. Review URL: https://codereview.chromium.org/12965018 git-svn-id: http://skia.googlecode.com/svn/trunk@8369 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
4d94e1bb06342e611d4e2cc8ecb3b921ea217475 |
|
21-Mar-2013 |
sugoi@google.com <sugoi@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Removed the "any" command from the displacement glsl shader. WebKit's version of Mesa's compiler seems to crash on the "any" command even though it's a GLSL 1.1 command. Review URL: https://codereview.chromium.org/12413030 git-svn-id: http://skia.googlecode.com/svn/trunk@8300 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
c1641fc92259a1ca5cfc32cd5c8c55ea316b2bd1 |
|
21-Mar-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping git-svn-id: http://skia.googlecode.com/svn/trunk@8281 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
c78188896e28a4ae49e406a7422b345ae177dafe |
|
20-Mar-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Attempt to reland 8264-5 with warning-as-error fixes. git-svn-id: http://skia.googlecode.com/svn/trunk@8272 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
67e7cde5c5e59a8f1de7ee28276b8193ecb2bc7f |
|
20-Mar-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
revert 8265-8264 (broke build) git-svn-id: http://skia.googlecode.com/svn/trunk@8268 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
ae81d5c4aa1716756b2cfb4c44f27f4dce2716ef |
|
20-Mar-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Adds local coords to GrEffect system. Effects can ask the builder for local coords which may or may not be distinct from positions. GrEffectStage tracks changes to relationship between pos and local coords. GrGLEffectMatrix and GrSingleTextureEffect can use either pos or textures as intput coords GrSimpleTextureEffect now allows for an explicit texture coords attribute. Review URL: https://codereview.chromium.org/12531015 git-svn-id: http://skia.googlecode.com/svn/trunk@8264 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
4ecd42e4bf41ef5ad92bfd67bdcf365c8c6d2864 |
|
19-Mar-2013 |
sugoi@google.com <sugoi@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix for displacement mapping Fixed the skia displacement map effect to match the WebKit displacement map fix. Review URL: https://codereview.chromium.org/12787007 git-svn-id: http://skia.googlecode.com/svn/trunk@8225 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
f910d3b23bcf590ee937628dbab8e39a98ee5860 |
|
07-Mar-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make GrGLEffects use an interface to append their code. A small step towards encapsulating GrGLShaderBuilder. Review URL: https://codereview.chromium.org/12547012 git-svn-id: http://skia.googlecode.com/svn/trunk@8018 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
73a9694b4ceb67547e5863db5315488e7d5294f7 |
|
13-Feb-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Use SkMWRandom in GLPrograms test. R=jvanverth@google.com Review URL: https://codereview.appspot.com/7306097 git-svn-id: http://skia.googlecode.com/svn/trunk@7721 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
c2594f41066102d7a8a73effd3c574142a018b9a |
|
30-Jan-2013 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
This changes the signature of SkImageFilter::filterImageGPU() to use SkBitmaps for input and output, and removes the rect param. This allows us to return textures which are larger than the actual result, such as when GrAutoScratchTextures are used. The SkBitmap's size represents the active region, while the GrTexture's size is the full texture size. This fixes the bicubic image filter GM on the GPU, which otherwise draws garbage outside the filtered region. It also moves us closer to unifying the signatures of SkImageFilter::onFilterImage() and SkImageFilter::filterImageGPU(). Review URL: https://codereview.appspot.com/7180048 git-svn-id: http://skia.googlecode.com/svn/trunk@7467 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
ef5dbe1cd90fe586f165e54cb6f7608942610793 |
|
28-Jan-2013 |
senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add an origin flag for backend (external) textures. Some textures in WebKit have a topdown orientation, and skia needs to be notified of this, so that they are not drawn upside-down. Review URL: https://codereview.appspot.com/7200048 git-svn-id: http://skia.googlecode.com/svn/trunk@7414 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
95ed55adc6b8f0cee063c2cf2e14782773b0087f |
|
24-Jan-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make all GrContext members that return a texture also ref the texture for the caller. Review URL: https://codereview.appspot.com/7198049 git-svn-id: http://skia.googlecode.com/svn/trunk@7362 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
8a252f79629b189a03de22cd8ff0312c5bccedd1 |
|
22-Jan-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Switch GrEffect::onIsEqual signature back to GrEffect from GrEffectRef. R=robertphillips@google.com Review URL: https://codereview.appspot.com/7188046 git-svn-id: http://skia.googlecode.com/svn/trunk@7326 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
6340a41108633ac1ce5941e5cd30538630c4c55b |
|
22-Jan-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Let them eat GrEffectRef. Changes the remaining existing code that operates on naked GrEffects to GrEffectRef. Review URL: https://codereview.appspot.com/7124058 git-svn-id: http://skia.googlecode.com/svn/trunk@7321 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
68b58c95384dd6c2fd389a5b4bbf8fc468819454 |
|
17-Jan-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove default implementation of GrEffect::isEqual. Make GrSingleTextureEffect abstract. Review URL: https://codereview.appspot.com/7142049 git-svn-id: http://skia.googlecode.com/svn/trunk@7254 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
a1ebbe447d5eab098111eb83580e55f2f5f6faca |
|
16-Jan-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Change some function/vars from EffectPtr to EffectRef to reflect GrEffectPtr->GrEffectRef renaming. git-svn-id: http://skia.googlecode.com/svn/trunk@7226 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
0ac6af49975c54c2debf41e9200af416ecd2d973 |
|
16-Jan-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Wrap GrEffects in GrEffectPtr. This is the first step towards automatic recycling of scratch resouces in the cache via ref-cnts. R=robertphillips@google.com Review URL: https://codereview.appspot.com/7092061 git-svn-id: http://skia.googlecode.com/svn/trunk@7222 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
ff21c2e0ae23da0f4742b47d4d37969a2a18bd99 |
|
16-Jan-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping git-svn-id: http://skia.googlecode.com/svn/trunk@7215 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
4d69227d9030b48929ace51fc0b016f7c0c1e584 |
|
15-Jan-2013 |
sugoi@google.com <sugoi@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Unreviewed mac build fix : Removing unused variable git-svn-id: http://skia.googlecode.com/svn/trunk@7186 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
8cec63e477e8fb55c94ca7ed9643ebbfcc38c008 |
|
15-Jan-2013 |
sugoi@google.com <sugoi@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added missing include in non GPU case. Review URL: https://codereview.appspot.com/7093067 git-svn-id: http://skia.googlecode.com/svn/trunk@7185 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|
781cc76e0f1ebb06e0796a9237045ae9d4bddd21 |
|
15-Jan-2013 |
sugoi@google.com <sugoi@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implementation of the displacement effect (both CPU and GPU) TEST=Added new GM called "displacement" Review URL: https://codereview.appspot.com/7058075 git-svn-id: http://skia.googlecode.com/svn/trunk@7182 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/effects/SkDisplacementMapEffect.cpp
|