283b5878e7225a49511cbd3f0fa12603a51319df |
|
25-Apr-2015 |
tfarina <tfarina@chromium.org> |
Update {virtual,override} to follow C++11 style in src/utils. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. The entries were found using the following command line: $ find src/utils -iname "*.h" -o -iname "*.cpp" | xargs pcregrep -M "[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]" The regex was a courtesy of nick@chromium.org BUG=None R=mtklein@google.com Review URL: https://codereview.chromium.org/1099333004
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
5965b73e54da7746e1dafa7c696a4ddf9bd0f271 |
|
07-Apr-2015 |
scroggo <scroggo@google.com> |
Revert of Remove now-redundant SkPathOps enum. (patchset #1 id:1 of https://codereview.chromium.org/1051113005/) Reason for revert: Android is still using this. See https://android-build.storage.googleapis.com/builds/git_master-skia-linux-razor-userdebug/1836783/4c2968b94c5f4b238ff5ba61111bf867ea872fd8dce930612f376711883419b8/logs/build_error.log?GoogleAccessId=701025073339-mqn0q2nvir9iurm6q5d00tdv7blbgvjr%40developer.gserviceaccount.com&Signature=ATvg9ZvwZGFDDVb%2B1Ue2WHVGaCCL1hAD7QjXeZv2gBT08I3JaKLcseUhV5K2G%2F%2BWUnsnSgNNjzjBnBLmnPbK9Uu8NC%2B%2F5J0dU3sKD8TU9dvMtkQhFQSp2x5t5Xxf5mczi2EPps%2FwoPHqTKQqrMgqStySzw206W1%2Fc135RrdrgYg%3D&Expires=1428415459 Original issue's description: > Remove now-redundant SkPathOps enum. > > R=caryclark,reed > BUG=473772 > > Committed: https://skia.googlesource.com/skia/+/143244e27d95255807d8fa505ce0affef96d1fc8 TBR=caryclark@google.com,reed@google.com,schenney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=473772 Review URL: https://codereview.chromium.org/1068873002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
143244e27d95255807d8fa505ce0affef96d1fc8 |
|
06-Apr-2015 |
schenney <schenney@chromium.org> |
Remove now-redundant SkPathOps enum. R=caryclark,reed BUG=473772 Review URL: https://codereview.chromium.org/1051113005
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
160ebb2bfa0794d72d31a786793b13413289863d |
|
02-Apr-2015 |
fmalita <fmalita@chromium.org> |
[SkDebugger] Flatten drawPicture ops Add two drawPicture bracketing ops (BeginDrawPicture, EndDrawPicture) to replace the current DrawPicture op, and flatten picture contents. Review URL: https://codereview.chromium.org/1048383002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
546db46a76ad5f7485cebeb27efaf8b4806fa914 |
|
26-Mar-2015 |
robertphillips <robertphillips@google.com> |
Debugger: remove dead feature (SkPicture offset display) & fix bug (unbalanced indents) Displaying the offset into an SkPicture hasn't worked for a while so this CL deletes the feature. When "Save Layer" was renamed to "SaveLayer" the code that computes the indent in the list view was broken. This CL patches the problem. Review URL: https://codereview.chromium.org/1034733004
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
65cdb57ae8fd23ccec5f7f4f86b34e4aa85c45ae |
|
26-Mar-2015 |
fmalita <fmalita@chromium.org> |
Add a paint filter utility canvas (SkPaintFilterCanvas) Introduce a paint filter proxy base class as a SkDrawFilter replacement, and convert SkDebugCanvas to use the new approach. BUG=skia:3587 R=reed@google.com,mtklein@google.com,robertphillips@google.com,tomhudson@google.com Review URL: https://codereview.chromium.org/1032173002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
36352bf5e38f45a70ee4f4fc132a38048d38206d |
|
26-Mar-2015 |
mtklein <mtklein@chromium.org> |
C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} NOPRESUBMIT=true BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1037793002 Review URL: https://codereview.chromium.org/1037793002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
93a1215fe0ab007ce941c721f1fd3e9dcb5d4754 |
|
16-Mar-2015 |
reed <reed@google.com> |
SkPaint::FilterLevel -> SkFilterQuality clone (+rebase) of https://codereview.chromium.org/1009183002/ BUG=skia: TBR=scroggo@google.com Review URL: https://codereview.chromium.org/1014533004
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
6ba791f66128ebbe401978103baf7b5ec0ac98cd |
|
11-Mar-2015 |
robertphillips <robertphillips@google.com> |
Fix debugger's overdraw color filter The colors seen in the overdraw color filter are not guaranteed to remain the colors from its own table. Looping through the table to find the old overdraw level is error prone and expensive. Review URL: https://codereview.chromium.org/997913002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
9bafc30c7900375d316d47e24412ddfd8bd0b1f2 |
|
13-Feb-2015 |
robertphillips <robertphillips@google.com> |
Remove SkPictureFlat.h include from SkDrawCommands.h This cannot land until https://codereview.chromium.org/909353004/ (Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes) lands in Chromium Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976 Committed: https://skia.googlesource.com/skia/+/fa3a83d0fe53907e618346d3f1c17a95da1a9d22 Review URL: https://codereview.chromium.org/912403004
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
3a092042bce0a8b7c43bf621cacdb2c644febeb2 |
|
12-Feb-2015 |
robertphillips <robertphillips@google.com> |
Revert of Remove SkPictureFlat.h include from SkDrawCommands.h (patchset #3 id:40001 of https://codereview.chromium.org/912403004/) Reason for revert: Erm - Chrome. Original issue's description: > Remove SkPictureFlat.h include from SkDrawCommands.h > > This cannot land until https://codereview.chromium.org/909353004/ (Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes) lands in Chromium > > Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976 > > Committed: https://skia.googlesource.com/skia/+/fa3a83d0fe53907e618346d3f1c17a95da1a9d22 TBR=reed@google.com,fmalita@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/923753002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
fa3a83d0fe53907e618346d3f1c17a95da1a9d22 |
|
12-Feb-2015 |
robertphillips <robertphillips@google.com> |
Remove SkPictureFlat.h include from SkDrawCommands.h This cannot land until https://codereview.chromium.org/909353004/ (Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes) lands in Chromium Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976 Review URL: https://codereview.chromium.org/912403004
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
2e6024248f81329779a6915c0312f99151d998fd |
|
11-Feb-2015 |
robertphillips <robertphillips@google.com> |
Revert of Remove SkPictureFlat.h include from SkDrawCommands.h (patchset #2 id:20001 of https://codereview.chromium.org/912403004/) Reason for revert: Chrome Original issue's description: > Remove SkPictureFlat.h include from SkDrawCommands.h > > Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976 TBR=reed@google.com,fmalita@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/917933002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
5a4c233a3657d12d836de388b41e30405b4ab976 |
|
11-Feb-2015 |
robertphillips <robertphillips@google.com> |
Remove SkPictureFlat.h include from SkDrawCommands.h Review URL: https://codereview.chromium.org/912403004
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
465206af184f58e8097e7f4f414b791232627c31 |
|
02-Feb-2015 |
rmistry <rmistry@google.com> |
Add missing SK_OVERRIDE Tested by running on clang head + ubuntu 14.04: GYP_DEFINES=”skia_gpu=0 skia_warnings_as_errors=1" tools/xsan_build thread dm BUILDTYPE=Release out/Release/dm -v BUG=skia:3386 Review URL: https://codereview.chromium.org/894833002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
26a00de4f303fe74527f00b777a871843ae4437e |
|
14-Jan-2015 |
kkinnunen <kkinnunen@nvidia.com> |
Remove incremental draw optimization from SkDebugCanvas The SkDebugCanvas can be (or is currently) being used to draw to multiple different canvases. If this use-case is intended, then storing draw -related state in the canvas causes bugs. Remove incremental draw from SkDebugCanvas. It can only optimize the case where draw command index is advanced, no other changes are done and no visualization is used. This case is not that critical, as it happens only once per new frame at most. It causes bugs, because one SkDebugCanvas is used to draw to multiple canvases. Leave the draw to canvas in same state as it was passed in. This fixes the debugger bugs where: * Old, stale image would stay on the raster canvas when a new image is loaded. Also happened with resizes. * Proper image for overdraw filter would be visible only for the first frame Review URL: https://codereview.chromium.org/844493003
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
72c9faab45124e08c85f70ca38536914862d947c |
|
09-Jan-2015 |
mtklein <mtklein@chromium.org> |
Fix up all the easy virtual ... SK_OVERRIDE cases. This fixes every case where virtual and SK_OVERRIDE were on the same line, which should be the bulk of cases. We'll have to manually clean up the rest over time unless I level up in regexes. for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end BUG=skia: Review URL: https://codereview.chromium.org/806653007
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
26e5400de4db969d32356a0b703261c1c98735f6 |
|
05-Jan-2015 |
kkinnunen <kkinnunen@nvidia.com> |
Remove draw window size state from SkDebugCanvas The SkDebugCanvas can be (or is currently) being used to draw to multiple different canvases. If this use-case is intended, then storing draw -related state in the canvas causes bugs. Remove draw window size state form SkDebugCanvas. Instead, use the canvas base layer size as the window size to clip to. This is consistent with the current use in debugger. This is part of work trying to remove bugs in debugger that result from replaying one SkDrawCanvas to two different canvases. Currently the SkDrawCanvas stores state that can only be valid if it is used for one canvas. Review URL: https://codereview.chromium.org/835113002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
41af966ab338e95eee81ab618ab28195075338f7 |
|
05-Jan-2015 |
reed <reed@google.com> |
Revert of Revert of move remaining virtual draw methods to onDraw (patchset #1 id:1 of https://codereview.chromium.org/835913002/) Reason for revert: test to see if it wasn't this CL that broke chromeos Original issue's description: > Revert of move remaining virtual draw methods to onDraw (patchset #5 id:80001 of https://codereview.chromium.org/817723005/) > > Reason for revert: > did this cause chromeos heap corruption on skp? > > Original issue's description: > > move remaining virtual draw methods to onDraw > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/2e0f7d53bba5438c9bf11ee5ccae2c301e348419 > > TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/e87e383351e1547b21d96d02bcd0c3cbbe0837f1 TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com,reed@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/831253002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
e87e383351e1547b21d96d02bcd0c3cbbe0837f1 |
|
05-Jan-2015 |
reed <reed@chromium.org> |
Revert of move remaining virtual draw methods to onDraw (patchset #5 id:80001 of https://codereview.chromium.org/817723005/) Reason for revert: did this cause chromeos heap corruption on skp? Original issue's description: > move remaining virtual draw methods to onDraw > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/2e0f7d53bba5438c9bf11ee5ccae2c301e348419 TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/835913002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
2e0f7d53bba5438c9bf11ee5ccae2c301e348419 |
|
05-Jan-2015 |
reed <reed@chromium.org> |
move remaining virtual draw methods to onDraw BUG=skia: Review URL: https://codereview.chromium.org/817723005
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
c4fda92f45b9649f233a5b8636618a6431aa59cb |
|
02-Jan-2015 |
reed <reed@chromium.org> |
remove unused drawData BUG=skia: Review URL: https://codereview.chromium.org/830083002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
5037e9de94e57d36592cc596d831cc2b5ec45bd3 |
|
30-Dec-2014 |
kkinnunen <kkinnunen@nvidia.com> |
Change DebugCanvas API to not encourage memory leaks Pass command strings and offset arrays as out parameters instead of returning new arrays from the functions. This simplifies debugger leak investigations, as the app leaks less by design. Review URL: https://codereview.chromium.org/821663003
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
f0f14113431ace669f278fdd97b50950f2cf4c80 |
|
12-Dec-2014 |
mtklein <mtklein@chromium.org> |
Cull pushCull and popCull from Skia. These calls are unused and going away. Waiting on crrev.com/796083002. BUG=skia: Review URL: https://codereview.chromium.org/794263002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
c54d8db4d169ea5f2af2a9a2349df007bd428475 |
|
10-Dec-2014 |
Florin Malita <fmalita@google.com> |
Remove SkCanvas::drawBitmapMatrix() R=mtklein@google.com, reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/789033002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
8eddfb50c0c9e4bcba6384a2ce39852b5fb5becb |
|
04-Dec-2014 |
reed <reed@google.com> |
Change clear() to respect the clip This reverts commit af641a1c10f176cb9617026d3cc93c117a85d13d. BUG=skia: TBR= Review URL: https://codereview.chromium.org/783493002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
af641a1c10f176cb9617026d3cc93c117a85d13d |
|
03-Dec-2014 |
reed <reed@chromium.org> |
Revert "Change clear() to respect the clip" This reverts commit 3729469d6a12266037b697c2192768545e097ab0. BUG=skia: TBR= Review URL: https://codereview.chromium.org/778563002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
3729469d6a12266037b697c2192768545e097ab0 |
|
02-Dec-2014 |
reed <reed@google.com> |
Change clear() to respect the clip patch from issue 769703002 at patchset 1 (http://crrev.com/769703002#ps1) BUG=skia: Review URL: https://codereview.chromium.org/772533004
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
b07a94f1cba3976596ae1a7f23d8c2043ba353f3 |
|
19-Nov-2014 |
reed <reed@chromium.org> |
add roundOut that returns its result BUG=skia: Review URL: https://codereview.chromium.org/742663002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
8c89c528f31dff25bce74aabe28abe23a772cb1e |
|
09-Nov-2014 |
fmalita <fmalita@chromium.org> |
Revert of Revert of SkDrawCommand scrubbing (patchset #1 id:1 of https://codereview.chromium.org/712683002/) Reason for revert: Chromium clients updated, this should be canary-proof now. Original issue's description: > Revert of SkDrawCommand scrubbing (patchset #2 id:20001 of https://codereview.chromium.org/706363002/) > > Reason for revert: > Canary borkage. > > Original issue's description: > > SkDrawCommand scrubbing > > > > Remove unused ctor, constify, etc. > > > > R=robertphillips@google.com > > > > Committed: https://skia.googlesource.com/skia/+/1931ec5b5dac68f1e452af0c65161bdce35b2dec > > TBR=robertphillips@google.com > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/9063ddd511f8e0d8c7454950cbc56e273678bf60 TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/708333002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
9063ddd511f8e0d8c7454950cbc56e273678bf60 |
|
07-Nov-2014 |
fmalita <fmalita@chromium.org> |
Revert of SkDrawCommand scrubbing (patchset #2 id:20001 of https://codereview.chromium.org/706363002/) Reason for revert: Canary borkage. Original issue's description: > SkDrawCommand scrubbing > > Remove unused ctor, constify, etc. > > R=robertphillips@google.com > > Committed: https://skia.googlesource.com/skia/+/1931ec5b5dac68f1e452af0c65161bdce35b2dec TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/712683002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
1931ec5b5dac68f1e452af0c65161bdce35b2dec |
|
07-Nov-2014 |
fmalita <fmalita@chromium.org> |
SkDrawCommand scrubbing Remove unused ctor, constify, etc. R=robertphillips@google.com Review URL: https://codereview.chromium.org/706363002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
b9750892ddfc84c3976fc5d4c9297c6940889767 |
|
21-Oct-2014 |
robertphillips <robertphillips@google.com> |
Fix debugger's SaveAs functionality Without this patch the SaveAs functionality only copies the portion of the picture from the current command in the GUI. Review URL: https://codereview.chromium.org/672453002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
70171683e6977af7472f0f465bd81852d0644ddd |
|
16-Oct-2014 |
robertphillips <robertphillips@google.com> |
"Fix" debugger's setMatrix handling This remedies two problems with the debugger's matrix handling: 1) the user matrix was not being passed to the setMatrix command (for a concat) 2) the setting of the user matrix was not consistently forcing a complete re-rendering of the scene BUG=skia:3018 Review URL: https://codereview.chromium.org/660883002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
a8d7f0b13cd4c6d773fcf055fe17db75d260fa05 |
|
29-Aug-2014 |
robertphillips <robertphillips@google.com> |
Try out scalar picture sizes This paves the way for removing the 'fTile' parameter from SkPictureShader (although that should be a different CL). If we like this we could also move to providing an entire cull SkRect. R=reed@google.com, mtklein@google.com, fmalita@google.com, fmalita@chromium.org Author: robertphillips@google.com Review URL: https://codereview.chromium.org/513983002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
b7425173f96e93b090787e2386ba5f022b6c2869 |
|
26-Aug-2014 |
fmalita <fmalita@chromium.org> |
SkTextBlob plumbing Add SkTextBlob serialization + drawTextBlob() overrides. R=mtklein@google.com, reed@google.com, robertphillips@google.com BUG=269080 Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/499413002
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
b3f319fbb01c74e757846d9fcfbf1da174c0cb17 |
|
13-Aug-2014 |
robertphillips <robertphillips@google.com> |
Add support for new drawPicture entry point to debugger R=fmalita@google.com, fmalita@chromium.org Author: robertphillips@google.com Review URL: https://codereview.chromium.org/464063003
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
d5fa1a455aad61f3e99081fe7a9b065cb3b115c6 |
|
09-Aug-2014 |
reed <reed@google.com> |
add drawPicture variant that takes a matrix and paint will need some staging strategy, since chrome and blink have overrides of onDrawPicture R=robertphillips@google.com, fmalita@google.com, bsalomon@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/448793004
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
5f6102d07982043542343ff0a6c67b1319ac9fc7 |
|
30-Jun-2014 |
Florin Malita <fmalita@chromium.org> |
SaveFlags be-gone Remove the deprecated save(SaveFlags), willSave(SaveFlags) and all traces of kMatrix_SaveFlags/kClip_SaveFlag. BUG=skia:2297 R=mtklein@google.com, reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/340403003
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
9b14f26d0f3a974f3dd626c8354e1db1cfcd322f |
|
04-Jun-2014 |
robertphillips <robertphillips@google.com> |
Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) R=reed@google.com, bsalomon@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/313613004
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
2a67e123a3e559774a16a58cbe5106bc0fb86740 |
|
19-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
This adds a checkbox to the debugger to allow seeing the effect pathops has on the clip. A new tab shows the C code that the pathops generate. Once in place, this CL found a bug in the pathops code where it was not handling empty clip stack elements correctly. The Cl also has the change to SkCanvas to fix this bug. R=robertphillips@google.com, reed@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/282283002 git-svn-id: http://skia.googlecode.com/svn/trunk@14774 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
2e74f9d375d2c5d0a3eb4acc7cecd35afa6bf4ae |
|
01-May-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove code behind SK_SUPPORT_LEGACY_PROCXFERMODE BUG=skia: R=scroggo@google.com Review URL: https://codereview.chromium.org/264923004 git-svn-id: http://skia.googlecode.com/svn/trunk@14504 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
e0d9ce890e67d02727ac2811bb456ddb64f827d4 |
|
23-Apr-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make drawText calls non-virtual, to ease SkFont and TextBlob (https://codereview.chromium.org/243853006/)" associated chrome change (to be committed with DEPS roll) https://codereview.chromium.org/248693002/ This reverts commit bfaceb53f58c9625b5471fcff35b5ca9ca3ae29c. TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/248083002 git-svn-id: http://skia.googlecode.com/svn/trunk@14321 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
945ec3a2bec668ca845071a65df8ec55e8f43819 |
|
22-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of make drawText calls non-virtual, to ease SkFont and TextBlob (https://codereview.chromium.org/243853006/) Reason for revert: need to test more the code-path where we don't opt into the new virtuals Original issue's description: > make drawText calls non-virtual, to ease SkFont and TextBlob > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14307 R=robertphillips@google.com TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/247983003 git-svn-id: http://skia.googlecode.com/svn/trunk@14314 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
4325d114a5679e46f25ae75b0e43547fd7694998 |
|
22-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
make drawText calls non-virtual, to ease SkFont and TextBlob BUG=skia: R=robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/243853006 git-svn-id: http://skia.googlecode.com/svn/trunk@14307 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
60bd7519a9db4ddddd95e490f93165e5676f90f5 |
|
18-Apr-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@14252 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
cc277b729b16c0d8d042f9ae1db6563fb4538d88 |
|
17-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Orphan ProcXfermode, with an eye towards removing it BUG=skia: R=scroggo@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/240533003 git-svn-id: http://skia.googlecode.com/svn/trunk@14238 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
57f74e0aa931e7784d47cba3ecc83020aa8e72b2 |
|
26-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Debugger improvements This CL: improves the 'SaveAs' functionality allows switching between # and offset indexing in the command list minor nit cleanup R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/211383003 git-svn-id: http://skia.googlecode.com/svn/trunk@13950 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
d9ea09e1f29b303e6fa36079e99729d2951925b9 |
|
25-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Consolidate SkCanvas matrix virtuals. Remove didTranslate, didScale, didRotate & didSkew, and rely on didConcat instead. Subclasses can sniff the matrix type if they want to differentiate. (work in progress) R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/203203004 git-svn-id: http://skia.googlecode.com/svn/trunk@13940 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
44c48d062f7996b5b46917e1b312a32ad101f326 |
|
13-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
De-virtualize SkCanvas matrix ops. This moves the matrix management logic into non-virtual SkCanvas methods, and turns the virtuals into protected notifiers. R=reed@google.com, robertphillips@google.com, bsalomon@google.com BUG=skia:2297 Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/195793012 git-svn-id: http://skia.googlecode.com/svn/trunk@13799 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
e54a23fcfa42b2fc9d320650de72bcb2d9566b2d |
|
12-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
De-virtualize SkCanvas save/restore. This moves the state management logic into non-virtual SkCanvas methods, and turns the virtuals into protected notifiers. R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/194713008 git-svn-id: http://skia.googlecode.com/svn/trunk@13776 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
069a55a7fe2c3ae6f5049843b3fc1a167b51215c |
|
12-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/196323003/) Reason for revert: Pulling out to rename the virtuals. Original issue's description: > Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/194923008/) > > Reason for revert: > Re-landing after roll fix. > > Original issue's description: > > Revert "De-virtualize SkCanvas save/restore." > > > > (To allow a roll fix into the tree). > > > > This reverts commit edf702204be42c945254191f9f9cd6585b3d189b. > > > > R=halcanary@google.com > > > > Committed: https://code.google.com/p/skia/source/detail?r=13748 > > TBR=halcanary@google.com,fmalita@chromium.org > NOTREECHECKS=true > NOTRY=true > > Committed: http://code.google.com/p/skia/source/detail?r=13754 R=halcanary@google.com, fmalita@chromium.org TBR=fmalita@chromium.org, halcanary@google.com NOTREECHECKS=true NOTRY=true Author: fmalita@google.com Review URL: https://codereview.chromium.org/197553002 git-svn-id: http://skia.googlecode.com/svn/trunk@13765 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
4fcd92d0bf09dc9c28643e83b95b6cbf9f1ff2b2 |
|
12-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/194923008/) Reason for revert: Re-landing after roll fix. Original issue's description: > Revert "De-virtualize SkCanvas save/restore." > > (To allow a roll fix into the tree). > > This reverts commit edf702204be42c945254191f9f9cd6585b3d189b. > > R=halcanary@google.com > > Committed: https://code.google.com/p/skia/source/detail?r=13748 R=halcanary@google.com, fmalita@chromium.org TBR=fmalita@chromium.org, halcanary@google.com NOTREECHECKS=true NOTRY=true Author: fmalita@google.com Review URL: https://codereview.chromium.org/196323003 git-svn-id: http://skia.googlecode.com/svn/trunk@13754 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
f1292bc01fa3a2e398454b0cf03d36b23b6912f7 |
|
11-Mar-2014 |
fmalita@google.com <fmalita@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "De-virtualize SkCanvas save/restore." (To allow a roll fix into the tree). This reverts commit edf702204be42c945254191f9f9cd6585b3d189b. R=halcanary@google.com Review URL: https://codereview.chromium.org/194923008 git-svn-id: http://skia.googlecode.com/svn/trunk@13748 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
80b10518a27a47b25a7dbf3591b425a741ebf406 |
|
11-Mar-2014 |
fmalita@google.com <fmalita@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
De-virtualize SkCanvas save/restore. This moves the state management logic into non-virtual SkCanvas methods, and turns the virtuals into protected notifiers. R=robertphillips@google.com, reed@google.com Review URL: https://codereview.chromium.org/194713008 git-svn-id: http://skia.googlecode.com/svn/trunk@13747 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
5c70cdca5efe541b70d010e91607bf8626ea49ca |
|
08-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
hide getTotalClip, so we can eventually remove it hide getClipType, so we can eventually remove it patch from issue 189443007 TBR=robertphilips@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/189883010 git-svn-id: http://skia.googlecode.com/svn/trunk@13715 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
1643b2c9bc5adb4324bb459bb7811f58bc7c2d62 |
|
04-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
This adds cull rect visualization to the debugger's "mega" visualization mode. R=fmalita@google.com, fmalita@chromium.org Author: robertphillips@google.com Review URL: https://codereview.chromium.org/177423013 git-svn-id: http://skia.googlecode.com/svn/trunk@13649 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
768ac85655017d4106444bf3ad044680a575ccaa |
|
03-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
The new "mega" viz mode both adds visualization and forces all drawing to the visible canvas (by replacing the active saveLayers with saves). R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/185293007 git-svn-id: http://skia.googlecode.com/svn/trunk@13640 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
8f90a892c5130d4d26b5588e1ff151d01a40688a |
|
28-Feb-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add new onClip* methods to SkCanvas https://codereview.chromium.org/183453002/ git-svn-id: http://skia.googlecode.com/svn/trunk@13627 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
03fc3b4f67a115e4a7945d173856a6c80b09311e |
|
28-Feb-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of r13620 (add new onClip* methods to SkCanvas - https://codereview.chromium.org/183453002/) due to broken Chrome Canary and failing tests. git-svn-id: http://skia.googlecode.com/svn/trunk@13622 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
392c9be344549e809d0468abafdbeb6e32135bcd |
|
28-Feb-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add new onClip* methods to SkCanvas https://codereview.chromium.org/183453002/ git-svn-id: http://skia.googlecode.com/svn/trunk@13620 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
210ae2a42613b9048e8e8c4096c5bf4fe2ddf838 |
|
27-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Culling API *** SKP format breaking change *** Adding a couple of culling primitives: pushCull(SkRect) & popCull(). These are currently only plumbed for SKP playback quickreject. At record time, we perform a couple of optimizations to trim down the number of redundant culls: * collapse empty pushCull/popCull pairs * skip pushCull/popCull pairs nested within an identical cull rect Things still missing/to consider: * use an inlineable, simplified quickreject (Mike's old prototype) * debugger visualization for cull boxes * BBH integration: the initial prototype had some minimal BBH support, but since the optimizations required expensive rewinds and culling is expected to be a BBH alternative, it got dropped. R=bsalomon@google.com, reed@google.com, robertphillips@google.com, caryclark@google.com, tomhudson@google.com, iancottrell@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/138013009 git-svn-id: http://skia.googlecode.com/svn/trunk@13611 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
3d305207bd40f4e5ae10010492420a2fdfa1153c |
|
24-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add DRRect to debugger R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/177683003 git-svn-id: http://skia.googlecode.com/svn/trunk@13565 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
ab5827354e2c23624acc3fc1fe4a83788bc99e96 |
|
21-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
override new virtual onDrawDRRect in util canvas subclasses BUG=skia: R=robertphillips@google.com, reed@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/174593003 git-svn-id: http://skia.googlecode.com/svn/trunk@13529 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
0a2bf90dccba3bde188e0386a7f0c60e6dde1ae9 |
|
20-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Factory methods for heap-allocated SkPathEffect and SkXfermode objects. This is part of an effort to ensure that all SkPaint effects can only be allocated on the heap. This patch makes the constructors of SkPathEffect, SkXfermode and their subclasses non-public and instead provides factory methods for creating these objects on the heap. We temporarily keep the constructors of the following classes public to not break Chrome/Blink: SkXfermode SkCornerPathEffect SkDashPathEffect BUG=skia:2187 R=scroggo@google.com, reed@google.com, mtklein@google.com, bungeman@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/166583002 git-svn-id: http://skia.googlecode.com/svn/trunk@13519 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
e254310a55d55a710309714c48f7fbbe7a6126f7 |
|
31-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SkCanvas constructor that explicitly creates no_config with dimensions BUG=skia: R=scroggo@google.com, halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/137833016 git-svn-id: http://skia.googlecode.com/svn/trunk@13272 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
9ebcac54635cde63110d73ad7c43d70772e7872f |
|
24-Jan-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add installPixels BUG=skia: R=halcanary@google.com Review URL: https://codereview.chromium.org/143073008 git-svn-id: http://skia.googlecode.com/svn/trunk@13174 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
1735d6696e9a941925e6ca352849307d698ef139 |
|
04-Dec-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix incremental visibility filter handling. When drawing incrementally, SkDebugCanvas can end up applying the visibility overlay multiple times (resulting in a fade-to-white effect). The CL also includes a minor/unrelated SkDebugCanvas cleanup. R=robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/103083004 git-svn-id: http://skia.googlecode.com/svn/trunk@12478 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
6c1e49af8de1f6dfdc5fb09cd0edfc2e469e945f |
|
10-Nov-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Removed deprecated API calls that have crept in git-svn-id: http://skia.googlecode.com/svn/trunk@12210 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
8b15717bb02c9101e8c621affd41a2e5c2cc8636 |
|
07-Nov-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
"Fix" bug in debug canvas https://codereview.chromium.org/59073008/ git-svn-id: http://skia.googlecode.com/svn/trunk@12180 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
7ce564cccb246ec56427085872b2e1458fe74bd1 |
|
22-Oct-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance." This reverts commit r11904 Review URL: https://codereview.chromium.org/35543002 git-svn-id: http://skia.googlecode.com/svn/trunk@11909 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
ad254fee73ad70a45acba69dccb9b65f88c3a92a |
|
22-Oct-2013 |
bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance. Committed: http://code.google.com/p/skia/source/detail?r=11842 R=bsalomon@google.com Review URL: https://codereview.chromium.org/23484007 git-svn-id: http://skia.googlecode.com/svn/trunk@11904 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
f84ad8f7fc0194389a8099da2c5e8fff9f092890 |
|
18-Oct-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@11850 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
32bbcf828d66ad244fa25b468bc3a229e531491f |
|
17-Oct-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add texture filtering override to debugger https://codereview.chromium.org/27716003/ git-svn-id: http://skia.googlecode.com/svn/trunk@11846 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
c2cc1dbe818c8a5a699fbe18c4fc79b9d93daa94 |
|
17-Oct-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert r11842 (call drawRect to try GrAARectRenderer if the path is a rect - https://codereview.chromium.org/23484007) due to changes to the following GM images: inverse_paths pathopsinverse git-svn-id: http://skia.googlecode.com/svn/trunk@11845 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
521a46750d87d3d206617d05d917ad6aad242ca4 |
|
17-Oct-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance. R=bsalomon@google.com, robertphillips@google.com, reed@google.com Author: yunchao.he@intel.com Review URL: https://codereview.chromium.org/23484007 git-svn-id: http://skia.googlecode.com/svn/trunk@11842 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
7475811143e190e172bf83d13c4bdba85704b604 |
|
17-Aug-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@10790 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
eed779d866e1e239bfb9ebc6a225b7345a41adf9 |
|
16-Aug-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
This CL plumbs in the drawBitmapRectToRect "bleed" flag and makes it live on the simplest GPU path. R=bsalomon@google.com, reed@google.com, edisonn@google.com, scroggo@google.com, jvanverth@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://chromiumcodereview.appspot.com/20806003 git-svn-id: http://skia.googlecode.com/svn/trunk@10765 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
a27622c18de99fdb2c68e23b01006d3aa2bd1699 |
|
05-Aug-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix OverdrawFilter not set on first call to SkDebugCanvas::drawTo() R=robertphillips@google.com Author: egraether@chromium.org Review URL: https://chromiumcodereview.appspot.com/21789005 git-svn-id: http://skia.googlecode.com/svn/trunk@10535 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
56a57aeb3c0d71faf72a05c19787c403e76fa474 |
|
21-Jun-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
SkDebugCanvas: remove unused <iostream> include. No only this is unused, but it's pulling in a static initializer (which makes SkDebugCanvas unusable in Chromium). BUG= R=robertphillips@google.com, bungeman@google.com Author: fmalita@chromium.org Review URL: https://chromiumcodereview.appspot.com/17553006 git-svn-id: http://skia.googlecode.com/svn/trunk@9723 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
7a11591e5e09493f1589c93d53fd1fe10086920a |
|
18-Jun-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Rename SkDrawCommand subclasses SkDrawCommand subclass names are too generic and likely to clash in the default namespace. This makes the header unusable in Chrome - for example, on Mac builders: ../../third_party/skia/src/utils/debugger/SkDrawCommand.h:251:7: error: redefinition of 'Comment' class Comment : public SkDrawCommand { ^ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/AIFF.h:192:8: note: previous definition is here struct Comment { This CL renames SkDrawCommand subclasses using the following pattern: "${cmd}" -> "Sk${cmd}Command". R=robertphillips@google.com, bungeman@google.com, djsollen@google.com Author: fmalita@chromium.org Review URL: https://chromiumcodereview.appspot.com/17101005 git-svn-id: http://skia.googlecode.com/svn/trunk@9667 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|
86681b37bd20204e47a492119b345c01d00bc939 |
|
13-Jun-2013 |
fmalita@google.com <fmalita@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Expose debugger backend classes externally. SkDebugCanvas & friends are useful beyond the Qt debugger app - Chromium's picture inspector (in development) is at the point where it could take advantage of it. This patch moves SkDrawCommand, SkDebugCanvas & SkObjectParser from trunk/debugger to trunk/src/utils (since several tools already use these, this seems appropriate), and makes SkDrawCommand & SkDebugCanvas' symbols visible externally (SK_API). R=reed@google.com Review URL: https://codereview.chromium.org/16638014 git-svn-id: http://skia.googlecode.com/svn/trunk@9598 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/debugger/SkDebugCanvas.cpp
|